LegacyGuzzleReaderFactory::__construct() - Code Metrics - Inspection of "Refactor teleporters" - alchemy-fr/Zippy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#104)

by Thibaud

created 2016-03-19 13:21 UTC

LegacyGuzzleReaderFactory::__construct() A

↳ Parent: LegacyGuzzleReaderFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
rs	9.4285
cc	2
eloc	8
nc	2
nop	1

<?php

namespace Alchemy\Zippy\Resource\Reader\Guzzle;

use Alchemy\Zippy\Resource\Resource;
use Alchemy\Zippy\Resource\ResourceReader;
use Alchemy\Zippy\Resource\ResourceReaderFactory;
use Guzzle\Http\Client;
use Guzzle\Http\ClientInterface;
use Guzzle\Plugin\Backoff\BackoffPlugin;
use Symfony\Component\EventDispatcher\Event;

class LegacyGuzzleReaderFactory implements ResourceReaderFactory
{
    /**
     * @var ClientInterface|null
     */
    private $client = null;

    public function __construct(ClientInterface $client = null)
    {
        $this->client = $client;

        if (! $this->client) {
            $this->client = new Client();

            $this->client->getEventDispatcher()->addListener('request.error', function (Event $event) {
                // override guzzle default behavior of throwing exceptions
                // when 4xx & 5xx responses are encountered
                $event->stopPropagation();
            }, -254);

            $this->client->addSubscriber(BackoffPlugin::getExponentialBackoff(5, array(500, 502, 503, 408)));
        }
    }

    /**
     * @param \Alchemy\Zippy\Resource\Resource $resource
     * @param string $context
     * @return ResourceReader
     */
    public function getReader(Resource $resource, $context)
    {
        return new LegacyGuzzleReader($resource, $this->client);
    }
}


1			<?php
2
3			namespace Alchemy\Zippy\Resource\Reader\Guzzle;
4
5			use Alchemy\Zippy\Resource\Resource;
6			use Alchemy\Zippy\Resource\ResourceReader;
7			use Alchemy\Zippy\Resource\ResourceReaderFactory;
8			use Guzzle\Http\Client;
9			use Guzzle\Http\ClientInterface;
10			use Guzzle\Plugin\Backoff\BackoffPlugin;
11			use Symfony\Component\EventDispatcher\Event;
12
13			class LegacyGuzzleReaderFactory implements ResourceReaderFactory
14			{
15			/**
16			* @var ClientInterface\|null
17			*/
18			private $client = null;
19
20			public function __construct(ClientInterface $client = null)
21			{
22			$this->client = $client;
23
24			if (! $this->client) {
25			$this->client = new Client();
26
27			$this->client->getEventDispatcher()->addListener('request.error', function (Event $event) {
28			// override guzzle default behavior of throwing exceptions
29			// when 4xx & 5xx responses are encountered
30			$event->stopPropagation();
31			}, -254);
32
33			$this->client->addSubscriber(BackoffPlugin::getExponentialBackoff(5, array(500, 502, 503, 408)));
34			}
35			}
36
37			/**
38			* @param \Alchemy\Zippy\Resource\Resource $resource
39			* @param string $context
40			* @return ResourceReader
41			*/
42			public function getReader(Resource $resource, $context)
43			{
44			return new LegacyGuzzleReader($resource, $this->client);
45			}
46			}
47

alchemy-fr / Zippy

Pull Request — master (#104)

LegacyGuzzleReaderFactory::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like