Complex classes like User often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use User, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class User |
||
| 18 | { |
||
| 19 | |||
| 20 | public static function fromList(array $values) |
||
| 30 | |||
| 31 | 5 | public static function fromValue(\stdClass $value) |
|
| 35 | |||
| 36 | /** |
||
| 37 | * @var \stdClass |
||
| 38 | */ |
||
| 39 | protected $source; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * @ApiField(bind_to="updated_on", type="date") |
||
| 43 | */ |
||
| 44 | protected $updatedOn; |
||
| 45 | |||
| 46 | /** |
||
| 47 | * @ApiField(bind_to="created_on", type="date") |
||
| 48 | */ |
||
| 49 | protected $createdOn; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * @ApiField(bind_to="last_connection", type="date") |
||
| 53 | */ |
||
| 54 | protected $lastConnection; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @var array |
||
| 58 | */ |
||
| 59 | protected $collectionRights = array(); |
||
| 60 | |||
| 61 | /** |
||
| 62 | * @var bool |
||
| 63 | */ |
||
| 64 | protected $hasCollectionRights = false; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @var array |
||
| 68 | */ |
||
| 69 | protected $collectionDemands = array(); |
||
| 70 | |||
| 71 | /** |
||
| 72 | * @var bool |
||
| 73 | */ |
||
| 74 | protected $hasCollectionDemands = false; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * @param \stdClass $source |
||
| 78 | */ |
||
| 79 | 5 | public function __construct(\stdClass $source) |
|
| 83 | |||
| 84 | /** |
||
| 85 | * @return \stdClass |
||
| 86 | */ |
||
| 87 | public function getRawData() |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function getAddress() |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @param string $address |
||
| 102 | */ |
||
| 103 | public function setAddress($address) |
||
| 107 | |||
| 108 | /** |
||
| 109 | * @return string |
||
| 110 | */ |
||
| 111 | public function getCity() |
||
| 115 | |||
| 116 | /** |
||
| 117 | * @param string $city |
||
| 118 | */ |
||
| 119 | public function setCity($city) |
||
| 123 | |||
| 124 | /** |
||
| 125 | * @return string |
||
| 126 | */ |
||
| 127 | public function getCompany() |
||
| 131 | |||
| 132 | /** |
||
| 133 | * @param string $company |
||
| 134 | */ |
||
| 135 | public function setCompany($company) |
||
| 139 | |||
| 140 | /** |
||
| 141 | * @return string |
||
| 142 | */ |
||
| 143 | public function getCountry() |
||
| 147 | |||
| 148 | /** |
||
| 149 | * @param string $country |
||
| 150 | */ |
||
| 151 | public function setCountry($country) |
||
| 155 | |||
| 156 | /** |
||
| 157 | * @return \DateTime |
||
| 158 | */ |
||
| 159 | public function getCreatedOn() |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @param \DateTime $createdOn |
||
| 166 | */ |
||
| 167 | public function setCreatedOn($createdOn) |
||
| 171 | |||
| 172 | /** |
||
| 173 | * @return string |
||
| 174 | */ |
||
| 175 | public function getDisplayName() |
||
| 179 | |||
| 180 | /** |
||
| 181 | * @param string $displayName |
||
| 182 | */ |
||
| 183 | 5 | public function setDisplayName($displayName) |
|
| 187 | |||
| 188 | /** |
||
| 189 | * @return string |
||
| 190 | */ |
||
| 191 | public function getEmail() |
||
| 195 | |||
| 196 | /** |
||
| 197 | * @param string $email |
||
| 198 | */ |
||
| 199 | public function setEmail($email) |
||
| 203 | |||
| 204 | /** |
||
| 205 | * @return string |
||
| 206 | */ |
||
| 207 | public function getFax() |
||
| 211 | |||
| 212 | /** |
||
| 213 | * @param string $fax |
||
| 214 | */ |
||
| 215 | public function setFax($fax) |
||
| 219 | |||
| 220 | /** |
||
| 221 | * @return string |
||
| 222 | */ |
||
| 223 | public function getFirstName() |
||
| 227 | |||
| 228 | /** |
||
| 229 | * @param string $firstName |
||
| 230 | */ |
||
| 231 | public function setFirstName($firstName) |
||
| 235 | |||
| 236 | /** |
||
| 237 | * @return string |
||
| 238 | */ |
||
| 239 | public function getGender() |
||
| 243 | |||
| 244 | /** |
||
| 245 | * @param string $gender |
||
| 246 | */ |
||
| 247 | public function setGender($gender) |
||
| 251 | |||
| 252 | /** |
||
| 253 | * @return string |
||
| 254 | */ |
||
| 255 | public function getGeonameId() |
||
| 259 | |||
| 260 | /** |
||
| 261 | * @param string $geonameId |
||
| 262 | */ |
||
| 263 | public function setGeonameId($geonameId) |
||
| 267 | |||
| 268 | /** |
||
| 269 | * @return int |
||
| 270 | */ |
||
| 271 | public function getId() |
||
| 275 | |||
| 276 | /** |
||
| 277 | * @param int $id |
||
| 278 | */ |
||
| 279 | public function setId($id) |
||
| 283 | |||
| 284 | /** |
||
| 285 | * @return string |
||
| 286 | */ |
||
| 287 | public function getJob() |
||
| 291 | |||
| 292 | /** |
||
| 293 | * @param string $job |
||
| 294 | */ |
||
| 295 | public function setJob($job) |
||
| 299 | |||
| 300 | /** |
||
| 301 | * @return \DateTime |
||
| 302 | */ |
||
| 303 | public function getLastConnection() |
||
| 307 | |||
| 308 | /** |
||
| 309 | * @param \DateTime $lastConnection |
||
| 310 | */ |
||
| 311 | public function setLastConnection($lastConnection) |
||
| 315 | |||
| 316 | /** |
||
| 317 | * @return string |
||
| 318 | */ |
||
| 319 | public function getLastName() |
||
| 323 | |||
| 324 | /** |
||
| 325 | * @param string $lastName |
||
| 326 | */ |
||
| 327 | public function setLastName($lastName) |
||
| 331 | |||
| 332 | /** |
||
| 333 | * @return string |
||
| 334 | */ |
||
| 335 | public function getLocale() |
||
| 339 | |||
| 340 | /** |
||
| 341 | * @param string $locale |
||
| 342 | */ |
||
| 343 | 5 | public function setLocale($locale) |
|
| 347 | |||
| 348 | /** |
||
| 349 | * @return string |
||
| 350 | */ |
||
| 351 | public function getLogin() |
||
| 355 | |||
| 356 | /** |
||
| 357 | * @param string $login |
||
| 358 | */ |
||
| 359 | public function setLogin($login) |
||
| 363 | |||
| 364 | /** |
||
| 365 | * @return string |
||
| 366 | */ |
||
| 367 | public function getPhone() |
||
| 371 | |||
| 372 | /** |
||
| 373 | * @param string $phone |
||
| 374 | */ |
||
| 375 | public function setPhone($phone) |
||
| 379 | |||
| 380 | /** |
||
| 381 | * @return string |
||
| 382 | */ |
||
| 383 | public function getPosition() |
||
| 387 | |||
| 388 | /** |
||
| 389 | * @param string $position |
||
| 390 | */ |
||
| 391 | public function setPosition($position) |
||
| 395 | |||
| 396 | /** |
||
| 397 | * @return \DateTime |
||
| 398 | */ |
||
| 399 | public function getUpdatedOn() |
||
| 403 | |||
| 404 | /** |
||
| 405 | * @param \DateTime $updatedOn |
||
| 406 | */ |
||
| 407 | public function setUpdatedOn($updatedOn) |
||
| 411 | |||
| 412 | /** |
||
| 413 | * @return string |
||
| 414 | */ |
||
| 415 | public function getZipCode() |
||
| 419 | |||
| 420 | /** |
||
| 421 | * @param string $zipCode |
||
| 422 | */ |
||
| 423 | public function setZipCode($zipCode) |
||
| 427 | |||
| 428 | /** |
||
| 429 | * @param array $collectionRights |
||
| 430 | */ |
||
| 431 | public function setCollectionRights(array $collectionRights) |
||
| 436 | |||
| 437 | /** |
||
| 438 | * @return array |
||
| 439 | */ |
||
| 440 | public function getCollectionRights() |
||
| 444 | |||
| 445 | /** |
||
| 446 | * @return bool |
||
| 447 | */ |
||
| 448 | public function hasCollectionRights() |
||
| 452 | |||
| 453 | |||
| 454 | /** |
||
| 455 | * @param array $collectionDemands |
||
| 456 | */ |
||
| 457 | public function setCollectionDemands(array $collectionDemands) |
||
| 462 | |||
| 463 | /** |
||
| 464 | * @return array |
||
| 465 | */ |
||
| 466 | public function getCollectionDemands() |
||
| 470 | |||
| 471 | /** |
||
| 472 | * @return bool |
||
| 473 | */ |
||
| 474 | public function hasCollectionDemands() |
||
| 478 | } |
||
| 479 |