Completed
Pull Request — master (#76)
by Thibaud
02:50
created

ClientFactory::createClient()   A

Complexity

Conditions 3
Paths 3

Size

Total Lines 12
Code Lines 6

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 0
loc 12
rs 9.4285
cc 3
eloc 6
nc 3
nop 1
1
<?php
2
3
/*
4
 * This file is part of Phraseanet-PHP-SDK.
5
 *
6
 * (c) Alchemy <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace PhraseanetSDK\Http;
13
14
use GuzzleHttp\Client;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, PhraseanetSDK\Http\Client.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
15
use PhraseanetSDK\Http\Guzzle\GuzzleClient;
16
use PhraseanetSDK\Http\GuzzleHttp\GuzzleHttpClient;
17
18
class ClientFactory
19
{
20
21
    public function createClient(Endpoint $endpoint)
22
    {
23
        if (interface_exists('GuzzleHttp\ClientInterface')) {
24
            return $this->createGuzzleClient($endpoint);
25
        }
26
27
        if (interface_exists('Guzzle\Http\ClientInterface')) {
28
            return $this->createLegacyGuzzleClient($endpoint);
29
        }
30
31
        throw new \RuntimeException('No HTTP adapter is available.');
32
    }
33
34
    /**
35
     * @param Endpoint $endpoint
36
     * @return Client|\GuzzleHttp\ClientInterface
37
     */
38
    private function createGuzzleClient(Endpoint $endpoint)
39
    {
40
        return GuzzleClient::create($endpoint);
41
    }
42
43
    /**
44
     * @param $endpoint
45
     * @return \Guzzle\Http\Client|Client
46
     */
47
    private function createLegacyGuzzleClient(Endpoint $endpoint)
48
    {
49
        return GuzzleHttpClient::create($endpoint);
50
    }
51
}
52