PhraseanetSDK\Orders\OrderRepository::listOrders()

Complexity

Conditions	4
Paths	4

Size

Total Lines	28
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function listOrders($pageIndex = 0, $pageSize = 20)
    {
        // 't' param is used for cache busting
        $parameters = [
            'page' => max($pageIndex, 0),
            'per_page' => max($pageSize, 1),
            'includes' => [ 'elements' ],
            't' => time()
        ];

        $response = $this->query('GET', 'v2/orders/', $parameters);

        if ($response->isEmpty()) {
            throw new RuntimeException('Response content is empty');
        }

        if (! $response->hasProperty('data')) {
            throw new RuntimeException('Missing \'data\' property in response');
        }

        if (! $response->hasProperty('meta')) {
            throw new RuntimeException('Missing \'meta\' property in response');
        }

        $meta = $response->getProperty('meta');

        return new OrderList($response->getProperty('data'), $meta->pagination);

It seems like $response->getProperty('data') targeting PhraseanetSDK\Http\APIResponse::getProperty() can also be of type null or object<stdClass>; however, PhraseanetSDK\Orders\OrderList::__construct() does only seem to accept array, maybe add an additional type check?

    }
}