AbstractRepository - Code Metrics - Inspection of "Add support for V2 routes" - alchemy-fr/Phraseanet-PHP-SDK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#64)

by Thibaud

created 2016-02-23 08:53 UTC

AbstractRepository A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	6
dl	0
loc	64
ccs	18
cts	18
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	__construct()	5	2
A	getAdapter()	4	1
A	query()	20	4

<?php

/*
 * This file is part of Phraseanet SDK.
 *
 * (c) Alchemy <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace PhraseanetSDK;

use PhraseanetSDK\EntityManager;
use PhraseanetSDK\Exception\BadResponseException;
use PhraseanetSDK\Exception\NotFoundException;
use PhraseanetSDK\Exception\UnauthorizedException;
use PhraseanetSDK\Exception\RuntimeException;
use PhraseanetSDK\Http\APIResponse;
use PhraseanetSDK\Http\APIGuzzleAdapter;

abstract class AbstractRepository
{
    /**
     * @var EntityManager
     */
    protected $em;

    /**
     * @var APIGuzzleAdapter
     */
    private $adapter;

    /**
     * @param EntityManager $em
     * @param APIGuzzleAdapter $adapter
     */
    public function __construct(EntityManager $em, APIGuzzleAdapter $adapter = null)
    {
        $this->em = $em;
        $this->adapter = $adapter ?: $this->em->getAdapter();
    }

    /**
     * @return APIGuzzleAdapter
     */
    private function getAdapter()
    {
        return $this->adapter;
    }

    /**
     * Query the API
     *
     * @param string $method HTTP method type (POST, GET ...)
     * @param string $path The requested path (/path/to/ressource/1)
     * @param array $query An array of query parameters
     * @param array $postFields An array of request parameters
     * @param array $headers
     *
     * @return APIResponse
     * @throws NotFoundException
     * @throws UnauthorizedException
     */
    protected function query($method, $path, $query = array(), $postFields = array(), array $headers = array())
    {
        try {
            $response = $this->getAdapter()->call($method, $path, $query, $postFields, array(), $headers);
        } catch (BadResponseException $e) {
            $statusCode = $e->getStatusCode();
            switch ($statusCode) {
                case 404:
                    throw new NotFoundException(sprintf('Resource under %s could not be found', $path));
                    break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                case 401:
                    throw new UnauthorizedException(sprintf('Access to the following resource %s is forbidden', $path));
                    break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
                default:
                    throw new RuntimeException(sprintf('Something went wrong "%s"', $e->getMessage()));
            }
        }

        return $response;
    }
}


1		<?php
2
3		/*
4		* This file is part of Phraseanet SDK.
5		*
6		* (c) Alchemy <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace PhraseanetSDK;
13
14		use PhraseanetSDK\EntityManager;
15		use PhraseanetSDK\Exception\BadResponseException;
16		use PhraseanetSDK\Exception\NotFoundException;
17		use PhraseanetSDK\Exception\UnauthorizedException;
18		use PhraseanetSDK\Exception\RuntimeException;
19		use PhraseanetSDK\Http\APIResponse;
20		use PhraseanetSDK\Http\APIGuzzleAdapter;
21
22		abstract class AbstractRepository
23		{
24		/**
25		* @var EntityManager
26		*/
27		protected $em;
28
29		/**
30		* @var APIGuzzleAdapter
31		*/
32		private $adapter;
33
34		/**
35		* @param EntityManager $em
36		* @param APIGuzzleAdapter $adapter
37		*/
38	85	public function __construct(EntityManager $em, APIGuzzleAdapter $adapter = null)
39		{
40	85	$this->em = $em;
41	85	$this->adapter = $adapter ?: $this->em->getAdapter();
42	85	}
43
44		/**
45		* @return APIGuzzleAdapter
46		*/
47	68	private function getAdapter()
48		{
49	68	return $this->adapter;
50		}
51
52		/**
53		* Query the API
54		*
55		* @param string $method HTTP method type (POST, GET ...)
56		* @param string $path The requested path (/path/to/ressource/1)
57		* @param array $query An array of query parameters
58		* @param array $postFields An array of request parameters
59		* @param array $headers
60		*
61		* @return APIResponse
62		* @throws NotFoundException
63		* @throws UnauthorizedException
64		*/
65	68	protected function query($method, $path, $query = array(), $postFields = array(), array $headers = array())
66		{
67		try {
68	68	$response = $this->getAdapter()->call($method, $path, $query, $postFields, array(), $headers);
69	68	} catch (BadResponseException $e) {
70	14	$statusCode = $e->getStatusCode();
71		switch ($statusCode) {
72	14	case 404:
73	1	throw new NotFoundException(sprintf('Resource under %s could not be found', $path));
74		break;
		0 ignored issues – show Unused Code introduced 2015-12-07 17:16 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
75	13	case 401:
76	12	throw new UnauthorizedException(sprintf('Access to the following resource %s is forbidden', $path));
77		break;
		0 ignored issues – show Unused Code introduced 2015-12-07 17:16 UTC by Report Bug Copy Issue Report `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
78	1	default:
79	1	throw new RuntimeException(sprintf('Something went wrong "%s"', $e->getMessage()));
80	1	}
81		}
82
83	52	return $response;
84		}
85		}
86

alchemy-fr / Phraseanet-PHP-SDK

Pull Request — master (#64)

AbstractRepository A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like