PayplugIPNService::verifyIPNRequest() - Code Metrics - alcalyn/payplug-bundle - Measure and Improve Code Quality continuously with Scrutinizer

PayplugIPNService::verifyIPNRequest() A
last analyzed 2017-08-25 15:42 UTC

↳ Parent: PayplugIPNService

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1

<?php

namespace Alcalyn\PayplugBundle\Services;

use Symfony\Component\HttpFoundation\Request;
use Alcalyn\PayplugBundle\Model\IPN;

class PayplugIPNService
{
    /**
     * Payplug public key from configuration
     * 
     * @var string
     */
    private $payplugPublicKey;
    
    /**
     * IPN class from configuration used to create ipn instance
     * 
     * @var string
     */
    private $ipnClass;
    
    /**
     * @param string $payplugPublicKey
     */
    public function __construct($payplugPublicKey, $ipnClass)
    {
        $this->payplugPublicKey = $payplugPublicKey;
        $this->ipnClass = $ipnClass;
    }
    
    /**
     * Verify ipn request validity
     * 
     * @param Request $request
     * 
     * @return boolean
     */
    public function verifyIPNRequest(Request $request)
    {
        $signature = base64_decode($request->headers->get('payplug-signature'));
        $body = $request->getContent();
        
        return $this->verifyIPN($body, $signature);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
    
    /**
     * Verify ipn content
     * 
     * @param string $body
     * @param string $signature
     * 
     * @return boolean
     */
    public function verifyIPN($body, $signature)
    {
        $publicKey = openssl_pkey_get_public($this->payplugPublicKey);
        return 1 === openssl_verify($body, $signature, $publicKey, OPENSSL_ALGO_SHA1);
    }
    
    /**
     * Create IPN instance from body json data
     * 
     * @param string $body
     * 
     * @return IPN
     */
    public function createIPNFromBody($body)
    {
        $data = json_decode($body, true);
        
        return $this->createIPNFromData($data);
    }
    
    /**
     * Build IPN instance from array
     * 
     * @param array $data
     * 
     * @return IPN
     */
    public function createIPNFromData(array $data)
    {
        $ipn = new $this->ipnClass();
        
        return $ipn
            ->setState($data['state'])
            ->setIdTransaction($data['id_transaction'])
            ->setAmount($data['amount'])
            ->setEmail($data['email'])
            ->setFirstName($data['first_name'])
            ->setLastName($data['last_name'])
            ->setCustomer($data['customer'])
            ->setOrder($data['order'])
            ->setCustomData($data['custom_data'])
            ->setOrigin($data['origin'])
            ->setIsTest($data['is_test'])
        ;
    }
}


1			<?php
2
3			namespace Alcalyn\PayplugBundle\Services;
4
5			use Symfony\Component\HttpFoundation\Request;
6			use Alcalyn\PayplugBundle\Model\IPN;
7
8			class PayplugIPNService
9			{
10			/**
11			* Payplug public key from configuration
12			*
13			* @var string
14			*/
15			private $payplugPublicKey;
16
17			/**
18			* IPN class from configuration used to create ipn instance
19			*
20			* @var string
21			*/
22			private $ipnClass;
23
24			/**
25			* @param string $payplugPublicKey
26			*/
27			public function __construct($payplugPublicKey, $ipnClass)
28			{
29			$this->payplugPublicKey = $payplugPublicKey;
30			$this->ipnClass = $ipnClass;
31			}
32
33			/**
34			* Verify ipn request validity
35			*
36			* @param Request $request
37			*
38			* @return boolean
39			*/
40			public function verifyIPNRequest(Request $request)
41			{
42			$signature = base64_decode($request->headers->get('payplug-signature'));
43			$body = $request->getContent();
44
45			return $this->verifyIPN($body, $signature);
			0 ignored issues – show Bug introduced 2015-12-09 22:12 UTC by Report Bug Copy Issue Report It seems like `$body` defined by `$request->getContent()` on line `43` can also be of type `resource`; however, `Alcalyn\PayplugBundle\Se...IPNService::verifyIPN()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
46			}
47
48			/**
49			* Verify ipn content
50			*
51			* @param string $body
52			* @param string $signature
53			*
54			* @return boolean
55			*/
56			public function verifyIPN($body, $signature)
57			{
58			$publicKey = openssl_pkey_get_public($this->payplugPublicKey);
59			return 1 === openssl_verify($body, $signature, $publicKey, OPENSSL_ALGO_SHA1);
60			}
61
62			/**
63			* Create IPN instance from body json data
64			*
65			* @param string $body
66			*
67			* @return IPN
68			*/
69			public function createIPNFromBody($body)
70			{
71			$data = json_decode($body, true);
72
73			return $this->createIPNFromData($data);
74			}
75
76			/**
77			* Build IPN instance from array
78			*
79			* @param array $data
80			*
81			* @return IPN
82			*/
83			public function createIPNFromData(array $data)
84			{
85			$ipn = new $this->ipnClass();
86
87			return $ipn
88			->setState($data['state'])
89			->setIdTransaction($data['id_transaction'])
90			->setAmount($data['amount'])
91			->setEmail($data['email'])
92			->setFirstName($data['first_name'])
93			->setLastName($data['last_name'])
94			->setCustomer($data['customer'])
95			->setOrder($data['order'])
96			->setCustomData($data['custom_data'])
97			->setOrigin($data['origin'])
98			->setIsTest($data['is_test'])
99			;
100			}
101			}
102

alcalyn / payplug-bundle

PayplugIPNService::verifyIPNRequest() A last analyzed 2017-08-25 15:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PayplugIPNService::verifyIPNRequest() A
last analyzed 2017-08-25 15:42 UTC