Alcalyn\PayplugBundle\Event\PayplugMalformedIPNEvent

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getRequest()	0	4	1

<?php

namespace Alcalyn\PayplugBundle\Event;

use Symfony\Component\HttpFoundation\Request;

class PayplugMalformedIPNEvent extends PayplugEvent
{
    /**
     * Event throw on a malformed IPN received.
     * 
     * The listener receive a PayplugMalformedIPNEvent event
     * 
     * @var string
     */
    const PAYPLUG_IPN_MALFORMED = 'event.payplug.ipn.malformed';
    
    /**
     * @var Request
     */
    private $request;
    
    /**
     * @param Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }
    
    /**
     * Return the request responsible of the malformed IPN
     * 
     * @return Request
     */
    public function getRequest()
    {
        return $this->request;
    }
}