Issues in MongoTimestamp.php (master) - Issues in master - alcaeus/mongo-php-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Issues (61)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Mongo/MongoTimestamp.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

if (class_exists('MongoTimestamp', false)) {
    return;
}

use Alcaeus\MongoDbAdapter\TypeInterface;
use MongoDB\BSON\Timestamp;

class MongoTimestamp implements TypeInterface
{
    /**
     * @var int
     */
    private static $globalInc = 0;

    /**
     * @link http://php.net/manual/en/class.mongotimestamp.php#mongotimestamp.props.sec
     * @var int
     */
    public $sec;

    /**
     * @link http://php.net/manual/en/class.mongotimestamp.php#mongotimestamp.props.inc
     * @var int
     */
    public $inc;

    /**
     * Creates a new timestamp. If no parameters are given, the current time is used
     * and the increment is automatically provided. The increment is set to 0 when the
     * module is loaded and is incremented every time this constructor is called
     * (without the $inc parameter passed in).
     *
     * @link http://php.net/manual/en/mongotimestamp.construct.php
     * @param int $sec [optional] Number of seconds since January 1st, 1970
     * @param int $inc [optional] Increment
     */
    public function __construct($sec = 0, $inc = 0)
    {
        if ($sec instanceof Timestamp) {
            // Only way is to convert is from string: [<inc>:<sec>]
            $parts = explode(':', substr((string) $sec, 1, -1));
            $this->sec = (int) $parts[1];
            $this->inc = (int) $parts[0];

            return;
        }

        if (func_num_args() == 0) {
            $sec = time();
        }

        if (func_num_args() <= 1) {
            $inc = static::$globalInc;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$globalInc++;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        $this->sec = (int) $sec;
        $this->inc = (int) $inc;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        return (string) $this->sec;
    }

    /**
     * Converts this MongoTimestamp to the new BSON Timestamp type
     *
     * @return Timestamp
     * @internal This method is not part of the ext-mongo API
     */
    public function toBSONType()
    {
        return new Timestamp($this->inc, $this->sec);
    }
}


1			<?php
2			/*
3			* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4			* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5			* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6			* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7			* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8			* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9			* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10			* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11			* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12			* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13			* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14			*/
15
16			if (class_exists('MongoTimestamp', false)) {
17			return;
18			}
19
20			use Alcaeus\MongoDbAdapter\TypeInterface;
21			use MongoDB\BSON\Timestamp;
22
23			class MongoTimestamp implements TypeInterface
24			{
25			/**
26			* @var int
27			*/
28			private static $globalInc = 0;
29
30			/**
31			* @link http://php.net/manual/en/class.mongotimestamp.php#mongotimestamp.props.sec
32			* @var int
33			*/
34			public $sec;
35
36			/**
37			* @link http://php.net/manual/en/class.mongotimestamp.php#mongotimestamp.props.inc
38			* @var int
39			*/
40			public $inc;
41
42			/**
43			* Creates a new timestamp. If no parameters are given, the current time is used
44			* and the increment is automatically provided. The increment is set to 0 when the
45			* module is loaded and is incremented every time this constructor is called
46			* (without the $inc parameter passed in).
47			*
48			* @link http://php.net/manual/en/mongotimestamp.construct.php
49			* @param int $sec [optional] Number of seconds since January 1st, 1970
50			* @param int $inc [optional] Increment
51			*/
52			public function __construct($sec = 0, $inc = 0)
53			{
54			if ($sec instanceof Timestamp) {
55			// Only way is to convert is from string: [<inc>:<sec>]
56			$parts = explode(':', substr((string) $sec, 1, -1));
57			$this->sec = (int) $parts[1];
58			$this->inc = (int) $parts[0];
59
60			return;
61			}
62
63			if (func_num_args() == 0) {
64			$sec = time();
65			}
66
67			if (func_num_args() <= 1) {
68			$inc = static::$globalInc;
			0 ignored issues – show Bug introduced 2015-12-30 16:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$globalInc` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$globalInc` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
69			static::$globalInc++;
			0 ignored issues – show Bug introduced 2015-12-30 16:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$globalInc` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$globalInc` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
70			}
71
72			$this->sec = (int) $sec;
73			$this->inc = (int) $inc;
74			}
75
76			/**
77			* @return string
78			*/
79			public function __toString()
80			{
81			return (string) $this->sec;
82			}
83
84			/**
85			* Converts this MongoTimestamp to the new BSON Timestamp type
86			*
87			* @return Timestamp
88			* @internal This method is not part of the ext-mongo API
89			*/
90			public function toBSONType()
91			{
92			return new Timestamp($this->inc, $this->sec);
93			}
94			}
95

alcaeus / mongo-php-adapter

Issues (61)

Security Analysis not enabled

lib/Mongo/MongoTimestamp.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like