Completed
Pull Request — master (#74)
by Andreas
03:46
created
lib/Mongo/MongoId.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@
 block discarded – undo
200 200
     }
201 201
 
202 202
     /**
203
-     * @param $id
203
+     * @param string|null $id
204 204
      * @throws MongoException
205 205
      */
206 206
     private function createObjectID($id)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     {
49 49
         if ($value instanceof ObjectID || $value instanceof MongoId) {
50 50
             return true;
51
-        } elseif (! is_string($value)) {
51
+        } elseif ( ! is_string($value)) {
52 52
             return false;
53 53
         }
54 54
 
Please login to merge, or discard this patch.
lib/Mongo/MongoResultException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      * http://php.net/manual/en/mongoresultexception.getdocument.php
26 26
      * @return array <p>The full result document as an array, including partial data if available and additional keys.</p>
27 27
      */
28
-    public function getDocument () {}
28
+    public function getDocument() {}
29 29
 
30 30
     public $document;
31 31
 
Please login to merge, or discard this patch.
lib/Mongo/MongoGridFSFile.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -126,6 +126,9 @@
 block discarded – undo
126 126
         );
127 127
     }
128 128
 
129
+    /**
130
+     * @param resource $handle
131
+     */
129 132
     private function writeFromRessource($handle)
130 133
     {
131 134
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
             $filename = 'file';
76 76
         }
77 77
 
78
-        if (! $handle = fopen($filename, 'w')) {
78
+        if ( ! $handle = fopen($filename, 'w')) {
79 79
             trigger_error(E_ERROR, 'Can not open the destination file');
80 80
             return 0;
81 81
         }
Please login to merge, or discard this patch.
lib/Mongo/Mongo.php 2 patches
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      * Returns the address being used by this for slaveOkay reads
49 49
      *
50 50
      * @link http://php.net/manual/en/mongo.getslave.php
51
-     * @return bool The address of the secondary this connection is using for
51
+     * @return boolean|null The address of the secondary this connection is using for
52 52
      * reads. This returns NULL if this is not connected to a replica set or not yet
53 53
      * initialized.
54 54
      */
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
      * Get slaveOkay setting for this connection
62 62
      *
63 63
      * @link http://php.net/manual/en/mongo.getslaveokay.php
64
-     * @return bool Returns the value of slaveOkay for this instance.
64
+     * @return boolean|null Returns the value of slaveOkay for this instance.
65 65
      */
66 66
     public function getSlaveOkay()
67 67
     {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      *
74 74
      * @link http://www.php.net/manual/en/mongo.pairconnect.php
75 75
      * @throws MongoConnectionException
76
-     * @return boolean
76
+     * @return boolean|null
77 77
      *
78 78
      * @deprecated Pass a string of the form "mongodb://server1,server2" to the constructor instead of using this method.
79 79
      */
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      *
100 100
      * @link http://php.net/manual/en/mongo.setslaveokay.php
101 101
      * @param bool $ok
102
-     * @return bool returns the former value of slaveOkay for this instance.
102
+     * @return boolean|null returns the former value of slaveOkay for this instance.
103 103
      */
104 104
     public function setSlaveOkay ($ok)
105 105
     {
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
      *
112 112
      * @link http://php.net/manual/en/mongo.setpoolsize.php
113 113
      * @param $size <p>The max number of connections future pools will be able to create. Negative numbers mean that the pool will spawn an infinite number of connections.</p>
114
-     * @return bool Returns the former value of pool size.
114
+     * @return boolean|null Returns the former value of pool size.
115 115
      * @deprecated Relying on this feature is highly discouraged. Please use MongoPool::setSize() instead.
116 116
      */
117 117
     public function setPoolSize($size)
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      * @param string $username A username used to identify the connection.
127 127
      * @param string $password A password used to identify the connection.
128 128
      * @throws MongoConnectionException
129
-     * @return boolean If the connection was successful.
129
+     * @return boolean|null If the connection was successful.
130 130
      * @deprecated Pass array("persist" => $id) to the constructor instead of using this method.
131 131
      */
132 132
     public function persistConnect($username = "", $password = "")
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      * @param string $username A username used to identify the connection.
142 142
      * @param string $password A password used to identify the connection.
143 143
      * @throws MongoConnectionException
144
-     * @return boolean If the connection was successful.
144
+     * @return boolean|null If the connection was successful.
145 145
      * @deprecated Pass "mongodb://server1,server2" and array("persist" => $id) to the constructor instead of using this method.
146 146
      */
147 147
     public function pairPersistConnect($username = "", $password = "")
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
      *
155 155
      * @link http://www.php.net/manual/en/mongo.connectutil.php
156 156
      * @throws MongoConnectionException
157
-     * @return boolean If the connection was successful.
157
+     * @return boolean|null If the connection was successful.
158 158
      */
159 159
     protected function connectUtil()
160 160
     {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
      * Creates a database error on the database.
202 202
      *
203 203
      * @link http://www.php.net/manual/en/mongo.forceerror.php
204
-     * @return boolean The database response.
204
+     * @return boolean|null The database response.
205 205
      * @deprecated Use MongoDB::forceError() instead.
206 206
      */
207 207
     public function forceError()
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@
 block discarded – undo
101 101
      * @param bool $ok
102 102
      * @return bool returns the former value of slaveOkay for this instance.
103 103
      */
104
-    public function setSlaveOkay ($ok)
104
+    public function setSlaveOkay($ok)
105 105
     {
106 106
         $this->notImplemented();
107 107
     }
Please login to merge, or discard this patch.
lib/Mongo/MongoDBRef.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
      */
78 78
     public static function get($db, $ref)
79 79
     {
80
-        if (! static::isRef($ref)) {
80
+        if ( ! static::isRef($ref)) {
81 81
             return null;
82 82
         }
83 83
 
Please login to merge, or discard this patch.
lib/Mongo/MongoRegex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
             return;
44 44
         }
45 45
 
46
-        if (! preg_match('#^/(.*)/([imxslu]*)$#', $regex, $matches)) {
46
+        if ( ! preg_match('#^/(.*)/([imxslu]*)$#', $regex, $matches)) {
47 47
             throw new MongoException('invalid regex', 9);
48 48
         }
49 49
 
Please login to merge, or discard this patch.
lib/Mongo/MongoPool.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
      *
36 36
      * @link http://php.net/manual/en/mongopool.setsize.php
37 37
      * @param int $size
38
-     * @return boolean Returns the former value of pool size
38
+     * @return integer Returns the former value of pool size
39 39
      */
40 40
     public static function setSize($size)
41 41
     {
Please login to merge, or discard this patch.
lib/Mongo/MongoLog.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@
 block discarded – undo
119 119
      * <ul>
120 120
      * @return boolean Returns <b>TRUE</b> on success or <b>FALSE</b> on failure.
121 121
      */
122
-    public static function setCallback(callable $log_function )
122
+    public static function setCallback(callable $log_function)
123 123
     {
124 124
         self::$callback = $log_function;
125 125
         return true;
Please login to merge, or discard this patch.
lib/Mongo/MongoGridFSCursor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -65,6 +65,6 @@
 block discarded – undo
65 65
     public function key()
66 66
     {
67 67
         $file = $this->current();
68
-        return ($file !== null) ? (string)$file->file['_id'] : null;
68
+        return ($file !== null) ? (string) $file->file['_id'] : null;
69 69
     }
70 70
 }
Please login to merge, or discard this patch.