Completed
Pull Request — master (#20)
by
unknown
02:34
created

MongoCollection::setWriteConcern()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %
Metric Value
dl 0
loc 7
rs 9.4285
cc 1
eloc 4
nc 1
nop 2
1
<?php
2
/*
3
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
4
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
5
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
6
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
7
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
8
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
9
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
10
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
11
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
12
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
13
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
14
 */
15
16
use Alcaeus\MongoDbAdapter\Helper;
17
use Alcaeus\MongoDbAdapter\TypeConverter;
18
use Alcaeus\MongoDbAdapter\ExceptionConverter;
19
20
/**
21
 * Represents a database collection.
22
 * @link http://www.php.net/manual/en/class.mongocollection.php
23
 */
24
class MongoCollection
1 ignored issue
show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
25
{
26
    use Helper\ReadPreference;
27
    use Helper\SlaveOkay;
28
    use Helper\WriteConcern;
29
30
    const ASCENDING = 1;
31
    const DESCENDING = -1;
32
33
    /**
34
     * @var MongoDB
35
     */
36
    public $db = NULL;
37
38
    /**
39
     * @var string
40
     */
41
    protected $name;
42
43
    /**
44
     * @var \MongoDB\Collection
45
     */
46
    protected $collection;
47
48
    /**
49
     * Creates a new collection
50
     *
51
     * @link http://www.php.net/manual/en/mongocollection.construct.php
52
     * @param MongoDB $db Parent database.
53
     * @param string $name Name for this collection.
54
     * @throws Exception
55
     * @return MongoCollection
0 ignored issues
show
Comprehensibility Best Practice introduced by
Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

Adding a @return annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.

Please refer to the PHP core documentation on constructors.

Loading history...
56
     */
57
    public function __construct(MongoDB $db, $name)
58
    {
59
        $this->checkCollectionName($name);
60
        $this->db = $db;
61
        $this->name = $name;
62
63
        $this->setReadPreferenceFromArray($db->getReadPreference());
64
        $this->setWriteConcernFromArray($db->getWriteConcern());
65
66
        $this->createCollectionObject();
67
    }
68
69
    /**
70
     * Gets the underlying collection for this object
71
     *
72
     * @internal This part is not of the ext-mongo API and should not be used
73
     * @return \MongoDB\Collection
74
     */
75
    public function getCollection()
76
    {
77
        return $this->collection;
78
    }
79
80
    /**
81
     * String representation of this collection
82
     *
83
     * @link http://www.php.net/manual/en/mongocollection.--tostring.php
84
     * @return string Returns the full name of this collection.
85
     */
86
    public function __toString()
87
    {
88
        return (string) $this->db . '.' . $this->name;
89
    }
90
91
    /**
92
     * Gets a collection
93
     *
94
     * @link http://www.php.net/manual/en/mongocollection.get.php
95
     * @param string $name The next string in the collection name.
96
     * @return MongoCollection
97
     */
98
    public function __get($name)
99
    {
100
        // Handle w and wtimeout properties that replicate data stored in $readPreference
101
        if ($name === 'w' || $name === 'wtimeout') {
102
            return $this->getWriteConcern()[$name];
103
        }
104
105
        return $this->db->selectCollection($this->name . '.' . $name);
106
    }
107
108
    /**
109
     * @param string $name
110
     * @param mixed $value
111
     */
112 View Code Duplication
    public function __set($name, $value)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
113
    {
114
        if ($name === 'w' || $name === 'wtimeout') {
115
            $this->setWriteConcernFromArray([$name => $value] + $this->getWriteConcern());
116
            $this->createCollectionObject();
117
        }
118
    }
119
120
    /**
121
     * Perform an aggregation using the aggregation framework
122
     *
123
     * @link http://www.php.net/manual/en/mongocollection.aggregate.php
124
     * @param array $pipeline
125
     * @param array $op
126
     * @return array
127
     */
128
    public function aggregate(array $pipeline, array $op = [])
129
    {
130
        if (! TypeConverter::isNumericArray($pipeline)) {
131
            $pipeline = [];
132
            $options = [];
133
134
            $i = 0;
135
            foreach (func_get_args() as $operator) {
136
                $i++;
137
                if (! is_array($operator)) {
138
                    trigger_error("Argument $i is not an array", E_WARNING);
139
                    return;
140
                }
141
142
                $pipeline[] = $operator;
143
            }
144
        } else {
145
            $options = $op;
146
        }
147
148
        $command = [
149
            'aggregate' => $this->name,
150
            'pipeline' => $pipeline
151
        ];
152
153
        $command += $options;
154
155
        try {
156
            return $this->db->command($command);
157
        } catch (MongoCursorTimeoutException $e) {
158
            throw new MongoExecutionTimeoutException($e->getMessage(), $e->getCode(), $e);
159
        }
160
161
    }
162
163
    /**
164
     * Execute an aggregation pipeline command and retrieve results through a cursor
165
     *
166
     * @link http://php.net/manual/en/mongocollection.aggregatecursor.php
167
     * @param array $pipeline
168
     * @param array $options
169
     * @return MongoCommandCursor
170
     */
171
    public function aggregateCursor(array $pipeline, array $options = [])
172
    {
173
        // Build command manually, can't use mongo-php-library here
174
        $command = [
175
            'aggregate' => $this->name,
176
            'pipeline' => $pipeline
177
        ];
178
179
        // Convert cursor option
180
        if (! isset($options['cursor'])) {
181
            $options['cursor'] = true;
182
        }
183
184
        $command += $options;
185
186
        $cursor = new MongoCommandCursor($this->db->getConnection(), (string) $this, $command);
187
        $cursor->setReadPreference($this->getReadPreference());
0 ignored issues
show
Documentation introduced by
$this->getReadPreference() is of type array, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
188
189
        return $cursor;
190
    }
191
192
    /**
193
     * Returns this collection's name
194
     *
195
     * @link http://www.php.net/manual/en/mongocollection.getname.php
196
     * @return string
197
     */
198
    public function getName()
199
    {
200
        return $this->name;
201
    }
202
203
    /**
204
     * {@inheritdoc}
205
     */
206
    public function setReadPreference($readPreference, $tags = null)
207
    {
208
        $result = $this->setReadPreferenceFromParameters($readPreference, $tags);
209
        $this->createCollectionObject();
210
211
        return $result;
212
    }
213
214
    /**
215
     * {@inheritdoc}
216
     */
217
    public function setWriteConcern($wstring, $wtimeout = 0)
218
    {
219
        $result = $this->setWriteConcernFromParameters($wstring, $wtimeout);
220
        $this->createCollectionObject();
221
222
        return $result;
223
    }
224
225
    /**
226
     * Drops this collection
227
     *
228
     * @link http://www.php.net/manual/en/mongocollection.drop.php
229
     * @return array Returns the database response.
230
     */
231
    public function drop()
232
    {
233
        return TypeConverter::toLegacy($this->collection->drop());
234
    }
235
236
    /**
237
     * Validates this collection
238
     *
239
     * @link http://www.php.net/manual/en/mongocollection.validate.php
240
     * @param bool $scan_data Only validate indices, not the base collection.
241
     * @return array Returns the database's evaluation of this object.
242
     */
243
    public function validate($scan_data = FALSE)
244
    {
245
        $command = [
246
            'validate' => $this->name,
247
            'full'     => $scan_data,
248
        ];
249
250
        return $this->db->command($command);
251
    }
252
253
    /**
254
     * Inserts an array into the collection
255
     *
256
     * @link http://www.php.net/manual/en/mongocollection.insert.php
257
     * @param array|object $a
258
     * @param array $options
259
     * @throws MongoException if the inserted document is empty or if it contains zero-length keys. Attempting to insert an object with protected and private properties will cause a zero-length key error.
260
     * @throws MongoCursorException if the "w" option is set and the write fails.
261
     * @throws MongoCursorTimeoutException if the "w" option is set to a value greater than one and the operation takes longer than MongoCursor::$timeout milliseconds to complete. This does not kill the operation on the server, it is a client-side timeout. The operation in MongoCollection::$wtimeout is milliseconds.
262
     * @return bool|array Returns an array containing the status of the insertion if the "w" option is set.
263
     */
264
    public function insert(&$a, array $options = [])
265
    {
266
        if (! $this->ensureDocumentHasMongoId($a)) {
267
            trigger_error(sprintf('%s expects parameter %d to be an array or object, %s given', __METHOD__, 1, gettype($a)), E_USER_WARNING);
268
            return;
269
        }
270
271
        if (! count((array)$a)) {
272
            throw new \MongoException('document must be an array or object');
273
        }
274
275
        try {
276
            $result = $this->collection->insertOne(
277
                TypeConverter::fromLegacy($a),
278
                $this->convertWriteConcernOptions($options)
279
            );
280
        } catch (\MongoDB\Driver\Exception\BulkWriteException $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\BulkWriteException does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
281
            $writeResult = $e->getWriteResult();
282
            $writeError = $writeResult->getWriteErrors()[0];
283
            return [
284
                'ok' => 0.0,
285
                'n' => 0,
286
                'err' => $writeError->getCode(),
287
                'errmsg' => $writeError->getMessage(),
288
            ];
289
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
290
            ExceptionConverter::toLegacy($e);
291
        }
292
293
        if (! $result->isAcknowledged()) {
294
            return true;
295
        }
296
297
        return [
298
            'ok' => 1.0,
299
            'n' => 0,
300
            'err' => null,
301
            'errmsg' => null,
302
        ];
303
    }
304
305
    /**
306
     * Inserts multiple documents into this collection
307
     *
308
     * @link http://www.php.net/manual/en/mongocollection.batchinsert.php
309
     * @param array $a An array of arrays.
310
     * @param array $options Options for the inserts.
311
     * @throws MongoCursorException
312
     * @return mixed If "safe" is set, returns an associative array with the status of the inserts ("ok") and any error that may have occured ("err"). Otherwise, returns TRUE if the batch insert was successfully sent, FALSE otherwise.
313
     */
314
    public function batchInsert(array &$a, array $options = [])
315
    {
316
        if (empty($a)) {
317
            throw new \MongoException('No write ops were included in the batch');
318
        }
319
320
        $continueOnError = isset($options['continueOnError']) && $options['continueOnError'];
321
322
        foreach ($a as $key => $item) {
323
            try {
324
                if (! $this->ensureDocumentHasMongoId($a[$key])) {
325
                    if ($continueOnError) {
326
                        unset($a[$key]);
327
                    } else {
328
                        trigger_error(sprintf('%s expects parameter %d to be an array or object, %s given', __METHOD__, 1, gettype($a)), E_USER_WARNING);
329
                        return;
330
                    }
331
                }
332
            } catch (MongoException $e) {
333
                if ( ! $continueOnError) {
334
                    throw $e;
335
                }
336
            }
337
        }
338
339
        try {
340
            $result = $this->collection->insertMany(
341
                TypeConverter::fromLegacy(array_values($a)),
342
                $this->convertWriteConcernOptions($options)
343
            );
344
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
345
            ExceptionConverter::toLegacy($e);
346
        }
347
348
        if (! $result->isAcknowledged()) {
349
            return true;
350
        }
351
352
        return [
353
            'connectionId' => 0,
354
            'n' => 0,
355
            'syncMillis' => 0,
356
            'writtenTo' => null,
357
            'err' => null,
358
            'errmsg' => null,
359
        ];
360
    }
361
362
    /**
363
     * Update records based on a given criteria
364
     *
365
     * @link http://www.php.net/manual/en/mongocollection.update.php
366
     * @param array $criteria Description of the objects to update.
367
     * @param array $newobj The object with which to update the matching records.
368
     * @param array $options
369
     * @throws MongoCursorException
370
     * @return boolean
371
     */
372
    public function update(array $criteria , array $newobj, array $options = [])
373
    {
374
        $multiple = isset($options['multiple']) ? $options['multiple'] : false;
375
        $method = $multiple ? 'updateMany' : 'updateOne';
376
        unset($options['multiple']);
377
378
        try {
379
            /** @var \MongoDB\UpdateResult $result */
380
            $result = $this->collection->$method(
381
                TypeConverter::fromLegacy($criteria),
382
                TypeConverter::fromLegacy($newobj),
383
                $this->convertWriteConcernOptions($options)
384
            );
385
        } catch (\MongoDB\Driver\Exception\BulkWriteException $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\BulkWriteException does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
386
            $writeResult = $e->getWriteResult();
387
            $writeError = $writeResult->getWriteErrors()[0];
388
            return [
389
                'ok' => 0.0,
390
                'nModified' => $writeResult->getModifiedCount(),
391
                'n' => $writeResult->getMatchedCount(),
392
                'err' => $writeError->getCode(),
393
                'errmsg' => $writeError->getMessage(),
394
                'updatedExisting' => $writeResult->getUpsertedCount() == 0,
395
            ];
396
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
397
            ExceptionConverter::toLegacy($e);
398
        }
399
400
        if (! $result->isAcknowledged()) {
401
            return true;
402
        }
403
404
        return [
405
            'ok' => 1.0,
406
            'nModified' => $result->getModifiedCount(),
407
            'n' => $result->getMatchedCount(),
408
            'err' => null,
409
            'errmsg' => null,
410
            'updatedExisting' => $result->getUpsertedCount() == 0,
411
        ];
412
    }
413
414
    /**
415
     * Remove records from this collection
416
     *
417
     * @link http://www.php.net/manual/en/mongocollection.remove.php
418
     * @param array $criteria Query criteria for the documents to delete.
419
     * @param array $options An array of options for the remove operation.
420
     * @throws MongoCursorException
421
     * @throws MongoCursorTimeoutException
422
     * @return bool|array Returns an array containing the status of the removal
423
     * if the "w" option is set. Otherwise, returns TRUE.
424
     */
425
    public function remove(array $criteria = [], array $options = [])
426
    {
427
        $multiple = isset($options['justOne']) ? !$options['justOne'] : true;
428
        $method = $multiple ? 'deleteMany' : 'deleteOne';
429
430
        try {
431
            /** @var \MongoDB\DeleteResult $result */
432
            $result = $this->collection->$method(
433
                TypeConverter::fromLegacy($criteria),
434
                $this->convertWriteConcernOptions($options)
435
            );
436
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
437
            ExceptionConverter::toLegacy($e);
438
        }
439
440
        if (! $result->isAcknowledged()) {
441
            return true;
442
        }
443
444
        return [
445
            'ok' => 1.0,
446
            'n' => $result->getDeletedCount(),
447
            'err' => null,
448
            'errmsg' => null
449
        ];
450
    }
451
452
    /**
453
     * Querys this collection
454
     *
455
     * @link http://www.php.net/manual/en/mongocollection.find.php
456
     * @param array $query The fields for which to search.
457
     * @param array $fields Fields of the results to return.
458
     * @return MongoCursor
459
     */
460 View Code Duplication
    public function find(array $query = [], array $fields = [])
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
461
    {
462
        $cursor = new MongoCursor($this->db->getConnection(), (string) $this, $query, $fields);
463
        $cursor->setReadPreference($this->getReadPreference());
0 ignored issues
show
Documentation introduced by
$this->getReadPreference() is of type array, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
464
465
        return $cursor;
466
    }
467
468
    /**
469
     * Retrieve a list of distinct values for the given key across a collection
470
     *
471
     * @link http://www.php.net/manual/ru/mongocollection.distinct.php
472
     * @param string $key The key to use.
473
     * @param array $query An optional query parameters
474
     * @return array|bool Returns an array of distinct values, or FALSE on failure
475
     */
476
    public function distinct($key, array $query = [])
477
    {
478
        try {
479
            return array_map([TypeConverter::class, 'toLegacy'], $this->collection->distinct($key, $query));
480
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
481
            return false;
482
        }
483
    }
484
485
    /**
486
     * Update a document and return it
487
     *
488
     * @link http://www.php.net/manual/ru/mongocollection.findandmodify.php
489
     * @param array $query The query criteria to search for.
490
     * @param array $update The update criteria.
491
     * @param array $fields Optionally only return these fields.
492
     * @param array $options An array of options to apply, such as remove the match document from the DB and return it.
493
     * @return array Returns the original document, or the modified document when new is set.
494
     */
495
    public function findAndModify(array $query, array $update = null, array $fields = null, array $options = [])
496
    {
497
        $query = TypeConverter::fromLegacy($query);
498
        try {
499
            if (isset($options['remove'])) {
500
                unset($options['remove']);
501
                $document = $this->collection->findOneAndDelete($query, $options);
502
            } else {
503
                $update = is_array($update) ? TypeConverter::fromLegacy($update) : [];
504
505
                if (isset($options['new'])) {
506
                    $options['returnDocument'] = \MongoDB\Operation\FindOneAndUpdate::RETURN_DOCUMENT_AFTER;
507
                    unset($options['new']);
508
                }
509
510
                $options['projection'] = is_array($fields) ? TypeConverter::fromLegacy($fields) : [];
511
512
                $document = $this->collection->findOneAndUpdate($query, $update, $options);
513
            }
514
        } catch (\MongoDB\Driver\Exception\ConnectionException $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\ConnectionException does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
515
            throw new MongoResultException($e->getMessage(), $e->getCode(), $e);
516
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
517
            ExceptionConverter::toLegacy($e);
518
        }
519
520
        if ($document) {
521
            $document = TypeConverter::toLegacy($document);
0 ignored issues
show
Bug introduced by
The variable $document does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
522
        }
523
524
        return $document;
525
    }
526
527
    /**
528
     * Querys this collection, returning a single element
529
     *
530
     * @link http://www.php.net/manual/en/mongocollection.findone.php
531
     * @param array $query The fields for which to search.
532
     * @param array $fields Fields of the results to return.
533
     * @param array $options
534
     * @return array|null
535
     */
536
    public function findOne(array $query = [], array $fields = [], array $options = [])
537
    {
538
        $options = ['projection' => $fields] + $options;
539
        try {
540
            $document = $this->collection->findOne(TypeConverter::fromLegacy($query), $options);
541
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
542
            ExceptionConverter::toLegacy($e);
543
        }
544
545
        if ($document !== null) {
546
            $document = TypeConverter::toLegacy($document);
547
        }
548
549
        return $document;
550
    }
551
552
    /**
553
     * Creates an index on the given field(s), or does nothing if the index already exists
554
     *
555
     * @link http://www.php.net/manual/en/mongocollection.createindex.php
556
     * @param array $keys Field or fields to use as index.
557
     * @param array $options [optional] This parameter is an associative array of the form array("optionname" => <boolean>, ...).
558
     * @return array Returns the database response.
559
     *
560
     * @todo This method does not yet return the correct result
561
     */
562
    public function createIndex($keys, array $options = [])
563
    {
564
        if (is_string($keys)) {
565
            if (empty($keys)) {
566
                throw new MongoException('empty string passed as key field');
567
            }
568
            $keys = [$keys => 1];
569
        }
570
571
        if (is_object($keys)) {
572
            $keys = (array) $keys;
573
        }
574
575
        if (! is_array($keys) || ! count($keys)) {
576
            throw new MongoException('keys cannot be empty');
577
        }
578
579
        // duplicate
580
        $neededOptions = ['unique' => 1, 'sparse' => 1, 'expireAfterSeconds' => 1, 'background' => 1, 'dropDups' => 1];
581
        $indexOptions = array_intersect_key($options, $neededOptions);
582
        $indexes = $this->collection->listIndexes();
583
        foreach ($indexes as $index) {
584
585
            if (! empty($options['name']) && $index->getName() === $options['name']) {
586
                throw new \MongoResultException(sprintf('index with name: %s already exists', $index->getName()));
587
            }
588
589
            if ($index->getKey() == $keys) {
590
                $currentIndexOptions = array_intersect_key($index->__debugInfo(), $neededOptions);
591
592
                unset($currentIndexOptions['name']);
593
                if ($currentIndexOptions != $indexOptions) {
594
                    throw new \MongoResultException('Index with same keys but different options already exists');
595
                }
596
597
                return [
598
                    'createdCollectionAutomatically' => false,
599
                    'numIndexesBefore' => count($indexes),
600
                    'numIndexesAfter' => count($indexes),
601
                    'note' => 'all indexes already exist',
602
                    'ok' => 1.0
603
                ];
604
            }
605
        }
606
607
        try {
608
            $this->collection->createIndex($keys, $this->convertWriteConcernOptions($options));
609
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
610
            ExceptionConverter::toLegacy($e);
611
        }
612
613
        return [
614
            'createdCollectionAutomatically' => true,
615
            'numIndexesBefore' => count($indexes),
616
            'numIndexesAfter' => count($indexes) + 1,
617
            'ok' => 1.0
618
        ];
619
    }
620
621
    /**
622
     * Creates an index on the given field(s), or does nothing if the index already exists
623
     *
624
     * @link http://www.php.net/manual/en/mongocollection.ensureindex.php
625
     * @param array $keys Field or fields to use as index.
626
     * @param array $options [optional] This parameter is an associative array of the form array("optionname" => <boolean>, ...).
627
     * @return boolean always true
628
     * @deprecated Use MongoCollection::createIndex() instead.
629
     */
630
    public function ensureIndex(array $keys, array $options = [])
631
    {
632
        $this->createIndex($keys, $options);
633
634
        return true;
635
    }
636
637
    /**
638
     * Deletes an index from this collection
639
     *
640
     * @link http://www.php.net/manual/en/mongocollection.deleteindex.php
641
     * @param string|array $keys Field or fields from which to delete the index.
642
     * @return array Returns the database response.
643
     */
644
    public function deleteIndex($keys)
645
    {
646
        if (is_string($keys)) {
647
            $indexName = $keys;
648
        } elseif (is_array($keys)) {
649
            $indexName = \MongoDB\generate_index_name($keys);
650
        } else {
651
            throw new \InvalidArgumentException();
652
        }
653
654
        return TypeConverter::toLegacy($this->collection->dropIndex($indexName));
655
    }
656
657
    /**
658
     * Delete all indexes for this collection
659
     *
660
     * @link http://www.php.net/manual/en/mongocollection.deleteindexes.php
661
     * @return array Returns the database response.
662
     */
663
    public function deleteIndexes()
664
    {
665
        return TypeConverter::toLegacy($this->collection->dropIndexes());
666
    }
667
668
    /**
669
     * Returns an array of index names for this collection
670
     *
671
     * @link http://www.php.net/manual/en/mongocollection.getindexinfo.php
672
     * @return array Returns a list of index names.
673
     */
674
    public function getIndexInfo()
675
    {
676
        $convertIndex = function(\MongoDB\Model\IndexInfo $indexInfo) {
677
            return [
678
                'v' => $indexInfo->getVersion(),
679
                'key' => $indexInfo->getKey(),
680
                'name' => $indexInfo->getName(),
681
                'ns' => $indexInfo->getNamespace(),
682
            ];
683
        };
684
685
        return array_map($convertIndex, iterator_to_array($this->collection->listIndexes()));
686
    }
687
688
    /**
689
     * Counts the number of documents in this collection
690
     *
691
     * @link http://www.php.net/manual/en/mongocollection.count.php
692
     * @param array|stdClass $query
693
     * @param array $options
694
     * @return int Returns the number of documents matching the query.
695
     */
696
    public function count($query = [], array $options = [])
697
    {
698
        try {
699
            return $this->collection->count(TypeConverter::fromLegacy($query), $options);
700
        } catch (\MongoDB\Driver\Exception\Exception $e) {
1 ignored issue
show
Bug introduced by
The class MongoDB\Driver\Exception\Exception does not exist. Did you forget a USE statement, or did you not list all dependencies?

Scrutinizer analyzes your composer.json/composer.lock file if available to determine the classes, and functions that are defined by your dependencies.

It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis.

Loading history...
701
            ExceptionConverter::toLegacy($e);
702
        }
703
    }
704
705
    /**
706
     * Saves an object to this collection
707
     *
708
     * @link http://www.php.net/manual/en/mongocollection.save.php
709
     * @param array|object $a Array to save. If an object is used, it may not have protected or private properties.
710
     * @param array $options Options for the save.
711
     * @throws MongoException if the inserted document is empty or if it contains zero-length keys. Attempting to insert an object with protected and private properties will cause a zero-length key error.
712
     * @throws MongoCursorException if the "w" option is set and the write fails.
713
     * @throws MongoCursorTimeoutException if the "w" option is set to a value greater than one and the operation takes longer than MongoCursor::$timeout milliseconds to complete. This does not kill the operation on the server, it is a client-side timeout. The operation in MongoCollection::$wtimeout is milliseconds.
714
     * @return array|boolean If w was set, returns an array containing the status of the save.
715
     * Otherwise, returns a boolean representing if the array was not empty (an empty array will not be inserted).
716
     */
717
    public function save(&$a, array $options = [])
718
    {
719
        $id = $this->ensureDocumentHasMongoId($a);
720
721
        $document = (array) $a;
722
        unset($document['_id']);
723
724
        $options['upsert'] = true;
725
726
        $result = $this->update(['_id' => $id], ['$set' => $a], $options);
727
        if ($result['ok'] == 0.0) {
728
            throw new \MongoCursorException();
729
        }
730
731
        return $result;
732
    }
733
734
    /**
735
     * Creates a database reference
736
     *
737
     * @link http://www.php.net/manual/en/mongocollection.createdbref.php
738
     * @param array|object $document_or_id Object to which to create a reference.
739
     * @return array Returns a database reference array.
740
     */
741 View Code Duplication
    public function createDBRef($document_or_id)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
742
    {
743
        if ($document_or_id instanceof \MongoId) {
744
            $id = $document_or_id;
745
        } elseif (is_object($document_or_id)) {
746
            if (! isset($document_or_id->_id)) {
747
                return null;
748
            }
749
750
            $id = $document_or_id->_id;
751
        } elseif (is_array($document_or_id)) {
752
            if (! isset($document_or_id['_id'])) {
753
                return null;
754
            }
755
756
            $id = $document_or_id['_id'];
757
        } else {
758
            $id = $document_or_id;
759
        }
760
761
        return MongoDBRef::create($this->name, $id);
762
    }
763
764
    /**
765
     * Fetches the document pointed to by a database reference
766
     *
767
     * @link http://www.php.net/manual/en/mongocollection.getdbref.php
768
     * @param array $ref A database reference.
769
     * @return array Returns the database document pointed to by the reference.
770
     */
771
    public function getDBRef(array $ref)
772
    {
773
        return $this->db->getDBRef($ref);
774
    }
775
776
    /**
777
     * Performs an operation similar to SQL's GROUP BY command
778
     *
779
     * @link http://www.php.net/manual/en/mongocollection.group.php
780
     * @param mixed $keys Fields to group by. If an array or non-code object is passed, it will be the key used to group results.
781
     * @param array $initial Initial value of the aggregation counter object.
782
     * @param MongoCode|string $reduce A function that aggregates (reduces) the objects iterated.
783
     * @param array $condition An condition that must be true for a row to be considered.
784
     * @return array
785
     */
786
    public function group($keys, array $initial, $reduce, array $condition = [])
787
    {
788
        if (is_string($reduce)) {
789
            $reduce = new MongoCode($reduce);
790
        }
791
792
        $command = [
793
            'group' => [
794
                'ns' => $this->name,
795
                '$reduce' => (string)$reduce,
796
                'initial' => $initial,
797
                'cond' => $condition,
798
            ],
799
        ];
800
801
        if ($keys instanceof MongoCode) {
802
            $command['group']['$keyf'] = (string)$keys;
803
        } else {
804
            $command['group']['key'] = $keys;
805
        }
806
        if (array_key_exists('condition', $condition)) {
807
            $command['group']['cond'] = $condition['condition'];
808
        }
809
        if (array_key_exists('finalize', $condition)) {
810
            if ($condition['finalize'] instanceof MongoCode) {
811
                $condition['finalize'] = (string)$condition['finalize'];
812
            }
813
            $command['group']['finalize'] = $condition['finalize'];
814
        }
815
816
        return $this->db->command($command);
817
    }
818
819
    /**
820
     * Returns an array of cursors to iterator over a full collection in parallel
821
     *
822
     * @link http://www.php.net/manual/en/mongocollection.parallelcollectionscan.php
823
     * @param int $num_cursors The number of cursors to request from the server. Please note, that the server can return less cursors than you requested.
824
     * @return MongoCommandCursor[]
825
     */
826
    public function parallelCollectionScan($num_cursors)
0 ignored issues
show
Unused Code introduced by
The parameter $num_cursors is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
827
    {
828
        $this->notImplemented();
829
    }
830
831
    protected function notImplemented()
832
    {
833
        throw new \Exception('Not implemented');
834
    }
835
836
    /**
837
     * @return \MongoDB\Collection
838
     */
839 View Code Duplication
    private function createCollectionObject()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
840
    {
841
        $options = [
842
            'readPreference' => $this->readPreference,
843
            'writeConcern' => $this->writeConcern,
844
        ];
845
846
        if ($this->collection === null) {
847
            $this->collection = $this->db->getDb()->selectCollection($this->name, $options);
848
        } else {
849
            $this->collection = $this->collection->withOptions($options);
850
        }
851
    }
852
853
    /**
854
     * Converts legacy write concern options to a WriteConcern object
855
     *
856
     * @param array $options
857
     * @return array
858
     */
859
    private function convertWriteConcernOptions(array $options)
860
    {
861
        if (isset($options['safe'])) {
862
            $options['w'] = ($options['safe']) ? 1 : 0;
863
        }
864
865
        if (isset($options['wtimeout']) && !isset($options['wTimeoutMS'])) {
866
            $options['wTimeoutMS'] = $options['wtimeout'];
867
        }
868
869
        if (isset($options['w']) || !isset($options['wTimeoutMS'])) {
870
            $collectionWriteConcern = $this->getWriteConcern();
871
            $writeConcern = $this->createWriteConcernFromParameters(
872
                isset($options['w']) ? $options['w'] : $collectionWriteConcern['w'],
873
                isset($options['wTimeoutMS']) ? $options['wTimeoutMS'] : $collectionWriteConcern['wtimeout']
874
            );
875
876
            $options['writeConcern'] = $writeConcern;
877
        }
878
879
        unset($options['safe']);
880
        unset($options['w']);
881
        unset($options['wTimeout']);
882
        unset($options['wTimeoutMS']);
883
884
        return $options;
885
    }
886
887
    /**
888
     * @param array|object $document
889
     * @return MongoId
890
     */
891
    private function ensureDocumentHasMongoId(&$document)
892
    {
893
        $checkKeys = function($array) {
894
            foreach (array_keys($array) as $key) {
895
                if (is_int($key) || empty($key) || strpos($key, '*') === 1) {
896
                    throw new \MongoException('document contain invalid key');
897
                }
898
            }
899
        };
900
901
        if (is_array($document)) {
902
            if (empty($document)) {
903
                throw new \MongoException('document cannot be empty');
904
            }
905
            if (! isset($document['_id'])) {
906
                $document['_id'] = new \MongoId();
907
            }
908
909
            $checkKeys($document);
910
911
            return $document['_id'];
912
        } elseif (is_object($document)) {
913
            if (empty((array) $document)) {
914
                throw new \MongoException('document cannot be empty');
915
            }
916
            if (! isset($document->_id)) {
917
                $document->_id = new \MongoId();
918
            }
919
920
            $checkKeys((array) $document);
921
922
            return $document->_id;
923
        }
924
925
        return null;
926
    }
927
928
    private function checkCollectionName($name)
929
    {
930
        if (empty($name)) {
931
            throw new Exception('Collection name cannot be empty');
932
        } elseif (strpos($name, chr(0)) !== false) {
933
            throw new Exception('Collection name cannot contain null bytes');
934
        }
935
    }
936
}
937
938