@@ -12,7 +12,8 @@ |
||
| 12 | 12 | header('Location: ' . $boardurl); |
| 13 | 13 | } |
| 14 | 14 | // Can't find it... just forget it. |
| 15 | -else |
|
| 15 | +else { |
|
| 16 | 16 | exit; |
| 17 | +} |
|
| 17 | 18 | |
| 18 | 19 | ?> |
| 19 | 20 | \ No newline at end of file |
@@ -523,7 +523,6 @@ discard block |
||
| 523 | 523 | /** |
| 524 | 524 | * Copy image. |
| 525 | 525 | * Used when imagecopyresample() is not available. |
| 526 | - |
|
| 527 | 526 | * @param resource $dst_img The destination image - a GD image resource |
| 528 | 527 | * @param resource $src_img The source image - a GD image resource |
| 529 | 528 | * @param int $dst_x The "x" coordinate of the destination image |
@@ -754,7 +753,6 @@ discard block |
||
| 754 | 753 | |
| 755 | 754 | /** |
| 756 | 755 | * Writes a gif file to disk as a png file. |
| 757 | - |
|
| 758 | 756 | * @param resource $gif A gif image resource |
| 759 | 757 | * @param string $lpszFileName The name of the file |
| 760 | 758 | * @param int $background_color The background color |
@@ -18,8 +18,9 @@ discard block |
||
| 18 | 18 | * @version 2.1 Beta 4 |
| 19 | 19 | */ |
| 20 | 20 | |
| 21 | -if (!defined('SMF')) |
|
| 21 | +if (!defined('SMF')) { |
|
| 22 | 22 | die('No direct access...'); |
| 23 | +} |
|
| 23 | 24 | |
| 24 | 25 | /** |
| 25 | 26 | * downloads a file from a url and stores it locally for avatar use by id_member. |
@@ -44,8 +45,9 @@ discard block |
||
| 44 | 45 | $destName = 'avatar_' . $memID . '_' . time() . '.' . $ext; |
| 45 | 46 | |
| 46 | 47 | // Just making sure there is a non-zero member. |
| 47 | - if (empty($memID)) |
|
| 48 | - return false; |
|
| 48 | + if (empty($memID)) { |
|
| 49 | + return false; |
|
| 50 | + } |
|
| 49 | 51 | |
| 50 | 52 | require_once($sourcedir . '/ManageAttachments.php'); |
| 51 | 53 | removeAttachments(array('id_member' => $memID)); |
@@ -76,10 +78,11 @@ discard block |
||
| 76 | 78 | $destName = $modSettings['custom_avatar_dir'] . '/' . $destName . '.tmp'; |
| 77 | 79 | |
| 78 | 80 | // Resize it. |
| 79 | - if (!empty($modSettings['avatar_download_png'])) |
|
| 80 | - $success = resizeImageFile($url, $destName, $max_width, $max_height, 3); |
|
| 81 | - else |
|
| 82 | - $success = resizeImageFile($url, $destName, $max_width, $max_height); |
|
| 81 | + if (!empty($modSettings['avatar_download_png'])) { |
|
| 82 | + $success = resizeImageFile($url, $destName, $max_width, $max_height, 3); |
|
| 83 | + } else { |
|
| 84 | + $success = resizeImageFile($url, $destName, $max_width, $max_height); |
|
| 85 | + } |
|
| 83 | 86 | |
| 84 | 87 | // Remove the .tmp extension. |
| 85 | 88 | $destName = substr($destName, 0, -4); |
@@ -108,11 +111,10 @@ discard block |
||
| 108 | 111 | ) |
| 109 | 112 | ); |
| 110 | 113 | return true; |
| 114 | + } else { |
|
| 115 | + return false; |
|
| 111 | 116 | } |
| 112 | - else |
|
| 113 | - return false; |
|
| 114 | - } |
|
| 115 | - else |
|
| 117 | + } else |
|
| 116 | 118 | { |
| 117 | 119 | $smcFunc['db_query']('', ' |
| 118 | 120 | DELETE FROM {db_prefix}attachments |
@@ -144,17 +146,18 @@ discard block |
||
| 144 | 146 | $destName = $source . '_thumb.tmp'; |
| 145 | 147 | |
| 146 | 148 | // Do the actual resize. |
| 147 | - if (!empty($modSettings['attachment_thumb_png'])) |
|
| 148 | - $success = resizeImageFile($source, $destName, $max_width, $max_height, 3); |
|
| 149 | - else |
|
| 150 | - $success = resizeImageFile($source, $destName, $max_width, $max_height); |
|
| 149 | + if (!empty($modSettings['attachment_thumb_png'])) { |
|
| 150 | + $success = resizeImageFile($source, $destName, $max_width, $max_height, 3); |
|
| 151 | + } else { |
|
| 152 | + $success = resizeImageFile($source, $destName, $max_width, $max_height); |
|
| 153 | + } |
|
| 151 | 154 | |
| 152 | 155 | // Okay, we're done with the temporary stuff. |
| 153 | 156 | $destName = substr($destName, 0, -4); |
| 154 | 157 | |
| 155 | - if ($success && @rename($destName . '.tmp', $destName)) |
|
| 156 | - return true; |
|
| 157 | - else |
|
| 158 | + if ($success && @rename($destName . '.tmp', $destName)) { |
|
| 159 | + return true; |
|
| 160 | + } else |
|
| 158 | 161 | { |
| 159 | 162 | @unlink($destName . '.tmp'); |
| 160 | 163 | @touch($destName); |
@@ -176,18 +179,21 @@ discard block |
||
| 176 | 179 | { |
| 177 | 180 | if (!resizeImageFile($fileName, $fileName . '.tmp', null, null, $preferred_format)) |
| 178 | 181 | { |
| 179 | - if (file_exists($fileName . '.tmp')) |
|
| 180 | - unlink($fileName . '.tmp'); |
|
| 182 | + if (file_exists($fileName . '.tmp')) { |
|
| 183 | + unlink($fileName . '.tmp'); |
|
| 184 | + } |
|
| 181 | 185 | |
| 182 | 186 | return false; |
| 183 | 187 | } |
| 184 | 188 | |
| 185 | - if (!unlink($fileName)) |
|
| 186 | - return false; |
|
| 189 | + if (!unlink($fileName)) { |
|
| 190 | + return false; |
|
| 191 | + } |
|
| 187 | 192 | |
| 188 | - if (!rename($fileName . '.tmp', $fileName)) |
|
| 189 | - return false; |
|
| 190 | -} |
|
| 193 | + if (!rename($fileName . '.tmp', $fileName)) { |
|
| 194 | + return false; |
|
| 195 | + } |
|
| 196 | + } |
|
| 191 | 197 | |
| 192 | 198 | /** |
| 193 | 199 | * Searches through the file to see if there's potentially harmful non-binary content. |
@@ -200,8 +206,9 @@ discard block |
||
| 200 | 206 | function checkImageContents($fileName, $extensiveCheck = false) |
| 201 | 207 | { |
| 202 | 208 | $fp = fopen($fileName, 'rb'); |
| 203 | - if (!$fp) |
|
| 204 | - fatal_lang_error('attach_timeout'); |
|
| 209 | + if (!$fp) { |
|
| 210 | + fatal_lang_error('attach_timeout'); |
|
| 211 | + } |
|
| 205 | 212 | |
| 206 | 213 | $prev_chunk = ''; |
| 207 | 214 | while (!feof($fp)) |
@@ -218,8 +225,7 @@ discard block |
||
| 218 | 225 | fclose($fp); |
| 219 | 226 | return false; |
| 220 | 227 | } |
| 221 | - } |
|
| 222 | - else |
|
| 228 | + } else |
|
| 223 | 229 | { |
| 224 | 230 | // Check for potential infection - focus on clues for inline php & flash. |
| 225 | 231 | // Will result in significantly fewer false positives than the paranoid check. |
@@ -247,8 +253,9 @@ discard block |
||
| 247 | 253 | global $gd2; |
| 248 | 254 | |
| 249 | 255 | // Check to see if GD is installed and what version. |
| 250 | - if (($extensionFunctions = get_extension_funcs('gd')) === false) |
|
| 251 | - return false; |
|
| 256 | + if (($extensionFunctions = get_extension_funcs('gd')) === false) { |
|
| 257 | + return false; |
|
| 258 | + } |
|
| 252 | 259 | |
| 253 | 260 | // Also determine if GD2 is installed and store it in a global. |
| 254 | 261 | $gd2 = in_array('imagecreatetruecolor', $extensionFunctions) && function_exists('imagecreatetruecolor'); |
@@ -320,8 +327,9 @@ discard block |
||
| 320 | 327 | global $sourcedir; |
| 321 | 328 | |
| 322 | 329 | // Nothing to do without GD or IM/MW |
| 323 | - if (!checkGD() && !checkImagick() && !checkMagickWand()) |
|
| 324 | - return false; |
|
| 330 | + if (!checkGD() && !checkImagick() && !checkMagickWand()) { |
|
| 331 | + return false; |
|
| 332 | + } |
|
| 325 | 333 | |
| 326 | 334 | static $default_formats = array( |
| 327 | 335 | '1' => 'gif', |
@@ -343,38 +351,39 @@ discard block |
||
| 343 | 351 | fclose($fp_destination); |
| 344 | 352 | |
| 345 | 353 | $sizes = @getimagesize($destination); |
| 346 | - } |
|
| 347 | - elseif ($fp_destination) |
|
| 354 | + } elseif ($fp_destination) |
|
| 348 | 355 | { |
| 349 | 356 | $sizes = @getimagesize($source); |
| 350 | 357 | |
| 351 | 358 | $fp_source = fopen($source, 'rb'); |
| 352 | 359 | if ($fp_source !== false) |
| 353 | 360 | { |
| 354 | - while (!feof($fp_source)) |
|
| 355 | - fwrite($fp_destination, fread($fp_source, 8192)); |
|
| 361 | + while (!feof($fp_source)) { |
|
| 362 | + fwrite($fp_destination, fread($fp_source, 8192)); |
|
| 363 | + } |
|
| 356 | 364 | fclose($fp_source); |
| 365 | + } else { |
|
| 366 | + $sizes = array(-1, -1, -1); |
|
| 357 | 367 | } |
| 358 | - else |
|
| 359 | - $sizes = array(-1, -1, -1); |
|
| 360 | 368 | fclose($fp_destination); |
| 361 | 369 | } |
| 362 | 370 | // We can't get to the file. |
| 363 | - else |
|
| 364 | - $sizes = array(-1, -1, -1); |
|
| 371 | + else { |
|
| 372 | + $sizes = array(-1, -1, -1); |
|
| 373 | + } |
|
| 365 | 374 | |
| 366 | 375 | // See if we have -or- can get the needed memory for this operation |
| 367 | 376 | // ImageMagick isn't subject to PHP's memory limits :) |
| 368 | - if (!(checkIMagick() || checkMagickWand()) && checkGD() && !imageMemoryCheck($sizes)) |
|
| 369 | - return false; |
|
| 377 | + if (!(checkIMagick() || checkMagickWand()) && checkGD() && !imageMemoryCheck($sizes)) { |
|
| 378 | + return false; |
|
| 379 | + } |
|
| 370 | 380 | |
| 371 | 381 | // A known and supported format? |
| 372 | 382 | // @todo test PSD and gif. |
| 373 | 383 | if ((checkImagick() || checkMagickWand()) && isset($default_formats[$sizes[2]])) |
| 374 | 384 | { |
| 375 | 385 | return resizeImage(null, $destination, null, null, $max_width, $max_height, true, $preferred_format); |
| 376 | - } |
|
| 377 | - elseif (checkGD() && isset($default_formats[$sizes[2]]) && function_exists('imagecreatefrom' . $default_formats[$sizes[2]])) |
|
| 386 | + } elseif (checkGD() && isset($default_formats[$sizes[2]]) && function_exists('imagecreatefrom' . $default_formats[$sizes[2]])) |
|
| 378 | 387 | { |
| 379 | 388 | $imagecreatefrom = 'imagecreatefrom' . $default_formats[$sizes[2]]; |
| 380 | 389 | if ($src_img = @$imagecreatefrom($destination)) |
@@ -427,14 +436,14 @@ discard block |
||
| 427 | 436 | $dest_width = empty($max_width) ? $src_width : $max_width; |
| 428 | 437 | $dest_height = empty($max_height) ? $src_height : $max_height; |
| 429 | 438 | |
| 430 | - if ($default_formats[$preferred_format] == 'jpeg') |
|
| 431 | - $imagick->setCompressionQuality(!empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 439 | + if ($default_formats[$preferred_format] == 'jpeg') { |
|
| 440 | + $imagick->setCompressionQuality(!empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 441 | + } |
|
| 432 | 442 | |
| 433 | 443 | $imagick->setImageFormat($default_formats[$preferred_format]); |
| 434 | 444 | $imagick->resizeImage($dest_width, $dest_height, Imagick::FILTER_LANCZOS, 1, true); |
| 435 | 445 | $success = $imagick->writeImage($destName); |
| 436 | - } |
|
| 437 | - else |
|
| 446 | + } else |
|
| 438 | 447 | { |
| 439 | 448 | $magick_wand = newMagickWand(); |
| 440 | 449 | MagickReadImage($magick_wand, $destName); |
@@ -443,8 +452,9 @@ discard block |
||
| 443 | 452 | $dest_width = empty($max_width) ? $src_width : $max_width; |
| 444 | 453 | $dest_height = empty($max_height) ? $src_height : $max_height; |
| 445 | 454 | |
| 446 | - if ($default_formats[$preferred_format] == 'jpeg') |
|
| 447 | - MagickSetCompressionQuality($magick_wand, !empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 455 | + if ($default_formats[$preferred_format] == 'jpeg') { |
|
| 456 | + MagickSetCompressionQuality($magick_wand, !empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 457 | + } |
|
| 448 | 458 | |
| 449 | 459 | MagickSetImageFormat($magick_wand, $default_formats[$preferred_format]); |
| 450 | 460 | MagickResizeImage($magick_wand, $dest_width, $dest_height, MW_LanczosFilter, 1, true); |
@@ -452,8 +462,7 @@ discard block |
||
| 452 | 462 | } |
| 453 | 463 | |
| 454 | 464 | return !empty($success); |
| 455 | - } |
|
| 456 | - elseif (checkGD()) |
|
| 465 | + } elseif (checkGD()) |
|
| 457 | 466 | { |
| 458 | 467 | $success = false; |
| 459 | 468 | |
@@ -464,8 +473,7 @@ discard block |
||
| 464 | 473 | { |
| 465 | 474 | $dst_width = $max_width; |
| 466 | 475 | $dst_height = round($src_height * $max_width / $src_width); |
| 467 | - } |
|
| 468 | - elseif (!empty($max_height)) |
|
| 476 | + } elseif (!empty($max_height)) |
|
| 469 | 477 | { |
| 470 | 478 | $dst_width = round($src_width * $max_height / $src_height); |
| 471 | 479 | $dst_height = $max_height; |
@@ -483,44 +491,48 @@ discard block |
||
| 483 | 491 | if ((!empty($preferred_format)) && ($preferred_format == 3)) |
| 484 | 492 | { |
| 485 | 493 | imagealphablending($dst_img, false); |
| 486 | - if (function_exists('imagesavealpha')) |
|
| 487 | - imagesavealpha($dst_img, true); |
|
| 494 | + if (function_exists('imagesavealpha')) { |
|
| 495 | + imagesavealpha($dst_img, true); |
|
| 496 | + } |
|
| 488 | 497 | } |
| 498 | + } else { |
|
| 499 | + $dst_img = imagecreate($dst_width, $dst_height); |
|
| 489 | 500 | } |
| 490 | - else |
|
| 491 | - $dst_img = imagecreate($dst_width, $dst_height); |
|
| 492 | 501 | |
| 493 | 502 | // Resize it! |
| 494 | - if ($gd2) |
|
| 495 | - imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $dst_width, $dst_height, $src_width, $src_height); |
|
| 496 | - else |
|
| 497 | - imagecopyresamplebicubic($dst_img, $src_img, 0, 0, 0, 0, $dst_width, $dst_height, $src_width, $src_height); |
|
| 503 | + if ($gd2) { |
|
| 504 | + imagecopyresampled($dst_img, $src_img, 0, 0, 0, 0, $dst_width, $dst_height, $src_width, $src_height); |
|
| 505 | + } else { |
|
| 506 | + imagecopyresamplebicubic($dst_img, $src_img, 0, 0, 0, 0, $dst_width, $dst_height, $src_width, $src_height); |
|
| 507 | + } |
|
| 508 | + } else { |
|
| 509 | + $dst_img = $src_img; |
|
| 498 | 510 | } |
| 499 | - else |
|
| 500 | - $dst_img = $src_img; |
|
| 511 | + } else { |
|
| 512 | + $dst_img = $src_img; |
|
| 501 | 513 | } |
| 502 | - else |
|
| 503 | - $dst_img = $src_img; |
|
| 504 | 514 | |
| 505 | 515 | // Save the image as ... |
| 506 | - if (!empty($preferred_format) && ($preferred_format == 3) && function_exists('imagepng')) |
|
| 507 | - $success = imagepng($dst_img, $destName); |
|
| 508 | - elseif (!empty($preferred_format) && ($preferred_format == 1) && function_exists('imagegif')) |
|
| 509 | - $success = imagegif($dst_img, $destName); |
|
| 510 | - elseif (function_exists('imagejpeg')) |
|
| 511 | - $success = imagejpeg($dst_img, $destName, !empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 516 | + if (!empty($preferred_format) && ($preferred_format == 3) && function_exists('imagepng')) { |
|
| 517 | + $success = imagepng($dst_img, $destName); |
|
| 518 | + } elseif (!empty($preferred_format) && ($preferred_format == 1) && function_exists('imagegif')) { |
|
| 519 | + $success = imagegif($dst_img, $destName); |
|
| 520 | + } elseif (function_exists('imagejpeg')) { |
|
| 521 | + $success = imagejpeg($dst_img, $destName, !empty($modSettings['avatar_jpeg_quality']) ? $modSettings['avatar_jpeg_quality'] : 82); |
|
| 522 | + } |
|
| 512 | 523 | |
| 513 | 524 | // Free the memory. |
| 514 | 525 | imagedestroy($src_img); |
| 515 | - if ($dst_img != $src_img) |
|
| 516 | - imagedestroy($dst_img); |
|
| 526 | + if ($dst_img != $src_img) { |
|
| 527 | + imagedestroy($dst_img); |
|
| 528 | + } |
|
| 517 | 529 | |
| 518 | 530 | return $success; |
| 519 | - } |
|
| 520 | - else |
|
| 521 | - // Without GD, no image resizing at all. |
|
| 531 | + } else { |
|
| 532 | + // Without GD, no image resizing at all. |
|
| 522 | 533 | return false; |
| 523 | -} |
|
| 534 | + } |
|
| 535 | + } |
|
| 524 | 536 | |
| 525 | 537 | /** |
| 526 | 538 | * Copy image. |
@@ -574,8 +586,9 @@ discard block |
||
| 574 | 586 | $color = imagecolorresolve($dst_img, $red, $green, $blue); |
| 575 | 587 | if ($color == -1) |
| 576 | 588 | { |
| 577 | - if ($palsize++ < 256) |
|
| 578 | - imagecolorallocate($dst_img, $red, $green, $blue); |
|
| 589 | + if ($palsize++ < 256) { |
|
| 590 | + imagecolorallocate($dst_img, $red, $green, $blue); |
|
| 591 | + } |
|
| 579 | 592 | $color = imagecolorclosest($dst_img, $red, $green, $blue); |
| 580 | 593 | } |
| 581 | 594 | |
@@ -605,13 +618,15 @@ discard block |
||
| 605 | 618 | $header = unpack('vtype/Vsize/Vreserved/Voffset', fread($fp, 14)); |
| 606 | 619 | $info = unpack('Vsize/Vwidth/Vheight/vplanes/vbits/Vcompression/Vimagesize/Vxres/Vyres/Vncolor/Vcolorimportant', fread($fp, 40)); |
| 607 | 620 | |
| 608 | - if ($header['type'] != 0x4D42) |
|
| 609 | - return false; |
|
| 621 | + if ($header['type'] != 0x4D42) { |
|
| 622 | + return false; |
|
| 623 | + } |
|
| 610 | 624 | |
| 611 | - if ($gd2) |
|
| 612 | - $dst_img = imagecreatetruecolor($info['width'], $info['height']); |
|
| 613 | - else |
|
| 614 | - $dst_img = imagecreate($info['width'], $info['height']); |
|
| 625 | + if ($gd2) { |
|
| 626 | + $dst_img = imagecreatetruecolor($info['width'], $info['height']); |
|
| 627 | + } else { |
|
| 628 | + $dst_img = imagecreate($info['width'], $info['height']); |
|
| 629 | + } |
|
| 615 | 630 | |
| 616 | 631 | $palette_size = $header['offset'] - 54; |
| 617 | 632 | $info['ncolor'] = $palette_size / 4; |
@@ -637,8 +652,9 @@ discard block |
||
| 637 | 652 | fseek($fp, $header['offset'] + ($scan_line_size + $scan_line_align) * $l); |
| 638 | 653 | $scan_line = fread($fp, $scan_line_size); |
| 639 | 654 | |
| 640 | - if (strlen($scan_line) < $scan_line_size) |
|
| 641 | - continue; |
|
| 655 | + if (strlen($scan_line) < $scan_line_size) { |
|
| 656 | + continue; |
|
| 657 | + } |
|
| 642 | 658 | |
| 643 | 659 | if ($info['bits'] == 32) |
| 644 | 660 | { |
@@ -656,14 +672,14 @@ discard block |
||
| 656 | 672 | $color = imagecolorallocate($dst_img, $r, $g, $b); |
| 657 | 673 | |
| 658 | 674 | // Gah! Out of colors? Stupid GD 1... try anyhow. |
| 659 | - if ($color == -1) |
|
| 660 | - $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 675 | + if ($color == -1) { |
|
| 676 | + $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 677 | + } |
|
| 661 | 678 | } |
| 662 | 679 | |
| 663 | 680 | imagesetpixel($dst_img, $x, $y, $color); |
| 664 | 681 | } |
| 665 | - } |
|
| 666 | - elseif ($info['bits'] == 24) |
|
| 682 | + } elseif ($info['bits'] == 24) |
|
| 667 | 683 | { |
| 668 | 684 | $x = 0; |
| 669 | 685 | for ($j = 0; $j < $scan_line_size; $x++) |
@@ -678,14 +694,14 @@ discard block |
||
| 678 | 694 | $color = imagecolorallocate($dst_img, $r, $g, $b); |
| 679 | 695 | |
| 680 | 696 | // Gah! Out of colors? Stupid GD 1... try anyhow. |
| 681 | - if ($color == -1) |
|
| 682 | - $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 697 | + if ($color == -1) { |
|
| 698 | + $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 699 | + } |
|
| 683 | 700 | } |
| 684 | 701 | |
| 685 | 702 | imagesetpixel($dst_img, $x, $y, $color); |
| 686 | 703 | } |
| 687 | - } |
|
| 688 | - elseif ($info['bits'] == 16) |
|
| 704 | + } elseif ($info['bits'] == 16) |
|
| 689 | 705 | { |
| 690 | 706 | $x = 0; |
| 691 | 707 | for ($j = 0; $j < $scan_line_size; $x++) |
@@ -706,20 +722,20 @@ discard block |
||
| 706 | 722 | $color = imagecolorallocate($dst_img, $r, $g, $b); |
| 707 | 723 | |
| 708 | 724 | // Gah! Out of colors? Stupid GD 1... try anyhow. |
| 709 | - if ($color == -1) |
|
| 710 | - $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 725 | + if ($color == -1) { |
|
| 726 | + $color = imagecolorclosest($dst_img, $r, $g, $b); |
|
| 727 | + } |
|
| 711 | 728 | } |
| 712 | 729 | |
| 713 | 730 | imagesetpixel($dst_img, $x, $y, $color); |
| 714 | 731 | } |
| 715 | - } |
|
| 716 | - elseif ($info['bits'] == 8) |
|
| 732 | + } elseif ($info['bits'] == 8) |
|
| 717 | 733 | { |
| 718 | 734 | $x = 0; |
| 719 | - for ($j = 0; $j < $scan_line_size; $x++) |
|
| 720 | - imagesetpixel($dst_img, $x, $y, $palette[ord($scan_line{$j++})]); |
|
| 721 | - } |
|
| 722 | - elseif ($info['bits'] == 4) |
|
| 735 | + for ($j = 0; $j < $scan_line_size; $x++) { |
|
| 736 | + imagesetpixel($dst_img, $x, $y, $palette[ord($scan_line{$j++})]); |
|
| 737 | + } |
|
| 738 | + } elseif ($info['bits'] == 4) |
|
| 723 | 739 | { |
| 724 | 740 | $x = 0; |
| 725 | 741 | for ($j = 0; $j < $scan_line_size; $x++) |
@@ -727,11 +743,11 @@ discard block |
||
| 727 | 743 | $byte = ord($scan_line{$j++}); |
| 728 | 744 | |
| 729 | 745 | imagesetpixel($dst_img, $x, $y, $palette[(int) ($byte / 16)]); |
| 730 | - if (++$x < $info['width']) |
|
| 731 | - imagesetpixel($dst_img, $x, $y, $palette[$byte & 15]); |
|
| 746 | + if (++$x < $info['width']) { |
|
| 747 | + imagesetpixel($dst_img, $x, $y, $palette[$byte & 15]); |
|
| 748 | + } |
|
| 732 | 749 | } |
| 733 | - } |
|
| 734 | - elseif ($info['bits'] == 1) |
|
| 750 | + } elseif ($info['bits'] == 1) |
|
| 735 | 751 | { |
| 736 | 752 | $x = 0; |
| 737 | 753 | for ($j = 0; $j < $scan_line_size; $x++) |
@@ -740,7 +756,9 @@ discard block |
||
| 740 | 756 | |
| 741 | 757 | imagesetpixel($dst_img, $x, $y, $palette[(($byte) & 128) != 0]); |
| 742 | 758 | for ($shift = 1; $shift < 8; $shift++) { |
| 743 | - if (++$x < $info['width']) imagesetpixel($dst_img, $x, $y, $palette[(($byte << $shift) & 128) != 0]); |
|
| 759 | + if (++$x < $info['width']) { |
|
| 760 | + imagesetpixel($dst_img, $x, $y, $palette[(($byte << $shift) & 128) != 0]); |
|
| 761 | + } |
|
| 744 | 762 | } |
| 745 | 763 | } |
| 746 | 764 | } |
@@ -764,15 +782,18 @@ discard block |
||
| 764 | 782 | */ |
| 765 | 783 | function gif_outputAsPng($gif, $lpszFileName, $background_color = -1) |
| 766 | 784 | { |
| 767 | - if (!isset($gif) || @get_class($gif) != 'cgif' || !$gif->loaded || $lpszFileName == '') |
|
| 768 | - return false; |
|
| 785 | + if (!isset($gif) || @get_class($gif) != 'cgif' || !$gif->loaded || $lpszFileName == '') { |
|
| 786 | + return false; |
|
| 787 | + } |
|
| 769 | 788 | |
| 770 | 789 | $fd = $gif->get_png_data($background_color); |
| 771 | - if (strlen($fd) <= 0) |
|
| 772 | - return false; |
|
| 790 | + if (strlen($fd) <= 0) { |
|
| 791 | + return false; |
|
| 792 | + } |
|
| 773 | 793 | |
| 774 | - if (!($fh = @fopen($lpszFileName, 'wb'))) |
|
| 775 | - return false; |
|
| 794 | + if (!($fh = @fopen($lpszFileName, 'wb'))) { |
|
| 795 | + return false; |
|
| 796 | + } |
|
| 776 | 797 | |
| 777 | 798 | @fwrite($fh, $fd, strlen($fd)); |
| 778 | 799 | @fflush($fh); |
@@ -799,8 +820,9 @@ discard block |
||
| 799 | 820 | // What type are we going to be doing? |
| 800 | 821 | $imageType = $modSettings['visual_verification_type']; |
| 801 | 822 | // Special case to allow the admin center to show samples. |
| 802 | - if ($user_info['is_admin'] && isset($_GET['type'])) |
|
| 803 | - $imageType = (int) $_GET['type']; |
|
| 823 | + if ($user_info['is_admin'] && isset($_GET['type'])) { |
|
| 824 | + $imageType = (int) $_GET['type']; |
|
| 825 | + } |
|
| 804 | 826 | |
| 805 | 827 | // Some quick references for what we do. |
| 806 | 828 | // Do we show no, low or high noise? |
@@ -834,25 +856,28 @@ discard block |
||
| 834 | 856 | $character_spacing = 1; |
| 835 | 857 | |
| 836 | 858 | // What color is the background - generally white unless we're on "hard". |
| 837 | - if ($simpleBGColor) |
|
| 838 | - $background_color = array(255, 255, 255); |
|
| 839 | - else |
|
| 840 | - $background_color = isset($settings['verification_background']) ? $settings['verification_background'] : array(236, 237, 243); |
|
| 859 | + if ($simpleBGColor) { |
|
| 860 | + $background_color = array(255, 255, 255); |
|
| 861 | + } else { |
|
| 862 | + $background_color = isset($settings['verification_background']) ? $settings['verification_background'] : array(236, 237, 243); |
|
| 863 | + } |
|
| 841 | 864 | |
| 842 | 865 | // The color of the characters shown (red, green, blue). |
| 843 | - if ($simpleFGColor) |
|
| 844 | - $foreground_color = array(0, 0, 0); |
|
| 845 | - else |
|
| 866 | + if ($simpleFGColor) { |
|
| 867 | + $foreground_color = array(0, 0, 0); |
|
| 868 | + } else |
|
| 846 | 869 | { |
| 847 | 870 | $foreground_color = array(64, 101, 136); |
| 848 | 871 | |
| 849 | 872 | // Has the theme author requested a custom color? |
| 850 | - if (isset($settings['verification_foreground'])) |
|
| 851 | - $foreground_color = $settings['verification_foreground']; |
|
| 873 | + if (isset($settings['verification_foreground'])) { |
|
| 874 | + $foreground_color = $settings['verification_foreground']; |
|
| 875 | + } |
|
| 852 | 876 | } |
| 853 | 877 | |
| 854 | - if (!is_dir($settings['default_theme_dir'] . '/fonts')) |
|
| 855 | - return false; |
|
| 878 | + if (!is_dir($settings['default_theme_dir'] . '/fonts')) { |
|
| 879 | + return false; |
|
| 880 | + } |
|
| 856 | 881 | |
| 857 | 882 | // Get a list of the available fonts. |
| 858 | 883 | $font_dir = dir($settings['default_theme_dir'] . '/fonts'); |
@@ -863,25 +888,28 @@ discard block |
||
| 863 | 888 | { |
| 864 | 889 | if (preg_match('~^(.+)\.gdf$~', $entry, $matches) === 1) |
| 865 | 890 | { |
| 866 | - if ($endian ^ (strpos($entry, '_end.gdf') === false)) |
|
| 867 | - $font_list[] = $entry; |
|
| 891 | + if ($endian ^ (strpos($entry, '_end.gdf') === false)) { |
|
| 892 | + $font_list[] = $entry; |
|
| 893 | + } |
|
| 894 | + } elseif (preg_match('~^(.+)\.ttf$~', $entry, $matches) === 1) { |
|
| 895 | + $ttfont_list[] = $entry; |
|
| 868 | 896 | } |
| 869 | - elseif (preg_match('~^(.+)\.ttf$~', $entry, $matches) === 1) |
|
| 870 | - $ttfont_list[] = $entry; |
|
| 871 | 897 | } |
| 872 | 898 | |
| 873 | - if (empty($font_list)) |
|
| 874 | - return false; |
|
| 899 | + if (empty($font_list)) { |
|
| 900 | + return false; |
|
| 901 | + } |
|
| 875 | 902 | |
| 876 | 903 | // For non-hard things don't even change fonts. |
| 877 | 904 | if (!$varyFonts) |
| 878 | 905 | { |
| 879 | 906 | $font_list = array($font_list[0]); |
| 880 | 907 | // Try use Screenge if we can - it looks good! |
| 881 | - if (in_array('AnonymousPro.ttf', $ttfont_list)) |
|
| 882 | - $ttfont_list = array('AnonymousPro.ttf'); |
|
| 883 | - else |
|
| 884 | - $ttfont_list = empty($ttfont_list) ? array() : array($ttfont_list[0]); |
|
| 908 | + if (in_array('AnonymousPro.ttf', $ttfont_list)) { |
|
| 909 | + $ttfont_list = array('AnonymousPro.ttf'); |
|
| 910 | + } else { |
|
| 911 | + $ttfont_list = empty($ttfont_list) ? array() : array($ttfont_list[0]); |
|
| 912 | + } |
|
| 885 | 913 | |
| 886 | 914 | } |
| 887 | 915 | |
@@ -899,14 +927,16 @@ discard block |
||
| 899 | 927 | } |
| 900 | 928 | |
| 901 | 929 | // Load all fonts and determine the maximum font height. |
| 902 | - foreach ($loaded_fonts as $font_index => $dummy) |
|
| 903 | - $loaded_fonts[$font_index] = imageloadfont($settings['default_theme_dir'] . '/fonts/' . $font_list[$font_index]); |
|
| 930 | + foreach ($loaded_fonts as $font_index => $dummy) { |
|
| 931 | + $loaded_fonts[$font_index] = imageloadfont($settings['default_theme_dir'] . '/fonts/' . $font_list[$font_index]); |
|
| 932 | + } |
|
| 904 | 933 | |
| 905 | 934 | // Determine the dimensions of each character. |
| 906 | - if ($imageType == 4 || $imageType == 5) |
|
| 907 | - $extra = 80; |
|
| 908 | - else |
|
| 909 | - $extra = 45; |
|
| 935 | + if ($imageType == 4 || $imageType == 5) { |
|
| 936 | + $extra = 80; |
|
| 937 | + } else { |
|
| 938 | + $extra = 45; |
|
| 939 | + } |
|
| 910 | 940 | |
| 911 | 941 | $total_width = $character_spacing * strlen($code) + $extra; |
| 912 | 942 | $max_height = 0; |
@@ -927,13 +957,15 @@ discard block |
||
| 927 | 957 | imagefilledrectangle($code_image, 0, 0, $total_width - 1, $max_height - 1, $bg_color); |
| 928 | 958 | |
| 929 | 959 | // Randomize the foreground color a little. |
| 930 | - for ($i = 0; $i < 3; $i++) |
|
| 931 | - $foreground_color[$i] = mt_rand(max($foreground_color[$i] - 3, 0), min($foreground_color[$i] + 3, 255)); |
|
| 960 | + for ($i = 0; $i < 3; $i++) { |
|
| 961 | + $foreground_color[$i] = mt_rand(max($foreground_color[$i] - 3, 0), min($foreground_color[$i] + 3, 255)); |
|
| 962 | + } |
|
| 932 | 963 | $fg_color = imagecolorallocate($code_image, $foreground_color[0], $foreground_color[1], $foreground_color[2]); |
| 933 | 964 | |
| 934 | 965 | // Color for the dots. |
| 935 | - for ($i = 0; $i < 3; $i++) |
|
| 936 | - $dotbgcolor[$i] = $background_color[$i] < $foreground_color[$i] ? mt_rand(0, max($foreground_color[$i] - 20, 0)) : mt_rand(min($foreground_color[$i] + 20, 255), 255); |
|
| 966 | + for ($i = 0; $i < 3; $i++) { |
|
| 967 | + $dotbgcolor[$i] = $background_color[$i] < $foreground_color[$i] ? mt_rand(0, max($foreground_color[$i] - 20, 0)) : mt_rand(min($foreground_color[$i] + 20, 255), 255); |
|
| 968 | + } |
|
| 937 | 969 | $randomness_color = imagecolorallocate($code_image, $dotbgcolor[0], $dotbgcolor[1], $dotbgcolor[2]); |
| 938 | 970 | |
| 939 | 971 | // Some squares/rectanges for new extreme level |
@@ -959,10 +991,11 @@ discard block |
||
| 959 | 991 | $can_do_ttf = function_exists('imagettftext'); |
| 960 | 992 | |
| 961 | 993 | // How much rotation will we give? |
| 962 | - if ($rotationType == 'none') |
|
| 963 | - $angle = 0; |
|
| 964 | - else |
|
| 965 | - $angle = mt_rand(-100, 100) / ($rotationType == 'high' ? 6 : 10); |
|
| 994 | + if ($rotationType == 'none') { |
|
| 995 | + $angle = 0; |
|
| 996 | + } else { |
|
| 997 | + $angle = mt_rand(-100, 100) / ($rotationType == 'high' ? 6 : 10); |
|
| 998 | + } |
|
| 966 | 999 | |
| 967 | 1000 | // What color shall we do it? |
| 968 | 1001 | if ($fontColorType == 'cyclic') |
@@ -976,51 +1009,56 @@ discard block |
||
| 976 | 1009 | array(0, 0, 0), |
| 977 | 1010 | array(143, 39, 31), |
| 978 | 1011 | ); |
| 979 | - if (!isset($last_index)) |
|
| 980 | - $last_index = -1; |
|
| 1012 | + if (!isset($last_index)) { |
|
| 1013 | + $last_index = -1; |
|
| 1014 | + } |
|
| 981 | 1015 | $new_index = $last_index; |
| 982 | - while ($last_index == $new_index) |
|
| 983 | - $new_index = mt_rand(0, count($colors) - 1); |
|
| 1016 | + while ($last_index == $new_index) { |
|
| 1017 | + $new_index = mt_rand(0, count($colors) - 1); |
|
| 1018 | + } |
|
| 984 | 1019 | $char_fg_color = $colors[$new_index]; |
| 985 | 1020 | $last_index = $new_index; |
| 1021 | + } elseif ($fontColorType == 'random') { |
|
| 1022 | + $char_fg_color = array(mt_rand(max($foreground_color[0] - 2, 0), $foreground_color[0]), mt_rand(max($foreground_color[1] - 2, 0), $foreground_color[1]), mt_rand(max($foreground_color[2] - 2, 0), $foreground_color[2])); |
|
| 1023 | + } else { |
|
| 1024 | + $char_fg_color = array($foreground_color[0], $foreground_color[1], $foreground_color[2]); |
|
| 986 | 1025 | } |
| 987 | - elseif ($fontColorType == 'random') |
|
| 988 | - $char_fg_color = array(mt_rand(max($foreground_color[0] - 2, 0), $foreground_color[0]), mt_rand(max($foreground_color[1] - 2, 0), $foreground_color[1]), mt_rand(max($foreground_color[2] - 2, 0), $foreground_color[2])); |
|
| 989 | - else |
|
| 990 | - $char_fg_color = array($foreground_color[0], $foreground_color[1], $foreground_color[2]); |
|
| 991 | 1026 | |
| 992 | 1027 | if (!empty($can_do_ttf)) |
| 993 | 1028 | { |
| 994 | 1029 | // GD2 handles font size differently. |
| 995 | - if ($fontSizeRandom) |
|
| 996 | - $font_size = $gd2 ? mt_rand(17, 19) : mt_rand(18, 25); |
|
| 997 | - else |
|
| 998 | - $font_size = $gd2 ? 18 : 24; |
|
| 1030 | + if ($fontSizeRandom) { |
|
| 1031 | + $font_size = $gd2 ? mt_rand(17, 19) : mt_rand(18, 25); |
|
| 1032 | + } else { |
|
| 1033 | + $font_size = $gd2 ? 18 : 24; |
|
| 1034 | + } |
|
| 999 | 1035 | |
| 1000 | 1036 | // Work out the sizes - also fix the character width cause TTF not quite so wide! |
| 1001 | 1037 | $font_x = $fontHorSpace == 'minus' && $cur_x > 0 ? $cur_x - 3 : $cur_x + 5; |
| 1002 | 1038 | $font_y = $max_height - ($fontVerPos == 'vrandom' ? mt_rand(2, 8) : ($fontVerPos == 'random' ? mt_rand(3, 5) : 5)); |
| 1003 | 1039 | |
| 1004 | 1040 | // What font face? |
| 1005 | - if (!empty($ttfont_list)) |
|
| 1006 | - $fontface = $settings['default_theme_dir'] . '/fonts/' . $ttfont_list[mt_rand(0, count($ttfont_list) - 1)]; |
|
| 1041 | + if (!empty($ttfont_list)) { |
|
| 1042 | + $fontface = $settings['default_theme_dir'] . '/fonts/' . $ttfont_list[mt_rand(0, count($ttfont_list) - 1)]; |
|
| 1043 | + } |
|
| 1007 | 1044 | |
| 1008 | 1045 | // What color are we to do it in? |
| 1009 | 1046 | $is_reverse = $showReverseChars ? mt_rand(0, 1) : false; |
| 1010 | 1047 | $char_color = function_exists('imagecolorallocatealpha') && $fontTrans ? imagecolorallocatealpha($code_image, $char_fg_color[0], $char_fg_color[1], $char_fg_color[2], 50) : imagecolorallocate($code_image, $char_fg_color[0], $char_fg_color[1], $char_fg_color[2]); |
| 1011 | 1048 | |
| 1012 | 1049 | $fontcord = @imagettftext($code_image, $font_size, $angle, $font_x, $font_y, $char_color, $fontface, $character['id']); |
| 1013 | - if (empty($fontcord)) |
|
| 1014 | - $can_do_ttf = false; |
|
| 1015 | - elseif ($is_reverse) |
|
| 1050 | + if (empty($fontcord)) { |
|
| 1051 | + $can_do_ttf = false; |
|
| 1052 | + } elseif ($is_reverse) |
|
| 1016 | 1053 | { |
| 1017 | 1054 | imagefilledpolygon($code_image, $fontcord, 4, $fg_color); |
| 1018 | 1055 | // Put the character back! |
| 1019 | 1056 | imagettftext($code_image, $font_size, $angle, $font_x, $font_y, $randomness_color, $fontface, $character['id']); |
| 1020 | 1057 | } |
| 1021 | 1058 | |
| 1022 | - if ($can_do_ttf) |
|
| 1023 | - $cur_x = max($fontcord[2], $fontcord[4]) + ($angle == 0 ? 0 : 3); |
|
| 1059 | + if ($can_do_ttf) { |
|
| 1060 | + $cur_x = max($fontcord[2], $fontcord[4]) + ($angle == 0 ? 0 : 3); |
|
| 1061 | + } |
|
| 1024 | 1062 | } |
| 1025 | 1063 | |
| 1026 | 1064 | if (!$can_do_ttf) |
@@ -1039,8 +1077,9 @@ discard block |
||
| 1039 | 1077 | } |
| 1040 | 1078 | |
| 1041 | 1079 | // Sorry, no rotation available. |
| 1042 | - else |
|
| 1043 | - imagechar($code_image, $loaded_fonts[$character['font']], $cur_x, floor(($max_height - $character['height']) / 2), $character['id'], imagecolorallocate($code_image, $char_fg_color[0], $char_fg_color[1], $char_fg_color[2])); |
|
| 1080 | + else { |
|
| 1081 | + imagechar($code_image, $loaded_fonts[$character['font']], $cur_x, floor(($max_height - $character['height']) / 2), $character['id'], imagecolorallocate($code_image, $char_fg_color[0], $char_fg_color[1], $char_fg_color[2])); |
|
| 1082 | + } |
|
| 1044 | 1083 | $cur_x += $character['width'] + $character_spacing; |
| 1045 | 1084 | } |
| 1046 | 1085 | } |
@@ -1053,17 +1092,22 @@ discard block |
||
| 1053 | 1092 | } |
| 1054 | 1093 | |
| 1055 | 1094 | // Make the background color transparent on the hard image. |
| 1056 | - if (!$simpleBGColor) |
|
| 1057 | - imagecolortransparent($code_image, $bg_color); |
|
| 1058 | - if ($hasBorder) |
|
| 1059 | - imagerectangle($code_image, 0, 0, $total_width - 1, $max_height - 1, $fg_color); |
|
| 1095 | + if (!$simpleBGColor) { |
|
| 1096 | + imagecolortransparent($code_image, $bg_color); |
|
| 1097 | + } |
|
| 1098 | + if ($hasBorder) { |
|
| 1099 | + imagerectangle($code_image, 0, 0, $total_width - 1, $max_height - 1, $fg_color); |
|
| 1100 | + } |
|
| 1060 | 1101 | |
| 1061 | 1102 | // Add some noise to the background? |
| 1062 | 1103 | if ($noiseType != 'none') |
| 1063 | 1104 | { |
| 1064 | - for ($i = mt_rand(0, 2); $i < $max_height; $i += mt_rand(1, 2)) |
|
| 1065 | - for ($j = mt_rand(0, 10); $j < $total_width; $j += mt_rand(1, 10)) |
|
| 1066 | - imagesetpixel($code_image, $j, $i, mt_rand(0, 1) ? $fg_color : $randomness_color); |
|
| 1105 | + for ($i = mt_rand(0, 2); $i < $max_height; $i += mt_rand(1, 2)) { |
|
| 1106 | + for ($j = mt_rand(0, 10); |
|
| 1107 | + } |
|
| 1108 | + $j < $total_width; $j += mt_rand(1, 10)) { |
|
| 1109 | + imagesetpixel($code_image, $j, $i, mt_rand(0, 1) ? $fg_color : $randomness_color); |
|
| 1110 | + } |
|
| 1067 | 1111 | |
| 1068 | 1112 | // Put in some lines too? |
| 1069 | 1113 | if ($noiseType != 'extreme') |
@@ -1076,8 +1120,7 @@ discard block |
||
| 1076 | 1120 | $x1 = mt_rand(0, $total_width); |
| 1077 | 1121 | $x2 = mt_rand(0, $total_width); |
| 1078 | 1122 | $y1 = 0; $y2 = $max_height; |
| 1079 | - } |
|
| 1080 | - else |
|
| 1123 | + } else |
|
| 1081 | 1124 | { |
| 1082 | 1125 | $y1 = mt_rand(0, $max_height); |
| 1083 | 1126 | $y2 = mt_rand(0, $max_height); |
@@ -1086,8 +1129,7 @@ discard block |
||
| 1086 | 1129 | imagesetthickness($code_image, mt_rand(1, 2)); |
| 1087 | 1130 | imageline($code_image, $x1, $y1, $x2, $y2, mt_rand(0, 1) ? $fg_color : $randomness_color); |
| 1088 | 1131 | } |
| 1089 | - } |
|
| 1090 | - else |
|
| 1132 | + } else |
|
| 1091 | 1133 | { |
| 1092 | 1134 | // Put in some ellipse |
| 1093 | 1135 | $num_ellipse = $noiseType == 'extreme' ? mt_rand(6, 12) : mt_rand(2, 6); |
@@ -1107,8 +1149,7 @@ discard block |
||
| 1107 | 1149 | { |
| 1108 | 1150 | header('Content-type: image/gif'); |
| 1109 | 1151 | imagegif($code_image); |
| 1110 | - } |
|
| 1111 | - else |
|
| 1152 | + } else |
|
| 1112 | 1153 | { |
| 1113 | 1154 | header('Content-type: image/png'); |
| 1114 | 1155 | imagepng($code_image); |
@@ -1131,25 +1172,29 @@ discard block |
||
| 1131 | 1172 | { |
| 1132 | 1173 | global $settings; |
| 1133 | 1174 | |
| 1134 | - if (!is_dir($settings['default_theme_dir'] . '/fonts')) |
|
| 1135 | - return false; |
|
| 1175 | + if (!is_dir($settings['default_theme_dir'] . '/fonts')) { |
|
| 1176 | + return false; |
|
| 1177 | + } |
|
| 1136 | 1178 | |
| 1137 | 1179 | // Get a list of the available font directories. |
| 1138 | 1180 | $font_dir = dir($settings['default_theme_dir'] . '/fonts'); |
| 1139 | 1181 | $font_list = array(); |
| 1140 | - while ($entry = $font_dir->read()) |
|
| 1141 | - if ($entry[0] !== '.' && is_dir($settings['default_theme_dir'] . '/fonts/' . $entry) && file_exists($settings['default_theme_dir'] . '/fonts/' . $entry . '.gdf')) |
|
| 1182 | + while ($entry = $font_dir->read()) { |
|
| 1183 | + if ($entry[0] !== '.' && is_dir($settings['default_theme_dir'] . '/fonts/' . $entry) && file_exists($settings['default_theme_dir'] . '/fonts/' . $entry . '.gdf')) |
|
| 1142 | 1184 | $font_list[] = $entry; |
| 1185 | + } |
|
| 1143 | 1186 | |
| 1144 | - if (empty($font_list)) |
|
| 1145 | - return false; |
|
| 1187 | + if (empty($font_list)) { |
|
| 1188 | + return false; |
|
| 1189 | + } |
|
| 1146 | 1190 | |
| 1147 | 1191 | // Pick a random font. |
| 1148 | 1192 | $random_font = $font_list[array_rand($font_list)]; |
| 1149 | 1193 | |
| 1150 | 1194 | // Check if the given letter exists. |
| 1151 | - if (!file_exists($settings['default_theme_dir'] . '/fonts/' . $random_font . '/' . $letter . '.png')) |
|
| 1152 | - return false; |
|
| 1195 | + if (!file_exists($settings['default_theme_dir'] . '/fonts/' . $random_font . '/' . $letter . '.png')) { |
|
| 1196 | + return false; |
|
| 1197 | + } |
|
| 1153 | 1198 | |
| 1154 | 1199 | // Include it! |
| 1155 | 1200 | header('Content-type: image/png'); |
@@ -273,7 +273,6 @@ |
||
| 273 | 273 | * Modify any setting related to topics. |
| 274 | 274 | * Requires the admin_forum permission. |
| 275 | 275 | * Accessed from ?action=admin;area=postsettings;sa=topics. |
| 276 | - |
|
| 277 | 276 | * @param bool $return_config Whether or not to return the config_vars array (used for admin search) |
| 278 | 277 | * @return void|array Returns nothing or returns $config_vars if $return_config is true |
| 279 | 278 | * @uses Admin template, edit_topic_settings sub-template. |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * The main entrance point for the 'Posts and topics' screen. |
@@ -98,23 +99,23 @@ discard block |
||
| 98 | 99 | { |
| 99 | 100 | $_POST['censortext'] = explode("\n", strtr($_POST['censortext'], array("\r" => ''))); |
| 100 | 101 | |
| 101 | - foreach ($_POST['censortext'] as $c) |
|
| 102 | - list ($censored_vulgar[], $censored_proper[]) = array_pad(explode('=', trim($c)), 2, ''); |
|
| 103 | - } |
|
| 104 | - elseif (isset($_POST['censor_vulgar'], $_POST['censor_proper'])) |
|
| 102 | + foreach ($_POST['censortext'] as $c) { |
|
| 103 | + list ($censored_vulgar[], $censored_proper[]) = array_pad(explode('=', trim($c)), 2, ''); |
|
| 104 | + } |
|
| 105 | + } elseif (isset($_POST['censor_vulgar'], $_POST['censor_proper'])) |
|
| 105 | 106 | { |
| 106 | 107 | if (is_array($_POST['censor_vulgar'])) |
| 107 | 108 | { |
| 108 | 109 | foreach ($_POST['censor_vulgar'] as $i => $value) |
| 109 | 110 | { |
| 110 | - if (trim(strtr($value, '*', ' ')) == '') |
|
| 111 | - unset($_POST['censor_vulgar'][$i], $_POST['censor_proper'][$i]); |
|
| 111 | + if (trim(strtr($value, '*', ' ')) == '') { |
|
| 112 | + unset($_POST['censor_vulgar'][$i], $_POST['censor_proper'][$i]); |
|
| 113 | + } |
|
| 112 | 114 | } |
| 113 | 115 | |
| 114 | 116 | $censored_vulgar = $_POST['censor_vulgar']; |
| 115 | 117 | $censored_proper = $_POST['censor_proper']; |
| 116 | - } |
|
| 117 | - else |
|
| 118 | + } else |
|
| 118 | 119 | { |
| 119 | 120 | $censored_vulgar = explode("\n", strtr($_POST['censor_vulgar'], array("\r" => ''))); |
| 120 | 121 | $censored_proper = explode("\n", strtr($_POST['censor_proper'], array("\r" => ''))); |
@@ -151,12 +152,14 @@ discard block |
||
| 151 | 152 | $context['censored_words'] = array(); |
| 152 | 153 | for ($i = 0, $n = count($censor_vulgar); $i < $n; $i++) |
| 153 | 154 | { |
| 154 | - if (empty($censor_vulgar[$i])) |
|
| 155 | - continue; |
|
| 155 | + if (empty($censor_vulgar[$i])) { |
|
| 156 | + continue; |
|
| 157 | + } |
|
| 156 | 158 | |
| 157 | 159 | // Skip it, it's either spaces or stars only. |
| 158 | - if (trim(strtr($censor_vulgar[$i], '*', ' ')) == '') |
|
| 159 | - continue; |
|
| 160 | + if (trim(strtr($censor_vulgar[$i], '*', ' ')) == '') { |
|
| 161 | + continue; |
|
| 162 | + } |
|
| 160 | 163 | |
| 161 | 164 | $context['censored_words'][$smcFunc['htmlspecialchars'](trim($censor_vulgar[$i]))] = isset($censor_proper[$i]) ? $smcFunc['htmlspecialchars']($censor_proper[$i]) : ''; |
| 162 | 165 | } |
@@ -187,10 +190,11 @@ discard block |
||
| 187 | 190 | |
| 188 | 191 | // Make an inline conditional a little shorter... |
| 189 | 192 | $can_spell_check = false; |
| 190 | - if (function_exists('pspell_new')) |
|
| 191 | - $can_spell_check = true; |
|
| 192 | - elseif (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv'))) |
|
| 193 | - $can_spell_check = true; |
|
| 193 | + if (function_exists('pspell_new')) { |
|
| 194 | + $can_spell_check = true; |
|
| 195 | + } elseif (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv'))) { |
|
| 196 | + $can_spell_check = true; |
|
| 197 | + } |
|
| 194 | 198 | |
| 195 | 199 | // All the settings... |
| 196 | 200 | $config_vars = array( |
@@ -221,8 +225,9 @@ discard block |
||
| 221 | 225 | |
| 222 | 226 | call_integration_hook('integrate_modify_post_settings', array(&$config_vars)); |
| 223 | 227 | |
| 224 | - if ($return_config) |
|
| 225 | - return $config_vars; |
|
| 228 | + if ($return_config) { |
|
| 229 | + return $config_vars; |
|
| 230 | + } |
|
| 226 | 231 | |
| 227 | 232 | // We'll want this for our easy save. |
| 228 | 233 | require_once($sourcedir . '/ManageServer.php'); |
@@ -242,17 +247,20 @@ discard block |
||
| 242 | 247 | db_extend('packages'); |
| 243 | 248 | |
| 244 | 249 | $colData = $smcFunc['db_list_columns']('{db_prefix}messages', true); |
| 245 | - foreach ($colData as $column) |
|
| 246 | - if ($column['name'] == 'body') |
|
| 250 | + foreach ($colData as $column) { |
|
| 251 | + if ($column['name'] == 'body') |
|
| 247 | 252 | $body_type = $column['type']; |
| 253 | + } |
|
| 248 | 254 | |
| 249 | - if (isset($body_type) && ($_POST['max_messageLength'] > 65535 || $_POST['max_messageLength'] == 0) && $body_type == 'text') |
|
| 250 | - fatal_lang_error('convert_to_mediumtext', false, array($scripturl . '?action=admin;area=maintain;sa=database')); |
|
| 255 | + if (isset($body_type) && ($_POST['max_messageLength'] > 65535 || $_POST['max_messageLength'] == 0) && $body_type == 'text') { |
|
| 256 | + fatal_lang_error('convert_to_mediumtext', false, array($scripturl . '?action=admin;area=maintain;sa=database')); |
|
| 257 | + } |
|
| 251 | 258 | } |
| 252 | 259 | |
| 253 | 260 | // If we're changing the post preview length let's check its valid |
| 254 | - if (!empty($_POST['preview_characters'])) |
|
| 255 | - $_POST['preview_characters'] = (int) min(max(0, $_POST['preview_characters']), 512); |
|
| 261 | + if (!empty($_POST['preview_characters'])) { |
|
| 262 | + $_POST['preview_characters'] = (int) min(max(0, $_POST['preview_characters']), 512); |
|
| 263 | + } |
|
| 256 | 264 | |
| 257 | 265 | call_integration_hook('integrate_save_post_settings'); |
| 258 | 266 | |
@@ -313,8 +321,9 @@ discard block |
||
| 313 | 321 | |
| 314 | 322 | call_integration_hook('integrate_modify_topic_settings', array(&$config_vars)); |
| 315 | 323 | |
| 316 | - if ($return_config) |
|
| 317 | - return $config_vars; |
|
| 324 | + if ($return_config) { |
|
| 325 | + return $config_vars; |
|
| 326 | + } |
|
| 318 | 327 | |
| 319 | 328 | // Get the settings template ready. |
| 320 | 329 | require_once($sourcedir . '/ManageServer.php'); |
@@ -367,8 +376,9 @@ discard block |
||
| 367 | 376 | array('int', 'drafts_autosave_frequency', 'postinput' => $txt['manageposts_seconds'], 'subtext' => $txt['drafts_autosave_frequency_subnote']), |
| 368 | 377 | ); |
| 369 | 378 | |
| 370 | - if ($return_config) |
|
| 371 | - return $config_vars; |
|
| 379 | + if ($return_config) { |
|
| 380 | + return $config_vars; |
|
| 381 | + } |
|
| 372 | 382 | |
| 373 | 383 | // Get the settings template ready. |
| 374 | 384 | require_once($sourcedir . '/ManageServer.php'); |
@@ -130,7 +130,6 @@ |
||
| 130 | 130 | * |
| 131 | 131 | * @param int $closed 1 for counting closed reports, 0 for open ones. |
| 132 | 132 | * @return integer How many reports. |
| 133 | - |
|
| 134 | 133 | */ |
| 135 | 134 | function countReports($closed = 0) |
| 136 | 135 | { |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Updates a report with the given parameters. Logs each action via logAction() |
@@ -28,19 +29,20 @@ discard block |
||
| 28 | 29 | global $smcFunc, $user_info, $context; |
| 29 | 30 | |
| 30 | 31 | // Don't bother. |
| 31 | - if (empty($action) || empty($report_id)) |
|
| 32 | - return false; |
|
| 32 | + if (empty($action) || empty($report_id)) { |
|
| 33 | + return false; |
|
| 34 | + } |
|
| 33 | 35 | |
| 34 | 36 | // Add the "_all" thingy. |
| 35 | - if ($action == 'ignore') |
|
| 36 | - $action = 'ignore_all'; |
|
| 37 | + if ($action == 'ignore') { |
|
| 38 | + $action = 'ignore_all'; |
|
| 39 | + } |
|
| 37 | 40 | |
| 38 | 41 | // We don't need the board query for reported members |
| 39 | 42 | if ($context['report_type'] == 'members') |
| 40 | 43 | { |
| 41 | 44 | $board_query = ''; |
| 42 | - } |
|
| 43 | - else |
|
| 45 | + } else |
|
| 44 | 46 | { |
| 45 | 47 | $board_query = ' AND ' . $user_info['mod_cache']['bq']; |
| 46 | 48 | } |
@@ -76,17 +78,17 @@ discard block |
||
| 76 | 78 | ) |
| 77 | 79 | ); |
| 78 | 80 | |
| 79 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 80 | - $extra[$row['id_report']] = array( |
|
| 81 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 82 | + $extra[$row['id_report']] = array( |
|
| 81 | 83 | 'report' => $row['id_report'], |
| 82 | 84 | 'board' => $row['id_board'], |
| 83 | 85 | 'message' => $row['id_msg'], |
| 84 | 86 | 'topic' => $row['id_topic'], |
| 85 | 87 | ); |
| 88 | + } |
|
| 86 | 89 | |
| 87 | 90 | $smcFunc['db_free_result']($request); |
| 88 | - } |
|
| 89 | - else |
|
| 91 | + } else |
|
| 90 | 92 | { |
| 91 | 93 | $request = $smcFunc['db_query']('', ' |
| 92 | 94 | SELECT id_report, id_member, membername |
@@ -97,28 +99,32 @@ discard block |
||
| 97 | 99 | ) |
| 98 | 100 | ); |
| 99 | 101 | |
| 100 | - while($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 101 | - $extra[$row['id_report']] = array( |
|
| 102 | + while($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 103 | + $extra[$row['id_report']] = array( |
|
| 102 | 104 | 'report' => $row['id_report'], |
| 103 | 105 | 'member' => $row['id_member'], |
| 104 | 106 | ); |
| 107 | + } |
|
| 105 | 108 | |
| 106 | 109 | $smcFunc['db_free_result']($request); |
| 107 | 110 | } |
| 108 | 111 | |
| 109 | 112 | // Back to "ignore". |
| 110 | - if ($action == 'ignore_all') |
|
| 111 | - $action = 'ignore'; |
|
| 113 | + if ($action == 'ignore_all') { |
|
| 114 | + $action = 'ignore'; |
|
| 115 | + } |
|
| 112 | 116 | |
| 113 | 117 | $log_report = $action == 'ignore' ? (!empty($value) ? 'ignore' : 'unignore') : (!empty($value) ? 'close' : 'open'); |
| 114 | 118 | |
| 115 | - if ($context['report_type'] == 'members') |
|
| 116 | - $log_report .= '_user'; |
|
| 119 | + if ($context['report_type'] == 'members') { |
|
| 120 | + $log_report .= '_user'; |
|
| 121 | + } |
|
| 117 | 122 | |
| 118 | 123 | // Log this action. |
| 119 | - if (!empty($extra)) |
|
| 120 | - foreach ($extra as $report) |
|
| 124 | + if (!empty($extra)) { |
|
| 125 | + foreach ($extra as $report) |
|
| 121 | 126 | logAction($log_report . '_report', $report); |
| 127 | + } |
|
| 122 | 128 | |
| 123 | 129 | // Time to update. |
| 124 | 130 | updateSettings(array('last_mod_report_action' => time())); |
@@ -140,14 +146,12 @@ discard block |
||
| 140 | 146 | if ($context['report_type'] == 'members') |
| 141 | 147 | { |
| 142 | 148 | $and = 'lr.id_board = 0'; |
| 143 | - } |
|
| 144 | - else |
|
| 149 | + } else |
|
| 145 | 150 | { |
| 146 | 151 | if ($user_info['mod_cache']['bq'] == '1=1' || $user_info['mod_cache']['bq'] == '0=1') |
| 147 | 152 | { |
| 148 | 153 | $bq = $user_info['mod_cache']['bq']; |
| 149 | - } |
|
| 150 | - else |
|
| 154 | + } else |
|
| 151 | 155 | { |
| 152 | 156 | $bq = 'lr.' . $user_info['mod_cache']['bq']; |
| 153 | 157 | } |
@@ -203,8 +207,7 @@ discard block |
||
| 203 | 207 | 'max' => 10, |
| 204 | 208 | ) |
| 205 | 209 | ); |
| 206 | - } |
|
| 207 | - else |
|
| 210 | + } else |
|
| 208 | 211 | { |
| 209 | 212 | $request = $smcFunc['db_query']('', ' |
| 210 | 213 | SELECT lr.id_report, lr.id_msg, lr.id_topic, lr.id_board, lr.id_member, lr.subject, lr.body, |
@@ -252,8 +255,7 @@ discard block |
||
| 252 | 255 | 'href' => $scripturl . '?action=profile;u=' . $row['id_user'], |
| 253 | 256 | ), |
| 254 | 257 | ); |
| 255 | - } |
|
| 256 | - else |
|
| 258 | + } else |
|
| 257 | 259 | { |
| 258 | 260 | $report_boards_ids[] = $row['id_board']; |
| 259 | 261 | $extraDetails = array( |
@@ -293,14 +295,16 @@ discard block |
||
| 293 | 295 | ) |
| 294 | 296 | ); |
| 295 | 297 | |
| 296 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 297 | - $board_names[$row['id_board']] = $row['name']; |
|
| 298 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 299 | + $board_names[$row['id_board']] = $row['name']; |
|
| 300 | + } |
|
| 298 | 301 | |
| 299 | 302 | $smcFunc['db_free_result']($request); |
| 300 | 303 | |
| 301 | - foreach ($reports as $id_report => $report) |
|
| 302 | - if (!empty($board_names[$report['topic']['id_board']])) |
|
| 304 | + foreach ($reports as $id_report => $report) { |
|
| 305 | + if (!empty($board_names[$report['topic']['id_board']])) |
|
| 303 | 306 | $reports[$id_report]['topic']['board_name'] = $board_names[$report['topic']['id_board']]; |
| 307 | + } |
|
| 304 | 308 | } |
| 305 | 309 | |
| 306 | 310 | // Now get all the people who reported it. |
@@ -350,10 +354,11 @@ discard block |
||
| 350 | 354 | { |
| 351 | 355 | global $user_info, $smcFunc; |
| 352 | 356 | |
| 353 | - if ($type == 'members') |
|
| 354 | - $bq = ''; |
|
| 355 | - else |
|
| 356 | - $bq = ' AND ' . $user_info['mod_cache']['bq']; |
|
| 357 | + if ($type == 'members') { |
|
| 358 | + $bq = ''; |
|
| 359 | + } else { |
|
| 360 | + $bq = ' AND ' . $user_info['mod_cache']['bq']; |
|
| 361 | + } |
|
| 357 | 362 | |
| 358 | 363 | $request = $smcFunc['db_query']('', ' |
| 359 | 364 | SELECT COUNT(*) |
@@ -392,8 +397,9 @@ discard block |
||
| 392 | 397 | { |
| 393 | 398 | global $smcFunc, $user_info, $context; |
| 394 | 399 | |
| 395 | - if (empty($report_id)) |
|
| 396 | - return false; |
|
| 400 | + if (empty($report_id)) { |
|
| 401 | + return false; |
|
| 402 | + } |
|
| 397 | 403 | |
| 398 | 404 | // We don't need all this info if we're only getting user info |
| 399 | 405 | if ($context['report_type'] == 'members') |
@@ -411,8 +417,7 @@ discard block |
||
| 411 | 417 | 'id_report' => $report_id, |
| 412 | 418 | ) |
| 413 | 419 | ); |
| 414 | - } |
|
| 415 | - else |
|
| 420 | + } else |
|
| 416 | 421 | { |
| 417 | 422 | // Get the report details, need this so we can limit access to a particular board. |
| 418 | 423 | $request = $smcFunc['db_query']('', ' |
@@ -431,8 +436,9 @@ discard block |
||
| 431 | 436 | } |
| 432 | 437 | |
| 433 | 438 | // So did we find anything? |
| 434 | - if (!$smcFunc['db_num_rows']($request)) |
|
| 435 | - return false; |
|
| 439 | + if (!$smcFunc['db_num_rows']($request)) { |
|
| 440 | + return false; |
|
| 441 | + } |
|
| 436 | 442 | |
| 437 | 443 | // Woohoo we found a report and they can see it! |
| 438 | 444 | $row = $smcFunc['db_fetch_assoc']($request); |
@@ -451,8 +457,9 @@ discard block |
||
| 451 | 457 | { |
| 452 | 458 | global $smcFunc, $scripturl, $user_info, $txt; |
| 453 | 459 | |
| 454 | - if (empty($report_id)) |
|
| 455 | - return false; |
|
| 460 | + if (empty($report_id)) { |
|
| 461 | + return false; |
|
| 462 | + } |
|
| 456 | 463 | |
| 457 | 464 | $report = array( |
| 458 | 465 | 'comments' => array(), |
@@ -533,8 +540,9 @@ discard block |
||
| 533 | 540 | { |
| 534 | 541 | global $smcFunc, $user_info; |
| 535 | 542 | |
| 536 | - if (empty($comment_id)) |
|
| 537 | - return false; |
|
| 543 | + if (empty($comment_id)) { |
|
| 544 | + return false; |
|
| 545 | + } |
|
| 538 | 546 | |
| 539 | 547 | $request = $smcFunc['db_query']('', ' |
| 540 | 548 | SELECT id_comment, id_notice, log_time, body, id_member |
@@ -551,8 +559,9 @@ discard block |
||
| 551 | 559 | $smcFunc['db_free_result']($request); |
| 552 | 560 | |
| 553 | 561 | // Add the permission |
| 554 | - if (!empty($comment)) |
|
| 555 | - $comment['can_edit'] = allowedTo('admin_forum') || (($user_info['id'] == $comment['id_member'])); |
|
| 562 | + if (!empty($comment)) { |
|
| 563 | + $comment['can_edit'] = allowedTo('admin_forum') || (($user_info['id'] == $comment['id_member'])); |
|
| 564 | + } |
|
| 556 | 565 | |
| 557 | 566 | return $comment; |
| 558 | 567 | } |
@@ -568,8 +577,9 @@ discard block |
||
| 568 | 577 | { |
| 569 | 578 | global $smcFunc, $user_info, $context; |
| 570 | 579 | |
| 571 | - if (empty($data)) |
|
| 572 | - return false; |
|
| 580 | + if (empty($data)) { |
|
| 581 | + return false; |
|
| 582 | + } |
|
| 573 | 583 | |
| 574 | 584 | $data = array_merge(array($user_info['id'], $user_info['name'], 'reportc', ''), $data); |
| 575 | 585 | |
@@ -598,8 +608,7 @@ discard block |
||
| 598 | 608 | 'comment_id' => $last_comment, |
| 599 | 609 | 'time' => time(), |
| 600 | 610 | ); |
| 601 | - } |
|
| 602 | - else |
|
| 611 | + } else |
|
| 603 | 612 | { |
| 604 | 613 | $prefix = 'Msg'; |
| 605 | 614 | $data = array( |
@@ -615,14 +624,15 @@ discard block |
||
| 615 | 624 | } |
| 616 | 625 | |
| 617 | 626 | // And get ready to notify people. |
| 618 | - if (!empty($report)) |
|
| 619 | - $smcFunc['db_insert']('insert', |
|
| 627 | + if (!empty($report)) { |
|
| 628 | + $smcFunc['db_insert']('insert', |
|
| 620 | 629 | '{db_prefix}background_tasks', |
| 621 | 630 | array('task_file' => 'string', 'task_class' => 'string', 'task_data' => 'string', 'claimed_time' => 'int'), |
| 622 | 631 | array('$sourcedir/tasks/' . $prefix . 'ReportReply-Notify.php', $prefix . 'ReportReply_Notify_Background', json_encode($data), 0), |
| 623 | 632 | array('id_task') |
| 624 | 633 | ); |
| 625 | -} |
|
| 634 | + } |
|
| 635 | + } |
|
| 626 | 636 | |
| 627 | 637 | /** |
| 628 | 638 | * Saves the new information whenever a moderator comment is edited. |
@@ -635,8 +645,9 @@ discard block |
||
| 635 | 645 | { |
| 636 | 646 | global $smcFunc; |
| 637 | 647 | |
| 638 | - if (empty($comment_id) || empty($edited_comment)) |
|
| 639 | - return false; |
|
| 648 | + if (empty($comment_id) || empty($edited_comment)) { |
|
| 649 | + return false; |
|
| 650 | + } |
|
| 640 | 651 | |
| 641 | 652 | $smcFunc['db_query']('', ' |
| 642 | 653 | UPDATE {db_prefix}log_comments |
@@ -659,8 +670,9 @@ discard block |
||
| 659 | 670 | { |
| 660 | 671 | global $smcFunc; |
| 661 | 672 | |
| 662 | - if (empty($comment_id)) |
|
| 663 | - return false; |
|
| 673 | + if (empty($comment_id)) { |
|
| 674 | + return false; |
|
| 675 | + } |
|
| 664 | 676 | |
| 665 | 677 | $smcFunc['db_query']('', ' |
| 666 | 678 | DELETE FROM {db_prefix}log_comments |
@@ -5370,7 +5370,6 @@ discard block |
||
| 5370 | 5370 | |
| 5371 | 5371 | /** |
| 5372 | 5372 | * Tries different modes to make file/dirs writable. Wrapper function for chmod() |
| 5373 | - |
|
| 5374 | 5373 | * @param string $file The file/dir full path. |
| 5375 | 5374 | * @param int $value Not needed, added for legacy reasons. |
| 5376 | 5375 | * @return boolean true if the file/dir is already writable or the function was able to make it writable, false if the function couldn't make the file/dir writable. |
@@ -5410,7 +5409,6 @@ discard block |
||
| 5410 | 5409 | |
| 5411 | 5410 | /** |
| 5412 | 5411 | * Wrapper function for json_decode() with error handling. |
| 5413 | - |
|
| 5414 | 5412 | * @param string $json The string to decode. |
| 5415 | 5413 | * @param bool $returnAsArray To return the decoded string as an array or an object, SMF only uses Arrays but to keep on compatibility with json_decode its set to false as default. |
| 5416 | 5414 | * @param bool $logIt To specify if the error will be logged if theres any. |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Update some basic statistics. |
@@ -122,10 +123,11 @@ discard block |
||
| 122 | 123 | $smcFunc['db_free_result']($result); |
| 123 | 124 | |
| 124 | 125 | // Add this to the number of unapproved members |
| 125 | - if (!empty($changes['unapprovedMembers'])) |
|
| 126 | - $changes['unapprovedMembers'] += $coppa_approvals; |
|
| 127 | - else |
|
| 128 | - $changes['unapprovedMembers'] = $coppa_approvals; |
|
| 126 | + if (!empty($changes['unapprovedMembers'])) { |
|
| 127 | + $changes['unapprovedMembers'] += $coppa_approvals; |
|
| 128 | + } else { |
|
| 129 | + $changes['unapprovedMembers'] = $coppa_approvals; |
|
| 130 | + } |
|
| 129 | 131 | } |
| 130 | 132 | } |
| 131 | 133 | } |
@@ -133,9 +135,9 @@ discard block |
||
| 133 | 135 | break; |
| 134 | 136 | |
| 135 | 137 | case 'message': |
| 136 | - if ($parameter1 === true && $parameter2 !== null) |
|
| 137 | - updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
| 138 | - else |
|
| 138 | + if ($parameter1 === true && $parameter2 !== null) { |
|
| 139 | + updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true); |
|
| 140 | + } else |
|
| 139 | 141 | { |
| 140 | 142 | // SUM and MAX on a smaller table is better for InnoDB tables. |
| 141 | 143 | $result = $smcFunc['db_query']('', ' |
@@ -175,23 +177,25 @@ discard block |
||
| 175 | 177 | $parameter2 = text2words($parameter2); |
| 176 | 178 | |
| 177 | 179 | $inserts = array(); |
| 178 | - foreach ($parameter2 as $word) |
|
| 179 | - $inserts[] = array($word, $parameter1); |
|
| 180 | + foreach ($parameter2 as $word) { |
|
| 181 | + $inserts[] = array($word, $parameter1); |
|
| 182 | + } |
|
| 180 | 183 | |
| 181 | - if (!empty($inserts)) |
|
| 182 | - $smcFunc['db_insert']('ignore', |
|
| 184 | + if (!empty($inserts)) { |
|
| 185 | + $smcFunc['db_insert']('ignore', |
|
| 183 | 186 | '{db_prefix}log_search_subjects', |
| 184 | 187 | array('word' => 'string', 'id_topic' => 'int'), |
| 185 | 188 | $inserts, |
| 186 | 189 | array('word', 'id_topic') |
| 187 | 190 | ); |
| 191 | + } |
|
| 188 | 192 | } |
| 189 | 193 | break; |
| 190 | 194 | |
| 191 | 195 | case 'topic': |
| 192 | - if ($parameter1 === true) |
|
| 193 | - updateSettings(array('totalTopics' => true), true); |
|
| 194 | - else |
|
| 196 | + if ($parameter1 === true) { |
|
| 197 | + updateSettings(array('totalTopics' => true), true); |
|
| 198 | + } else |
|
| 195 | 199 | { |
| 196 | 200 | // Get the number of topics - a SUM is better for InnoDB tables. |
| 197 | 201 | // We also ignore the recycle bin here because there will probably be a bunch of one-post topics there. |
@@ -212,8 +216,9 @@ discard block |
||
| 212 | 216 | |
| 213 | 217 | case 'postgroups': |
| 214 | 218 | // Parameter two is the updated columns: we should check to see if we base groups off any of these. |
| 215 | - if ($parameter2 !== null && !in_array('posts', $parameter2)) |
|
| 216 | - return; |
|
| 219 | + if ($parameter2 !== null && !in_array('posts', $parameter2)) { |
|
| 220 | + return; |
|
| 221 | + } |
|
| 217 | 222 | |
| 218 | 223 | $postgroups = cache_get_data('updateStats:postgroups', 360); |
| 219 | 224 | if ($postgroups == null || $parameter1 == null) |
@@ -228,8 +233,9 @@ discard block |
||
| 228 | 233 | ) |
| 229 | 234 | ); |
| 230 | 235 | $postgroups = array(); |
| 231 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 232 | - $postgroups[$row['id_group']] = $row['min_posts']; |
|
| 236 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 237 | + $postgroups[$row['id_group']] = $row['min_posts']; |
|
| 238 | + } |
|
| 233 | 239 | $smcFunc['db_free_result']($request); |
| 234 | 240 | |
| 235 | 241 | // Sort them this way because if it's done with MySQL it causes a filesort :(. |
@@ -239,8 +245,9 @@ discard block |
||
| 239 | 245 | } |
| 240 | 246 | |
| 241 | 247 | // Oh great, they've screwed their post groups. |
| 242 | - if (empty($postgroups)) |
|
| 243 | - return; |
|
| 248 | + if (empty($postgroups)) { |
|
| 249 | + return; |
|
| 250 | + } |
|
| 244 | 251 | |
| 245 | 252 | // Set all membergroups from most posts to least posts. |
| 246 | 253 | $conditions = ''; |
@@ -298,10 +305,9 @@ discard block |
||
| 298 | 305 | { |
| 299 | 306 | $condition = 'id_member IN ({array_int:members})'; |
| 300 | 307 | $parameters['members'] = $members; |
| 301 | - } |
|
| 302 | - elseif ($members === null) |
|
| 303 | - $condition = '1=1'; |
|
| 304 | - else |
|
| 308 | + } elseif ($members === null) { |
|
| 309 | + $condition = '1=1'; |
|
| 310 | + } else |
|
| 305 | 311 | { |
| 306 | 312 | $condition = 'id_member = {int:member}'; |
| 307 | 313 | $parameters['member'] = $members; |
@@ -341,9 +347,9 @@ discard block |
||
| 341 | 347 | if (count($vars_to_integrate) != 0) |
| 342 | 348 | { |
| 343 | 349 | // Fetch a list of member_names if necessary |
| 344 | - if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) |
|
| 345 | - $member_names = array($user_info['username']); |
|
| 346 | - else |
|
| 350 | + if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) { |
|
| 351 | + $member_names = array($user_info['username']); |
|
| 352 | + } else |
|
| 347 | 353 | { |
| 348 | 354 | $member_names = array(); |
| 349 | 355 | $request = $smcFunc['db_query']('', ' |
@@ -352,14 +358,16 @@ discard block |
||
| 352 | 358 | WHERE ' . $condition, |
| 353 | 359 | $parameters |
| 354 | 360 | ); |
| 355 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 356 | - $member_names[] = $row['member_name']; |
|
| 361 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 362 | + $member_names[] = $row['member_name']; |
|
| 363 | + } |
|
| 357 | 364 | $smcFunc['db_free_result']($request); |
| 358 | 365 | } |
| 359 | 366 | |
| 360 | - if (!empty($member_names)) |
|
| 361 | - foreach ($vars_to_integrate as $var) |
|
| 367 | + if (!empty($member_names)) { |
|
| 368 | + foreach ($vars_to_integrate as $var) |
|
| 362 | 369 | call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats)); |
| 370 | + } |
|
| 363 | 371 | } |
| 364 | 372 | } |
| 365 | 373 | |
@@ -367,16 +375,17 @@ discard block |
||
| 367 | 375 | foreach ($data as $var => $val) |
| 368 | 376 | { |
| 369 | 377 | $type = 'string'; |
| 370 | - if (in_array($var, $knownInts)) |
|
| 371 | - $type = 'int'; |
|
| 372 | - elseif (in_array($var, $knownFloats)) |
|
| 373 | - $type = 'float'; |
|
| 374 | - elseif ($var == 'birthdate') |
|
| 375 | - $type = 'date'; |
|
| 376 | - elseif ($var == 'member_ip') |
|
| 377 | - $type = 'inet'; |
|
| 378 | - elseif ($var == 'member_ip2') |
|
| 379 | - $type = 'inet'; |
|
| 378 | + if (in_array($var, $knownInts)) { |
|
| 379 | + $type = 'int'; |
|
| 380 | + } elseif (in_array($var, $knownFloats)) { |
|
| 381 | + $type = 'float'; |
|
| 382 | + } elseif ($var == 'birthdate') { |
|
| 383 | + $type = 'date'; |
|
| 384 | + } elseif ($var == 'member_ip') { |
|
| 385 | + $type = 'inet'; |
|
| 386 | + } elseif ($var == 'member_ip2') { |
|
| 387 | + $type = 'inet'; |
|
| 388 | + } |
|
| 380 | 389 | |
| 381 | 390 | // Doing an increment? |
| 382 | 391 | if ($type == 'int' && ($val === '+' || $val === '-')) |
@@ -390,8 +399,9 @@ discard block |
||
| 390 | 399 | { |
| 391 | 400 | if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match)) |
| 392 | 401 | { |
| 393 | - if ($match[1] != '+ ') |
|
| 394 | - $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
| 402 | + if ($match[1] != '+ ') { |
|
| 403 | + $val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END'; |
|
| 404 | + } |
|
| 395 | 405 | $type = 'raw'; |
| 396 | 406 | } |
| 397 | 407 | } |
@@ -412,8 +422,9 @@ discard block |
||
| 412 | 422 | // Clear any caching? |
| 413 | 423 | if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members)) |
| 414 | 424 | { |
| 415 | - if (!is_array($members)) |
|
| 416 | - $members = array($members); |
|
| 425 | + if (!is_array($members)) { |
|
| 426 | + $members = array($members); |
|
| 427 | + } |
|
| 417 | 428 | |
| 418 | 429 | foreach ($members as $member) |
| 419 | 430 | { |
@@ -446,29 +457,32 @@ discard block |
||
| 446 | 457 | { |
| 447 | 458 | global $modSettings, $smcFunc; |
| 448 | 459 | |
| 449 | - if (empty($changeArray) || !is_array($changeArray)) |
|
| 450 | - return; |
|
| 460 | + if (empty($changeArray) || !is_array($changeArray)) { |
|
| 461 | + return; |
|
| 462 | + } |
|
| 451 | 463 | |
| 452 | 464 | $toRemove = array(); |
| 453 | 465 | |
| 454 | 466 | // Go check if there is any setting to be removed. |
| 455 | - foreach ($changeArray as $k => $v) |
|
| 456 | - if ($v === null) |
|
| 467 | + foreach ($changeArray as $k => $v) { |
|
| 468 | + if ($v === null) |
|
| 457 | 469 | { |
| 458 | 470 | // Found some, remove them from the original array and add them to ours. |
| 459 | 471 | unset($changeArray[$k]); |
| 472 | + } |
|
| 460 | 473 | $toRemove[] = $k; |
| 461 | 474 | } |
| 462 | 475 | |
| 463 | 476 | // Proceed with the deletion. |
| 464 | - if (!empty($toRemove)) |
|
| 465 | - $smcFunc['db_query']('', ' |
|
| 477 | + if (!empty($toRemove)) { |
|
| 478 | + $smcFunc['db_query']('', ' |
|
| 466 | 479 | DELETE FROM {db_prefix}settings |
| 467 | 480 | WHERE variable IN ({array_string:remove})', |
| 468 | 481 | array( |
| 469 | 482 | 'remove' => $toRemove, |
| 470 | 483 | ) |
| 471 | 484 | ); |
| 485 | + } |
|
| 472 | 486 | |
| 473 | 487 | // In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs. |
| 474 | 488 | if ($update) |
@@ -497,19 +511,22 @@ discard block |
||
| 497 | 511 | foreach ($changeArray as $variable => $value) |
| 498 | 512 | { |
| 499 | 513 | // Don't bother if it's already like that ;). |
| 500 | - if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) |
|
| 501 | - continue; |
|
| 514 | + if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) { |
|
| 515 | + continue; |
|
| 516 | + } |
|
| 502 | 517 | // If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it. |
| 503 | - elseif (!isset($modSettings[$variable]) && empty($value)) |
|
| 504 | - continue; |
|
| 518 | + elseif (!isset($modSettings[$variable]) && empty($value)) { |
|
| 519 | + continue; |
|
| 520 | + } |
|
| 505 | 521 | |
| 506 | 522 | $replaceArray[] = array($variable, $value); |
| 507 | 523 | |
| 508 | 524 | $modSettings[$variable] = $value; |
| 509 | 525 | } |
| 510 | 526 | |
| 511 | - if (empty($replaceArray)) |
|
| 512 | - return; |
|
| 527 | + if (empty($replaceArray)) { |
|
| 528 | + return; |
|
| 529 | + } |
|
| 513 | 530 | |
| 514 | 531 | $smcFunc['db_insert']('replace', |
| 515 | 532 | '{db_prefix}settings', |
@@ -555,20 +572,25 @@ discard block |
||
| 555 | 572 | $start = (int) $start; |
| 556 | 573 | $start_invalid = $start < 0; |
| 557 | 574 | |
| 558 | - if (!empty($options['low_id'])) |
|
| 559 | - $low_id = $options['low_id']; |
|
| 560 | - if (!empty($options['max_id'])) |
|
| 561 | - $max_id = $options['max_id']; |
|
| 575 | + if (!empty($options['low_id'])) { |
|
| 576 | + $low_id = $options['low_id']; |
|
| 577 | + } |
|
| 578 | + if (!empty($options['max_id'])) { |
|
| 579 | + $max_id = $options['max_id']; |
|
| 580 | + } |
|
| 562 | 581 | |
| 563 | 582 | // Make sure $start is a proper variable - not less than 0. |
| 564 | - if ($start_invalid) |
|
| 565 | - $start = 0; |
|
| 583 | + if ($start_invalid) { |
|
| 584 | + $start = 0; |
|
| 585 | + } |
|
| 566 | 586 | // Not greater than the upper bound. |
| 567 | - elseif ($start >= $max_value) |
|
| 568 | - $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
| 587 | + elseif ($start >= $max_value) { |
|
| 588 | + $start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page))); |
|
| 589 | + } |
|
| 569 | 590 | // And it has to be a multiple of $num_per_page! |
| 570 | - else |
|
| 571 | - $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
| 591 | + else { |
|
| 592 | + $start = max(0, (int) $start - ((int) $start % (int) $num_per_page)); |
|
| 593 | + } |
|
| 572 | 594 | |
| 573 | 595 | $context['current_page'] = $start / $num_per_page; |
| 574 | 596 | |
@@ -596,101 +618,115 @@ discard block |
||
| 596 | 618 | if (empty($modSettings['compactTopicPagesEnable'])) |
| 597 | 619 | { |
| 598 | 620 | // Show the left arrow. |
| 599 | - if (empty($low_id)) |
|
| 600 | - $pageindex .= $start == 0 ? ' ' : sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
| 601 | - else |
|
| 602 | - $pageindex .= $start == 0 ? ' ' : sprintf($base_link_page, ($start - $num_per_page), $settings['page_index']['previous_page'], 'L'.$low_id); |
|
| 621 | + if (empty($low_id)) { |
|
| 622 | + $pageindex .= $start == 0 ? ' ' : sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
|
| 623 | + } else { |
|
| 624 | + $pageindex .= $start == 0 ? ' ' : sprintf($base_link_page, ($start - $num_per_page), $settings['page_index']['previous_page'], 'L'.$low_id); |
|
| 625 | + } |
|
| 603 | 626 | |
| 604 | 627 | // Show all the pages. |
| 605 | 628 | $display_page = 1; |
| 606 | - for ($counter = 0; $counter < $max_value; $counter += $num_per_page) |
|
| 607 | - $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
| 629 | + for ($counter = 0; $counter < $max_value; $counter += $num_per_page) { |
|
| 630 | + $pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++); |
|
| 631 | + } |
|
| 608 | 632 | |
| 609 | 633 | // Show the right arrow. |
| 610 | 634 | $display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page); |
| 611 | 635 | if ($start != $counter - $max_value && !$start_invalid){ |
| 612 | - if (empty($max_id)) |
|
| 613 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
| 614 | - else |
|
| 615 | - $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link_page, $display_page , $settings['page_index']['next_page'], 'M'.$max_id); |
|
| 636 | + if (empty($max_id)) { |
|
| 637 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']); |
|
| 638 | + } else { |
|
| 639 | + $pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link_page, $display_page , $settings['page_index']['next_page'], 'M'.$max_id); |
|
| 640 | + } |
|
| 616 | 641 | } |
| 617 | 642 | |
| 618 | - } |
|
| 619 | - else |
|
| 643 | + } else |
|
| 620 | 644 | { |
| 621 | 645 | // If they didn't enter an odd value, pretend they did. |
| 622 | 646 | $PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2; |
| 623 | 647 | |
| 624 | 648 | // Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page) |
| 625 | - if (!empty($start) && $show_prevnext) |
|
| 626 | - if (empty($low_id)) |
|
| 649 | + if (!empty($start) && $show_prevnext) { |
|
| 650 | + if (empty($low_id)) |
|
| 627 | 651 | $pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']); |
| 628 | - else |
|
| 629 | - $pageindex .= sprintf($base_link_page, $start - $num_per_page, $settings['page_index']['previous_page'], 'L'.$low_id); |
|
| 630 | - else |
|
| 631 | - $pageindex .= ''; |
|
| 652 | + } else { |
|
| 653 | + $pageindex .= sprintf($base_link_page, $start - $num_per_page, $settings['page_index']['previous_page'], 'L'.$low_id); |
|
| 654 | + } |
|
| 655 | + else { |
|
| 656 | + $pageindex .= ''; |
|
| 657 | + } |
|
| 632 | 658 | |
| 633 | 659 | // Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15) |
| 634 | - if ($start > $num_per_page * $PageContiguous) |
|
| 635 | - $pageindex .= sprintf($base_link, 0, '1'); |
|
| 660 | + if ($start > $num_per_page * $PageContiguous) { |
|
| 661 | + $pageindex .= sprintf($base_link, 0, '1'); |
|
| 662 | + } |
|
| 636 | 663 | |
| 637 | 664 | // Show the ... after the first page. (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page) |
| 638 | - if ($start > $num_per_page * ($PageContiguous + 1)) |
|
| 639 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 665 | + if ($start > $num_per_page * ($PageContiguous + 1)) { |
|
| 666 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 640 | 667 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
| 641 | 668 | '{FIRST_PAGE}' => $num_per_page, |
| 642 | 669 | '{LAST_PAGE}' => $start - $num_per_page * $PageContiguous, |
| 643 | 670 | '{PER_PAGE}' => $num_per_page, |
| 644 | 671 | )); |
| 672 | + } |
|
| 645 | 673 | |
| 646 | 674 | // Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page) |
| 647 | - for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) |
|
| 648 | - if ($start >= $num_per_page * $nCont) |
|
| 675 | + for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) { |
|
| 676 | + if ($start >= $num_per_page * $nCont) |
|
| 649 | 677 | { |
| 650 | 678 | $tmpStart = $start - $num_per_page * $nCont; |
| 651 | - if($nCont != 1 || empty($low_id)) |
|
| 652 | - $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
|
| 653 | - else |
|
| 654 | - $pageindex .= sprintf($base_link_page, $tmpStart, $tmpStart / $num_per_page + 1, 'L'.$low_id); |
|
| 679 | + } |
|
| 680 | + if($nCont != 1 || empty($low_id)) { |
|
| 681 | + $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
|
| 682 | + } else { |
|
| 683 | + $pageindex .= sprintf($base_link_page, $tmpStart, $tmpStart / $num_per_page + 1, 'L'.$low_id); |
|
| 684 | + } |
|
| 655 | 685 | } |
| 656 | 686 | |
| 657 | 687 | // Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page) |
| 658 | - if (!$start_invalid) |
|
| 659 | - $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
| 660 | - else |
|
| 661 | - $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
| 688 | + if (!$start_invalid) { |
|
| 689 | + $pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1); |
|
| 690 | + } else { |
|
| 691 | + $pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1); |
|
| 692 | + } |
|
| 662 | 693 | |
| 663 | 694 | // Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page) |
| 664 | 695 | $tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page; |
| 665 | - for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) |
|
| 666 | - if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
| 696 | + for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) { |
|
| 697 | + if ($start + $num_per_page * $nCont <= $tmpMaxPages) |
|
| 667 | 698 | { |
| 668 | 699 | $tmpStart = $start + $num_per_page * $nCont; |
| 669 | - if($nCont != 1 || empty($max_id)) |
|
| 670 | - $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
|
| 671 | - else |
|
| 672 | - $pageindex .= sprintf($base_link_page, $tmpStart, $tmpStart / $num_per_page + 1, 'M'.$max_id); |
|
| 700 | + } |
|
| 701 | + if($nCont != 1 || empty($max_id)) { |
|
| 702 | + $pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1); |
|
| 703 | + } else { |
|
| 704 | + $pageindex .= sprintf($base_link_page, $tmpStart, $tmpStart / $num_per_page + 1, 'M'.$max_id); |
|
| 705 | + } |
|
| 673 | 706 | } |
| 674 | 707 | |
| 675 | 708 | // Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page) |
| 676 | - if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) |
|
| 677 | - $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 709 | + if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) { |
|
| 710 | + $pageindex .= strtr($settings['page_index']['expand_pages'], array( |
|
| 678 | 711 | '{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)), |
| 679 | 712 | '{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1), |
| 680 | 713 | '{LAST_PAGE}' => $tmpMaxPages, |
| 681 | 714 | '{PER_PAGE}' => $num_per_page, |
| 682 | 715 | )); |
| 716 | + } |
|
| 683 | 717 | |
| 684 | 718 | // Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15< next page) |
| 685 | - if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) |
|
| 686 | - $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
| 719 | + if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) { |
|
| 720 | + $pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1); |
|
| 721 | + } |
|
| 687 | 722 | |
| 688 | 723 | // Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<) |
| 689 | - if ($start != $tmpMaxPages && $show_prevnext) |
|
| 690 | - if (empty($max_id)) |
|
| 724 | + if ($start != $tmpMaxPages && $show_prevnext) { |
|
| 725 | + if (empty($max_id)) |
|
| 691 | 726 | $pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']); |
| 692 | - else |
|
| 693 | - $pageindex .= sprintf($base_link_page, $start + $num_per_page, $settings['page_index']['next_page'], 'M'.$max_id); |
|
| 727 | + } else { |
|
| 728 | + $pageindex .= sprintf($base_link_page, $start + $num_per_page, $settings['page_index']['next_page'], 'M'.$max_id); |
|
| 729 | + } |
|
| 694 | 730 | } |
| 695 | 731 | $pageindex .= $settings['page_index']['extra_after']; |
| 696 | 732 | |
@@ -716,8 +752,9 @@ discard block |
||
| 716 | 752 | if ($decimal_separator === null) |
| 717 | 753 | { |
| 718 | 754 | // Not set for whatever reason? |
| 719 | - if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) |
|
| 720 | - return $number; |
|
| 755 | + if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) { |
|
| 756 | + return $number; |
|
| 757 | + } |
|
| 721 | 758 | |
| 722 | 759 | // Cache these each load... |
| 723 | 760 | $thousands_separator = $matches[1]; |
@@ -751,17 +788,20 @@ discard block |
||
| 751 | 788 | static $local_cache; |
| 752 | 789 | |
| 753 | 790 | // Offset the time. |
| 754 | - if (!$offset_type) |
|
| 755 | - $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
| 791 | + if (!$offset_type) { |
|
| 792 | + $time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600; |
|
| 793 | + } |
|
| 756 | 794 | // Just the forum offset? |
| 757 | - elseif ($offset_type == 'forum') |
|
| 758 | - $time = $log_time + $modSettings['time_offset'] * 3600; |
|
| 759 | - else |
|
| 760 | - $time = $log_time; |
|
| 795 | + elseif ($offset_type == 'forum') { |
|
| 796 | + $time = $log_time + $modSettings['time_offset'] * 3600; |
|
| 797 | + } else { |
|
| 798 | + $time = $log_time; |
|
| 799 | + } |
|
| 761 | 800 | |
| 762 | 801 | // We can't have a negative date (on Windows, at least.) |
| 763 | - if ($log_time < 0) |
|
| 764 | - $log_time = 0; |
|
| 802 | + if ($log_time < 0) { |
|
| 803 | + $log_time = 0; |
|
| 804 | + } |
|
| 765 | 805 | |
| 766 | 806 | // Today and Yesterday? |
| 767 | 807 | if ($modSettings['todayMod'] >= 1 && $show_today === true) |
@@ -778,56 +818,65 @@ discard block |
||
| 778 | 818 | { |
| 779 | 819 | $h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l'; |
| 780 | 820 | $today_fmt = $h . ':%M' . $s . ' %p'; |
| 821 | + } else { |
|
| 822 | + $today_fmt = '%H:%M' . $s; |
|
| 781 | 823 | } |
| 782 | - else |
|
| 783 | - $today_fmt = '%H:%M' . $s; |
|
| 784 | 824 | |
| 785 | 825 | // Same day of the year, same year.... Today! |
| 786 | - if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) |
|
| 787 | - return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 826 | + if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) { |
|
| 827 | + return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 828 | + } |
|
| 788 | 829 | |
| 789 | 830 | // Day-of-year is one less and same year, or it's the first of the year and that's the last of the year... |
| 790 | - if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) |
|
| 791 | - return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 831 | + if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) { |
|
| 832 | + return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type); |
|
| 833 | + } |
|
| 792 | 834 | } |
| 793 | 835 | |
| 794 | 836 | $str = !is_bool($show_today) ? $show_today : $user_info['time_format']; |
| 795 | 837 | |
| 796 | - if (!isset($local_cache)) |
|
| 797 | - $local_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
| 838 | + if (!isset($local_cache)) { |
|
| 839 | + $local_cache = setlocale(LC_TIME, $txt['lang_locale']); |
|
| 840 | + } |
|
| 798 | 841 | |
| 799 | 842 | if ($local_cache !== false) |
| 800 | 843 | { |
| 801 | 844 | //check if other process change the local |
| 802 | 845 | if ($process_safe === true) |
| 803 | 846 | { |
| 804 | - if (setlocale(LC_TIME, '0') != $local_cache) |
|
| 805 | - setlocale(LC_TIME, $txt['lang_locale']); |
|
| 847 | + if (setlocale(LC_TIME, '0') != $local_cache) { |
|
| 848 | + setlocale(LC_TIME, $txt['lang_locale']); |
|
| 849 | + } |
|
| 806 | 850 | } |
| 807 | 851 | |
| 808 | - if (!isset($non_twelve_hour)) |
|
| 809 | - $non_twelve_hour = trim(strftime('%p')) === ''; |
|
| 810 | - if ($non_twelve_hour && strpos($str, '%p') !== false) |
|
| 811 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 852 | + if (!isset($non_twelve_hour)) { |
|
| 853 | + $non_twelve_hour = trim(strftime('%p')) === ''; |
|
| 854 | + } |
|
| 855 | + if ($non_twelve_hour && strpos($str, '%p') !== false) { |
|
| 856 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 857 | + } |
|
| 812 | 858 | |
| 813 | - foreach (array('%a', '%A', '%b', '%B') as $token) |
|
| 814 | - if (strpos($str, $token) !== false) |
|
| 859 | + foreach (array('%a', '%A', '%b', '%B') as $token) { |
|
| 860 | + if (strpos($str, $token) !== false) |
|
| 815 | 861 | $str = str_replace($token, strftime($token, $time), $str); |
| 816 | - } |
|
| 817 | - else |
|
| 862 | + } |
|
| 863 | + } else |
|
| 818 | 864 | { |
| 819 | 865 | // Do-it-yourself time localization. Fun. |
| 820 | - foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) |
|
| 821 | - if (strpos($str, $token) !== false) |
|
| 866 | + foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) { |
|
| 867 | + if (strpos($str, $token) !== false) |
|
| 822 | 868 | $str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str); |
| 869 | + } |
|
| 823 | 870 | |
| 824 | - if (strpos($str, '%p') !== false) |
|
| 825 | - $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 871 | + if (strpos($str, '%p') !== false) { |
|
| 872 | + $str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str); |
|
| 873 | + } |
|
| 826 | 874 | } |
| 827 | 875 | |
| 828 | 876 | // Windows doesn't support %e; on some versions, strftime fails altogether if used, so let's prevent that. |
| 829 | - if ($context['server']['is_windows'] && strpos($str, '%e') !== false) |
|
| 830 | - $str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str); |
|
| 877 | + if ($context['server']['is_windows'] && strpos($str, '%e') !== false) { |
|
| 878 | + $str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str); |
|
| 879 | + } |
|
| 831 | 880 | |
| 832 | 881 | // Format any other characters.. |
| 833 | 882 | return strftime($str, $time); |
@@ -849,16 +898,19 @@ discard block |
||
| 849 | 898 | static $translation = array(); |
| 850 | 899 | |
| 851 | 900 | // Determine the character set... Default to UTF-8 |
| 852 | - if (empty($context['character_set'])) |
|
| 853 | - $charset = 'UTF-8'; |
|
| 901 | + if (empty($context['character_set'])) { |
|
| 902 | + $charset = 'UTF-8'; |
|
| 903 | + } |
|
| 854 | 904 | // Use ISO-8859-1 in place of non-supported ISO-8859 charsets... |
| 855 | - elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) |
|
| 856 | - $charset = 'ISO-8859-1'; |
|
| 857 | - else |
|
| 858 | - $charset = $context['character_set']; |
|
| 905 | + elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) { |
|
| 906 | + $charset = 'ISO-8859-1'; |
|
| 907 | + } else { |
|
| 908 | + $charset = $context['character_set']; |
|
| 909 | + } |
|
| 859 | 910 | |
| 860 | - if (empty($translation)) |
|
| 861 | - $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
| 911 | + if (empty($translation)) { |
|
| 912 | + $translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array(''' => '\'', ''' => '\'', ' ' => ' '); |
|
| 913 | + } |
|
| 862 | 914 | |
| 863 | 915 | return strtr($string, $translation); |
| 864 | 916 | } |
@@ -880,8 +932,9 @@ discard block |
||
| 880 | 932 | global $smcFunc; |
| 881 | 933 | |
| 882 | 934 | // It was already short enough! |
| 883 | - if ($smcFunc['strlen']($subject) <= $len) |
|
| 884 | - return $subject; |
|
| 935 | + if ($smcFunc['strlen']($subject) <= $len) { |
|
| 936 | + return $subject; |
|
| 937 | + } |
|
| 885 | 938 | |
| 886 | 939 | // Shorten it by the length it was too long, and strip off junk from the end. |
| 887 | 940 | return $smcFunc['substr']($subject, 0, $len) . '...'; |
@@ -900,10 +953,11 @@ discard block |
||
| 900 | 953 | { |
| 901 | 954 | global $user_info, $modSettings; |
| 902 | 955 | |
| 903 | - if ($timestamp === null) |
|
| 904 | - $timestamp = time(); |
|
| 905 | - elseif ($timestamp == 0) |
|
| 906 | - return 0; |
|
| 956 | + if ($timestamp === null) { |
|
| 957 | + $timestamp = time(); |
|
| 958 | + } elseif ($timestamp == 0) { |
|
| 959 | + return 0; |
|
| 960 | + } |
|
| 907 | 961 | |
| 908 | 962 | return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600; |
| 909 | 963 | } |
@@ -932,8 +986,9 @@ discard block |
||
| 932 | 986 | $array[$i] = $array[$j]; |
| 933 | 987 | $array[$j] = $temp; |
| 934 | 988 | |
| 935 | - for ($i = 1; $p[$i] == 0; $i++) |
|
| 936 | - $p[$i] = 1; |
|
| 989 | + for ($i = 1; $p[$i] == 0; $i++) { |
|
| 990 | + $p[$i] = 1; |
|
| 991 | + } |
|
| 937 | 992 | |
| 938 | 993 | $orders[] = $array; |
| 939 | 994 | } |
@@ -965,12 +1020,14 @@ discard block |
||
| 965 | 1020 | static $disabled; |
| 966 | 1021 | |
| 967 | 1022 | // Don't waste cycles |
| 968 | - if ($message === '') |
|
| 969 | - return ''; |
|
| 1023 | + if ($message === '') { |
|
| 1024 | + return ''; |
|
| 1025 | + } |
|
| 970 | 1026 | |
| 971 | 1027 | // Just in case it wasn't determined yet whether UTF-8 is enabled. |
| 972 | - if (!isset($context['utf8'])) |
|
| 973 | - $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
| 1028 | + if (!isset($context['utf8'])) { |
|
| 1029 | + $context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8'; |
|
| 1030 | + } |
|
| 974 | 1031 | |
| 975 | 1032 | // Clean up any cut/paste issues we may have |
| 976 | 1033 | $message = sanitizeMSCutPaste($message); |
@@ -982,13 +1039,15 @@ discard block |
||
| 982 | 1039 | return $message; |
| 983 | 1040 | } |
| 984 | 1041 | |
| 985 | - if ($smileys !== null && ($smileys == '1' || $smileys == '0')) |
|
| 986 | - $smileys = (bool) $smileys; |
|
| 1042 | + if ($smileys !== null && ($smileys == '1' || $smileys == '0')) { |
|
| 1043 | + $smileys = (bool) $smileys; |
|
| 1044 | + } |
|
| 987 | 1045 | |
| 988 | 1046 | if (empty($modSettings['enableBBC']) && $message !== false) |
| 989 | 1047 | { |
| 990 | - if ($smileys === true) |
|
| 991 | - parsesmileys($message); |
|
| 1048 | + if ($smileys === true) { |
|
| 1049 | + parsesmileys($message); |
|
| 1050 | + } |
|
| 992 | 1051 | |
| 993 | 1052 | return $message; |
| 994 | 1053 | } |
@@ -1001,8 +1060,9 @@ discard block |
||
| 1001 | 1060 | } |
| 1002 | 1061 | |
| 1003 | 1062 | // Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker |
| 1004 | - if (!empty($modSettings['autoLinkUrls'])) |
|
| 1005 | - set_tld_regex(); |
|
| 1063 | + if (!empty($modSettings['autoLinkUrls'])) { |
|
| 1064 | + set_tld_regex(); |
|
| 1065 | + } |
|
| 1006 | 1066 | |
| 1007 | 1067 | // Allow mods access before entering the main parse_bbc loop |
| 1008 | 1068 | call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
@@ -1016,12 +1076,14 @@ discard block |
||
| 1016 | 1076 | |
| 1017 | 1077 | $temp = explode(',', strtolower($modSettings['disabledBBC'])); |
| 1018 | 1078 | |
| 1019 | - foreach ($temp as $tag) |
|
| 1020 | - $disabled[trim($tag)] = true; |
|
| 1079 | + foreach ($temp as $tag) { |
|
| 1080 | + $disabled[trim($tag)] = true; |
|
| 1081 | + } |
|
| 1021 | 1082 | } |
| 1022 | 1083 | |
| 1023 | - if (empty($modSettings['enableEmbeddedFlash'])) |
|
| 1024 | - $disabled['flash'] = true; |
|
| 1084 | + if (empty($modSettings['enableEmbeddedFlash'])) { |
|
| 1085 | + $disabled['flash'] = true; |
|
| 1086 | + } |
|
| 1025 | 1087 | |
| 1026 | 1088 | /* The following bbc are formatted as an array, with keys as follows: |
| 1027 | 1089 | |
@@ -1142,8 +1204,9 @@ discard block |
||
| 1142 | 1204 | $returnContext = ''; |
| 1143 | 1205 | |
| 1144 | 1206 | // BBC or the entire attachments feature is disabled |
| 1145 | - if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) |
|
| 1146 | - return $data; |
|
| 1207 | + if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) { |
|
| 1208 | + return $data; |
|
| 1209 | + } |
|
| 1147 | 1210 | |
| 1148 | 1211 | // Save the attach ID. |
| 1149 | 1212 | $attachID = $data; |
@@ -1154,8 +1217,9 @@ discard block |
||
| 1154 | 1217 | $currentAttachment = parseAttachBBC($attachID); |
| 1155 | 1218 | |
| 1156 | 1219 | // parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do. |
| 1157 | - if (is_string($currentAttachment)) |
|
| 1158 | - return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
| 1220 | + if (is_string($currentAttachment)) { |
|
| 1221 | + return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment; |
|
| 1222 | + } |
|
| 1159 | 1223 | |
| 1160 | 1224 | if (!empty($currentAttachment['is_image'])) |
| 1161 | 1225 | { |
@@ -1171,15 +1235,17 @@ discard block |
||
| 1171 | 1235 | $height = ' height="' . $currentAttachment['height'] . '"'; |
| 1172 | 1236 | } |
| 1173 | 1237 | |
| 1174 | - if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) |
|
| 1175 | - $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
| 1176 | - else |
|
| 1177 | - $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
| 1238 | + if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) { |
|
| 1239 | + $returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>'; |
|
| 1240 | + } else { |
|
| 1241 | + $returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>'; |
|
| 1242 | + } |
|
| 1178 | 1243 | } |
| 1179 | 1244 | |
| 1180 | 1245 | // No image. Show a link. |
| 1181 | - else |
|
| 1182 | - $returnContext .= $currentAttachment['link']; |
|
| 1246 | + else { |
|
| 1247 | + $returnContext .= $currentAttachment['link']; |
|
| 1248 | + } |
|
| 1183 | 1249 | |
| 1184 | 1250 | // Gotta append what we just did. |
| 1185 | 1251 | $data = $returnContext; |
@@ -1210,8 +1276,9 @@ discard block |
||
| 1210 | 1276 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
| 1211 | 1277 | { |
| 1212 | 1278 | // Do PHP code coloring? |
| 1213 | - if ($php_parts[$php_i] != '<?php') |
|
| 1214 | - continue; |
|
| 1279 | + if ($php_parts[$php_i] != '<?php') { |
|
| 1280 | + continue; |
|
| 1281 | + } |
|
| 1215 | 1282 | |
| 1216 | 1283 | $php_string = ''; |
| 1217 | 1284 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1227,8 +1294,9 @@ discard block |
||
| 1227 | 1294 | $data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data); |
| 1228 | 1295 | |
| 1229 | 1296 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
| 1230 | - if ($context['browser']['is_opera']) |
|
| 1231 | - $data .= ' '; |
|
| 1297 | + if ($context['browser']['is_opera']) { |
|
| 1298 | + $data .= ' '; |
|
| 1299 | + } |
|
| 1232 | 1300 | } |
| 1233 | 1301 | }, |
| 1234 | 1302 | 'block_level' => true, |
@@ -1247,8 +1315,9 @@ discard block |
||
| 1247 | 1315 | for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++) |
| 1248 | 1316 | { |
| 1249 | 1317 | // Do PHP code coloring? |
| 1250 | - if ($php_parts[$php_i] != '<?php') |
|
| 1251 | - continue; |
|
| 1318 | + if ($php_parts[$php_i] != '<?php') { |
|
| 1319 | + continue; |
|
| 1320 | + } |
|
| 1252 | 1321 | |
| 1253 | 1322 | $php_string = ''; |
| 1254 | 1323 | while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?>') |
@@ -1264,8 +1333,9 @@ discard block |
||
| 1264 | 1333 | $data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]); |
| 1265 | 1334 | |
| 1266 | 1335 | // Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection. |
| 1267 | - if ($context['browser']['is_opera']) |
|
| 1268 | - $data[0] .= ' '; |
|
| 1336 | + if ($context['browser']['is_opera']) { |
|
| 1337 | + $data[0] .= ' '; |
|
| 1338 | + } |
|
| 1269 | 1339 | } |
| 1270 | 1340 | }, |
| 1271 | 1341 | 'block_level' => true, |
@@ -1303,11 +1373,13 @@ discard block |
||
| 1303 | 1373 | 'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">', |
| 1304 | 1374 | 'validate' => function (&$tag, &$data, $disabled) |
| 1305 | 1375 | { |
| 1306 | - if (isset($disabled['url'])) |
|
| 1307 | - $tag['content'] = '$1'; |
|
| 1376 | + if (isset($disabled['url'])) { |
|
| 1377 | + $tag['content'] = '$1'; |
|
| 1378 | + } |
|
| 1308 | 1379 | $scheme = parse_url($data[0], PHP_URL_SCHEME); |
| 1309 | - if (empty($scheme)) |
|
| 1310 | - $data[0] = '//' . ltrim($data[0], ':/'); |
|
| 1380 | + if (empty($scheme)) { |
|
| 1381 | + $data[0] = '//' . ltrim($data[0], ':/'); |
|
| 1382 | + } |
|
| 1311 | 1383 | }, |
| 1312 | 1384 | 'disabled_content' => '<a href="$1" target="_blank" class="new_win">$1</a>', |
| 1313 | 1385 | ), |
@@ -1321,10 +1393,11 @@ discard block |
||
| 1321 | 1393 | { |
| 1322 | 1394 | $class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"'; |
| 1323 | 1395 | |
| 1324 | - if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) |
|
| 1325 | - $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
| 1326 | - else |
|
| 1327 | - $css = ''; |
|
| 1396 | + if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) { |
|
| 1397 | + $css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"'; |
|
| 1398 | + } else { |
|
| 1399 | + $css = ''; |
|
| 1400 | + } |
|
| 1328 | 1401 | |
| 1329 | 1402 | $data = $class . $css; |
| 1330 | 1403 | }, |
@@ -1374,14 +1447,16 @@ discard block |
||
| 1374 | 1447 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1375 | 1448 | if ($image_proxy_enabled) |
| 1376 | 1449 | { |
| 1377 | - if (empty($scheme)) |
|
| 1378 | - $data = 'http://' . ltrim($data, ':/'); |
|
| 1450 | + if (empty($scheme)) { |
|
| 1451 | + $data = 'http://' . ltrim($data, ':/'); |
|
| 1452 | + } |
|
| 1379 | 1453 | |
| 1380 | - if ($scheme != 'https') |
|
| 1381 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
| 1454 | + if ($scheme != 'https') { |
|
| 1455 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
| 1456 | + } |
|
| 1457 | + } elseif (empty($scheme)) { |
|
| 1458 | + $data = '//' . ltrim($data, ':/'); |
|
| 1382 | 1459 | } |
| 1383 | - elseif (empty($scheme)) |
|
| 1384 | - $data = '//' . ltrim($data, ':/'); |
|
| 1385 | 1460 | }, |
| 1386 | 1461 | 'disabled_content' => '($1)', |
| 1387 | 1462 | ), |
@@ -1397,14 +1472,16 @@ discard block |
||
| 1397 | 1472 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1398 | 1473 | if ($image_proxy_enabled) |
| 1399 | 1474 | { |
| 1400 | - if (empty($scheme)) |
|
| 1401 | - $data = 'http://' . ltrim($data, ':/'); |
|
| 1475 | + if (empty($scheme)) { |
|
| 1476 | + $data = 'http://' . ltrim($data, ':/'); |
|
| 1477 | + } |
|
| 1402 | 1478 | |
| 1403 | - if ($scheme != 'https') |
|
| 1404 | - $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
| 1479 | + if ($scheme != 'https') { |
|
| 1480 | + $data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret); |
|
| 1481 | + } |
|
| 1482 | + } elseif (empty($scheme)) { |
|
| 1483 | + $data = '//' . ltrim($data, ':/'); |
|
| 1405 | 1484 | } |
| 1406 | - elseif (empty($scheme)) |
|
| 1407 | - $data = '//' . ltrim($data, ':/'); |
|
| 1408 | 1485 | }, |
| 1409 | 1486 | 'disabled_content' => '($1)', |
| 1410 | 1487 | ), |
@@ -1416,8 +1493,9 @@ discard block |
||
| 1416 | 1493 | { |
| 1417 | 1494 | $data = strtr($data, array('<br>' => '')); |
| 1418 | 1495 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1419 | - if (empty($scheme)) |
|
| 1420 | - $data = '//' . ltrim($data, ':/'); |
|
| 1496 | + if (empty($scheme)) { |
|
| 1497 | + $data = '//' . ltrim($data, ':/'); |
|
| 1498 | + } |
|
| 1421 | 1499 | }, |
| 1422 | 1500 | ), |
| 1423 | 1501 | array( |
@@ -1428,13 +1506,14 @@ discard block |
||
| 1428 | 1506 | 'after' => '</a>', |
| 1429 | 1507 | 'validate' => function (&$tag, &$data, $disabled) |
| 1430 | 1508 | { |
| 1431 | - if (substr($data, 0, 1) == '#') |
|
| 1432 | - $data = '#post_' . substr($data, 1); |
|
| 1433 | - else |
|
| 1509 | + if (substr($data, 0, 1) == '#') { |
|
| 1510 | + $data = '#post_' . substr($data, 1); |
|
| 1511 | + } else |
|
| 1434 | 1512 | { |
| 1435 | 1513 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1436 | - if (empty($scheme)) |
|
| 1437 | - $data = '//' . ltrim($data, ':/'); |
|
| 1514 | + if (empty($scheme)) { |
|
| 1515 | + $data = '//' . ltrim($data, ':/'); |
|
| 1516 | + } |
|
| 1438 | 1517 | } |
| 1439 | 1518 | }, |
| 1440 | 1519 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
@@ -1512,8 +1591,9 @@ discard block |
||
| 1512 | 1591 | { |
| 1513 | 1592 | $add_begin = substr(trim($data), 0, 5) != '<?'; |
| 1514 | 1593 | $data = highlight_php_code($add_begin ? '<?php ' . $data . '?>' : $data); |
| 1515 | - if ($add_begin) |
|
| 1516 | - $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
| 1594 | + if ($add_begin) { |
|
| 1595 | + $data = preg_replace(array('~^(.+?)<\?.{0,40}?php(?: |\s)~', '~\?>((?:</(font|span)>)*)$~'), '$1', $data, 2); |
|
| 1596 | + } |
|
| 1517 | 1597 | } |
| 1518 | 1598 | }, |
| 1519 | 1599 | 'block_level' => false, |
@@ -1644,10 +1724,11 @@ discard block |
||
| 1644 | 1724 | 'content' => '$1', |
| 1645 | 1725 | 'validate' => function (&$tag, &$data, $disabled) |
| 1646 | 1726 | { |
| 1647 | - if (is_numeric($data)) |
|
| 1648 | - $data = timeformat($data); |
|
| 1649 | - else |
|
| 1650 | - $tag['content'] = '[time]$1[/time]'; |
|
| 1727 | + if (is_numeric($data)) { |
|
| 1728 | + $data = timeformat($data); |
|
| 1729 | + } else { |
|
| 1730 | + $tag['content'] = '[time]$1[/time]'; |
|
| 1731 | + } |
|
| 1651 | 1732 | }, |
| 1652 | 1733 | ), |
| 1653 | 1734 | array( |
@@ -1674,8 +1755,9 @@ discard block |
||
| 1674 | 1755 | { |
| 1675 | 1756 | $data = strtr($data, array('<br>' => '')); |
| 1676 | 1757 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1677 | - if (empty($scheme)) |
|
| 1678 | - $data = '//' . ltrim($data, ':/'); |
|
| 1758 | + if (empty($scheme)) { |
|
| 1759 | + $data = '//' . ltrim($data, ':/'); |
|
| 1760 | + } |
|
| 1679 | 1761 | }, |
| 1680 | 1762 | ), |
| 1681 | 1763 | array( |
@@ -1687,8 +1769,9 @@ discard block |
||
| 1687 | 1769 | 'validate' => function (&$tag, &$data, $disabled) |
| 1688 | 1770 | { |
| 1689 | 1771 | $scheme = parse_url($data, PHP_URL_SCHEME); |
| 1690 | - if (empty($scheme)) |
|
| 1691 | - $data = '//' . ltrim($data, ':/'); |
|
| 1772 | + if (empty($scheme)) { |
|
| 1773 | + $data = '//' . ltrim($data, ':/'); |
|
| 1774 | + } |
|
| 1692 | 1775 | }, |
| 1693 | 1776 | 'disallow_children' => array('email', 'ftp', 'url', 'iurl'), |
| 1694 | 1777 | 'disabled_after' => ' ($1)', |
@@ -1708,8 +1791,9 @@ discard block |
||
| 1708 | 1791 | // This is mainly for the bbc manager, so it's easy to add tags above. Custom BBC should be added above this line. |
| 1709 | 1792 | if ($message === false) |
| 1710 | 1793 | { |
| 1711 | - if (isset($temp_bbc)) |
|
| 1712 | - $bbc_codes = $temp_bbc; |
|
| 1794 | + if (isset($temp_bbc)) { |
|
| 1795 | + $bbc_codes = $temp_bbc; |
|
| 1796 | + } |
|
| 1713 | 1797 | usort($codes, function ($a, $b) { |
| 1714 | 1798 | return strcmp($a['tag'], $b['tag']); |
| 1715 | 1799 | }); |
@@ -1729,8 +1813,9 @@ discard block |
||
| 1729 | 1813 | ); |
| 1730 | 1814 | if (!isset($disabled['li']) && !isset($disabled['list'])) |
| 1731 | 1815 | { |
| 1732 | - foreach ($itemcodes as $c => $dummy) |
|
| 1733 | - $bbc_codes[$c] = array(); |
|
| 1816 | + foreach ($itemcodes as $c => $dummy) { |
|
| 1817 | + $bbc_codes[$c] = array(); |
|
| 1818 | + } |
|
| 1734 | 1819 | } |
| 1735 | 1820 | |
| 1736 | 1821 | // Shhhh! |
@@ -1751,12 +1836,14 @@ discard block |
||
| 1751 | 1836 | foreach ($codes as $code) |
| 1752 | 1837 | { |
| 1753 | 1838 | // Make it easier to process parameters later |
| 1754 | - if (!empty($code['parameters'])) |
|
| 1755 | - ksort($code['parameters'], SORT_STRING); |
|
| 1839 | + if (!empty($code['parameters'])) { |
|
| 1840 | + ksort($code['parameters'], SORT_STRING); |
|
| 1841 | + } |
|
| 1756 | 1842 | |
| 1757 | 1843 | // If we are not doing every tag only do ones we are interested in. |
| 1758 | - if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) |
|
| 1759 | - $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
| 1844 | + if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) { |
|
| 1845 | + $bbc_codes[substr($code['tag'], 0, 1)][] = $code; |
|
| 1846 | + } |
|
| 1760 | 1847 | } |
| 1761 | 1848 | $codes = null; |
| 1762 | 1849 | } |
@@ -1767,8 +1854,9 @@ discard block |
||
| 1767 | 1854 | // It's likely this will change if the message is modified. |
| 1768 | 1855 | $cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . json_encode($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']); |
| 1769 | 1856 | |
| 1770 | - if (($temp = cache_get_data($cache_key, 240)) != null) |
|
| 1771 | - return $temp; |
|
| 1857 | + if (($temp = cache_get_data($cache_key, 240)) != null) { |
|
| 1858 | + return $temp; |
|
| 1859 | + } |
|
| 1772 | 1860 | |
| 1773 | 1861 | $cache_t = microtime(); |
| 1774 | 1862 | } |
@@ -1800,8 +1888,9 @@ discard block |
||
| 1800 | 1888 | $disabled['flash'] = true; |
| 1801 | 1889 | |
| 1802 | 1890 | // @todo Change maybe? |
| 1803 | - if (!isset($_GET['images'])) |
|
| 1804 | - $disabled['img'] = true; |
|
| 1891 | + if (!isset($_GET['images'])) { |
|
| 1892 | + $disabled['img'] = true; |
|
| 1893 | + } |
|
| 1805 | 1894 | |
| 1806 | 1895 | // @todo Interface/setting to add more? |
| 1807 | 1896 | } |
@@ -1825,8 +1914,9 @@ discard block |
||
| 1825 | 1914 | $pos = isset($matches[0][1]) ? $matches[0][1] : false; |
| 1826 | 1915 | |
| 1827 | 1916 | // Failsafe. |
| 1828 | - if ($pos === false || $last_pos > $pos) |
|
| 1829 | - $pos = strlen($message) + 1; |
|
| 1917 | + if ($pos === false || $last_pos > $pos) { |
|
| 1918 | + $pos = strlen($message) + 1; |
|
| 1919 | + } |
|
| 1830 | 1920 | |
| 1831 | 1921 | // Can't have a one letter smiley, URL, or email! (sorry.) |
| 1832 | 1922 | if ($last_pos < $pos - 1) |
@@ -1845,8 +1935,9 @@ discard block |
||
| 1845 | 1935 | |
| 1846 | 1936 | // <br> should be empty. |
| 1847 | 1937 | $empty_tags = array('br', 'hr'); |
| 1848 | - foreach ($empty_tags as $tag) |
|
| 1849 | - $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '[' . $tag . ' /]', $data); |
|
| 1938 | + foreach ($empty_tags as $tag) { |
|
| 1939 | + $data = str_replace(array('<' . $tag . '>', '<' . $tag . '/>', '<' . $tag . ' />'), '[' . $tag . ' /]', $data); |
|
| 1940 | + } |
|
| 1850 | 1941 | |
| 1851 | 1942 | // b, u, i, s, pre... basic tags. |
| 1852 | 1943 | $closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote'); |
@@ -1855,8 +1946,9 @@ discard block |
||
| 1855 | 1946 | $diff = substr_count($data, '<' . $tag . '>') - substr_count($data, '</' . $tag . '>'); |
| 1856 | 1947 | $data = strtr($data, array('<' . $tag . '>' => '<' . $tag . '>', '</' . $tag . '>' => '</' . $tag . '>')); |
| 1857 | 1948 | |
| 1858 | - if ($diff > 0) |
|
| 1859 | - $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
| 1949 | + if ($diff > 0) { |
|
| 1950 | + $data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1); |
|
| 1951 | + } |
|
| 1860 | 1952 | } |
| 1861 | 1953 | |
| 1862 | 1954 | // Do <img ...> - with security... action= -> action-. |
@@ -1869,8 +1961,9 @@ discard block |
||
| 1869 | 1961 | $alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^"|"$~', '', $matches[3][$match]); |
| 1870 | 1962 | |
| 1871 | 1963 | // Remove action= from the URL - no funny business, now. |
| 1872 | - if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) |
|
| 1873 | - $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
| 1964 | + if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) { |
|
| 1965 | + $imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag); |
|
| 1966 | + } |
|
| 1874 | 1967 | |
| 1875 | 1968 | // Check if the image is larger than allowed. |
| 1876 | 1969 | if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height'])) |
@@ -1891,9 +1984,9 @@ discard block |
||
| 1891 | 1984 | |
| 1892 | 1985 | // Set the new image tag. |
| 1893 | 1986 | $replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]'; |
| 1987 | + } else { |
|
| 1988 | + $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
| 1894 | 1989 | } |
| 1895 | - else |
|
| 1896 | - $replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]'; |
|
| 1897 | 1990 | } |
| 1898 | 1991 | |
| 1899 | 1992 | $data = strtr($data, $replaces); |
@@ -1906,16 +1999,18 @@ discard block |
||
| 1906 | 1999 | $no_autolink_area = false; |
| 1907 | 2000 | if (!empty($open_tags)) |
| 1908 | 2001 | { |
| 1909 | - foreach ($open_tags as $open_tag) |
|
| 1910 | - if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
| 2002 | + foreach ($open_tags as $open_tag) { |
|
| 2003 | + if (in_array($open_tag['tag'], $no_autolink_tags)) |
|
| 1911 | 2004 | $no_autolink_area = true; |
| 2005 | + } |
|
| 1912 | 2006 | } |
| 1913 | 2007 | |
| 1914 | 2008 | // Don't go backwards. |
| 1915 | 2009 | // @todo Don't think is the real solution.... |
| 1916 | 2010 | $lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0; |
| 1917 | - if ($pos < $lastAutoPos) |
|
| 1918 | - $no_autolink_area = true; |
|
| 2011 | + if ($pos < $lastAutoPos) { |
|
| 2012 | + $no_autolink_area = true; |
|
| 2013 | + } |
|
| 1919 | 2014 | $lastAutoPos = $pos; |
| 1920 | 2015 | |
| 1921 | 2016 | if (!$no_autolink_area) |
@@ -2024,17 +2119,19 @@ discard block |
||
| 2024 | 2119 | if ($scheme == 'mailto') |
| 2025 | 2120 | { |
| 2026 | 2121 | $email_address = str_replace('mailto:', '', $url); |
| 2027 | - if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) |
|
| 2028 | - return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
| 2029 | - else |
|
| 2030 | - return $url; |
|
| 2122 | + if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) { |
|
| 2123 | + return '[email=' . $email_address . ']' . $url . '[/email]'; |
|
| 2124 | + } else { |
|
| 2125 | + return $url; |
|
| 2126 | + } |
|
| 2031 | 2127 | } |
| 2032 | 2128 | |
| 2033 | 2129 | // Are we linking a schemeless URL or naked domain name (e.g. "example.com")? |
| 2034 | - if (empty($scheme)) |
|
| 2035 | - $fullUrl = '//' . ltrim($url, ':/'); |
|
| 2036 | - else |
|
| 2037 | - $fullUrl = $url; |
|
| 2130 | + if (empty($scheme)) { |
|
| 2131 | + $fullUrl = '//' . ltrim($url, ':/'); |
|
| 2132 | + } else { |
|
| 2133 | + $fullUrl = $url; |
|
| 2134 | + } |
|
| 2038 | 2135 | |
| 2039 | 2136 | return '[url="' . str_replace(array('[', ']'), array('[', ']'), $fullUrl) . '"]' . $url . '[/url]'; |
| 2040 | 2137 | }, $data); |
@@ -2083,16 +2180,18 @@ discard block |
||
| 2083 | 2180 | } |
| 2084 | 2181 | |
| 2085 | 2182 | // Are we there yet? Are we there yet? |
| 2086 | - if ($pos >= strlen($message) - 1) |
|
| 2087 | - break; |
|
| 2183 | + if ($pos >= strlen($message) - 1) { |
|
| 2184 | + break; |
|
| 2185 | + } |
|
| 2088 | 2186 | |
| 2089 | 2187 | $tags = strtolower($message[$pos + 1]); |
| 2090 | 2188 | |
| 2091 | 2189 | if ($tags == '/' && !empty($open_tags)) |
| 2092 | 2190 | { |
| 2093 | 2191 | $pos2 = strpos($message, ']', $pos + 1); |
| 2094 | - if ($pos2 == $pos + 2) |
|
| 2095 | - continue; |
|
| 2192 | + if ($pos2 == $pos + 2) { |
|
| 2193 | + continue; |
|
| 2194 | + } |
|
| 2096 | 2195 | |
| 2097 | 2196 | $look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2)); |
| 2098 | 2197 | |
@@ -2102,8 +2201,9 @@ discard block |
||
| 2102 | 2201 | do |
| 2103 | 2202 | { |
| 2104 | 2203 | $tag = array_pop($open_tags); |
| 2105 | - if (!$tag) |
|
| 2106 | - break; |
|
| 2204 | + if (!$tag) { |
|
| 2205 | + break; |
|
| 2206 | + } |
|
| 2107 | 2207 | |
| 2108 | 2208 | if (!empty($tag['block_level'])) |
| 2109 | 2209 | { |
@@ -2117,10 +2217,11 @@ discard block |
||
| 2117 | 2217 | // The idea is, if we are LOOKING for a block level tag, we can close them on the way. |
| 2118 | 2218 | if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]])) |
| 2119 | 2219 | { |
| 2120 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
| 2121 | - if ($temp['tag'] == $look_for) |
|
| 2220 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
| 2221 | + if ($temp['tag'] == $look_for) |
|
| 2122 | 2222 | { |
| 2123 | 2223 | $block_level = !empty($temp['block_level']); |
| 2224 | + } |
|
| 2124 | 2225 | break; |
| 2125 | 2226 | } |
| 2126 | 2227 | } |
@@ -2142,15 +2243,15 @@ discard block |
||
| 2142 | 2243 | { |
| 2143 | 2244 | $open_tags = $to_close; |
| 2144 | 2245 | continue; |
| 2145 | - } |
|
| 2146 | - elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
| 2246 | + } elseif (!empty($to_close) && $tag['tag'] != $look_for) |
|
| 2147 | 2247 | { |
| 2148 | 2248 | if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]])) |
| 2149 | 2249 | { |
| 2150 | - foreach ($bbc_codes[$look_for[0]] as $temp) |
|
| 2151 | - if ($temp['tag'] == $look_for) |
|
| 2250 | + foreach ($bbc_codes[$look_for[0]] as $temp) { |
|
| 2251 | + if ($temp['tag'] == $look_for) |
|
| 2152 | 2252 | { |
| 2153 | 2253 | $block_level = !empty($temp['block_level']); |
| 2254 | + } |
|
| 2154 | 2255 | break; |
| 2155 | 2256 | } |
| 2156 | 2257 | } |
@@ -2158,8 +2259,9 @@ discard block |
||
| 2158 | 2259 | // We're not looking for a block level tag (or maybe even a tag that exists...) |
| 2159 | 2260 | if (!$block_level) |
| 2160 | 2261 | { |
| 2161 | - foreach ($to_close as $tag) |
|
| 2162 | - array_push($open_tags, $tag); |
|
| 2262 | + foreach ($to_close as $tag) { |
|
| 2263 | + array_push($open_tags, $tag); |
|
| 2264 | + } |
|
| 2163 | 2265 | continue; |
| 2164 | 2266 | } |
| 2165 | 2267 | } |
@@ -2172,14 +2274,17 @@ discard block |
||
| 2172 | 2274 | |
| 2173 | 2275 | // See the comment at the end of the big loop - just eating whitespace ;). |
| 2174 | 2276 | $whitespace_regex = ''; |
| 2175 | - if (!empty($tag['block_level'])) |
|
| 2176 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2277 | + if (!empty($tag['block_level'])) { |
|
| 2278 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2279 | + } |
|
| 2177 | 2280 | // Trim one line of whitespace after unnested tags, but all of it after nested ones |
| 2178 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
| 2179 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2281 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
| 2282 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2283 | + } |
|
| 2180 | 2284 | |
| 2181 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
| 2182 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2285 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
| 2286 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2287 | + } |
|
| 2183 | 2288 | } |
| 2184 | 2289 | |
| 2185 | 2290 | if (!empty($to_close)) |
@@ -2192,8 +2297,9 @@ discard block |
||
| 2192 | 2297 | } |
| 2193 | 2298 | |
| 2194 | 2299 | // No tags for this character, so just keep going (fastest possible course.) |
| 2195 | - if (!isset($bbc_codes[$tags])) |
|
| 2196 | - continue; |
|
| 2300 | + if (!isset($bbc_codes[$tags])) { |
|
| 2301 | + continue; |
|
| 2302 | + } |
|
| 2197 | 2303 | |
| 2198 | 2304 | $inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1]; |
| 2199 | 2305 | $tag = null; |
@@ -2202,44 +2308,52 @@ discard block |
||
| 2202 | 2308 | $pt_strlen = strlen($possible['tag']); |
| 2203 | 2309 | |
| 2204 | 2310 | // Not a match? |
| 2205 | - if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) |
|
| 2206 | - continue; |
|
| 2311 | + if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) { |
|
| 2312 | + continue; |
|
| 2313 | + } |
|
| 2207 | 2314 | |
| 2208 | 2315 | $next_c = $message[$pos + 1 + $pt_strlen]; |
| 2209 | 2316 | |
| 2210 | 2317 | // A test validation? |
| 2211 | - if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) |
|
| 2212 | - continue; |
|
| 2318 | + if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) { |
|
| 2319 | + continue; |
|
| 2320 | + } |
|
| 2213 | 2321 | // Do we want parameters? |
| 2214 | 2322 | elseif (!empty($possible['parameters'])) |
| 2215 | 2323 | { |
| 2216 | - if ($next_c != ' ') |
|
| 2217 | - continue; |
|
| 2218 | - } |
|
| 2219 | - elseif (isset($possible['type'])) |
|
| 2324 | + if ($next_c != ' ') { |
|
| 2325 | + continue; |
|
| 2326 | + } |
|
| 2327 | + } elseif (isset($possible['type'])) |
|
| 2220 | 2328 | { |
| 2221 | 2329 | // Do we need an equal sign? |
| 2222 | - if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') |
|
| 2223 | - continue; |
|
| 2330 | + if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') { |
|
| 2331 | + continue; |
|
| 2332 | + } |
|
| 2224 | 2333 | // Maybe we just want a /... |
| 2225 | - if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') |
|
| 2226 | - continue; |
|
| 2334 | + if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') { |
|
| 2335 | + continue; |
|
| 2336 | + } |
|
| 2227 | 2337 | // An immediate ]? |
| 2228 | - if ($possible['type'] == 'unparsed_content' && $next_c != ']') |
|
| 2229 | - continue; |
|
| 2338 | + if ($possible['type'] == 'unparsed_content' && $next_c != ']') { |
|
| 2339 | + continue; |
|
| 2340 | + } |
|
| 2230 | 2341 | } |
| 2231 | 2342 | // No type means 'parsed_content', which demands an immediate ] without parameters! |
| 2232 | - elseif ($next_c != ']') |
|
| 2233 | - continue; |
|
| 2343 | + elseif ($next_c != ']') { |
|
| 2344 | + continue; |
|
| 2345 | + } |
|
| 2234 | 2346 | |
| 2235 | 2347 | // Check allowed tree? |
| 2236 | - if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) |
|
| 2237 | - continue; |
|
| 2238 | - elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) |
|
| 2239 | - continue; |
|
| 2348 | + if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) { |
|
| 2349 | + continue; |
|
| 2350 | + } elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) { |
|
| 2351 | + continue; |
|
| 2352 | + } |
|
| 2240 | 2353 | // If this is in the list of disallowed child tags, don't parse it. |
| 2241 | - elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) |
|
| 2242 | - continue; |
|
| 2354 | + elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) { |
|
| 2355 | + continue; |
|
| 2356 | + } |
|
| 2243 | 2357 | |
| 2244 | 2358 | $pos1 = $pos + 1 + $pt_strlen + 1; |
| 2245 | 2359 | |
@@ -2251,8 +2365,9 @@ discard block |
||
| 2251 | 2365 | foreach ($open_tags as $open_quote) |
| 2252 | 2366 | { |
| 2253 | 2367 | // Every parent quote this quote has flips the styling |
| 2254 | - if ($open_quote['tag'] == 'quote') |
|
| 2255 | - $quote_alt = !$quote_alt; |
|
| 2368 | + if ($open_quote['tag'] == 'quote') { |
|
| 2369 | + $quote_alt = !$quote_alt; |
|
| 2370 | + } |
|
| 2256 | 2371 | } |
| 2257 | 2372 | // Add a class to the quote to style alternating blockquotes |
| 2258 | 2373 | $possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">')); |
@@ -2263,8 +2378,9 @@ discard block |
||
| 2263 | 2378 | { |
| 2264 | 2379 | // Build a regular expression for each parameter for the current tag. |
| 2265 | 2380 | $preg = array(); |
| 2266 | - foreach ($possible['parameters'] as $p => $info) |
|
| 2267 | - $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
| 2381 | + foreach ($possible['parameters'] as $p => $info) { |
|
| 2382 | + $preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '"') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '"') . '\s*)' . (empty($info['optional']) ? '' : '?'); |
|
| 2383 | + } |
|
| 2268 | 2384 | |
| 2269 | 2385 | // Extract the string that potentially holds our parameters. |
| 2270 | 2386 | $blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos)); |
@@ -2284,24 +2400,27 @@ discard block |
||
| 2284 | 2400 | |
| 2285 | 2401 | $match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0; |
| 2286 | 2402 | |
| 2287 | - if ($match) |
|
| 2288 | - $blob_counter = count($blobs) + 1; |
|
| 2403 | + if ($match) { |
|
| 2404 | + $blob_counter = count($blobs) + 1; |
|
| 2405 | + } |
|
| 2289 | 2406 | } |
| 2290 | 2407 | |
| 2291 | 2408 | // Didn't match our parameter list, try the next possible. |
| 2292 | - if (!$match) |
|
| 2293 | - continue; |
|
| 2409 | + if (!$match) { |
|
| 2410 | + continue; |
|
| 2411 | + } |
|
| 2294 | 2412 | |
| 2295 | 2413 | $params = array(); |
| 2296 | 2414 | for ($i = 1, $n = count($matches); $i < $n; $i += 2) |
| 2297 | 2415 | { |
| 2298 | 2416 | $key = strtok(ltrim($matches[$i]), '='); |
| 2299 | - if (isset($possible['parameters'][$key]['value'])) |
|
| 2300 | - $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
| 2301 | - elseif (isset($possible['parameters'][$key]['validate'])) |
|
| 2302 | - $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
| 2303 | - else |
|
| 2304 | - $params['{' . $key . '}'] = $matches[$i + 1]; |
|
| 2417 | + if (isset($possible['parameters'][$key]['value'])) { |
|
| 2418 | + $params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1])); |
|
| 2419 | + } elseif (isset($possible['parameters'][$key]['validate'])) { |
|
| 2420 | + $params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]); |
|
| 2421 | + } else { |
|
| 2422 | + $params['{' . $key . '}'] = $matches[$i + 1]; |
|
| 2423 | + } |
|
| 2305 | 2424 | |
| 2306 | 2425 | // Just to make sure: replace any $ or { so they can't interpolate wrongly. |
| 2307 | 2426 | $params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '$', '{' => '{')); |
@@ -2309,23 +2428,26 @@ discard block |
||
| 2309 | 2428 | |
| 2310 | 2429 | foreach ($possible['parameters'] as $p => $info) |
| 2311 | 2430 | { |
| 2312 | - if (!isset($params['{' . $p . '}'])) |
|
| 2313 | - $params['{' . $p . '}'] = ''; |
|
| 2431 | + if (!isset($params['{' . $p . '}'])) { |
|
| 2432 | + $params['{' . $p . '}'] = ''; |
|
| 2433 | + } |
|
| 2314 | 2434 | } |
| 2315 | 2435 | |
| 2316 | 2436 | $tag = $possible; |
| 2317 | 2437 | |
| 2318 | 2438 | // Put the parameters into the string. |
| 2319 | - if (isset($tag['before'])) |
|
| 2320 | - $tag['before'] = strtr($tag['before'], $params); |
|
| 2321 | - if (isset($tag['after'])) |
|
| 2322 | - $tag['after'] = strtr($tag['after'], $params); |
|
| 2323 | - if (isset($tag['content'])) |
|
| 2324 | - $tag['content'] = strtr($tag['content'], $params); |
|
| 2439 | + if (isset($tag['before'])) { |
|
| 2440 | + $tag['before'] = strtr($tag['before'], $params); |
|
| 2441 | + } |
|
| 2442 | + if (isset($tag['after'])) { |
|
| 2443 | + $tag['after'] = strtr($tag['after'], $params); |
|
| 2444 | + } |
|
| 2445 | + if (isset($tag['content'])) { |
|
| 2446 | + $tag['content'] = strtr($tag['content'], $params); |
|
| 2447 | + } |
|
| 2325 | 2448 | |
| 2326 | 2449 | $pos1 += strlen($given_param_string); |
| 2327 | - } |
|
| 2328 | - else |
|
| 2450 | + } else |
|
| 2329 | 2451 | { |
| 2330 | 2452 | $tag = $possible; |
| 2331 | 2453 | $params = array(); |
@@ -2336,8 +2458,9 @@ discard block |
||
| 2336 | 2458 | // Item codes are complicated buggers... they are implicit [li]s and can make [list]s! |
| 2337 | 2459 | if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li'])) |
| 2338 | 2460 | { |
| 2339 | - if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) |
|
| 2340 | - continue; |
|
| 2461 | + if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) { |
|
| 2462 | + continue; |
|
| 2463 | + } |
|
| 2341 | 2464 | |
| 2342 | 2465 | $tag = $itemcodes[$message[$pos + 1]]; |
| 2343 | 2466 | |
@@ -2358,9 +2481,9 @@ discard block |
||
| 2358 | 2481 | { |
| 2359 | 2482 | array_pop($open_tags); |
| 2360 | 2483 | $code = '</li>'; |
| 2484 | + } else { |
|
| 2485 | + $code = ''; |
|
| 2361 | 2486 | } |
| 2362 | - else |
|
| 2363 | - $code = ''; |
|
| 2364 | 2487 | |
| 2365 | 2488 | // Now we open a new tag. |
| 2366 | 2489 | $open_tags[] = array( |
@@ -2407,12 +2530,14 @@ discard block |
||
| 2407 | 2530 | } |
| 2408 | 2531 | |
| 2409 | 2532 | // No tag? Keep looking, then. Silly people using brackets without actual tags. |
| 2410 | - if ($tag === null) |
|
| 2411 | - continue; |
|
| 2533 | + if ($tag === null) { |
|
| 2534 | + continue; |
|
| 2535 | + } |
|
| 2412 | 2536 | |
| 2413 | 2537 | // Propagate the list to the child (so wrapping the disallowed tag won't work either.) |
| 2414 | - if (isset($inside['disallow_children'])) |
|
| 2415 | - $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
| 2538 | + if (isset($inside['disallow_children'])) { |
|
| 2539 | + $tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children']; |
|
| 2540 | + } |
|
| 2416 | 2541 | |
| 2417 | 2542 | // Is this tag disabled? |
| 2418 | 2543 | if (isset($disabled[$tag['tag']])) |
@@ -2422,14 +2547,13 @@ discard block |
||
| 2422 | 2547 | $tag['before'] = !empty($tag['block_level']) ? '<div>' : ''; |
| 2423 | 2548 | $tag['after'] = !empty($tag['block_level']) ? '</div>' : ''; |
| 2424 | 2549 | $tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1'); |
| 2425 | - } |
|
| 2426 | - elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
| 2550 | + } elseif (isset($tag['disabled_before']) || isset($tag['disabled_after'])) |
|
| 2427 | 2551 | { |
| 2428 | 2552 | $tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : ''); |
| 2429 | 2553 | $tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : ''); |
| 2554 | + } else { |
|
| 2555 | + $tag['content'] = $tag['disabled_content']; |
|
| 2430 | 2556 | } |
| 2431 | - else |
|
| 2432 | - $tag['content'] = $tag['disabled_content']; |
|
| 2433 | 2557 | } |
| 2434 | 2558 | |
| 2435 | 2559 | // we use this a lot |
@@ -2439,8 +2563,9 @@ discard block |
||
| 2439 | 2563 | if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level'])) |
| 2440 | 2564 | { |
| 2441 | 2565 | $n = count($open_tags) - 1; |
| 2442 | - while (empty($open_tags[$n]['block_level']) && $n >= 0) |
|
| 2443 | - $n--; |
|
| 2566 | + while (empty($open_tags[$n]['block_level']) && $n >= 0) { |
|
| 2567 | + $n--; |
|
| 2568 | + } |
|
| 2444 | 2569 | |
| 2445 | 2570 | // Close all the non block level tags so this tag isn't surrounded by them. |
| 2446 | 2571 | for ($i = count($open_tags) - 1; $i > $n; $i--) |
@@ -2452,12 +2577,15 @@ discard block |
||
| 2452 | 2577 | |
| 2453 | 2578 | // Trim or eat trailing stuff... see comment at the end of the big loop. |
| 2454 | 2579 | $whitespace_regex = ''; |
| 2455 | - if (!empty($tag['block_level'])) |
|
| 2456 | - $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2457 | - if (!empty($tag['trim']) && $tag['trim'] != 'inside') |
|
| 2458 | - $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2459 | - if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) |
|
| 2460 | - $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2580 | + if (!empty($tag['block_level'])) { |
|
| 2581 | + $whitespace_regex .= '( |\s)*(<br>)?'; |
|
| 2582 | + } |
|
| 2583 | + if (!empty($tag['trim']) && $tag['trim'] != 'inside') { |
|
| 2584 | + $whitespace_regex .= empty($tag['require_parents']) ? '( |\s)*' : '(<br>| |\s)*'; |
|
| 2585 | + } |
|
| 2586 | + if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) { |
|
| 2587 | + $message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0])); |
|
| 2588 | + } |
|
| 2461 | 2589 | |
| 2462 | 2590 | array_pop($open_tags); |
| 2463 | 2591 | } |
@@ -2475,16 +2603,19 @@ discard block |
||
| 2475 | 2603 | elseif ($tag['type'] == 'unparsed_content') |
| 2476 | 2604 | { |
| 2477 | 2605 | $pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1); |
| 2478 | - if ($pos2 === false) |
|
| 2479 | - continue; |
|
| 2606 | + if ($pos2 === false) { |
|
| 2607 | + continue; |
|
| 2608 | + } |
|
| 2480 | 2609 | |
| 2481 | 2610 | $data = substr($message, $pos1, $pos2 - $pos1); |
| 2482 | 2611 | |
| 2483 | - if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') |
|
| 2484 | - $data = substr($data, 4); |
|
| 2612 | + if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') { |
|
| 2613 | + $data = substr($data, 4); |
|
| 2614 | + } |
|
| 2485 | 2615 | |
| 2486 | - if (isset($tag['validate'])) |
|
| 2487 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2616 | + if (isset($tag['validate'])) { |
|
| 2617 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2618 | + } |
|
| 2488 | 2619 | |
| 2489 | 2620 | $code = strtr($tag['content'], array('$1' => $data)); |
| 2490 | 2621 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen); |
@@ -2500,34 +2631,40 @@ discard block |
||
| 2500 | 2631 | if (isset($tag['quoted'])) |
| 2501 | 2632 | { |
| 2502 | 2633 | $quoted = substr($message, $pos1, 6) == '"'; |
| 2503 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
| 2504 | - continue; |
|
| 2634 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
| 2635 | + continue; |
|
| 2636 | + } |
|
| 2505 | 2637 | |
| 2506 | - if ($quoted) |
|
| 2507 | - $pos1 += 6; |
|
| 2638 | + if ($quoted) { |
|
| 2639 | + $pos1 += 6; |
|
| 2640 | + } |
|
| 2641 | + } else { |
|
| 2642 | + $quoted = false; |
|
| 2508 | 2643 | } |
| 2509 | - else |
|
| 2510 | - $quoted = false; |
|
| 2511 | 2644 | |
| 2512 | 2645 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
| 2513 | - if ($pos2 === false) |
|
| 2514 | - continue; |
|
| 2646 | + if ($pos2 === false) { |
|
| 2647 | + continue; |
|
| 2648 | + } |
|
| 2515 | 2649 | |
| 2516 | 2650 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
| 2517 | - if ($pos3 === false) |
|
| 2518 | - continue; |
|
| 2651 | + if ($pos3 === false) { |
|
| 2652 | + continue; |
|
| 2653 | + } |
|
| 2519 | 2654 | |
| 2520 | 2655 | $data = array( |
| 2521 | 2656 | substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))), |
| 2522 | 2657 | substr($message, $pos1, $pos2 - $pos1) |
| 2523 | 2658 | ); |
| 2524 | 2659 | |
| 2525 | - if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') |
|
| 2526 | - $data[0] = substr($data[0], 4); |
|
| 2660 | + if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') { |
|
| 2661 | + $data[0] = substr($data[0], 4); |
|
| 2662 | + } |
|
| 2527 | 2663 | |
| 2528 | 2664 | // Validation for my parking, please! |
| 2529 | - if (isset($tag['validate'])) |
|
| 2530 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2665 | + if (isset($tag['validate'])) { |
|
| 2666 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2667 | + } |
|
| 2531 | 2668 | |
| 2532 | 2669 | $code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1])); |
| 2533 | 2670 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
@@ -2544,23 +2681,27 @@ discard block |
||
| 2544 | 2681 | elseif ($tag['type'] == 'unparsed_commas_content') |
| 2545 | 2682 | { |
| 2546 | 2683 | $pos2 = strpos($message, ']', $pos1); |
| 2547 | - if ($pos2 === false) |
|
| 2548 | - continue; |
|
| 2684 | + if ($pos2 === false) { |
|
| 2685 | + continue; |
|
| 2686 | + } |
|
| 2549 | 2687 | |
| 2550 | 2688 | $pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2); |
| 2551 | - if ($pos3 === false) |
|
| 2552 | - continue; |
|
| 2689 | + if ($pos3 === false) { |
|
| 2690 | + continue; |
|
| 2691 | + } |
|
| 2553 | 2692 | |
| 2554 | 2693 | // We want $1 to be the content, and the rest to be csv. |
| 2555 | 2694 | $data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1)); |
| 2556 | 2695 | $data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1); |
| 2557 | 2696 | |
| 2558 | - if (isset($tag['validate'])) |
|
| 2559 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2697 | + if (isset($tag['validate'])) { |
|
| 2698 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2699 | + } |
|
| 2560 | 2700 | |
| 2561 | 2701 | $code = $tag['content']; |
| 2562 | - foreach ($data as $k => $d) |
|
| 2563 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2702 | + foreach ($data as $k => $d) { |
|
| 2703 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2704 | + } |
|
| 2564 | 2705 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen); |
| 2565 | 2706 | $pos += strlen($code) - 1 + 2; |
| 2566 | 2707 | } |
@@ -2568,24 +2709,28 @@ discard block |
||
| 2568 | 2709 | elseif ($tag['type'] == 'unparsed_commas') |
| 2569 | 2710 | { |
| 2570 | 2711 | $pos2 = strpos($message, ']', $pos1); |
| 2571 | - if ($pos2 === false) |
|
| 2572 | - continue; |
|
| 2712 | + if ($pos2 === false) { |
|
| 2713 | + continue; |
|
| 2714 | + } |
|
| 2573 | 2715 | |
| 2574 | 2716 | $data = explode(',', substr($message, $pos1, $pos2 - $pos1)); |
| 2575 | 2717 | |
| 2576 | - if (isset($tag['validate'])) |
|
| 2577 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2718 | + if (isset($tag['validate'])) { |
|
| 2719 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2720 | + } |
|
| 2578 | 2721 | |
| 2579 | 2722 | // Fix after, for disabled code mainly. |
| 2580 | - foreach ($data as $k => $d) |
|
| 2581 | - $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
| 2723 | + foreach ($data as $k => $d) { |
|
| 2724 | + $tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d))); |
|
| 2725 | + } |
|
| 2582 | 2726 | |
| 2583 | 2727 | $open_tags[] = $tag; |
| 2584 | 2728 | |
| 2585 | 2729 | // Replace them out, $1, $2, $3, $4, etc. |
| 2586 | 2730 | $code = $tag['before']; |
| 2587 | - foreach ($data as $k => $d) |
|
| 2588 | - $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2731 | + foreach ($data as $k => $d) { |
|
| 2732 | + $code = strtr($code, array('$' . ($k + 1) => trim($d))); |
|
| 2733 | + } |
|
| 2589 | 2734 | $message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1); |
| 2590 | 2735 | $pos += strlen($code) - 1 + 2; |
| 2591 | 2736 | } |
@@ -2596,28 +2741,33 @@ discard block |
||
| 2596 | 2741 | if (isset($tag['quoted'])) |
| 2597 | 2742 | { |
| 2598 | 2743 | $quoted = substr($message, $pos1, 6) == '"'; |
| 2599 | - if ($tag['quoted'] != 'optional' && !$quoted) |
|
| 2600 | - continue; |
|
| 2744 | + if ($tag['quoted'] != 'optional' && !$quoted) { |
|
| 2745 | + continue; |
|
| 2746 | + } |
|
| 2601 | 2747 | |
| 2602 | - if ($quoted) |
|
| 2603 | - $pos1 += 6; |
|
| 2748 | + if ($quoted) { |
|
| 2749 | + $pos1 += 6; |
|
| 2750 | + } |
|
| 2751 | + } else { |
|
| 2752 | + $quoted = false; |
|
| 2604 | 2753 | } |
| 2605 | - else |
|
| 2606 | - $quoted = false; |
|
| 2607 | 2754 | |
| 2608 | 2755 | $pos2 = strpos($message, $quoted == false ? ']' : '"]', $pos1); |
| 2609 | - if ($pos2 === false) |
|
| 2610 | - continue; |
|
| 2756 | + if ($pos2 === false) { |
|
| 2757 | + continue; |
|
| 2758 | + } |
|
| 2611 | 2759 | |
| 2612 | 2760 | $data = substr($message, $pos1, $pos2 - $pos1); |
| 2613 | 2761 | |
| 2614 | 2762 | // Validation for my parking, please! |
| 2615 | - if (isset($tag['validate'])) |
|
| 2616 | - $tag['validate']($tag, $data, $disabled, $params); |
|
| 2763 | + if (isset($tag['validate'])) { |
|
| 2764 | + $tag['validate']($tag, $data, $disabled, $params); |
|
| 2765 | + } |
|
| 2617 | 2766 | |
| 2618 | 2767 | // For parsed content, we must recurse to avoid security problems. |
| 2619 | - if ($tag['type'] != 'unparsed_equals') |
|
| 2620 | - $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
| 2768 | + if ($tag['type'] != 'unparsed_equals') { |
|
| 2769 | + $data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array()); |
|
| 2770 | + } |
|
| 2621 | 2771 | |
| 2622 | 2772 | $tag['after'] = strtr($tag['after'], array('$1' => $data)); |
| 2623 | 2773 | |
@@ -2629,34 +2779,40 @@ discard block |
||
| 2629 | 2779 | } |
| 2630 | 2780 | |
| 2631 | 2781 | // If this is block level, eat any breaks after it. |
| 2632 | - if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') |
|
| 2633 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
| 2782 | + if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') { |
|
| 2783 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 5); |
|
| 2784 | + } |
|
| 2634 | 2785 | |
| 2635 | 2786 | // Are we trimming outside this tag? |
| 2636 | - if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) |
|
| 2637 | - $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
| 2787 | + if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>| |\s)*~', substr($message, $pos + 1), $matches) != 0) { |
|
| 2788 | + $message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0])); |
|
| 2789 | + } |
|
| 2638 | 2790 | } |
| 2639 | 2791 | |
| 2640 | 2792 | // Close any remaining tags. |
| 2641 | - while ($tag = array_pop($open_tags)) |
|
| 2642 | - $message .= "\n" . $tag['after'] . "\n"; |
|
| 2793 | + while ($tag = array_pop($open_tags)) { |
|
| 2794 | + $message .= "\n" . $tag['after'] . "\n"; |
|
| 2795 | + } |
|
| 2643 | 2796 | |
| 2644 | 2797 | // Parse the smileys within the parts where it can be done safely. |
| 2645 | 2798 | if ($smileys === true) |
| 2646 | 2799 | { |
| 2647 | 2800 | $message_parts = explode("\n", $message); |
| 2648 | - for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) |
|
| 2649 | - parsesmileys($message_parts[$i]); |
|
| 2801 | + for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) { |
|
| 2802 | + parsesmileys($message_parts[$i]); |
|
| 2803 | + } |
|
| 2650 | 2804 | |
| 2651 | 2805 | $message = implode('', $message_parts); |
| 2652 | 2806 | } |
| 2653 | 2807 | |
| 2654 | 2808 | // No smileys, just get rid of the markers. |
| 2655 | - else |
|
| 2656 | - $message = strtr($message, array("\n" => '')); |
|
| 2809 | + else { |
|
| 2810 | + $message = strtr($message, array("\n" => '')); |
|
| 2811 | + } |
|
| 2657 | 2812 | |
| 2658 | - if ($message !== '' && $message[0] === ' ') |
|
| 2659 | - $message = ' ' . substr($message, 1); |
|
| 2813 | + if ($message !== '' && $message[0] === ' ') { |
|
| 2814 | + $message = ' ' . substr($message, 1); |
|
| 2815 | + } |
|
| 2660 | 2816 | |
| 2661 | 2817 | // Cleanup whitespace. |
| 2662 | 2818 | $message = strtr($message, array(' ' => ' ', "\r" => '', "\n" => '<br>', '<br> ' => '<br> ', ' ' => "\n")); |
@@ -2665,15 +2821,16 @@ discard block |
||
| 2665 | 2821 | call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags)); |
| 2666 | 2822 | |
| 2667 | 2823 | // Cache the output if it took some time... |
| 2668 | - if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) |
|
| 2669 | - cache_put_data($cache_key, $message, 240); |
|
| 2824 | + if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) { |
|
| 2825 | + cache_put_data($cache_key, $message, 240); |
|
| 2826 | + } |
|
| 2670 | 2827 | |
| 2671 | 2828 | // If this was a force parse revert if needed. |
| 2672 | 2829 | if (!empty($parse_tags)) |
| 2673 | 2830 | { |
| 2674 | - if (empty($temp_bbc)) |
|
| 2675 | - $bbc_codes = array(); |
|
| 2676 | - else |
|
| 2831 | + if (empty($temp_bbc)) { |
|
| 2832 | + $bbc_codes = array(); |
|
| 2833 | + } else |
|
| 2677 | 2834 | { |
| 2678 | 2835 | $bbc_codes = $temp_bbc; |
| 2679 | 2836 | unset($temp_bbc); |
@@ -2700,8 +2857,9 @@ discard block |
||
| 2700 | 2857 | static $smileyPregSearch = null, $smileyPregReplacements = array(); |
| 2701 | 2858 | |
| 2702 | 2859 | // No smiley set at all?! |
| 2703 | - if ($user_info['smiley_set'] == 'none' || trim($message) == '') |
|
| 2704 | - return; |
|
| 2860 | + if ($user_info['smiley_set'] == 'none' || trim($message) == '') { |
|
| 2861 | + return; |
|
| 2862 | + } |
|
| 2705 | 2863 | |
| 2706 | 2864 | // If smileyPregSearch hasn't been set, do it now. |
| 2707 | 2865 | if (empty($smileyPregSearch)) |
@@ -2712,8 +2870,7 @@ discard block |
||
| 2712 | 2870 | $smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)'); |
| 2713 | 2871 | $smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif'); |
| 2714 | 2872 | $smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', ''); |
| 2715 | - } |
|
| 2716 | - else |
|
| 2873 | + } else |
|
| 2717 | 2874 | { |
| 2718 | 2875 | // Load the smileys in reverse order by length so they don't get parsed wrong. |
| 2719 | 2876 | if (($temp = cache_get_data('parsing_smileys', 480)) == null) |
@@ -2737,9 +2894,9 @@ discard block |
||
| 2737 | 2894 | $smcFunc['db_free_result']($result); |
| 2738 | 2895 | |
| 2739 | 2896 | cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480); |
| 2897 | + } else { |
|
| 2898 | + list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
| 2740 | 2899 | } |
| 2741 | - else |
|
| 2742 | - list ($smileysfrom, $smileysto, $smileysdescs) = $temp; |
|
| 2743 | 2900 | } |
| 2744 | 2901 | |
| 2745 | 2902 | // The non-breaking-space is a complex thing... |
@@ -2816,35 +2973,41 @@ discard block |
||
| 2816 | 2973 | global $scripturl, $context, $modSettings, $db_show_debug, $db_cache; |
| 2817 | 2974 | |
| 2818 | 2975 | // In case we have mail to send, better do that - as obExit doesn't always quite make it... |
| 2819 | - if (!empty($context['flush_mail'])) |
|
| 2820 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 2976 | + if (!empty($context['flush_mail'])) { |
|
| 2977 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 2821 | 2978 | AddMailQueue(true); |
| 2979 | + } |
|
| 2822 | 2980 | |
| 2823 | 2981 | $add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:'; |
| 2824 | 2982 | |
| 2825 | - if ($add) |
|
| 2826 | - $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
| 2983 | + if ($add) { |
|
| 2984 | + $setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : ''); |
|
| 2985 | + } |
|
| 2827 | 2986 | |
| 2828 | 2987 | // Put the session ID in. |
| 2829 | - if (defined('SID') && SID != '') |
|
| 2830 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
| 2988 | + if (defined('SID') && SID != '') { |
|
| 2989 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation); |
|
| 2990 | + } |
|
| 2831 | 2991 | // Keep that debug in their for template debugging! |
| 2832 | - elseif (isset($_GET['debug'])) |
|
| 2833 | - $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
| 2992 | + elseif (isset($_GET['debug'])) { |
|
| 2993 | + $setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation); |
|
| 2994 | + } |
|
| 2834 | 2995 | |
| 2835 | 2996 | if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed']))) |
| 2836 | 2997 | { |
| 2837 | - if (defined('SID') && SID != '') |
|
| 2838 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
| 2998 | + if (defined('SID') && SID != '') { |
|
| 2999 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&))((?:board|topic)=[^#]+?)(#[^"]*?)?$~', |
|
| 2839 | 3000 | function ($m) use ($scripturl) |
| 2840 | 3001 | { |
| 2841 | 3002 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : ""); |
| 3003 | + } |
|
| 2842 | 3004 | }, $setLocation); |
| 2843 | - else |
|
| 2844 | - $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
| 3005 | + else { |
|
| 3006 | + $setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~', |
|
| 2845 | 3007 | function ($m) use ($scripturl) |
| 2846 | 3008 | { |
| 2847 | 3009 | return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : ""); |
| 3010 | + } |
|
| 2848 | 3011 | }, $setLocation); |
| 2849 | 3012 | } |
| 2850 | 3013 | |
@@ -2855,8 +3018,9 @@ discard block |
||
| 2855 | 3018 | header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302); |
| 2856 | 3019 | |
| 2857 | 3020 | // Debugging. |
| 2858 | - if (isset($db_show_debug) && $db_show_debug === true) |
|
| 2859 | - $_SESSION['debug_redirect'] = $db_cache; |
|
| 3021 | + if (isset($db_show_debug) && $db_show_debug === true) { |
|
| 3022 | + $_SESSION['debug_redirect'] = $db_cache; |
|
| 3023 | + } |
|
| 2860 | 3024 | |
| 2861 | 3025 | obExit(false); |
| 2862 | 3026 | } |
@@ -2875,51 +3039,60 @@ discard block |
||
| 2875 | 3039 | |
| 2876 | 3040 | // Attempt to prevent a recursive loop. |
| 2877 | 3041 | ++$level; |
| 2878 | - if ($level > 1 && !$from_fatal_error && !$has_fatal_error) |
|
| 2879 | - exit; |
|
| 2880 | - if ($from_fatal_error) |
|
| 2881 | - $has_fatal_error = true; |
|
| 3042 | + if ($level > 1 && !$from_fatal_error && !$has_fatal_error) { |
|
| 3043 | + exit; |
|
| 3044 | + } |
|
| 3045 | + if ($from_fatal_error) { |
|
| 3046 | + $has_fatal_error = true; |
|
| 3047 | + } |
|
| 2882 | 3048 | |
| 2883 | 3049 | // Clear out the stat cache. |
| 2884 | 3050 | trackStats(); |
| 2885 | 3051 | |
| 2886 | 3052 | // If we have mail to send, send it. |
| 2887 | - if (!empty($context['flush_mail'])) |
|
| 2888 | - // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 3053 | + if (!empty($context['flush_mail'])) { |
|
| 3054 | + // @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\ |
|
| 2889 | 3055 | AddMailQueue(true); |
| 3056 | + } |
|
| 2890 | 3057 | |
| 2891 | 3058 | $do_header = $header === null ? !$header_done : $header; |
| 2892 | - if ($do_footer === null) |
|
| 2893 | - $do_footer = $do_header; |
|
| 3059 | + if ($do_footer === null) { |
|
| 3060 | + $do_footer = $do_header; |
|
| 3061 | + } |
|
| 2894 | 3062 | |
| 2895 | 3063 | // Has the template/header been done yet? |
| 2896 | 3064 | if ($do_header) |
| 2897 | 3065 | { |
| 2898 | 3066 | // Was the page title set last minute? Also update the HTML safe one. |
| 2899 | - if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) |
|
| 2900 | - $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
| 3067 | + if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) { |
|
| 3068 | + $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
|
| 3069 | + } |
|
| 2901 | 3070 | |
| 2902 | 3071 | // Start up the session URL fixer. |
| 2903 | 3072 | ob_start('ob_sessrewrite'); |
| 2904 | 3073 | |
| 2905 | - if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) |
|
| 2906 | - $buffers = explode(',', $settings['output_buffers']); |
|
| 2907 | - elseif (!empty($settings['output_buffers'])) |
|
| 2908 | - $buffers = $settings['output_buffers']; |
|
| 2909 | - else |
|
| 2910 | - $buffers = array(); |
|
| 3074 | + if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) { |
|
| 3075 | + $buffers = explode(',', $settings['output_buffers']); |
|
| 3076 | + } elseif (!empty($settings['output_buffers'])) { |
|
| 3077 | + $buffers = $settings['output_buffers']; |
|
| 3078 | + } else { |
|
| 3079 | + $buffers = array(); |
|
| 3080 | + } |
|
| 2911 | 3081 | |
| 2912 | - if (isset($modSettings['integrate_buffer'])) |
|
| 2913 | - $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
| 3082 | + if (isset($modSettings['integrate_buffer'])) { |
|
| 3083 | + $buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers); |
|
| 3084 | + } |
|
| 2914 | 3085 | |
| 2915 | - if (!empty($buffers)) |
|
| 2916 | - foreach ($buffers as $function) |
|
| 3086 | + if (!empty($buffers)) { |
|
| 3087 | + foreach ($buffers as $function) |
|
| 2917 | 3088 | { |
| 2918 | 3089 | $call = call_helper($function, true); |
| 3090 | + } |
|
| 2919 | 3091 | |
| 2920 | 3092 | // Is it valid? |
| 2921 | - if (!empty($call)) |
|
| 2922 | - ob_start($call); |
|
| 3093 | + if (!empty($call)) { |
|
| 3094 | + ob_start($call); |
|
| 3095 | + } |
|
| 2923 | 3096 | } |
| 2924 | 3097 | |
| 2925 | 3098 | // Display the screen in the logical order. |
@@ -2931,8 +3104,9 @@ discard block |
||
| 2931 | 3104 | loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main'); |
| 2932 | 3105 | |
| 2933 | 3106 | // Anything special to put out? |
| 2934 | - if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) |
|
| 2935 | - echo $context['insert_after_template']; |
|
| 3107 | + if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) { |
|
| 3108 | + echo $context['insert_after_template']; |
|
| 3109 | + } |
|
| 2936 | 3110 | |
| 2937 | 3111 | // Just so we don't get caught in an endless loop of errors from the footer... |
| 2938 | 3112 | if (!$footer_done) |
@@ -2941,14 +3115,16 @@ discard block |
||
| 2941 | 3115 | template_footer(); |
| 2942 | 3116 | |
| 2943 | 3117 | // (since this is just debugging... it's okay that it's after </html>.) |
| 2944 | - if (!isset($_REQUEST['xml'])) |
|
| 2945 | - displayDebug(); |
|
| 3118 | + if (!isset($_REQUEST['xml'])) { |
|
| 3119 | + displayDebug(); |
|
| 3120 | + } |
|
| 2946 | 3121 | } |
| 2947 | 3122 | } |
| 2948 | 3123 | |
| 2949 | 3124 | // Remember this URL in case someone doesn't like sending HTTP_REFERER. |
| 2950 | - if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) |
|
| 2951 | - $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
| 3125 | + if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) { |
|
| 3126 | + $_SESSION['old_url'] = $_SERVER['REQUEST_URL']; |
|
| 3127 | + } |
|
| 2952 | 3128 | |
| 2953 | 3129 | // For session check verification.... don't switch browsers... |
| 2954 | 3130 | $_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT']; |
@@ -2957,9 +3133,10 @@ discard block |
||
| 2957 | 3133 | call_integration_hook('integrate_exit', array($do_footer)); |
| 2958 | 3134 | |
| 2959 | 3135 | // Don't exit if we're coming from index.php; that will pass through normally. |
| 2960 | - if (!$from_index) |
|
| 2961 | - exit; |
|
| 2962 | -} |
|
| 3136 | + if (!$from_index) { |
|
| 3137 | + exit; |
|
| 3138 | + } |
|
| 3139 | + } |
|
| 2963 | 3140 | |
| 2964 | 3141 | /** |
| 2965 | 3142 | * Get the size of a specified image with better error handling. |
@@ -2978,8 +3155,9 @@ discard block |
||
| 2978 | 3155 | $url = str_replace(' ', '%20', $url); |
| 2979 | 3156 | |
| 2980 | 3157 | // Can we pull this from the cache... please please? |
| 2981 | - if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) |
|
| 2982 | - return $temp; |
|
| 3158 | + if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) { |
|
| 3159 | + return $temp; |
|
| 3160 | + } |
|
| 2983 | 3161 | $t = microtime(); |
| 2984 | 3162 | |
| 2985 | 3163 | // Get the host to pester... |
@@ -2989,12 +3167,10 @@ discard block |
||
| 2989 | 3167 | if ($url == '' || $url == 'http://' || $url == 'https://') |
| 2990 | 3168 | { |
| 2991 | 3169 | return false; |
| 2992 | - } |
|
| 2993 | - elseif (!isset($match[1])) |
|
| 3170 | + } elseif (!isset($match[1])) |
|
| 2994 | 3171 | { |
| 2995 | 3172 | $size = @getimagesize($url); |
| 2996 | - } |
|
| 2997 | - else |
|
| 3173 | + } else |
|
| 2998 | 3174 | { |
| 2999 | 3175 | // Try to connect to the server... give it half a second. |
| 3000 | 3176 | $temp = 0; |
@@ -3033,12 +3209,14 @@ discard block |
||
| 3033 | 3209 | } |
| 3034 | 3210 | |
| 3035 | 3211 | // If we didn't get it, we failed. |
| 3036 | - if (!isset($size)) |
|
| 3037 | - $size = false; |
|
| 3212 | + if (!isset($size)) { |
|
| 3213 | + $size = false; |
|
| 3214 | + } |
|
| 3038 | 3215 | |
| 3039 | 3216 | // If this took a long time, we may never have to do it again, but then again we might... |
| 3040 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) |
|
| 3041 | - cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
| 3217 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) { |
|
| 3218 | + cache_put_data('url_image_size-' . md5($url), $size, 240); |
|
| 3219 | + } |
|
| 3042 | 3220 | |
| 3043 | 3221 | // Didn't work. |
| 3044 | 3222 | return $size; |
@@ -3056,8 +3234,9 @@ discard block |
||
| 3056 | 3234 | |
| 3057 | 3235 | // Under SSI this function can be called more then once. That can cause some problems. |
| 3058 | 3236 | // So only run the function once unless we are forced to run it again. |
| 3059 | - if ($loaded && !$forceload) |
|
| 3060 | - return; |
|
| 3237 | + if ($loaded && !$forceload) { |
|
| 3238 | + return; |
|
| 3239 | + } |
|
| 3061 | 3240 | |
| 3062 | 3241 | $loaded = true; |
| 3063 | 3242 | |
@@ -3069,14 +3248,16 @@ discard block |
||
| 3069 | 3248 | $context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news']))))); |
| 3070 | 3249 | for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++) |
| 3071 | 3250 | { |
| 3072 | - if (trim($context['news_lines'][$i]) == '') |
|
| 3073 | - continue; |
|
| 3251 | + if (trim($context['news_lines'][$i]) == '') { |
|
| 3252 | + continue; |
|
| 3253 | + } |
|
| 3074 | 3254 | |
| 3075 | 3255 | // Clean it up for presentation ;). |
| 3076 | 3256 | $context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i); |
| 3077 | 3257 | } |
| 3078 | - if (!empty($context['news_lines'])) |
|
| 3079 | - $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
| 3258 | + if (!empty($context['news_lines'])) { |
|
| 3259 | + $context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)]; |
|
| 3260 | + } |
|
| 3080 | 3261 | |
| 3081 | 3262 | if (!$user_info['is_guest']) |
| 3082 | 3263 | { |
@@ -3085,40 +3266,48 @@ discard block |
||
| 3085 | 3266 | $context['user']['alerts'] = &$user_info['alerts']; |
| 3086 | 3267 | |
| 3087 | 3268 | // Personal message popup... |
| 3088 | - if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) |
|
| 3089 | - $context['user']['popup_messages'] = true; |
|
| 3090 | - else |
|
| 3091 | - $context['user']['popup_messages'] = false; |
|
| 3269 | + if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) { |
|
| 3270 | + $context['user']['popup_messages'] = true; |
|
| 3271 | + } else { |
|
| 3272 | + $context['user']['popup_messages'] = false; |
|
| 3273 | + } |
|
| 3092 | 3274 | $_SESSION['unread_messages'] = $user_info['unread_messages']; |
| 3093 | 3275 | |
| 3094 | - if (allowedTo('moderate_forum')) |
|
| 3095 | - $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
| 3276 | + if (allowedTo('moderate_forum')) { |
|
| 3277 | + $context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0; |
|
| 3278 | + } |
|
| 3096 | 3279 | |
| 3097 | 3280 | $context['user']['avatar'] = array(); |
| 3098 | 3281 | |
| 3099 | 3282 | // Check for gravatar first since we might be forcing them... |
| 3100 | 3283 | if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride'])) |
| 3101 | 3284 | { |
| 3102 | - if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) |
|
| 3103 | - $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
| 3104 | - else |
|
| 3105 | - $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
| 3285 | + if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) { |
|
| 3286 | + $context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11)); |
|
| 3287 | + } else { |
|
| 3288 | + $context['user']['avatar']['href'] = get_gravatar_url($user_info['email']); |
|
| 3289 | + } |
|
| 3106 | 3290 | } |
| 3107 | 3291 | // Uploaded? |
| 3108 | - elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) |
|
| 3109 | - $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
| 3292 | + elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) { |
|
| 3293 | + $context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar'; |
|
| 3294 | + } |
|
| 3110 | 3295 | // Full URL? |
| 3111 | - elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) |
|
| 3112 | - $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
| 3296 | + elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) { |
|
| 3297 | + $context['user']['avatar']['href'] = $user_info['avatar']['url']; |
|
| 3298 | + } |
|
| 3113 | 3299 | // Otherwise we assume it's server stored. |
| 3114 | - elseif ($user_info['avatar']['url'] != '') |
|
| 3115 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
| 3300 | + elseif ($user_info['avatar']['url'] != '') { |
|
| 3301 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']); |
|
| 3302 | + } |
|
| 3116 | 3303 | // No avatar at all? Fine, we have a big fat default avatar ;) |
| 3117 | - else |
|
| 3118 | - $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
| 3304 | + else { |
|
| 3305 | + $context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png'; |
|
| 3306 | + } |
|
| 3119 | 3307 | |
| 3120 | - if (!empty($context['user']['avatar'])) |
|
| 3121 | - $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
| 3308 | + if (!empty($context['user']['avatar'])) { |
|
| 3309 | + $context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">'; |
|
| 3310 | + } |
|
| 3122 | 3311 | |
| 3123 | 3312 | // Figure out how long they've been logged in. |
| 3124 | 3313 | $context['user']['total_time_logged_in'] = array( |
@@ -3126,8 +3315,7 @@ discard block |
||
| 3126 | 3315 | 'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600), |
| 3127 | 3316 | 'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60) |
| 3128 | 3317 | ); |
| 3129 | - } |
|
| 3130 | - else |
|
| 3318 | + } else |
|
| 3131 | 3319 | { |
| 3132 | 3320 | $context['user']['messages'] = 0; |
| 3133 | 3321 | $context['user']['unread_messages'] = 0; |
@@ -3135,12 +3323,14 @@ discard block |
||
| 3135 | 3323 | $context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0); |
| 3136 | 3324 | $context['user']['popup_messages'] = false; |
| 3137 | 3325 | |
| 3138 | - if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) |
|
| 3139 | - $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
| 3326 | + if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) { |
|
| 3327 | + $txt['welcome_guest'] .= $txt['welcome_guest_activate']; |
|
| 3328 | + } |
|
| 3140 | 3329 | |
| 3141 | 3330 | // If we've upgraded recently, go easy on the passwords. |
| 3142 | - if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) |
|
| 3143 | - $context['disable_login_hashing'] = true; |
|
| 3331 | + if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) { |
|
| 3332 | + $context['disable_login_hashing'] = true; |
|
| 3333 | + } |
|
| 3144 | 3334 | } |
| 3145 | 3335 | |
| 3146 | 3336 | // Setup the main menu items. |
@@ -3153,8 +3343,8 @@ discard block |
||
| 3153 | 3343 | $context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'); |
| 3154 | 3344 | |
| 3155 | 3345 | // 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array. |
| 3156 | - if ($context['show_pm_popup']) |
|
| 3157 | - addInlineJavaScript(' |
|
| 3346 | + if ($context['show_pm_popup']) { |
|
| 3347 | + addInlineJavaScript(' |
|
| 3158 | 3348 | jQuery(document).ready(function($) { |
| 3159 | 3349 | new smc_Popup({ |
| 3160 | 3350 | heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ', |
@@ -3162,15 +3352,17 @@ discard block |
||
| 3162 | 3352 | icon_class: \'generic_icons mail_new\' |
| 3163 | 3353 | }); |
| 3164 | 3354 | });'); |
| 3355 | + } |
|
| 3165 | 3356 | |
| 3166 | 3357 | // Add a generic "Are you sure?" confirmation message. |
| 3167 | 3358 | addInlineJavaScript(' |
| 3168 | 3359 | var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';'); |
| 3169 | 3360 | |
| 3170 | 3361 | // Now add the capping code for avatars. |
| 3171 | - if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') |
|
| 3172 | - addInlineCss(' |
|
| 3362 | + if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') { |
|
| 3363 | + addInlineCss(' |
|
| 3173 | 3364 | img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }'); |
| 3365 | + } |
|
| 3174 | 3366 | |
| 3175 | 3367 | // This looks weird, but it's because BoardIndex.php references the variable. |
| 3176 | 3368 | $context['common_stats']['latest_member'] = array( |
@@ -3187,11 +3379,13 @@ discard block |
||
| 3187 | 3379 | ); |
| 3188 | 3380 | $context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']); |
| 3189 | 3381 | |
| 3190 | - if (empty($settings['theme_version'])) |
|
| 3191 | - addJavaScriptVar('smf_scripturl', $scripturl); |
|
| 3382 | + if (empty($settings['theme_version'])) { |
|
| 3383 | + addJavaScriptVar('smf_scripturl', $scripturl); |
|
| 3384 | + } |
|
| 3192 | 3385 | |
| 3193 | - if (!isset($context['page_title'])) |
|
| 3194 | - $context['page_title'] = ''; |
|
| 3386 | + if (!isset($context['page_title'])) { |
|
| 3387 | + $context['page_title'] = ''; |
|
| 3388 | + } |
|
| 3195 | 3389 | |
| 3196 | 3390 | // Set some specific vars. |
| 3197 | 3391 | $context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : ''); |
@@ -3201,21 +3395,23 @@ discard block |
||
| 3201 | 3395 | $context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']); |
| 3202 | 3396 | $context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']); |
| 3203 | 3397 | |
| 3204 | - if (!empty($context['meta_keywords'])) |
|
| 3205 | - $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
| 3398 | + if (!empty($context['meta_keywords'])) { |
|
| 3399 | + $context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']); |
|
| 3400 | + } |
|
| 3206 | 3401 | |
| 3207 | - if (!empty($context['canonical_url'])) |
|
| 3208 | - $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
| 3402 | + if (!empty($context['canonical_url'])) { |
|
| 3403 | + $context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']); |
|
| 3404 | + } |
|
| 3209 | 3405 | |
| 3210 | - if (!empty($settings['og_image'])) |
|
| 3211 | - $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
| 3406 | + if (!empty($settings['og_image'])) { |
|
| 3407 | + $context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']); |
|
| 3408 | + } |
|
| 3212 | 3409 | |
| 3213 | 3410 | if (!empty($context['meta_description'])) |
| 3214 | 3411 | { |
| 3215 | 3412 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']); |
| 3216 | 3413 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']); |
| 3217 | - } |
|
| 3218 | - else |
|
| 3414 | + } else |
|
| 3219 | 3415 | { |
| 3220 | 3416 | $context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']); |
| 3221 | 3417 | $context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']); |
@@ -3240,8 +3436,9 @@ discard block |
||
| 3240 | 3436 | $memory_needed = memoryReturnBytes($needed); |
| 3241 | 3437 | |
| 3242 | 3438 | // should we account for how much is currently being used? |
| 3243 | - if ($in_use) |
|
| 3244 | - $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
| 3439 | + if ($in_use) { |
|
| 3440 | + $memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576); |
|
| 3441 | + } |
|
| 3245 | 3442 | |
| 3246 | 3443 | // if more is needed, request it |
| 3247 | 3444 | if ($memory_current < $memory_needed) |
@@ -3264,8 +3461,9 @@ discard block |
||
| 3264 | 3461 | */ |
| 3265 | 3462 | function memoryReturnBytes($val) |
| 3266 | 3463 | { |
| 3267 | - if (is_integer($val)) |
|
| 3268 | - return $val; |
|
| 3464 | + if (is_integer($val)) { |
|
| 3465 | + return $val; |
|
| 3466 | + } |
|
| 3269 | 3467 | |
| 3270 | 3468 | // Separate the number from the designator |
| 3271 | 3469 | $val = trim($val); |
@@ -3301,10 +3499,11 @@ discard block |
||
| 3301 | 3499 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT'); |
| 3302 | 3500 | |
| 3303 | 3501 | // Are we debugging the template/html content? |
| 3304 | - if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) |
|
| 3305 | - header('Content-Type: application/xhtml+xml'); |
|
| 3306 | - elseif (!isset($_REQUEST['xml'])) |
|
| 3307 | - header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3502 | + if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) { |
|
| 3503 | + header('Content-Type: application/xhtml+xml'); |
|
| 3504 | + } elseif (!isset($_REQUEST['xml'])) { |
|
| 3505 | + header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
|
| 3506 | + } |
|
| 3308 | 3507 | } |
| 3309 | 3508 | |
| 3310 | 3509 | header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set'])); |
@@ -3313,8 +3512,9 @@ discard block |
||
| 3313 | 3512 | if ($context['in_maintenance'] && $context['user']['is_admin']) |
| 3314 | 3513 | { |
| 3315 | 3514 | $position = array_search('body', $context['template_layers']); |
| 3316 | - if ($position === false) |
|
| 3317 | - $position = array_search('main', $context['template_layers']); |
|
| 3515 | + if ($position === false) { |
|
| 3516 | + $position = array_search('main', $context['template_layers']); |
|
| 3517 | + } |
|
| 3318 | 3518 | |
| 3319 | 3519 | if ($position !== false) |
| 3320 | 3520 | { |
@@ -3342,23 +3542,25 @@ discard block |
||
| 3342 | 3542 | |
| 3343 | 3543 | foreach ($securityFiles as $i => $securityFile) |
| 3344 | 3544 | { |
| 3345 | - if (!file_exists($boarddir . '/' . $securityFile)) |
|
| 3346 | - unset($securityFiles[$i]); |
|
| 3545 | + if (!file_exists($boarddir . '/' . $securityFile)) { |
|
| 3546 | + unset($securityFiles[$i]); |
|
| 3547 | + } |
|
| 3347 | 3548 | } |
| 3348 | 3549 | |
| 3349 | 3550 | // We are already checking so many files...just few more doesn't make any difference! :P |
| 3350 | - if (!empty($modSettings['currentAttachmentUploadDir'])) |
|
| 3351 | - $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
| 3352 | - |
|
| 3353 | - else |
|
| 3354 | - $path = $modSettings['attachmentUploadDir']; |
|
| 3551 | + if (!empty($modSettings['currentAttachmentUploadDir'])) { |
|
| 3552 | + $path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']]; |
|
| 3553 | + } else { |
|
| 3554 | + $path = $modSettings['attachmentUploadDir']; |
|
| 3555 | + } |
|
| 3355 | 3556 | |
| 3356 | 3557 | secureDirectory($path, true); |
| 3357 | 3558 | secureDirectory($cachedir); |
| 3358 | 3559 | |
| 3359 | 3560 | // If agreement is enabled, at least the english version shall exists |
| 3360 | - if ($modSettings['requireAgreement']) |
|
| 3361 | - $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
| 3561 | + if ($modSettings['requireAgreement']) { |
|
| 3562 | + $agreement = !file_exists($boarddir . '/agreement.txt'); |
|
| 3563 | + } |
|
| 3362 | 3564 | |
| 3363 | 3565 | if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement)) |
| 3364 | 3566 | { |
@@ -3373,18 +3575,21 @@ discard block |
||
| 3373 | 3575 | echo ' |
| 3374 | 3576 | ', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>'; |
| 3375 | 3577 | |
| 3376 | - if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') |
|
| 3377 | - echo ' |
|
| 3578 | + if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') { |
|
| 3579 | + echo ' |
|
| 3378 | 3580 | ', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>'; |
| 3581 | + } |
|
| 3379 | 3582 | } |
| 3380 | 3583 | |
| 3381 | - if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) |
|
| 3382 | - echo ' |
|
| 3584 | + if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) { |
|
| 3585 | + echo ' |
|
| 3383 | 3586 | <strong>', $txt['cache_writable'], '</strong><br>'; |
| 3587 | + } |
|
| 3384 | 3588 | |
| 3385 | - if (!empty($agreement)) |
|
| 3386 | - echo ' |
|
| 3589 | + if (!empty($agreement)) { |
|
| 3590 | + echo ' |
|
| 3387 | 3591 | <strong>', $txt['agreement_missing'], '</strong><br>'; |
| 3592 | + } |
|
| 3388 | 3593 | |
| 3389 | 3594 | echo ' |
| 3390 | 3595 | </p> |
@@ -3399,16 +3604,18 @@ discard block |
||
| 3399 | 3604 | <div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;"> |
| 3400 | 3605 | ', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']); |
| 3401 | 3606 | |
| 3402 | - if (!empty($_SESSION['ban']['cannot_post']['reason'])) |
|
| 3403 | - echo ' |
|
| 3607 | + if (!empty($_SESSION['ban']['cannot_post']['reason'])) { |
|
| 3608 | + echo ' |
|
| 3404 | 3609 | <div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>'; |
| 3610 | + } |
|
| 3405 | 3611 | |
| 3406 | - if (!empty($_SESSION['ban']['expire_time'])) |
|
| 3407 | - echo ' |
|
| 3612 | + if (!empty($_SESSION['ban']['expire_time'])) { |
|
| 3613 | + echo ' |
|
| 3408 | 3614 | <div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>'; |
| 3409 | - else |
|
| 3410 | - echo ' |
|
| 3615 | + } else { |
|
| 3616 | + echo ' |
|
| 3411 | 3617 | <div>', $txt['your_ban_expires_never'], '</div>'; |
| 3618 | + } |
|
| 3412 | 3619 | |
| 3413 | 3620 | echo ' |
| 3414 | 3621 | </div>'; |
@@ -3424,8 +3631,9 @@ discard block |
||
| 3424 | 3631 | global $forum_copyright, $software_year, $forum_version; |
| 3425 | 3632 | |
| 3426 | 3633 | // Don't display copyright for things like SSI. |
| 3427 | - if (!isset($forum_version) || !isset($software_year)) |
|
| 3428 | - return; |
|
| 3634 | + if (!isset($forum_version) || !isset($software_year)) { |
|
| 3635 | + return; |
|
| 3636 | + } |
|
| 3429 | 3637 | |
| 3430 | 3638 | // Put in the version... |
| 3431 | 3639 | printf($forum_copyright, $forum_version, $software_year); |
@@ -3443,9 +3651,10 @@ discard block |
||
| 3443 | 3651 | $context['load_time'] = comma_format(round(array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)), 3)); |
| 3444 | 3652 | $context['load_queries'] = $db_count; |
| 3445 | 3653 | |
| 3446 | - foreach (array_reverse($context['template_layers']) as $layer) |
|
| 3447 | - loadSubTemplate($layer . '_below', true); |
|
| 3448 | -} |
|
| 3654 | + foreach (array_reverse($context['template_layers']) as $layer) { |
|
| 3655 | + loadSubTemplate($layer . '_below', true); |
|
| 3656 | + } |
|
| 3657 | + } |
|
| 3449 | 3658 | |
| 3450 | 3659 | /** |
| 3451 | 3660 | * Output the Javascript files |
@@ -3476,8 +3685,7 @@ discard block |
||
| 3476 | 3685 | { |
| 3477 | 3686 | echo ' |
| 3478 | 3687 | var ', $key, ';'; |
| 3479 | - } |
|
| 3480 | - else |
|
| 3688 | + } else |
|
| 3481 | 3689 | { |
| 3482 | 3690 | echo ' |
| 3483 | 3691 | var ', $key, ' = ', $value, ';'; |
@@ -3492,26 +3700,27 @@ discard block |
||
| 3492 | 3700 | foreach ($context['javascript_files'] as $id => $js_file) |
| 3493 | 3701 | { |
| 3494 | 3702 | // Last minute call! allow theme authors to disable single files. |
| 3495 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
| 3496 | - continue; |
|
| 3703 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
| 3704 | + continue; |
|
| 3705 | + } |
|
| 3497 | 3706 | |
| 3498 | 3707 | // By default all files don't get minimized unless the file explicitly says so! |
| 3499 | 3708 | if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
| 3500 | 3709 | { |
| 3501 | - if ($do_deferred && !empty($js_file['options']['defer'])) |
|
| 3502 | - $toMinifyDefer[] = $js_file; |
|
| 3503 | - |
|
| 3504 | - elseif (!$do_deferred && empty($js_file['options']['defer'])) |
|
| 3505 | - $toMinify[] = $js_file; |
|
| 3710 | + if ($do_deferred && !empty($js_file['options']['defer'])) { |
|
| 3711 | + $toMinifyDefer[] = $js_file; |
|
| 3712 | + } elseif (!$do_deferred && empty($js_file['options']['defer'])) { |
|
| 3713 | + $toMinify[] = $js_file; |
|
| 3714 | + } |
|
| 3506 | 3715 | |
| 3507 | 3716 | // Grab a random seed. |
| 3508 | - if (!isset($minSeed)) |
|
| 3509 | - $minSeed = $js_file['options']['seed']; |
|
| 3510 | - } |
|
| 3511 | - |
|
| 3512 | - elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) |
|
| 3513 | - echo ' |
|
| 3717 | + if (!isset($minSeed)) { |
|
| 3718 | + $minSeed = $js_file['options']['seed']; |
|
| 3719 | + } |
|
| 3720 | + } elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) { |
|
| 3721 | + echo ' |
|
| 3514 | 3722 | <script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>'; |
| 3723 | + } |
|
| 3515 | 3724 | } |
| 3516 | 3725 | |
| 3517 | 3726 | if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer))) |
@@ -3519,14 +3728,14 @@ discard block |
||
| 3519 | 3728 | $result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred); |
| 3520 | 3729 | |
| 3521 | 3730 | // Minify process couldn't work, print each individual files. |
| 3522 | - if (!empty($result) && is_array($result)) |
|
| 3523 | - foreach ($result as $minFailedFile) |
|
| 3731 | + if (!empty($result) && is_array($result)) { |
|
| 3732 | + foreach ($result as $minFailedFile) |
|
| 3524 | 3733 | echo ' |
| 3525 | 3734 | <script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>'; |
| 3526 | - |
|
| 3527 | - else |
|
| 3528 | - echo ' |
|
| 3735 | + } else { |
|
| 3736 | + echo ' |
|
| 3529 | 3737 | <script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>'; |
| 3738 | + } |
|
| 3530 | 3739 | } |
| 3531 | 3740 | |
| 3532 | 3741 | // Inline JavaScript - Actually useful some times! |
@@ -3537,8 +3746,9 @@ discard block |
||
| 3537 | 3746 | echo ' |
| 3538 | 3747 | <script>'; |
| 3539 | 3748 | |
| 3540 | - foreach ($context['javascript_inline']['defer'] as $js_code) |
|
| 3541 | - echo $js_code; |
|
| 3749 | + foreach ($context['javascript_inline']['defer'] as $js_code) { |
|
| 3750 | + echo $js_code; |
|
| 3751 | + } |
|
| 3542 | 3752 | |
| 3543 | 3753 | echo ' |
| 3544 | 3754 | </script>'; |
@@ -3549,8 +3759,9 @@ discard block |
||
| 3549 | 3759 | echo ' |
| 3550 | 3760 | <script>'; |
| 3551 | 3761 | |
| 3552 | - foreach ($context['javascript_inline']['standard'] as $js_code) |
|
| 3553 | - echo $js_code; |
|
| 3762 | + foreach ($context['javascript_inline']['standard'] as $js_code) { |
|
| 3763 | + echo $js_code; |
|
| 3764 | + } |
|
| 3554 | 3765 | |
| 3555 | 3766 | echo ' |
| 3556 | 3767 | </script>'; |
@@ -3575,8 +3786,9 @@ discard block |
||
| 3575 | 3786 | foreach ($context['css_files'] as $id => $file) |
| 3576 | 3787 | { |
| 3577 | 3788 | // Last minute call! allow theme authors to disable single files. |
| 3578 | - if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) |
|
| 3579 | - continue; |
|
| 3789 | + if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) { |
|
| 3790 | + continue; |
|
| 3791 | + } |
|
| 3580 | 3792 | |
| 3581 | 3793 | // By default all files don't get minimized unless the file explicitly says so! |
| 3582 | 3794 | if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files'])) |
@@ -3584,12 +3796,12 @@ discard block |
||
| 3584 | 3796 | $toMinify[] = $file; |
| 3585 | 3797 | |
| 3586 | 3798 | // Grab a random seed. |
| 3587 | - if (!isset($minSeed)) |
|
| 3588 | - $minSeed = $file['options']['seed']; |
|
| 3799 | + if (!isset($minSeed)) { |
|
| 3800 | + $minSeed = $file['options']['seed']; |
|
| 3801 | + } |
|
| 3802 | + } else { |
|
| 3803 | + $normal[] = $file['fileUrl']; |
|
| 3589 | 3804 | } |
| 3590 | - |
|
| 3591 | - else |
|
| 3592 | - $normal[] = $file['fileUrl']; |
|
| 3593 | 3805 | } |
| 3594 | 3806 | |
| 3595 | 3807 | if (!empty($toMinify)) |
@@ -3597,28 +3809,30 @@ discard block |
||
| 3597 | 3809 | $result = custMinify($toMinify, 'css'); |
| 3598 | 3810 | |
| 3599 | 3811 | // Minify process couldn't work, print each individual files. |
| 3600 | - if (!empty($result) && is_array($result)) |
|
| 3601 | - foreach ($result as $minFailedFile) |
|
| 3812 | + if (!empty($result) && is_array($result)) { |
|
| 3813 | + foreach ($result as $minFailedFile) |
|
| 3602 | 3814 | echo ' |
| 3603 | 3815 | <link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">'; |
| 3604 | - |
|
| 3605 | - else |
|
| 3606 | - echo ' |
|
| 3816 | + } else { |
|
| 3817 | + echo ' |
|
| 3607 | 3818 | <link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">'; |
| 3819 | + } |
|
| 3608 | 3820 | } |
| 3609 | 3821 | |
| 3610 | 3822 | // Print the rest after the minified files. |
| 3611 | - if (!empty($normal)) |
|
| 3612 | - foreach ($normal as $nf) |
|
| 3823 | + if (!empty($normal)) { |
|
| 3824 | + foreach ($normal as $nf) |
|
| 3613 | 3825 | echo ' |
| 3614 | 3826 | <link rel="stylesheet" href="', $nf ,'">'; |
| 3827 | + } |
|
| 3615 | 3828 | |
| 3616 | 3829 | if ($db_show_debug === true) |
| 3617 | 3830 | { |
| 3618 | 3831 | // Try to keep only what's useful. |
| 3619 | 3832 | $repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => ''); |
| 3620 | - foreach ($context['css_files'] as $file) |
|
| 3621 | - $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
| 3833 | + foreach ($context['css_files'] as $file) { |
|
| 3834 | + $context['debug']['sheets'][] = strtr($file['fileName'], $repl); |
|
| 3835 | + } |
|
| 3622 | 3836 | } |
| 3623 | 3837 | |
| 3624 | 3838 | if (!empty($context['css_header'])) |
@@ -3626,9 +3840,10 @@ discard block |
||
| 3626 | 3840 | echo ' |
| 3627 | 3841 | <style>'; |
| 3628 | 3842 | |
| 3629 | - foreach ($context['css_header'] as $css) |
|
| 3630 | - echo $css .' |
|
| 3843 | + foreach ($context['css_header'] as $css) { |
|
| 3844 | + echo $css .' |
|
| 3631 | 3845 | '; |
| 3846 | + } |
|
| 3632 | 3847 | |
| 3633 | 3848 | echo' |
| 3634 | 3849 | </style>'; |
@@ -3652,15 +3867,17 @@ discard block |
||
| 3652 | 3867 | $type = !empty($type) && in_array($type, $types) ? $type : false; |
| 3653 | 3868 | $data = !empty($data) ? $data : false; |
| 3654 | 3869 | |
| 3655 | - if (empty($type) || empty($data)) |
|
| 3656 | - return false; |
|
| 3870 | + if (empty($type) || empty($data)) { |
|
| 3871 | + return false; |
|
| 3872 | + } |
|
| 3657 | 3873 | |
| 3658 | 3874 | // Did we already did this? |
| 3659 | 3875 | $toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400); |
| 3660 | 3876 | |
| 3661 | 3877 | // Already done? |
| 3662 | - if (!empty($toCache)) |
|
| 3663 | - return true; |
|
| 3878 | + if (!empty($toCache)) { |
|
| 3879 | + return true; |
|
| 3880 | + } |
|
| 3664 | 3881 | |
| 3665 | 3882 | // No namespaces, sorry! |
| 3666 | 3883 | $classType = 'MatthiasMullie\\Minify\\'. strtoupper($type); |
@@ -3742,8 +3959,9 @@ discard block |
||
| 3742 | 3959 | global $modSettings, $smcFunc; |
| 3743 | 3960 | |
| 3744 | 3961 | // Just make up a nice hash... |
| 3745 | - if ($new) |
|
| 3746 | - return sha1(md5($filename . time()) . mt_rand()); |
|
| 3962 | + if ($new) { |
|
| 3963 | + return sha1(md5($filename . time()) . mt_rand()); |
|
| 3964 | + } |
|
| 3747 | 3965 | |
| 3748 | 3966 | // Just make sure that attachment id is only a int |
| 3749 | 3967 | $attachment_id = (int) $attachment_id; |
@@ -3760,23 +3978,25 @@ discard block |
||
| 3760 | 3978 | 'id_attach' => $attachment_id, |
| 3761 | 3979 | )); |
| 3762 | 3980 | |
| 3763 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
| 3764 | - return false; |
|
| 3981 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
| 3982 | + return false; |
|
| 3983 | + } |
|
| 3765 | 3984 | |
| 3766 | 3985 | list ($file_hash) = $smcFunc['db_fetch_row']($request); |
| 3767 | 3986 | $smcFunc['db_free_result']($request); |
| 3768 | 3987 | } |
| 3769 | 3988 | |
| 3770 | 3989 | // Still no hash? mmm... |
| 3771 | - if (empty($file_hash)) |
|
| 3772 | - $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
| 3990 | + if (empty($file_hash)) { |
|
| 3991 | + $file_hash = sha1(md5($filename . time()) . mt_rand()); |
|
| 3992 | + } |
|
| 3773 | 3993 | |
| 3774 | 3994 | // Are we using multiple directories? |
| 3775 | - if (is_array($modSettings['attachmentUploadDir'])) |
|
| 3776 | - $path = $modSettings['attachmentUploadDir'][$dir]; |
|
| 3777 | - |
|
| 3778 | - else |
|
| 3779 | - $path = $modSettings['attachmentUploadDir']; |
|
| 3995 | + if (is_array($modSettings['attachmentUploadDir'])) { |
|
| 3996 | + $path = $modSettings['attachmentUploadDir'][$dir]; |
|
| 3997 | + } else { |
|
| 3998 | + $path = $modSettings['attachmentUploadDir']; |
|
| 3999 | + } |
|
| 3780 | 4000 | |
| 3781 | 4001 | return $path . '/' . $attachment_id . '_' . $file_hash .'.dat'; |
| 3782 | 4002 | } |
@@ -3791,8 +4011,9 @@ discard block |
||
| 3791 | 4011 | function ip2range($fullip) |
| 3792 | 4012 | { |
| 3793 | 4013 | // Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.) |
| 3794 | - if ($fullip == 'unknown') |
|
| 3795 | - $fullip = '255.255.255.255'; |
|
| 4014 | + if ($fullip == 'unknown') { |
|
| 4015 | + $fullip = '255.255.255.255'; |
|
| 4016 | + } |
|
| 3796 | 4017 | |
| 3797 | 4018 | $ip_parts = explode('-', $fullip); |
| 3798 | 4019 | $ip_array = array(); |
@@ -3816,10 +4037,11 @@ discard block |
||
| 3816 | 4037 | $ip_array['low'] = $ip_parts[0]; |
| 3817 | 4038 | $ip_array['high'] = $ip_parts[1]; |
| 3818 | 4039 | return $ip_array; |
| 3819 | - } |
|
| 3820 | - elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.* |
|
| 4040 | + } elseif (count($ip_parts) == 2) { |
|
| 4041 | + // if ip 22.22.*-22.22.* |
|
| 3821 | 4042 | { |
| 3822 | 4043 | $valid_low = isValidIP($ip_parts[0]); |
| 4044 | + } |
|
| 3823 | 4045 | $valid_high = isValidIP($ip_parts[1]); |
| 3824 | 4046 | $count = 0; |
| 3825 | 4047 | $mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.'); |
@@ -3834,7 +4056,9 @@ discard block |
||
| 3834 | 4056 | $ip_parts[0] .= $mode . $min; |
| 3835 | 4057 | $valid_low = isValidIP($ip_parts[0]); |
| 3836 | 4058 | $count++; |
| 3837 | - if ($count > 9) break; |
|
| 4059 | + if ($count > 9) { |
|
| 4060 | + break; |
|
| 4061 | + } |
|
| 3838 | 4062 | } |
| 3839 | 4063 | } |
| 3840 | 4064 | |
@@ -3848,7 +4072,9 @@ discard block |
||
| 3848 | 4072 | $ip_parts[1] .= $mode . $max; |
| 3849 | 4073 | $valid_high = isValidIP($ip_parts[1]); |
| 3850 | 4074 | $count++; |
| 3851 | - if ($count > 9) break; |
|
| 4075 | + if ($count > 9) { |
|
| 4076 | + break; |
|
| 4077 | + } |
|
| 3852 | 4078 | } |
| 3853 | 4079 | } |
| 3854 | 4080 | |
@@ -3873,46 +4099,54 @@ discard block |
||
| 3873 | 4099 | { |
| 3874 | 4100 | global $modSettings; |
| 3875 | 4101 | |
| 3876 | - if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) |
|
| 3877 | - return $host; |
|
| 4102 | + if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) { |
|
| 4103 | + return $host; |
|
| 4104 | + } |
|
| 3878 | 4105 | $t = microtime(); |
| 3879 | 4106 | |
| 3880 | 4107 | // Try the Linux host command, perhaps? |
| 3881 | 4108 | if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1) |
| 3882 | 4109 | { |
| 3883 | - if (!isset($modSettings['host_to_dis'])) |
|
| 3884 | - $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
| 3885 | - else |
|
| 3886 | - $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
| 4110 | + if (!isset($modSettings['host_to_dis'])) { |
|
| 4111 | + $test = @shell_exec('host -W 1 ' . @escapeshellarg($ip)); |
|
| 4112 | + } else { |
|
| 4113 | + $test = @shell_exec('host ' . @escapeshellarg($ip)); |
|
| 4114 | + } |
|
| 3887 | 4115 | |
| 3888 | 4116 | // Did host say it didn't find anything? |
| 3889 | - if (strpos($test, 'not found') !== false) |
|
| 3890 | - $host = ''; |
|
| 4117 | + if (strpos($test, 'not found') !== false) { |
|
| 4118 | + $host = ''; |
|
| 4119 | + } |
|
| 3891 | 4120 | // Invalid server option? |
| 3892 | - elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) |
|
| 3893 | - updateSettings(array('host_to_dis' => 1)); |
|
| 4121 | + elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) { |
|
| 4122 | + updateSettings(array('host_to_dis' => 1)); |
|
| 4123 | + } |
|
| 3894 | 4124 | // Maybe it found something, after all? |
| 3895 | - elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) |
|
| 3896 | - $host = $match[1]; |
|
| 4125 | + elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) { |
|
| 4126 | + $host = $match[1]; |
|
| 4127 | + } |
|
| 3897 | 4128 | } |
| 3898 | 4129 | |
| 3899 | 4130 | // This is nslookup; usually only Windows, but possibly some Unix? |
| 3900 | 4131 | if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1) |
| 3901 | 4132 | { |
| 3902 | 4133 | $test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip)); |
| 3903 | - if (strpos($test, 'Non-existent domain') !== false) |
|
| 3904 | - $host = ''; |
|
| 3905 | - elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) |
|
| 3906 | - $host = $match[1]; |
|
| 4134 | + if (strpos($test, 'Non-existent domain') !== false) { |
|
| 4135 | + $host = ''; |
|
| 4136 | + } elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) { |
|
| 4137 | + $host = $match[1]; |
|
| 4138 | + } |
|
| 3907 | 4139 | } |
| 3908 | 4140 | |
| 3909 | 4141 | // This is the last try :/. |
| 3910 | - if (!isset($host) || $host === false) |
|
| 3911 | - $host = @gethostbyaddr($ip); |
|
| 4142 | + if (!isset($host) || $host === false) { |
|
| 4143 | + $host = @gethostbyaddr($ip); |
|
| 4144 | + } |
|
| 3912 | 4145 | |
| 3913 | 4146 | // It took a long time, so let's cache it! |
| 3914 | - if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) |
|
| 3915 | - cache_put_data('hostlookup-' . $ip, $host, 600); |
|
| 4147 | + if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) { |
|
| 4148 | + cache_put_data('hostlookup-' . $ip, $host, 600); |
|
| 4149 | + } |
|
| 3916 | 4150 | |
| 3917 | 4151 | return $host; |
| 3918 | 4152 | } |
@@ -3948,20 +4182,21 @@ discard block |
||
| 3948 | 4182 | { |
| 3949 | 4183 | $encrypted = substr(crypt($word, 'uk'), 2, $max_chars); |
| 3950 | 4184 | $total = 0; |
| 3951 | - for ($i = 0; $i < $max_chars; $i++) |
|
| 3952 | - $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
| 4185 | + for ($i = 0; $i < $max_chars; $i++) { |
|
| 4186 | + $total += $possible_chars[ord($encrypted{$i})] * pow(63, $i); |
|
| 4187 | + } |
|
| 3953 | 4188 | $returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total; |
| 3954 | 4189 | } |
| 3955 | 4190 | } |
| 3956 | 4191 | return array_unique($returned_ints); |
| 3957 | - } |
|
| 3958 | - else |
|
| 4192 | + } else |
|
| 3959 | 4193 | { |
| 3960 | 4194 | // Trim characters before and after and add slashes for database insertion. |
| 3961 | 4195 | $returned_words = array(); |
| 3962 | - foreach ($words as $word) |
|
| 3963 | - if (($word = trim($word, '-_\'')) !== '') |
|
| 4196 | + foreach ($words as $word) { |
|
| 4197 | + if (($word = trim($word, '-_\'')) !== '') |
|
| 3964 | 4198 | $returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars); |
| 4199 | + } |
|
| 3965 | 4200 | |
| 3966 | 4201 | // Filter out all words that occur more than once. |
| 3967 | 4202 | return array_unique($returned_words); |
@@ -3983,16 +4218,18 @@ discard block |
||
| 3983 | 4218 | global $settings, $txt; |
| 3984 | 4219 | |
| 3985 | 4220 | // Does the current loaded theme have this and we are not forcing the usage of this function? |
| 3986 | - if (function_exists('template_create_button') && !$force_use) |
|
| 3987 | - return template_create_button($name, $alt, $label = '', $custom = ''); |
|
| 4221 | + if (function_exists('template_create_button') && !$force_use) { |
|
| 4222 | + return template_create_button($name, $alt, $label = '', $custom = ''); |
|
| 4223 | + } |
|
| 3988 | 4224 | |
| 3989 | - if (!$settings['use_image_buttons']) |
|
| 3990 | - return $txt[$alt]; |
|
| 3991 | - elseif (!empty($settings['use_buttons'])) |
|
| 3992 | - return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
| 3993 | - else |
|
| 3994 | - return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
| 3995 | -} |
|
| 4225 | + if (!$settings['use_image_buttons']) { |
|
| 4226 | + return $txt[$alt]; |
|
| 4227 | + } elseif (!empty($settings['use_buttons'])) { |
|
| 4228 | + return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? ' <strong>' . $txt[$label] . '</strong>' : ''); |
|
| 4229 | + } else { |
|
| 4230 | + return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>'; |
|
| 4231 | + } |
|
| 4232 | + } |
|
| 3996 | 4233 | |
| 3997 | 4234 | /** |
| 3998 | 4235 | * Sets up all of the top menu buttons |
@@ -4035,9 +4272,10 @@ discard block |
||
| 4035 | 4272 | var user_menus = new smc_PopupMenu(); |
| 4036 | 4273 | user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup"); |
| 4037 | 4274 | user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true); |
| 4038 | - if ($context['allow_pm']) |
|
| 4039 | - addInlineJavaScript(' |
|
| 4275 | + if ($context['allow_pm']) { |
|
| 4276 | + addInlineJavaScript(' |
|
| 4040 | 4277 | user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true); |
| 4278 | + } |
|
| 4041 | 4279 | |
| 4042 | 4280 | if (!empty($modSettings['enable_ajax_alerts'])) |
| 4043 | 4281 | { |
@@ -4197,88 +4435,96 @@ discard block |
||
| 4197 | 4435 | |
| 4198 | 4436 | // Now we put the buttons in the context so the theme can use them. |
| 4199 | 4437 | $menu_buttons = array(); |
| 4200 | - foreach ($buttons as $act => $button) |
|
| 4201 | - if (!empty($button['show'])) |
|
| 4438 | + foreach ($buttons as $act => $button) { |
|
| 4439 | + if (!empty($button['show'])) |
|
| 4202 | 4440 | { |
| 4203 | 4441 | $button['active_button'] = false; |
| 4442 | + } |
|
| 4204 | 4443 | |
| 4205 | 4444 | // This button needs some action. |
| 4206 | - if (isset($button['action_hook'])) |
|
| 4207 | - $needs_action_hook = true; |
|
| 4445 | + if (isset($button['action_hook'])) { |
|
| 4446 | + $needs_action_hook = true; |
|
| 4447 | + } |
|
| 4208 | 4448 | |
| 4209 | 4449 | // Make sure the last button truly is the last button. |
| 4210 | 4450 | if (!empty($button['is_last'])) |
| 4211 | 4451 | { |
| 4212 | - if (isset($last_button)) |
|
| 4213 | - unset($menu_buttons[$last_button]['is_last']); |
|
| 4452 | + if (isset($last_button)) { |
|
| 4453 | + unset($menu_buttons[$last_button]['is_last']); |
|
| 4454 | + } |
|
| 4214 | 4455 | $last_button = $act; |
| 4215 | 4456 | } |
| 4216 | 4457 | |
| 4217 | 4458 | // Go through the sub buttons if there are any. |
| 4218 | - if (!empty($button['sub_buttons'])) |
|
| 4219 | - foreach ($button['sub_buttons'] as $key => $subbutton) |
|
| 4459 | + if (!empty($button['sub_buttons'])) { |
|
| 4460 | + foreach ($button['sub_buttons'] as $key => $subbutton) |
|
| 4220 | 4461 | { |
| 4221 | 4462 | if (empty($subbutton['show'])) |
| 4222 | 4463 | unset($button['sub_buttons'][$key]); |
| 4464 | + } |
|
| 4223 | 4465 | |
| 4224 | 4466 | // 2nd level sub buttons next... |
| 4225 | 4467 | if (!empty($subbutton['sub_buttons'])) |
| 4226 | 4468 | { |
| 4227 | 4469 | foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2) |
| 4228 | 4470 | { |
| 4229 | - if (empty($sub_button2['show'])) |
|
| 4230 | - unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
| 4471 | + if (empty($sub_button2['show'])) { |
|
| 4472 | + unset($button['sub_buttons'][$key]['sub_buttons'][$key2]); |
|
| 4473 | + } |
|
| 4231 | 4474 | } |
| 4232 | 4475 | } |
| 4233 | 4476 | } |
| 4234 | 4477 | |
| 4235 | 4478 | // Does this button have its own icon? |
| 4236 | - if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) |
|
| 4237 | - $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4238 | - elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) |
|
| 4239 | - $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4240 | - elseif (isset($button['icon'])) |
|
| 4241 | - $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
| 4242 | - else |
|
| 4243 | - $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
| 4479 | + if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) { |
|
| 4480 | + $button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4481 | + } elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) { |
|
| 4482 | + $button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">'; |
|
| 4483 | + } elseif (isset($button['icon'])) { |
|
| 4484 | + $button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>'; |
|
| 4485 | + } else { |
|
| 4486 | + $button['icon'] = '<span class="generic_icons ' . $act . '"></span>'; |
|
| 4487 | + } |
|
| 4244 | 4488 | |
| 4245 | 4489 | $menu_buttons[$act] = $button; |
| 4246 | 4490 | } |
| 4247 | 4491 | |
| 4248 | - if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) |
|
| 4249 | - cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
| 4492 | + if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) { |
|
| 4493 | + cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime); |
|
| 4494 | + } |
|
| 4250 | 4495 | } |
| 4251 | 4496 | |
| 4252 | 4497 | $context['menu_buttons'] = $menu_buttons; |
| 4253 | 4498 | |
| 4254 | 4499 | // Logging out requires the session id in the url. |
| 4255 | - if (isset($context['menu_buttons']['logout'])) |
|
| 4256 | - $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
| 4500 | + if (isset($context['menu_buttons']['logout'])) { |
|
| 4501 | + $context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']); |
|
| 4502 | + } |
|
| 4257 | 4503 | |
| 4258 | 4504 | // Figure out which action we are doing so we can set the active tab. |
| 4259 | 4505 | // Default to home. |
| 4260 | 4506 | $current_action = 'home'; |
| 4261 | 4507 | |
| 4262 | - if (isset($context['menu_buttons'][$context['current_action']])) |
|
| 4263 | - $current_action = $context['current_action']; |
|
| 4264 | - elseif ($context['current_action'] == 'search2') |
|
| 4265 | - $current_action = 'search'; |
|
| 4266 | - elseif ($context['current_action'] == 'theme') |
|
| 4267 | - $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
| 4268 | - elseif ($context['current_action'] == 'register2') |
|
| 4269 | - $current_action = 'register'; |
|
| 4270 | - elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) |
|
| 4271 | - $current_action = 'login'; |
|
| 4272 | - elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) |
|
| 4273 | - $current_action = 'moderate'; |
|
| 4508 | + if (isset($context['menu_buttons'][$context['current_action']])) { |
|
| 4509 | + $current_action = $context['current_action']; |
|
| 4510 | + } elseif ($context['current_action'] == 'search2') { |
|
| 4511 | + $current_action = 'search'; |
|
| 4512 | + } elseif ($context['current_action'] == 'theme') { |
|
| 4513 | + $current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin'; |
|
| 4514 | + } elseif ($context['current_action'] == 'register2') { |
|
| 4515 | + $current_action = 'register'; |
|
| 4516 | + } elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) { |
|
| 4517 | + $current_action = 'login'; |
|
| 4518 | + } elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) { |
|
| 4519 | + $current_action = 'moderate'; |
|
| 4520 | + } |
|
| 4274 | 4521 | |
| 4275 | 4522 | // There are certain exceptions to the above where we don't want anything on the menu highlighted. |
| 4276 | 4523 | if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner'])) |
| 4277 | 4524 | { |
| 4278 | 4525 | $current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile'; |
| 4279 | 4526 | $context[$current_action] = true; |
| 4280 | - } |
|
| 4281 | - elseif ($context['current_action'] == 'pm') |
|
| 4527 | + } elseif ($context['current_action'] == 'pm') |
|
| 4282 | 4528 | { |
| 4283 | 4529 | $current_action = 'self_pm'; |
| 4284 | 4530 | $context['self_pm'] = true; |
@@ -4319,12 +4565,14 @@ discard block |
||
| 4319 | 4565 | } |
| 4320 | 4566 | |
| 4321 | 4567 | // Not all actions are simple. |
| 4322 | - if (!empty($needs_action_hook)) |
|
| 4323 | - call_integration_hook('integrate_current_action', array(&$current_action)); |
|
| 4568 | + if (!empty($needs_action_hook)) { |
|
| 4569 | + call_integration_hook('integrate_current_action', array(&$current_action)); |
|
| 4570 | + } |
|
| 4324 | 4571 | |
| 4325 | - if (isset($context['menu_buttons'][$current_action])) |
|
| 4326 | - $context['menu_buttons'][$current_action]['active_button'] = true; |
|
| 4327 | -} |
|
| 4572 | + if (isset($context['menu_buttons'][$current_action])) { |
|
| 4573 | + $context['menu_buttons'][$current_action]['active_button'] = true; |
|
| 4574 | + } |
|
| 4575 | + } |
|
| 4328 | 4576 | |
| 4329 | 4577 | /** |
| 4330 | 4578 | * Generate a random seed and ensure it's stored in settings. |
@@ -4348,30 +4596,35 @@ discard block |
||
| 4348 | 4596 | global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug; |
| 4349 | 4597 | global $context, $txt; |
| 4350 | 4598 | |
| 4351 | - if ($db_show_debug === true) |
|
| 4352 | - $context['debug']['hooks'][] = $hook; |
|
| 4599 | + if ($db_show_debug === true) { |
|
| 4600 | + $context['debug']['hooks'][] = $hook; |
|
| 4601 | + } |
|
| 4353 | 4602 | |
| 4354 | 4603 | // Need to have some control. |
| 4355 | - if (!isset($context['instances'])) |
|
| 4356 | - $context['instances'] = array(); |
|
| 4604 | + if (!isset($context['instances'])) { |
|
| 4605 | + $context['instances'] = array(); |
|
| 4606 | + } |
|
| 4357 | 4607 | |
| 4358 | 4608 | $results = array(); |
| 4359 | - if (empty($modSettings[$hook])) |
|
| 4360 | - return $results; |
|
| 4609 | + if (empty($modSettings[$hook])) { |
|
| 4610 | + return $results; |
|
| 4611 | + } |
|
| 4361 | 4612 | |
| 4362 | 4613 | $functions = explode(',', $modSettings[$hook]); |
| 4363 | 4614 | // Loop through each function. |
| 4364 | 4615 | foreach ($functions as $function) |
| 4365 | 4616 | { |
| 4366 | 4617 | // Hook has been marked as "disabled". Skip it! |
| 4367 | - if (strpos($function, '!') !== false) |
|
| 4368 | - continue; |
|
| 4618 | + if (strpos($function, '!') !== false) { |
|
| 4619 | + continue; |
|
| 4620 | + } |
|
| 4369 | 4621 | |
| 4370 | 4622 | $call = call_helper($function, true); |
| 4371 | 4623 | |
| 4372 | 4624 | // Is it valid? |
| 4373 | - if (!empty($call)) |
|
| 4374 | - $results[$function] = call_user_func_array($call, $parameters); |
|
| 4625 | + if (!empty($call)) { |
|
| 4626 | + $results[$function] = call_user_func_array($call, $parameters); |
|
| 4627 | + } |
|
| 4375 | 4628 | |
| 4376 | 4629 | // Whatever it was suppose to call, it failed :( |
| 4377 | 4630 | elseif (!empty($function)) |
@@ -4387,8 +4640,9 @@ discard block |
||
| 4387 | 4640 | } |
| 4388 | 4641 | |
| 4389 | 4642 | // "Assume" the file resides on $boarddir somewhere... |
| 4390 | - else |
|
| 4391 | - log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
| 4643 | + else { |
|
| 4644 | + log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general'); |
|
| 4645 | + } |
|
| 4392 | 4646 | } |
| 4393 | 4647 | } |
| 4394 | 4648 | |
@@ -4410,12 +4664,14 @@ discard block |
||
| 4410 | 4664 | global $smcFunc, $modSettings; |
| 4411 | 4665 | |
| 4412 | 4666 | // Any objects? |
| 4413 | - if ($object) |
|
| 4414 | - $function = $function . '#'; |
|
| 4667 | + if ($object) { |
|
| 4668 | + $function = $function . '#'; |
|
| 4669 | + } |
|
| 4415 | 4670 | |
| 4416 | 4671 | // Any files to load? |
| 4417 | - if (!empty($file) && is_string($file)) |
|
| 4418 | - $function = $file . (!empty($function) ? '|' . $function : ''); |
|
| 4672 | + if (!empty($file) && is_string($file)) { |
|
| 4673 | + $function = $file . (!empty($function) ? '|' . $function : ''); |
|
| 4674 | + } |
|
| 4419 | 4675 | |
| 4420 | 4676 | // Get the correct string. |
| 4421 | 4677 | $integration_call = $function; |
@@ -4437,13 +4693,14 @@ discard block |
||
| 4437 | 4693 | if (!empty($current_functions)) |
| 4438 | 4694 | { |
| 4439 | 4695 | $current_functions = explode(',', $current_functions); |
| 4440 | - if (in_array($integration_call, $current_functions)) |
|
| 4441 | - return; |
|
| 4696 | + if (in_array($integration_call, $current_functions)) { |
|
| 4697 | + return; |
|
| 4698 | + } |
|
| 4442 | 4699 | |
| 4443 | 4700 | $permanent_functions = array_merge($current_functions, array($integration_call)); |
| 4701 | + } else { |
|
| 4702 | + $permanent_functions = array($integration_call); |
|
| 4444 | 4703 | } |
| 4445 | - else |
|
| 4446 | - $permanent_functions = array($integration_call); |
|
| 4447 | 4704 | |
| 4448 | 4705 | updateSettings(array($hook => implode(',', $permanent_functions))); |
| 4449 | 4706 | } |
@@ -4452,8 +4709,9 @@ discard block |
||
| 4452 | 4709 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
| 4453 | 4710 | |
| 4454 | 4711 | // Do nothing, if it's already there. |
| 4455 | - if (in_array($integration_call, $functions)) |
|
| 4456 | - return; |
|
| 4712 | + if (in_array($integration_call, $functions)) { |
|
| 4713 | + return; |
|
| 4714 | + } |
|
| 4457 | 4715 | |
| 4458 | 4716 | $functions[] = $integration_call; |
| 4459 | 4717 | $modSettings[$hook] = implode(',', $functions); |
@@ -4476,12 +4734,14 @@ discard block |
||
| 4476 | 4734 | global $smcFunc, $modSettings; |
| 4477 | 4735 | |
| 4478 | 4736 | // Any objects? |
| 4479 | - if ($object) |
|
| 4480 | - $function = $function . '#'; |
|
| 4737 | + if ($object) { |
|
| 4738 | + $function = $function . '#'; |
|
| 4739 | + } |
|
| 4481 | 4740 | |
| 4482 | 4741 | // Any files to load? |
| 4483 | - if (!empty($file) && is_string($file)) |
|
| 4484 | - $function = $file . '|' . $function; |
|
| 4742 | + if (!empty($file) && is_string($file)) { |
|
| 4743 | + $function = $file . '|' . $function; |
|
| 4744 | + } |
|
| 4485 | 4745 | |
| 4486 | 4746 | // Get the correct string. |
| 4487 | 4747 | $integration_call = $function; |
@@ -4502,16 +4762,18 @@ discard block |
||
| 4502 | 4762 | { |
| 4503 | 4763 | $current_functions = explode(',', $current_functions); |
| 4504 | 4764 | |
| 4505 | - if (in_array($integration_call, $current_functions)) |
|
| 4506 | - updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
| 4765 | + if (in_array($integration_call, $current_functions)) { |
|
| 4766 | + updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call))))); |
|
| 4767 | + } |
|
| 4507 | 4768 | } |
| 4508 | 4769 | |
| 4509 | 4770 | // Turn the function list into something usable. |
| 4510 | 4771 | $functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]); |
| 4511 | 4772 | |
| 4512 | 4773 | // You can only remove it if it's available. |
| 4513 | - if (!in_array($integration_call, $functions)) |
|
| 4514 | - return; |
|
| 4774 | + if (!in_array($integration_call, $functions)) { |
|
| 4775 | + return; |
|
| 4776 | + } |
|
| 4515 | 4777 | |
| 4516 | 4778 | $functions = array_diff($functions, array($integration_call)); |
| 4517 | 4779 | $modSettings[$hook] = implode(',', $functions); |
@@ -4532,17 +4794,20 @@ discard block |
||
| 4532 | 4794 | global $context, $smcFunc, $txt, $db_show_debug; |
| 4533 | 4795 | |
| 4534 | 4796 | // Really? |
| 4535 | - if (empty($string)) |
|
| 4536 | - return false; |
|
| 4797 | + if (empty($string)) { |
|
| 4798 | + return false; |
|
| 4799 | + } |
|
| 4537 | 4800 | |
| 4538 | 4801 | // An array? should be a "callable" array IE array(object/class, valid_callable). |
| 4539 | 4802 | // A closure? should be a callable one. |
| 4540 | - if (is_array($string) || $string instanceof Closure) |
|
| 4541 | - return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
| 4803 | + if (is_array($string) || $string instanceof Closure) { |
|
| 4804 | + return $return ? $string : (is_callable($string) ? call_user_func($string) : false); |
|
| 4805 | + } |
|
| 4542 | 4806 | |
| 4543 | 4807 | // No full objects, sorry! pass a method or a property instead! |
| 4544 | - if (is_object($string)) |
|
| 4545 | - return false; |
|
| 4808 | + if (is_object($string)) { |
|
| 4809 | + return false; |
|
| 4810 | + } |
|
| 4546 | 4811 | |
| 4547 | 4812 | // Stay vitaminized my friends... |
| 4548 | 4813 | $string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string)); |
@@ -4551,8 +4816,9 @@ discard block |
||
| 4551 | 4816 | $string = load_file($string); |
| 4552 | 4817 | |
| 4553 | 4818 | // Loaded file failed |
| 4554 | - if (empty($string)) |
|
| 4555 | - return false; |
|
| 4819 | + if (empty($string)) { |
|
| 4820 | + return false; |
|
| 4821 | + } |
|
| 4556 | 4822 | |
| 4557 | 4823 | // Found a method. |
| 4558 | 4824 | if (strpos($string, '::') !== false) |
@@ -4573,8 +4839,9 @@ discard block |
||
| 4573 | 4839 | // Add another one to the list. |
| 4574 | 4840 | if ($db_show_debug === true) |
| 4575 | 4841 | { |
| 4576 | - if (!isset($context['debug']['instances'])) |
|
| 4577 | - $context['debug']['instances'] = array(); |
|
| 4842 | + if (!isset($context['debug']['instances'])) { |
|
| 4843 | + $context['debug']['instances'] = array(); |
|
| 4844 | + } |
|
| 4578 | 4845 | |
| 4579 | 4846 | $context['debug']['instances'][$class] = $class; |
| 4580 | 4847 | } |
@@ -4584,13 +4851,15 @@ discard block |
||
| 4584 | 4851 | } |
| 4585 | 4852 | |
| 4586 | 4853 | // Right then. This is a call to a static method. |
| 4587 | - else |
|
| 4588 | - $func = array($class, $method); |
|
| 4854 | + else { |
|
| 4855 | + $func = array($class, $method); |
|
| 4856 | + } |
|
| 4589 | 4857 | } |
| 4590 | 4858 | |
| 4591 | 4859 | // Nope! just a plain regular function. |
| 4592 | - else |
|
| 4593 | - $func = $string; |
|
| 4860 | + else { |
|
| 4861 | + $func = $string; |
|
| 4862 | + } |
|
| 4594 | 4863 | |
| 4595 | 4864 | // Right, we got what we need, time to do some checks. |
| 4596 | 4865 | if (!is_callable($func, false, $callable_name)) |
@@ -4606,17 +4875,18 @@ discard block |
||
| 4606 | 4875 | else |
| 4607 | 4876 | { |
| 4608 | 4877 | // What are we gonna do about it? |
| 4609 | - if ($return) |
|
| 4610 | - return $func; |
|
| 4878 | + if ($return) { |
|
| 4879 | + return $func; |
|
| 4880 | + } |
|
| 4611 | 4881 | |
| 4612 | 4882 | // If this is a plain function, avoid the heat of calling call_user_func(). |
| 4613 | 4883 | else |
| 4614 | 4884 | { |
| 4615 | - if (is_array($func)) |
|
| 4616 | - call_user_func($func); |
|
| 4617 | - |
|
| 4618 | - else |
|
| 4619 | - $func(); |
|
| 4885 | + if (is_array($func)) { |
|
| 4886 | + call_user_func($func); |
|
| 4887 | + } else { |
|
| 4888 | + $func(); |
|
| 4889 | + } |
|
| 4620 | 4890 | } |
| 4621 | 4891 | } |
| 4622 | 4892 | } |
@@ -4633,31 +4903,34 @@ discard block |
||
| 4633 | 4903 | { |
| 4634 | 4904 | global $sourcedir, $txt, $boarddir, $settings; |
| 4635 | 4905 | |
| 4636 | - if (empty($string)) |
|
| 4637 | - return false; |
|
| 4906 | + if (empty($string)) { |
|
| 4907 | + return false; |
|
| 4908 | + } |
|
| 4638 | 4909 | |
| 4639 | 4910 | if (strpos($string, '|') !== false) |
| 4640 | 4911 | { |
| 4641 | 4912 | list ($file, $string) = explode('|', $string); |
| 4642 | 4913 | |
| 4643 | 4914 | // Match the wildcards to their regular vars. |
| 4644 | - if (empty($settings['theme_dir'])) |
|
| 4645 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 4646 | - |
|
| 4647 | - else |
|
| 4648 | - $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 4915 | + if (empty($settings['theme_dir'])) { |
|
| 4916 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 4917 | + } else { |
|
| 4918 | + $absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 4919 | + } |
|
| 4649 | 4920 | |
| 4650 | 4921 | // Load the file if it can be loaded. |
| 4651 | - if (file_exists($absPath)) |
|
| 4652 | - require_once($absPath); |
|
| 4922 | + if (file_exists($absPath)) { |
|
| 4923 | + require_once($absPath); |
|
| 4924 | + } |
|
| 4653 | 4925 | |
| 4654 | 4926 | // No? try a fallback to $sourcedir |
| 4655 | 4927 | else |
| 4656 | 4928 | { |
| 4657 | 4929 | $absPath = $sourcedir .'/'. $file; |
| 4658 | 4930 | |
| 4659 | - if (file_exists($absPath)) |
|
| 4660 | - require_once($absPath); |
|
| 4931 | + if (file_exists($absPath)) { |
|
| 4932 | + require_once($absPath); |
|
| 4933 | + } |
|
| 4661 | 4934 | |
| 4662 | 4935 | // Sorry, can't do much for you at this point. |
| 4663 | 4936 | else |
@@ -4684,8 +4957,9 @@ discard block |
||
| 4684 | 4957 | global $user_info, $smcFunc; |
| 4685 | 4958 | |
| 4686 | 4959 | // Make sure we have something to work with. |
| 4687 | - if (empty($topic)) |
|
| 4688 | - return array(); |
|
| 4960 | + if (empty($topic)) { |
|
| 4961 | + return array(); |
|
| 4962 | + } |
|
| 4689 | 4963 | |
| 4690 | 4964 | |
| 4691 | 4965 | // We already know the number of likes per message, we just want to know whether the current user liked it or not. |
@@ -4708,8 +4982,9 @@ discard block |
||
| 4708 | 4982 | 'topic' => $topic, |
| 4709 | 4983 | ) |
| 4710 | 4984 | ); |
| 4711 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 4712 | - $temp[] = (int) $row['content_id']; |
|
| 4985 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 4986 | + $temp[] = (int) $row['content_id']; |
|
| 4987 | + } |
|
| 4713 | 4988 | |
| 4714 | 4989 | cache_put_data($cache_key, $temp, $ttl); |
| 4715 | 4990 | } |
@@ -4730,8 +5005,9 @@ discard block |
||
| 4730 | 5005 | { |
| 4731 | 5006 | global $context; |
| 4732 | 5007 | |
| 4733 | - if (empty($string)) |
|
| 4734 | - return $string; |
|
| 5008 | + if (empty($string)) { |
|
| 5009 | + return $string; |
|
| 5010 | + } |
|
| 4735 | 5011 | |
| 4736 | 5012 | // UTF-8 occurences of MS special characters |
| 4737 | 5013 | $findchars_utf8 = array( |
@@ -4772,10 +5048,11 @@ discard block |
||
| 4772 | 5048 | '--', // — |
| 4773 | 5049 | ); |
| 4774 | 5050 | |
| 4775 | - if ($context['utf8']) |
|
| 4776 | - $string = str_replace($findchars_utf8, $replacechars, $string); |
|
| 4777 | - else |
|
| 4778 | - $string = str_replace($findchars_iso, $replacechars, $string); |
|
| 5051 | + if ($context['utf8']) { |
|
| 5052 | + $string = str_replace($findchars_utf8, $replacechars, $string); |
|
| 5053 | + } else { |
|
| 5054 | + $string = str_replace($findchars_iso, $replacechars, $string); |
|
| 5055 | + } |
|
| 4779 | 5056 | |
| 4780 | 5057 | return $string; |
| 4781 | 5058 | } |
@@ -4794,49 +5071,59 @@ discard block |
||
| 4794 | 5071 | { |
| 4795 | 5072 | global $context; |
| 4796 | 5073 | |
| 4797 | - if (!isset($matches[2])) |
|
| 4798 | - return ''; |
|
| 5074 | + if (!isset($matches[2])) { |
|
| 5075 | + return ''; |
|
| 5076 | + } |
|
| 4799 | 5077 | |
| 4800 | 5078 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
| 4801 | 5079 | |
| 4802 | 5080 | // remove left to right / right to left overrides |
| 4803 | - if ($num === 0x202D || $num === 0x202E) |
|
| 4804 | - return ''; |
|
| 5081 | + if ($num === 0x202D || $num === 0x202E) { |
|
| 5082 | + return ''; |
|
| 5083 | + } |
|
| 4805 | 5084 | |
| 4806 | 5085 | // Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced |
| 4807 | - if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) |
|
| 4808 | - return '&#' . $num . ';'; |
|
| 5086 | + if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) { |
|
| 5087 | + return '&#' . $num . ';'; |
|
| 5088 | + } |
|
| 4809 | 5089 | |
| 4810 | 5090 | if (empty($context['utf8'])) |
| 4811 | 5091 | { |
| 4812 | 5092 | // no control characters |
| 4813 | - if ($num < 0x20) |
|
| 4814 | - return ''; |
|
| 5093 | + if ($num < 0x20) { |
|
| 5094 | + return ''; |
|
| 5095 | + } |
|
| 4815 | 5096 | // text is text |
| 4816 | - elseif ($num < 0x80) |
|
| 4817 | - return chr($num); |
|
| 5097 | + elseif ($num < 0x80) { |
|
| 5098 | + return chr($num); |
|
| 5099 | + } |
|
| 4818 | 5100 | // all others get html-ised |
| 4819 | - else |
|
| 4820 | - return '&#' . $matches[2] . ';'; |
|
| 4821 | - } |
|
| 4822 | - else |
|
| 5101 | + else { |
|
| 5102 | + return '&#' . $matches[2] . ';'; |
|
| 5103 | + } |
|
| 5104 | + } else |
|
| 4823 | 5105 | { |
| 4824 | 5106 | // <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set |
| 4825 | 5107 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text) |
| 4826 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) |
|
| 4827 | - return ''; |
|
| 5108 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) { |
|
| 5109 | + return ''; |
|
| 5110 | + } |
|
| 4828 | 5111 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
| 4829 | - elseif ($num < 0x80) |
|
| 4830 | - return chr($num); |
|
| 5112 | + elseif ($num < 0x80) { |
|
| 5113 | + return chr($num); |
|
| 5114 | + } |
|
| 4831 | 5115 | // <0x800 (2048) |
| 4832 | - elseif ($num < 0x800) |
|
| 4833 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5116 | + elseif ($num < 0x800) { |
|
| 5117 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5118 | + } |
|
| 4834 | 5119 | // < 0x10000 (65536) |
| 4835 | - elseif ($num < 0x10000) |
|
| 4836 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5120 | + elseif ($num < 0x10000) { |
|
| 5121 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5122 | + } |
|
| 4837 | 5123 | // <= 0x10FFFF (1114111) |
| 4838 | - else |
|
| 4839 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5124 | + else { |
|
| 5125 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5126 | + } |
|
| 4840 | 5127 | } |
| 4841 | 5128 | } |
| 4842 | 5129 | |
@@ -4852,28 +5139,34 @@ discard block |
||
| 4852 | 5139 | */ |
| 4853 | 5140 | function fixchar__callback($matches) |
| 4854 | 5141 | { |
| 4855 | - if (!isset($matches[1])) |
|
| 4856 | - return ''; |
|
| 5142 | + if (!isset($matches[1])) { |
|
| 5143 | + return ''; |
|
| 5144 | + } |
|
| 4857 | 5145 | |
| 4858 | 5146 | $num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1]; |
| 4859 | 5147 | |
| 4860 | 5148 | // <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set |
| 4861 | 5149 | // 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides |
| 4862 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) |
|
| 4863 | - return ''; |
|
| 5150 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) { |
|
| 5151 | + return ''; |
|
| 5152 | + } |
|
| 4864 | 5153 | // <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation |
| 4865 | - elseif ($num < 0x80) |
|
| 4866 | - return chr($num); |
|
| 5154 | + elseif ($num < 0x80) { |
|
| 5155 | + return chr($num); |
|
| 5156 | + } |
|
| 4867 | 5157 | // <0x800 (2048) |
| 4868 | - elseif ($num < 0x800) |
|
| 4869 | - return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5158 | + elseif ($num < 0x800) { |
|
| 5159 | + return chr(($num >> 6) + 192) . chr(($num & 63) + 128); |
|
| 5160 | + } |
|
| 4870 | 5161 | // < 0x10000 (65536) |
| 4871 | - elseif ($num < 0x10000) |
|
| 4872 | - return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5162 | + elseif ($num < 0x10000) { |
|
| 5163 | + return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5164 | + } |
|
| 4873 | 5165 | // <= 0x10FFFF (1114111) |
| 4874 | - else |
|
| 4875 | - return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 4876 | -} |
|
| 5166 | + else { |
|
| 5167 | + return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128); |
|
| 5168 | + } |
|
| 5169 | + } |
|
| 4877 | 5170 | |
| 4878 | 5171 | /** |
| 4879 | 5172 | * Strips out invalid html entities, replaces others with html style { codes |
@@ -4886,17 +5179,19 @@ discard block |
||
| 4886 | 5179 | */ |
| 4887 | 5180 | function entity_fix__callback($matches) |
| 4888 | 5181 | { |
| 4889 | - if (!isset($matches[2])) |
|
| 4890 | - return ''; |
|
| 5182 | + if (!isset($matches[2])) { |
|
| 5183 | + return ''; |
|
| 5184 | + } |
|
| 4891 | 5185 | |
| 4892 | 5186 | $num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2]; |
| 4893 | 5187 | |
| 4894 | 5188 | // we don't allow control characters, characters out of range, byte markers, etc |
| 4895 | - if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) |
|
| 4896 | - return ''; |
|
| 4897 | - else |
|
| 4898 | - return '&#' . $num . ';'; |
|
| 4899 | -} |
|
| 5189 | + if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) { |
|
| 5190 | + return ''; |
|
| 5191 | + } else { |
|
| 5192 | + return '&#' . $num . ';'; |
|
| 5193 | + } |
|
| 5194 | + } |
|
| 4900 | 5195 | |
| 4901 | 5196 | /** |
| 4902 | 5197 | * Return a Gravatar URL based on |
@@ -4920,18 +5215,23 @@ discard block |
||
| 4920 | 5215 | $ratings = array('G', 'PG', 'R', 'X'); |
| 4921 | 5216 | $defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank'); |
| 4922 | 5217 | $url_params = array(); |
| 4923 | - if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) |
|
| 4924 | - $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
| 4925 | - if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) |
|
| 4926 | - $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
| 4927 | - if (!empty($modSettings['avatar_max_width_external'])) |
|
| 4928 | - $size_string = (int) $modSettings['avatar_max_width_external']; |
|
| 4929 | - if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) |
|
| 4930 | - if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
| 5218 | + if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) { |
|
| 5219 | + $url_params[] = 'rating=' . $modSettings['gravatarMaxRating']; |
|
| 5220 | + } |
|
| 5221 | + if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) { |
|
| 5222 | + $url_params[] = 'default=' . $modSettings['gravatarDefault']; |
|
| 5223 | + } |
|
| 5224 | + if (!empty($modSettings['avatar_max_width_external'])) { |
|
| 5225 | + $size_string = (int) $modSettings['avatar_max_width_external']; |
|
| 5226 | + } |
|
| 5227 | + if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) { |
|
| 5228 | + if ((int) $modSettings['avatar_max_height_external'] < $size_string) |
|
| 4931 | 5229 | $size_string = $modSettings['avatar_max_height_external']; |
| 5230 | + } |
|
| 4932 | 5231 | |
| 4933 | - if (!empty($size_string)) |
|
| 4934 | - $url_params[] = 's=' . $size_string; |
|
| 5232 | + if (!empty($size_string)) { |
|
| 5233 | + $url_params[] = 's=' . $size_string; |
|
| 5234 | + } |
|
| 4935 | 5235 | } |
| 4936 | 5236 | $http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www'; |
| 4937 | 5237 | |
@@ -4950,22 +5250,26 @@ discard block |
||
| 4950 | 5250 | static $timezones = null, $lastwhen = null; |
| 4951 | 5251 | |
| 4952 | 5252 | // No point doing this over if we already did it once |
| 4953 | - if (!empty($timezones) && $when == $lastwhen) |
|
| 4954 | - return $timezones; |
|
| 4955 | - else |
|
| 4956 | - $lastwhen = $when; |
|
| 5253 | + if (!empty($timezones) && $when == $lastwhen) { |
|
| 5254 | + return $timezones; |
|
| 5255 | + } else { |
|
| 5256 | + $lastwhen = $when; |
|
| 5257 | + } |
|
| 4957 | 5258 | |
| 4958 | 5259 | // Parseable datetime string? |
| 4959 | - if (is_int($timestamp = strtotime($when))) |
|
| 4960 | - $when = $timestamp; |
|
| 5260 | + if (is_int($timestamp = strtotime($when))) { |
|
| 5261 | + $when = $timestamp; |
|
| 5262 | + } |
|
| 4961 | 5263 | |
| 4962 | 5264 | // A Unix timestamp? |
| 4963 | - elseif (is_numeric($when)) |
|
| 4964 | - $when = intval($when); |
|
| 5265 | + elseif (is_numeric($when)) { |
|
| 5266 | + $when = intval($when); |
|
| 5267 | + } |
|
| 4965 | 5268 | |
| 4966 | 5269 | // Invalid value? Just get current Unix timestamp. |
| 4967 | - else |
|
| 4968 | - $when = time(); |
|
| 5270 | + else { |
|
| 5271 | + $when = time(); |
|
| 5272 | + } |
|
| 4969 | 5273 | |
| 4970 | 5274 | // We'll need these too |
| 4971 | 5275 | $date_when = date_create('@' . $when); |
@@ -5029,8 +5333,9 @@ discard block |
||
| 5029 | 5333 | foreach ($priority_countries as $country) |
| 5030 | 5334 | { |
| 5031 | 5335 | $country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country))); |
| 5032 | - if (!empty($country_tzids)) |
|
| 5033 | - $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
| 5336 | + if (!empty($country_tzids)) { |
|
| 5337 | + $priority_tzids = array_merge($priority_tzids, $country_tzids); |
|
| 5338 | + } |
|
| 5034 | 5339 | } |
| 5035 | 5340 | |
| 5036 | 5341 | // Process the preferred timezones first, then the rest. |
@@ -5040,8 +5345,9 @@ discard block |
||
| 5040 | 5345 | foreach ($tzids as $tzid) |
| 5041 | 5346 | { |
| 5042 | 5347 | // We don't want UTC right now |
| 5043 | - if ($tzid == 'UTC') |
|
| 5044 | - continue; |
|
| 5348 | + if ($tzid == 'UTC') { |
|
| 5349 | + continue; |
|
| 5350 | + } |
|
| 5045 | 5351 | |
| 5046 | 5352 | $tz = timezone_open($tzid); |
| 5047 | 5353 | |
@@ -5056,12 +5362,14 @@ discard block |
||
| 5056 | 5362 | $tzgeo = timezone_location_get($tz); |
| 5057 | 5363 | |
| 5058 | 5364 | // Don't overwrite our preferred tzids |
| 5059 | - if (empty($zones[$tzkey]['tzid'])) |
|
| 5060 | - $zones[$tzkey]['tzid'] = $tzid; |
|
| 5365 | + if (empty($zones[$tzkey]['tzid'])) { |
|
| 5366 | + $zones[$tzkey]['tzid'] = $tzid; |
|
| 5367 | + } |
|
| 5061 | 5368 | |
| 5062 | 5369 | // A time zone from a prioritized country? |
| 5063 | - if (in_array($tzid, $priority_tzids)) |
|
| 5064 | - $priority_zones[$tzkey] = true; |
|
| 5370 | + if (in_array($tzid, $priority_tzids)) { |
|
| 5371 | + $priority_zones[$tzkey] = true; |
|
| 5372 | + } |
|
| 5065 | 5373 | |
| 5066 | 5374 | // Keep track of the location and offset for this tzid |
| 5067 | 5375 | $tzid_parts = explode('/', $tzid); |
@@ -5082,15 +5390,17 @@ discard block |
||
| 5082 | 5390 | |
| 5083 | 5391 | date_timezone_set($date_when, timezone_open($tzvalue['tzid'])); |
| 5084 | 5392 | |
| 5085 | - if (!empty($timezone_descriptions[$tzvalue['tzid']])) |
|
| 5086 | - $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
| 5087 | - else |
|
| 5088 | - $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
| 5393 | + if (!empty($timezone_descriptions[$tzvalue['tzid']])) { |
|
| 5394 | + $desc = $timezone_descriptions[$tzvalue['tzid']]; |
|
| 5395 | + } else { |
|
| 5396 | + $desc = implode(', ', array_unique($tzvalue['locations'])); |
|
| 5397 | + } |
|
| 5089 | 5398 | |
| 5090 | - if (isset($priority_zones[$tzkey])) |
|
| 5091 | - $priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
| 5092 | - else |
|
| 5093 | - $timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
| 5399 | + if (isset($priority_zones[$tzkey])) { |
|
| 5400 | + $priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
| 5401 | + } else { |
|
| 5402 | + $timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']'; |
|
| 5403 | + } |
|
| 5094 | 5404 | } |
| 5095 | 5405 | |
| 5096 | 5406 | $timezones = array_merge( |
@@ -5144,9 +5454,9 @@ discard block |
||
| 5144 | 5454 | 'Indian/Kerguelen' => 'TFT', |
| 5145 | 5455 | ); |
| 5146 | 5456 | |
| 5147 | - if (!empty($missing_tz_abbrs[$tzid])) |
|
| 5148 | - $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
| 5149 | - else |
|
| 5457 | + if (!empty($missing_tz_abbrs[$tzid])) { |
|
| 5458 | + $tz_abbrev = $missing_tz_abbrs[$tzid]; |
|
| 5459 | + } else |
|
| 5150 | 5460 | { |
| 5151 | 5461 | // Russia likes to experiment with time zones often, and names them as offsets from Moscow |
| 5152 | 5462 | $tz_location = timezone_location_get(timezone_open($tzid)); |
@@ -5174,8 +5484,9 @@ discard block |
||
| 5174 | 5484 | */ |
| 5175 | 5485 | function inet_ptod($ip_address) |
| 5176 | 5486 | { |
| 5177 | - if (!isValidIP($ip_address)) |
|
| 5178 | - return $ip_address; |
|
| 5487 | + if (!isValidIP($ip_address)) { |
|
| 5488 | + return $ip_address; |
|
| 5489 | + } |
|
| 5179 | 5490 | |
| 5180 | 5491 | $bin = inet_pton($ip_address); |
| 5181 | 5492 | return $bin; |
@@ -5187,13 +5498,15 @@ discard block |
||
| 5187 | 5498 | */ |
| 5188 | 5499 | function inet_dtop($bin) |
| 5189 | 5500 | { |
| 5190 | - if(empty($bin)) |
|
| 5191 | - return ''; |
|
| 5501 | + if(empty($bin)) { |
|
| 5502 | + return ''; |
|
| 5503 | + } |
|
| 5192 | 5504 | |
| 5193 | 5505 | global $db_type; |
| 5194 | 5506 | |
| 5195 | - if ($db_type == 'postgresql') |
|
| 5196 | - return $bin; |
|
| 5507 | + if ($db_type == 'postgresql') { |
|
| 5508 | + return $bin; |
|
| 5509 | + } |
|
| 5197 | 5510 | |
| 5198 | 5511 | $ip_address = inet_ntop($bin); |
| 5199 | 5512 | |
@@ -5218,26 +5531,32 @@ discard block |
||
| 5218 | 5531 | */ |
| 5219 | 5532 | function _safe_serialize($value) |
| 5220 | 5533 | { |
| 5221 | - if(is_null($value)) |
|
| 5222 | - return 'N;'; |
|
| 5534 | + if(is_null($value)) { |
|
| 5535 | + return 'N;'; |
|
| 5536 | + } |
|
| 5223 | 5537 | |
| 5224 | - if(is_bool($value)) |
|
| 5225 | - return 'b:'. (int) $value .';'; |
|
| 5538 | + if(is_bool($value)) { |
|
| 5539 | + return 'b:'. (int) $value .';'; |
|
| 5540 | + } |
|
| 5226 | 5541 | |
| 5227 | - if(is_int($value)) |
|
| 5228 | - return 'i:'. $value .';'; |
|
| 5542 | + if(is_int($value)) { |
|
| 5543 | + return 'i:'. $value .';'; |
|
| 5544 | + } |
|
| 5229 | 5545 | |
| 5230 | - if(is_float($value)) |
|
| 5231 | - return 'd:'. str_replace(',', '.', $value) .';'; |
|
| 5546 | + if(is_float($value)) { |
|
| 5547 | + return 'd:'. str_replace(',', '.', $value) .';'; |
|
| 5548 | + } |
|
| 5232 | 5549 | |
| 5233 | - if(is_string($value)) |
|
| 5234 | - return 's:'. strlen($value) .':"'. $value .'";'; |
|
| 5550 | + if(is_string($value)) { |
|
| 5551 | + return 's:'. strlen($value) .':"'. $value .'";'; |
|
| 5552 | + } |
|
| 5235 | 5553 | |
| 5236 | 5554 | if(is_array($value)) |
| 5237 | 5555 | { |
| 5238 | 5556 | $out = ''; |
| 5239 | - foreach($value as $k => $v) |
|
| 5240 | - $out .= _safe_serialize($k) . _safe_serialize($v); |
|
| 5557 | + foreach($value as $k => $v) { |
|
| 5558 | + $out .= _safe_serialize($k) . _safe_serialize($v); |
|
| 5559 | + } |
|
| 5241 | 5560 | |
| 5242 | 5561 | return 'a:'. count($value) .':{'. $out .'}'; |
| 5243 | 5562 | } |
@@ -5263,8 +5582,9 @@ discard block |
||
| 5263 | 5582 | |
| 5264 | 5583 | $out = _safe_serialize($value); |
| 5265 | 5584 | |
| 5266 | - if (isset($mbIntEnc)) |
|
| 5267 | - mb_internal_encoding($mbIntEnc); |
|
| 5585 | + if (isset($mbIntEnc)) { |
|
| 5586 | + mb_internal_encoding($mbIntEnc); |
|
| 5587 | + } |
|
| 5268 | 5588 | |
| 5269 | 5589 | return $out; |
| 5270 | 5590 | } |
@@ -5281,8 +5601,9 @@ discard block |
||
| 5281 | 5601 | function _safe_unserialize($str) |
| 5282 | 5602 | { |
| 5283 | 5603 | // Input is not a string. |
| 5284 | - if(empty($str) || !is_string($str)) |
|
| 5285 | - return false; |
|
| 5604 | + if(empty($str) || !is_string($str)) { |
|
| 5605 | + return false; |
|
| 5606 | + } |
|
| 5286 | 5607 | |
| 5287 | 5608 | $stack = array(); |
| 5288 | 5609 | $expected = array(); |
@@ -5298,43 +5619,38 @@ discard block |
||
| 5298 | 5619 | while($state != 1) |
| 5299 | 5620 | { |
| 5300 | 5621 | $type = isset($str[0]) ? $str[0] : ''; |
| 5301 | - if($type == '}') |
|
| 5302 | - $str = substr($str, 1); |
|
| 5303 | - |
|
| 5304 | - else if($type == 'N' && $str[1] == ';') |
|
| 5622 | + if($type == '}') { |
|
| 5623 | + $str = substr($str, 1); |
|
| 5624 | + } else if($type == 'N' && $str[1] == ';') |
|
| 5305 | 5625 | { |
| 5306 | 5626 | $value = null; |
| 5307 | 5627 | $str = substr($str, 2); |
| 5308 | - } |
|
| 5309 | - else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5628 | + } else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches)) |
|
| 5310 | 5629 | { |
| 5311 | 5630 | $value = $matches[1] == '1' ? true : false; |
| 5312 | 5631 | $str = substr($str, 4); |
| 5313 | - } |
|
| 5314 | - else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5632 | + } else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches)) |
|
| 5315 | 5633 | { |
| 5316 | 5634 | $value = (int)$matches[1]; |
| 5317 | 5635 | $str = $matches[2]; |
| 5318 | - } |
|
| 5319 | - else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5636 | + } else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches)) |
|
| 5320 | 5637 | { |
| 5321 | 5638 | $value = (float)$matches[1]; |
| 5322 | 5639 | $str = $matches[3]; |
| 5323 | - } |
|
| 5324 | - else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
| 5640 | + } else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";') |
|
| 5325 | 5641 | { |
| 5326 | 5642 | $value = substr($matches[2], 0, (int)$matches[1]); |
| 5327 | 5643 | $str = substr($matches[2], (int)$matches[1] + 2); |
| 5328 | - } |
|
| 5329 | - else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5644 | + } else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches)) |
|
| 5330 | 5645 | { |
| 5331 | 5646 | $expectedLength = (int)$matches[1]; |
| 5332 | 5647 | $str = $matches[2]; |
| 5333 | 5648 | } |
| 5334 | 5649 | |
| 5335 | 5650 | // Object or unknown/malformed type. |
| 5336 | - else |
|
| 5337 | - return false; |
|
| 5651 | + else { |
|
| 5652 | + return false; |
|
| 5653 | + } |
|
| 5338 | 5654 | |
| 5339 | 5655 | switch($state) |
| 5340 | 5656 | { |
@@ -5362,8 +5678,9 @@ discard block |
||
| 5362 | 5678 | if($type == '}') |
| 5363 | 5679 | { |
| 5364 | 5680 | // Array size is less than expected. |
| 5365 | - if(count($list) < end($expected)) |
|
| 5366 | - return false; |
|
| 5681 | + if(count($list) < end($expected)) { |
|
| 5682 | + return false; |
|
| 5683 | + } |
|
| 5367 | 5684 | |
| 5368 | 5685 | unset($list); |
| 5369 | 5686 | $list = &$stack[count($stack)-1]; |
@@ -5372,8 +5689,9 @@ discard block |
||
| 5372 | 5689 | // Go to terminal state if we're at the end of the root array. |
| 5373 | 5690 | array_pop($expected); |
| 5374 | 5691 | |
| 5375 | - if(count($expected) == 0) |
|
| 5376 | - $state = 1; |
|
| 5692 | + if(count($expected) == 0) { |
|
| 5693 | + $state = 1; |
|
| 5694 | + } |
|
| 5377 | 5695 | |
| 5378 | 5696 | break; |
| 5379 | 5697 | } |
@@ -5381,8 +5699,9 @@ discard block |
||
| 5381 | 5699 | if($type == 'i' || $type == 's') |
| 5382 | 5700 | { |
| 5383 | 5701 | // Array size exceeds expected length. |
| 5384 | - if(count($list) >= end($expected)) |
|
| 5385 | - return false; |
|
| 5702 | + if(count($list) >= end($expected)) { |
|
| 5703 | + return false; |
|
| 5704 | + } |
|
| 5386 | 5705 | |
| 5387 | 5706 | $key = $value; |
| 5388 | 5707 | $state = 3; |
@@ -5416,8 +5735,9 @@ discard block |
||
| 5416 | 5735 | } |
| 5417 | 5736 | |
| 5418 | 5737 | // Trailing data in input. |
| 5419 | - if(!empty($str)) |
|
| 5420 | - return false; |
|
| 5738 | + if(!empty($str)) { |
|
| 5739 | + return false; |
|
| 5740 | + } |
|
| 5421 | 5741 | |
| 5422 | 5742 | return $data; |
| 5423 | 5743 | } |
@@ -5440,8 +5760,9 @@ discard block |
||
| 5440 | 5760 | |
| 5441 | 5761 | $out = _safe_unserialize($str); |
| 5442 | 5762 | |
| 5443 | - if (isset($mbIntEnc)) |
|
| 5444 | - mb_internal_encoding($mbIntEnc); |
|
| 5763 | + if (isset($mbIntEnc)) { |
|
| 5764 | + mb_internal_encoding($mbIntEnc); |
|
| 5765 | + } |
|
| 5445 | 5766 | |
| 5446 | 5767 | return $out; |
| 5447 | 5768 | } |
@@ -5456,12 +5777,14 @@ discard block |
||
| 5456 | 5777 | function smf_chmod($file, $value = 0) |
| 5457 | 5778 | { |
| 5458 | 5779 | // No file? no checks! |
| 5459 | - if (empty($file)) |
|
| 5460 | - return false; |
|
| 5780 | + if (empty($file)) { |
|
| 5781 | + return false; |
|
| 5782 | + } |
|
| 5461 | 5783 | |
| 5462 | 5784 | // Already writable? |
| 5463 | - if (is_writable($file)) |
|
| 5464 | - return true; |
|
| 5785 | + if (is_writable($file)) { |
|
| 5786 | + return true; |
|
| 5787 | + } |
|
| 5465 | 5788 | |
| 5466 | 5789 | // Do we have a file or a dir? |
| 5467 | 5790 | $isDir = is_dir($file); |
@@ -5477,10 +5800,9 @@ discard block |
||
| 5477 | 5800 | { |
| 5478 | 5801 | $isWritable = true; |
| 5479 | 5802 | break; |
| 5803 | + } else { |
|
| 5804 | + @chmod($file, $val); |
|
| 5480 | 5805 | } |
| 5481 | - |
|
| 5482 | - else |
|
| 5483 | - @chmod($file, $val); |
|
| 5484 | 5806 | } |
| 5485 | 5807 | |
| 5486 | 5808 | return $isWritable; |
@@ -5499,8 +5821,9 @@ discard block |
||
| 5499 | 5821 | global $txt; |
| 5500 | 5822 | |
| 5501 | 5823 | // Come on... |
| 5502 | - if (empty($json) || !is_string($json)) |
|
| 5503 | - return array(); |
|
| 5824 | + if (empty($json) || !is_string($json)) { |
|
| 5825 | + return array(); |
|
| 5826 | + } |
|
| 5504 | 5827 | |
| 5505 | 5828 | $returnArray = @json_decode($json, $returnAsArray); |
| 5506 | 5829 | |
@@ -5538,11 +5861,11 @@ discard block |
||
| 5538 | 5861 | $jsonDebug = $jsonDebug[0]; |
| 5539 | 5862 | loadLanguage('Errors'); |
| 5540 | 5863 | |
| 5541 | - if (!empty($jsonDebug)) |
|
| 5542 | - log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 5543 | - |
|
| 5544 | - else |
|
| 5545 | - log_error($txt['json_'. $jsonError], 'critical'); |
|
| 5864 | + if (!empty($jsonDebug)) { |
|
| 5865 | + log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']); |
|
| 5866 | + } else { |
|
| 5867 | + log_error($txt['json_'. $jsonError], 'critical'); |
|
| 5868 | + } |
|
| 5546 | 5869 | |
| 5547 | 5870 | // Everyone expects an array. |
| 5548 | 5871 | return array(); |
@@ -5572,8 +5895,9 @@ discard block |
||
| 5572 | 5895 | global $db_show_debug, $modSettings; |
| 5573 | 5896 | |
| 5574 | 5897 | // Defensive programming anyone? |
| 5575 | - if (empty($data)) |
|
| 5576 | - return false; |
|
| 5898 | + if (empty($data)) { |
|
| 5899 | + return false; |
|
| 5900 | + } |
|
| 5577 | 5901 | |
| 5578 | 5902 | // Don't need extra stuff... |
| 5579 | 5903 | $db_show_debug = false; |
@@ -5581,11 +5905,11 @@ discard block |
||
| 5581 | 5905 | // Kill anything else. |
| 5582 | 5906 | ob_end_clean(); |
| 5583 | 5907 | |
| 5584 | - if (!empty($modSettings['CompressedOutput'])) |
|
| 5585 | - @ob_start('ob_gzhandler'); |
|
| 5586 | - |
|
| 5587 | - else |
|
| 5588 | - ob_start(); |
|
| 5908 | + if (!empty($modSettings['CompressedOutput'])) { |
|
| 5909 | + @ob_start('ob_gzhandler'); |
|
| 5910 | + } else { |
|
| 5911 | + ob_start(); |
|
| 5912 | + } |
|
| 5589 | 5913 | |
| 5590 | 5914 | // Set the header. |
| 5591 | 5915 | header($type); |
@@ -5617,8 +5941,9 @@ discard block |
||
| 5617 | 5941 | static $done = false; |
| 5618 | 5942 | |
| 5619 | 5943 | // If we don't need to do anything, don't |
| 5620 | - if (!$update && $done) |
|
| 5621 | - return; |
|
| 5944 | + if (!$update && $done) { |
|
| 5945 | + return; |
|
| 5946 | + } |
|
| 5622 | 5947 | |
| 5623 | 5948 | // Should we get a new copy of the official list of TLDs? |
| 5624 | 5949 | if ($update) |
@@ -5639,10 +5964,11 @@ discard block |
||
| 5639 | 5964 | // Clean $tlds and convert it to an array |
| 5640 | 5965 | $tlds = array_filter(explode("\n", strtolower($tlds)), function($line) { |
| 5641 | 5966 | $line = trim($line); |
| 5642 | - if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) |
|
| 5643 | - return false; |
|
| 5644 | - else |
|
| 5645 | - return true; |
|
| 5967 | + if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) { |
|
| 5968 | + return false; |
|
| 5969 | + } else { |
|
| 5970 | + return true; |
|
| 5971 | + } |
|
| 5646 | 5972 | }); |
| 5647 | 5973 | |
| 5648 | 5974 | // Convert Punycode to Unicode |
@@ -5696,8 +6022,9 @@ discard block |
||
| 5696 | 6022 | $idx += $digit * $w; |
| 5697 | 6023 | $t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias)); |
| 5698 | 6024 | |
| 5699 | - if ($digit < $t) |
|
| 5700 | - break; |
|
| 6025 | + if ($digit < $t) { |
|
| 6026 | + break; |
|
| 6027 | + } |
|
| 5701 | 6028 | |
| 5702 | 6029 | $w = (int) ($w * ($base - $t)); |
| 5703 | 6030 | } |
@@ -5706,8 +6033,9 @@ discard block |
||
| 5706 | 6033 | $delta = intval($is_first ? ($delta / $damp) : ($delta / 2)); |
| 5707 | 6034 | $delta += intval($delta / ($deco_len + 1)); |
| 5708 | 6035 | |
| 5709 | - for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) |
|
| 5710 | - $delta = intval($delta / ($base - $tmin)); |
|
| 6036 | + for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) { |
|
| 6037 | + $delta = intval($delta / ($base - $tmin)); |
|
| 6038 | + } |
|
| 5711 | 6039 | |
| 5712 | 6040 | $bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew)); |
| 5713 | 6041 | $is_first = false; |
@@ -5716,8 +6044,9 @@ discard block |
||
| 5716 | 6044 | |
| 5717 | 6045 | if ($deco_len > 0) |
| 5718 | 6046 | { |
| 5719 | - for ($i = $deco_len; $i > $idx; $i--) |
|
| 5720 | - $decoded[$i] = $decoded[($i - 1)]; |
|
| 6047 | + for ($i = $deco_len; $i > $idx; $i--) { |
|
| 6048 | + $decoded[$i] = $decoded[($i - 1)]; |
|
| 6049 | + } |
|
| 5721 | 6050 | } |
| 5722 | 6051 | $decoded[$idx++] = $char; |
| 5723 | 6052 | } |
@@ -5725,24 +6054,29 @@ discard block |
||
| 5725 | 6054 | foreach ($decoded as $k => $v) |
| 5726 | 6055 | { |
| 5727 | 6056 | // 7bit are transferred literally |
| 5728 | - if ($v < 128) |
|
| 5729 | - $output .= chr($v); |
|
| 6057 | + if ($v < 128) { |
|
| 6058 | + $output .= chr($v); |
|
| 6059 | + } |
|
| 5730 | 6060 | |
| 5731 | 6061 | // 2 bytes |
| 5732 | - elseif ($v < (1 << 11)) |
|
| 5733 | - $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
| 6062 | + elseif ($v < (1 << 11)) { |
|
| 6063 | + $output .= chr(192+($v >> 6)) . chr(128+($v & 63)); |
|
| 6064 | + } |
|
| 5734 | 6065 | |
| 5735 | 6066 | // 3 bytes |
| 5736 | - elseif ($v < (1 << 16)) |
|
| 5737 | - $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
| 6067 | + elseif ($v < (1 << 16)) { |
|
| 6068 | + $output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
| 6069 | + } |
|
| 5738 | 6070 | |
| 5739 | 6071 | // 4 bytes |
| 5740 | - elseif ($v < (1 << 21)) |
|
| 5741 | - $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
| 6072 | + elseif ($v < (1 << 21)) { |
|
| 6073 | + $output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63)); |
|
| 6074 | + } |
|
| 5742 | 6075 | |
| 5743 | 6076 | // 'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k |
| 5744 | - else |
|
| 5745 | - $output .= $safe_char; |
|
| 6077 | + else { |
|
| 6078 | + $output .= $safe_char; |
|
| 6079 | + } |
|
| 5746 | 6080 | } |
| 5747 | 6081 | |
| 5748 | 6082 | $output_parts[] = $output; |
@@ -5837,8 +6171,7 @@ discard block |
||
| 5837 | 6171 | |
| 5838 | 6172 | $strlen = 'mb_strlen'; |
| 5839 | 6173 | $substr = 'mb_substr'; |
| 5840 | - } |
|
| 5841 | - else |
|
| 6174 | + } else |
|
| 5842 | 6175 | { |
| 5843 | 6176 | $strlen = $smcFunc['strlen']; |
| 5844 | 6177 | $substr = $smcFunc['substr']; |
@@ -5852,20 +6185,21 @@ discard block |
||
| 5852 | 6185 | |
| 5853 | 6186 | $first = $substr($string, 0, 1); |
| 5854 | 6187 | |
| 5855 | - if (empty($index[$first])) |
|
| 5856 | - $index[$first] = array(); |
|
| 6188 | + if (empty($index[$first])) { |
|
| 6189 | + $index[$first] = array(); |
|
| 6190 | + } |
|
| 5857 | 6191 | |
| 5858 | 6192 | if ($strlen($string) > 1) |
| 5859 | 6193 | { |
| 5860 | 6194 | // Sanity check on recursion |
| 5861 | - if ($depth > 99) |
|
| 5862 | - $index[$first][$substr($string, 1)] = ''; |
|
| 5863 | - |
|
| 5864 | - else |
|
| 5865 | - $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
| 6195 | + if ($depth > 99) { |
|
| 6196 | + $index[$first][$substr($string, 1)] = ''; |
|
| 6197 | + } else { |
|
| 6198 | + $index[$first] = $add_string_to_index($substr($string, 1), $index[$first]); |
|
| 6199 | + } |
|
| 6200 | + } else { |
|
| 6201 | + $index[$first][''] = ''; |
|
| 5866 | 6202 | } |
| 5867 | - else |
|
| 5868 | - $index[$first][''] = ''; |
|
| 5869 | 6203 | |
| 5870 | 6204 | $depth--; |
| 5871 | 6205 | return $index; |
@@ -5888,9 +6222,9 @@ discard block |
||
| 5888 | 6222 | $key_regex = preg_quote($key, $delim); |
| 5889 | 6223 | $new_key = $key; |
| 5890 | 6224 | |
| 5891 | - if (empty($value)) |
|
| 5892 | - $sub_regex = ''; |
|
| 5893 | - else |
|
| 6225 | + if (empty($value)) { |
|
| 6226 | + $sub_regex = ''; |
|
| 6227 | + } else |
|
| 5894 | 6228 | { |
| 5895 | 6229 | $sub_regex = $index_to_regex($value, $delim); |
| 5896 | 6230 | |
@@ -5898,22 +6232,22 @@ discard block |
||
| 5898 | 6232 | { |
| 5899 | 6233 | $new_key_array = explode('(?'.'>', $sub_regex); |
| 5900 | 6234 | $new_key .= $new_key_array[0]; |
| 6235 | + } else { |
|
| 6236 | + $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
| 5901 | 6237 | } |
| 5902 | - else |
|
| 5903 | - $sub_regex = '(?'.'>' . $sub_regex . ')'; |
|
| 5904 | 6238 | } |
| 5905 | 6239 | |
| 5906 | - if ($depth > 1) |
|
| 5907 | - $regex[$new_key] = $key_regex . $sub_regex; |
|
| 5908 | - else |
|
| 6240 | + if ($depth > 1) { |
|
| 6241 | + $regex[$new_key] = $key_regex . $sub_regex; |
|
| 6242 | + } else |
|
| 5909 | 6243 | { |
| 5910 | 6244 | if (($length += strlen($key_regex) + 1) < $max_length || empty($regex)) |
| 5911 | 6245 | { |
| 5912 | 6246 | $regex[$new_key] = $key_regex . $sub_regex; |
| 5913 | 6247 | unset($index[$key]); |
| 6248 | + } else { |
|
| 6249 | + break; |
|
| 5914 | 6250 | } |
| 5915 | - else |
|
| 5916 | - break; |
|
| 5917 | 6251 | } |
| 5918 | 6252 | } |
| 5919 | 6253 | |
@@ -5922,10 +6256,11 @@ discard block |
||
| 5922 | 6256 | $l1 = $strlen($k1); |
| 5923 | 6257 | $l2 = $strlen($k2); |
| 5924 | 6258 | |
| 5925 | - if ($l1 == $l2) |
|
| 5926 | - return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
| 5927 | - else |
|
| 5928 | - return $l1 > $l2 ? -1 : 1; |
|
| 6259 | + if ($l1 == $l2) { |
|
| 6260 | + return strcmp($k1, $k2) > 0 ? 1 : -1; |
|
| 6261 | + } else { |
|
| 6262 | + return $l1 > $l2 ? -1 : 1; |
|
| 6263 | + } |
|
| 5929 | 6264 | }); |
| 5930 | 6265 | |
| 5931 | 6266 | $depth--; |
@@ -5936,15 +6271,18 @@ discard block |
||
| 5936 | 6271 | $index = array(); |
| 5937 | 6272 | $regexes = array(); |
| 5938 | 6273 | |
| 5939 | - foreach ($strings as $string) |
|
| 5940 | - $index = $add_string_to_index($string, $index); |
|
| 6274 | + foreach ($strings as $string) { |
|
| 6275 | + $index = $add_string_to_index($string, $index); |
|
| 6276 | + } |
|
| 5941 | 6277 | |
| 5942 | - while (!empty($index)) |
|
| 5943 | - $regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6278 | + while (!empty($index)) { |
|
| 6279 | + $regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')'; |
|
| 6280 | + } |
|
| 5944 | 6281 | |
| 5945 | 6282 | // Restore PHP's internal character encoding to whatever it was originally |
| 5946 | - if (!empty($current_encoding)) |
|
| 5947 | - mb_internal_encoding($current_encoding); |
|
| 6283 | + if (!empty($current_encoding)) { |
|
| 6284 | + mb_internal_encoding($current_encoding); |
|
| 6285 | + } |
|
| 5948 | 6286 | |
| 5949 | 6287 | return $regexes; |
| 5950 | 6288 | } |
@@ -101,9 +101,9 @@ discard block |
||
| 101 | 101 | } |
| 102 | 102 | |
| 103 | 103 | /** |
| 104 | - * Determine if the browser is Opera or not |
|
| 105 | - * @return boolean Whether or not this is Opera |
|
| 106 | - */ |
|
| 104 | + * Determine if the browser is Opera or not |
|
| 105 | + * @return boolean Whether or not this is Opera |
|
| 106 | + */ |
|
| 107 | 107 | function isOpera() |
| 108 | 108 | { |
| 109 | 109 | if (!isset($this->_browsers['is_opera'])) |
@@ -112,9 +112,9 @@ discard block |
||
| 112 | 112 | } |
| 113 | 113 | |
| 114 | 114 | /** |
| 115 | - * Determine if the browser is IE or not |
|
| 116 | - * @return boolean true Whether or not the browser is IE |
|
| 117 | - */ |
|
| 115 | + * Determine if the browser is IE or not |
|
| 116 | + * @return boolean true Whether or not the browser is IE |
|
| 117 | + */ |
|
| 118 | 118 | function isIe() |
| 119 | 119 | { |
| 120 | 120 | // I'm IE, Yes I'm the real IE; All you other IEs are just imitating. |
@@ -124,9 +124,9 @@ discard block |
||
| 124 | 124 | } |
| 125 | 125 | |
| 126 | 126 | /** |
| 127 | - * Determine if the browser is IE11 or not |
|
| 128 | - * @return boolean Whether or not the browser is IE11 |
|
| 129 | - */ |
|
| 127 | + * Determine if the browser is IE11 or not |
|
| 128 | + * @return boolean Whether or not the browser is IE11 |
|
| 129 | + */ |
|
| 130 | 130 | function isIe11() |
| 131 | 131 | { |
| 132 | 132 | // IE11 is a bit different than earlier versions |
@@ -137,9 +137,9 @@ discard block |
||
| 137 | 137 | } |
| 138 | 138 | |
| 139 | 139 | /** |
| 140 | - * Determine if the browser is Edge or not |
|
| 141 | - * @return boolean Whether or not the browser is Edge |
|
| 142 | - */ |
|
| 140 | + * Determine if the browser is Edge or not |
|
| 141 | + * @return boolean Whether or not the browser is Edge |
|
| 142 | + */ |
|
| 143 | 143 | function isEdge() |
| 144 | 144 | { |
| 145 | 145 | if (!isset($this->_browsers['is_edge'])) |
@@ -148,9 +148,9 @@ discard block |
||
| 148 | 148 | } |
| 149 | 149 | |
| 150 | 150 | /** |
| 151 | - * Determine if the browser is a Webkit based one or not |
|
| 152 | - * @return boolean Whether or not this is a Webkit-based browser |
|
| 153 | - */ |
|
| 151 | + * Determine if the browser is a Webkit based one or not |
|
| 152 | + * @return boolean Whether or not this is a Webkit-based browser |
|
| 153 | + */ |
|
| 154 | 154 | function isWebkit() |
| 155 | 155 | { |
| 156 | 156 | if (!isset($this->_browsers['is_webkit'])) |
@@ -159,9 +159,9 @@ discard block |
||
| 159 | 159 | } |
| 160 | 160 | |
| 161 | 161 | /** |
| 162 | - * Determine if the browser is Firefox or one of its variants |
|
| 163 | - * @return boolean Whether or not this is Firefox (or one of its variants) |
|
| 164 | - */ |
|
| 162 | + * Determine if the browser is Firefox or one of its variants |
|
| 163 | + * @return boolean Whether or not this is Firefox (or one of its variants) |
|
| 164 | + */ |
|
| 165 | 165 | function isFirefox() |
| 166 | 166 | { |
| 167 | 167 | if (!isset($this->_browsers['is_firefox'])) |
@@ -170,9 +170,9 @@ discard block |
||
| 170 | 170 | } |
| 171 | 171 | |
| 172 | 172 | /** |
| 173 | - * Determine if the browser is WebTv or not |
|
| 174 | - * @return boolean Whether or not this is WebTV |
|
| 175 | - */ |
|
| 173 | + * Determine if the browser is WebTv or not |
|
| 174 | + * @return boolean Whether or not this is WebTV |
|
| 175 | + */ |
|
| 176 | 176 | function isWebTv() |
| 177 | 177 | { |
| 178 | 178 | if (!isset($this->_browsers['is_web_tv'])) |
@@ -181,9 +181,9 @@ discard block |
||
| 181 | 181 | } |
| 182 | 182 | |
| 183 | 183 | /** |
| 184 | - * Determine if the browser is konqueror or not |
|
| 185 | - * @return boolean Whether or not this is Konqueror |
|
| 186 | - */ |
|
| 184 | + * Determine if the browser is konqueror or not |
|
| 185 | + * @return boolean Whether or not this is Konqueror |
|
| 186 | + */ |
|
| 187 | 187 | function isKonqueror() |
| 188 | 188 | { |
| 189 | 189 | if (!isset($this->_browsers['is_konqueror'])) |
@@ -192,9 +192,9 @@ discard block |
||
| 192 | 192 | } |
| 193 | 193 | |
| 194 | 194 | /** |
| 195 | - * Determine if the browser is Gecko or not |
|
| 196 | - * @return boolean Whether or not this is a Gecko-based browser |
|
| 197 | - */ |
|
| 195 | + * Determine if the browser is Gecko or not |
|
| 196 | + * @return boolean Whether or not this is a Gecko-based browser |
|
| 197 | + */ |
|
| 198 | 198 | function isGecko() |
| 199 | 199 | { |
| 200 | 200 | if (!isset($this->_browsers['is_gecko'])) |
@@ -203,9 +203,9 @@ discard block |
||
| 203 | 203 | } |
| 204 | 204 | |
| 205 | 205 | /** |
| 206 | - * Determine if the browser is Opera Mini or not |
|
| 207 | - * @return boolean Whether or not this is Opera Mini |
|
| 208 | - */ |
|
| 206 | + * Determine if the browser is Opera Mini or not |
|
| 207 | + * @return boolean Whether or not this is Opera Mini |
|
| 208 | + */ |
|
| 209 | 209 | function isOperaMini() |
| 210 | 210 | { |
| 211 | 211 | if (!isset($this->_browsers['is_opera_mini'])) |
@@ -216,9 +216,9 @@ discard block |
||
| 216 | 216 | } |
| 217 | 217 | |
| 218 | 218 | /** |
| 219 | - * Determine if the browser is Opera Mobile or not |
|
| 220 | - * @return boolean Whether or not this is Opera Mobile |
|
| 221 | - */ |
|
| 219 | + * Determine if the browser is Opera Mobile or not |
|
| 220 | + * @return boolean Whether or not this is Opera Mobile |
|
| 221 | + */ |
|
| 222 | 222 | function isOperaMobi() |
| 223 | 223 | { |
| 224 | 224 | if (!isset($this->_browsers['is_opera_mobi'])) |
@@ -11,8 +11,9 @@ discard block |
||
| 11 | 11 | * @version 2.1 Beta 4 |
| 12 | 12 | */ |
| 13 | 13 | |
| 14 | -if (!defined('SMF')) |
|
| 14 | +if (!defined('SMF')) { |
|
| 15 | 15 | die('No direct access...'); |
| 16 | +} |
|
| 16 | 17 | |
| 17 | 18 | /** |
| 18 | 19 | * Class browser_detector |
@@ -55,20 +56,25 @@ discard block |
||
| 55 | 56 | $this->_browsers['needs_size_fix'] = false; |
| 56 | 57 | |
| 57 | 58 | // One at a time, one at a time, and in this order too |
| 58 | - if ($this->isOpera()) |
|
| 59 | - $this->setupOpera(); |
|
| 59 | + if ($this->isOpera()) { |
|
| 60 | + $this->setupOpera(); |
|
| 61 | + } |
|
| 60 | 62 | // Meh... |
| 61 | - elseif ($this->isEdge()) |
|
| 62 | - $this->setupEdge(); |
|
| 63 | + elseif ($this->isEdge()) { |
|
| 64 | + $this->setupEdge(); |
|
| 65 | + } |
|
| 63 | 66 | // Them webkits need to be set up too |
| 64 | - elseif ($this->isWebkit()) |
|
| 65 | - $this->setupWebkit(); |
|
| 67 | + elseif ($this->isWebkit()) { |
|
| 68 | + $this->setupWebkit(); |
|
| 69 | + } |
|
| 66 | 70 | // We may have work to do on Firefox... |
| 67 | - elseif ($this->isFirefox()) |
|
| 68 | - $this->setupFirefox(); |
|
| 71 | + elseif ($this->isFirefox()) { |
|
| 72 | + $this->setupFirefox(); |
|
| 73 | + } |
|
| 69 | 74 | // Old friend, old frenemy |
| 70 | - elseif ($this->isIe()) |
|
| 71 | - $this->setupIe(); |
|
| 75 | + elseif ($this->isIe()) { |
|
| 76 | + $this->setupIe(); |
|
| 77 | + } |
|
| 72 | 78 | |
| 73 | 79 | // Just a few mobile checks |
| 74 | 80 | $this->isOperaMini(); |
@@ -84,11 +90,12 @@ discard block |
||
| 84 | 90 | $this->_browsers['possibly_robot'] = !empty($user_info['possibly_robot']); |
| 85 | 91 | |
| 86 | 92 | // Robots shouldn't be logging in or registering. So, they aren't a bot. Better to be wrong than sorry (or people won't be able to log in!), anyway. |
| 87 | - if ((isset($_REQUEST['action']) && in_array($_REQUEST['action'], array('login', 'login2', 'register', 'signup'))) || !$user_info['is_guest']) |
|
| 88 | - $this->_browsers['possibly_robot'] = false; |
|
| 93 | + if ((isset($_REQUEST['action']) && in_array($_REQUEST['action'], array('login', 'login2', 'register', 'signup'))) || !$user_info['is_guest']) { |
|
| 94 | + $this->_browsers['possibly_robot'] = false; |
|
| 95 | + } |
|
| 96 | + } else { |
|
| 97 | + $this->_browsers['possibly_robot'] = false; |
|
| 89 | 98 | } |
| 90 | - else |
|
| 91 | - $this->_browsers['possibly_robot'] = false; |
|
| 92 | 99 | |
| 93 | 100 | // Fill out the historical array as needed to support old mods that don't use isBrowser |
| 94 | 101 | $this->fillInformation(); |
@@ -106,8 +113,9 @@ discard block |
||
| 106 | 113 | */ |
| 107 | 114 | function isOpera() |
| 108 | 115 | { |
| 109 | - if (!isset($this->_browsers['is_opera'])) |
|
| 110 | - $this->_browsers['is_opera'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Opera') !== false; |
|
| 116 | + if (!isset($this->_browsers['is_opera'])) { |
|
| 117 | + $this->_browsers['is_opera'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Opera') !== false; |
|
| 118 | + } |
|
| 111 | 119 | return $this->_browsers['is_opera']; |
| 112 | 120 | } |
| 113 | 121 | |
@@ -118,8 +126,9 @@ discard block |
||
| 118 | 126 | function isIe() |
| 119 | 127 | { |
| 120 | 128 | // I'm IE, Yes I'm the real IE; All you other IEs are just imitating. |
| 121 | - if (!isset($this->_browsers['is_ie'])) |
|
| 122 | - $this->_browsers['is_ie'] = !$this->isOpera() && !$this->isGecko() && !$this->isWebTv() && preg_match('~MSIE \d+~', $_SERVER['HTTP_USER_AGENT']) === 1; |
|
| 129 | + if (!isset($this->_browsers['is_ie'])) { |
|
| 130 | + $this->_browsers['is_ie'] = !$this->isOpera() && !$this->isGecko() && !$this->isWebTv() && preg_match('~MSIE \d+~', $_SERVER['HTTP_USER_AGENT']) === 1; |
|
| 131 | + } |
|
| 123 | 132 | return $this->_browsers['is_ie']; |
| 124 | 133 | } |
| 125 | 134 | |
@@ -131,8 +140,9 @@ discard block |
||
| 131 | 140 | { |
| 132 | 141 | // IE11 is a bit different than earlier versions |
| 133 | 142 | // The isGecko() part is to ensure we get this right... |
| 134 | - if (!isset($this->_browsers['is_ie11'])) |
|
| 135 | - $this->_browsers['is_ie11'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Trident') !== false && $this->isGecko(); |
|
| 143 | + if (!isset($this->_browsers['is_ie11'])) { |
|
| 144 | + $this->_browsers['is_ie11'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Trident') !== false && $this->isGecko(); |
|
| 145 | + } |
|
| 136 | 146 | return $this->_browsers['is_ie11']; |
| 137 | 147 | } |
| 138 | 148 | |
@@ -142,8 +152,9 @@ discard block |
||
| 142 | 152 | */ |
| 143 | 153 | function isEdge() |
| 144 | 154 | { |
| 145 | - if (!isset($this->_browsers['is_edge'])) |
|
| 146 | - $this->_browsers['is_edge'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Edge') !== false; |
|
| 155 | + if (!isset($this->_browsers['is_edge'])) { |
|
| 156 | + $this->_browsers['is_edge'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Edge') !== false; |
|
| 157 | + } |
|
| 147 | 158 | return $this->_browsers['is_edge']; |
| 148 | 159 | } |
| 149 | 160 | |
@@ -153,8 +164,9 @@ discard block |
||
| 153 | 164 | */ |
| 154 | 165 | function isWebkit() |
| 155 | 166 | { |
| 156 | - if (!isset($this->_browsers['is_webkit'])) |
|
| 157 | - $this->_browsers['is_webkit'] = strpos($_SERVER['HTTP_USER_AGENT'], 'AppleWebKit') !== false; |
|
| 167 | + if (!isset($this->_browsers['is_webkit'])) { |
|
| 168 | + $this->_browsers['is_webkit'] = strpos($_SERVER['HTTP_USER_AGENT'], 'AppleWebKit') !== false; |
|
| 169 | + } |
|
| 158 | 170 | return $this->_browsers['is_webkit']; |
| 159 | 171 | } |
| 160 | 172 | |
@@ -164,8 +176,9 @@ discard block |
||
| 164 | 176 | */ |
| 165 | 177 | function isFirefox() |
| 166 | 178 | { |
| 167 | - if (!isset($this->_browsers['is_firefox'])) |
|
| 168 | - $this->_browsers['is_firefox'] = preg_match('~(?:Firefox|Ice[wW]easel|IceCat|Shiretoko|Minefield)/~', $_SERVER['HTTP_USER_AGENT']) === 1 && $this->isGecko(); |
|
| 179 | + if (!isset($this->_browsers['is_firefox'])) { |
|
| 180 | + $this->_browsers['is_firefox'] = preg_match('~(?:Firefox|Ice[wW]easel|IceCat|Shiretoko|Minefield)/~', $_SERVER['HTTP_USER_AGENT']) === 1 && $this->isGecko(); |
|
| 181 | + } |
|
| 169 | 182 | return $this->_browsers['is_firefox']; |
| 170 | 183 | } |
| 171 | 184 | |
@@ -175,8 +188,9 @@ discard block |
||
| 175 | 188 | */ |
| 176 | 189 | function isWebTv() |
| 177 | 190 | { |
| 178 | - if (!isset($this->_browsers['is_web_tv'])) |
|
| 179 | - $this->_browsers['is_web_tv'] = strpos($_SERVER['HTTP_USER_AGENT'], 'WebTV') !== false; |
|
| 191 | + if (!isset($this->_browsers['is_web_tv'])) { |
|
| 192 | + $this->_browsers['is_web_tv'] = strpos($_SERVER['HTTP_USER_AGENT'], 'WebTV') !== false; |
|
| 193 | + } |
|
| 180 | 194 | return $this->_browsers['is_web_tv']; |
| 181 | 195 | } |
| 182 | 196 | |
@@ -186,8 +200,9 @@ discard block |
||
| 186 | 200 | */ |
| 187 | 201 | function isKonqueror() |
| 188 | 202 | { |
| 189 | - if (!isset($this->_browsers['is_konqueror'])) |
|
| 190 | - $this->_browsers['is_konqueror'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Konqueror') !== false; |
|
| 203 | + if (!isset($this->_browsers['is_konqueror'])) { |
|
| 204 | + $this->_browsers['is_konqueror'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Konqueror') !== false; |
|
| 205 | + } |
|
| 191 | 206 | return $this->_browsers['is_konqueror']; |
| 192 | 207 | } |
| 193 | 208 | |
@@ -197,8 +212,9 @@ discard block |
||
| 197 | 212 | */ |
| 198 | 213 | function isGecko() |
| 199 | 214 | { |
| 200 | - if (!isset($this->_browsers['is_gecko'])) |
|
| 201 | - $this->_browsers['is_gecko'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Gecko') !== false && !$this->isWebkit() && !$this->isKonqueror(); |
|
| 215 | + if (!isset($this->_browsers['is_gecko'])) { |
|
| 216 | + $this->_browsers['is_gecko'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Gecko') !== false && !$this->isWebkit() && !$this->isKonqueror(); |
|
| 217 | + } |
|
| 202 | 218 | return $this->_browsers['is_gecko']; |
| 203 | 219 | } |
| 204 | 220 | |
@@ -208,10 +224,12 @@ discard block |
||
| 208 | 224 | */ |
| 209 | 225 | function isOperaMini() |
| 210 | 226 | { |
| 211 | - if (!isset($this->_browsers['is_opera_mini'])) |
|
| 212 | - $this->_browsers['is_opera_mini'] = (isset($_SERVER['HTTP_X_OPERAMINI_PHONE_UA']) || stripos($_SERVER['HTTP_USER_AGENT'], 'opera mini') !== false); |
|
| 213 | - if ($this->_browsers['is_opera_mini']) |
|
| 214 | - $this->_is_mobile = true; |
|
| 227 | + if (!isset($this->_browsers['is_opera_mini'])) { |
|
| 228 | + $this->_browsers['is_opera_mini'] = (isset($_SERVER['HTTP_X_OPERAMINI_PHONE_UA']) || stripos($_SERVER['HTTP_USER_AGENT'], 'opera mini') !== false); |
|
| 229 | + } |
|
| 230 | + if ($this->_browsers['is_opera_mini']) { |
|
| 231 | + $this->_is_mobile = true; |
|
| 232 | + } |
|
| 215 | 233 | return $this->_browsers['is_opera_mini']; |
| 216 | 234 | } |
| 217 | 235 | |
@@ -221,10 +239,12 @@ discard block |
||
| 221 | 239 | */ |
| 222 | 240 | function isOperaMobi() |
| 223 | 241 | { |
| 224 | - if (!isset($this->_browsers['is_opera_mobi'])) |
|
| 225 | - $this->_browsers['is_opera_mobi'] = stripos($_SERVER['HTTP_USER_AGENT'], 'opera mobi') !== false; |
|
| 226 | - if ($this->_browsers['is_opera_mobi']) |
|
| 227 | - $this->_is_mobile = true; |
|
| 242 | + if (!isset($this->_browsers['is_opera_mobi'])) { |
|
| 243 | + $this->_browsers['is_opera_mobi'] = stripos($_SERVER['HTTP_USER_AGENT'], 'opera mobi') !== false; |
|
| 244 | + } |
|
| 245 | + if ($this->_browsers['is_opera_mobi']) { |
|
| 246 | + $this->_is_mobile = true; |
|
| 247 | + } |
|
| 228 | 248 | return $this->_browsers['is_opera_mini']; |
| 229 | 249 | } |
| 230 | 250 | |
@@ -244,8 +264,9 @@ discard block |
||
| 244 | 264 | ); |
| 245 | 265 | |
| 246 | 266 | // blackberry, playbook, iphone, nokia, android and ipods set a mobile flag |
| 247 | - if ($this->_browsers['is_iphone'] || $this->_browsers['is_blackberry'] || $this->_browsers['is_android'] || $this->_browsers['is_nokia']) |
|
| 248 | - $this->_is_mobile = true; |
|
| 267 | + if ($this->_browsers['is_iphone'] || $this->_browsers['is_blackberry'] || $this->_browsers['is_android'] || $this->_browsers['is_nokia']) { |
|
| 268 | + $this->_is_mobile = true; |
|
| 269 | + } |
|
| 249 | 270 | |
| 250 | 271 | // @todo what to do with the blaPad? ... for now leave it detected as Safari ... |
| 251 | 272 | $this->_browsers['is_safari'] = strpos($_SERVER['HTTP_USER_AGENT'], 'Safari') !== false && !$this->_browsers['is_chrome'] && !$this->_browsers['is_iphone']; |
@@ -254,15 +275,17 @@ discard block |
||
| 254 | 275 | // if Chrome, get the major version |
| 255 | 276 | if ($this->_browsers['is_chrome']) |
| 256 | 277 | { |
| 257 | - if (preg_match('~chrome[/]([0-9][0-9]?[.])~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) |
|
| 258 | - $this->_browsers['is_chrome' . (int) $match[1]] = true; |
|
| 278 | + if (preg_match('~chrome[/]([0-9][0-9]?[.])~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) { |
|
| 279 | + $this->_browsers['is_chrome' . (int) $match[1]] = true; |
|
| 280 | + } |
|
| 259 | 281 | } |
| 260 | 282 | |
| 261 | 283 | // or if Safari get its major version |
| 262 | 284 | if ($this->_browsers['is_safari']) |
| 263 | 285 | { |
| 264 | - if (preg_match('~version/?(.*)safari.*~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) |
|
| 265 | - $this->_browsers['is_safari' . (int) trim($match[1])] = true; |
|
| 286 | + if (preg_match('~version/?(.*)safari.*~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) { |
|
| 287 | + $this->_browsers['is_safari' . (int) trim($match[1])] = true; |
|
| 288 | + } |
|
| 266 | 289 | } |
| 267 | 290 | } |
| 268 | 291 | |
@@ -291,8 +314,9 @@ discard block |
||
| 291 | 314 | $this->_browsers['is_ie' . ((int) $trident_match[1] + 4)] = true; |
| 292 | 315 | |
| 293 | 316 | // If trident is set, see the (if any) msie tag in the user agent matches ... if not its in some compatibility view |
| 294 | - if (isset($msie_match[1]) && ($msie_match[1] < $trident_match[1] + 4)) |
|
| 295 | - $this->_browsers['is_ie_compat_view'] = true; |
|
| 317 | + if (isset($msie_match[1]) && ($msie_match[1] < $trident_match[1] + 4)) { |
|
| 318 | + $this->_browsers['is_ie_compat_view'] = true; |
|
| 319 | + } |
|
| 296 | 320 | } |
| 297 | 321 | |
| 298 | 322 | // Detect true IE6 and IE7 and not IE in compat mode. |
@@ -326,8 +350,9 @@ discard block |
||
| 326 | 350 | */ |
| 327 | 351 | private function setupFirefox() |
| 328 | 352 | { |
| 329 | - if (preg_match('~(?:Firefox|Ice[wW]easel|IceCat|Shiretoko|Minefield)[\/ \(]([^ ;\)]+)~', $_SERVER['HTTP_USER_AGENT'], $match) === 1) |
|
| 330 | - $this->_browsers['is_firefox' . (int) $match[1]] = true; |
|
| 353 | + if (preg_match('~(?:Firefox|Ice[wW]easel|IceCat|Shiretoko|Minefield)[\/ \(]([^ ;\)]+)~', $_SERVER['HTTP_USER_AGENT'], $match) === 1) { |
|
| 354 | + $this->_browsers['is_firefox' . (int) $match[1]] = true; |
|
| 355 | + } |
|
| 331 | 356 | } |
| 332 | 357 | |
| 333 | 358 | /** |
@@ -338,11 +363,13 @@ discard block |
||
| 338 | 363 | private function setupOpera() |
| 339 | 364 | { |
| 340 | 365 | // Opera 10+ uses the version tag at the end of the string |
| 341 | - if (preg_match('~\sVersion/([0-9]+)\.[0-9]+(?:\s*|$)~', $_SERVER['HTTP_USER_AGENT'], $match)) |
|
| 342 | - $this->_browsers['is_opera' . (int) $match[1]] = true; |
|
| 366 | + if (preg_match('~\sVersion/([0-9]+)\.[0-9]+(?:\s*|$)~', $_SERVER['HTTP_USER_AGENT'], $match)) { |
|
| 367 | + $this->_browsers['is_opera' . (int) $match[1]] = true; |
|
| 368 | + } |
|
| 343 | 369 | // Opera pre 10 is supposed to uses the Opera tag alone, as do some spoofers |
| 344 | - elseif (preg_match('~Opera[ /]([0-9]+)(?!\\.[89])~', $_SERVER['HTTP_USER_AGENT'], $match)) |
|
| 345 | - $this->_browsers['is_opera' . (int) $match[1]] = true; |
|
| 370 | + elseif (preg_match('~Opera[ /]([0-9]+)(?!\\.[89])~', $_SERVER['HTTP_USER_AGENT'], $match)) { |
|
| 371 | + $this->_browsers['is_opera' . (int) $match[1]] = true; |
|
| 372 | + } |
|
| 346 | 373 | |
| 347 | 374 | // Needs size fix? |
| 348 | 375 | $this->_browsers['needs_size_fix'] = !empty($this->_browsers['is_opera6']); |
@@ -353,8 +380,9 @@ discard block |
||
| 353 | 380 | */ |
| 354 | 381 | private function setupEdge() |
| 355 | 382 | { |
| 356 | - if (preg_match('~Edge[\/]([0-9][0-9]?[\.][0-9][0-9])~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) |
|
| 357 | - $this->_browsers['is_edge' . (int) $match[1]] = true; |
|
| 383 | + if (preg_match('~Edge[\/]([0-9][0-9]?[\.][0-9][0-9])~i', $_SERVER['HTTP_USER_AGENT'], $match) === 1) { |
|
| 384 | + $this->_browsers['is_edge' . (int) $match[1]] = true; |
|
| 385 | + } |
|
| 358 | 386 | } |
| 359 | 387 | |
| 360 | 388 | /** |
@@ -367,9 +395,9 @@ discard block |
||
| 367 | 395 | { |
| 368 | 396 | global $context; |
| 369 | 397 | |
| 370 | - if ($this->_is_mobile) |
|
| 371 | - $context['browser_body_id'] = 'mobile'; |
|
| 372 | - else |
|
| 398 | + if ($this->_is_mobile) { |
|
| 399 | + $context['browser_body_id'] = 'mobile'; |
|
| 400 | + } else |
|
| 373 | 401 | { |
| 374 | 402 | // add in any specific detection conversions here if you want a special body id e.g. 'is_opera9' => 'opera9' |
| 375 | 403 | $browser_priority = array( |
@@ -694,7 +694,6 @@ |
||
| 694 | 694 | * It shows as the maintain_forum admin area. |
| 695 | 695 | * It is accessed from ?action=admin;area=maintain;sa=database;activity=optimize. |
| 696 | 696 | * It also updates the optimize scheduled task such that the tables are not automatically optimized again too soon. |
| 697 | - |
|
| 698 | 697 | * @uses the optimize sub template |
| 699 | 698 | */ |
| 700 | 699 | function OptimizeTables() |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Main dispatcher, the maintenance access point. |
@@ -96,14 +97,16 @@ discard block |
||
| 96 | 97 | call_integration_hook('integrate_manage_maintenance', array(&$subActions)); |
| 97 | 98 | |
| 98 | 99 | // Yep, sub-action time! |
| 99 | - if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) |
|
| 100 | - $subAction = $_REQUEST['sa']; |
|
| 101 | - else |
|
| 102 | - $subAction = 'routine'; |
|
| 100 | + if (isset($_REQUEST['sa']) && isset($subActions[$_REQUEST['sa']])) { |
|
| 101 | + $subAction = $_REQUEST['sa']; |
|
| 102 | + } else { |
|
| 103 | + $subAction = 'routine'; |
|
| 104 | + } |
|
| 103 | 105 | |
| 104 | 106 | // Doing something special? |
| 105 | - if (isset($_REQUEST['activity']) && isset($subActions[$subAction]['activities'][$_REQUEST['activity']])) |
|
| 106 | - $activity = $_REQUEST['activity']; |
|
| 107 | + if (isset($_REQUEST['activity']) && isset($subActions[$subAction]['activities'][$_REQUEST['activity']])) { |
|
| 108 | + $activity = $_REQUEST['activity']; |
|
| 109 | + } |
|
| 107 | 110 | |
| 108 | 111 | // Set a few things. |
| 109 | 112 | $context['page_title'] = $txt['maintain_title']; |
@@ -114,12 +117,14 @@ discard block |
||
| 114 | 117 | call_helper($subActions[$subAction]['function']); |
| 115 | 118 | |
| 116 | 119 | // Any special activity? |
| 117 | - if (isset($activity)) |
|
| 118 | - call_helper($subActions[$subAction]['activities'][$activity]); |
|
| 120 | + if (isset($activity)) { |
|
| 121 | + call_helper($subActions[$subAction]['activities'][$activity]); |
|
| 122 | + } |
|
| 119 | 123 | |
| 120 | 124 | //converted to UTF-8? show a small maintenance info |
| 121 | - if (isset($_GET['done']) && $_GET['done'] == 'convertutf8') |
|
| 122 | - $context['maintenance_finished'] = $txt['utf8_title']; |
|
| 125 | + if (isset($_GET['done']) && $_GET['done'] == 'convertutf8') { |
|
| 126 | + $context['maintenance_finished'] = $txt['utf8_title']; |
|
| 127 | + } |
|
| 123 | 128 | |
| 124 | 129 | // Create a maintenance token. Kinda hard to do it any other way. |
| 125 | 130 | createToken('admin-maint'); |
@@ -141,19 +146,22 @@ discard block |
||
| 141 | 146 | db_extend('packages'); |
| 142 | 147 | |
| 143 | 148 | $colData = $smcFunc['db_list_columns']('{db_prefix}messages', true); |
| 144 | - foreach ($colData as $column) |
|
| 145 | - if ($column['name'] == 'body') |
|
| 149 | + foreach ($colData as $column) { |
|
| 150 | + if ($column['name'] == 'body') |
|
| 146 | 151 | $body_type = $column['type']; |
| 152 | + } |
|
| 147 | 153 | |
| 148 | 154 | $context['convert_to'] = $body_type == 'text' ? 'mediumtext' : 'text'; |
| 149 | 155 | $context['convert_to_suggest'] = ($body_type != 'text' && !empty($modSettings['max_messageLength']) && $modSettings['max_messageLength'] < 65536); |
| 150 | 156 | } |
| 151 | 157 | |
| 152 | - if (isset($_GET['done']) && $_GET['done'] == 'convertutf8') |
|
| 153 | - $context['maintenance_finished'] = $txt['utf8_title']; |
|
| 154 | - if (isset($_GET['done']) && $_GET['done'] == 'convertentities') |
|
| 155 | - $context['maintenance_finished'] = $txt['entity_convert_title']; |
|
| 156 | -} |
|
| 158 | + if (isset($_GET['done']) && $_GET['done'] == 'convertutf8') { |
|
| 159 | + $context['maintenance_finished'] = $txt['utf8_title']; |
|
| 160 | + } |
|
| 161 | + if (isset($_GET['done']) && $_GET['done'] == 'convertentities') { |
|
| 162 | + $context['maintenance_finished'] = $txt['entity_convert_title']; |
|
| 163 | + } |
|
| 164 | + } |
|
| 157 | 165 | |
| 158 | 166 | /** |
| 159 | 167 | * Supporting function for the routine maintenance area. |
@@ -162,9 +170,10 @@ discard block |
||
| 162 | 170 | { |
| 163 | 171 | global $context, $txt; |
| 164 | 172 | |
| 165 | - if (isset($_GET['done']) && $_GET['done'] == 'recount') |
|
| 166 | - $context['maintenance_finished'] = $txt['maintain_recount']; |
|
| 167 | -} |
|
| 173 | + if (isset($_GET['done']) && $_GET['done'] == 'recount') { |
|
| 174 | + $context['maintenance_finished'] = $txt['maintain_recount']; |
|
| 175 | + } |
|
| 176 | + } |
|
| 168 | 177 | |
| 169 | 178 | /** |
| 170 | 179 | * Supporting function for the members maintenance area. |
@@ -195,8 +204,9 @@ discard block |
||
| 195 | 204 | } |
| 196 | 205 | $smcFunc['db_free_result']($result); |
| 197 | 206 | |
| 198 | - if (isset($_GET['done']) && $_GET['done'] == 'recountposts') |
|
| 199 | - $context['maintenance_finished'] = $txt['maintain_recountposts']; |
|
| 207 | + if (isset($_GET['done']) && $_GET['done'] == 'recountposts') { |
|
| 208 | + $context['maintenance_finished'] = $txt['maintain_recountposts']; |
|
| 209 | + } |
|
| 200 | 210 | |
| 201 | 211 | loadJavaScriptFile('suggest.js', array('defer' => false), 'smf_suggest'); |
| 202 | 212 | } |
@@ -222,11 +232,12 @@ discard block |
||
| 222 | 232 | $context['categories'] = array(); |
| 223 | 233 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
| 224 | 234 | { |
| 225 | - if (!isset($context['categories'][$row['id_cat']])) |
|
| 226 | - $context['categories'][$row['id_cat']] = array( |
|
| 235 | + if (!isset($context['categories'][$row['id_cat']])) { |
|
| 236 | + $context['categories'][$row['id_cat']] = array( |
|
| 227 | 237 | 'name' => $row['cat_name'], |
| 228 | 238 | 'boards' => array() |
| 229 | 239 | ); |
| 240 | + } |
|
| 230 | 241 | |
| 231 | 242 | $context['categories'][$row['id_cat']]['boards'][$row['id_board']] = array( |
| 232 | 243 | 'id' => $row['id_board'], |
@@ -239,11 +250,12 @@ discard block |
||
| 239 | 250 | require_once($sourcedir . '/Subs-Boards.php'); |
| 240 | 251 | sortCategories($context['categories']); |
| 241 | 252 | |
| 242 | - if (isset($_GET['done']) && $_GET['done'] == 'purgeold') |
|
| 243 | - $context['maintenance_finished'] = $txt['maintain_old']; |
|
| 244 | - elseif (isset($_GET['done']) && $_GET['done'] == 'massmove') |
|
| 245 | - $context['maintenance_finished'] = $txt['move_topics_maintenance']; |
|
| 246 | -} |
|
| 253 | + if (isset($_GET['done']) && $_GET['done'] == 'purgeold') { |
|
| 254 | + $context['maintenance_finished'] = $txt['maintain_old']; |
|
| 255 | + } elseif (isset($_GET['done']) && $_GET['done'] == 'massmove') { |
|
| 256 | + $context['maintenance_finished'] = $txt['move_topics_maintenance']; |
|
| 257 | + } |
|
| 258 | + } |
|
| 247 | 259 | |
| 248 | 260 | /** |
| 249 | 261 | * Find and fix all errors on the forum. |
@@ -351,15 +363,17 @@ discard block |
||
| 351 | 363 | // Show me your badge! |
| 352 | 364 | isAllowedTo('admin_forum'); |
| 353 | 365 | |
| 354 | - if ($db_type != 'mysql') |
|
| 355 | - return; |
|
| 366 | + if ($db_type != 'mysql') { |
|
| 367 | + return; |
|
| 368 | + } |
|
| 356 | 369 | |
| 357 | 370 | db_extend('packages'); |
| 358 | 371 | |
| 359 | 372 | $colData = $smcFunc['db_list_columns']('{db_prefix}messages', true); |
| 360 | - foreach ($colData as $column) |
|
| 361 | - if ($column['name'] == 'body') |
|
| 373 | + foreach ($colData as $column) { |
|
| 374 | + if ($column['name'] == 'body') |
|
| 362 | 375 | $body_type = $column['type']; |
| 376 | + } |
|
| 363 | 377 | |
| 364 | 378 | $context['convert_to'] = $body_type == 'text' ? 'mediumtext' : 'text'; |
| 365 | 379 | |
@@ -369,33 +383,36 @@ discard block |
||
| 369 | 383 | validateToken('admin-maint'); |
| 370 | 384 | |
| 371 | 385 | // Make it longer so we can do their limit. |
| 372 | - if ($body_type == 'text') |
|
| 373 | - $smcFunc['db_change_column']('{db_prefix}messages', 'body', array('type' => 'mediumtext')); |
|
| 386 | + if ($body_type == 'text') { |
|
| 387 | + $smcFunc['db_change_column']('{db_prefix}messages', 'body', array('type' => 'mediumtext')); |
|
| 388 | + } |
|
| 374 | 389 | // Shorten the column so we can have a bit (literally per record) less space occupied |
| 375 | - else |
|
| 376 | - $smcFunc['db_change_column']('{db_prefix}messages', 'body', array('type' => 'text')); |
|
| 390 | + else { |
|
| 391 | + $smcFunc['db_change_column']('{db_prefix}messages', 'body', array('type' => 'text')); |
|
| 392 | + } |
|
| 377 | 393 | |
| 378 | 394 | // 3rd party integrations may be interested in knowning about this. |
| 379 | 395 | call_integration_hook('integrate_convert_msgbody', array($body_type)); |
| 380 | 396 | |
| 381 | 397 | $colData = $smcFunc['db_list_columns']('{db_prefix}messages', true); |
| 382 | - foreach ($colData as $column) |
|
| 383 | - if ($column['name'] == 'body') |
|
| 398 | + foreach ($colData as $column) { |
|
| 399 | + if ($column['name'] == 'body') |
|
| 384 | 400 | $body_type = $column['type']; |
| 401 | + } |
|
| 385 | 402 | |
| 386 | 403 | $context['maintenance_finished'] = $txt[$context['convert_to'] . '_title']; |
| 387 | 404 | $context['convert_to'] = $body_type == 'text' ? 'mediumtext' : 'text'; |
| 388 | 405 | $context['convert_to_suggest'] = ($body_type != 'text' && !empty($modSettings['max_messageLength']) && $modSettings['max_messageLength'] < 65536); |
| 389 | 406 | |
| 390 | 407 | return; |
| 391 | - } |
|
| 392 | - elseif ($body_type != 'text' && (!isset($_POST['do_conversion']) || isset($_POST['cont']))) |
|
| 408 | + } elseif ($body_type != 'text' && (!isset($_POST['do_conversion']) || isset($_POST['cont']))) |
|
| 393 | 409 | { |
| 394 | 410 | checkSession(); |
| 395 | - if (empty($_REQUEST['start'])) |
|
| 396 | - validateToken('admin-maint'); |
|
| 397 | - else |
|
| 398 | - validateToken('admin-convertMsg'); |
|
| 411 | + if (empty($_REQUEST['start'])) { |
|
| 412 | + validateToken('admin-maint'); |
|
| 413 | + } else { |
|
| 414 | + validateToken('admin-convertMsg'); |
|
| 415 | + } |
|
| 399 | 416 | |
| 400 | 417 | $context['page_title'] = $txt['not_done_title']; |
| 401 | 418 | $context['continue_post_data'] = ''; |
@@ -427,8 +444,9 @@ discard block |
||
| 427 | 444 | 'increment' => $increment - 1, |
| 428 | 445 | ) |
| 429 | 446 | ); |
| 430 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 431 | - $id_msg_exceeding[] = $row['id_msg']; |
|
| 447 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 448 | + $id_msg_exceeding[] = $row['id_msg']; |
|
| 449 | + } |
|
| 432 | 450 | $smcFunc['db_free_result']($request); |
| 433 | 451 | |
| 434 | 452 | $_REQUEST['start'] += $increment; |
@@ -457,9 +475,9 @@ discard block |
||
| 457 | 475 | { |
| 458 | 476 | $query_msg = array_slice($id_msg_exceeding, 0, 100); |
| 459 | 477 | $context['exceeding_messages_morethan'] = sprintf($txt['exceeding_messages_morethan'], count($id_msg_exceeding)); |
| 478 | + } else { |
|
| 479 | + $query_msg = $id_msg_exceeding; |
|
| 460 | 480 | } |
| 461 | - else |
|
| 462 | - $query_msg = $id_msg_exceeding; |
|
| 463 | 481 | |
| 464 | 482 | $context['exceeding_messages'] = array(); |
| 465 | 483 | $request = $smcFunc['db_query']('', ' |
@@ -470,8 +488,9 @@ discard block |
||
| 470 | 488 | 'messages' => $query_msg, |
| 471 | 489 | ) |
| 472 | 490 | ); |
| 473 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 474 | - $context['exceeding_messages'][] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
| 491 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 492 | + $context['exceeding_messages'][] = '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>'; |
|
| 493 | + } |
|
| 475 | 494 | $smcFunc['db_free_result']($request); |
| 476 | 495 | } |
| 477 | 496 | } |
@@ -495,8 +514,9 @@ discard block |
||
| 495 | 514 | isAllowedTo('admin_forum'); |
| 496 | 515 | |
| 497 | 516 | // Check to see if UTF-8 is currently the default character set. |
| 498 | - if ($modSettings['global_character_set'] !== 'UTF-8' || !isset($db_character_set) || $db_character_set !== 'utf8') |
|
| 499 | - fatal_lang_error('entity_convert_only_utf8'); |
|
| 517 | + if ($modSettings['global_character_set'] !== 'UTF-8' || !isset($db_character_set) || $db_character_set !== 'utf8') { |
|
| 518 | + fatal_lang_error('entity_convert_only_utf8'); |
|
| 519 | + } |
|
| 500 | 520 | |
| 501 | 521 | // Some starting values. |
| 502 | 522 | $context['table'] = empty($_REQUEST['table']) ? 0 : (int) $_REQUEST['table']; |
@@ -558,8 +578,9 @@ discard block |
||
| 558 | 578 | // Make sure we keep stuff unique! |
| 559 | 579 | $primary_keys = array(); |
| 560 | 580 | |
| 561 | - if (function_exists('apache_reset_timeout')) |
|
| 562 | - @apache_reset_timeout(); |
|
| 581 | + if (function_exists('apache_reset_timeout')) { |
|
| 582 | + @apache_reset_timeout(); |
|
| 583 | + } |
|
| 563 | 584 | |
| 564 | 585 | // Get a list of text columns. |
| 565 | 586 | $columns = array(); |
@@ -570,9 +591,10 @@ discard block |
||
| 570 | 591 | 'cur_table' => $cur_table, |
| 571 | 592 | ) |
| 572 | 593 | ); |
| 573 | - while ($column_info = $smcFunc['db_fetch_assoc']($request)) |
|
| 574 | - if (strpos($column_info['Type'], 'text') !== false || strpos($column_info['Type'], 'char') !== false) |
|
| 594 | + while ($column_info = $smcFunc['db_fetch_assoc']($request)) { |
|
| 595 | + if (strpos($column_info['Type'], 'text') !== false || strpos($column_info['Type'], 'char') !== false) |
|
| 575 | 596 | $columns[] = strtolower($column_info['Field']); |
| 597 | + } |
|
| 576 | 598 | |
| 577 | 599 | // Get the column with the (first) primary key. |
| 578 | 600 | $request = $smcFunc['db_query']('', ' |
@@ -586,8 +608,9 @@ discard block |
||
| 586 | 608 | { |
| 587 | 609 | if ($row['Key_name'] === 'PRIMARY') |
| 588 | 610 | { |
| 589 | - if (empty($primary_key) || ($row['Seq_in_index'] == 1 && !in_array(strtolower($row['Column_name']), $columns))) |
|
| 590 | - $primary_key = $row['Column_name']; |
|
| 611 | + if (empty($primary_key) || ($row['Seq_in_index'] == 1 && !in_array(strtolower($row['Column_name']), $columns))) { |
|
| 612 | + $primary_key = $row['Column_name']; |
|
| 613 | + } |
|
| 591 | 614 | |
| 592 | 615 | $primary_keys[] = $row['Column_name']; |
| 593 | 616 | } |
@@ -596,8 +619,9 @@ discard block |
||
| 596 | 619 | |
| 597 | 620 | // No primary key, no glory. |
| 598 | 621 | // Same for columns. Just to be sure we've work to do! |
| 599 | - if (empty($primary_key) || empty($columns)) |
|
| 600 | - continue; |
|
| 622 | + if (empty($primary_key) || empty($columns)) { |
|
| 623 | + continue; |
|
| 624 | + } |
|
| 601 | 625 | |
| 602 | 626 | // Get the maximum value for the primary key. |
| 603 | 627 | $request = $smcFunc['db_query']('', ' |
@@ -611,8 +635,9 @@ discard block |
||
| 611 | 635 | list($max_value) = $smcFunc['db_fetch_row']($request); |
| 612 | 636 | $smcFunc['db_free_result']($request); |
| 613 | 637 | |
| 614 | - if (empty($max_value)) |
|
| 615 | - continue; |
|
| 638 | + if (empty($max_value)) { |
|
| 639 | + continue; |
|
| 640 | + } |
|
| 616 | 641 | |
| 617 | 642 | while ($context['start'] <= $max_value) |
| 618 | 643 | { |
@@ -636,10 +661,11 @@ discard block |
||
| 636 | 661 | { |
| 637 | 662 | $insertion_variables = array(); |
| 638 | 663 | $changes = array(); |
| 639 | - foreach ($row as $column_name => $column_value) |
|
| 640 | - if ($column_name !== $primary_key && strpos($column_value, '&#') !== false) |
|
| 664 | + foreach ($row as $column_name => $column_value) { |
|
| 665 | + if ($column_name !== $primary_key && strpos($column_value, '&#') !== false) |
|
| 641 | 666 | { |
| 642 | 667 | $changes[] = $column_name . ' = {string:changes_' . $column_name . '}'; |
| 668 | + } |
|
| 643 | 669 | $insertion_variables['changes_' . $column_name] = preg_replace_callback('~&#(\d{1,7}|x[0-9a-fA-F]{1,6});~', 'fixchar__callback', $column_value); |
| 644 | 670 | } |
| 645 | 671 | |
@@ -651,8 +677,8 @@ discard block |
||
| 651 | 677 | } |
| 652 | 678 | |
| 653 | 679 | // Update the row. |
| 654 | - if (!empty($changes)) |
|
| 655 | - $smcFunc['db_query']('', ' |
|
| 680 | + if (!empty($changes)) { |
|
| 681 | + $smcFunc['db_query']('', ' |
|
| 656 | 682 | UPDATE {db_prefix}' . $cur_table . ' |
| 657 | 683 | SET |
| 658 | 684 | ' . implode(', |
@@ -660,6 +686,7 @@ discard block |
||
| 660 | 686 | WHERE ' . implode(' AND ', $where), |
| 661 | 687 | $insertion_variables |
| 662 | 688 | ); |
| 689 | + } |
|
| 663 | 690 | } |
| 664 | 691 | $smcFunc['db_free_result']($request); |
| 665 | 692 | $context['start'] += 500; |
@@ -704,10 +731,11 @@ discard block |
||
| 704 | 731 | |
| 705 | 732 | checkSession('request'); |
| 706 | 733 | |
| 707 | - if (!isset($_SESSION['optimized_tables'])) |
|
| 708 | - validateToken('admin-maint'); |
|
| 709 | - else |
|
| 710 | - validateToken('admin-optimize', 'post', false); |
|
| 734 | + if (!isset($_SESSION['optimized_tables'])) { |
|
| 735 | + validateToken('admin-maint'); |
|
| 736 | + } else { |
|
| 737 | + validateToken('admin-optimize', 'post', false); |
|
| 738 | + } |
|
| 711 | 739 | |
| 712 | 740 | ignore_user_abort(true); |
| 713 | 741 | db_extend(); |
@@ -723,13 +751,15 @@ discard block |
||
| 723 | 751 | // Get a list of tables, as well as how many there are. |
| 724 | 752 | $temp_tables = $smcFunc['db_list_tables'](false, $real_prefix . '%'); |
| 725 | 753 | $tables = array(); |
| 726 | - foreach ($temp_tables as $table) |
|
| 727 | - $tables[] = array('table_name' => $table); |
|
| 754 | + foreach ($temp_tables as $table) { |
|
| 755 | + $tables[] = array('table_name' => $table); |
|
| 756 | + } |
|
| 728 | 757 | |
| 729 | 758 | // If there aren't any tables then I believe that would mean the world has exploded... |
| 730 | 759 | $context['num_tables'] = count($tables); |
| 731 | - if ($context['num_tables'] == 0) |
|
| 732 | - fatal_error('You appear to be running SMF in a flat file mode... fantastic!', false); |
|
| 760 | + if ($context['num_tables'] == 0) { |
|
| 761 | + fatal_error('You appear to be running SMF in a flat file mode... fantastic!', false); |
|
| 762 | + } |
|
| 733 | 763 | |
| 734 | 764 | $_REQUEST['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start']; |
| 735 | 765 | |
@@ -740,8 +770,9 @@ discard block |
||
| 740 | 770 | $_SESSION['optimized_tables'] = !empty($_SESSION['optimized_tables']) ? $_SESSION['optimized_tables'] : array(); |
| 741 | 771 | for ($key = $_REQUEST['start']; $context['num_tables'] - 1; $key++) |
| 742 | 772 | { |
| 743 | - if (empty($tables[$key])) |
|
| 744 | - break; |
|
| 773 | + if (empty($tables[$key])) { |
|
| 774 | + break; |
|
| 775 | + } |
|
| 745 | 776 | |
| 746 | 777 | // Continue? |
| 747 | 778 | if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)) > 10) |
@@ -755,8 +786,9 @@ discard block |
||
| 755 | 786 | createToken('admin-optimize'); |
| 756 | 787 | $context['continue_post_data'] = '<input type="hidden" name="' . $context['admin-optimize_token_var'] . '" value="' . $context['admin-optimize_token'] . '">'; |
| 757 | 788 | |
| 758 | - if (function_exists('apache_reset_timeout')) |
|
| 759 | - apache_reset_timeout(); |
|
| 789 | + if (function_exists('apache_reset_timeout')) { |
|
| 790 | + apache_reset_timeout(); |
|
| 791 | + } |
|
| 760 | 792 | |
| 761 | 793 | return; |
| 762 | 794 | } |
@@ -764,11 +796,12 @@ discard block |
||
| 764 | 796 | // Optimize the table! We use backticks here because it might be a custom table. |
| 765 | 797 | $data_freed = $smcFunc['db_optimize_table']($tables[$key]['table_name']); |
| 766 | 798 | |
| 767 | - if ($data_freed > 0) |
|
| 768 | - $_SESSION['optimized_tables'][] = array( |
|
| 799 | + if ($data_freed > 0) { |
|
| 800 | + $_SESSION['optimized_tables'][] = array( |
|
| 769 | 801 | 'name' => $tables[$key]['table_name'], |
| 770 | 802 | 'data_freed' => $data_freed, |
| 771 | 803 | ); |
| 804 | + } |
|
| 772 | 805 | } |
| 773 | 806 | |
| 774 | 807 | // Number of tables, etc... |
@@ -803,10 +836,11 @@ discard block |
||
| 803 | 836 | checkSession('request'); |
| 804 | 837 | |
| 805 | 838 | // validate the request or the loop |
| 806 | - if (!isset($_REQUEST['step'])) |
|
| 807 | - validateToken('admin-maint'); |
|
| 808 | - else |
|
| 809 | - validateToken('admin-boardrecount'); |
|
| 839 | + if (!isset($_REQUEST['step'])) { |
|
| 840 | + validateToken('admin-maint'); |
|
| 841 | + } else { |
|
| 842 | + validateToken('admin-boardrecount'); |
|
| 843 | + } |
|
| 810 | 844 | |
| 811 | 845 | $context['page_title'] = $txt['not_done_title']; |
| 812 | 846 | $context['continue_post_data'] = ''; |
@@ -827,8 +861,9 @@ discard block |
||
| 827 | 861 | $smcFunc['db_free_result']($request); |
| 828 | 862 | |
| 829 | 863 | $increment = min(max(50, ceil($max_topics / 4)), 2000); |
| 830 | - if (empty($_REQUEST['start'])) |
|
| 831 | - $_REQUEST['start'] = 0; |
|
| 864 | + if (empty($_REQUEST['start'])) { |
|
| 865 | + $_REQUEST['start'] = 0; |
|
| 866 | + } |
|
| 832 | 867 | |
| 833 | 868 | $total_steps = 8; |
| 834 | 869 | |
@@ -855,8 +890,8 @@ discard block |
||
| 855 | 890 | 'max_id' => $_REQUEST['start'] + $increment, |
| 856 | 891 | ) |
| 857 | 892 | ); |
| 858 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 859 | - $smcFunc['db_query']('', ' |
|
| 893 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 894 | + $smcFunc['db_query']('', ' |
|
| 860 | 895 | UPDATE {db_prefix}topics |
| 861 | 896 | SET num_replies = {int:num_replies} |
| 862 | 897 | WHERE id_topic = {int:id_topic}', |
@@ -865,6 +900,7 @@ discard block |
||
| 865 | 900 | 'id_topic' => $row['id_topic'], |
| 866 | 901 | ) |
| 867 | 902 | ); |
| 903 | + } |
|
| 868 | 904 | $smcFunc['db_free_result']($request); |
| 869 | 905 | |
| 870 | 906 | // Recount unapproved messages |
@@ -883,8 +919,8 @@ discard block |
||
| 883 | 919 | 'max_id' => $_REQUEST['start'] + $increment, |
| 884 | 920 | ) |
| 885 | 921 | ); |
| 886 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 887 | - $smcFunc['db_query']('', ' |
|
| 922 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 923 | + $smcFunc['db_query']('', ' |
|
| 888 | 924 | UPDATE {db_prefix}topics |
| 889 | 925 | SET unapproved_posts = {int:unapproved_posts} |
| 890 | 926 | WHERE id_topic = {int:id_topic}', |
@@ -893,6 +929,7 @@ discard block |
||
| 893 | 929 | 'id_topic' => $row['id_topic'], |
| 894 | 930 | ) |
| 895 | 931 | ); |
| 932 | + } |
|
| 896 | 933 | $smcFunc['db_free_result']($request); |
| 897 | 934 | |
| 898 | 935 | $_REQUEST['start'] += $increment; |
@@ -915,8 +952,8 @@ discard block |
||
| 915 | 952 | // Update the post count of each board. |
| 916 | 953 | if ($_REQUEST['step'] <= 1) |
| 917 | 954 | { |
| 918 | - if (empty($_REQUEST['start'])) |
|
| 919 | - $smcFunc['db_query']('', ' |
|
| 955 | + if (empty($_REQUEST['start'])) { |
|
| 956 | + $smcFunc['db_query']('', ' |
|
| 920 | 957 | UPDATE {db_prefix}boards |
| 921 | 958 | SET num_posts = {int:num_posts} |
| 922 | 959 | WHERE redirect = {string:redirect}', |
@@ -925,6 +962,7 @@ discard block |
||
| 925 | 962 | 'redirect' => '', |
| 926 | 963 | ) |
| 927 | 964 | ); |
| 965 | + } |
|
| 928 | 966 | |
| 929 | 967 | while ($_REQUEST['start'] < $max_topics) |
| 930 | 968 | { |
@@ -941,8 +979,8 @@ discard block |
||
| 941 | 979 | 'is_approved' => 1, |
| 942 | 980 | ) |
| 943 | 981 | ); |
| 944 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 945 | - $smcFunc['db_query']('', ' |
|
| 982 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 983 | + $smcFunc['db_query']('', ' |
|
| 946 | 984 | UPDATE {db_prefix}boards |
| 947 | 985 | SET num_posts = num_posts + {int:real_num_posts} |
| 948 | 986 | WHERE id_board = {int:id_board}', |
@@ -951,6 +989,7 @@ discard block |
||
| 951 | 989 | 'real_num_posts' => $row['real_num_posts'], |
| 952 | 990 | ) |
| 953 | 991 | ); |
| 992 | + } |
|
| 954 | 993 | $smcFunc['db_free_result']($request); |
| 955 | 994 | |
| 956 | 995 | $_REQUEST['start'] += $increment; |
@@ -973,14 +1012,15 @@ discard block |
||
| 973 | 1012 | // Update the topic count of each board. |
| 974 | 1013 | if ($_REQUEST['step'] <= 2) |
| 975 | 1014 | { |
| 976 | - if (empty($_REQUEST['start'])) |
|
| 977 | - $smcFunc['db_query']('', ' |
|
| 1015 | + if (empty($_REQUEST['start'])) { |
|
| 1016 | + $smcFunc['db_query']('', ' |
|
| 978 | 1017 | UPDATE {db_prefix}boards |
| 979 | 1018 | SET num_topics = {int:num_topics}', |
| 980 | 1019 | array( |
| 981 | 1020 | 'num_topics' => 0, |
| 982 | 1021 | ) |
| 983 | 1022 | ); |
| 1023 | + } |
|
| 984 | 1024 | |
| 985 | 1025 | while ($_REQUEST['start'] < $max_topics) |
| 986 | 1026 | { |
@@ -997,8 +1037,8 @@ discard block |
||
| 997 | 1037 | 'id_topic_max' => $_REQUEST['start'] + $increment, |
| 998 | 1038 | ) |
| 999 | 1039 | ); |
| 1000 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1001 | - $smcFunc['db_query']('', ' |
|
| 1040 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1041 | + $smcFunc['db_query']('', ' |
|
| 1002 | 1042 | UPDATE {db_prefix}boards |
| 1003 | 1043 | SET num_topics = num_topics + {int:real_num_topics} |
| 1004 | 1044 | WHERE id_board = {int:id_board}', |
@@ -1007,6 +1047,7 @@ discard block |
||
| 1007 | 1047 | 'real_num_topics' => $row['real_num_topics'], |
| 1008 | 1048 | ) |
| 1009 | 1049 | ); |
| 1050 | + } |
|
| 1010 | 1051 | $smcFunc['db_free_result']($request); |
| 1011 | 1052 | |
| 1012 | 1053 | $_REQUEST['start'] += $increment; |
@@ -1029,14 +1070,15 @@ discard block |
||
| 1029 | 1070 | // Update the unapproved post count of each board. |
| 1030 | 1071 | if ($_REQUEST['step'] <= 3) |
| 1031 | 1072 | { |
| 1032 | - if (empty($_REQUEST['start'])) |
|
| 1033 | - $smcFunc['db_query']('', ' |
|
| 1073 | + if (empty($_REQUEST['start'])) { |
|
| 1074 | + $smcFunc['db_query']('', ' |
|
| 1034 | 1075 | UPDATE {db_prefix}boards |
| 1035 | 1076 | SET unapproved_posts = {int:unapproved_posts}', |
| 1036 | 1077 | array( |
| 1037 | 1078 | 'unapproved_posts' => 0, |
| 1038 | 1079 | ) |
| 1039 | 1080 | ); |
| 1081 | + } |
|
| 1040 | 1082 | |
| 1041 | 1083 | while ($_REQUEST['start'] < $max_topics) |
| 1042 | 1084 | { |
@@ -1053,8 +1095,8 @@ discard block |
||
| 1053 | 1095 | 'is_approved' => 0, |
| 1054 | 1096 | ) |
| 1055 | 1097 | ); |
| 1056 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1057 | - $smcFunc['db_query']('', ' |
|
| 1098 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1099 | + $smcFunc['db_query']('', ' |
|
| 1058 | 1100 | UPDATE {db_prefix}boards |
| 1059 | 1101 | SET unapproved_posts = unapproved_posts + {int:unapproved_posts} |
| 1060 | 1102 | WHERE id_board = {int:id_board}', |
@@ -1063,6 +1105,7 @@ discard block |
||
| 1063 | 1105 | 'unapproved_posts' => $row['real_unapproved_posts'], |
| 1064 | 1106 | ) |
| 1065 | 1107 | ); |
| 1108 | + } |
|
| 1066 | 1109 | $smcFunc['db_free_result']($request); |
| 1067 | 1110 | |
| 1068 | 1111 | $_REQUEST['start'] += $increment; |
@@ -1085,14 +1128,15 @@ discard block |
||
| 1085 | 1128 | // Update the unapproved topic count of each board. |
| 1086 | 1129 | if ($_REQUEST['step'] <= 4) |
| 1087 | 1130 | { |
| 1088 | - if (empty($_REQUEST['start'])) |
|
| 1089 | - $smcFunc['db_query']('', ' |
|
| 1131 | + if (empty($_REQUEST['start'])) { |
|
| 1132 | + $smcFunc['db_query']('', ' |
|
| 1090 | 1133 | UPDATE {db_prefix}boards |
| 1091 | 1134 | SET unapproved_topics = {int:unapproved_topics}', |
| 1092 | 1135 | array( |
| 1093 | 1136 | 'unapproved_topics' => 0, |
| 1094 | 1137 | ) |
| 1095 | 1138 | ); |
| 1139 | + } |
|
| 1096 | 1140 | |
| 1097 | 1141 | while ($_REQUEST['start'] < $max_topics) |
| 1098 | 1142 | { |
@@ -1109,8 +1153,8 @@ discard block |
||
| 1109 | 1153 | 'id_topic_max' => $_REQUEST['start'] + $increment, |
| 1110 | 1154 | ) |
| 1111 | 1155 | ); |
| 1112 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1113 | - $smcFunc['db_query']('', ' |
|
| 1156 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1157 | + $smcFunc['db_query']('', ' |
|
| 1114 | 1158 | UPDATE {db_prefix}boards |
| 1115 | 1159 | SET unapproved_topics = unapproved_topics + {int:real_unapproved_topics} |
| 1116 | 1160 | WHERE id_board = {int:id_board}', |
@@ -1119,6 +1163,7 @@ discard block |
||
| 1119 | 1163 | 'real_unapproved_topics' => $row['real_unapproved_topics'], |
| 1120 | 1164 | ) |
| 1121 | 1165 | ); |
| 1166 | + } |
|
| 1122 | 1167 | $smcFunc['db_free_result']($request); |
| 1123 | 1168 | |
| 1124 | 1169 | $_REQUEST['start'] += $increment; |
@@ -1152,8 +1197,9 @@ discard block |
||
| 1152 | 1197 | 'is_not_deleted' => 0, |
| 1153 | 1198 | ) |
| 1154 | 1199 | ); |
| 1155 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1156 | - updateMemberData($row['id_member'], array('instant_messages' => $row['real_num'])); |
|
| 1200 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1201 | + updateMemberData($row['id_member'], array('instant_messages' => $row['real_num'])); |
|
| 1202 | + } |
|
| 1157 | 1203 | $smcFunc['db_free_result']($request); |
| 1158 | 1204 | |
| 1159 | 1205 | $request = $smcFunc['db_query']('', ' |
@@ -1168,8 +1214,9 @@ discard block |
||
| 1168 | 1214 | 'is_not_read' => 0, |
| 1169 | 1215 | ) |
| 1170 | 1216 | ); |
| 1171 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1172 | - updateMemberData($row['id_member'], array('unread_messages' => $row['real_num'])); |
|
| 1217 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1218 | + updateMemberData($row['id_member'], array('unread_messages' => $row['real_num'])); |
|
| 1219 | + } |
|
| 1173 | 1220 | $smcFunc['db_free_result']($request); |
| 1174 | 1221 | |
| 1175 | 1222 | if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)) > 3) |
@@ -1201,12 +1248,13 @@ discard block |
||
| 1201 | 1248 | ) |
| 1202 | 1249 | ); |
| 1203 | 1250 | $boards = array(); |
| 1204 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1205 | - $boards[$row['id_board']][] = $row['id_msg']; |
|
| 1251 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1252 | + $boards[$row['id_board']][] = $row['id_msg']; |
|
| 1253 | + } |
|
| 1206 | 1254 | $smcFunc['db_free_result']($request); |
| 1207 | 1255 | |
| 1208 | - foreach ($boards as $board_id => $messages) |
|
| 1209 | - $smcFunc['db_query']('', ' |
|
| 1256 | + foreach ($boards as $board_id => $messages) { |
|
| 1257 | + $smcFunc['db_query']('', ' |
|
| 1210 | 1258 | UPDATE {db_prefix}messages |
| 1211 | 1259 | SET id_board = {int:id_board} |
| 1212 | 1260 | WHERE id_msg IN ({array_int:id_msg_array})', |
@@ -1215,6 +1263,7 @@ discard block |
||
| 1215 | 1263 | 'id_board' => $board_id, |
| 1216 | 1264 | ) |
| 1217 | 1265 | ); |
| 1266 | + } |
|
| 1218 | 1267 | |
| 1219 | 1268 | $_REQUEST['start'] += $increment; |
| 1220 | 1269 | |
@@ -1244,8 +1293,9 @@ discard block |
||
| 1244 | 1293 | ) |
| 1245 | 1294 | ); |
| 1246 | 1295 | $realBoardCounts = array(); |
| 1247 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1248 | - $realBoardCounts[$row['id_board']] = $row['local_last_msg']; |
|
| 1296 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1297 | + $realBoardCounts[$row['id_board']] = $row['local_last_msg']; |
|
| 1298 | + } |
|
| 1249 | 1299 | $smcFunc['db_free_result']($request); |
| 1250 | 1300 | |
| 1251 | 1301 | $request = $smcFunc['db_query']('', ' |
@@ -1265,18 +1315,20 @@ discard block |
||
| 1265 | 1315 | krsort($resort_me); |
| 1266 | 1316 | |
| 1267 | 1317 | $lastModifiedMsg = array(); |
| 1268 | - foreach ($resort_me as $rows) |
|
| 1269 | - foreach ($rows as $row) |
|
| 1318 | + foreach ($resort_me as $rows) { |
|
| 1319 | + foreach ($rows as $row) |
|
| 1270 | 1320 | { |
| 1271 | 1321 | // The latest message is the latest of the current board and its children. |
| 1272 | 1322 | if (isset($lastModifiedMsg[$row['id_board']])) |
| 1273 | 1323 | $curLastModifiedMsg = max($row['local_last_msg'], $lastModifiedMsg[$row['id_board']]); |
| 1274 | - else |
|
| 1275 | - $curLastModifiedMsg = $row['local_last_msg']; |
|
| 1324 | + } |
|
| 1325 | + else { |
|
| 1326 | + $curLastModifiedMsg = $row['local_last_msg']; |
|
| 1327 | + } |
|
| 1276 | 1328 | |
| 1277 | 1329 | // If what is and what should be the latest message differ, an update is necessary. |
| 1278 | - if ($row['local_last_msg'] != $row['id_last_msg'] || $curLastModifiedMsg != $row['id_msg_updated']) |
|
| 1279 | - $smcFunc['db_query']('', ' |
|
| 1330 | + if ($row['local_last_msg'] != $row['id_last_msg'] || $curLastModifiedMsg != $row['id_msg_updated']) { |
|
| 1331 | + $smcFunc['db_query']('', ' |
|
| 1280 | 1332 | UPDATE {db_prefix}boards |
| 1281 | 1333 | SET id_last_msg = {int:id_last_msg}, id_msg_updated = {int:id_msg_updated} |
| 1282 | 1334 | WHERE id_board = {int:id_board}', |
@@ -1286,12 +1338,14 @@ discard block |
||
| 1286 | 1338 | 'id_board' => $row['id_board'], |
| 1287 | 1339 | ) |
| 1288 | 1340 | ); |
| 1341 | + } |
|
| 1289 | 1342 | |
| 1290 | 1343 | // Parent boards inherit the latest modified message of their children. |
| 1291 | - if (isset($lastModifiedMsg[$row['id_parent']])) |
|
| 1292 | - $lastModifiedMsg[$row['id_parent']] = max($row['local_last_msg'], $lastModifiedMsg[$row['id_parent']]); |
|
| 1293 | - else |
|
| 1294 | - $lastModifiedMsg[$row['id_parent']] = $row['local_last_msg']; |
|
| 1344 | + if (isset($lastModifiedMsg[$row['id_parent']])) { |
|
| 1345 | + $lastModifiedMsg[$row['id_parent']] = max($row['local_last_msg'], $lastModifiedMsg[$row['id_parent']]); |
|
| 1346 | + } else { |
|
| 1347 | + $lastModifiedMsg[$row['id_parent']] = $row['local_last_msg']; |
|
| 1348 | + } |
|
| 1295 | 1349 | } |
| 1296 | 1350 | |
| 1297 | 1351 | // Update all the basic statistics. |
@@ -1363,8 +1417,9 @@ discard block |
||
| 1363 | 1417 | require_once($sourcedir . '/Subs-Auth.php'); |
| 1364 | 1418 | $members = findMembers($_POST['to']); |
| 1365 | 1419 | |
| 1366 | - if (empty($members)) |
|
| 1367 | - fatal_lang_error('reattribute_cannot_find_member'); |
|
| 1420 | + if (empty($members)) { |
|
| 1421 | + fatal_lang_error('reattribute_cannot_find_member'); |
|
| 1422 | + } |
|
| 1368 | 1423 | |
| 1369 | 1424 | $memID = array_shift($members); |
| 1370 | 1425 | $memID = $memID['id']; |
@@ -1394,8 +1449,9 @@ discard block |
||
| 1394 | 1449 | validateToken('admin-maint'); |
| 1395 | 1450 | |
| 1396 | 1451 | $groups = array(); |
| 1397 | - foreach ($_POST['groups'] as $id => $dummy) |
|
| 1398 | - $groups[] = (int) $id; |
|
| 1452 | + foreach ($_POST['groups'] as $id => $dummy) { |
|
| 1453 | + $groups[] = (int) $id; |
|
| 1454 | + } |
|
| 1399 | 1455 | $time_limit = (time() - ($_POST['maxdays'] * 24 * 3600)); |
| 1400 | 1456 | $where_vars = array( |
| 1401 | 1457 | 'time_limit' => $time_limit, |
@@ -1404,9 +1460,9 @@ discard block |
||
| 1404 | 1460 | { |
| 1405 | 1461 | $where = 'mem.date_registered < {int:time_limit} AND mem.is_activated = {int:is_activated}'; |
| 1406 | 1462 | $where_vars['is_activated'] = 0; |
| 1463 | + } else { |
|
| 1464 | + $where = 'mem.last_login < {int:time_limit} AND (mem.last_login != 0 OR mem.date_registered < {int:time_limit})'; |
|
| 1407 | 1465 | } |
| 1408 | - else |
|
| 1409 | - $where = 'mem.last_login < {int:time_limit} AND (mem.last_login != 0 OR mem.date_registered < {int:time_limit})'; |
|
| 1410 | 1466 | |
| 1411 | 1467 | // Need to get *all* groups then work out which (if any) we avoid. |
| 1412 | 1468 | $request = $smcFunc['db_query']('', ' |
@@ -1425,8 +1481,7 @@ discard block |
||
| 1425 | 1481 | { |
| 1426 | 1482 | $where .= ' AND mem.id_post_group != {int:id_post_group_' . $row['id_group'] . '}'; |
| 1427 | 1483 | $where_vars['id_post_group_' . $row['id_group']] = $row['id_group']; |
| 1428 | - } |
|
| 1429 | - else |
|
| 1484 | + } else |
|
| 1430 | 1485 | { |
| 1431 | 1486 | $where .= ' AND mem.id_group != {int:id_group_' . $row['id_group'] . '} AND FIND_IN_SET({int:id_group_' . $row['id_group'] . '}, mem.additional_groups) = 0'; |
| 1432 | 1487 | $where_vars['id_group_' . $row['id_group']] = $row['id_group']; |
@@ -1453,8 +1508,9 @@ discard block |
||
| 1453 | 1508 | $members = array(); |
| 1454 | 1509 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1455 | 1510 | { |
| 1456 | - if (!$row['is_mod'] || !in_array(3, $groups)) |
|
| 1457 | - $members[] = $row['id_member']; |
|
| 1511 | + if (!$row['is_mod'] || !in_array(3, $groups)) { |
|
| 1512 | + $members[] = $row['id_member']; |
|
| 1513 | + } |
|
| 1458 | 1514 | } |
| 1459 | 1515 | $smcFunc['db_free_result']($request); |
| 1460 | 1516 | |
@@ -1501,8 +1557,9 @@ discard block |
||
| 1501 | 1557 | ) |
| 1502 | 1558 | ); |
| 1503 | 1559 | |
| 1504 | - while ($row = $smcFunc['db_fetch_row']($request)) |
|
| 1505 | - $drafts[] = (int) $row[0]; |
|
| 1560 | + while ($row = $smcFunc['db_fetch_row']($request)) { |
|
| 1561 | + $drafts[] = (int) $row[0]; |
|
| 1562 | + } |
|
| 1506 | 1563 | $smcFunc['db_free_result']($request); |
| 1507 | 1564 | |
| 1508 | 1565 | // If we have old drafts, remove them |
@@ -1545,8 +1602,9 @@ discard block |
||
| 1545 | 1602 | $sticky = isset($_POST['move_type_sticky']) || isset($_GET['sticky']); |
| 1546 | 1603 | |
| 1547 | 1604 | // No boards then this is your stop. |
| 1548 | - if (empty($id_board_from) || empty($id_board_to)) |
|
| 1549 | - return; |
|
| 1605 | + if (empty($id_board_from) || empty($id_board_to)) { |
|
| 1606 | + return; |
|
| 1607 | + } |
|
| 1550 | 1608 | |
| 1551 | 1609 | // The big WHERE clause |
| 1552 | 1610 | $conditions = 'WHERE t.id_board = {int:id_board_from} |
@@ -1594,18 +1652,20 @@ discard block |
||
| 1594 | 1652 | ); |
| 1595 | 1653 | list ($total_topics) = $smcFunc['db_fetch_row']($request); |
| 1596 | 1654 | $smcFunc['db_free_result']($request); |
| 1655 | + } else { |
|
| 1656 | + $total_topics = (int) $_REQUEST['totaltopics']; |
|
| 1597 | 1657 | } |
| 1598 | - else |
|
| 1599 | - $total_topics = (int) $_REQUEST['totaltopics']; |
|
| 1600 | 1658 | |
| 1601 | 1659 | // Seems like we need this here. |
| 1602 | 1660 | $context['continue_get_data'] = '?action=admin;area=maintain;sa=topics;activity=massmove;id_board_from=' . $id_board_from . ';id_board_to=' . $id_board_to . ';totaltopics=' . $total_topics . ';max_days=' . $max_days; |
| 1603 | 1661 | |
| 1604 | - if ($locked) |
|
| 1605 | - $context['continue_get_data'] .= ';locked'; |
|
| 1662 | + if ($locked) { |
|
| 1663 | + $context['continue_get_data'] .= ';locked'; |
|
| 1664 | + } |
|
| 1606 | 1665 | |
| 1607 | - if ($sticky) |
|
| 1608 | - $context['continue_get_data'] .= ';sticky'; |
|
| 1666 | + if ($sticky) { |
|
| 1667 | + $context['continue_get_data'] .= ';sticky'; |
|
| 1668 | + } |
|
| 1609 | 1669 | |
| 1610 | 1670 | $context['continue_get_data'] .= ';start=' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
| 1611 | 1671 | |
@@ -1626,8 +1686,9 @@ discard block |
||
| 1626 | 1686 | |
| 1627 | 1687 | // Get the ids. |
| 1628 | 1688 | $topics = array(); |
| 1629 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1630 | - $topics[] = $row['id_topic']; |
|
| 1689 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1690 | + $topics[] = $row['id_topic']; |
|
| 1691 | + } |
|
| 1631 | 1692 | |
| 1632 | 1693 | // Just return if we don't have any topics left to move. |
| 1633 | 1694 | if (empty($topics)) |
@@ -1718,9 +1779,9 @@ discard block |
||
| 1718 | 1779 | // save it so we don't do this again for this task |
| 1719 | 1780 | list ($_SESSION['total_members']) = $smcFunc['db_fetch_row']($request); |
| 1720 | 1781 | $smcFunc['db_free_result']($request); |
| 1782 | + } else { |
|
| 1783 | + validateToken('admin-recountposts'); |
|
| 1721 | 1784 | } |
| 1722 | - else |
|
| 1723 | - validateToken('admin-recountposts'); |
|
| 1724 | 1785 | |
| 1725 | 1786 | // Lets get a group of members and determine their post count (from the boards that have post count enabled of course). |
| 1726 | 1787 | $request = $smcFunc['db_query']('', ' |
@@ -1766,8 +1827,9 @@ discard block |
||
| 1766 | 1827 | createToken('admin-recountposts'); |
| 1767 | 1828 | $context['continue_post_data'] = '<input type="hidden" name="' . $context['admin-recountposts_token_var'] . '" value="' . $context['admin-recountposts_token'] . '">'; |
| 1768 | 1829 | |
| 1769 | - if (function_exists('apache_reset_timeout')) |
|
| 1770 | - apache_reset_timeout(); |
|
| 1830 | + if (function_exists('apache_reset_timeout')) { |
|
| 1831 | + apache_reset_timeout(); |
|
| 1832 | + } |
|
| 1771 | 1833 | return; |
| 1772 | 1834 | } |
| 1773 | 1835 | |
@@ -1853,10 +1915,9 @@ discard block |
||
| 1853 | 1915 | checkSession('request'); |
| 1854 | 1916 | validateToken('admin-hook', 'request'); |
| 1855 | 1917 | |
| 1856 | - if ($_REQUEST['do'] == 'remove') |
|
| 1857 | - remove_integration_function($_REQUEST['hook'], urldecode($_REQUEST['function'])); |
|
| 1858 | - |
|
| 1859 | - else |
|
| 1918 | + if ($_REQUEST['do'] == 'remove') { |
|
| 1919 | + remove_integration_function($_REQUEST['hook'], urldecode($_REQUEST['function'])); |
|
| 1920 | + } else |
|
| 1860 | 1921 | { |
| 1861 | 1922 | $function_remove = urldecode($_REQUEST['function']) . (($_REQUEST['do'] == 'disable') ? '' : '!'); |
| 1862 | 1923 | $function_add = urldecode($_REQUEST['function']) . (($_REQUEST['do'] == 'disable') ? '!' : ''); |
@@ -1906,11 +1967,11 @@ discard block |
||
| 1906 | 1967 | // Show a nice icon to indicate this is an instance. |
| 1907 | 1968 | $instance = (!empty($data['instance']) ? '<span class="generic_icons news" title="' . $txt['hooks_field_function_method'] . '"></span> ' : ''); |
| 1908 | 1969 | |
| 1909 | - if (!empty($data['included_file'])) |
|
| 1910 | - return $instance . $txt['hooks_field_function'] . ': ' . $data['real_function'] . '<br>' . $txt['hooks_field_included_file'] . ': ' . $data['included_file']; |
|
| 1911 | - |
|
| 1912 | - else |
|
| 1913 | - return $instance . $data['real_function']; |
|
| 1970 | + if (!empty($data['included_file'])) { |
|
| 1971 | + return $instance . $txt['hooks_field_function'] . ': ' . $data['real_function'] . '<br>' . $txt['hooks_field_included_file'] . ': ' . $data['included_file']; |
|
| 1972 | + } else { |
|
| 1973 | + return $instance . $data['real_function']; |
|
| 1974 | + } |
|
| 1914 | 1975 | }, |
| 1915 | 1976 | ), |
| 1916 | 1977 | 'sort' => array( |
@@ -1975,11 +2036,12 @@ discard block |
||
| 1975 | 2036 | 'data' => array( |
| 1976 | 2037 | 'function' => function($data) use ($txt, $scripturl, $context) |
| 1977 | 2038 | { |
| 1978 | - if (!$data['hook_exists']) |
|
| 1979 | - return ' |
|
| 2039 | + if (!$data['hook_exists']) { |
|
| 2040 | + return ' |
|
| 1980 | 2041 | <a href="' . $scripturl . '?action=admin;area=maintain;sa=hooks;do=remove;hook=' . $data['hook_name'] . ';function=' . urlencode($data['function_name']) . $context['filter_url'] . ';' . $context['admin-hook_token_var'] . '=' . $context['admin-hook_token'] . ';' . $context['session_var'] . '=' . $context['session_id'] . '" data-confirm="' . $txt['quickmod_confirm'] . '" class="you_sure"> |
| 1981 | 2042 | <span class="generic_icons delete" title="' . $txt['hooks_button_remove'] . '"></span> |
| 1982 | 2043 | </a>'; |
| 2044 | + } |
|
| 1983 | 2045 | }, |
| 1984 | 2046 | 'class' => 'centertext', |
| 1985 | 2047 | ), |
@@ -2014,10 +2076,11 @@ discard block |
||
| 2014 | 2076 | { |
| 2015 | 2077 | if ($file != '.' && $file != '..') |
| 2016 | 2078 | { |
| 2017 | - if (is_dir($dir_path . '/' . $file)) |
|
| 2018 | - $files = array_merge($files, get_files_recursive($dir_path . '/' . $file)); |
|
| 2019 | - else |
|
| 2020 | - $files[] = array('dir' => $dir_path, 'name' => $file); |
|
| 2079 | + if (is_dir($dir_path . '/' . $file)) { |
|
| 2080 | + $files = array_merge($files, get_files_recursive($dir_path . '/' . $file)); |
|
| 2081 | + } else { |
|
| 2082 | + $files[] = array('dir' => $dir_path, 'name' => $file); |
|
| 2083 | + } |
|
| 2021 | 2084 | } |
| 2022 | 2085 | } |
| 2023 | 2086 | } |
@@ -2066,16 +2129,16 @@ discard block |
||
| 2066 | 2129 | // I need to know if there is at least one function called in this file. |
| 2067 | 2130 | $temp_data['include'][$hookParsedData['pureFunc']] = array('hook' => $hook, 'function' => $hookParsedData['pureFunc']); |
| 2068 | 2131 | unset($temp_hooks[$hook][$rawFunc]); |
| 2069 | - } |
|
| 2070 | - elseif (strpos(str_replace(' (', '(', $fc), 'function ' . trim($hookParsedData['pureFunc']) . '(') !== false) |
|
| 2132 | + } elseif (strpos(str_replace(' (', '(', $fc), 'function ' . trim($hookParsedData['pureFunc']) . '(') !== false) |
|
| 2071 | 2133 | { |
| 2072 | 2134 | $hook_status[$hook][$hookParsedData['pureFunc']] = $hookParsedData; |
| 2073 | 2135 | $hook_status[$hook][$hookParsedData['pureFunc']]['exists'] = true; |
| 2074 | 2136 | $hook_status[$hook][$hookParsedData['pureFunc']]['in_file'] = (!empty($file['name']) ? $file['name'] : (!empty($hookParsedData['hookFile']) ? $hookParsedData['hookFile'] : '')); |
| 2075 | 2137 | |
| 2076 | 2138 | // Does the hook has its own file? |
| 2077 | - if (!empty($hookParsedData['hookFile'])) |
|
| 2078 | - $temp_data['include'][$hookParsedData['pureFunc']] = array('hook' => $hook, 'function' => $hookParsedData['pureFunc']); |
|
| 2139 | + if (!empty($hookParsedData['hookFile'])) { |
|
| 2140 | + $temp_data['include'][$hookParsedData['pureFunc']] = array('hook' => $hook, 'function' => $hookParsedData['pureFunc']); |
|
| 2141 | + } |
|
| 2079 | 2142 | |
| 2080 | 2143 | // I want to remember all the functions called within this file (to check later if they are enabled or disabled and decide if the integrare_*_include of that file can be disabled too) |
| 2081 | 2144 | $temp_data['function'][$file['name']][$hookParsedData['pureFunc']] = $hookParsedData['enabled']; |
@@ -2102,15 +2165,17 @@ discard block |
||
| 2102 | 2165 | $sort = array(); |
| 2103 | 2166 | $hooks_filters = array(); |
| 2104 | 2167 | |
| 2105 | - foreach ($hooks as $hook => $functions) |
|
| 2106 | - $hooks_filters[] = '<option' . ($context['current_filter'] == $hook ? ' selected ' : '') . ' value="' . $hook . '">' . $hook . '</option>'; |
|
| 2168 | + foreach ($hooks as $hook => $functions) { |
|
| 2169 | + $hooks_filters[] = '<option' . ($context['current_filter'] == $hook ? ' selected ' : '') . ' value="' . $hook . '">' . $hook . '</option>'; |
|
| 2170 | + } |
|
| 2107 | 2171 | |
| 2108 | - if (!empty($hooks_filters)) |
|
| 2109 | - $context['insert_after_template'] .= ' |
|
| 2172 | + if (!empty($hooks_filters)) { |
|
| 2173 | + $context['insert_after_template'] .= ' |
|
| 2110 | 2174 | <script> |
| 2111 | 2175 | var hook_name_header = document.getElementById(\'header_list_integration_hooks_hook_name\'); |
| 2112 | 2176 | hook_name_header.innerHTML += ' . JavaScriptEscape('<select style="margin-left:15px;" onchange="window.location=(\'' . $scripturl . '?action=admin;area=maintain;sa=hooks\' + (this.value ? \';filter=\' + this.value : \'\'));"><option value="">' . $txt['hooks_reset_filter'] . '</option>' . implode('', $hooks_filters) . '</select>') . '; |
| 2113 | 2177 | </script>'; |
| 2178 | + } |
|
| 2114 | 2179 | |
| 2115 | 2180 | $temp_data = array(); |
| 2116 | 2181 | $id = 0; |
@@ -2152,10 +2217,11 @@ discard block |
||
| 2152 | 2217 | |
| 2153 | 2218 | foreach ($temp_data as $data) |
| 2154 | 2219 | { |
| 2155 | - if (++$counter < $start) |
|
| 2156 | - continue; |
|
| 2157 | - elseif ($counter == $start + $per_page) |
|
| 2158 | - break; |
|
| 2220 | + if (++$counter < $start) { |
|
| 2221 | + continue; |
|
| 2222 | + } elseif ($counter == $start + $per_page) { |
|
| 2223 | + break; |
|
| 2224 | + } |
|
| 2159 | 2225 | |
| 2160 | 2226 | $hooks_data[] = $data; |
| 2161 | 2227 | } |
@@ -2177,13 +2243,15 @@ discard block |
||
| 2177 | 2243 | $hooks_count = 0; |
| 2178 | 2244 | |
| 2179 | 2245 | $context['filter'] = false; |
| 2180 | - if (isset($_GET['filter'])) |
|
| 2181 | - $context['filter'] = $_GET['filter']; |
|
| 2246 | + if (isset($_GET['filter'])) { |
|
| 2247 | + $context['filter'] = $_GET['filter']; |
|
| 2248 | + } |
|
| 2182 | 2249 | |
| 2183 | 2250 | foreach ($hooks as $hook => $functions) |
| 2184 | 2251 | { |
| 2185 | - if (empty($context['filter']) || (!empty($context['filter']) && $context['filter'] == $hook)) |
|
| 2186 | - $hooks_count += count($functions); |
|
| 2252 | + if (empty($context['filter']) || (!empty($context['filter']) && $context['filter'] == $hook)) { |
|
| 2253 | + $hooks_count += count($functions); |
|
| 2254 | + } |
|
| 2187 | 2255 | } |
| 2188 | 2256 | |
| 2189 | 2257 | return $hooks_count; |
@@ -2204,8 +2272,9 @@ discard block |
||
| 2204 | 2272 | $integration_hooks = array(); |
| 2205 | 2273 | foreach ($modSettings as $key => $value) |
| 2206 | 2274 | { |
| 2207 | - if (!empty($value) && substr($key, 0, 10) === 'integrate_') |
|
| 2208 | - $integration_hooks[$key] = explode(',', $value); |
|
| 2275 | + if (!empty($value) && substr($key, 0, 10) === 'integrate_') { |
|
| 2276 | + $integration_hooks[$key] = explode(',', $value); |
|
| 2277 | + } |
|
| 2209 | 2278 | } |
| 2210 | 2279 | } |
| 2211 | 2280 | |
@@ -2236,8 +2305,9 @@ discard block |
||
| 2236 | 2305 | ); |
| 2237 | 2306 | |
| 2238 | 2307 | // Meh... |
| 2239 | - if (empty($rawData)) |
|
| 2240 | - return $hookData; |
|
| 2308 | + if (empty($rawData)) { |
|
| 2309 | + return $hookData; |
|
| 2310 | + } |
|
| 2241 | 2311 | |
| 2242 | 2312 | // For convenience purposes only! |
| 2243 | 2313 | $modFunc = $rawData; |
@@ -2248,11 +2318,11 @@ discard block |
||
| 2248 | 2318 | list ($hookData['hookFile'], $modFunc) = explode('|', $modFunc); |
| 2249 | 2319 | |
| 2250 | 2320 | // Does the file exists? who knows! |
| 2251 | - if (empty($settings['theme_dir'])) |
|
| 2252 | - $hookData['absPath'] = strtr(trim($hookData['hookFile']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 2253 | - |
|
| 2254 | - else |
|
| 2255 | - $hookData['absPath'] = strtr(trim($hookData['hookFile']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 2321 | + if (empty($settings['theme_dir'])) { |
|
| 2322 | + $hookData['absPath'] = strtr(trim($hookData['hookFile']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir)); |
|
| 2323 | + } else { |
|
| 2324 | + $hookData['absPath'] = strtr(trim($hookData['hookFile']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir'])); |
|
| 2325 | + } |
|
| 2256 | 2326 | |
| 2257 | 2327 | $hookData['fileExists'] = file_exists($hookData['absPath']); |
| 2258 | 2328 | $hookData['hookFile'] = basename($hookData['hookFile']); |
@@ -2277,11 +2347,10 @@ discard block |
||
| 2277 | 2347 | { |
| 2278 | 2348 | list ($hookData['class'], $hookData['method']) = explode('::', $modFunc); |
| 2279 | 2349 | $hookData['pureFunc'] = $hookData['method']; |
| 2350 | + } else { |
|
| 2351 | + $hookData['pureFunc'] = $modFunc; |
|
| 2280 | 2352 | } |
| 2281 | 2353 | |
| 2282 | - else |
|
| 2283 | - $hookData['pureFunc'] = $modFunc; |
|
| 2284 | - |
|
| 2285 | 2354 | return $hookData; |
| 2286 | 2355 | } |
| 2287 | 2356 | |
@@ -272,13 +272,13 @@ |
||
| 272 | 272 | $context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body']; |
| 273 | 273 | // Add in few replacements. |
| 274 | 274 | /** |
| 275 | - * These are the defaults: |
|
| 276 | - * - {MEMBER} - Member Name. => current user for review |
|
| 277 | - * - {MESSAGE} - Link to Offending Post. (If Applicable) => not applicable here, so not replaced |
|
| 278 | - * - {FORUMNAME} - Forum Name. |
|
| 279 | - * - {SCRIPTURL} - Web address of forum. |
|
| 280 | - * - {REGARDS} - Standard email sign-off. |
|
| 281 | - */ |
|
| 275 | + * These are the defaults: |
|
| 276 | + * - {MEMBER} - Member Name. => current user for review |
|
| 277 | + * - {MESSAGE} - Link to Offending Post. (If Applicable) => not applicable here, so not replaced |
|
| 278 | + * - {FORUMNAME} - Forum Name. |
|
| 279 | + * - {SCRIPTURL} - Web address of forum. |
|
| 280 | + * - {REGARDS} - Standard email sign-off. |
|
| 281 | + */ |
|
| 282 | 282 | $find = array( |
| 283 | 283 | '{MEMBER}', |
| 284 | 284 | '{FORUMNAME}', |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * The main handler and designator for AJAX stuff - jumpto, message icons and previews |
@@ -32,8 +33,9 @@ discard block |
||
| 32 | 33 | // Easy adding of sub actions. |
| 33 | 34 | call_integration_hook('integrate_XMLhttpMain_subActions', array(&$subActions)); |
| 34 | 35 | |
| 35 | - if (!isset($_REQUEST['sa'], $subActions[$_REQUEST['sa']])) |
|
| 36 | - fatal_lang_error('no_access', false); |
|
| 36 | + if (!isset($_REQUEST['sa'], $subActions[$_REQUEST['sa']])) { |
|
| 37 | + fatal_lang_error('no_access', false); |
|
| 38 | + } |
|
| 37 | 39 | |
| 38 | 40 | call_helper($subActions[$_REQUEST['sa']]); |
| 39 | 41 | } |
@@ -57,8 +59,9 @@ discard block |
||
| 57 | 59 | foreach ($context['jump_to'] as $id_cat => $cat) |
| 58 | 60 | { |
| 59 | 61 | $context['jump_to'][$id_cat]['name'] = un_htmlspecialchars(strip_tags($cat['name'])); |
| 60 | - foreach ($cat['boards'] as $id_board => $board) |
|
| 61 | - $context['jump_to'][$id_cat]['boards'][$id_board]['name'] = un_htmlspecialchars(strip_tags($board['name'])); |
|
| 62 | + foreach ($cat['boards'] as $id_board => $board) { |
|
| 63 | + $context['jump_to'][$id_cat]['boards'][$id_board]['name'] = un_htmlspecialchars(strip_tags($board['name'])); |
|
| 64 | + } |
|
| 62 | 65 | } |
| 63 | 66 | |
| 64 | 67 | $context['sub_template'] = 'jump_to'; |
@@ -95,8 +98,9 @@ discard block |
||
| 95 | 98 | |
| 96 | 99 | $context['sub_template'] = 'generic_xml'; |
| 97 | 100 | |
| 98 | - if (!isset($_POST['item']) || !in_array($_POST['item'], $items)) |
|
| 99 | - return false; |
|
| 101 | + if (!isset($_POST['item']) || !in_array($_POST['item'], $items)) { |
|
| 102 | + return false; |
|
| 103 | + } |
|
| 100 | 104 | |
| 101 | 105 | $_POST['item'](); |
| 102 | 106 | } |
@@ -112,10 +116,11 @@ discard block |
||
| 112 | 116 | |
| 113 | 117 | $errors = array(); |
| 114 | 118 | $news = !isset($_POST['news']) ? '' : $smcFunc['htmlspecialchars']($_POST['news'], ENT_QUOTES); |
| 115 | - if (empty($news)) |
|
| 116 | - $errors[] = array('value' => 'no_news'); |
|
| 117 | - else |
|
| 118 | - preparsecode($news); |
|
| 119 | + if (empty($news)) { |
|
| 120 | + $errors[] = array('value' => 'no_news'); |
|
| 121 | + } else { |
|
| 122 | + preparsecode($news); |
|
| 123 | + } |
|
| 119 | 124 | |
| 120 | 125 | $context['xml_data'] = array( |
| 121 | 126 | 'news' => array( |
@@ -148,10 +153,12 @@ discard block |
||
| 148 | 153 | $context['send_pm'] = !empty($_POST['send_pm']) ? 1 : 0; |
| 149 | 154 | $context['send_html'] = !empty($_POST['send_html']) ? 1 : 0; |
| 150 | 155 | |
| 151 | - if (empty($_POST['subject'])) |
|
| 152 | - $context['post_error']['messages'][] = $txt['error_no_subject']; |
|
| 153 | - if (empty($_POST['message'])) |
|
| 154 | - $context['post_error']['messages'][] = $txt['error_no_message']; |
|
| 156 | + if (empty($_POST['subject'])) { |
|
| 157 | + $context['post_error']['messages'][] = $txt['error_no_subject']; |
|
| 158 | + } |
|
| 159 | + if (empty($_POST['message'])) { |
|
| 160 | + $context['post_error']['messages'][] = $txt['error_no_message']; |
|
| 161 | + } |
|
| 155 | 162 | |
| 156 | 163 | prepareMailingForPreview(); |
| 157 | 164 | |
@@ -196,38 +203,41 @@ discard block |
||
| 196 | 203 | $preview_signature = !empty($_POST['signature']) ? $_POST['signature'] : $txt['no_signature_preview']; |
| 197 | 204 | $validation = profileValidateSignature($preview_signature); |
| 198 | 205 | |
| 199 | - if ($validation !== true && $validation !== false) |
|
| 200 | - $errors[] = array('value' => $txt['profile_error_' . $validation], 'attributes' => array('type' => 'error')); |
|
| 206 | + if ($validation !== true && $validation !== false) { |
|
| 207 | + $errors[] = array('value' => $txt['profile_error_' . $validation], 'attributes' => array('type' => 'error')); |
|
| 208 | + } |
|
| 201 | 209 | |
| 202 | 210 | censorText($preview_signature); |
| 203 | 211 | $preview_signature = parse_bbc($preview_signature, true, 'sig' . $user); |
| 204 | - } |
|
| 205 | - elseif (!$can_change) |
|
| 212 | + } elseif (!$can_change) |
|
| 206 | 213 | { |
| 207 | - if ($is_owner) |
|
| 208 | - $errors[] = array('value' => $txt['cannot_profile_extra_own'], 'attributes' => array('type' => 'error')); |
|
| 209 | - else |
|
| 210 | - $errors[] = array('value' => $txt['cannot_profile_extra_any'], 'attributes' => array('type' => 'error')); |
|
| 214 | + if ($is_owner) { |
|
| 215 | + $errors[] = array('value' => $txt['cannot_profile_extra_own'], 'attributes' => array('type' => 'error')); |
|
| 216 | + } else { |
|
| 217 | + $errors[] = array('value' => $txt['cannot_profile_extra_any'], 'attributes' => array('type' => 'error')); |
|
| 218 | + } |
|
| 219 | + } else { |
|
| 220 | + $errors[] = array('value' => $txt['no_user_selected'], 'attributes' => array('type' => 'error')); |
|
| 211 | 221 | } |
| 212 | - else |
|
| 213 | - $errors[] = array('value' => $txt['no_user_selected'], 'attributes' => array('type' => 'error')); |
|
| 214 | 222 | |
| 215 | 223 | $context['xml_data']['signatures'] = array( |
| 216 | 224 | 'identifier' => 'signature', |
| 217 | 225 | 'children' => array() |
| 218 | 226 | ); |
| 219 | - if (isset($current_signature)) |
|
| 220 | - $context['xml_data']['signatures']['children'][] = array( |
|
| 227 | + if (isset($current_signature)) { |
|
| 228 | + $context['xml_data']['signatures']['children'][] = array( |
|
| 221 | 229 | 'value' => $current_signature, |
| 222 | 230 | 'attributes' => array('type' => 'current'), |
| 223 | 231 | ); |
| 224 | - if (isset($preview_signature)) |
|
| 225 | - $context['xml_data']['signatures']['children'][] = array( |
|
| 232 | + } |
|
| 233 | + if (isset($preview_signature)) { |
|
| 234 | + $context['xml_data']['signatures']['children'][] = array( |
|
| 226 | 235 | 'value' => $preview_signature, |
| 227 | 236 | 'attributes' => array('type' => 'preview'), |
| 228 | 237 | ); |
| 229 | - if (!empty($errors)) |
|
| 230 | - $context['xml_data']['errors'] = array( |
|
| 238 | + } |
|
| 239 | + if (!empty($errors)) { |
|
| 240 | + $context['xml_data']['errors'] = array( |
|
| 231 | 241 | 'identifier' => 'error', |
| 232 | 242 | 'children' => array_merge( |
| 233 | 243 | array( |
@@ -239,7 +249,8 @@ discard block |
||
| 239 | 249 | $errors |
| 240 | 250 | ), |
| 241 | 251 | ); |
| 242 | -} |
|
| 252 | + } |
|
| 253 | + } |
|
| 243 | 254 | |
| 244 | 255 | /** |
| 245 | 256 | * Handles previewing user warnings |
@@ -259,15 +270,17 @@ discard block |
||
| 259 | 270 | $context['preview_subject'] = !empty($_POST['title']) ? trim($smcFunc['htmlspecialchars']($_POST['title'])) : ''; |
| 260 | 271 | if (isset($_POST['issuing'])) |
| 261 | 272 | { |
| 262 | - if (empty($_POST['title']) || empty($_POST['body'])) |
|
| 263 | - $context['post_error']['messages'][] = $txt['warning_notify_blank']; |
|
| 264 | - } |
|
| 265 | - else |
|
| 273 | + if (empty($_POST['title']) || empty($_POST['body'])) { |
|
| 274 | + $context['post_error']['messages'][] = $txt['warning_notify_blank']; |
|
| 275 | + } |
|
| 276 | + } else |
|
| 266 | 277 | { |
| 267 | - if (empty($_POST['title'])) |
|
| 268 | - $context['post_error']['messages'][] = $txt['mc_warning_template_error_no_title']; |
|
| 269 | - if (empty($_POST['body'])) |
|
| 270 | - $context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body']; |
|
| 278 | + if (empty($_POST['title'])) { |
|
| 279 | + $context['post_error']['messages'][] = $txt['mc_warning_template_error_no_title']; |
|
| 280 | + } |
|
| 281 | + if (empty($_POST['body'])) { |
|
| 282 | + $context['post_error']['messages'][] = $txt['mc_warning_template_error_no_body']; |
|
| 283 | + } |
|
| 271 | 284 | // Add in few replacements. |
| 272 | 285 | /** |
| 273 | 286 | * These are the defaults: |
@@ -298,9 +311,9 @@ discard block |
||
| 298 | 311 | $warning_body = parse_bbc($warning_body, true); |
| 299 | 312 | } |
| 300 | 313 | $context['preview_message'] = $warning_body; |
| 314 | + } else { |
|
| 315 | + $context['post_error']['messages'][] = array('value' => $txt['cannot_issue_warning'], 'attributes' => array('type' => 'error')); |
|
| 301 | 316 | } |
| 302 | - else |
|
| 303 | - $context['post_error']['messages'][] = array('value' => $txt['cannot_issue_warning'], 'attributes' => array('type' => 'error')); |
|
| 304 | 317 | |
| 305 | 318 | $context['sub_template'] = 'warning'; |
| 306 | 319 | } |
@@ -793,7 +793,7 @@ discard block |
||
| 793 | 793 | if (!$this->connection) |
| 794 | 794 | { |
| 795 | 795 | $this->error = 'bad_server'; |
| 796 | - $this->last_message = 'Invalid Server'; |
|
| 796 | + $this->last_message = 'Invalid Server'; |
|
| 797 | 797 | return; |
| 798 | 798 | } |
| 799 | 799 | |
@@ -801,7 +801,7 @@ discard block |
||
| 801 | 801 | if (!$this->check_response(220)) |
| 802 | 802 | { |
| 803 | 803 | $this->error = 'bad_response'; |
| 804 | - $this->last_message = 'Bad Response'; |
|
| 804 | + $this->last_message = 'Bad Response'; |
|
| 805 | 805 | return; |
| 806 | 806 | } |
| 807 | 807 | |
@@ -13,8 +13,9 @@ discard block |
||
| 13 | 13 | * @version 2.1 Beta 4 |
| 14 | 14 | */ |
| 15 | 15 | |
| 16 | -if (!defined('SMF')) |
|
| 16 | +if (!defined('SMF')) { |
|
| 17 | 17 | die('No direct access...'); |
| 18 | +} |
|
| 18 | 19 | |
| 19 | 20 | /** |
| 20 | 21 | * Class xmlArray |
@@ -65,8 +66,9 @@ discard block |
||
| 65 | 66 | } |
| 66 | 67 | |
| 67 | 68 | // Is the input an array? (ie. passed from file()?) |
| 68 | - if (is_array($data)) |
|
| 69 | - $data = implode('', $data); |
|
| 69 | + if (is_array($data)) { |
|
| 70 | + $data = implode('', $data); |
|
| 71 | + } |
|
| 70 | 72 | |
| 71 | 73 | // Remove any xml declaration or doctype, and parse out comments and CDATA. |
| 72 | 74 | $data = preg_replace('/<!--.*?-->/s', '', $this->_to_cdata(preg_replace(array('/^<\?xml.+?\?' . '>/is', '/<!DOCTYPE[^>]+?' . '>/s'), '', $data))); |
@@ -101,8 +103,9 @@ discard block |
||
| 101 | 103 | // Get the element, in array form. |
| 102 | 104 | $array = $this->path($path); |
| 103 | 105 | |
| 104 | - if ($array === false) |
|
| 105 | - return false; |
|
| 106 | + if ($array === false) { |
|
| 107 | + return false; |
|
| 108 | + } |
|
| 106 | 109 | |
| 107 | 110 | // Getting elements into this is a bit complicated... |
| 108 | 111 | if ($get_elements && !is_string($array)) |
@@ -113,8 +116,9 @@ discard block |
||
| 113 | 116 | foreach ($array->array as $val) |
| 114 | 117 | { |
| 115 | 118 | // Skip the name and any attributes. |
| 116 | - if (is_array($val)) |
|
| 117 | - $temp .= $this->_xml($val, null); |
|
| 119 | + if (is_array($val)) { |
|
| 120 | + $temp .= $this->_xml($val, null); |
|
| 121 | + } |
|
| 118 | 122 | } |
| 119 | 123 | |
| 120 | 124 | // Just get the XML data and then take out the CDATAs. |
@@ -156,32 +160,35 @@ discard block |
||
| 156 | 160 | elseif (substr($el, 0, 1) == '@') |
| 157 | 161 | { |
| 158 | 162 | // It simplifies things if the attribute is already there ;). |
| 159 | - if (isset($array[$el])) |
|
| 160 | - return $array[$el]; |
|
| 161 | - else |
|
| 163 | + if (isset($array[$el])) { |
|
| 164 | + return $array[$el]; |
|
| 165 | + } else |
|
| 162 | 166 | { |
| 163 | 167 | $trace = debug_backtrace(); |
| 164 | 168 | $i = 0; |
| 165 | - while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) |
|
| 166 | - $i++; |
|
| 169 | + while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) { |
|
| 170 | + $i++; |
|
| 171 | + } |
|
| 167 | 172 | $debug = ' (from ' . $trace[$i - 1]['file'] . ' on line ' . $trace[$i - 1]['line'] . ')'; |
| 168 | 173 | |
| 169 | 174 | // Cause an error. |
| 170 | - if ($this->debug_level & E_NOTICE) |
|
| 171 | - trigger_error('Undefined XML attribute: ' . substr($el, 1) . $debug, E_USER_NOTICE); |
|
| 175 | + if ($this->debug_level & E_NOTICE) { |
|
| 176 | + trigger_error('Undefined XML attribute: ' . substr($el, 1) . $debug, E_USER_NOTICE); |
|
| 177 | + } |
|
| 172 | 178 | return false; |
| 173 | 179 | } |
| 180 | + } else { |
|
| 181 | + $lvl = null; |
|
| 174 | 182 | } |
| 175 | - else |
|
| 176 | - $lvl = null; |
|
| 177 | 183 | |
| 178 | 184 | // Find this element. |
| 179 | 185 | $array = $this->_path($array, $el, $lvl); |
| 180 | 186 | } |
| 181 | 187 | |
| 182 | 188 | // Clean up after $lvl, for $return_full. |
| 183 | - if ($return_full && (!isset($array['name']) || substr($array['name'], -1) != ']')) |
|
| 184 | - $array = array('name' => $el . '[]', $array); |
|
| 189 | + if ($return_full && (!isset($array['name']) || substr($array['name'], -1) != ']')) { |
|
| 190 | + $array = array('name' => $el . '[]', $array); |
|
| 191 | + } |
|
| 185 | 192 | |
| 186 | 193 | // Create the right type of class... |
| 187 | 194 | $newClass = get_class($this); |
@@ -216,10 +223,11 @@ discard block |
||
| 216 | 223 | $el = substr($el, 0, strpos($el, '[')); |
| 217 | 224 | } |
| 218 | 225 | // Find an attribute. |
| 219 | - elseif (substr($el, 0, 1) == '@') |
|
| 220 | - return isset($array[$el]); |
|
| 221 | - else |
|
| 222 | - $lvl = null; |
|
| 226 | + elseif (substr($el, 0, 1) == '@') { |
|
| 227 | + return isset($array[$el]); |
|
| 228 | + } else { |
|
| 229 | + $lvl = null; |
|
| 230 | + } |
|
| 223 | 231 | |
| 224 | 232 | // Find this element. |
| 225 | 233 | $array = $this->_path($array, $el, $lvl, true); |
@@ -244,8 +252,9 @@ discard block |
||
| 244 | 252 | $i = 0; |
| 245 | 253 | foreach ($temp->array as $item) |
| 246 | 254 | { |
| 247 | - if (is_array($item)) |
|
| 248 | - $i++; |
|
| 255 | + if (is_array($item)) { |
|
| 256 | + $i++; |
|
| 257 | + } |
|
| 249 | 258 | } |
| 250 | 259 | |
| 251 | 260 | return $i; |
@@ -269,8 +278,9 @@ discard block |
||
| 269 | 278 | foreach ($xml->array as $val) |
| 270 | 279 | { |
| 271 | 280 | // Skip these, they aren't elements. |
| 272 | - if (!is_array($val) || $val['name'] == '!') |
|
| 273 | - continue; |
|
| 281 | + if (!is_array($val) || $val['name'] == '!') { |
|
| 282 | + continue; |
|
| 283 | + } |
|
| 274 | 284 | |
| 275 | 285 | // Create the right type of class... |
| 276 | 286 | $newClass = get_class($this); |
@@ -297,14 +307,16 @@ discard block |
||
| 297 | 307 | $path = $this->path($path); |
| 298 | 308 | |
| 299 | 309 | // The path was not found |
| 300 | - if ($path === false) |
|
| 301 | - return false; |
|
| 310 | + if ($path === false) { |
|
| 311 | + return false; |
|
| 312 | + } |
|
| 302 | 313 | |
| 303 | 314 | $path = $path->array; |
| 304 | 315 | } |
| 305 | 316 | // Just use the current array. |
| 306 | - else |
|
| 307 | - $path = $this->array; |
|
| 317 | + else { |
|
| 318 | + $path = $this->array; |
|
| 319 | + } |
|
| 308 | 320 | |
| 309 | 321 | // Add the xml declaration to the front. |
| 310 | 322 | return '<?xml version="1.0"?' . '>' . $this->_xml($path, 0); |
@@ -326,14 +338,16 @@ discard block |
||
| 326 | 338 | $path = $this->path($path); |
| 327 | 339 | |
| 328 | 340 | // The path was not found |
| 329 | - if ($path === false) |
|
| 330 | - return false; |
|
| 341 | + if ($path === false) { |
|
| 342 | + return false; |
|
| 343 | + } |
|
| 331 | 344 | |
| 332 | 345 | $path = $path->array; |
| 333 | 346 | } |
| 334 | 347 | // No, so just use the current array. |
| 335 | - else |
|
| 336 | - $path = $this->array; |
|
| 348 | + else { |
|
| 349 | + $path = $this->array; |
|
| 350 | + } |
|
| 337 | 351 | |
| 338 | 352 | return $this->_array($path); |
| 339 | 353 | } |
@@ -355,8 +369,9 @@ discard block |
||
| 355 | 369 | { |
| 356 | 370 | // Find and remove the next tag. |
| 357 | 371 | preg_match('/\A<([\w\-:]+)((?:\s+.+?)?)([\s]?\/)?' . '>/', $data, $match); |
| 358 | - if (isset($match[0])) |
|
| 359 | - $data = preg_replace('/' . preg_quote($match[0], '/') . '/s', '', $data, 1); |
|
| 372 | + if (isset($match[0])) { |
|
| 373 | + $data = preg_replace('/' . preg_quote($match[0], '/') . '/s', '', $data, 1); |
|
| 374 | + } |
|
| 360 | 375 | |
| 361 | 376 | // Didn't find a tag? Keep looping.... |
| 362 | 377 | if (!isset($match[1]) || $match[1] == '') |
@@ -367,11 +382,12 @@ discard block |
||
| 367 | 382 | $text_value = $this->_from_cdata($data); |
| 368 | 383 | $data = ''; |
| 369 | 384 | |
| 370 | - if ($text_value != '') |
|
| 371 | - $current[] = array( |
|
| 385 | + if ($text_value != '') { |
|
| 386 | + $current[] = array( |
|
| 372 | 387 | 'name' => '!', |
| 373 | 388 | 'value' => $text_value |
| 374 | 389 | ); |
| 390 | + } |
|
| 375 | 391 | } |
| 376 | 392 | // If the < isn't immediately next to the current position... more data. |
| 377 | 393 | elseif (strpos($data, '<') > 0) |
@@ -379,11 +395,12 @@ discard block |
||
| 379 | 395 | $text_value = $this->_from_cdata(substr($data, 0, strpos($data, '<'))); |
| 380 | 396 | $data = substr($data, strpos($data, '<')); |
| 381 | 397 | |
| 382 | - if ($text_value != '') |
|
| 383 | - $current[] = array( |
|
| 398 | + if ($text_value != '') { |
|
| 399 | + $current[] = array( |
|
| 384 | 400 | 'name' => '!', |
| 385 | 401 | 'value' => $text_value |
| 386 | 402 | ); |
| 403 | + } |
|
| 387 | 404 | } |
| 388 | 405 | // If we're looking at a </something> with no start, kill it. |
| 389 | 406 | elseif (strpos($data, '<') !== false && strpos($data, '<') == 0) |
@@ -393,22 +410,23 @@ discard block |
||
| 393 | 410 | $text_value = $this->_from_cdata(substr($data, 0, strpos($data, '<', 1))); |
| 394 | 411 | $data = substr($data, strpos($data, '<', 1)); |
| 395 | 412 | |
| 396 | - if ($text_value != '') |
|
| 397 | - $current[] = array( |
|
| 413 | + if ($text_value != '') { |
|
| 414 | + $current[] = array( |
|
| 398 | 415 | 'name' => '!', |
| 399 | 416 | 'value' => $text_value |
| 400 | 417 | ); |
| 401 | - } |
|
| 402 | - else |
|
| 418 | + } |
|
| 419 | + } else |
|
| 403 | 420 | { |
| 404 | 421 | $text_value = $this->_from_cdata($data); |
| 405 | 422 | $data = ''; |
| 406 | 423 | |
| 407 | - if ($text_value != '') |
|
| 408 | - $current[] = array( |
|
| 424 | + if ($text_value != '') { |
|
| 425 | + $current[] = array( |
|
| 409 | 426 | 'name' => '!', |
| 410 | 427 | 'value' => $text_value |
| 411 | 428 | ); |
| 429 | + } |
|
| 412 | 430 | } |
| 413 | 431 | } |
| 414 | 432 | |
@@ -425,8 +443,9 @@ discard block |
||
| 425 | 443 | { |
| 426 | 444 | // Because PHP 5.2.0+ seems to croak using regex, we'll have to do this the less fun way. |
| 427 | 445 | $last_tag_end = strpos($data, '</' . $match[1] . '>'); |
| 428 | - if ($last_tag_end === false) |
|
| 429 | - continue; |
|
| 446 | + if ($last_tag_end === false) { |
|
| 447 | + continue; |
|
| 448 | + } |
|
| 430 | 449 | |
| 431 | 450 | $offset = 0; |
| 432 | 451 | while (1 == 1) |
@@ -434,16 +453,17 @@ discard block |
||
| 434 | 453 | // Where is the next start tag? |
| 435 | 454 | $next_tag_start = strpos($data, '<' . $match[1], $offset); |
| 436 | 455 | // If the next start tag is after the last end tag then we've found the right close. |
| 437 | - if ($next_tag_start === false || $next_tag_start > $last_tag_end) |
|
| 438 | - break; |
|
| 456 | + if ($next_tag_start === false || $next_tag_start > $last_tag_end) { |
|
| 457 | + break; |
|
| 458 | + } |
|
| 439 | 459 | |
| 440 | 460 | // If not then find the next ending tag. |
| 441 | 461 | $next_tag_end = strpos($data, '</' . $match[1] . '>', $offset); |
| 442 | 462 | |
| 443 | 463 | // Didn't find one? Then just use the last and sod it. |
| 444 | - if ($next_tag_end === false) |
|
| 445 | - break; |
|
| 446 | - else |
|
| 464 | + if ($next_tag_end === false) { |
|
| 465 | + break; |
|
| 466 | + } else |
|
| 447 | 467 | { |
| 448 | 468 | $last_tag_end = $next_tag_end; |
| 449 | 469 | $offset = $next_tag_start + 1; |
@@ -457,16 +477,17 @@ discard block |
||
| 457 | 477 | if (!empty($inner_match)) |
| 458 | 478 | { |
| 459 | 479 | // Parse the inner data. |
| 460 | - if (strpos($inner_match, '<') !== false) |
|
| 461 | - $el += $this->_parse($inner_match); |
|
| 462 | - elseif (trim($inner_match) != '') |
|
| 480 | + if (strpos($inner_match, '<') !== false) { |
|
| 481 | + $el += $this->_parse($inner_match); |
|
| 482 | + } elseif (trim($inner_match) != '') |
|
| 463 | 483 | { |
| 464 | 484 | $text_value = $this->_from_cdata($inner_match); |
| 465 | - if ($text_value != '') |
|
| 466 | - $el[] = array( |
|
| 485 | + if ($text_value != '') { |
|
| 486 | + $el[] = array( |
|
| 467 | 487 | 'name' => '!', |
| 468 | 488 | 'value' => $text_value |
| 469 | 489 | ); |
| 490 | + } |
|
| 470 | 491 | } |
| 471 | 492 | } |
| 472 | 493 | } |
@@ -478,8 +499,9 @@ discard block |
||
| 478 | 499 | preg_match_all('/([\w:]+)="(.+?)"/', $match[2], $attr, PREG_SET_ORDER); |
| 479 | 500 | |
| 480 | 501 | // Set them as @attribute-name. |
| 481 | - foreach ($attr as $match_attr) |
|
| 482 | - $el['@' . $match_attr[1]] = $match_attr[2]; |
|
| 502 | + foreach ($attr as $match_attr) { |
|
| 503 | + $el['@' . $match_attr[1]] = $match_attr[2]; |
|
| 504 | + } |
|
| 483 | 505 | } |
| 484 | 506 | } |
| 485 | 507 | |
@@ -503,16 +525,18 @@ discard block |
||
| 503 | 525 | if (is_array($array) && !isset($array['name'])) |
| 504 | 526 | { |
| 505 | 527 | $temp = ''; |
| 506 | - foreach ($array as $val) |
|
| 507 | - $temp .= $this->_xml($val, $indent); |
|
| 528 | + foreach ($array as $val) { |
|
| 529 | + $temp .= $this->_xml($val, $indent); |
|
| 530 | + } |
|
| 508 | 531 | return $temp; |
| 509 | 532 | } |
| 510 | 533 | |
| 511 | 534 | // This is just text! |
| 512 | - if ($array['name'] == '!') |
|
| 513 | - return $indentation . '<![CDATA[' . $array['value'] . ']]>'; |
|
| 514 | - elseif (substr($array['name'], -2) == '[]') |
|
| 515 | - $array['name'] = substr($array['name'], 0, -2); |
|
| 535 | + if ($array['name'] == '!') { |
|
| 536 | + return $indentation . '<![CDATA[' . $array['value'] . ']]>'; |
|
| 537 | + } elseif (substr($array['name'], -2) == '[]') { |
|
| 538 | + $array['name'] = substr($array['name'], 0, -2); |
|
| 539 | + } |
|
| 516 | 540 | |
| 517 | 541 | // Start the element. |
| 518 | 542 | $output = $indentation . '<' . $array['name']; |
@@ -523,9 +547,9 @@ discard block |
||
| 523 | 547 | // Run through and recursively output all the elements or attrbutes inside this. |
| 524 | 548 | foreach ($array as $k => $v) |
| 525 | 549 | { |
| 526 | - if (substr($k, 0, 1) == '@') |
|
| 527 | - $output .= ' ' . substr($k, 1) . '="' . $v . '"'; |
|
| 528 | - elseif (is_array($v)) |
|
| 550 | + if (substr($k, 0, 1) == '@') { |
|
| 551 | + $output .= ' ' . substr($k, 1) . '="' . $v . '"'; |
|
| 552 | + } elseif (is_array($v)) |
|
| 529 | 553 | { |
| 530 | 554 | $output_el .= $this->_xml($v, $indent === null ? null : $indent + 1); |
| 531 | 555 | $inside_elements = true; |
@@ -533,10 +557,11 @@ discard block |
||
| 533 | 557 | } |
| 534 | 558 | |
| 535 | 559 | // Indent, if necessary.... then close the tag. |
| 536 | - if ($inside_elements) |
|
| 537 | - $output .= '>' . $output_el . $indentation . '</' . $array['name'] . '>'; |
|
| 538 | - else |
|
| 539 | - $output .= ' />'; |
|
| 560 | + if ($inside_elements) { |
|
| 561 | + $output .= '>' . $output_el . $indentation . '</' . $array['name'] . '>'; |
|
| 562 | + } else { |
|
| 563 | + $output .= ' />'; |
|
| 564 | + } |
|
| 540 | 565 | |
| 541 | 566 | return $output; |
| 542 | 567 | } |
@@ -553,19 +578,22 @@ discard block |
||
| 553 | 578 | $text = ''; |
| 554 | 579 | foreach ($array as $value) |
| 555 | 580 | { |
| 556 | - if (!is_array($value) || !isset($value['name'])) |
|
| 557 | - continue; |
|
| 581 | + if (!is_array($value) || !isset($value['name'])) { |
|
| 582 | + continue; |
|
| 583 | + } |
|
| 558 | 584 | |
| 559 | - if ($value['name'] == '!') |
|
| 560 | - $text .= $value['value']; |
|
| 561 | - else |
|
| 562 | - $return[$value['name']] = $this->_array($value); |
|
| 585 | + if ($value['name'] == '!') { |
|
| 586 | + $text .= $value['value']; |
|
| 587 | + } else { |
|
| 588 | + $return[$value['name']] = $this->_array($value); |
|
| 589 | + } |
|
| 563 | 590 | } |
| 564 | 591 | |
| 565 | - if (empty($return)) |
|
| 566 | - return $text; |
|
| 567 | - else |
|
| 568 | - return $return; |
|
| 592 | + if (empty($return)) { |
|
| 593 | + return $text; |
|
| 594 | + } else { |
|
| 595 | + return $return; |
|
| 596 | + } |
|
| 569 | 597 | } |
| 570 | 598 | |
| 571 | 599 | /** |
@@ -583,24 +611,28 @@ discard block |
||
| 583 | 611 | foreach ($parts as $part) |
| 584 | 612 | { |
| 585 | 613 | // Handle XML comments. |
| 586 | - if (!$inCdata && $part === '<!--') |
|
| 587 | - $inComment = true; |
|
| 588 | - if ($inComment && $part === '-->') |
|
| 589 | - $inComment = false; |
|
| 590 | - elseif ($inComment) |
|
| 591 | - continue; |
|
| 614 | + if (!$inCdata && $part === '<!--') { |
|
| 615 | + $inComment = true; |
|
| 616 | + } |
|
| 617 | + if ($inComment && $part === '-->') { |
|
| 618 | + $inComment = false; |
|
| 619 | + } elseif ($inComment) { |
|
| 620 | + continue; |
|
| 621 | + } |
|
| 592 | 622 | |
| 593 | 623 | // Handle Cdata blocks. |
| 594 | - elseif (!$inComment && $part === '<![CDATA[') |
|
| 595 | - $inCdata = true; |
|
| 596 | - elseif ($inCdata && $part === ']]>') |
|
| 597 | - $inCdata = false; |
|
| 598 | - elseif ($inCdata) |
|
| 599 | - $output .= htmlentities($part, ENT_QUOTES); |
|
| 624 | + elseif (!$inComment && $part === '<![CDATA[') { |
|
| 625 | + $inCdata = true; |
|
| 626 | + } elseif ($inCdata && $part === ']]>') { |
|
| 627 | + $inCdata = false; |
|
| 628 | + } elseif ($inCdata) { |
|
| 629 | + $output .= htmlentities($part, ENT_QUOTES); |
|
| 630 | + } |
|
| 600 | 631 | |
| 601 | 632 | // Everything else is kept as is. |
| 602 | - else |
|
| 603 | - $output .= $part; |
|
| 633 | + else { |
|
| 634 | + $output .= $part; |
|
| 635 | + } |
|
| 604 | 636 | } |
| 605 | 637 | |
| 606 | 638 | return $output; |
@@ -635,22 +667,26 @@ discard block |
||
| 635 | 667 | protected function _fetch($array) |
| 636 | 668 | { |
| 637 | 669 | // Don't return anything if this is just a string. |
| 638 | - if (is_string($array)) |
|
| 639 | - return ''; |
|
| 670 | + if (is_string($array)) { |
|
| 671 | + return ''; |
|
| 672 | + } |
|
| 640 | 673 | |
| 641 | 674 | $temp = ''; |
| 642 | 675 | foreach ($array as $text) |
| 643 | 676 | { |
| 644 | 677 | // This means it's most likely an attribute or the name itself. |
| 645 | - if (!isset($text['name'])) |
|
| 646 | - continue; |
|
| 678 | + if (!isset($text['name'])) { |
|
| 679 | + continue; |
|
| 680 | + } |
|
| 647 | 681 | |
| 648 | 682 | // This is text! |
| 649 | - if ($text['name'] == '!') |
|
| 650 | - $temp .= $text['value']; |
|
| 683 | + if ($text['name'] == '!') { |
|
| 684 | + $temp .= $text['value']; |
|
| 685 | + } |
|
| 651 | 686 | // Another element - dive in ;). |
| 652 | - else |
|
| 653 | - $temp .= $this->_fetch($text); |
|
| 687 | + else { |
|
| 688 | + $temp .= $this->_fetch($text); |
|
| 689 | + } |
|
| 654 | 690 | } |
| 655 | 691 | |
| 656 | 692 | // Return all the bits and pieces we've put together. |
@@ -669,12 +705,14 @@ discard block |
||
| 669 | 705 | protected function _path($array, $path, $level, $no_error = false) |
| 670 | 706 | { |
| 671 | 707 | // Is $array even an array? It might be false! |
| 672 | - if (!is_array($array)) |
|
| 673 | - return false; |
|
| 708 | + if (!is_array($array)) { |
|
| 709 | + return false; |
|
| 710 | + } |
|
| 674 | 711 | |
| 675 | 712 | // Asking for *no* path? |
| 676 | - if ($path == '' || $path == '.') |
|
| 677 | - return $array; |
|
| 713 | + if ($path == '' || $path == '.') { |
|
| 714 | + return $array; |
|
| 715 | + } |
|
| 678 | 716 | $paths = explode('|', $path); |
| 679 | 717 | |
| 680 | 718 | // A * means all elements of any name. |
@@ -685,16 +723,18 @@ discard block |
||
| 685 | 723 | // Check each element. |
| 686 | 724 | foreach ($array as $value) |
| 687 | 725 | { |
| 688 | - if (!is_array($value) || $value['name'] === '!') |
|
| 689 | - continue; |
|
| 726 | + if (!is_array($value) || $value['name'] === '!') { |
|
| 727 | + continue; |
|
| 728 | + } |
|
| 690 | 729 | |
| 691 | 730 | if ($show_all || in_array($value['name'], $paths)) |
| 692 | 731 | { |
| 693 | 732 | // Skip elements before "the one". |
| 694 | - if ($level !== null && $level > 0) |
|
| 695 | - $level--; |
|
| 696 | - else |
|
| 697 | - $results[] = $value; |
|
| 733 | + if ($level !== null && $level > 0) { |
|
| 734 | + $level--; |
|
| 735 | + } else { |
|
| 736 | + $results[] = $value; |
|
| 737 | + } |
|
| 698 | 738 | } |
| 699 | 739 | } |
| 700 | 740 | |
@@ -703,21 +743,25 @@ discard block |
||
| 703 | 743 | { |
| 704 | 744 | $trace = debug_backtrace(); |
| 705 | 745 | $i = 0; |
| 706 | - while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) |
|
| 707 | - $i++; |
|
| 746 | + while ($i < count($trace) && isset($trace[$i]['class']) && $trace[$i]['class'] == get_class($this)) { |
|
| 747 | + $i++; |
|
| 748 | + } |
|
| 708 | 749 | $debug = ' from ' . $trace[$i - 1]['file'] . ' on line ' . $trace[$i - 1]['line']; |
| 709 | 750 | |
| 710 | 751 | // Cause an error. |
| 711 | - if ($this->debug_level & E_NOTICE && !$no_error) |
|
| 712 | - trigger_error('Undefined XML element: ' . $path . $debug, E_USER_NOTICE); |
|
| 752 | + if ($this->debug_level & E_NOTICE && !$no_error) { |
|
| 753 | + trigger_error('Undefined XML element: ' . $path . $debug, E_USER_NOTICE); |
|
| 754 | + } |
|
| 713 | 755 | return false; |
| 714 | 756 | } |
| 715 | 757 | // Only one result. |
| 716 | - elseif (count($results) == 1 || $level !== null) |
|
| 717 | - return $results[0]; |
|
| 758 | + elseif (count($results) == 1 || $level !== null) { |
|
| 759 | + return $results[0]; |
|
| 760 | + } |
|
| 718 | 761 | // Return the result set. |
| 719 | - else |
|
| 720 | - return $results + array('name' => $path . '[]'); |
|
| 762 | + else { |
|
| 763 | + return $results + array('name' => $path . '[]'); |
|
| 764 | + } |
|
| 721 | 765 | } |
| 722 | 766 | } |
| 723 | 767 | |
@@ -764,8 +808,9 @@ discard block |
||
| 764 | 808 | $this->error = false; |
| 765 | 809 | $this->pasv = array(); |
| 766 | 810 | |
| 767 | - if ($ftp_server !== null) |
|
| 768 | - $this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass); |
|
| 811 | + if ($ftp_server !== null) { |
|
| 812 | + $this->connect($ftp_server, $ftp_port, $ftp_user, $ftp_pass); |
|
| 813 | + } |
|
| 769 | 814 | } |
| 770 | 815 | |
| 771 | 816 | /** |
@@ -778,14 +823,16 @@ discard block |
||
| 778 | 823 | */ |
| 779 | 824 | public function connect($ftp_server, $ftp_port = 21, $ftp_user = 'anonymous', $ftp_pass = '[email protected]') |
| 780 | 825 | { |
| 781 | - if (strpos($ftp_server, 'ftp://') === 0) |
|
| 782 | - $ftp_server = substr($ftp_server, 6); |
|
| 783 | - elseif (strpos($ftp_server, 'ftps://') === 0) |
|
| 784 | - $ftp_server = 'ssl://' . substr($ftp_server, 7); |
|
| 785 | - if (strpos($ftp_server, 'http://') === 0) |
|
| 786 | - $ftp_server = substr($ftp_server, 7); |
|
| 787 | - elseif (strpos($ftp_server, 'https://') === 0) |
|
| 788 | - $ftp_server = substr($ftp_server, 8); |
|
| 826 | + if (strpos($ftp_server, 'ftp://') === 0) { |
|
| 827 | + $ftp_server = substr($ftp_server, 6); |
|
| 828 | + } elseif (strpos($ftp_server, 'ftps://') === 0) { |
|
| 829 | + $ftp_server = 'ssl://' . substr($ftp_server, 7); |
|
| 830 | + } |
|
| 831 | + if (strpos($ftp_server, 'http://') === 0) { |
|
| 832 | + $ftp_server = substr($ftp_server, 7); |
|
| 833 | + } elseif (strpos($ftp_server, 'https://') === 0) { |
|
| 834 | + $ftp_server = substr($ftp_server, 8); |
|
| 835 | + } |
|
| 789 | 836 | $ftp_server = strtr($ftp_server, array('/' => '', ':' => '', '@' => '')); |
| 790 | 837 | |
| 791 | 838 | // Connect to the FTP server. |
@@ -834,12 +881,14 @@ discard block |
||
| 834 | 881 | */ |
| 835 | 882 | public function chdir($ftp_path) |
| 836 | 883 | { |
| 837 | - if (!is_resource($this->connection)) |
|
| 838 | - return false; |
|
| 884 | + if (!is_resource($this->connection)) { |
|
| 885 | + return false; |
|
| 886 | + } |
|
| 839 | 887 | |
| 840 | 888 | // No slash on the end, please... |
| 841 | - if ($ftp_path !== '/' && substr($ftp_path, -1) === '/') |
|
| 842 | - $ftp_path = substr($ftp_path, 0, -1); |
|
| 889 | + if ($ftp_path !== '/' && substr($ftp_path, -1) === '/') { |
|
| 890 | + $ftp_path = substr($ftp_path, 0, -1); |
|
| 891 | + } |
|
| 843 | 892 | |
| 844 | 893 | fwrite($this->connection, 'CWD ' . $ftp_path . "\r\n"); |
| 845 | 894 | if (!$this->check_response(250)) |
@@ -860,11 +909,13 @@ discard block |
||
| 860 | 909 | */ |
| 861 | 910 | public function chmod($ftp_file, $chmod) |
| 862 | 911 | { |
| 863 | - if (!is_resource($this->connection)) |
|
| 864 | - return false; |
|
| 912 | + if (!is_resource($this->connection)) { |
|
| 913 | + return false; |
|
| 914 | + } |
|
| 865 | 915 | |
| 866 | - if ($ftp_file == '') |
|
| 867 | - $ftp_file = '.'; |
|
| 916 | + if ($ftp_file == '') { |
|
| 917 | + $ftp_file = '.'; |
|
| 918 | + } |
|
| 868 | 919 | |
| 869 | 920 | // Do we have a file or a dir? |
| 870 | 921 | $is_dir = is_dir($ftp_file); |
@@ -880,9 +931,7 @@ discard block |
||
| 880 | 931 | { |
| 881 | 932 | $is_writable = true; |
| 882 | 933 | break; |
| 883 | - } |
|
| 884 | - |
|
| 885 | - else |
|
| 934 | + } else |
|
| 886 | 935 | { |
| 887 | 936 | // Convert the chmod value from octal (0777) to text ("777"). |
| 888 | 937 | fwrite($this->connection, 'SITE CHMOD ' . decoct($val) . ' ' . $ftp_file . "\r\n"); |
@@ -905,8 +954,9 @@ discard block |
||
| 905 | 954 | public function unlink($ftp_file) |
| 906 | 955 | { |
| 907 | 956 | // We are actually connected, right? |
| 908 | - if (!is_resource($this->connection)) |
|
| 909 | - return false; |
|
| 957 | + if (!is_resource($this->connection)) { |
|
| 958 | + return false; |
|
| 959 | + } |
|
| 910 | 960 | |
| 911 | 961 | // Delete file X. |
| 912 | 962 | fwrite($this->connection, 'DELE ' . $ftp_file . "\r\n"); |
@@ -935,9 +985,9 @@ discard block |
||
| 935 | 985 | { |
| 936 | 986 | // Wait for a response that isn't continued with -, but don't wait too long. |
| 937 | 987 | $time = time(); |
| 938 | - do |
|
| 939 | - $this->last_message = fgets($this->connection, 1024); |
|
| 940 | - while ((strlen($this->last_message) < 4 || strpos($this->last_message, ' ') === 0 || strpos($this->last_message, ' ', 3) !== 3) && time() - $time < 5); |
|
| 988 | + do { |
|
| 989 | + $this->last_message = fgets($this->connection, 1024); |
|
| 990 | + } while ((strlen($this->last_message) < 4 || strpos($this->last_message, ' ') === 0 || strpos($this->last_message, ' ', 3) !== 3) && time() - $time < 5); |
|
| 941 | 991 | |
| 942 | 992 | // Was the desired response returned? |
| 943 | 993 | return is_array($desired) ? in_array(substr($this->last_message, 0, 3), $desired) : substr($this->last_message, 0, 3) == $desired; |
@@ -951,15 +1001,16 @@ discard block |
||
| 951 | 1001 | public function passive() |
| 952 | 1002 | { |
| 953 | 1003 | // We can't create a passive data connection without a primary one first being there. |
| 954 | - if (!is_resource($this->connection)) |
|
| 955 | - return false; |
|
| 1004 | + if (!is_resource($this->connection)) { |
|
| 1005 | + return false; |
|
| 1006 | + } |
|
| 956 | 1007 | |
| 957 | 1008 | // Request a passive connection - this means, we'll talk to you, you don't talk to us. |
| 958 | 1009 | @fwrite($this->connection, 'PASV' . "\r\n"); |
| 959 | 1010 | $time = time(); |
| 960 | - do |
|
| 961 | - $response = fgets($this->connection, 1024); |
|
| 962 | - while (strpos($response, ' ', 3) !== 3 && time() - $time < 5); |
|
| 1011 | + do { |
|
| 1012 | + $response = fgets($this->connection, 1024); |
|
| 1013 | + } while (strpos($response, ' ', 3) !== 3 && time() - $time < 5); |
|
| 963 | 1014 | |
| 964 | 1015 | // If it's not 227, we weren't given an IP and port, which means it failed. |
| 965 | 1016 | if (strpos($response, '227 ') !== 0) |
@@ -990,12 +1041,14 @@ discard block |
||
| 990 | 1041 | public function create_file($ftp_file) |
| 991 | 1042 | { |
| 992 | 1043 | // First, we have to be connected... very important. |
| 993 | - if (!is_resource($this->connection)) |
|
| 994 | - return false; |
|
| 1044 | + if (!is_resource($this->connection)) { |
|
| 1045 | + return false; |
|
| 1046 | + } |
|
| 995 | 1047 | |
| 996 | 1048 | // I'd like one passive mode, please! |
| 997 | - if (!$this->passive()) |
|
| 998 | - return false; |
|
| 1049 | + if (!$this->passive()) { |
|
| 1050 | + return false; |
|
| 1051 | + } |
|
| 999 | 1052 | |
| 1000 | 1053 | // Seems logical enough, so far... |
| 1001 | 1054 | fwrite($this->connection, 'STOR ' . $ftp_file . "\r\n"); |
@@ -1030,12 +1083,14 @@ discard block |
||
| 1030 | 1083 | public function list_dir($ftp_path = '', $search = false) |
| 1031 | 1084 | { |
| 1032 | 1085 | // Are we even connected...? |
| 1033 | - if (!is_resource($this->connection)) |
|
| 1034 | - return false; |
|
| 1086 | + if (!is_resource($this->connection)) { |
|
| 1087 | + return false; |
|
| 1088 | + } |
|
| 1035 | 1089 | |
| 1036 | 1090 | // Passive... non-agressive... |
| 1037 | - if (!$this->passive()) |
|
| 1038 | - return false; |
|
| 1091 | + if (!$this->passive()) { |
|
| 1092 | + return false; |
|
| 1093 | + } |
|
| 1039 | 1094 | |
| 1040 | 1095 | // Get the listing! |
| 1041 | 1096 | fwrite($this->connection, 'LIST -1' . ($search ? 'R' : '') . ($ftp_path == '' ? '' : ' ' . $ftp_path) . "\r\n"); |
@@ -1051,8 +1106,9 @@ discard block |
||
| 1051 | 1106 | |
| 1052 | 1107 | // Read in the file listing. |
| 1053 | 1108 | $data = ''; |
| 1054 | - while (!feof($fp)) |
|
| 1055 | - $data .= fread($fp, 4096); |
|
| 1109 | + while (!feof($fp)) { |
|
| 1110 | + $data .= fread($fp, 4096); |
|
| 1111 | + } |
|
| 1056 | 1112 | fclose($fp); |
| 1057 | 1113 | |
| 1058 | 1114 | // Everything go okay? |
@@ -1074,21 +1130,23 @@ discard block |
||
| 1074 | 1130 | */ |
| 1075 | 1131 | public function locate($file, $listing = null) |
| 1076 | 1132 | { |
| 1077 | - if ($listing === null) |
|
| 1078 | - $listing = $this->list_dir('', true); |
|
| 1133 | + if ($listing === null) { |
|
| 1134 | + $listing = $this->list_dir('', true); |
|
| 1135 | + } |
|
| 1079 | 1136 | $listing = explode("\n", $listing); |
| 1080 | 1137 | |
| 1081 | 1138 | @fwrite($this->connection, 'PWD' . "\r\n"); |
| 1082 | 1139 | $time = time(); |
| 1083 | - do |
|
| 1084 | - $response = fgets($this->connection, 1024); |
|
| 1085 | - while ($response[3] != ' ' && time() - $time < 5); |
|
| 1140 | + do { |
|
| 1141 | + $response = fgets($this->connection, 1024); |
|
| 1142 | + } while ($response[3] != ' ' && time() - $time < 5); |
|
| 1086 | 1143 | |
| 1087 | 1144 | // Check for 257! |
| 1088 | - if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0) |
|
| 1089 | - $current_dir = strtr($match[1], array('""' => '"')); |
|
| 1090 | - else |
|
| 1091 | - $current_dir = ''; |
|
| 1145 | + if (preg_match('~^257 "(.+?)" ~', $response, $match) != 0) { |
|
| 1146 | + $current_dir = strtr($match[1], array('""' => '"')); |
|
| 1147 | + } else { |
|
| 1148 | + $current_dir = ''; |
|
| 1149 | + } |
|
| 1092 | 1150 | |
| 1093 | 1151 | for ($i = 0, $n = count($listing); $i < $n; $i++) |
| 1094 | 1152 | { |
@@ -1101,12 +1159,15 @@ discard block |
||
| 1101 | 1159 | // Okay, this file's name is: |
| 1102 | 1160 | $listing[$i] = $current_dir . '/' . trim(strlen($listing[$i]) > 30 ? strrchr($listing[$i], ' ') : $listing[$i]); |
| 1103 | 1161 | |
| 1104 | - if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1)) |
|
| 1105 | - return $listing[$i]; |
|
| 1106 | - if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1)) |
|
| 1107 | - return $listing[$i]; |
|
| 1108 | - if (basename($listing[$i]) == $file || $listing[$i] == $file) |
|
| 1109 | - return $listing[$i]; |
|
| 1162 | + if ($file[0] == '*' && substr($listing[$i], -(strlen($file) - 1)) == substr($file, 1)) { |
|
| 1163 | + return $listing[$i]; |
|
| 1164 | + } |
|
| 1165 | + if (substr($file, -1) == '*' && substr($listing[$i], 0, strlen($file) - 1) == substr($file, 0, -1)) { |
|
| 1166 | + return $listing[$i]; |
|
| 1167 | + } |
|
| 1168 | + if (basename($listing[$i]) == $file || $listing[$i] == $file) { |
|
| 1169 | + return $listing[$i]; |
|
| 1170 | + } |
|
| 1110 | 1171 | } |
| 1111 | 1172 | |
| 1112 | 1173 | return false; |
@@ -1121,8 +1182,9 @@ discard block |
||
| 1121 | 1182 | public function create_dir($ftp_dir) |
| 1122 | 1183 | { |
| 1123 | 1184 | // We must be connected to the server to do something. |
| 1124 | - if (!is_resource($this->connection)) |
|
| 1125 | - return false; |
|
| 1185 | + if (!is_resource($this->connection)) { |
|
| 1186 | + return false; |
|
| 1187 | + } |
|
| 1126 | 1188 | |
| 1127 | 1189 | // Make this new beautiful directory! |
| 1128 | 1190 | fwrite($this->connection, 'MKD ' . $ftp_dir . "\r\n"); |
@@ -1154,35 +1216,40 @@ discard block |
||
| 1154 | 1216 | |
| 1155 | 1217 | $path = strtr($_SERVER['DOCUMENT_ROOT'], array('/home/' . $match[1] . '/' => '', '/home2/' . $match[1] . '/' => '')); |
| 1156 | 1218 | |
| 1157 | - if (substr($path, -1) == '/') |
|
| 1158 | - $path = substr($path, 0, -1); |
|
| 1219 | + if (substr($path, -1) == '/') { |
|
| 1220 | + $path = substr($path, 0, -1); |
|
| 1221 | + } |
|
| 1159 | 1222 | |
| 1160 | - if (strlen(dirname($_SERVER['PHP_SELF'])) > 1) |
|
| 1161 | - $path .= dirname($_SERVER['PHP_SELF']); |
|
| 1223 | + if (strlen(dirname($_SERVER['PHP_SELF'])) > 1) { |
|
| 1224 | + $path .= dirname($_SERVER['PHP_SELF']); |
|
| 1225 | + } |
|
| 1226 | + } elseif (strpos($filesystem_path, '/var/www/') === 0) { |
|
| 1227 | + $path = substr($filesystem_path, 8); |
|
| 1228 | + } else { |
|
| 1229 | + $path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => '')); |
|
| 1162 | 1230 | } |
| 1163 | - elseif (strpos($filesystem_path, '/var/www/') === 0) |
|
| 1164 | - $path = substr($filesystem_path, 8); |
|
| 1165 | - else |
|
| 1166 | - $path = strtr(strtr($filesystem_path, array('\\' => '/')), array($_SERVER['DOCUMENT_ROOT'] => '')); |
|
| 1231 | + } else { |
|
| 1232 | + $path = ''; |
|
| 1167 | 1233 | } |
| 1168 | - else |
|
| 1169 | - $path = ''; |
|
| 1170 | 1234 | |
| 1171 | 1235 | if (is_resource($this->connection) && $this->list_dir($path) == '') |
| 1172 | 1236 | { |
| 1173 | 1237 | $data = $this->list_dir('', true); |
| 1174 | 1238 | |
| 1175 | - if ($lookup_file === null) |
|
| 1176 | - $lookup_file = $_SERVER['PHP_SELF']; |
|
| 1239 | + if ($lookup_file === null) { |
|
| 1240 | + $lookup_file = $_SERVER['PHP_SELF']; |
|
| 1241 | + } |
|
| 1177 | 1242 | |
| 1178 | 1243 | $found_path = dirname($this->locate('*' . basename(dirname($lookup_file)) . '/' . basename($lookup_file), $data)); |
| 1179 | - if ($found_path == false) |
|
| 1180 | - $found_path = dirname($this->locate(basename($lookup_file))); |
|
| 1181 | - if ($found_path != false) |
|
| 1182 | - $path = $found_path; |
|
| 1244 | + if ($found_path == false) { |
|
| 1245 | + $found_path = dirname($this->locate(basename($lookup_file))); |
|
| 1246 | + } |
|
| 1247 | + if ($found_path != false) { |
|
| 1248 | + $path = $found_path; |
|
| 1249 | + } |
|
| 1250 | + } elseif (is_resource($this->connection)) { |
|
| 1251 | + $found_path = true; |
|
| 1183 | 1252 | } |
| 1184 | - elseif (is_resource($this->connection)) |
|
| 1185 | - $found_path = true; |
|
| 1186 | 1253 | |
| 1187 | 1254 | return array($username, $path, isset($found_path)); |
| 1188 | 1255 | } |