albertlast / SMF2.1

Themes/default/ManageLanguages.template.php

Braces +9 added lines, -6 removed lines

@@ -36,11 +36,12 @@ 
 	}
 
 	// An error?
-	if (!empty($context['error_message']))
-		echo '
+	if (!empty($context['error_message'])) {
+			echo '
 	<div class="errorbox">
 		', $context['error_message'], '
 	</div>';
+	}
 
 	// Provide something of an introduction...
 	echo '
@@ -67,11 +68,12 @@ 
 	// If the files are not writable, we might!
 	if (!empty($context['still_not_writable']))
 	{
-		if (!empty($context['package_ftp']['error']))
-			echo '
+		if (!empty($context['package_ftp']['error'])) {
+					echo '
 			<div class="errorbox">
 				', $context['package_ftp']['error'], '
 			</div>';
+		}
 
 		echo '
 			<div class="cat_bar">
@@ -243,11 +245,12 @@ 
 
 	// Is it not writable?
 	// Show an error.
-	if (!empty($context['entries_not_writable_message']))
-		echo '
+	if (!empty($context['entries_not_writable_message'])) {
+			echo '
 			<div class="errorbox">
 				', $context['entries_not_writable_message'], '
 			</div>';
+	}
 
 	// Already have some file entries?
 	if (!empty($context['file_entries']))

Themes/default/Errors.template.php

Braces +24 added lines, -17 removed lines

@@ -23,13 +23,13 @@ 
 {
 	global $context, $txt;
 
-	if (!empty($context['simple_action']))
-		echo '
+	if (!empty($context['simple_action'])) {
+			echo '
 		<strong>
 			', $context['error_title'], '
 		</strong><br>
 		<div ', $context['error_code'], 'class="padding">', $context['error_message'], '</div>';
-	else
+	} else
 	{
 		echo '
 	<div id="fatal_error">
@@ -82,21 +82,23 @@ 
 						&nbsp;&nbsp;', $txt['apply_filter_of_type'], ':';
 
 	$error_types = array();
-	foreach ($context['error_types'] as $type => $details)
-		$error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>';
+	foreach ($context['error_types'] as $type => $details) {
+			$error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>';
+	}
 
 	echo '
 						', implode('&nbsp;|&nbsp;', $error_types), '
 					</td>
 				</tr>';
 
-	if ($context['has_filter'])
-		echo '
+	if ($context['has_filter']) {
+			echo '
 				<tr>
 					<td colspan="3" class="windowbg">
 						<strong>&nbsp;&nbsp;', $txt['applying_filter'], ':</strong> ', $context['filter']['entity'], ' ', $context['filter']['value']['html'], '&nbsp;&nbsp;[<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', '">', $txt['clear_filter'], '</a>]
 					</td>
 				</tr>';
+	}
 
 	echo '
 				<tr>
@@ -107,11 +109,12 @@ 
 				</tr>';
 
 	// No errors, then show a message
-	if (count($context['errors']) == 0)
-		echo '
+	if (count($context['errors']) == 0) {
+			echo '
 				<tr class="windowbg">
 					<td class="centertext" colspan="2">', $txt['errlog_no_entries'], '</td>
 				</tr>';
+	}
 
 	// we have some errors, must be some mods installed :P
 	foreach ($context['errors'] as $error)
@@ -126,20 +129,22 @@ 
 							<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? '' : ';desc', $context['has_filter'] ? $context['filter']['href'] : '', '" title="', $txt['reverse_direction'], '"><span class="generic_icons sort_' . $context['sort_direction'] . '"></span></a>
 							', $error['time'], '<br>';
 
-		if (!empty($error['member']['ip']))
-			echo '
+		if (!empty($error['member']['ip'])) {
+					echo '
 							<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=ip;value=', $error['member']['ip'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_ip'], '"><span class="generic_icons filter centericon"></span></a>
 							<strong><a href="', $scripturl, '?action=trackip;searchip=', $error['member']['ip'], '">', $error['member']['ip'], '</a></strong>&nbsp;&nbsp;<br>';
+		}
 
 		echo '
 						</div>
 
 						<div style="float: left; width: 50%; line-height: 1.8em; padding: 0 4px;">';
 
-		if ($error['member']['session'] != '')
-			echo '
+		if ($error['member']['session'] != '') {
+					echo '
 							<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=session;value=', $error['member']['session'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_session'], '"><span class="generic_icons filter centericon"></span></a>
 							', $error['member']['session'], '<br>';
+		}
 
 		echo '
 							<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=error_type;value=', $error['error_type']['type'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_type'], '"><span class="generic_icons filter centericon"></span></a>
@@ -153,8 +158,8 @@ 
 							<a style="display: table-cell;" href="', $error['url']['html'], '">', $error['url']['html'], '</a>
 						</div>';
 
-		if (!empty($error['file']))
-			echo '
+		if (!empty($error['file'])) {
+					echo '
 						<div style="float: left; width: 100%; padding: 4px 0; line-height: 1.6em; border-top: 1px solid #e3e3e3;">
 							<a style="display: table-cell; padding: 4px; width: 20px; vertical-align: top;" href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=file;value=', $error['file']['search'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_file'], '"><span class="generic_icons filter"></span></a>
 							<div>
@@ -162,6 +167,7 @@ 
 								', $txt['line'], ': ', $error['file']['line'], '
 							</div>
 						</div>';
+		}
 
 		echo '
 					</td>
@@ -190,9 +196,10 @@ 
 			</div>
 			<br>';
 
-	if ($context['sort_direction'] == 'down')
-		echo '
+	if ($context['sort_direction'] == 'down') {
+			echo '
 			<input type="hidden" name="desc" value="1">';
+	}
 
 	echo '
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">';

Themes/default/GenericList.template.php

Indentation +1 added lines, -1 removed lines

@@ -220,7 +220,7 @@
 				),
 			),
 		);
-	*/
+	 */
 
 	// Are we using right-to-left orientation?
 	$first = $context['right_to_left'] ? 'last' : 'first';

Braces +62 added lines, -44 removed lines

@@ -21,26 +21,30 @@ 
 
 	// Get a shortcut to the current list.
 	$list_id = $list_id === null ? (!empty($context['default_list']) ? $context['default_list'] : '') : $list_id;
-	if (empty($list_id) || empty($context[$list_id]))
-		return;
+	if (empty($list_id) || empty($context[$list_id])) {
+			return;
+	}
 	$cur_list = &$context[$list_id];
 
 	// These are the main tabs that is used all around the template.
-	if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'top'))
-		template_create_list_menu($cur_list['list_menu'], 'top');
+	if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'top')) {
+			template_create_list_menu($cur_list['list_menu'], 'top');
+	}
 
-	if (isset($cur_list['form']))
-		echo '
+	if (isset($cur_list['form'])) {
+			echo '
 	<form action="', $cur_list['form']['href'], '" method="post"', empty($cur_list['form']['name']) ? '' : ' name="' . $cur_list['form']['name'] . '" id="' . $cur_list['form']['name'] . '"', ' accept-charset="', $context['character_set'], '">';
+	}
 
 	// Show the title of the table (if any).
-	if (!empty($cur_list['title']))
-		echo '
+	if (!empty($cur_list['title'])) {
+			echo '
 			<div class="cat_bar">
 				<h3 class="catbg">
 					', $cur_list['title'], '
 				</h3>
 			</div>';
+	}
 
 	if (isset($cur_list['additional_rows']['after_title']))
 	{
@@ -51,20 +55,23 @@ 
 			</div>';
 	}
 
-	if (isset($cur_list['additional_rows']['top_of_list']))
-		template_additional_rows('top_of_list', $cur_list);
+	if (isset($cur_list['additional_rows']['top_of_list'])) {
+			template_additional_rows('top_of_list', $cur_list);
+	}
 
 	if ((!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) || isset($cur_list['additional_rows']['above_column_headers']))
 	{
 		// Show the page index (if this list doesn't intend to show all items).
-		if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index']))
-			echo '
+		if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) {
+					echo '
 				<div class="floatleft">
 					<div class="pagesection">', $cur_list['page_index'], '</div>
 				</div>';
+		}
 
-		if (isset($cur_list['additional_rows']['above_column_headers']))
-			template_additional_rows('above_column_headers', $cur_list);
+		if (isset($cur_list['additional_rows']['above_column_headers'])) {
+					template_additional_rows('above_column_headers', $cur_list);
+		}
 	}
 
 	echo '
@@ -94,11 +101,12 @@ 
 			<tbody>';
 
 	// Show a nice message informing there are no items in this list.
-	if (empty($cur_list['rows']) && !empty($cur_list['no_items_label']))
-		echo '
+	if (empty($cur_list['rows']) && !empty($cur_list['no_items_label'])) {
+			echo '
 				<tr class="windowbg">
 					<td colspan="', $cur_list['num_columns'], '" class="', !empty($cur_list['no_items_align']) ? $cur_list['no_items_align'] : 'centertext', '">', $cur_list['no_items_label'], '</td>
 				</tr>';
+	}
 
 	// Show the list rows.
 	elseif (!empty($cur_list['rows']))
@@ -108,10 +116,11 @@ 
 			echo '
 				<tr class="windowbg', empty($row['class']) ? '' : ' ' . $row['class'], '"', empty($row['style']) ? '' : ' style="' . $row['style'] . '"', ' id="list_', $list_id, '_', $id, '">';
 
-			if (!empty($row['data']))
-				foreach ($row['data'] as $row_data)
+			if (!empty($row['data'])) {
+							foreach ($row['data'] as $row_data)
 					echo '
 					<td', empty($row_data['class']) ? '' : ' class="' . $row_data['class'] . '"', empty($row_data['style']) ? '' : ' style="' . $row_data['style'] . '"', '>', $row_data['value'], '</td>';
+			}
 
 			echo '
 				</tr>';
@@ -128,46 +137,53 @@ 
 			<div class="flow_auto">';
 
 		// Show the page index (if this list doesn't intend to show all items).
-		if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index']))
-			echo '
+		if (!empty($cur_list['items_per_page']) && !empty($cur_list['page_index'])) {
+					echo '
 				<div class="floatleft">
 					<div class="pagesection">', $cur_list['page_index'], '</div>
 				</div>';
+		}
 
-		if (isset($cur_list['additional_rows']['below_table_data']))
-			template_additional_rows('below_table_data', $cur_list);
+		if (isset($cur_list['additional_rows']['below_table_data'])) {
+					template_additional_rows('below_table_data', $cur_list);
+		}
 
 		echo '
 			</div>';
 	}
 
-	if (isset($cur_list['additional_rows']['bottom_of_list']))
-		template_additional_rows('bottom_of_list', $cur_list);
+	if (isset($cur_list['additional_rows']['bottom_of_list'])) {
+			template_additional_rows('bottom_of_list', $cur_list);
+	}
 
 	if (isset($cur_list['form']))
 	{
-		foreach ($cur_list['form']['hidden_fields'] as $name => $value)
-			echo '
+		foreach ($cur_list['form']['hidden_fields'] as $name => $value) {
+					echo '
 			<input type="hidden" name="', $name, '" value="', $value, '">';
+		}
 
-		if (isset($cur_list['form']['token']))
-			echo '
+		if (isset($cur_list['form']['token'])) {
+					echo '
 			<input type="hidden" name="', $context[$cur_list['form']['token'] . '_token_var'], '" value="', $context[$cur_list['form']['token'] . '_token'], '">';
+		}
 
 		echo '
 	</form>';
 	}
 
 	// Tabs at the bottom.  Usually bottom aligned.
-	if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'bottom'))
-		template_create_list_menu($cur_list['list_menu'], 'bottom');
+	if (isset($cur_list['list_menu'], $cur_list['list_menu']['show_on']) && ($cur_list['list_menu']['show_on'] == 'both' || $cur_list['list_menu']['show_on'] == 'bottom')) {
+			template_create_list_menu($cur_list['list_menu'], 'bottom');
+	}
 
-	if (isset($cur_list['javascript']))
-		echo '
+	if (isset($cur_list['javascript'])) {
+			echo '
 	<script>
 		', $cur_list['javascript'], '
 	</script>';
-}
+	}
+	}
 
 /**
  * This template displays additional rows above or below the list.
@@ -177,10 +193,11 @@ 
  */
 function template_additional_rows($row_position, $cur_list)
 {
-	foreach ($cur_list['additional_rows'][$row_position] as $row)
-		echo '
+	foreach ($cur_list['additional_rows'][$row_position] as $row) {
+			echo '
 			<div class="additional_row', empty($row['class']) ? '' : ' ' . $row['class'], '"', empty($row['style']) ? '' : ' style="' . $row['style'] . '"', '>', $row['value'], '</div>';
-}
+	}
+	}
 
 /**
  * This function creates a menu
@@ -239,18 +256,19 @@ 
 
 		foreach ($list_menu['links'] as $link)
 		{
-			if ($link['is_selected'])
-				echo '
+			if ($link['is_selected']) {
+							echo '
 							<td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_active_', $first, '">&nbsp;</td>
 							<td class="', $direction == 'top' ? 'mirrortab' : 'maintab', '_active_back">
 								<a href="', $link['href'], '">', $link['label'], '</a>
 							</td>
 							<td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_active_', $last, '">&nbsp;</td>';
-			else
-				echo '
+			} else {
+							echo '
 							<td class="', $direction == 'top' ? 'mirror' : 'main', 'tab_back">
 								<a href="', $link['href'], '">', $link['label'], '</a>
 							</td>';
+			}
 		}
 
 		echo '
@@ -261,12 +279,12 @@ 
 				<td>&nbsp;</td>' : '', '
 			</tr>
 		</table>';
-	}
-	elseif (isset($list_menu['style']) && $list_menu['style'] == 'buttons')
+	} elseif (isset($list_menu['style']) && $list_menu['style'] == 'buttons')
 	{
 		$links = array();
-		foreach ($list_menu['links'] as $link)
-			$links[] = '<a href="' . $link['href'] . '">' . $link['label'] . '</a>';
+		foreach ($list_menu['links'] as $link) {
+					$links[] = '<a href="' . $link['href'] . '">' . $link['label'] . '</a>';
+		}
 
 		echo '
 		<table style="margin-', $list_menu['position'], ': 10px; width: 100%;">

Themes/default/ManageMembers.template.php

Braces +6 added lines, -4 removed lines

@@ -148,8 +148,8 @@ 
 				</thead>
 				<tbody>';
 
-			foreach ($context['membergroups'] as $membergroup)
-				echo '
+			foreach ($context['membergroups'] as $membergroup) {
+							echo '
 					<tr class="windowbg">
 						<td>', $membergroup['name'], '</td>
 						<td class="centercol">
@@ -159,6 +159,7 @@ 
 							', $membergroup['can_be_additional'] ? '<input type="checkbox" name="membergroups[2][]" value="' . $membergroup['id'] . '" checked class="input_check">' : '', '
 						</td>
 					</tr>';
+			}
 
 			echo '
 					<tr class="windowbg">
@@ -185,8 +186,8 @@ 
 				</thead>
 				<tbody>';
 
-			foreach ($context['postgroups'] as $postgroup)
-				echo '
+			foreach ($context['postgroups'] as $postgroup) {
+							echo '
 					<tr class="windowbg">
 						<td>
 							', $postgroup['name'], '
@@ -195,6 +196,7 @@ 
 							<input type="checkbox" name="postgroups[]" value="', $postgroup['id'], '" checked class="input_check">
 						</td>
 					</tr>';
+			}
 
 			echo '
 					<tr class="windowbg">

Themes/default/ManageAttachments.template.php

Braces +20 added lines, -14 removed lines

@@ -116,9 +116,10 @@ 
 				<h3 class="catbg">', $txt['attachment_transfer'], '</h3>
 			</div>';
 
-	if (!empty($context['results']))
-		echo '
+	if (!empty($context['results'])) {
+			echo '
 			<div class="noticebox">', $context['results'], '</div>';
+	}
 
 	echo '
 			<div class="windowbg2 noup">
@@ -129,9 +130,10 @@ 
 						<dd><select name="from">
 							<option value="0">', $txt['attachment_transfer_select'], '</option>';
 
-	foreach ($context['attach_dirs'] as $id => $dir)
-		echo '
+	foreach ($context['attach_dirs'] as $id => $dir) {
+			echo '
 							<option value="', $id, '">', $dir, '</option>';
+	}
 	echo '
 						</select></dd>
 						<dt>', $txt['attachment_transfer_auto'], '</dt>
@@ -139,13 +141,14 @@ 
 							<option value="0">', $txt['attachment_transfer_auto_select'], '</option>
 							<option value="-1">', $txt['attachment_transfer_forum_root'], '</option>';
 
-	if (!empty($context['base_dirs']))
-		foreach ($context['base_dirs'] as $id => $dir)
+	if (!empty($context['base_dirs'])) {
+			foreach ($context['base_dirs'] as $id => $dir)
 			echo '
 							<option value="', $id, '">', $dir, '</option>';
-	else
-			echo '
+	} else {
+				echo '
 							<option value="0" disabled>', $txt['attachment_transfer_no_base'], '</option>';
+	}
 
 	echo '
 						</select></dd>
@@ -153,16 +156,18 @@ 
 						<dd><select name="to">
 							<option value="0">', $txt['attachment_transfer_select'], '</option>';
 
-	foreach ($context['attach_dirs'] as $id => $dir)
-		echo '
+	foreach ($context['attach_dirs'] as $id => $dir) {
+			echo '
 							<option value="', $id, '">', $dir, '</option>';
+	}
 	echo '
 						</select></dd>';
 
-	if (!empty($modSettings['attachmentDirFileLimit']))
-		echo '
+	if (!empty($modSettings['attachmentDirFileLimit'])) {
+			echo '
 						<dt>', $txt['attachment_transfer_empty'], '</dt>
 						<dd><input type="checkbox" name="empty_it"', $context['checked'] ? ' checked' : '', '></dd>';
+	}
 	echo '
 					</dl>
 					<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -238,10 +243,11 @@ 
 		// Loop through each error reporting the status
 		foreach ($context['repair_errors'] as $error => $number)
 		{
-			if (!empty($number))
-			echo '
+			if (!empty($number)) {
+						echo '
 				<input type="checkbox" name="to_fix[]" id="', $error, '" value="', $error, '" class="input_check">
 				<label for="', $error, '">', sprintf($txt['attach_repair_' . $error], $number), '</label><br>';
+			}
 		}
 
 		echo '		<br>

ssi_examples.php

Braces +4 added lines, -4 removed lines

@@ -583,8 +583,7 @@ 
 	{
 		$header = '<?php require("' . ($user_info['is_admin'] ? addslashes(realpath($boarddir . '/SSI.php')) : 'SSI.php') . '"); ?>' . "\n" . $header;
 		return $header . template_homepage_sample1_html() . $footer;
-	}
-	else
+	} else
 	{
 		echo $header;
 		template_homepage_sample1_php();
@@ -599,9 +598,10 @@ 
 
 	$topics = ssi_recentTopics(8, null, null, 'array');
 
-	foreach ($topics as $topic)
-		echo '
+	foreach ($topics as $topic) {
+			echo '
 			<li><a href="', $topic['href'], '">', $topic['subject'], '</a> ', $txt['by'], ' ', $topic['poster']['link'], '</li>';
+	}
 
 	unset($topics);
 

cron.php

Braces +36 added lines, -28 removed lines

@@ -41,37 +41,43 @@ 
 define('TIME_START', microtime(true));
 
 // Just being safe...
-foreach (array('db_character_set', 'cachedir') as $variable)
+foreach (array('db_character_set', 'cachedir') as $variable) {
 	if (isset($GLOBALS[$variable]))
 		unset($GLOBALS[$variable]);
+}
 
 // Get the forum's settings for database and file paths.
 require_once(dirname(__FILE__) . '/Settings.php');
 
 // Make absolutely sure the cache directory is defined.
-if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache'))
+if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) {
 	$cachedir = $boarddir . '/cache';
+}
 
 // Don't do john didley if the forum's been shut down competely.
-if ($maintenance == 2)
+if ($maintenance == 2) {
 	die($mmessage);
+}
 
 // Fix for using the current directory as a path.
-if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
+if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') {
 	$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);
+}
 
 // Have we already turned this off? If so, exist gracefully.
-if (file_exists($cachedir . '/cron.lock'))
+if (file_exists($cachedir . '/cron.lock')) {
 	obExit_cron();
+}
 
 // Before we go any further, if this is not a CLI request, we need to do some checking.
 if (!FROM_CLI)
 {
 	// We will clean up $_GET shortly. But we want to this ASAP.
 	$ts = isset($_GET['ts']) ? (int) $_GET['ts'] : 0;
-	if ($ts <= 0 || $ts % 15 != 0 || time() - $ts < 0 || time() - $ts > 20)
-		obExit_cron();
-}
+	if ($ts <= 0 || $ts % 15 != 0 || time() - $ts < 0 || time() - $ts > 20) {
+			obExit_cron();
+	}
+	}
 
 // Load the most important includes. In general, a background should be loading its own dependencies.
 require_once($sourcedir . '/Errors.php');
@@ -123,8 +129,9 @@ 
 	global $smcFunc;
 
 	// Check we haven't run over our time limit.
-	if (microtime(true) - TIME_START > MAX_CRON_TIME)
-		return false;
+	if (microtime(true) - TIME_START > MAX_CRON_TIME) {
+			return false;
+	}
 
 	// Try to find a task. Specifically, try to find one that hasn't been claimed previously, or failing that,
 	// a task that was claimed but failed for whatever reason and failed long enough ago. We should not care
@@ -159,14 +166,12 @@ 
 			// Update the time and go back.
 			$row['claimed_time'] = time();
 			return $row;
-		}
-		else
+		} else
 		{
 			// Uh oh, we just missed it. Try to claim another one, and let it fall through if there aren't any.
 			return fetch_task();
 		}
-	}
-	else
+	} else
 	{
 		// No dice. Clean up and go home.
 		$smcFunc['db_free_result']($request);
@@ -187,8 +192,9 @@ 
 	if (!empty($task_details['task_file']))
 	{
 		$include = strtr(trim($task_details['task_file']), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
-		if (file_exists($include))
-			require_once($include);
+		if (file_exists($include)) {
+					require_once($include);
+		}
 	}
 
 	if (empty($task_details['task_class']))
@@ -204,8 +210,7 @@ 
 		$details = empty($task_details['task_data']) ? array() : json_decode($task_details['task_data'], true);
 		$bgtask = new $task_details['task_class']($details);
 		return $bgtask->execute();
-	}
-	else
+	} else
 	{
 		log_error('Invalid background task specified: (class: ' . $task_details['task_class'] . ', ' . (empty($task_details['task_file']) ? ' no file' : ' to load ' . $task_details['task_file']) . ')');
 		return true; // So we clear it from the queue.
@@ -224,8 +229,9 @@ 
 	$scripturl = $boardurl . '/index.php';
 
 	// These keys shouldn't be set...ever.
-	if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS']))
-		die('Invalid request variable.');
+	if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) {
+			die('Invalid request variable.');
+	}
 
 	// Save some memory.. (since we don't use these anyway.)
 	unset($GLOBALS['HTTP_POST_VARS'], $GLOBALS['HTTP_POST_VARS']);
@@ -246,26 +252,28 @@ 
 	global $modSettings;
 
 	// Ignore errors if we're ignoring them or they are strict notices from PHP 5 (which cannot be solved without breaking PHP 4.)
-	if (error_reporting() == 0 || (defined('E_STRICT') && $error_level == E_STRICT && !empty($modSettings['enableErrorLogging'])))
-		return;
+	if (error_reporting() == 0 || (defined('E_STRICT') && $error_level == E_STRICT && !empty($modSettings['enableErrorLogging']))) {
+			return;
+	}
 
 	$error_type = 'cron';
 
 	log_error($error_level . ': ' . $error_string, $error_type, $file, $line);
 
 	// If this is an E_ERROR or E_USER_ERROR.... die.  Violently so.
-	if ($error_level % 255 == E_ERROR)
-		die('No direct access...');
-}
+	if ($error_level % 255 == E_ERROR) {
+			die('No direct access...');
+	}
+	}
 
 /**
  * The exit function
  */
 function obExit_cron()
 {
-	if (FROM_CLI)
-		die(0);
-	else
+	if (FROM_CLI) {
+			die(0);
+	} else
 	{
 		header('Content-Type: image/gif');
 		die("\x47\x49\x46\x38\x39\x61\x01\x00\x01\x00\x80\x00\x00\x00\x00\x00\x00\x00\x00\x21\xF9\x04\x01\x00\x00\x00\x00\x2C\x00\x00\x00\x00\x01\x00\x01\x00\x00\x02\x02\x44\x01\x00\x3B");

other/Settings.php

Braces +8 added lines, -4 removed lines

@@ -186,8 +186,9 @@ 
 
 ########## Error-Catching ##########
 # Note: You shouldn't touch these settings.
-if (file_exists(dirname(__FILE__) . '/db_last_error.php'))
+if (file_exists(dirname(__FILE__) . '/db_last_error.php')) {
 	include(dirname(__FILE__) . '/db_last_error.php');
+}
 
 if (!isset($db_last_error))
 {
@@ -202,11 +203,14 @@ 
 }
 
 # Make sure the paths are correct... at least try to fix them.
-if (!file_exists($boarddir) && file_exists(dirname(__FILE__) . '/agreement.txt'))
+if (!file_exists($boarddir) && file_exists(dirname(__FILE__) . '/agreement.txt')) {
 	$boarddir = dirname(__FILE__);
-if (!file_exists($sourcedir) && file_exists($boarddir . '/Sources'))
+}
+if (!file_exists($sourcedir) && file_exists($boarddir . '/Sources')) {
 	$sourcedir = $boarddir . '/Sources';
-if (!file_exists($cachedir) && file_exists($boarddir . '/cache'))
+}
+if (!file_exists($cachedir) && file_exists($boarddir . '/cache')) {
 	$cachedir = $boarddir . '/cache';
+}
 
 ?>
\ No newline at end of file

subscriptions.php

Braces +38 added lines, -28 removed lines

@@ -16,8 +16,9 @@ 
 
 // Start things rolling by getting SMF alive...
 $ssi_guest_access = true;
-if (!file_exists(dirname(__FILE__) . '/SSI.php'))
+if (!file_exists(dirname(__FILE__) . '/SSI.php')) {
 	die('Cannot find SSI.php');
+}
 
 require_once(dirname(__FILE__) . '/SSI.php');
 require_once($sourcedir . '/ManagePaid.php');
@@ -35,20 +36,22 @@ 
 }
 
 // I assume we're even active?
-if (empty($modSettings['paid_enabled']))
+if (empty($modSettings['paid_enabled'])) {
 	exit;
+}
 
 // If we have some custom people who find out about problems load them here.
 $notify_users = array();
 if (!empty($modSettings['paid_email_to']))
 {
-	foreach (explode(',', $modSettings['paid_email_to']) as $email)
-		$notify_users[] = array(
+	foreach (explode(',', $modSettings['paid_email_to']) as $email) {
+			$notify_users[] = array(
 			'email' => $email,
 			'name' => $txt['who_member'],
 			'id' => 0,
 		);
-}
+	}
+	}
 
 // We need to see whether we can find the correct payment gateway,
 // we'll going to go through all our gateway scripts and find out
@@ -65,8 +68,9 @@ 
 	}
 }
 
-if (empty($txnType))
+if (empty($txnType)) {
 	generateSubscriptionError($txt['paid_unknown_transaction_type']);
+}
 
 // Get the subscription and member ID amoungst others...
 @list($subscription_id, $member_id) = $gatewayClass->precheck();
@@ -76,8 +80,9 @@ 
 $member_id = (int) $member_id;
 
 // This would be bad...
-if (empty($member_id))
+if (empty($member_id)) {
 	generateSubscriptionError($txt['paid_empty_member']);
+}
 
 // Verify the member.
 $request = $smcFunc['db_query']('', '
@@ -89,8 +94,9 @@ 
 	)
 );
 // Didn't find them?
-if ($smcFunc['db_num_rows']($request) === 0)
+if ($smcFunc['db_num_rows']($request) === 0) {
 	generateSubscriptionError(sprintf($txt['paid_could_not_find_member'], $member_id));
+}
 $member_info = $smcFunc['db_fetch_assoc']($request);
 $smcFunc['db_free_result']($request);
 
@@ -105,8 +111,9 @@ 
 );
 
 // Didn't find it?
-if ($smcFunc['db_num_rows']($request) === 0)
+if ($smcFunc['db_num_rows']($request) === 0) {
 	generateSubscriptionError(sprintf($txt['paid_count_not_find_subscription'], $member_id, $subscription_id));
+}
 
 $subscription_info = $smcFunc['db_fetch_assoc']($request);
 $smcFunc['db_free_result']($request);
@@ -123,8 +130,9 @@ 
 		'current_member' => $member_id,
 	)
 );
-if ($smcFunc['db_num_rows']($request) === 0)
+if ($smcFunc['db_num_rows']($request) === 0) {
 	generateSubscriptionError(sprintf($txt['paid_count_not_find_subscription_log'], $member_id, $subscription_id));
+}
 $subscription_info += $smcFunc['db_fetch_assoc']($request);
 $smcFunc['db_free_result']($request);
 
@@ -139,8 +147,7 @@ 
 		removeSubscription($subscription_id, $member_id);
 		$subscription_act = time();
 		$status = 0;
-	}
-	else
+	} else
 	{
 		loadSubscriptions();
 		$subscription_act = $subscription_info['end_time'] - $context['subscriptions'][$subscription_id]['num_length'];
@@ -188,16 +195,18 @@ 
 	if (!$gatewayClass->isSubscription())
 	{
 		$real_details = json_decode($subscription_info['pending_details'], true);
-		if (empty($real_details))
-			generateSubscriptionError(sprintf($txt['paid_count_not_find_outstanding_payment'], $member_id, $subscription_id));
+		if (empty($real_details)) {
+					generateSubscriptionError(sprintf($txt['paid_count_not_find_outstanding_payment'], $member_id, $subscription_id));
+		}
 
 		// Now we just try to find anything pending.
 		// We don't really care which it is as security happens later.
 		foreach ($real_details as $id => $detail)
 		{
 			unset($real_details[$id]);
-			if ($detail[3] == 'payback' && $subscription_info['payments_pending'])
-				$subscription_info['payments_pending']--;
+			if ($detail[3] == 'payback' && $subscription_info['payments_pending']) {
+							$subscription_info['payments_pending']--;
+			}
 			break;
 		}
 
@@ -223,10 +232,11 @@ 
 		// This is a little harder, can we find the right duration?
 		foreach ($cost as $duration => $value)
 		{
-			if ($duration == 'fixed')
-				continue;
-			elseif ((float) $value == (float) $total_cost)
-				$found_duration = strtoupper(substr($duration, 0, 1));
+			if ($duration == 'fixed') {
+							continue;
+			} elseif ((float) $value == (float) $total_cost) {
+							$found_duration = strtoupper(substr($duration, 0, 1));
+			}
 		}
 
 		// If we have the duration then we're done.
@@ -235,8 +245,7 @@ 
 			$notify = true;
 			addSubscription($subscription_id, $member_id, $found_duration);
 		}
-	}
-	else
+	} else
 	{
 		$actual_cost = $cost['fixed'];
 
@@ -268,10 +277,10 @@ 
 // Maybe they're cancelling. Some subscriptions may require actively doing something, but PayPal doesn't, for example.
 elseif ($gatewayClass->isCancellation())
 {
-	if (method_exists($gatewayClass, 'performCancel'))
-		$gatewayClass->performCancel($subscription_id, $member_id, $subscription_info);
-}
-else
+	if (method_exists($gatewayClass, 'performCancel')) {
+			$gatewayClass->performCancel($subscription_id, $member_id, $subscription_info);
+	}
+	} else
 {
 	// Some other "valid" transaction such as:
 	//
@@ -308,8 +317,9 @@ 
 	// Maybe we can try to give them the post data?
 	if (!empty($_POST))
 	{
-		foreach ($_POST as $key => $val)
-			$text .= '<br>' . $smcFunc['htmlspecialchars']($key) . ': ' . $smcFunc['htmlspecialchars']($val);
+		foreach ($_POST as $key => $val) {
+					$text .= '<br>' . $smcFunc['htmlspecialchars']($key) . ': ' . $smcFunc['htmlspecialchars']($val);
+		}
 	}
 
 	// Then just log and die.