albertlast / SMF2.1

Sources/CacheAPI-apcu.php

<?php

/**
 * Simple Machines Forum (SMF)
 *
 * @package SMF
 * @author Simple Machines http://www.simplemachines.org
 * @copyright 2017 Simple Machines and individual contributors
 * @license http://www.simplemachines.org/about/smf/license.php BSD
 *
 * @version 2.1 Beta 4
 */

if (!defined('SMF'))
	die('Hacking attempt...');

/**
 * Our Cache API class
 * @package cacheAPI
 */
class apcu_cache extends cache_api
{
	/**
	 * {@inheritDoc}
	 */
	public function isSupported($test = false)
	{
		$supported = function_exists('apcu_fetch') && function_exists('apcu_store');

		if ($test)
			return $supported;
		return parent::isSupported() && $supported;
	}

	/**
	 * {@inheritDoc}
	 */
	public function getData($key, $ttl = null)
	{
		$key = $this->prefix . strtr($key, ':/', '-_');

		return apcu_fetch($key . 'smf');
	}

	/**
	 * {@inheritDoc}
	 */
	public function putData($key, $value, $ttl = null)

This method seems to be duplicated in your project.

	{
		$key = $this->prefix . strtr($key, ':/', '-_');

		// An extended key is needed to counteract a bug in APC.
		if ($value === null)
			return apcu_delete($key . 'smf');

The expression apcu_delete($key . 'smf'); of type boolean|string[] adds the type string[] to the return on line 54 which is incompatible with the return type declared by the interface cache_api_interface::putData of type boolean.

		else
			return apcu_store($key . 'smf', $value, $ttl);

The expression apcu_store($key . 'smf', $value, $ttl); of type boolean|array adds the type array to the return on line 56 which is incompatible with the return type declared by the interface cache_api_interface::putData of type boolean.

	}

	/**
	 * {@inheritDoc}
	 */
	public function cleanCache($type = '')
	{
		$this->invalidateCache();
		return apcu_clear_cache();
	}
}

?>

It is not recommended to use PHP's closing tag ?> in files other than templates.