@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -1459,8 +1459,6 @@ |
||
1459 | 1459 | * Helper function for getEventRange, getEventProperties, getNewEventDatetimes, etc. |
1460 | 1460 | * |
1461 | 1461 | * @param array $row A database row representing an event from the calendar table |
1462 | - * @param string $date_format Tells timeformat() how to format the date values for display to the user |
|
1463 | - * @param string $time_format Tells timeformat() how to format the time values for display to the user |
|
1464 | 1462 | * @return array An array containing the start and end date and time properties for the event |
1465 | 1463 | */ |
1466 | 1464 | function buildEventDatetimes($row) |
@@ -13,8 +13,9 @@ discard block |
||
13 | 13 | * @version 2.1 Beta 3 |
14 | 14 | */ |
15 | 15 | |
16 | -if (!defined('SMF')) |
|
16 | +if (!defined('SMF')) { |
|
17 | 17 | die('No direct access...'); |
18 | +} |
|
18 | 19 | |
19 | 20 | /** |
20 | 21 | * Get all birthdays within the given time range. |
@@ -61,10 +62,11 @@ discard block |
||
61 | 62 | $bday = array(); |
62 | 63 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
63 | 64 | { |
64 | - if ($year_low != $year_high) |
|
65 | - $age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low; |
|
66 | - else |
|
67 | - $age_year = $year_low; |
|
65 | + if ($year_low != $year_high) { |
|
66 | + $age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low; |
|
67 | + } else { |
|
68 | + $age_year = $year_low; |
|
69 | + } |
|
68 | 70 | |
69 | 71 | $bday[$age_year . substr($row['birthdate'], 4)][] = array( |
70 | 72 | 'id' => $row['id_member'], |
@@ -76,8 +78,9 @@ discard block |
||
76 | 78 | $smcFunc['db_free_result']($result); |
77 | 79 | |
78 | 80 | // Set is_last, so the themes know when to stop placing separators. |
79 | - foreach ($bday as $mday => $array) |
|
80 | - $bday[$mday][count($array) - 1]['is_last'] = true; |
|
81 | + foreach ($bday as $mday => $array) { |
|
82 | + $bday[$mday][count($array) - 1]['is_last'] = true; |
|
83 | + } |
|
81 | 84 | |
82 | 85 | return $bday; |
83 | 86 | } |
@@ -125,8 +128,9 @@ discard block |
||
125 | 128 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
126 | 129 | { |
127 | 130 | // If the attached topic is not approved then for the moment pretend it doesn't exist |
128 | - if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved']) |
|
129 | - continue; |
|
131 | + if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved']) { |
|
132 | + continue; |
|
133 | + } |
|
130 | 134 | |
131 | 135 | // Force a censor of the title - as often these are used by others. |
132 | 136 | censorText($row['title'], $use_permissions ? false : true); |
@@ -137,8 +141,9 @@ discard block |
||
137 | 141 | list($start, $end, $allday, $span, $tz_abbrev) = buildEventDatetimes($row); |
138 | 142 | |
139 | 143 | // Sanity check |
140 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
141 | - continue; |
|
144 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
145 | + continue; |
|
146 | + } |
|
142 | 147 | |
143 | 148 | // Get set up for the loop |
144 | 149 | $start_object = date_create($row['start_date'] . (!$allday ? ' ' . $row['start_time'] : ''), timezone_open($tz)); |
@@ -202,8 +207,8 @@ discard block |
||
202 | 207 | ); |
203 | 208 | |
204 | 209 | // If we're using permissions (calendar pages?) then just ouput normal contextual style information. |
205 | - if ($use_permissions) |
|
206 | - $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
210 | + if ($use_permissions) { |
|
211 | + $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
207 | 212 | 'href' => $row['id_board'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0', |
208 | 213 | 'link' => $row['id_board'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>', |
209 | 214 | 'can_edit' => allowedTo('calendar_edit_any') || ($row['id_member'] == $user_info['id'] && allowedTo('calendar_edit_own')), |
@@ -211,9 +216,10 @@ discard block |
||
211 | 216 | 'can_export' => !empty($modSettings['cal_export']) ? true : false, |
212 | 217 | 'export_href' => $scripturl . '?action=calendar;sa=ical;eventid=' . $row['id_event'] . ';' . $context['session_var'] . '=' . $context['session_id'], |
213 | 218 | )); |
219 | + } |
|
214 | 220 | // Otherwise, this is going to be cached and the VIEWER'S permissions should apply... just put together some info. |
215 | - else |
|
216 | - $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
221 | + else { |
|
222 | + $events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array( |
|
217 | 223 | 'href' => $row['id_topic'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0', |
218 | 224 | 'link' => $row['id_topic'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>', |
219 | 225 | 'can_edit' => false, |
@@ -223,6 +229,7 @@ discard block |
||
223 | 229 | 'poster' => $row['id_member'], |
224 | 230 | 'allowed_groups' => explode(',', $row['member_groups']), |
225 | 231 | )); |
232 | + } |
|
226 | 233 | |
227 | 234 | date_add($cal_date, date_interval_create_from_date_string('1 day')); |
228 | 235 | } |
@@ -232,8 +239,9 @@ discard block |
||
232 | 239 | // If we're doing normal contextual data, go through and make things clear to the templates ;). |
233 | 240 | if ($use_permissions) |
234 | 241 | { |
235 | - foreach ($events as $mday => $array) |
|
236 | - $events[$mday][count($array) - 1]['is_last'] = true; |
|
242 | + foreach ($events as $mday => $array) { |
|
243 | + $events[$mday][count($array) - 1]['is_last'] = true; |
|
244 | + } |
|
237 | 245 | } |
238 | 246 | |
239 | 247 | return $events; |
@@ -251,11 +259,12 @@ discard block |
||
251 | 259 | global $smcFunc; |
252 | 260 | |
253 | 261 | // Get the lowest and highest dates for "all years". |
254 | - if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) |
|
255 | - $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec} |
|
262 | + if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) { |
|
263 | + $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec} |
|
256 | 264 | OR event_date BETWEEN {date:all_year_jan} AND {date:all_year_high}'; |
257 | - else |
|
258 | - $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}'; |
|
265 | + } else { |
|
266 | + $allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}'; |
|
267 | + } |
|
259 | 268 | |
260 | 269 | // Find some holidays... ;). |
261 | 270 | $result = $smcFunc['db_query']('', ' |
@@ -275,10 +284,11 @@ discard block |
||
275 | 284 | $holidays = array(); |
276 | 285 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
277 | 286 | { |
278 | - if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) |
|
279 | - $event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4); |
|
280 | - else |
|
281 | - $event_year = substr($low_date, 0, 4); |
|
287 | + if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) { |
|
288 | + $event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4); |
|
289 | + } else { |
|
290 | + $event_year = substr($low_date, 0, 4); |
|
291 | + } |
|
282 | 292 | |
283 | 293 | $holidays[$event_year . substr($row['event_date'], 4)][] = $row['title']; |
284 | 294 | } |
@@ -302,10 +312,12 @@ discard block |
||
302 | 312 | isAllowedTo('calendar_post'); |
303 | 313 | |
304 | 314 | // No board? No topic?!? |
305 | - if (empty($board)) |
|
306 | - fatal_lang_error('missing_board_id', false); |
|
307 | - if (empty($topic)) |
|
308 | - fatal_lang_error('missing_topic_id', false); |
|
315 | + if (empty($board)) { |
|
316 | + fatal_lang_error('missing_board_id', false); |
|
317 | + } |
|
318 | + if (empty($topic)) { |
|
319 | + fatal_lang_error('missing_topic_id', false); |
|
320 | + } |
|
309 | 321 | |
310 | 322 | // Administrator, Moderator, or owner. Period. |
311 | 323 | if (!allowedTo('admin_forum') && !allowedTo('moderate_board')) |
@@ -323,12 +335,14 @@ discard block |
||
323 | 335 | if ($row = $smcFunc['db_fetch_assoc']($result)) |
324 | 336 | { |
325 | 337 | // Not the owner of the topic. |
326 | - if ($row['id_member_started'] != $user_info['id']) |
|
327 | - fatal_lang_error('not_your_topic', 'user'); |
|
338 | + if ($row['id_member_started'] != $user_info['id']) { |
|
339 | + fatal_lang_error('not_your_topic', 'user'); |
|
340 | + } |
|
328 | 341 | } |
329 | 342 | // Topic/Board doesn't exist..... |
330 | - else |
|
331 | - fatal_lang_error('calendar_no_topic', 'general'); |
|
343 | + else { |
|
344 | + fatal_lang_error('calendar_no_topic', 'general'); |
|
345 | + } |
|
332 | 346 | $smcFunc['db_free_result']($result); |
333 | 347 | } |
334 | 348 | } |
@@ -416,14 +430,16 @@ discard block |
||
416 | 430 | if (!empty($calendarOptions['start_day'])) |
417 | 431 | { |
418 | 432 | $nShift -= $calendarOptions['start_day']; |
419 | - if ($nShift < 0) |
|
420 | - $nShift = 7 + $nShift; |
|
433 | + if ($nShift < 0) { |
|
434 | + $nShift = 7 + $nShift; |
|
435 | + } |
|
421 | 436 | } |
422 | 437 | |
423 | 438 | // Number of rows required to fit the month. |
424 | 439 | $nRows = floor(($month_info['last_day']['day_of_month'] + $nShift) / 7); |
425 | - if (($month_info['last_day']['day_of_month'] + $nShift) % 7) |
|
426 | - $nRows++; |
|
440 | + if (($month_info['last_day']['day_of_month'] + $nShift) % 7) { |
|
441 | + $nRows++; |
|
442 | + } |
|
427 | 443 | |
428 | 444 | // Fetch the arrays for birthdays, posted events, and holidays. |
429 | 445 | $bday = $calendarOptions['show_birthdays'] ? getBirthdayRange($month_info['first_day']['date'], $month_info['last_day']['date']) : array(); |
@@ -436,8 +452,9 @@ discard block |
||
436 | 452 | { |
437 | 453 | $calendarGrid['week_days'][] = $count; |
438 | 454 | $count++; |
439 | - if ($count == 7) |
|
440 | - $count = 0; |
|
455 | + if ($count == 7) { |
|
456 | + $count = 0; |
|
457 | + } |
|
441 | 458 | } |
442 | 459 | |
443 | 460 | // Iterate through each week. |
@@ -454,8 +471,9 @@ discard block |
||
454 | 471 | { |
455 | 472 | $nDay = ($nRow * 7) + $nCol - $nShift + 1; |
456 | 473 | |
457 | - if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month']) |
|
458 | - $nDay = 0; |
|
474 | + if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month']) { |
|
475 | + $nDay = 0; |
|
476 | + } |
|
459 | 477 | |
460 | 478 | $date = sprintf('%04d-%02d-%02d', $year, $month, $nDay); |
461 | 479 | |
@@ -473,8 +491,9 @@ discard block |
||
473 | 491 | } |
474 | 492 | |
475 | 493 | // What is the last day of the month? |
476 | - if ($is_previous === true) |
|
477 | - $calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month']; |
|
494 | + if ($is_previous === true) { |
|
495 | + $calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month']; |
|
496 | + } |
|
478 | 497 | |
479 | 498 | // We'll use the shift in the template. |
480 | 499 | $calendarGrid['shift'] = $nShift; |
@@ -508,8 +527,9 @@ discard block |
||
508 | 527 | { |
509 | 528 | // Here we offset accordingly to get things to the real start of a week. |
510 | 529 | $date_diff = $day_of_week - $calendarOptions['start_day']; |
511 | - if ($date_diff < 0) |
|
512 | - $date_diff += 7; |
|
530 | + if ($date_diff < 0) { |
|
531 | + $date_diff += 7; |
|
532 | + } |
|
513 | 533 | $new_timestamp = mktime(0, 0, 0, $month, $day, $year) - $date_diff * 86400; |
514 | 534 | $day = (int) strftime('%d', $new_timestamp); |
515 | 535 | $month = (int) strftime('%m', $new_timestamp); |
@@ -660,8 +680,9 @@ discard block |
||
660 | 680 | // Holidays between now and now + days. |
661 | 681 | for ($i = $now; $i < $now + $days_for_index; $i += 86400) |
662 | 682 | { |
663 | - if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)])) |
|
664 | - $return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]); |
|
683 | + if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)])) { |
|
684 | + $return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]); |
|
685 | + } |
|
665 | 686 | } |
666 | 687 | |
667 | 688 | // Happy Birthday, guys and gals! |
@@ -670,8 +691,9 @@ discard block |
||
670 | 691 | $loop_date = strftime('%Y-%m-%d', $i); |
671 | 692 | if (isset($cached_data['birthdays'][$loop_date])) |
672 | 693 | { |
673 | - foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy) |
|
674 | - $cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date']; |
|
694 | + foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy) { |
|
695 | + $cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date']; |
|
696 | + } |
|
675 | 697 | $return_data['calendar_birthdays'] = array_merge($return_data['calendar_birthdays'], $cached_data['birthdays'][$loop_date]); |
676 | 698 | } |
677 | 699 | } |
@@ -683,8 +705,9 @@ discard block |
||
683 | 705 | $loop_date = strftime('%Y-%m-%d', $i); |
684 | 706 | |
685 | 707 | // No events today? Check the next day. |
686 | - if (empty($cached_data['events'][$loop_date])) |
|
687 | - continue; |
|
708 | + if (empty($cached_data['events'][$loop_date])) { |
|
709 | + continue; |
|
710 | + } |
|
688 | 711 | |
689 | 712 | // Loop through all events to add a few last-minute values. |
690 | 713 | foreach ($cached_data['events'][$loop_date] as $ev => $event) |
@@ -697,9 +720,9 @@ discard block |
||
697 | 720 | { |
698 | 721 | unset($cached_data['events'][$loop_date][$ev]); |
699 | 722 | continue; |
723 | + } else { |
|
724 | + $duplicates[$this_event['topic'] . $this_event['title']] = true; |
|
700 | 725 | } |
701 | - else |
|
702 | - $duplicates[$this_event['topic'] . $this_event['title']] = true; |
|
703 | 726 | |
704 | 727 | // Might be set to true afterwards, depending on the permissions. |
705 | 728 | $this_event['can_edit'] = false; |
@@ -707,15 +730,18 @@ discard block |
||
707 | 730 | $this_event['date'] = $loop_date; |
708 | 731 | } |
709 | 732 | |
710 | - if (!empty($cached_data['events'][$loop_date])) |
|
711 | - $return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]); |
|
733 | + if (!empty($cached_data['events'][$loop_date])) { |
|
734 | + $return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]); |
|
735 | + } |
|
712 | 736 | } |
713 | 737 | |
714 | 738 | // Mark the last item so that a list separator can be used in the template. |
715 | - for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++) |
|
716 | - $return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]); |
|
717 | - for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++) |
|
718 | - $return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]); |
|
739 | + for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++) { |
|
740 | + $return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]); |
|
741 | + } |
|
742 | + for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++) { |
|
743 | + $return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]); |
|
744 | + } |
|
719 | 745 | |
720 | 746 | return array( |
721 | 747 | 'data' => $return_data, |
@@ -763,37 +789,46 @@ discard block |
||
763 | 789 | if (isset($_POST['start_date'])) |
764 | 790 | { |
765 | 791 | $d = date_parse($_POST['start_date']); |
766 | - if (!empty($d['error_count']) || !empty($d['warning_count'])) |
|
767 | - fatal_lang_error('invalid_date', false); |
|
768 | - if (empty($d['year'])) |
|
769 | - fatal_lang_error('event_year_missing', false); |
|
770 | - if (empty($d['month'])) |
|
771 | - fatal_lang_error('event_month_missing', false); |
|
772 | - } |
|
773 | - elseif (isset($_POST['start_datetime'])) |
|
792 | + if (!empty($d['error_count']) || !empty($d['warning_count'])) { |
|
793 | + fatal_lang_error('invalid_date', false); |
|
794 | + } |
|
795 | + if (empty($d['year'])) { |
|
796 | + fatal_lang_error('event_year_missing', false); |
|
797 | + } |
|
798 | + if (empty($d['month'])) { |
|
799 | + fatal_lang_error('event_month_missing', false); |
|
800 | + } |
|
801 | + } elseif (isset($_POST['start_datetime'])) |
|
774 | 802 | { |
775 | 803 | $d = date_parse($_POST['start_datetime']); |
776 | - if (!empty($d['error_count']) || !empty($d['warning_count'])) |
|
777 | - fatal_lang_error('invalid_date', false); |
|
778 | - if (empty($d['year'])) |
|
779 | - fatal_lang_error('event_year_missing', false); |
|
780 | - if (empty($d['month'])) |
|
781 | - fatal_lang_error('event_month_missing', false); |
|
804 | + if (!empty($d['error_count']) || !empty($d['warning_count'])) { |
|
805 | + fatal_lang_error('invalid_date', false); |
|
806 | + } |
|
807 | + if (empty($d['year'])) { |
|
808 | + fatal_lang_error('event_year_missing', false); |
|
809 | + } |
|
810 | + if (empty($d['month'])) { |
|
811 | + fatal_lang_error('event_month_missing', false); |
|
812 | + } |
|
782 | 813 | } |
783 | 814 | // The 2.0 way |
784 | 815 | else |
785 | 816 | { |
786 | 817 | // No month? No year? |
787 | - if (!isset($_POST['month'])) |
|
788 | - fatal_lang_error('event_month_missing', false); |
|
789 | - if (!isset($_POST['year'])) |
|
790 | - fatal_lang_error('event_year_missing', false); |
|
818 | + if (!isset($_POST['month'])) { |
|
819 | + fatal_lang_error('event_month_missing', false); |
|
820 | + } |
|
821 | + if (!isset($_POST['year'])) { |
|
822 | + fatal_lang_error('event_year_missing', false); |
|
823 | + } |
|
791 | 824 | |
792 | 825 | // Check the month and year... |
793 | - if ($_POST['month'] < 1 || $_POST['month'] > 12) |
|
794 | - fatal_lang_error('invalid_month', false); |
|
795 | - if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear']) |
|
796 | - fatal_lang_error('invalid_year', false); |
|
826 | + if ($_POST['month'] < 1 || $_POST['month'] > 12) { |
|
827 | + fatal_lang_error('invalid_month', false); |
|
828 | + } |
|
829 | + if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear']) { |
|
830 | + fatal_lang_error('invalid_year', false); |
|
831 | + } |
|
797 | 832 | } |
798 | 833 | } |
799 | 834 | |
@@ -803,8 +838,9 @@ discard block |
||
803 | 838 | // If they want to us to calculate an end date, make sure it will fit in an acceptable range. |
804 | 839 | if (isset($_POST['span'])) |
805 | 840 | { |
806 | - if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan'])) |
|
807 | - fatal_lang_error('invalid_days_numb', false); |
|
841 | + if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan'])) { |
|
842 | + fatal_lang_error('invalid_days_numb', false); |
|
843 | + } |
|
808 | 844 | } |
809 | 845 | |
810 | 846 | // There is no need to validate the following values if we are just deleting the event. |
@@ -814,24 +850,29 @@ discard block |
||
814 | 850 | if (empty($_POST['start_date']) && empty($_POST['start_datetime'])) |
815 | 851 | { |
816 | 852 | // No day? |
817 | - if (!isset($_POST['day'])) |
|
818 | - fatal_lang_error('event_day_missing', false); |
|
853 | + if (!isset($_POST['day'])) { |
|
854 | + fatal_lang_error('event_day_missing', false); |
|
855 | + } |
|
819 | 856 | |
820 | 857 | // Bad day? |
821 | - if (!checkdate($_POST['month'], $_POST['day'], $_POST['year'])) |
|
822 | - fatal_lang_error('invalid_date', false); |
|
858 | + if (!checkdate($_POST['month'], $_POST['day'], $_POST['year'])) { |
|
859 | + fatal_lang_error('invalid_date', false); |
|
860 | + } |
|
823 | 861 | } |
824 | 862 | |
825 | - if (!isset($_POST['evtitle']) && !isset($_POST['subject'])) |
|
826 | - fatal_lang_error('event_title_missing', false); |
|
827 | - elseif (!isset($_POST['evtitle'])) |
|
828 | - $_POST['evtitle'] = $_POST['subject']; |
|
863 | + if (!isset($_POST['evtitle']) && !isset($_POST['subject'])) { |
|
864 | + fatal_lang_error('event_title_missing', false); |
|
865 | + } elseif (!isset($_POST['evtitle'])) { |
|
866 | + $_POST['evtitle'] = $_POST['subject']; |
|
867 | + } |
|
829 | 868 | |
830 | 869 | // No title? |
831 | - if ($smcFunc['htmltrim']($_POST['evtitle']) === '') |
|
832 | - fatal_lang_error('no_event_title', false); |
|
833 | - if ($smcFunc['strlen']($_POST['evtitle']) > 100) |
|
834 | - $_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100); |
|
870 | + if ($smcFunc['htmltrim']($_POST['evtitle']) === '') { |
|
871 | + fatal_lang_error('no_event_title', false); |
|
872 | + } |
|
873 | + if ($smcFunc['strlen']($_POST['evtitle']) > 100) { |
|
874 | + $_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100); |
|
875 | + } |
|
835 | 876 | $_POST['evtitle'] = str_replace(';', '', $_POST['evtitle']); |
836 | 877 | } |
837 | 878 | } |
@@ -858,8 +899,9 @@ discard block |
||
858 | 899 | ); |
859 | 900 | |
860 | 901 | // No results, return false. |
861 | - if ($smcFunc['db_num_rows'] === 0) |
|
862 | - return false; |
|
902 | + if ($smcFunc['db_num_rows'] === 0) { |
|
903 | + return false; |
|
904 | + } |
|
863 | 905 | |
864 | 906 | // Grab the results and return. |
865 | 907 | list ($poster) = $smcFunc['db_fetch_row']($request); |
@@ -995,8 +1037,9 @@ discard block |
||
995 | 1037 | call_integration_hook('integrate_modify_event', array($event_id, &$eventOptions, &$event_columns, &$event_parameters)); |
996 | 1038 | |
997 | 1039 | $column_clauses = array(); |
998 | - foreach ($event_columns as $col => $crit) |
|
999 | - $column_clauses[] = $col . ' = ' . $crit; |
|
1040 | + foreach ($event_columns as $col => $crit) { |
|
1041 | + $column_clauses[] = $col . ' = ' . $crit; |
|
1042 | + } |
|
1000 | 1043 | |
1001 | 1044 | $smcFunc['db_query']('', ' |
1002 | 1045 | UPDATE {db_prefix}calendar |
@@ -1081,8 +1124,9 @@ discard block |
||
1081 | 1124 | ); |
1082 | 1125 | |
1083 | 1126 | // If nothing returned, we are in poo, poo. |
1084 | - if ($smcFunc['db_num_rows']($request) === 0) |
|
1085 | - return false; |
|
1127 | + if ($smcFunc['db_num_rows']($request) === 0) { |
|
1128 | + return false; |
|
1129 | + } |
|
1086 | 1130 | |
1087 | 1131 | $row = $smcFunc['db_fetch_assoc']($request); |
1088 | 1132 | $smcFunc['db_free_result']($request); |
@@ -1090,8 +1134,9 @@ discard block |
||
1090 | 1134 | list($start, $end, $allday, $span, $tz_abbrev) = buildEventDatetimes($row); |
1091 | 1135 | |
1092 | 1136 | // Sanity check |
1093 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
1094 | - return false; |
|
1137 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
1138 | + return false; |
|
1139 | + } |
|
1095 | 1140 | |
1096 | 1141 | $return_value = array( |
1097 | 1142 | 'boards' => array(), |
@@ -1161,10 +1206,11 @@ discard block |
||
1161 | 1206 | $allday = isset($_REQUEST['allday']) ? 1 : (isset($_REQUEST['start_time']) ? 0 : 1); |
1162 | 1207 | $span = isset($_REQUEST['span']) && filter_var($_REQUEST['span'], FILTER_VALIDATE_INT, array('options' => array('min_range' => 0))) ? $_REQUEST['span'] : 1; |
1163 | 1208 | |
1164 | - if (!empty($_REQUEST['tz']) && in_array($_REQUEST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1165 | - $tz = $_REQUEST['tz']; |
|
1166 | - else |
|
1167 | - $tz = getUserTimezone(); |
|
1209 | + if (!empty($_REQUEST['tz']) && in_array($_REQUEST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1210 | + $tz = $_REQUEST['tz']; |
|
1211 | + } else { |
|
1212 | + $tz = getUserTimezone(); |
|
1213 | + } |
|
1168 | 1214 | |
1169 | 1215 | // Was the input given as individual parameters? |
1170 | 1216 | $start_year = isset($_REQUEST['year']) ? $_REQUEST['year'] : $today['year']; |
@@ -1275,24 +1321,27 @@ discard block |
||
1275 | 1321 | |
1276 | 1322 | // Set $span, in case we need it |
1277 | 1323 | $span = isset($eventOptions['span']) ? $eventOptions['span'] : (isset($_POST['span']) ? $_POST['span'] : 0); |
1278 | - if ($span > 0) |
|
1279 | - $span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1; |
|
1324 | + if ($span > 0) { |
|
1325 | + $span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1; |
|
1326 | + } |
|
1280 | 1327 | |
1281 | 1328 | // Define the timezone for this event, falling back to the default if not provided |
1282 | - if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1283 | - $tz = $eventOptions['tz']; |
|
1284 | - elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1285 | - $tz = $_POST['tz']; |
|
1286 | - else |
|
1287 | - $tz = getUserTimezone(); |
|
1329 | + if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1330 | + $tz = $eventOptions['tz']; |
|
1331 | + } elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1332 | + $tz = $_POST['tz']; |
|
1333 | + } else { |
|
1334 | + $tz = getUserTimezone(); |
|
1335 | + } |
|
1288 | 1336 | |
1289 | 1337 | // Is this supposed to be an all day event, or should it have specific start and end times? |
1290 | - if (isset($eventOptions['allday'])) |
|
1291 | - $allday = $eventOptions['allday']; |
|
1292 | - elseif (empty($_POST['allday'])) |
|
1293 | - $allday = false; |
|
1294 | - else |
|
1295 | - $allday = true; |
|
1338 | + if (isset($eventOptions['allday'])) { |
|
1339 | + $allday = $eventOptions['allday']; |
|
1340 | + } elseif (empty($_POST['allday'])) { |
|
1341 | + $allday = false; |
|
1342 | + } else { |
|
1343 | + $allday = true; |
|
1344 | + } |
|
1296 | 1345 | |
1297 | 1346 | // Input might come as individual parameters... |
1298 | 1347 | $start_year = isset($eventOptions['year']) ? $eventOptions['year'] : (isset($_POST['year']) ? $_POST['year'] : null); |
@@ -1319,10 +1368,12 @@ discard block |
||
1319 | 1368 | $end_time_string = isset($eventOptions['end_time']) ? $eventOptions['end_time'] : (isset($_POST['end_time']) ? $_POST['end_time'] : null); |
1320 | 1369 | |
1321 | 1370 | // If the date and time were given in separate strings, combine them |
1322 | - if (empty($start_string) && isset($start_date_string)) |
|
1323 | - $start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : ''); |
|
1324 | - if (empty($end_string) && isset($end_date_string)) |
|
1325 | - $end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : ''); |
|
1371 | + if (empty($start_string) && isset($start_date_string)) { |
|
1372 | + $start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : ''); |
|
1373 | + } |
|
1374 | + if (empty($end_string) && isset($end_date_string)) { |
|
1375 | + $end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : ''); |
|
1376 | + } |
|
1326 | 1377 | |
1327 | 1378 | // If some form of string input was given, override individually defined options with it |
1328 | 1379 | if (isset($start_string)) |
@@ -1413,10 +1464,11 @@ discard block |
||
1413 | 1464 | if ($start_object >= $end_object) |
1414 | 1465 | { |
1415 | 1466 | $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz); |
1416 | - if ($span > 0) |
|
1417 | - date_add($end_object, date_interval_create_from_date_string($span . ' days')); |
|
1418 | - else |
|
1419 | - date_add($end_object, date_interval_create_from_date_string('1 hour')); |
|
1467 | + if ($span > 0) { |
|
1468 | + date_add($end_object, date_interval_create_from_date_string($span . ' days')); |
|
1469 | + } else { |
|
1470 | + date_add($end_object, date_interval_create_from_date_string('1 hour')); |
|
1471 | + } |
|
1420 | 1472 | } |
1421 | 1473 | |
1422 | 1474 | // Is $end_object too late? |
@@ -1430,9 +1482,9 @@ discard block |
||
1430 | 1482 | { |
1431 | 1483 | $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz); |
1432 | 1484 | date_add($end_object, date_interval_create_from_date_string($modSettings['cal_maxspan'] . ' days')); |
1485 | + } else { |
|
1486 | + $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz); |
|
1433 | 1487 | } |
1434 | - else |
|
1435 | - $end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz); |
|
1436 | 1488 | } |
1437 | 1489 | } |
1438 | 1490 | |
@@ -1445,8 +1497,7 @@ discard block |
||
1445 | 1497 | $start_time = null; |
1446 | 1498 | $end_time = null; |
1447 | 1499 | $tz = null; |
1448 | - } |
|
1449 | - else |
|
1500 | + } else |
|
1450 | 1501 | { |
1451 | 1502 | $start_time = date_format($start_object, 'H:i:s'); |
1452 | 1503 | $end_time = date_format($end_object, 'H:i:s'); |
@@ -1469,19 +1520,22 @@ discard block |
||
1469 | 1520 | require_once($sourcedir . '/Subs.php'); |
1470 | 1521 | |
1471 | 1522 | // First, try to create a better date format, ignoring the "time" elements. |
1472 | - if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
1473 | - $date_format = '%F'; |
|
1474 | - else |
|
1475 | - $date_format = $matches[0]; |
|
1523 | + if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
1524 | + $date_format = '%F'; |
|
1525 | + } else { |
|
1526 | + $date_format = $matches[0]; |
|
1527 | + } |
|
1476 | 1528 | |
1477 | - if (empty($row['timezone'])) |
|
1478 | - $row['timezone'] = getUserTimezone(); |
|
1529 | + if (empty($row['timezone'])) { |
|
1530 | + $row['timezone'] = getUserTimezone(); |
|
1531 | + } |
|
1479 | 1532 | |
1480 | 1533 | // We want a fairly compact version of the time, but as close as possible to the user's settings. |
1481 | - if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
1482 | - $time_format = '%k:%M'; |
|
1483 | - else |
|
1484 | - $time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
1534 | + if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
1535 | + $time_format = '%k:%M'; |
|
1536 | + } else { |
|
1537 | + $time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
1538 | + } |
|
1485 | 1539 | |
1486 | 1540 | $allday = (empty($row['start_time']) || empty($row['end_time']) || empty($row['timezone']) || !in_array($row['timezone'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) ? true : false; |
1487 | 1541 | |
@@ -1527,8 +1581,9 @@ discard block |
||
1527 | 1581 | { |
1528 | 1582 | global $smcFunc, $context, $sourcedir, $user_info; |
1529 | 1583 | |
1530 | - if (is_null($id_member) && $user_info['is_guest'] == false) |
|
1531 | - $id_member = $context['user']['id']; |
|
1584 | + if (is_null($id_member) && $user_info['is_guest'] == false) { |
|
1585 | + $id_member = $context['user']['id']; |
|
1586 | + } |
|
1532 | 1587 | |
1533 | 1588 | if (isset($id_member)) |
1534 | 1589 | { |
@@ -1544,8 +1599,9 @@ discard block |
||
1544 | 1599 | $smcFunc['db_free_result']($request); |
1545 | 1600 | } |
1546 | 1601 | |
1547 | - if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) |
|
1548 | - $timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get(); |
|
1602 | + if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) { |
|
1603 | + $timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get(); |
|
1604 | + } |
|
1549 | 1605 | |
1550 | 1606 | return $timezone; |
1551 | 1607 | } |
@@ -1574,8 +1630,9 @@ discard block |
||
1574 | 1630 | ) |
1575 | 1631 | ); |
1576 | 1632 | $holidays = array(); |
1577 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1578 | - $holidays[] = $row; |
|
1633 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1634 | + $holidays[] = $row; |
|
1635 | + } |
|
1579 | 1636 | $smcFunc['db_free_result']($request); |
1580 | 1637 | |
1581 | 1638 | return $holidays; |
@@ -259,8 +259,8 @@ discard block |
||
259 | 259 | $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
260 | 260 | |
261 | 261 | $js_time_string = str_replace( |
262 | - array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
263 | - array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
262 | + array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
263 | + array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
264 | 264 | $time_string |
265 | 265 | ); |
266 | 266 | |
@@ -855,7 +855,7 @@ discard block |
||
855 | 855 | { |
856 | 856 | // It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat. |
857 | 857 | if ($i % 4 == 0) |
858 | - $parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function ($m) |
|
858 | + $parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function($m) |
|
859 | 859 | { |
860 | 860 | return '[html]' . preg_replace('~<br\s?/?' . '>~i', '<br /><br>', "$m[1]") . '[/html]'; |
861 | 861 | }, $parts[$i]); |
@@ -952,7 +952,7 @@ discard block |
||
952 | 952 | { |
953 | 953 | // Since, they don't belong here. Let's inform the user that they exist.. |
954 | 954 | if (!empty($topic)) |
955 | - $delete_url = $scripturl . '?action=post' .(!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp'; |
|
955 | + $delete_url = $scripturl . '?action=post' . (!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp'; |
|
956 | 956 | else |
957 | 957 | $delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp'; |
958 | 958 | |
@@ -960,7 +960,7 @@ discard block |
||
960 | 960 | $file_list = array(); |
961 | 961 | foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
962 | 962 | if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) |
963 | - $file_list[] = $attachment['name']; |
|
963 | + $file_list[] = $attachment['name']; |
|
964 | 964 | |
965 | 965 | $_SESSION['temp_attachments']['post']['files'] = $file_list; |
966 | 966 | $file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>'; |
@@ -968,7 +968,7 @@ discard block |
||
968 | 968 | if (!empty($_SESSION['temp_attachments']['post']['msg'])) |
969 | 969 | { |
970 | 970 | // We have a message id, so we can link back to the old topic they were trying to edit.. |
971 | - $goback_url = $scripturl . '?action=post' .(!empty($_SESSION['temp_attachments']['post']['msg']) ? (';msg=' . $_SESSION['temp_attachments']['post']['msg']) : '') . (!empty($_SESSION['temp_attachments']['post']['last_msg']) ? (';last_msg=' . $_SESSION['temp_attachments']['post']['last_msg']) : '') . ';topic=' . $_SESSION['temp_attachments']['post']['topic'] . ';additionalOptions'; |
|
971 | + $goback_url = $scripturl . '?action=post' . (!empty($_SESSION['temp_attachments']['post']['msg']) ? (';msg=' . $_SESSION['temp_attachments']['post']['msg']) : '') . (!empty($_SESSION['temp_attachments']['post']['last_msg']) ? (';last_msg=' . $_SESSION['temp_attachments']['post']['last_msg']) : '') . ';topic=' . $_SESSION['temp_attachments']['post']['topic'] . ';additionalOptions'; |
|
972 | 972 | |
973 | 973 | $post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list)); |
974 | 974 | $context['ignore_temp_attachments'] = true; |
@@ -1255,55 +1255,55 @@ discard block |
||
1255 | 1255 | foreach ($context['current_attachments'] as $key => $mock) |
1256 | 1256 | addInlineJavaScript(' |
1257 | 1257 | current_attachments.push({ |
1258 | - name: '. JavaScriptEscape($mock['name']) .', |
|
1259 | - size: '. $mock['size'] .', |
|
1260 | - attachID: '. $mock['attachID'] .', |
|
1261 | - approved: '. $mock['approved'] .', |
|
1262 | - type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') .', |
|
1263 | - thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) .' |
|
1258 | + name: '. JavaScriptEscape($mock['name']) . ', |
|
1259 | + size: '. $mock['size'] . ', |
|
1260 | + attachID: '. $mock['attachID'] . ', |
|
1261 | + approved: '. $mock['approved'] . ', |
|
1262 | + type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') . ', |
|
1263 | + thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) . ' |
|
1264 | 1264 | });', true); |
1265 | 1265 | } |
1266 | 1266 | |
1267 | 1267 | // File Upload. |
1268 | 1268 | if ($context['can_post_attachment']) |
1269 | 1269 | { |
1270 | - $acceptedFiles = implode(',', array_map(function($val) use($smcFunc) { return '.'. $smcFunc['htmltrim']($val);} , explode(',', $context['allowed_extensions']))); |
|
1270 | + $acceptedFiles = implode(',', array_map(function($val) use($smcFunc) { return '.' . $smcFunc['htmltrim']($val); } , explode(',', $context['allowed_extensions']))); |
|
1271 | 1271 | |
1272 | 1272 | loadJavaScriptFile('dropzone.min.js', array('defer' => true), 'smf_dropzone'); |
1273 | 1273 | loadJavaScriptFile('smf_fileUpload.js', array('defer' => true), 'smf_fileUpload'); |
1274 | 1274 | addInlineJavaScript(' |
1275 | 1275 | $(function() { |
1276 | 1276 | smf_fileUpload({ |
1277 | - dictDefaultMessage : '. JavaScriptEscape($txt['attach_drop_zone']) .', |
|
1278 | - dictFallbackMessage : '. JavaScriptEscape($txt['attach_drop_zone_no']) .', |
|
1279 | - dictCancelUpload : '. JavaScriptEscape($txt['modify_cancel']) .', |
|
1280 | - genericError: '. JavaScriptEscape($txt['attach_php_error']) .', |
|
1281 | - text_attachLeft: '. JavaScriptEscape($txt['attached_attachedLeft']) .', |
|
1282 | - text_deleteAttach: '. JavaScriptEscape($txt['attached_file_delete']) .', |
|
1283 | - text_attachDeleted: '. JavaScriptEscape($txt['attached_file_deleted']) .', |
|
1284 | - text_insertBBC: '. JavaScriptEscape($txt['attached_insertBBC']) .', |
|
1285 | - text_attachUploaded: '. JavaScriptEscape($txt['attached_file_uploaded']) .', |
|
1286 | - text_attach_unlimited: '. JavaScriptEscape($txt['attach_drop_unlimited']) .', |
|
1287 | - dictMaxFilesExceeded: '. JavaScriptEscape($txt['more_attachments_error']) .', |
|
1288 | - dictInvalidFileType: '. JavaScriptEscape(sprintf($txt['cant_upload_type'], $context['allowed_extensions'])) .', |
|
1289 | - dictFileTooBig: '. JavaScriptEscape(sprintf($txt['file_too_big'], comma_format($modSettings['attachmentSizeLimit'], 0))) .', |
|
1290 | - maxTotalSize: '. JavaScriptEscape($txt['attach_max_total_file_size_current']) .', |
|
1291 | - acceptedFiles: '. JavaScriptEscape($acceptedFiles) .', |
|
1292 | - maxFilesize: '. (!empty($modSettings['attachmentSizeLimit']) ? $modSettings['attachmentSizeLimit'] : 'null') .', |
|
1293 | - thumbnailWidth: '.(!empty($modSettings['attachmentThumbWidth']) ? $modSettings['attachmentThumbWidth'] : 'null') .', |
|
1294 | - thumbnailHeight: '.(!empty($modSettings['attachmentThumbHeight']) ? $modSettings['attachmentThumbHeight'] : 'null') .', |
|
1295 | - maxFiles: '. (!empty($context['num_allowed_attachments']) ? $context['num_allowed_attachments'] : 'null') .', |
|
1296 | - text_totalMaxSize: '. JavaScriptEscape($txt['attach_max_total_file_size_current']) .', |
|
1297 | - text_max_size_progress: '. JavaScriptEscape($txt['attach_max_size_progress']) .', |
|
1298 | - limitMultiFileUploadSize:'. round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)) * 1024 .', |
|
1299 | - maxLimitReferenceUploadSize: '. $modSettings['attachmentPostLimit'] * 1024 .', |
|
1277 | + dictDefaultMessage : '. JavaScriptEscape($txt['attach_drop_zone']) . ', |
|
1278 | + dictFallbackMessage : '. JavaScriptEscape($txt['attach_drop_zone_no']) . ', |
|
1279 | + dictCancelUpload : '. JavaScriptEscape($txt['modify_cancel']) . ', |
|
1280 | + genericError: '. JavaScriptEscape($txt['attach_php_error']) . ', |
|
1281 | + text_attachLeft: '. JavaScriptEscape($txt['attached_attachedLeft']) . ', |
|
1282 | + text_deleteAttach: '. JavaScriptEscape($txt['attached_file_delete']) . ', |
|
1283 | + text_attachDeleted: '. JavaScriptEscape($txt['attached_file_deleted']) . ', |
|
1284 | + text_insertBBC: '. JavaScriptEscape($txt['attached_insertBBC']) . ', |
|
1285 | + text_attachUploaded: '. JavaScriptEscape($txt['attached_file_uploaded']) . ', |
|
1286 | + text_attach_unlimited: '. JavaScriptEscape($txt['attach_drop_unlimited']) . ', |
|
1287 | + dictMaxFilesExceeded: '. JavaScriptEscape($txt['more_attachments_error']) . ', |
|
1288 | + dictInvalidFileType: '. JavaScriptEscape(sprintf($txt['cant_upload_type'], $context['allowed_extensions'])) . ', |
|
1289 | + dictFileTooBig: '. JavaScriptEscape(sprintf($txt['file_too_big'], comma_format($modSettings['attachmentSizeLimit'], 0))) . ', |
|
1290 | + maxTotalSize: '. JavaScriptEscape($txt['attach_max_total_file_size_current']) . ', |
|
1291 | + acceptedFiles: '. JavaScriptEscape($acceptedFiles) . ', |
|
1292 | + maxFilesize: '. (!empty($modSettings['attachmentSizeLimit']) ? $modSettings['attachmentSizeLimit'] : 'null') . ', |
|
1293 | + thumbnailWidth: '.(!empty($modSettings['attachmentThumbWidth']) ? $modSettings['attachmentThumbWidth'] : 'null') . ', |
|
1294 | + thumbnailHeight: '.(!empty($modSettings['attachmentThumbHeight']) ? $modSettings['attachmentThumbHeight'] : 'null') . ', |
|
1295 | + maxFiles: '. (!empty($context['num_allowed_attachments']) ? $context['num_allowed_attachments'] : 'null') . ', |
|
1296 | + text_totalMaxSize: '. JavaScriptEscape($txt['attach_max_total_file_size_current']) . ', |
|
1297 | + text_max_size_progress: '. JavaScriptEscape($txt['attach_max_size_progress']) . ', |
|
1298 | + limitMultiFileUploadSize:'. round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)) * 1024 . ', |
|
1299 | + maxLimitReferenceUploadSize: '. $modSettings['attachmentPostLimit'] * 1024 . ', |
|
1300 | 1300 | }); |
1301 | 1301 | });', true); |
1302 | 1302 | } |
1303 | 1303 | |
1304 | 1304 | // Knowing the current board ID might be handy. |
1305 | 1305 | addInlineJavaScript(' |
1306 | - var current_board = '. (empty($context['current_board']) ? 'null' : $context['current_board']) .';', false); |
|
1306 | + var current_board = '. (empty($context['current_board']) ? 'null' : $context['current_board']) . ';', false); |
|
1307 | 1307 | |
1308 | 1308 | // Finally, load the template. |
1309 | 1309 | if (!isset($_REQUEST['xml'])) |
@@ -1721,7 +1721,7 @@ discard block |
||
1721 | 1721 | } |
1722 | 1722 | |
1723 | 1723 | // Coming from the quickReply? |
1724 | - if(isset($_POST['quickReply'])) |
|
1724 | + if (isset($_POST['quickReply'])) |
|
1725 | 1725 | $_POST['message'] = $_POST['quickReply']; |
1726 | 1726 | |
1727 | 1727 | // Check the subject and message. |
@@ -2510,7 +2510,7 @@ discard block |
||
2510 | 2510 | FROM {db_prefix}messages AS m |
2511 | 2511 | LEFT JOIN {db_prefix}members AS mem ON (mem.id_member = m.id_member) |
2512 | 2512 | WHERE m.id_topic = {int:current_topic}' . (isset($_REQUEST['msg']) ? ' |
2513 | - AND m.id_msg < {int:id_msg}' : '') .(!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : ' |
|
2513 | + AND m.id_msg < {int:id_msg}' : '') . (!$modSettings['postmod_active'] || allowedTo('approve_posts') ? '' : ' |
|
2514 | 2514 | AND m.approved = {int:approved}') . ' |
2515 | 2515 | ORDER BY m.id_msg DESC' . $limit, |
2516 | 2516 | array( |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 3 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Handles showing the post screen, loading the post to be modified, and loading any post quoted. |
@@ -35,12 +36,14 @@ discard block |
||
35 | 36 | global $sourcedir, $smcFunc, $language; |
36 | 37 | |
37 | 38 | loadLanguage('Post'); |
38 | - if (!empty($modSettings['drafts_post_enabled'])) |
|
39 | - loadLanguage('Drafts'); |
|
39 | + if (!empty($modSettings['drafts_post_enabled'])) { |
|
40 | + loadLanguage('Drafts'); |
|
41 | + } |
|
40 | 42 | |
41 | 43 | // You can't reply with a poll... hacker. |
42 | - if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) |
|
43 | - unset($_REQUEST['poll']); |
|
44 | + if (isset($_REQUEST['poll']) && !empty($topic) && !isset($_REQUEST['msg'])) { |
|
45 | + unset($_REQUEST['poll']); |
|
46 | + } |
|
44 | 47 | |
45 | 48 | // Posting an event? |
46 | 49 | $context['make_event'] = isset($_REQUEST['calendar']); |
@@ -55,8 +58,9 @@ discard block |
||
55 | 58 | $context['auto_notify'] = !empty($context['notify_prefs']['msg_auto_notify']); |
56 | 59 | |
57 | 60 | // You must be posting to *some* board. |
58 | - if (empty($board) && !$context['make_event']) |
|
59 | - fatal_lang_error('no_board', false); |
|
61 | + if (empty($board) && !$context['make_event']) { |
|
62 | + fatal_lang_error('no_board', false); |
|
63 | + } |
|
60 | 64 | |
61 | 65 | require_once($sourcedir . '/Subs-Post.php'); |
62 | 66 | |
@@ -79,10 +83,11 @@ discard block |
||
79 | 83 | array( |
80 | 84 | 'msg' => (int) $_REQUEST['msg'], |
81 | 85 | )); |
82 | - if ($smcFunc['db_num_rows']($request) != 1) |
|
83 | - unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']); |
|
84 | - else |
|
85 | - list ($topic) = $smcFunc['db_fetch_row']($request); |
|
86 | + if ($smcFunc['db_num_rows']($request) != 1) { |
|
87 | + unset($_REQUEST['msg'], $_POST['msg'], $_GET['msg']); |
|
88 | + } else { |
|
89 | + list ($topic) = $smcFunc['db_fetch_row']($request); |
|
90 | + } |
|
86 | 91 | $smcFunc['db_free_result']($request); |
87 | 92 | } |
88 | 93 | |
@@ -109,33 +114,36 @@ discard block |
||
109 | 114 | $smcFunc['db_free_result']($request); |
110 | 115 | |
111 | 116 | // If this topic already has a poll, they sure can't add another. |
112 | - if (isset($_REQUEST['poll']) && $pollID > 0) |
|
113 | - unset($_REQUEST['poll']); |
|
117 | + if (isset($_REQUEST['poll']) && $pollID > 0) { |
|
118 | + unset($_REQUEST['poll']); |
|
119 | + } |
|
114 | 120 | |
115 | 121 | if (empty($_REQUEST['msg'])) |
116 | 122 | { |
117 | - if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) |
|
118 | - is_not_guest(); |
|
123 | + if ($user_info['is_guest'] && !allowedTo('post_reply_any') && (!$modSettings['postmod_active'] || !allowedTo('post_unapproved_replies_any'))) { |
|
124 | + is_not_guest(); |
|
125 | + } |
|
119 | 126 | |
120 | 127 | // By default the reply will be approved... |
121 | 128 | $context['becomes_approved'] = true; |
122 | 129 | if ($id_member_poster != $user_info['id'] || $user_info['is_guest']) |
123 | 130 | { |
124 | - if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) |
|
125 | - $context['becomes_approved'] = false; |
|
126 | - else |
|
127 | - isAllowedTo('post_reply_any'); |
|
128 | - } |
|
129 | - elseif (!allowedTo('post_reply_any')) |
|
131 | + if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) { |
|
132 | + $context['becomes_approved'] = false; |
|
133 | + } else { |
|
134 | + isAllowedTo('post_reply_any'); |
|
135 | + } |
|
136 | + } elseif (!allowedTo('post_reply_any')) |
|
130 | 137 | { |
131 | - if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) |
|
132 | - $context['becomes_approved'] = false; |
|
133 | - else |
|
134 | - isAllowedTo('post_reply_own'); |
|
138 | + if ($modSettings['postmod_active'] && ((allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) || allowedTo('post_unapproved_replies_any'))) { |
|
139 | + $context['becomes_approved'] = false; |
|
140 | + } else { |
|
141 | + isAllowedTo('post_reply_own'); |
|
142 | + } |
|
135 | 143 | } |
144 | + } else { |
|
145 | + $context['becomes_approved'] = true; |
|
136 | 146 | } |
137 | - else |
|
138 | - $context['becomes_approved'] = true; |
|
139 | 147 | |
140 | 148 | $context['can_lock'] = allowedTo('lock_any') || ($user_info['id'] == $id_member_poster && allowedTo('lock_own')); |
141 | 149 | $context['can_sticky'] = allowedTo('make_sticky'); |
@@ -147,18 +155,19 @@ discard block |
||
147 | 155 | $context['sticky'] = isset($_REQUEST['sticky']) ? !empty($_REQUEST['sticky']) : $sticky; |
148 | 156 | |
149 | 157 | // Check whether this is a really old post being bumped... |
150 | - if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) |
|
151 | - $post_errors[] = array('old_topic', array($modSettings['oldTopicDays'])); |
|
152 | - } |
|
153 | - else |
|
158 | + if (!empty($modSettings['oldTopicDays']) && $lastPostTime + $modSettings['oldTopicDays'] * 86400 < time() && empty($sticky) && !isset($_REQUEST['subject'])) { |
|
159 | + $post_errors[] = array('old_topic', array($modSettings['oldTopicDays'])); |
|
160 | + } |
|
161 | + } else |
|
154 | 162 | { |
155 | 163 | $context['becomes_approved'] = true; |
156 | 164 | if ((!$context['make_event'] || !empty($board))) |
157 | 165 | { |
158 | - if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) |
|
159 | - $context['becomes_approved'] = false; |
|
160 | - else |
|
161 | - isAllowedTo('post_new'); |
|
166 | + if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) { |
|
167 | + $context['becomes_approved'] = false; |
|
168 | + } else { |
|
169 | + isAllowedTo('post_new'); |
|
170 | + } |
|
162 | 171 | } |
163 | 172 | |
164 | 173 | $locked = 0; |
@@ -196,20 +205,24 @@ discard block |
||
196 | 205 | } |
197 | 206 | |
198 | 207 | // Don't allow a post if it's locked and you aren't all powerful. |
199 | - if ($locked && !allowedTo('moderate_board')) |
|
200 | - fatal_lang_error('topic_locked', false); |
|
208 | + if ($locked && !allowedTo('moderate_board')) { |
|
209 | + fatal_lang_error('topic_locked', false); |
|
210 | + } |
|
201 | 211 | // Check the users permissions - is the user allowed to add or post a poll? |
202 | 212 | if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1') |
203 | 213 | { |
204 | 214 | // New topic, new poll. |
205 | - if (empty($topic)) |
|
206 | - isAllowedTo('poll_post'); |
|
215 | + if (empty($topic)) { |
|
216 | + isAllowedTo('poll_post'); |
|
217 | + } |
|
207 | 218 | // This is an old topic - but it is yours! Can you add to it? |
208 | - elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) |
|
209 | - isAllowedTo('poll_add_own'); |
|
219 | + elseif ($user_info['id'] == $id_member_poster && !allowedTo('poll_add_any')) { |
|
220 | + isAllowedTo('poll_add_own'); |
|
221 | + } |
|
210 | 222 | // If you're not the owner, can you add to any poll? |
211 | - else |
|
212 | - isAllowedTo('poll_add_any'); |
|
223 | + else { |
|
224 | + isAllowedTo('poll_add_any'); |
|
225 | + } |
|
213 | 226 | |
214 | 227 | require_once($sourcedir . '/Subs-Members.php'); |
215 | 228 | $allowedVoteGroups = groupsAllowedTo('poll_vote', $board); |
@@ -238,8 +251,9 @@ discard block |
||
238 | 251 | if ($context['make_event']) |
239 | 252 | { |
240 | 253 | // They might want to pick a board. |
241 | - if (!isset($context['current_board'])) |
|
242 | - $context['current_board'] = 0; |
|
254 | + if (!isset($context['current_board'])) { |
|
255 | + $context['current_board'] = 0; |
|
256 | + } |
|
243 | 257 | |
244 | 258 | // Start loading up the event info. |
245 | 259 | $context['event'] = array(); |
@@ -253,10 +267,11 @@ discard block |
||
253 | 267 | isAllowedTo('calendar_post'); |
254 | 268 | |
255 | 269 | // We want a fairly compact version of the time, but as close as possible to the user's settings. |
256 | - if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
257 | - $time_string = '%k:%M'; |
|
258 | - else |
|
259 | - $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
270 | + if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
271 | + $time_string = '%k:%M'; |
|
272 | + } else { |
|
273 | + $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
274 | + } |
|
260 | 275 | |
261 | 276 | $js_time_string = str_replace( |
262 | 277 | array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
@@ -278,8 +293,7 @@ discard block |
||
278 | 293 | require_once($sourcedir . '/Subs-Calendar.php'); |
279 | 294 | $eventProperties = getEventProperties($context['event']['id']); |
280 | 295 | $context['event'] = array_merge($context['event'], $eventProperties); |
281 | - } |
|
282 | - else |
|
296 | + } else |
|
283 | 297 | { |
284 | 298 | // Get the current event information. |
285 | 299 | require_once($sourcedir . '/Subs-Calendar.php'); |
@@ -287,15 +301,18 @@ discard block |
||
287 | 301 | $context['event'] = array_merge($context['event'], $eventProperties); |
288 | 302 | |
289 | 303 | // Make sure the year and month are in the valid range. |
290 | - if ($context['event']['month'] < 1 || $context['event']['month'] > 12) |
|
291 | - fatal_lang_error('invalid_month', false); |
|
292 | - if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) |
|
293 | - fatal_lang_error('invalid_year', false); |
|
304 | + if ($context['event']['month'] < 1 || $context['event']['month'] > 12) { |
|
305 | + fatal_lang_error('invalid_month', false); |
|
306 | + } |
|
307 | + if ($context['event']['year'] < $modSettings['cal_minyear'] || $context['event']['year'] > $modSettings['cal_maxyear']) { |
|
308 | + fatal_lang_error('invalid_year', false); |
|
309 | + } |
|
294 | 310 | |
295 | 311 | // Get a list of boards they can post in. |
296 | 312 | $boards = boardsAllowedTo('post_new'); |
297 | - if (empty($boards)) |
|
298 | - fatal_lang_error('cannot_post_new', 'user'); |
|
313 | + if (empty($boards)) { |
|
314 | + fatal_lang_error('cannot_post_new', 'user'); |
|
315 | + } |
|
299 | 316 | |
300 | 317 | // Load a list of boards for this event in the context. |
301 | 318 | require_once($sourcedir . '/Subs-MessageIndex.php'); |
@@ -414,10 +431,11 @@ discard block |
||
414 | 431 | |
415 | 432 | if (!empty($context['new_replies'])) |
416 | 433 | { |
417 | - if ($context['new_replies'] == 1) |
|
418 | - $txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply']; |
|
419 | - else |
|
420 | - $txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']); |
|
434 | + if ($context['new_replies'] == 1) { |
|
435 | + $txt['error_new_replies'] = isset($_GET['last_msg']) ? $txt['error_new_reply_reading'] : $txt['error_new_reply']; |
|
436 | + } else { |
|
437 | + $txt['error_new_replies'] = sprintf(isset($_GET['last_msg']) ? $txt['error_new_replies_reading'] : $txt['error_new_replies'], $context['new_replies']); |
|
438 | + } |
|
421 | 439 | |
422 | 440 | $post_errors[] = 'new_replies'; |
423 | 441 | |
@@ -429,9 +447,9 @@ discard block |
||
429 | 447 | // Get a response prefix (like 'Re:') in the default forum language. |
430 | 448 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix'))) |
431 | 449 | { |
432 | - if ($language === $user_info['language']) |
|
433 | - $context['response_prefix'] = $txt['response_prefix']; |
|
434 | - else |
|
450 | + if ($language === $user_info['language']) { |
|
451 | + $context['response_prefix'] = $txt['response_prefix']; |
|
452 | + } else |
|
435 | 453 | { |
436 | 454 | loadLanguage('index', $language, false); |
437 | 455 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -444,8 +462,9 @@ discard block |
||
444 | 462 | // Do we have a body, but an error happened. |
445 | 463 | if (isset($_REQUEST['message']) || isset($_REQUEST['quickReply']) || !empty($context['post_error'])) |
446 | 464 | { |
447 | - if (isset($_REQUEST['quickReply'])) |
|
448 | - $_REQUEST['message'] = $_REQUEST['quickReply']; |
|
465 | + if (isset($_REQUEST['quickReply'])) { |
|
466 | + $_REQUEST['message'] = $_REQUEST['quickReply']; |
|
467 | + } |
|
449 | 468 | |
450 | 469 | // Validate inputs. |
451 | 470 | if (empty($context['post_error'])) |
@@ -453,15 +472,17 @@ discard block |
||
453 | 472 | // This means they didn't click Post and get an error. |
454 | 473 | $really_previewing = true; |
455 | 474 | |
456 | - } |
|
457 | - else |
|
475 | + } else |
|
458 | 476 | { |
459 | - if (!isset($_REQUEST['subject'])) |
|
460 | - $_REQUEST['subject'] = ''; |
|
461 | - if (!isset($_REQUEST['message'])) |
|
462 | - $_REQUEST['message'] = ''; |
|
463 | - if (!isset($_REQUEST['icon'])) |
|
464 | - $_REQUEST['icon'] = 'xx'; |
|
477 | + if (!isset($_REQUEST['subject'])) { |
|
478 | + $_REQUEST['subject'] = ''; |
|
479 | + } |
|
480 | + if (!isset($_REQUEST['message'])) { |
|
481 | + $_REQUEST['message'] = ''; |
|
482 | + } |
|
483 | + if (!isset($_REQUEST['icon'])) { |
|
484 | + $_REQUEST['icon'] = 'xx'; |
|
485 | + } |
|
465 | 486 | |
466 | 487 | // They are previewing if they asked to preview (i.e. came from quick reply). |
467 | 488 | $really_previewing = !empty($_POST['preview']); |
@@ -477,8 +498,9 @@ discard block |
||
477 | 498 | $form_message = $smcFunc['htmlspecialchars']($_REQUEST['message'], ENT_QUOTES); |
478 | 499 | |
479 | 500 | // Make sure the subject isn't too long - taking into account special characters. |
480 | - if ($smcFunc['strlen']($form_subject) > 100) |
|
481 | - $form_subject = $smcFunc['substr']($form_subject, 0, 100); |
|
501 | + if ($smcFunc['strlen']($form_subject) > 100) { |
|
502 | + $form_subject = $smcFunc['substr']($form_subject, 0, 100); |
|
503 | + } |
|
482 | 504 | |
483 | 505 | if (isset($_REQUEST['poll'])) |
484 | 506 | { |
@@ -490,8 +512,9 @@ discard block |
||
490 | 512 | $_POST['options'] = empty($_POST['options']) ? array() : htmlspecialchars__recursive($_POST['options']); |
491 | 513 | foreach ($_POST['options'] as $option) |
492 | 514 | { |
493 | - if (trim($option) == '') |
|
494 | - continue; |
|
515 | + if (trim($option) == '') { |
|
516 | + continue; |
|
517 | + } |
|
495 | 518 | |
496 | 519 | $context['choices'][] = array( |
497 | 520 | 'id' => $choice_id++, |
@@ -553,13 +576,14 @@ discard block |
||
553 | 576 | $context['preview_subject'] = $form_subject; |
554 | 577 | |
555 | 578 | censorText($context['preview_subject']); |
579 | + } else { |
|
580 | + $context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>'; |
|
556 | 581 | } |
557 | - else |
|
558 | - $context['preview_subject'] = '<em>' . $txt['no_subject'] . '</em>'; |
|
559 | 582 | |
560 | 583 | // Protect any CDATA blocks. |
561 | - if (isset($_REQUEST['xml'])) |
|
562 | - $context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]><![CDATA[>')); |
|
584 | + if (isset($_REQUEST['xml'])) { |
|
585 | + $context['preview_message'] = strtr($context['preview_message'], array(']]>' => ']]]]>< == 0) |
|
602 | - fatal_lang_error('no_board', false); |
|
625 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
626 | + fatal_lang_error('no_board', false); |
|
627 | + } |
|
603 | 628 | $row = $smcFunc['db_fetch_assoc']($request); |
604 | 629 | |
605 | 630 | $attachment_stuff = array($row); |
606 | - while ($row2 = $smcFunc['db_fetch_assoc']($request)) |
|
607 | - $attachment_stuff[] = $row2; |
|
631 | + while ($row2 = $smcFunc['db_fetch_assoc']($request)) { |
|
632 | + $attachment_stuff[] = $row2; |
|
633 | + } |
|
608 | 634 | $smcFunc['db_free_result']($request); |
609 | 635 | |
610 | 636 | if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any')) |
611 | 637 | { |
612 | 638 | // Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public. |
613 | - if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) |
|
614 | - fatal_lang_error('modify_post_time_passed', false); |
|
615 | - elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) |
|
616 | - isAllowedTo('modify_replies'); |
|
617 | - else |
|
618 | - isAllowedTo('modify_own'); |
|
639 | + if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) { |
|
640 | + fatal_lang_error('modify_post_time_passed', false); |
|
641 | + } elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) { |
|
642 | + isAllowedTo('modify_replies'); |
|
643 | + } else { |
|
644 | + isAllowedTo('modify_own'); |
|
645 | + } |
|
646 | + } elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) { |
|
647 | + isAllowedTo('modify_replies'); |
|
648 | + } else { |
|
649 | + isAllowedTo('modify_any'); |
|
619 | 650 | } |
620 | - elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) |
|
621 | - isAllowedTo('modify_replies'); |
|
622 | - else |
|
623 | - isAllowedTo('modify_any'); |
|
624 | 651 | |
625 | 652 | if ($context['can_announce'] && !empty($row['id_action'])) |
626 | 653 | { |
@@ -644,8 +671,9 @@ discard block |
||
644 | 671 | |
645 | 672 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
646 | 673 | { |
647 | - if ($row['filesize'] <= 0) |
|
648 | - continue; |
|
674 | + if ($row['filesize'] <= 0) { |
|
675 | + continue; |
|
676 | + } |
|
649 | 677 | $context['current_attachments'][$row['id_attach']] = array( |
650 | 678 | 'name' => $smcFunc['htmlspecialchars']($row['filename']), |
651 | 679 | 'size' => $row['filesize'], |
@@ -715,29 +743,32 @@ discard block |
||
715 | 743 | ) |
716 | 744 | ); |
717 | 745 | // The message they were trying to edit was most likely deleted. |
718 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
719 | - fatal_lang_error('no_message', false); |
|
746 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
747 | + fatal_lang_error('no_message', false); |
|
748 | + } |
|
720 | 749 | $row = $smcFunc['db_fetch_assoc']($request); |
721 | 750 | |
722 | 751 | $attachment_stuff = array($row); |
723 | - while ($row2 = $smcFunc['db_fetch_assoc']($request)) |
|
724 | - $attachment_stuff[] = $row2; |
|
752 | + while ($row2 = $smcFunc['db_fetch_assoc']($request)) { |
|
753 | + $attachment_stuff[] = $row2; |
|
754 | + } |
|
725 | 755 | $smcFunc['db_free_result']($request); |
726 | 756 | |
727 | 757 | if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any')) |
728 | 758 | { |
729 | 759 | // Give an extra five minutes over the disable time threshold, so they can type - assuming the post is public. |
730 | - if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) |
|
731 | - fatal_lang_error('modify_post_time_passed', false); |
|
732 | - elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) |
|
733 | - isAllowedTo('modify_replies'); |
|
734 | - else |
|
735 | - isAllowedTo('modify_own'); |
|
760 | + if ($row['approved'] && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) { |
|
761 | + fatal_lang_error('modify_post_time_passed', false); |
|
762 | + } elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_own')) { |
|
763 | + isAllowedTo('modify_replies'); |
|
764 | + } else { |
|
765 | + isAllowedTo('modify_own'); |
|
766 | + } |
|
767 | + } elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) { |
|
768 | + isAllowedTo('modify_replies'); |
|
769 | + } else { |
|
770 | + isAllowedTo('modify_any'); |
|
736 | 771 | } |
737 | - elseif ($row['id_member_poster'] == $user_info['id'] && !allowedTo('modify_any')) |
|
738 | - isAllowedTo('modify_replies'); |
|
739 | - else |
|
740 | - isAllowedTo('modify_any'); |
|
741 | 772 | |
742 | 773 | if ($context['can_announce'] && !empty($row['id_action'])) |
743 | 774 | { |
@@ -764,15 +795,17 @@ discard block |
||
764 | 795 | $context['icon'] = $row['icon']; |
765 | 796 | |
766 | 797 | // Show an "approve" box if the user can approve it, and the message isn't approved. |
767 | - if (!$row['approved'] && !$context['show_approval']) |
|
768 | - $context['show_approval'] = allowedTo('approve_posts'); |
|
798 | + if (!$row['approved'] && !$context['show_approval']) { |
|
799 | + $context['show_approval'] = allowedTo('approve_posts'); |
|
800 | + } |
|
769 | 801 | |
770 | 802 | // Sort the attachments so they are in the order saved |
771 | 803 | $temp = array(); |
772 | 804 | foreach ($attachment_stuff as $attachment) |
773 | 805 | { |
774 | - if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) |
|
775 | - $temp[$attachment['id_attach']] = $attachment; |
|
806 | + if ($attachment['filesize'] >= 0 && !empty($modSettings['attachmentEnable'])) { |
|
807 | + $temp[$attachment['id_attach']] = $attachment; |
|
808 | + } |
|
776 | 809 | |
777 | 810 | } |
778 | 811 | ksort($temp); |
@@ -834,14 +867,16 @@ discard block |
||
834 | 867 | 'is_approved' => 1, |
835 | 868 | ) |
836 | 869 | ); |
837 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
838 | - fatal_lang_error('quoted_post_deleted', false); |
|
870 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
871 | + fatal_lang_error('quoted_post_deleted', false); |
|
872 | + } |
|
839 | 873 | list ($form_subject, $mname, $mdate, $form_message) = $smcFunc['db_fetch_row']($request); |
840 | 874 | $smcFunc['db_free_result']($request); |
841 | 875 | |
842 | 876 | // Add 'Re: ' to the front of the quoted subject. |
843 | - if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) |
|
844 | - $form_subject = $context['response_prefix'] . $form_subject; |
|
877 | + if (trim($context['response_prefix']) != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) { |
|
878 | + $form_subject = $context['response_prefix'] . $form_subject; |
|
879 | + } |
|
845 | 880 | |
846 | 881 | // Censor the message and subject. |
847 | 882 | censorText($form_message); |
@@ -854,10 +889,11 @@ discard block |
||
854 | 889 | for ($i = 0, $n = count($parts); $i < $n; $i++) |
855 | 890 | { |
856 | 891 | // It goes 0 = outside, 1 = begin tag, 2 = inside, 3 = close tag, repeat. |
857 | - if ($i % 4 == 0) |
|
858 | - $parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function ($m) |
|
892 | + if ($i % 4 == 0) { |
|
893 | + $parts[$i] = preg_replace_callback('~\[html\](.+?)\[/html\]~is', function ($m) |
|
859 | 894 | { |
860 | 895 | return '[html]' . preg_replace('~<br\s?/?' . '>~i', '<br /><br>', "$m[1]") . '[/html]'; |
896 | + } |
|
861 | 897 | }, $parts[$i]); |
862 | 898 | } |
863 | 899 | $form_message = implode('', $parts); |
@@ -866,8 +902,9 @@ discard block |
||
866 | 902 | $form_message = preg_replace('~<br ?/?' . '>~i', "\n", $form_message); |
867 | 903 | |
868 | 904 | // Remove any nested quotes, if necessary. |
869 | - if (!empty($modSettings['removeNestedQuotes'])) |
|
870 | - $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
905 | + if (!empty($modSettings['removeNestedQuotes'])) { |
|
906 | + $form_message = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $form_message); |
|
907 | + } |
|
871 | 908 | |
872 | 909 | // Add a quote string on the front and end. |
873 | 910 | $form_message = '[quote author=' . $mname . ' link=msg=' . (int) $_REQUEST['quote'] . ' date=' . $mdate . ']' . "\n" . rtrim($form_message) . "\n" . '[/quote]'; |
@@ -879,15 +916,15 @@ discard block |
||
879 | 916 | $form_subject = $first_subject; |
880 | 917 | |
881 | 918 | // Add 'Re: ' to the front of the subject. |
882 | - if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) |
|
883 | - $form_subject = $context['response_prefix'] . $form_subject; |
|
919 | + if (trim($context['response_prefix']) != '' && $form_subject != '' && $smcFunc['strpos']($form_subject, trim($context['response_prefix'])) !== 0) { |
|
920 | + $form_subject = $context['response_prefix'] . $form_subject; |
|
921 | + } |
|
884 | 922 | |
885 | 923 | // Censor the subject. |
886 | 924 | censorText($form_subject); |
887 | 925 | |
888 | 926 | $form_message = ''; |
889 | - } |
|
890 | - else |
|
927 | + } else |
|
891 | 928 | { |
892 | 929 | $form_subject = isset($_GET['subject']) ? $_GET['subject'] : ''; |
893 | 930 | $form_message = ''; |
@@ -905,13 +942,15 @@ discard block |
||
905 | 942 | if (isset($_REQUEST['msg'])) |
906 | 943 | { |
907 | 944 | $context['attachments']['quantity'] = count($context['current_attachments']); |
908 | - foreach ($context['current_attachments'] as $attachment) |
|
909 | - $context['attachments']['total_size'] += $attachment['size']; |
|
945 | + foreach ($context['current_attachments'] as $attachment) { |
|
946 | + $context['attachments']['total_size'] += $attachment['size']; |
|
947 | + } |
|
910 | 948 | } |
911 | 949 | |
912 | 950 | // A bit of house keeping first. |
913 | - if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) |
|
914 | - unset($_SESSION['temp_attachments']); |
|
951 | + if (!empty($_SESSION['temp_attachments']) && count($_SESSION['temp_attachments']) == 1) { |
|
952 | + unset($_SESSION['temp_attachments']); |
|
953 | + } |
|
915 | 954 | |
916 | 955 | if (!empty($_SESSION['temp_attachments'])) |
917 | 956 | { |
@@ -920,9 +959,10 @@ discard block |
||
920 | 959 | { |
921 | 960 | foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
922 | 961 | { |
923 | - if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) |
|
924 | - if (file_exists($attachment['tmp_name'])) |
|
962 | + if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) { |
|
963 | + if (file_exists($attachment['tmp_name'])) |
|
925 | 964 | unlink($attachment['tmp_name']); |
965 | + } |
|
926 | 966 | } |
927 | 967 | $post_errors[] = 'temp_attachments_gone'; |
928 | 968 | $_SESSION['temp_attachments'] = array(); |
@@ -936,8 +976,9 @@ discard block |
||
936 | 976 | // See if any files still exist before showing the warning message and the files attached. |
937 | 977 | foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
938 | 978 | { |
939 | - if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) |
|
940 | - continue; |
|
979 | + if (strpos($attachID, 'post_tmp_' . $user_info['id']) === false) { |
|
980 | + continue; |
|
981 | + } |
|
941 | 982 | |
942 | 983 | if (file_exists($attachment['tmp_name'])) |
943 | 984 | { |
@@ -947,20 +988,21 @@ discard block |
||
947 | 988 | break; |
948 | 989 | } |
949 | 990 | } |
950 | - } |
|
951 | - else |
|
991 | + } else |
|
952 | 992 | { |
953 | 993 | // Since, they don't belong here. Let's inform the user that they exist.. |
954 | - if (!empty($topic)) |
|
955 | - $delete_url = $scripturl . '?action=post' .(!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp'; |
|
956 | - else |
|
957 | - $delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp'; |
|
994 | + if (!empty($topic)) { |
|
995 | + $delete_url = $scripturl . '?action=post' .(!empty($_REQUEST['msg']) ? (';msg=' . $_REQUEST['msg']) : '') . (!empty($_REQUEST['last_msg']) ? (';last_msg=' . $_REQUEST['last_msg']) : '') . ';topic=' . $topic . ';delete_temp'; |
|
996 | + } else { |
|
997 | + $delete_url = $scripturl . '?action=post;board=' . $board . ';delete_temp'; |
|
998 | + } |
|
958 | 999 | |
959 | 1000 | // Compile a list of the files to show the user. |
960 | 1001 | $file_list = array(); |
961 | - foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
|
962 | - if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) |
|
1002 | + foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) { |
|
1003 | + if (strpos($attachID, 'post_tmp_' . $user_info['id']) !== false) |
|
963 | 1004 | $file_list[] = $attachment['name']; |
1005 | + } |
|
964 | 1006 | |
965 | 1007 | $_SESSION['temp_attachments']['post']['files'] = $file_list; |
966 | 1008 | $file_list = '<div class="attachments">' . implode('<br>', $file_list) . '</div>'; |
@@ -972,8 +1014,7 @@ discard block |
||
972 | 1014 | |
973 | 1015 | $post_errors[] = array('temp_attachments_found', array($delete_url, $goback_url, $file_list)); |
974 | 1016 | $context['ignore_temp_attachments'] = true; |
975 | - } |
|
976 | - else |
|
1017 | + } else |
|
977 | 1018 | { |
978 | 1019 | $post_errors[] = array('temp_attachments_lost', array($delete_url, $file_list)); |
979 | 1020 | $context['ignore_temp_attachments'] = true; |
@@ -981,16 +1022,19 @@ discard block |
||
981 | 1022 | } |
982 | 1023 | } |
983 | 1024 | |
984 | - if (!empty($context['we_are_history'])) |
|
985 | - $post_errors[] = $context['we_are_history']; |
|
1025 | + if (!empty($context['we_are_history'])) { |
|
1026 | + $post_errors[] = $context['we_are_history']; |
|
1027 | + } |
|
986 | 1028 | |
987 | 1029 | foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
988 | 1030 | { |
989 | - if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) |
|
990 | - break; |
|
1031 | + if (isset($context['ignore_temp_attachments']) || isset($_SESSION['temp_attachments']['post']['files'])) { |
|
1032 | + break; |
|
1033 | + } |
|
991 | 1034 | |
992 | - if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) |
|
993 | - continue; |
|
1035 | + if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) { |
|
1036 | + continue; |
|
1037 | + } |
|
994 | 1038 | |
995 | 1039 | if ($attachID == 'initial_error') |
996 | 1040 | { |
@@ -1005,15 +1049,17 @@ discard block |
||
1005 | 1049 | { |
1006 | 1050 | $txt['error_attach_errors'] = empty($txt['error_attach_errors']) ? '<br>' : ''; |
1007 | 1051 | $txt['error_attach_errors'] .= vsprintf($txt['attach_warning'], $attachment['name']) . '<div style="padding: 0 1em;">'; |
1008 | - foreach ($attachment['errors'] as $error) |
|
1009 | - $txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >'; |
|
1052 | + foreach ($attachment['errors'] as $error) { |
|
1053 | + $txt['error_attach_errors'] .= (is_array($error) ? vsprintf($txt[$error[0]], $error[1]) : $txt[$error]) . '<br >'; |
|
1054 | + } |
|
1010 | 1055 | $txt['error_attach_errors'] .= '</div>'; |
1011 | 1056 | $post_errors[] = 'attach_errors'; |
1012 | 1057 | |
1013 | 1058 | // Take out the trash. |
1014 | 1059 | unset($_SESSION['temp_attachments'][$attachID]); |
1015 | - if (file_exists($attachment['tmp_name'])) |
|
1016 | - unlink($attachment['tmp_name']); |
|
1060 | + if (file_exists($attachment['tmp_name'])) { |
|
1061 | + unlink($attachment['tmp_name']); |
|
1062 | + } |
|
1017 | 1063 | continue; |
1018 | 1064 | } |
1019 | 1065 | |
@@ -1026,8 +1072,9 @@ discard block |
||
1026 | 1072 | |
1027 | 1073 | $context['attachments']['quantity']++; |
1028 | 1074 | $context['attachments']['total_size'] += $attachment['size']; |
1029 | - if (!isset($context['files_in_session_warning'])) |
|
1030 | - $context['files_in_session_warning'] = $txt['attached_files_in_session']; |
|
1075 | + if (!isset($context['files_in_session_warning'])) { |
|
1076 | + $context['files_in_session_warning'] = $txt['attached_files_in_session']; |
|
1077 | + } |
|
1031 | 1078 | |
1032 | 1079 | $context['current_attachments'][$attachID] = array( |
1033 | 1080 | 'name' => '<u>' . $smcFunc['htmlspecialchars']($attachment['name']) . '</u>', |
@@ -1055,8 +1102,9 @@ discard block |
||
1055 | 1102 | } |
1056 | 1103 | |
1057 | 1104 | // If they came from quick reply, and have to enter verification details, give them some notice. |
1058 | - if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) |
|
1059 | - $post_errors[] = 'need_qr_verification'; |
|
1105 | + if (!empty($_REQUEST['from_qr']) && !empty($context['require_verification'])) { |
|
1106 | + $post_errors[] = 'need_qr_verification'; |
|
1107 | + } |
|
1060 | 1108 | |
1061 | 1109 | /* |
1062 | 1110 | * There are two error types: serious and minor. Serious errors |
@@ -1073,52 +1121,56 @@ discard block |
||
1073 | 1121 | { |
1074 | 1122 | loadLanguage('Errors'); |
1075 | 1123 | $context['error_type'] = 'minor'; |
1076 | - foreach ($post_errors as $post_error) |
|
1077 | - if (is_array($post_error)) |
|
1124 | + foreach ($post_errors as $post_error) { |
|
1125 | + if (is_array($post_error)) |
|
1078 | 1126 | { |
1079 | 1127 | $post_error_id = $post_error[0]; |
1128 | + } |
|
1080 | 1129 | $context['post_error'][$post_error_id] = vsprintf($txt['error_' . $post_error_id], $post_error[1]); |
1081 | 1130 | |
1082 | 1131 | // If it's not a minor error flag it as such. |
1083 | - if (!in_array($post_error_id, $minor_errors)) |
|
1084 | - $context['error_type'] = 'serious'; |
|
1085 | - } |
|
1086 | - else |
|
1132 | + if (!in_array($post_error_id, $minor_errors)) { |
|
1133 | + $context['error_type'] = 'serious'; |
|
1134 | + } |
|
1135 | + } else |
|
1087 | 1136 | { |
1088 | 1137 | $context['post_error'][$post_error] = $txt['error_' . $post_error]; |
1089 | 1138 | |
1090 | 1139 | // If it's not a minor error flag it as such. |
1091 | - if (!in_array($post_error, $minor_errors)) |
|
1092 | - $context['error_type'] = 'serious'; |
|
1140 | + if (!in_array($post_error, $minor_errors)) { |
|
1141 | + $context['error_type'] = 'serious'; |
|
1142 | + } |
|
1093 | 1143 | } |
1094 | 1144 | } |
1095 | 1145 | |
1096 | 1146 | // What are you doing? Posting a poll, modifying, previewing, new post, or reply... |
1097 | - if (isset($_REQUEST['poll'])) |
|
1098 | - $context['page_title'] = $txt['new_poll']; |
|
1099 | - elseif ($context['make_event']) |
|
1100 | - $context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit']; |
|
1101 | - elseif (isset($_REQUEST['msg'])) |
|
1102 | - $context['page_title'] = $txt['modify_msg']; |
|
1103 | - elseif (isset($_REQUEST['subject'], $context['preview_subject'])) |
|
1104 | - $context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']); |
|
1105 | - elseif (empty($topic)) |
|
1106 | - $context['page_title'] = $txt['start_new_topic']; |
|
1107 | - else |
|
1108 | - $context['page_title'] = $txt['post_reply']; |
|
1147 | + if (isset($_REQUEST['poll'])) { |
|
1148 | + $context['page_title'] = $txt['new_poll']; |
|
1149 | + } elseif ($context['make_event']) { |
|
1150 | + $context['page_title'] = $context['event']['id'] == -1 ? $txt['calendar_post_event'] : $txt['calendar_edit']; |
|
1151 | + } elseif (isset($_REQUEST['msg'])) { |
|
1152 | + $context['page_title'] = $txt['modify_msg']; |
|
1153 | + } elseif (isset($_REQUEST['subject'], $context['preview_subject'])) { |
|
1154 | + $context['page_title'] = $txt['preview'] . ' - ' . strip_tags($context['preview_subject']); |
|
1155 | + } elseif (empty($topic)) { |
|
1156 | + $context['page_title'] = $txt['start_new_topic']; |
|
1157 | + } else { |
|
1158 | + $context['page_title'] = $txt['post_reply']; |
|
1159 | + } |
|
1109 | 1160 | |
1110 | 1161 | // Build the link tree. |
1111 | - if (empty($topic)) |
|
1112 | - $context['linktree'][] = array( |
|
1162 | + if (empty($topic)) { |
|
1163 | + $context['linktree'][] = array( |
|
1113 | 1164 | 'name' => '<em>' . $txt['start_new_topic'] . '</em>' |
1114 | 1165 | ); |
1115 | - else |
|
1116 | - $context['linktree'][] = array( |
|
1166 | + } else { |
|
1167 | + $context['linktree'][] = array( |
|
1117 | 1168 | 'url' => $scripturl . '?topic=' . $topic . '.' . $_REQUEST['start'], |
1118 | 1169 | 'name' => $form_subject, |
1119 | 1170 | 'extra_before' => '<span><strong class="nav">' . $context['page_title'] . ' (</strong></span>', |
1120 | 1171 | 'extra_after' => '<span><strong class="nav">)</strong></span>' |
1121 | 1172 | ); |
1173 | + } |
|
1122 | 1174 | |
1123 | 1175 | $context['subject'] = addcslashes($form_subject, '"'); |
1124 | 1176 | $context['message'] = str_replace(array('"', '<', '>', ' '), array('"', '<', '>', ' '), $form_message); |
@@ -1162,8 +1214,9 @@ discard block |
||
1162 | 1214 | // Message icons - customized icons are off? |
1163 | 1215 | $context['icons'] = getMessageIcons($board); |
1164 | 1216 | |
1165 | - if (!empty($context['icons'])) |
|
1166 | - $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1217 | + if (!empty($context['icons'])) { |
|
1218 | + $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1219 | + } |
|
1167 | 1220 | |
1168 | 1221 | // Are we starting a poll? if set the poll icon as selected if its available |
1169 | 1222 | if (isset($_REQUEST['poll'])) |
@@ -1183,8 +1236,9 @@ discard block |
||
1183 | 1236 | for ($i = 0, $n = count($context['icons']); $i < $n; $i++) |
1184 | 1237 | { |
1185 | 1238 | $context['icons'][$i]['selected'] = $context['icon'] == $context['icons'][$i]['value']; |
1186 | - if ($context['icons'][$i]['selected']) |
|
1187 | - $context['icon_url'] = $context['icons'][$i]['url']; |
|
1239 | + if ($context['icons'][$i]['selected']) { |
|
1240 | + $context['icon_url'] = $context['icons'][$i]['url']; |
|
1241 | + } |
|
1188 | 1242 | } |
1189 | 1243 | if (empty($context['icon_url'])) |
1190 | 1244 | { |
@@ -1198,8 +1252,9 @@ discard block |
||
1198 | 1252 | )); |
1199 | 1253 | } |
1200 | 1254 | |
1201 | - if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) |
|
1202 | - getTopic(); |
|
1255 | + if (!empty($topic) && !empty($modSettings['topicSummaryPosts'])) { |
|
1256 | + getTopic(); |
|
1257 | + } |
|
1203 | 1258 | |
1204 | 1259 | // If the user can post attachments prepare the warning labels. |
1205 | 1260 | if ($context['can_post_attachment']) |
@@ -1210,15 +1265,17 @@ discard block |
||
1210 | 1265 | $context['attachment_restrictions'] = array(); |
1211 | 1266 | $context['allowed_extensions'] = strtr(strtolower($modSettings['attachmentExtensions']), array(',' => ', ')); |
1212 | 1267 | $attachmentRestrictionTypes = array('attachmentNumPerPostLimit', 'attachmentPostLimit', 'attachmentSizeLimit'); |
1213 | - foreach ($attachmentRestrictionTypes as $type) |
|
1214 | - if (!empty($modSettings[$type])) |
|
1268 | + foreach ($attachmentRestrictionTypes as $type) { |
|
1269 | + if (!empty($modSettings[$type])) |
|
1215 | 1270 | { |
1216 | 1271 | $context['attachment_restrictions'][] = sprintf($txt['attach_restrict_' . $type . ($modSettings[$type] >= 1024 ? '_MB' : '')], comma_format($modSettings[$type], 0)); |
1272 | + } |
|
1217 | 1273 | // Show some numbers. If they exist. |
1218 | - if ($type == 'attachmentNumPerPostLimit' && $context['attachments']['quantity'] > 0) |
|
1219 | - $context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']); |
|
1220 | - elseif ($type == 'attachmentPostLimit' && $context['attachments']['total_size'] > 0) |
|
1221 | - $context['attachment_restrictions'][] = sprintf($txt['attach_available'], comma_format(round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)), 0)); |
|
1274 | + if ($type == 'attachmentNumPerPostLimit' && $context['attachments']['quantity'] > 0) { |
|
1275 | + $context['attachment_restrictions'][] = sprintf($txt['attach_remaining'], $modSettings['attachmentNumPerPostLimit'] - $context['attachments']['quantity']); |
|
1276 | + } elseif ($type == 'attachmentPostLimit' && $context['attachments']['total_size'] > 0) { |
|
1277 | + $context['attachment_restrictions'][] = sprintf($txt['attach_available'], comma_format(round(max($modSettings['attachmentPostLimit'] - ($context['attachments']['total_size'] / 1024), 0)), 0)); |
|
1278 | + } |
|
1222 | 1279 | } |
1223 | 1280 | } |
1224 | 1281 | |
@@ -1252,8 +1309,8 @@ discard block |
||
1252 | 1309 | |
1253 | 1310 | if (!empty($context['current_attachments'])) |
1254 | 1311 | { |
1255 | - foreach ($context['current_attachments'] as $key => $mock) |
|
1256 | - addInlineJavaScript(' |
|
1312 | + foreach ($context['current_attachments'] as $key => $mock) { |
|
1313 | + addInlineJavaScript(' |
|
1257 | 1314 | current_attachments.push({ |
1258 | 1315 | name: '. JavaScriptEscape($mock['name']) .', |
1259 | 1316 | size: '. $mock['size'] .', |
@@ -1262,6 +1319,7 @@ discard block |
||
1262 | 1319 | type: '. JavaScriptEscape(!empty($mock['mime_type']) ? $mock['mime_type'] : '') .', |
1263 | 1320 | thumbID: '. (!empty($mock['thumb']) ? $mock['thumb'] : 0) .' |
1264 | 1321 | });', true); |
1322 | + } |
|
1265 | 1323 | } |
1266 | 1324 | |
1267 | 1325 | // File Upload. |
@@ -1306,8 +1364,9 @@ discard block |
||
1306 | 1364 | var current_board = '. (empty($context['current_board']) ? 'null' : $context['current_board']) .';', false); |
1307 | 1365 | |
1308 | 1366 | // Finally, load the template. |
1309 | - if (!isset($_REQUEST['xml'])) |
|
1310 | - loadTemplate('Post'); |
|
1367 | + if (!isset($_REQUEST['xml'])) { |
|
1368 | + loadTemplate('Post'); |
|
1369 | + } |
|
1311 | 1370 | |
1312 | 1371 | call_integration_hook('integrate_post_end'); |
1313 | 1372 | } |
@@ -1328,13 +1387,14 @@ discard block |
||
1328 | 1387 | // Sneaking off, are we? |
1329 | 1388 | if (empty($_POST) && empty($topic)) |
1330 | 1389 | { |
1331 | - if (empty($_SERVER['CONTENT_LENGTH'])) |
|
1332 | - redirectexit('action=post;board=' . $board . '.0'); |
|
1333 | - else |
|
1334 | - fatal_lang_error('post_upload_error', false); |
|
1390 | + if (empty($_SERVER['CONTENT_LENGTH'])) { |
|
1391 | + redirectexit('action=post;board=' . $board . '.0'); |
|
1392 | + } else { |
|
1393 | + fatal_lang_error('post_upload_error', false); |
|
1394 | + } |
|
1395 | + } elseif (empty($_POST) && !empty($topic)) { |
|
1396 | + redirectexit('action=post;topic=' . $topic . '.0'); |
|
1335 | 1397 | } |
1336 | - elseif (empty($_POST) && !empty($topic)) |
|
1337 | - redirectexit('action=post;topic=' . $topic . '.0'); |
|
1338 | 1398 | |
1339 | 1399 | // No need! |
1340 | 1400 | $context['robot_no_index'] = true; |
@@ -1346,8 +1406,9 @@ discard block |
||
1346 | 1406 | $post_errors = array(); |
1347 | 1407 | |
1348 | 1408 | // If the session has timed out, let the user re-submit their form. |
1349 | - if (checkSession('post', '', false) != '') |
|
1350 | - $post_errors[] = 'session_timeout'; |
|
1409 | + if (checkSession('post', '', false) != '') { |
|
1410 | + $post_errors[] = 'session_timeout'; |
|
1411 | + } |
|
1351 | 1412 | |
1352 | 1413 | // Wrong verification code? |
1353 | 1414 | if (!$user_info['is_admin'] && !$user_info['is_mod'] && !empty($modSettings['posts_require_captcha']) && ($user_info['posts'] < $modSettings['posts_require_captcha'] || ($user_info['is_guest'] && $modSettings['posts_require_captcha'] == -1))) |
@@ -1357,33 +1418,38 @@ discard block |
||
1357 | 1418 | 'id' => 'post', |
1358 | 1419 | ); |
1359 | 1420 | $context['require_verification'] = create_control_verification($verificationOptions, true); |
1360 | - if (is_array($context['require_verification'])) |
|
1361 | - $post_errors = array_merge($post_errors, $context['require_verification']); |
|
1421 | + if (is_array($context['require_verification'])) { |
|
1422 | + $post_errors = array_merge($post_errors, $context['require_verification']); |
|
1423 | + } |
|
1362 | 1424 | } |
1363 | 1425 | |
1364 | 1426 | require_once($sourcedir . '/Subs-Post.php'); |
1365 | 1427 | loadLanguage('Post'); |
1366 | 1428 | |
1367 | 1429 | // Drafts enabled and needed? |
1368 | - if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) |
|
1369 | - require_once($sourcedir . '/Drafts.php'); |
|
1430 | + if (!empty($modSettings['drafts_post_enabled']) && (isset($_POST['save_draft']) || isset($_POST['id_draft']))) { |
|
1431 | + require_once($sourcedir . '/Drafts.php'); |
|
1432 | + } |
|
1370 | 1433 | |
1371 | 1434 | // First check to see if they are trying to delete any current attachments. |
1372 | 1435 | if (isset($_POST['attach_del'])) |
1373 | 1436 | { |
1374 | 1437 | $keep_temp = array(); |
1375 | 1438 | $keep_ids = array(); |
1376 | - foreach ($_POST['attach_del'] as $dummy) |
|
1377 | - if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false) |
|
1439 | + foreach ($_POST['attach_del'] as $dummy) { |
|
1440 | + if (strpos($dummy, 'post_tmp_' . $user_info['id']) !== false) |
|
1378 | 1441 | $keep_temp[] = $dummy; |
1379 | - else |
|
1380 | - $keep_ids[] = (int) $dummy; |
|
1442 | + } |
|
1443 | + else { |
|
1444 | + $keep_ids[] = (int) $dummy; |
|
1445 | + } |
|
1381 | 1446 | |
1382 | - if (isset($_SESSION['temp_attachments'])) |
|
1383 | - foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
|
1447 | + if (isset($_SESSION['temp_attachments'])) { |
|
1448 | + foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
|
1384 | 1449 | { |
1385 | 1450 | if ((isset($_SESSION['temp_attachments']['post']['files'], $attachment['name']) && in_array($attachment['name'], $_SESSION['temp_attachments']['post']['files'])) || in_array($attachID, $keep_temp) || strpos($attachID, 'post_tmp_' . $user_info['id']) === false) |
1386 | 1451 | continue; |
1452 | + } |
|
1387 | 1453 | |
1388 | 1454 | unset($_SESSION['temp_attachments'][$attachID]); |
1389 | 1455 | unlink($attachment['tmp_name']); |
@@ -1425,24 +1491,28 @@ discard block |
||
1425 | 1491 | $smcFunc['db_free_result']($request); |
1426 | 1492 | |
1427 | 1493 | // Though the topic should be there, it might have vanished. |
1428 | - if (!is_array($topic_info)) |
|
1429 | - fatal_lang_error('topic_doesnt_exist', 404); |
|
1494 | + if (!is_array($topic_info)) { |
|
1495 | + fatal_lang_error('topic_doesnt_exist', 404); |
|
1496 | + } |
|
1430 | 1497 | |
1431 | 1498 | // Did this topic suddenly move? Just checking... |
1432 | - if ($topic_info['id_board'] != $board) |
|
1433 | - fatal_lang_error('not_a_topic'); |
|
1499 | + if ($topic_info['id_board'] != $board) { |
|
1500 | + fatal_lang_error('not_a_topic'); |
|
1501 | + } |
|
1434 | 1502 | } |
1435 | 1503 | |
1436 | 1504 | // Replying to a topic? |
1437 | 1505 | if (!empty($topic) && !isset($_REQUEST['msg'])) |
1438 | 1506 | { |
1439 | 1507 | // Don't allow a post if it's locked. |
1440 | - if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) |
|
1441 | - fatal_lang_error('topic_locked', false); |
|
1508 | + if ($topic_info['locked'] != 0 && !allowedTo('moderate_board')) { |
|
1509 | + fatal_lang_error('topic_locked', false); |
|
1510 | + } |
|
1442 | 1511 | |
1443 | 1512 | // Sorry, multiple polls aren't allowed... yet. You should stop giving me ideas :P. |
1444 | - if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) |
|
1445 | - unset($_REQUEST['poll']); |
|
1513 | + if (isset($_REQUEST['poll']) && $topic_info['id_poll'] > 0) { |
|
1514 | + unset($_REQUEST['poll']); |
|
1515 | + } |
|
1446 | 1516 | |
1447 | 1517 | // Do the permissions and approval stuff... |
1448 | 1518 | $becomesApproved = true; |
@@ -1458,44 +1528,43 @@ discard block |
||
1458 | 1528 | |
1459 | 1529 | // Set a nice session var... |
1460 | 1530 | $_SESSION['becomesUnapproved'] = true; |
1461 | - } |
|
1462 | - |
|
1463 | - elseif ($topic_info['id_member_started'] != $user_info['id']) |
|
1531 | + } elseif ($topic_info['id_member_started'] != $user_info['id']) |
|
1464 | 1532 | { |
1465 | - if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) |
|
1466 | - $becomesApproved = false; |
|
1467 | - |
|
1468 | - else |
|
1469 | - isAllowedTo('post_reply_any'); |
|
1470 | - } |
|
1471 | - elseif (!allowedTo('post_reply_any')) |
|
1533 | + if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_any') && !allowedTo('post_reply_any')) { |
|
1534 | + $becomesApproved = false; |
|
1535 | + } else { |
|
1536 | + isAllowedTo('post_reply_any'); |
|
1537 | + } |
|
1538 | + } elseif (!allowedTo('post_reply_any')) |
|
1472 | 1539 | { |
1473 | - if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) |
|
1474 | - $becomesApproved = false; |
|
1475 | - |
|
1476 | - else |
|
1477 | - isAllowedTo('post_reply_own'); |
|
1540 | + if ($modSettings['postmod_active'] && allowedTo('post_unapproved_replies_own') && !allowedTo('post_reply_own')) { |
|
1541 | + $becomesApproved = false; |
|
1542 | + } else { |
|
1543 | + isAllowedTo('post_reply_own'); |
|
1544 | + } |
|
1478 | 1545 | } |
1479 | 1546 | |
1480 | 1547 | if (isset($_POST['lock'])) |
1481 | 1548 | { |
1482 | 1549 | // Nothing is changed to the lock. |
1483 | - if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) |
|
1484 | - unset($_POST['lock']); |
|
1550 | + if ((empty($topic_info['locked']) && empty($_POST['lock'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) { |
|
1551 | + unset($_POST['lock']); |
|
1552 | + } |
|
1485 | 1553 | |
1486 | 1554 | // You're have no permission to lock this topic. |
1487 | - elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) |
|
1488 | - unset($_POST['lock']); |
|
1555 | + elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) { |
|
1556 | + unset($_POST['lock']); |
|
1557 | + } |
|
1489 | 1558 | |
1490 | 1559 | // You are allowed to (un)lock your own topic only. |
1491 | 1560 | elseif (!allowedTo('lock_any')) |
1492 | 1561 | { |
1493 | 1562 | // You cannot override a moderator lock. |
1494 | - if ($topic_info['locked'] == 1) |
|
1495 | - unset($_POST['lock']); |
|
1496 | - |
|
1497 | - else |
|
1498 | - $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
1563 | + if ($topic_info['locked'] == 1) { |
|
1564 | + unset($_POST['lock']); |
|
1565 | + } else { |
|
1566 | + $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
1567 | + } |
|
1499 | 1568 | } |
1500 | 1569 | // Hail mighty moderator, (un)lock this topic immediately. |
1501 | 1570 | else |
@@ -1503,19 +1572,21 @@ discard block |
||
1503 | 1572 | $_POST['lock'] = empty($_POST['lock']) ? 0 : 1; |
1504 | 1573 | |
1505 | 1574 | // Did someone (un)lock this while you were posting? |
1506 | - if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) |
|
1507 | - $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked'; |
|
1575 | + if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) { |
|
1576 | + $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked'; |
|
1577 | + } |
|
1508 | 1578 | } |
1509 | 1579 | } |
1510 | 1580 | |
1511 | 1581 | // So you wanna (un)sticky this...let's see. |
1512 | - if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) |
|
1513 | - unset($_POST['sticky']); |
|
1514 | - elseif (isset($_POST['sticky'])) |
|
1582 | + if (isset($_POST['sticky']) && ($_POST['sticky'] == $topic_info['is_sticky'] || !allowedTo('make_sticky'))) { |
|
1583 | + unset($_POST['sticky']); |
|
1584 | + } elseif (isset($_POST['sticky'])) |
|
1515 | 1585 | { |
1516 | 1586 | // Did someone (un)sticky this while you were posting? |
1517 | - if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) |
|
1518 | - $post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky'; |
|
1587 | + if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) { |
|
1588 | + $post_errors[] = 'topic_' . (empty($topic_info['is_sticky']) ? 'un' : '') . 'sticky'; |
|
1589 | + } |
|
1519 | 1590 | } |
1520 | 1591 | |
1521 | 1592 | // If drafts are enabled, then pass this off |
@@ -1542,26 +1613,31 @@ discard block |
||
1542 | 1613 | |
1543 | 1614 | // Do like, the permissions, for safety and stuff... |
1544 | 1615 | $becomesApproved = true; |
1545 | - if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) |
|
1546 | - $becomesApproved = false; |
|
1547 | - else |
|
1548 | - isAllowedTo('post_new'); |
|
1616 | + if ($modSettings['postmod_active'] && !allowedTo('post_new') && allowedTo('post_unapproved_topics')) { |
|
1617 | + $becomesApproved = false; |
|
1618 | + } else { |
|
1619 | + isAllowedTo('post_new'); |
|
1620 | + } |
|
1549 | 1621 | |
1550 | 1622 | if (isset($_POST['lock'])) |
1551 | 1623 | { |
1552 | 1624 | // New topics are by default not locked. |
1553 | - if (empty($_POST['lock'])) |
|
1554 | - unset($_POST['lock']); |
|
1625 | + if (empty($_POST['lock'])) { |
|
1626 | + unset($_POST['lock']); |
|
1627 | + } |
|
1555 | 1628 | // Besides, you need permission. |
1556 | - elseif (!allowedTo(array('lock_any', 'lock_own'))) |
|
1557 | - unset($_POST['lock']); |
|
1629 | + elseif (!allowedTo(array('lock_any', 'lock_own'))) { |
|
1630 | + unset($_POST['lock']); |
|
1631 | + } |
|
1558 | 1632 | // A moderator-lock (1) can override a user-lock (2). |
1559 | - else |
|
1560 | - $_POST['lock'] = allowedTo('lock_any') ? 1 : 2; |
|
1633 | + else { |
|
1634 | + $_POST['lock'] = allowedTo('lock_any') ? 1 : 2; |
|
1635 | + } |
|
1561 | 1636 | } |
1562 | 1637 | |
1563 | - if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) |
|
1564 | - unset($_POST['sticky']); |
|
1638 | + if (isset($_POST['sticky']) && (empty($_POST['sticky']) || !allowedTo('make_sticky'))) { |
|
1639 | + unset($_POST['sticky']); |
|
1640 | + } |
|
1565 | 1641 | |
1566 | 1642 | // Saving your new topic as a draft first? |
1567 | 1643 | if (!empty($modSettings['drafts_post_enabled']) && isset($_POST['save_draft'])) |
@@ -1586,31 +1662,37 @@ discard block |
||
1586 | 1662 | 'id_msg' => $_REQUEST['msg'], |
1587 | 1663 | ) |
1588 | 1664 | ); |
1589 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
1590 | - fatal_lang_error('cant_find_messages', false); |
|
1665 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
1666 | + fatal_lang_error('cant_find_messages', false); |
|
1667 | + } |
|
1591 | 1668 | $row = $smcFunc['db_fetch_assoc']($request); |
1592 | 1669 | $smcFunc['db_free_result']($request); |
1593 | 1670 | |
1594 | - if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) |
|
1595 | - fatal_lang_error('topic_locked', false); |
|
1671 | + if (!empty($topic_info['locked']) && !allowedTo('moderate_board')) { |
|
1672 | + fatal_lang_error('topic_locked', false); |
|
1673 | + } |
|
1596 | 1674 | |
1597 | 1675 | if (isset($_POST['lock'])) |
1598 | 1676 | { |
1599 | 1677 | // Nothing changes to the lock status. |
1600 | - if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) |
|
1601 | - unset($_POST['lock']); |
|
1678 | + if ((empty($_POST['lock']) && empty($topic_info['locked'])) || (!empty($_POST['lock']) && !empty($topic_info['locked']))) { |
|
1679 | + unset($_POST['lock']); |
|
1680 | + } |
|
1602 | 1681 | // You're simply not allowed to (un)lock this. |
1603 | - elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) |
|
1604 | - unset($_POST['lock']); |
|
1682 | + elseif (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $topic_info['id_member_started'])) { |
|
1683 | + unset($_POST['lock']); |
|
1684 | + } |
|
1605 | 1685 | // You're only allowed to lock your own topics. |
1606 | 1686 | elseif (!allowedTo('lock_any')) |
1607 | 1687 | { |
1608 | 1688 | // You're not allowed to break a moderator's lock. |
1609 | - if ($topic_info['locked'] == 1) |
|
1610 | - unset($_POST['lock']); |
|
1689 | + if ($topic_info['locked'] == 1) { |
|
1690 | + unset($_POST['lock']); |
|
1691 | + } |
|
1611 | 1692 | // Lock it with a soft lock or unlock it. |
1612 | - else |
|
1613 | - $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
1693 | + else { |
|
1694 | + $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
1695 | + } |
|
1614 | 1696 | } |
1615 | 1697 | // You must be the moderator. |
1616 | 1698 | else |
@@ -1618,44 +1700,46 @@ discard block |
||
1618 | 1700 | $_POST['lock'] = empty($_POST['lock']) ? 0 : 1; |
1619 | 1701 | |
1620 | 1702 | // Did someone (un)lock this while you were posting? |
1621 | - if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) |
|
1622 | - $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked'; |
|
1703 | + if (isset($_POST['already_locked']) && $_POST['already_locked'] != $topic_info['locked']) { |
|
1704 | + $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'locked'; |
|
1705 | + } |
|
1623 | 1706 | } |
1624 | 1707 | } |
1625 | 1708 | |
1626 | 1709 | // Change the sticky status of this topic? |
1627 | - if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) |
|
1628 | - unset($_POST['sticky']); |
|
1629 | - elseif (isset($_POST['sticky'])) |
|
1710 | + if (isset($_POST['sticky']) && (!allowedTo('make_sticky') || $_POST['sticky'] == $topic_info['is_sticky'])) { |
|
1711 | + unset($_POST['sticky']); |
|
1712 | + } elseif (isset($_POST['sticky'])) |
|
1630 | 1713 | { |
1631 | 1714 | // Did someone (un)sticky this while you were posting? |
1632 | - if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) |
|
1633 | - $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied'; |
|
1715 | + if (isset($_POST['already_sticky']) && $_POST['already_sticky'] != $topic_info['is_sticky']) { |
|
1716 | + $post_errors[] = 'topic_' . (empty($topic_info['locked']) ? 'un' : '') . 'stickied'; |
|
1717 | + } |
|
1634 | 1718 | } |
1635 | 1719 | |
1636 | 1720 | if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any')) |
1637 | 1721 | { |
1638 | - if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) |
|
1639 | - fatal_lang_error('modify_post_time_passed', false); |
|
1640 | - elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) |
|
1641 | - isAllowedTo('modify_replies'); |
|
1642 | - else |
|
1643 | - isAllowedTo('modify_own'); |
|
1644 | - } |
|
1645 | - elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) |
|
1722 | + if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) { |
|
1723 | + fatal_lang_error('modify_post_time_passed', false); |
|
1724 | + } elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) { |
|
1725 | + isAllowedTo('modify_replies'); |
|
1726 | + } else { |
|
1727 | + isAllowedTo('modify_own'); |
|
1728 | + } |
|
1729 | + } elseif ($topic_info['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) |
|
1646 | 1730 | { |
1647 | 1731 | isAllowedTo('modify_replies'); |
1648 | 1732 | |
1649 | 1733 | // If you're modifying a reply, I say it better be logged... |
1650 | 1734 | $moderationAction = true; |
1651 | - } |
|
1652 | - else |
|
1735 | + } else |
|
1653 | 1736 | { |
1654 | 1737 | isAllowedTo('modify_any'); |
1655 | 1738 | |
1656 | 1739 | // Log it, assuming you're not modifying your own post. |
1657 | - if ($row['id_member'] != $user_info['id']) |
|
1658 | - $moderationAction = true; |
|
1740 | + if ($row['id_member'] != $user_info['id']) { |
|
1741 | + $moderationAction = true; |
|
1742 | + } |
|
1659 | 1743 | } |
1660 | 1744 | |
1661 | 1745 | // If drafts are enabled, then lets send this off to save |
@@ -1692,20 +1776,24 @@ discard block |
||
1692 | 1776 | $_POST['guestname'] = !isset($_POST['guestname']) ? '' : trim($_POST['guestname']); |
1693 | 1777 | $_POST['email'] = !isset($_POST['email']) ? '' : trim($_POST['email']); |
1694 | 1778 | |
1695 | - if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') |
|
1696 | - $post_errors[] = 'no_name'; |
|
1697 | - if ($smcFunc['strlen']($_POST['guestname']) > 25) |
|
1698 | - $post_errors[] = 'long_name'; |
|
1779 | + if ($_POST['guestname'] == '' || $_POST['guestname'] == '_') { |
|
1780 | + $post_errors[] = 'no_name'; |
|
1781 | + } |
|
1782 | + if ($smcFunc['strlen']($_POST['guestname']) > 25) { |
|
1783 | + $post_errors[] = 'long_name'; |
|
1784 | + } |
|
1699 | 1785 | |
1700 | 1786 | if (empty($modSettings['guest_post_no_email'])) |
1701 | 1787 | { |
1702 | 1788 | // Only check if they changed it! |
1703 | 1789 | if (!isset($row) || $row['poster_email'] != $_POST['email']) |
1704 | 1790 | { |
1705 | - if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) |
|
1706 | - $post_errors[] = 'no_email'; |
|
1707 | - if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) |
|
1708 | - $post_errors[] = 'bad_email'; |
|
1791 | + if (!allowedTo('moderate_forum') && (!isset($_POST['email']) || $_POST['email'] == '')) { |
|
1792 | + $post_errors[] = 'no_email'; |
|
1793 | + } |
|
1794 | + if (!allowedTo('moderate_forum') && !filter_var($_POST['email'], FILTER_VALIDATE_EMAIL)) { |
|
1795 | + $post_errors[] = 'bad_email'; |
|
1796 | + } |
|
1709 | 1797 | } |
1710 | 1798 | |
1711 | 1799 | // Now make sure this email address is not banned from posting. |
@@ -1721,75 +1809,89 @@ discard block |
||
1721 | 1809 | } |
1722 | 1810 | |
1723 | 1811 | // Coming from the quickReply? |
1724 | - if(isset($_POST['quickReply'])) |
|
1725 | - $_POST['message'] = $_POST['quickReply']; |
|
1812 | + if(isset($_POST['quickReply'])) { |
|
1813 | + $_POST['message'] = $_POST['quickReply']; |
|
1814 | + } |
|
1726 | 1815 | |
1727 | 1816 | // Check the subject and message. |
1728 | - if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') |
|
1729 | - $post_errors[] = 'no_subject'; |
|
1730 | - if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') |
|
1731 | - $post_errors[] = 'no_message'; |
|
1732 | - elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) |
|
1733 | - $post_errors[] = array('long_message', array($modSettings['max_messageLength'])); |
|
1734 | - else |
|
1817 | + if (!isset($_POST['subject']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['subject'])) === '') { |
|
1818 | + $post_errors[] = 'no_subject'; |
|
1819 | + } |
|
1820 | + if (!isset($_POST['message']) || $smcFunc['htmltrim']($smcFunc['htmlspecialchars']($_POST['message']), ENT_QUOTES) === '') { |
|
1821 | + $post_errors[] = 'no_message'; |
|
1822 | + } elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) { |
|
1823 | + $post_errors[] = array('long_message', array($modSettings['max_messageLength'])); |
|
1824 | + } else |
|
1735 | 1825 | { |
1736 | 1826 | // Prepare the message a bit for some additional testing. |
1737 | 1827 | $_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES); |
1738 | 1828 | |
1739 | 1829 | // Preparse code. (Zef) |
1740 | - if ($user_info['is_guest']) |
|
1741 | - $user_info['name'] = $_POST['guestname']; |
|
1830 | + if ($user_info['is_guest']) { |
|
1831 | + $user_info['name'] = $_POST['guestname']; |
|
1832 | + } |
|
1742 | 1833 | preparsecode($_POST['message']); |
1743 | 1834 | |
1744 | 1835 | // Let's see if there's still some content left without the tags. |
1745 | - if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) |
|
1746 | - $post_errors[] = 'no_message'; |
|
1836 | + if ($smcFunc['htmltrim'](strip_tags(parse_bbc($_POST['message'], false), implode('', $context['allowed_html_tags']))) === '' && (!allowedTo('admin_forum') || strpos($_POST['message'], '[html]') === false)) { |
|
1837 | + $post_errors[] = 'no_message'; |
|
1838 | + } |
|
1839 | + } |
|
1840 | + if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') { |
|
1841 | + $post_errors[] = 'no_event'; |
|
1747 | 1842 | } |
1748 | - if (isset($_POST['calendar']) && !isset($_REQUEST['deleteevent']) && $smcFunc['htmltrim']($_POST['evtitle']) === '') |
|
1749 | - $post_errors[] = 'no_event'; |
|
1750 | 1843 | // You are not! |
1751 | - if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) |
|
1752 | - fatal_error('Knave! Masquerader! Charlatan!', false); |
|
1844 | + if (isset($_POST['message']) && strtolower($_POST['message']) == 'i am the administrator.' && !$user_info['is_admin']) { |
|
1845 | + fatal_error('Knave! Masquerader! Charlatan!', false); |
|
1846 | + } |
|
1753 | 1847 | |
1754 | 1848 | // Validate the poll... |
1755 | 1849 | if (isset($_REQUEST['poll']) && $modSettings['pollMode'] == '1') |
1756 | 1850 | { |
1757 | - if (!empty($topic) && !isset($_REQUEST['msg'])) |
|
1758 | - fatal_lang_error('no_access', false); |
|
1851 | + if (!empty($topic) && !isset($_REQUEST['msg'])) { |
|
1852 | + fatal_lang_error('no_access', false); |
|
1853 | + } |
|
1759 | 1854 | |
1760 | 1855 | // This is a new topic... so it's a new poll. |
1761 | - if (empty($topic)) |
|
1762 | - isAllowedTo('poll_post'); |
|
1856 | + if (empty($topic)) { |
|
1857 | + isAllowedTo('poll_post'); |
|
1858 | + } |
|
1763 | 1859 | // Can you add to your own topics? |
1764 | - elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) |
|
1765 | - isAllowedTo('poll_add_own'); |
|
1860 | + elseif ($user_info['id'] == $topic_info['id_member_started'] && !allowedTo('poll_add_any')) { |
|
1861 | + isAllowedTo('poll_add_own'); |
|
1862 | + } |
|
1766 | 1863 | // Can you add polls to any topic, then? |
1767 | - else |
|
1768 | - isAllowedTo('poll_add_any'); |
|
1864 | + else { |
|
1865 | + isAllowedTo('poll_add_any'); |
|
1866 | + } |
|
1769 | 1867 | |
1770 | - if (!isset($_POST['question']) || trim($_POST['question']) == '') |
|
1771 | - $post_errors[] = 'no_question'; |
|
1868 | + if (!isset($_POST['question']) || trim($_POST['question']) == '') { |
|
1869 | + $post_errors[] = 'no_question'; |
|
1870 | + } |
|
1772 | 1871 | |
1773 | 1872 | $_POST['options'] = empty($_POST['options']) ? array() : htmltrim__recursive($_POST['options']); |
1774 | 1873 | |
1775 | 1874 | // Get rid of empty ones. |
1776 | - foreach ($_POST['options'] as $k => $option) |
|
1777 | - if ($option == '') |
|
1875 | + foreach ($_POST['options'] as $k => $option) { |
|
1876 | + if ($option == '') |
|
1778 | 1877 | unset($_POST['options'][$k], $_POST['options'][$k]); |
1878 | + } |
|
1779 | 1879 | |
1780 | 1880 | // What are you going to vote between with one choice?!? |
1781 | - if (count($_POST['options']) < 2) |
|
1782 | - $post_errors[] = 'poll_few'; |
|
1783 | - elseif (count($_POST['options']) > 256) |
|
1784 | - $post_errors[] = 'poll_many'; |
|
1881 | + if (count($_POST['options']) < 2) { |
|
1882 | + $post_errors[] = 'poll_few'; |
|
1883 | + } elseif (count($_POST['options']) > 256) { |
|
1884 | + $post_errors[] = 'poll_many'; |
|
1885 | + } |
|
1785 | 1886 | } |
1786 | 1887 | |
1787 | 1888 | if ($posterIsGuest) |
1788 | 1889 | { |
1789 | 1890 | // If user is a guest, make sure the chosen name isn't taken. |
1790 | 1891 | require_once($sourcedir . '/Subs-Members.php'); |
1791 | - if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) |
|
1792 | - $post_errors[] = 'bad_name'; |
|
1892 | + if (isReservedName($_POST['guestname'], 0, true, false) && (!isset($row['poster_name']) || $_POST['guestname'] != $row['poster_name'])) { |
|
1893 | + $post_errors[] = 'bad_name'; |
|
1894 | + } |
|
1793 | 1895 | } |
1794 | 1896 | // If the user isn't a guest, get his or her name and email. |
1795 | 1897 | elseif (!isset($_REQUEST['msg'])) |
@@ -1820,8 +1922,9 @@ discard block |
||
1820 | 1922 | } |
1821 | 1923 | |
1822 | 1924 | // Make sure the user isn't spamming the board. |
1823 | - if (!isset($_REQUEST['msg'])) |
|
1824 | - spamProtection('post'); |
|
1925 | + if (!isset($_REQUEST['msg'])) { |
|
1926 | + spamProtection('post'); |
|
1927 | + } |
|
1825 | 1928 | |
1826 | 1929 | // At about this point, we're posting and that's that. |
1827 | 1930 | ignore_user_abort(true); |
@@ -1834,32 +1937,36 @@ discard block |
||
1834 | 1937 | $_POST['modify_reason'] = empty($_POST['modify_reason']) ? '' : strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => '')); |
1835 | 1938 | |
1836 | 1939 | // At this point, we want to make sure the subject isn't too long. |
1837 | - if ($smcFunc['strlen']($_POST['subject']) > 100) |
|
1838 | - $_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100); |
|
1940 | + if ($smcFunc['strlen']($_POST['subject']) > 100) { |
|
1941 | + $_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100); |
|
1942 | + } |
|
1839 | 1943 | |
1840 | 1944 | // Same with the "why did you edit this" text. |
1841 | - if ($smcFunc['strlen']($_POST['modify_reason']) > 100) |
|
1842 | - $_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100); |
|
1945 | + if ($smcFunc['strlen']($_POST['modify_reason']) > 100) { |
|
1946 | + $_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100); |
|
1947 | + } |
|
1843 | 1948 | |
1844 | 1949 | // Make the poll... |
1845 | 1950 | if (isset($_REQUEST['poll'])) |
1846 | 1951 | { |
1847 | 1952 | // Make sure that the user has not entered a ridiculous number of options.. |
1848 | - if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) |
|
1849 | - $_POST['poll_max_votes'] = 1; |
|
1850 | - elseif ($_POST['poll_max_votes'] > count($_POST['options'])) |
|
1851 | - $_POST['poll_max_votes'] = count($_POST['options']); |
|
1852 | - else |
|
1853 | - $_POST['poll_max_votes'] = (int) $_POST['poll_max_votes']; |
|
1953 | + if (empty($_POST['poll_max_votes']) || $_POST['poll_max_votes'] <= 0) { |
|
1954 | + $_POST['poll_max_votes'] = 1; |
|
1955 | + } elseif ($_POST['poll_max_votes'] > count($_POST['options'])) { |
|
1956 | + $_POST['poll_max_votes'] = count($_POST['options']); |
|
1957 | + } else { |
|
1958 | + $_POST['poll_max_votes'] = (int) $_POST['poll_max_votes']; |
|
1959 | + } |
|
1854 | 1960 | |
1855 | 1961 | $_POST['poll_expire'] = (int) $_POST['poll_expire']; |
1856 | 1962 | $_POST['poll_expire'] = $_POST['poll_expire'] > 9999 ? 9999 : ($_POST['poll_expire'] < 0 ? 0 : $_POST['poll_expire']); |
1857 | 1963 | |
1858 | 1964 | // Just set it to zero if it's not there.. |
1859 | - if (!isset($_POST['poll_hide'])) |
|
1860 | - $_POST['poll_hide'] = 0; |
|
1861 | - else |
|
1862 | - $_POST['poll_hide'] = (int) $_POST['poll_hide']; |
|
1965 | + if (!isset($_POST['poll_hide'])) { |
|
1966 | + $_POST['poll_hide'] = 0; |
|
1967 | + } else { |
|
1968 | + $_POST['poll_hide'] = (int) $_POST['poll_hide']; |
|
1969 | + } |
|
1863 | 1970 | $_POST['poll_change_vote'] = isset($_POST['poll_change_vote']) ? 1 : 0; |
1864 | 1971 | |
1865 | 1972 | $_POST['poll_guest_vote'] = isset($_POST['poll_guest_vote']) ? 1 : 0; |
@@ -1868,16 +1975,19 @@ discard block |
||
1868 | 1975 | { |
1869 | 1976 | require_once($sourcedir . '/Subs-Members.php'); |
1870 | 1977 | $allowedVoteGroups = groupsAllowedTo('poll_vote', $board); |
1871 | - if (!in_array(-1, $allowedVoteGroups['allowed'])) |
|
1872 | - $_POST['poll_guest_vote'] = 0; |
|
1978 | + if (!in_array(-1, $allowedVoteGroups['allowed'])) { |
|
1979 | + $_POST['poll_guest_vote'] = 0; |
|
1980 | + } |
|
1873 | 1981 | } |
1874 | 1982 | |
1875 | 1983 | // If the user tries to set the poll too far in advance, don't let them. |
1876 | - if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) |
|
1877 | - fatal_lang_error('poll_range_error', false); |
|
1984 | + if (!empty($_POST['poll_expire']) && $_POST['poll_expire'] < 1) { |
|
1985 | + fatal_lang_error('poll_range_error', false); |
|
1986 | + } |
|
1878 | 1987 | // Don't allow them to select option 2 for hidden results if it's not time limited. |
1879 | - elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) |
|
1880 | - $_POST['poll_hide'] = 1; |
|
1988 | + elseif (empty($_POST['poll_expire']) && $_POST['poll_hide'] == 2) { |
|
1989 | + $_POST['poll_hide'] = 1; |
|
1990 | + } |
|
1881 | 1991 | |
1882 | 1992 | // Clean up the question and answers. |
1883 | 1993 | $_POST['question'] = $smcFunc['htmlspecialchars']($_POST['question']); |
@@ -1891,13 +2001,15 @@ discard block |
||
1891 | 2001 | { |
1892 | 2002 | $attachIDs = array(); |
1893 | 2003 | $attach_errors = array(); |
1894 | - if (!empty($context['we_are_history'])) |
|
1895 | - $attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>'; |
|
2004 | + if (!empty($context['we_are_history'])) { |
|
2005 | + $attach_errors[] = '<dd>' . $txt['error_temp_attachments_flushed'] . '<br><br></dd>'; |
|
2006 | + } |
|
1896 | 2007 | |
1897 | 2008 | foreach ($_SESSION['temp_attachments'] as $attachID => $attachment) |
1898 | 2009 | { |
1899 | - if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) |
|
1900 | - continue; |
|
2010 | + if ($attachID != 'initial_error' && strpos($attachID, 'post_tmp_' . $user_info['id']) === false) { |
|
2011 | + continue; |
|
2012 | + } |
|
1901 | 2013 | |
1902 | 2014 | // If there was an initial error just show that message. |
1903 | 2015 | if ($attachID == 'initial_error') |
@@ -1926,12 +2038,13 @@ discard block |
||
1926 | 2038 | if (createAttachment($attachmentOptions)) |
1927 | 2039 | { |
1928 | 2040 | $attachIDs[] = $attachmentOptions['id']; |
1929 | - if (!empty($attachmentOptions['thumb'])) |
|
1930 | - $attachIDs[] = $attachmentOptions['thumb']; |
|
2041 | + if (!empty($attachmentOptions['thumb'])) { |
|
2042 | + $attachIDs[] = $attachmentOptions['thumb']; |
|
2043 | + } |
|
1931 | 2044 | } |
2045 | + } else { |
|
2046 | + $attach_errors[] = '<dt> </dt>'; |
|
1932 | 2047 | } |
1933 | - else |
|
1934 | - $attach_errors[] = '<dt> </dt>'; |
|
1935 | 2048 | |
1936 | 2049 | if (!empty($attachmentOptions['errors'])) |
1937 | 2050 | { |
@@ -1943,14 +2056,16 @@ discard block |
||
1943 | 2056 | if (!is_array($error)) |
1944 | 2057 | { |
1945 | 2058 | $attach_errors[] = '<dd>' . $txt[$error] . '</dd>'; |
1946 | - if (in_array($error, $log_these)) |
|
1947 | - log_error($attachment['name'] . ': ' . $txt[$error], 'critical'); |
|
2059 | + if (in_array($error, $log_these)) { |
|
2060 | + log_error($attachment['name'] . ': ' . $txt[$error], 'critical'); |
|
2061 | + } |
|
2062 | + } else { |
|
2063 | + $attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>'; |
|
1948 | 2064 | } |
1949 | - else |
|
1950 | - $attach_errors[] = '<dd>' . vsprintf($txt[$error[0]], $error[1]) . '</dd>'; |
|
1951 | 2065 | } |
1952 | - if (file_exists($attachment['tmp_name'])) |
|
1953 | - unlink($attachment['tmp_name']); |
|
2066 | + if (file_exists($attachment['tmp_name'])) { |
|
2067 | + unlink($attachment['tmp_name']); |
|
2068 | + } |
|
1954 | 2069 | } |
1955 | 2070 | } |
1956 | 2071 | unset($_SESSION['temp_attachments']); |
@@ -1991,24 +2106,24 @@ discard block |
||
1991 | 2106 | ); |
1992 | 2107 | |
1993 | 2108 | call_integration_hook('integrate_poll_add_edit', array($id_poll, false)); |
2109 | + } else { |
|
2110 | + $id_poll = 0; |
|
1994 | 2111 | } |
1995 | - else |
|
1996 | - $id_poll = 0; |
|
1997 | 2112 | |
1998 | 2113 | // Creating a new topic? |
1999 | 2114 | $newTopic = empty($_REQUEST['msg']) && empty($topic); |
2000 | 2115 | |
2001 | 2116 | // Check the icon. |
2002 | - if (!isset($_POST['icon'])) |
|
2003 | - $_POST['icon'] = 'xx'; |
|
2004 | - |
|
2005 | - else |
|
2117 | + if (!isset($_POST['icon'])) { |
|
2118 | + $_POST['icon'] = 'xx'; |
|
2119 | + } else |
|
2006 | 2120 | { |
2007 | 2121 | $_POST['icon'] = $smcFunc['htmlspecialchars']($_POST['icon']); |
2008 | 2122 | |
2009 | 2123 | // Need to figure it out if this is a valid icon name. |
2010 | - if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) |
|
2011 | - $_POST['icon'] = 'xx'; |
|
2124 | + if ((!file_exists($settings['theme_dir'] . '/images/post/' . $_POST['icon'] . '.png')) && (!file_exists($settings['default_theme_dir'] . '/images/post/' . $_POST['icon'] . '.png'))) { |
|
2125 | + $_POST['icon'] = 'xx'; |
|
2126 | + } |
|
2012 | 2127 | } |
2013 | 2128 | |
2014 | 2129 | // Collect all parameters for the creation or modification of a post. |
@@ -2049,8 +2164,9 @@ discard block |
||
2049 | 2164 | } |
2050 | 2165 | |
2051 | 2166 | // This will save some time... |
2052 | - if (empty($approve_has_changed)) |
|
2053 | - unset($msgOptions['approved']); |
|
2167 | + if (empty($approve_has_changed)) { |
|
2168 | + unset($msgOptions['approved']); |
|
2169 | + } |
|
2054 | 2170 | |
2055 | 2171 | modifyPost($msgOptions, $topicOptions, $posterOptions); |
2056 | 2172 | } |
@@ -2059,8 +2175,9 @@ discard block |
||
2059 | 2175 | { |
2060 | 2176 | createPost($msgOptions, $topicOptions, $posterOptions); |
2061 | 2177 | |
2062 | - if (isset($topicOptions['id'])) |
|
2063 | - $topic = $topicOptions['id']; |
|
2178 | + if (isset($topicOptions['id'])) { |
|
2179 | + $topic = $topicOptions['id']; |
|
2180 | + } |
|
2064 | 2181 | } |
2065 | 2182 | |
2066 | 2183 | // Assign the previously uploaded attachments to the brand new message. |
@@ -2072,8 +2189,9 @@ discard block |
||
2072 | 2189 | } |
2073 | 2190 | |
2074 | 2191 | // If we had a draft for this, its time to remove it since it was just posted |
2075 | - if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) |
|
2076 | - DeleteDraft($_POST['id_draft']); |
|
2192 | + if (!empty($modSettings['drafts_post_enabled']) && !empty($_POST['id_draft'])) { |
|
2193 | + DeleteDraft($_POST['id_draft']); |
|
2194 | + } |
|
2077 | 2195 | |
2078 | 2196 | // Editing or posting an event? |
2079 | 2197 | if (isset($_POST['calendar']) && (!isset($_REQUEST['eventid']) || $_REQUEST['eventid'] == -1)) |
@@ -2092,8 +2210,7 @@ discard block |
||
2092 | 2210 | 'member' => $user_info['id'], |
2093 | 2211 | ); |
2094 | 2212 | insertEvent($eventOptions); |
2095 | - } |
|
2096 | - elseif (isset($_POST['calendar'])) |
|
2213 | + } elseif (isset($_POST['calendar'])) |
|
2097 | 2214 | { |
2098 | 2215 | $_REQUEST['eventid'] = (int) $_REQUEST['eventid']; |
2099 | 2216 | |
@@ -2121,14 +2238,15 @@ discard block |
||
2121 | 2238 | } |
2122 | 2239 | |
2123 | 2240 | // Delete it? |
2124 | - if (isset($_REQUEST['deleteevent'])) |
|
2125 | - $smcFunc['db_query']('', ' |
|
2241 | + if (isset($_REQUEST['deleteevent'])) { |
|
2242 | + $smcFunc['db_query']('', ' |
|
2126 | 2243 | DELETE FROM {db_prefix}calendar |
2127 | 2244 | WHERE id_event = {int:id_event}', |
2128 | 2245 | array( |
2129 | 2246 | 'id_event' => $_REQUEST['eventid'], |
2130 | 2247 | ) |
2131 | 2248 | ); |
2249 | + } |
|
2132 | 2250 | // ... or just update it? |
2133 | 2251 | else |
2134 | 2252 | { |
@@ -2170,9 +2288,8 @@ discard block |
||
2170 | 2288 | array($user_info['id'], $topic, 0), |
2171 | 2289 | array('id_member', 'id_topic', 'id_board') |
2172 | 2290 | ); |
2173 | - } |
|
2174 | - elseif (!$newTopic) |
|
2175 | - $smcFunc['db_query']('', ' |
|
2291 | + } elseif (!$newTopic) { |
|
2292 | + $smcFunc['db_query']('', ' |
|
2176 | 2293 | DELETE FROM {db_prefix}log_notify |
2177 | 2294 | WHERE id_member = {int:current_member} |
2178 | 2295 | AND id_topic = {int:current_topic}', |
@@ -2181,16 +2298,20 @@ discard block |
||
2181 | 2298 | 'current_topic' => $topic, |
2182 | 2299 | ) |
2183 | 2300 | ); |
2301 | + } |
|
2184 | 2302 | |
2185 | 2303 | // Log an act of moderation - modifying. |
2186 | - if (!empty($moderationAction)) |
|
2187 | - logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board)); |
|
2304 | + if (!empty($moderationAction)) { |
|
2305 | + logAction('modify', array('topic' => $topic, 'message' => (int) $_REQUEST['msg'], 'member' => $row['id_member'], 'board' => $board)); |
|
2306 | + } |
|
2188 | 2307 | |
2189 | - if (isset($_POST['lock']) && $_POST['lock'] != 2) |
|
2190 | - logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board'])); |
|
2308 | + if (isset($_POST['lock']) && $_POST['lock'] != 2) { |
|
2309 | + logAction(empty($_POST['lock']) ? 'unlock' : 'lock', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board'])); |
|
2310 | + } |
|
2191 | 2311 | |
2192 | - if (isset($_POST['sticky'])) |
|
2193 | - logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board'])); |
|
2312 | + if (isset($_POST['sticky'])) { |
|
2313 | + logAction(empty($_POST['sticky']) ? 'unsticky' : 'sticky', array('topic' => $topicOptions['id'], 'board' => $topicOptions['board'])); |
|
2314 | + } |
|
2194 | 2315 | |
2195 | 2316 | // Returning to the topic? |
2196 | 2317 | if (!empty($_REQUEST['goback'])) |
@@ -2209,26 +2330,31 @@ discard block |
||
2209 | 2330 | ); |
2210 | 2331 | } |
2211 | 2332 | |
2212 | - if ($board_info['num_topics'] == 0) |
|
2213 | - cache_put_data('board-' . $board, null, 120); |
|
2333 | + if ($board_info['num_topics'] == 0) { |
|
2334 | + cache_put_data('board-' . $board, null, 120); |
|
2335 | + } |
|
2214 | 2336 | |
2215 | 2337 | call_integration_hook('integrate_post2_end'); |
2216 | 2338 | |
2217 | - if (!empty($_POST['announce_topic'])) |
|
2218 | - redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2339 | + if (!empty($_POST['announce_topic'])) { |
|
2340 | + redirectexit('action=announce;sa=selectgroup;topic=' . $topic . (!empty($_POST['move']) && allowedTo('move_any') ? ';move' : '') . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2341 | + } |
|
2219 | 2342 | |
2220 | - if (!empty($_POST['move']) && allowedTo('move_any')) |
|
2221 | - redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2343 | + if (!empty($_POST['move']) && allowedTo('move_any')) { |
|
2344 | + redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2345 | + } |
|
2222 | 2346 | |
2223 | 2347 | // Return to post if the mod is on. |
2224 | - if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) |
|
2225 | - redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie')); |
|
2226 | - elseif (!empty($_REQUEST['goback'])) |
|
2227 | - redirectexit('topic=' . $topic . '.new#new', isBrowser('ie')); |
|
2348 | + if (isset($_REQUEST['msg']) && !empty($_REQUEST['goback'])) { |
|
2349 | + redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg'], isBrowser('ie')); |
|
2350 | + } elseif (!empty($_REQUEST['goback'])) { |
|
2351 | + redirectexit('topic=' . $topic . '.new#new', isBrowser('ie')); |
|
2352 | + } |
|
2228 | 2353 | // Dut-dut-duh-duh-DUH-duh-dut-duh-duh! *dances to the Final Fantasy Fanfare...* |
2229 | - else |
|
2230 | - redirectexit('board=' . $board . '.0'); |
|
2231 | -} |
|
2354 | + else { |
|
2355 | + redirectexit('board=' . $board . '.0'); |
|
2356 | + } |
|
2357 | + } |
|
2232 | 2358 | |
2233 | 2359 | /** |
2234 | 2360 | * Handle the announce topic function (action=announce). |
@@ -2246,8 +2372,9 @@ discard block |
||
2246 | 2372 | |
2247 | 2373 | validateSession(); |
2248 | 2374 | |
2249 | - if (empty($topic)) |
|
2250 | - fatal_lang_error('topic_gone', false); |
|
2375 | + if (empty($topic)) { |
|
2376 | + fatal_lang_error('topic_gone', false); |
|
2377 | + } |
|
2251 | 2378 | |
2252 | 2379 | loadLanguage('Post'); |
2253 | 2380 | loadTemplate('Post'); |
@@ -2274,8 +2401,9 @@ discard block |
||
2274 | 2401 | global $txt, $context, $topic, $board, $board_info, $smcFunc; |
2275 | 2402 | |
2276 | 2403 | $groups = array_merge($board_info['groups'], array(1)); |
2277 | - foreach ($groups as $id => $group) |
|
2278 | - $groups[$id] = (int) $group; |
|
2404 | + foreach ($groups as $id => $group) { |
|
2405 | + $groups[$id] = (int) $group; |
|
2406 | + } |
|
2279 | 2407 | |
2280 | 2408 | $context['groups'] = array(); |
2281 | 2409 | if (in_array(0, $groups)) |
@@ -2318,8 +2446,9 @@ discard block |
||
2318 | 2446 | 'group_list' => $groups, |
2319 | 2447 | ) |
2320 | 2448 | ); |
2321 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
2322 | - $context['groups'][$row['id_group']]['name'] = $row['group_name']; |
|
2449 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
2450 | + $context['groups'][$row['id_group']]['name'] = $row['group_name']; |
|
2451 | + } |
|
2323 | 2452 | $smcFunc['db_free_result']($request); |
2324 | 2453 | |
2325 | 2454 | // Get the subject of the topic we're about to announce. |
@@ -2361,16 +2490,19 @@ discard block |
||
2361 | 2490 | $context['start'] = empty($_REQUEST['start']) ? 0 : (int) $_REQUEST['start']; |
2362 | 2491 | $groups = array_merge($board_info['groups'], array(1)); |
2363 | 2492 | |
2364 | - if (isset($_POST['membergroups'])) |
|
2365 | - $_POST['who'] = explode(',', $_POST['membergroups']); |
|
2493 | + if (isset($_POST['membergroups'])) { |
|
2494 | + $_POST['who'] = explode(',', $_POST['membergroups']); |
|
2495 | + } |
|
2366 | 2496 | |
2367 | 2497 | // Check whether at least one membergroup was selected. |
2368 | - if (empty($_POST['who'])) |
|
2369 | - fatal_lang_error('no_membergroup_selected'); |
|
2498 | + if (empty($_POST['who'])) { |
|
2499 | + fatal_lang_error('no_membergroup_selected'); |
|
2500 | + } |
|
2370 | 2501 | |
2371 | 2502 | // Make sure all membergroups are integers and can access the board of the announcement. |
2372 | - foreach ($_POST['who'] as $id => $mg) |
|
2373 | - $_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0; |
|
2503 | + foreach ($_POST['who'] as $id => $mg) { |
|
2504 | + $_POST['who'][$id] = in_array((int) $mg, $groups) ? (int) $mg : 0; |
|
2505 | + } |
|
2374 | 2506 | |
2375 | 2507 | // Get the topic subject and censor it. |
2376 | 2508 | $request = $smcFunc['db_query']('', ' |
@@ -2416,12 +2548,13 @@ discard block |
||
2416 | 2548 | if ($smcFunc['db_num_rows']($request) == 0) |
2417 | 2549 | { |
2418 | 2550 | logAction('announce_topic', array('topic' => $topic), 'user'); |
2419 | - if (!empty($_REQUEST['move']) && allowedTo('move_any')) |
|
2420 | - redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2421 | - elseif (!empty($_REQUEST['goback'])) |
|
2422 | - redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie')); |
|
2423 | - else |
|
2424 | - redirectexit('board=' . $board . '.0'); |
|
2551 | + if (!empty($_REQUEST['move']) && allowedTo('move_any')) { |
|
2552 | + redirectexit('action=movetopic;topic=' . $topic . '.0' . (empty($_REQUEST['goback']) ? '' : ';goback')); |
|
2553 | + } elseif (!empty($_REQUEST['goback'])) { |
|
2554 | + redirectexit('topic=' . $topic . '.new;boardseen#new', isBrowser('ie')); |
|
2555 | + } else { |
|
2556 | + redirectexit('board=' . $board . '.0'); |
|
2557 | + } |
|
2425 | 2558 | } |
2426 | 2559 | |
2427 | 2560 | $announcements = array(); |
@@ -2440,8 +2573,9 @@ discard block |
||
2440 | 2573 | foreach ($rows as $row) |
2441 | 2574 | { |
2442 | 2575 | // Force them to have it? |
2443 | - if (empty($prefs[$row['id_member']]['announcements'])) |
|
2444 | - continue; |
|
2576 | + if (empty($prefs[$row['id_member']]['announcements'])) { |
|
2577 | + continue; |
|
2578 | + } |
|
2445 | 2579 | |
2446 | 2580 | $cur_language = empty($row['lngfile']) || empty($modSettings['userLanguage']) ? $language : $row['lngfile']; |
2447 | 2581 | |
@@ -2469,8 +2603,9 @@ discard block |
||
2469 | 2603 | } |
2470 | 2604 | |
2471 | 2605 | // For each language send a different mail - low priority... |
2472 | - foreach ($announcements as $lang => $mail) |
|
2473 | - sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5); |
|
2606 | + foreach ($announcements as $lang => $mail) { |
|
2607 | + sendmail($mail['recipients'], $mail['subject'], $mail['body'], null, 'ann-' . $lang, $mail['is_html'], 5); |
|
2608 | + } |
|
2474 | 2609 | |
2475 | 2610 | $context['percentage_done'] = round(100 * $context['start'] / $modSettings['latestMember'], 1); |
2476 | 2611 | |
@@ -2480,9 +2615,10 @@ discard block |
||
2480 | 2615 | $context['sub_template'] = 'announcement_send'; |
2481 | 2616 | |
2482 | 2617 | // Go back to the correct language for the user ;). |
2483 | - if (!empty($modSettings['userLanguage'])) |
|
2484 | - loadLanguage('Post'); |
|
2485 | -} |
|
2618 | + if (!empty($modSettings['userLanguage'])) { |
|
2619 | + loadLanguage('Post'); |
|
2620 | + } |
|
2621 | + } |
|
2486 | 2622 | |
2487 | 2623 | /** |
2488 | 2624 | * Get the topic for display purposes. |
@@ -2495,12 +2631,13 @@ discard block |
||
2495 | 2631 | { |
2496 | 2632 | global $topic, $modSettings, $context, $smcFunc, $counter, $options; |
2497 | 2633 | |
2498 | - if (isset($_REQUEST['xml'])) |
|
2499 | - $limit = ' |
|
2634 | + if (isset($_REQUEST['xml'])) { |
|
2635 | + $limit = ' |
|
2500 | 2636 | LIMIT ' . (empty($context['new_replies']) ? '0' : $context['new_replies']); |
2501 | - else |
|
2502 | - $limit = empty($modSettings['topicSummaryPosts']) ? '' : ' |
|
2637 | + } else { |
|
2638 | + $limit = empty($modSettings['topicSummaryPosts']) ? '' : ' |
|
2503 | 2639 | LIMIT ' . (int) $modSettings['topicSummaryPosts']; |
2640 | + } |
|
2504 | 2641 | |
2505 | 2642 | // If you're modifying, get only those posts before the current one. (otherwise get all.) |
2506 | 2643 | $request = $smcFunc['db_query']('', ' |
@@ -2538,8 +2675,9 @@ discard block |
||
2538 | 2675 | 'is_ignored' => !empty($modSettings['enable_buddylist']) && !empty($options['posts_apply_ignore_list']) && in_array($row['id_member'], $context['user']['ignoreusers']), |
2539 | 2676 | ); |
2540 | 2677 | |
2541 | - if (!empty($context['new_replies'])) |
|
2542 | - $context['new_replies']--; |
|
2678 | + if (!empty($context['new_replies'])) { |
|
2679 | + $context['new_replies']--; |
|
2680 | + } |
|
2543 | 2681 | } |
2544 | 2682 | $smcFunc['db_free_result']($request); |
2545 | 2683 | } |
@@ -2556,8 +2694,9 @@ discard block |
||
2556 | 2694 | global $sourcedir, $smcFunc; |
2557 | 2695 | |
2558 | 2696 | loadLanguage('Post'); |
2559 | - if (!isset($_REQUEST['xml'])) |
|
2560 | - loadTemplate('Post'); |
|
2697 | + if (!isset($_REQUEST['xml'])) { |
|
2698 | + loadTemplate('Post'); |
|
2699 | + } |
|
2561 | 2700 | |
2562 | 2701 | include_once($sourcedir . '/Subs-Post.php'); |
2563 | 2702 | |
@@ -2588,8 +2727,9 @@ discard block |
||
2588 | 2727 | $smcFunc['db_free_result']($request); |
2589 | 2728 | |
2590 | 2729 | $context['sub_template'] = 'quotefast'; |
2591 | - if (!empty($row)) |
|
2592 | - $can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']); |
|
2730 | + if (!empty($row)) { |
|
2731 | + $can_view_post = $row['approved'] || ($row['id_member'] != 0 && $row['id_member'] == $user_info['id']) || allowedTo('approve_posts', $row['id_board']); |
|
2732 | + } |
|
2593 | 2733 | |
2594 | 2734 | if (!empty($can_view_post)) |
2595 | 2735 | { |
@@ -2622,8 +2762,9 @@ discard block |
||
2622 | 2762 | } |
2623 | 2763 | |
2624 | 2764 | // Remove any nested quotes. |
2625 | - if (!empty($modSettings['removeNestedQuotes'])) |
|
2626 | - $row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']); |
|
2765 | + if (!empty($modSettings['removeNestedQuotes'])) { |
|
2766 | + $row['body'] = preg_replace(array('~\n?\[quote.*?\].+?\[/quote\]\n?~is', '~^\n~', '~\[/quote\]~'), '', $row['body']); |
|
2767 | + } |
|
2627 | 2768 | |
2628 | 2769 | $lb = "\n"; |
2629 | 2770 | |
@@ -2649,14 +2790,14 @@ discard block |
||
2649 | 2790 | 'time' => '', |
2650 | 2791 | ), |
2651 | 2792 | ); |
2652 | - } |
|
2653 | - else |
|
2654 | - $context['quote'] = array( |
|
2793 | + } else { |
|
2794 | + $context['quote'] = array( |
|
2655 | 2795 | 'xml' => '', |
2656 | 2796 | 'mozilla' => '', |
2657 | 2797 | 'text' => '', |
2658 | 2798 | ); |
2659 | -} |
|
2799 | + } |
|
2800 | + } |
|
2660 | 2801 | |
2661 | 2802 | /** |
2662 | 2803 | * Used to edit the body or subject of a message inline |
@@ -2668,8 +2809,9 @@ discard block |
||
2668 | 2809 | global $user_info, $context, $smcFunc, $language, $board_info; |
2669 | 2810 | |
2670 | 2811 | // We have to have a topic! |
2671 | - if (empty($topic)) |
|
2672 | - obExit(false); |
|
2812 | + if (empty($topic)) { |
|
2813 | + obExit(false); |
|
2814 | + } |
|
2673 | 2815 | |
2674 | 2816 | checkSession('get'); |
2675 | 2817 | require_once($sourcedir . '/Subs-Post.php'); |
@@ -2695,31 +2837,35 @@ discard block |
||
2695 | 2837 | 'guest_id' => 0, |
2696 | 2838 | ) |
2697 | 2839 | ); |
2698 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
2699 | - fatal_lang_error('no_board', false); |
|
2840 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
2841 | + fatal_lang_error('no_board', false); |
|
2842 | + } |
|
2700 | 2843 | $row = $smcFunc['db_fetch_assoc']($request); |
2701 | 2844 | $smcFunc['db_free_result']($request); |
2702 | 2845 | |
2703 | 2846 | // Change either body or subject requires permissions to modify messages. |
2704 | 2847 | if (isset($_POST['message']) || isset($_POST['subject']) || isset($_REQUEST['icon'])) |
2705 | 2848 | { |
2706 | - if (!empty($row['locked'])) |
|
2707 | - isAllowedTo('moderate_board'); |
|
2849 | + if (!empty($row['locked'])) { |
|
2850 | + isAllowedTo('moderate_board'); |
|
2851 | + } |
|
2708 | 2852 | |
2709 | 2853 | if ($row['id_member'] == $user_info['id'] && !allowedTo('modify_any')) |
2710 | 2854 | { |
2711 | - if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) |
|
2712 | - fatal_lang_error('modify_post_time_passed', false); |
|
2713 | - elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) |
|
2714 | - isAllowedTo('modify_replies'); |
|
2715 | - else |
|
2716 | - isAllowedTo('modify_own'); |
|
2855 | + if ((!$modSettings['postmod_active'] || $row['approved']) && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + ($modSettings['edit_disable_time'] + 5) * 60 < time()) { |
|
2856 | + fatal_lang_error('modify_post_time_passed', false); |
|
2857 | + } elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_own')) { |
|
2858 | + isAllowedTo('modify_replies'); |
|
2859 | + } else { |
|
2860 | + isAllowedTo('modify_own'); |
|
2861 | + } |
|
2717 | 2862 | } |
2718 | 2863 | // Otherwise, they're locked out; someone who can modify the replies is needed. |
2719 | - elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) |
|
2720 | - isAllowedTo('modify_replies'); |
|
2721 | - else |
|
2722 | - isAllowedTo('modify_any'); |
|
2864 | + elseif ($row['id_member_started'] == $user_info['id'] && !allowedTo('modify_any')) { |
|
2865 | + isAllowedTo('modify_replies'); |
|
2866 | + } else { |
|
2867 | + isAllowedTo('modify_any'); |
|
2868 | + } |
|
2723 | 2869 | |
2724 | 2870 | // Only log this action if it wasn't your message. |
2725 | 2871 | $moderationAction = $row['id_member'] != $user_info['id']; |
@@ -2731,10 +2877,10 @@ discard block |
||
2731 | 2877 | $_POST['subject'] = strtr($smcFunc['htmlspecialchars']($_POST['subject']), array("\r" => '', "\n" => '', "\t" => '')); |
2732 | 2878 | |
2733 | 2879 | // Maximum number of characters. |
2734 | - if ($smcFunc['strlen']($_POST['subject']) > 100) |
|
2735 | - $_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100); |
|
2736 | - } |
|
2737 | - elseif (isset($_POST['subject'])) |
|
2880 | + if ($smcFunc['strlen']($_POST['subject']) > 100) { |
|
2881 | + $_POST['subject'] = $smcFunc['substr']($_POST['subject'], 0, 100); |
|
2882 | + } |
|
2883 | + } elseif (isset($_POST['subject'])) |
|
2738 | 2884 | { |
2739 | 2885 | $post_errors[] = 'no_subject'; |
2740 | 2886 | unset($_POST['subject']); |
@@ -2746,13 +2892,11 @@ discard block |
||
2746 | 2892 | { |
2747 | 2893 | $post_errors[] = 'no_message'; |
2748 | 2894 | unset($_POST['message']); |
2749 | - } |
|
2750 | - elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) |
|
2895 | + } elseif (!empty($modSettings['max_messageLength']) && $smcFunc['strlen']($_POST['message']) > $modSettings['max_messageLength']) |
|
2751 | 2896 | { |
2752 | 2897 | $post_errors[] = 'long_message'; |
2753 | 2898 | unset($_POST['message']); |
2754 | - } |
|
2755 | - else |
|
2899 | + } else |
|
2756 | 2900 | { |
2757 | 2901 | $_POST['message'] = $smcFunc['htmlspecialchars']($_POST['message'], ENT_QUOTES); |
2758 | 2902 | |
@@ -2768,31 +2912,34 @@ discard block |
||
2768 | 2912 | |
2769 | 2913 | if (isset($_POST['lock'])) |
2770 | 2914 | { |
2771 | - if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) |
|
2772 | - unset($_POST['lock']); |
|
2773 | - elseif (!allowedTo('lock_any')) |
|
2915 | + if (!allowedTo(array('lock_any', 'lock_own')) || (!allowedTo('lock_any') && $user_info['id'] != $row['id_member'])) { |
|
2916 | + unset($_POST['lock']); |
|
2917 | + } elseif (!allowedTo('lock_any')) |
|
2774 | 2918 | { |
2775 | - if ($row['locked'] == 1) |
|
2776 | - unset($_POST['lock']); |
|
2777 | - else |
|
2778 | - $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
2919 | + if ($row['locked'] == 1) { |
|
2920 | + unset($_POST['lock']); |
|
2921 | + } else { |
|
2922 | + $_POST['lock'] = empty($_POST['lock']) ? 0 : 2; |
|
2923 | + } |
|
2924 | + } elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) { |
|
2925 | + unset($_POST['lock']); |
|
2926 | + } else { |
|
2927 | + $_POST['lock'] = empty($_POST['lock']) ? 0 : 1; |
|
2779 | 2928 | } |
2780 | - elseif (!empty($row['locked']) && !empty($_POST['lock']) || $_POST['lock'] == $row['locked']) |
|
2781 | - unset($_POST['lock']); |
|
2782 | - else |
|
2783 | - $_POST['lock'] = empty($_POST['lock']) ? 0 : 1; |
|
2784 | 2929 | } |
2785 | 2930 | |
2786 | - if (isset($_POST['sticky']) && !allowedTo('make_sticky')) |
|
2787 | - unset($_POST['sticky']); |
|
2931 | + if (isset($_POST['sticky']) && !allowedTo('make_sticky')) { |
|
2932 | + unset($_POST['sticky']); |
|
2933 | + } |
|
2788 | 2934 | |
2789 | 2935 | if (isset($_POST['modify_reason'])) |
2790 | 2936 | { |
2791 | 2937 | $_POST['modify_reason'] = strtr($smcFunc['htmlspecialchars']($_POST['modify_reason']), array("\r" => '', "\n" => '', "\t" => '')); |
2792 | 2938 | |
2793 | 2939 | // Maximum number of characters. |
2794 | - if ($smcFunc['strlen']($_POST['modify_reason']) > 100) |
|
2795 | - $_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100); |
|
2940 | + if ($smcFunc['strlen']($_POST['modify_reason']) > 100) { |
|
2941 | + $_POST['modify_reason'] = $smcFunc['substr']($_POST['modify_reason'], 0, 100); |
|
2942 | + } |
|
2796 | 2943 | } |
2797 | 2944 | |
2798 | 2945 | if (empty($post_errors)) |
@@ -2829,8 +2976,9 @@ discard block |
||
2829 | 2976 | } |
2830 | 2977 | } |
2831 | 2978 | // If nothing was changed there's no need to add an entry to the moderation log. |
2832 | - else |
|
2833 | - $moderationAction = false; |
|
2979 | + else { |
|
2980 | + $moderationAction = false; |
|
2981 | + } |
|
2834 | 2982 | |
2835 | 2983 | modifyPost($msgOptions, $topicOptions, $posterOptions); |
2836 | 2984 | |
@@ -2848,9 +2996,9 @@ discard block |
||
2848 | 2996 | // Get the proper (default language) response prefix first. |
2849 | 2997 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix'))) |
2850 | 2998 | { |
2851 | - if ($language === $user_info['language']) |
|
2852 | - $context['response_prefix'] = $txt['response_prefix']; |
|
2853 | - else |
|
2999 | + if ($language === $user_info['language']) { |
|
3000 | + $context['response_prefix'] = $txt['response_prefix']; |
|
3001 | + } else |
|
2854 | 3002 | { |
2855 | 3003 | loadLanguage('index', $language, false); |
2856 | 3004 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -2872,8 +3020,9 @@ discard block |
||
2872 | 3020 | ); |
2873 | 3021 | } |
2874 | 3022 | |
2875 | - if (!empty($moderationAction)) |
|
2876 | - logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board)); |
|
3023 | + if (!empty($moderationAction)) { |
|
3024 | + logAction('modify', array('topic' => $topic, 'message' => $row['id_msg'], 'member' => $row['id_member'], 'board' => $board)); |
|
3025 | + } |
|
2877 | 3026 | } |
2878 | 3027 | |
2879 | 3028 | if (isset($_REQUEST['xml'])) |
@@ -2914,8 +3063,7 @@ discard block |
||
2914 | 3063 | ); |
2915 | 3064 | |
2916 | 3065 | censorText($context['message']['subject']); |
2917 | - } |
|
2918 | - else |
|
3066 | + } else |
|
2919 | 3067 | { |
2920 | 3068 | $context['message'] = array( |
2921 | 3069 | 'id' => $row['id_msg'], |
@@ -2927,15 +3075,16 @@ discard block |
||
2927 | 3075 | loadLanguage('Errors'); |
2928 | 3076 | foreach ($post_errors as $post_error) |
2929 | 3077 | { |
2930 | - if ($post_error == 'long_message') |
|
2931 | - $context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']); |
|
2932 | - else |
|
2933 | - $context['message']['errors'][] = $txt['error_' . $post_error]; |
|
3078 | + if ($post_error == 'long_message') { |
|
3079 | + $context['message']['errors'][] = sprintf($txt['error_' . $post_error], $modSettings['max_messageLength']); |
|
3080 | + } else { |
|
3081 | + $context['message']['errors'][] = $txt['error_' . $post_error]; |
|
3082 | + } |
|
2934 | 3083 | } |
2935 | 3084 | } |
3085 | + } else { |
|
3086 | + obExit(false); |
|
3087 | + } |
|
2936 | 3088 | } |
2937 | - else |
|
2938 | - obExit(false); |
|
2939 | -} |
|
2940 | 3089 | |
2941 | 3090 | ?> |
2942 | 3091 | \ No newline at end of file |
@@ -240,8 +240,8 @@ |
||
240 | 240 | $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
241 | 241 | |
242 | 242 | $js_time_string = str_replace( |
243 | - array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
244 | - array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
243 | + array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
|
244 | + array('H', 'G', 'h', 'g', 'i', 'A', 'a', 'h:i:s A', 'H:i', 's', 'H:i:s', 'H:i:s'), |
|
245 | 245 | $time_string |
246 | 246 | ); |
247 | 247 |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 3 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * Show the calendar. |
@@ -47,12 +48,14 @@ discard block |
||
47 | 48 | 'post' => 'CalendarPost', |
48 | 49 | ); |
49 | 50 | |
50 | - if (isset($_GET['sa']) && isset($subActions[$_GET['sa']])) |
|
51 | - return call_helper($subActions[$_GET['sa']]); |
|
51 | + if (isset($_GET['sa']) && isset($subActions[$_GET['sa']])) { |
|
52 | + return call_helper($subActions[$_GET['sa']]); |
|
53 | + } |
|
52 | 54 | |
53 | 55 | // You can't do anything if the calendar is off. |
54 | - if (empty($modSettings['cal_enabled'])) |
|
55 | - fatal_lang_error('calendar_off', false); |
|
56 | + if (empty($modSettings['cal_enabled'])) { |
|
57 | + fatal_lang_error('calendar_off', false); |
|
58 | + } |
|
56 | 59 | |
57 | 60 | // This is gonna be needed... |
58 | 61 | loadTemplate('Calendar'); |
@@ -97,8 +100,9 @@ discard block |
||
97 | 100 | $context['view_week'] = isset($_GET['viewweek']); |
98 | 101 | |
99 | 102 | // Don't let search engines index weekly calendar pages. |
100 | - if ($context['view_week']) |
|
101 | - $context['robot_no_index'] = true; |
|
103 | + if ($context['view_week']) { |
|
104 | + $context['robot_no_index'] = true; |
|
105 | + } |
|
102 | 106 | |
103 | 107 | // Get the current day of month... |
104 | 108 | require_once($sourcedir . '/Subs-Calendar.php'); |
@@ -112,17 +116,20 @@ discard block |
||
112 | 116 | ); |
113 | 117 | |
114 | 118 | // Make sure the year and month are in valid ranges. |
115 | - if ($curPage['month'] < 1 || $curPage['month'] > 12) |
|
116 | - fatal_lang_error('invalid_month', false); |
|
117 | - if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear']) |
|
118 | - fatal_lang_error('invalid_year', false); |
|
119 | + if ($curPage['month'] < 1 || $curPage['month'] > 12) { |
|
120 | + fatal_lang_error('invalid_month', false); |
|
121 | + } |
|
122 | + if ($curPage['year'] < $modSettings['cal_minyear'] || $curPage['year'] > $modSettings['cal_maxyear']) { |
|
123 | + fatal_lang_error('invalid_year', false); |
|
124 | + } |
|
119 | 125 | // If we have a day clean that too. |
120 | 126 | if ($context['view_week']) |
121 | 127 | { |
122 | 128 | // Note $isValid is -1 < PHP 5.1 |
123 | 129 | $isValid = mktime(0, 0, 0, $curPage['month'], $curPage['day'], $curPage['year']); |
124 | - if ($curPage['day'] > 31 || !$isValid || $isValid == -1) |
|
125 | - fatal_lang_error('invalid_day', false); |
|
130 | + if ($curPage['day'] > 31 || !$isValid || $isValid == -1) { |
|
131 | + fatal_lang_error('invalid_day', false); |
|
132 | + } |
|
126 | 133 | } |
127 | 134 | |
128 | 135 | // Load all the context information needed to show the calendar grid. |
@@ -144,21 +151,24 @@ discard block |
||
144 | 151 | ); |
145 | 152 | |
146 | 153 | // Load up the main view. |
147 | - if ($context['view_week']) |
|
148 | - $context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions); |
|
149 | - else |
|
150 | - $context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
|
154 | + if ($context['view_week']) { |
|
155 | + $context['calendar_grid_main'] = getCalendarWeek($curPage['month'], $curPage['year'], $curPage['day'], $calendarOptions); |
|
156 | + } else { |
|
157 | + $context['calendar_grid_main'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
|
158 | + } |
|
151 | 159 | |
152 | 160 | // Load up the previous and next months. |
153 | 161 | $context['calendar_grid_current'] = getCalendarGrid($curPage['month'], $curPage['year'], $calendarOptions); |
154 | 162 | |
155 | 163 | // Only show previous month if it isn't pre-January of the min-year |
156 | - if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1) |
|
157 | - $context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true); |
|
164 | + if ($context['calendar_grid_current']['previous_calendar']['year'] > $modSettings['cal_minyear'] || $curPage['month'] != 1) { |
|
165 | + $context['calendar_grid_prev'] = getCalendarGrid($context['calendar_grid_current']['previous_calendar']['month'], $context['calendar_grid_current']['previous_calendar']['year'], $calendarOptions, true); |
|
166 | + } |
|
158 | 167 | |
159 | 168 | // Only show next month if it isn't post-December of the max-year |
160 | - if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12) |
|
161 | - $context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions); |
|
169 | + if ($context['calendar_grid_current']['next_calendar']['year'] < $modSettings['cal_maxyear'] || $curPage['month'] != 12) { |
|
170 | + $context['calendar_grid_next'] = getCalendarGrid($context['calendar_grid_current']['next_calendar']['month'], $context['calendar_grid_current']['next_calendar']['year'], $calendarOptions); |
|
171 | + } |
|
162 | 172 | |
163 | 173 | // Basic template stuff. |
164 | 174 | $context['allow_calendar_event'] = allowedTo('calendar_post'); |
@@ -191,17 +201,19 @@ discard block |
||
191 | 201 | 'name' => $txt['months'][$context['current_month']] . ' ' . $context['current_year'] |
192 | 202 | ); |
193 | 203 | // If applicable, add the current week to the linktree. |
194 | - if ($context['view_week']) |
|
195 | - $context['linktree'][] = array( |
|
204 | + if ($context['view_week']) { |
|
205 | + $context['linktree'][] = array( |
|
196 | 206 | 'url' => $scripturl . '?action=calendar;viewweek;year=' . $context['current_year'] . ';month=' . $context['current_month'] . ';day=' . $context['current_day'], |
197 | 207 | 'name' => $context['calendar_grid_main']['week_title'], |
198 | 208 | ); |
209 | + } |
|
199 | 210 | |
200 | 211 | // Build the calendar button array. |
201 | 212 | $context['calendar_buttons'] = array(); |
202 | 213 | |
203 | - if ($context['can_post']) |
|
204 | - $context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
214 | + if ($context['can_post']) { |
|
215 | + $context['calendar_buttons']['post_event'] = array('text' => 'calendar_post_event', 'image' => 'calendarpe.png', 'url' => $scripturl . '?action=calendar;sa=post;month=' . $context['current_month'] . ';year=' . $context['current_year'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
216 | + } |
|
205 | 217 | |
206 | 218 | // Allow mods to add additional buttons here |
207 | 219 | call_integration_hook('integrate_calendar_buttons'); |
@@ -230,14 +242,16 @@ discard block |
||
230 | 242 | require_once($sourcedir . '/Subs.php'); |
231 | 243 | |
232 | 244 | // Cast this for safety... |
233 | - if (isset($_REQUEST['eventid'])) |
|
234 | - $_REQUEST['eventid'] = (int) $_REQUEST['eventid']; |
|
245 | + if (isset($_REQUEST['eventid'])) { |
|
246 | + $_REQUEST['eventid'] = (int) $_REQUEST['eventid']; |
|
247 | + } |
|
235 | 248 | |
236 | 249 | // We want a fairly compact version of the time, but as close as possible to the user's settings. |
237 | - if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) |
|
238 | - $time_string = '%k:%M'; |
|
239 | - else |
|
240 | - $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
250 | + if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) { |
|
251 | + $time_string = '%k:%M'; |
|
252 | + } else { |
|
253 | + $time_string = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]); |
|
254 | + } |
|
241 | 255 | |
242 | 256 | $js_time_string = str_replace( |
243 | 257 | array('%H', '%k', '%I', '%l', '%M', '%p', '%P', '%r', '%R', '%S', '%T', '%X'), |
@@ -251,12 +265,14 @@ discard block |
||
251 | 265 | checkSession(); |
252 | 266 | |
253 | 267 | // Validate the post... |
254 | - if (!isset($_POST['link_to_board'])) |
|
255 | - validateEventPost(); |
|
268 | + if (!isset($_POST['link_to_board'])) { |
|
269 | + validateEventPost(); |
|
270 | + } |
|
256 | 271 | |
257 | 272 | // If you're not allowed to edit any events, you have to be the poster. |
258 | - if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any')) |
|
259 | - isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any')); |
|
273 | + if ($_REQUEST['eventid'] > 0 && !allowedTo('calendar_edit_any')) { |
|
274 | + isAllowedTo('calendar_edit_' . (!empty($user_info['id']) && getEventPoster($_REQUEST['eventid']) == $user_info['id'] ? 'own' : 'any')); |
|
275 | + } |
|
260 | 276 | |
261 | 277 | // New - and directing? |
262 | 278 | if (isset($_POST['link_to_board']) || empty($modSettings['cal_allow_unlinked'])) |
@@ -279,8 +295,9 @@ discard block |
||
279 | 295 | } |
280 | 296 | |
281 | 297 | // Deleting... |
282 | - elseif (isset($_REQUEST['deleteevent'])) |
|
283 | - removeEvent($_REQUEST['eventid']); |
|
298 | + elseif (isset($_REQUEST['deleteevent'])) { |
|
299 | + removeEvent($_REQUEST['eventid']); |
|
300 | + } |
|
284 | 301 | |
285 | 302 | // ... or just update it? |
286 | 303 | else |
@@ -302,14 +319,12 @@ discard block |
||
302 | 319 | $d = date_parse($_POST['start_date']); |
303 | 320 | $year = $d['year']; |
304 | 321 | $month = $d['month']; |
305 | - } |
|
306 | - elseif (isset($_POST['start_datetime'])) |
|
322 | + } elseif (isset($_POST['start_datetime'])) |
|
307 | 323 | { |
308 | 324 | $d = date_parse($_POST['start_datetime']); |
309 | 325 | $year = $d['year']; |
310 | 326 | $month = $d['month']; |
311 | - } |
|
312 | - else |
|
327 | + } else |
|
313 | 328 | { |
314 | 329 | $today = getdate(); |
315 | 330 | $year = isset($_POST['year']) ? $_POST['year'] : $today['year']; |
@@ -342,13 +357,13 @@ discard block |
||
342 | 357 | $context['event'] = array_merge($context['event'], $eventDatetimes); |
343 | 358 | |
344 | 359 | $context['event']['last_day'] = (int) strftime('%d', mktime(0, 0, 0, $context['event']['month'] == 12 ? 1 : $context['event']['month'] + 1, 0, $context['event']['month'] == 12 ? $context['event']['year'] + 1 : $context['event']['year'])); |
345 | - } |
|
346 | - else |
|
360 | + } else |
|
347 | 361 | { |
348 | 362 | $context['event'] = getEventProperties($_REQUEST['eventid']); |
349 | 363 | |
350 | - if ($context['event'] === false) |
|
351 | - fatal_lang_error('no_access', false); |
|
364 | + if ($context['event'] === false) { |
|
365 | + fatal_lang_error('no_access', false); |
|
366 | + } |
|
352 | 367 | |
353 | 368 | // If it has a board, then they should be editing it within the topic. |
354 | 369 | if (!empty($context['event']['topic']['id']) && !empty($context['event']['topic']['first_msg'])) |
@@ -359,10 +374,11 @@ discard block |
||
359 | 374 | } |
360 | 375 | |
361 | 376 | // Make sure the user is allowed to edit this event. |
362 | - if ($context['event']['member'] != $user_info['id']) |
|
363 | - isAllowedTo('calendar_edit_any'); |
|
364 | - elseif (!allowedTo('calendar_edit_any')) |
|
365 | - isAllowedTo('calendar_edit_own'); |
|
377 | + if ($context['event']['member'] != $user_info['id']) { |
|
378 | + isAllowedTo('calendar_edit_any'); |
|
379 | + } elseif (!allowedTo('calendar_edit_any')) { |
|
380 | + isAllowedTo('calendar_edit_own'); |
|
381 | + } |
|
366 | 382 | } |
367 | 383 | |
368 | 384 | // An all day event? Set up some nice defaults in case the user wants to change that |
@@ -396,8 +412,7 @@ discard block |
||
396 | 412 | { |
397 | 413 | // You can post new events but can't link them to anything... |
398 | 414 | $context['event']['categories'] = array(); |
399 | - } |
|
400 | - else |
|
415 | + } else |
|
401 | 416 | { |
402 | 417 | // Load the list of boards and categories in the context. |
403 | 418 | require_once($sourcedir . '/Subs-MessageIndex.php'); |
@@ -484,12 +499,14 @@ discard block |
||
484 | 499 | global $smcFunc, $sourcedir, $forum_version, $modSettings, $webmaster_email, $mbname; |
485 | 500 | |
486 | 501 | // You can't export if the calendar export feature is off. |
487 | - if (empty($modSettings['cal_export'])) |
|
488 | - fatal_lang_error('calendar_export_off', false); |
|
502 | + if (empty($modSettings['cal_export'])) { |
|
503 | + fatal_lang_error('calendar_export_off', false); |
|
504 | + } |
|
489 | 505 | |
490 | 506 | // Goes without saying that this is required. |
491 | - if (!isset($_REQUEST['eventid'])) |
|
492 | - fatal_lang_error('no_access', false); |
|
507 | + if (!isset($_REQUEST['eventid'])) { |
|
508 | + fatal_lang_error('no_access', false); |
|
509 | + } |
|
493 | 510 | |
494 | 511 | // This is kinda wanted. |
495 | 512 | require_once($sourcedir . '/Subs-Calendar.php'); |
@@ -497,15 +514,17 @@ discard block |
||
497 | 514 | // Load up the event in question and check it exists. |
498 | 515 | $event = getEventProperties($_REQUEST['eventid']); |
499 | 516 | |
500 | - if ($event === false) |
|
501 | - fatal_lang_error('no_access', false); |
|
517 | + if ($event === false) { |
|
518 | + fatal_lang_error('no_access', false); |
|
519 | + } |
|
502 | 520 | |
503 | 521 | // Check the title isn't too long - iCal requires some formatting if so. |
504 | 522 | $title = str_split($event['title'], 30); |
505 | 523 | foreach ($title as $id => $line) |
506 | 524 | { |
507 | - if ($id != 0) |
|
508 | - $title[$id] = ' ' . $title[$id]; |
|
525 | + if ($id != 0) { |
|
526 | + $title[$id] = ' ' . $title[$id]; |
|
527 | + } |
|
509 | 528 | $title[$id] .= "\n"; |
510 | 529 | } |
511 | 530 | |
@@ -518,8 +537,7 @@ discard block |
||
518 | 537 | { |
519 | 538 | $datestart = date_format($start_date, 'Ymd\THis'); |
520 | 539 | $dateend = date_format($end_date, 'Ymd\THis'); |
521 | - } |
|
522 | - else |
|
540 | + } else |
|
523 | 541 | { |
524 | 542 | $datestart = date_format($start_date, 'Ymd'); |
525 | 543 | |
@@ -540,15 +558,18 @@ discard block |
||
540 | 558 | $filecontents .= 'DTSTART' . (!empty($event['start_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $datestart . "\n"; |
541 | 559 | |
542 | 560 | // event has a duration |
543 | - if ($event['start_iso_gmdate'] != $event['end_iso_gmdate']) |
|
544 | - $filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n"; |
|
561 | + if ($event['start_iso_gmdate'] != $event['end_iso_gmdate']) { |
|
562 | + $filecontents .= 'DTEND' . (!empty($event['end_time']) ? ';TZID=' . $event['tz'] : ';VALUE=DATE') . ':' . $dateend . "\n"; |
|
563 | + } |
|
545 | 564 | |
546 | 565 | // event has changed? advance the sequence for this UID |
547 | - if ($event['sequence'] > 0) |
|
548 | - $filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n"; |
|
566 | + if ($event['sequence'] > 0) { |
|
567 | + $filecontents .= 'SEQUENCE:' . $event['sequence'] . "\n"; |
|
568 | + } |
|
549 | 569 | |
550 | - if (!empty($event['location'])) |
|
551 | - $filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n"; |
|
570 | + if (!empty($event['location'])) { |
|
571 | + $filecontents .= 'LOCATION:' . str_replace(',', '\,', $event['location']) . "\n"; |
|
572 | + } |
|
552 | 573 | |
553 | 574 | $filecontents .= 'SUMMARY:' . implode('', $title); |
554 | 575 | $filecontents .= 'UID:' . $event['eventid'] . '@' . str_replace(' ', '-', $mbname) . "\n"; |
@@ -557,23 +578,26 @@ discard block |
||
557 | 578 | |
558 | 579 | // Send some standard headers. |
559 | 580 | ob_end_clean(); |
560 | - if (!empty($modSettings['enableCompressedOutput'])) |
|
561 | - @ob_start('ob_gzhandler'); |
|
562 | - else |
|
563 | - ob_start(); |
|
581 | + if (!empty($modSettings['enableCompressedOutput'])) { |
|
582 | + @ob_start('ob_gzhandler'); |
|
583 | + } else { |
|
584 | + ob_start(); |
|
585 | + } |
|
564 | 586 | |
565 | 587 | // Send the file headers |
566 | 588 | header('Pragma: '); |
567 | 589 | header('Cache-Control: no-cache'); |
568 | - if (!isBrowser('gecko')) |
|
569 | - header('Content-Transfer-Encoding: binary'); |
|
590 | + if (!isBrowser('gecko')) { |
|
591 | + header('Content-Transfer-Encoding: binary'); |
|
592 | + } |
|
570 | 593 | header('Expires: ' . gmdate('D, d M Y H:i:s', time() + 525600 * 60) . ' GMT'); |
571 | 594 | header('Last-Modified: ' . gmdate('D, d M Y H:i:s', time()) . 'GMT'); |
572 | 595 | header('Accept-Ranges: bytes'); |
573 | 596 | header('Connection: close'); |
574 | 597 | header('Content-Disposition: attachment; filename="' . $event['title'] . '.ics"'); |
575 | - if (empty($modSettings['enableCompressedOutput'])) |
|
576 | - header('Content-Length: ' . $smcFunc['strlen']($filecontents)); |
|
598 | + if (empty($modSettings['enableCompressedOutput'])) { |
|
599 | + header('Content-Length: ' . $smcFunc['strlen']($filecontents)); |
|
600 | + } |
|
577 | 601 | |
578 | 602 | // This is a calendar item! |
579 | 603 | header('Content-Type: text/calendar'); |
@@ -612,20 +636,17 @@ discard block |
||
612 | 636 | $context['sub_template'] = 'bcd'; |
613 | 637 | $context['linktree'][] = array('url' => $scripturl . '?action=clock;bcd', 'name' => 'BCD'); |
614 | 638 | $context['clockicons'] = safe_unserialize(base64_decode('YTo2OntzOjI6ImgxIjthOjI6e2k6MDtpOjI7aToxO2k6MTt9czoyOiJoMiI7YTo0OntpOjA7aTo4O2k6MTtpOjQ7aToyO2k6MjtpOjM7aToxO31zOjI6Im0xIjthOjM6e2k6MDtpOjQ7aToxO2k6MjtpOjI7aToxO31zOjI6Im0yIjthOjQ6e2k6MDtpOjg7aToxO2k6NDtpOjI7aToyO2k6MztpOjE7fXM6MjoiczEiO2E6Mzp7aTowO2k6NDtpOjE7aToyO2k6MjtpOjE7fXM6MjoiczIiO2E6NDp7aTowO2k6ODtpOjE7aTo0O2k6MjtpOjI7aTozO2k6MTt9fQ==')); |
615 | - } |
|
616 | - elseif (!$omfg && !isset($_REQUEST['time'])) |
|
639 | + } elseif (!$omfg && !isset($_REQUEST['time'])) |
|
617 | 640 | { |
618 | 641 | $context['sub_template'] = 'hms'; |
619 | 642 | $context['linktree'][] = array('url' => $scripturl . '?action=clock', 'name' => 'Binary'); |
620 | 643 | $context['clockicons'] = safe_unserialize(base64_decode('YTozOntzOjE6ImgiO2E6NTp7aTowO2k6MTY7aToxO2k6ODtpOjI7aTo0O2k6MztpOjI7aTo0O2k6MTt9czoxOiJtIjthOjY6e2k6MDtpOjMyO2k6MTtpOjE2O2k6MjtpOjg7aTozO2k6NDtpOjQ7aToyO2k6NTtpOjE7fXM6MToicyI7YTo2OntpOjA7aTozMjtpOjE7aToxNjtpOjI7aTo4O2k6MztpOjQ7aTo0O2k6MjtpOjU7aToxO319')); |
621 | - } |
|
622 | - elseif ($omfg) |
|
644 | + } elseif ($omfg) |
|
623 | 645 | { |
624 | 646 | $context['sub_template'] = 'omfg'; |
625 | 647 | $context['linktree'][] = array('url' => $scripturl . '?action=clock;omfg', 'name' => 'OMFG'); |
626 | 648 | $context['clockicons'] = safe_unserialize(base64_decode('YTo2OntzOjQ6InllYXIiO2E6Nzp7aTowO2k6NjQ7aToxO2k6MzI7aToyO2k6MTY7aTozO2k6ODtpOjQ7aTo0O2k6NTtpOjI7aTo2O2k6MTt9czo1OiJtb250aCI7YTo0OntpOjA7aTo4O2k6MTtpOjQ7aToyO2k6MjtpOjM7aToxO31zOjM6ImRheSI7YTo1OntpOjA7aToxNjtpOjE7aTo4O2k6MjtpOjQ7aTozO2k6MjtpOjQ7aToxO31zOjQ6ImhvdXIiO2E6NTp7aTowO2k6MTY7aToxO2k6ODtpOjI7aTo0O2k6MztpOjI7aTo0O2k6MTt9czozOiJtaW4iO2E6Njp7aTowO2k6MzI7aToxO2k6MTY7aToyO2k6ODtpOjM7aTo0O2k6NDtpOjI7aTo1O2k6MTt9czozOiJzZWMiO2E6Njp7aTowO2k6MzI7aToxO2k6MTY7aToyO2k6ODtpOjM7aTo0O2k6NDtpOjI7aTo1O2k6MTt9fQ==')); |
627 | - } |
|
628 | - elseif (isset($_REQUEST['time'])) |
|
649 | + } elseif (isset($_REQUEST['time'])) |
|
629 | 650 | { |
630 | 651 | $context['sub_template'] = 'thetime'; |
631 | 652 | $time = getdate($_REQUEST['time'] == 'now' ? time() : (int) $_REQUEST['time']); |
@@ -685,12 +706,13 @@ discard block |
||
685 | 706 | ), |
686 | 707 | ); |
687 | 708 | |
688 | - foreach ($context['clockicons'] as $t => $vs) |
|
689 | - foreach ($vs as $v => $dumb) |
|
709 | + foreach ($context['clockicons'] as $t => $vs) { |
|
710 | + foreach ($vs as $v => $dumb) |
|
690 | 711 | { |
691 | 712 | if ($$t >= $v) |
692 | 713 | { |
693 | 714 | $$t -= $v; |
715 | + } |
|
694 | 716 | $context['clockicons'][$t][$v] = true; |
695 | 717 | } |
696 | 718 | } |