Completed
Push — release-2.1 ( 001348...ca7b71 )
by Mathias
18:55
created
Sources/Subscriptions-PayPal.php 1 patch
Braces   +83 added lines, -61 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
 // This won't be dedicated without this - this must exist in each gateway!
15 15
 // SMF Payment Gateway: paypal
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Class for returning available form data for this gateway
@@ -118,8 +119,7 @@  discard block
 block discarded – undo
118 119
 		{
119 120
 			$return_data['hidden']['p3'] = 1;
120 121
 			$return_data['hidden']['t3'] = strtoupper(substr($period, 0, 1));
121
-		}
122
-		else
122
+		} else
123 123
 		{
124 124
 			preg_match('~(\d*)(\w)~', $sub_data['real_length'], $match);
125 125
 			$unit = $match[1];
@@ -130,14 +130,15 @@  discard block
 block discarded – undo
130 130
 		}
131 131
 
132 132
 		// If it's repeatable do some javascript to respect this idea.
133
-		if (!empty($sub_data['repeatable']))
134
-			$return_data['javascript'] = '
133
+		if (!empty($sub_data['repeatable'])) {
134
+					$return_data['javascript'] = '
135 135
 				document.write(\'<label for="do_paypal_recur"><input type="checkbox" name="do_paypal_recur" id="do_paypal_recur" checked onclick="switchPaypalRecur();" class="input_check">' . $txt['paid_make_recurring'] . '</label><br>\');
136 136
 
137 137
 				function switchPaypalRecur()
138 138
 				{
139 139
 					document.getElementById("paypal_cmd").value = document.getElementById("do_paypal_recur").checked ? "_xclick-subscriptions" : "_xclick";
140 140
 				}';
141
+		}
141 142
 
142 143
 		return $return_data;
143 144
 	}
@@ -160,20 +161,24 @@  discard block
 block discarded – undo
160 161
 		global $modSettings;
161 162
 
162 163
 		// Has the user set up an email address?
163
-		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email'])))
164
-			return false;
164
+		if ((empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_email'])) || (!empty($modSettings['paidsubs_test']) && empty($modSettings['paypal_sandbox_email']))) {
165
+					return false;
166
+		}
165 167
 		// Check the correct transaction types are even here.
166
-		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email'])))
167
-			return false;
168
+		if ((!isset($_POST['txn_type']) && !isset($_POST['payment_status'])) || (!isset($_POST['business']) && !isset($_POST['receiver_email']))) {
169
+					return false;
170
+		}
168 171
 		// Correct email address?
169
-		if (!isset($_POST['business']))
170
-			$_POST['business'] = $_POST['receiver_email'];
172
+		if (!isset($_POST['business'])) {
173
+					$_POST['business'] = $_POST['receiver_email'];
174
+		}
171 175
 
172 176
 		// Are we testing?
173
-		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
174
-			return false;
175
-		elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails']))))
176
-			return false;
177
+		if (empty($modSettings['paidsubs_test']) && strtolower($modSettings['paypal_sandbox_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
178
+					return false;
179
+		} elseif (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', $modSettings['paypal_additional_emails'])))) {
180
+					return false;
181
+		}
177 182
 		return true;
178 183
 	}
179 184
 
@@ -192,15 +197,17 @@  discard block
 block discarded – undo
192 197
 		global $modSettings, $txt;
193 198
 
194 199
 		// Put this to some default value.
195
-		if (!isset($_POST['txn_type']))
196
-			$_POST['txn_type'] = '';
200
+		if (!isset($_POST['txn_type'])) {
201
+					$_POST['txn_type'] = '';
202
+		}
197 203
 
198 204
 		// Build the request string - starting with the minimum requirement.
199 205
 		$requestString = 'cmd=_notify-validate';
200 206
 
201 207
 		// Now my dear, add all the posted bits in the order we got them
202
-		foreach ($_POST as $k => $v)
203
-			$requestString .= '&' . $k . '=' . urlencode($v);
208
+		foreach ($_POST as $k => $v) {
209
+					$requestString .= '&' . $k . '=' . urlencode($v);
210
+		}
204 211
 
205 212
 		// Can we use curl?
206 213
 		if (function_exists('curl_init') && $curl = curl_init((!empty($modSettings['paidsubs_test']) ? 'https://www.sandbox.' : 'https://www.') . 'paypal.com/cgi-bin/webscr'))
@@ -240,14 +247,16 @@  discard block
 block discarded – undo
240 247
 			$header .= 'Connection: close' . "\r\n\r\n";
241 248
 
242 249
 			// Open the connection.
243
-			if (!empty($modSettings['paidsubs_test']))
244
-				$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
245
-			else
246
-				$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
250
+			if (!empty($modSettings['paidsubs_test'])) {
251
+							$fp = fsockopen('ssl://www.sandbox.paypal.com', 443, $errno, $errstr, 30);
252
+			} else {
253
+							$fp = fsockopen('www.paypal.com', 80, $errno, $errstr, 30);
254
+			}
247 255
 
248 256
 			// Did it work?
249
-			if (!$fp)
250
-				generateSubscriptionError($txt['paypal_could_not_connect']);
257
+			if (!$fp) {
258
+							generateSubscriptionError($txt['paypal_could_not_connect']);
259
+			}
251 260
 
252 261
 			// Put the data to the port.
253 262
 			fputs($fp, $header . $requestString);
@@ -256,8 +265,9 @@  discard block
 block discarded – undo
256 265
 			while (!feof($fp))
257 266
 			{
258 267
 				$this->return_data = fgets($fp, 1024);
259
-				if (strcmp(trim($this->return_data), 'VERIFIED') === 0)
260
-					break;
268
+				if (strcmp(trim($this->return_data), 'VERIFIED') === 0) {
269
+									break;
270
+				}
261 271
 			}
262 272
 
263 273
 			// Clean up.
@@ -265,28 +275,34 @@  discard block
 block discarded – undo
265 275
 		}
266 276
 
267 277
 		// If this isn't verified then give up...
268
-		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0)
269
-			exit;
278
+		if (strcmp(trim($this->return_data), 'VERIFIED') !== 0) {
279
+					exit;
280
+		}
270 281
 
271 282
 		// Check that this is intended for us.
272
-		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails'])))))
273
-			exit;
283
+		if (strtolower($modSettings['paypal_email']) != strtolower($_POST['business']) && (empty($modSettings['paypal_additional_emails']) || !in_array(strtolower($_POST['business']), explode(',', strtolower($modSettings['paypal_additional_emails']))))) {
284
+					exit;
285
+		}
274 286
 
275 287
 		// Is this a subscription - and if so is it a secondary payment that we need to process?
276 288
 		// If so, make sure we get it in the expected format. Seems PayPal sometimes sends it without urlencoding.
277
-		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false)
278
-			$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
279
-		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false))
280
-			// Calculate the subscription it relates to!
289
+		if (!empty($_POST['item_number']) && strpos($_POST['item_number'], ' ') !== false) {
290
+					$_POST['item_number'] = str_replace(' ', '+', $_POST['item_number']);
291
+		}
292
+		if ($this->isSubscription() && (empty($_POST['item_number']) || strpos($_POST['item_number'], '+') === false)) {
293
+					// Calculate the subscription it relates to!
281 294
 			$this->_findSubscription();
295
+		}
282 296
 
283 297
 		// Verify the currency!
284
-		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code']))
285
-			exit;
298
+		if (strtolower($_POST['mc_currency']) !== strtolower($modSettings['paid_currency_code'])) {
299
+					exit;
300
+		}
286 301
 
287 302
 		// Can't exist if it doesn't contain anything.
288
-		if (empty($_POST['item_number']))
289
-			exit;
303
+		if (empty($_POST['item_number'])) {
304
+					exit;
305
+		}
290 306
 
291 307
 		// Return the id_sub and id_member
292 308
 		return explode('+', $_POST['item_number']);
@@ -299,10 +315,11 @@  discard block
 block discarded – undo
299 315
 	 */
300 316
 	public function isRefund()
301 317
 	{
302
-		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed'))
303
-			return true;
304
-		else
305
-			return false;
318
+		if ($_POST['payment_status'] === 'Refunded' || $_POST['payment_status'] === 'Reversed' || $_POST['txn_type'] === 'Refunded' || ($_POST['txn_type'] === 'reversal' && $_POST['payment_status'] === 'Completed')) {
319
+					return true;
320
+		} else {
321
+					return false;
322
+		}
306 323
 	}
307 324
 
308 325
 	/**
@@ -312,10 +329,11 @@  discard block
 block discarded – undo
312 329
 	 */
313 330
 	public function isSubscription()
314 331
 	{
315
-		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed')
316
-			return true;
317
-		else
318
-			return false;
332
+		if (substr($_POST['txn_type'], 0, 14) === 'subscr_payment' && $_POST['payment_status'] === 'Completed') {
333
+					return true;
334
+		} else {
335
+					return false;
336
+		}
319 337
 	}
320 338
 
321 339
 	/**
@@ -325,10 +343,11 @@  discard block
 block discarded – undo
325 343
 	 */
326 344
 	public function isPayment()
327 345
 	{
328
-		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept')
329
-			return true;
330
-		else
331
-			return false;
346
+		if ($_POST['payment_status'] === 'Completed' && $_POST['txn_type'] === 'web_accept') {
347
+					return true;
348
+		} else {
349
+					return false;
350
+		}
332 351
 	}
333 352
 
334 353
 	/**
@@ -341,10 +360,11 @@  discard block
 block discarded – undo
341 360
 		// subscr_cancel is sent when the user cancels, subscr_eot is sent when the subscription reaches final payment
342 361
 		// Neither require us to *do* anything as per performCancel().
343 362
 		// subscr_eot, if sent, indicates an end of payments term.
344
-		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot')
345
-			return true;
346
-		else
347
-			return false;
363
+		if (substr($_POST['txn_type'], 0, 13) === 'subscr_cancel' || substr($_POST['txn_type'], 0, 10) === 'subscr_eot') {
364
+					return true;
365
+		} else {
366
+					return false;
367
+		}
348 368
 	}
349 369
 
350 370
 	/**
@@ -409,8 +429,9 @@  discard block
 block discarded – undo
409 429
 		global $smcFunc;
410 430
 
411 431
 		// Assume we have this?
412
-		if (empty($_POST['subscr_id']))
413
-			return false;
432
+		if (empty($_POST['subscr_id'])) {
433
+					return false;
434
+		}
414 435
 
415 436
 		// Do we have this in the database?
416 437
 		$request = $smcFunc['db_query']('', '
@@ -439,11 +460,12 @@  discard block
 block discarded – undo
439 460
 						'payer_email' => $_POST['payer_email'],
440 461
 					)
441 462
 				);
442
-				if ($smcFunc['db_num_rows']($request) === 0)
443
-					return false;
463
+				if ($smcFunc['db_num_rows']($request) === 0) {
464
+									return false;
465
+				}
466
+			} else {
467
+							return false;
444 468
 			}
445
-			else
446
-				return false;
447 469
 		}
448 470
 		list ($member_id, $subscription_id) = $smcFunc['db_fetch_row']($request);
449 471
 		$_POST['item_number'] = $member_id . '+' . $subscription_id;
Please login to merge, or discard this patch.
Sources/SearchAPI-Fulltext.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
 		if (!empty($modSettings['search_simple_fulltext']))
208 208
 		{
209
-			if($smcFunc['db_title'] == "PostgreSQL")
209
+			if ($smcFunc['db_title'] == "PostgreSQL")
210 210
 			{
211 211
 				$language_ftx = $smcFunc['db_search_language']();
212 212
 				
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 			// remove any indexed words that are used in the complex body search terms
225 225
 			$words['indexed_words'] = array_diff($words['indexed_words'], $words['complex_words']);
226 226
 
227
-			if($smcFunc['db_title'] == "PostgreSQL"){
227
+			if ($smcFunc['db_title'] == "PostgreSQL") {
228 228
 				$row = 0;
229 229
 				foreach ($words['indexed_words'] as $fulltextWord) {
230 230
 					$query_params['boolean_match'] .= ($row <> 0 ? '&' : '');
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
 
241 241
 			// if we have bool terms to search, add them in
242 242
 			if ($query_params['boolean_match']) {
243
-				if($smcFunc['db_title'] == "PostgreSQL")
243
+				if ($smcFunc['db_title'] == "PostgreSQL")
244 244
 				{
245 245
 					$language_ftx = $smcFunc['db_search_language']();
246 246
 					
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
 
254 254
 		}
255 255
 
256
-		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ( '
256
+		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ('
257 257
 			INSERT IGNORE INTO {db_prefix}' . $search_data['insert_into'] . '
258 258
 				(' . implode(', ', array_keys($query_select)) . ')') : '') . '
259 259
 			SELECT ' . implode(', ', $query_select) . '
Please login to merge, or discard this patch.
Braces   +44 added lines, -34 removed lines patch added patch discarded remove patch
@@ -11,8 +11,9 @@  discard block
 block discarded – undo
11 11
  * @version 2.1 Beta 3
12 12
  */
13 13
 
14
-if (!defined('SMF'))
14
+if (!defined('SMF')) {
15 15
 	die('No direct access...');
16
+}
16 17
 
17 18
 /**
18 19
  * Class fulltext_search
@@ -98,8 +99,9 @@  discard block
 block discarded – undo
98 99
 			$smcFunc['db_free_result']($request);
99 100
 		}
100 101
 		// 4 is the MySQL default...
101
-		else
102
-			$min_word_length = 4;
102
+		else {
103
+					$min_word_length = 4;
104
+		}
103 105
 
104 106
 		return $min_word_length;
105 107
 	}
@@ -138,8 +140,7 @@  discard block
 block discarded – undo
138 140
 					$wordsSearch['words'][] = trim($word, "/*- ");
139 141
 					$wordsSearch['complex_words'][] = count($subwords) === 1 ? $word : '"' . $word . '"';
140 142
 				}
141
-			}
142
-			elseif ($smcFunc['strlen'](trim($word, "/*- ")) < $this->min_word_length)
143
+			} elseif ($smcFunc['strlen'](trim($word, "/*- ")) < $this->min_word_length)
143 144
 			{
144 145
 				// short words have feelings too
145 146
 				$wordsSearch['words'][] = trim($word, "/*- ");
@@ -149,8 +150,9 @@  discard block
 block discarded – undo
149 150
 
150 151
 		$fulltextWord = count($subwords) === 1 ? $word : '"' . $word . '"';
151 152
 		$wordsSearch['indexed_words'][] = $fulltextWord;
152
-		if ($isExcluded)
153
-			$wordsExclude[] = $fulltextWord;
153
+		if ($isExcluded) {
154
+					$wordsExclude[] = $fulltextWord;
155
+		}
154 156
 	}
155 157
 
156 158
 	/**
@@ -166,41 +168,50 @@  discard block
 block discarded – undo
166 168
 		$query_where = array();
167 169
 		$query_params = $search_data['params'];
168 170
 
169
-		if ($query_params['id_search'])
170
-			$query_select['id_search'] = '{int:id_search}';
171
+		if ($query_params['id_search']) {
172
+					$query_select['id_search'] = '{int:id_search}';
173
+		}
171 174
 
172 175
 		$count = 0;
173
-		if (empty($modSettings['search_simple_fulltext']))
174
-			foreach ($words['words'] as $regularWord)
176
+		if (empty($modSettings['search_simple_fulltext'])) {
177
+					foreach ($words['words'] as $regularWord)
175 178
 			{
176 179
 				$query_where[] = 'm.body' . (in_array($regularWord, $query_params['excluded_words']) ? ' NOT' : '') . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:complex_body_' . $count . '}';
180
+		}
177 181
 				$query_params['complex_body_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($regularWord, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $regularWord), '\\\'') . '[[:>:]]';
178 182
 			}
179 183
 
180
-		if ($query_params['user_query'])
181
-			$query_where[] = '{raw:user_query}';
182
-		if ($query_params['board_query'])
183
-			$query_where[] = 'm.id_board {raw:board_query}';
184
+		if ($query_params['user_query']) {
185
+					$query_where[] = '{raw:user_query}';
186
+		}
187
+		if ($query_params['board_query']) {
188
+					$query_where[] = 'm.id_board {raw:board_query}';
189
+		}
184 190
 
185
-		if ($query_params['topic'])
186
-			$query_where[] = 'm.id_topic = {int:topic}';
187
-		if ($query_params['min_msg_id'])
188
-			$query_where[] = 'm.id_msg >= {int:min_msg_id}';
189
-		if ($query_params['max_msg_id'])
190
-			$query_where[] = 'm.id_msg <= {int:max_msg_id}';
191
+		if ($query_params['topic']) {
192
+					$query_where[] = 'm.id_topic = {int:topic}';
193
+		}
194
+		if ($query_params['min_msg_id']) {
195
+					$query_where[] = 'm.id_msg >= {int:min_msg_id}';
196
+		}
197
+		if ($query_params['max_msg_id']) {
198
+					$query_where[] = 'm.id_msg <= {int:max_msg_id}';
199
+		}
191 200
 
192 201
 		$count = 0;
193
-		if (!empty($query_params['excluded_phrases']) && empty($modSettings['search_force_index']))
194
-			foreach ($query_params['excluded_phrases'] as $phrase)
202
+		if (!empty($query_params['excluded_phrases']) && empty($modSettings['search_force_index'])) {
203
+					foreach ($query_params['excluded_phrases'] as $phrase)
195 204
 			{
196 205
 				$query_where[] = 'subject NOT ' . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:exclude_subject_phrase_' . $count . '}';
206
+		}
197 207
 				$query_params['exclude_subject_phrase_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($phrase, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $phrase), '\\\'') . '[[:>:]]';
198 208
 			}
199 209
 		$count = 0;
200
-		if (!empty($query_params['excluded_subject_words']) && empty($modSettings['search_force_index']))
201
-			foreach ($query_params['excluded_subject_words'] as $excludedWord)
210
+		if (!empty($query_params['excluded_subject_words']) && empty($modSettings['search_force_index'])) {
211
+					foreach ($query_params['excluded_subject_words'] as $excludedWord)
202 212
 			{
203 213
 				$query_where[] = 'subject NOT ' . (empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? ' LIKE ' : 'RLIKE') . '{string:exclude_subject_words_' . $count . '}';
214
+		}
204 215
 				$query_params['exclude_subject_words_' . $count++] = empty($modSettings['search_match_words']) || $search_data['no_regexp'] ? '%' . strtr($excludedWord, array('_' => '\\_', '%' => '\\%')) . '%' : '[[:<:]]' . addcslashes(preg_replace(array('/([\[\]$.+*?|{}()])/'), array('[$1]'), $excludedWord), '\\\'') . '[[:>:]]';
205 216
 			}
206 217
 
@@ -212,12 +223,11 @@  discard block
 block discarded – undo
212 223
 				
213 224
 				$query_where[] = 'to_tsvector({string:language_ftx},body) @@ to_tsquery({string:language_ftx},{string:body_match})';
214 225
 				$query_params['language_ftx'] = $language_ftx;
226
+			} else {
227
+							$query_where[] = 'MATCH (body) AGAINST ({string:body_match})';
215 228
 			}
216
-			else
217
-				$query_where[] = 'MATCH (body) AGAINST ({string:body_match})';
218 229
 			$query_params['body_match'] = implode(' ', array_diff($words['indexed_words'], $query_params['excluded_index_words']));
219
-		}
220
-		else
230
+		} else
221 231
 		{
222 232
 			$query_params['boolean_match'] = '';
223 233
 
@@ -231,10 +241,10 @@  discard block
 block discarded – undo
231 241
 					$query_params['boolean_match'] .= (in_array($fulltextWord, $query_params['excluded_index_words']) ? '!' : '') . $fulltextWord . ' ';
232 242
 					$row++;
233 243
 				}
234
-			}
235
-			else
236
-				foreach ($words['indexed_words'] as $fulltextWord)
244
+			} else {
245
+							foreach ($words['indexed_words'] as $fulltextWord)
237 246
 					$query_params['boolean_match'] .= (in_array($fulltextWord, $query_params['excluded_index_words']) ? '-' : '+') . $fulltextWord . ' ';
247
+			}
238 248
 
239 249
 			$query_params['boolean_match'] = substr($query_params['boolean_match'], 0, -1);
240 250
 
@@ -246,9 +256,9 @@  discard block
 block discarded – undo
246 256
 					
247 257
 					$query_where[] = 'to_tsvector({string:language_ftx},body) @@ to_tsquery({string:language_ftx},{string:boolean_match})';
248 258
 					$query_params['language_ftx'] = $language_ftx;
259
+				} else {
260
+									$query_where[] = 'MATCH (body) AGAINST ({string:boolean_match} IN BOOLEAN MODE)';
249 261
 				}
250
-				else
251
-					$query_where[] = 'MATCH (body) AGAINST ({string:boolean_match} IN BOOLEAN MODE)';
252 262
 			}
253 263
 
254 264
 		}
Please login to merge, or discard this patch.
Sources/Subs-Calendar.php 1 patch
Braces   +215 added lines, -157 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Get all birthdays within the given time range.
@@ -60,8 +61,7 @@  discard block
 block discarded – undo
60 61
 				'max_year' => $year_high,
61 62
 			)
62 63
 		);
63
-	}
64
-	else
64
+	} else
65 65
 	{
66 66
 		$result = $smcFunc['db_query']('birthday_array', '
67 67
 			SELECT id_member, real_name, YEAR(birthdate) AS birth_year, birthdate
@@ -91,10 +91,11 @@  discard block
 block discarded – undo
91 91
 	$bday = array();
92 92
 	while ($row = $smcFunc['db_fetch_assoc']($result))
93 93
 	{
94
-		if ($year_low != $year_high)
95
-			$age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low;
96
-		else
97
-			$age_year = $year_low;
94
+		if ($year_low != $year_high) {
95
+					$age_year = substr($row['birthdate'], 5) < substr($high_date, 5) ? $year_high : $year_low;
96
+		} else {
97
+					$age_year = $year_low;
98
+		}
98 99
 
99 100
 		$bday[$age_year . substr($row['birthdate'], 4)][] = array(
100 101
 			'id' => $row['id_member'],
@@ -108,8 +109,9 @@  discard block
 block discarded – undo
108 109
 	ksort($bday);
109 110
 
110 111
 	// Set is_last, so the themes know when to stop placing separators.
111
-	foreach ($bday as $mday => $array)
112
-		$bday[$mday][count($array) - 1]['is_last'] = true;
112
+	foreach ($bday as $mday => $array) {
113
+			$bday[$mday][count($array) - 1]['is_last'] = true;
114
+	}
113 115
 
114 116
 	return $bday;
115 117
 }
@@ -157,8 +159,9 @@  discard block
 block discarded – undo
157 159
 	while ($row = $smcFunc['db_fetch_assoc']($result))
158 160
 	{
159 161
 		// If the attached topic is not approved then for the moment pretend it doesn't exist
160
-		if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved'])
161
-			continue;
162
+		if (!empty($row['id_first_msg']) && $modSettings['postmod_active'] && !$row['approved']) {
163
+					continue;
164
+		}
162 165
 
163 166
 		// Force a censor of the title - as often these are used by others.
164 167
 		censorText($row['title'], $use_permissions ? false : true);
@@ -167,8 +170,9 @@  discard block
 block discarded – undo
167 170
 		list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row);
168 171
 
169 172
 		// Sanity check
170
-		if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count']))
171
-			continue;
173
+		if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) {
174
+					continue;
175
+		}
172 176
 
173 177
 		// Get set up for the loop
174 178
 		$start_object = date_create($row['start_date'] . (!$allday ? ' ' . $row['start_time'] : ''), timezone_open($tz));
@@ -232,8 +236,8 @@  discard block
 block discarded – undo
232 236
 			);
233 237
 
234 238
 			// If we're using permissions (calendar pages?) then just ouput normal contextual style information.
235
-			if ($use_permissions)
236
-				$events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array(
239
+			if ($use_permissions) {
240
+							$events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array(
237 241
 					'href' => $row['id_board'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0',
238 242
 					'link' => $row['id_board'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>',
239 243
 					'can_edit' => allowedTo('calendar_edit_any') || ($row['id_member'] == $user_info['id'] && allowedTo('calendar_edit_own')),
@@ -241,9 +245,10 @@  discard block
 block discarded – undo
241 245
 					'can_export' => !empty($modSettings['cal_export']) ? true : false,
242 246
 					'export_href' => $scripturl . '?action=calendar;sa=ical;eventid=' . $row['id_event'] . ';' . $context['session_var'] . '=' . $context['session_id'],
243 247
 				));
248
+			}
244 249
 			// Otherwise, this is going to be cached and the VIEWER'S permissions should apply... just put together some info.
245
-			else
246
-				$events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array(
250
+			else {
251
+							$events[date_format($cal_date, 'Y-m-d')][] = array_merge($eventProperties, array(
247 252
 					'href' => $row['id_topic'] == 0 ? '' : $scripturl . '?topic=' . $row['id_topic'] . '.0',
248 253
 					'link' => $row['id_topic'] == 0 ? $row['title'] : '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0">' . $row['title'] . '</a>',
249 254
 					'can_edit' => false,
@@ -253,6 +258,7 @@  discard block
 block discarded – undo
253 258
 					'poster' => $row['id_member'],
254 259
 					'allowed_groups' => explode(',', $row['member_groups']),
255 260
 				));
261
+			}
256 262
 
257 263
 			date_add($cal_date, date_interval_create_from_date_string('1 day'));
258 264
 		}
@@ -262,8 +268,9 @@  discard block
 block discarded – undo
262 268
 	// If we're doing normal contextual data, go through and make things clear to the templates ;).
263 269
 	if ($use_permissions)
264 270
 	{
265
-		foreach ($events as $mday => $array)
266
-			$events[$mday][count($array) - 1]['is_last'] = true;
271
+		foreach ($events as $mday => $array) {
272
+					$events[$mday][count($array) - 1]['is_last'] = true;
273
+		}
267 274
 	}
268 275
 
269 276
 	ksort($events);
@@ -283,11 +290,12 @@  discard block
 block discarded – undo
283 290
 	global $smcFunc;
284 291
 
285 292
 	// Get the lowest and highest dates for "all years".
286
-	if (substr($low_date, 0, 4) != substr($high_date, 0, 4))
287
-		$allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec}
293
+	if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) {
294
+			$allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_dec}
288 295
 			OR event_date BETWEEN {date:all_year_jan} AND {date:all_year_high}';
289
-	else
290
-		$allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}';
296
+	} else {
297
+			$allyear_part = 'event_date BETWEEN {date:all_year_low} AND {date:all_year_high}';
298
+	}
291 299
 
292 300
 	// Find some holidays... ;).
293 301
 	$result = $smcFunc['db_query']('', '
@@ -307,10 +315,11 @@  discard block
 block discarded – undo
307 315
 	$holidays = array();
308 316
 	while ($row = $smcFunc['db_fetch_assoc']($result))
309 317
 	{
310
-		if (substr($low_date, 0, 4) != substr($high_date, 0, 4))
311
-			$event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4);
312
-		else
313
-			$event_year = substr($low_date, 0, 4);
318
+		if (substr($low_date, 0, 4) != substr($high_date, 0, 4)) {
319
+					$event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4);
320
+		} else {
321
+					$event_year = substr($low_date, 0, 4);
322
+		}
314 323
 
315 324
 		$holidays[$event_year . substr($row['event_date'], 4)][] = $row['title'];
316 325
 	}
@@ -336,10 +345,12 @@  discard block
 block discarded – undo
336 345
 	isAllowedTo('calendar_post');
337 346
 
338 347
 	// No board?  No topic?!?
339
-	if (empty($board))
340
-		fatal_lang_error('missing_board_id', false);
341
-	if (empty($topic))
342
-		fatal_lang_error('missing_topic_id', false);
348
+	if (empty($board)) {
349
+			fatal_lang_error('missing_board_id', false);
350
+	}
351
+	if (empty($topic)) {
352
+			fatal_lang_error('missing_topic_id', false);
353
+	}
343 354
 
344 355
 	// Administrator, Moderator, or owner.  Period.
345 356
 	if (!allowedTo('admin_forum') && !allowedTo('moderate_board'))
@@ -357,12 +368,14 @@  discard block
 block discarded – undo
357 368
 		if ($row = $smcFunc['db_fetch_assoc']($result))
358 369
 		{
359 370
 			// Not the owner of the topic.
360
-			if ($row['id_member_started'] != $user_info['id'])
361
-				fatal_lang_error('not_your_topic', 'user');
371
+			if ($row['id_member_started'] != $user_info['id']) {
372
+							fatal_lang_error('not_your_topic', 'user');
373
+			}
362 374
 		}
363 375
 		// Topic/Board doesn't exist.....
364
-		else
365
-			fatal_lang_error('calendar_no_topic', 'general');
376
+		else {
377
+					fatal_lang_error('calendar_no_topic', 'general');
378
+		}
366 379
 		$smcFunc['db_free_result']($result);
367 380
 	}
368 381
 }
@@ -450,14 +463,16 @@  discard block
 block discarded – undo
450 463
 	if (!empty($calendarOptions['start_day']))
451 464
 	{
452 465
 		$nShift -= $calendarOptions['start_day'];
453
-		if ($nShift < 0)
454
-			$nShift = 7 + $nShift;
466
+		if ($nShift < 0) {
467
+					$nShift = 7 + $nShift;
468
+		}
455 469
 	}
456 470
 
457 471
 	// Number of rows required to fit the month.
458 472
 	$nRows = floor(($month_info['last_day']['day_of_month'] + $nShift) / 7);
459
-	if (($month_info['last_day']['day_of_month'] + $nShift) % 7)
460
-		$nRows++;
473
+	if (($month_info['last_day']['day_of_month'] + $nShift) % 7) {
474
+			$nRows++;
475
+	}
461 476
 
462 477
 	// Fetch the arrays for birthdays, posted events, and holidays.
463 478
 	$bday = $calendarOptions['show_birthdays'] ? getBirthdayRange($month_info['first_day']['date'], $month_info['last_day']['date']) : array();
@@ -470,8 +485,9 @@  discard block
 block discarded – undo
470 485
 	{
471 486
 		$calendarGrid['week_days'][] = $count;
472 487
 		$count++;
473
-		if ($count == 7)
474
-			$count = 0;
488
+		if ($count == 7) {
489
+					$count = 0;
490
+		}
475 491
 	}
476 492
 
477 493
 	// Iterate through each week.
@@ -488,8 +504,9 @@  discard block
 block discarded – undo
488 504
 		{
489 505
 			$nDay = ($nRow * 7) + $nCol - $nShift + 1;
490 506
 
491
-			if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month'])
492
-				$nDay = 0;
507
+			if ($nDay < 1 || $nDay > $month_info['last_day']['day_of_month']) {
508
+							$nDay = 0;
509
+			}
493 510
 
494 511
 			$date = sprintf('%04d-%02d-%02d', $year, $month, $nDay);
495 512
 
@@ -507,8 +524,9 @@  discard block
 block discarded – undo
507 524
 	}
508 525
 
509 526
 	// What is the last day of the month?
510
-	if ($is_previous === true)
511
-		$calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month'];
527
+	if ($is_previous === true) {
528
+			$calendarGrid['last_of_month'] = $month_info['last_day']['day_of_month'];
529
+	}
512 530
 
513 531
 	// We'll use the shift in the template.
514 532
 	$calendarGrid['shift'] = $nShift;
@@ -542,8 +560,9 @@  discard block
 block discarded – undo
542 560
 	{
543 561
 		// Here we offset accordingly to get things to the real start of a week.
544 562
 		$date_diff = $day_of_week - $calendarOptions['start_day'];
545
-		if ($date_diff < 0)
546
-			$date_diff += 7;
563
+		if ($date_diff < 0) {
564
+					$date_diff += 7;
565
+		}
547 566
 		$new_timestamp = mktime(0, 0, 0, $month, $day, $year) - $date_diff * 86400;
548 567
 		$day = (int) strftime('%d', $new_timestamp);
549 568
 		$month = (int) strftime('%m', $new_timestamp);
@@ -673,18 +692,20 @@  discard block
 block discarded – undo
673 692
 	{
674 693
 		foreach ($date_events as $event_key => $event_val)
675 694
 		{
676
-			if (in_array($event_val['id'], $temp))
677
-				unset($calendarGrid['events'][$date][$event_key]);
678
-			else
679
-				$temp[] = $event_val['id'];
695
+			if (in_array($event_val['id'], $temp)) {
696
+							unset($calendarGrid['events'][$date][$event_key]);
697
+			} else {
698
+							$temp[] = $event_val['id'];
699
+			}
680 700
 		}
681 701
 	}
682 702
 
683 703
 	// Give birthdays and holidays a friendly format, without the year
684
-	if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
685
-		$date_format = '%b %d';
686
-	else
687
-		$date_format = str_replace(array('%Y', '%y', '%G', '%g', '%C', '%c', '%D'), array('', '', '', '', '', '%b %d', '%m/%d'), $matches[0]);
704
+	if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
705
+			$date_format = '%b %d';
706
+	} else {
707
+			$date_format = str_replace(array('%Y', '%y', '%G', '%g', '%C', '%c', '%D'), array('', '', '', '', '', '%b %d', '%m/%d'), $matches[0]);
708
+	}
688 709
 
689 710
 	foreach (array('birthdays', 'holidays') as $type)
690 711
 	{
@@ -779,8 +800,9 @@  discard block
 block discarded – undo
779 800
 	// Holidays between now and now + days.
780 801
 	for ($i = $now; $i < $now + $days_for_index; $i += 86400)
781 802
 	{
782
-		if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)]))
783
-			$return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]);
803
+		if (isset($cached_data['holidays'][strftime('%Y-%m-%d', $i)])) {
804
+					$return_data['calendar_holidays'] = array_merge($return_data['calendar_holidays'], $cached_data['holidays'][strftime('%Y-%m-%d', $i)]);
805
+		}
784 806
 	}
785 807
 
786 808
 	// Happy Birthday, guys and gals!
@@ -789,8 +811,9 @@  discard block
 block discarded – undo
789 811
 		$loop_date = strftime('%Y-%m-%d', $i);
790 812
 		if (isset($cached_data['birthdays'][$loop_date]))
791 813
 		{
792
-			foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy)
793
-				$cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date'];
814
+			foreach ($cached_data['birthdays'][$loop_date] as $index => $dummy) {
815
+							$cached_data['birthdays'][strftime('%Y-%m-%d', $i)][$index]['is_today'] = $loop_date === $today['date'];
816
+			}
794 817
 			$return_data['calendar_birthdays'] = array_merge($return_data['calendar_birthdays'], $cached_data['birthdays'][$loop_date]);
795 818
 		}
796 819
 	}
@@ -802,8 +825,9 @@  discard block
 block discarded – undo
802 825
 		$loop_date = strftime('%Y-%m-%d', $i);
803 826
 
804 827
 		// No events today? Check the next day.
805
-		if (empty($cached_data['events'][$loop_date]))
806
-			continue;
828
+		if (empty($cached_data['events'][$loop_date])) {
829
+					continue;
830
+		}
807 831
 
808 832
 		// Loop through all events to add a few last-minute values.
809 833
 		foreach ($cached_data['events'][$loop_date] as $ev => $event)
@@ -816,9 +840,9 @@  discard block
 block discarded – undo
816 840
 			{
817 841
 				unset($cached_data['events'][$loop_date][$ev]);
818 842
 				continue;
843
+			} else {
844
+							$duplicates[$this_event['topic'] . $this_event['title']] = true;
819 845
 			}
820
-			else
821
-				$duplicates[$this_event['topic'] . $this_event['title']] = true;
822 846
 
823 847
 			// Might be set to true afterwards, depending on the permissions.
824 848
 			$this_event['can_edit'] = false;
@@ -826,15 +850,18 @@  discard block
 block discarded – undo
826 850
 			$this_event['date'] = $loop_date;
827 851
 		}
828 852
 
829
-		if (!empty($cached_data['events'][$loop_date]))
830
-			$return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]);
853
+		if (!empty($cached_data['events'][$loop_date])) {
854
+					$return_data['calendar_events'] = array_merge($return_data['calendar_events'], $cached_data['events'][$loop_date]);
855
+		}
831 856
 	}
832 857
 
833 858
 	// Mark the last item so that a list separator can be used in the template.
834
-	for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++)
835
-		$return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]);
836
-	for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++)
837
-		$return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]);
859
+	for ($i = 0, $n = count($return_data['calendar_birthdays']); $i < $n; $i++) {
860
+			$return_data['calendar_birthdays'][$i]['is_last'] = !isset($return_data['calendar_birthdays'][$i + 1]);
861
+	}
862
+	for ($i = 0, $n = count($return_data['calendar_events']); $i < $n; $i++) {
863
+			$return_data['calendar_events'][$i]['is_last'] = !isset($return_data['calendar_events'][$i + 1]);
864
+	}
838 865
 
839 866
 	return array(
840 867
 		'data' => $return_data,
@@ -882,37 +909,46 @@  discard block
 block discarded – undo
882 909
 		if (isset($_POST['start_date']))
883 910
 		{
884 911
 			$d = date_parse($_POST['start_date']);
885
-			if (!empty($d['error_count']) || !empty($d['warning_count']))
886
-				fatal_lang_error('invalid_date', false);
887
-			if (empty($d['year']))
888
-				fatal_lang_error('event_year_missing', false);
889
-			if (empty($d['month']))
890
-				fatal_lang_error('event_month_missing', false);
891
-		}
892
-		elseif (isset($_POST['start_datetime']))
912
+			if (!empty($d['error_count']) || !empty($d['warning_count'])) {
913
+							fatal_lang_error('invalid_date', false);
914
+			}
915
+			if (empty($d['year'])) {
916
+							fatal_lang_error('event_year_missing', false);
917
+			}
918
+			if (empty($d['month'])) {
919
+							fatal_lang_error('event_month_missing', false);
920
+			}
921
+		} elseif (isset($_POST['start_datetime']))
893 922
 		{
894 923
 			$d = date_parse($_POST['start_datetime']);
895
-			if (!empty($d['error_count']) || !empty($d['warning_count']))
896
-				fatal_lang_error('invalid_date', false);
897
-			if (empty($d['year']))
898
-				fatal_lang_error('event_year_missing', false);
899
-			if (empty($d['month']))
900
-				fatal_lang_error('event_month_missing', false);
924
+			if (!empty($d['error_count']) || !empty($d['warning_count'])) {
925
+							fatal_lang_error('invalid_date', false);
926
+			}
927
+			if (empty($d['year'])) {
928
+							fatal_lang_error('event_year_missing', false);
929
+			}
930
+			if (empty($d['month'])) {
931
+							fatal_lang_error('event_month_missing', false);
932
+			}
901 933
 		}
902 934
 		// The 2.0 way
903 935
 		else
904 936
 		{
905 937
 			// No month?  No year?
906
-			if (!isset($_POST['month']))
907
-				fatal_lang_error('event_month_missing', false);
908
-			if (!isset($_POST['year']))
909
-				fatal_lang_error('event_year_missing', false);
938
+			if (!isset($_POST['month'])) {
939
+							fatal_lang_error('event_month_missing', false);
940
+			}
941
+			if (!isset($_POST['year'])) {
942
+							fatal_lang_error('event_year_missing', false);
943
+			}
910 944
 
911 945
 			// Check the month and year...
912
-			if ($_POST['month'] < 1 || $_POST['month'] > 12)
913
-				fatal_lang_error('invalid_month', false);
914
-			if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear'])
915
-				fatal_lang_error('invalid_year', false);
946
+			if ($_POST['month'] < 1 || $_POST['month'] > 12) {
947
+							fatal_lang_error('invalid_month', false);
948
+			}
949
+			if ($_POST['year'] < $modSettings['cal_minyear'] || $_POST['year'] > $modSettings['cal_maxyear']) {
950
+							fatal_lang_error('invalid_year', false);
951
+			}
916 952
 		}
917 953
 	}
918 954
 
@@ -922,8 +958,9 @@  discard block
 block discarded – undo
922 958
 	// If they want to us to calculate an end date, make sure it will fit in an acceptable range.
923 959
 	if (isset($_POST['span']))
924 960
 	{
925
-		if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan']))
926
-			fatal_lang_error('invalid_days_numb', false);
961
+		if (($_POST['span'] < 1) || (!empty($modSettings['cal_maxspan']) && $_POST['span'] > $modSettings['cal_maxspan'])) {
962
+					fatal_lang_error('invalid_days_numb', false);
963
+		}
927 964
 	}
928 965
 
929 966
 	// There is no need to validate the following values if we are just deleting the event.
@@ -933,24 +970,29 @@  discard block
 block discarded – undo
933 970
 		if (empty($_POST['start_date']) && empty($_POST['start_datetime']))
934 971
 		{
935 972
 			// No day?
936
-			if (!isset($_POST['day']))
937
-				fatal_lang_error('event_day_missing', false);
973
+			if (!isset($_POST['day'])) {
974
+							fatal_lang_error('event_day_missing', false);
975
+			}
938 976
 
939 977
 			// Bad day?
940
-			if (!checkdate($_POST['month'], $_POST['day'], $_POST['year']))
941
-				fatal_lang_error('invalid_date', false);
978
+			if (!checkdate($_POST['month'], $_POST['day'], $_POST['year'])) {
979
+							fatal_lang_error('invalid_date', false);
980
+			}
942 981
 		}
943 982
 
944
-		if (!isset($_POST['evtitle']) && !isset($_POST['subject']))
945
-			fatal_lang_error('event_title_missing', false);
946
-		elseif (!isset($_POST['evtitle']))
947
-			$_POST['evtitle'] = $_POST['subject'];
983
+		if (!isset($_POST['evtitle']) && !isset($_POST['subject'])) {
984
+					fatal_lang_error('event_title_missing', false);
985
+		} elseif (!isset($_POST['evtitle'])) {
986
+					$_POST['evtitle'] = $_POST['subject'];
987
+		}
948 988
 
949 989
 		// No title?
950
-		if ($smcFunc['htmltrim']($_POST['evtitle']) === '')
951
-			fatal_lang_error('no_event_title', false);
952
-		if ($smcFunc['strlen']($_POST['evtitle']) > 100)
953
-			$_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100);
990
+		if ($smcFunc['htmltrim']($_POST['evtitle']) === '') {
991
+					fatal_lang_error('no_event_title', false);
992
+		}
993
+		if ($smcFunc['strlen']($_POST['evtitle']) > 100) {
994
+					$_POST['evtitle'] = $smcFunc['substr']($_POST['evtitle'], 0, 100);
995
+		}
954 996
 		$_POST['evtitle'] = str_replace(';', '', $_POST['evtitle']);
955 997
 	}
956 998
 }
@@ -977,8 +1019,9 @@  discard block
 block discarded – undo
977 1019
 	);
978 1020
 
979 1021
 	// No results, return false.
980
-	if ($smcFunc['db_num_rows'] === 0)
981
-		return false;
1022
+	if ($smcFunc['db_num_rows'] === 0) {
1023
+			return false;
1024
+	}
982 1025
 
983 1026
 	// Grab the results and return.
984 1027
 	list ($poster) = $smcFunc['db_fetch_row']($request);
@@ -1112,8 +1155,9 @@  discard block
 block discarded – undo
1112 1155
 	call_integration_hook('integrate_modify_event', array($event_id, &$eventOptions, &$event_columns, &$event_parameters));
1113 1156
 
1114 1157
 	$column_clauses = array();
1115
-	foreach ($event_columns as $col => $crit)
1116
-		$column_clauses[] = $col . ' = ' . $crit;
1158
+	foreach ($event_columns as $col => $crit) {
1159
+			$column_clauses[] = $col . ' = ' . $crit;
1160
+	}
1117 1161
 
1118 1162
 	$smcFunc['db_query']('', '
1119 1163
 		UPDATE {db_prefix}calendar
@@ -1198,8 +1242,9 @@  discard block
 block discarded – undo
1198 1242
 	);
1199 1243
 
1200 1244
 	// If nothing returned, we are in poo, poo.
1201
-	if ($smcFunc['db_num_rows']($request) === 0)
1202
-		return false;
1245
+	if ($smcFunc['db_num_rows']($request) === 0) {
1246
+			return false;
1247
+	}
1203 1248
 
1204 1249
 	$row = $smcFunc['db_fetch_assoc']($request);
1205 1250
 	$smcFunc['db_free_result']($request);
@@ -1207,8 +1252,9 @@  discard block
 block discarded – undo
1207 1252
 	list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row);
1208 1253
 
1209 1254
 	// Sanity check
1210
-	if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count']))
1211
-		return false;
1255
+	if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) {
1256
+			return false;
1257
+	}
1212 1258
 
1213 1259
 	$return_value = array(
1214 1260
 		'boards' => array(),
@@ -1345,24 +1391,27 @@  discard block
 block discarded – undo
1345 1391
 
1346 1392
 	// Set $span, in case we need it
1347 1393
 	$span = isset($eventOptions['span']) ? $eventOptions['span'] : (isset($_POST['span']) ? $_POST['span'] : 0);
1348
-	if ($span > 0)
1349
-		$span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1;
1394
+	if ($span > 0) {
1395
+			$span = !empty($modSettings['cal_maxspan']) ? min($modSettings['cal_maxspan'], $span - 1) : $span - 1;
1396
+	}
1350 1397
 
1351 1398
 	// Define the timezone for this event, falling back to the default if not provided
1352
-	if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC)))
1353
-		$tz = $eventOptions['tz'];
1354
-	elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC)))
1355
-		$tz = $_POST['tz'];
1356
-	else
1357
-		$tz = getUserTimezone();
1399
+	if (!empty($eventOptions['tz']) && in_array($eventOptions['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) {
1400
+			$tz = $eventOptions['tz'];
1401
+	} elseif (!empty($_POST['tz']) && in_array($_POST['tz'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) {
1402
+			$tz = $_POST['tz'];
1403
+	} else {
1404
+			$tz = getUserTimezone();
1405
+	}
1358 1406
 
1359 1407
 	// Is this supposed to be an all day event, or should it have specific start and end times?
1360
-	if (isset($eventOptions['allday']))
1361
-		$allday = $eventOptions['allday'];
1362
-	elseif (empty($_POST['allday']))
1363
-		$allday = false;
1364
-	else
1365
-		$allday = true;
1408
+	if (isset($eventOptions['allday'])) {
1409
+			$allday = $eventOptions['allday'];
1410
+	} elseif (empty($_POST['allday'])) {
1411
+			$allday = false;
1412
+	} else {
1413
+			$allday = true;
1414
+	}
1366 1415
 
1367 1416
 	// Input might come as individual parameters...
1368 1417
 	$start_year = isset($eventOptions['year']) ? $eventOptions['year'] : (isset($_POST['year']) ? $_POST['year'] : null);
@@ -1389,10 +1438,12 @@  discard block
 block discarded – undo
1389 1438
 	$end_time_string = isset($eventOptions['end_time']) ? $eventOptions['end_time'] : (isset($_POST['end_time']) ? $_POST['end_time'] : null);
1390 1439
 
1391 1440
 	// If the date and time were given in separate strings, combine them
1392
-	if (empty($start_string) && isset($start_date_string))
1393
-		$start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : '');
1394
-	if (empty($end_string) && isset($end_date_string))
1395
-		$end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : '');
1441
+	if (empty($start_string) && isset($start_date_string)) {
1442
+			$start_string = $start_date_string . (isset($start_time_string) ? ' ' . $start_time_string : '');
1443
+	}
1444
+	if (empty($end_string) && isset($end_date_string)) {
1445
+			$end_string = $end_date_string . (isset($end_time_string) ? ' ' . $end_time_string : '');
1446
+	}
1396 1447
 
1397 1448
 	// If some form of string input was given, override individually defined options with it
1398 1449
 	if (isset($start_string))
@@ -1483,10 +1534,11 @@  discard block
 block discarded – undo
1483 1534
 	if ($start_object >= $end_object)
1484 1535
 	{
1485 1536
 		$end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz);
1486
-		if ($span > 0)
1487
-			date_add($end_object, date_interval_create_from_date_string($span . ' days'));
1488
-		else
1489
-			date_add($end_object, date_interval_create_from_date_string('1 hour'));
1537
+		if ($span > 0) {
1538
+					date_add($end_object, date_interval_create_from_date_string($span . ' days'));
1539
+		} else {
1540
+					date_add($end_object, date_interval_create_from_date_string('1 hour'));
1541
+		}
1490 1542
 	}
1491 1543
 
1492 1544
 	// Is $end_object too late?
@@ -1499,9 +1551,9 @@  discard block
 block discarded – undo
1499 1551
 			{
1500 1552
 				$end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, $start_hour, $start_minute, $start_second) . ' ' . $tz);
1501 1553
 				date_add($end_object, date_interval_create_from_date_string($modSettings['cal_maxspan'] . ' days'));
1554
+			} else {
1555
+							$end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz);
1502 1556
 			}
1503
-			else
1504
-				$end_object = date_create(sprintf('%04d-%02d-%02d %02d:%02d:%02d', $start_year, $start_month, $start_day, '11', '59', '59') . ' ' . $tz);
1505 1557
 		}
1506 1558
 	}
1507 1559
 
@@ -1514,8 +1566,7 @@  discard block
 block discarded – undo
1514 1566
 		$start_time = null;
1515 1567
 		$end_time = null;
1516 1568
 		$tz = null;
1517
-	}
1518
-	else
1569
+	} else
1519 1570
 	{
1520 1571
 		$start_time = date_format($start_object, 'H:i:s');
1521 1572
 		$end_time = date_format($end_object, 'H:i:s');
@@ -1536,16 +1587,18 @@  discard block
 block discarded – undo
1536 1587
 	require_once($sourcedir . '/Subs.php');
1537 1588
 
1538 1589
 	// First, try to create a better date format, ignoring the "time" elements.
1539
-	if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
1540
-		$date_format = '%F';
1541
-	else
1542
-		$date_format = $matches[0];
1590
+	if (preg_match('~%[AaBbCcDdeGghjmuYy](?:[^%]*%[AaBbCcDdeGghjmuYy])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
1591
+			$date_format = '%F';
1592
+	} else {
1593
+			$date_format = $matches[0];
1594
+	}
1543 1595
 
1544 1596
 	// We want a fairly compact version of the time, but as close as possible to the user's settings.
1545
-	if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0]))
1546
-		$time_format = '%k:%M';
1547
-	else
1548
-		$time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
1597
+	if (preg_match('~%[HkIlMpPrRSTX](?:[^%]*%[HkIlMpPrRSTX])*~', $user_info['time_format'], $matches) == 0 || empty($matches[0])) {
1598
+			$time_format = '%k:%M';
1599
+	} else {
1600
+			$time_format = str_replace(array('%I', '%H', '%S', '%r', '%R', '%T'), array('%l', '%k', '', '%l:%M %p', '%k:%M', '%l:%M'), $matches[0]);
1601
+	}
1549 1602
 
1550 1603
 	// Should this be an all day event?
1551 1604
 	$allday = (empty($row['start_time']) || empty($row['end_time']) || empty($row['timezone']) || !in_array($row['timezone'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) ? true : false;
@@ -1554,8 +1607,9 @@  discard block
 block discarded – undo
1554 1607
 	$span = 1 + date_interval_format(date_diff(date_create($row['start_date']), date_create($row['end_date'])), '%d');
1555 1608
 
1556 1609
 	// We need to have a defined timezone in the steps below
1557
-	if (empty($row['timezone']))
1558
-		$row['timezone'] = getUserTimezone();
1610
+	if (empty($row['timezone'])) {
1611
+			$row['timezone'] = getUserTimezone();
1612
+	}
1559 1613
 
1560 1614
 	// Get most of the standard date information for the start and end datetimes
1561 1615
 	$start = date_parse($row['start_date'] . (!$allday ? ' ' . $row['start_time'] : ''));
@@ -1607,8 +1661,9 @@  discard block
 block discarded – undo
1607 1661
 	global $smcFunc, $context, $sourcedir, $user_info, $modSettings;
1608 1662
 	static $member_cache = array();
1609 1663
 
1610
-	if (is_null($id_member) && $user_info['is_guest'] == false)
1611
-		$id_member = $context['user']['id'];
1664
+	if (is_null($id_member) && $user_info['is_guest'] == false) {
1665
+			$id_member = $context['user']['id'];
1666
+	}
1612 1667
 
1613 1668
 	//check if the cache got the data
1614 1669
 	if (isset($id_member) && isset($member_cache[$id_member]))
@@ -1630,11 +1685,13 @@  discard block
 block discarded – undo
1630 1685
 		$smcFunc['db_free_result']($request);
1631 1686
 	}
1632 1687
 
1633
-	if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC)))
1634
-		$timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get();
1688
+	if (empty($timezone) || !in_array($timezone, timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) {
1689
+			$timezone = isset($modSettings['default_timezone']) ? $modSettings['default_timezone'] : date_default_timezone_get();
1690
+	}
1635 1691
 
1636
-	if (isset($id_member))
1637
-		$member_cache[$id_member] = $timezone;
1692
+	if (isset($id_member)) {
1693
+			$member_cache[$id_member] = $timezone;
1694
+	}
1638 1695
 
1639 1696
 	return $timezone;
1640 1697
 }
@@ -1663,8 +1720,9 @@  discard block
 block discarded – undo
1663 1720
 		)
1664 1721
 	);
1665 1722
 	$holidays = array();
1666
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1667
-		$holidays[] = $row;
1723
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
1724
+			$holidays[] = $row;
1725
+	}
1668 1726
 	$smcFunc['db_free_result']($request);
1669 1727
 
1670 1728
 	return $holidays;
Please login to merge, or discard this patch.
Sources/DbSearch-postgresql.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -38,12 +38,12 @@  discard block
 block discarded – undo
38 38
 	$version = $smcFunc['db_get_version']();
39 39
 	// if we got a Beta Version
40 40
 	if (stripos($version, 'beta') !== false)
41
-		$version = substr($version, 0, stripos($version, 'beta')).'.0';
41
+		$version = substr($version, 0, stripos($version, 'beta')) . '.0';
42 42
 	// or RC
43 43
 	if (stripos($version, 'rc') !== false)
44
-		$version = substr($version, 0, stripos($version, 'rc')).'.0';
44
+		$version = substr($version, 0, stripos($version, 'rc')) . '.0';
45 45
 
46
-	if (version_compare($version,'9.5.0','>='))
46
+	if (version_compare($version, '9.5.0', '>='))
47 47
 		$smcFunc['db_support_ignore'] = true;
48 48
 }
49 49
 
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
  */
56 56
 function smf_db_search_support($search_type)
57 57
 {
58
-	$supported_types = array('custom','fulltext');
58
+	$supported_types = array('custom', 'fulltext');
59 59
 
60 60
 	return in_array($search_type, $supported_types);
61 61
 }
@@ -109,9 +109,9 @@  discard block
 block discarded – undo
109 109
 	if (preg_match('~^\s*INSERT\sIGNORE~i', $db_string) != 0)
110 110
 	{
111 111
 		$db_string = preg_replace('~^\s*INSERT\sIGNORE~i', 'INSERT', $db_string);
112
-		if ($smcFunc['db_support_ignore']){
112
+		if ($smcFunc['db_support_ignore']) {
113 113
 			//pg style "INSERT INTO.... ON CONFLICT DO NOTHING"
114
-			$db_string = $db_string.' ON CONFLICT DO NOTHING';
114
+			$db_string = $db_string . ' ON CONFLICT DO NOTHING';
115 115
 		}
116 116
 		else
117 117
 		{
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 		$language_ftx = $modSettings['search_language'];
169 169
 	else
170 170
 	{
171
-		$request = $smcFunc['db_query']('','
171
+		$request = $smcFunc['db_query']('', '
172 172
 			SHOW default_text_search_config',
173 173
 			array()
174 174
 		);
Please login to merge, or discard this patch.
Braces   +25 added lines, -19 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  *  Add the file functions to the $smcFunc array.
@@ -23,29 +24,33 @@  discard block
 block discarded – undo
23 24
 {
24 25
 	global $smcFunc;
25 26
 
26
-	if (!isset($smcFunc['db_search_query']) || $smcFunc['db_search_query'] != 'smf_db_search_query')
27
-		$smcFunc += array(
27
+	if (!isset($smcFunc['db_search_query']) || $smcFunc['db_search_query'] != 'smf_db_search_query') {
28
+			$smcFunc += array(
28 29
 			'db_search_query' => 'smf_db_search_query',
29 30
 			'db_search_support' => 'smf_db_search_support',
30 31
 			'db_create_word_search' => 'smf_db_create_word_search',
31 32
 			'db_support_ignore' => false,
32 33
 			'db_search_language' => 'smf_db_search_language',
33 34
 		);
35
+	}
34 36
 
35 37
 	db_extend();
36 38
 
37 39
 	//pg 9.5 got ignore support
38 40
 	$version = $smcFunc['db_get_version']();
39 41
 	// if we got a Beta Version
40
-	if (stripos($version, 'beta') !== false)
41
-		$version = substr($version, 0, stripos($version, 'beta')).'.0';
42
+	if (stripos($version, 'beta') !== false) {
43
+			$version = substr($version, 0, stripos($version, 'beta')).'.0';
44
+	}
42 45
 	// or RC
43
-	if (stripos($version, 'rc') !== false)
44
-		$version = substr($version, 0, stripos($version, 'rc')).'.0';
46
+	if (stripos($version, 'rc') !== false) {
47
+			$version = substr($version, 0, stripos($version, 'rc')).'.0';
48
+	}
45 49
 
46
-	if (version_compare($version,'9.5.0','>='))
47
-		$smcFunc['db_support_ignore'] = true;
48
-}
50
+	if (version_compare($version,'9.5.0','>=')) {
51
+			$smcFunc['db_support_ignore'] = true;
52
+	}
53
+	}
49 54
 
50 55
 /**
51 56
  * This function will tell you whether this database type supports this search type.
@@ -104,16 +109,16 @@  discard block
 block discarded – undo
104 109
 		),
105 110
 	);
106 111
 
107
-	if (isset($replacements[$identifier]))
108
-		$db_string = preg_replace(array_keys($replacements[$identifier]), array_values($replacements[$identifier]), $db_string);
112
+	if (isset($replacements[$identifier])) {
113
+			$db_string = preg_replace(array_keys($replacements[$identifier]), array_values($replacements[$identifier]), $db_string);
114
+	}
109 115
 	if (preg_match('~^\s*INSERT\sIGNORE~i', $db_string) != 0)
110 116
 	{
111 117
 		$db_string = preg_replace('~^\s*INSERT\sIGNORE~i', 'INSERT', $db_string);
112 118
 		if ($smcFunc['db_support_ignore']){
113 119
 			//pg style "INSERT INTO.... ON CONFLICT DO NOTHING"
114 120
 			$db_string = $db_string.' ON CONFLICT DO NOTHING';
115
-		}
116
-		else
121
+		} else
117 122
 		{
118 123
 			// Don't error on multi-insert.
119 124
 			$db_values['db_error_skip'] = true;
@@ -121,8 +126,9 @@  discard block
 block discarded – undo
121 126
 	}
122 127
 	
123 128
 	//fix double quotes
124
-	if ($identifier == 'insert_into_log_messages_fulltext')
125
-		$db_values = str_replace('"', "'", $db_values);
129
+	if ($identifier == 'insert_into_log_messages_fulltext') {
130
+			$db_values = str_replace('"', "'", $db_values);
131
+	}
126 132
 
127 133
 	$return = $smcFunc['db_query']('', $db_string,
128 134
 		$db_values, $connection
@@ -164,9 +170,9 @@  discard block
 block discarded – undo
164 170
 	
165 171
 	$language_ftx = 'english';
166 172
 	
167
-	if (!empty($modSettings['search_language']))
168
-		$language_ftx = $modSettings['search_language'];
169
-	else
173
+	if (!empty($modSettings['search_language'])) {
174
+			$language_ftx = $modSettings['search_language'];
175
+	} else
170 176
 	{
171 177
 		$request = $smcFunc['db_query']('','
172 178
 			SHOW default_text_search_config',
Please login to merge, or discard this patch.
Sources/Subs-Editor.php 1 patch
Braces   +402 added lines, -303 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 3
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * !!!Compatibility!!!
@@ -30,8 +31,9 @@  discard block
 block discarded – undo
30 31
 {
31 32
 	global $modSettings;
32 33
 
33
-	if (!$compat_mode)
34
-		return $text;
34
+	if (!$compat_mode) {
35
+			return $text;
36
+	}
35 37
 
36 38
 	// Turn line breaks back into br's.
37 39
 	$text = strtr($text, array("\r" => '', "\n" => '<br>'));
@@ -48,8 +50,9 @@  discard block
 block discarded – undo
48 50
 			for ($i = 0, $n = count($parts); $i < $n; $i++)
49 51
 			{
50 52
 				// Value of 2 means we're inside the tag.
51
-				if ($i % 4 == 2)
52
-					$parts[$i] = strtr($parts[$i], array('[' => '&#91;', ']' => '&#93;', "'" => "'"));
53
+				if ($i % 4 == 2) {
54
+									$parts[$i] = strtr($parts[$i], array('[' => '&#91;', ']' => '&#93;', "'" => "'"));
55
+				}
53 56
 			}
54 57
 			// Put our humpty dumpty message back together again.
55 58
 			$text = implode('', $parts);
@@ -107,8 +110,9 @@  discard block
 block discarded – undo
107 110
 	$text = preg_replace('~</p>\s*(?!<)~i', '</p><br>', $text);
108 111
 
109 112
 	// Safari/webkit wraps lines in Wysiwyg in <div>'s.
110
-	if (isBrowser('webkit'))
111
-		$text = preg_replace(array('~<div(?:\s(?:[^<>]*?))?' . '>~i', '</div>'), array('<br>', ''), $text);
113
+	if (isBrowser('webkit')) {
114
+			$text = preg_replace(array('~<div(?:\s(?:[^<>]*?))?' . '>~i', '</div>'), array('<br>', ''), $text);
115
+	}
112 116
 
113 117
 	// If there's a trailing break get rid of it - Firefox tends to add one.
114 118
 	$text = preg_replace('~<br\s?/?' . '>$~i', '', $text);
@@ -123,8 +127,9 @@  discard block
 block discarded – undo
123 127
 		for ($i = 0, $n = count($parts); $i < $n; $i++)
124 128
 		{
125 129
 			// Value of 2 means we're inside the tag.
126
-			if ($i % 4 == 2)
127
-				$parts[$i] = strip_tags($parts[$i]);
130
+			if ($i % 4 == 2) {
131
+							$parts[$i] = strip_tags($parts[$i]);
132
+			}
128 133
 		}
129 134
 
130 135
 		$text = strtr(implode('', $parts), array('#smf_br_spec_grudge_cool!#' => '<br>'));
@@ -150,18 +155,19 @@  discard block
 block discarded – undo
150 155
 			{
151 156
 				$found = array_search($file, $smileysto);
152 157
 				// Note the weirdness here is to stop double spaces between smileys.
153
-				if ($found)
154
-					$matches[1][$k] = '-[]-smf_smily_start#|#' . $smcFunc['htmlspecialchars']($smileysfrom[$found]) . '-[]-smf_smily_end#|#';
155
-				else
156
-					$matches[1][$k] = '';
158
+				if ($found) {
159
+									$matches[1][$k] = '-[]-smf_smily_start#|#' . $smcFunc['htmlspecialchars']($smileysfrom[$found]) . '-[]-smf_smily_end#|#';
160
+				} else {
161
+									$matches[1][$k] = '';
162
+				}
157 163
 			}
158
-		}
159
-		else
164
+		} else
160 165
 		{
161 166
 			// Load all the smileys.
162 167
 			$names = array();
163
-			foreach ($matches[1] as $file)
164
-				$names[] = $file;
168
+			foreach ($matches[1] as $file) {
169
+							$names[] = $file;
170
+			}
165 171
 			$names = array_unique($names);
166 172
 
167 173
 			if (!empty($names))
@@ -175,13 +181,15 @@  discard block
 block discarded – undo
175 181
 					)
176 182
 				);
177 183
 				$mappings = array();
178
-				while ($row = $smcFunc['db_fetch_assoc']($request))
179
-					$mappings[$row['filename']] = $smcFunc['htmlspecialchars']($row['code']);
184
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
185
+									$mappings[$row['filename']] = $smcFunc['htmlspecialchars']($row['code']);
186
+				}
180 187
 				$smcFunc['db_free_result']($request);
181 188
 
182
-				foreach ($matches[1] as $k => $file)
183
-					if (isset($mappings[$file]))
189
+				foreach ($matches[1] as $k => $file) {
190
+									if (isset($mappings[$file]))
184 191
 						$matches[1][$k] = '-[]-smf_smily_start#|#' . $mappings[$file] . '-[]-smf_smily_end#|#';
192
+				}
185 193
 			}
186 194
 		}
187 195
 
@@ -193,8 +201,9 @@  discard block
 block discarded – undo
193 201
 	}
194 202
 
195 203
 	// Only try to buy more time if the client didn't quit.
196
-	if (connection_aborted() && $context['server']['is_apache'])
197
-		@apache_reset_timeout();
204
+	if (connection_aborted() && $context['server']['is_apache']) {
205
+			@apache_reset_timeout();
206
+	}
198 207
 
199 208
 	$parts = preg_split('~(<[A-Za-z]+\s*[^<>]*?style="?[^<>"]+"?[^<>]*?(?:/?)>|</[A-Za-z]+>)~', $text, -1, PREG_SPLIT_DELIM_CAPTURE);
200 209
 	$replacement = '';
@@ -205,9 +214,9 @@  discard block
 block discarded – undo
205 214
 		if (preg_match('~(<([A-Za-z]+)\s*[^<>]*?)style="?([^<>"]+)"?([^<>]*?(/?)>)~', $part, $matches) === 1)
206 215
 		{
207 216
 			// If it's being closed instantly, we can't deal with it...yet.
208
-			if ($matches[5] === '/')
209
-				continue;
210
-			else
217
+			if ($matches[5] === '/') {
218
+							continue;
219
+			} else
211 220
 			{
212 221
 				// Get an array of styles that apply to this element. (The strtr is there to combat HTML generated by Word.)
213 222
 				$styles = explode(';', strtr($matches[3], array('&quot;' => '')));
@@ -223,8 +232,9 @@  discard block
 block discarded – undo
223 232
 					$clean_type_value_pair = strtolower(strtr(trim($type_value_pair), '=', ':'));
224 233
 
225 234
 					// Something like 'font-weight: bold' is expected here.
226
-					if (strpos($clean_type_value_pair, ':') === false)
227
-						continue;
235
+					if (strpos($clean_type_value_pair, ':') === false) {
236
+											continue;
237
+					}
228 238
 
229 239
 					// Capture the elements of a single style item (e.g. 'font-weight' and 'bold').
230 240
 					list ($style_type, $style_value) = explode(':', $type_value_pair);
@@ -246,8 +256,7 @@  discard block
 block discarded – undo
246 256
 							{
247 257
 								$curCloseTags .= '[/u]';
248 258
 								$replacement .= '[u]';
249
-							}
250
-							elseif ($style_value == 'line-through')
259
+							} elseif ($style_value == 'line-through')
251 260
 							{
252 261
 								$curCloseTags .= '[/s]';
253 262
 								$replacement .= '[s]';
@@ -259,13 +268,11 @@  discard block
 block discarded – undo
259 268
 							{
260 269
 								$curCloseTags .= '[/left]';
261 270
 								$replacement .= '[left]';
262
-							}
263
-							elseif ($style_value == 'center')
271
+							} elseif ($style_value == 'center')
264 272
 							{
265 273
 								$curCloseTags .= '[/center]';
266 274
 								$replacement .= '[center]';
267
-							}
268
-							elseif ($style_value == 'right')
275
+							} elseif ($style_value == 'right')
269 276
 							{
270 277
 								$curCloseTags .= '[/right]';
271 278
 								$replacement .= '[right]';
@@ -287,8 +294,9 @@  discard block
 block discarded – undo
287 294
 
288 295
 						case 'font-size':
289 296
 							// Sometimes people put decimals where decimals should not be.
290
-							if (preg_match('~(\d)+\.\d+(p[xt])~i', $style_value, $dec_matches) === 1)
291
-								$style_value = $dec_matches[1] . $dec_matches[2];
297
+							if (preg_match('~(\d)+\.\d+(p[xt])~i', $style_value, $dec_matches) === 1) {
298
+															$style_value = $dec_matches[1] . $dec_matches[2];
299
+							}
292 300
 
293 301
 							$curCloseTags .= '[/size]';
294 302
 							$replacement .= '[size=' . $style_value . ']';
@@ -296,8 +304,9 @@  discard block
 block discarded – undo
296 304
 
297 305
 						case 'font-family':
298 306
 							// Only get the first freaking font if there's a list!
299
-							if (strpos($style_value, ',') !== false)
300
-								$style_value = substr($style_value, 0, strpos($style_value, ','));
307
+							if (strpos($style_value, ',') !== false) {
308
+															$style_value = substr($style_value, 0, strpos($style_value, ','));
309
+							}
301 310
 
302 311
 							$curCloseTags .= '[/font]';
303 312
 							$replacement .= '[font=' . strtr($style_value, array("'" => '')) . ']';
@@ -306,13 +315,15 @@  discard block
 block discarded – undo
306 315
 						// This is a hack for images with dimensions embedded.
307 316
 						case 'width':
308 317
 						case 'height':
309
-							if (preg_match('~[1-9]\d*~i', $style_value, $dimension) === 1)
310
-								$extra_attr .= ' ' . $style_type . '="' . $dimension[0] . '"';
318
+							if (preg_match('~[1-9]\d*~i', $style_value, $dimension) === 1) {
319
+															$extra_attr .= ' ' . $style_type . '="' . $dimension[0] . '"';
320
+							}
311 321
 						break;
312 322
 
313 323
 						case 'list-style-type':
314
-							if (preg_match('~none|disc|circle|square|decimal|decimal-leading-zero|lower-roman|upper-roman|lower-alpha|upper-alpha|lower-greek|lower-latin|upper-latin|hebrew|armenian|georgian|cjk-ideographic|hiragana|katakana|hiragana-iroha|katakana-iroha~i', $style_value, $listType) === 1)
315
-								$extra_attr .= ' listtype="' . $listType[0] . '"';
324
+							if (preg_match('~none|disc|circle|square|decimal|decimal-leading-zero|lower-roman|upper-roman|lower-alpha|upper-alpha|lower-greek|lower-latin|upper-latin|hebrew|armenian|georgian|cjk-ideographic|hiragana|katakana|hiragana-iroha|katakana-iroha~i', $style_value, $listType) === 1) {
325
+															$extra_attr .= ' listtype="' . $listType[0] . '"';
326
+							}
316 327
 						break;
317 328
 					}
318 329
 				}
@@ -325,18 +336,17 @@  discard block
 block discarded – undo
325 336
 				}
326 337
 
327 338
 				// If there's something that still needs closing, push it to the stack.
328
-				if (!empty($curCloseTags))
329
-					array_push($stack, array(
339
+				if (!empty($curCloseTags)) {
340
+									array_push($stack, array(
330 341
 							'element' => strtolower($curElement),
331 342
 							'closeTags' => $curCloseTags
332 343
 						)
333 344
 					);
334
-				elseif (!empty($extra_attr))
335
-					$replacement .= $precedingStyle . $extra_attr . $afterStyle;
345
+				} elseif (!empty($extra_attr)) {
346
+									$replacement .= $precedingStyle . $extra_attr . $afterStyle;
347
+				}
336 348
 			}
337
-		}
338
-
339
-		elseif (preg_match('~</([A-Za-z]+)>~', $part, $matches) === 1)
349
+		} elseif (preg_match('~</([A-Za-z]+)>~', $part, $matches) === 1)
340 350
 		{
341 351
 			// Is this the element that we've been waiting for to be closed?
342 352
 			if (!empty($stack) && strtolower($matches[1]) === $stack[count($stack) - 1]['element'])
@@ -346,28 +356,32 @@  discard block
 block discarded – undo
346 356
 			}
347 357
 
348 358
 			// Must've been something else.
349
-			else
350
-				$replacement .= $part;
359
+			else {
360
+							$replacement .= $part;
361
+			}
351 362
 		}
352 363
 		// In all other cases, just add the part to the replacement.
353
-		else
354
-			$replacement .= $part;
364
+		else {
365
+					$replacement .= $part;
366
+		}
355 367
 	}
356 368
 
357 369
 	// Now put back the replacement in the text.
358 370
 	$text = $replacement;
359 371
 
360 372
 	// We are not finished yet, request more time.
361
-	if (connection_aborted() && $context['server']['is_apache'])
362
-		@apache_reset_timeout();
373
+	if (connection_aborted() && $context['server']['is_apache']) {
374
+			@apache_reset_timeout();
375
+	}
363 376
 
364 377
 	// Let's pull out any legacy alignments.
365 378
 	while (preg_match('~<([A-Za-z]+)\s+[^<>]*?(align="*(left|center|right)"*)[^<>]*?(/?)>~i', $text, $matches) === 1)
366 379
 	{
367 380
 		// Find the position in the text of this tag over again.
368 381
 		$start_pos = strpos($text, $matches[0]);
369
-		if ($start_pos === false)
370
-			break;
382
+		if ($start_pos === false) {
383
+					break;
384
+		}
371 385
 
372 386
 		// End tag?
373 387
 		if ($matches[4] != '/' && strpos($text, '</' . $matches[1] . '>', $start_pos) !== false)
@@ -382,8 +396,7 @@  discard block
 block discarded – undo
382 396
 
383 397
 			// Put the tags back into the body.
384 398
 			$text = substr($text, 0, $start_pos) . $tag . '[' . $matches[3] . ']' . $content . '[/' . $matches[3] . ']' . substr($text, $end_pos);
385
-		}
386
-		else
399
+		} else
387 400
 		{
388 401
 			// Just get rid of this evil tag.
389 402
 			$text = substr($text, 0, $start_pos) . substr($text, $start_pos + strlen($matches[0]));
@@ -396,8 +409,9 @@  discard block
 block discarded – undo
396 409
 		// Find the position of this again.
397 410
 		$start_pos = strpos($text, $matches[0]);
398 411
 		$end_pos = false;
399
-		if ($start_pos === false)
400
-			break;
412
+		if ($start_pos === false) {
413
+					break;
414
+		}
401 415
 
402 416
 		// This must have an end tag - and we must find the right one.
403 417
 		$lower_text = strtolower($text);
@@ -430,8 +444,9 @@  discard block
 block discarded – undo
430 444
 				break;
431 445
 			}
432 446
 		}
433
-		if ($end_pos === false)
434
-			break;
447
+		if ($end_pos === false) {
448
+					break;
449
+		}
435 450
 
436 451
 		// Now work out what the attributes are.
437 452
 		$attribs = fetchTagAttributes($matches[1]);
@@ -445,11 +460,11 @@  discard block
 block discarded – undo
445 460
 				$v = (int) trim($v);
446 461
 				$v = empty($v) ? 1 : $v;
447 462
 				$tags[] = array('[size=' . $sizes_equivalence[$v] . ']', '[/size]');
463
+			} elseif ($s == 'face') {
464
+							$tags[] = array('[font=' . trim(strtolower($v)) . ']', '[/font]');
465
+			} elseif ($s == 'color') {
466
+							$tags[] = array('[color=' . trim(strtolower($v)) . ']', '[/color]');
448 467
 			}
449
-			elseif ($s == 'face')
450
-				$tags[] = array('[font=' . trim(strtolower($v)) . ']', '[/font]');
451
-			elseif ($s == 'color')
452
-				$tags[] = array('[color=' . trim(strtolower($v)) . ']', '[/color]');
453 468
 		}
454 469
 
455 470
 		// As before add in our tags.
@@ -457,8 +472,9 @@  discard block
 block discarded – undo
457 472
 		foreach ($tags as $tag)
458 473
 		{
459 474
 			$before .= $tag[0];
460
-			if (isset($tag[1]))
461
-				$after = $tag[1] . $after;
475
+			if (isset($tag[1])) {
476
+							$after = $tag[1] . $after;
477
+			}
462 478
 		}
463 479
 
464 480
 		// Remove the tag so it's never checked again.
@@ -469,8 +485,9 @@  discard block
 block discarded – undo
469 485
 	}
470 486
 
471 487
 	// Almost there, just a little more time.
472
-	if (connection_aborted() && $context['server']['is_apache'])
473
-		@apache_reset_timeout();
488
+	if (connection_aborted() && $context['server']['is_apache']) {
489
+			@apache_reset_timeout();
490
+	}
474 491
 
475 492
 	if (count($parts = preg_split('~<(/?)(li|ol|ul)([^>]*)>~i', $text, null, PREG_SPLIT_DELIM_CAPTURE)) > 1)
476 493
 	{
@@ -526,12 +543,13 @@  discard block
 block discarded – undo
526 543
 						{
527 544
 							$inList = true;
528 545
 
529
-							if ($tag === 'ol')
530
-								$listType = 'decimal';
531
-							elseif (preg_match('~type="?(' . implode('|', array_keys($listTypeMapping)) . ')"?~', $parts[$i + 3], $match) === 1)
532
-								$listType = $listTypeMapping[$match[1]];
533
-							else
534
-								$listType = null;
546
+							if ($tag === 'ol') {
547
+															$listType = 'decimal';
548
+							} elseif (preg_match('~type="?(' . implode('|', array_keys($listTypeMapping)) . ')"?~', $parts[$i + 3], $match) === 1) {
549
+															$listType = $listTypeMapping[$match[1]];
550
+							} else {
551
+															$listType = null;
552
+							}
535 553
 
536 554
 							$listDepth++;
537 555
 
@@ -595,9 +613,7 @@  discard block
 block discarded – undo
595 613
 							$parts[$i + 1] = '';
596 614
 							$parts[$i + 2] = str_repeat("\t", $listDepth) . '[/list]';
597 615
 							$parts[$i + 3] = '';
598
-						}
599
-
600
-						else
616
+						} else
601 617
 						{
602 618
 							// We're in a list item.
603 619
 							if ($listDepth > 0)
@@ -634,9 +650,7 @@  discard block
 block discarded – undo
634 650
 							$parts[$i + 1] = '';
635 651
 							$parts[$i + 2] = '';
636 652
 							$parts[$i + 3] = '';
637
-						}
638
-
639
-						else
653
+						} else
640 654
 						{
641 655
 							// Remove the trailing breaks from the list item.
642 656
 							$parts[$i] = preg_replace('~\s*<br\s*' . '/?' . '>\s*$~', '', $parts[$i]);
@@ -674,8 +688,9 @@  discard block
 block discarded – undo
674 688
 			$text .= str_repeat("\t", $listDepth) . '[/list]';
675 689
 		}
676 690
 
677
-		for ($i = $listDepth; $i > 0; $i--)
678
-			$text .= '[/li]' . "\n" . str_repeat("\t", $i - 1) . '[/list]';
691
+		for ($i = $listDepth; $i > 0; $i--) {
692
+					$text .= '[/li]' . "\n" . str_repeat("\t", $i - 1) . '[/list]';
693
+		}
679 694
 
680 695
 	}
681 696
 
@@ -684,8 +699,9 @@  discard block
 block discarded – undo
684 699
 	{
685 700
 		// Find the position of the image.
686 701
 		$start_pos = strpos($text, $matches[0]);
687
-		if ($start_pos === false)
688
-			break;
702
+		if ($start_pos === false) {
703
+					break;
704
+		}
689 705
 		$end_pos = $start_pos + strlen($matches[0]);
690 706
 
691 707
 		$params = '';
@@ -694,12 +710,13 @@  discard block
 block discarded – undo
694 710
 		$attrs = fetchTagAttributes($matches[1]);
695 711
 		foreach ($attrs as $attrib => $value)
696 712
 		{
697
-			if (in_array($attrib, array('width', 'height')))
698
-				$params .= ' ' . $attrib . '=' . (int) $value;
699
-			elseif ($attrib == 'alt' && trim($value) != '')
700
-				$params .= ' alt=' . trim($value);
701
-			elseif ($attrib == 'src')
702
-				$src = trim($value);
713
+			if (in_array($attrib, array('width', 'height'))) {
714
+							$params .= ' ' . $attrib . '=' . (int) $value;
715
+			} elseif ($attrib == 'alt' && trim($value) != '') {
716
+							$params .= ' alt=' . trim($value);
717
+			} elseif ($attrib == 'src') {
718
+							$src = trim($value);
719
+			}
703 720
 		}
704 721
 
705 722
 		$tag = '';
@@ -710,10 +727,11 @@  discard block
 block discarded – undo
710 727
 			{
711 728
 				$baseURL = (isset($parsedURL['scheme']) ? $parsedURL['scheme'] : 'http') . '://' . $parsedURL['host'] . (empty($parsedURL['port']) ? '' : ':' . $parsedURL['port']);
712 729
 
713
-				if (substr($src, 0, 1) === '/')
714
-					$src = $baseURL . $src;
715
-				else
716
-					$src = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $src;
730
+				if (substr($src, 0, 1) === '/') {
731
+									$src = $baseURL . $src;
732
+				} else {
733
+									$src = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $src;
734
+				}
717 735
 			}
718 736
 
719 737
 			$tag = '[img' . $params . ']' . $src . '[/img]';
@@ -891,20 +909,23 @@  discard block
 block discarded – undo
891 909
 		},
892 910
 	);
893 911
 
894
-	foreach ($tags as $tag => $replace)
895
-		$text = preg_replace_callback($tag, $replace, $text);
912
+	foreach ($tags as $tag => $replace) {
913
+			$text = preg_replace_callback($tag, $replace, $text);
914
+	}
896 915
 
897 916
 	// Please give us just a little more time.
898
-	if (connection_aborted() && $context['server']['is_apache'])
899
-		@apache_reset_timeout();
917
+	if (connection_aborted() && $context['server']['is_apache']) {
918
+			@apache_reset_timeout();
919
+	}
900 920
 
901 921
 	// What about URL's - the pain in the ass of the tag world.
902 922
 	while (preg_match('~<a\s+([^<>]*)>([^<>]*)</a>~i', $text, $matches) === 1)
903 923
 	{
904 924
 		// Find the position of the URL.
905 925
 		$start_pos = strpos($text, $matches[0]);
906
-		if ($start_pos === false)
907
-			break;
926
+		if ($start_pos === false) {
927
+					break;
928
+		}
908 929
 		$end_pos = $start_pos + strlen($matches[0]);
909 930
 
910 931
 		$tag_type = 'url';
@@ -918,8 +939,9 @@  discard block
 block discarded – undo
918 939
 				$href = trim($value);
919 940
 
920 941
 				// Are we dealing with an FTP link?
921
-				if (preg_match('~^ftps?://~', $href) === 1)
922
-					$tag_type = 'ftp';
942
+				if (preg_match('~^ftps?://~', $href) === 1) {
943
+									$tag_type = 'ftp';
944
+				}
923 945
 
924 946
 				// Or is this a link to an email address?
925 947
 				elseif (substr($href, 0, 7) == 'mailto:')
@@ -933,28 +955,31 @@  discard block
 block discarded – undo
933 955
 				{
934 956
 					$baseURL = (isset($parsedURL['scheme']) ? $parsedURL['scheme'] : 'http') . '://' . $parsedURL['host'] . (empty($parsedURL['port']) ? '' : ':' . $parsedURL['port']);
935 957
 
936
-					if (substr($href, 0, 1) === '/')
937
-						$href = $baseURL . $href;
938
-					else
939
-						$href = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $href;
958
+					if (substr($href, 0, 1) === '/') {
959
+											$href = $baseURL . $href;
960
+					} else {
961
+											$href = $baseURL . (empty($parsedURL['path']) ? '/' : preg_replace('~/(?:index\\.php)?$~', '', $parsedURL['path'])) . '/' . $href;
962
+					}
940 963
 				}
941 964
 			}
942 965
 
943 966
 			// External URL?
944 967
 			if ($attrib == 'target' && $tag_type == 'url')
945 968
 			{
946
-				if (trim($value) == '_blank')
947
-					$tag_type == 'iurl';
969
+				if (trim($value) == '_blank') {
970
+									$tag_type == 'iurl';
971
+				}
948 972
 			}
949 973
 		}
950 974
 
951 975
 		$tag = '';
952 976
 		if ($href != '')
953 977
 		{
954
-			if ($matches[2] == $href)
955
-				$tag = '[' . $tag_type . ']' . $href . '[/' . $tag_type . ']';
956
-			else
957
-				$tag = '[' . $tag_type . '=' . $href . ']' . $matches[2] . '[/' . $tag_type . ']';
978
+			if ($matches[2] == $href) {
979
+							$tag = '[' . $tag_type . ']' . $href . '[/' . $tag_type . ']';
980
+			} else {
981
+							$tag = '[' . $tag_type . '=' . $href . ']' . $matches[2] . '[/' . $tag_type . ']';
982
+			}
958 983
 		}
959 984
 
960 985
 		// Replace the tag
@@ -993,17 +1018,18 @@  discard block
 block discarded – undo
993 1018
 		// We're either moving from the key to the attribute or we're in a string and this is fine.
994 1019
 		if ($text[$i] == '=')
995 1020
 		{
996
-			if ($tag_state == 0)
997
-				$tag_state = 1;
998
-			elseif ($tag_state == 2)
999
-				$value .= '=';
1021
+			if ($tag_state == 0) {
1022
+							$tag_state = 1;
1023
+			} elseif ($tag_state == 2) {
1024
+							$value .= '=';
1025
+			}
1000 1026
 		}
1001 1027
 		// A space is either moving from an attribute back to a potential key or in a string is fine.
1002 1028
 		elseif ($text[$i] == ' ')
1003 1029
 		{
1004
-			if ($tag_state == 2)
1005
-				$value .= ' ';
1006
-			elseif ($tag_state == 1)
1030
+			if ($tag_state == 2) {
1031
+							$value .= ' ';
1032
+			} elseif ($tag_state == 1)
1007 1033
 			{
1008 1034
 				$attribs[$key] = $value;
1009 1035
 				$key = $value = '';
@@ -1014,24 +1040,27 @@  discard block
 block discarded – undo
1014 1040
 		elseif ($text[$i] == '"')
1015 1041
 		{
1016 1042
 			// Must be either going into or out of a string.
1017
-			if ($tag_state == 1)
1018
-				$tag_state = 2;
1019
-			else
1020
-				$tag_state = 1;
1043
+			if ($tag_state == 1) {
1044
+							$tag_state = 2;
1045
+			} else {
1046
+							$tag_state = 1;
1047
+			}
1021 1048
 		}
1022 1049
 		// Otherwise it's fine.
1023 1050
 		else
1024 1051
 		{
1025
-			if ($tag_state == 0)
1026
-				$key .= $text[$i];
1027
-			else
1028
-				$value .= $text[$i];
1052
+			if ($tag_state == 0) {
1053
+							$key .= $text[$i];
1054
+			} else {
1055
+							$value .= $text[$i];
1056
+			}
1029 1057
 		}
1030 1058
 	}
1031 1059
 
1032 1060
 	// Anything left?
1033
-	if ($key != '' && $value != '')
1034
-		$attribs[$key] = $value;
1061
+	if ($key != '' && $value != '') {
1062
+			$attribs[$key] = $value;
1063
+	}
1035 1064
 
1036 1065
 	return $attribs;
1037 1066
 }
@@ -1047,15 +1076,17 @@  discard block
 block discarded – undo
1047 1076
 	global $modSettings;
1048 1077
 
1049 1078
 	// Don't care about the texts that are too short.
1050
-	if (strlen($text) < 3)
1051
-		return $text;
1079
+	if (strlen($text) < 3) {
1080
+			return $text;
1081
+	}
1052 1082
 
1053 1083
 	// A list of tags that's disabled by the admin.
1054 1084
 	$disabled = empty($modSettings['disabledBBC']) ? array() : array_flip(explode(',', strtolower($modSettings['disabledBBC'])));
1055 1085
 
1056 1086
 	// Add flash if it's disabled as embedded tag.
1057
-	if (empty($modSettings['enableEmbeddedFlash']))
1058
-		$disabled['flash'] = true;
1087
+	if (empty($modSettings['enableEmbeddedFlash'])) {
1088
+			$disabled['flash'] = true;
1089
+	}
1059 1090
 
1060 1091
 	// Get a list of all the tags that are not disabled.
1061 1092
 	$all_tags = parse_bbc(false);
@@ -1063,10 +1094,12 @@  discard block
 block discarded – undo
1063 1094
 	$self_closing_tags = array();
1064 1095
 	foreach ($all_tags as $tag)
1065 1096
 	{
1066
-		if (!isset($disabled[$tag['tag']]))
1067
-			$valid_tags[$tag['tag']] = !empty($tag['block_level']);
1068
-		if (isset($tag['type']) && $tag['type'] == 'closed')
1069
-			$self_closing_tags[] = $tag['tag'];
1097
+		if (!isset($disabled[$tag['tag']])) {
1098
+					$valid_tags[$tag['tag']] = !empty($tag['block_level']);
1099
+		}
1100
+		if (isset($tag['type']) && $tag['type'] == 'closed') {
1101
+					$self_closing_tags[] = $tag['tag'];
1102
+		}
1070 1103
 	}
1071 1104
 
1072 1105
 	// Right - we're going to start by going through the whole lot to make sure we don't have align stuff crossed as this happens load and is stupid!
@@ -1093,16 +1126,19 @@  discard block
 block discarded – undo
1093 1126
 				$tagName = substr($match, $isClosingTag ? 2 : 1, -1);
1094 1127
 
1095 1128
 				// We're closing the exact same tag that we opened.
1096
-				if ($isClosingTag && $insideTag === $tagName)
1097
-					$insideTag = null;
1129
+				if ($isClosingTag && $insideTag === $tagName) {
1130
+									$insideTag = null;
1131
+				}
1098 1132
 
1099 1133
 				// We're opening a tag and we're not yet inside one either
1100
-				elseif (!$isClosingTag && $insideTag === null)
1101
-					$insideTag = $tagName;
1134
+				elseif (!$isClosingTag && $insideTag === null) {
1135
+									$insideTag = $tagName;
1136
+				}
1102 1137
 
1103 1138
 				// In all other cases, this tag must be invalid
1104
-				else
1105
-					unset($matches[$i]);
1139
+				else {
1140
+									unset($matches[$i]);
1141
+				}
1106 1142
 			}
1107 1143
 
1108 1144
 			// The next one is gonna be the other one.
@@ -1110,8 +1146,9 @@  discard block
 block discarded – undo
1110 1146
 		}
1111 1147
 
1112 1148
 		// We're still inside a tag and had no chance for closure?
1113
-		if ($insideTag !== null)
1114
-			$matches[] = '[/' . $insideTag . ']';
1149
+		if ($insideTag !== null) {
1150
+					$matches[] = '[/' . $insideTag . ']';
1151
+		}
1115 1152
 
1116 1153
 		// And a complete text string again.
1117 1154
 		$text = implode('', $matches);
@@ -1120,8 +1157,9 @@  discard block
 block discarded – undo
1120 1157
 	// Quickly remove any tags which are back to back.
1121 1158
 	$backToBackPattern = '~\\[(' . implode('|', array_diff(array_keys($valid_tags), array('td', 'anchor'))) . ')[^<>\\[\\]]*\\]\s*\\[/\\1\\]~';
1122 1159
 	$lastlen = 0;
1123
-	while (strlen($text) !== $lastlen)
1124
-		$lastlen = strlen($text = preg_replace($backToBackPattern, '', $text));
1160
+	while (strlen($text) !== $lastlen) {
1161
+			$lastlen = strlen($text = preg_replace($backToBackPattern, '', $text));
1162
+	}
1125 1163
 
1126 1164
 	// Need to sort the tags my name length.
1127 1165
 	uksort($valid_tags, 'sort_array_length');
@@ -1158,8 +1196,9 @@  discard block
 block discarded – undo
1158 1196
 			$isCompetingTag = in_array($tag, $competing_tags);
1159 1197
 
1160 1198
 			// Check if this might be one of those cleaned out tags.
1161
-			if ($tag === '')
1162
-				continue;
1199
+			if ($tag === '') {
1200
+							continue;
1201
+			}
1163 1202
 
1164 1203
 			// Special case: inside [code] blocks any code is left untouched.
1165 1204
 			elseif ($tag === 'code')
@@ -1170,8 +1209,9 @@  discard block
 block discarded – undo
1170 1209
 					$inCode = false;
1171 1210
 
1172 1211
 					// Reopen tags that were closed before the code block.
1173
-					if (!empty($inlineElements))
1174
-						$parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']';
1212
+					if (!empty($inlineElements)) {
1213
+											$parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']';
1214
+					}
1175 1215
 				}
1176 1216
 
1177 1217
 				// We're outside a coding and nobbc block and opening it.
@@ -1200,8 +1240,9 @@  discard block
 block discarded – undo
1200 1240
 					$inNoBbc = false;
1201 1241
 
1202 1242
 					// Some inline elements might've been closed that need reopening.
1203
-					if (!empty($inlineElements))
1204
-						$parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']';
1243
+					if (!empty($inlineElements)) {
1244
+											$parts[$i + 4] .= '[' . implode('][', array_keys($inlineElements)) . ']';
1245
+					}
1205 1246
 				}
1206 1247
 
1207 1248
 				// We're outside a nobbc and coding block and opening it.
@@ -1221,8 +1262,9 @@  discard block
 block discarded – undo
1221 1262
 			}
1222 1263
 
1223 1264
 			// So, we're inside one of the special blocks: ignore any tag.
1224
-			elseif ($inCode || $inNoBbc)
1225
-				continue;
1265
+			elseif ($inCode || $inNoBbc) {
1266
+							continue;
1267
+			}
1226 1268
 
1227 1269
 			// We're dealing with an opening tag.
1228 1270
 			if ($isOpeningTag)
@@ -1263,8 +1305,9 @@  discard block
 block discarded – undo
1263 1305
 							if ($parts[$j + 3] === $tag)
1264 1306
 							{
1265 1307
 								// If it's an opening tag, increase the level.
1266
-								if ($parts[$j + 2] === '')
1267
-									$curLevel++;
1308
+								if ($parts[$j + 2] === '') {
1309
+																	$curLevel++;
1310
+								}
1268 1311
 
1269 1312
 								// A closing tag, decrease the level.
1270 1313
 								else
@@ -1287,13 +1330,15 @@  discard block
 block discarded – undo
1287 1330
 					{
1288 1331
 						if ($isCompetingTag)
1289 1332
 						{
1290
-							if (!isset($competingElements[$tag]))
1291
-								$competingElements[$tag] = array();
1333
+							if (!isset($competingElements[$tag])) {
1334
+															$competingElements[$tag] = array();
1335
+							}
1292 1336
 
1293 1337
 							$competingElements[$tag][] = $parts[$i + 4];
1294 1338
 
1295
-							if (count($competingElements[$tag]) > 1)
1296
-								$parts[$i] .= '[/' . $tag . ']';
1339
+							if (count($competingElements[$tag]) > 1) {
1340
+															$parts[$i] .= '[/' . $tag . ']';
1341
+							}
1297 1342
 						}
1298 1343
 
1299 1344
 						$inlineElements[$elementContent] = $tag;
@@ -1314,15 +1359,17 @@  discard block
 block discarded – undo
1314 1359
 						$addClosingTags = array();
1315 1360
 						while ($element = array_pop($blockElements))
1316 1361
 						{
1317
-							if ($element === $tag)
1318
-								break;
1362
+							if ($element === $tag) {
1363
+															break;
1364
+							}
1319 1365
 
1320 1366
 							// Still a block tag was open not equal to this tag.
1321 1367
 							$addClosingTags[] = $element['type'];
1322 1368
 						}
1323 1369
 
1324
-						if (!empty($addClosingTags))
1325
-							$parts[$i + 1] = '[/' . implode('][/', array_reverse($addClosingTags)) . ']' . $parts[$i + 1];
1370
+						if (!empty($addClosingTags)) {
1371
+													$parts[$i + 1] = '[/' . implode('][/', array_reverse($addClosingTags)) . ']' . $parts[$i + 1];
1372
+						}
1326 1373
 
1327 1374
 						// Apparently the closing tag was not found on the stack.
1328 1375
 						if (!is_string($element) || $element !== $tag)
@@ -1332,8 +1379,7 @@  discard block
 block discarded – undo
1332 1379
 							$parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = '';
1333 1380
 							continue;
1334 1381
 						}
1335
-					}
1336
-					else
1382
+					} else
1337 1383
 					{
1338 1384
 						// Get rid of this closing tag!
1339 1385
 						$parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = '';
@@ -1362,53 +1408,62 @@  discard block
 block discarded – undo
1362 1408
 							unset($inlineElements[$tagContentToBeClosed]);
1363 1409
 
1364 1410
 							// Was this the tag we were looking for?
1365
-							if ($tagToBeClosed === $tag)
1366
-								break;
1411
+							if ($tagToBeClosed === $tag) {
1412
+															break;
1413
+							}
1367 1414
 
1368 1415
 							// Nope, close it and look further!
1369
-							else
1370
-								$parts[$i] .= '[/' . $tagToBeClosed . ']';
1416
+							else {
1417
+															$parts[$i] .= '[/' . $tagToBeClosed . ']';
1418
+							}
1371 1419
 						}
1372 1420
 
1373 1421
 						if ($isCompetingTag && !empty($competingElements[$tag]))
1374 1422
 						{
1375 1423
 							array_pop($competingElements[$tag]);
1376 1424
 
1377
-							if (count($competingElements[$tag]) > 0)
1378
-								$parts[$i + 5] = '[' . $tag . $competingElements[$tag][count($competingElements[$tag]) - 1] . $parts[$i + 5];
1425
+							if (count($competingElements[$tag]) > 0) {
1426
+															$parts[$i + 5] = '[' . $tag . $competingElements[$tag][count($competingElements[$tag]) - 1] . $parts[$i + 5];
1427
+							}
1379 1428
 						}
1380 1429
 					}
1381 1430
 
1382 1431
 					// Unexpected closing tag, ex-ter-mi-nate.
1383
-					else
1384
-						$parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = '';
1432
+					else {
1433
+											$parts[$i + 1] = $parts[$i + 2] = $parts[$i + 3] = $parts[$i + 4] = '';
1434
+					}
1385 1435
 				}
1386 1436
 			}
1387 1437
 		}
1388 1438
 
1389 1439
 		// Close the code tags.
1390
-		if ($inCode)
1391
-			$parts[$i] .= '[/code]';
1440
+		if ($inCode) {
1441
+					$parts[$i] .= '[/code]';
1442
+		}
1392 1443
 
1393 1444
 		// The same for nobbc tags.
1394
-		elseif ($inNoBbc)
1395
-			$parts[$i] .= '[/nobbc]';
1445
+		elseif ($inNoBbc) {
1446
+					$parts[$i] .= '[/nobbc]';
1447
+		}
1396 1448
 
1397 1449
 		// Still inline tags left unclosed? Close them now, better late than never.
1398
-		elseif (!empty($inlineElements))
1399
-			$parts[$i] .= '[/' . implode('][/', array_reverse($inlineElements)) . ']';
1450
+		elseif (!empty($inlineElements)) {
1451
+					$parts[$i] .= '[/' . implode('][/', array_reverse($inlineElements)) . ']';
1452
+		}
1400 1453
 
1401 1454
 		// Now close the block elements.
1402
-		if (!empty($blockElements))
1403
-			$parts[$i] .= '[/' . implode('][/', array_reverse($blockElements)) . ']';
1455
+		if (!empty($blockElements)) {
1456
+					$parts[$i] .= '[/' . implode('][/', array_reverse($blockElements)) . ']';
1457
+		}
1404 1458
 
1405 1459
 		$text = implode('', $parts);
1406 1460
 	}
1407 1461
 
1408 1462
 	// Final clean up of back to back tags.
1409 1463
 	$lastlen = 0;
1410
-	while (strlen($text) !== $lastlen)
1411
-		$lastlen = strlen($text = preg_replace($backToBackPattern, '', $text));
1464
+	while (strlen($text) !== $lastlen) {
1465
+			$lastlen = strlen($text = preg_replace($backToBackPattern, '', $text));
1466
+	}
1412 1467
 
1413 1468
 	return $text;
1414 1469
 }
@@ -1437,22 +1492,25 @@  discard block
 block discarded – undo
1437 1492
 	$context['template_layers'] = array();
1438 1493
 	// Lets make sure we aren't going to output anything nasty.
1439 1494
 	@ob_end_clean();
1440
-	if (!empty($modSettings['enableCompressedOutput']))
1441
-		@ob_start('ob_gzhandler');
1442
-	else
1443
-		@ob_start();
1495
+	if (!empty($modSettings['enableCompressedOutput'])) {
1496
+			@ob_start('ob_gzhandler');
1497
+	} else {
1498
+			@ob_start();
1499
+	}
1444 1500
 
1445 1501
 	// If we don't have any locale better avoid broken js
1446
-	if (empty($txt['lang_locale']))
1447
-		die();
1502
+	if (empty($txt['lang_locale'])) {
1503
+			die();
1504
+	}
1448 1505
 
1449 1506
 	$file_data = '(function ($) {
1450 1507
 	\'use strict\';
1451 1508
 
1452 1509
 	$.sceditor.locale[' . javaScriptEscape($txt['lang_locale']) . '] = {';
1453
-	foreach ($editortxt as $key => $val)
1454
-		$file_data .= '
1510
+	foreach ($editortxt as $key => $val) {
1511
+			$file_data .= '
1455 1512
 		' . javaScriptEscape($key) . ': ' . javaScriptEscape($val) . ',';
1513
+	}
1456 1514
 
1457 1515
 	$file_data .= '
1458 1516
 		dateFormat: "day.month.year"
@@ -1520,8 +1578,9 @@  discard block
 block discarded – undo
1520 1578
 				)
1521 1579
 			);
1522 1580
 			$icon_data = array();
1523
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1524
-				$icon_data[] = $row;
1581
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1582
+							$icon_data[] = $row;
1583
+			}
1525 1584
 			$smcFunc['db_free_result']($request);
1526 1585
 
1527 1586
 			$icons = array();
@@ -1536,9 +1595,9 @@  discard block
 block discarded – undo
1536 1595
 			}
1537 1596
 
1538 1597
 			cache_put_data('posting_icons-' . $board_id, $icons, 480);
1598
+		} else {
1599
+					$icons = $temp;
1539 1600
 		}
1540
-		else
1541
-			$icons = $temp;
1542 1601
 	}
1543 1602
 	call_integration_hook('integrate_load_message_icons', array(&$icons));
1544 1603
 
@@ -1579,8 +1638,9 @@  discard block
 block discarded – undo
1579 1638
 	{
1580 1639
 		// Some general stuff.
1581 1640
 		$settings['smileys_url'] = $modSettings['smileys_url'] . '/' . $user_info['smiley_set'];
1582
-		if (!empty($context['drafts_autosave']))
1583
-			$context['drafts_autosave_frequency'] = empty($modSettings['drafts_autosave_frequency']) ? 60000 : $modSettings['drafts_autosave_frequency'] * 1000;
1641
+		if (!empty($context['drafts_autosave'])) {
1642
+					$context['drafts_autosave_frequency'] = empty($modSettings['drafts_autosave_frequency']) ? 60000 : $modSettings['drafts_autosave_frequency'] * 1000;
1643
+		}
1584 1644
 
1585 1645
 		// This really has some WYSIWYG stuff.
1586 1646
 		loadCSSFile('jquery.sceditor.css', array('force_current' => false, 'validate' => true), 'smf_jquery_sceditor');
@@ -1596,8 +1656,9 @@  discard block
 block discarded – undo
1596 1656
 		var bbc_quote = \'' . addcslashes($txt['quote'], "'") . '\';
1597 1657
 		var bbc_search_on = \'' . addcslashes($txt['search_on'], "'") . '\';');
1598 1658
 		// editor language file
1599
-		if (!empty($txt['lang_locale']) && $txt['lang_locale'] != 'en_US')
1600
-			loadJavaScriptFile($scripturl . '?action=loadeditorlocale', array('external' => true), 'sceditor_language');
1659
+		if (!empty($txt['lang_locale']) && $txt['lang_locale'] != 'en_US') {
1660
+					loadJavaScriptFile($scripturl . '?action=loadeditorlocale', array('external' => true), 'sceditor_language');
1661
+		}
1601 1662
 
1602 1663
 		$context['shortcuts_text'] = $txt['shortcuts' . (!empty($context['drafts_save']) ? '_drafts' : '') . (stripos($_SERVER['HTTP_USER_AGENT'], 'Macintosh') !== false ? '_mac' : (isBrowser('is_firefox') ? '_firefox' : ''))];
1603 1664
 		$context['show_spellchecking'] = !empty($modSettings['enableSpellChecking']) && (function_exists('pspell_new') || (function_exists('enchant_broker_init') && ($txt['lang_charset'] == 'UTF-8' || function_exists('iconv'))));
@@ -1606,11 +1667,12 @@  discard block
 block discarded – undo
1606 1667
 			loadJavaScriptFile('spellcheck.js', array(), 'smf_spellcheck');
1607 1668
 
1608 1669
 			// Some hidden information is needed in order to make the spell checking work.
1609
-			if (!isset($_REQUEST['xml']))
1610
-				$context['insert_after_template'] .= '
1670
+			if (!isset($_REQUEST['xml'])) {
1671
+							$context['insert_after_template'] .= '
1611 1672
 		<form name="spell_form" id="spell_form" method="post" accept-charset="' . $context['character_set'] . '" target="spellWindow" action="' . $scripturl . '?action=spellcheck">
1612 1673
 			<input type="hidden" name="spellstring" value="">
1613 1674
 		</form>';
1675
+			}
1614 1676
 		}
1615 1677
 	}
1616 1678
 
@@ -1776,10 +1838,12 @@  discard block
 block discarded – undo
1776 1838
 
1777 1839
 		// Generate a list of buttons that shouldn't be shown - this should be the fastest way to do this.
1778 1840
 		$disabled_tags = array();
1779
-		if (!empty($modSettings['disabledBBC']))
1780
-			$disabled_tags = explode(',', $modSettings['disabledBBC']);
1781
-		if (empty($modSettings['enableEmbeddedFlash']))
1782
-			$disabled_tags[] = 'flash';
1841
+		if (!empty($modSettings['disabledBBC'])) {
1842
+					$disabled_tags = explode(',', $modSettings['disabledBBC']);
1843
+		}
1844
+		if (empty($modSettings['enableEmbeddedFlash'])) {
1845
+					$disabled_tags[] = 'flash';
1846
+		}
1783 1847
 
1784 1848
 		foreach ($disabled_tags as $tag)
1785 1849
 		{
@@ -1789,9 +1853,10 @@  discard block
 block discarded – undo
1789 1853
 				$context['disabled_tags']['orderedlist'] = true;
1790 1854
 			}
1791 1855
 
1792
-			foreach ($editor_tag_map as $thisTag => $tagNameBBC)
1793
-				if ($tag === $thisTag)
1856
+			foreach ($editor_tag_map as $thisTag => $tagNameBBC) {
1857
+							if ($tag === $thisTag)
1794 1858
 					$context['disabled_tags'][$tagNameBBC] = true;
1859
+			}
1795 1860
 
1796 1861
 			$context['disabled_tags'][trim($tag)] = true;
1797 1862
 		}
@@ -1801,19 +1866,21 @@  discard block
 block discarded – undo
1801 1866
 		$context['bbc_toolbar'] = array();
1802 1867
 		foreach ($context['bbc_tags'] as $row => $tagRow)
1803 1868
 		{
1804
-			if (!isset($context['bbc_toolbar'][$row]))
1805
-				$context['bbc_toolbar'][$row] = array();
1869
+			if (!isset($context['bbc_toolbar'][$row])) {
1870
+							$context['bbc_toolbar'][$row] = array();
1871
+			}
1806 1872
 			$tagsRow = array();
1807 1873
 			foreach ($tagRow as $tag)
1808 1874
 			{
1809 1875
 				if ((!empty($tag['code'])) && empty($context['disabled_tags'][$tag['code']]))
1810 1876
 				{
1811 1877
 					$tagsRow[] = $tag['code'];
1812
-					if (isset($tag['image']))
1813
-						$bbcodes_styles .= '
1878
+					if (isset($tag['image'])) {
1879
+											$bbcodes_styles .= '
1814 1880
 			.sceditor-button-' . $tag['code'] . ' div {
1815 1881
 				background: url(\'' . $settings['default_theme_url'] . '/images/bbc/' . $tag['image'] . '.png\');
1816 1882
 			}';
1883
+					}
1817 1884
 					if (isset($tag['before']))
1818 1885
 					{
1819 1886
 						$context['bbcodes_handlers'] .= '
@@ -1827,8 +1894,7 @@  discard block
 block discarded – undo
1827 1894
 				});';
1828 1895
 					}
1829 1896
 
1830
-				}
1831
-				else
1897
+				} else
1832 1898
 				{
1833 1899
 					$context['bbc_toolbar'][$row][] = implode(',', $tagsRow);
1834 1900
 					$tagsRow = array();
@@ -1839,14 +1905,16 @@  discard block
 block discarded – undo
1839 1905
 			{
1840 1906
 				$context['bbc_toolbar'][$row][] = implode(',', $tagsRow);
1841 1907
 				$tagsRow = array();
1842
-				if (!isset($context['disabled_tags']['font']))
1843
-					$tagsRow[] = 'font';
1844
-				if (!isset($context['disabled_tags']['size']))
1845
-					$tagsRow[] = 'size';
1846
-				if (!isset($context['disabled_tags']['color']))
1847
-					$tagsRow[] = 'color';
1848
-			}
1849
-			elseif ($row == 1 && empty($modSettings['disable_wysiwyg']))
1908
+				if (!isset($context['disabled_tags']['font'])) {
1909
+									$tagsRow[] = 'font';
1910
+				}
1911
+				if (!isset($context['disabled_tags']['size'])) {
1912
+									$tagsRow[] = 'size';
1913
+				}
1914
+				if (!isset($context['disabled_tags']['color'])) {
1915
+									$tagsRow[] = 'color';
1916
+				}
1917
+			} elseif ($row == 1 && empty($modSettings['disable_wysiwyg']))
1850 1918
 			{
1851 1919
 				$tmp = array();
1852 1920
 				$tagsRow[] = 'removeformat';
@@ -1857,13 +1925,15 @@  discard block
 block discarded – undo
1857 1925
 				}
1858 1926
 			}
1859 1927
 
1860
-			if (!empty($tagsRow))
1861
-				$context['bbc_toolbar'][$row][] = implode(',', $tagsRow);
1928
+			if (!empty($tagsRow)) {
1929
+							$context['bbc_toolbar'][$row][] = implode(',', $tagsRow);
1930
+			}
1862 1931
 		}
1863
-		if (!empty($bbcodes_styles))
1864
-			$context['html_headers'] .= '
1932
+		if (!empty($bbcodes_styles)) {
1933
+					$context['html_headers'] .= '
1865 1934
 		<style>' . $bbcodes_styles . '
1866 1935
 		</style>';
1936
+		}
1867 1937
 	}
1868 1938
 
1869 1939
 	// Initialize smiley array... if not loaded before.
@@ -1875,8 +1945,8 @@  discard block
 block discarded – undo
1875 1945
 		);
1876 1946
 
1877 1947
 		// Load smileys - don't bother to run a query if we're not using the database's ones anyhow.
1878
-		if (empty($modSettings['smiley_enable']) && $user_info['smiley_set'] != 'none')
1879
-			$context['smileys']['postform'][] = array(
1948
+		if (empty($modSettings['smiley_enable']) && $user_info['smiley_set'] != 'none') {
1949
+					$context['smileys']['postform'][] = array(
1880 1950
 				'smileys' => array(
1881 1951
 					array(
1882 1952
 						'code' => ':)',
@@ -1962,7 +2032,7 @@  discard block
 block discarded – undo
1962 2032
 				),
1963 2033
 				'isLast' => true,
1964 2034
 			);
1965
-		elseif ($user_info['smiley_set'] != 'none')
2035
+		} elseif ($user_info['smiley_set'] != 'none')
1966 2036
 		{
1967 2037
 			if (($temp = cache_get_data('posting_smileys', 480)) == null)
1968 2038
 			{
@@ -1985,17 +2055,19 @@  discard block
 block discarded – undo
1985 2055
 
1986 2056
 				foreach ($context['smileys'] as $section => $smileyRows)
1987 2057
 				{
1988
-					foreach ($smileyRows as $rowIndex => $smileys)
1989
-						$context['smileys'][$section][$rowIndex]['smileys'][count($smileys['smileys']) - 1]['isLast'] = true;
2058
+					foreach ($smileyRows as $rowIndex => $smileys) {
2059
+											$context['smileys'][$section][$rowIndex]['smileys'][count($smileys['smileys']) - 1]['isLast'] = true;
2060
+					}
1990 2061
 
1991
-					if (!empty($smileyRows))
1992
-						$context['smileys'][$section][count($smileyRows) - 1]['isLast'] = true;
2062
+					if (!empty($smileyRows)) {
2063
+											$context['smileys'][$section][count($smileyRows) - 1]['isLast'] = true;
2064
+					}
1993 2065
 				}
1994 2066
 
1995 2067
 				cache_put_data('posting_smileys', $context['smileys'], 480);
2068
+			} else {
2069
+							$context['smileys'] = $temp;
1996 2070
 			}
1997
-			else
1998
-				$context['smileys'] = $temp;
1999 2071
 		}
2000 2072
 	}
2001 2073
 
@@ -2021,8 +2093,9 @@  discard block
 block discarded – undo
2021 2093
 		loadTemplate('GenericControls');
2022 2094
 
2023 2095
 		// Some javascript ma'am?
2024
-		if (!empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual'])))
2025
-			loadJavaScriptFile('captcha.js', array(), 'smf_captcha');
2096
+		if (!empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual']))) {
2097
+					loadJavaScriptFile('captcha.js', array(), 'smf_captcha');
2098
+		}
2026 2099
 
2027 2100
 		$context['use_graphic_library'] = in_array('gd', get_loaded_extensions());
2028 2101
 
@@ -2035,8 +2108,8 @@  discard block
 block discarded – undo
2035 2108
 	$isNew = !isset($context['controls']['verification'][$verificationOptions['id']]);
2036 2109
 
2037 2110
 	// Log this into our collection.
2038
-	if ($isNew)
2039
-		$context['controls']['verification'][$verificationOptions['id']] = array(
2111
+	if ($isNew) {
2112
+			$context['controls']['verification'][$verificationOptions['id']] = array(
2040 2113
 			'id' => $verificationOptions['id'],
2041 2114
 			'empty_field' => empty($verificationOptions['no_empty_field']),
2042 2115
 			'show_visual' => !empty($verificationOptions['override_visual']) || (!empty($modSettings['visual_verification_type']) && !isset($verificationOptions['override_visual'])),
@@ -2047,13 +2120,15 @@  discard block
 block discarded – undo
2047 2120
 			'questions' => array(),
2048 2121
 			'can_recaptcha' => !empty($modSettings['recaptcha_enabled']) && !empty($modSettings['recaptcha_site_key']) && !empty($modSettings['recaptcha_secret_key']),
2049 2122
 		);
2123
+	}
2050 2124
 	$thisVerification = &$context['controls']['verification'][$verificationOptions['id']];
2051 2125
 
2052 2126
 	// Is there actually going to be anything?
2053
-	if (empty($thisVerification['show_visual']) && empty($thisVerification['number_questions']) && empty($thisVerification['can_recaptcha']))
2054
-		return false;
2055
-	elseif (!$isNew && !$do_test)
2056
-		return true;
2127
+	if (empty($thisVerification['show_visual']) && empty($thisVerification['number_questions']) && empty($thisVerification['can_recaptcha'])) {
2128
+			return false;
2129
+	} elseif (!$isNew && !$do_test) {
2130
+			return true;
2131
+	}
2057 2132
 
2058 2133
 	// Sanitize reCAPTCHA fields?
2059 2134
 	if ($thisVerification['can_recaptcha'])
@@ -2066,11 +2141,12 @@  discard block
 block discarded – undo
2066 2141
 	}
2067 2142
 
2068 2143
 	// Add javascript for the object.
2069
-	if ($context['controls']['verification'][$verificationOptions['id']]['show_visual'])
2070
-		$context['insert_after_template'] .= '
2144
+	if ($context['controls']['verification'][$verificationOptions['id']]['show_visual']) {
2145
+			$context['insert_after_template'] .= '
2071 2146
 			<script>
2072 2147
 				var verification' . $verificationOptions['id'] . 'Handle = new smfCaptcha("' . $thisVerification['image_href'] . '", "' . $verificationOptions['id'] . '", ' . ($context['use_graphic_library'] ? 1 : 0) . ');
2073 2148
 			</script>';
2149
+	}
2074 2150
 
2075 2151
 	// If we want questions do we have a cache of all the IDs?
2076 2152
 	if (!empty($thisVerification['number_questions']) && empty($modSettings['question_id_cache']))
@@ -2093,8 +2169,9 @@  discard block
 block discarded – undo
2093 2169
 				unset ($row['id_question']);
2094 2170
 				// Make them all lowercase. We can't directly use $smcFunc['strtolower'] with array_walk, so do it manually, eh?
2095 2171
 				$row['answers'] = smf_json_decode($row['answers'], true);
2096
-				foreach ($row['answers'] as $k => $v)
2097
-					$row['answers'][$k] = $smcFunc['strtolower']($v);
2172
+				foreach ($row['answers'] as $k => $v) {
2173
+									$row['answers'][$k] = $smcFunc['strtolower']($v);
2174
+				}
2098 2175
 
2099 2176
 				$modSettings['question_id_cache']['questions'][$id_question] = $row;
2100 2177
 				$modSettings['question_id_cache']['langs'][$row['lngfile']][] = $id_question;
@@ -2105,35 +2182,42 @@  discard block
 block discarded – undo
2105 2182
 		}
2106 2183
 	}
2107 2184
 
2108
-	if (!isset($_SESSION[$verificationOptions['id'] . '_vv']))
2109
-		$_SESSION[$verificationOptions['id'] . '_vv'] = array();
2185
+	if (!isset($_SESSION[$verificationOptions['id'] . '_vv'])) {
2186
+			$_SESSION[$verificationOptions['id'] . '_vv'] = array();
2187
+	}
2110 2188
 
2111 2189
 	// Do we need to refresh the verification?
2112
-	if (!$do_test && (!empty($_SESSION[$verificationOptions['id'] . '_vv']['did_pass']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) || $_SESSION[$verificationOptions['id'] . '_vv']['count'] > 3) && empty($verificationOptions['dont_refresh']))
2113
-		$force_refresh = true;
2114
-	else
2115
-		$force_refresh = false;
2190
+	if (!$do_test && (!empty($_SESSION[$verificationOptions['id'] . '_vv']['did_pass']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) || $_SESSION[$verificationOptions['id'] . '_vv']['count'] > 3) && empty($verificationOptions['dont_refresh'])) {
2191
+			$force_refresh = true;
2192
+	} else {
2193
+			$force_refresh = false;
2194
+	}
2116 2195
 
2117 2196
 	// This can also force a fresh, although unlikely.
2118
-	if (($thisVerification['show_visual'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['code'])) || ($thisVerification['number_questions'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['q'])))
2119
-		$force_refresh = true;
2197
+	if (($thisVerification['show_visual'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['code'])) || ($thisVerification['number_questions'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['q']))) {
2198
+			$force_refresh = true;
2199
+	}
2120 2200
 
2121 2201
 	$verification_errors = array();
2122 2202
 	// Start with any testing.
2123 2203
 	if ($do_test)
2124 2204
 	{
2125 2205
 		// This cannot happen!
2126
-		if (!isset($_SESSION[$verificationOptions['id'] . '_vv']['count']))
2127
-			fatal_lang_error('no_access', false);
2206
+		if (!isset($_SESSION[$verificationOptions['id'] . '_vv']['count'])) {
2207
+					fatal_lang_error('no_access', false);
2208
+		}
2128 2209
 		// ... nor this!
2129
-		if ($thisVerification['number_questions'] && (!isset($_SESSION[$verificationOptions['id'] . '_vv']['q']) || !isset($_REQUEST[$verificationOptions['id'] . '_vv']['q'])))
2130
-			fatal_lang_error('no_access', false);
2210
+		if ($thisVerification['number_questions'] && (!isset($_SESSION[$verificationOptions['id'] . '_vv']['q']) || !isset($_REQUEST[$verificationOptions['id'] . '_vv']['q']))) {
2211
+					fatal_lang_error('no_access', false);
2212
+		}
2131 2213
 		// Hmm, it's requested but not actually declared. This shouldn't happen.
2132
-		if ($thisVerification['empty_field'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']))
2133
-			fatal_lang_error('no_access', false);
2214
+		if ($thisVerification['empty_field'] && empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field'])) {
2215
+					fatal_lang_error('no_access', false);
2216
+		}
2134 2217
 		// While we're here, did the user do something bad?
2135
-		if ($thisVerification['empty_field'] && !empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']) && !empty($_REQUEST[$_SESSION[$verificationOptions['id'] . '_vv']['empty_field']]))
2136
-			$verification_errors[] = 'wrong_verification_answer';
2218
+		if ($thisVerification['empty_field'] && !empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']) && !empty($_REQUEST[$_SESSION[$verificationOptions['id'] . '_vv']['empty_field']])) {
2219
+					$verification_errors[] = 'wrong_verification_answer';
2220
+		}
2137 2221
 
2138 2222
 		if ($thisVerification['can_recaptcha'])
2139 2223
 		{
@@ -2144,22 +2228,25 @@  discard block
 block discarded – undo
2144 2228
 			{
2145 2229
 				$resp = $reCaptcha->verify($_POST['g-recaptcha-response'], $user_info['ip']);
2146 2230
 
2147
-				if (!$resp->isSuccess())
2148
-					$verification_errors[] = 'wrong_verification_code';
2231
+				if (!$resp->isSuccess()) {
2232
+									$verification_errors[] = 'wrong_verification_code';
2233
+				}
2234
+			} else {
2235
+							$verification_errors[] = 'wrong_verification_code';
2149 2236
 			}
2150
-			else
2151
-				$verification_errors[] = 'wrong_verification_code';
2152 2237
 		}
2153
-		if ($thisVerification['show_visual'] && (empty($_REQUEST[$verificationOptions['id'] . '_vv']['code']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['code']) || strtoupper($_REQUEST[$verificationOptions['id'] . '_vv']['code']) !== $_SESSION[$verificationOptions['id'] . '_vv']['code']))
2154
-			$verification_errors[] = 'wrong_verification_code';
2238
+		if ($thisVerification['show_visual'] && (empty($_REQUEST[$verificationOptions['id'] . '_vv']['code']) || empty($_SESSION[$verificationOptions['id'] . '_vv']['code']) || strtoupper($_REQUEST[$verificationOptions['id'] . '_vv']['code']) !== $_SESSION[$verificationOptions['id'] . '_vv']['code'])) {
2239
+					$verification_errors[] = 'wrong_verification_code';
2240
+		}
2155 2241
 		if ($thisVerification['number_questions'])
2156 2242
 		{
2157 2243
 			$incorrectQuestions = array();
2158 2244
 			foreach ($_SESSION[$verificationOptions['id'] . '_vv']['q'] as $q)
2159 2245
 			{
2160 2246
 				// We don't have this question any more, thus no answers.
2161
-				if (!isset($modSettings['question_id_cache']['questions'][$q]))
2162
-					continue;
2247
+				if (!isset($modSettings['question_id_cache']['questions'][$q])) {
2248
+									continue;
2249
+				}
2163 2250
 				// This is quite complex. We have our question but it might have multiple answers.
2164 2251
 				// First, did they actually answer this question?
2165 2252
 				if (!isset($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q]) || trim($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q]) == '')
@@ -2171,24 +2258,28 @@  discard block
 block discarded – undo
2171 2258
 				else
2172 2259
 				{
2173 2260
 					$given_answer = trim($smcFunc['htmlspecialchars'](strtolower($_REQUEST[$verificationOptions['id'] . '_vv']['q'][$q])));
2174
-					if (!in_array($given_answer, $modSettings['question_id_cache']['questions'][$q]['answers']))
2175
-						$incorrectQuestions[] = $q;
2261
+					if (!in_array($given_answer, $modSettings['question_id_cache']['questions'][$q]['answers'])) {
2262
+											$incorrectQuestions[] = $q;
2263
+					}
2176 2264
 				}
2177 2265
 			}
2178 2266
 
2179
-			if (!empty($incorrectQuestions))
2180
-				$verification_errors[] = 'wrong_verification_answer';
2267
+			if (!empty($incorrectQuestions)) {
2268
+							$verification_errors[] = 'wrong_verification_answer';
2269
+			}
2181 2270
 		}
2182 2271
 	}
2183 2272
 
2184 2273
 	// Any errors means we refresh potentially.
2185 2274
 	if (!empty($verification_errors))
2186 2275
 	{
2187
-		if (empty($_SESSION[$verificationOptions['id'] . '_vv']['errors']))
2188
-			$_SESSION[$verificationOptions['id'] . '_vv']['errors'] = 0;
2276
+		if (empty($_SESSION[$verificationOptions['id'] . '_vv']['errors'])) {
2277
+					$_SESSION[$verificationOptions['id'] . '_vv']['errors'] = 0;
2278
+		}
2189 2279
 		// Too many errors?
2190
-		elseif ($_SESSION[$verificationOptions['id'] . '_vv']['errors'] > $thisVerification['max_errors'])
2191
-			$force_refresh = true;
2280
+		elseif ($_SESSION[$verificationOptions['id'] . '_vv']['errors'] > $thisVerification['max_errors']) {
2281
+					$force_refresh = true;
2282
+		}
2192 2283
 
2193 2284
 		// Keep a track of these.
2194 2285
 		$_SESSION[$verificationOptions['id'] . '_vv']['errors']++;
@@ -2221,8 +2312,9 @@  discard block
 block discarded – undo
2221 2312
 			// Are we overriding the range?
2222 2313
 			$character_range = !empty($verificationOptions['override_range']) ? $verificationOptions['override_range'] : $context['standard_captcha_range'];
2223 2314
 
2224
-			for ($i = 0; $i < 6; $i++)
2225
-				$_SESSION[$verificationOptions['id'] . '_vv']['code'] .= $character_range[array_rand($character_range)];
2315
+			for ($i = 0; $i < 6; $i++) {
2316
+							$_SESSION[$verificationOptions['id'] . '_vv']['code'] .= $character_range[array_rand($character_range)];
2317
+			}
2226 2318
 		}
2227 2319
 
2228 2320
 		// Getting some new questions?
@@ -2230,8 +2322,9 @@  discard block
 block discarded – undo
2230 2322
 		{
2231 2323
 			// Attempt to try the current page's language, followed by the user's preference, followed by the site default.
2232 2324
 			$possible_langs = array();
2233
-			if (isset($_SESSION['language']))
2234
-				$possible_langs[] = strtr($_SESSION['language'], array('-utf8' => ''));
2325
+			if (isset($_SESSION['language'])) {
2326
+							$possible_langs[] = strtr($_SESSION['language'], array('-utf8' => ''));
2327
+			}
2235 2328
 			if (!empty($user_info['language']));
2236 2329
 			$possible_langs[] = $user_info['language'];
2237 2330
 			$possible_langs[] = $language;
@@ -2250,8 +2343,7 @@  discard block
 block discarded – undo
2250 2343
 				}
2251 2344
 			}
2252 2345
 		}
2253
-	}
2254
-	else
2346
+	} else
2255 2347
 	{
2256 2348
 		// Same questions as before.
2257 2349
 		$questionIDs = !empty($_SESSION[$verificationOptions['id'] . '_vv']['q']) ? $_SESSION[$verificationOptions['id'] . '_vv']['q'] : array();
@@ -2261,8 +2353,9 @@  discard block
 block discarded – undo
2261 2353
 	// If we do have an empty field, it would be nice to hide it from legitimate users who shouldn't be populating it anyway.
2262 2354
 	if (!empty($_SESSION[$verificationOptions['id'] . '_vv']['empty_field']))
2263 2355
 	{
2264
-		if (!isset($context['html_headers']))
2265
-			$context['html_headers'] = '';
2356
+		if (!isset($context['html_headers'])) {
2357
+					$context['html_headers'] = '';
2358
+		}
2266 2359
 		$context['html_headers'] .= '<style>.vv_special { display:none; }</style>';
2267 2360
 	}
2268 2361
 
@@ -2288,11 +2381,13 @@  discard block
 block discarded – undo
2288 2381
 	$_SESSION[$verificationOptions['id'] . '_vv']['count'] = empty($_SESSION[$verificationOptions['id'] . '_vv']['count']) ? 1 : $_SESSION[$verificationOptions['id'] . '_vv']['count'] + 1;
2289 2382
 
2290 2383
 	// Return errors if we have them.
2291
-	if (!empty($verification_errors))
2292
-		return $verification_errors;
2384
+	if (!empty($verification_errors)) {
2385
+			return $verification_errors;
2386
+	}
2293 2387
 	// If we had a test that one, make a note.
2294
-	elseif ($do_test)
2295
-		$_SESSION[$verificationOptions['id'] . '_vv']['did_pass'] = true;
2388
+	elseif ($do_test) {
2389
+			$_SESSION[$verificationOptions['id'] . '_vv']['did_pass'] = true;
2390
+	}
2296 2391
 
2297 2392
 	// Say that everything went well chaps.
2298 2393
 	return true;
@@ -2317,8 +2412,9 @@  discard block
 block discarded – undo
2317 2412
 	call_integration_hook('integrate_autosuggest', array(&$searchTypes));
2318 2413
 
2319 2414
 	// If we're just checking the callback function is registered return true or false.
2320
-	if ($checkRegistered != null)
2321
-		return isset($searchTypes[$checkRegistered]) && function_exists('AutoSuggest_Search_' . $checkRegistered);
2415
+	if ($checkRegistered != null) {
2416
+			return isset($searchTypes[$checkRegistered]) && function_exists('AutoSuggest_Search_' . $checkRegistered);
2417
+	}
2322 2418
 
2323 2419
 	checkSession('get');
2324 2420
 	loadTemplate('Xml');
@@ -2469,24 +2565,27 @@  discard block
 block discarded – undo
2469 2565
 		foreach ($possible_versions as $ver)
2470 2566
 		{
2471 2567
 			$ver = trim($ver);
2472
-			if (strpos($ver, 'SMF') === 0)
2473
-				$versions[] = $ver;
2568
+			if (strpos($ver, 'SMF') === 0) {
2569
+							$versions[] = $ver;
2570
+			}
2474 2571
 		}
2475 2572
 	}
2476 2573
 	$smcFunc['db_free_result']($request);
2477 2574
 
2478 2575
 	// Just in case we don't have ANYthing.
2479
-	if (empty($versions))
2480
-		$versions = array('SMF 2.0');
2576
+	if (empty($versions)) {
2577
+			$versions = array('SMF 2.0');
2578
+	}
2481 2579
 
2482
-	foreach ($versions as $id => $version)
2483
-		if (strpos($version, strtoupper($_REQUEST['search'])) !== false)
2580
+	foreach ($versions as $id => $version) {
2581
+			if (strpos($version, strtoupper($_REQUEST['search'])) !== false)
2484 2582
 			$xml_data['items']['children'][] = array(
2485 2583
 				'attributes' => array(
2486 2584
 					'id' => $id,
2487 2585
 				),
2488 2586
 				'value' => $version,
2489 2587
 			);
2588
+	}
2490 2589
 
2491 2590
 	return $xml_data;
2492 2591
 }
Please login to merge, or discard this patch.
Sources/Subs.php 2 patches
Spacing   +117 added lines, -117 removed lines patch added patch discarded remove patch
@@ -1097,7 +1097,7 @@  discard block
 block discarded – undo
1097 1097
 					'height' => array('optional' => true, 'match' => '(\d+)'),
1098 1098
 				),
1099 1099
 				'content' => '$1',
1100
-				'validate' => function (&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1100
+				'validate' => function(&$tag, &$data, $disabled, $params) use ($modSettings, $context, $sourcedir, $txt)
1101 1101
 				{
1102 1102
 					$returnContext = '';
1103 1103
 
@@ -1132,7 +1132,7 @@  discard block
 block discarded – undo
1132 1132
 						}
1133 1133
 
1134 1134
 						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1135
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1135
+							$returnContext .= '<a href="' . $currentAttachment['href'] . ';image" id="link_' . $currentAttachment['id'] . '" onclick="' . $currentAttachment['thumbnail']['javascript'] . '"><img src="' . $currentAttachment['thumbnail']['href'] . '"' . $alt . $title . ' id="thumb_' . $currentAttachment['id'] . '" class="atc_img"></a>';
1136 1136
 						else
1137 1137
 							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1138 1138
 					}
@@ -1161,7 +1161,7 @@  discard block
 block discarded – undo
1161 1161
 				'type' => 'unparsed_content',
1162 1162
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1163 1163
 				// @todo Maybe this can be simplified?
1164
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1164
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1165 1165
 				{
1166 1166
 					if (!isset($disabled['code']))
1167 1167
 					{
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
 				'type' => 'unparsed_equals_content',
1199 1199
 				'content' => '<div class="codeheader"><span class="code floatleft">' . $txt['code'] . '</span> ($2) <a class="codeoperation smf_select_text">' . $txt['code_select'] . '</a></div><code class="bbc_code">$1</code>',
1200 1200
 				// @todo Maybe this can be simplified?
1201
-				'validate' => isset($disabled['code']) ? null : function (&$tag, &$data, $disabled) use ($context)
1201
+				'validate' => isset($disabled['code']) ? null : function(&$tag, &$data, $disabled) use ($context)
1202 1202
 				{
1203 1203
 					if (!isset($disabled['code']))
1204 1204
 					{
@@ -1242,7 +1242,7 @@  discard block
 block discarded – undo
1242 1242
 				'type' => 'unparsed_content',
1243 1243
 				'content' => '<a href="mailto:$1" class="bbc_email">$1</a>',
1244 1244
 				// @todo Should this respect guest_hideContacts?
1245
-				'validate' => function (&$tag, &$data, $disabled)
1245
+				'validate' => function(&$tag, &$data, $disabled)
1246 1246
 				{
1247 1247
 					$data = strtr($data, array('<br>' => ''));
1248 1248
 				},
@@ -1261,7 +1261,7 @@  discard block
 block discarded – undo
1261 1261
 				'type' => 'unparsed_commas_content',
1262 1262
 				'test' => '\d+,\d+\]',
1263 1263
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1264
-				'validate' => function (&$tag, &$data, $disabled)
1264
+				'validate' => function(&$tag, &$data, $disabled)
1265 1265
 				{
1266 1266
 					if (isset($disabled['url']))
1267 1267
 						$tag['content'] = '$1';
@@ -1277,7 +1277,7 @@  discard block
 block discarded – undo
1277 1277
 				'test' => '(left|right)(\s+max=\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)?\]',
1278 1278
 				'before' => '<div $1>',
1279 1279
 				'after' => '</div>',
1280
-				'validate' => function (&$tag, &$data, $disabled)
1280
+				'validate' => function(&$tag, &$data, $disabled)
1281 1281
 				{
1282 1282
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1283 1283
 
@@ -1326,7 +1326,7 @@  discard block
 block discarded – undo
1326 1326
 					'height' => array('optional' => true, 'value' => ' height="$1"', 'match' => '(\d+)'),
1327 1327
 				),
1328 1328
 				'content' => '<img src="$1" alt="{alt}" title="{title}"{width}{height} class="bbc_img resized">',
1329
-				'validate' => function (&$tag, &$data, $disabled)
1329
+				'validate' => function(&$tag, &$data, $disabled)
1330 1330
 				{
1331 1331
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1332 1332
 
@@ -1349,7 +1349,7 @@  discard block
 block discarded – undo
1349 1349
 				'tag' => 'img',
1350 1350
 				'type' => 'unparsed_content',
1351 1351
 				'content' => '<img src="$1" alt="" class="bbc_img">',
1352
-				'validate' => function (&$tag, &$data, $disabled)
1352
+				'validate' => function(&$tag, &$data, $disabled)
1353 1353
 				{
1354 1354
 					global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1355 1355
 
@@ -1372,7 +1372,7 @@  discard block
 block discarded – undo
1372 1372
 				'tag' => 'iurl',
1373 1373
 				'type' => 'unparsed_content',
1374 1374
 				'content' => '<a href="$1" class="bbc_link">$1</a>',
1375
-				'validate' => function (&$tag, &$data, $disabled)
1375
+				'validate' => function(&$tag, &$data, $disabled)
1376 1376
 				{
1377 1377
 					$data = strtr($data, array('<br>' => ''));
1378 1378
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1386,7 +1386,7 @@  discard block
 block discarded – undo
1386 1386
 				'quoted' => 'optional',
1387 1387
 				'before' => '<a href="$1" class="bbc_link">',
1388 1388
 				'after' => '</a>',
1389
-				'validate' => function (&$tag, &$data, $disabled)
1389
+				'validate' => function(&$tag, &$data, $disabled)
1390 1390
 				{
1391 1391
 					if (substr($data, 0, 1) == '#')
1392 1392
 						$data = '#post_' . substr($data, 1);
@@ -1466,7 +1466,7 @@  discard block
 block discarded – undo
1466 1466
 				'tag' => 'php',
1467 1467
 				'type' => 'unparsed_content',
1468 1468
 				'content' => '<span class="phpcode">$1</span>',
1469
-				'validate' => isset($disabled['php']) ? null : function (&$tag, &$data, $disabled)
1469
+				'validate' => isset($disabled['php']) ? null : function(&$tag, &$data, $disabled)
1470 1470
 				{
1471 1471
 					if (!isset($disabled['php']))
1472 1472
 					{
@@ -1564,7 +1564,7 @@  discard block
 block discarded – undo
1564 1564
 				'test' => '[1-7]\]',
1565 1565
 				'before' => '<span style="font-size: $1;" class="bbc_size">',
1566 1566
 				'after' => '</span>',
1567
-				'validate' => function (&$tag, &$data, $disabled)
1567
+				'validate' => function(&$tag, &$data, $disabled)
1568 1568
 				{
1569 1569
 					$sizes = array(1 => 0.7, 2 => 1.0, 3 => 1.35, 4 => 1.45, 5 => 2.0, 6 => 2.65, 7 => 3.95);
1570 1570
 					$data = $sizes[$data] . 'em';
@@ -1602,7 +1602,7 @@  discard block
 block discarded – undo
1602 1602
 				'tag' => 'time',
1603 1603
 				'type' => 'unparsed_content',
1604 1604
 				'content' => '$1',
1605
-				'validate' => function (&$tag, &$data, $disabled)
1605
+				'validate' => function(&$tag, &$data, $disabled)
1606 1606
 				{
1607 1607
 					if (is_numeric($data))
1608 1608
 						$data = timeformat($data);
@@ -1630,7 +1630,7 @@  discard block
 block discarded – undo
1630 1630
 				'tag' => 'url',
1631 1631
 				'type' => 'unparsed_content',
1632 1632
 				'content' => '<a href="$1" class="bbc_link" target="_blank">$1</a>',
1633
-				'validate' => function (&$tag, &$data, $disabled)
1633
+				'validate' => function(&$tag, &$data, $disabled)
1634 1634
 				{
1635 1635
 					$data = strtr($data, array('<br>' => ''));
1636 1636
 					$scheme = parse_url($data, PHP_URL_SCHEME);
@@ -1644,7 +1644,7 @@  discard block
 block discarded – undo
1644 1644
 				'quoted' => 'optional',
1645 1645
 				'before' => '<a href="$1" class="bbc_link" target="_blank">',
1646 1646
 				'after' => '</a>',
1647
-				'validate' => function (&$tag, &$data, $disabled)
1647
+				'validate' => function(&$tag, &$data, $disabled)
1648 1648
 				{
1649 1649
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1650 1650
 					if (empty($scheme))
@@ -1670,7 +1670,7 @@  discard block
 block discarded – undo
1670 1670
 		{
1671 1671
 			if (isset($temp_bbc))
1672 1672
 				$bbc_codes = $temp_bbc;
1673
-			usort($codes, function ($a, $b) {
1673
+			usort($codes, function($a, $b) {
1674 1674
 				return strcmp($a['tag'], $b['tag']);
1675 1675
 			});
1676 1676
 			return $codes;
@@ -1908,7 +1908,7 @@  discard block
 block discarded – undo
1908 1908
 										# a run of Unicode domain name characters and a dot
1909 1909
 										[\p{L}\p{M}\p{N}\-.:@]+\.
1910 1910
 										# and then a TLD valid in the DNS or the reserved "local" TLD
1911
-										(?:'. $modSettings['tld_regex'] .'|local)
1911
+										(?:'. $modSettings['tld_regex'] . '|local)
1912 1912
 									)
1913 1913
 									# followed by a non-domain character or end of line
1914 1914
 									(?=[^\p{L}\p{N}\-.]|$)
@@ -1976,7 +1976,7 @@  discard block
 block discarded – undo
1976 1976
 						)?
1977 1977
 						';
1978 1978
 
1979
-						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function ($matches) {
1979
+						$data = preg_replace_callback('~' . $url_regex . '~xi' . ($context['utf8'] ? 'u' : ''), function($matches) {
1980 1980
 							$url = array_shift($matches);
1981 1981
 
1982 1982
 							$scheme = parse_url($url, PHP_URL_SCHEME);
@@ -2713,7 +2713,7 @@  discard block
 block discarded – undo
2713 2713
 		for ($i = 0, $n = count($smileysfrom); $i < $n; $i++)
2714 2714
 		{
2715 2715
 			$specialChars = $smcFunc['htmlspecialchars']($smileysfrom[$i], ENT_QUOTES);
2716
-			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')). '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2716
+			$smileyCode = '<img src="' . $smileys_path . $smileysto[$i] . '" alt="' . strtr($specialChars, array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" title="' . strtr($smcFunc['htmlspecialchars']($smileysdescs[$i]), array(':' => '&#58;', '(' => '&#40;', ')' => '&#41;', '$' => '&#36;', '[' => '&#091;')) . '" class="smiley">';
2717 2717
 
2718 2718
 			$smileyPregReplacements[$smileysfrom[$i]] = $smileyCode;
2719 2719
 
@@ -2730,7 +2730,7 @@  discard block
 block discarded – undo
2730 2730
 
2731 2731
 	// Replace away!
2732 2732
 	$message = preg_replace_callback($smileyPregSearch,
2733
-		function ($matches) use ($smileyPregReplacements)
2733
+		function($matches) use ($smileyPregReplacements)
2734 2734
 		{
2735 2735
 			return $smileyPregReplacements[$matches[1]];
2736 2736
 		}, $message);
@@ -2796,13 +2796,13 @@  discard block
 block discarded – undo
2796 2796
 	{
2797 2797
 		if (defined('SID') && SID != '')
2798 2798
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2799
-				function ($m) use ($scripturl)
2799
+				function($m) use ($scripturl)
2800 2800
 				{
2801
-					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
2801
+					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID . (isset($m[2]) ? "$m[2]" : "");
2802 2802
 				}, $setLocation);
2803 2803
 		else
2804 2804
 			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2805
-				function ($m) use ($scripturl)
2805
+				function($m) use ($scripturl)
2806 2806
 				{
2807 2807
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
2808 2808
 				}, $setLocation);
@@ -3125,7 +3125,7 @@  discard block
 block discarded – undo
3125 3125
 
3126 3126
 	// Add a generic "Are you sure?" confirmation message.
3127 3127
 	addInlineJavaScript('
3128
-	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3128
+	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) . ';');
3129 3129
 
3130 3130
 	// Now add the capping code for avatars.
3131 3131
 	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
@@ -3486,7 +3486,7 @@  discard block
 block discarded – undo
3486 3486
 
3487 3487
 		else
3488 3488
 			echo '
3489
-	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3489
+	<script src="', $settings['theme_url'], '/scripts/minified', ($do_deferred ? '_deferred' : ''), '.js', $minSeed, '"></script>';
3490 3490
 	}
3491 3491
 
3492 3492
 	// Inline JavaScript - Actually useful some times!
@@ -3564,14 +3564,14 @@  discard block
 block discarded – undo
3564 3564
 
3565 3565
 		else
3566 3566
 			echo '
3567
-	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3567
+	<link rel="stylesheet" href="', $settings['theme_url'], '/css/minified.css', $minSeed, '">';
3568 3568
 	}
3569 3569
 
3570 3570
 	// Print the rest after the minified files.
3571 3571
 	if (!empty($normal))
3572 3572
 		foreach ($normal as $nf)
3573 3573
 			echo '
3574
-	<link rel="stylesheet" href="', $nf ,'">';
3574
+	<link rel="stylesheet" href="', $nf, '">';
3575 3575
 
3576 3576
 	if ($db_show_debug === true)
3577 3577
 	{
@@ -3587,7 +3587,7 @@  discard block
 block discarded – undo
3587 3587
 	<style>';
3588 3588
 
3589 3589
 		foreach ($context['css_header'] as $css)
3590
-			echo $css .'
3590
+			echo $css . '
3591 3591
 	';
3592 3592
 
3593 3593
 		echo'
@@ -3616,27 +3616,27 @@  discard block
 block discarded – undo
3616 3616
 		return false;
3617 3617
 
3618 3618
 	// Did we already did this?
3619
-	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3619
+	$toCache = cache_get_data('minimized_' . $settings['theme_id'] . '_' . $type, 86400);
3620 3620
 
3621 3621
 	// Already done?
3622 3622
 	if (!empty($toCache))
3623 3623
 		return true;
3624 3624
 
3625 3625
 	// No namespaces, sorry!
3626
-	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
3626
+	$classType = 'MatthiasMullie\\Minify\\' . strtoupper($type);
3627 3627
 
3628 3628
 	// Temp path.
3629
-	$cTempPath = $settings['theme_dir'] .'/'. ($type == 'css' ? 'css' : 'scripts') .'/';
3629
+	$cTempPath = $settings['theme_dir'] . '/' . ($type == 'css' ? 'css' : 'scripts') . '/';
3630 3630
 
3631 3631
 	// What kind of file are we going to create?
3632
-	$toCreate = $cTempPath .'minified'. ($do_deferred ? '_deferred' : '') .'.'. $type;
3632
+	$toCreate = $cTempPath . 'minified' . ($do_deferred ? '_deferred' : '') . '.' . $type;
3633 3633
 
3634 3634
 	// File has to exists, if it isn't try to create it.
3635 3635
 	if ((!file_exists($toCreate) && @fopen($toCreate, 'w') === false) || !smf_chmod($toCreate))
3636 3636
 	{
3637 3637
 		loadLanguage('Errors');
3638 3638
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3639
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3639
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3640 3640
 
3641 3641
 		// The process failed so roll back to print each individual file.
3642 3642
 		return $data;
@@ -3671,14 +3671,14 @@  discard block
 block discarded – undo
3671 3671
 	{
3672 3672
 		loadLanguage('Errors');
3673 3673
 		log_error(sprintf($txt['file_not_created'], $toCreate), 'general');
3674
-		cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, null);
3674
+		cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, null);
3675 3675
 
3676 3676
 		// The process failed so roll back to print each individual file.
3677 3677
 		return $data;
3678 3678
 	}
3679 3679
 
3680 3680
 	// And create a long lived cache entry.
3681
-	cache_put_data('minimized_'. $settings['theme_id'] .'_'. $type, $toCreate, 86400);
3681
+	cache_put_data('minimized_' . $settings['theme_id'] . '_' . $type, $toCreate, 86400);
3682 3682
 
3683 3683
 	return true;
3684 3684
 }
@@ -3738,7 +3738,7 @@  discard block
 block discarded – undo
3738 3738
 	else
3739 3739
 		$path = $modSettings['attachmentUploadDir'];
3740 3740
 
3741
-	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3741
+	return $path . '/' . $attachment_id . '_' . $file_hash . '.dat';
3742 3742
 }
3743 3743
 
3744 3744
 /**
@@ -3782,10 +3782,10 @@  discard block
 block discarded – undo
3782 3782
 		$valid_low = isValidIP($ip_parts[0]);
3783 3783
 		$valid_high = isValidIP($ip_parts[1]);
3784 3784
 		$count = 0;
3785
-		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
3785
+		$mode = (preg_match('/:/', $ip_parts[0]) > 0 ? ':' : '.');
3786 3786
 		$max = ($mode == ':' ? 'ffff' : '255');
3787 3787
 		$min = 0;
3788
-		if(!$valid_low)
3788
+		if (!$valid_low)
3789 3789
 		{
3790 3790
 			$ip_parts[0] = preg_replace('/\*/', '0', $ip_parts[0]);
3791 3791
 			$valid_low = isValidIP($ip_parts[0]);
@@ -3799,7 +3799,7 @@  discard block
 block discarded – undo
3799 3799
 		}
3800 3800
 
3801 3801
 		$count = 0;
3802
-		if(!$valid_high)
3802
+		if (!$valid_high)
3803 3803
 		{
3804 3804
 			$ip_parts[1] = preg_replace('/\*/', $max, $ip_parts[1]);
3805 3805
 			$valid_high = isValidIP($ip_parts[1]);
@@ -3812,7 +3812,7 @@  discard block
 block discarded – undo
3812 3812
 			}
3813 3813
 		}
3814 3814
 
3815
-		if($valid_high && $valid_low)
3815
+		if ($valid_high && $valid_low)
3816 3816
 		{
3817 3817
 			$ip_array['low'] = $ip_parts[0];
3818 3818
 			$ip_array['high'] = $ip_parts[1];
@@ -3994,7 +3994,7 @@  discard block
 block discarded – undo
3994 3994
 		addInlineJavaScript('
3995 3995
 	var user_menus = new smc_PopupMenu();
3996 3996
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
3997
-	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
3997
+	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u=' . $context['user']['id'] . '");', true);
3998 3998
 		if ($context['allow_pm'])
3999 3999
 			addInlineJavaScript('
4000 4000
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
@@ -4619,7 +4619,7 @@  discard block
 block discarded – undo
4619 4619
 		// No? try a fallback to $sourcedir
4620 4620
 		else
4621 4621
 		{
4622
-			$absPath = $sourcedir .'/'. $file;
4622
+			$absPath = $sourcedir . '/' . $file;
4623 4623
 
4624 4624
 			if (file_exists($absPath))
4625 4625
 				require_once($absPath);
@@ -4700,15 +4700,15 @@  discard block
 block discarded – undo
4700 4700
 
4701 4701
 	// UTF-8 occurences of MS special characters
4702 4702
 	$findchars_utf8 = array(
4703
-		"\xe2\x80\x9a",	// single low-9 quotation mark
4704
-		"\xe2\x80\x9e",	// double low-9 quotation mark
4705
-		"\xe2\x80\xa6",	// horizontal ellipsis
4706
-		"\xe2\x80\x98",	// left single curly quote
4707
-		"\xe2\x80\x99",	// right single curly quote
4708
-		"\xe2\x80\x9c",	// left double curly quote
4709
-		"\xe2\x80\x9d",	// right double curly quote
4710
-		"\xe2\x80\x93",	// en dash
4711
-		"\xe2\x80\x94",	// em dash
4703
+		"\xe2\x80\x9a", // single low-9 quotation mark
4704
+		"\xe2\x80\x9e", // double low-9 quotation mark
4705
+		"\xe2\x80\xa6", // horizontal ellipsis
4706
+		"\xe2\x80\x98", // left single curly quote
4707
+		"\xe2\x80\x99", // right single curly quote
4708
+		"\xe2\x80\x9c", // left double curly quote
4709
+		"\xe2\x80\x9d", // right double curly quote
4710
+		"\xe2\x80\x93", // en dash
4711
+		"\xe2\x80\x94", // em dash
4712 4712
 	);
4713 4713
 
4714 4714
 	// windows 1252 / iso equivalents
@@ -4726,15 +4726,15 @@  discard block
 block discarded – undo
4726 4726
 
4727 4727
 	// safe replacements
4728 4728
 	$replacechars = array(
4729
-		',',	// &sbquo;
4730
-		',,',	// &bdquo;
4731
-		'...',	// &hellip;
4732
-		"'",	// &lsquo;
4733
-		"'",	// &rsquo;
4734
-		'"',	// &ldquo;
4735
-		'"',	// &rdquo;
4736
-		'-',	// &ndash;
4737
-		'--',	// &mdash;
4729
+		',', // &sbquo;
4730
+		',,', // &bdquo;
4731
+		'...', // &hellip;
4732
+		"'", // &lsquo;
4733
+		"'", // &rsquo;
4734
+		'"', // &ldquo;
4735
+		'"', // &rdquo;
4736
+		'-', // &ndash;
4737
+		'--', // &mdash;
4738 4738
 	);
4739 4739
 
4740 4740
 	if ($context['utf8'])
@@ -5152,7 +5152,7 @@  discard block
 block discarded – undo
5152 5152
  */
5153 5153
 function inet_dtop($bin)
5154 5154
 {
5155
-	if(empty($bin))
5155
+	if (empty($bin))
5156 5156
 		return '';
5157 5157
 
5158 5158
 	global $db_type;
@@ -5183,28 +5183,28 @@  discard block
 block discarded – undo
5183 5183
  */
5184 5184
 function _safe_serialize($value)
5185 5185
 {
5186
-	if(is_null($value))
5186
+	if (is_null($value))
5187 5187
 		return 'N;';
5188 5188
 
5189
-	if(is_bool($value))
5190
-		return 'b:'. (int) $value .';';
5189
+	if (is_bool($value))
5190
+		return 'b:' . (int) $value . ';';
5191 5191
 
5192
-	if(is_int($value))
5193
-		return 'i:'. $value .';';
5192
+	if (is_int($value))
5193
+		return 'i:' . $value . ';';
5194 5194
 
5195
-	if(is_float($value))
5196
-		return 'd:'. str_replace(',', '.', $value) .';';
5195
+	if (is_float($value))
5196
+		return 'd:' . str_replace(',', '.', $value) . ';';
5197 5197
 
5198
-	if(is_string($value))
5199
-		return 's:'. strlen($value) .':"'. $value .'";';
5198
+	if (is_string($value))
5199
+		return 's:' . strlen($value) . ':"' . $value . '";';
5200 5200
 
5201
-	if(is_array($value))
5201
+	if (is_array($value))
5202 5202
 	{
5203 5203
 		$out = '';
5204
-		foreach($value as $k => $v)
5204
+		foreach ($value as $k => $v)
5205 5205
 			$out .= _safe_serialize($k) . _safe_serialize($v);
5206 5206
 
5207
-		return 'a:'. count($value) .':{'. $out .'}';
5207
+		return 'a:' . count($value) . ':{' . $out . '}';
5208 5208
 	}
5209 5209
 
5210 5210
 	// safe_serialize cannot serialize resources or objects.
@@ -5246,7 +5246,7 @@  discard block
 block discarded – undo
5246 5246
 function _safe_unserialize($str)
5247 5247
 {
5248 5248
 	// Input  is not a string.
5249
-	if(empty($str) || !is_string($str))
5249
+	if (empty($str) || !is_string($str))
5250 5250
 		return false;
5251 5251
 
5252 5252
 	$stack = array();
@@ -5260,40 +5260,40 @@  discard block
 block discarded – undo
5260 5260
 	 *   3 - in array, expecting value or another array
5261 5261
 	 */
5262 5262
 	$state = 0;
5263
-	while($state != 1)
5263
+	while ($state != 1)
5264 5264
 	{
5265 5265
 		$type = isset($str[0]) ? $str[0] : '';
5266
-		if($type == '}')
5266
+		if ($type == '}')
5267 5267
 			$str = substr($str, 1);
5268 5268
 
5269
-		else if($type == 'N' && $str[1] == ';')
5269
+		else if ($type == 'N' && $str[1] == ';')
5270 5270
 		{
5271 5271
 			$value = null;
5272 5272
 			$str = substr($str, 2);
5273 5273
 		}
5274
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5274
+		else if ($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5275 5275
 		{
5276 5276
 			$value = $matches[1] == '1' ? true : false;
5277 5277
 			$str = substr($str, 4);
5278 5278
 		}
5279
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5279
+		else if ($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5280 5280
 		{
5281
-			$value = (int)$matches[1];
5281
+			$value = (int) $matches[1];
5282 5282
 			$str = $matches[2];
5283 5283
 		}
5284
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5284
+		else if ($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5285 5285
 		{
5286
-			$value = (float)$matches[1];
5286
+			$value = (float) $matches[1];
5287 5287
 			$str = $matches[3];
5288 5288
 		}
5289
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5289
+		else if ($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int) $matches[1], 2) == '";')
5290 5290
 		{
5291
-			$value = substr($matches[2], 0, (int)$matches[1]);
5292
-			$str = substr($matches[2], (int)$matches[1] + 2);
5291
+			$value = substr($matches[2], 0, (int) $matches[1]);
5292
+			$str = substr($matches[2], (int) $matches[1] + 2);
5293 5293
 		}
5294
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5294
+		else if ($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5295 5295
 		{
5296
-			$expectedLength = (int)$matches[1];
5296
+			$expectedLength = (int) $matches[1];
5297 5297
 			$str = $matches[2];
5298 5298
 		}
5299 5299
 
@@ -5301,10 +5301,10 @@  discard block
 block discarded – undo
5301 5301
 		else
5302 5302
 			return false;
5303 5303
 
5304
-		switch($state)
5304
+		switch ($state)
5305 5305
 		{
5306 5306
 			case 3: // In array, expecting value or another array.
5307
-				if($type == 'a')
5307
+				if ($type == 'a')
5308 5308
 				{
5309 5309
 					$stack[] = &$list;
5310 5310
 					$list[$key] = array();
@@ -5313,7 +5313,7 @@  discard block
 block discarded – undo
5313 5313
 					$state = 2;
5314 5314
 					break;
5315 5315
 				}
5316
-				if($type != '}')
5316
+				if ($type != '}')
5317 5317
 				{
5318 5318
 					$list[$key] = $value;
5319 5319
 					$state = 2;
@@ -5324,29 +5324,29 @@  discard block
 block discarded – undo
5324 5324
 				return false;
5325 5325
 
5326 5326
 			case 2: // in array, expecting end of array or a key
5327
-				if($type == '}')
5327
+				if ($type == '}')
5328 5328
 				{
5329 5329
 					// Array size is less than expected.
5330
-					if(count($list) < end($expected))
5330
+					if (count($list) < end($expected))
5331 5331
 						return false;
5332 5332
 
5333 5333
 					unset($list);
5334
-					$list = &$stack[count($stack)-1];
5334
+					$list = &$stack[count($stack) - 1];
5335 5335
 					array_pop($stack);
5336 5336
 
5337 5337
 					// Go to terminal state if we're at the end of the root array.
5338 5338
 					array_pop($expected);
5339 5339
 
5340
-					if(count($expected) == 0)
5340
+					if (count($expected) == 0)
5341 5341
 						$state = 1;
5342 5342
 
5343 5343
 					break;
5344 5344
 				}
5345 5345
 
5346
-				if($type == 'i' || $type == 's')
5346
+				if ($type == 'i' || $type == 's')
5347 5347
 				{
5348 5348
 					// Array size exceeds expected length.
5349
-					if(count($list) >= end($expected))
5349
+					if (count($list) >= end($expected))
5350 5350
 						return false;
5351 5351
 
5352 5352
 					$key = $value;
@@ -5359,7 +5359,7 @@  discard block
 block discarded – undo
5359 5359
 
5360 5360
 			// Expecting array or value.
5361 5361
 			case 0:
5362
-				if($type == 'a')
5362
+				if ($type == 'a')
5363 5363
 				{
5364 5364
 					$data = array();
5365 5365
 					$list = &$data;
@@ -5368,7 +5368,7 @@  discard block
 block discarded – undo
5368 5368
 					break;
5369 5369
 				}
5370 5370
 
5371
-				if($type != '}')
5371
+				if ($type != '}')
5372 5372
 				{
5373 5373
 					$data = $value;
5374 5374
 					$state = 1;
@@ -5381,7 +5381,7 @@  discard block
 block discarded – undo
5381 5381
 	}
5382 5382
 
5383 5383
 	// Trailing data in input.
5384
-	if(!empty($str))
5384
+	if (!empty($str))
5385 5385
 		return false;
5386 5386
 
5387 5387
 	return $data;
@@ -5435,7 +5435,7 @@  discard block
 block discarded – undo
5435 5435
 	// Set different modes.
5436 5436
 	$chmodValues = $isDir ? array(0750, 0755, 0775, 0777) : array(0644, 0664, 0666);
5437 5437
 
5438
-	foreach($chmodValues as $val)
5438
+	foreach ($chmodValues as $val)
5439 5439
 	{
5440 5440
 		// If it's writable, break out of the loop.
5441 5441
 		if (is_writable($file))
@@ -5470,13 +5470,13 @@  discard block
 block discarded – undo
5470 5470
 	$returnArray = @json_decode($json, $returnAsArray);
5471 5471
 
5472 5472
 	// PHP 5.3 so no json_last_error_msg()
5473
-	switch(json_last_error())
5473
+	switch (json_last_error())
5474 5474
 	{
5475 5475
 		case JSON_ERROR_NONE:
5476 5476
 			$jsonError = false;
5477 5477
 			break;
5478 5478
 		case JSON_ERROR_DEPTH:
5479
-			$jsonError =  'JSON_ERROR_DEPTH';
5479
+			$jsonError = 'JSON_ERROR_DEPTH';
5480 5480
 			break;
5481 5481
 		case JSON_ERROR_STATE_MISMATCH:
5482 5482
 			$jsonError = 'JSON_ERROR_STATE_MISMATCH';
@@ -5504,10 +5504,10 @@  discard block
 block discarded – undo
5504 5504
 		loadLanguage('Errors');
5505 5505
 
5506 5506
 		if (!empty($jsonDebug))
5507
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5507
+			log_error($txt['json_' . $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5508 5508
 
5509 5509
 		else
5510
-			log_error($txt['json_'. $jsonError], 'critical');
5510
+			log_error($txt['json_' . $jsonError], 'critical');
5511 5511
 
5512 5512
 		// Everyone expects an array.
5513 5513
 		return array();
@@ -5611,7 +5611,7 @@  discard block
 block discarded – undo
5611 5611
 		});
5612 5612
 
5613 5613
 		// Convert Punycode to Unicode
5614
-		$tlds = array_map(function ($input) {
5614
+		$tlds = array_map(function($input) {
5615 5615
 			$prefix = 'xn--';
5616 5616
 			$safe_char = 0xFFFC;
5617 5617
 			$base = 36;
@@ -5627,7 +5627,7 @@  discard block
 block discarded – undo
5627 5627
 
5628 5628
 			foreach ($enco_parts as $encoded)
5629 5629
 			{
5630
-				if (strpos($encoded,$prefix) !== 0 || strlen(trim(str_replace($prefix,'',$encoded))) == 0)
5630
+				if (strpos($encoded, $prefix) !== 0 || strlen(trim(str_replace($prefix, '', $encoded))) == 0)
5631 5631
 				{
5632 5632
 					$output_parts[] = $encoded;
5633 5633
 					continue;
@@ -5638,7 +5638,7 @@  discard block
 block discarded – undo
5638 5638
 				$idx = 0;
5639 5639
 				$char = 0x80;
5640 5640
 				$decoded = array();
5641
-				$output='';
5641
+				$output = '';
5642 5642
 				$delim_pos = strrpos($encoded, '-');
5643 5643
 
5644 5644
 				if ($delim_pos > strlen($prefix))
@@ -5654,7 +5654,7 @@  discard block
 block discarded – undo
5654 5654
 
5655 5655
 				for ($enco_idx = $delim_pos ? ($delim_pos + 1) : 0; $enco_idx < $enco_len; ++$deco_len)
5656 5656
 				{
5657
-					for ($old_idx = $idx, $w = 1, $k = $base; 1 ; $k += $base)
5657
+					for ($old_idx = $idx, $w = 1, $k = $base; 1; $k += $base)
5658 5658
 					{
5659 5659
 						$cp = ord($encoded{$enco_idx++});
5660 5660
 						$digit = ($cp - 48 < 10) ? $cp - 22 : (($cp - 65 < 26) ? $cp - 65 : (($cp - 97 < 26) ? $cp - 97 : $base));
@@ -5695,15 +5695,15 @@  discard block
 block discarded – undo
5695 5695
 
5696 5696
 					// 2 bytes
5697 5697
 					elseif ($v < (1 << 11))
5698
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
5698
+						$output .= chr(192 + ($v >> 6)) . chr(128 + ($v & 63));
5699 5699
 
5700 5700
 					// 3 bytes
5701 5701
 					elseif ($v < (1 << 16))
5702
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5702
+						$output .= chr(224 + ($v >> 12)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5703 5703
 
5704 5704
 					// 4 bytes
5705 5705
 					elseif ($v < (1 << 21))
5706
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
5706
+						$output .= chr(240 + ($v >> 18)) . chr(128 + (($v >> 12) & 63)) . chr(128 + (($v >> 6) & 63)) . chr(128 + ($v & 63));
5707 5707
 
5708 5708
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5709 5709
 					else
@@ -5810,7 +5810,7 @@  discard block
 block discarded – undo
5810 5810
 	}
5811 5811
 
5812 5812
 	// This recursive function creates the index array from the strings
5813
-	$add_string_to_index = function ($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5813
+	$add_string_to_index = function($string, $index) use (&$strlen, &$substr, &$add_string_to_index)
5814 5814
 	{
5815 5815
 		static $depth = 0;
5816 5816
 		$depth++;
@@ -5837,7 +5837,7 @@  discard block
 block discarded – undo
5837 5837
 	};
5838 5838
 
5839 5839
 	// This recursive function turns the index array into a regular expression
5840
-	$index_to_regex = function (&$index, $delim) use (&$strlen, &$index_to_regex)
5840
+	$index_to_regex = function(&$index, $delim) use (&$strlen, &$index_to_regex)
5841 5841
 	{
5842 5842
 		static $depth = 0;
5843 5843
 		$depth++;
@@ -5861,11 +5861,11 @@  discard block
 block discarded – undo
5861 5861
 
5862 5862
 				if (count(array_keys($value)) == 1)
5863 5863
 				{
5864
-					$new_key_array = explode('(?'.'>', $sub_regex);
5864
+					$new_key_array = explode('(?' . '>', $sub_regex);
5865 5865
 					$new_key .= $new_key_array[0];
5866 5866
 				}
5867 5867
 				else
5868
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5868
+					$sub_regex = '(?' . '>' . $sub_regex . ')';
5869 5869
 			}
5870 5870
 
5871 5871
 			if ($depth > 1)
@@ -5905,7 +5905,7 @@  discard block
 block discarded – undo
5905 5905
 		$index = $add_string_to_index($string, $index);
5906 5906
 
5907 5907
 	while (!empty($index))
5908
-		$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
5908
+		$regexes[] = '(?' . '>' . $index_to_regex($index, $delim) . ')';
5909 5909
 
5910 5910
 	// Restore PHP's internal character encoding to whatever it was originally
5911 5911
 	if (!empty($current_encoding))
Please login to merge, or discard this patch.
Braces   +1287 added lines, -957 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 3
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Update some basic statistics.
@@ -122,10 +123,11 @@  discard block
 block discarded – undo
122 123
 						$smcFunc['db_free_result']($result);
123 124
 
124 125
 						// Add this to the number of unapproved members
125
-						if (!empty($changes['unapprovedMembers']))
126
-							$changes['unapprovedMembers'] += $coppa_approvals;
127
-						else
128
-							$changes['unapprovedMembers'] = $coppa_approvals;
126
+						if (!empty($changes['unapprovedMembers'])) {
127
+													$changes['unapprovedMembers'] += $coppa_approvals;
128
+						} else {
129
+													$changes['unapprovedMembers'] = $coppa_approvals;
130
+						}
129 131
 					}
130 132
 				}
131 133
 			}
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 			break;
134 136
 
135 137
 		case 'message':
136
-			if ($parameter1 === true && $parameter2 !== null)
137
-				updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
138
-			else
138
+			if ($parameter1 === true && $parameter2 !== null) {
139
+							updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
140
+			} else
139 141
 			{
140 142
 				// SUM and MAX on a smaller table is better for InnoDB tables.
141 143
 				$result = $smcFunc['db_query']('', '
@@ -175,23 +177,25 @@  discard block
 block discarded – undo
175 177
 				$parameter2 = text2words($parameter2);
176 178
 
177 179
 				$inserts = array();
178
-				foreach ($parameter2 as $word)
179
-					$inserts[] = array($word, $parameter1);
180
+				foreach ($parameter2 as $word) {
181
+									$inserts[] = array($word, $parameter1);
182
+				}
180 183
 
181
-				if (!empty($inserts))
182
-					$smcFunc['db_insert']('ignore',
184
+				if (!empty($inserts)) {
185
+									$smcFunc['db_insert']('ignore',
183 186
 						'{db_prefix}log_search_subjects',
184 187
 						array('word' => 'string', 'id_topic' => 'int'),
185 188
 						$inserts,
186 189
 						array('word', 'id_topic')
187 190
 					);
191
+				}
188 192
 			}
189 193
 			break;
190 194
 
191 195
 		case 'topic':
192
-			if ($parameter1 === true)
193
-				updateSettings(array('totalTopics' => true), true);
194
-			else
196
+			if ($parameter1 === true) {
197
+							updateSettings(array('totalTopics' => true), true);
198
+			} else
195 199
 			{
196 200
 				// Get the number of topics - a SUM is better for InnoDB tables.
197 201
 				// We also ignore the recycle bin here because there will probably be a bunch of one-post topics there.
@@ -212,8 +216,9 @@  discard block
 block discarded – undo
212 216
 
213 217
 		case 'postgroups':
214 218
 			// Parameter two is the updated columns: we should check to see if we base groups off any of these.
215
-			if ($parameter2 !== null && !in_array('posts', $parameter2))
216
-				return;
219
+			if ($parameter2 !== null && !in_array('posts', $parameter2)) {
220
+							return;
221
+			}
217 222
 
218 223
 			$postgroups = cache_get_data('updateStats:postgroups', 360);
219 224
 			if ($postgroups == null || $parameter1 == null)
@@ -228,8 +233,9 @@  discard block
 block discarded – undo
228 233
 					)
229 234
 				);
230 235
 				$postgroups = array();
231
-				while ($row = $smcFunc['db_fetch_assoc']($request))
232
-					$postgroups[$row['id_group']] = $row['min_posts'];
236
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
237
+									$postgroups[$row['id_group']] = $row['min_posts'];
238
+				}
233 239
 				$smcFunc['db_free_result']($request);
234 240
 
235 241
 				// Sort them this way because if it's done with MySQL it causes a filesort :(.
@@ -239,8 +245,9 @@  discard block
 block discarded – undo
239 245
 			}
240 246
 
241 247
 			// Oh great, they've screwed their post groups.
242
-			if (empty($postgroups))
243
-				return;
248
+			if (empty($postgroups)) {
249
+							return;
250
+			}
244 251
 
245 252
 			// Set all membergroups from most posts to least posts.
246 253
 			$conditions = '';
@@ -298,10 +305,9 @@  discard block
 block discarded – undo
298 305
 	{
299 306
 		$condition = 'id_member IN ({array_int:members})';
300 307
 		$parameters['members'] = $members;
301
-	}
302
-	elseif ($members === null)
303
-		$condition = '1=1';
304
-	else
308
+	} elseif ($members === null) {
309
+			$condition = '1=1';
310
+	} else
305 311
 	{
306 312
 		$condition = 'id_member = {int:member}';
307 313
 		$parameters['member'] = $members;
@@ -341,9 +347,9 @@  discard block
 block discarded – undo
341 347
 		if (count($vars_to_integrate) != 0)
342 348
 		{
343 349
 			// Fetch a list of member_names if necessary
344
-			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members)))
345
-				$member_names = array($user_info['username']);
346
-			else
350
+			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) {
351
+							$member_names = array($user_info['username']);
352
+			} else
347 353
 			{
348 354
 				$member_names = array();
349 355
 				$request = $smcFunc['db_query']('', '
@@ -352,14 +358,16 @@  discard block
 block discarded – undo
352 358
 					WHERE ' . $condition,
353 359
 					$parameters
354 360
 				);
355
-				while ($row = $smcFunc['db_fetch_assoc']($request))
356
-					$member_names[] = $row['member_name'];
361
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
362
+									$member_names[] = $row['member_name'];
363
+				}
357 364
 				$smcFunc['db_free_result']($request);
358 365
 			}
359 366
 
360
-			if (!empty($member_names))
361
-				foreach ($vars_to_integrate as $var)
367
+			if (!empty($member_names)) {
368
+							foreach ($vars_to_integrate as $var)
362 369
 					call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats));
370
+			}
363 371
 		}
364 372
 	}
365 373
 
@@ -367,16 +375,17 @@  discard block
 block discarded – undo
367 375
 	foreach ($data as $var => $val)
368 376
 	{
369 377
 		$type = 'string';
370
-		if (in_array($var, $knownInts))
371
-			$type = 'int';
372
-		elseif (in_array($var, $knownFloats))
373
-			$type = 'float';
374
-		elseif ($var == 'birthdate')
375
-			$type = 'date';
376
-		elseif ($var == 'member_ip')
377
-			$type = 'inet';
378
-		elseif ($var == 'member_ip2')
379
-			$type = 'inet';
378
+		if (in_array($var, $knownInts)) {
379
+					$type = 'int';
380
+		} elseif (in_array($var, $knownFloats)) {
381
+					$type = 'float';
382
+		} elseif ($var == 'birthdate') {
383
+					$type = 'date';
384
+		} elseif ($var == 'member_ip') {
385
+					$type = 'inet';
386
+		} elseif ($var == 'member_ip2') {
387
+					$type = 'inet';
388
+		}
380 389
 
381 390
 		// Doing an increment?
382 391
 		if ($type == 'int' && ($val === '+' || $val === '-'))
@@ -390,8 +399,9 @@  discard block
 block discarded – undo
390 399
 		{
391 400
 			if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match))
392 401
 			{
393
-				if ($match[1] != '+ ')
394
-					$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
402
+				if ($match[1] != '+ ') {
403
+									$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
404
+				}
395 405
 				$type = 'raw';
396 406
 			}
397 407
 		}
@@ -412,8 +422,9 @@  discard block
 block discarded – undo
412 422
 	// Clear any caching?
413 423
 	if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members))
414 424
 	{
415
-		if (!is_array($members))
416
-			$members = array($members);
425
+		if (!is_array($members)) {
426
+					$members = array($members);
427
+		}
417 428
 
418 429
 		foreach ($members as $member)
419 430
 		{
@@ -446,29 +457,32 @@  discard block
 block discarded – undo
446 457
 {
447 458
 	global $modSettings, $smcFunc;
448 459
 
449
-	if (empty($changeArray) || !is_array($changeArray))
450
-		return;
460
+	if (empty($changeArray) || !is_array($changeArray)) {
461
+			return;
462
+	}
451 463
 
452 464
 	$toRemove = array();
453 465
 
454 466
 	// Go check if there is any setting to be removed.
455
-	foreach ($changeArray as $k => $v)
456
-		if ($v === null)
467
+	foreach ($changeArray as $k => $v) {
468
+			if ($v === null)
457 469
 		{
458 470
 			// Found some, remove them from the original array and add them to ours.
459 471
 			unset($changeArray[$k]);
472
+	}
460 473
 			$toRemove[] = $k;
461 474
 		}
462 475
 
463 476
 	// Proceed with the deletion.
464
-	if (!empty($toRemove))
465
-		$smcFunc['db_query']('', '
477
+	if (!empty($toRemove)) {
478
+			$smcFunc['db_query']('', '
466 479
 			DELETE FROM {db_prefix}settings
467 480
 			WHERE variable IN ({array_string:remove})',
468 481
 			array(
469 482
 				'remove' => $toRemove,
470 483
 			)
471 484
 		);
485
+	}
472 486
 
473 487
 	// In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs.
474 488
 	if ($update)
@@ -497,19 +511,22 @@  discard block
 block discarded – undo
497 511
 	foreach ($changeArray as $variable => $value)
498 512
 	{
499 513
 		// Don't bother if it's already like that ;).
500
-		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value)
501
-			continue;
514
+		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) {
515
+					continue;
516
+		}
502 517
 		// If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it.
503
-		elseif (!isset($modSettings[$variable]) && empty($value))
504
-			continue;
518
+		elseif (!isset($modSettings[$variable]) && empty($value)) {
519
+					continue;
520
+		}
505 521
 
506 522
 		$replaceArray[] = array($variable, $value);
507 523
 
508 524
 		$modSettings[$variable] = $value;
509 525
 	}
510 526
 
511
-	if (empty($replaceArray))
512
-		return;
527
+	if (empty($replaceArray)) {
528
+			return;
529
+	}
513 530
 
514 531
 	$smcFunc['db_insert']('replace',
515 532
 		'{db_prefix}settings',
@@ -555,14 +572,17 @@  discard block
 block discarded – undo
555 572
 	$start_invalid = $start < 0;
556 573
 
557 574
 	// Make sure $start is a proper variable - not less than 0.
558
-	if ($start_invalid)
559
-		$start = 0;
575
+	if ($start_invalid) {
576
+			$start = 0;
577
+	}
560 578
 	// Not greater than the upper bound.
561
-	elseif ($start >= $max_value)
562
-		$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
579
+	elseif ($start >= $max_value) {
580
+			$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
581
+	}
563 582
 	// And it has to be a multiple of $num_per_page!
564
-	else
565
-		$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
583
+	else {
584
+			$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
585
+	}
566 586
 
567 587
 	$context['current_page'] = $start / $num_per_page;
568 588
 
@@ -592,77 +612,87 @@  discard block
 block discarded – undo
592 612
 
593 613
 		// Show all the pages.
594 614
 		$display_page = 1;
595
-		for ($counter = 0; $counter < $max_value; $counter += $num_per_page)
596
-			$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
615
+		for ($counter = 0; $counter < $max_value; $counter += $num_per_page) {
616
+					$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
617
+		}
597 618
 
598 619
 		// Show the right arrow.
599 620
 		$display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page);
600
-		if ($start != $counter - $max_value && !$start_invalid)
601
-			$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
602
-	}
603
-	else
621
+		if ($start != $counter - $max_value && !$start_invalid) {
622
+					$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
623
+		}
624
+	} else
604 625
 	{
605 626
 		// If they didn't enter an odd value, pretend they did.
606 627
 		$PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2;
607 628
 
608 629
 		// Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page)
609
-		if (!empty($start) && $show_prevnext)
610
-			$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
611
-		else
612
-			$pageindex .= '';
630
+		if (!empty($start) && $show_prevnext) {
631
+					$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
632
+		} else {
633
+					$pageindex .= '';
634
+		}
613 635
 
614 636
 		// Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15)
615
-		if ($start > $num_per_page * $PageContiguous)
616
-			$pageindex .= sprintf($base_link, 0, '1');
637
+		if ($start > $num_per_page * $PageContiguous) {
638
+					$pageindex .= sprintf($base_link, 0, '1');
639
+		}
617 640
 
618 641
 		// Show the ... after the first page.  (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page)
619
-		if ($start > $num_per_page * ($PageContiguous + 1))
620
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
642
+		if ($start > $num_per_page * ($PageContiguous + 1)) {
643
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
621 644
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
622 645
 				'{FIRST_PAGE}' => $num_per_page,
623 646
 				'{LAST_PAGE}' => $start - $num_per_page * $PageContiguous,
624 647
 				'{PER_PAGE}' => $num_per_page,
625 648
 			));
649
+		}
626 650
 
627 651
 		// Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page)
628
-		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--)
629
-			if ($start >= $num_per_page * $nCont)
652
+		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) {
653
+					if ($start >= $num_per_page * $nCont)
630 654
 			{
631 655
 				$tmpStart = $start - $num_per_page * $nCont;
656
+		}
632 657
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
633 658
 			}
634 659
 
635 660
 		// Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page)
636
-		if (!$start_invalid)
637
-			$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
638
-		else
639
-			$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
661
+		if (!$start_invalid) {
662
+					$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
663
+		} else {
664
+					$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
665
+		}
640 666
 
641 667
 		// Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page)
642 668
 		$tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page;
643
-		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++)
644
-			if ($start + $num_per_page * $nCont <= $tmpMaxPages)
669
+		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) {
670
+					if ($start + $num_per_page * $nCont <= $tmpMaxPages)
645 671
 			{
646 672
 				$tmpStart = $start + $num_per_page * $nCont;
673
+		}
647 674
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
648 675
 			}
649 676
 
650 677
 		// Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page)
651
-		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages)
652
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
678
+		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) {
679
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
653 680
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
654 681
 				'{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1),
655 682
 				'{LAST_PAGE}' => $tmpMaxPages,
656 683
 				'{PER_PAGE}' => $num_per_page,
657 684
 			));
685
+		}
658 686
 
659 687
 		// Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15<  next page)
660
-		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages)
661
-			$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
688
+		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) {
689
+					$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
690
+		}
662 691
 
663 692
 		// Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<)
664
-		if ($start != $tmpMaxPages && $show_prevnext)
665
-			$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
693
+		if ($start != $tmpMaxPages && $show_prevnext) {
694
+					$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
695
+		}
666 696
 	}
667 697
 	$pageindex .= $settings['page_index']['extra_after'];
668 698
 
@@ -688,8 +718,9 @@  discard block
 block discarded – undo
688 718
 	if ($decimal_separator === null)
689 719
 	{
690 720
 		// Not set for whatever reason?
691
-		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1)
692
-			return $number;
721
+		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) {
722
+					return $number;
723
+		}
693 724
 
694 725
 		// Cache these each load...
695 726
 		$thousands_separator = $matches[1];
@@ -721,17 +752,20 @@  discard block
 block discarded – undo
721 752
 	static $non_twelve_hour;
722 753
 
723 754
 	// Offset the time.
724
-	if (!$offset_type)
725
-		$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
755
+	if (!$offset_type) {
756
+			$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
757
+	}
726 758
 	// Just the forum offset?
727
-	elseif ($offset_type == 'forum')
728
-		$time = $log_time + $modSettings['time_offset'] * 3600;
729
-	else
730
-		$time = $log_time;
759
+	elseif ($offset_type == 'forum') {
760
+			$time = $log_time + $modSettings['time_offset'] * 3600;
761
+	} else {
762
+			$time = $log_time;
763
+	}
731 764
 
732 765
 	// We can't have a negative date (on Windows, at least.)
733
-	if ($log_time < 0)
734
-		$log_time = 0;
766
+	if ($log_time < 0) {
767
+			$log_time = 0;
768
+	}
735 769
 
736 770
 	// Today and Yesterday?
737 771
 	if ($modSettings['todayMod'] >= 1 && $show_today === true)
@@ -748,46 +782,53 @@  discard block
 block discarded – undo
748 782
 		{
749 783
 			$h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l';
750 784
 			$today_fmt = $h . ':%M' . $s . ' %p';
785
+		} else {
786
+					$today_fmt = '%H:%M' . $s;
751 787
 		}
752
-		else
753
-			$today_fmt = '%H:%M' . $s;
754 788
 
755 789
 		// Same day of the year, same year.... Today!
756
-		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year'])
757
-			return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
790
+		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) {
791
+					return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
792
+		}
758 793
 
759 794
 		// Day-of-year is one less and same year, or it's the first of the year and that's the last of the year...
760
-		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31))
761
-			return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
795
+		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) {
796
+					return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
797
+		}
762 798
 	}
763 799
 
764 800
 	$str = !is_bool($show_today) ? $show_today : $user_info['time_format'];
765 801
 
766 802
 	if (setlocale(LC_TIME, $txt['lang_locale']))
767 803
 	{
768
-		if (!isset($non_twelve_hour))
769
-			$non_twelve_hour = trim(strftime('%p')) === '';
770
-		if ($non_twelve_hour && strpos($str, '%p') !== false)
771
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
804
+		if (!isset($non_twelve_hour)) {
805
+					$non_twelve_hour = trim(strftime('%p')) === '';
806
+		}
807
+		if ($non_twelve_hour && strpos($str, '%p') !== false) {
808
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
809
+		}
772 810
 
773
-		foreach (array('%a', '%A', '%b', '%B') as $token)
774
-			if (strpos($str, $token) !== false)
811
+		foreach (array('%a', '%A', '%b', '%B') as $token) {
812
+					if (strpos($str, $token) !== false)
775 813
 				$str = str_replace($token, strftime($token, $time), $str);
776
-	}
777
-	else
814
+		}
815
+	} else
778 816
 	{
779 817
 		// Do-it-yourself time localization.  Fun.
780
-		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label)
781
-			if (strpos($str, $token) !== false)
818
+		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) {
819
+					if (strpos($str, $token) !== false)
782 820
 				$str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str);
821
+		}
783 822
 
784
-		if (strpos($str, '%p') !== false)
785
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
823
+		if (strpos($str, '%p') !== false) {
824
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
825
+		}
786 826
 	}
787 827
 
788 828
 	// Windows doesn't support %e; on some versions, strftime fails altogether if used, so let's prevent that.
789
-	if ($context['server']['is_windows'] && strpos($str, '%e') !== false)
790
-		$str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str);
829
+	if ($context['server']['is_windows'] && strpos($str, '%e') !== false) {
830
+			$str = str_replace('%e', ltrim(strftime('%d', $time), '0'), $str);
831
+	}
791 832
 
792 833
 	// Format any other characters..
793 834
 	return strftime($str, $time);
@@ -809,16 +850,19 @@  discard block
 block discarded – undo
809 850
 	static $translation = array();
810 851
 
811 852
 	// Determine the character set... Default to UTF-8
812
-	if (empty($context['character_set']))
813
-		$charset = 'UTF-8';
853
+	if (empty($context['character_set'])) {
854
+			$charset = 'UTF-8';
855
+	}
814 856
 	// Use ISO-8859-1 in place of non-supported ISO-8859 charsets...
815
-	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15')))
816
-		$charset = 'ISO-8859-1';
817
-	else
818
-		$charset = $context['character_set'];
857
+	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) {
858
+			$charset = 'ISO-8859-1';
859
+	} else {
860
+			$charset = $context['character_set'];
861
+	}
819 862
 
820
-	if (empty($translation))
821
-		$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
863
+	if (empty($translation)) {
864
+			$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
865
+	}
822 866
 
823 867
 	return strtr($string, $translation);
824 868
 }
@@ -840,8 +884,9 @@  discard block
 block discarded – undo
840 884
 	global $smcFunc;
841 885
 
842 886
 	// It was already short enough!
843
-	if ($smcFunc['strlen']($subject) <= $len)
844
-		return $subject;
887
+	if ($smcFunc['strlen']($subject) <= $len) {
888
+			return $subject;
889
+	}
845 890
 
846 891
 	// Shorten it by the length it was too long, and strip off junk from the end.
847 892
 	return $smcFunc['substr']($subject, 0, $len) . '...';
@@ -860,10 +905,11 @@  discard block
 block discarded – undo
860 905
 {
861 906
 	global $user_info, $modSettings;
862 907
 
863
-	if ($timestamp === null)
864
-		$timestamp = time();
865
-	elseif ($timestamp == 0)
866
-		return 0;
908
+	if ($timestamp === null) {
909
+			$timestamp = time();
910
+	} elseif ($timestamp == 0) {
911
+			return 0;
912
+	}
867 913
 
868 914
 	return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600;
869 915
 }
@@ -892,8 +938,9 @@  discard block
 block discarded – undo
892 938
 		$array[$i] = $array[$j];
893 939
 		$array[$j] = $temp;
894 940
 
895
-		for ($i = 1; $p[$i] == 0; $i++)
896
-			$p[$i] = 1;
941
+		for ($i = 1; $p[$i] == 0; $i++) {
942
+					$p[$i] = 1;
943
+		}
897 944
 
898 945
 		$orders[] = $array;
899 946
 	}
@@ -925,12 +972,14 @@  discard block
 block discarded – undo
925 972
 	static $disabled;
926 973
 
927 974
 	// Don't waste cycles
928
-	if ($message === '')
929
-		return '';
975
+	if ($message === '') {
976
+			return '';
977
+	}
930 978
 
931 979
 	// Just in case it wasn't determined yet whether UTF-8 is enabled.
932
-	if (!isset($context['utf8']))
933
-		$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
980
+	if (!isset($context['utf8'])) {
981
+			$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
982
+	}
934 983
 
935 984
 	// Clean up any cut/paste issues we may have
936 985
 	$message = sanitizeMSCutPaste($message);
@@ -942,13 +991,15 @@  discard block
 block discarded – undo
942 991
 		return $message;
943 992
 	}
944 993
 
945
-	if ($smileys !== null && ($smileys == '1' || $smileys == '0'))
946
-		$smileys = (bool) $smileys;
994
+	if ($smileys !== null && ($smileys == '1' || $smileys == '0')) {
995
+			$smileys = (bool) $smileys;
996
+	}
947 997
 
948 998
 	if (empty($modSettings['enableBBC']) && $message !== false)
949 999
 	{
950
-		if ($smileys === true)
951
-			parsesmileys($message);
1000
+		if ($smileys === true) {
1001
+					parsesmileys($message);
1002
+		}
952 1003
 
953 1004
 		return $message;
954 1005
 	}
@@ -961,8 +1012,9 @@  discard block
 block discarded – undo
961 1012
 	}
962 1013
 
963 1014
 	// Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker
964
-	if (!empty($modSettings['autoLinkUrls']))
965
-		set_tld_regex();
1015
+	if (!empty($modSettings['autoLinkUrls'])) {
1016
+			set_tld_regex();
1017
+	}
966 1018
 
967 1019
 	// Allow mods access before entering the main parse_bbc loop
968 1020
 	call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
@@ -976,12 +1028,14 @@  discard block
 block discarded – undo
976 1028
 
977 1029
 			$temp = explode(',', strtolower($modSettings['disabledBBC']));
978 1030
 
979
-			foreach ($temp as $tag)
980
-				$disabled[trim($tag)] = true;
1031
+			foreach ($temp as $tag) {
1032
+							$disabled[trim($tag)] = true;
1033
+			}
981 1034
 		}
982 1035
 
983
-		if (empty($modSettings['enableEmbeddedFlash']))
984
-			$disabled['flash'] = true;
1036
+		if (empty($modSettings['enableEmbeddedFlash'])) {
1037
+					$disabled['flash'] = true;
1038
+		}
985 1039
 
986 1040
 		/* The following bbc are formatted as an array, with keys as follows:
987 1041
 
@@ -1102,8 +1156,9 @@  discard block
 block discarded – undo
1102 1156
 					$returnContext = '';
1103 1157
 
1104 1158
 					// BBC or the entire attachments feature is disabled
1105
-					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach']))
1106
-						return $data;
1159
+					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) {
1160
+											return $data;
1161
+					}
1107 1162
 
1108 1163
 					// Save the attach ID.
1109 1164
 					$attachID = $data;
@@ -1114,8 +1169,9 @@  discard block
 block discarded – undo
1114 1169
 					$currentAttachment = parseAttachBBC($attachID);
1115 1170
 
1116 1171
 					// parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do.
1117
-					if (is_string($currentAttachment))
1118
-						return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1172
+					if (is_string($currentAttachment)) {
1173
+											return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1174
+					}
1119 1175
 
1120 1176
 					if (!empty($currentAttachment['is_image']))
1121 1177
 					{
@@ -1131,15 +1187,17 @@  discard block
 block discarded – undo
1131 1187
 							$height = ' height="' . $currentAttachment['height'] . '"';
1132 1188
 						}
1133 1189
 
1134
-						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1135
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1136
-						else
1137
-							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1190
+						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) {
1191
+													$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1192
+						} else {
1193
+													$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1194
+						}
1138 1195
 					}
1139 1196
 
1140 1197
 					// No image. Show a link.
1141
-					else
1142
-						$returnContext .= $currentAttachment['link'];
1198
+					else {
1199
+											$returnContext .= $currentAttachment['link'];
1200
+					}
1143 1201
 
1144 1202
 					// Gotta append what we just did.
1145 1203
 					$data = $returnContext;
@@ -1170,8 +1228,9 @@  discard block
 block discarded – undo
1170 1228
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1171 1229
 						{
1172 1230
 							// Do PHP code coloring?
1173
-							if ($php_parts[$php_i] != '&lt;?php')
1174
-								continue;
1231
+							if ($php_parts[$php_i] != '&lt;?php') {
1232
+															continue;
1233
+							}
1175 1234
 
1176 1235
 							$php_string = '';
1177 1236
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1187,8 +1246,9 @@  discard block
 block discarded – undo
1187 1246
 						$data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data);
1188 1247
 
1189 1248
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1190
-						if ($context['browser']['is_opera'])
1191
-							$data .= '&nbsp;';
1249
+						if ($context['browser']['is_opera']) {
1250
+													$data .= '&nbsp;';
1251
+						}
1192 1252
 					}
1193 1253
 				},
1194 1254
 				'block_level' => true,
@@ -1207,8 +1267,9 @@  discard block
 block discarded – undo
1207 1267
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1208 1268
 						{
1209 1269
 							// Do PHP code coloring?
1210
-							if ($php_parts[$php_i] != '&lt;?php')
1211
-								continue;
1270
+							if ($php_parts[$php_i] != '&lt;?php') {
1271
+															continue;
1272
+							}
1212 1273
 
1213 1274
 							$php_string = '';
1214 1275
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1224,8 +1285,9 @@  discard block
 block discarded – undo
1224 1285
 						$data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]);
1225 1286
 
1226 1287
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1227
-						if ($context['browser']['is_opera'])
1228
-							$data[0] .= '&nbsp;';
1288
+						if ($context['browser']['is_opera']) {
1289
+													$data[0] .= '&nbsp;';
1290
+						}
1229 1291
 					}
1230 1292
 				},
1231 1293
 				'block_level' => true,
@@ -1263,11 +1325,13 @@  discard block
 block discarded – undo
1263 1325
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1264 1326
 				'validate' => function (&$tag, &$data, $disabled)
1265 1327
 				{
1266
-					if (isset($disabled['url']))
1267
-						$tag['content'] = '$1';
1328
+					if (isset($disabled['url'])) {
1329
+											$tag['content'] = '$1';
1330
+					}
1268 1331
 					$scheme = parse_url($data[0], PHP_URL_SCHEME);
1269
-					if (empty($scheme))
1270
-						$data[0] = '//' . ltrim($data[0], ':/');
1332
+					if (empty($scheme)) {
1333
+											$data[0] = '//' . ltrim($data[0], ':/');
1334
+					}
1271 1335
 				},
1272 1336
 				'disabled_content' => '<a href="$1" target="_blank" class="new_win">$1</a>',
1273 1337
 			),
@@ -1281,10 +1345,11 @@  discard block
 block discarded – undo
1281 1345
 				{
1282 1346
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1283 1347
 
1284
-					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches))
1285
-						$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1286
-					else
1287
-						$css = '';
1348
+					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) {
1349
+											$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1350
+					} else {
1351
+											$css = '';
1352
+					}
1288 1353
 
1289 1354
 					$data = $class . $css;
1290 1355
 				},
@@ -1334,14 +1399,16 @@  discard block
 block discarded – undo
1334 1399
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1335 1400
 					if ($image_proxy_enabled)
1336 1401
 					{
1337
-						if (empty($scheme))
1338
-							$data = 'http://' . ltrim($data, ':/');
1402
+						if (empty($scheme)) {
1403
+													$data = 'http://' . ltrim($data, ':/');
1404
+						}
1339 1405
 
1340
-						if ($scheme != 'https')
1341
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1406
+						if ($scheme != 'https') {
1407
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1408
+						}
1409
+					} elseif (empty($scheme)) {
1410
+											$data = '//' . ltrim($data, ':/');
1342 1411
 					}
1343
-					elseif (empty($scheme))
1344
-						$data = '//' . ltrim($data, ':/');
1345 1412
 				},
1346 1413
 				'disabled_content' => '($1)',
1347 1414
 			),
@@ -1357,14 +1424,16 @@  discard block
 block discarded – undo
1357 1424
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1358 1425
 					if ($image_proxy_enabled)
1359 1426
 					{
1360
-						if (empty($scheme))
1361
-							$data = 'http://' . ltrim($data, ':/');
1427
+						if (empty($scheme)) {
1428
+													$data = 'http://' . ltrim($data, ':/');
1429
+						}
1362 1430
 
1363
-						if ($scheme != 'https')
1364
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1431
+						if ($scheme != 'https') {
1432
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1433
+						}
1434
+					} elseif (empty($scheme)) {
1435
+											$data = '//' . ltrim($data, ':/');
1365 1436
 					}
1366
-					elseif (empty($scheme))
1367
-						$data = '//' . ltrim($data, ':/');
1368 1437
 				},
1369 1438
 				'disabled_content' => '($1)',
1370 1439
 			),
@@ -1376,8 +1445,9 @@  discard block
 block discarded – undo
1376 1445
 				{
1377 1446
 					$data = strtr($data, array('<br>' => ''));
1378 1447
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1379
-					if (empty($scheme))
1380
-						$data = '//' . ltrim($data, ':/');
1448
+					if (empty($scheme)) {
1449
+											$data = '//' . ltrim($data, ':/');
1450
+					}
1381 1451
 				},
1382 1452
 			),
1383 1453
 			array(
@@ -1388,13 +1458,14 @@  discard block
 block discarded – undo
1388 1458
 				'after' => '</a>',
1389 1459
 				'validate' => function (&$tag, &$data, $disabled)
1390 1460
 				{
1391
-					if (substr($data, 0, 1) == '#')
1392
-						$data = '#post_' . substr($data, 1);
1393
-					else
1461
+					if (substr($data, 0, 1) == '#') {
1462
+											$data = '#post_' . substr($data, 1);
1463
+					} else
1394 1464
 					{
1395 1465
 						$scheme = parse_url($data, PHP_URL_SCHEME);
1396
-						if (empty($scheme))
1397
-							$data = '//' . ltrim($data, ':/');
1466
+						if (empty($scheme)) {
1467
+													$data = '//' . ltrim($data, ':/');
1468
+						}
1398 1469
 					}
1399 1470
 				},
1400 1471
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
@@ -1472,8 +1543,9 @@  discard block
 block discarded – undo
1472 1543
 					{
1473 1544
 						$add_begin = substr(trim($data), 0, 5) != '&lt;?';
1474 1545
 						$data = highlight_php_code($add_begin ? '&lt;?php ' . $data . '?&gt;' : $data);
1475
-						if ($add_begin)
1476
-							$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1546
+						if ($add_begin) {
1547
+													$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1548
+						}
1477 1549
 					}
1478 1550
 				},
1479 1551
 				'block_level' => false,
@@ -1604,10 +1676,11 @@  discard block
 block discarded – undo
1604 1676
 				'content' => '$1',
1605 1677
 				'validate' => function (&$tag, &$data, $disabled)
1606 1678
 				{
1607
-					if (is_numeric($data))
1608
-						$data = timeformat($data);
1609
-					else
1610
-						$tag['content'] = '[time]$1[/time]';
1679
+					if (is_numeric($data)) {
1680
+											$data = timeformat($data);
1681
+					} else {
1682
+											$tag['content'] = '[time]$1[/time]';
1683
+					}
1611 1684
 				},
1612 1685
 			),
1613 1686
 			array(
@@ -1634,8 +1707,9 @@  discard block
 block discarded – undo
1634 1707
 				{
1635 1708
 					$data = strtr($data, array('<br>' => ''));
1636 1709
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1637
-					if (empty($scheme))
1638
-						$data = '//' . ltrim($data, ':/');
1710
+					if (empty($scheme)) {
1711
+											$data = '//' . ltrim($data, ':/');
1712
+					}
1639 1713
 				},
1640 1714
 			),
1641 1715
 			array(
@@ -1647,8 +1721,9 @@  discard block
 block discarded – undo
1647 1721
 				'validate' => function (&$tag, &$data, $disabled)
1648 1722
 				{
1649 1723
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1650
-					if (empty($scheme))
1651
-						$data = '//' . ltrim($data, ':/');
1724
+					if (empty($scheme)) {
1725
+											$data = '//' . ltrim($data, ':/');
1726
+					}
1652 1727
 				},
1653 1728
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
1654 1729
 				'disabled_after' => ' ($1)',
@@ -1668,8 +1743,9 @@  discard block
 block discarded – undo
1668 1743
 		// This is mainly for the bbc manager, so it's easy to add tags above.  Custom BBC should be added above this line.
1669 1744
 		if ($message === false)
1670 1745
 		{
1671
-			if (isset($temp_bbc))
1672
-				$bbc_codes = $temp_bbc;
1746
+			if (isset($temp_bbc)) {
1747
+							$bbc_codes = $temp_bbc;
1748
+			}
1673 1749
 			usort($codes, function ($a, $b) {
1674 1750
 				return strcmp($a['tag'], $b['tag']);
1675 1751
 			});
@@ -1689,8 +1765,9 @@  discard block
 block discarded – undo
1689 1765
 		);
1690 1766
 		if (!isset($disabled['li']) && !isset($disabled['list']))
1691 1767
 		{
1692
-			foreach ($itemcodes as $c => $dummy)
1693
-				$bbc_codes[$c] = array();
1768
+			foreach ($itemcodes as $c => $dummy) {
1769
+							$bbc_codes[$c] = array();
1770
+			}
1694 1771
 		}
1695 1772
 
1696 1773
 		// Shhhh!
@@ -1711,12 +1788,14 @@  discard block
 block discarded – undo
1711 1788
 		foreach ($codes as $code)
1712 1789
 		{
1713 1790
 			// Make it easier to process parameters later
1714
-			if (!empty($code['parameters']))
1715
-				ksort($code['parameters'], SORT_STRING);
1791
+			if (!empty($code['parameters'])) {
1792
+							ksort($code['parameters'], SORT_STRING);
1793
+			}
1716 1794
 
1717 1795
 			// If we are not doing every tag only do ones we are interested in.
1718
-			if (empty($parse_tags) || in_array($code['tag'], $parse_tags))
1719
-				$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1796
+			if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) {
1797
+							$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1798
+			}
1720 1799
 		}
1721 1800
 		$codes = null;
1722 1801
 	}
@@ -1727,8 +1806,9 @@  discard block
 block discarded – undo
1727 1806
 		// It's likely this will change if the message is modified.
1728 1807
 		$cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . json_encode($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']);
1729 1808
 
1730
-		if (($temp = cache_get_data($cache_key, 240)) != null)
1731
-			return $temp;
1809
+		if (($temp = cache_get_data($cache_key, 240)) != null) {
1810
+					return $temp;
1811
+		}
1732 1812
 
1733 1813
 		$cache_t = microtime();
1734 1814
 	}
@@ -1760,8 +1840,9 @@  discard block
 block discarded – undo
1760 1840
 		$disabled['flash'] = true;
1761 1841
 
1762 1842
 		// @todo Change maybe?
1763
-		if (!isset($_GET['images']))
1764
-			$disabled['img'] = true;
1843
+		if (!isset($_GET['images'])) {
1844
+					$disabled['img'] = true;
1845
+		}
1765 1846
 
1766 1847
 		// @todo Interface/setting to add more?
1767 1848
 	}
@@ -1785,8 +1866,9 @@  discard block
 block discarded – undo
1785 1866
 		$pos = isset($matches[0][1]) ? $matches[0][1] : false;
1786 1867
 
1787 1868
 		// Failsafe.
1788
-		if ($pos === false || $last_pos > $pos)
1789
-			$pos = strlen($message) + 1;
1869
+		if ($pos === false || $last_pos > $pos) {
1870
+					$pos = strlen($message) + 1;
1871
+		}
1790 1872
 
1791 1873
 		// Can't have a one letter smiley, URL, or email! (sorry.)
1792 1874
 		if ($last_pos < $pos - 1)
@@ -1805,8 +1887,9 @@  discard block
 block discarded – undo
1805 1887
 
1806 1888
 				// <br> should be empty.
1807 1889
 				$empty_tags = array('br', 'hr');
1808
-				foreach ($empty_tags as $tag)
1809
-					$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '[' . $tag . ' /]', $data);
1890
+				foreach ($empty_tags as $tag) {
1891
+									$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '[' . $tag . ' /]', $data);
1892
+				}
1810 1893
 
1811 1894
 				// b, u, i, s, pre... basic tags.
1812 1895
 				$closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote');
@@ -1815,8 +1898,9 @@  discard block
 block discarded – undo
1815 1898
 					$diff = substr_count($data, '&lt;' . $tag . '&gt;') - substr_count($data, '&lt;/' . $tag . '&gt;');
1816 1899
 					$data = strtr($data, array('&lt;' . $tag . '&gt;' => '<' . $tag . '>', '&lt;/' . $tag . '&gt;' => '</' . $tag . '>'));
1817 1900
 
1818
-					if ($diff > 0)
1819
-						$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1901
+					if ($diff > 0) {
1902
+											$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1903
+					}
1820 1904
 				}
1821 1905
 
1822 1906
 				// Do <img ...> - with security... action= -> action-.
@@ -1829,8 +1913,9 @@  discard block
 block discarded – undo
1829 1913
 						$alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^&quot;|&quot;$~', '', $matches[3][$match]);
1830 1914
 
1831 1915
 						// Remove action= from the URL - no funny business, now.
1832
-						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0)
1833
-							$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1916
+						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) {
1917
+													$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1918
+						}
1834 1919
 
1835 1920
 						// Check if the image is larger than allowed.
1836 1921
 						if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height']))
@@ -1851,9 +1936,9 @@  discard block
 block discarded – undo
1851 1936
 
1852 1937
 							// Set the new image tag.
1853 1938
 							$replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]';
1939
+						} else {
1940
+													$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1854 1941
 						}
1855
-						else
1856
-							$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1857 1942
 					}
1858 1943
 
1859 1944
 					$data = strtr($data, $replaces);
@@ -1866,16 +1951,18 @@  discard block
 block discarded – undo
1866 1951
 				$no_autolink_area = false;
1867 1952
 				if (!empty($open_tags))
1868 1953
 				{
1869
-					foreach ($open_tags as $open_tag)
1870
-						if (in_array($open_tag['tag'], $no_autolink_tags))
1954
+					foreach ($open_tags as $open_tag) {
1955
+											if (in_array($open_tag['tag'], $no_autolink_tags))
1871 1956
 							$no_autolink_area = true;
1957
+					}
1872 1958
 				}
1873 1959
 
1874 1960
 				// Don't go backwards.
1875 1961
 				// @todo Don't think is the real solution....
1876 1962
 				$lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0;
1877
-				if ($pos < $lastAutoPos)
1878
-					$no_autolink_area = true;
1963
+				if ($pos < $lastAutoPos) {
1964
+									$no_autolink_area = true;
1965
+				}
1879 1966
 				$lastAutoPos = $pos;
1880 1967
 
1881 1968
 				if (!$no_autolink_area)
@@ -1984,17 +2071,19 @@  discard block
 block discarded – undo
1984 2071
 							if ($scheme == 'mailto')
1985 2072
 							{
1986 2073
 								$email_address = str_replace('mailto:', '', $url);
1987
-								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false)
1988
-									return '[email=' . $email_address . ']' . $url . '[/email]';
1989
-								else
1990
-									return $url;
2074
+								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) {
2075
+																	return '[email=' . $email_address . ']' . $url . '[/email]';
2076
+								} else {
2077
+																	return $url;
2078
+								}
1991 2079
 							}
1992 2080
 
1993 2081
 							// Are we linking a schemeless URL or naked domain name (e.g. "example.com")?
1994
-							if (empty($scheme))
1995
-								$fullUrl = '//' . ltrim($url, ':/');
1996
-							else
1997
-								$fullUrl = $url;
2082
+							if (empty($scheme)) {
2083
+															$fullUrl = '//' . ltrim($url, ':/');
2084
+							} else {
2085
+															$fullUrl = $url;
2086
+							}
1998 2087
 
1999 2088
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
2000 2089
 						}, $data);
@@ -2043,16 +2132,18 @@  discard block
 block discarded – undo
2043 2132
 		}
2044 2133
 
2045 2134
 		// Are we there yet?  Are we there yet?
2046
-		if ($pos >= strlen($message) - 1)
2047
-			break;
2135
+		if ($pos >= strlen($message) - 1) {
2136
+					break;
2137
+		}
2048 2138
 
2049 2139
 		$tags = strtolower($message[$pos + 1]);
2050 2140
 
2051 2141
 		if ($tags == '/' && !empty($open_tags))
2052 2142
 		{
2053 2143
 			$pos2 = strpos($message, ']', $pos + 1);
2054
-			if ($pos2 == $pos + 2)
2055
-				continue;
2144
+			if ($pos2 == $pos + 2) {
2145
+							continue;
2146
+			}
2056 2147
 
2057 2148
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2058 2149
 
@@ -2062,8 +2153,9 @@  discard block
 block discarded – undo
2062 2153
 			do
2063 2154
 			{
2064 2155
 				$tag = array_pop($open_tags);
2065
-				if (!$tag)
2066
-					break;
2156
+				if (!$tag) {
2157
+									break;
2158
+				}
2067 2159
 
2068 2160
 				if (!empty($tag['block_level']))
2069 2161
 				{
@@ -2077,10 +2169,11 @@  discard block
 block discarded – undo
2077 2169
 					// The idea is, if we are LOOKING for a block level tag, we can close them on the way.
2078 2170
 					if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]]))
2079 2171
 					{
2080
-						foreach ($bbc_codes[$look_for[0]] as $temp)
2081
-							if ($temp['tag'] == $look_for)
2172
+						foreach ($bbc_codes[$look_for[0]] as $temp) {
2173
+													if ($temp['tag'] == $look_for)
2082 2174
 							{
2083 2175
 								$block_level = !empty($temp['block_level']);
2176
+						}
2084 2177
 								break;
2085 2178
 							}
2086 2179
 					}
@@ -2102,15 +2195,15 @@  discard block
 block discarded – undo
2102 2195
 			{
2103 2196
 				$open_tags = $to_close;
2104 2197
 				continue;
2105
-			}
2106
-			elseif (!empty($to_close) && $tag['tag'] != $look_for)
2198
+			} elseif (!empty($to_close) && $tag['tag'] != $look_for)
2107 2199
 			{
2108 2200
 				if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]]))
2109 2201
 				{
2110
-					foreach ($bbc_codes[$look_for[0]] as $temp)
2111
-						if ($temp['tag'] == $look_for)
2202
+					foreach ($bbc_codes[$look_for[0]] as $temp) {
2203
+											if ($temp['tag'] == $look_for)
2112 2204
 						{
2113 2205
 							$block_level = !empty($temp['block_level']);
2206
+					}
2114 2207
 							break;
2115 2208
 						}
2116 2209
 				}
@@ -2118,8 +2211,9 @@  discard block
 block discarded – undo
2118 2211
 				// We're not looking for a block level tag (or maybe even a tag that exists...)
2119 2212
 				if (!$block_level)
2120 2213
 				{
2121
-					foreach ($to_close as $tag)
2122
-						array_push($open_tags, $tag);
2214
+					foreach ($to_close as $tag) {
2215
+											array_push($open_tags, $tag);
2216
+					}
2123 2217
 					continue;
2124 2218
 				}
2125 2219
 			}
@@ -2132,14 +2226,17 @@  discard block
 block discarded – undo
2132 2226
 
2133 2227
 				// See the comment at the end of the big loop - just eating whitespace ;).
2134 2228
 				$whitespace_regex = '';
2135
-				if (!empty($tag['block_level']))
2136
-					$whitespace_regex .= '(&nbsp;|\s)*<br>';
2229
+				if (!empty($tag['block_level'])) {
2230
+									$whitespace_regex .= '(&nbsp;|\s)*<br>';
2231
+				}
2137 2232
 				// Trim one line of whitespace after unnested tags, but all of it after nested ones
2138
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2139
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2233
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2234
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2235
+				}
2140 2236
 
2141
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2142
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2237
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2238
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2239
+				}
2143 2240
 			}
2144 2241
 
2145 2242
 			if (!empty($to_close))
@@ -2152,8 +2249,9 @@  discard block
 block discarded – undo
2152 2249
 		}
2153 2250
 
2154 2251
 		// No tags for this character, so just keep going (fastest possible course.)
2155
-		if (!isset($bbc_codes[$tags]))
2156
-			continue;
2252
+		if (!isset($bbc_codes[$tags])) {
2253
+					continue;
2254
+		}
2157 2255
 
2158 2256
 		$inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1];
2159 2257
 		$tag = null;
@@ -2162,44 +2260,52 @@  discard block
 block discarded – undo
2162 2260
 			$pt_strlen = strlen($possible['tag']);
2163 2261
 
2164 2262
 			// Not a match?
2165
-			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag'])
2166
-				continue;
2263
+			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) {
2264
+							continue;
2265
+			}
2167 2266
 
2168 2267
 			$next_c = $message[$pos + 1 + $pt_strlen];
2169 2268
 
2170 2269
 			// A test validation?
2171
-			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0)
2172
-				continue;
2270
+			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) {
2271
+							continue;
2272
+			}
2173 2273
 			// Do we want parameters?
2174 2274
 			elseif (!empty($possible['parameters']))
2175 2275
 			{
2176
-				if ($next_c != ' ')
2177
-					continue;
2178
-			}
2179
-			elseif (isset($possible['type']))
2276
+				if ($next_c != ' ') {
2277
+									continue;
2278
+				}
2279
+			} elseif (isset($possible['type']))
2180 2280
 			{
2181 2281
 				// Do we need an equal sign?
2182
-				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=')
2183
-					continue;
2282
+				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') {
2283
+									continue;
2284
+				}
2184 2285
 				// Maybe we just want a /...
2185
-				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]')
2186
-					continue;
2286
+				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') {
2287
+									continue;
2288
+				}
2187 2289
 				// An immediate ]?
2188
-				if ($possible['type'] == 'unparsed_content' && $next_c != ']')
2189
-					continue;
2290
+				if ($possible['type'] == 'unparsed_content' && $next_c != ']') {
2291
+									continue;
2292
+				}
2190 2293
 			}
2191 2294
 			// No type means 'parsed_content', which demands an immediate ] without parameters!
2192
-			elseif ($next_c != ']')
2193
-				continue;
2295
+			elseif ($next_c != ']') {
2296
+							continue;
2297
+			}
2194 2298
 
2195 2299
 			// Check allowed tree?
2196
-			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents'])))
2197
-				continue;
2198
-			elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children']))
2199
-				continue;
2300
+			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) {
2301
+							continue;
2302
+			} elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) {
2303
+							continue;
2304
+			}
2200 2305
 			// If this is in the list of disallowed child tags, don't parse it.
2201
-			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children']))
2202
-				continue;
2306
+			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) {
2307
+							continue;
2308
+			}
2203 2309
 
2204 2310
 			$pos1 = $pos + 1 + $pt_strlen + 1;
2205 2311
 
@@ -2211,8 +2317,9 @@  discard block
 block discarded – undo
2211 2317
 				foreach ($open_tags as $open_quote)
2212 2318
 				{
2213 2319
 					// Every parent quote this quote has flips the styling
2214
-					if ($open_quote['tag'] == 'quote')
2215
-						$quote_alt = !$quote_alt;
2320
+					if ($open_quote['tag'] == 'quote') {
2321
+											$quote_alt = !$quote_alt;
2322
+					}
2216 2323
 				}
2217 2324
 				// Add a class to the quote to style alternating blockquotes
2218 2325
 				$possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">'));
@@ -2223,8 +2330,9 @@  discard block
 block discarded – undo
2223 2330
 			{
2224 2331
 				// Build a regular expression for each parameter for the current tag.
2225 2332
 				$preg = array();
2226
-				foreach ($possible['parameters'] as $p => $info)
2227
-					$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2333
+				foreach ($possible['parameters'] as $p => $info) {
2334
+									$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2335
+				}
2228 2336
 
2229 2337
 				// Extract the string that potentially holds our parameters.
2230 2338
 				$blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos));
@@ -2244,24 +2352,27 @@  discard block
 block discarded – undo
2244 2352
 
2245 2353
 					$match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0;
2246 2354
 
2247
-					if ($match)
2248
-						$blob_counter = count($blobs) + 1;
2355
+					if ($match) {
2356
+											$blob_counter = count($blobs) + 1;
2357
+					}
2249 2358
 				}
2250 2359
 
2251 2360
 				// Didn't match our parameter list, try the next possible.
2252
-				if (!$match)
2253
-					continue;
2361
+				if (!$match) {
2362
+									continue;
2363
+				}
2254 2364
 
2255 2365
 				$params = array();
2256 2366
 				for ($i = 1, $n = count($matches); $i < $n; $i += 2)
2257 2367
 				{
2258 2368
 					$key = strtok(ltrim($matches[$i]), '=');
2259
-					if (isset($possible['parameters'][$key]['value']))
2260
-						$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2261
-					elseif (isset($possible['parameters'][$key]['validate']))
2262
-						$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2263
-					else
2264
-						$params['{' . $key . '}'] = $matches[$i + 1];
2369
+					if (isset($possible['parameters'][$key]['value'])) {
2370
+											$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2371
+					} elseif (isset($possible['parameters'][$key]['validate'])) {
2372
+											$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2373
+					} else {
2374
+											$params['{' . $key . '}'] = $matches[$i + 1];
2375
+					}
2265 2376
 
2266 2377
 					// Just to make sure: replace any $ or { so they can't interpolate wrongly.
2267 2378
 					$params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '&#036;', '{' => '&#123;'));
@@ -2269,23 +2380,26 @@  discard block
 block discarded – undo
2269 2380
 
2270 2381
 				foreach ($possible['parameters'] as $p => $info)
2271 2382
 				{
2272
-					if (!isset($params['{' . $p . '}']))
2273
-						$params['{' . $p . '}'] = '';
2383
+					if (!isset($params['{' . $p . '}'])) {
2384
+											$params['{' . $p . '}'] = '';
2385
+					}
2274 2386
 				}
2275 2387
 
2276 2388
 				$tag = $possible;
2277 2389
 
2278 2390
 				// Put the parameters into the string.
2279
-				if (isset($tag['before']))
2280
-					$tag['before'] = strtr($tag['before'], $params);
2281
-				if (isset($tag['after']))
2282
-					$tag['after'] = strtr($tag['after'], $params);
2283
-				if (isset($tag['content']))
2284
-					$tag['content'] = strtr($tag['content'], $params);
2391
+				if (isset($tag['before'])) {
2392
+									$tag['before'] = strtr($tag['before'], $params);
2393
+				}
2394
+				if (isset($tag['after'])) {
2395
+									$tag['after'] = strtr($tag['after'], $params);
2396
+				}
2397
+				if (isset($tag['content'])) {
2398
+									$tag['content'] = strtr($tag['content'], $params);
2399
+				}
2285 2400
 
2286 2401
 				$pos1 += strlen($given_param_string);
2287
-			}
2288
-			else
2402
+			} else
2289 2403
 			{
2290 2404
 				$tag = $possible;
2291 2405
 				$params = array();
@@ -2296,8 +2410,9 @@  discard block
 block discarded – undo
2296 2410
 		// Item codes are complicated buggers... they are implicit [li]s and can make [list]s!
2297 2411
 		if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li']))
2298 2412
 		{
2299
-			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))
2300
-				continue;
2413
+			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) {
2414
+							continue;
2415
+			}
2301 2416
 
2302 2417
 			$tag = $itemcodes[$message[$pos + 1]];
2303 2418
 
@@ -2318,9 +2433,9 @@  discard block
 block discarded – undo
2318 2433
 			{
2319 2434
 				array_pop($open_tags);
2320 2435
 				$code = '</li>';
2436
+			} else {
2437
+							$code = '';
2321 2438
 			}
2322
-			else
2323
-				$code = '';
2324 2439
 
2325 2440
 			// Now we open a new tag.
2326 2441
 			$open_tags[] = array(
@@ -2367,12 +2482,14 @@  discard block
 block discarded – undo
2367 2482
 		}
2368 2483
 
2369 2484
 		// No tag?  Keep looking, then.  Silly people using brackets without actual tags.
2370
-		if ($tag === null)
2371
-			continue;
2485
+		if ($tag === null) {
2486
+					continue;
2487
+		}
2372 2488
 
2373 2489
 		// Propagate the list to the child (so wrapping the disallowed tag won't work either.)
2374
-		if (isset($inside['disallow_children']))
2375
-			$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2490
+		if (isset($inside['disallow_children'])) {
2491
+					$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2492
+		}
2376 2493
 
2377 2494
 		// Is this tag disabled?
2378 2495
 		if (isset($disabled[$tag['tag']]))
@@ -2382,14 +2499,13 @@  discard block
 block discarded – undo
2382 2499
 				$tag['before'] = !empty($tag['block_level']) ? '<div>' : '';
2383 2500
 				$tag['after'] = !empty($tag['block_level']) ? '</div>' : '';
2384 2501
 				$tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1');
2385
-			}
2386
-			elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2502
+			} elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2387 2503
 			{
2388 2504
 				$tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : '');
2389 2505
 				$tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : '');
2506
+			} else {
2507
+							$tag['content'] = $tag['disabled_content'];
2390 2508
 			}
2391
-			else
2392
-				$tag['content'] = $tag['disabled_content'];
2393 2509
 		}
2394 2510
 
2395 2511
 		// we use this a lot
@@ -2399,8 +2515,9 @@  discard block
 block discarded – undo
2399 2515
 		if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level']))
2400 2516
 		{
2401 2517
 			$n = count($open_tags) - 1;
2402
-			while (empty($open_tags[$n]['block_level']) && $n >= 0)
2403
-				$n--;
2518
+			while (empty($open_tags[$n]['block_level']) && $n >= 0) {
2519
+							$n--;
2520
+			}
2404 2521
 
2405 2522
 			// Close all the non block level tags so this tag isn't surrounded by them.
2406 2523
 			for ($i = count($open_tags) - 1; $i > $n; $i--)
@@ -2412,12 +2529,15 @@  discard block
 block discarded – undo
2412 2529
 
2413 2530
 				// Trim or eat trailing stuff... see comment at the end of the big loop.
2414 2531
 				$whitespace_regex = '';
2415
-				if (!empty($tag['block_level']))
2416
-					$whitespace_regex .= '(&nbsp;|\s)*<br>';
2417
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2418
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2419
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2420
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2532
+				if (!empty($tag['block_level'])) {
2533
+									$whitespace_regex .= '(&nbsp;|\s)*<br>';
2534
+				}
2535
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2536
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2537
+				}
2538
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2539
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2540
+				}
2421 2541
 
2422 2542
 				array_pop($open_tags);
2423 2543
 			}
@@ -2435,16 +2555,19 @@  discard block
 block discarded – undo
2435 2555
 		elseif ($tag['type'] == 'unparsed_content')
2436 2556
 		{
2437 2557
 			$pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1);
2438
-			if ($pos2 === false)
2439
-				continue;
2558
+			if ($pos2 === false) {
2559
+							continue;
2560
+			}
2440 2561
 
2441 2562
 			$data = substr($message, $pos1, $pos2 - $pos1);
2442 2563
 
2443
-			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>')
2444
-				$data = substr($data, 4);
2564
+			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') {
2565
+							$data = substr($data, 4);
2566
+			}
2445 2567
 
2446
-			if (isset($tag['validate']))
2447
-				$tag['validate']($tag, $data, $disabled, $params);
2568
+			if (isset($tag['validate'])) {
2569
+							$tag['validate']($tag, $data, $disabled, $params);
2570
+			}
2448 2571
 
2449 2572
 			$code = strtr($tag['content'], array('$1' => $data));
2450 2573
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen);
@@ -2460,34 +2583,40 @@  discard block
 block discarded – undo
2460 2583
 			if (isset($tag['quoted']))
2461 2584
 			{
2462 2585
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2463
-				if ($tag['quoted'] != 'optional' && !$quoted)
2464
-					continue;
2586
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2587
+									continue;
2588
+				}
2465 2589
 
2466
-				if ($quoted)
2467
-					$pos1 += 6;
2590
+				if ($quoted) {
2591
+									$pos1 += 6;
2592
+				}
2593
+			} else {
2594
+							$quoted = false;
2468 2595
 			}
2469
-			else
2470
-				$quoted = false;
2471 2596
 
2472 2597
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2473
-			if ($pos2 === false)
2474
-				continue;
2598
+			if ($pos2 === false) {
2599
+							continue;
2600
+			}
2475 2601
 
2476 2602
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2477
-			if ($pos3 === false)
2478
-				continue;
2603
+			if ($pos3 === false) {
2604
+							continue;
2605
+			}
2479 2606
 
2480 2607
 			$data = array(
2481 2608
 				substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))),
2482 2609
 				substr($message, $pos1, $pos2 - $pos1)
2483 2610
 			);
2484 2611
 
2485
-			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>')
2486
-				$data[0] = substr($data[0], 4);
2612
+			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') {
2613
+							$data[0] = substr($data[0], 4);
2614
+			}
2487 2615
 
2488 2616
 			// Validation for my parking, please!
2489
-			if (isset($tag['validate']))
2490
-				$tag['validate']($tag, $data, $disabled, $params);
2617
+			if (isset($tag['validate'])) {
2618
+							$tag['validate']($tag, $data, $disabled, $params);
2619
+			}
2491 2620
 
2492 2621
 			$code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1]));
2493 2622
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
@@ -2504,23 +2633,27 @@  discard block
 block discarded – undo
2504 2633
 		elseif ($tag['type'] == 'unparsed_commas_content')
2505 2634
 		{
2506 2635
 			$pos2 = strpos($message, ']', $pos1);
2507
-			if ($pos2 === false)
2508
-				continue;
2636
+			if ($pos2 === false) {
2637
+							continue;
2638
+			}
2509 2639
 
2510 2640
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2511
-			if ($pos3 === false)
2512
-				continue;
2641
+			if ($pos3 === false) {
2642
+							continue;
2643
+			}
2513 2644
 
2514 2645
 			// We want $1 to be the content, and the rest to be csv.
2515 2646
 			$data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1));
2516 2647
 			$data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1);
2517 2648
 
2518
-			if (isset($tag['validate']))
2519
-				$tag['validate']($tag, $data, $disabled, $params);
2649
+			if (isset($tag['validate'])) {
2650
+							$tag['validate']($tag, $data, $disabled, $params);
2651
+			}
2520 2652
 
2521 2653
 			$code = $tag['content'];
2522
-			foreach ($data as $k => $d)
2523
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2654
+			foreach ($data as $k => $d) {
2655
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2656
+			}
2524 2657
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
2525 2658
 			$pos += strlen($code) - 1 + 2;
2526 2659
 		}
@@ -2528,24 +2661,28 @@  discard block
 block discarded – undo
2528 2661
 		elseif ($tag['type'] == 'unparsed_commas')
2529 2662
 		{
2530 2663
 			$pos2 = strpos($message, ']', $pos1);
2531
-			if ($pos2 === false)
2532
-				continue;
2664
+			if ($pos2 === false) {
2665
+							continue;
2666
+			}
2533 2667
 
2534 2668
 			$data = explode(',', substr($message, $pos1, $pos2 - $pos1));
2535 2669
 
2536
-			if (isset($tag['validate']))
2537
-				$tag['validate']($tag, $data, $disabled, $params);
2670
+			if (isset($tag['validate'])) {
2671
+							$tag['validate']($tag, $data, $disabled, $params);
2672
+			}
2538 2673
 
2539 2674
 			// Fix after, for disabled code mainly.
2540
-			foreach ($data as $k => $d)
2541
-				$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2675
+			foreach ($data as $k => $d) {
2676
+							$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2677
+			}
2542 2678
 
2543 2679
 			$open_tags[] = $tag;
2544 2680
 
2545 2681
 			// Replace them out, $1, $2, $3, $4, etc.
2546 2682
 			$code = $tag['before'];
2547
-			foreach ($data as $k => $d)
2548
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2683
+			foreach ($data as $k => $d) {
2684
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2685
+			}
2549 2686
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1);
2550 2687
 			$pos += strlen($code) - 1 + 2;
2551 2688
 		}
@@ -2556,28 +2693,33 @@  discard block
 block discarded – undo
2556 2693
 			if (isset($tag['quoted']))
2557 2694
 			{
2558 2695
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2559
-				if ($tag['quoted'] != 'optional' && !$quoted)
2560
-					continue;
2696
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2697
+									continue;
2698
+				}
2561 2699
 
2562
-				if ($quoted)
2563
-					$pos1 += 6;
2700
+				if ($quoted) {
2701
+									$pos1 += 6;
2702
+				}
2703
+			} else {
2704
+							$quoted = false;
2564 2705
 			}
2565
-			else
2566
-				$quoted = false;
2567 2706
 
2568 2707
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2569
-			if ($pos2 === false)
2570
-				continue;
2708
+			if ($pos2 === false) {
2709
+							continue;
2710
+			}
2571 2711
 
2572 2712
 			$data = substr($message, $pos1, $pos2 - $pos1);
2573 2713
 
2574 2714
 			// Validation for my parking, please!
2575
-			if (isset($tag['validate']))
2576
-				$tag['validate']($tag, $data, $disabled, $params);
2715
+			if (isset($tag['validate'])) {
2716
+							$tag['validate']($tag, $data, $disabled, $params);
2717
+			}
2577 2718
 
2578 2719
 			// For parsed content, we must recurse to avoid security problems.
2579
-			if ($tag['type'] != 'unparsed_equals')
2580
-				$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2720
+			if ($tag['type'] != 'unparsed_equals') {
2721
+							$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2722
+			}
2581 2723
 
2582 2724
 			$tag['after'] = strtr($tag['after'], array('$1' => $data));
2583 2725
 
@@ -2589,34 +2731,40 @@  discard block
 block discarded – undo
2589 2731
 		}
2590 2732
 
2591 2733
 		// If this is block level, eat any breaks after it.
2592
-		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>')
2593
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2734
+		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') {
2735
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2736
+		}
2594 2737
 
2595 2738
 		// Are we trimming outside this tag?
2596
-		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0)
2597
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2739
+		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0) {
2740
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2741
+		}
2598 2742
 	}
2599 2743
 
2600 2744
 	// Close any remaining tags.
2601
-	while ($tag = array_pop($open_tags))
2602
-		$message .= "\n" . $tag['after'] . "\n";
2745
+	while ($tag = array_pop($open_tags)) {
2746
+			$message .= "\n" . $tag['after'] . "\n";
2747
+	}
2603 2748
 
2604 2749
 	// Parse the smileys within the parts where it can be done safely.
2605 2750
 	if ($smileys === true)
2606 2751
 	{
2607 2752
 		$message_parts = explode("\n", $message);
2608
-		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2)
2609
-			parsesmileys($message_parts[$i]);
2753
+		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) {
2754
+					parsesmileys($message_parts[$i]);
2755
+		}
2610 2756
 
2611 2757
 		$message = implode('', $message_parts);
2612 2758
 	}
2613 2759
 
2614 2760
 	// No smileys, just get rid of the markers.
2615
-	else
2616
-		$message = strtr($message, array("\n" => ''));
2761
+	else {
2762
+			$message = strtr($message, array("\n" => ''));
2763
+	}
2617 2764
 
2618
-	if ($message !== '' && $message[0] === ' ')
2619
-		$message = '&nbsp;' . substr($message, 1);
2765
+	if ($message !== '' && $message[0] === ' ') {
2766
+			$message = '&nbsp;' . substr($message, 1);
2767
+	}
2620 2768
 
2621 2769
 	// Cleanup whitespace.
2622 2770
 	$message = strtr($message, array('  ' => ' &nbsp;', "\r" => '', "\n" => '<br>', '<br> ' => '<br>&nbsp;', '&#13;' => "\n"));
@@ -2625,15 +2773,16 @@  discard block
 block discarded – undo
2625 2773
 	call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
2626 2774
 
2627 2775
 	// Cache the output if it took some time...
2628
-	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05)
2629
-		cache_put_data($cache_key, $message, 240);
2776
+	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) {
2777
+			cache_put_data($cache_key, $message, 240);
2778
+	}
2630 2779
 
2631 2780
 	// If this was a force parse revert if needed.
2632 2781
 	if (!empty($parse_tags))
2633 2782
 	{
2634
-		if (empty($temp_bbc))
2635
-			$bbc_codes = array();
2636
-		else
2783
+		if (empty($temp_bbc)) {
2784
+					$bbc_codes = array();
2785
+		} else
2637 2786
 		{
2638 2787
 			$bbc_codes = $temp_bbc;
2639 2788
 			unset($temp_bbc);
@@ -2660,8 +2809,9 @@  discard block
 block discarded – undo
2660 2809
 	static $smileyPregSearch = null, $smileyPregReplacements = array();
2661 2810
 
2662 2811
 	// No smiley set at all?!
2663
-	if ($user_info['smiley_set'] == 'none' || trim($message) == '')
2664
-		return;
2812
+	if ($user_info['smiley_set'] == 'none' || trim($message) == '') {
2813
+			return;
2814
+	}
2665 2815
 
2666 2816
 	// If smileyPregSearch hasn't been set, do it now.
2667 2817
 	if (empty($smileyPregSearch))
@@ -2672,8 +2822,7 @@  discard block
 block discarded – undo
2672 2822
 			$smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)');
2673 2823
 			$smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif');
2674 2824
 			$smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', '');
2675
-		}
2676
-		else
2825
+		} else
2677 2826
 		{
2678 2827
 			// Load the smileys in reverse order by length so they don't get parsed wrong.
2679 2828
 			if (($temp = cache_get_data('parsing_smileys', 480)) == null)
@@ -2697,9 +2846,9 @@  discard block
 block discarded – undo
2697 2846
 				$smcFunc['db_free_result']($result);
2698 2847
 
2699 2848
 				cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480);
2849
+			} else {
2850
+							list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2700 2851
 			}
2701
-			else
2702
-				list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2703 2852
 		}
2704 2853
 
2705 2854
 		// The non-breaking-space is a complex thing...
@@ -2776,35 +2925,41 @@  discard block
 block discarded – undo
2776 2925
 	global $scripturl, $context, $modSettings, $db_show_debug, $db_cache;
2777 2926
 
2778 2927
 	// In case we have mail to send, better do that - as obExit doesn't always quite make it...
2779
-	if (!empty($context['flush_mail']))
2780
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2928
+	if (!empty($context['flush_mail'])) {
2929
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2781 2930
 		AddMailQueue(true);
2931
+	}
2782 2932
 
2783 2933
 	$add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:';
2784 2934
 
2785
-	if ($add)
2786
-		$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
2935
+	if ($add) {
2936
+			$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
2937
+	}
2787 2938
 
2788 2939
 	// Put the session ID in.
2789
-	if (defined('SID') && SID != '')
2790
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
2940
+	if (defined('SID') && SID != '') {
2941
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
2942
+	}
2791 2943
 	// Keep that debug in their for template debugging!
2792
-	elseif (isset($_GET['debug']))
2793
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
2944
+	elseif (isset($_GET['debug'])) {
2945
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
2946
+	}
2794 2947
 
2795 2948
 	if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed'])))
2796 2949
 	{
2797
-		if (defined('SID') && SID != '')
2798
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2950
+		if (defined('SID') && SID != '') {
2951
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2799 2952
 				function ($m) use ($scripturl)
2800 2953
 				{
2801 2954
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
2955
+		}
2802 2956
 				}, $setLocation);
2803
-		else
2804
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2957
+		else {
2958
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2805 2959
 				function ($m) use ($scripturl)
2806 2960
 				{
2807 2961
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
2962
+		}
2808 2963
 				}, $setLocation);
2809 2964
 	}
2810 2965
 
@@ -2815,8 +2970,9 @@  discard block
 block discarded – undo
2815 2970
 	header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302);
2816 2971
 
2817 2972
 	// Debugging.
2818
-	if (isset($db_show_debug) && $db_show_debug === true)
2819
-		$_SESSION['debug_redirect'] = $db_cache;
2973
+	if (isset($db_show_debug) && $db_show_debug === true) {
2974
+			$_SESSION['debug_redirect'] = $db_cache;
2975
+	}
2820 2976
 
2821 2977
 	obExit(false);
2822 2978
 }
@@ -2835,51 +2991,60 @@  discard block
 block discarded – undo
2835 2991
 
2836 2992
 	// Attempt to prevent a recursive loop.
2837 2993
 	++$level;
2838
-	if ($level > 1 && !$from_fatal_error && !$has_fatal_error)
2839
-		exit;
2840
-	if ($from_fatal_error)
2841
-		$has_fatal_error = true;
2994
+	if ($level > 1 && !$from_fatal_error && !$has_fatal_error) {
2995
+			exit;
2996
+	}
2997
+	if ($from_fatal_error) {
2998
+			$has_fatal_error = true;
2999
+	}
2842 3000
 
2843 3001
 	// Clear out the stat cache.
2844 3002
 	trackStats();
2845 3003
 
2846 3004
 	// If we have mail to send, send it.
2847
-	if (!empty($context['flush_mail']))
2848
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3005
+	if (!empty($context['flush_mail'])) {
3006
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2849 3007
 		AddMailQueue(true);
3008
+	}
2850 3009
 
2851 3010
 	$do_header = $header === null ? !$header_done : $header;
2852
-	if ($do_footer === null)
2853
-		$do_footer = $do_header;
3011
+	if ($do_footer === null) {
3012
+			$do_footer = $do_header;
3013
+	}
2854 3014
 
2855 3015
 	// Has the template/header been done yet?
2856 3016
 	if ($do_header)
2857 3017
 	{
2858 3018
 		// Was the page title set last minute? Also update the HTML safe one.
2859
-		if (!empty($context['page_title']) && empty($context['page_title_html_safe']))
2860
-			$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3019
+		if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) {
3020
+					$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3021
+		}
2861 3022
 
2862 3023
 		// Start up the session URL fixer.
2863 3024
 		ob_start('ob_sessrewrite');
2864 3025
 
2865
-		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers']))
2866
-			$buffers = explode(',', $settings['output_buffers']);
2867
-		elseif (!empty($settings['output_buffers']))
2868
-			$buffers = $settings['output_buffers'];
2869
-		else
2870
-			$buffers = array();
3026
+		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) {
3027
+					$buffers = explode(',', $settings['output_buffers']);
3028
+		} elseif (!empty($settings['output_buffers'])) {
3029
+					$buffers = $settings['output_buffers'];
3030
+		} else {
3031
+					$buffers = array();
3032
+		}
2871 3033
 
2872
-		if (isset($modSettings['integrate_buffer']))
2873
-			$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3034
+		if (isset($modSettings['integrate_buffer'])) {
3035
+					$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3036
+		}
2874 3037
 
2875
-		if (!empty($buffers))
2876
-			foreach ($buffers as $function)
3038
+		if (!empty($buffers)) {
3039
+					foreach ($buffers as $function)
2877 3040
 			{
2878 3041
 				$call = call_helper($function, true);
3042
+		}
2879 3043
 
2880 3044
 				// Is it valid?
2881
-				if (!empty($call))
2882
-					ob_start($call);
3045
+				if (!empty($call)) {
3046
+									ob_start($call);
3047
+				}
2883 3048
 			}
2884 3049
 
2885 3050
 		// Display the screen in the logical order.
@@ -2891,8 +3056,9 @@  discard block
 block discarded – undo
2891 3056
 		loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main');
2892 3057
 
2893 3058
 		// Anything special to put out?
2894
-		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml']))
2895
-			echo $context['insert_after_template'];
3059
+		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) {
3060
+					echo $context['insert_after_template'];
3061
+		}
2896 3062
 
2897 3063
 		// Just so we don't get caught in an endless loop of errors from the footer...
2898 3064
 		if (!$footer_done)
@@ -2901,14 +3067,16 @@  discard block
 block discarded – undo
2901 3067
 			template_footer();
2902 3068
 
2903 3069
 			// (since this is just debugging... it's okay that it's after </html>.)
2904
-			if (!isset($_REQUEST['xml']))
2905
-				displayDebug();
3070
+			if (!isset($_REQUEST['xml'])) {
3071
+							displayDebug();
3072
+			}
2906 3073
 		}
2907 3074
 	}
2908 3075
 
2909 3076
 	// Remember this URL in case someone doesn't like sending HTTP_REFERER.
2910
-	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
2911
-		$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3077
+	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) {
3078
+			$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3079
+	}
2912 3080
 
2913 3081
 	// For session check verification.... don't switch browsers...
2914 3082
 	$_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT'];
@@ -2917,9 +3085,10 @@  discard block
 block discarded – undo
2917 3085
 	call_integration_hook('integrate_exit', array($do_footer));
2918 3086
 
2919 3087
 	// Don't exit if we're coming from index.php; that will pass through normally.
2920
-	if (!$from_index)
2921
-		exit;
2922
-}
3088
+	if (!$from_index) {
3089
+			exit;
3090
+	}
3091
+	}
2923 3092
 
2924 3093
 /**
2925 3094
  * Get the size of a specified image with better error handling.
@@ -2938,8 +3107,9 @@  discard block
 block discarded – undo
2938 3107
 	$url = str_replace(' ', '%20', $url);
2939 3108
 
2940 3109
 	// Can we pull this from the cache... please please?
2941
-	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null)
2942
-		return $temp;
3110
+	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) {
3111
+			return $temp;
3112
+	}
2943 3113
 	$t = microtime();
2944 3114
 
2945 3115
 	// Get the host to pester...
@@ -2949,12 +3119,10 @@  discard block
 block discarded – undo
2949 3119
 	if ($url == '' || $url == 'http://' || $url == 'https://')
2950 3120
 	{
2951 3121
 		return false;
2952
-	}
2953
-	elseif (!isset($match[1]))
3122
+	} elseif (!isset($match[1]))
2954 3123
 	{
2955 3124
 		$size = @getimagesize($url);
2956
-	}
2957
-	else
3125
+	} else
2958 3126
 	{
2959 3127
 		// Try to connect to the server... give it half a second.
2960 3128
 		$temp = 0;
@@ -2993,12 +3161,14 @@  discard block
 block discarded – undo
2993 3161
 	}
2994 3162
 
2995 3163
 	// If we didn't get it, we failed.
2996
-	if (!isset($size))
2997
-		$size = false;
3164
+	if (!isset($size)) {
3165
+			$size = false;
3166
+	}
2998 3167
 
2999 3168
 	// If this took a long time, we may never have to do it again, but then again we might...
3000
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8)
3001
-		cache_put_data('url_image_size-' . md5($url), $size, 240);
3169
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) {
3170
+			cache_put_data('url_image_size-' . md5($url), $size, 240);
3171
+	}
3002 3172
 
3003 3173
 	// Didn't work.
3004 3174
 	return $size;
@@ -3016,8 +3186,9 @@  discard block
 block discarded – undo
3016 3186
 
3017 3187
 	// Under SSI this function can be called more then once.  That can cause some problems.
3018 3188
 	//   So only run the function once unless we are forced to run it again.
3019
-	if ($loaded && !$forceload)
3020
-		return;
3189
+	if ($loaded && !$forceload) {
3190
+			return;
3191
+	}
3021 3192
 
3022 3193
 	$loaded = true;
3023 3194
 
@@ -3029,14 +3200,16 @@  discard block
 block discarded – undo
3029 3200
 	$context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news'])))));
3030 3201
 	for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++)
3031 3202
 	{
3032
-		if (trim($context['news_lines'][$i]) == '')
3033
-			continue;
3203
+		if (trim($context['news_lines'][$i]) == '') {
3204
+					continue;
3205
+		}
3034 3206
 
3035 3207
 		// Clean it up for presentation ;).
3036 3208
 		$context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i);
3037 3209
 	}
3038
-	if (!empty($context['news_lines']))
3039
-		$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3210
+	if (!empty($context['news_lines'])) {
3211
+			$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3212
+	}
3040 3213
 
3041 3214
 	if (!$user_info['is_guest'])
3042 3215
 	{
@@ -3045,40 +3218,48 @@  discard block
 block discarded – undo
3045 3218
 		$context['user']['alerts'] = &$user_info['alerts'];
3046 3219
 
3047 3220
 		// Personal message popup...
3048
-		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0))
3049
-			$context['user']['popup_messages'] = true;
3050
-		else
3051
-			$context['user']['popup_messages'] = false;
3221
+		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) {
3222
+					$context['user']['popup_messages'] = true;
3223
+		} else {
3224
+					$context['user']['popup_messages'] = false;
3225
+		}
3052 3226
 		$_SESSION['unread_messages'] = $user_info['unread_messages'];
3053 3227
 
3054
-		if (allowedTo('moderate_forum'))
3055
-			$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3228
+		if (allowedTo('moderate_forum')) {
3229
+					$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3230
+		}
3056 3231
 
3057 3232
 		$context['user']['avatar'] = array();
3058 3233
 
3059 3234
 		// Check for gravatar first since we might be forcing them...
3060 3235
 		if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride']))
3061 3236
 		{
3062
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11)
3063
-				$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3064
-			else
3065
-				$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3237
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) {
3238
+							$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3239
+			} else {
3240
+							$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3241
+			}
3066 3242
 		}
3067 3243
 		// Uploaded?
3068
-		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach']))
3069
-			$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3244
+		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) {
3245
+					$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3246
+		}
3070 3247
 		// Full URL?
3071
-		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0)
3072
-			$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3248
+		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) {
3249
+					$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3250
+		}
3073 3251
 		// Otherwise we assume it's server stored.
3074
-		elseif ($user_info['avatar']['url'] != '')
3075
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3252
+		elseif ($user_info['avatar']['url'] != '') {
3253
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3254
+		}
3076 3255
 		// No avatar at all? Fine, we have a big fat default avatar ;)
3077
-		else
3078
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3256
+		else {
3257
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3258
+		}
3079 3259
 
3080
-		if (!empty($context['user']['avatar']))
3081
-			$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3260
+		if (!empty($context['user']['avatar'])) {
3261
+					$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3262
+		}
3082 3263
 
3083 3264
 		// Figure out how long they've been logged in.
3084 3265
 		$context['user']['total_time_logged_in'] = array(
@@ -3086,8 +3267,7 @@  discard block
 block discarded – undo
3086 3267
 			'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600),
3087 3268
 			'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60)
3088 3269
 		);
3089
-	}
3090
-	else
3270
+	} else
3091 3271
 	{
3092 3272
 		$context['user']['messages'] = 0;
3093 3273
 		$context['user']['unread_messages'] = 0;
@@ -3095,12 +3275,14 @@  discard block
 block discarded – undo
3095 3275
 		$context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0);
3096 3276
 		$context['user']['popup_messages'] = false;
3097 3277
 
3098
-		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1)
3099
-			$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3278
+		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) {
3279
+					$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3280
+		}
3100 3281
 
3101 3282
 		// If we've upgraded recently, go easy on the passwords.
3102
-		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime']))
3103
-			$context['disable_login_hashing'] = true;
3283
+		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) {
3284
+					$context['disable_login_hashing'] = true;
3285
+		}
3104 3286
 	}
3105 3287
 
3106 3288
 	// Setup the main menu items.
@@ -3113,8 +3295,8 @@  discard block
 block discarded – undo
3113 3295
 	$context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm');
3114 3296
 
3115 3297
 	// 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array.
3116
-	if ($context['show_pm_popup'])
3117
-		addInlineJavaScript('
3298
+	if ($context['show_pm_popup']) {
3299
+			addInlineJavaScript('
3118 3300
 		jQuery(document).ready(function($) {
3119 3301
 			new smc_Popup({
3120 3302
 				heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ',
@@ -3122,15 +3304,17 @@  discard block
 block discarded – undo
3122 3304
 				icon_class: \'generic_icons mail_new\'
3123 3305
 			});
3124 3306
 		});');
3307
+	}
3125 3308
 
3126 3309
 	// Add a generic "Are you sure?" confirmation message.
3127 3310
 	addInlineJavaScript('
3128 3311
 	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3129 3312
 
3130 3313
 	// Now add the capping code for avatars.
3131
-	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
3132
-		addInlineCss('
3314
+	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') {
3315
+			addInlineCss('
3133 3316
 img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }');
3317
+	}
3134 3318
 
3135 3319
 	// This looks weird, but it's because BoardIndex.php references the variable.
3136 3320
 	$context['common_stats']['latest_member'] = array(
@@ -3147,11 +3331,13 @@  discard block
 block discarded – undo
3147 3331
 	);
3148 3332
 	$context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']);
3149 3333
 
3150
-	if (empty($settings['theme_version']))
3151
-		addJavaScriptVar('smf_scripturl', $scripturl);
3334
+	if (empty($settings['theme_version'])) {
3335
+			addJavaScriptVar('smf_scripturl', $scripturl);
3336
+	}
3152 3337
 
3153
-	if (!isset($context['page_title']))
3154
-		$context['page_title'] = '';
3338
+	if (!isset($context['page_title'])) {
3339
+			$context['page_title'] = '';
3340
+	}
3155 3341
 
3156 3342
 	// Set some specific vars.
3157 3343
 	$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
@@ -3161,21 +3347,23 @@  discard block
 block discarded – undo
3161 3347
 	$context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']);
3162 3348
 	$context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']);
3163 3349
 
3164
-	if (!empty($context['meta_keywords']))
3165
-		$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3350
+	if (!empty($context['meta_keywords'])) {
3351
+			$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3352
+	}
3166 3353
 
3167
-	if (!empty($context['canonical_url']))
3168
-		$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3354
+	if (!empty($context['canonical_url'])) {
3355
+			$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3356
+	}
3169 3357
 
3170
-	if (!empty($settings['og_image']))
3171
-		$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3358
+	if (!empty($settings['og_image'])) {
3359
+			$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3360
+	}
3172 3361
 
3173 3362
 	if (!empty($context['meta_description']))
3174 3363
 	{
3175 3364
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']);
3176 3365
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']);
3177
-	}
3178
-	else
3366
+	} else
3179 3367
 	{
3180 3368
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']);
3181 3369
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']);
@@ -3200,8 +3388,9 @@  discard block
 block discarded – undo
3200 3388
 	$memory_needed = memoryReturnBytes($needed);
3201 3389
 
3202 3390
 	// should we account for how much is currently being used?
3203
-	if ($in_use)
3204
-		$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3391
+	if ($in_use) {
3392
+			$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3393
+	}
3205 3394
 
3206 3395
 	// if more is needed, request it
3207 3396
 	if ($memory_current < $memory_needed)
@@ -3224,8 +3413,9 @@  discard block
 block discarded – undo
3224 3413
  */
3225 3414
 function memoryReturnBytes($val)
3226 3415
 {
3227
-	if (is_integer($val))
3228
-		return $val;
3416
+	if (is_integer($val)) {
3417
+			return $val;
3418
+	}
3229 3419
 
3230 3420
 	// Separate the number from the designator
3231 3421
 	$val = trim($val);
@@ -3261,10 +3451,11 @@  discard block
 block discarded – undo
3261 3451
 		header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
3262 3452
 
3263 3453
 		// Are we debugging the template/html content?
3264
-		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie'))
3265
-			header('Content-Type: application/xhtml+xml');
3266
-		elseif (!isset($_REQUEST['xml']))
3267
-			header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3454
+		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) {
3455
+					header('Content-Type: application/xhtml+xml');
3456
+		} elseif (!isset($_REQUEST['xml'])) {
3457
+					header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3458
+		}
3268 3459
 	}
3269 3460
 
3270 3461
 	header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
@@ -3273,8 +3464,9 @@  discard block
 block discarded – undo
3273 3464
 	if ($context['in_maintenance'] && $context['user']['is_admin'])
3274 3465
 	{
3275 3466
 		$position = array_search('body', $context['template_layers']);
3276
-		if ($position === false)
3277
-			$position = array_search('main', $context['template_layers']);
3467
+		if ($position === false) {
3468
+					$position = array_search('main', $context['template_layers']);
3469
+		}
3278 3470
 
3279 3471
 		if ($position !== false)
3280 3472
 		{
@@ -3302,23 +3494,25 @@  discard block
 block discarded – undo
3302 3494
 
3303 3495
 			foreach ($securityFiles as $i => $securityFile)
3304 3496
 			{
3305
-				if (!file_exists($boarddir . '/' . $securityFile))
3306
-					unset($securityFiles[$i]);
3497
+				if (!file_exists($boarddir . '/' . $securityFile)) {
3498
+									unset($securityFiles[$i]);
3499
+				}
3307 3500
 			}
3308 3501
 
3309 3502
 			// We are already checking so many files...just few more doesn't make any difference! :P
3310
-			if (!empty($modSettings['currentAttachmentUploadDir']))
3311
-				$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3312
-
3313
-			else
3314
-				$path = $modSettings['attachmentUploadDir'];
3503
+			if (!empty($modSettings['currentAttachmentUploadDir'])) {
3504
+							$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3505
+			} else {
3506
+							$path = $modSettings['attachmentUploadDir'];
3507
+			}
3315 3508
 
3316 3509
 			secureDirectory($path, true);
3317 3510
 			secureDirectory($cachedir);
3318 3511
 
3319 3512
 			// If agreement is enabled, at least the english version shall exists
3320
-			if ($modSettings['requireAgreement'])
3321
-				$agreement = !file_exists($boarddir . '/agreement.txt');
3513
+			if ($modSettings['requireAgreement']) {
3514
+							$agreement = !file_exists($boarddir . '/agreement.txt');
3515
+			}
3322 3516
 
3323 3517
 			if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement))
3324 3518
 			{
@@ -3333,18 +3527,21 @@  discard block
 block discarded – undo
3333 3527
 					echo '
3334 3528
 				', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>';
3335 3529
 
3336
-					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~')
3337
-						echo '
3530
+					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') {
3531
+											echo '
3338 3532
 				', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>';
3533
+					}
3339 3534
 				}
3340 3535
 
3341
-				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir))
3342
-					echo '
3536
+				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) {
3537
+									echo '
3343 3538
 				<strong>', $txt['cache_writable'], '</strong><br>';
3539
+				}
3344 3540
 
3345
-				if (!empty($agreement))
3346
-					echo '
3541
+				if (!empty($agreement)) {
3542
+									echo '
3347 3543
 				<strong>', $txt['agreement_missing'], '</strong><br>';
3544
+				}
3348 3545
 
3349 3546
 				echo '
3350 3547
 			</p>
@@ -3359,16 +3556,18 @@  discard block
 block discarded – undo
3359 3556
 				<div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;">
3360 3557
 					', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']);
3361 3558
 
3362
-			if (!empty($_SESSION['ban']['cannot_post']['reason']))
3363
-				echo '
3559
+			if (!empty($_SESSION['ban']['cannot_post']['reason'])) {
3560
+							echo '
3364 3561
 					<div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>';
3562
+			}
3365 3563
 
3366
-			if (!empty($_SESSION['ban']['expire_time']))
3367
-				echo '
3564
+			if (!empty($_SESSION['ban']['expire_time'])) {
3565
+							echo '
3368 3566
 					<div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>';
3369
-			else
3370
-				echo '
3567
+			} else {
3568
+							echo '
3371 3569
 					<div>', $txt['your_ban_expires_never'], '</div>';
3570
+			}
3372 3571
 
3373 3572
 			echo '
3374 3573
 				</div>';
@@ -3384,8 +3583,9 @@  discard block
 block discarded – undo
3384 3583
 	global $forum_copyright, $software_year, $forum_version;
3385 3584
 
3386 3585
 	// Don't display copyright for things like SSI.
3387
-	if (!isset($forum_version) || !isset($software_year))
3388
-		return;
3586
+	if (!isset($forum_version) || !isset($software_year)) {
3587
+			return;
3588
+	}
3389 3589
 
3390 3590
 	// Put in the version...
3391 3591
 	printf($forum_copyright, $forum_version, $software_year);
@@ -3403,9 +3603,10 @@  discard block
 block discarded – undo
3403 3603
 	$context['load_time'] = comma_format(round(array_sum(explode(' ', microtime())) - array_sum(explode(' ', $time_start)), 3));
3404 3604
 	$context['load_queries'] = $db_count;
3405 3605
 
3406
-	foreach (array_reverse($context['template_layers']) as $layer)
3407
-		loadSubTemplate($layer . '_below', true);
3408
-}
3606
+	foreach (array_reverse($context['template_layers']) as $layer) {
3607
+			loadSubTemplate($layer . '_below', true);
3608
+	}
3609
+	}
3409 3610
 
3410 3611
 /**
3411 3612
  * Output the Javascript files
@@ -3436,8 +3637,7 @@  discard block
 block discarded – undo
3436 3637
 			{
3437 3638
 				echo '
3438 3639
 		var ', $key, ';';
3439
-			}
3440
-			else
3640
+			} else
3441 3641
 			{
3442 3642
 				echo '
3443 3643
 		var ', $key, ' = ', $value, ';';
@@ -3452,26 +3652,27 @@  discard block
 block discarded – undo
3452 3652
 	foreach ($context['javascript_files'] as $id => $js_file)
3453 3653
 	{
3454 3654
 		// Last minute call! allow theme authors to disable single files.
3455
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3456
-			continue;
3655
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3656
+					continue;
3657
+		}
3457 3658
 
3458 3659
 		// By default all files don't get minimized unless the file explicitly says so!
3459 3660
 		if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files']))
3460 3661
 		{
3461
-			if ($do_deferred && !empty($js_file['options']['defer']))
3462
-				$toMinifyDefer[] = $js_file;
3463
-
3464
-			elseif (!$do_deferred && empty($js_file['options']['defer']))
3465
-				$toMinify[] = $js_file;
3662
+			if ($do_deferred && !empty($js_file['options']['defer'])) {
3663
+							$toMinifyDefer[] = $js_file;
3664
+			} elseif (!$do_deferred && empty($js_file['options']['defer'])) {
3665
+							$toMinify[] = $js_file;
3666
+			}
3466 3667
 
3467 3668
 			// Grab a random seed.
3468
-			if (!isset($minSeed))
3469
-				$minSeed = $js_file['options']['seed'];
3470
-		}
3471
-
3472
-		elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer'])))
3473
-			echo '
3669
+			if (!isset($minSeed)) {
3670
+							$minSeed = $js_file['options']['seed'];
3671
+			}
3672
+		} elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) {
3673
+					echo '
3474 3674
 	<script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>';
3675
+		}
3475 3676
 	}
3476 3677
 
3477 3678
 	if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer)))
@@ -3479,14 +3680,14 @@  discard block
 block discarded – undo
3479 3680
 		$result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred);
3480 3681
 
3481 3682
 		// Minify process couldn't work, print each individual files.
3482
-		if (!empty($result) && is_array($result))
3483
-			foreach ($result as $minFailedFile)
3683
+		if (!empty($result) && is_array($result)) {
3684
+					foreach ($result as $minFailedFile)
3484 3685
 				echo '
3485 3686
 	<script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>';
3486
-
3487
-		else
3488
-			echo '
3687
+		} else {
3688
+					echo '
3489 3689
 	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3690
+		}
3490 3691
 	}
3491 3692
 
3492 3693
 	// Inline JavaScript - Actually useful some times!
@@ -3497,8 +3698,9 @@  discard block
 block discarded – undo
3497 3698
 			echo '
3498 3699
 <script>';
3499 3700
 
3500
-			foreach ($context['javascript_inline']['defer'] as $js_code)
3501
-				echo $js_code;
3701
+			foreach ($context['javascript_inline']['defer'] as $js_code) {
3702
+							echo $js_code;
3703
+			}
3502 3704
 
3503 3705
 			echo '
3504 3706
 </script>';
@@ -3509,8 +3711,9 @@  discard block
 block discarded – undo
3509 3711
 			echo '
3510 3712
 	<script>';
3511 3713
 
3512
-			foreach ($context['javascript_inline']['standard'] as $js_code)
3513
-				echo $js_code;
3714
+			foreach ($context['javascript_inline']['standard'] as $js_code) {
3715
+							echo $js_code;
3716
+			}
3514 3717
 
3515 3718
 			echo '
3516 3719
 	</script>';
@@ -3535,8 +3738,9 @@  discard block
 block discarded – undo
3535 3738
 	foreach ($context['css_files'] as $id => $file)
3536 3739
 	{
3537 3740
 		// Last minute call! allow theme authors to disable single files.
3538
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3539
-			continue;
3741
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3742
+					continue;
3743
+		}
3540 3744
 
3541 3745
 		// By default all files don't get minimized unless the file explicitly says so!
3542 3746
 		if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files']))
@@ -3544,12 +3748,12 @@  discard block
 block discarded – undo
3544 3748
 			$toMinify[] = $file;
3545 3749
 
3546 3750
 			// Grab a random seed.
3547
-			if (!isset($minSeed))
3548
-				$minSeed = $file['options']['seed'];
3751
+			if (!isset($minSeed)) {
3752
+							$minSeed = $file['options']['seed'];
3753
+			}
3754
+		} else {
3755
+					$normal[] = $file['fileUrl'];
3549 3756
 		}
3550
-
3551
-		else
3552
-			$normal[] = $file['fileUrl'];
3553 3757
 	}
3554 3758
 
3555 3759
 	if (!empty($toMinify))
@@ -3557,28 +3761,30 @@  discard block
 block discarded – undo
3557 3761
 		$result = custMinify($toMinify, 'css');
3558 3762
 
3559 3763
 		// Minify process couldn't work, print each individual files.
3560
-		if (!empty($result) && is_array($result))
3561
-			foreach ($result as $minFailedFile)
3764
+		if (!empty($result) && is_array($result)) {
3765
+					foreach ($result as $minFailedFile)
3562 3766
 				echo '
3563 3767
 	<link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">';
3564
-
3565
-		else
3566
-			echo '
3768
+		} else {
3769
+					echo '
3567 3770
 	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3771
+		}
3568 3772
 	}
3569 3773
 
3570 3774
 	// Print the rest after the minified files.
3571
-	if (!empty($normal))
3572
-		foreach ($normal as $nf)
3775
+	if (!empty($normal)) {
3776
+			foreach ($normal as $nf)
3573 3777
 			echo '
3574 3778
 	<link rel="stylesheet" href="', $nf ,'">';
3779
+	}
3575 3780
 
3576 3781
 	if ($db_show_debug === true)
3577 3782
 	{
3578 3783
 		// Try to keep only what's useful.
3579 3784
 		$repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => '');
3580
-		foreach ($context['css_files'] as $file)
3581
-			$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3785
+		foreach ($context['css_files'] as $file) {
3786
+					$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3787
+		}
3582 3788
 	}
3583 3789
 
3584 3790
 	if (!empty($context['css_header']))
@@ -3586,9 +3792,10 @@  discard block
 block discarded – undo
3586 3792
 		echo '
3587 3793
 	<style>';
3588 3794
 
3589
-		foreach ($context['css_header'] as $css)
3590
-			echo $css .'
3795
+		foreach ($context['css_header'] as $css) {
3796
+					echo $css .'
3591 3797
 	';
3798
+		}
3592 3799
 
3593 3800
 		echo'
3594 3801
 	</style>';
@@ -3612,15 +3819,17 @@  discard block
 block discarded – undo
3612 3819
 	$type = !empty($type) && in_array($type, $types) ? $type : false;
3613 3820
 	$data = !empty($data) ? $data : false;
3614 3821
 
3615
-	if (empty($type) || empty($data))
3616
-		return false;
3822
+	if (empty($type) || empty($data)) {
3823
+			return false;
3824
+	}
3617 3825
 
3618 3826
 	// Did we already did this?
3619 3827
 	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3620 3828
 
3621 3829
 	// Already done?
3622
-	if (!empty($toCache))
3623
-		return true;
3830
+	if (!empty($toCache)) {
3831
+			return true;
3832
+	}
3624 3833
 
3625 3834
 	// No namespaces, sorry!
3626 3835
 	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
@@ -3702,8 +3911,9 @@  discard block
 block discarded – undo
3702 3911
 	global $modSettings, $smcFunc;
3703 3912
 
3704 3913
 	// Just make up a nice hash...
3705
-	if ($new)
3706
-		return sha1(md5($filename . time()) . mt_rand());
3914
+	if ($new) {
3915
+			return sha1(md5($filename . time()) . mt_rand());
3916
+	}
3707 3917
 
3708 3918
 	// Just make sure that attachment id is only a int
3709 3919
 	$attachment_id = (int) $attachment_id;
@@ -3720,23 +3930,25 @@  discard block
 block discarded – undo
3720 3930
 				'id_attach' => $attachment_id,
3721 3931
 			));
3722 3932
 
3723
-		if ($smcFunc['db_num_rows']($request) === 0)
3724
-			return false;
3933
+		if ($smcFunc['db_num_rows']($request) === 0) {
3934
+					return false;
3935
+		}
3725 3936
 
3726 3937
 		list ($file_hash) = $smcFunc['db_fetch_row']($request);
3727 3938
 		$smcFunc['db_free_result']($request);
3728 3939
 	}
3729 3940
 
3730 3941
 	// Still no hash? mmm...
3731
-	if (empty($file_hash))
3732
-		$file_hash = sha1(md5($filename . time()) . mt_rand());
3942
+	if (empty($file_hash)) {
3943
+			$file_hash = sha1(md5($filename . time()) . mt_rand());
3944
+	}
3733 3945
 
3734 3946
 	// Are we using multiple directories?
3735
-	if (is_array($modSettings['attachmentUploadDir']))
3736
-		$path = $modSettings['attachmentUploadDir'][$dir];
3737
-
3738
-	else
3739
-		$path = $modSettings['attachmentUploadDir'];
3947
+	if (is_array($modSettings['attachmentUploadDir'])) {
3948
+			$path = $modSettings['attachmentUploadDir'][$dir];
3949
+	} else {
3950
+			$path = $modSettings['attachmentUploadDir'];
3951
+	}
3740 3952
 
3741 3953
 	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3742 3954
 }
@@ -3751,8 +3963,9 @@  discard block
 block discarded – undo
3751 3963
 function ip2range($fullip)
3752 3964
 {
3753 3965
 	// Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.)
3754
-	if ($fullip == 'unknown')
3755
-		$fullip = '255.255.255.255';
3966
+	if ($fullip == 'unknown') {
3967
+			$fullip = '255.255.255.255';
3968
+	}
3756 3969
 
3757 3970
 	$ip_parts = explode('-', $fullip);
3758 3971
 	$ip_array = array();
@@ -3776,10 +3989,11 @@  discard block
 block discarded – undo
3776 3989
 		$ip_array['low'] = $ip_parts[0];
3777 3990
 		$ip_array['high'] = $ip_parts[1];
3778 3991
 		return $ip_array;
3779
-	}
3780
-	elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.*
3992
+	} elseif (count($ip_parts) == 2) {
3993
+		// if ip 22.22.*-22.22.*
3781 3994
 	{
3782 3995
 		$valid_low = isValidIP($ip_parts[0]);
3996
+	}
3783 3997
 		$valid_high = isValidIP($ip_parts[1]);
3784 3998
 		$count = 0;
3785 3999
 		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
@@ -3794,7 +4008,9 @@  discard block
 block discarded – undo
3794 4008
 				$ip_parts[0] .= $mode . $min;
3795 4009
 				$valid_low = isValidIP($ip_parts[0]);
3796 4010
 				$count++;
3797
-				if ($count > 9) break;
4011
+				if ($count > 9) {
4012
+					break;
4013
+				}
3798 4014
 			}
3799 4015
 		}
3800 4016
 
@@ -3808,7 +4024,9 @@  discard block
 block discarded – undo
3808 4024
 				$ip_parts[1] .= $mode . $max;
3809 4025
 				$valid_high = isValidIP($ip_parts[1]);
3810 4026
 				$count++;
3811
-				if ($count > 9) break;
4027
+				if ($count > 9) {
4028
+					break;
4029
+				}
3812 4030
 			}
3813 4031
 		}
3814 4032
 
@@ -3833,46 +4051,54 @@  discard block
 block discarded – undo
3833 4051
 {
3834 4052
 	global $modSettings;
3835 4053
 
3836
-	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null)
3837
-		return $host;
4054
+	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) {
4055
+			return $host;
4056
+	}
3838 4057
 	$t = microtime();
3839 4058
 
3840 4059
 	// Try the Linux host command, perhaps?
3841 4060
 	if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1)
3842 4061
 	{
3843
-		if (!isset($modSettings['host_to_dis']))
3844
-			$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
3845
-		else
3846
-			$test = @shell_exec('host ' . @escapeshellarg($ip));
4062
+		if (!isset($modSettings['host_to_dis'])) {
4063
+					$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
4064
+		} else {
4065
+					$test = @shell_exec('host ' . @escapeshellarg($ip));
4066
+		}
3847 4067
 
3848 4068
 		// Did host say it didn't find anything?
3849
-		if (strpos($test, 'not found') !== false)
3850
-			$host = '';
4069
+		if (strpos($test, 'not found') !== false) {
4070
+					$host = '';
4071
+		}
3851 4072
 		// Invalid server option?
3852
-		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis']))
3853
-			updateSettings(array('host_to_dis' => 1));
4073
+		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) {
4074
+					updateSettings(array('host_to_dis' => 1));
4075
+		}
3854 4076
 		// Maybe it found something, after all?
3855
-		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1)
3856
-			$host = $match[1];
4077
+		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) {
4078
+					$host = $match[1];
4079
+		}
3857 4080
 	}
3858 4081
 
3859 4082
 	// This is nslookup; usually only Windows, but possibly some Unix?
3860 4083
 	if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1)
3861 4084
 	{
3862 4085
 		$test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip));
3863
-		if (strpos($test, 'Non-existent domain') !== false)
3864
-			$host = '';
3865
-		elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1)
3866
-			$host = $match[1];
4086
+		if (strpos($test, 'Non-existent domain') !== false) {
4087
+					$host = '';
4088
+		} elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) {
4089
+					$host = $match[1];
4090
+		}
3867 4091
 	}
3868 4092
 
3869 4093
 	// This is the last try :/.
3870
-	if (!isset($host) || $host === false)
3871
-		$host = @gethostbyaddr($ip);
4094
+	if (!isset($host) || $host === false) {
4095
+			$host = @gethostbyaddr($ip);
4096
+	}
3872 4097
 
3873 4098
 	// It took a long time, so let's cache it!
3874
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5)
3875
-		cache_put_data('hostlookup-' . $ip, $host, 600);
4099
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) {
4100
+			cache_put_data('hostlookup-' . $ip, $host, 600);
4101
+	}
3876 4102
 
3877 4103
 	return $host;
3878 4104
 }
@@ -3908,20 +4134,21 @@  discard block
 block discarded – undo
3908 4134
 			{
3909 4135
 				$encrypted = substr(crypt($word, 'uk'), 2, $max_chars);
3910 4136
 				$total = 0;
3911
-				for ($i = 0; $i < $max_chars; $i++)
3912
-					$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4137
+				for ($i = 0; $i < $max_chars; $i++) {
4138
+									$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4139
+				}
3913 4140
 				$returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total;
3914 4141
 			}
3915 4142
 		}
3916 4143
 		return array_unique($returned_ints);
3917
-	}
3918
-	else
4144
+	} else
3919 4145
 	{
3920 4146
 		// Trim characters before and after and add slashes for database insertion.
3921 4147
 		$returned_words = array();
3922
-		foreach ($words as $word)
3923
-			if (($word = trim($word, '-_\'')) !== '')
4148
+		foreach ($words as $word) {
4149
+					if (($word = trim($word, '-_\'')) !== '')
3924 4150
 				$returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars);
4151
+		}
3925 4152
 
3926 4153
 		// Filter out all words that occur more than once.
3927 4154
 		return array_unique($returned_words);
@@ -3943,16 +4170,18 @@  discard block
 block discarded – undo
3943 4170
 	global $settings, $txt;
3944 4171
 
3945 4172
 	// Does the current loaded theme have this and we are not forcing the usage of this function?
3946
-	if (function_exists('template_create_button') && !$force_use)
3947
-		return template_create_button($name, $alt, $label = '', $custom = '');
4173
+	if (function_exists('template_create_button') && !$force_use) {
4174
+			return template_create_button($name, $alt, $label = '', $custom = '');
4175
+	}
3948 4176
 
3949
-	if (!$settings['use_image_buttons'])
3950
-		return $txt[$alt];
3951
-	elseif (!empty($settings['use_buttons']))
3952
-		return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
3953
-	else
3954
-		return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
3955
-}
4177
+	if (!$settings['use_image_buttons']) {
4178
+			return $txt[$alt];
4179
+	} elseif (!empty($settings['use_buttons'])) {
4180
+			return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4181
+	} else {
4182
+			return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4183
+	}
4184
+	}
3956 4185
 
3957 4186
 /**
3958 4187
  * Sets up all of the top menu buttons
@@ -3995,9 +4224,10 @@  discard block
 block discarded – undo
3995 4224
 	var user_menus = new smc_PopupMenu();
3996 4225
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
3997 4226
 	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
3998
-		if ($context['allow_pm'])
3999
-			addInlineJavaScript('
4227
+		if ($context['allow_pm']) {
4228
+					addInlineJavaScript('
4000 4229
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
4230
+		}
4001 4231
 
4002 4232
 		if (!empty($modSettings['enable_ajax_alerts']))
4003 4233
 		{
@@ -4157,88 +4387,96 @@  discard block
 block discarded – undo
4157 4387
 
4158 4388
 		// Now we put the buttons in the context so the theme can use them.
4159 4389
 		$menu_buttons = array();
4160
-		foreach ($buttons as $act => $button)
4161
-			if (!empty($button['show']))
4390
+		foreach ($buttons as $act => $button) {
4391
+					if (!empty($button['show']))
4162 4392
 			{
4163 4393
 				$button['active_button'] = false;
4394
+		}
4164 4395
 
4165 4396
 				// This button needs some action.
4166
-				if (isset($button['action_hook']))
4167
-					$needs_action_hook = true;
4397
+				if (isset($button['action_hook'])) {
4398
+									$needs_action_hook = true;
4399
+				}
4168 4400
 
4169 4401
 				// Make sure the last button truly is the last button.
4170 4402
 				if (!empty($button['is_last']))
4171 4403
 				{
4172
-					if (isset($last_button))
4173
-						unset($menu_buttons[$last_button]['is_last']);
4404
+					if (isset($last_button)) {
4405
+											unset($menu_buttons[$last_button]['is_last']);
4406
+					}
4174 4407
 					$last_button = $act;
4175 4408
 				}
4176 4409
 
4177 4410
 				// Go through the sub buttons if there are any.
4178
-				if (!empty($button['sub_buttons']))
4179
-					foreach ($button['sub_buttons'] as $key => $subbutton)
4411
+				if (!empty($button['sub_buttons'])) {
4412
+									foreach ($button['sub_buttons'] as $key => $subbutton)
4180 4413
 					{
4181 4414
 						if (empty($subbutton['show']))
4182 4415
 							unset($button['sub_buttons'][$key]);
4416
+				}
4183 4417
 
4184 4418
 						// 2nd level sub buttons next...
4185 4419
 						if (!empty($subbutton['sub_buttons']))
4186 4420
 						{
4187 4421
 							foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2)
4188 4422
 							{
4189
-								if (empty($sub_button2['show']))
4190
-									unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4423
+								if (empty($sub_button2['show'])) {
4424
+																	unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4425
+								}
4191 4426
 							}
4192 4427
 						}
4193 4428
 					}
4194 4429
 
4195 4430
 				// Does this button have its own icon?
4196
-				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon']))
4197
-					$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4198
-				elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon']))
4199
-					$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4200
-				elseif (isset($button['icon']))
4201
-					$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4202
-				else
4203
-					$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4431
+				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) {
4432
+									$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4433
+				} elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) {
4434
+									$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4435
+				} elseif (isset($button['icon'])) {
4436
+									$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4437
+				} else {
4438
+									$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4439
+				}
4204 4440
 
4205 4441
 				$menu_buttons[$act] = $button;
4206 4442
 			}
4207 4443
 
4208
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
4209
-			cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4444
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
4445
+					cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4446
+		}
4210 4447
 	}
4211 4448
 
4212 4449
 	$context['menu_buttons'] = $menu_buttons;
4213 4450
 
4214 4451
 	// Logging out requires the session id in the url.
4215
-	if (isset($context['menu_buttons']['logout']))
4216
-		$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4452
+	if (isset($context['menu_buttons']['logout'])) {
4453
+			$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4454
+	}
4217 4455
 
4218 4456
 	// Figure out which action we are doing so we can set the active tab.
4219 4457
 	// Default to home.
4220 4458
 	$current_action = 'home';
4221 4459
 
4222
-	if (isset($context['menu_buttons'][$context['current_action']]))
4223
-		$current_action = $context['current_action'];
4224
-	elseif ($context['current_action'] == 'search2')
4225
-		$current_action = 'search';
4226
-	elseif ($context['current_action'] == 'theme')
4227
-		$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4228
-	elseif ($context['current_action'] == 'register2')
4229
-		$current_action = 'register';
4230
-	elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder'))
4231
-		$current_action = 'login';
4232
-	elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center'])
4233
-		$current_action = 'moderate';
4460
+	if (isset($context['menu_buttons'][$context['current_action']])) {
4461
+			$current_action = $context['current_action'];
4462
+	} elseif ($context['current_action'] == 'search2') {
4463
+			$current_action = 'search';
4464
+	} elseif ($context['current_action'] == 'theme') {
4465
+			$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4466
+	} elseif ($context['current_action'] == 'register2') {
4467
+			$current_action = 'register';
4468
+	} elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) {
4469
+			$current_action = 'login';
4470
+	} elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) {
4471
+			$current_action = 'moderate';
4472
+	}
4234 4473
 
4235 4474
 	// There are certain exceptions to the above where we don't want anything on the menu highlighted.
4236 4475
 	if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner']))
4237 4476
 	{
4238 4477
 		$current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile';
4239 4478
 		$context[$current_action] = true;
4240
-	}
4241
-	elseif ($context['current_action'] == 'pm')
4479
+	} elseif ($context['current_action'] == 'pm')
4242 4480
 	{
4243 4481
 		$current_action = 'self_pm';
4244 4482
 		$context['self_pm'] = true;
@@ -4281,12 +4519,14 @@  discard block
 block discarded – undo
4281 4519
 	}
4282 4520
 
4283 4521
 	// Not all actions are simple.
4284
-	if (!empty($needs_action_hook))
4285
-		call_integration_hook('integrate_current_action', array(&$current_action));
4522
+	if (!empty($needs_action_hook)) {
4523
+			call_integration_hook('integrate_current_action', array(&$current_action));
4524
+	}
4286 4525
 
4287
-	if (isset($context['menu_buttons'][$current_action]))
4288
-		$context['menu_buttons'][$current_action]['active_button'] = true;
4289
-}
4526
+	if (isset($context['menu_buttons'][$current_action])) {
4527
+			$context['menu_buttons'][$current_action]['active_button'] = true;
4528
+	}
4529
+	}
4290 4530
 
4291 4531
 /**
4292 4532
  * Generate a random seed and ensure it's stored in settings.
@@ -4310,16 +4550,19 @@  discard block
 block discarded – undo
4310 4550
 	global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug;
4311 4551
 	global $context, $txt;
4312 4552
 
4313
-	if ($db_show_debug === true)
4314
-		$context['debug']['hooks'][] = $hook;
4553
+	if ($db_show_debug === true) {
4554
+			$context['debug']['hooks'][] = $hook;
4555
+	}
4315 4556
 
4316 4557
 	// Need to have some control.
4317
-	if (!isset($context['instances']))
4318
-		$context['instances'] = array();
4558
+	if (!isset($context['instances'])) {
4559
+			$context['instances'] = array();
4560
+	}
4319 4561
 
4320 4562
 	$results = array();
4321
-	if (empty($modSettings[$hook]))
4322
-		return $results;
4563
+	if (empty($modSettings[$hook])) {
4564
+			return $results;
4565
+	}
4323 4566
 
4324 4567
 	// Define some needed vars.
4325 4568
 	$function = false;
@@ -4329,14 +4572,16 @@  discard block
 block discarded – undo
4329 4572
 	foreach ($functions as $function)
4330 4573
 	{
4331 4574
 		// Hook has been marked as "disabled". Skip it!
4332
-		if (strpos($function, '!') !== false)
4333
-			continue;
4575
+		if (strpos($function, '!') !== false) {
4576
+					continue;
4577
+		}
4334 4578
 
4335 4579
 		$call = call_helper($function, true);
4336 4580
 
4337 4581
 		// Is it valid?
4338
-		if (!empty($call))
4339
-			$results[$function] = call_user_func_array($call, $parameters);
4582
+		if (!empty($call)) {
4583
+					$results[$function] = call_user_func_array($call, $parameters);
4584
+		}
4340 4585
 
4341 4586
 		// Whatever it was suppose to call, it failed :(
4342 4587
 		elseif (!empty($function))
@@ -4352,8 +4597,9 @@  discard block
 block discarded – undo
4352 4597
 			}
4353 4598
 
4354 4599
 			// "Assume" the file resides on $boarddir somewhere...
4355
-			else
4356
-				log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4600
+			else {
4601
+							log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4602
+			}
4357 4603
 		}
4358 4604
 	}
4359 4605
 
@@ -4375,12 +4621,14 @@  discard block
 block discarded – undo
4375 4621
 	global $smcFunc, $modSettings;
4376 4622
 
4377 4623
 	// Any objects?
4378
-	if ($object)
4379
-		$function = $function . '#';
4624
+	if ($object) {
4625
+			$function = $function . '#';
4626
+	}
4380 4627
 
4381 4628
 	// Any files  to load?
4382
-	if (!empty($file) && is_string($file))
4383
-		$function = $file . (!empty($function) ? '|' . $function : '');
4629
+	if (!empty($file) && is_string($file)) {
4630
+			$function = $file . (!empty($function) ? '|' . $function : '');
4631
+	}
4384 4632
 
4385 4633
 	// Get the correct string.
4386 4634
 	$integration_call = $function;
@@ -4402,13 +4650,14 @@  discard block
 block discarded – undo
4402 4650
 		if (!empty($current_functions))
4403 4651
 		{
4404 4652
 			$current_functions = explode(',', $current_functions);
4405
-			if (in_array($integration_call, $current_functions))
4406
-				return;
4653
+			if (in_array($integration_call, $current_functions)) {
4654
+							return;
4655
+			}
4407 4656
 
4408 4657
 			$permanent_functions = array_merge($current_functions, array($integration_call));
4658
+		} else {
4659
+					$permanent_functions = array($integration_call);
4409 4660
 		}
4410
-		else
4411
-			$permanent_functions = array($integration_call);
4412 4661
 
4413 4662
 		updateSettings(array($hook => implode(',', $permanent_functions)));
4414 4663
 	}
@@ -4417,8 +4666,9 @@  discard block
 block discarded – undo
4417 4666
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4418 4667
 
4419 4668
 	// Do nothing, if it's already there.
4420
-	if (in_array($integration_call, $functions))
4421
-		return;
4669
+	if (in_array($integration_call, $functions)) {
4670
+			return;
4671
+	}
4422 4672
 
4423 4673
 	$functions[] = $integration_call;
4424 4674
 	$modSettings[$hook] = implode(',', $functions);
@@ -4441,12 +4691,14 @@  discard block
 block discarded – undo
4441 4691
 	global $smcFunc, $modSettings;
4442 4692
 
4443 4693
 	// Any objects?
4444
-	if ($object)
4445
-		$function = $function . '#';
4694
+	if ($object) {
4695
+			$function = $function . '#';
4696
+	}
4446 4697
 
4447 4698
 	// Any files  to load?
4448
-	if (!empty($file) && is_string($file))
4449
-		$function = $file . '|' . $function;
4699
+	if (!empty($file) && is_string($file)) {
4700
+			$function = $file . '|' . $function;
4701
+	}
4450 4702
 
4451 4703
 	// Get the correct string.
4452 4704
 	$integration_call = $function;
@@ -4467,16 +4719,18 @@  discard block
 block discarded – undo
4467 4719
 	{
4468 4720
 		$current_functions = explode(',', $current_functions);
4469 4721
 
4470
-		if (in_array($integration_call, $current_functions))
4471
-			updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4722
+		if (in_array($integration_call, $current_functions)) {
4723
+					updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4724
+		}
4472 4725
 	}
4473 4726
 
4474 4727
 	// Turn the function list into something usable.
4475 4728
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4476 4729
 
4477 4730
 	// You can only remove it if it's available.
4478
-	if (!in_array($integration_call, $functions))
4479
-		return;
4731
+	if (!in_array($integration_call, $functions)) {
4732
+			return;
4733
+	}
4480 4734
 
4481 4735
 	$functions = array_diff($functions, array($integration_call));
4482 4736
 	$modSettings[$hook] = implode(',', $functions);
@@ -4497,17 +4751,20 @@  discard block
 block discarded – undo
4497 4751
 	global $context, $smcFunc, $txt, $db_show_debug;
4498 4752
 
4499 4753
 	// Really?
4500
-	if (empty($string))
4501
-		return false;
4754
+	if (empty($string)) {
4755
+			return false;
4756
+	}
4502 4757
 
4503 4758
 	// An array? should be a "callable" array IE array(object/class, valid_callable).
4504 4759
 	// A closure? should be a callable one.
4505
-	if (is_array($string) || $string instanceof Closure)
4506
-		return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4760
+	if (is_array($string) || $string instanceof Closure) {
4761
+			return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4762
+	}
4507 4763
 
4508 4764
 	// No full objects, sorry! pass a method or a property instead!
4509
-	if (is_object($string))
4510
-		return false;
4765
+	if (is_object($string)) {
4766
+			return false;
4767
+	}
4511 4768
 
4512 4769
 	// Stay vitaminized my friends...
4513 4770
 	$string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string));
@@ -4516,8 +4773,9 @@  discard block
 block discarded – undo
4516 4773
 	$string = load_file($string);
4517 4774
 
4518 4775
 	// Loaded file failed
4519
-	if (empty($string))
4520
-		return false;
4776
+	if (empty($string)) {
4777
+			return false;
4778
+	}
4521 4779
 
4522 4780
 	// Found a method.
4523 4781
 	if (strpos($string, '::') !== false)
@@ -4538,8 +4796,9 @@  discard block
 block discarded – undo
4538 4796
 				// Add another one to the list.
4539 4797
 				if ($db_show_debug === true)
4540 4798
 				{
4541
-					if (!isset($context['debug']['instances']))
4542
-						$context['debug']['instances'] = array();
4799
+					if (!isset($context['debug']['instances'])) {
4800
+											$context['debug']['instances'] = array();
4801
+					}
4543 4802
 
4544 4803
 					$context['debug']['instances'][$class] = $class;
4545 4804
 				}
@@ -4549,13 +4808,15 @@  discard block
 block discarded – undo
4549 4808
 		}
4550 4809
 
4551 4810
 		// Right then. This is a call to a static method.
4552
-		else
4553
-			$func = array($class, $method);
4811
+		else {
4812
+					$func = array($class, $method);
4813
+		}
4554 4814
 	}
4555 4815
 
4556 4816
 	// Nope! just a plain regular function.
4557
-	else
4558
-		$func = $string;
4817
+	else {
4818
+			$func = $string;
4819
+	}
4559 4820
 
4560 4821
 	// Right, we got what we need, time to do some checks.
4561 4822
 	if (!is_callable($func, false, $callable_name))
@@ -4571,17 +4832,18 @@  discard block
 block discarded – undo
4571 4832
 	else
4572 4833
 	{
4573 4834
 		// What are we gonna do about it?
4574
-		if ($return)
4575
-			return $func;
4835
+		if ($return) {
4836
+					return $func;
4837
+		}
4576 4838
 
4577 4839
 		// If this is a plain function, avoid the heat of calling call_user_func().
4578 4840
 		else
4579 4841
 		{
4580
-			if (is_array($func))
4581
-				call_user_func($func);
4582
-
4583
-			else
4584
-				$func();
4842
+			if (is_array($func)) {
4843
+							call_user_func($func);
4844
+			} else {
4845
+							$func();
4846
+			}
4585 4847
 		}
4586 4848
 	}
4587 4849
 }
@@ -4598,31 +4860,34 @@  discard block
 block discarded – undo
4598 4860
 {
4599 4861
 	global $sourcedir, $txt, $boarddir, $settings;
4600 4862
 
4601
-	if (empty($string))
4602
-		return false;
4863
+	if (empty($string)) {
4864
+			return false;
4865
+	}
4603 4866
 
4604 4867
 	if (strpos($string, '|') !== false)
4605 4868
 	{
4606 4869
 		list ($file, $string) = explode('|', $string);
4607 4870
 
4608 4871
 		// Match the wildcards to their regular vars.
4609
-		if (empty($settings['theme_dir']))
4610
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4611
-
4612
-		else
4613
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4872
+		if (empty($settings['theme_dir'])) {
4873
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4874
+		} else {
4875
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4876
+		}
4614 4877
 
4615 4878
 		// Load the file if it can be loaded.
4616
-		if (file_exists($absPath))
4617
-			require_once($absPath);
4879
+		if (file_exists($absPath)) {
4880
+					require_once($absPath);
4881
+		}
4618 4882
 
4619 4883
 		// No? try a fallback to $sourcedir
4620 4884
 		else
4621 4885
 		{
4622 4886
 			$absPath = $sourcedir .'/'. $file;
4623 4887
 
4624
-			if (file_exists($absPath))
4625
-				require_once($absPath);
4888
+			if (file_exists($absPath)) {
4889
+							require_once($absPath);
4890
+			}
4626 4891
 
4627 4892
 			// Sorry, can't do much for you at this point.
4628 4893
 			else
@@ -4649,8 +4914,9 @@  discard block
 block discarded – undo
4649 4914
 	global $user_info, $smcFunc;
4650 4915
 
4651 4916
 	// Make sure we have something to work with.
4652
-	if (empty($topic))
4653
-		return array();
4917
+	if (empty($topic)) {
4918
+			return array();
4919
+	}
4654 4920
 
4655 4921
 
4656 4922
 	// We already know the number of likes per message, we just want to know whether the current user liked it or not.
@@ -4673,8 +4939,9 @@  discard block
 block discarded – undo
4673 4939
 				'topic' => $topic,
4674 4940
 			)
4675 4941
 		);
4676
-		while ($row = $smcFunc['db_fetch_assoc']($request))
4677
-			$temp[] = (int) $row['content_id'];
4942
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
4943
+					$temp[] = (int) $row['content_id'];
4944
+		}
4678 4945
 
4679 4946
 		cache_put_data($cache_key, $temp, $ttl);
4680 4947
 	}
@@ -4695,8 +4962,9 @@  discard block
 block discarded – undo
4695 4962
 {
4696 4963
 	global $context;
4697 4964
 
4698
-	if (empty($string))
4699
-		return $string;
4965
+	if (empty($string)) {
4966
+			return $string;
4967
+	}
4700 4968
 
4701 4969
 	// UTF-8 occurences of MS special characters
4702 4970
 	$findchars_utf8 = array(
@@ -4737,10 +5005,11 @@  discard block
 block discarded – undo
4737 5005
 		'--',	// &mdash;
4738 5006
 	);
4739 5007
 
4740
-	if ($context['utf8'])
4741
-		$string = str_replace($findchars_utf8, $replacechars, $string);
4742
-	else
4743
-		$string = str_replace($findchars_iso, $replacechars, $string);
5008
+	if ($context['utf8']) {
5009
+			$string = str_replace($findchars_utf8, $replacechars, $string);
5010
+	} else {
5011
+			$string = str_replace($findchars_iso, $replacechars, $string);
5012
+	}
4744 5013
 
4745 5014
 	return $string;
4746 5015
 }
@@ -4759,49 +5028,59 @@  discard block
 block discarded – undo
4759 5028
 {
4760 5029
 	global $context;
4761 5030
 
4762
-	if (!isset($matches[2]))
4763
-		return '';
5031
+	if (!isset($matches[2])) {
5032
+			return '';
5033
+	}
4764 5034
 
4765 5035
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4766 5036
 
4767 5037
 	// remove left to right / right to left overrides
4768
-	if ($num === 0x202D || $num === 0x202E)
4769
-		return '';
5038
+	if ($num === 0x202D || $num === 0x202E) {
5039
+			return '';
5040
+	}
4770 5041
 
4771 5042
 	// Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced
4772
-	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E)))
4773
-		return '&#' . $num . ';';
5043
+	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) {
5044
+			return '&#' . $num . ';';
5045
+	}
4774 5046
 
4775 5047
 	if (empty($context['utf8']))
4776 5048
 	{
4777 5049
 		// no control characters
4778
-		if ($num < 0x20)
4779
-			return '';
5050
+		if ($num < 0x20) {
5051
+					return '';
5052
+		}
4780 5053
 		// text is text
4781
-		elseif ($num < 0x80)
4782
-			return chr($num);
5054
+		elseif ($num < 0x80) {
5055
+					return chr($num);
5056
+		}
4783 5057
 		// all others get html-ised
4784
-		else
4785
-			return '&#' . $matches[2] . ';';
4786
-	}
4787
-	else
5058
+		else {
5059
+					return '&#' . $matches[2] . ';';
5060
+		}
5061
+	} else
4788 5062
 	{
4789 5063
 		// <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set
4790 5064
 		// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text)
4791
-		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF))
4792
-			return '';
5065
+		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) {
5066
+					return '';
5067
+		}
4793 5068
 		// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4794
-		elseif ($num < 0x80)
4795
-			return chr($num);
5069
+		elseif ($num < 0x80) {
5070
+					return chr($num);
5071
+		}
4796 5072
 		// <0x800 (2048)
4797
-		elseif ($num < 0x800)
4798
-			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5073
+		elseif ($num < 0x800) {
5074
+					return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5075
+		}
4799 5076
 		// < 0x10000 (65536)
4800
-		elseif ($num < 0x10000)
4801
-			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5077
+		elseif ($num < 0x10000) {
5078
+					return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5079
+		}
4802 5080
 		// <= 0x10FFFF (1114111)
4803
-		else
4804
-			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5081
+		else {
5082
+					return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5083
+		}
4805 5084
 	}
4806 5085
 }
4807 5086
 
@@ -4817,28 +5096,34 @@  discard block
 block discarded – undo
4817 5096
  */
4818 5097
 function fixchar__callback($matches)
4819 5098
 {
4820
-	if (!isset($matches[1]))
4821
-		return '';
5099
+	if (!isset($matches[1])) {
5100
+			return '';
5101
+	}
4822 5102
 
4823 5103
 	$num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1];
4824 5104
 
4825 5105
 	// <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set
4826 5106
 	// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides
4827
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E)
4828
-		return '';
5107
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) {
5108
+			return '';
5109
+	}
4829 5110
 	// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4830
-	elseif ($num < 0x80)
4831
-		return chr($num);
5111
+	elseif ($num < 0x80) {
5112
+			return chr($num);
5113
+	}
4832 5114
 	// <0x800 (2048)
4833
-	elseif ($num < 0x800)
4834
-		return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5115
+	elseif ($num < 0x800) {
5116
+			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5117
+	}
4835 5118
 	// < 0x10000 (65536)
4836
-	elseif ($num < 0x10000)
4837
-		return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5119
+	elseif ($num < 0x10000) {
5120
+			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5121
+	}
4838 5122
 	// <= 0x10FFFF (1114111)
4839
-	else
4840
-		return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
4841
-}
5123
+	else {
5124
+			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5125
+	}
5126
+	}
4842 5127
 
4843 5128
 /**
4844 5129
  * Strips out invalid html entities, replaces others with html style &#123; codes
@@ -4851,17 +5136,19 @@  discard block
 block discarded – undo
4851 5136
  */
4852 5137
 function entity_fix__callback($matches)
4853 5138
 {
4854
-	if (!isset($matches[2]))
4855
-		return '';
5139
+	if (!isset($matches[2])) {
5140
+			return '';
5141
+	}
4856 5142
 
4857 5143
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4858 5144
 
4859 5145
 	// we don't allow control characters, characters out of range, byte markers, etc
4860
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E)
4861
-		return '';
4862
-	else
4863
-		return '&#' . $num . ';';
4864
-}
5146
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) {
5147
+			return '';
5148
+	} else {
5149
+			return '&#' . $num . ';';
5150
+	}
5151
+	}
4865 5152
 
4866 5153
 /**
4867 5154
  * Return a Gravatar URL based on
@@ -4885,18 +5172,23 @@  discard block
 block discarded – undo
4885 5172
 		$ratings = array('G', 'PG', 'R', 'X');
4886 5173
 		$defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank');
4887 5174
 		$url_params = array();
4888
-		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings))
4889
-			$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
4890
-		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults))
4891
-			$url_params[] = 'default=' . $modSettings['gravatarDefault'];
4892
-		if (!empty($modSettings['avatar_max_width_external']))
4893
-			$size_string = (int) $modSettings['avatar_max_width_external'];
4894
-		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string))
4895
-			if ((int) $modSettings['avatar_max_height_external'] < $size_string)
5175
+		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) {
5176
+					$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
5177
+		}
5178
+		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) {
5179
+					$url_params[] = 'default=' . $modSettings['gravatarDefault'];
5180
+		}
5181
+		if (!empty($modSettings['avatar_max_width_external'])) {
5182
+					$size_string = (int) $modSettings['avatar_max_width_external'];
5183
+		}
5184
+		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) {
5185
+					if ((int) $modSettings['avatar_max_height_external'] < $size_string)
4896 5186
 				$size_string = $modSettings['avatar_max_height_external'];
5187
+		}
4897 5188
 
4898
-		if (!empty($size_string))
4899
-			$url_params[] = 's=' . $size_string;
5189
+		if (!empty($size_string)) {
5190
+					$url_params[] = 's=' . $size_string;
5191
+		}
4900 5192
 	}
4901 5193
 	$http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www';
4902 5194
 
@@ -4915,22 +5207,26 @@  discard block
 block discarded – undo
4915 5207
 	static $timezones = null, $lastwhen = null;
4916 5208
 
4917 5209
 	// No point doing this over if we already did it once
4918
-	if (!empty($timezones) && $when == $lastwhen)
4919
-		return $timezones;
4920
-	else
4921
-		$lastwhen = $when;
5210
+	if (!empty($timezones) && $when == $lastwhen) {
5211
+			return $timezones;
5212
+	} else {
5213
+			$lastwhen = $when;
5214
+	}
4922 5215
 
4923 5216
 	// Parseable datetime string?
4924
-	if (is_int($timestamp = strtotime($when)))
4925
-		$when = $timestamp;
5217
+	if (is_int($timestamp = strtotime($when))) {
5218
+			$when = $timestamp;
5219
+	}
4926 5220
 
4927 5221
 	// A Unix timestamp?
4928
-	elseif (is_numeric($when))
4929
-		$when = intval($when);
5222
+	elseif (is_numeric($when)) {
5223
+			$when = intval($when);
5224
+	}
4930 5225
 
4931 5226
 	// Invalid value? Just get current Unix timestamp.
4932
-	else
4933
-		$when = time();
5227
+	else {
5228
+			$when = time();
5229
+	}
4934 5230
 
4935 5231
 	// We'll need these too
4936 5232
 	$date_when = date_create('@' . $when);
@@ -4994,8 +5290,9 @@  discard block
 block discarded – undo
4994 5290
 	foreach ($priority_countries as $country)
4995 5291
 	{
4996 5292
 		$country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country)));
4997
-		if (!empty($country_tzids))
4998
-			$priority_tzids = array_merge($priority_tzids, $country_tzids);
5293
+		if (!empty($country_tzids)) {
5294
+					$priority_tzids = array_merge($priority_tzids, $country_tzids);
5295
+		}
4999 5296
 	}
5000 5297
 
5001 5298
 	// Process the preferred timezones first, then the rest.
@@ -5005,8 +5302,9 @@  discard block
 block discarded – undo
5005 5302
 	foreach ($tzids as $tzid)
5006 5303
 	{
5007 5304
 		// We don't want UTC right now
5008
-		if ($tzid == 'UTC')
5009
-			continue;
5305
+		if ($tzid == 'UTC') {
5306
+					continue;
5307
+		}
5010 5308
 
5011 5309
 		$tz = timezone_open($tzid);
5012 5310
 
@@ -5021,12 +5319,14 @@  discard block
 block discarded – undo
5021 5319
 		$tzgeo = timezone_location_get($tz);
5022 5320
 
5023 5321
 		// Don't overwrite our preferred tzids
5024
-		if (empty($zones[$tzkey]['tzid']))
5025
-			$zones[$tzkey]['tzid'] = $tzid;
5322
+		if (empty($zones[$tzkey]['tzid'])) {
5323
+					$zones[$tzkey]['tzid'] = $tzid;
5324
+		}
5026 5325
 
5027 5326
 		// A time zone from a prioritized country?
5028
-		if (in_array($tzid, $priority_tzids))
5029
-			$priority_zones[$tzkey] = true;
5327
+		if (in_array($tzid, $priority_tzids)) {
5328
+					$priority_zones[$tzkey] = true;
5329
+		}
5030 5330
 
5031 5331
 		// Keep track of the location and offset for this tzid
5032 5332
 		$tzid_parts = explode('/', $tzid);
@@ -5047,15 +5347,17 @@  discard block
 block discarded – undo
5047 5347
 
5048 5348
 		date_timezone_set($date_when, timezone_open($tzvalue['tzid']));
5049 5349
 
5050
-		if (!empty($timezone_descriptions[$tzvalue['tzid']]))
5051
-			$desc = $timezone_descriptions[$tzvalue['tzid']];
5052
-		else
5053
-			$desc = implode(', ', array_unique($tzvalue['locations']));
5350
+		if (!empty($timezone_descriptions[$tzvalue['tzid']])) {
5351
+					$desc = $timezone_descriptions[$tzvalue['tzid']];
5352
+		} else {
5353
+					$desc = implode(', ', array_unique($tzvalue['locations']));
5354
+		}
5054 5355
 
5055
-		if (isset($priority_zones[$tzkey]))
5056
-			$priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5057
-		else
5058
-			$timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5356
+		if (isset($priority_zones[$tzkey])) {
5357
+					$priority_timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5358
+		} else {
5359
+					$timezones[$tzvalue['tzid']] = $tzinfo[0]['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5360
+		}
5059 5361
 	}
5060 5362
 
5061 5363
 	$timezones = array_merge(
@@ -5109,9 +5411,9 @@  discard block
 block discarded – undo
5109 5411
 			'Indian/Kerguelen' => 'TFT',
5110 5412
 		);
5111 5413
 
5112
-		if (!empty($missing_tz_abbrs[$tzid]))
5113
-			$tz_abbrev = $missing_tz_abbrs[$tzid];
5114
-		else
5414
+		if (!empty($missing_tz_abbrs[$tzid])) {
5415
+					$tz_abbrev = $missing_tz_abbrs[$tzid];
5416
+		} else
5115 5417
 		{
5116 5418
 			// Russia likes to experiment with time zones often, and names them as offsets from Moscow
5117 5419
 			$tz_location = timezone_location_get(timezone_open($tzid));
@@ -5139,8 +5441,9 @@  discard block
 block discarded – undo
5139 5441
  */
5140 5442
 function inet_ptod($ip_address)
5141 5443
 {
5142
-	if (!isValidIP($ip_address))
5143
-		return $ip_address;
5444
+	if (!isValidIP($ip_address)) {
5445
+			return $ip_address;
5446
+	}
5144 5447
 
5145 5448
 	$bin = inet_pton($ip_address);
5146 5449
 	return $bin;
@@ -5152,13 +5455,15 @@  discard block
 block discarded – undo
5152 5455
  */
5153 5456
 function inet_dtop($bin)
5154 5457
 {
5155
-	if(empty($bin))
5156
-		return '';
5458
+	if(empty($bin)) {
5459
+			return '';
5460
+	}
5157 5461
 
5158 5462
 	global $db_type;
5159 5463
 
5160
-	if ($db_type == 'postgresql')
5161
-		return $bin;
5464
+	if ($db_type == 'postgresql') {
5465
+			return $bin;
5466
+	}
5162 5467
 
5163 5468
 	$ip_address = inet_ntop($bin);
5164 5469
 
@@ -5183,26 +5488,32 @@  discard block
 block discarded – undo
5183 5488
  */
5184 5489
 function _safe_serialize($value)
5185 5490
 {
5186
-	if(is_null($value))
5187
-		return 'N;';
5491
+	if(is_null($value)) {
5492
+			return 'N;';
5493
+	}
5188 5494
 
5189
-	if(is_bool($value))
5190
-		return 'b:'. (int) $value .';';
5495
+	if(is_bool($value)) {
5496
+			return 'b:'. (int) $value .';';
5497
+	}
5191 5498
 
5192
-	if(is_int($value))
5193
-		return 'i:'. $value .';';
5499
+	if(is_int($value)) {
5500
+			return 'i:'. $value .';';
5501
+	}
5194 5502
 
5195
-	if(is_float($value))
5196
-		return 'd:'. str_replace(',', '.', $value) .';';
5503
+	if(is_float($value)) {
5504
+			return 'd:'. str_replace(',', '.', $value) .';';
5505
+	}
5197 5506
 
5198
-	if(is_string($value))
5199
-		return 's:'. strlen($value) .':"'. $value .'";';
5507
+	if(is_string($value)) {
5508
+			return 's:'. strlen($value) .':"'. $value .'";';
5509
+	}
5200 5510
 
5201 5511
 	if(is_array($value))
5202 5512
 	{
5203 5513
 		$out = '';
5204
-		foreach($value as $k => $v)
5205
-			$out .= _safe_serialize($k) . _safe_serialize($v);
5514
+		foreach($value as $k => $v) {
5515
+					$out .= _safe_serialize($k) . _safe_serialize($v);
5516
+		}
5206 5517
 
5207 5518
 		return 'a:'. count($value) .':{'. $out .'}';
5208 5519
 	}
@@ -5228,8 +5539,9 @@  discard block
 block discarded – undo
5228 5539
 
5229 5540
 	$out = _safe_serialize($value);
5230 5541
 
5231
-	if (isset($mbIntEnc))
5232
-		mb_internal_encoding($mbIntEnc);
5542
+	if (isset($mbIntEnc)) {
5543
+			mb_internal_encoding($mbIntEnc);
5544
+	}
5233 5545
 
5234 5546
 	return $out;
5235 5547
 }
@@ -5246,8 +5558,9 @@  discard block
 block discarded – undo
5246 5558
 function _safe_unserialize($str)
5247 5559
 {
5248 5560
 	// Input  is not a string.
5249
-	if(empty($str) || !is_string($str))
5250
-		return false;
5561
+	if(empty($str) || !is_string($str)) {
5562
+			return false;
5563
+	}
5251 5564
 
5252 5565
 	$stack = array();
5253 5566
 	$expected = array();
@@ -5263,43 +5576,38 @@  discard block
 block discarded – undo
5263 5576
 	while($state != 1)
5264 5577
 	{
5265 5578
 		$type = isset($str[0]) ? $str[0] : '';
5266
-		if($type == '}')
5267
-			$str = substr($str, 1);
5268
-
5269
-		else if($type == 'N' && $str[1] == ';')
5579
+		if($type == '}') {
5580
+					$str = substr($str, 1);
5581
+		} else if($type == 'N' && $str[1] == ';')
5270 5582
 		{
5271 5583
 			$value = null;
5272 5584
 			$str = substr($str, 2);
5273
-		}
5274
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5585
+		} else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5275 5586
 		{
5276 5587
 			$value = $matches[1] == '1' ? true : false;
5277 5588
 			$str = substr($str, 4);
5278
-		}
5279
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5589
+		} else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5280 5590
 		{
5281 5591
 			$value = (int)$matches[1];
5282 5592
 			$str = $matches[2];
5283
-		}
5284
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5593
+		} else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5285 5594
 		{
5286 5595
 			$value = (float)$matches[1];
5287 5596
 			$str = $matches[3];
5288
-		}
5289
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5597
+		} else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5290 5598
 		{
5291 5599
 			$value = substr($matches[2], 0, (int)$matches[1]);
5292 5600
 			$str = substr($matches[2], (int)$matches[1] + 2);
5293
-		}
5294
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5601
+		} else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5295 5602
 		{
5296 5603
 			$expectedLength = (int)$matches[1];
5297 5604
 			$str = $matches[2];
5298 5605
 		}
5299 5606
 
5300 5607
 		// Object or unknown/malformed type.
5301
-		else
5302
-			return false;
5608
+		else {
5609
+					return false;
5610
+		}
5303 5611
 
5304 5612
 		switch($state)
5305 5613
 		{
@@ -5327,8 +5635,9 @@  discard block
 block discarded – undo
5327 5635
 				if($type == '}')
5328 5636
 				{
5329 5637
 					// Array size is less than expected.
5330
-					if(count($list) < end($expected))
5331
-						return false;
5638
+					if(count($list) < end($expected)) {
5639
+											return false;
5640
+					}
5332 5641
 
5333 5642
 					unset($list);
5334 5643
 					$list = &$stack[count($stack)-1];
@@ -5337,8 +5646,9 @@  discard block
 block discarded – undo
5337 5646
 					// Go to terminal state if we're at the end of the root array.
5338 5647
 					array_pop($expected);
5339 5648
 
5340
-					if(count($expected) == 0)
5341
-						$state = 1;
5649
+					if(count($expected) == 0) {
5650
+											$state = 1;
5651
+					}
5342 5652
 
5343 5653
 					break;
5344 5654
 				}
@@ -5346,8 +5656,9 @@  discard block
 block discarded – undo
5346 5656
 				if($type == 'i' || $type == 's')
5347 5657
 				{
5348 5658
 					// Array size exceeds expected length.
5349
-					if(count($list) >= end($expected))
5350
-						return false;
5659
+					if(count($list) >= end($expected)) {
5660
+											return false;
5661
+					}
5351 5662
 
5352 5663
 					$key = $value;
5353 5664
 					$state = 3;
@@ -5381,8 +5692,9 @@  discard block
 block discarded – undo
5381 5692
 	}
5382 5693
 
5383 5694
 	// Trailing data in input.
5384
-	if(!empty($str))
5385
-		return false;
5695
+	if(!empty($str)) {
5696
+			return false;
5697
+	}
5386 5698
 
5387 5699
 	return $data;
5388 5700
 }
@@ -5405,8 +5717,9 @@  discard block
 block discarded – undo
5405 5717
 
5406 5718
 	$out = _safe_unserialize($str);
5407 5719
 
5408
-	if (isset($mbIntEnc))
5409
-		mb_internal_encoding($mbIntEnc);
5720
+	if (isset($mbIntEnc)) {
5721
+			mb_internal_encoding($mbIntEnc);
5722
+	}
5410 5723
 
5411 5724
 	return $out;
5412 5725
 }
@@ -5421,12 +5734,14 @@  discard block
 block discarded – undo
5421 5734
 function smf_chmod($file, $value = 0)
5422 5735
 {
5423 5736
 	// No file? no checks!
5424
-	if (empty($file))
5425
-		return false;
5737
+	if (empty($file)) {
5738
+			return false;
5739
+	}
5426 5740
 
5427 5741
 	// Already writable?
5428
-	if (is_writable($file))
5429
-		return true;
5742
+	if (is_writable($file)) {
5743
+			return true;
5744
+	}
5430 5745
 
5431 5746
 	// Do we have a file or a dir?
5432 5747
 	$isDir = is_dir($file);
@@ -5442,10 +5757,9 @@  discard block
 block discarded – undo
5442 5757
 		{
5443 5758
 			$isWritable = true;
5444 5759
 			break;
5760
+		} else {
5761
+					@chmod($file, $val);
5445 5762
 		}
5446
-
5447
-		else
5448
-			@chmod($file, $val);
5449 5763
 	}
5450 5764
 
5451 5765
 	return $isWritable;
@@ -5464,8 +5778,9 @@  discard block
 block discarded – undo
5464 5778
 	global $txt;
5465 5779
 
5466 5780
 	// Come on...
5467
-	if (empty($json) || !is_string($json))
5468
-		return array();
5781
+	if (empty($json) || !is_string($json)) {
5782
+			return array();
5783
+	}
5469 5784
 
5470 5785
 	$returnArray = @json_decode($json, $returnAsArray);
5471 5786
 
@@ -5503,11 +5818,11 @@  discard block
 block discarded – undo
5503 5818
 		$jsonDebug = $jsonDebug[0];
5504 5819
 		loadLanguage('Errors');
5505 5820
 
5506
-		if (!empty($jsonDebug))
5507
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5508
-
5509
-		else
5510
-			log_error($txt['json_'. $jsonError], 'critical');
5821
+		if (!empty($jsonDebug)) {
5822
+					log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5823
+		} else {
5824
+					log_error($txt['json_'. $jsonError], 'critical');
5825
+		}
5511 5826
 
5512 5827
 		// Everyone expects an array.
5513 5828
 		return array();
@@ -5537,8 +5852,9 @@  discard block
 block discarded – undo
5537 5852
 	global $db_show_debug, $modSettings;
5538 5853
 
5539 5854
 	// Defensive programming anyone?
5540
-	if (empty($data))
5541
-		return false;
5855
+	if (empty($data)) {
5856
+			return false;
5857
+	}
5542 5858
 
5543 5859
 	// Don't need extra stuff...
5544 5860
 	$db_show_debug = false;
@@ -5546,11 +5862,11 @@  discard block
 block discarded – undo
5546 5862
 	// Kill anything else.
5547 5863
 	ob_end_clean();
5548 5864
 
5549
-	if (!empty($modSettings['CompressedOutput']))
5550
-		@ob_start('ob_gzhandler');
5551
-
5552
-	else
5553
-		ob_start();
5865
+	if (!empty($modSettings['CompressedOutput'])) {
5866
+			@ob_start('ob_gzhandler');
5867
+	} else {
5868
+			ob_start();
5869
+	}
5554 5870
 
5555 5871
 	// Set the header.
5556 5872
 	header($type);
@@ -5582,8 +5898,9 @@  discard block
 block discarded – undo
5582 5898
 	static $done = false;
5583 5899
 
5584 5900
 	// If we don't need to do anything, don't
5585
-	if (!$update && $done)
5586
-		return;
5901
+	if (!$update && $done) {
5902
+			return;
5903
+	}
5587 5904
 
5588 5905
 	// Should we get a new copy of the official list of TLDs?
5589 5906
 	if ($update)
@@ -5604,10 +5921,11 @@  discard block
 block discarded – undo
5604 5921
 		// Clean $tlds and convert it to an array
5605 5922
 		$tlds = array_filter(explode("\n", strtolower($tlds)), function($line) {
5606 5923
 			$line = trim($line);
5607
-			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false)
5608
-				return false;
5609
-			else
5610
-				return true;
5924
+			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) {
5925
+							return false;
5926
+			} else {
5927
+							return true;
5928
+			}
5611 5929
 		});
5612 5930
 
5613 5931
 		// Convert Punycode to Unicode
@@ -5661,8 +5979,9 @@  discard block
 block discarded – undo
5661 5979
 						$idx += $digit * $w;
5662 5980
 						$t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias));
5663 5981
 
5664
-						if ($digit < $t)
5665
-							break;
5982
+						if ($digit < $t) {
5983
+													break;
5984
+						}
5666 5985
 
5667 5986
 						$w = (int) ($w * ($base - $t));
5668 5987
 					}
@@ -5671,8 +5990,9 @@  discard block
 block discarded – undo
5671 5990
 					$delta = intval($is_first ? ($delta / $damp) : ($delta / 2));
5672 5991
 					$delta += intval($delta / ($deco_len + 1));
5673 5992
 
5674
-					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base)
5675
-						$delta = intval($delta / ($base - $tmin));
5993
+					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) {
5994
+											$delta = intval($delta / ($base - $tmin));
5995
+					}
5676 5996
 
5677 5997
 					$bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew));
5678 5998
 					$is_first = false;
@@ -5681,8 +6001,9 @@  discard block
 block discarded – undo
5681 6001
 
5682 6002
 					if ($deco_len > 0)
5683 6003
 					{
5684
-						for ($i = $deco_len; $i > $idx; $i--)
5685
-							$decoded[$i] = $decoded[($i - 1)];
6004
+						for ($i = $deco_len; $i > $idx; $i--) {
6005
+													$decoded[$i] = $decoded[($i - 1)];
6006
+						}
5686 6007
 					}
5687 6008
 					$decoded[$idx++] = $char;
5688 6009
 				}
@@ -5690,24 +6011,29 @@  discard block
 block discarded – undo
5690 6011
 				foreach ($decoded as $k => $v)
5691 6012
 				{
5692 6013
 					// 7bit are transferred literally
5693
-					if ($v < 128)
5694
-						$output .= chr($v);
6014
+					if ($v < 128) {
6015
+											$output .= chr($v);
6016
+					}
5695 6017
 
5696 6018
 					// 2 bytes
5697
-					elseif ($v < (1 << 11))
5698
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
6019
+					elseif ($v < (1 << 11)) {
6020
+											$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
6021
+					}
5699 6022
 
5700 6023
 					// 3 bytes
5701
-					elseif ($v < (1 << 16))
5702
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6024
+					elseif ($v < (1 << 16)) {
6025
+											$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6026
+					}
5703 6027
 
5704 6028
 					// 4 bytes
5705
-					elseif ($v < (1 << 21))
5706
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6029
+					elseif ($v < (1 << 21)) {
6030
+											$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6031
+					}
5707 6032
 
5708 6033
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5709
-					else
5710
-						$output .= $safe_char;
6034
+					else {
6035
+											$output .= $safe_char;
6036
+					}
5711 6037
 				}
5712 6038
 
5713 6039
 				$output_parts[] = $output;
@@ -5802,8 +6128,7 @@  discard block
 block discarded – undo
5802 6128
 
5803 6129
 		$strlen = 'mb_strlen';
5804 6130
 		$substr = 'mb_substr';
5805
-	}
5806
-	else
6131
+	} else
5807 6132
 	{
5808 6133
 		$strlen = $smcFunc['strlen'];
5809 6134
 		$substr = $smcFunc['substr'];
@@ -5817,20 +6142,21 @@  discard block
 block discarded – undo
5817 6142
 
5818 6143
 		$first = $substr($string, 0, 1);
5819 6144
 
5820
-		if (empty($index[$first]))
5821
-			$index[$first] = array();
6145
+		if (empty($index[$first])) {
6146
+					$index[$first] = array();
6147
+		}
5822 6148
 
5823 6149
 		if ($strlen($string) > 1)
5824 6150
 		{
5825 6151
 			// Sanity check on recursion
5826
-			if ($depth > 99)
5827
-				$index[$first][$substr($string, 1)] = '';
5828
-
5829
-			else
5830
-				$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6152
+			if ($depth > 99) {
6153
+							$index[$first][$substr($string, 1)] = '';
6154
+			} else {
6155
+							$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6156
+			}
6157
+		} else {
6158
+					$index[$first][''] = '';
5831 6159
 		}
5832
-		else
5833
-			$index[$first][''] = '';
5834 6160
 
5835 6161
 		$depth--;
5836 6162
 		return $index;
@@ -5853,9 +6179,9 @@  discard block
 block discarded – undo
5853 6179
 			$key_regex = preg_quote($key, $delim);
5854 6180
 			$new_key = $key;
5855 6181
 
5856
-			if (empty($value))
5857
-				$sub_regex = '';
5858
-			else
6182
+			if (empty($value)) {
6183
+							$sub_regex = '';
6184
+			} else
5859 6185
 			{
5860 6186
 				$sub_regex = $index_to_regex($value, $delim);
5861 6187
 
@@ -5863,22 +6189,22 @@  discard block
 block discarded – undo
5863 6189
 				{
5864 6190
 					$new_key_array = explode('(?'.'>', $sub_regex);
5865 6191
 					$new_key .= $new_key_array[0];
6192
+				} else {
6193
+									$sub_regex = '(?'.'>' . $sub_regex . ')';
5866 6194
 				}
5867
-				else
5868
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5869 6195
 			}
5870 6196
 
5871
-			if ($depth > 1)
5872
-				$regex[$new_key] = $key_regex . $sub_regex;
5873
-			else
6197
+			if ($depth > 1) {
6198
+							$regex[$new_key] = $key_regex . $sub_regex;
6199
+			} else
5874 6200
 			{
5875 6201
 				if (($length += strlen($key_regex) + 1) < $max_length || empty($regex))
5876 6202
 				{
5877 6203
 					$regex[$new_key] = $key_regex . $sub_regex;
5878 6204
 					unset($index[$key]);
6205
+				} else {
6206
+									break;
5879 6207
 				}
5880
-				else
5881
-					break;
5882 6208
 			}
5883 6209
 		}
5884 6210
 
@@ -5887,10 +6213,11 @@  discard block
 block discarded – undo
5887 6213
 			$l1 = $strlen($k1);
5888 6214
 			$l2 = $strlen($k2);
5889 6215
 
5890
-			if ($l1 == $l2)
5891
-				return strcmp($k1, $k2) > 0 ? 1 : -1;
5892
-			else
5893
-				return $l1 > $l2 ? -1 : 1;
6216
+			if ($l1 == $l2) {
6217
+							return strcmp($k1, $k2) > 0 ? 1 : -1;
6218
+			} else {
6219
+							return $l1 > $l2 ? -1 : 1;
6220
+			}
5894 6221
 		});
5895 6222
 
5896 6223
 		$depth--;
@@ -5901,15 +6228,18 @@  discard block
 block discarded – undo
5901 6228
 	$index = array();
5902 6229
 	$regexes = array();
5903 6230
 
5904
-	foreach ($strings as $string)
5905
-		$index = $add_string_to_index($string, $index);
6231
+	foreach ($strings as $string) {
6232
+			$index = $add_string_to_index($string, $index);
6233
+	}
5906 6234
 
5907
-	while (!empty($index))
5908
-		$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6235
+	while (!empty($index)) {
6236
+			$regexes[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6237
+	}
5909 6238
 
5910 6239
 	// Restore PHP's internal character encoding to whatever it was originally
5911
-	if (!empty($current_encoding))
5912
-		mb_internal_encoding($current_encoding);
6240
+	if (!empty($current_encoding)) {
6241
+			mb_internal_encoding($current_encoding);
6242
+	}
5913 6243
 
5914 6244
 	return $regexes;
5915 6245
 }
Please login to merge, or discard this patch.
SSI.php 1 patch
Braces   +430 added lines, -306 removed lines patch added patch discarded remove patch
@@ -12,8 +12,9 @@  discard block
 block discarded – undo
12 12
  */
13 13
 
14 14
 // Don't do anything if SMF is already loaded.
15
-if (defined('SMF'))
15
+if (defined('SMF')) {
16 16
 	return true;
17
+}
17 18
 
18 19
 define('SMF', 'SSI');
19 20
 
@@ -26,21 +27,24 @@  discard block
 block discarded – undo
26 27
 
27 28
 // Remember the current configuration so it can be set back.
28 29
 $ssi_magic_quotes_runtime = function_exists('get_magic_quotes_gpc') && get_magic_quotes_runtime();
29
-if (function_exists('set_magic_quotes_runtime'))
30
+if (function_exists('set_magic_quotes_runtime')) {
30 31
 	@set_magic_quotes_runtime(0);
32
+}
31 33
 $time_start = microtime();
32 34
 
33 35
 // Just being safe...
34
-foreach (array('db_character_set', 'cachedir') as $variable)
36
+foreach (array('db_character_set', 'cachedir') as $variable) {
35 37
 	if (isset($GLOBALS[$variable]))
36 38
 		unset($GLOBALS[$variable]);
39
+}
37 40
 
38 41
 // Get the forum's settings for database and file paths.
39 42
 require_once(dirname(__FILE__) . '/Settings.php');
40 43
 
41 44
 // Make absolutely sure the cache directory is defined.
42
-if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache'))
45
+if ((empty($cachedir) || !file_exists($cachedir)) && file_exists($boarddir . '/cache')) {
43 46
 	$cachedir = $boarddir . '/cache';
47
+}
44 48
 
45 49
 $ssi_error_reporting = error_reporting(defined('E_STRICT') ? E_ALL | E_STRICT : E_ALL);
46 50
 /* Set this to one of three values depending on what you want to happen in the case of a fatal error.
@@ -51,12 +55,14 @@  discard block
 block discarded – undo
51 55
 $ssi_on_error_method = false;
52 56
 
53 57
 // Don't do john didley if the forum's been shut down completely.
54
-if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true))
58
+if ($maintenance == 2 && (!isset($ssi_maintenance_off) || $ssi_maintenance_off !== true)) {
55 59
 	die($mmessage);
60
+}
56 61
 
57 62
 // Fix for using the current directory as a path.
58
-if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.')
63
+if (substr($sourcedir, 0, 1) == '.' && substr($sourcedir, 1, 1) != '.') {
59 64
 	$sourcedir = dirname(__FILE__) . substr($sourcedir, 1);
65
+}
60 66
 
61 67
 // Load the important includes.
62 68
 require_once($sourcedir . '/QueryString.php');
@@ -81,34 +87,38 @@  discard block
 block discarded – undo
81 87
 cleanRequest();
82 88
 
83 89
 // Seed the random generator?
84
-if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69)
90
+if (empty($modSettings['rand_seed']) || mt_rand(1, 250) == 69) {
85 91
 	smf_seed_generator();
92
+}
86 93
 
87 94
 // Check on any hacking attempts.
88
-if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS']))
95
+if (isset($_REQUEST['GLOBALS']) || isset($_COOKIE['GLOBALS'])) {
89 96
 	die('No direct access...');
90
-elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme)
97
+} elseif (isset($_REQUEST['ssi_theme']) && (int) $_REQUEST['ssi_theme'] == (int) $ssi_theme) {
91 98
 	die('No direct access...');
92
-elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme)
99
+} elseif (isset($_COOKIE['ssi_theme']) && (int) $_COOKIE['ssi_theme'] == (int) $ssi_theme) {
93 100
 	die('No direct access...');
94
-elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers)
101
+} elseif (isset($_REQUEST['ssi_layers'], $ssi_layers) && (@get_magic_quotes_gpc() ? stripslashes($_REQUEST['ssi_layers']) : $_REQUEST['ssi_layers']) == $ssi_layers) {
95 102
 	die('No direct access...');
96
-if (isset($_REQUEST['context']))
103
+}
104
+if (isset($_REQUEST['context'])) {
97 105
 	die('No direct access...');
106
+}
98 107
 
99 108
 // Gzip output? (because it must be boolean and true, this can't be hacked.)
100
-if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>='))
109
+if (isset($ssi_gzip) && $ssi_gzip === true && ini_get('zlib.output_compression') != '1' && ini_get('output_handler') != 'ob_gzhandler' && version_compare(PHP_VERSION, '4.2.0', '>=')) {
101 110
 	ob_start('ob_gzhandler');
102
-else
111
+} else {
103 112
 	$modSettings['enableCompressedOutput'] = '0';
113
+}
104 114
 
105 115
 // Primarily, this is to fix the URLs...
106 116
 ob_start('ob_sessrewrite');
107 117
 
108 118
 // Start the session... known to scramble SSI includes in cases...
109
-if (!headers_sent())
119
+if (!headers_sent()) {
110 120
 	loadSession();
111
-else
121
+} else
112 122
 {
113 123
 	if (isset($_COOKIE[session_name()]) || isset($_REQUEST[session_name()]))
114 124
 	{
@@ -142,12 +152,14 @@  discard block
 block discarded – undo
142 152
 loadTheme(isset($ssi_theme) ? (int) $ssi_theme : 0);
143 153
 
144 154
 // @todo: probably not the best place, but somewhere it should be set...
145
-if (!headers_sent())
155
+if (!headers_sent()) {
146 156
 	header('Content-Type: text/html; charset=' . (empty($modSettings['global_character_set']) ? (empty($txt['lang_character_set']) ? 'ISO-8859-1' : $txt['lang_character_set']) : $modSettings['global_character_set']));
157
+}
147 158
 
148 159
 // Take care of any banning that needs to be done.
149
-if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true))
160
+if (isset($_REQUEST['ssi_ban']) || (isset($ssi_ban) && $ssi_ban === true)) {
150 161
 	is_not_banned();
162
+}
151 163
 
152 164
 // Do we allow guests in here?
153 165
 if (empty($ssi_guest_access) && empty($modSettings['allow_guestAccess']) && $user_info['is_guest'] && basename($_SERVER['PHP_SELF']) != 'SSI.php')
@@ -162,17 +174,19 @@  discard block
 block discarded – undo
162 174
 {
163 175
 	$context['template_layers'] = $ssi_layers;
164 176
 	template_header();
165
-}
166
-else
177
+} else {
167 178
 	setupThemeContext();
179
+}
168 180
 
169 181
 // Make sure they didn't muss around with the settings... but only if it's not cli.
170
-if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '')
182
+if (isset($_SERVER['REMOTE_ADDR']) && !isset($_SERVER['is_cli']) && session_id() == '') {
171 183
 	trigger_error($txt['ssi_session_broken'], E_USER_NOTICE);
184
+}
172 185
 
173 186
 // Without visiting the forum this session variable might not be set on submit.
174
-if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote'))
187
+if (!isset($_SESSION['USER_AGENT']) && (!isset($_GET['ssi_function']) || $_GET['ssi_function'] !== 'pollVote')) {
175 188
 	$_SESSION['USER_AGENT'] = $_SERVER['HTTP_USER_AGENT'];
189
+}
176 190
 
177 191
 // Have the ability to easily add functions to SSI.
178 192
 call_integration_hook('integrate_SSI');
@@ -181,11 +195,13 @@  discard block
 block discarded – undo
181 195
 if (basename($_SERVER['PHP_SELF']) == 'SSI.php')
182 196
 {
183 197
 	// You shouldn't just access SSI.php directly by URL!!
184
-	if (!isset($_GET['ssi_function']))
185
-		die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\''));
198
+	if (!isset($_GET['ssi_function'])) {
199
+			die(sprintf($txt['ssi_not_direct'], $user_info['is_admin'] ? '\'' . addslashes(__FILE__) . '\'' : '\'SSI.php\''));
200
+	}
186 201
 	// Call a function passed by GET.
187
-	if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest']))
188
-		call_user_func('ssi_' . $_GET['ssi_function']);
202
+	if (function_exists('ssi_' . $_GET['ssi_function']) && (!empty($modSettings['allow_guestAccess']) || !$user_info['is_guest'])) {
203
+			call_user_func('ssi_' . $_GET['ssi_function']);
204
+	}
189 205
 	exit;
190 206
 }
191 207
 
@@ -193,8 +209,9 @@  discard block
 block discarded – undo
193 209
 unset($_GET['ssi_function']);
194 210
 
195 211
 error_reporting($ssi_error_reporting);
196
-if (function_exists('set_magic_quotes_runtime'))
212
+if (function_exists('set_magic_quotes_runtime')) {
197 213
 	@set_magic_quotes_runtime($ssi_magic_quotes_runtime);
214
+}
198 215
 
199 216
 return true;
200 217
 
@@ -204,9 +221,10 @@  discard block
 block discarded – undo
204 221
  */
205 222
 function ssi_shutdown()
206 223
 {
207
-	if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown')
208
-		template_footer();
209
-}
224
+	if (!isset($_GET['ssi_function']) || $_GET['ssi_function'] != 'shutdown') {
225
+			template_footer();
226
+	}
227
+	}
210 228
 
211 229
 /**
212 230
  * Display a welcome message, like: Hey, User, you have 0 messages, 0 are new.
@@ -219,15 +237,17 @@  discard block
 block discarded – undo
219 237
 
220 238
 	if ($output_method == 'echo')
221 239
 	{
222
-		if ($context['user']['is_guest'])
223
-			echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup');
224
-		else
225
-			echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : '';
240
+		if ($context['user']['is_guest']) {
241
+					echo sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup');
242
+		} else {
243
+					echo $txt['hello_member'], ' <strong>', $context['user']['name'], '</strong>', allowedTo('pm_read') ? ', ' . (empty($context['user']['messages']) ? $txt['msg_alert_no_messages'] : (($context['user']['messages'] == 1 ? sprintf($txt['msg_alert_one_message'], $scripturl . '?action=pm') : sprintf($txt['msg_alert_many_message'], $scripturl . '?action=pm', $context['user']['messages'])) . ', ' . ($context['user']['unread_messages'] == 1 ? $txt['msg_alert_one_new'] : sprintf($txt['msg_alert_many_new'], $context['user']['unread_messages'])))) : '';
244
+		}
226 245
 	}
227 246
 	// Don't echo... then do what?!
228
-	else
229
-		return $context['user'];
230
-}
247
+	else {
248
+			return $context['user'];
249
+	}
250
+	}
231 251
 
232 252
 /**
233 253
  * Display a menu bar, like is displayed at the top of the forum.
@@ -238,12 +258,14 @@  discard block
 block discarded – undo
238 258
 {
239 259
 	global $context;
240 260
 
241
-	if ($output_method == 'echo')
242
-		template_menu();
261
+	if ($output_method == 'echo') {
262
+			template_menu();
263
+	}
243 264
 	// What else could this do?
244
-	else
245
-		return $context['menu_buttons'];
246
-}
265
+	else {
266
+			return $context['menu_buttons'];
267
+	}
268
+	}
247 269
 
248 270
 /**
249 271
  * Show a logout link.
@@ -255,20 +277,23 @@  discard block
 block discarded – undo
255 277
 {
256 278
 	global $context, $txt, $scripturl;
257 279
 
258
-	if ($redirect_to != '')
259
-		$_SESSION['logout_url'] = $redirect_to;
280
+	if ($redirect_to != '') {
281
+			$_SESSION['logout_url'] = $redirect_to;
282
+	}
260 283
 
261 284
 	// Guests can't log out.
262
-	if ($context['user']['is_guest'])
263
-		return false;
285
+	if ($context['user']['is_guest']) {
286
+			return false;
287
+	}
264 288
 
265 289
 	$link = '<a href="' . $scripturl . '?action=logout;' . $context['session_var'] . '=' . $context['session_id'] . '">' . $txt['logout'] . '</a>';
266 290
 
267
-	if ($output_method == 'echo')
268
-		echo $link;
269
-	else
270
-		return $link;
271
-}
291
+	if ($output_method == 'echo') {
292
+			echo $link;
293
+	} else {
294
+			return $link;
295
+	}
296
+	}
272 297
 
273 298
 /**
274 299
  * Recent post list:   [board] Subject by Poster    Date
@@ -284,17 +309,17 @@  discard block
 block discarded – undo
284 309
 	global $modSettings, $context;
285 310
 
286 311
 	// Excluding certain boards...
287
-	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0)
288
-		$exclude_boards = array($modSettings['recycle_board']);
289
-	else
290
-		$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
312
+	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) {
313
+			$exclude_boards = array($modSettings['recycle_board']);
314
+	} else {
315
+			$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
316
+	}
291 317
 
292 318
 	// What about including certain boards - note we do some protection here as pre-2.0 didn't have this parameter.
293 319
 	if (is_array($include_boards) || (int) $include_boards === $include_boards)
294 320
 	{
295 321
 		$include_boards = is_array($include_boards) ? $include_boards : array($include_boards);
296
-	}
297
-	elseif ($include_boards != null)
322
+	} elseif ($include_boards != null)
298 323
 	{
299 324
 		$include_boards = array();
300 325
 	}
@@ -331,8 +356,9 @@  discard block
 block discarded – undo
331 356
 {
332 357
 	global $modSettings;
333 358
 
334
-	if (empty($post_ids))
335
-		return;
359
+	if (empty($post_ids)) {
360
+			return;
361
+	}
336 362
 
337 363
 	// Allow the user to request more than one - why not?
338 364
 	$post_ids = is_array($post_ids) ? $post_ids : array($post_ids);
@@ -367,8 +393,9 @@  discard block
 block discarded – undo
367 393
 	global $scripturl, $txt, $user_info;
368 394
 	global $modSettings, $smcFunc, $context;
369 395
 
370
-	if (!empty($modSettings['enable_likes']))
371
-		$context['can_like'] = allowedTo('likes_like');
396
+	if (!empty($modSettings['enable_likes'])) {
397
+			$context['can_like'] = allowedTo('likes_like');
398
+	}
372 399
 
373 400
 	// Find all the posts. Newer ones will have higher IDs.
374 401
 	$request = $smcFunc['db_query']('substring', '
@@ -434,12 +461,13 @@  discard block
 block discarded – undo
434 461
 		);
435 462
 
436 463
 		// Get the likes for each message.
437
-		if (!empty($modSettings['enable_likes']))
438
-			$posts[$row['id_msg']]['likes'] = array(
464
+		if (!empty($modSettings['enable_likes'])) {
465
+					$posts[$row['id_msg']]['likes'] = array(
439 466
 				'count' => $row['likes'],
440 467
 				'you' => in_array($row['id_msg'], prepareLikesContext($row['id_topic'])),
441 468
 				'can_like' => !$context['user']['is_guest'] && $row['id_member'] != $context['user']['id'] && !empty($context['can_like']),
442 469
 			);
470
+		}
443 471
 	}
444 472
 	$smcFunc['db_free_result']($request);
445 473
 
@@ -447,13 +475,14 @@  discard block
 block discarded – undo
447 475
 	call_integration_hook('integrate_ssi_queryPosts', array(&$posts));
448 476
 
449 477
 	// Just return it.
450
-	if ($output_method != 'echo' || empty($posts))
451
-		return $posts;
478
+	if ($output_method != 'echo' || empty($posts)) {
479
+			return $posts;
480
+	}
452 481
 
453 482
 	echo '
454 483
 		<table style="border: none" class="ssi_table">';
455
-	foreach ($posts as $post)
456
-		echo '
484
+	foreach ($posts as $post) {
485
+			echo '
457 486
 			<tr>
458 487
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
459 488
 					[', $post['board']['link'], ']
@@ -467,6 +496,7 @@  discard block
 block discarded – undo
467 496
 					', $post['time'], '
468 497
 				</td>
469 498
 			</tr>';
499
+	}
470 500
 	echo '
471 501
 		</table>';
472 502
 }
@@ -484,25 +514,26 @@  discard block
 block discarded – undo
484 514
 	global $settings, $scripturl, $txt, $user_info;
485 515
 	global $modSettings, $smcFunc, $context;
486 516
 
487
-	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0)
488
-		$exclude_boards = array($modSettings['recycle_board']);
489
-	else
490
-		$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
517
+	if ($exclude_boards === null && !empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0) {
518
+			$exclude_boards = array($modSettings['recycle_board']);
519
+	} else {
520
+			$exclude_boards = empty($exclude_boards) ? array() : (is_array($exclude_boards) ? $exclude_boards : array($exclude_boards));
521
+	}
491 522
 
492 523
 	// Only some boards?.
493 524
 	if (is_array($include_boards) || (int) $include_boards === $include_boards)
494 525
 	{
495 526
 		$include_boards = is_array($include_boards) ? $include_boards : array($include_boards);
496
-	}
497
-	elseif ($include_boards != null)
527
+	} elseif ($include_boards != null)
498 528
 	{
499 529
 		$output_method = $include_boards;
500 530
 		$include_boards = array();
501 531
 	}
502 532
 
503 533
 	$icon_sources = array();
504
-	foreach ($context['stable_icons'] as $icon)
505
-		$icon_sources[$icon] = 'images_url';
534
+	foreach ($context['stable_icons'] as $icon) {
535
+			$icon_sources[$icon] = 'images_url';
536
+	}
506 537
 
507 538
 	// Find all the posts in distinct topics.  Newer ones will have higher IDs.
508 539
 	$request = $smcFunc['db_query']('substring', '
@@ -527,13 +558,15 @@  discard block
 block discarded – undo
527 558
 		)
528 559
 	);
529 560
 	$topics = array();
530
-	while ($row = $smcFunc['db_fetch_assoc']($request))
531
-		$topics[$row['id_topic']] = $row;
561
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
562
+			$topics[$row['id_topic']] = $row;
563
+	}
532 564
 	$smcFunc['db_free_result']($request);
533 565
 
534 566
 	// Did we find anything? If not, bail.
535
-	if (empty($topics))
536
-		return array();
567
+	if (empty($topics)) {
568
+			return array();
569
+	}
537 570
 
538 571
 	$recycle_board = !empty($modSettings['recycle_enable']) && !empty($modSettings['recycle_board']) ? (int) $modSettings['recycle_board'] : 0;
539 572
 
@@ -561,19 +594,22 @@  discard block
 block discarded – undo
561 594
 	while ($row = $smcFunc['db_fetch_assoc']($request))
562 595
 	{
563 596
 		$row['body'] = strip_tags(strtr(parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']), array('<br>' => '&#10;')));
564
-		if ($smcFunc['strlen']($row['body']) > 128)
565
-			$row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...';
597
+		if ($smcFunc['strlen']($row['body']) > 128) {
598
+					$row['body'] = $smcFunc['substr']($row['body'], 0, 128) . '...';
599
+		}
566 600
 
567 601
 		// Censor the subject.
568 602
 		censorText($row['subject']);
569 603
 		censorText($row['body']);
570 604
 
571 605
 		// Recycled icon
572
-		if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board'])
573
-			$row['icon'] = 'recycled';
606
+		if (!empty($recycle_board) && $topics[$row['id_topic']]['id_board']) {
607
+					$row['icon'] = 'recycled';
608
+		}
574 609
 
575
-		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']]))
576
-			$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
610
+		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) {
611
+					$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
612
+		}
577 613
 
578 614
 		// Build the array.
579 615
 		$posts[] = array(
@@ -612,13 +648,14 @@  discard block
 block discarded – undo
612 648
 	call_integration_hook('integrate_ssi_recentTopics', array(&$posts));
613 649
 
614 650
 	// Just return it.
615
-	if ($output_method != 'echo' || empty($posts))
616
-		return $posts;
651
+	if ($output_method != 'echo' || empty($posts)) {
652
+			return $posts;
653
+	}
617 654
 
618 655
 	echo '
619 656
 		<table style="border: none" class="ssi_table">';
620
-	foreach ($posts as $post)
621
-		echo '
657
+	foreach ($posts as $post) {
658
+			echo '
622 659
 			<tr>
623 660
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
624 661
 					[', $post['board']['link'], ']
@@ -632,6 +669,7 @@  discard block
 block discarded – undo
632 669
 					', $post['time'], '
633 670
 				</td>
634 671
 			</tr>';
672
+	}
635 673
 	echo '
636 674
 		</table>';
637 675
 }
@@ -656,27 +694,30 @@  discard block
 block discarded – undo
656 694
 		)
657 695
 	);
658 696
 	$return = array();
659
-	while ($row = $smcFunc['db_fetch_assoc']($request))
660
-		$return[] = array(
697
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
698
+			$return[] = array(
661 699
 			'id' => $row['id_member'],
662 700
 			'name' => $row['real_name'],
663 701
 			'href' => $scripturl . '?action=profile;u=' . $row['id_member'],
664 702
 			'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>',
665 703
 			'posts' => $row['posts']
666 704
 		);
705
+	}
667 706
 	$smcFunc['db_free_result']($request);
668 707
 
669 708
 	// If mods want to do somthing with this list of members, let them do that now.
670 709
 	call_integration_hook('integrate_ssi_topPoster', array(&$return));
671 710
 
672 711
 	// Just return all the top posters.
673
-	if ($output_method != 'echo')
674
-		return $return;
712
+	if ($output_method != 'echo') {
713
+			return $return;
714
+	}
675 715
 
676 716
 	// Make a quick array to list the links in.
677 717
 	$temp_array = array();
678
-	foreach ($return as $member)
679
-		$temp_array[] = $member['link'];
718
+	foreach ($return as $member) {
719
+			$temp_array[] = $member['link'];
720
+	}
680 721
 
681 722
 	echo implode(', ', $temp_array);
682 723
 }
@@ -708,8 +749,8 @@  discard block
 block discarded – undo
708 749
 		)
709 750
 	);
710 751
 	$boards = array();
711
-	while ($row = $smcFunc['db_fetch_assoc']($request))
712
-		$boards[] = array(
752
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
753
+			$boards[] = array(
713 754
 			'id' => $row['id_board'],
714 755
 			'num_posts' => $row['num_posts'],
715 756
 			'num_topics' => $row['num_topics'],
@@ -718,14 +759,16 @@  discard block
 block discarded – undo
718 759
 			'href' => $scripturl . '?board=' . $row['id_board'] . '.0',
719 760
 			'link' => '<a href="' . $scripturl . '?board=' . $row['id_board'] . '.0">' . $row['name'] . '</a>'
720 761
 		);
762
+	}
721 763
 	$smcFunc['db_free_result']($request);
722 764
 
723 765
 	// If mods want to do somthing with this list of boards, let them do that now.
724 766
 	call_integration_hook('integrate_ssi_topBoards', array(&$boards));
725 767
 
726 768
 	// If we shouldn't output or have nothing to output, just jump out.
727
-	if ($output_method != 'echo' || empty($boards))
728
-		return $boards;
769
+	if ($output_method != 'echo' || empty($boards)) {
770
+			return $boards;
771
+	}
729 772
 
730 773
 	echo '
731 774
 		<table class="ssi_table">
@@ -734,13 +777,14 @@  discard block
 block discarded – undo
734 777
 				<th style="text-align: left">', $txt['board_topics'], '</th>
735 778
 				<th style="text-align: left">', $txt['posts'], '</th>
736 779
 			</tr>';
737
-	foreach ($boards as $sBoard)
738
-		echo '
780
+	foreach ($boards as $sBoard) {
781
+			echo '
739 782
 			<tr>
740 783
 				<td>', $sBoard['link'], $sBoard['new'] ? ' <a href="' . $sBoard['href'] . '"><span class="new_posts">' . $txt['new'] . '</span></a>' : '', '</td>
741 784
 				<td style="text-align: right">', comma_format($sBoard['num_topics']), '</td>
742 785
 				<td style="text-align: right">', comma_format($sBoard['num_posts']), '</td>
743 786
 			</tr>';
787
+	}
744 788
 	echo '
745 789
 		</table>';
746 790
 }
@@ -773,12 +817,13 @@  discard block
 block discarded – undo
773 817
 			)
774 818
 		);
775 819
 		$topic_ids = array();
776
-		while ($row = $smcFunc['db_fetch_assoc']($request))
777
-			$topic_ids[] = $row['id_topic'];
820
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
821
+					$topic_ids[] = $row['id_topic'];
822
+		}
778 823
 		$smcFunc['db_free_result']($request);
824
+	} else {
825
+			$topic_ids = array();
779 826
 	}
780
-	else
781
-		$topic_ids = array();
782 827
 
783 828
 	$request = $smcFunc['db_query']('', '
784 829
 		SELECT m.subject, m.id_topic, t.num_views, t.num_replies
@@ -817,8 +862,9 @@  discard block
 block discarded – undo
817 862
 	// If mods want to do somthing with this list of topics, let them do that now.
818 863
 	call_integration_hook('integrate_ssi_topTopics', array(&$topics, $type));
819 864
 
820
-	if ($output_method != 'echo' || empty($topics))
821
-		return $topics;
865
+	if ($output_method != 'echo' || empty($topics)) {
866
+			return $topics;
867
+	}
822 868
 
823 869
 	echo '
824 870
 		<table class="ssi_table">
@@ -827,8 +873,8 @@  discard block
 block discarded – undo
827 873
 				<th style="text-align: left">', $txt['views'], '</th>
828 874
 				<th style="text-align: left">', $txt['replies'], '</th>
829 875
 			</tr>';
830
-	foreach ($topics as $sTopic)
831
-		echo '
876
+	foreach ($topics as $sTopic) {
877
+			echo '
832 878
 			<tr>
833 879
 				<td style="text-align: left">
834 880
 					', $sTopic['link'], '
@@ -836,6 +882,7 @@  discard block
 block discarded – undo
836 882
 				<td style="text-align: right">', comma_format($sTopic['num_views']), '</td>
837 883
 				<td style="text-align: right">', comma_format($sTopic['num_replies']), '</td>
838 884
 			</tr>';
885
+	}
839 886
 	echo '
840 887
 		</table>';
841 888
 }
@@ -871,12 +918,13 @@  discard block
 block discarded – undo
871 918
 {
872 919
 	global $txt, $context;
873 920
 
874
-	if ($output_method == 'echo')
875
-		echo '
921
+	if ($output_method == 'echo') {
922
+			echo '
876 923
 	', sprintf($txt['welcome_newest_member'], $context['common_stats']['latest_member']['link']), '<br>';
877
-	else
878
-		return $context['common_stats']['latest_member'];
879
-}
924
+	} else {
925
+			return $context['common_stats']['latest_member'];
926
+	}
927
+	}
880 928
 
881 929
 /**
882 930
  * Fetches a random member.
@@ -925,8 +973,9 @@  discard block
 block discarded – undo
925 973
 	}
926 974
 
927 975
 	// Just to be sure put the random generator back to something... random.
928
-	if ($random_type != '')
929
-		mt_srand(time());
976
+	if ($random_type != '') {
977
+			mt_srand(time());
978
+	}
930 979
 
931 980
 	return $result;
932 981
 }
@@ -939,8 +988,9 @@  discard block
 block discarded – undo
939 988
  */
940 989
 function ssi_fetchMember($member_ids = array(), $output_method = 'echo')
941 990
 {
942
-	if (empty($member_ids))
943
-		return;
991
+	if (empty($member_ids)) {
992
+			return;
993
+	}
944 994
 
945 995
 	// Can have more than one member if you really want...
946 996
 	$member_ids = is_array($member_ids) ? $member_ids : array($member_ids);
@@ -965,8 +1015,9 @@  discard block
 block discarded – undo
965 1015
  */
966 1016
 function ssi_fetchGroupMembers($group_id = null, $output_method = 'echo')
967 1017
 {
968
-	if ($group_id === null)
969
-		return;
1018
+	if ($group_id === null) {
1019
+			return;
1020
+	}
970 1021
 
971 1022
 	$query_where = '
972 1023
 		id_group = {int:id_group}
@@ -993,8 +1044,9 @@  discard block
 block discarded – undo
993 1044
 {
994 1045
 	global $smcFunc, $memberContext;
995 1046
 
996
-	if ($query_where === null)
997
-		return;
1047
+	if ($query_where === null) {
1048
+			return;
1049
+	}
998 1050
 
999 1051
 	// Fetch the members in question.
1000 1052
 	$request = $smcFunc['db_query']('', '
@@ -1007,12 +1059,14 @@  discard block
 block discarded – undo
1007 1059
 		))
1008 1060
 	);
1009 1061
 	$members = array();
1010
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1011
-		$members[] = $row['id_member'];
1062
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
1063
+			$members[] = $row['id_member'];
1064
+	}
1012 1065
 	$smcFunc['db_free_result']($request);
1013 1066
 
1014
-	if (empty($members))
1015
-		return array();
1067
+	if (empty($members)) {
1068
+			return array();
1069
+	}
1016 1070
 
1017 1071
 	// If mods want to do somthing with this list of members, let them do that now.
1018 1072
 	call_integration_hook('integrate_ssi_queryMembers', array(&$members));
@@ -1021,23 +1075,25 @@  discard block
 block discarded – undo
1021 1075
 	loadMemberData($members);
1022 1076
 
1023 1077
 	// Draw the table!
1024
-	if ($output_method == 'echo')
1025
-		echo '
1078
+	if ($output_method == 'echo') {
1079
+			echo '
1026 1080
 		<table style="border: none" class="ssi_table">';
1081
+	}
1027 1082
 
1028 1083
 	$query_members = array();
1029 1084
 	foreach ($members as $member)
1030 1085
 	{
1031 1086
 		// Load their context data.
1032
-		if (!loadMemberContext($member))
1033
-			continue;
1087
+		if (!loadMemberContext($member)) {
1088
+					continue;
1089
+		}
1034 1090
 
1035 1091
 		// Store this member's information.
1036 1092
 		$query_members[$member] = $memberContext[$member];
1037 1093
 
1038 1094
 		// Only do something if we're echo'ing.
1039
-		if ($output_method == 'echo')
1040
-			echo '
1095
+		if ($output_method == 'echo') {
1096
+					echo '
1041 1097
 			<tr>
1042 1098
 				<td style="text-align: right; vertical-align: top; white-space: nowrap">
1043 1099
 					', $query_members[$member]['link'], '
@@ -1045,12 +1101,14 @@  discard block
 block discarded – undo
1045 1101
 					<br>', $query_members[$member]['avatar']['image'], '
1046 1102
 				</td>
1047 1103
 			</tr>';
1104
+		}
1048 1105
 	}
1049 1106
 
1050 1107
 	// End the table if appropriate.
1051
-	if ($output_method == 'echo')
1052
-		echo '
1108
+	if ($output_method == 'echo') {
1109
+			echo '
1053 1110
 		</table>';
1111
+	}
1054 1112
 
1055 1113
 	// Send back the data.
1056 1114
 	return $query_members;
@@ -1065,8 +1123,9 @@  discard block
 block discarded – undo
1065 1123
 {
1066 1124
 	global $txt, $scripturl, $modSettings, $smcFunc;
1067 1125
 
1068
-	if (!allowedTo('view_stats'))
1069
-		return;
1126
+	if (!allowedTo('view_stats')) {
1127
+			return;
1128
+	}
1070 1129
 
1071 1130
 	$totals = array(
1072 1131
 		'members' => $modSettings['totalMembers'],
@@ -1095,8 +1154,9 @@  discard block
 block discarded – undo
1095 1154
 	// If mods want to do somthing with the board stats, let them do that now.
1096 1155
 	call_integration_hook('integrate_ssi_boardStats', array(&$totals));
1097 1156
 
1098
-	if ($output_method != 'echo')
1099
-		return $totals;
1157
+	if ($output_method != 'echo') {
1158
+			return $totals;
1159
+	}
1100 1160
 
1101 1161
 	echo '
1102 1162
 		', $txt['total_members'], ': <a href="', $scripturl . '?action=mlist">', comma_format($totals['members']), '</a><br>
@@ -1125,8 +1185,8 @@  discard block
 block discarded – undo
1125 1185
 	call_integration_hook('integrate_ssi_whosOnline', array(&$return));
1126 1186
 
1127 1187
 	// Add some redundancy for backwards compatibility reasons.
1128
-	if ($output_method != 'echo')
1129
-		return $return + array(
1188
+	if ($output_method != 'echo') {
1189
+			return $return + array(
1130 1190
 			'users' => $return['users_online'],
1131 1191
 			'guests' => $return['num_guests'],
1132 1192
 			'hidden' => $return['num_users_hidden'],
@@ -1134,29 +1194,35 @@  discard block
 block discarded – undo
1134 1194
 			'num_users' => $return['num_users_online'],
1135 1195
 			'total_users' => $return['num_users_online'] + $return['num_guests'],
1136 1196
 		);
1197
+	}
1137 1198
 
1138 1199
 	echo '
1139 1200
 		', comma_format($return['num_guests']), ' ', $return['num_guests'] == 1 ? $txt['guest'] : $txt['guests'], ', ', comma_format($return['num_users_online']), ' ', $return['num_users_online'] == 1 ? $txt['user'] : $txt['users'];
1140 1201
 
1141 1202
 	$bracketList = array();
1142
-	if (!empty($user_info['buddies']))
1143
-		$bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']);
1144
-	if (!empty($return['num_spiders']))
1145
-		$bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']);
1146
-	if (!empty($return['num_users_hidden']))
1147
-		$bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden'];
1203
+	if (!empty($user_info['buddies'])) {
1204
+			$bracketList[] = comma_format($return['num_buddies']) . ' ' . ($return['num_buddies'] == 1 ? $txt['buddy'] : $txt['buddies']);
1205
+	}
1206
+	if (!empty($return['num_spiders'])) {
1207
+			$bracketList[] = comma_format($return['num_spiders']) . ' ' . ($return['num_spiders'] == 1 ? $txt['spider'] : $txt['spiders']);
1208
+	}
1209
+	if (!empty($return['num_users_hidden'])) {
1210
+			$bracketList[] = comma_format($return['num_users_hidden']) . ' ' . $txt['hidden'];
1211
+	}
1148 1212
 
1149
-	if (!empty($bracketList))
1150
-		echo ' (' . implode(', ', $bracketList) . ')';
1213
+	if (!empty($bracketList)) {
1214
+			echo ' (' . implode(', ', $bracketList) . ')';
1215
+	}
1151 1216
 
1152 1217
 	echo '<br>
1153 1218
 			', implode(', ', $return['list_users_online']);
1154 1219
 
1155 1220
 	// Showing membergroups?
1156
-	if (!empty($settings['show_group_key']) && !empty($return['membergroups']))
1157
-		echo '<br>
1221
+	if (!empty($settings['show_group_key']) && !empty($return['membergroups'])) {
1222
+			echo '<br>
1158 1223
 			[' . implode(']&nbsp;&nbsp;[', $return['membergroups']) . ']';
1159
-}
1224
+	}
1225
+	}
1160 1226
 
1161 1227
 /**
1162 1228
  * Just like whosOnline except it also logs the online presence.
@@ -1167,11 +1233,12 @@  discard block
 block discarded – undo
1167 1233
 {
1168 1234
 	writeLog();
1169 1235
 
1170
-	if ($output_method != 'echo')
1171
-		return ssi_whosOnline($output_method);
1172
-	else
1173
-		ssi_whosOnline($output_method);
1174
-}
1236
+	if ($output_method != 'echo') {
1237
+			return ssi_whosOnline($output_method);
1238
+	} else {
1239
+			ssi_whosOnline($output_method);
1240
+	}
1241
+	}
1175 1242
 
1176 1243
 // Shows a login box.
1177 1244
 /**
@@ -1184,11 +1251,13 @@  discard block
 block discarded – undo
1184 1251
 {
1185 1252
 	global $scripturl, $txt, $user_info, $context;
1186 1253
 
1187
-	if ($redirect_to != '')
1188
-		$_SESSION['login_url'] = $redirect_to;
1254
+	if ($redirect_to != '') {
1255
+			$_SESSION['login_url'] = $redirect_to;
1256
+	}
1189 1257
 
1190
-	if ($output_method != 'echo' || !$user_info['is_guest'])
1191
-		return $user_info['is_guest'];
1258
+	if ($output_method != 'echo' || !$user_info['is_guest']) {
1259
+			return $user_info['is_guest'];
1260
+	}
1192 1261
 
1193 1262
 	// Create a login token
1194 1263
 	createToken('login');
@@ -1240,8 +1309,9 @@  discard block
 block discarded – undo
1240 1309
 
1241 1310
 	$boardsAllowed = array_intersect(boardsAllowedTo('poll_view'), boardsAllowedTo('poll_vote'));
1242 1311
 
1243
-	if (empty($boardsAllowed))
1244
-		return array();
1312
+	if (empty($boardsAllowed)) {
1313
+			return array();
1314
+	}
1245 1315
 
1246 1316
 	$request = $smcFunc['db_query']('', '
1247 1317
 		SELECT p.id_poll, p.question, t.id_topic, p.max_votes, p.guest_vote, p.hide_results, p.expire_time
@@ -1274,12 +1344,14 @@  discard block
 block discarded – undo
1274 1344
 	$smcFunc['db_free_result']($request);
1275 1345
 
1276 1346
 	// This user has voted on all the polls.
1277
-	if (empty($row) || !is_array($row))
1278
-		return array();
1347
+	if (empty($row) || !is_array($row)) {
1348
+			return array();
1349
+	}
1279 1350
 
1280 1351
 	// If this is a guest who's voted we'll through ourselves to show poll to show the results.
1281
-	if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote'])))))
1282
-		return ssi_showPoll($row['id_topic'], $output_method);
1352
+	if ($user_info['is_guest'] && (!$row['guest_vote'] || (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))))) {
1353
+			return ssi_showPoll($row['id_topic'], $output_method);
1354
+	}
1283 1355
 
1284 1356
 	$request = $smcFunc['db_query']('', '
1285 1357
 		SELECT COUNT(DISTINCT id_member)
@@ -1343,8 +1415,9 @@  discard block
 block discarded – undo
1343 1415
 	// If mods want to do somthing with this list of polls, let them do that now.
1344 1416
 	call_integration_hook('integrate_ssi_recentPoll', array(&$return, $topPollInstead));
1345 1417
 
1346
-	if ($output_method != 'echo')
1347
-		return $return;
1418
+	if ($output_method != 'echo') {
1419
+			return $return;
1420
+	}
1348 1421
 
1349 1422
 	if ($allow_view_results)
1350 1423
 	{
@@ -1353,19 +1426,20 @@  discard block
 block discarded – undo
1353 1426
 			<strong>', $return['question'], '</strong><br>
1354 1427
 			', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : '';
1355 1428
 
1356
-		foreach ($return['options'] as $option)
1357
-			echo '
1429
+		foreach ($return['options'] as $option) {
1430
+					echo '
1358 1431
 			<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
1432
+		}
1359 1433
 
1360 1434
 		echo '
1361 1435
 			<input type="submit" value="', $txt['poll_vote'], '" class="button_submit">
1362 1436
 			<input type="hidden" name="poll" value="', $return['id'], '">
1363 1437
 			<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1364 1438
 		</form>';
1439
+	} else {
1440
+			echo $txt['poll_cannot_see'];
1441
+	}
1365 1442
 	}
1366
-	else
1367
-		echo $txt['poll_cannot_see'];
1368
-}
1369 1443
 
1370 1444
 /**
1371 1445
  * Shows the poll from the specified topic
@@ -1379,13 +1453,15 @@  discard block
 block discarded – undo
1379 1453
 
1380 1454
 	$boardsAllowed = boardsAllowedTo('poll_view');
1381 1455
 
1382
-	if (empty($boardsAllowed))
1383
-		return array();
1456
+	if (empty($boardsAllowed)) {
1457
+			return array();
1458
+	}
1384 1459
 
1385
-	if ($topic === null && isset($_REQUEST['ssi_topic']))
1386
-		$topic = (int) $_REQUEST['ssi_topic'];
1387
-	else
1388
-		$topic = (int) $topic;
1460
+	if ($topic === null && isset($_REQUEST['ssi_topic'])) {
1461
+			$topic = (int) $_REQUEST['ssi_topic'];
1462
+	} else {
1463
+			$topic = (int) $topic;
1464
+	}
1389 1465
 
1390 1466
 	$request = $smcFunc['db_query']('', '
1391 1467
 		SELECT
@@ -1406,17 +1482,18 @@  discard block
 block discarded – undo
1406 1482
 	);
1407 1483
 
1408 1484
 	// Either this topic has no poll, or the user cannot view it.
1409
-	if ($smcFunc['db_num_rows']($request) == 0)
1410
-		return array();
1485
+	if ($smcFunc['db_num_rows']($request) == 0) {
1486
+			return array();
1487
+	}
1411 1488
 
1412 1489
 	$row = $smcFunc['db_fetch_assoc']($request);
1413 1490
 	$smcFunc['db_free_result']($request);
1414 1491
 
1415 1492
 	// Check if they can vote.
1416 1493
 	$already_voted = false;
1417
-	if (!empty($row['expire_time']) && $row['expire_time'] < time())
1418
-		$allow_vote = false;
1419
-	elseif ($user_info['is_guest'])
1494
+	if (!empty($row['expire_time']) && $row['expire_time'] < time()) {
1495
+			$allow_vote = false;
1496
+	} elseif ($user_info['is_guest'])
1420 1497
 	{
1421 1498
 		// There's a difference between "allowed to vote" and "already voted"...
1422 1499
 		$allow_vote = $row['guest_vote'];
@@ -1426,10 +1503,9 @@  discard block
 block discarded – undo
1426 1503
 		{
1427 1504
 			$already_voted = true;
1428 1505
 		}
1429
-	}
1430
-	elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board']))
1431
-		$allow_vote = false;
1432
-	else
1506
+	} elseif (!empty($row['voting_locked']) || !allowedTo('poll_vote', $row['id_board'])) {
1507
+			$allow_vote = false;
1508
+	} else
1433 1509
 	{
1434 1510
 		$request = $smcFunc['db_query']('', '
1435 1511
 			SELECT id_member
@@ -1511,8 +1587,9 @@  discard block
 block discarded – undo
1511 1587
 	// If mods want to do somthing with this poll, let them do that now.
1512 1588
 	call_integration_hook('integrate_ssi_showPoll', array(&$return));
1513 1589
 
1514
-	if ($output_method != 'echo')
1515
-		return $return;
1590
+	if ($output_method != 'echo') {
1591
+			return $return;
1592
+	}
1516 1593
 
1517 1594
 	if ($return['allow_vote'])
1518 1595
 	{
@@ -1521,17 +1598,17 @@  discard block
 block discarded – undo
1521 1598
 				<strong>', $return['question'], '</strong><br>
1522 1599
 				', !empty($return['allowed_warning']) ? $return['allowed_warning'] . '<br>' : '';
1523 1600
 
1524
-		foreach ($return['options'] as $option)
1525
-			echo '
1601
+		foreach ($return['options'] as $option) {
1602
+					echo '
1526 1603
 				<label for="', $option['id'], '">', $option['vote_button'], ' ', $option['option'], '</label><br>';
1604
+		}
1527 1605
 
1528 1606
 		echo '
1529 1607
 				<input type="submit" value="', $txt['poll_vote'], '" class="button_submit">
1530 1608
 				<input type="hidden" name="poll" value="', $return['id'], '">
1531 1609
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1532 1610
 			</form>';
1533
-	}
1534
-	else
1611
+	} else
1535 1612
 	{
1536 1613
 		echo '
1537 1614
 			<div class="ssi_poll">
@@ -1611,27 +1688,32 @@  discard block
 block discarded – undo
1611 1688
 			'is_approved' => 1,
1612 1689
 		)
1613 1690
 	);
1614
-	if ($smcFunc['db_num_rows']($request) == 0)
1615
-		die;
1691
+	if ($smcFunc['db_num_rows']($request) == 0) {
1692
+			die;
1693
+	}
1616 1694
 	$row = $smcFunc['db_fetch_assoc']($request);
1617 1695
 	$smcFunc['db_free_result']($request);
1618 1696
 
1619
-	if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time']))
1620
-		redirectexit('topic=' . $row['id_topic'] . '.0');
1697
+	if (!empty($row['voting_locked']) || ($row['selected'] != -1 && !$user_info['is_guest']) || (!empty($row['expire_time']) && time() > $row['expire_time'])) {
1698
+			redirectexit('topic=' . $row['id_topic'] . '.0');
1699
+	}
1621 1700
 
1622 1701
 	// Too many options checked?
1623
-	if (count($_REQUEST['options']) > $row['max_votes'])
1624
-		redirectexit('topic=' . $row['id_topic'] . '.0');
1702
+	if (count($_REQUEST['options']) > $row['max_votes']) {
1703
+			redirectexit('topic=' . $row['id_topic'] . '.0');
1704
+	}
1625 1705
 
1626 1706
 	// It's a guest who has already voted?
1627 1707
 	if ($user_info['is_guest'])
1628 1708
 	{
1629 1709
 		// Guest voting disabled?
1630
-		if (!$row['guest_vote'])
1631
-			redirectexit('topic=' . $row['id_topic'] . '.0');
1710
+		if (!$row['guest_vote']) {
1711
+					redirectexit('topic=' . $row['id_topic'] . '.0');
1712
+		}
1632 1713
 		// Already voted?
1633
-		elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote'])))
1634
-			redirectexit('topic=' . $row['id_topic'] . '.0');
1714
+		elseif (isset($_COOKIE['guest_poll_vote']) && in_array($row['id_poll'], explode(',', $_COOKIE['guest_poll_vote']))) {
1715
+					redirectexit('topic=' . $row['id_topic'] . '.0');
1716
+		}
1635 1717
 	}
1636 1718
 
1637 1719
 	$sOptions = array();
@@ -1685,11 +1767,13 @@  discard block
 block discarded – undo
1685 1767
 {
1686 1768
 	global $scripturl, $txt, $context;
1687 1769
 
1688
-	if (!allowedTo('search_posts'))
1689
-		return;
1770
+	if (!allowedTo('search_posts')) {
1771
+			return;
1772
+	}
1690 1773
 
1691
-	if ($output_method != 'echo')
1692
-		return $scripturl . '?action=search';
1774
+	if ($output_method != 'echo') {
1775
+			return $scripturl . '?action=search';
1776
+	}
1693 1777
 
1694 1778
 	echo '
1695 1779
 		<form action="', $scripturl, '?action=search2" method="post" accept-charset="', $context['character_set'], '">
@@ -1711,8 +1795,9 @@  discard block
 block discarded – undo
1711 1795
 	// If mods want to do somthing with the news, let them do that now. Don't need to pass the news line itself, since it is already in $context.
1712 1796
 	call_integration_hook('integrate_ssi_news');
1713 1797
 
1714
-	if ($output_method != 'echo')
1715
-		return $context['random_news_line'];
1798
+	if ($output_method != 'echo') {
1799
+			return $context['random_news_line'];
1800
+	}
1716 1801
 
1717 1802
 	echo $context['random_news_line'];
1718 1803
 }
@@ -1726,8 +1811,9 @@  discard block
 block discarded – undo
1726 1811
 {
1727 1812
 	global $scripturl, $modSettings, $user_info;
1728 1813
 
1729
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view'))
1730
-		return;
1814
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view') || !allowedTo('profile_view')) {
1815
+			return;
1816
+	}
1731 1817
 
1732 1818
 	$eventOptions = array(
1733 1819
 		'include_birthdays' => true,
@@ -1738,13 +1824,15 @@  discard block
 block discarded – undo
1738 1824
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1739 1825
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1740 1826
 
1741
-	if ($output_method != 'echo')
1742
-		return $return['calendar_birthdays'];
1827
+	if ($output_method != 'echo') {
1828
+			return $return['calendar_birthdays'];
1829
+	}
1743 1830
 
1744
-	foreach ($return['calendar_birthdays'] as $member)
1745
-		echo '
1831
+	foreach ($return['calendar_birthdays'] as $member) {
1832
+			echo '
1746 1833
 			<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">' . $member['name'] . '</span>' . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>' . (!$member['is_last'] ? ', ' : '');
1747
-}
1834
+	}
1835
+	}
1748 1836
 
1749 1837
 /**
1750 1838
  * Shows today's holidays.
@@ -1755,8 +1843,9 @@  discard block
 block discarded – undo
1755 1843
 {
1756 1844
 	global $modSettings, $user_info;
1757 1845
 
1758
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1759
-		return;
1846
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1847
+			return;
1848
+	}
1760 1849
 
1761 1850
 	$eventOptions = array(
1762 1851
 		'include_holidays' => true,
@@ -1767,8 +1856,9 @@  discard block
 block discarded – undo
1767 1856
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1768 1857
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1769 1858
 
1770
-	if ($output_method != 'echo')
1771
-		return $return['calendar_holidays'];
1859
+	if ($output_method != 'echo') {
1860
+			return $return['calendar_holidays'];
1861
+	}
1772 1862
 
1773 1863
 	echo '
1774 1864
 		', implode(', ', $return['calendar_holidays']);
@@ -1782,8 +1872,9 @@  discard block
 block discarded – undo
1782 1872
 {
1783 1873
 	global $modSettings, $user_info;
1784 1874
 
1785
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1786
-		return;
1875
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1876
+			return;
1877
+	}
1787 1878
 
1788 1879
 	$eventOptions = array(
1789 1880
 		'include_events' => true,
@@ -1794,14 +1885,16 @@  discard block
 block discarded – undo
1794 1885
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1795 1886
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1796 1887
 
1797
-	if ($output_method != 'echo')
1798
-		return $return['calendar_events'];
1888
+	if ($output_method != 'echo') {
1889
+			return $return['calendar_events'];
1890
+	}
1799 1891
 
1800 1892
 	foreach ($return['calendar_events'] as $event)
1801 1893
 	{
1802
-		if ($event['can_edit'])
1803
-			echo '
1894
+		if ($event['can_edit']) {
1895
+					echo '
1804 1896
 	<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
1897
+		}
1805 1898
 		echo '
1806 1899
 	' . $event['link'] . (!$event['is_last'] ? ', ' : '');
1807 1900
 	}
@@ -1816,8 +1909,9 @@  discard block
 block discarded – undo
1816 1909
 {
1817 1910
 	global $modSettings, $txt, $scripturl, $user_info;
1818 1911
 
1819
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
1820
-		return;
1912
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
1913
+			return;
1914
+	}
1821 1915
 
1822 1916
 	$eventOptions = array(
1823 1917
 		'include_birthdays' => allowedTo('profile_view'),
@@ -1830,19 +1924,22 @@  discard block
 block discarded – undo
1830 1924
 	// The ssi_todaysCalendar variants all use the same hook and just pass on $eventOptions so the hooked code can distinguish different cases if necessary
1831 1925
 	call_integration_hook('integrate_ssi_calendar', array(&$return, $eventOptions));
1832 1926
 
1833
-	if ($output_method != 'echo')
1834
-		return $return;
1927
+	if ($output_method != 'echo') {
1928
+			return $return;
1929
+	}
1835 1930
 
1836
-	if (!empty($return['calendar_holidays']))
1837
-		echo '
1931
+	if (!empty($return['calendar_holidays'])) {
1932
+			echo '
1838 1933
 			<span class="holiday">' . $txt['calendar_prompt'] . ' ' . implode(', ', $return['calendar_holidays']) . '<br></span>';
1934
+	}
1839 1935
 	if (!empty($return['calendar_birthdays']))
1840 1936
 	{
1841 1937
 		echo '
1842 1938
 			<span class="birthday">' . $txt['birthdays_upcoming'] . '</span> ';
1843
-		foreach ($return['calendar_birthdays'] as $member)
1844
-			echo '
1939
+		foreach ($return['calendar_birthdays'] as $member) {
1940
+					echo '
1845 1941
 			<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', !$member['is_last'] ? ', ' : '';
1942
+		}
1846 1943
 		echo '
1847 1944
 			<br>';
1848 1945
 	}
@@ -1852,9 +1949,10 @@  discard block
 block discarded – undo
1852 1949
 			<span class="event">' . $txt['events_upcoming'] . '</span> ';
1853 1950
 		foreach ($return['calendar_events'] as $event)
1854 1951
 		{
1855
-			if ($event['can_edit'])
1856
-				echo '
1952
+			if ($event['can_edit']) {
1953
+							echo '
1857 1954
 			<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
1955
+			}
1858 1956
 			echo '
1859 1957
 			' . $event['link'] . (!$event['is_last'] ? ', ' : '');
1860 1958
 		}
@@ -1878,25 +1976,29 @@  discard block
 block discarded – undo
1878 1976
 	loadLanguage('Stats');
1879 1977
 
1880 1978
 	// Must be integers....
1881
-	if ($limit === null)
1882
-		$limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5;
1883
-	else
1884
-		$limit = (int) $limit;
1885
-
1886
-	if ($start === null)
1887
-		$start = isset($_GET['start']) ? (int) $_GET['start'] : 0;
1888
-	else
1889
-		$start = (int) $start;
1890
-
1891
-	if ($board !== null)
1892
-		$board = (int) $board;
1893
-	elseif (isset($_GET['board']))
1894
-		$board = (int) $_GET['board'];
1895
-
1896
-	if ($length === null)
1897
-		$length = isset($_GET['length']) ? (int) $_GET['length'] : 0;
1898
-	else
1899
-		$length = (int) $length;
1979
+	if ($limit === null) {
1980
+			$limit = isset($_GET['limit']) ? (int) $_GET['limit'] : 5;
1981
+	} else {
1982
+			$limit = (int) $limit;
1983
+	}
1984
+
1985
+	if ($start === null) {
1986
+			$start = isset($_GET['start']) ? (int) $_GET['start'] : 0;
1987
+	} else {
1988
+			$start = (int) $start;
1989
+	}
1990
+
1991
+	if ($board !== null) {
1992
+			$board = (int) $board;
1993
+	} elseif (isset($_GET['board'])) {
1994
+			$board = (int) $_GET['board'];
1995
+	}
1996
+
1997
+	if ($length === null) {
1998
+			$length = isset($_GET['length']) ? (int) $_GET['length'] : 0;
1999
+	} else {
2000
+			$length = (int) $length;
2001
+	}
1900 2002
 
1901 2003
 	$limit = max(0, $limit);
1902 2004
 	$start = max(0, $start);
@@ -1914,17 +2016,19 @@  discard block
 block discarded – undo
1914 2016
 	);
1915 2017
 	if ($smcFunc['db_num_rows']($request) == 0)
1916 2018
 	{
1917
-		if ($output_method == 'echo')
1918
-			die($txt['ssi_no_guests']);
1919
-		else
1920
-			return array();
2019
+		if ($output_method == 'echo') {
2020
+					die($txt['ssi_no_guests']);
2021
+		} else {
2022
+					return array();
2023
+		}
1921 2024
 	}
1922 2025
 	list ($board) = $smcFunc['db_fetch_row']($request);
1923 2026
 	$smcFunc['db_free_result']($request);
1924 2027
 
1925 2028
 	$icon_sources = array();
1926
-	foreach ($context['stable_icons'] as $icon)
1927
-		$icon_sources[$icon] = 'images_url';
2029
+	foreach ($context['stable_icons'] as $icon) {
2030
+			$icon_sources[$icon] = 'images_url';
2031
+	}
1928 2032
 
1929 2033
 	if (!empty($modSettings['enable_likes']))
1930 2034
 	{
@@ -1948,12 +2052,14 @@  discard block
 block discarded – undo
1948 2052
 		)
1949 2053
 	);
1950 2054
 	$posts = array();
1951
-	while ($row = $smcFunc['db_fetch_assoc']($request))
1952
-		$posts[] = $row['id_first_msg'];
2055
+	while ($row = $smcFunc['db_fetch_assoc']($request)) {
2056
+			$posts[] = $row['id_first_msg'];
2057
+	}
1953 2058
 	$smcFunc['db_free_result']($request);
1954 2059
 
1955
-	if (empty($posts))
1956
-		return array();
2060
+	if (empty($posts)) {
2061
+			return array();
2062
+	}
1957 2063
 
1958 2064
 	// Find the posts.
1959 2065
 	$request = $smcFunc['db_query']('', '
@@ -1983,24 +2089,28 @@  discard block
 block discarded – undo
1983 2089
 			$last_space = strrpos($row['body'], ' ');
1984 2090
 			$last_open = strrpos($row['body'], '<');
1985 2091
 			$last_close = strrpos($row['body'], '>');
1986
-			if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6)
1987
-				$cutoff = $last_open;
1988
-			elseif (empty($last_close) || $last_close < $last_open)
1989
-				$cutoff = $last_space;
2092
+			if (empty($last_space) || ($last_space == $last_open + 3 && (empty($last_close) || (!empty($last_close) && $last_close < $last_open))) || $last_space < $last_open || $last_open == $length - 6) {
2093
+							$cutoff = $last_open;
2094
+			} elseif (empty($last_close) || $last_close < $last_open) {
2095
+							$cutoff = $last_space;
2096
+			}
1990 2097
 
1991
-			if ($cutoff !== false)
1992
-				$row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff);
2098
+			if ($cutoff !== false) {
2099
+							$row['body'] = $smcFunc['substr']($row['body'], 0, $cutoff);
2100
+			}
1993 2101
 			$row['body'] .= '...';
1994 2102
 		}
1995 2103
 
1996 2104
 		$row['body'] = parse_bbc($row['body'], $row['smileys_enabled'], $row['id_msg']);
1997 2105
 
1998
-		if (!empty($recycle_board) && $row['id_board'] == $recycle_board)
1999
-			$row['icon'] = 'recycled';
2106
+		if (!empty($recycle_board) && $row['id_board'] == $recycle_board) {
2107
+					$row['icon'] = 'recycled';
2108
+		}
2000 2109
 
2001 2110
 		// Check that this message icon is there...
2002
-		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']]))
2003
-			$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
2111
+		if (!empty($modSettings['messageIconChecks_enable']) && !isset($icon_sources[$row['icon']])) {
2112
+					$icon_sources[$row['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['icon'] . '.png') ? 'images_url' : 'default_images_url';
2113
+		}
2004 2114
 
2005 2115
 		censorText($row['subject']);
2006 2116
 		censorText($row['body']);
@@ -2037,16 +2147,18 @@  discard block
 block discarded – undo
2037 2147
 	}
2038 2148
 	$smcFunc['db_free_result']($request);
2039 2149
 
2040
-	if (empty($return))
2041
-		return $return;
2150
+	if (empty($return)) {
2151
+			return $return;
2152
+	}
2042 2153
 
2043 2154
 	$return[count($return) - 1]['is_last'] = true;
2044 2155
 
2045 2156
 	// If mods want to do somthing with this list of posts, let them do that now.
2046 2157
 	call_integration_hook('integrate_ssi_boardNews', array(&$return));
2047 2158
 
2048
-	if ($output_method != 'echo')
2049
-		return $return;
2159
+	if ($output_method != 'echo') {
2160
+			return $return;
2161
+	}
2050 2162
 
2051 2163
 	foreach ($return as $news)
2052 2164
 	{
@@ -2098,9 +2210,10 @@  discard block
 block discarded – undo
2098 2210
 		echo '
2099 2211
 			</div>';
2100 2212
 
2101
-		if (!$news['is_last'])
2102
-			echo '
2213
+		if (!$news['is_last']) {
2214
+					echo '
2103 2215
 			<hr>';
2216
+		}
2104 2217
 	}
2105 2218
 }
2106 2219
 
@@ -2114,8 +2227,9 @@  discard block
 block discarded – undo
2114 2227
 {
2115 2228
 	global $user_info, $scripturl, $modSettings, $txt, $context, $smcFunc;
2116 2229
 
2117
-	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view'))
2118
-		return;
2230
+	if (empty($modSettings['cal_enabled']) || !allowedTo('calendar_view')) {
2231
+			return;
2232
+	}
2119 2233
 
2120 2234
 	// Find all events which are happening in the near future that the member can see.
2121 2235
 	$request = $smcFunc['db_query']('', '
@@ -2141,20 +2255,23 @@  discard block
 block discarded – undo
2141 2255
 	while ($row = $smcFunc['db_fetch_assoc']($request))
2142 2256
 	{
2143 2257
 		// Check if we've already come by an event linked to this same topic with the same title... and don't display it if we have.
2144
-		if (!empty($duplicates[$row['title'] . $row['id_topic']]))
2145
-			continue;
2258
+		if (!empty($duplicates[$row['title'] . $row['id_topic']])) {
2259
+					continue;
2260
+		}
2146 2261
 
2147 2262
 		// Censor the title.
2148 2263
 		censorText($row['title']);
2149 2264
 
2150
-		if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false)))
2151
-			$date = strftime('%Y-%m-%d', forum_time(false));
2152
-		else
2153
-			$date = $row['start_date'];
2265
+		if ($row['start_date'] < strftime('%Y-%m-%d', forum_time(false))) {
2266
+					$date = strftime('%Y-%m-%d', forum_time(false));
2267
+		} else {
2268
+					$date = $row['start_date'];
2269
+		}
2154 2270
 
2155 2271
 		// If the topic it is attached to is not approved then don't link it.
2156
-		if (!empty($row['id_first_msg']) && !$row['approved'])
2157
-			$row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0;
2272
+		if (!empty($row['id_first_msg']) && !$row['approved']) {
2273
+					$row['id_board'] = $row['id_topic'] = $row['id_first_msg'] = 0;
2274
+		}
2158 2275
 
2159 2276
 		$allday = (empty($row['start_time']) || empty($row['end_time']) || empty($row['timezone']) || !in_array($row['timezone'], timezone_identifiers_list(DateTimeZone::ALL_WITH_BC))) ? true : false;
2160 2277
 
@@ -2180,24 +2297,27 @@  discard block
 block discarded – undo
2180 2297
 	}
2181 2298
 	$smcFunc['db_free_result']($request);
2182 2299
 
2183
-	foreach ($return as $mday => $array)
2184
-		$return[$mday][count($array) - 1]['is_last'] = true;
2300
+	foreach ($return as $mday => $array) {
2301
+			$return[$mday][count($array) - 1]['is_last'] = true;
2302
+	}
2185 2303
 
2186 2304
 	// If mods want to do somthing with this list of events, let them do that now.
2187 2305
 	call_integration_hook('integrate_ssi_recentEvents', array(&$return));
2188 2306
 
2189
-	if ($output_method != 'echo' || empty($return))
2190
-		return $return;
2307
+	if ($output_method != 'echo' || empty($return)) {
2308
+			return $return;
2309
+	}
2191 2310
 
2192 2311
 	// Well the output method is echo.
2193 2312
 	echo '
2194 2313
 			<span class="event">' . $txt['events'] . '</span> ';
2195
-	foreach ($return as $mday => $array)
2196
-		foreach ($array as $event)
2314
+	foreach ($return as $mday => $array) {
2315
+			foreach ($array as $event)
2197 2316
 		{
2198 2317
 			if ($event['can_edit'])
2199 2318
 				echo '
2200 2319
 				<a href="' . $event['modify_href'] . '" style="color: #ff0000;">*</a> ';
2320
+	}
2201 2321
 
2202 2322
 			echo '
2203 2323
 				' . $event['link'] . (!$event['is_last'] ? ', ' : '');
@@ -2216,8 +2336,9 @@  discard block
 block discarded – undo
2216 2336
 	global $smcFunc;
2217 2337
 
2218 2338
 	// If $id is null, this was most likely called from a query string and should do nothing.
2219
-	if ($id === null)
2220
-		return;
2339
+	if ($id === null) {
2340
+			return;
2341
+	}
2221 2342
 
2222 2343
 	$request = $smcFunc['db_query']('', '
2223 2344
 		SELECT passwd, member_name, is_activated
@@ -2249,8 +2370,9 @@  discard block
 block discarded – undo
2249 2370
 	$attachments_boards = boardsAllowedTo('view_attachments');
2250 2371
 
2251 2372
 	// No boards?  Adios amigo.
2252
-	if (empty($attachments_boards))
2253
-		return array();
2373
+	if (empty($attachments_boards)) {
2374
+			return array();
2375
+	}
2254 2376
 
2255 2377
 	// Is it an array?
2256 2378
 	$attachment_ext = (array) $attachment_ext;
@@ -2334,8 +2456,9 @@  discard block
 block discarded – undo
2334 2456
 	call_integration_hook('integrate_ssi_recentAttachments', array(&$attachments));
2335 2457
 
2336 2458
 	// So you just want an array?  Here you can have it.
2337
-	if ($output_method == 'array' || empty($attachments))
2338
-		return $attachments;
2459
+	if ($output_method == 'array' || empty($attachments)) {
2460
+			return $attachments;
2461
+	}
2339 2462
 
2340 2463
 	// Give them the default.
2341 2464
 	echo '
@@ -2346,14 +2469,15 @@  discard block
 block discarded – undo
2346 2469
 				<th style="text-align: left; padding: 2">', $txt['downloads'], '</th>
2347 2470
 				<th style="text-align: left; padding: 2">', $txt['filesize'], '</th>
2348 2471
 			</tr>';
2349
-	foreach ($attachments as $attach)
2350
-		echo '
2472
+	foreach ($attachments as $attach) {
2473
+			echo '
2351 2474
 			<tr>
2352 2475
 				<td>', $attach['file']['link'], '</td>
2353 2476
 				<td>', $attach['member']['link'], '</td>
2354 2477
 				<td style="text-align: center">', $attach['file']['downloads'], '</td>
2355 2478
 				<td>', $attach['file']['filesize'], '</td>
2356 2479
 			</tr>';
2480
+	}
2357 2481
 	echo '
2358 2482
 		</table>';
2359 2483
 }
Please login to merge, or discard this patch.