memcached_cache

Complexity

Total Complexity

20

Size/Duplication

Total Lines	135
Duplicated Lines	31.11 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	isSupported()	10	10	4
C	connect()	5	38	8
A	getData()	11	11	2
A	putData()	0	6	1
A	cleanCache()	0	7	1
A	quit()	0	4	1
A	cacheSettings()	16	16	2
A	getVersion()	0	4	1

<?php

/**
 * Simple Machines Forum (SMF)
 *
 * @package SMF
 * @author Simple Machines http://www.simplemachines.org
 * @copyright 2017 Simple Machines and individual contributors
 * @license http://www.simplemachines.org/about/smf/license.php BSD
 *
 * @version 2.1 Beta 4
 */

if (!defined('SMF'))
	die('Hacking attempt...');

/**
 * Our Cache API class
 * @package cacheAPI
 */
class memcached_cache extends cache_api
{
	/**
	 * @var \Memcached The memcache instance.
	 */
	private $memcached = null;

	/**
	 * {@inheritDoc}
	 */
	public function isSupported($test = false)

This method seems to be duplicated in your project.

	{
		global $cache_memcached;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		$supported = class_exists('memcached');

		if ($test)
			return $supported;
		return parent::isSupported() && $supported && !empty($cache_memcached);
	}

	/**
	 * {@inheritDoc}
	 */
	public function connect()
	{
		global $cache_memcached;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		$servers = explode(',', $cache_memcached);

		// memcached does not remove servers from the list upon completing the script under modes like FastCGI. So check to see if servers exist or not.
		$this->memcached = new Memcached;
		$currentServers = $this->memcached->getServerList();
		foreach ($servers as $server)
		{
			if (strpos($server,'/') !== false)
				$tempServer = array($server, 0);
			else
			{
				$server = explode(':', $server);
				$tempServer = array($server[0], isset($server[1]) ? $server[1] : 11211);
			}

			// Figure out if we have this server or not
			$foundServer = false;
			foreach ($currentServers as $currentServer)
			{
				if ($tempServer[0] == $currentServer['host'] && $tempServer[1] == $currentServer['port'])
				{
					$foundServer = true;
					break;
				}
			}

			// Found it?
			if (empty($foundServer))
				$this->memcached->addServer($tempServer[0], $tempServer[1]);
		}

		// Best guess is this worked.
		return true;
	}

	/**
	 * {@inheritDoc}
	 */
	public function getData($key, $ttl = null)

This method seems to be duplicated in your project.

	{
		$key = $this->prefix . strtr($key, ':/', '-_');

		$value = $this->memcached->get($key);

		// $value should return either data or false (from failure, key not found or empty array).
		if ($value === false)
			return null;
		return $value;
	}

	/**
	 * {@inheritDoc}
	 */
	public function putData($key, $value, $ttl = null)
	{
		$key = $this->prefix . strtr($key, ':/', '-_');

		return $this->memcached->set($key, $value, $ttl);
	}

	/**
	 * {@inheritDoc}
	 */
	public function cleanCache($type = '')
	{
		$this->invalidateCache();

		// Memcached accepts a delay parameter, always use 0 (instant).
		return $this->memcached->flush(0);
	}

	/**
	 * {@inheritDoc}
	 */
	public function quit()
	{
		return $this->memcached->quit();
	}

	/**
	 * {@inheritDoc}
	 */
	public function cacheSettings(array &$config_vars)

This method seems to be duplicated in your project.

	{
		global $context, $txt;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

		$config_vars[] = $txt['cache_memcache_settings'];
		$config_vars[] = array('cache_memcached', $txt['cache_memcache_servers'], 'file', 'text', 0, 'cache_memcached', 'postinput' => '<br><div class="smalltext"><em>' . $txt['cache_memcache_servers_subtext'] . '</em></div>');

		if (!isset($context['settings_post_javascript']))
			$context['settings_post_javascript'] = '';

		$context['settings_post_javascript'] .= '
			$("#cache_accelerator").change(function (e) {
				var cache_type = e.currentTarget.value;
				$("#cache_memcached").prop("disabled", cache_type != "memcached");
			});';
	}

	/**
	 * {@inheritDoc}
	 */
	public function getVersion()
	{
		return $this->memcached->getVersion();
	}
}

?>