@@ -15,8 +15,9 @@ discard block |
||
| 15 | 15 | * @version 2.1 Beta 4 |
| 16 | 16 | */ |
| 17 | 17 | |
| 18 | -if (!defined('SMF')) |
|
| 18 | +if (!defined('SMF')) { |
|
| 19 | 19 | die('No direct access...'); |
| 20 | +} |
|
| 20 | 21 | |
| 21 | 22 | /** |
| 22 | 23 | * Main dispatcher. This function checks permissions and passes control through to the relevant section. |
@@ -245,8 +246,9 @@ discard block |
||
| 245 | 246 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 246 | 247 | { |
| 247 | 248 | // Private PM/email subjects and similar shouldn't be shown in the mailbox area. |
| 248 | - if (!empty($row['private'])) |
|
| 249 | - $row['subject'] = $txt['personal_message']; |
|
| 249 | + if (!empty($row['private'])) { |
|
| 250 | + $row['subject'] = $txt['personal_message']; |
|
| 251 | + } |
|
| 250 | 252 | |
| 251 | 253 | $mails[] = $row; |
| 252 | 254 | } |
@@ -300,8 +302,9 @@ discard block |
||
| 300 | 302 | $element = substr($key, strrpos($key, '_') + 1); |
| 301 | 303 | $processedBirthdayEmails[$index][$element] = $value; |
| 302 | 304 | } |
| 303 | - foreach ($processedBirthdayEmails as $index => $dummy) |
|
| 304 | - $emails[$index] = $index; |
|
| 305 | + foreach ($processedBirthdayEmails as $index => $dummy) { |
|
| 306 | + $emails[$index] = $index; |
|
| 307 | + } |
|
| 305 | 308 | |
| 306 | 309 | $config_vars = array( |
| 307 | 310 | // Mail queue stuff, this rocks ;) |
@@ -322,8 +325,9 @@ discard block |
||
| 322 | 325 | |
| 323 | 326 | call_integration_hook('integrate_modify_mail_settings', array(&$config_vars)); |
| 324 | 327 | |
| 325 | - if ($return_config) |
|
| 326 | - return $config_vars; |
|
| 328 | + if ($return_config) { |
|
| 329 | + return $config_vars; |
|
| 330 | + } |
|
| 327 | 331 | |
| 328 | 332 | // Saving? |
| 329 | 333 | if (isset($_GET['save'])) |
@@ -398,9 +402,9 @@ discard block |
||
| 398 | 402 | ); |
| 399 | 403 | list ($_GET['te']) = $smcFunc['db_fetch_row']($request); |
| 400 | 404 | $smcFunc['db_free_result']($request); |
| 405 | + } else { |
|
| 406 | + $_GET['te'] = (int) $_GET['te']; |
|
| 401 | 407 | } |
| 402 | - else |
|
| 403 | - $_GET['te'] = (int) $_GET['te']; |
|
| 404 | 408 | |
| 405 | 409 | $_GET['sent'] = isset($_GET['sent']) ? (int) $_GET['sent'] : 0; |
| 406 | 410 | |
@@ -424,12 +428,14 @@ discard block |
||
| 424 | 428 | |
| 425 | 429 | // Try get more time... |
| 426 | 430 | @set_time_limit(600); |
| 427 | - if (function_exists('apache_reset_timeout')) |
|
| 428 | - @apache_reset_timeout(); |
|
| 431 | + if (function_exists('apache_reset_timeout')) { |
|
| 432 | + @apache_reset_timeout(); |
|
| 433 | + } |
|
| 429 | 434 | |
| 430 | 435 | // Have we already used our maximum time? |
| 431 | - if ((time() - $time_start) < 5) |
|
| 432 | - return; |
|
| 436 | + if ((time() - $time_start) < 5) { |
|
| 437 | + return; |
|
| 438 | + } |
|
| 433 | 439 | |
| 434 | 440 | $context['continue_get_data'] = '?action=admin;area=mailqueue;sa=clear;te=' . $_GET['te'] . ';sent=' . $_GET['sent'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
| 435 | 441 | $context['page_title'] = $txt['not_done_title']; |
@@ -459,8 +465,9 @@ discard block |
||
| 459 | 465 | { |
| 460 | 466 | global $txt; |
| 461 | 467 | |
| 462 | - if ($time_diff < 0) |
|
| 463 | - $time_diff = 0; |
|
| 468 | + if ($time_diff < 0) { |
|
| 469 | + $time_diff = 0; |
|
| 470 | + } |
|
| 464 | 471 | |
| 465 | 472 | // Just do a bit of an if fest... |
| 466 | 473 | if ($time_diff > 86400) |
@@ -481,8 +488,9 @@ discard block |
||
| 481 | 488 | return sprintf($minutes == 1 ? $txt['mq_minute'] : $txt['mq_minutes'], $minutes); |
| 482 | 489 | } |
| 483 | 490 | // Otherwise must be second |
| 484 | - else |
|
| 485 | - return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
| 486 | -} |
|
| 491 | + else { |
|
| 492 | + return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
| 493 | + } |
|
| 494 | + } |
|
| 487 | 495 | |
| 488 | 496 | ?> |
| 489 | 497 | \ No newline at end of file |
@@ -14,8 +14,9 @@ discard block |
||
| 14 | 14 | * @version 2.1 Beta 4 |
| 15 | 15 | */ |
| 16 | 16 | |
| 17 | -if (!defined('SMF')) |
|
| 17 | +if (!defined('SMF')) { |
|
| 18 | 18 | die('No direct access...'); |
| 19 | +} |
|
| 19 | 20 | |
| 20 | 21 | /** |
| 21 | 22 | * Show the list of topics in this board, along with any child boards. |
@@ -56,8 +57,9 @@ discard block |
||
| 56 | 57 | |
| 57 | 58 | $context['name'] = $board_info['name']; |
| 58 | 59 | $context['description'] = $board_info['description']; |
| 59 | - if (!empty($board_info['description'])) |
|
| 60 | - $context['meta_description'] = strip_tags($board_info['description']); |
|
| 60 | + if (!empty($board_info['description'])) { |
|
| 61 | + $context['meta_description'] = strip_tags($board_info['description']); |
|
| 62 | + } |
|
| 61 | 63 | |
| 62 | 64 | // How many topics do we have in total? |
| 63 | 65 | $board_info['total_topics'] = allowedTo('approve_posts') ? $board_info['num_topics'] + $board_info['unapproved_topics'] : $board_info['num_topics'] + $board_info['unapproved_user_topics']; |
@@ -73,12 +75,14 @@ discard block |
||
| 73 | 75 | $session_name = session_name(); |
| 74 | 76 | foreach ($_GET as $k => $v) |
| 75 | 77 | { |
| 76 | - if (!in_array($k, array('board', 'start', $session_name))) |
|
| 77 | - $context['robot_no_index'] = true; |
|
| 78 | + if (!in_array($k, array('board', 'start', $session_name))) { |
|
| 79 | + $context['robot_no_index'] = true; |
|
| 80 | + } |
|
| 78 | 81 | } |
| 79 | 82 | } |
| 80 | - if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) |
|
| 81 | - $context['robot_no_index'] = true; |
|
| 83 | + if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) { |
|
| 84 | + $context['robot_no_index'] = true; |
|
| 85 | + } |
|
| 82 | 86 | |
| 83 | 87 | // If we can view unapproved messages and there are some build up a list. |
| 84 | 88 | if (allowedTo('approve_posts') && ($board_info['unapproved_topics'] || $board_info['unapproved_posts'])) |
@@ -89,14 +93,16 @@ discard block |
||
| 89 | 93 | } |
| 90 | 94 | |
| 91 | 95 | // We only know these. |
| 92 | - if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post'))) |
|
| 93 | - $_REQUEST['sort'] = 'last_post'; |
|
| 96 | + if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post'))) { |
|
| 97 | + $_REQUEST['sort'] = 'last_post'; |
|
| 98 | + } |
|
| 94 | 99 | |
| 95 | 100 | // Make sure the starting place makes sense and construct the page index. |
| 96 | - if (isset($_REQUEST['sort'])) |
|
| 97 | - $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true); |
|
| 98 | - else |
|
| 99 | - $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true); |
|
| 101 | + if (isset($_REQUEST['sort'])) { |
|
| 102 | + $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true); |
|
| 103 | + } else { |
|
| 104 | + $context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true); |
|
| 105 | + } |
|
| 100 | 106 | $context['start'] = &$_REQUEST['start']; |
| 101 | 107 | |
| 102 | 108 | // Set a canonical URL for this page. |
@@ -132,14 +138,16 @@ discard block |
||
| 132 | 138 | $context['link_moderators'] = array(); |
| 133 | 139 | if (!empty($board_info['moderators'])) |
| 134 | 140 | { |
| 135 | - foreach ($board_info['moderators'] as $mod) |
|
| 136 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
| 141 | + foreach ($board_info['moderators'] as $mod) { |
|
| 142 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
| 143 | + } |
|
| 137 | 144 | } |
| 138 | 145 | if (!empty($board_info['moderator_groups'])) |
| 139 | 146 | { |
| 140 | 147 | // By default just tack the moderator groups onto the end of the members |
| 141 | - foreach ($board_info['moderator_groups'] as $mod_group) |
|
| 142 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
| 148 | + foreach ($board_info['moderator_groups'] as $mod_group) { |
|
| 149 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
| 150 | + } |
|
| 143 | 151 | } |
| 144 | 152 | |
| 145 | 153 | // Now we tack the info onto the end of the linktree |
@@ -191,20 +199,24 @@ discard block |
||
| 191 | 199 | ); |
| 192 | 200 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 193 | 201 | { |
| 194 | - if (empty($row['id_member'])) |
|
| 195 | - continue; |
|
| 202 | + if (empty($row['id_member'])) { |
|
| 203 | + continue; |
|
| 204 | + } |
|
| 196 | 205 | |
| 197 | - if (!empty($row['online_color'])) |
|
| 198 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
| 199 | - else |
|
| 200 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
| 206 | + if (!empty($row['online_color'])) { |
|
| 207 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
| 208 | + } else { |
|
| 209 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
| 210 | + } |
|
| 201 | 211 | |
| 202 | 212 | $is_buddy = in_array($row['id_member'], $user_info['buddies']); |
| 203 | - if ($is_buddy) |
|
| 204 | - $link = '<strong>' . $link . '</strong>'; |
|
| 213 | + if ($is_buddy) { |
|
| 214 | + $link = '<strong>' . $link . '</strong>'; |
|
| 215 | + } |
|
| 205 | 216 | |
| 206 | - if (!empty($row['show_online']) || allowedTo('moderate_forum')) |
|
| 207 | - $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
| 217 | + if (!empty($row['show_online']) || allowedTo('moderate_forum')) { |
|
| 218 | + $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
| 219 | + } |
|
| 208 | 220 | // @todo why are we filling this array of data that are just counted (twice) and discarded? ??? |
| 209 | 221 | $context['view_members'][$row['log_time'] . $row['member_name']] = array( |
| 210 | 222 | 'id' => $row['id_member'], |
@@ -217,8 +229,9 @@ discard block |
||
| 217 | 229 | 'hidden' => empty($row['show_online']), |
| 218 | 230 | ); |
| 219 | 231 | |
| 220 | - if (empty($row['show_online'])) |
|
| 221 | - $context['view_num_hidden']++; |
|
| 232 | + if (empty($row['show_online'])) { |
|
| 233 | + $context['view_num_hidden']++; |
|
| 234 | + } |
|
| 222 | 235 | } |
| 223 | 236 | $context['view_num_guests'] = $smcFunc['db_num_rows']($request) - count($context['view_members']); |
| 224 | 237 | $smcFunc['db_free_result']($request); |
@@ -260,8 +273,9 @@ discard block |
||
| 260 | 273 | // Bring in any changes we want to make before the query. |
| 261 | 274 | call_integration_hook('integrate_pre_messageindex', array(&$sort_methods)); |
| 262 | 275 | |
| 263 | - foreach ($sort_methods as $key => $val) |
|
| 264 | - $context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>'; |
|
| 276 | + foreach ($sort_methods as $key => $val) { |
|
| 277 | + $context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>'; |
|
| 278 | + } |
|
| 265 | 279 | |
| 266 | 280 | // Calculate the fastest way to get the topics. |
| 267 | 281 | $start = (int) $_REQUEST['start']; |
@@ -271,14 +285,15 @@ discard block |
||
| 271 | 285 | $fake_ascending = true; |
| 272 | 286 | $context['maxindex'] = $board_info['total_topics'] < $start + $context['maxindex'] + 1 ? $board_info['total_topics'] - $start : $context['maxindex']; |
| 273 | 287 | $start = $board_info['total_topics'] < $start + $context['maxindex'] + 1 ? 0 : $board_info['total_topics'] - $start - $context['maxindex']; |
| 288 | + } else { |
|
| 289 | + $fake_ascending = false; |
|
| 274 | 290 | } |
| 275 | - else |
|
| 276 | - $fake_ascending = false; |
|
| 277 | 291 | |
| 278 | 292 | // Setup the default topic icons... |
| 279 | 293 | $context['icon_sources'] = array(); |
| 280 | - foreach ($context['stable_icons'] as $icon) |
|
| 281 | - $context['icon_sources'][$icon] = 'images_url'; |
|
| 294 | + foreach ($context['stable_icons'] as $icon) { |
|
| 295 | + $context['icon_sources'][$icon] = 'images_url'; |
|
| 296 | + } |
|
| 282 | 297 | |
| 283 | 298 | $topic_ids = array(); |
| 284 | 299 | $context['topics'] = array(); |
@@ -316,8 +331,9 @@ discard block |
||
| 316 | 331 | $message_pre_index_parameters |
| 317 | 332 | ); |
| 318 | 333 | $topic_ids = array(); |
| 319 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 320 | - $topic_ids[] = $row['id_topic']; |
|
| 334 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 335 | + $topic_ids[] = $row['id_topic']; |
|
| 336 | + } |
|
| 321 | 337 | } |
| 322 | 338 | |
| 323 | 339 | // Grab the appropriate topic information... |
@@ -375,11 +391,13 @@ discard block |
||
| 375 | 391 | // Begin 'printing' the message index for current board. |
| 376 | 392 | while ($row = $smcFunc['db_fetch_assoc']($result)) |
| 377 | 393 | { |
| 378 | - if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0') |
|
| 379 | - continue; |
|
| 394 | + if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0') { |
|
| 395 | + continue; |
|
| 396 | + } |
|
| 380 | 397 | |
| 381 | - if (!$pre_query) |
|
| 382 | - $topic_ids[] = $row['id_topic']; |
|
| 398 | + if (!$pre_query) { |
|
| 399 | + $topic_ids[] = $row['id_topic']; |
|
| 400 | + } |
|
| 383 | 401 | |
| 384 | 402 | // Reference the main color class. |
| 385 | 403 | $colorClass = 'windowbg'; |
@@ -389,8 +407,9 @@ discard block |
||
| 389 | 407 | { |
| 390 | 408 | // Limit them to $modSettings['preview_characters'] characters |
| 391 | 409 | $row['first_body'] = strip_tags(strtr(parse_bbc($row['first_body'], $row['first_smileys'], $row['id_first_msg']), array('<br>' => ' '))); |
| 392 | - if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) |
|
| 393 | - $row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...'; |
|
| 410 | + if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) { |
|
| 411 | + $row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...'; |
|
| 412 | + } |
|
| 394 | 413 | |
| 395 | 414 | // Censor the subject and message preview. |
| 396 | 415 | censorText($row['first_subject']); |
@@ -401,27 +420,27 @@ discard block |
||
| 401 | 420 | { |
| 402 | 421 | $row['last_subject'] = $row['first_subject']; |
| 403 | 422 | $row['last_body'] = $row['first_body']; |
| 404 | - } |
|
| 405 | - else |
|
| 423 | + } else |
|
| 406 | 424 | { |
| 407 | 425 | $row['last_body'] = strip_tags(strtr(parse_bbc($row['last_body'], $row['last_smileys'], $row['id_last_msg']), array('<br>' => ' '))); |
| 408 | - if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters']) |
|
| 409 | - $row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...'; |
|
| 426 | + if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters']) { |
|
| 427 | + $row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...'; |
|
| 428 | + } |
|
| 410 | 429 | |
| 411 | 430 | censorText($row['last_subject']); |
| 412 | 431 | censorText($row['last_body']); |
| 413 | 432 | } |
| 414 | - } |
|
| 415 | - else |
|
| 433 | + } else |
|
| 416 | 434 | { |
| 417 | 435 | $row['first_body'] = ''; |
| 418 | 436 | $row['last_body'] = ''; |
| 419 | 437 | censorText($row['first_subject']); |
| 420 | 438 | |
| 421 | - if ($row['id_first_msg'] == $row['id_last_msg']) |
|
| 422 | - $row['last_subject'] = $row['first_subject']; |
|
| 423 | - else |
|
| 424 | - censorText($row['last_subject']); |
|
| 439 | + if ($row['id_first_msg'] == $row['id_last_msg']) { |
|
| 440 | + $row['last_subject'] = $row['first_subject']; |
|
| 441 | + } else { |
|
| 442 | + censorText($row['last_subject']); |
|
| 443 | + } |
|
| 425 | 444 | } |
| 426 | 445 | |
| 427 | 446 | // Decide how many pages the topic should have. |
@@ -432,42 +451,50 @@ discard block |
||
| 432 | 451 | $pages = constructPageIndex($scripturl . '?topic=' . $row['id_topic'] . '.%1$d', $start, $row['num_replies'] + 1, $context['messages_per_page'], true, false); |
| 433 | 452 | |
| 434 | 453 | // If we can use all, show all. |
| 435 | - if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages']) |
|
| 436 | - $pages .= ' <a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>'; |
|
| 454 | + if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages']) { |
|
| 455 | + $pages .= ' <a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>'; |
|
| 456 | + } |
|
| 457 | + } else { |
|
| 458 | + $pages = ''; |
|
| 437 | 459 | } |
| 438 | - else |
|
| 439 | - $pages = ''; |
|
| 440 | 460 | |
| 441 | 461 | // We need to check the topic icons exist... |
| 442 | 462 | if (!empty($modSettings['messageIconChecks_enable'])) |
| 443 | 463 | { |
| 444 | - if (!isset($context['icon_sources'][$row['first_icon']])) |
|
| 445 | - $context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
| 446 | - if (!isset($context['icon_sources'][$row['last_icon']])) |
|
| 447 | - $context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
| 448 | - } |
|
| 449 | - else |
|
| 464 | + if (!isset($context['icon_sources'][$row['first_icon']])) { |
|
| 465 | + $context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
| 466 | + } |
|
| 467 | + if (!isset($context['icon_sources'][$row['last_icon']])) { |
|
| 468 | + $context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
| 469 | + } |
|
| 470 | + } else |
|
| 450 | 471 | { |
| 451 | - if (!isset($context['icon_sources'][$row['first_icon']])) |
|
| 452 | - $context['icon_sources'][$row['first_icon']] = 'images_url'; |
|
| 453 | - if (!isset($context['icon_sources'][$row['last_icon']])) |
|
| 454 | - $context['icon_sources'][$row['last_icon']] = 'images_url'; |
|
| 472 | + if (!isset($context['icon_sources'][$row['first_icon']])) { |
|
| 473 | + $context['icon_sources'][$row['first_icon']] = 'images_url'; |
|
| 474 | + } |
|
| 475 | + if (!isset($context['icon_sources'][$row['last_icon']])) { |
|
| 476 | + $context['icon_sources'][$row['last_icon']] = 'images_url'; |
|
| 477 | + } |
|
| 455 | 478 | } |
| 456 | 479 | |
| 457 | - if (!empty($board_info['recycle'])) |
|
| 458 | - $row['first_icon'] = 'recycled'; |
|
| 480 | + if (!empty($board_info['recycle'])) { |
|
| 481 | + $row['first_icon'] = 'recycled'; |
|
| 482 | + } |
|
| 459 | 483 | |
| 460 | 484 | // Is this topic pending approval, or does it have any posts pending approval? |
| 461 | - if ($context['can_approve_posts'] && $row['unapproved_posts']) |
|
| 462 | - $colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost'); |
|
| 485 | + if ($context['can_approve_posts'] && $row['unapproved_posts']) { |
|
| 486 | + $colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost'); |
|
| 487 | + } |
|
| 463 | 488 | |
| 464 | 489 | // Sticky topics should get a different color, too. |
| 465 | - if ($row['is_sticky']) |
|
| 466 | - $colorClass .= ' sticky'; |
|
| 490 | + if ($row['is_sticky']) { |
|
| 491 | + $colorClass .= ' sticky'; |
|
| 492 | + } |
|
| 467 | 493 | |
| 468 | 494 | // Locked topics get special treatment as well. |
| 469 | - if ($row['locked']) |
|
| 470 | - $colorClass .= ' locked'; |
|
| 495 | + if ($row['locked']) { |
|
| 496 | + $colorClass .= ' locked'; |
|
| 497 | + } |
|
| 471 | 498 | |
| 472 | 499 | // 'Print' the topic info. |
| 473 | 500 | $context['topics'][$row['id_topic']] = array_merge($row, array( |
@@ -548,8 +575,9 @@ discard block |
||
| 548 | 575 | $smcFunc['db_free_result']($result); |
| 549 | 576 | |
| 550 | 577 | // Fix the sequence of topics if they were retrieved in the wrong order. (for speed reasons...) |
| 551 | - if ($fake_ascending) |
|
| 552 | - $context['topics'] = array_reverse($context['topics'], true); |
|
| 578 | + if ($fake_ascending) { |
|
| 579 | + $context['topics'] = array_reverse($context['topics'], true); |
|
| 580 | + } |
|
| 553 | 581 | |
| 554 | 582 | if (!empty($modSettings['enableParticipation']) && !$user_info['is_guest'] && !empty($topic_ids)) |
| 555 | 583 | { |
@@ -566,8 +594,9 @@ discard block |
||
| 566 | 594 | 'limit' => count($topic_ids), |
| 567 | 595 | ) |
| 568 | 596 | ); |
| 569 | - while ($row = $smcFunc['db_fetch_assoc']($result)) |
|
| 570 | - $context['topics'][$row['id_topic']]['is_posted_in'] = true; |
|
| 597 | + while ($row = $smcFunc['db_fetch_assoc']($result)) { |
|
| 598 | + $context['topics'][$row['id_topic']]['is_posted_in'] = true; |
|
| 599 | + } |
|
| 571 | 600 | $smcFunc['db_free_result']($result); |
| 572 | 601 | } |
| 573 | 602 | } |
@@ -592,9 +621,9 @@ discard block |
||
| 592 | 621 | // Can we restore topics? |
| 593 | 622 | $context['can_restore'] = allowedTo('move_any') && !empty($board_info['recycle']); |
| 594 | 623 | |
| 595 | - if ($user_info['is_admin'] || $modSettings['topic_move_any']) |
|
| 596 | - $context['can_move_any'] = true; |
|
| 597 | - else |
|
| 624 | + if ($user_info['is_admin'] || $modSettings['topic_move_any']) { |
|
| 625 | + $context['can_move_any'] = true; |
|
| 626 | + } else |
|
| 598 | 627 | { |
| 599 | 628 | // We'll use this in a minute |
| 600 | 629 | $boards_allowed = boardsAllowedTo('post_new'); |
@@ -621,11 +650,13 @@ discard block |
||
| 621 | 650 | } |
| 622 | 651 | |
| 623 | 652 | // Can we use quick moderation checkboxes? |
| 624 | - if ($options['display_quick_mod'] == 1) |
|
| 625 | - $context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore']; |
|
| 653 | + if ($options['display_quick_mod'] == 1) { |
|
| 654 | + $context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore']; |
|
| 655 | + } |
|
| 626 | 656 | // Or the icons? |
| 627 | - else |
|
| 628 | - $context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move']; |
|
| 657 | + else { |
|
| 658 | + $context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move']; |
|
| 659 | + } |
|
| 629 | 660 | } |
| 630 | 661 | |
| 631 | 662 | if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1) |
@@ -659,13 +690,15 @@ discard block |
||
| 659 | 690 | ); |
| 660 | 691 | |
| 661 | 692 | // We've seen all these boards now! |
| 662 | - foreach ($board_info['parent_boards'] as $k => $dummy) |
|
| 663 | - if (isset($_SESSION['topicseen_cache'][$k])) |
|
| 693 | + foreach ($board_info['parent_boards'] as $k => $dummy) { |
|
| 694 | + if (isset($_SESSION['topicseen_cache'][$k])) |
|
| 664 | 695 | unset($_SESSION['topicseen_cache'][$k]); |
| 696 | + } |
|
| 665 | 697 | } |
| 666 | 698 | |
| 667 | - if (isset($_SESSION['topicseen_cache'][$board])) |
|
| 668 | - unset($_SESSION['topicseen_cache'][$board]); |
|
| 699 | + if (isset($_SESSION['topicseen_cache'][$board])) { |
|
| 700 | + unset($_SESSION['topicseen_cache'][$board]); |
|
| 701 | + } |
|
| 669 | 702 | |
| 670 | 703 | $request = $smcFunc['db_query']('', ' |
| 671 | 704 | SELECT id_topic, id_board, sent |
@@ -686,8 +719,9 @@ discard block |
||
| 686 | 719 | $context['is_marked_notify'] = true; |
| 687 | 720 | $board_sent = $row['sent']; |
| 688 | 721 | } |
| 689 | - if (!empty($row['id_topic'])) |
|
| 690 | - $context['topics'][$row['id_topic']]['is_watched'] = true; |
|
| 722 | + if (!empty($row['id_topic'])) { |
|
| 723 | + $context['topics'][$row['id_topic']]['is_watched'] = true; |
|
| 724 | + } |
|
| 691 | 725 | } |
| 692 | 726 | $smcFunc['db_free_result']($request); |
| 693 | 727 | |
@@ -711,8 +745,7 @@ discard block |
||
| 711 | 745 | $pref = !empty($pref[$user_info['id']]) ? $pref[$user_info['id']] : array(); |
| 712 | 746 | $pref = isset($pref['board_notify_' . $board]) ? $pref['board_notify_' . $board] : (!empty($pref['board_notify']) ? $pref['board_notify'] : 0); |
| 713 | 747 | $context['board_notification_mode'] = !$context['is_marked_notify'] ? 1 : ($pref & 0x02 ? 3 : ($pref & 0x01 ? 2 : 1)); |
| 714 | - } |
|
| 715 | - else |
|
| 748 | + } else |
|
| 716 | 749 | { |
| 717 | 750 | $context['is_marked_notify'] = false; |
| 718 | 751 | $context['board_notification_mode'] = 1; |
@@ -725,23 +758,27 @@ discard block |
||
| 725 | 758 | $context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false; |
| 726 | 759 | |
| 727 | 760 | // Don't want to show this forever... |
| 728 | - if ($context['becomesUnapproved']) |
|
| 729 | - unset($_SESSION['becomesUnapproved']); |
|
| 761 | + if ($context['becomesUnapproved']) { |
|
| 762 | + unset($_SESSION['becomesUnapproved']); |
|
| 763 | + } |
|
| 730 | 764 | |
| 731 | 765 | // Build the message index button array. |
| 732 | 766 | $context['normal_buttons'] = array(); |
| 733 | 767 | |
| 734 | - if ($context['can_post_new']) |
|
| 735 | - $context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true); |
|
| 768 | + if ($context['can_post_new']) { |
|
| 769 | + $context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true); |
|
| 770 | + } |
|
| 736 | 771 | |
| 737 | - if ($context['can_post_poll']) |
|
| 738 | - $context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll'); |
|
| 772 | + if ($context['can_post_poll']) { |
|
| 773 | + $context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll'); |
|
| 774 | + } |
|
| 739 | 775 | |
| 740 | - if (!$context['user']['is_logged']) |
|
| 741 | - $context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
| 776 | + if (!$context['user']['is_logged']) { |
|
| 777 | + $context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
| 778 | + } |
|
| 742 | 779 | |
| 743 | - if ($context['can_mark_notify']) |
|
| 744 | - $context['normal_buttons']['notify'] = array( |
|
| 780 | + if ($context['can_mark_notify']) { |
|
| 781 | + $context['normal_buttons']['notify'] = array( |
|
| 745 | 782 | 'lang' => true, |
| 746 | 783 | 'text' => 'notify_board_' . $context['board_notification_mode'], |
| 747 | 784 | 'sub_buttons' => array( |
@@ -759,6 +796,7 @@ discard block |
||
| 759 | 796 | ), |
| 760 | 797 | ), |
| 761 | 798 | ); |
| 799 | + } |
|
| 762 | 800 | |
| 763 | 801 | // Javascript for inline editing. |
| 764 | 802 | loadJavaScriptFile('topic.js', array('defer' => false), 'smf_topic'); |
@@ -780,18 +818,21 @@ discard block |
||
| 780 | 818 | checkSession('request'); |
| 781 | 819 | |
| 782 | 820 | // Lets go straight to the restore area. |
| 783 | - if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics'])) |
|
| 784 | - redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
| 821 | + if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics'])) { |
|
| 822 | + redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
| 823 | + } |
|
| 785 | 824 | |
| 786 | - if (isset($_SESSION['topicseen_cache'])) |
|
| 787 | - $_SESSION['topicseen_cache'] = array(); |
|
| 825 | + if (isset($_SESSION['topicseen_cache'])) { |
|
| 826 | + $_SESSION['topicseen_cache'] = array(); |
|
| 827 | + } |
|
| 788 | 828 | |
| 789 | 829 | // This is going to be needed to send off the notifications and for updateLastMessages(). |
| 790 | 830 | require_once($sourcedir . '/Subs-Post.php'); |
| 791 | 831 | |
| 792 | 832 | // Remember the last board they moved things to. |
| 793 | - if (isset($_REQUEST['move_to'])) |
|
| 794 | - $_SESSION['move_to_topic'] = $_REQUEST['move_to']; |
|
| 833 | + if (isset($_REQUEST['move_to'])) { |
|
| 834 | + $_SESSION['move_to_topic'] = $_REQUEST['move_to']; |
|
| 835 | + } |
|
| 795 | 836 | |
| 796 | 837 | // Only a few possible actions. |
| 797 | 838 | $possibleActions = array(); |
@@ -811,8 +852,7 @@ discard block |
||
| 811 | 852 | ); |
| 812 | 853 | |
| 813 | 854 | $redirect_url = 'board=' . $board . '.' . $_REQUEST['start']; |
| 814 | - } |
|
| 815 | - else |
|
| 855 | + } else |
|
| 816 | 856 | { |
| 817 | 857 | /** |
| 818 | 858 | * @todo Ugly. There's no getting around this, is there? |
@@ -830,8 +870,7 @@ discard block |
||
| 830 | 870 | if (!empty($board)) |
| 831 | 871 | { |
| 832 | 872 | $boards_can['post_new'] = array_diff(boardsAllowedTo('post_new'), array($board)); |
| 833 | - } |
|
| 834 | - else |
|
| 873 | + } else |
|
| 835 | 874 | { |
| 836 | 875 | $boards_can['post_new'] = boardsAllowedTo('post_new'); |
| 837 | 876 | } |
@@ -842,55 +881,67 @@ discard block |
||
| 842 | 881 | } |
| 843 | 882 | } |
| 844 | 883 | |
| 845 | - if (!$user_info['is_guest']) |
|
| 846 | - $possibleActions[] = 'markread'; |
|
| 847 | - if (!empty($boards_can['make_sticky'])) |
|
| 848 | - $possibleActions[] = 'sticky'; |
|
| 849 | - if (!empty($boards_can['move_any']) || !empty($boards_can['move_own'])) |
|
| 850 | - $possibleActions[] = 'move'; |
|
| 851 | - if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own'])) |
|
| 852 | - $possibleActions[] = 'remove'; |
|
| 853 | - if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own'])) |
|
| 854 | - $possibleActions[] = 'lock'; |
|
| 855 | - if (!empty($boards_can['merge_any'])) |
|
| 856 | - $possibleActions[] = 'merge'; |
|
| 857 | - if (!empty($boards_can['approve_posts'])) |
|
| 858 | - $possibleActions[] = 'approve'; |
|
| 884 | + if (!$user_info['is_guest']) { |
|
| 885 | + $possibleActions[] = 'markread'; |
|
| 886 | + } |
|
| 887 | + if (!empty($boards_can['make_sticky'])) { |
|
| 888 | + $possibleActions[] = 'sticky'; |
|
| 889 | + } |
|
| 890 | + if (!empty($boards_can['move_any']) || !empty($boards_can['move_own'])) { |
|
| 891 | + $possibleActions[] = 'move'; |
|
| 892 | + } |
|
| 893 | + if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own'])) { |
|
| 894 | + $possibleActions[] = 'remove'; |
|
| 895 | + } |
|
| 896 | + if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own'])) { |
|
| 897 | + $possibleActions[] = 'lock'; |
|
| 898 | + } |
|
| 899 | + if (!empty($boards_can['merge_any'])) { |
|
| 900 | + $possibleActions[] = 'merge'; |
|
| 901 | + } |
|
| 902 | + if (!empty($boards_can['approve_posts'])) { |
|
| 903 | + $possibleActions[] = 'approve'; |
|
| 904 | + } |
|
| 859 | 905 | |
| 860 | 906 | // Two methods: $_REQUEST['actions'] (id_topic => action), and $_REQUEST['topics'] and $_REQUEST['qaction']. |
| 861 | 907 | // (if action is 'move', $_REQUEST['move_to'] or $_REQUEST['move_tos'][$topic] is used.) |
| 862 | 908 | if (!empty($_REQUEST['topics'])) |
| 863 | 909 | { |
| 864 | 910 | // If the action isn't valid, just quit now. |
| 865 | - if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions)) |
|
| 866 | - redirectexit($redirect_url); |
|
| 911 | + if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions)) { |
|
| 912 | + redirectexit($redirect_url); |
|
| 913 | + } |
|
| 867 | 914 | |
| 868 | 915 | // Merge requires all topics as one parameter and can be done at once. |
| 869 | 916 | if ($_REQUEST['qaction'] == 'merge') |
| 870 | 917 | { |
| 871 | 918 | // Merge requires at least two topics. |
| 872 | - if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2) |
|
| 873 | - redirectexit($redirect_url); |
|
| 919 | + if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2) { |
|
| 920 | + redirectexit($redirect_url); |
|
| 921 | + } |
|
| 874 | 922 | |
| 875 | 923 | require_once($sourcedir . '/SplitTopics.php'); |
| 876 | 924 | return MergeExecute($_REQUEST['topics']); |
| 877 | 925 | } |
| 878 | 926 | |
| 879 | 927 | // Just convert to the other method, to make it easier. |
| 880 | - foreach ($_REQUEST['topics'] as $topic) |
|
| 881 | - $_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction']; |
|
| 928 | + foreach ($_REQUEST['topics'] as $topic) { |
|
| 929 | + $_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction']; |
|
| 930 | + } |
|
| 882 | 931 | } |
| 883 | 932 | |
| 884 | 933 | // Weird... how'd you get here? |
| 885 | - if (empty($_REQUEST['actions'])) |
|
| 886 | - redirectexit($redirect_url); |
|
| 934 | + if (empty($_REQUEST['actions'])) { |
|
| 935 | + redirectexit($redirect_url); |
|
| 936 | + } |
|
| 887 | 937 | |
| 888 | 938 | // Validate each action. |
| 889 | 939 | $temp = array(); |
| 890 | 940 | foreach ($_REQUEST['actions'] as $topic => $action) |
| 891 | 941 | { |
| 892 | - if (in_array($action, $possibleActions)) |
|
| 893 | - $temp[(int) $topic] = $action; |
|
| 942 | + if (in_array($action, $possibleActions)) { |
|
| 943 | + $temp[(int) $topic] = $action; |
|
| 944 | + } |
|
| 894 | 945 | } |
| 895 | 946 | $_REQUEST['actions'] = $temp; |
| 896 | 947 | |
@@ -911,27 +962,31 @@ discard block |
||
| 911 | 962 | { |
| 912 | 963 | if (!empty($board)) |
| 913 | 964 | { |
| 914 | - if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts'))) |
|
| 915 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 916 | - } |
|
| 917 | - else |
|
| 965 | + if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts'))) { |
|
| 966 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 967 | + } |
|
| 968 | + } else |
|
| 918 | 969 | { |
| 919 | 970 | // Don't allow them to act on unapproved posts they can't see... |
| 920 | - if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])) |
|
| 921 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 971 | + if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])) { |
|
| 972 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 973 | + } |
|
| 922 | 974 | // Goodness, this is fun. We need to validate the action. |
| 923 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky'])) |
|
| 924 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 925 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own'])))) |
|
| 926 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 927 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own'])))) |
|
| 928 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 975 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky'])) { |
|
| 976 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 977 | + } elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own'])))) { |
|
| 978 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 979 | + } elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own'])))) { |
|
| 980 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 981 | + } |
|
| 929 | 982 | // @todo $locked is not set, what are you trying to do? (taking the change it is supposed to be $row['locked']) |
| 930 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own'])))) |
|
| 931 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 983 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own'])))) { |
|
| 984 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 985 | + } |
|
| 932 | 986 | // If the topic is approved then you need permission to approve the posts within. |
| 933 | - elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])))) |
|
| 934 | - unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 987 | + elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])))) { |
|
| 988 | + unset($_REQUEST['actions'][$row['id_topic']]); |
|
| 989 | + } |
|
| 935 | 990 | } |
| 936 | 991 | } |
| 937 | 992 | $smcFunc['db_free_result']($request); |
@@ -949,11 +1004,11 @@ discard block |
||
| 949 | 1004 | { |
| 950 | 1005 | $topic = (int) $topic; |
| 951 | 1006 | |
| 952 | - if ($action == 'markread') |
|
| 953 | - $markCache[] = $topic; |
|
| 954 | - elseif ($action == 'sticky') |
|
| 955 | - $stickyCache[] = $topic; |
|
| 956 | - elseif ($action == 'move') |
|
| 1007 | + if ($action == 'markread') { |
|
| 1008 | + $markCache[] = $topic; |
|
| 1009 | + } elseif ($action == 'sticky') { |
|
| 1010 | + $stickyCache[] = $topic; |
|
| 1011 | + } elseif ($action == 'move') |
|
| 957 | 1012 | { |
| 958 | 1013 | require_once($sourcedir . '/MoveTopic.php'); |
| 959 | 1014 | moveTopicConcurrence(); |
@@ -961,23 +1016,25 @@ discard block |
||
| 961 | 1016 | // $moveCache[0] is the topic, $moveCache[1] is the board to move to. |
| 962 | 1017 | $moveCache[1][$topic] = (int) (isset($_REQUEST['move_tos'][$topic]) ? $_REQUEST['move_tos'][$topic] : $_REQUEST['move_to']); |
| 963 | 1018 | |
| 964 | - if (empty($moveCache[1][$topic])) |
|
| 965 | - continue; |
|
| 1019 | + if (empty($moveCache[1][$topic])) { |
|
| 1020 | + continue; |
|
| 1021 | + } |
|
| 966 | 1022 | |
| 967 | 1023 | $moveCache[0][] = $topic; |
| 1024 | + } elseif ($action == 'remove') { |
|
| 1025 | + $removeCache[] = $topic; |
|
| 1026 | + } elseif ($action == 'lock') { |
|
| 1027 | + $lockCache[] = $topic; |
|
| 1028 | + } elseif ($action == 'approve') { |
|
| 1029 | + $approveCache[] = $topic; |
|
| 968 | 1030 | } |
| 969 | - elseif ($action == 'remove') |
|
| 970 | - $removeCache[] = $topic; |
|
| 971 | - elseif ($action == 'lock') |
|
| 972 | - $lockCache[] = $topic; |
|
| 973 | - elseif ($action == 'approve') |
|
| 974 | - $approveCache[] = $topic; |
|
| 975 | 1031 | } |
| 976 | 1032 | |
| 977 | - if (empty($board)) |
|
| 978 | - $affectedBoards = array(); |
|
| 979 | - else |
|
| 980 | - $affectedBoards = array($board => array(0, 0)); |
|
| 1033 | + if (empty($board)) { |
|
| 1034 | + $affectedBoards = array(); |
|
| 1035 | + } else { |
|
| 1036 | + $affectedBoards = array($board => array(0, 0)); |
|
| 1037 | + } |
|
| 981 | 1038 | |
| 982 | 1039 | // Do all the stickies... |
| 983 | 1040 | if (!empty($stickyCache)) |
@@ -1037,14 +1094,16 @@ discard block |
||
| 1037 | 1094 | { |
| 1038 | 1095 | $to = $moveCache[1][$row['id_topic']]; |
| 1039 | 1096 | |
| 1040 | - if (empty($to)) |
|
| 1041 | - continue; |
|
| 1097 | + if (empty($to)) { |
|
| 1098 | + continue; |
|
| 1099 | + } |
|
| 1042 | 1100 | |
| 1043 | 1101 | // Does this topic's board count the posts or not? |
| 1044 | 1102 | $countPosts[$row['id_topic']] = empty($row['count_posts']); |
| 1045 | 1103 | |
| 1046 | - if (!isset($moveTos[$to])) |
|
| 1047 | - $moveTos[$to] = array(); |
|
| 1104 | + if (!isset($moveTos[$to])) { |
|
| 1105 | + $moveTos[$to] = array(); |
|
| 1106 | + } |
|
| 1048 | 1107 | |
| 1049 | 1108 | $moveTos[$to][] = $row['id_topic']; |
| 1050 | 1109 | |
@@ -1058,8 +1117,9 @@ discard block |
||
| 1058 | 1117 | require_once($sourcedir . '/MoveTopic.php'); |
| 1059 | 1118 | |
| 1060 | 1119 | // Do the actual moves... |
| 1061 | - foreach ($moveTos as $to => $topics) |
|
| 1062 | - moveTopics($topics, $to); |
|
| 1120 | + foreach ($moveTos as $to => $topics) { |
|
| 1121 | + moveTopics($topics, $to); |
|
| 1122 | + } |
|
| 1063 | 1123 | |
| 1064 | 1124 | // Does the post counts need to be updated? |
| 1065 | 1125 | if (!empty($moveTos)) |
@@ -1108,20 +1168,23 @@ discard block |
||
| 1108 | 1168 | |
| 1109 | 1169 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
| 1110 | 1170 | { |
| 1111 | - if (!isset($members[$row['id_member']])) |
|
| 1112 | - $members[$row['id_member']] = 0; |
|
| 1171 | + if (!isset($members[$row['id_member']])) { |
|
| 1172 | + $members[$row['id_member']] = 0; |
|
| 1173 | + } |
|
| 1113 | 1174 | |
| 1114 | - if ($topicRecounts[$row['id_topic']] === '+') |
|
| 1115 | - $members[$row['id_member']] += 1; |
|
| 1116 | - else |
|
| 1117 | - $members[$row['id_member']] -= 1; |
|
| 1175 | + if ($topicRecounts[$row['id_topic']] === '+') { |
|
| 1176 | + $members[$row['id_member']] += 1; |
|
| 1177 | + } else { |
|
| 1178 | + $members[$row['id_member']] -= 1; |
|
| 1179 | + } |
|
| 1118 | 1180 | } |
| 1119 | 1181 | |
| 1120 | 1182 | $smcFunc['db_free_result']($request); |
| 1121 | 1183 | |
| 1122 | 1184 | // And now update them member's post counts |
| 1123 | - foreach ($members as $id_member => $post_adj) |
|
| 1124 | - updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj)); |
|
| 1185 | + foreach ($members as $id_member => $post_adj) { |
|
| 1186 | + updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj)); |
|
| 1187 | + } |
|
| 1125 | 1188 | |
| 1126 | 1189 | } |
| 1127 | 1190 | } |
@@ -1201,8 +1264,9 @@ discard block |
||
| 1201 | 1264 | approveTopics($approveCache); |
| 1202 | 1265 | |
| 1203 | 1266 | // Time for some logging! |
| 1204 | - foreach ($approveCache as $topic) |
|
| 1205 | - logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic])); |
|
| 1267 | + foreach ($approveCache as $topic) { |
|
| 1268 | + logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic])); |
|
| 1269 | + } |
|
| 1206 | 1270 | } |
| 1207 | 1271 | } |
| 1208 | 1272 | |
@@ -1237,8 +1301,7 @@ discard block |
||
| 1237 | 1301 | $lockStatus[$row['id_topic']] = empty($row['locked']); |
| 1238 | 1302 | } |
| 1239 | 1303 | $smcFunc['db_free_result']($result); |
| 1240 | - } |
|
| 1241 | - else |
|
| 1304 | + } else |
|
| 1242 | 1305 | { |
| 1243 | 1306 | $result = $smcFunc['db_query']('', ' |
| 1244 | 1307 | SELECT id_topic, locked, id_board |
@@ -1288,13 +1351,15 @@ discard block |
||
| 1288 | 1351 | ) |
| 1289 | 1352 | ); |
| 1290 | 1353 | $logged_topics = array(); |
| 1291 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
| 1292 | - $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
| 1354 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
| 1355 | + $logged_topics[$row['id_topic']] = $row['unwatched']; |
|
| 1356 | + } |
|
| 1293 | 1357 | $smcFunc['db_free_result']($request); |
| 1294 | 1358 | |
| 1295 | 1359 | $markArray = array(); |
| 1296 | - foreach ($markCache as $topic) |
|
| 1297 | - $markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
| 1360 | + foreach ($markCache as $topic) { |
|
| 1361 | + $markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0)); |
|
| 1362 | + } |
|
| 1298 | 1363 | |
| 1299 | 1364 | $smcFunc['db_insert']('replace', |
| 1300 | 1365 | '{db_prefix}log_topics', |
@@ -1307,8 +1372,9 @@ discard block |
||
| 1307 | 1372 | foreach ($moveCache as $topic) |
| 1308 | 1373 | { |
| 1309 | 1374 | // Didn't actually move anything! |
| 1310 | - if (!isset($topic[0])) |
|
| 1311 | - break; |
|
| 1375 | + if (!isset($topic[0])) { |
|
| 1376 | + break; |
|
| 1377 | + } |
|
| 1312 | 1378 | |
| 1313 | 1379 | logAction('move', array('topic' => $topic[0], 'board_from' => $topic[1], 'board_to' => $topic[2])); |
| 1314 | 1380 | sendNotifications($topic[0], 'move'); |
@@ -1330,8 +1396,9 @@ discard block |
||
| 1330 | 1396 | 'calendar_updated' => time(), |
| 1331 | 1397 | )); |
| 1332 | 1398 | |
| 1333 | - if (!empty($affectedBoards)) |
|
| 1334 | - updateLastMessages(array_keys($affectedBoards)); |
|
| 1399 | + if (!empty($affectedBoards)) { |
|
| 1400 | + updateLastMessages(array_keys($affectedBoards)); |
|
| 1401 | + } |
|
| 1335 | 1402 | |
| 1336 | 1403 | redirectexit($redirect_url); |
| 1337 | 1404 | } |