Completed
Push — release-2.1 ( 3ecb1d...9bf9e9 )
by Mathias
08:21
created
Themes/default/ManageSmileys.template.php 1 patch
Braces   +55 added lines, -41 removed lines patch added patch discarded remove patch
@@ -63,18 +63,19 @@  discard block
 block discarded – undo
63 63
 					</dt>
64 64
 					<dd>
65 65
 						', $modSettings['smileys_url'], '/';
66
-		if ($context['current_set']['id'] == 'default')
67
-			echo '<strong>default</strong><input type="hidden" name="smiley_sets_path" id="smiley_sets_path" value="default">';
68
-		elseif (empty($context['smiley_set_dirs']))
69
-			echo '
66
+		if ($context['current_set']['id'] == 'default') {
67
+					echo '<strong>default</strong><input type="hidden" name="smiley_sets_path" id="smiley_sets_path" value="default">';
68
+		} elseif (empty($context['smiley_set_dirs'])) {
69
+					echo '
70 70
 						<input type="text" name="smiley_sets_path" id="smiley_sets_path" value="', $context['current_set']['path'], '"> ';
71
-		else
71
+		} else
72 72
 		{
73 73
 			echo '
74 74
 						<select name="smiley_sets_path" id="smiley_sets_path">';
75
-			foreach ($context['smiley_set_dirs'] as $smiley_set_dir)
76
-				echo '
75
+			foreach ($context['smiley_set_dirs'] as $smiley_set_dir) {
76
+							echo '
77 77
 							<option value="', $smiley_set_dir['id'], '"', $smiley_set_dir['current'] ? ' selected' : '', $smiley_set_dir['selectable'] ? '' : ' disabled', '>', $smiley_set_dir['id'], '</option>';
78
+			}
78 79
 			echo '
79 80
 						</select> ';
80 81
 		}
@@ -89,14 +90,15 @@  discard block
 block discarded – undo
89 90
 					</dd>';
90 91
 
91 92
 		// If this is a new smiley set they have the option to import smileys already in the directory.
92
-		if ($context['current_set']['is_new'] && !empty($modSettings['smiley_enable']))
93
-			echo '
93
+		if ($context['current_set']['is_new'] && !empty($modSettings['smiley_enable'])) {
94
+					echo '
94 95
 					<dt>
95 96
 						<strong><label for="smiley_sets_import">', $txt['smiley_set_import_directory'], '</label>: </strong>
96 97
 					</dt>
97 98
 					<dd>
98 99
 						<input type="checkbox" name="smiley_sets_import" id="smiley_sets_import" value="1">
99 100
 					</dd>';
101
+		}
100 102
 
101 103
 		echo '
102 104
 				</dl>
@@ -130,9 +132,10 @@  discard block
 block discarded – undo
130 132
 					<dd>
131 133
 						<img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $context['current_smiley']['filename'], '" id="preview" alt=""> (', $txt['smiley_preview_using'], ': <select name="set" onchange="updatePreview();">';
132 134
 
133
-		foreach ($context['smiley_sets'] as $smiley_set)
134
-			echo '
135
+		foreach ($context['smiley_sets'] as $smiley_set) {
136
+					echo '
135 137
 						<option value="', $smiley_set['path'], '"', $context['selected_set'] == $smiley_set['path'] ? ' selected' : '', '>', $smiley_set['name'], '</option>';
138
+		}
136 139
 
137 140
 		echo '
138 141
 						</select>)
@@ -147,16 +150,17 @@  discard block
 block discarded – undo
147 150
 						<strong><label for="smiley_filename">', $txt['smileys_filename'], '</label>: </strong>
148 151
 					</dt>
149 152
 					<dd>';
150
-			if (empty($context['filenames']))
151
-				echo '
153
+			if (empty($context['filenames'])) {
154
+							echo '
152 155
 						<input type="text" name="smiley_filename" id="smiley_filename" value="', $context['current_smiley']['filename'], '">';
153
-			else
156
+			} else
154 157
 			{
155 158
 				echo '
156 159
 						<select name="smiley_filename" id="smiley_filename" onchange="updatePreview();">';
157
-				foreach ($context['filenames'] as $filename)
158
-					echo '
160
+				foreach ($context['filenames'] as $filename) {
161
+									echo '
159 162
 							<option value="', $filename['id'], '"', $filename['selected'] ? ' selected' : '', '>', $filename['id'], '</option>';
163
+				}
160 164
 				echo '
161 165
 						</select>';
162 166
 			}
@@ -225,9 +229,10 @@  discard block
 block discarded – undo
225 229
 						<dd>
226 230
 							', $txt['smiley_preview_using'], ': <select name="set" onchange="updatePreview();selectMethod(\'existing\');">';
227 231
 
228
-		foreach ($context['smiley_sets'] as $smiley_set)
229
-			echo '
232
+		foreach ($context['smiley_sets'] as $smiley_set) {
233
+					echo '
230 234
 							<option value="', $smiley_set['path'], '"', $context['selected_set'] == $smiley_set['path'] ? ' selected' : '', '>', $smiley_set['name'], '</option>';
235
+		}
231 236
 
232 237
 		echo '
233 238
 							</select>
@@ -236,16 +241,17 @@  discard block
 block discarded – undo
236 241
 							<strong><label for="smiley_filename">', $txt['smileys_filename'], '</label>: </strong>
237 242
 						</dt>
238 243
 						<dd>';
239
-	if (empty($context['filenames']))
240
-		echo '
244
+	if (empty($context['filenames'])) {
245
+			echo '
241 246
 							<input type="text" name="smiley_filename" id="smiley_filename" value="', $context['current_smiley']['filename'], '" onchange="selectMethod(\'existing\');">';
242
-	else
247
+	} else
243 248
 	{
244 249
 		echo '
245 250
 								<select name="smiley_filename" id="smiley_filename" onchange="updatePreview();selectMethod(\'existing\');">';
246
-		foreach ($context['filenames'] as $filename)
247
-			echo '
251
+		foreach ($context['filenames'] as $filename) {
252
+					echo '
248 253
 								<option value="', $filename['id'], '"', $filename['selected'] ? ' selected' : '', '>', $filename['id'], '</option>';
254
+		}
249 255
 		echo '
250 256
 							</select>';
251 257
 	}
@@ -273,14 +279,15 @@  discard block
 block discarded – undo
273 279
 				</fieldset>
274 280
 
275 281
 				<dl id="uploadMore" style="display: none;" class="settings">';
276
-	foreach ($context['smiley_sets'] as $smiley_set)
277
-		echo '
282
+	foreach ($context['smiley_sets'] as $smiley_set) {
283
+			echo '
278 284
 					<dt>
279 285
 						', sprintf($txt['smileys_add_upload_for'], '<strong>' . $smiley_set['name'] . '</strong>'), ':
280 286
 					</dt>
281 287
 					<dd>
282 288
 						<input type="file" name="individual_', $smiley_set['name'], '" onchange="selectMethod(\'upload\');">
283 289
 					</dd>';
290
+	}
284 291
 	echo '
285 292
 				</dl>
286 293
 			</div>
@@ -349,24 +356,27 @@  discard block
 block discarded – undo
349 356
 				<strong>', empty($context['move_smiley']) ? $txt['smileys_move_select_smiley'] : $txt['smileys_move_select_destination'], '...</strong><br>';
350 357
 		foreach ($location['rows'] as $row)
351 358
 		{
352
-			if (!empty($context['move_smiley']))
353
-				echo '
359
+			if (!empty($context['move_smiley'])) {
360
+							echo '
354 361
 					<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';row=', $row[0]['row'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>';
362
+			}
355 363
 
356 364
 			foreach ($row as $smiley)
357 365
 			{
358
-				if (empty($context['move_smiley']))
359
-					echo '<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;move=', $smiley['id'], '"><img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px; border: 0px solid black;" alt="', $smiley['description'], '"></a>';
360
-				else
361
-					echo '<img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px;', $smiley['selected'] ? ' border: 2px solid red' : '', ';" alt="', $smiley['description'], '"><a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';after=', $smiley['id'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '" title="', $txt['smileys_move_here'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>';
366
+				if (empty($context['move_smiley'])) {
367
+									echo '<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;move=', $smiley['id'], '"><img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px; border: 0px solid black;" alt="', $smiley['description'], '"></a>';
368
+				} else {
369
+									echo '<img src="', $modSettings['smileys_url'], '/', $modSettings['smiley_sets_default'], '/', $smiley['filename'], '" style="padding: 2px;', $smiley['selected'] ? ' border: 2px solid red' : '', ';" alt="', $smiley['description'], '"><a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';after=', $smiley['id'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '" title="', $txt['smileys_move_here'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>';
370
+				}
362 371
 			}
363 372
 
364 373
 			echo '
365 374
 				<br>';
366 375
 		}
367
-		if (!empty($context['move_smiley']))
368
-			echo '
376
+		if (!empty($context['move_smiley'])) {
377
+					echo '
369 378
 				<a href="', $scripturl, '?action=admin;area=smileys;sa=setorder;location=', $location['id'], ';source=', $context['move_smiley'], ';row=', $location['last_row'], ';reorder=1;', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons select_below" title="', $txt['smileys_move_here'], '"></span></a>';
379
+		}
370 380
 		echo '
371 381
 			</div>
372 382
 		<input type="hidden" name="reorder" value="1">
@@ -402,14 +412,15 @@  discard block
 block discarded – undo
402 412
 			</div>
403 413
 			<div class="windowbg2">
404 414
 				<dl class="settings">';
405
-	if (!$context['new_icon'])
406
-		echo '
415
+	if (!$context['new_icon']) {
416
+			echo '
407 417
 					<dt>
408 418
 						<strong>', $txt['smiley_preview'], ': </strong>
409 419
 					</dt>
410 420
 					<dd>
411 421
 						<img src="', $context['icon']['image_url'], '" alt="', $context['icon']['title'], '">
412 422
 					</dd>';
423
+	}
413 424
 	echo '
414 425
 					<dt>
415 426
 						<strong><label for="icon_filename">', $txt['smileys_filename'], '</label>: </strong><br><span class="smalltext">', $txt['icons_filename_all_png'], '</span>
@@ -434,9 +445,10 @@  discard block
 block discarded – undo
434 445
 	{
435 446
 		echo '
436 447
 							<optgroup label="', $category['name'], '">';
437
-		foreach ($category['boards'] as $board)
438
-			echo '
448
+		foreach ($category['boards'] as $board) {
449
+					echo '
439 450
 								<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '</option>';
451
+		}
440 452
 		echo '
441 453
 							</optgroup>';
442 454
 	}
@@ -451,19 +463,21 @@  discard block
 block discarded – undo
451 463
 							<option value="0"', empty($context['icon']['after']) ? ' selected' : '', '>', $txt['icons_location_first_icon'], '</option>';
452 464
 
453 465
 	// Print the list of all the icons it can be put after...
454
-	foreach ($context['icons'] as $id => $data)
455
-		if (empty($context['icon']['id']) || $id != $context['icon']['id'])
466
+	foreach ($context['icons'] as $id => $data) {
467
+			if (empty($context['icon']['id']) || $id != $context['icon']['id'])
456 468
 			echo '
457 469
 							<option value="', $id, '"', !empty($context['icon']['after']) && $id == $context['icon']['after'] ? ' selected' : '', '>', $txt['icons_location_after'], ': ', $data['title'], '</option>';
470
+	}
458 471
 
459 472
 	echo '
460 473
 						</select>
461 474
 					</dd>
462 475
 				</dl>';
463 476
 
464
-	if (!$context['new_icon'])
465
-		echo '
477
+	if (!$context['new_icon']) {
478
+			echo '
466 479
 				<input type="hidden" name="icon" value="', $context['icon']['id'], '">';
480
+	}
467 481
 
468 482
 	echo '
469 483
 				<input type="submit" name="icons_save" value="', $txt['smileys_save'], '" class="button">
Please login to merge, or discard this patch.
Themes/default/Calendar.template.php 1 patch
Braces   +154 added lines, -118 removed lines patch added patch discarded remove patch
@@ -40,16 +40,14 @@  discard block
 block discarded – undo
40 40
 				', template_show_upcoming_list('main'), '
41 41
 			</div>
42 42
 		';
43
-	}
44
-	elseif ($context['calendar_view'] == 'viewweek')
43
+	} elseif ($context['calendar_view'] == 'viewweek')
45 44
 	{
46 45
 		echo '
47 46
 			<div id="main_grid">
48 47
 				', template_show_week_grid('main'), '
49 48
 			</div>
50 49
 		';
51
-	}
52
-	else
50
+	} else
53 51
 	{
54 52
 		echo '
55 53
 			<div id="main_grid">
@@ -75,8 +73,9 @@  discard block
 block discarded – undo
75 73
 	global $context, $scripturl, $txt;
76 74
 
77 75
 	// Bail out if we have nothing to work with
78
-	if (!isset($context['calendar_grid_' . $grid_name]))
79
-		return false;
76
+	if (!isset($context['calendar_grid_' . $grid_name])) {
77
+			return false;
78
+	}
80 79
 
81 80
 	// Protect programmer sanity
82 81
 	$calendar_data = &$context['calendar_grid_' . $grid_name];
@@ -113,11 +112,13 @@  discard block
 block discarded – undo
113 112
 					<li class="windowbg">
114 113
 						<strong class="event_title">', $event['link'], '</strong>';
115 114
 
116
-				if ($event['can_edit'])
117
-					echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>';
115
+				if ($event['can_edit']) {
116
+									echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>';
117
+				}
118 118
 
119
-				if ($event['can_export'])
120
-					echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>';
119
+				if ($event['can_export']) {
120
+									echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>';
121
+				}
121 122
 
122 123
 				echo '
123 124
 						<br>';
@@ -125,14 +126,14 @@  discard block
 block discarded – undo
125 126
 				if (!empty($event['allday']))
126 127
 				{
127 128
 					echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : '';
128
-				}
129
-				else
129
+				} else
130 130
 				{
131 131
 					// Display event info relative to user's local timezone
132 132
 					echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">';
133 133
 
134
-					if ($event['start_date_local'] != $event['end_date_local'])
135
-						echo trim($event['end_date_local']) . ', ';
134
+					if ($event['start_date_local'] != $event['end_date_local']) {
135
+											echo trim($event['end_date_local']) . ', ';
136
+					}
136 137
 
137 138
 					echo trim($event['end_time_local']);
138 139
 
@@ -141,23 +142,27 @@  discard block
 block discarded – undo
141 142
 					{
142 143
 						echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">';
143 144
 
144
-						if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig'])
145
-							echo trim($event['start_date_orig']), ', ';
145
+						if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) {
146
+													echo trim($event['start_date_orig']), ', ';
147
+						}
146 148
 
147 149
 						echo trim($event['start_time_orig']), '</time> &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">';
148 150
 
149
-						if ($event['start_date_orig'] != $event['end_date_orig'])
150
-							echo trim($event['end_date_orig']) . ', ';
151
+						if ($event['start_date_orig'] != $event['end_date_orig']) {
152
+													echo trim($event['end_date_orig']) . ', ';
153
+						}
151 154
 
152 155
 						echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)';
153 156
 					}
154 157
 					// Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion
155
-					else
156
-						echo ' ', $event['tz_abbrev'], '</time>';
158
+					else {
159
+											echo ' ', $event['tz_abbrev'], '</time>';
160
+					}
157 161
 				}
158 162
 
159
-				if (!empty($event['location']))
160
-					echo '<br>', $event['location'];
163
+				if (!empty($event['location'])) {
164
+									echo '<br>', $event['location'];
165
+				}
161 166
 
162 167
 				echo '
163 168
 					</li>';
@@ -189,8 +194,9 @@  discard block
 block discarded – undo
189 194
 
190 195
 			$birthdays = array();
191 196
 
192
-			foreach ($date as $member)
193
-				$birthdays[] = '<a href="' . $scripturl . '?action=profile;u=' . $member['id'] . '">' . $member['name'] . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>';
197
+			foreach ($date as $member) {
198
+							$birthdays[] = '<a href="' . $scripturl . '?action=profile;u=' . $member['id'] . '">' . $member['name'] . (isset($member['age']) ? ' (' . $member['age'] . ')' : '') . '</a>';
199
+			}
194 200
 
195 201
 			echo implode(', ', $birthdays);
196 202
 
@@ -221,8 +227,9 @@  discard block
 block discarded – undo
221 227
 			$date_local = $date['date_local'];
222 228
 			unset($date['date_local']);
223 229
 
224
-			foreach ($date as $holiday)
225
-				$holidays[] = $holiday . ' (' . $date_local . ')';
230
+			foreach ($date as $holiday) {
231
+							$holidays[] = $holiday . ' (' . $date_local . ')';
232
+			}
226 233
 		}
227 234
 
228 235
 		echo implode(', ', $holidays);
@@ -245,17 +252,19 @@  discard block
 block discarded – undo
245 252
 	global $context, $txt, $scripturl, $modSettings;
246 253
 
247 254
 	// If the grid doesn't exist, no point in proceeding.
248
-	if (!isset($context['calendar_grid_' . $grid_name]))
249
-		return false;
255
+	if (!isset($context['calendar_grid_' . $grid_name])) {
256
+			return false;
257
+	}
250 258
 
251 259
 	// A handy little pointer variable.
252 260
 	$calendar_data = &$context['calendar_grid_' . $grid_name];
253 261
 
254 262
 	// Some conditions for whether or not we should show the week links *here*.
255
-	if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false)))
256
-		$show_week_links = true;
257
-	else
258
-		$show_week_links = false;
263
+	if (isset($calendar_data['show_week_links']) && ($calendar_data['show_week_links'] == 3 || (($calendar_data['show_week_links'] == 1 && $is_mini === true) || $calendar_data['show_week_links'] == 2 && $is_mini === false))) {
264
+			$show_week_links = true;
265
+	} else {
266
+			$show_week_links = false;
267
+	}
259 268
 
260 269
 	// Assuming that we've not disabled it, show the title block!
261 270
 	if (empty($calendar_data['disable_title']))
@@ -294,8 +303,9 @@  discard block
 block discarded – undo
294 303
 	}
295 304
 
296 305
 	// Show the controls on main grids
297
-	if ($is_mini === false)
298
-		template_calendar_top($calendar_data);
306
+	if ($is_mini === false) {
307
+			template_calendar_top($calendar_data);
308
+	}
299 309
 
300 310
 	// Finally, the main calendar table.
301 311
 	echo '<table class="calendar_table">';
@@ -306,8 +316,9 @@  discard block
 block discarded – undo
306 316
 		echo '<tr>';
307 317
 
308 318
 		// If we're showing week links, there's an extra column ahead of the week links, so let's think ahead and be prepared!
309
-		if ($show_week_links === true)
310
-			echo '<th>&nbsp;</th>';
319
+		if ($show_week_links === true) {
320
+					echo '<th>&nbsp;</th>';
321
+		}
311 322
 
312 323
 		// Now, loop through each actual day of the week.
313 324
 		foreach ($calendar_data['week_days'] as $day)
@@ -354,27 +365,29 @@  discard block
 block discarded – undo
354 365
 				// Additional classes are given for events, holidays, and birthdays.
355 366
 				if (!empty($day['events']) && !empty($calendar_data['highlight']['events']))
356 367
 				{
357
-					if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3)))
358
-						$classes[] = 'events';
359
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3)))
360
-						$classes[] = 'events';
368
+					if ($is_mini === true && in_array($calendar_data['highlight']['events'], array(1, 3))) {
369
+											$classes[] = 'events';
370
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['events'], array(2, 3))) {
371
+											$classes[] = 'events';
372
+					}
361 373
 				}
362 374
 				if (!empty($day['holidays']) && !empty($calendar_data['highlight']['holidays']))
363 375
 				{
364
-					if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3)))
365
-						$classes[] = 'holidays';
366
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3)))
367
-						$classes[] = 'holidays';
376
+					if ($is_mini === true && in_array($calendar_data['highlight']['holidays'], array(1, 3))) {
377
+											$classes[] = 'holidays';
378
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['holidays'], array(2, 3))) {
379
+											$classes[] = 'holidays';
380
+					}
368 381
 				}
369 382
 				if (!empty($day['birthdays']) && !empty($calendar_data['highlight']['birthdays']))
370 383
 				{
371
-					if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3)))
372
-						$classes[] = 'birthdays';
373
-					elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3)))
374
-						$classes[] = 'birthdays';
384
+					if ($is_mini === true && in_array($calendar_data['highlight']['birthdays'], array(1, 3))) {
385
+											$classes[] = 'birthdays';
386
+					} elseif ($is_mini === false && in_array($calendar_data['highlight']['birthdays'], array(2, 3))) {
387
+											$classes[] = 'birthdays';
388
+					}
375 389
 				}
376
-			}
377
-			else
390
+			} else
378 391
 			{
379 392
 				// Default Classes (either compact or comfortable and disabled).
380 393
 				$classes[] = !empty($calendar_data['size']) && $calendar_data['size'] == 'small' ? 'compact' : 'comfortable';
@@ -392,19 +405,21 @@  discard block
 block discarded – undo
392 405
 				$title_prefix = !empty($day['is_first_of_month']) && $context['current_month'] == $calendar_data['current_month'] && $is_mini === false ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$calendar_data['current_month']] . ' ' : $txt['months_titles'][$calendar_data['current_month']] . ' ') : '';
393 406
 
394 407
 				// The actual day number - be it a link, or just plain old text!
395
-				if (!empty($modSettings['cal_daysaslink']) && $context['can_post'])
396
-					echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
397
-				elseif ($is_mini)
398
-					echo '<a href="', $scripturl, '?action=calendar;', $context['calendar_view'], ';year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
399
-				else
400
-					echo '<span class="day_text">', $title_prefix, $day['day'], '</span>';
408
+				if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) {
409
+									echo '<a href="', $scripturl, '?action=calendar;sa=post;year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
410
+				} elseif ($is_mini) {
411
+									echo '<a href="', $scripturl, '?action=calendar;', $context['calendar_view'], ';year=', $calendar_data['current_year'], ';month=', $calendar_data['current_month'], ';day=', $day['day'], '"><span class="day_text">', $title_prefix, $day['day'], '</span></a>';
412
+				} else {
413
+									echo '<span class="day_text">', $title_prefix, $day['day'], '</span>';
414
+				}
401 415
 
402 416
 				// A lot of stuff, we're not showing on mini-calendars to conserve space.
403 417
 				if ($is_mini === false)
404 418
 				{
405 419
 					// Holidays are always fun, let's show them!
406
-					if (!empty($day['holidays']))
407
-						echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>';
420
+					if (!empty($day['holidays'])) {
421
+											echo '<div class="smalltext holiday"><span>', $txt['calendar_prompt'], '</span> ', implode(', ', $day['holidays']), '</div>';
422
+					}
408 423
 
409 424
 					// Happy Birthday Dear, Member!
410 425
 					if (!empty($day['birthdays']))
@@ -422,14 +437,16 @@  discard block
 block discarded – undo
422 437
 							echo '<a href="', $scripturl, '?action=profile;u=', $member['id'], '"><span class="fix_rtl_names">', $member['name'], '</span>', isset($member['age']) ? ' (' . $member['age'] . ')' : '', '</a>', $member['is_last'] || ($count == 10 && $use_js_hide) ? '' : ', ';
423 438
 
424 439
 							// 9...10! Let's stop there.
425
-							if ($birthday_count == 10 && $use_js_hide)
426
-								// !!TODO - Inline CSS and JavaScript should be moved.
440
+							if ($birthday_count == 10 && $use_js_hide) {
441
+															// !!TODO - Inline CSS and JavaScript should be moved.
427 442
 								echo '<span class="hidelink" id="bdhidelink_', $day['day'], '">...<br><a href="', $scripturl, '?action=calendar;month=', $calendar_data['current_month'], ';year=', $calendar_data['current_year'], ';showbd" onclick="document.getElementById(\'bdhide_', $day['day'], '\').style.display = \'\'; document.getElementById(\'bdhidelink_', $day['day'], '\').style.display = \'none\'; return false;">(', sprintf($txt['calendar_click_all'], count($day['birthdays'])), ')</a></span><span id="bdhide_', $day['day'], '" style="display: none;">, ';
443
+							}
428 444
 
429 445
 							++$birthday_count;
430 446
 						}
431
-						if ($use_js_hide)
432
-							echo '</span>';
447
+						if ($use_js_hide) {
448
+													echo '</span>';
449
+						}
433 450
 
434 451
 						echo '</div>';
435 452
 					}
@@ -439,8 +456,9 @@  discard block
 block discarded – undo
439 456
 					{
440 457
 						// Sort events by start time (all day events will be listed first)
441 458
 						uasort($day['events'], function($a, $b) {
442
-						    if ($a['start_timestamp'] == $b['start_timestamp'])
443
-						        return 0;
459
+						    if ($a['start_timestamp'] == $b['start_timestamp']) {
460
+						    						        return 0;
461
+						    }
444 462
 						    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
445 463
 						});
446 464
 
@@ -456,17 +474,19 @@  discard block
 block discarded – undo
456 474
 
457 475
 							echo '<div class="event_wrapper', $event['starts_today'] == true ? ' event_starts_today' : '', $event['ends_today'] == true ? ' event_ends_today' : '', $event['allday'] == true ? ' allday' : '', $event['is_selected'] ? ' sel_event' : '', '">', $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">';
458 476
 
459
-							if (!empty($event['start_time_local']) && $event['starts_today'] == true)
460
-								echo trim(str_replace(':00 ', ' ', $event['start_time_local']));
461
-							elseif (!empty($event['end_time_local']) && $event['ends_today'] == true)
462
-								echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local']));
463
-							elseif (!empty($event['allday']))
464
-								echo $txt['calendar_allday'];
477
+							if (!empty($event['start_time_local']) && $event['starts_today'] == true) {
478
+															echo trim(str_replace(':00 ', ' ', $event['start_time_local']));
479
+							} elseif (!empty($event['end_time_local']) && $event['ends_today'] == true) {
480
+															echo strtolower($txt['ends']), ' ', trim(str_replace(':00 ', ' ', $event['end_time_local']));
481
+							} elseif (!empty($event['allday'])) {
482
+															echo $txt['calendar_allday'];
483
+							}
465 484
 
466 485
 							echo '</span>';
467 486
 
468
-							if (!empty($event['location']))
469
-								echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
487
+							if (!empty($event['location'])) {
488
+															echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
489
+							}
470 490
 
471 491
 							if ($event['can_edit'] || $event['can_export'])
472 492
 							{
@@ -503,10 +523,11 @@  discard block
 block discarded – undo
503 523
 			// Otherwise, assuming it's not a mini-calendar, we can show previous / next month days!
504 524
 			elseif ($is_mini === false)
505 525
 			{
506
-				if (empty($current_month_started) && !empty($context['calendar_grid_prev']))
507
-					echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>';
508
-				elseif (!empty($current_month_started) && !empty($context['calendar_grid_next']))
509
-					echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>';
526
+				if (empty($current_month_started) && !empty($context['calendar_grid_prev'])) {
527
+									echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_prev']['current_year'], ';month=', $context['calendar_grid_prev']['current_month'], '">', $context['calendar_grid_prev']['last_of_month'] - $calendar_data['shift']-- +1, '</a>';
528
+				} elseif (!empty($current_month_started) && !empty($context['calendar_grid_next'])) {
529
+									echo '<a href="', $scripturl, '?action=calendar;year=', $context['calendar_grid_next']['current_year'], ';month=', $context['calendar_grid_next']['current_month'], '">', $current_month_started + 1 == $count ? (!empty($calendar_data['short_month_titles']) ? $txt['months_short'][$context['calendar_grid_next']['current_month']] . ' ' : $txt['months_titles'][$context['calendar_grid_next']['current_month']] . ' ') : '', $final_count++, '</a>';
530
+				}
510 531
 			}
511 532
 
512 533
 			// Close this day and increase var count.
@@ -532,8 +553,9 @@  discard block
 block discarded – undo
532 553
 	global $context, $txt, $scripturl, $modSettings;
533 554
 
534 555
 	// We might have no reason to proceed, if the variable isn't there.
535
-	if (!isset($context['calendar_grid_' . $grid_name]))
536
-		return false;
556
+	if (!isset($context['calendar_grid_' . $grid_name])) {
557
+			return false;
558
+	}
537 559
 
538 560
 	// Handy pointer.
539 561
 	$calendar_data = &$context['calendar_grid_' . $grid_name];
@@ -568,8 +590,9 @@  discard block
 block discarded – undo
568 590
 					}
569 591
 
570 592
 					// The Month Title + Week Number...
571
-					if (!empty($calendar_data['week_title']))
572
-							echo $calendar_data['week_title'];
593
+					if (!empty($calendar_data['week_title'])) {
594
+												echo $calendar_data['week_title'];
595
+					}
573 596
 
574 597
 					echo '
575 598
 					</h3>
@@ -608,10 +631,11 @@  discard block
 block discarded – undo
608 631
 						<tr class="days_wrapper">
609 632
 							<td class="', implode(' ', $classes), ' act_day">';
610 633
 							// Should the day number be a link?
611
-							if (!empty($modSettings['cal_daysaslink']) && $context['can_post'])
612
-								echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>';
613
-							else
614
-								echo $txt['days'][$day['day_of_week']], ' - ', $day['day'];
634
+							if (!empty($modSettings['cal_daysaslink']) && $context['can_post']) {
635
+															echo '<a href="', $scripturl, '?action=calendar;sa=post;month=', $month_data['current_month'], ';year=', $month_data['current_year'], ';day=', $day['day'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['days'][$day['day_of_week']], ' - ', $day['day'], '</a>';
636
+							} else {
637
+															echo $txt['days'][$day['day_of_week']], ' - ', $day['day'];
638
+							}
615 639
 
616 640
 							echo '</td>
617 641
 							<td class="', implode(' ', $classes), '', empty($day['events']) ? (' disabled' . ($context['can_post'] ? ' week_post' : '')) : ' events', ' event_col" data-css-prefix="' . $txt['events'] . ' ', (empty($day['events']) && empty($context['can_post'])) ? $txt['none'] : '', '">';
@@ -620,8 +644,9 @@  discard block
 block discarded – undo
620 644
 							{
621 645
 								// Sort events by start time (all day events will be listed first)
622 646
 								uasort($day['events'], function($a, $b) {
623
-								    if ($a['start_timestamp'] == $b['start_timestamp'])
624
-								        return 0;
647
+								    if ($a['start_timestamp'] == $b['start_timestamp']) {
648
+								    								        return 0;
649
+								    }
625 650
 								    return ($a['start_timestamp'] < $b['start_timestamp']) ? -1 : 1;
626 651
 								});
627 652
 
@@ -633,15 +658,17 @@  discard block
 block discarded – undo
633 658
 
634 659
 									echo $event['link'], '<br><span class="event_time', empty($event_icons_needed) ? ' floatright' : '', '">';
635 660
 
636
-									if (!empty($event['start_time_local']))
637
-										echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' &ndash; ' . trim($event['end_time_local']) : '';
638
-									else
639
-										echo $txt['calendar_allday'];
661
+									if (!empty($event['start_time_local'])) {
662
+																			echo trim($event['start_time_local']), !empty($event['end_time_local']) ? ' &ndash; ' . trim($event['end_time_local']) : '';
663
+									} else {
664
+																			echo $txt['calendar_allday'];
665
+									}
640 666
 
641 667
 									echo '</span>';
642 668
 
643
-									if (!empty($event['location']))
644
-										echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
669
+									if (!empty($event['location'])) {
670
+																			echo '<br><span class="event_location', empty($event_icons_needed) ? ' floatright' : '', '">' . $event['location'] . '</span>';
671
+									}
645 672
 
646 673
 									if (!empty($event_icons_needed))
647 674
 									{
@@ -678,8 +705,7 @@  discard block
 block discarded – undo
678 705
 									</div>
679 706
 									<br class="clear">';
680 707
 								}
681
-							}
682
-							else
708
+							} else
683 709
 							{
684 710
 								if (!empty($context['can_post']))
685 711
 								{
@@ -692,8 +718,9 @@  discard block
 block discarded – undo
692 718
 							echo '</td>
693 719
 							<td class="', implode(' ', $classes), !empty($day['holidays']) ? ' holidays' : ' disabled', ' holiday_col" data-css-prefix="' . $txt['calendar_prompt'] . ' ">';
694 720
 							// Show any holidays!
695
-							if (!empty($day['holidays']))
696
-								echo implode('<br>', $day['holidays']);
721
+							if (!empty($day['holidays'])) {
722
+															echo implode('<br>', $day['holidays']);
723
+							}
697 724
 
698 725
 							echo '</td>
699 726
 							<td class="', implode(' ', $classes), '', !empty($day['birthdays']) ? ' birthdays' : ' disabled', ' birthday_col" data-css-prefix="' . $txt['birthdays'] . ' ">';
@@ -751,8 +778,7 @@  discard block
 block discarded – undo
751 778
 				<input type="text" name="end_date" id="end_date" maxlength="10" value="', $calendar_data['end_date'], '" tabindex="', $context['tabindex']++, '" class="date_input end" data-type="date">
752 779
 				<input type="submit" class="button" style="float:none" id="view_button" value="', $txt['view'], '">
753 780
 			</form>';
754
-	}
755
-	else
781
+	} else
756 782
 	{
757 783
 		echo'
758 784
 			<form action="', $scripturl, '?action=calendar" id="calendar_navigation" method="post" accept-charset="', $context['character_set'], '">
@@ -794,8 +820,9 @@  discard block
 block discarded – undo
794 820
 	echo '
795 821
 		<form action="', $scripturl, '?action=calendar;sa=post" method="post" name="postevent" accept-charset="', $context['character_set'], '" onsubmit="submitonce(this);smc_saveEntities(\'postevent\', [\'evtitle\']);" style="margin: 0;">';
796 822
 
797
-	if (!empty($context['event']['new']))
798
-		echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">';
823
+	if (!empty($context['event']['new'])) {
824
+			echo '<input type="hidden" name="eventid" value="', $context['event']['eventid'], '">';
825
+	}
799 826
 
800 827
 	// Start the main table.
801 828
 	echo '
@@ -845,9 +872,10 @@  discard block
 block discarded – undo
845 872
 		{
846 873
 			echo '
847 874
 								<optgroup label="', $category['name'], '">';
848
-			foreach ($category['boards'] as $board)
849
-				echo '
875
+			foreach ($category['boards'] as $board) {
876
+							echo '
850 877
 									<option value="', $board['id'], '"', $board['selected'] ? ' selected' : '', '>', $board['child_level'] > 0 ? str_repeat('==', $board['child_level'] - 1) . '=&gt;' : '', ' ', $board['name'], '&nbsp;</option>';
878
+			}
851 879
 			echo '
852 880
 								</optgroup>';
853 881
 		}
@@ -883,9 +911,10 @@  discard block
 block discarded – undo
883 911
 							<span class="label">', $txt['calendar_timezone'], '</span>
884 912
 							<select name="tz" id="tz"', !empty($context['event']['allday']) ? ' disabled' : '', '>';
885 913
 
886
-	foreach ($context['all_timezones'] as $tz => $tzname)
887
-		echo '
914
+	foreach ($context['all_timezones'] as $tz => $tzname) {
915
+			echo '
888 916
 								<option value="', $tz, '"', $tz == $context['event']['tz'] ? ' selected' : '', '>', $tzname, '</option>';
917
+	}
889 918
 
890 919
 	echo '
891 920
 							</select>
@@ -900,9 +929,10 @@  discard block
 block discarded – undo
900 929
 	echo '
901 930
 				<input type="submit" value="', empty($context['event']['new']) ? $txt['save'] : $txt['post'], '" class="button">';
902 931
 	// Delete button?
903
-	if (empty($context['event']['new']))
904
-		echo '
932
+	if (empty($context['event']['new'])) {
933
+			echo '
905 934
 				<input type="submit" name="deleteevent" value="', $txt['event_delete'], '" data-confirm="', $txt['calendar_confirm_delete'], '" class="button you_sure">';
935
+	}
906 936
 
907 937
 	echo '
908 938
 				<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
@@ -946,9 +976,10 @@  discard block
 block discarded – undo
946 976
 
947 977
 		foreach ($context['clockicons'] as $t => $v)
948 978
 		{
949
-			foreach ($v as $i)
950
-				echo '
979
+			foreach ($v as $i) {
980
+							echo '
951 981
 			icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
982
+			}
952 983
 		}
953 984
 
954 985
 		echo '
@@ -973,13 +1004,14 @@  discard block
 block discarded – undo
973 1004
 
974 1005
 		foreach ($context['clockicons'] as $t => $v)
975 1006
 		{
976
-			foreach ($v as $i)
977
-				echo '
1007
+			foreach ($v as $i) {
1008
+							echo '
978 1009
 			if (', $t, ' >= ', $i, ')
979 1010
 			{
980 1011
 				turnon.push("', $t, '_', $i, '");
981 1012
 				', $t, ' -= ', $i, ';
982 1013
 			}';
1014
+			}
983 1015
 		}
984 1016
 
985 1017
 		echo '
@@ -1043,9 +1075,10 @@  discard block
 block discarded – undo
1043 1075
 
1044 1076
 	foreach ($context['clockicons'] as $t => $v)
1045 1077
 	{
1046
-		foreach ($v as $i)
1047
-			echo '
1078
+		foreach ($v as $i) {
1079
+					echo '
1048 1080
 		icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
1081
+		}
1049 1082
 	}
1050 1083
 
1051 1084
 	echo '
@@ -1062,13 +1095,14 @@  discard block
 block discarded – undo
1062 1095
 
1063 1096
 	foreach ($context['clockicons'] as $t => $v)
1064 1097
 	{
1065
-		foreach ($v as $i)
1066
-			echo '
1098
+		foreach ($v as $i) {
1099
+					echo '
1067 1100
 		if (', $t, ' >= ', $i, ')
1068 1101
 		{
1069 1102
 			turnon.push("', $t, '_', $i, '");
1070 1103
 			', $t, ' -= ', $i, ';
1071 1104
 		}';
1105
+		}
1072 1106
 	}
1073 1107
 
1074 1108
 	echo '
@@ -1127,9 +1161,10 @@  discard block
 block discarded – undo
1127 1161
 
1128 1162
 	foreach ($context['clockicons'] as $t => $v)
1129 1163
 	{
1130
-		foreach ($v as $i)
1131
-			echo '
1164
+		foreach ($v as $i) {
1165
+					echo '
1132 1166
 		icons[\'', $t, '_', $i, '\'] = document.getElementById(\'', $t, '_', $i, '\');';
1167
+		}
1133 1168
 	}
1134 1169
 
1135 1170
 	echo '
@@ -1150,13 +1185,14 @@  discard block
 block discarded – undo
1150 1185
 
1151 1186
 	foreach ($context['clockicons'] as $t => $v)
1152 1187
 	{
1153
-		foreach ($v as $i)
1154
-		echo '
1188
+		foreach ($v as $i) {
1189
+				echo '
1155 1190
 		if (', $t, ' >= ', $i, ')
1156 1191
 		{
1157 1192
 			turnon.push("', $t, '_', $i, '");
1158 1193
 			', $t, ' -= ', $i, ';
1159 1194
 		}';
1195
+		}
1160 1196
 	}
1161 1197
 
1162 1198
 	echo '
Please login to merge, or discard this patch.
Themes/default/Display.template.php 1 patch
Braces   +221 added lines, -151 removed lines patch added patch discarded remove patch
@@ -51,11 +51,13 @@  discard block
 block discarded – undo
51 51
 				<p>';
52 52
 
53 53
 		// Show just numbers...?
54
-		if ($settings['display_who_viewing'] == 1)
55
-				echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members'];
54
+		if ($settings['display_who_viewing'] == 1) {
55
+						echo count($context['view_members']), ' ', count($context['view_members']) == 1 ? $txt['who_member'] : $txt['members'];
56
+		}
56 57
 		// Or show the actual people viewing the topic?
57
-		else
58
-			echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')');
58
+		else {
59
+					echo empty($context['view_members_list']) ? '0 ' . $txt['members'] : implode(', ', $context['view_members_list']) . ((empty($context['view_num_hidden']) || $context['can_moderate_forum']) ? '' : ' (+ ' . $context['view_num_hidden'] . ' ' . $txt['hidden'] . ')');
60
+		}
59 61
 
60 62
 		// Now show how many guests are here too.
61 63
 		echo $txt['who_and'], $context['view_num_guests'], ' ', $context['view_num_guests'] == 1 ? $txt['guest'] : $txt['guests'], $txt['who_viewing_topic'], '
@@ -93,10 +95,11 @@  discard block
 block discarded – undo
93 95
 						<dt class="', $option['voted_this'] ? ' voted' : '', '">', $option['option'], '</dt>
94 96
 						<dd class="statsbar', $option['voted_this'] ? ' voted' : '', '">';
95 97
 
96
-				if ($context['allow_results_view'])
97
-					echo '
98
+				if ($context['allow_results_view']) {
99
+									echo '
98 100
 							', $option['bar_ndt'], '
99 101
 							<span class="percentage">', $option['votes'], ' (', $option['percent'], '%)</span>';
102
+				}
100 103
 
101 104
 				echo '
102 105
 						</dd>';
@@ -105,9 +108,10 @@  discard block
 block discarded – undo
105 108
 			echo '
106 109
 					</dl>';
107 110
 
108
-			if ($context['allow_results_view'])
109
-				echo '
111
+			if ($context['allow_results_view']) {
112
+							echo '
110 113
 						<p><strong>', $txt['poll_total_voters'], ':</strong> ', $context['poll']['total_votes'], '</p>';
114
+			}
111 115
 		}
112 116
 		// They are allowed to vote! Go to it!
113 117
 		else
@@ -116,17 +120,19 @@  discard block
 block discarded – undo
116 120
 						<form action="', $scripturl, '?action=vote;topic=', $context['current_topic'], '.', $context['start'], ';poll=', $context['poll']['id'], '" method="post" accept-charset="', $context['character_set'], '">';
117 121
 
118 122
 			// Show a warning if they are allowed more than one option.
119
-			if ($context['poll']['allowed_warning'])
120
-				echo '
123
+			if ($context['poll']['allowed_warning']) {
124
+							echo '
121 125
 							<p class="smallpadding">', $context['poll']['allowed_warning'], '</p>';
126
+			}
122 127
 
123 128
 			echo '
124 129
 							<ul class="options">';
125 130
 
126 131
 			// Show each option with its button - a radio likely.
127
-			foreach ($context['poll']['options'] as $option)
128
-				echo '
132
+			foreach ($context['poll']['options'] as $option) {
133
+							echo '
129 134
 								<li>', $option['vote_button'], ' <label for="', $option['id'], '">', $option['option'], '</label></li>';
135
+			}
130 136
 
131 137
 			echo '
132 138
 							</ul>
@@ -138,9 +144,10 @@  discard block
 block discarded – undo
138 144
 		}
139 145
 
140 146
 		// Is the clock ticking?
141
-		if (!empty($context['poll']['expire_time']))
142
-			echo '
147
+		if (!empty($context['poll']['expire_time'])) {
148
+					echo '
143 149
 						<p><strong>', ($context['poll']['is_expired'] ? $txt['poll_expired_on'] : $txt['poll_expires_on']), ':</strong> ', $context['poll']['expire_time'], '</p>';
150
+		}
144 151
 
145 152
 		echo '
146 153
 					</div>
@@ -170,11 +177,13 @@  discard block
 block discarded – undo
170 177
 					<li>
171 178
 						<strong class="event_title"><a href="', $scripturl, '?action=calendar;event=', $event['id'], '">', $event['title'], '</a></strong>';
172 179
 
173
-			if ($event['can_edit'])
174
-				echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>';
180
+			if ($event['can_edit']) {
181
+							echo ' <a href="' . $event['modify_href'] . '"><span class="generic_icons calendar_modify" title="', $txt['calendar_edit'], '"></span></a>';
182
+			}
175 183
 
176
-			if ($event['can_export'])
177
-				echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>';
184
+			if ($event['can_export']) {
185
+							echo ' <a href="' . $event['export_href'] . '"><span class="generic_icons calendar_export" title="', $txt['calendar_export'], '"></span></a>';
186
+			}
178 187
 
179 188
 			echo '
180 189
 						<br>';
@@ -182,14 +191,14 @@  discard block
 block discarded – undo
182 191
 			if (!empty($event['allday']))
183 192
 			{
184 193
 				echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), '</time>', ($event['start_date'] != $event['end_date']) ? ' &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">' . trim($event['end_date_local']) . '</time>' : '';
185
-			}
186
-			else
194
+			} else
187 195
 			{
188 196
 				// Display event info relative to user's local timezone
189 197
 				echo '<time datetime="' . $event['start_iso_gmdate'] . '">', trim($event['start_date_local']), ', ', trim($event['start_time_local']), '</time> &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">';
190 198
 
191
-				if ($event['start_date_local'] != $event['end_date_local'])
192
-					echo trim($event['end_date_local']) . ', ';
199
+				if ($event['start_date_local'] != $event['end_date_local']) {
200
+									echo trim($event['end_date_local']) . ', ';
201
+				}
193 202
 
194 203
 				echo trim($event['end_time_local']);
195 204
 
@@ -198,23 +207,27 @@  discard block
 block discarded – undo
198 207
 				{
199 208
 					echo '</time> (<time datetime="' . $event['start_iso_gmdate'] . '">';
200 209
 
201
-					if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig'])
202
-						echo trim($event['start_date_orig']), ', ';
210
+					if ($event['start_date_orig'] != $event['start_date_local'] || $event['end_date_orig'] != $event['end_date_local'] || $event['start_date_orig'] != $event['end_date_orig']) {
211
+											echo trim($event['start_date_orig']), ', ';
212
+					}
203 213
 
204 214
 					echo trim($event['start_time_orig']), '</time> &ndash; <time datetime="' . $event['end_iso_gmdate'] . '">';
205 215
 
206
-					if ($event['start_date_orig'] != $event['end_date_orig'])
207
-						echo trim($event['end_date_orig']) . ', ';
216
+					if ($event['start_date_orig'] != $event['end_date_orig']) {
217
+											echo trim($event['end_date_orig']) . ', ';
218
+					}
208 219
 
209 220
 					echo trim($event['end_time_orig']), ' ', $event['tz_abbrev'], '</time>)';
210 221
 				}
211 222
 				// Event is scheduled in the user's own timezone? Let 'em know, just to avoid confusion
212
-				else
213
-					echo ' ', $event['tz_abbrev'], '</time>';
223
+				else {
224
+									echo ' ', $event['tz_abbrev'], '</time>';
225
+				}
214 226
 			}
215 227
 
216
-			if (!empty($event['location']))
217
-				echo '<br>', $event['location'];
228
+			if (!empty($event['location'])) {
229
+							echo '<br>', $event['location'];
230
+			}
218 231
 
219 232
 			echo '
220 233
 					</li>';
@@ -253,8 +266,9 @@  discard block
 block discarded – undo
253 266
 	$context['removableMessageIDs'] = array();
254 267
 
255 268
 	// Get all the messages...
256
-	while ($message = $context['get_message']())
257
-		template_single_post($message);
269
+	while ($message = $context['get_message']()) {
270
+			template_single_post($message);
271
+	}
258 272
 
259 273
 	echo '
260 274
 				</form>
@@ -292,8 +306,9 @@  discard block
 block discarded – undo
292 306
 			<div id="display_jump_to">&nbsp;</div>';
293 307
 
294 308
 	// Show quickreply
295
-	if ($context['can_reply'])
296
-	template_quickreply();
309
+	if ($context['can_reply']) {
310
+		template_quickreply();
311
+	}
297 312
 
298 313
 	// User action pop on mobile screen (or actually small screen), this uses responsive css does not check mobile device.
299 314
 	echo '
@@ -306,8 +321,8 @@  discard block
 block discarded – undo
306 321
 			</div>';
307 322
 
308 323
 	// Show the moderation button & pop only if user can moderate
309
-	if ($context['can_moderate_forum'] || $context['user']['is_mod'])
310
-		echo '
324
+	if ($context['can_moderate_forum'] || $context['user']['is_mod']) {
325
+			echo '
311 326
 			<div id="mobile_moderation" class="popup_container">
312 327
 				<div class="popup_window description">
313 328
 					<div class="popup_heading">', $txt['mobile_moderation'], '
@@ -317,6 +332,7 @@  discard block
 block discarded – undo
317 332
 					</div>
318 333
 				</div>
319 334
 			</div>';
335
+	}
320 336
 
321 337
 		echo '
322 338
 				<script>';
@@ -440,9 +456,10 @@  discard block
 block discarded – undo
440 456
 						});
441 457
 					}';
442 458
 
443
-	if (!empty($context['ignoredMsgs']))
444
-		echo '
459
+	if (!empty($context['ignoredMsgs'])) {
460
+			echo '
445 461
 					ignore_toggles([', implode(', ', $context['ignoredMsgs']), '], ', JavaScriptEscape($txt['show_ignore_user_post']), ');';
462
+	}
446 463
 
447 464
 	echo '
448 465
 				</script>';
@@ -459,8 +476,9 @@  discard block
 block discarded – undo
459 476
 
460 477
 	$ignoring = false;
461 478
 
462
-	if ($message['can_remove'])
463
-		$context['removableMessageIDs'][] = $message['id'];
479
+	if ($message['can_remove']) {
480
+			$context['removableMessageIDs'][] = $message['id'];
481
+	}
464 482
 
465 483
 	// Are we ignoring this message?
466 484
 	if (!empty($message['is_ignored']))
@@ -486,9 +504,10 @@  discard block
 block discarded – undo
486 504
 							<div class="custom_fields_above_member">
487 505
 								<ul class="nolist">';
488 506
 
489
-		foreach ($message['custom_fields']['above_member'] as $custom)
490
-			echo '
507
+		foreach ($message['custom_fields']['above_member'] as $custom) {
508
+					echo '
491 509
 									<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
510
+		}
492 511
 
493 512
 		echo '
494 513
 								</ul>
@@ -499,9 +518,10 @@  discard block
 block discarded – undo
499 518
 									<h4>';
500 519
 
501 520
 	// Show online and offline buttons?
502
-	if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest'])
503
-		echo '
521
+	if (!empty($modSettings['onlineEnable']) && !$message['member']['is_guest']) {
522
+			echo '
504 523
 								', $context['can_send_pm'] ? '<a href="' . $message['member']['online']['href'] . '" title="' . $message['member']['online']['label'] . '">' : '', '<span class="' . ($message['member']['online']['is_online'] == 1 ? 'on' : 'off') . '" title="' . $message['member']['online']['text'] . '"></span>', $context['can_send_pm'] ? '</a>' : '';
524
+	}
505 525
 
506 526
 
507 527
 	// Show a link to the member's profile.
@@ -514,51 +534,59 @@  discard block
 block discarded – undo
514 534
 
515 535
 
516 536
 	// Show the user's avatar.
517
-	if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image']))
518
-		echo '
537
+	if (!empty($modSettings['show_user_images']) && empty($options['show_no_avatars']) && !empty($message['member']['avatar']['image'])) {
538
+			echo '
519 539
 								<li class="avatar">
520 540
 									<a href="', $message['member']['href'], '">', $message['member']['avatar']['image'], '</a>
521 541
 								</li>';
542
+	}
522 543
 
523 544
 	// Are there any custom fields below the avatar?
524
-	if (!empty($message['custom_fields']['below_avatar']))
525
-		foreach ($message['custom_fields']['below_avatar'] as $custom)
545
+	if (!empty($message['custom_fields']['below_avatar'])) {
546
+			foreach ($message['custom_fields']['below_avatar'] as $custom)
526 547
 			echo '
527 548
 								<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
549
+	}
528 550
 
529 551
 	// Show the post group icons, but not for guests.
530
-	if (!$message['member']['is_guest'])
531
-		echo '
552
+	if (!$message['member']['is_guest']) {
553
+			echo '
532 554
 								<li class="icons">', $message['member']['group_icons'], '</li>';
555
+	}
533 556
 
534 557
 	// Show the member's primary group (like 'Administrator') if they have one.
535
-	if (!empty($message['member']['group']))
536
-		echo '
558
+	if (!empty($message['member']['group'])) {
559
+			echo '
537 560
 								<li class="membergroup">', $message['member']['group'], '</li>';
561
+	}
538 562
 
539 563
 	// Show the member's custom title, if they have one.
540
-	if (!empty($message['member']['title']))
541
-		echo '
564
+	if (!empty($message['member']['title'])) {
565
+			echo '
542 566
 								<li class="title">', $message['member']['title'], '</li>';
567
+	}
543 568
 
544 569
 	// Don't show these things for guests.
545 570
 	if (!$message['member']['is_guest'])
546 571
 	{
547 572
 
548 573
 		// Show the post group if and only if they have no other group or the option is on, and they are in a post group.
549
-		if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group']))
550
-			echo '
574
+		if ((empty($modSettings['hide_post_group']) || empty($message['member']['group'])) && !empty($message['member']['post_group'])) {
575
+					echo '
551 576
 								<li class="postgroup">', $message['member']['post_group'], '</li>';
577
+		}
552 578
 
553 579
 		// Show how many posts they have made.
554
-		if (!isset($context['disabled_fields']['posts']))
555
-			echo '
580
+		if (!isset($context['disabled_fields']['posts'])) {
581
+					echo '
556 582
 								<li class="postcount">', $txt['member_postcount'], ': ', $message['member']['posts'], '</li>';
583
+		}
557 584
 
558 585
 		// Show their personal text?
559
-		if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb']))
560
-			echo '
586
+		if (!empty($modSettings['show_blurb']) && !empty($message['member']['blurb'])) {
587
+					echo '
561 588
 								<li class="blurb">', $message['member']['blurb'], '</li>';
589
+		}
562 590
 
563 591
 		// Any custom fields to show as icons?
564 592
 		if (!empty($message['custom_fields']['icons']))
@@ -567,9 +595,10 @@  discard block
 block discarded – undo
567 595
 								<li class="im_icons">
568 596
 									<ol>';
569 597
 
570
-			foreach ($message['custom_fields']['icons'] as $custom)
571
-				echo '
598
+			foreach ($message['custom_fields']['icons'] as $custom) {
599
+							echo '
572 600
 										<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
601
+			}
573 602
 
574 603
 			echo '
575 604
 									</ol>
@@ -584,19 +613,22 @@  discard block
 block discarded – undo
584 613
 									<ol class="profile_icons">';
585 614
 
586 615
 			// Don't show an icon if they haven't specified a website.
587
-			if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website']))
588
-				echo '
616
+			if (!empty($message['member']['website']['url']) && !isset($context['disabled_fields']['website'])) {
617
+							echo '
589 618
 										<li><a href="', $message['member']['website']['url'], '" title="' . $message['member']['website']['title'] . '" target="_blank">', ($settings['use_image_buttons'] ? '<span class="generic_icons www centericon" title="' . $message['member']['website']['title'] . '"></span>' : $txt['www']), '</a></li>';
619
+			}
590 620
 
591 621
 			// Since we know this person isn't a guest, you *can* message them.
592
-			if ($context['can_send_pm'])
593
-				echo '
622
+			if ($context['can_send_pm']) {
623
+							echo '
594 624
 										<li><a href="', $scripturl, '?action=pm;sa=send;u=', $message['member']['id'], '" title="', $message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline'], '">', $settings['use_image_buttons'] ? '<span class="generic_icons im_' . ($message['member']['online']['is_online'] ? 'on' : 'off') . ' centericon" title="' . ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']) . '"></span> ' : ($message['member']['online']['is_online'] ? $txt['pm_online'] : $txt['pm_offline']), '</a></li>';
625
+			}
595 626
 
596 627
 			// Show the email if necessary
597
-			if (!empty($message['member']['email']) && $message['member']['show_email'])
598
-				echo '
628
+			if (!empty($message['member']['email']) && $message['member']['show_email']) {
629
+							echo '
599 630
 										<li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>';
631
+			}
600 632
 
601 633
 				echo '
602 634
 									</ol>
@@ -604,48 +636,56 @@  discard block
 block discarded – undo
604 636
 		}
605 637
 
606 638
 		// Any custom fields for standard placement?
607
-		if (!empty($message['custom_fields']['standard']))
608
-			foreach ($message['custom_fields']['standard'] as $custom)
639
+		if (!empty($message['custom_fields']['standard'])) {
640
+					foreach ($message['custom_fields']['standard'] as $custom)
609 641
 				echo '
610 642
 								<li class="custom ', $custom['col_name'], '">', $custom['title'], ': ', $custom['value'], '</li>';
643
+		}
611 644
 
612 645
 	}
613 646
 	// Otherwise, show the guest's email.
614
-	elseif (!empty($message['member']['email']) && $message['member']['show_email'])
615
-		echo '
647
+	elseif (!empty($message['member']['email']) && $message['member']['show_email']) {
648
+			echo '
616 649
 								<li class="email"><a href="mailto:' . $message['member']['email'] . '" rel="nofollow">', ($settings['use_image_buttons'] ? '<span class="generic_icons mail centericon" title="' . $txt['email'] . '"></span>' : $txt['email']), '</a></li>';
650
+	}
617 651
 
618 652
 	// Show the IP to this user for this post - because you can moderate?
619
-	if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip']))
620
-		echo '
653
+	if (!empty($context['can_moderate_forum']) && !empty($message['member']['ip'])) {
654
+			echo '
621 655
 								<li class="poster_ip"><a href="', $scripturl, '?action=', !empty($message['member']['is_guest']) ? 'trackip' : 'profile;area=tracking;sa=ip;u=' . $message['member']['id'], ';searchip=', $message['member']['ip'], '">', $message['member']['ip'], '</a> <a href="', $scripturl, '?action=helpadmin;help=see_admin_ip" onclick="return reqOverlayDiv(this.href);" class="help">(?)</a></li>';
656
+	}
622 657
 
623 658
 	// Or, should we show it because this is you?
624
-	elseif ($message['can_see_ip'])
625
-		echo '
659
+	elseif ($message['can_see_ip']) {
660
+			echo '
626 661
 								<li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $message['member']['ip'], '</a></li>';
662
+	}
627 663
 
628 664
 	// Okay, are you at least logged in? Then we can show something about why IPs are logged...
629
-	elseif (!$context['user']['is_guest'])
630
-		echo '
665
+	elseif (!$context['user']['is_guest']) {
666
+			echo '
631 667
 								<li class="poster_ip"><a href="', $scripturl, '?action=helpadmin;help=see_member_ip" onclick="return reqOverlayDiv(this.href);" class="help">', $txt['logged'], '</a></li>';
668
+	}
632 669
 
633 670
 	// Otherwise, you see NOTHING!
634
-	else
635
-		echo '
671
+	else {
672
+			echo '
636 673
 								<li class="poster_ip">', $txt['logged'], '</li>';
674
+	}
637 675
 
638 676
 	// Are we showing the warning status?
639 677
 	// Don't show these things for guests.
640
-	if (!$message['member']['is_guest'] && $message['member']['can_see_warning'])
641
-		echo '
678
+	if (!$message['member']['is_guest'] && $message['member']['can_see_warning']) {
679
+			echo '
642 680
 								<li class="warning">', $context['can_issue_warning'] ? '<a href="' . $scripturl . '?action=profile;area=issuewarning;u=' . $message['member']['id'] . '">' : '', '<span class="generic_icons warning_', $message['member']['warning_status'], '"></span> ', $context['can_issue_warning'] ? '</a>' : '', '<span class="warn_', $message['member']['warning_status'], '">', $txt['warn_' . $message['member']['warning_status']], '</span></li>';
681
+	}
643 682
 
644 683
 	// Are there any custom fields to show at the bottom of the poster info?
645
-	if (!empty($message['custom_fields']['bottom_poster']))
646
-		foreach ($message['custom_fields']['bottom_poster'] as $custom)
684
+	if (!empty($message['custom_fields']['bottom_poster'])) {
685
+			foreach ($message['custom_fields']['bottom_poster'] as $custom)
647 686
 			echo '
648 687
 									<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
688
+	}
649 689
 
650 690
 	// Poster info ends.
651 691
 	echo '
@@ -674,9 +714,10 @@  discard block
 block discarded – undo
674 714
 	echo '
675 715
 									<span class="smalltext modified floatright', !empty($modSettings['show_modify']) && !empty($message['modified']['name']) ? ' mvisible' : '','" id="modified_', $message['id'], '">';
676 716
 
677
-	if (!empty($modSettings['show_modify']) && !empty($message['modified']['name']))
678
-		echo
717
+	if (!empty($modSettings['show_modify']) && !empty($message['modified']['name'])) {
718
+			echo
679 719
 										$message['modified']['last_edit_text'];
720
+	}
680 721
 
681 722
 	echo '
682 723
 									</span>
@@ -685,22 +726,24 @@  discard block
 block discarded – undo
685 726
 							</div>';
686 727
 
687 728
 	// Ignoring this user? Hide the post.
688
-	if ($ignoring)
689
-		echo '
729
+	if ($ignoring) {
730
+			echo '
690 731
 							<div id="msg_', $message['id'], '_ignored_prompt">
691 732
 								', $txt['ignoring_user'], '
692 733
 								<a href="#" id="msg_', $message['id'], '_ignored_link" style="display: none;">', $txt['show_ignore_user_post'], '</a>
693 734
 							</div>';
735
+	}
694 736
 
695 737
 	// Show the post itself, finally!
696 738
 	echo '
697 739
 							<div class="post">';
698 740
 
699
-	if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id'])
700
-		echo '
741
+	if (!$message['approved'] && $message['member']['id'] != 0 && $message['member']['id'] == $context['user']['id']) {
742
+			echo '
701 743
 								<div class="approve_post">
702 744
 									', $txt['post_awaiting_approval'], '
703 745
 								</div>';
746
+	}
704 747
 	echo '
705 748
 								<div class="inner" data-msgid="', $message['id'], '" id="msg_', $message['id'], '"', $ignoring ? ' style="display:none;"' : '', '>', $message['body'], '</div>
706 749
 							</div>';
@@ -717,9 +760,9 @@  discard block
 block discarded – undo
717 760
 		foreach ($message['attachment'] as $attachment)
718 761
 		{
719 762
 			// Do we want this attachment to not be showed here?
720
-			if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']]))
721
-				continue;
722
-			elseif (!$div_output)
763
+			if (!empty($modSettings['dont_show_attach_under_post']) && !empty($context['show_attach_under_post'][$attachment['id']])) {
764
+							continue;
765
+			} elseif (!$div_output)
723 766
 			{
724 767
 				$div_output = true;
725 768
 
@@ -735,9 +778,10 @@  discard block
 block discarded – undo
735 778
 								<fieldset>
736 779
 									<legend>', $txt['attach_awaiting_approve'];
737 780
 
738
-				if ($context['can_approve'])
739
-					echo '
781
+				if ($context['can_approve']) {
782
+									echo '
740 783
 										&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]';
784
+				}
741 785
 
742 786
 				echo '
743 787
 									</legend>';
@@ -751,12 +795,13 @@  discard block
 block discarded – undo
751 795
 				echo '
752 796
 										<div class="attachments_top">';
753 797
 
754
-				if ($attachment['thumbnail']['has_thumb'])
755
-					echo '
798
+				if ($attachment['thumbnail']['has_thumb']) {
799
+									echo '
756 800
 											<a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" class="atc_img"></a>';
757
-				else
758
-					echo '
801
+				} else {
802
+									echo '
759 803
 											<img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" class="atc_img">';
804
+				}
760 805
 
761 806
 				echo '
762 807
 										</div>';
@@ -766,9 +811,10 @@  discard block
 block discarded – undo
766 811
 										<div class="attachments_bot">
767 812
 											<a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.png" class="centericon" alt="*">&nbsp;' . $attachment['name'] . '</a> ';
768 813
 
769
-			if (!$attachment['is_approved'] && $context['can_approve'])
770
-				echo '
814
+			if (!$attachment['is_approved'] && $context['can_approve']) {
815
+							echo '
771 816
 											[<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>]&nbsp;|&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] ';
817
+			}
772 818
 			echo '
773 819
 											<br>', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . '<br>' . sprintf($txt['attach_viewed'], $attachment['downloads']) : '<br>' . sprintf($txt['attach_downloaded'], $attachment['downloads'])), '
774 820
 										</div>';
@@ -777,33 +823,38 @@  discard block
 block discarded – undo
777 823
 									</div>';
778 824
 
779 825
 			// Next attachment line ?
780
-			if (++$i % $attachments_per_line === 0)
781
-				echo '
826
+			if (++$i % $attachments_per_line === 0) {
827
+							echo '
782 828
 									<br>';
829
+			}
783 830
 		}
784 831
 
785 832
 		// If we had unapproved attachments clean up.
786
-		if ($last_approved_state == 0)
787
-			echo '
833
+		if ($last_approved_state == 0) {
834
+					echo '
788 835
 								</fieldset>';
836
+		}
789 837
 
790 838
 		// Only do this if we output a div above - otherwise it'll break things
791
-		if ($div_output)
792
-			echo '
839
+		if ($div_output) {
840
+					echo '
793 841
 							</div>';
842
+		}
794 843
 	}
795 844
 
796 845
 	// And stuff below the attachments.
797
-	if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote'])
798
-	echo '
846
+	if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) {
847
+		echo '
799 848
 							<div class="under_message">';
849
+	}
800 850
 
801 851
 	// Maybe they want to report this post to the moderator(s)?
802
-	if ($context['can_report_moderator'])
803
-		echo '
852
+	if ($context['can_report_moderator']) {
853
+			echo '
804 854
 								<ul class="floatright smalltext">
805 855
 									<li class="report_link"><a href="', $scripturl, '?action=reporttm;topic=', $context['current_topic'], '.', $message['counter'], ';msg=', $message['id'], '">', $txt['report_to_mod'], '</a></li>
806 856
 								</ul>';
857
+	}
807 858
 
808 859
 	// What about likes?
809 860
 	if (!empty($modSettings['enable_likes']))
@@ -844,78 +895,91 @@  discard block
 block discarded – undo
844 895
 								<ul class="quickbuttons">';
845 896
 
846 897
 		// Can they quote? if so they can select and quote as well!
847
-		if ($context['can_quote'])
848
-			echo '
898
+		if ($context['can_quote']) {
899
+					echo '
849 900
 									<li><a href="', $scripturl, '?action=post;quote=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], ';last_msg=', $context['topic_last_message'], '" onclick="return oQuickReply.quote(', $message['id'], ');"><span class="generic_icons quote"></span>', $txt['quote_action'], '</a></li>
850 901
 									<li style="display:none;" id="quoteSelected_', $message['id'], '"><a href="javascript:void(0)"><span class="generic_icons quote_selected"></span>', $txt['quote_selected_action'], '</a></li>';
902
+		}
851 903
 
852 904
 		// Can the user modify the contents of this post? Show the modify inline image.
853
-		if ($message['can_modify'])
854
-			echo '
905
+		if ($message['can_modify']) {
906
+					echo '
855 907
 									<li class="quick_edit"><a title="', $txt['modify_msg'], '" class="modifybutton" id="modify_button_', $message['id'], '" onclick="oQuickModify.modifyMsg(\'', $message['id'], '\', \'', !empty($modSettings['toggle_subject']), '\')"><span class="generic_icons quick_edit_button"></span>', $txt['quick_edit'], '</a></li>';
908
+		}
856 909
 
857
-		if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'])
858
-			echo '
910
+		if ($message['can_approve'] || $message['can_unapprove'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) {
911
+					echo '
859 912
 									<li class="post_options">', $txt['post_options'];
913
+		}
860 914
 
861 915
 		echo '
862 916
 										<ul>';
863 917
 
864 918
 		// Can the user modify the contents of this post?
865
-		if ($message['can_modify'])
866
-			echo '
919
+		if ($message['can_modify']) {
920
+					echo '
867 921
 											<li><a href="', $scripturl, '?action=post;msg=', $message['id'], ';topic=', $context['current_topic'], '.', $context['start'], '"><span class="generic_icons modify_button"></span>', $txt['modify'], '</a></li>';
922
+		}
868 923
 
869 924
 		// How about... even... remove it entirely?!
870
-		if ($context['can_delete'] && ($context['topic_first_message'] == $message['id']))
871
-			echo '
925
+		if ($context['can_delete'] && ($context['topic_first_message'] == $message['id'])) {
926
+					echo '
872 927
 											<li><a href="', $scripturl, '?action=removetopic2;topic=', $context['current_topic'], '.', $context['start'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['are_sure_remove_topic'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove_topic'], '</a></li>';
873
-		elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id']))
874
-			echo '
928
+		} elseif ($message['can_remove'] && ($context['topic_first_message'] != $message['id'])) {
929
+					echo '
875 930
 											<li><a href="', $scripturl, '?action=deletemsg;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '" data-confirm="', $txt['remove_message_question'], '" class="you_sure"><span class="generic_icons remove_button"></span>', $txt['remove'], '</a></li>';
931
+		}
876 932
 
877 933
 		// What about splitting it off the rest of the topic?
878
-		if ($context['can_split'] && !empty($context['real_num_replies']))
879
-			echo '
934
+		if ($context['can_split'] && !empty($context['real_num_replies'])) {
935
+					echo '
880 936
 											<li><a href="', $scripturl, '?action=splittopics;topic=', $context['current_topic'], '.0;at=', $message['id'], '"><span class="generic_icons split_button"></span>', $txt['split'], '</a></li>';
937
+		}
881 938
 
882 939
 		// Can we issue a warning because of this post? Remember, we can't give guests warnings.
883
-		if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest'])
884
-			echo '
940
+		if ($context['can_issue_warning'] && !$message['is_message_author'] && !$message['member']['is_guest']) {
941
+					echo '
885 942
 											<li><a href="', $scripturl, '?action=profile;area=issuewarning;u=', $message['member']['id'], ';msg=', $message['id'], '"><span class="generic_icons warn_button"></span>', $txt['issue_warning'], '</a></li>';
943
+		}
886 944
 
887 945
 		// Can we restore topics?
888
-		if ($context['can_restore_msg'])
889
-			echo '
946
+		if ($context['can_restore_msg']) {
947
+					echo '
890 948
 											<li><a href="', $scripturl, '?action=restoretopic;msgs=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons restore_button"></span>', $txt['restore_message'], '</a></li>';
949
+		}
891 950
 
892 951
 		// Maybe we can approve it, maybe we should?
893
-		if ($message['can_approve'])
894
-			echo '
952
+		if ($message['can_approve']) {
953
+					echo '
895 954
 											<li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons approve_button"></span>', $txt['approve'], '</a></li>';
955
+		}
896 956
 
897 957
 		// Maybe we can unapprove it?
898
-		if ($message['can_unapprove'])
899
-			echo '
958
+		if ($message['can_unapprove']) {
959
+					echo '
900 960
 											<li><a href="', $scripturl, '?action=moderate;area=postmod;sa=approve;topic=', $context['current_topic'], '.', $context['start'], ';msg=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '"><span class="generic_icons unapprove_button"></span>', $txt['unapprove'], '</a></li>';
961
+		}
901 962
 
902 963
 		echo '
903 964
 										</ul>
904 965
 									</li>';
905 966
 
906 967
 		// Show a checkbox for quick moderation?
907
-		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove'])
908
-			echo '
968
+		if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $message['can_remove']) {
969
+					echo '
909 970
 									<li style="display: none;" id="in_topic_mod_check_', $message['id'], '"></li>';
971
+		}
910 972
 
911
-		if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'])
912
-			echo '
973
+		if ($message['can_approve'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg']) {
974
+					echo '
913 975
 								</ul>';
976
+		}
914 977
 	}
915 978
 
916
-	if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote'])
917
-	echo '
979
+	if ($context['can_report_moderator'] || !empty($modSettings['enable_likes']) || $message['can_approve'] || $message['can_unapprove'] || $context['can_reply'] || $message['can_modify'] || $message['can_remove'] || $context['can_split'] || $context['can_restore_msg'] || $context['can_quote']) {
980
+		echo '
918 981
 							</div>';
982
+	}
919 983
 
920 984
 	echo '
921 985
 						</div>
@@ -928,9 +992,10 @@  discard block
 block discarded – undo
928 992
 							<div class="custom_fields_above_signature">
929 993
 								<ul class="nolist">';
930 994
 
931
-		foreach ($message['custom_fields']['above_signature'] as $custom)
932
-			echo '
995
+		foreach ($message['custom_fields']['above_signature'] as $custom) {
996
+					echo '
933 997
 									<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
998
+		}
934 999
 
935 1000
 		echo '
936 1001
 								</ul>
@@ -938,9 +1003,10 @@  discard block
 block discarded – undo
938 1003
 	}
939 1004
 
940 1005
 	// Show the member's signature?
941
-	if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled'])
942
-		echo '
1006
+	if (!empty($message['member']['signature']) && empty($options['show_no_signatures']) && $context['signature_enabled']) {
1007
+			echo '
943 1008
 							<div class="signature" id="msg_', $message['id'], '_signature"', $ignoring ? ' style="display:none;"' : '', '>', $message['member']['signature'], '</div>';
1009
+	}
944 1010
 
945 1011
 
946 1012
 	// Are there any custom profile fields for below the signature?
@@ -950,9 +1016,10 @@  discard block
 block discarded – undo
950 1016
 							<div class="custom_fields_below_signature">
951 1017
 								<ul class="nolist">';
952 1018
 
953
-		foreach ($message['custom_fields']['below_signature'] as $custom)
954
-			echo '
1019
+		foreach ($message['custom_fields']['below_signature'] as $custom) {
1020
+					echo '
955 1021
 									<li class="custom ', $custom['col_name'], '">', $custom['value'], '</li>';
1022
+		}
956 1023
 
957 1024
 		echo '
958 1025
 								</ul>
@@ -1000,8 +1067,8 @@  discard block
 block discarded – undo
1000 1067
 						<input type="hidden" name="seqnum" value="', $context['form_sequence_number'], '">';
1001 1068
 
1002 1069
 		// Guests just need more.
1003
-		if ($context['user']['is_guest'])
1004
-			echo '
1070
+		if ($context['user']['is_guest']) {
1071
+					echo '
1005 1072
 						<dl id="post_header">
1006 1073
 							<dt>
1007 1074
 								', $txt['name'], ':
@@ -1016,6 +1083,7 @@  discard block
 block discarded – undo
1016 1083
 								<input type="email" name="email" size="25" value="', $context['email'], '" tabindex="', $context['tabindex']++, '" required>
1017 1084
 							</dd>
1018 1085
 						</dl>';
1086
+		}
1019 1087
 
1020 1088
 		echo '
1021 1089
 						', template_control_richedit($context['post_box_name'], 'smileyBox_message', 'bbcBox_message'), '
@@ -1063,8 +1131,8 @@  discard block
 block discarded – undo
1063 1131
 		<br class="clear">';
1064 1132
 
1065 1133
 	// draft autosave available and the user has it enabled?
1066
-	if (!empty($context['drafts_autosave']))
1067
-		echo '
1134
+	if (!empty($context['drafts_autosave'])) {
1135
+			echo '
1068 1136
 			<script>
1069 1137
 				var oDraftAutoSave = new smf_DraftAutoSave({
1070 1138
 					sSelf: \'oDraftAutoSave\',
@@ -1076,10 +1144,12 @@  discard block
 block discarded – undo
1076 1144
 					iFreq: ', (empty($modSettings['masterAutoSaveDraftsDelay']) ? 60000 : $modSettings['masterAutoSaveDraftsDelay'] * 1000), '
1077 1145
 				});
1078 1146
 			</script>';
1147
+	}
1079 1148
 
1080
-	if ($context['show_spellchecking'])
1081
-		echo '
1149
+	if ($context['show_spellchecking']) {
1150
+			echo '
1082 1151
 			<form action="', $scripturl, '?action=spellcheck" method="post" accept-charset="', $context['character_set'], '" name="spell_form" id="spell_form" target="spellWindow"><input type="hidden" name="spellstring" value=""></form>';
1152
+	}
1083 1153
 
1084 1154
 	echo '
1085 1155
 				<script>
Please login to merge, or discard this patch.
Sources/Subs.php 1 patch
Braces   +1313 added lines, -975 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Update some basic statistics.
@@ -122,10 +123,11 @@  discard block
 block discarded – undo
122 123
 						$smcFunc['db_free_result']($result);
123 124
 
124 125
 						// Add this to the number of unapproved members
125
-						if (!empty($changes['unapprovedMembers']))
126
-							$changes['unapprovedMembers'] += $coppa_approvals;
127
-						else
128
-							$changes['unapprovedMembers'] = $coppa_approvals;
126
+						if (!empty($changes['unapprovedMembers'])) {
127
+													$changes['unapprovedMembers'] += $coppa_approvals;
128
+						} else {
129
+													$changes['unapprovedMembers'] = $coppa_approvals;
130
+						}
129 131
 					}
130 132
 				}
131 133
 			}
@@ -133,9 +135,9 @@  discard block
 block discarded – undo
133 135
 			break;
134 136
 
135 137
 		case 'message':
136
-			if ($parameter1 === true && $parameter2 !== null)
137
-				updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
138
-			else
138
+			if ($parameter1 === true && $parameter2 !== null) {
139
+							updateSettings(array('totalMessages' => true, 'maxMsgID' => $parameter2), true);
140
+			} else
139 141
 			{
140 142
 				// SUM and MAX on a smaller table is better for InnoDB tables.
141 143
 				$result = $smcFunc['db_query']('', '
@@ -175,23 +177,25 @@  discard block
 block discarded – undo
175 177
 				$parameter2 = text2words($parameter2);
176 178
 
177 179
 				$inserts = array();
178
-				foreach ($parameter2 as $word)
179
-					$inserts[] = array($word, $parameter1);
180
+				foreach ($parameter2 as $word) {
181
+									$inserts[] = array($word, $parameter1);
182
+				}
180 183
 
181
-				if (!empty($inserts))
182
-					$smcFunc['db_insert']('ignore',
184
+				if (!empty($inserts)) {
185
+									$smcFunc['db_insert']('ignore',
183 186
 						'{db_prefix}log_search_subjects',
184 187
 						array('word' => 'string', 'id_topic' => 'int'),
185 188
 						$inserts,
186 189
 						array('word', 'id_topic')
187 190
 					);
191
+				}
188 192
 			}
189 193
 			break;
190 194
 
191 195
 		case 'topic':
192
-			if ($parameter1 === true)
193
-				updateSettings(array('totalTopics' => true), true);
194
-			else
196
+			if ($parameter1 === true) {
197
+							updateSettings(array('totalTopics' => true), true);
198
+			} else
195 199
 			{
196 200
 				// Get the number of topics - a SUM is better for InnoDB tables.
197 201
 				// We also ignore the recycle bin here because there will probably be a bunch of one-post topics there.
@@ -212,8 +216,9 @@  discard block
 block discarded – undo
212 216
 
213 217
 		case 'postgroups':
214 218
 			// Parameter two is the updated columns: we should check to see if we base groups off any of these.
215
-			if ($parameter2 !== null && !in_array('posts', $parameter2))
216
-				return;
219
+			if ($parameter2 !== null && !in_array('posts', $parameter2)) {
220
+							return;
221
+			}
217 222
 
218 223
 			$postgroups = cache_get_data('updateStats:postgroups', 360);
219 224
 			if ($postgroups == null || $parameter1 == null)
@@ -228,8 +233,9 @@  discard block
 block discarded – undo
228 233
 					)
229 234
 				);
230 235
 				$postgroups = array();
231
-				while ($row = $smcFunc['db_fetch_assoc']($request))
232
-					$postgroups[$row['id_group']] = $row['min_posts'];
236
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
237
+									$postgroups[$row['id_group']] = $row['min_posts'];
238
+				}
233 239
 				$smcFunc['db_free_result']($request);
234 240
 
235 241
 				// Sort them this way because if it's done with MySQL it causes a filesort :(.
@@ -239,8 +245,9 @@  discard block
 block discarded – undo
239 245
 			}
240 246
 
241 247
 			// Oh great, they've screwed their post groups.
242
-			if (empty($postgroups))
243
-				return;
248
+			if (empty($postgroups)) {
249
+							return;
250
+			}
244 251
 
245 252
 			// Set all membergroups from most posts to least posts.
246 253
 			$conditions = '';
@@ -298,10 +305,9 @@  discard block
 block discarded – undo
298 305
 	{
299 306
 		$condition = 'id_member IN ({array_int:members})';
300 307
 		$parameters['members'] = $members;
301
-	}
302
-	elseif ($members === null)
303
-		$condition = '1=1';
304
-	else
308
+	} elseif ($members === null) {
309
+			$condition = '1=1';
310
+	} else
305 311
 	{
306 312
 		$condition = 'id_member = {int:member}';
307 313
 		$parameters['member'] = $members;
@@ -341,9 +347,9 @@  discard block
 block discarded – undo
341 347
 		if (count($vars_to_integrate) != 0)
342 348
 		{
343 349
 			// Fetch a list of member_names if necessary
344
-			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members)))
345
-				$member_names = array($user_info['username']);
346
-			else
350
+			if ((!is_array($members) && $members === $user_info['id']) || (is_array($members) && count($members) == 1 && in_array($user_info['id'], $members))) {
351
+							$member_names = array($user_info['username']);
352
+			} else
347 353
 			{
348 354
 				$member_names = array();
349 355
 				$request = $smcFunc['db_query']('', '
@@ -352,14 +358,16 @@  discard block
 block discarded – undo
352 358
 					WHERE ' . $condition,
353 359
 					$parameters
354 360
 				);
355
-				while ($row = $smcFunc['db_fetch_assoc']($request))
356
-					$member_names[] = $row['member_name'];
361
+				while ($row = $smcFunc['db_fetch_assoc']($request)) {
362
+									$member_names[] = $row['member_name'];
363
+				}
357 364
 				$smcFunc['db_free_result']($request);
358 365
 			}
359 366
 
360
-			if (!empty($member_names))
361
-				foreach ($vars_to_integrate as $var)
367
+			if (!empty($member_names)) {
368
+							foreach ($vars_to_integrate as $var)
362 369
 					call_integration_hook('integrate_change_member_data', array($member_names, $var, &$data[$var], &$knownInts, &$knownFloats));
370
+			}
363 371
 		}
364 372
 	}
365 373
 
@@ -367,16 +375,17 @@  discard block
 block discarded – undo
367 375
 	foreach ($data as $var => $val)
368 376
 	{
369 377
 		$type = 'string';
370
-		if (in_array($var, $knownInts))
371
-			$type = 'int';
372
-		elseif (in_array($var, $knownFloats))
373
-			$type = 'float';
374
-		elseif ($var == 'birthdate')
375
-			$type = 'date';
376
-		elseif ($var == 'member_ip')
377
-			$type = 'inet';
378
-		elseif ($var == 'member_ip2')
379
-			$type = 'inet';
378
+		if (in_array($var, $knownInts)) {
379
+					$type = 'int';
380
+		} elseif (in_array($var, $knownFloats)) {
381
+					$type = 'float';
382
+		} elseif ($var == 'birthdate') {
383
+					$type = 'date';
384
+		} elseif ($var == 'member_ip') {
385
+					$type = 'inet';
386
+		} elseif ($var == 'member_ip2') {
387
+					$type = 'inet';
388
+		}
380 389
 
381 390
 		// Doing an increment?
382 391
 		if ($type == 'int' && ($val === '+' || $val === '-'))
@@ -390,8 +399,9 @@  discard block
 block discarded – undo
390 399
 		{
391 400
 			if (preg_match('~^' . $var . ' (\+ |- |\+ -)([\d]+)~', $val, $match))
392 401
 			{
393
-				if ($match[1] != '+ ')
394
-					$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
402
+				if ($match[1] != '+ ') {
403
+									$val = 'CASE WHEN ' . $var . ' <= ' . abs($match[2]) . ' THEN 0 ELSE ' . $val . ' END';
404
+				}
395 405
 				$type = 'raw';
396 406
 			}
397 407
 		}
@@ -412,8 +422,9 @@  discard block
 block discarded – undo
412 422
 	// Clear any caching?
413 423
 	if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && !empty($members))
414 424
 	{
415
-		if (!is_array($members))
416
-			$members = array($members);
425
+		if (!is_array($members)) {
426
+					$members = array($members);
427
+		}
417 428
 
418 429
 		foreach ($members as $member)
419 430
 		{
@@ -446,29 +457,32 @@  discard block
 block discarded – undo
446 457
 {
447 458
 	global $modSettings, $smcFunc;
448 459
 
449
-	if (empty($changeArray) || !is_array($changeArray))
450
-		return;
460
+	if (empty($changeArray) || !is_array($changeArray)) {
461
+			return;
462
+	}
451 463
 
452 464
 	$toRemove = array();
453 465
 
454 466
 	// Go check if there is any setting to be removed.
455
-	foreach ($changeArray as $k => $v)
456
-		if ($v === null)
467
+	foreach ($changeArray as $k => $v) {
468
+			if ($v === null)
457 469
 		{
458 470
 			// Found some, remove them from the original array and add them to ours.
459 471
 			unset($changeArray[$k]);
472
+	}
460 473
 			$toRemove[] = $k;
461 474
 		}
462 475
 
463 476
 	// Proceed with the deletion.
464
-	if (!empty($toRemove))
465
-		$smcFunc['db_query']('', '
477
+	if (!empty($toRemove)) {
478
+			$smcFunc['db_query']('', '
466 479
 			DELETE FROM {db_prefix}settings
467 480
 			WHERE variable IN ({array_string:remove})',
468 481
 			array(
469 482
 				'remove' => $toRemove,
470 483
 			)
471 484
 		);
485
+	}
472 486
 
473 487
 	// In some cases, this may be better and faster, but for large sets we don't want so many UPDATEs.
474 488
 	if ($update)
@@ -497,19 +511,22 @@  discard block
 block discarded – undo
497 511
 	foreach ($changeArray as $variable => $value)
498 512
 	{
499 513
 		// Don't bother if it's already like that ;).
500
-		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value)
501
-			continue;
514
+		if (isset($modSettings[$variable]) && $modSettings[$variable] == $value) {
515
+					continue;
516
+		}
502 517
 		// If the variable isn't set, but would only be set to nothing'ness, then don't bother setting it.
503
-		elseif (!isset($modSettings[$variable]) && empty($value))
504
-			continue;
518
+		elseif (!isset($modSettings[$variable]) && empty($value)) {
519
+					continue;
520
+		}
505 521
 
506 522
 		$replaceArray[] = array($variable, $value);
507 523
 
508 524
 		$modSettings[$variable] = $value;
509 525
 	}
510 526
 
511
-	if (empty($replaceArray))
512
-		return;
527
+	if (empty($replaceArray)) {
528
+			return;
529
+	}
513 530
 
514 531
 	$smcFunc['db_insert']('replace',
515 532
 		'{db_prefix}settings',
@@ -555,14 +572,17 @@  discard block
 block discarded – undo
555 572
 	$start_invalid = $start < 0;
556 573
 
557 574
 	// Make sure $start is a proper variable - not less than 0.
558
-	if ($start_invalid)
559
-		$start = 0;
575
+	if ($start_invalid) {
576
+			$start = 0;
577
+	}
560 578
 	// Not greater than the upper bound.
561
-	elseif ($start >= $max_value)
562
-		$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
579
+	elseif ($start >= $max_value) {
580
+			$start = max(0, (int) $max_value - (((int) $max_value % (int) $num_per_page) == 0 ? $num_per_page : ((int) $max_value % (int) $num_per_page)));
581
+	}
563 582
 	// And it has to be a multiple of $num_per_page!
564
-	else
565
-		$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
583
+	else {
584
+			$start = max(0, (int) $start - ((int) $start % (int) $num_per_page));
585
+	}
566 586
 
567 587
 	$context['current_page'] = $start / $num_per_page;
568 588
 
@@ -592,77 +612,87 @@  discard block
 block discarded – undo
592 612
 
593 613
 		// Show all the pages.
594 614
 		$display_page = 1;
595
-		for ($counter = 0; $counter < $max_value; $counter += $num_per_page)
596
-			$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
615
+		for ($counter = 0; $counter < $max_value; $counter += $num_per_page) {
616
+					$pageindex .= $start == $counter && !$start_invalid ? sprintf($settings['page_index']['current_page'], $display_page++) : sprintf($base_link, $counter, $display_page++);
617
+		}
597 618
 
598 619
 		// Show the right arrow.
599 620
 		$display_page = ($start + $num_per_page) > $max_value ? $max_value : ($start + $num_per_page);
600
-		if ($start != $counter - $max_value && !$start_invalid)
601
-			$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
602
-	}
603
-	else
621
+		if ($start != $counter - $max_value && !$start_invalid) {
622
+					$pageindex .= $display_page > $counter - $num_per_page ? ' ' : sprintf($base_link, $display_page, $settings['page_index']['next_page']);
623
+		}
624
+	} else
604 625
 	{
605 626
 		// If they didn't enter an odd value, pretend they did.
606 627
 		$PageContiguous = (int) ($modSettings['compactTopicPagesContiguous'] - ($modSettings['compactTopicPagesContiguous'] % 2)) / 2;
607 628
 
608 629
 		// Show the "prev page" link. (>prev page< 1 ... 6 7 [8] 9 10 ... 15 next page)
609
-		if (!empty($start) && $show_prevnext)
610
-			$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
611
-		else
612
-			$pageindex .= '';
630
+		if (!empty($start) && $show_prevnext) {
631
+					$pageindex .= sprintf($base_link, $start - $num_per_page, $settings['page_index']['previous_page']);
632
+		} else {
633
+					$pageindex .= '';
634
+		}
613 635
 
614 636
 		// Show the first page. (prev page >1< ... 6 7 [8] 9 10 ... 15)
615
-		if ($start > $num_per_page * $PageContiguous)
616
-			$pageindex .= sprintf($base_link, 0, '1');
637
+		if ($start > $num_per_page * $PageContiguous) {
638
+					$pageindex .= sprintf($base_link, 0, '1');
639
+		}
617 640
 
618 641
 		// Show the ... after the first page.  (prev page 1 >...< 6 7 [8] 9 10 ... 15 next page)
619
-		if ($start > $num_per_page * ($PageContiguous + 1))
620
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
642
+		if ($start > $num_per_page * ($PageContiguous + 1)) {
643
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
621 644
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
622 645
 				'{FIRST_PAGE}' => $num_per_page,
623 646
 				'{LAST_PAGE}' => $start - $num_per_page * $PageContiguous,
624 647
 				'{PER_PAGE}' => $num_per_page,
625 648
 			));
649
+		}
626 650
 
627 651
 		// Show the pages before the current one. (prev page 1 ... >6 7< [8] 9 10 ... 15 next page)
628
-		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--)
629
-			if ($start >= $num_per_page * $nCont)
652
+		for ($nCont = $PageContiguous; $nCont >= 1; $nCont--) {
653
+					if ($start >= $num_per_page * $nCont)
630 654
 			{
631 655
 				$tmpStart = $start - $num_per_page * $nCont;
656
+		}
632 657
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
633 658
 			}
634 659
 
635 660
 		// Show the current page. (prev page 1 ... 6 7 >[8]< 9 10 ... 15 next page)
636
-		if (!$start_invalid)
637
-			$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
638
-		else
639
-			$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
661
+		if (!$start_invalid) {
662
+					$pageindex .= sprintf($settings['page_index']['current_page'], $start / $num_per_page + 1);
663
+		} else {
664
+					$pageindex .= sprintf($base_link, $start, $start / $num_per_page + 1);
665
+		}
640 666
 
641 667
 		// Show the pages after the current one... (prev page 1 ... 6 7 [8] >9 10< ... 15 next page)
642 668
 		$tmpMaxPages = (int) (($max_value - 1) / $num_per_page) * $num_per_page;
643
-		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++)
644
-			if ($start + $num_per_page * $nCont <= $tmpMaxPages)
669
+		for ($nCont = 1; $nCont <= $PageContiguous; $nCont++) {
670
+					if ($start + $num_per_page * $nCont <= $tmpMaxPages)
645 671
 			{
646 672
 				$tmpStart = $start + $num_per_page * $nCont;
673
+		}
647 674
 				$pageindex .= sprintf($base_link, $tmpStart, $tmpStart / $num_per_page + 1);
648 675
 			}
649 676
 
650 677
 		// Show the '...' part near the end. (prev page 1 ... 6 7 [8] 9 10 >...< 15 next page)
651
-		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages)
652
-			$pageindex .= strtr($settings['page_index']['expand_pages'], array(
678
+		if ($start + $num_per_page * ($PageContiguous + 1) < $tmpMaxPages) {
679
+					$pageindex .= strtr($settings['page_index']['expand_pages'], array(
653 680
 				'{LINK}' => JavaScriptEscape($smcFunc['htmlspecialchars']($base_link)),
654 681
 				'{FIRST_PAGE}' => $start + $num_per_page * ($PageContiguous + 1),
655 682
 				'{LAST_PAGE}' => $tmpMaxPages,
656 683
 				'{PER_PAGE}' => $num_per_page,
657 684
 			));
685
+		}
658 686
 
659 687
 		// Show the last number in the list. (prev page 1 ... 6 7 [8] 9 10 ... >15<  next page)
660
-		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages)
661
-			$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
688
+		if ($start + $num_per_page * $PageContiguous < $tmpMaxPages) {
689
+					$pageindex .= sprintf($base_link, $tmpMaxPages, $tmpMaxPages / $num_per_page + 1);
690
+		}
662 691
 
663 692
 		// Show the "next page" link. (prev page 1 ... 6 7 [8] 9 10 ... 15 >next page<)
664
-		if ($start != $tmpMaxPages && $show_prevnext)
665
-			$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
693
+		if ($start != $tmpMaxPages && $show_prevnext) {
694
+					$pageindex .= sprintf($base_link, $start + $num_per_page, $settings['page_index']['next_page']);
695
+		}
666 696
 	}
667 697
 	$pageindex .= $settings['page_index']['extra_after'];
668 698
 
@@ -688,8 +718,9 @@  discard block
 block discarded – undo
688 718
 	if ($decimal_separator === null)
689 719
 	{
690 720
 		// Not set for whatever reason?
691
-		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1)
692
-			return $number;
721
+		if (empty($txt['number_format']) || preg_match('~^1([^\d]*)?234([^\d]*)(0*?)$~', $txt['number_format'], $matches) != 1) {
722
+					return $number;
723
+		}
693 724
 
694 725
 		// Cache these each load...
695 726
 		$thousands_separator = $matches[1];
@@ -723,17 +754,20 @@  discard block
 block discarded – undo
723 754
 	static $unsupportedFormats, $finalizedFormats;
724 755
 
725 756
 	// Offset the time.
726
-	if (!$offset_type)
727
-		$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
757
+	if (!$offset_type) {
758
+			$time = $log_time + ($user_info['time_offset'] + $modSettings['time_offset']) * 3600;
759
+	}
728 760
 	// Just the forum offset?
729
-	elseif ($offset_type == 'forum')
730
-		$time = $log_time + $modSettings['time_offset'] * 3600;
731
-	else
732
-		$time = $log_time;
761
+	elseif ($offset_type == 'forum') {
762
+			$time = $log_time + $modSettings['time_offset'] * 3600;
763
+	} else {
764
+			$time = $log_time;
765
+	}
733 766
 
734 767
 	// We can't have a negative date (on Windows, at least.)
735
-	if ($log_time < 0)
736
-		$log_time = 0;
768
+	if ($log_time < 0) {
769
+			$log_time = 0;
770
+	}
737 771
 
738 772
 	// Today and Yesterday?
739 773
 	if ($modSettings['todayMod'] >= 1 && $show_today === true)
@@ -750,24 +784,27 @@  discard block
 block discarded – undo
750 784
 		{
751 785
 			$h = strpos($user_info['time_format'], '%l') === false ? '%I' : '%l';
752 786
 			$today_fmt = $h . ':%M' . $s . ' %p';
787
+		} else {
788
+					$today_fmt = '%H:%M' . $s;
753 789
 		}
754
-		else
755
-			$today_fmt = '%H:%M' . $s;
756 790
 
757 791
 		// Same day of the year, same year.... Today!
758
-		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year'])
759
-			return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
792
+		if ($then['yday'] == $now['yday'] && $then['year'] == $now['year']) {
793
+					return $txt['today'] . timeformat($log_time, $today_fmt, $offset_type);
794
+		}
760 795
 
761 796
 		// Day-of-year is one less and same year, or it's the first of the year and that's the last of the year...
762
-		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31))
763
-			return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
797
+		if ($modSettings['todayMod'] == '2' && (($then['yday'] == $now['yday'] - 1 && $then['year'] == $now['year']) || ($now['yday'] == 0 && $then['year'] == $now['year'] - 1) && $then['mon'] == 12 && $then['mday'] == 31)) {
798
+					return $txt['yesterday'] . timeformat($log_time, $today_fmt, $offset_type);
799
+		}
764 800
 	}
765 801
 
766 802
 	$str = !is_bool($show_today) ? $show_today : $user_info['time_format'];
767 803
 
768 804
 	// Use the cached formats if available
769
-	if (is_null($finalizedFormats))
770
-		$finalizedFormats = (array) cache_get_data('timeformatstrings', 86400);
805
+	if (is_null($finalizedFormats)) {
806
+			$finalizedFormats = (array) cache_get_data('timeformatstrings', 86400);
807
+	}
771 808
 
772 809
 	// Make a supported version for this format if we don't already have one
773 810
 	if (empty($finalizedFormats[$str]))
@@ -796,8 +833,9 @@  discard block
 block discarded – undo
796 833
 		);
797 834
 
798 835
 		// No need to do this part again if we already did it once
799
-		if (is_null($unsupportedFormats))
800
-			$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
836
+		if (is_null($unsupportedFormats)) {
837
+					$unsupportedFormats = (array) cache_get_data('unsupportedtimeformats', 86400);
838
+		}
801 839
 		if (empty($unsupportedFormats))
802 840
 		{
803 841
 			foreach($strftimeFormatSubstitutions as $format => $substitution)
@@ -806,20 +844,23 @@  discard block
 block discarded – undo
806 844
 
807 845
 				// Windows will return false for unsupported formats
808 846
 				// Other operating systems return the format string as a literal
809
-				if ($value === false || $value === $format)
810
-					$unsupportedFormats[] = $format;
847
+				if ($value === false || $value === $format) {
848
+									$unsupportedFormats[] = $format;
849
+				}
811 850
 			}
812 851
 			cache_put_data('unsupportedtimeformats', $unsupportedFormats, 86400);
813 852
 		}
814 853
 
815 854
 		// Windows needs extra help if $timeformat contains something completely invalid, e.g. '%Q'
816
-		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN')
817
-			$timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '&#37;', $timeformat);
855
+		if (strtoupper(substr(PHP_OS, 0, 3)) == 'WIN') {
856
+					$timeformat = preg_replace('~%(?!' . implode('|', array_keys($strftimeFormatSubstitutions)) . ')~', '&#37;', $timeformat);
857
+		}
818 858
 
819 859
 		// Substitute unsupported formats with supported ones
820
-		if (!empty($unsupportedFormats))
821
-			while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches))
860
+		if (!empty($unsupportedFormats)) {
861
+					while (preg_match('~%(' . implode('|', $unsupportedFormats) . ')~', $timeformat, $matches))
822 862
 				$timeformat = str_replace($matches[0], $strftimeFormatSubstitutions[$matches[1]], $timeformat);
863
+		}
823 864
 
824 865
 		// Remember this so we don't need to do it again
825 866
 		$finalizedFormats[$str] = $timeformat;
@@ -828,33 +869,39 @@  discard block
 block discarded – undo
828 869
 
829 870
 	$str = $finalizedFormats[$str];
830 871
 
831
-	if (!isset($locale_cache))
832
-		$locale_cache = setlocale(LC_TIME, $txt['lang_locale']);
872
+	if (!isset($locale_cache)) {
873
+			$locale_cache = setlocale(LC_TIME, $txt['lang_locale']);
874
+	}
833 875
 
834 876
 	if ($locale_cache !== false)
835 877
 	{
836 878
 		// Check if another process changed the locale
837
-		if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache)
838
-			setlocale(LC_TIME, $txt['lang_locale']);
879
+		if ($process_safe === true && setlocale(LC_TIME, '0') != $locale_cache) {
880
+					setlocale(LC_TIME, $txt['lang_locale']);
881
+		}
839 882
 
840
-		if (!isset($non_twelve_hour))
841
-			$non_twelve_hour = trim(strftime('%p')) === '';
842
-		if ($non_twelve_hour && strpos($str, '%p') !== false)
843
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
883
+		if (!isset($non_twelve_hour)) {
884
+					$non_twelve_hour = trim(strftime('%p')) === '';
885
+		}
886
+		if ($non_twelve_hour && strpos($str, '%p') !== false) {
887
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
888
+		}
844 889
 
845
-		foreach (array('%a', '%A', '%b', '%B') as $token)
846
-			if (strpos($str, $token) !== false)
890
+		foreach (array('%a', '%A', '%b', '%B') as $token) {
891
+					if (strpos($str, $token) !== false)
847 892
 				$str = str_replace($token, strftime($token, $time), $str);
848
-	}
849
-	else
893
+		}
894
+	} else
850 895
 	{
851 896
 		// Do-it-yourself time localization.  Fun.
852
-		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label)
853
-			if (strpos($str, $token) !== false)
897
+		foreach (array('%a' => 'days_short', '%A' => 'days', '%b' => 'months_short', '%B' => 'months') as $token => $text_label) {
898
+					if (strpos($str, $token) !== false)
854 899
 				$str = str_replace($token, $txt[$text_label][(int) strftime($token === '%a' || $token === '%A' ? '%w' : '%m', $time)], $str);
900
+		}
855 901
 
856
-		if (strpos($str, '%p') !== false)
857
-			$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
902
+		if (strpos($str, '%p') !== false) {
903
+					$str = str_replace('%p', (strftime('%H', $time) < 12 ? $txt['time_am'] : $txt['time_pm']), $str);
904
+		}
858 905
 	}
859 906
 
860 907
 	// Format the time and then restore any literal percent characters
@@ -877,16 +924,19 @@  discard block
 block discarded – undo
877 924
 	static $translation = array();
878 925
 
879 926
 	// Determine the character set... Default to UTF-8
880
-	if (empty($context['character_set']))
881
-		$charset = 'UTF-8';
927
+	if (empty($context['character_set'])) {
928
+			$charset = 'UTF-8';
929
+	}
882 930
 	// Use ISO-8859-1 in place of non-supported ISO-8859 charsets...
883
-	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15')))
884
-		$charset = 'ISO-8859-1';
885
-	else
886
-		$charset = $context['character_set'];
931
+	elseif (strpos($context['character_set'], 'ISO-8859-') !== false && !in_array($context['character_set'], array('ISO-8859-5', 'ISO-8859-15'))) {
932
+			$charset = 'ISO-8859-1';
933
+	} else {
934
+			$charset = $context['character_set'];
935
+	}
887 936
 
888
-	if (empty($translation))
889
-		$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
937
+	if (empty($translation)) {
938
+			$translation = array_flip(get_html_translation_table(HTML_SPECIALCHARS, ENT_QUOTES, $charset)) + array('&#039;' => '\'', '&#39;' => '\'', '&nbsp;' => ' ');
939
+	}
890 940
 
891 941
 	return strtr($string, $translation);
892 942
 }
@@ -908,8 +958,9 @@  discard block
 block discarded – undo
908 958
 	global $smcFunc;
909 959
 
910 960
 	// It was already short enough!
911
-	if ($smcFunc['strlen']($subject) <= $len)
912
-		return $subject;
961
+	if ($smcFunc['strlen']($subject) <= $len) {
962
+			return $subject;
963
+	}
913 964
 
914 965
 	// Shorten it by the length it was too long, and strip off junk from the end.
915 966
 	return $smcFunc['substr']($subject, 0, $len) . '...';
@@ -928,10 +979,11 @@  discard block
 block discarded – undo
928 979
 {
929 980
 	global $user_info, $modSettings;
930 981
 
931
-	if ($timestamp === null)
932
-		$timestamp = time();
933
-	elseif ($timestamp == 0)
934
-		return 0;
982
+	if ($timestamp === null) {
983
+			$timestamp = time();
984
+	} elseif ($timestamp == 0) {
985
+			return 0;
986
+	}
935 987
 
936 988
 	return $timestamp + ($modSettings['time_offset'] + ($use_user_offset ? $user_info['time_offset'] : 0)) * 3600;
937 989
 }
@@ -960,8 +1012,9 @@  discard block
 block discarded – undo
960 1012
 		$array[$i] = $array[$j];
961 1013
 		$array[$j] = $temp;
962 1014
 
963
-		for ($i = 1; $p[$i] == 0; $i++)
964
-			$p[$i] = 1;
1015
+		for ($i = 1; $p[$i] == 0; $i++) {
1016
+					$p[$i] = 1;
1017
+		}
965 1018
 
966 1019
 		$orders[] = $array;
967 1020
 	}
@@ -993,12 +1046,14 @@  discard block
 block discarded – undo
993 1046
 	static $disabled;
994 1047
 
995 1048
 	// Don't waste cycles
996
-	if ($message === '')
997
-		return '';
1049
+	if ($message === '') {
1050
+			return '';
1051
+	}
998 1052
 
999 1053
 	// Just in case it wasn't determined yet whether UTF-8 is enabled.
1000
-	if (!isset($context['utf8']))
1001
-		$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
1054
+	if (!isset($context['utf8'])) {
1055
+			$context['utf8'] = (empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set']) === 'UTF-8';
1056
+	}
1002 1057
 
1003 1058
 	// Clean up any cut/paste issues we may have
1004 1059
 	$message = sanitizeMSCutPaste($message);
@@ -1010,13 +1065,15 @@  discard block
 block discarded – undo
1010 1065
 		return $message;
1011 1066
 	}
1012 1067
 
1013
-	if ($smileys !== null && ($smileys == '1' || $smileys == '0'))
1014
-		$smileys = (bool) $smileys;
1068
+	if ($smileys !== null && ($smileys == '1' || $smileys == '0')) {
1069
+			$smileys = (bool) $smileys;
1070
+	}
1015 1071
 
1016 1072
 	if (empty($modSettings['enableBBC']) && $message !== false)
1017 1073
 	{
1018
-		if ($smileys === true)
1019
-			parsesmileys($message);
1074
+		if ($smileys === true) {
1075
+					parsesmileys($message);
1076
+		}
1020 1077
 
1021 1078
 		return $message;
1022 1079
 	}
@@ -1029,8 +1086,9 @@  discard block
 block discarded – undo
1029 1086
 	}
1030 1087
 
1031 1088
 	// Ensure $modSettings['tld_regex'] contains a valid regex for the autolinker
1032
-	if (!empty($modSettings['autoLinkUrls']))
1033
-		set_tld_regex();
1089
+	if (!empty($modSettings['autoLinkUrls'])) {
1090
+			set_tld_regex();
1091
+	}
1034 1092
 
1035 1093
 	// Allow mods access before entering the main parse_bbc loop
1036 1094
 	call_integration_hook('integrate_pre_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
@@ -1044,12 +1102,14 @@  discard block
 block discarded – undo
1044 1102
 
1045 1103
 			$temp = explode(',', strtolower($modSettings['disabledBBC']));
1046 1104
 
1047
-			foreach ($temp as $tag)
1048
-				$disabled[trim($tag)] = true;
1105
+			foreach ($temp as $tag) {
1106
+							$disabled[trim($tag)] = true;
1107
+			}
1049 1108
 		}
1050 1109
 
1051
-		if (empty($modSettings['enableEmbeddedFlash']))
1052
-			$disabled['flash'] = true;
1110
+		if (empty($modSettings['enableEmbeddedFlash'])) {
1111
+					$disabled['flash'] = true;
1112
+		}
1053 1113
 
1054 1114
 		/* The following bbc are formatted as an array, with keys as follows:
1055 1115
 
@@ -1170,8 +1230,9 @@  discard block
 block discarded – undo
1170 1230
 					$returnContext = '';
1171 1231
 
1172 1232
 					// BBC or the entire attachments feature is disabled
1173
-					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach']))
1174
-						return $data;
1233
+					if (empty($modSettings['attachmentEnable']) || !empty($disabled['attach'])) {
1234
+											return $data;
1235
+					}
1175 1236
 
1176 1237
 					// Save the attach ID.
1177 1238
 					$attachID = $data;
@@ -1182,8 +1243,9 @@  discard block
 block discarded – undo
1182 1243
 					$currentAttachment = parseAttachBBC($attachID);
1183 1244
 
1184 1245
 					// parseAttachBBC will return a string ($txt key) rather than diying with a fatal_error. Up to you to decide what to do.
1185
-					if (is_string($currentAttachment))
1186
-						return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1246
+					if (is_string($currentAttachment)) {
1247
+											return $data = !empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment;
1248
+					}
1187 1249
 
1188 1250
 					if (!empty($currentAttachment['is_image']))
1189 1251
 					{
@@ -1199,15 +1261,17 @@  discard block
 block discarded – undo
1199 1261
 							$height = ' height="' . $currentAttachment['height'] . '"';
1200 1262
 						}
1201 1263
 
1202
-						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}']))
1203
-							$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1204
-						else
1205
-							$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1264
+						if ($currentAttachment['thumbnail']['has_thumb'] && empty($params['{width}']) && empty($params['{height}'])) {
1265
+													$returnContext .= '<a href="'. $currentAttachment['href']. ';image" id="link_'. $currentAttachment['id']. '" onclick="'. $currentAttachment['thumbnail']['javascript']. '"><img src="'. $currentAttachment['thumbnail']['href']. '"' . $alt . $title . ' id="thumb_'. $currentAttachment['id']. '" class="atc_img"></a>';
1266
+						} else {
1267
+													$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img"/>';
1268
+						}
1206 1269
 					}
1207 1270
 
1208 1271
 					// No image. Show a link.
1209
-					else
1210
-						$returnContext .= $currentAttachment['link'];
1272
+					else {
1273
+											$returnContext .= $currentAttachment['link'];
1274
+					}
1211 1275
 
1212 1276
 					// Gotta append what we just did.
1213 1277
 					$data = $returnContext;
@@ -1238,8 +1302,9 @@  discard block
 block discarded – undo
1238 1302
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1239 1303
 						{
1240 1304
 							// Do PHP code coloring?
1241
-							if ($php_parts[$php_i] != '&lt;?php')
1242
-								continue;
1305
+							if ($php_parts[$php_i] != '&lt;?php') {
1306
+															continue;
1307
+							}
1243 1308
 
1244 1309
 							$php_string = '';
1245 1310
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1255,8 +1320,9 @@  discard block
 block discarded – undo
1255 1320
 						$data = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data);
1256 1321
 
1257 1322
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1258
-						if ($context['browser']['is_opera'])
1259
-							$data .= '&nbsp;';
1323
+						if ($context['browser']['is_opera']) {
1324
+													$data .= '&nbsp;';
1325
+						}
1260 1326
 					}
1261 1327
 				},
1262 1328
 				'block_level' => true,
@@ -1275,8 +1341,9 @@  discard block
 block discarded – undo
1275 1341
 						for ($php_i = 0, $php_n = count($php_parts); $php_i < $php_n; $php_i++)
1276 1342
 						{
1277 1343
 							// Do PHP code coloring?
1278
-							if ($php_parts[$php_i] != '&lt;?php')
1279
-								continue;
1344
+							if ($php_parts[$php_i] != '&lt;?php') {
1345
+															continue;
1346
+							}
1280 1347
 
1281 1348
 							$php_string = '';
1282 1349
 							while ($php_i + 1 < count($php_parts) && $php_parts[$php_i] != '?&gt;')
@@ -1292,8 +1359,9 @@  discard block
 block discarded – undo
1292 1359
 						$data[0] = str_replace("\t", "<span style=\"white-space: pre;\">\t</span>", $data[0]);
1293 1360
 
1294 1361
 						// Recent Opera bug requiring temporary fix. &nsbp; is needed before </code> to avoid broken selection.
1295
-						if ($context['browser']['is_opera'])
1296
-							$data[0] .= '&nbsp;';
1362
+						if ($context['browser']['is_opera']) {
1363
+													$data[0] .= '&nbsp;';
1364
+						}
1297 1365
 					}
1298 1366
 				},
1299 1367
 				'block_level' => true,
@@ -1331,11 +1399,13 @@  discard block
 block discarded – undo
1331 1399
 				'content' => '<embed type="application/x-shockwave-flash" src="$1" width="$2" height="$3" play="true" loop="true" quality="high" AllowScriptAccess="never">',
1332 1400
 				'validate' => function (&$tag, &$data, $disabled)
1333 1401
 				{
1334
-					if (isset($disabled['url']))
1335
-						$tag['content'] = '$1';
1402
+					if (isset($disabled['url'])) {
1403
+											$tag['content'] = '$1';
1404
+					}
1336 1405
 					$scheme = parse_url($data[0], PHP_URL_SCHEME);
1337
-					if (empty($scheme))
1338
-						$data[0] = '//' . ltrim($data[0], ':/');
1406
+					if (empty($scheme)) {
1407
+											$data[0] = '//' . ltrim($data[0], ':/');
1408
+					}
1339 1409
 				},
1340 1410
 				'disabled_content' => '<a href="$1" target="_blank">$1</a>',
1341 1411
 			),
@@ -1349,10 +1419,11 @@  discard block
 block discarded – undo
1349 1419
 				{
1350 1420
 					$class = 'class="bbc_float float' . (strpos($data, 'left') === 0 ? 'left' : 'right') . '"';
1351 1421
 
1352
-					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches))
1353
-						$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1354
-					else
1355
-						$css = '';
1422
+					if (preg_match('~\bmax=(\d+(?:%|px|em|rem|ex|pt|pc|ch|vw|vh|vmin|vmax|cm|mm|in)?)~', $data, $matches)) {
1423
+											$css = ' style="max-width:' . $matches[1] . (is_numeric($matches[1]) ? 'px' : '') . '"';
1424
+					} else {
1425
+											$css = '';
1426
+					}
1356 1427
 
1357 1428
 					$data = $class . $css;
1358 1429
 				},
@@ -1402,14 +1473,16 @@  discard block
 block discarded – undo
1402 1473
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1403 1474
 					if ($image_proxy_enabled)
1404 1475
 					{
1405
-						if (empty($scheme))
1406
-							$data = 'http://' . ltrim($data, ':/');
1476
+						if (empty($scheme)) {
1477
+													$data = 'http://' . ltrim($data, ':/');
1478
+						}
1407 1479
 
1408
-						if ($scheme != 'https')
1409
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1480
+						if ($scheme != 'https') {
1481
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1482
+						}
1483
+					} elseif (empty($scheme)) {
1484
+											$data = '//' . ltrim($data, ':/');
1410 1485
 					}
1411
-					elseif (empty($scheme))
1412
-						$data = '//' . ltrim($data, ':/');
1413 1486
 				},
1414 1487
 				'disabled_content' => '($1)',
1415 1488
 			),
@@ -1425,14 +1498,16 @@  discard block
 block discarded – undo
1425 1498
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1426 1499
 					if ($image_proxy_enabled)
1427 1500
 					{
1428
-						if (empty($scheme))
1429
-							$data = 'http://' . ltrim($data, ':/');
1501
+						if (empty($scheme)) {
1502
+													$data = 'http://' . ltrim($data, ':/');
1503
+						}
1430 1504
 
1431
-						if ($scheme != 'https')
1432
-							$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1505
+						if ($scheme != 'https') {
1506
+													$data = $boardurl . '/proxy.php?request=' . urlencode($data) . '&hash=' . md5($data . $image_proxy_secret);
1507
+						}
1508
+					} elseif (empty($scheme)) {
1509
+											$data = '//' . ltrim($data, ':/');
1433 1510
 					}
1434
-					elseif (empty($scheme))
1435
-						$data = '//' . ltrim($data, ':/');
1436 1511
 				},
1437 1512
 				'disabled_content' => '($1)',
1438 1513
 			),
@@ -1444,8 +1519,9 @@  discard block
 block discarded – undo
1444 1519
 				{
1445 1520
 					$data = strtr($data, array('<br>' => ''));
1446 1521
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1447
-					if (empty($scheme))
1448
-						$data = '//' . ltrim($data, ':/');
1522
+					if (empty($scheme)) {
1523
+											$data = '//' . ltrim($data, ':/');
1524
+					}
1449 1525
 				},
1450 1526
 			),
1451 1527
 			array(
@@ -1456,13 +1532,14 @@  discard block
 block discarded – undo
1456 1532
 				'after' => '</a>',
1457 1533
 				'validate' => function (&$tag, &$data, $disabled)
1458 1534
 				{
1459
-					if (substr($data, 0, 1) == '#')
1460
-						$data = '#post_' . substr($data, 1);
1461
-					else
1535
+					if (substr($data, 0, 1) == '#') {
1536
+											$data = '#post_' . substr($data, 1);
1537
+					} else
1462 1538
 					{
1463 1539
 						$scheme = parse_url($data, PHP_URL_SCHEME);
1464
-						if (empty($scheme))
1465
-							$data = '//' . ltrim($data, ':/');
1540
+						if (empty($scheme)) {
1541
+													$data = '//' . ltrim($data, ':/');
1542
+						}
1466 1543
 					}
1467 1544
 				},
1468 1545
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
@@ -1540,8 +1617,9 @@  discard block
 block discarded – undo
1540 1617
 					{
1541 1618
 						$add_begin = substr(trim($data), 0, 5) != '&lt;?';
1542 1619
 						$data = highlight_php_code($add_begin ? '&lt;?php ' . $data . '?&gt;' : $data);
1543
-						if ($add_begin)
1544
-							$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1620
+						if ($add_begin) {
1621
+													$data = preg_replace(array('~^(.+?)&lt;\?.{0,40}?php(?:&nbsp;|\s)~', '~\?&gt;((?:</(font|span)>)*)$~'), '$1', $data, 2);
1622
+						}
1545 1623
 					}
1546 1624
 				},
1547 1625
 				'block_level' => false,
@@ -1672,10 +1750,11 @@  discard block
 block discarded – undo
1672 1750
 				'content' => '$1',
1673 1751
 				'validate' => function (&$tag, &$data, $disabled)
1674 1752
 				{
1675
-					if (is_numeric($data))
1676
-						$data = timeformat($data);
1677
-					else
1678
-						$tag['content'] = '[time]$1[/time]';
1753
+					if (is_numeric($data)) {
1754
+											$data = timeformat($data);
1755
+					} else {
1756
+											$tag['content'] = '[time]$1[/time]';
1757
+					}
1679 1758
 				},
1680 1759
 			),
1681 1760
 			array(
@@ -1702,8 +1781,9 @@  discard block
 block discarded – undo
1702 1781
 				{
1703 1782
 					$data = strtr($data, array('<br>' => ''));
1704 1783
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1705
-					if (empty($scheme))
1706
-						$data = '//' . ltrim($data, ':/');
1784
+					if (empty($scheme)) {
1785
+											$data = '//' . ltrim($data, ':/');
1786
+					}
1707 1787
 				},
1708 1788
 			),
1709 1789
 			array(
@@ -1715,8 +1795,9 @@  discard block
 block discarded – undo
1715 1795
 				'validate' => function (&$tag, &$data, $disabled)
1716 1796
 				{
1717 1797
 					$scheme = parse_url($data, PHP_URL_SCHEME);
1718
-					if (empty($scheme))
1719
-						$data = '//' . ltrim($data, ':/');
1798
+					if (empty($scheme)) {
1799
+											$data = '//' . ltrim($data, ':/');
1800
+					}
1720 1801
 				},
1721 1802
 				'disallow_children' => array('email', 'ftp', 'url', 'iurl'),
1722 1803
 				'disabled_after' => ' ($1)',
@@ -1736,8 +1817,9 @@  discard block
 block discarded – undo
1736 1817
 		// This is mainly for the bbc manager, so it's easy to add tags above.  Custom BBC should be added above this line.
1737 1818
 		if ($message === false)
1738 1819
 		{
1739
-			if (isset($temp_bbc))
1740
-				$bbc_codes = $temp_bbc;
1820
+			if (isset($temp_bbc)) {
1821
+							$bbc_codes = $temp_bbc;
1822
+			}
1741 1823
 			usort($codes, function ($a, $b) {
1742 1824
 				return strcmp($a['tag'], $b['tag']);
1743 1825
 			});
@@ -1757,8 +1839,9 @@  discard block
 block discarded – undo
1757 1839
 		);
1758 1840
 		if (!isset($disabled['li']) && !isset($disabled['list']))
1759 1841
 		{
1760
-			foreach ($itemcodes as $c => $dummy)
1761
-				$bbc_codes[$c] = array();
1842
+			foreach ($itemcodes as $c => $dummy) {
1843
+							$bbc_codes[$c] = array();
1844
+			}
1762 1845
 		}
1763 1846
 
1764 1847
 		// Shhhh!
@@ -1779,12 +1862,14 @@  discard block
 block discarded – undo
1779 1862
 		foreach ($codes as $code)
1780 1863
 		{
1781 1864
 			// Make it easier to process parameters later
1782
-			if (!empty($code['parameters']))
1783
-				ksort($code['parameters'], SORT_STRING);
1865
+			if (!empty($code['parameters'])) {
1866
+							ksort($code['parameters'], SORT_STRING);
1867
+			}
1784 1868
 
1785 1869
 			// If we are not doing every tag only do ones we are interested in.
1786
-			if (empty($parse_tags) || in_array($code['tag'], $parse_tags))
1787
-				$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1870
+			if (empty($parse_tags) || in_array($code['tag'], $parse_tags)) {
1871
+							$bbc_codes[substr($code['tag'], 0, 1)][] = $code;
1872
+			}
1788 1873
 		}
1789 1874
 		$codes = null;
1790 1875
 	}
@@ -1795,8 +1880,9 @@  discard block
 block discarded – undo
1795 1880
 		// It's likely this will change if the message is modified.
1796 1881
 		$cache_key = 'parse:' . $cache_id . '-' . md5(md5($message) . '-' . $smileys . (empty($disabled) ? '' : implode(',', array_keys($disabled))) . $smcFunc['json_encode']($context['browser']) . $txt['lang_locale'] . $user_info['time_offset'] . $user_info['time_format']);
1797 1882
 
1798
-		if (($temp = cache_get_data($cache_key, 240)) != null)
1799
-			return $temp;
1883
+		if (($temp = cache_get_data($cache_key, 240)) != null) {
1884
+					return $temp;
1885
+		}
1800 1886
 
1801 1887
 		$cache_t = microtime();
1802 1888
 	}
@@ -1828,8 +1914,9 @@  discard block
 block discarded – undo
1828 1914
 		$disabled['flash'] = true;
1829 1915
 
1830 1916
 		// @todo Change maybe?
1831
-		if (!isset($_GET['images']))
1832
-			$disabled['img'] = true;
1917
+		if (!isset($_GET['images'])) {
1918
+					$disabled['img'] = true;
1919
+		}
1833 1920
 
1834 1921
 		// @todo Interface/setting to add more?
1835 1922
 	}
@@ -1853,8 +1940,9 @@  discard block
 block discarded – undo
1853 1940
 		$pos = isset($matches[0][1]) ? $matches[0][1] : false;
1854 1941
 
1855 1942
 		// Failsafe.
1856
-		if ($pos === false || $last_pos > $pos)
1857
-			$pos = strlen($message) + 1;
1943
+		if ($pos === false || $last_pos > $pos) {
1944
+					$pos = strlen($message) + 1;
1945
+		}
1858 1946
 
1859 1947
 		// Can't have a one letter smiley, URL, or email! (sorry.)
1860 1948
 		if ($last_pos < $pos - 1)
@@ -1872,8 +1960,9 @@  discard block
 block discarded – undo
1872 1960
 
1873 1961
 				// <br> should be empty.
1874 1962
 				$empty_tags = array('br', 'hr');
1875
-				foreach ($empty_tags as $tag)
1876
-					$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '<' . $tag . '>', $data);
1963
+				foreach ($empty_tags as $tag) {
1964
+									$data = str_replace(array('&lt;' . $tag . '&gt;', '&lt;' . $tag . '/&gt;', '&lt;' . $tag . ' /&gt;'), '<' . $tag . '>', $data);
1965
+				}
1877 1966
 
1878 1967
 				// b, u, i, s, pre... basic tags.
1879 1968
 				$closable_tags = array('b', 'u', 'i', 's', 'em', 'ins', 'del', 'pre', 'blockquote', 'strong');
@@ -1882,8 +1971,9 @@  discard block
 block discarded – undo
1882 1971
 					$diff = substr_count($data, '&lt;' . $tag . '&gt;') - substr_count($data, '&lt;/' . $tag . '&gt;');
1883 1972
 					$data = strtr($data, array('&lt;' . $tag . '&gt;' => '<' . $tag . '>', '&lt;/' . $tag . '&gt;' => '</' . $tag . '>'));
1884 1973
 
1885
-					if ($diff > 0)
1886
-						$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1974
+					if ($diff > 0) {
1975
+											$data = substr($data, 0, -1) . str_repeat('</' . $tag . '>', $diff) . substr($data, -1);
1976
+					}
1887 1977
 				}
1888 1978
 
1889 1979
 				// Do <img ...> - with security... action= -> action-.
@@ -1896,8 +1986,9 @@  discard block
 block discarded – undo
1896 1986
 						$alt = empty($matches[3][$match]) ? '' : ' alt=' . preg_replace('~^&quot;|&quot;$~', '', $matches[3][$match]);
1897 1987
 
1898 1988
 						// Remove action= from the URL - no funny business, now.
1899
-						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0)
1900
-							$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1989
+						if (preg_match('~action(=|%3d)(?!dlattach)~i', $imgtag) != 0) {
1990
+													$imgtag = preg_replace('~action(?:=|%3d)(?!dlattach)~i', 'action-', $imgtag);
1991
+						}
1901 1992
 
1902 1993
 						// Check if the image is larger than allowed.
1903 1994
 						if (!empty($modSettings['max_image_width']) && !empty($modSettings['max_image_height']))
@@ -1918,9 +2009,9 @@  discard block
 block discarded – undo
1918 2009
 
1919 2010
 							// Set the new image tag.
1920 2011
 							$replaces[$matches[0][$match]] = '[img width=' . $width . ' height=' . $height . $alt . ']' . $imgtag . '[/img]';
2012
+						} else {
2013
+													$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1921 2014
 						}
1922
-						else
1923
-							$replaces[$matches[0][$match]] = '[img' . $alt . ']' . $imgtag . '[/img]';
1924 2015
 					}
1925 2016
 
1926 2017
 					$data = strtr($data, $replaces);
@@ -1933,16 +2024,18 @@  discard block
 block discarded – undo
1933 2024
 				$no_autolink_area = false;
1934 2025
 				if (!empty($open_tags))
1935 2026
 				{
1936
-					foreach ($open_tags as $open_tag)
1937
-						if (in_array($open_tag['tag'], $no_autolink_tags))
2027
+					foreach ($open_tags as $open_tag) {
2028
+											if (in_array($open_tag['tag'], $no_autolink_tags))
1938 2029
 							$no_autolink_area = true;
2030
+					}
1939 2031
 				}
1940 2032
 
1941 2033
 				// Don't go backwards.
1942 2034
 				// @todo Don't think is the real solution....
1943 2035
 				$lastAutoPos = isset($lastAutoPos) ? $lastAutoPos : 0;
1944
-				if ($pos < $lastAutoPos)
1945
-					$no_autolink_area = true;
2036
+				if ($pos < $lastAutoPos) {
2037
+									$no_autolink_area = true;
2038
+				}
1946 2039
 				$lastAutoPos = $pos;
1947 2040
 
1948 2041
 				if (!$no_autolink_area)
@@ -2051,17 +2144,19 @@  discard block
 block discarded – undo
2051 2144
 							if ($scheme == 'mailto')
2052 2145
 							{
2053 2146
 								$email_address = str_replace('mailto:', '', $url);
2054
-								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false)
2055
-									return '[email=' . $email_address . ']' . $url . '[/email]';
2056
-								else
2057
-									return $url;
2147
+								if (!isset($disabled['email']) && filter_var($email_address, FILTER_VALIDATE_EMAIL) !== false) {
2148
+																	return '[email=' . $email_address . ']' . $url . '[/email]';
2149
+								} else {
2150
+																	return $url;
2151
+								}
2058 2152
 							}
2059 2153
 
2060 2154
 							// Are we linking a schemeless URL or naked domain name (e.g. "example.com")?
2061
-							if (empty($scheme))
2062
-								$fullUrl = '//' . ltrim($url, ':/');
2063
-							else
2064
-								$fullUrl = $url;
2155
+							if (empty($scheme)) {
2156
+															$fullUrl = '//' . ltrim($url, ':/');
2157
+							} else {
2158
+															$fullUrl = $url;
2159
+							}
2065 2160
 
2066 2161
 							return '[url=&quot;' . str_replace(array('[', ']'), array('&#91;', '&#93;'), $fullUrl) . '&quot;]' . $url . '[/url]';
2067 2162
 						}, $data);
@@ -2110,16 +2205,18 @@  discard block
 block discarded – undo
2110 2205
 		}
2111 2206
 
2112 2207
 		// Are we there yet?  Are we there yet?
2113
-		if ($pos >= strlen($message) - 1)
2114
-			break;
2208
+		if ($pos >= strlen($message) - 1) {
2209
+					break;
2210
+		}
2115 2211
 
2116 2212
 		$tags = strtolower($message[$pos + 1]);
2117 2213
 
2118 2214
 		if ($tags == '/' && !empty($open_tags))
2119 2215
 		{
2120 2216
 			$pos2 = strpos($message, ']', $pos + 1);
2121
-			if ($pos2 == $pos + 2)
2122
-				continue;
2217
+			if ($pos2 == $pos + 2) {
2218
+							continue;
2219
+			}
2123 2220
 
2124 2221
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
2125 2222
 
@@ -2129,8 +2226,9 @@  discard block
 block discarded – undo
2129 2226
 			do
2130 2227
 			{
2131 2228
 				$tag = array_pop($open_tags);
2132
-				if (!$tag)
2133
-					break;
2229
+				if (!$tag) {
2230
+									break;
2231
+				}
2134 2232
 
2135 2233
 				if (!empty($tag['block_level']))
2136 2234
 				{
@@ -2144,10 +2242,11 @@  discard block
 block discarded – undo
2144 2242
 					// The idea is, if we are LOOKING for a block level tag, we can close them on the way.
2145 2243
 					if (strlen($look_for) > 0 && isset($bbc_codes[$look_for[0]]))
2146 2244
 					{
2147
-						foreach ($bbc_codes[$look_for[0]] as $temp)
2148
-							if ($temp['tag'] == $look_for)
2245
+						foreach ($bbc_codes[$look_for[0]] as $temp) {
2246
+													if ($temp['tag'] == $look_for)
2149 2247
 							{
2150 2248
 								$block_level = !empty($temp['block_level']);
2249
+						}
2151 2250
 								break;
2152 2251
 							}
2153 2252
 					}
@@ -2169,15 +2268,15 @@  discard block
 block discarded – undo
2169 2268
 			{
2170 2269
 				$open_tags = $to_close;
2171 2270
 				continue;
2172
-			}
2173
-			elseif (!empty($to_close) && $tag['tag'] != $look_for)
2271
+			} elseif (!empty($to_close) && $tag['tag'] != $look_for)
2174 2272
 			{
2175 2273
 				if ($block_level === null && isset($look_for[0], $bbc_codes[$look_for[0]]))
2176 2274
 				{
2177
-					foreach ($bbc_codes[$look_for[0]] as $temp)
2178
-						if ($temp['tag'] == $look_for)
2275
+					foreach ($bbc_codes[$look_for[0]] as $temp) {
2276
+											if ($temp['tag'] == $look_for)
2179 2277
 						{
2180 2278
 							$block_level = !empty($temp['block_level']);
2279
+					}
2181 2280
 							break;
2182 2281
 						}
2183 2282
 				}
@@ -2185,8 +2284,9 @@  discard block
 block discarded – undo
2185 2284
 				// We're not looking for a block level tag (or maybe even a tag that exists...)
2186 2285
 				if (!$block_level)
2187 2286
 				{
2188
-					foreach ($to_close as $tag)
2189
-						array_push($open_tags, $tag);
2287
+					foreach ($to_close as $tag) {
2288
+											array_push($open_tags, $tag);
2289
+					}
2190 2290
 					continue;
2191 2291
 				}
2192 2292
 			}
@@ -2199,14 +2299,17 @@  discard block
 block discarded – undo
2199 2299
 
2200 2300
 				// See the comment at the end of the big loop - just eating whitespace ;).
2201 2301
 				$whitespace_regex = '';
2202
-				if (!empty($tag['block_level']))
2203
-					$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2302
+				if (!empty($tag['block_level'])) {
2303
+									$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2304
+				}
2204 2305
 				// Trim one line of whitespace after unnested tags, but all of it after nested ones
2205
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2206
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2306
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2307
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2308
+				}
2207 2309
 
2208
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2209
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2310
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2311
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2312
+				}
2210 2313
 			}
2211 2314
 
2212 2315
 			if (!empty($to_close))
@@ -2219,8 +2322,9 @@  discard block
 block discarded – undo
2219 2322
 		}
2220 2323
 
2221 2324
 		// No tags for this character, so just keep going (fastest possible course.)
2222
-		if (!isset($bbc_codes[$tags]))
2223
-			continue;
2325
+		if (!isset($bbc_codes[$tags])) {
2326
+					continue;
2327
+		}
2224 2328
 
2225 2329
 		$inside = empty($open_tags) ? null : $open_tags[count($open_tags) - 1];
2226 2330
 		$tag = null;
@@ -2229,44 +2333,52 @@  discard block
 block discarded – undo
2229 2333
 			$pt_strlen = strlen($possible['tag']);
2230 2334
 
2231 2335
 			// Not a match?
2232
-			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag'])
2233
-				continue;
2336
+			if (strtolower(substr($message, $pos + 1, $pt_strlen)) != $possible['tag']) {
2337
+							continue;
2338
+			}
2234 2339
 
2235 2340
 			$next_c = $message[$pos + 1 + $pt_strlen];
2236 2341
 
2237 2342
 			// A test validation?
2238
-			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0)
2239
-				continue;
2343
+			if (isset($possible['test']) && preg_match('~^' . $possible['test'] . '~', substr($message, $pos + 1 + $pt_strlen + 1)) === 0) {
2344
+							continue;
2345
+			}
2240 2346
 			// Do we want parameters?
2241 2347
 			elseif (!empty($possible['parameters']))
2242 2348
 			{
2243
-				if ($next_c != ' ')
2244
-					continue;
2245
-			}
2246
-			elseif (isset($possible['type']))
2349
+				if ($next_c != ' ') {
2350
+									continue;
2351
+				}
2352
+			} elseif (isset($possible['type']))
2247 2353
 			{
2248 2354
 				// Do we need an equal sign?
2249
-				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=')
2250
-					continue;
2355
+				if (in_array($possible['type'], array('unparsed_equals', 'unparsed_commas', 'unparsed_commas_content', 'unparsed_equals_content', 'parsed_equals')) && $next_c != '=') {
2356
+									continue;
2357
+				}
2251 2358
 				// Maybe we just want a /...
2252
-				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]')
2253
-					continue;
2359
+				if ($possible['type'] == 'closed' && $next_c != ']' && substr($message, $pos + 1 + $pt_strlen, 2) != '/]' && substr($message, $pos + 1 + $pt_strlen, 3) != ' /]') {
2360
+									continue;
2361
+				}
2254 2362
 				// An immediate ]?
2255
-				if ($possible['type'] == 'unparsed_content' && $next_c != ']')
2256
-					continue;
2363
+				if ($possible['type'] == 'unparsed_content' && $next_c != ']') {
2364
+									continue;
2365
+				}
2257 2366
 			}
2258 2367
 			// No type means 'parsed_content', which demands an immediate ] without parameters!
2259
-			elseif ($next_c != ']')
2260
-				continue;
2368
+			elseif ($next_c != ']') {
2369
+							continue;
2370
+			}
2261 2371
 
2262 2372
 			// Check allowed tree?
2263
-			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents'])))
2264
-				continue;
2265
-			elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children']))
2266
-				continue;
2373
+			if (isset($possible['require_parents']) && ($inside === null || !in_array($inside['tag'], $possible['require_parents']))) {
2374
+							continue;
2375
+			} elseif (isset($inside['require_children']) && !in_array($possible['tag'], $inside['require_children'])) {
2376
+							continue;
2377
+			}
2267 2378
 			// If this is in the list of disallowed child tags, don't parse it.
2268
-			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children']))
2269
-				continue;
2379
+			elseif (isset($inside['disallow_children']) && in_array($possible['tag'], $inside['disallow_children'])) {
2380
+							continue;
2381
+			}
2270 2382
 
2271 2383
 			$pos1 = $pos + 1 + $pt_strlen + 1;
2272 2384
 
@@ -2278,8 +2390,9 @@  discard block
 block discarded – undo
2278 2390
 				foreach ($open_tags as $open_quote)
2279 2391
 				{
2280 2392
 					// Every parent quote this quote has flips the styling
2281
-					if ($open_quote['tag'] == 'quote')
2282
-						$quote_alt = !$quote_alt;
2393
+					if ($open_quote['tag'] == 'quote') {
2394
+											$quote_alt = !$quote_alt;
2395
+					}
2283 2396
 				}
2284 2397
 				// Add a class to the quote to style alternating blockquotes
2285 2398
 				$possible['before'] = strtr($possible['before'], array('<blockquote>' => '<blockquote class="bbc_' . ($quote_alt ? 'alternate' : 'standard') . '_quote">'));
@@ -2290,8 +2403,9 @@  discard block
 block discarded – undo
2290 2403
 			{
2291 2404
 				// Build a regular expression for each parameter for the current tag.
2292 2405
 				$preg = array();
2293
-				foreach ($possible['parameters'] as $p => $info)
2294
-					$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2406
+				foreach ($possible['parameters'] as $p => $info) {
2407
+									$preg[] = '(\s+' . $p . '=' . (empty($info['quoted']) ? '' : '&quot;') . (isset($info['match']) ? $info['match'] : '(.+?)') . (empty($info['quoted']) ? '' : '&quot;') . '\s*)' . (empty($info['optional']) ? '' : '?');
2408
+				}
2295 2409
 
2296 2410
 				// Extract the string that potentially holds our parameters.
2297 2411
 				$blob = preg_split('~\[/?(?:' . $alltags_regex . ')~i', substr($message, $pos));
@@ -2311,24 +2425,27 @@  discard block
 block discarded – undo
2311 2425
 
2312 2426
 					$match = preg_match('~^' . implode('', $preg) . '$~i', implode(' ', $given_params), $matches) !== 0;
2313 2427
 
2314
-					if ($match)
2315
-						$blob_counter = count($blobs) + 1;
2428
+					if ($match) {
2429
+											$blob_counter = count($blobs) + 1;
2430
+					}
2316 2431
 				}
2317 2432
 
2318 2433
 				// Didn't match our parameter list, try the next possible.
2319
-				if (!$match)
2320
-					continue;
2434
+				if (!$match) {
2435
+									continue;
2436
+				}
2321 2437
 
2322 2438
 				$params = array();
2323 2439
 				for ($i = 1, $n = count($matches); $i < $n; $i += 2)
2324 2440
 				{
2325 2441
 					$key = strtok(ltrim($matches[$i]), '=');
2326
-					if (isset($possible['parameters'][$key]['value']))
2327
-						$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2328
-					elseif (isset($possible['parameters'][$key]['validate']))
2329
-						$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2330
-					else
2331
-						$params['{' . $key . '}'] = $matches[$i + 1];
2442
+					if (isset($possible['parameters'][$key]['value'])) {
2443
+											$params['{' . $key . '}'] = strtr($possible['parameters'][$key]['value'], array('$1' => $matches[$i + 1]));
2444
+					} elseif (isset($possible['parameters'][$key]['validate'])) {
2445
+											$params['{' . $key . '}'] = $possible['parameters'][$key]['validate']($matches[$i + 1]);
2446
+					} else {
2447
+											$params['{' . $key . '}'] = $matches[$i + 1];
2448
+					}
2332 2449
 
2333 2450
 					// Just to make sure: replace any $ or { so they can't interpolate wrongly.
2334 2451
 					$params['{' . $key . '}'] = strtr($params['{' . $key . '}'], array('$' => '&#036;', '{' => '&#123;'));
@@ -2336,23 +2453,26 @@  discard block
 block discarded – undo
2336 2453
 
2337 2454
 				foreach ($possible['parameters'] as $p => $info)
2338 2455
 				{
2339
-					if (!isset($params['{' . $p . '}']))
2340
-						$params['{' . $p . '}'] = '';
2456
+					if (!isset($params['{' . $p . '}'])) {
2457
+											$params['{' . $p . '}'] = '';
2458
+					}
2341 2459
 				}
2342 2460
 
2343 2461
 				$tag = $possible;
2344 2462
 
2345 2463
 				// Put the parameters into the string.
2346
-				if (isset($tag['before']))
2347
-					$tag['before'] = strtr($tag['before'], $params);
2348
-				if (isset($tag['after']))
2349
-					$tag['after'] = strtr($tag['after'], $params);
2350
-				if (isset($tag['content']))
2351
-					$tag['content'] = strtr($tag['content'], $params);
2464
+				if (isset($tag['before'])) {
2465
+									$tag['before'] = strtr($tag['before'], $params);
2466
+				}
2467
+				if (isset($tag['after'])) {
2468
+									$tag['after'] = strtr($tag['after'], $params);
2469
+				}
2470
+				if (isset($tag['content'])) {
2471
+									$tag['content'] = strtr($tag['content'], $params);
2472
+				}
2352 2473
 
2353 2474
 				$pos1 += strlen($given_param_string);
2354
-			}
2355
-			else
2475
+			} else
2356 2476
 			{
2357 2477
 				$tag = $possible;
2358 2478
 				$params = array();
@@ -2363,8 +2483,9 @@  discard block
 block discarded – undo
2363 2483
 		// Item codes are complicated buggers... they are implicit [li]s and can make [list]s!
2364 2484
 		if ($smileys !== false && $tag === null && isset($itemcodes[$message[$pos + 1]]) && $message[$pos + 2] == ']' && !isset($disabled['list']) && !isset($disabled['li']))
2365 2485
 		{
2366
-			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>')))
2367
-				continue;
2486
+			if ($message[$pos + 1] == '0' && !in_array($message[$pos - 1], array(';', ' ', "\t", "\n", '>'))) {
2487
+							continue;
2488
+			}
2368 2489
 
2369 2490
 			$tag = $itemcodes[$message[$pos + 1]];
2370 2491
 
@@ -2385,9 +2506,9 @@  discard block
 block discarded – undo
2385 2506
 			{
2386 2507
 				array_pop($open_tags);
2387 2508
 				$code = '</li>';
2509
+			} else {
2510
+							$code = '';
2388 2511
 			}
2389
-			else
2390
-				$code = '';
2391 2512
 
2392 2513
 			// Now we open a new tag.
2393 2514
 			$open_tags[] = array(
@@ -2434,12 +2555,14 @@  discard block
 block discarded – undo
2434 2555
 		}
2435 2556
 
2436 2557
 		// No tag?  Keep looking, then.  Silly people using brackets without actual tags.
2437
-		if ($tag === null)
2438
-			continue;
2558
+		if ($tag === null) {
2559
+					continue;
2560
+		}
2439 2561
 
2440 2562
 		// Propagate the list to the child (so wrapping the disallowed tag won't work either.)
2441
-		if (isset($inside['disallow_children']))
2442
-			$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2563
+		if (isset($inside['disallow_children'])) {
2564
+					$tag['disallow_children'] = isset($tag['disallow_children']) ? array_unique(array_merge($tag['disallow_children'], $inside['disallow_children'])) : $inside['disallow_children'];
2565
+		}
2443 2566
 
2444 2567
 		// Is this tag disabled?
2445 2568
 		if (isset($disabled[$tag['tag']]))
@@ -2449,14 +2572,13 @@  discard block
 block discarded – undo
2449 2572
 				$tag['before'] = !empty($tag['block_level']) ? '<div>' : '';
2450 2573
 				$tag['after'] = !empty($tag['block_level']) ? '</div>' : '';
2451 2574
 				$tag['content'] = isset($tag['type']) && $tag['type'] == 'closed' ? '' : (!empty($tag['block_level']) ? '<div>$1</div>' : '$1');
2452
-			}
2453
-			elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2575
+			} elseif (isset($tag['disabled_before']) || isset($tag['disabled_after']))
2454 2576
 			{
2455 2577
 				$tag['before'] = isset($tag['disabled_before']) ? $tag['disabled_before'] : (!empty($tag['block_level']) ? '<div>' : '');
2456 2578
 				$tag['after'] = isset($tag['disabled_after']) ? $tag['disabled_after'] : (!empty($tag['block_level']) ? '</div>' : '');
2579
+			} else {
2580
+							$tag['content'] = $tag['disabled_content'];
2457 2581
 			}
2458
-			else
2459
-				$tag['content'] = $tag['disabled_content'];
2460 2582
 		}
2461 2583
 
2462 2584
 		// we use this a lot
@@ -2466,8 +2588,9 @@  discard block
 block discarded – undo
2466 2588
 		if (!empty($tag['block_level']) && $tag['tag'] != 'html' && empty($inside['block_level']))
2467 2589
 		{
2468 2590
 			$n = count($open_tags) - 1;
2469
-			while (empty($open_tags[$n]['block_level']) && $n >= 0)
2470
-				$n--;
2591
+			while (empty($open_tags[$n]['block_level']) && $n >= 0) {
2592
+							$n--;
2593
+			}
2471 2594
 
2472 2595
 			// Close all the non block level tags so this tag isn't surrounded by them.
2473 2596
 			for ($i = count($open_tags) - 1; $i > $n; $i--)
@@ -2479,12 +2602,15 @@  discard block
 block discarded – undo
2479 2602
 
2480 2603
 				// Trim or eat trailing stuff... see comment at the end of the big loop.
2481 2604
 				$whitespace_regex = '';
2482
-				if (!empty($tag['block_level']))
2483
-					$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2484
-				if (!empty($tag['trim']) && $tag['trim'] != 'inside')
2485
-					$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2486
-				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0)
2487
-					$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2605
+				if (!empty($tag['block_level'])) {
2606
+									$whitespace_regex .= '(&nbsp;|\s)*(<br>)?';
2607
+				}
2608
+				if (!empty($tag['trim']) && $tag['trim'] != 'inside') {
2609
+									$whitespace_regex .= empty($tag['require_parents']) ? '(&nbsp;|\s)*' : '(<br>|&nbsp;|\s)*';
2610
+				}
2611
+				if (!empty($whitespace_regex) && preg_match('~' . $whitespace_regex . '~', substr($message, $pos), $matches) != 0) {
2612
+									$message = substr($message, 0, $pos) . substr($message, $pos + strlen($matches[0]));
2613
+				}
2488 2614
 
2489 2615
 				array_pop($open_tags);
2490 2616
 			}
@@ -2502,16 +2628,19 @@  discard block
 block discarded – undo
2502 2628
 		elseif ($tag['type'] == 'unparsed_content')
2503 2629
 		{
2504 2630
 			$pos2 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos1);
2505
-			if ($pos2 === false)
2506
-				continue;
2631
+			if ($pos2 === false) {
2632
+							continue;
2633
+			}
2507 2634
 
2508 2635
 			$data = substr($message, $pos1, $pos2 - $pos1);
2509 2636
 
2510
-			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>')
2511
-				$data = substr($data, 4);
2637
+			if (!empty($tag['block_level']) && substr($data, 0, 4) == '<br>') {
2638
+							$data = substr($data, 4);
2639
+			}
2512 2640
 
2513
-			if (isset($tag['validate']))
2514
-				$tag['validate']($tag, $data, $disabled, $params);
2641
+			if (isset($tag['validate'])) {
2642
+							$tag['validate']($tag, $data, $disabled, $params);
2643
+			}
2515 2644
 
2516 2645
 			$code = strtr($tag['content'], array('$1' => $data));
2517 2646
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 3 + $tag_strlen);
@@ -2527,34 +2656,40 @@  discard block
 block discarded – undo
2527 2656
 			if (isset($tag['quoted']))
2528 2657
 			{
2529 2658
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2530
-				if ($tag['quoted'] != 'optional' && !$quoted)
2531
-					continue;
2659
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2660
+									continue;
2661
+				}
2532 2662
 
2533
-				if ($quoted)
2534
-					$pos1 += 6;
2663
+				if ($quoted) {
2664
+									$pos1 += 6;
2665
+				}
2666
+			} else {
2667
+							$quoted = false;
2535 2668
 			}
2536
-			else
2537
-				$quoted = false;
2538 2669
 
2539 2670
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2540
-			if ($pos2 === false)
2541
-				continue;
2671
+			if ($pos2 === false) {
2672
+							continue;
2673
+			}
2542 2674
 
2543 2675
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2544
-			if ($pos3 === false)
2545
-				continue;
2676
+			if ($pos3 === false) {
2677
+							continue;
2678
+			}
2546 2679
 
2547 2680
 			$data = array(
2548 2681
 				substr($message, $pos2 + ($quoted == false ? 1 : 7), $pos3 - ($pos2 + ($quoted == false ? 1 : 7))),
2549 2682
 				substr($message, $pos1, $pos2 - $pos1)
2550 2683
 			);
2551 2684
 
2552
-			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>')
2553
-				$data[0] = substr($data[0], 4);
2685
+			if (!empty($tag['block_level']) && substr($data[0], 0, 4) == '<br>') {
2686
+							$data[0] = substr($data[0], 4);
2687
+			}
2554 2688
 
2555 2689
 			// Validation for my parking, please!
2556
-			if (isset($tag['validate']))
2557
-				$tag['validate']($tag, $data, $disabled, $params);
2690
+			if (isset($tag['validate'])) {
2691
+							$tag['validate']($tag, $data, $disabled, $params);
2692
+			}
2558 2693
 
2559 2694
 			$code = strtr($tag['content'], array('$1' => $data[0], '$2' => $data[1]));
2560 2695
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
@@ -2571,23 +2706,27 @@  discard block
 block discarded – undo
2571 2706
 		elseif ($tag['type'] == 'unparsed_commas_content')
2572 2707
 		{
2573 2708
 			$pos2 = strpos($message, ']', $pos1);
2574
-			if ($pos2 === false)
2575
-				continue;
2709
+			if ($pos2 === false) {
2710
+							continue;
2711
+			}
2576 2712
 
2577 2713
 			$pos3 = stripos($message, '[/' . substr($message, $pos + 1, $tag_strlen) . ']', $pos2);
2578
-			if ($pos3 === false)
2579
-				continue;
2714
+			if ($pos3 === false) {
2715
+							continue;
2716
+			}
2580 2717
 
2581 2718
 			// We want $1 to be the content, and the rest to be csv.
2582 2719
 			$data = explode(',', ',' . substr($message, $pos1, $pos2 - $pos1));
2583 2720
 			$data[0] = substr($message, $pos2 + 1, $pos3 - $pos2 - 1);
2584 2721
 
2585
-			if (isset($tag['validate']))
2586
-				$tag['validate']($tag, $data, $disabled, $params);
2722
+			if (isset($tag['validate'])) {
2723
+							$tag['validate']($tag, $data, $disabled, $params);
2724
+			}
2587 2725
 
2588 2726
 			$code = $tag['content'];
2589
-			foreach ($data as $k => $d)
2590
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2727
+			foreach ($data as $k => $d) {
2728
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2729
+			}
2591 2730
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos3 + 3 + $tag_strlen);
2592 2731
 			$pos += strlen($code) - 1 + 2;
2593 2732
 		}
@@ -2595,24 +2734,28 @@  discard block
 block discarded – undo
2595 2734
 		elseif ($tag['type'] == 'unparsed_commas')
2596 2735
 		{
2597 2736
 			$pos2 = strpos($message, ']', $pos1);
2598
-			if ($pos2 === false)
2599
-				continue;
2737
+			if ($pos2 === false) {
2738
+							continue;
2739
+			}
2600 2740
 
2601 2741
 			$data = explode(',', substr($message, $pos1, $pos2 - $pos1));
2602 2742
 
2603
-			if (isset($tag['validate']))
2604
-				$tag['validate']($tag, $data, $disabled, $params);
2743
+			if (isset($tag['validate'])) {
2744
+							$tag['validate']($tag, $data, $disabled, $params);
2745
+			}
2605 2746
 
2606 2747
 			// Fix after, for disabled code mainly.
2607
-			foreach ($data as $k => $d)
2608
-				$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2748
+			foreach ($data as $k => $d) {
2749
+							$tag['after'] = strtr($tag['after'], array('$' . ($k + 1) => trim($d)));
2750
+			}
2609 2751
 
2610 2752
 			$open_tags[] = $tag;
2611 2753
 
2612 2754
 			// Replace them out, $1, $2, $3, $4, etc.
2613 2755
 			$code = $tag['before'];
2614
-			foreach ($data as $k => $d)
2615
-				$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2756
+			foreach ($data as $k => $d) {
2757
+							$code = strtr($code, array('$' . ($k + 1) => trim($d)));
2758
+			}
2616 2759
 			$message = substr($message, 0, $pos) . "\n" . $code . "\n" . substr($message, $pos2 + 1);
2617 2760
 			$pos += strlen($code) - 1 + 2;
2618 2761
 		}
@@ -2623,28 +2766,33 @@  discard block
 block discarded – undo
2623 2766
 			if (isset($tag['quoted']))
2624 2767
 			{
2625 2768
 				$quoted = substr($message, $pos1, 6) == '&quot;';
2626
-				if ($tag['quoted'] != 'optional' && !$quoted)
2627
-					continue;
2769
+				if ($tag['quoted'] != 'optional' && !$quoted) {
2770
+									continue;
2771
+				}
2628 2772
 
2629
-				if ($quoted)
2630
-					$pos1 += 6;
2773
+				if ($quoted) {
2774
+									$pos1 += 6;
2775
+				}
2776
+			} else {
2777
+							$quoted = false;
2631 2778
 			}
2632
-			else
2633
-				$quoted = false;
2634 2779
 
2635 2780
 			$pos2 = strpos($message, $quoted == false ? ']' : '&quot;]', $pos1);
2636
-			if ($pos2 === false)
2637
-				continue;
2781
+			if ($pos2 === false) {
2782
+							continue;
2783
+			}
2638 2784
 
2639 2785
 			$data = substr($message, $pos1, $pos2 - $pos1);
2640 2786
 
2641 2787
 			// Validation for my parking, please!
2642
-			if (isset($tag['validate']))
2643
-				$tag['validate']($tag, $data, $disabled, $params);
2788
+			if (isset($tag['validate'])) {
2789
+							$tag['validate']($tag, $data, $disabled, $params);
2790
+			}
2644 2791
 
2645 2792
 			// For parsed content, we must recurse to avoid security problems.
2646
-			if ($tag['type'] != 'unparsed_equals')
2647
-				$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2793
+			if ($tag['type'] != 'unparsed_equals') {
2794
+							$data = parse_bbc($data, !empty($tag['parsed_tags_allowed']) ? false : true, '', !empty($tag['parsed_tags_allowed']) ? $tag['parsed_tags_allowed'] : array());
2795
+			}
2648 2796
 
2649 2797
 			$tag['after'] = strtr($tag['after'], array('$1' => $data));
2650 2798
 
@@ -2656,34 +2804,40 @@  discard block
 block discarded – undo
2656 2804
 		}
2657 2805
 
2658 2806
 		// If this is block level, eat any breaks after it.
2659
-		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>')
2660
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2807
+		if (!empty($tag['block_level']) && substr($message, $pos + 1, 4) == '<br>') {
2808
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 5);
2809
+		}
2661 2810
 
2662 2811
 		// Are we trimming outside this tag?
2663
-		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0)
2664
-			$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2812
+		if (!empty($tag['trim']) && $tag['trim'] != 'outside' && preg_match('~(<br>|&nbsp;|\s)*~', substr($message, $pos + 1), $matches) != 0) {
2813
+					$message = substr($message, 0, $pos + 1) . substr($message, $pos + 1 + strlen($matches[0]));
2814
+		}
2665 2815
 	}
2666 2816
 
2667 2817
 	// Close any remaining tags.
2668
-	while ($tag = array_pop($open_tags))
2669
-		$message .= "\n" . $tag['after'] . "\n";
2818
+	while ($tag = array_pop($open_tags)) {
2819
+			$message .= "\n" . $tag['after'] . "\n";
2820
+	}
2670 2821
 
2671 2822
 	// Parse the smileys within the parts where it can be done safely.
2672 2823
 	if ($smileys === true)
2673 2824
 	{
2674 2825
 		$message_parts = explode("\n", $message);
2675
-		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2)
2676
-			parsesmileys($message_parts[$i]);
2826
+		for ($i = 0, $n = count($message_parts); $i < $n; $i += 2) {
2827
+					parsesmileys($message_parts[$i]);
2828
+		}
2677 2829
 
2678 2830
 		$message = implode('', $message_parts);
2679 2831
 	}
2680 2832
 
2681 2833
 	// No smileys, just get rid of the markers.
2682
-	else
2683
-		$message = strtr($message, array("\n" => ''));
2834
+	else {
2835
+			$message = strtr($message, array("\n" => ''));
2836
+	}
2684 2837
 
2685
-	if ($message !== '' && $message[0] === ' ')
2686
-		$message = '&nbsp;' . substr($message, 1);
2838
+	if ($message !== '' && $message[0] === ' ') {
2839
+			$message = '&nbsp;' . substr($message, 1);
2840
+	}
2687 2841
 
2688 2842
 	// Cleanup whitespace.
2689 2843
 	$message = strtr($message, array('  ' => ' &nbsp;', "\r" => '', "\n" => '<br>', '<br> ' => '<br>&nbsp;', '&#13;' => "\n"));
@@ -2692,15 +2846,16 @@  discard block
 block discarded – undo
2692 2846
 	call_integration_hook('integrate_post_parsebbc', array(&$message, &$smileys, &$cache_id, &$parse_tags));
2693 2847
 
2694 2848
 	// Cache the output if it took some time...
2695
-	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05)
2696
-		cache_put_data($cache_key, $message, 240);
2849
+	if (isset($cache_key, $cache_t) && array_sum(explode(' ', microtime())) - array_sum(explode(' ', $cache_t)) > 0.05) {
2850
+			cache_put_data($cache_key, $message, 240);
2851
+	}
2697 2852
 
2698 2853
 	// If this was a force parse revert if needed.
2699 2854
 	if (!empty($parse_tags))
2700 2855
 	{
2701
-		if (empty($temp_bbc))
2702
-			$bbc_codes = array();
2703
-		else
2856
+		if (empty($temp_bbc)) {
2857
+					$bbc_codes = array();
2858
+		} else
2704 2859
 		{
2705 2860
 			$bbc_codes = $temp_bbc;
2706 2861
 			unset($temp_bbc);
@@ -2727,8 +2882,9 @@  discard block
 block discarded – undo
2727 2882
 	static $smileyPregSearch = null, $smileyPregReplacements = array();
2728 2883
 
2729 2884
 	// No smiley set at all?!
2730
-	if ($user_info['smiley_set'] == 'none' || trim($message) == '')
2731
-		return;
2885
+	if ($user_info['smiley_set'] == 'none' || trim($message) == '') {
2886
+			return;
2887
+	}
2732 2888
 
2733 2889
 	// If smileyPregSearch hasn't been set, do it now.
2734 2890
 	if (empty($smileyPregSearch))
@@ -2739,8 +2895,7 @@  discard block
 block discarded – undo
2739 2895
 			$smileysfrom = array('>:D', ':D', '::)', '>:(', ':))', ':)', ';)', ';D', ':(', ':o', '8)', ':P', '???', ':-[', ':-X', ':-*', ':\'(', ':-\\', '^-^', 'O0', 'C:-)', '0:)');
2740 2896
 			$smileysto = array('evil.gif', 'cheesy.gif', 'rolleyes.gif', 'angry.gif', 'laugh.gif', 'smiley.gif', 'wink.gif', 'grin.gif', 'sad.gif', 'shocked.gif', 'cool.gif', 'tongue.gif', 'huh.gif', 'embarrassed.gif', 'lipsrsealed.gif', 'kiss.gif', 'cry.gif', 'undecided.gif', 'azn.gif', 'afro.gif', 'police.gif', 'angel.gif');
2741 2897
 			$smileysdescs = array('', $txt['icon_cheesy'], $txt['icon_rolleyes'], $txt['icon_angry'], '', $txt['icon_smiley'], $txt['icon_wink'], $txt['icon_grin'], $txt['icon_sad'], $txt['icon_shocked'], $txt['icon_cool'], $txt['icon_tongue'], $txt['icon_huh'], $txt['icon_embarrassed'], $txt['icon_lips'], $txt['icon_kiss'], $txt['icon_cry'], $txt['icon_undecided'], '', '', '', '');
2742
-		}
2743
-		else
2898
+		} else
2744 2899
 		{
2745 2900
 			// Load the smileys in reverse order by length so they don't get parsed wrong.
2746 2901
 			if (($temp = cache_get_data('parsing_smileys', 480)) == null)
@@ -2764,9 +2919,9 @@  discard block
 block discarded – undo
2764 2919
 				$smcFunc['db_free_result']($result);
2765 2920
 
2766 2921
 				cache_put_data('parsing_smileys', array($smileysfrom, $smileysto, $smileysdescs), 480);
2922
+			} else {
2923
+							list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2767 2924
 			}
2768
-			else
2769
-				list ($smileysfrom, $smileysto, $smileysdescs) = $temp;
2770 2925
 		}
2771 2926
 
2772 2927
 		// The non-breaking-space is a complex thing...
@@ -2843,35 +2998,41 @@  discard block
 block discarded – undo
2843 2998
 	global $scripturl, $context, $modSettings, $db_show_debug, $db_cache;
2844 2999
 
2845 3000
 	// In case we have mail to send, better do that - as obExit doesn't always quite make it...
2846
-	if (!empty($context['flush_mail']))
2847
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3001
+	if (!empty($context['flush_mail'])) {
3002
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2848 3003
 		AddMailQueue(true);
3004
+	}
2849 3005
 
2850 3006
 	$add = preg_match('~^(ftp|http)[s]?://~', $setLocation) == 0 && substr($setLocation, 0, 6) != 'about:';
2851 3007
 
2852
-	if ($add)
2853
-		$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
3008
+	if ($add) {
3009
+			$setLocation = $scripturl . ($setLocation != '' ? '?' . $setLocation : '');
3010
+	}
2854 3011
 
2855 3012
 	// Put the session ID in.
2856
-	if (defined('SID') && SID != '')
2857
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
3013
+	if (defined('SID') && SID != '') {
3014
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '(?!\?' . preg_quote(SID, '/') . ')\\??/', $scripturl . '?' . SID . ';', $setLocation);
3015
+	}
2858 3016
 	// Keep that debug in their for template debugging!
2859
-	elseif (isset($_GET['debug']))
2860
-		$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
3017
+	elseif (isset($_GET['debug'])) {
3018
+			$setLocation = preg_replace('/^' . preg_quote($scripturl, '/') . '\\??/', $scripturl . '?debug;', $setLocation);
3019
+	}
2861 3020
 
2862 3021
 	if (!empty($modSettings['queryless_urls']) && (empty($context['server']['is_cgi']) || ini_get('cgi.fix_pathinfo') == 1 || @get_cfg_var('cgi.fix_pathinfo') == 1) && (!empty($context['server']['is_apache']) || !empty($context['server']['is_lighttpd']) || !empty($context['server']['is_litespeed'])))
2863 3022
 	{
2864
-		if (defined('SID') && SID != '')
2865
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
3023
+		if (defined('SID') && SID != '') {
3024
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?(?:' . SID . '(?:;|&|&amp;))((?:board|topic)=[^#]+?)(#[^"]*?)?$~',
2866 3025
 				function ($m) use ($scripturl)
2867 3026
 				{
2868 3027
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html?' . SID. (isset($m[2]) ? "$m[2]" : "");
3028
+		}
2869 3029
 				}, $setLocation);
2870
-		else
2871
-			$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
3030
+		else {
3031
+					$setLocation = preg_replace_callback('~^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+?)(#[^"]*?)?$~',
2872 3032
 				function ($m) use ($scripturl)
2873 3033
 				{
2874 3034
 					return $scripturl . '/' . strtr("$m[1]", '&;=', '//,') . '.html' . (isset($m[2]) ? "$m[2]" : "");
3035
+		}
2875 3036
 				}, $setLocation);
2876 3037
 	}
2877 3038
 
@@ -2882,8 +3043,9 @@  discard block
 block discarded – undo
2882 3043
 	header('Location: ' . str_replace(' ', '%20', $setLocation), true, $permanent ? 301 : 302);
2883 3044
 
2884 3045
 	// Debugging.
2885
-	if (isset($db_show_debug) && $db_show_debug === true)
2886
-		$_SESSION['debug_redirect'] = $db_cache;
3046
+	if (isset($db_show_debug) && $db_show_debug === true) {
3047
+			$_SESSION['debug_redirect'] = $db_cache;
3048
+	}
2887 3049
 
2888 3050
 	obExit(false);
2889 3051
 }
@@ -2902,51 +3064,60 @@  discard block
 block discarded – undo
2902 3064
 
2903 3065
 	// Attempt to prevent a recursive loop.
2904 3066
 	++$level;
2905
-	if ($level > 1 && !$from_fatal_error && !$has_fatal_error)
2906
-		exit;
2907
-	if ($from_fatal_error)
2908
-		$has_fatal_error = true;
3067
+	if ($level > 1 && !$from_fatal_error && !$has_fatal_error) {
3068
+			exit;
3069
+	}
3070
+	if ($from_fatal_error) {
3071
+			$has_fatal_error = true;
3072
+	}
2909 3073
 
2910 3074
 	// Clear out the stat cache.
2911 3075
 	trackStats();
2912 3076
 
2913 3077
 	// If we have mail to send, send it.
2914
-	if (!empty($context['flush_mail']))
2915
-		// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
3078
+	if (!empty($context['flush_mail'])) {
3079
+			// @todo this relies on 'flush_mail' being only set in AddMailQueue itself... :\
2916 3080
 		AddMailQueue(true);
3081
+	}
2917 3082
 
2918 3083
 	$do_header = $header === null ? !$header_done : $header;
2919
-	if ($do_footer === null)
2920
-		$do_footer = $do_header;
3084
+	if ($do_footer === null) {
3085
+			$do_footer = $do_header;
3086
+	}
2921 3087
 
2922 3088
 	// Has the template/header been done yet?
2923 3089
 	if ($do_header)
2924 3090
 	{
2925 3091
 		// Was the page title set last minute? Also update the HTML safe one.
2926
-		if (!empty($context['page_title']) && empty($context['page_title_html_safe']))
2927
-			$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3092
+		if (!empty($context['page_title']) && empty($context['page_title_html_safe'])) {
3093
+					$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
3094
+		}
2928 3095
 
2929 3096
 		// Start up the session URL fixer.
2930 3097
 		ob_start('ob_sessrewrite');
2931 3098
 
2932
-		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers']))
2933
-			$buffers = explode(',', $settings['output_buffers']);
2934
-		elseif (!empty($settings['output_buffers']))
2935
-			$buffers = $settings['output_buffers'];
2936
-		else
2937
-			$buffers = array();
3099
+		if (!empty($settings['output_buffers']) && is_string($settings['output_buffers'])) {
3100
+					$buffers = explode(',', $settings['output_buffers']);
3101
+		} elseif (!empty($settings['output_buffers'])) {
3102
+					$buffers = $settings['output_buffers'];
3103
+		} else {
3104
+					$buffers = array();
3105
+		}
2938 3106
 
2939
-		if (isset($modSettings['integrate_buffer']))
2940
-			$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3107
+		if (isset($modSettings['integrate_buffer'])) {
3108
+					$buffers = array_merge(explode(',', $modSettings['integrate_buffer']), $buffers);
3109
+		}
2941 3110
 
2942
-		if (!empty($buffers))
2943
-			foreach ($buffers as $function)
3111
+		if (!empty($buffers)) {
3112
+					foreach ($buffers as $function)
2944 3113
 			{
2945 3114
 				$call = call_helper($function, true);
3115
+		}
2946 3116
 
2947 3117
 				// Is it valid?
2948
-				if (!empty($call))
2949
-					ob_start($call);
3118
+				if (!empty($call)) {
3119
+									ob_start($call);
3120
+				}
2950 3121
 			}
2951 3122
 
2952 3123
 		// Display the screen in the logical order.
@@ -2958,8 +3129,9 @@  discard block
 block discarded – undo
2958 3129
 		loadSubTemplate(isset($context['sub_template']) ? $context['sub_template'] : 'main');
2959 3130
 
2960 3131
 		// Anything special to put out?
2961
-		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml']))
2962
-			echo $context['insert_after_template'];
3132
+		if (!empty($context['insert_after_template']) && !isset($_REQUEST['xml'])) {
3133
+					echo $context['insert_after_template'];
3134
+		}
2963 3135
 
2964 3136
 		// Just so we don't get caught in an endless loop of errors from the footer...
2965 3137
 		if (!$footer_done)
@@ -2968,14 +3140,16 @@  discard block
 block discarded – undo
2968 3140
 			template_footer();
2969 3141
 
2970 3142
 			// (since this is just debugging... it's okay that it's after </html>.)
2971
-			if (!isset($_REQUEST['xml']))
2972
-				displayDebug();
3143
+			if (!isset($_REQUEST['xml'])) {
3144
+							displayDebug();
3145
+			}
2973 3146
 		}
2974 3147
 	}
2975 3148
 
2976 3149
 	// Remember this URL in case someone doesn't like sending HTTP_REFERER.
2977
-	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false)
2978
-		$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3150
+	if (strpos($_SERVER['REQUEST_URL'], 'action=dlattach') === false && strpos($_SERVER['REQUEST_URL'], 'action=viewsmfile') === false) {
3151
+			$_SESSION['old_url'] = $_SERVER['REQUEST_URL'];
3152
+	}
2979 3153
 
2980 3154
 	// For session check verification.... don't switch browsers...
2981 3155
 	$_SESSION['USER_AGENT'] = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT'];
@@ -2984,9 +3158,10 @@  discard block
 block discarded – undo
2984 3158
 	call_integration_hook('integrate_exit', array($do_footer));
2985 3159
 
2986 3160
 	// Don't exit if we're coming from index.php; that will pass through normally.
2987
-	if (!$from_index)
2988
-		exit;
2989
-}
3161
+	if (!$from_index) {
3162
+			exit;
3163
+	}
3164
+	}
2990 3165
 
2991 3166
 /**
2992 3167
  * Get the size of a specified image with better error handling.
@@ -3005,8 +3180,9 @@  discard block
 block discarded – undo
3005 3180
 	$url = str_replace(' ', '%20', $url);
3006 3181
 
3007 3182
 	// Can we pull this from the cache... please please?
3008
-	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null)
3009
-		return $temp;
3183
+	if (($temp = cache_get_data('url_image_size-' . md5($url), 240)) !== null) {
3184
+			return $temp;
3185
+	}
3010 3186
 	$t = microtime();
3011 3187
 
3012 3188
 	// Get the host to pester...
@@ -3016,12 +3192,10 @@  discard block
 block discarded – undo
3016 3192
 	if ($url == '' || $url == 'http://' || $url == 'https://')
3017 3193
 	{
3018 3194
 		return false;
3019
-	}
3020
-	elseif (!isset($match[1]))
3195
+	} elseif (!isset($match[1]))
3021 3196
 	{
3022 3197
 		$size = @getimagesize($url);
3023
-	}
3024
-	else
3198
+	} else
3025 3199
 	{
3026 3200
 		// Try to connect to the server... give it half a second.
3027 3201
 		$temp = 0;
@@ -3060,12 +3234,14 @@  discard block
 block discarded – undo
3060 3234
 	}
3061 3235
 
3062 3236
 	// If we didn't get it, we failed.
3063
-	if (!isset($size))
3064
-		$size = false;
3237
+	if (!isset($size)) {
3238
+			$size = false;
3239
+	}
3065 3240
 
3066 3241
 	// If this took a long time, we may never have to do it again, but then again we might...
3067
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8)
3068
-		cache_put_data('url_image_size-' . md5($url), $size, 240);
3242
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.8) {
3243
+			cache_put_data('url_image_size-' . md5($url), $size, 240);
3244
+	}
3069 3245
 
3070 3246
 	// Didn't work.
3071 3247
 	return $size;
@@ -3083,8 +3259,9 @@  discard block
 block discarded – undo
3083 3259
 
3084 3260
 	// Under SSI this function can be called more then once.  That can cause some problems.
3085 3261
 	//   So only run the function once unless we are forced to run it again.
3086
-	if ($loaded && !$forceload)
3087
-		return;
3262
+	if ($loaded && !$forceload) {
3263
+			return;
3264
+	}
3088 3265
 
3089 3266
 	$loaded = true;
3090 3267
 
@@ -3096,14 +3273,16 @@  discard block
 block discarded – undo
3096 3273
 	$context['news_lines'] = array_filter(explode("\n", str_replace("\r", '', trim(addslashes($modSettings['news'])))));
3097 3274
 	for ($i = 0, $n = count($context['news_lines']); $i < $n; $i++)
3098 3275
 	{
3099
-		if (trim($context['news_lines'][$i]) == '')
3100
-			continue;
3276
+		if (trim($context['news_lines'][$i]) == '') {
3277
+					continue;
3278
+		}
3101 3279
 
3102 3280
 		// Clean it up for presentation ;).
3103 3281
 		$context['news_lines'][$i] = parse_bbc(stripslashes(trim($context['news_lines'][$i])), true, 'news' . $i);
3104 3282
 	}
3105
-	if (!empty($context['news_lines']))
3106
-		$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3283
+	if (!empty($context['news_lines'])) {
3284
+			$context['random_news_line'] = $context['news_lines'][mt_rand(0, count($context['news_lines']) - 1)];
3285
+	}
3107 3286
 
3108 3287
 	if (!$user_info['is_guest'])
3109 3288
 	{
@@ -3112,40 +3291,48 @@  discard block
 block discarded – undo
3112 3291
 		$context['user']['alerts'] = &$user_info['alerts'];
3113 3292
 
3114 3293
 		// Personal message popup...
3115
-		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0))
3116
-			$context['user']['popup_messages'] = true;
3117
-		else
3118
-			$context['user']['popup_messages'] = false;
3294
+		if ($user_info['unread_messages'] > (isset($_SESSION['unread_messages']) ? $_SESSION['unread_messages'] : 0)) {
3295
+					$context['user']['popup_messages'] = true;
3296
+		} else {
3297
+					$context['user']['popup_messages'] = false;
3298
+		}
3119 3299
 		$_SESSION['unread_messages'] = $user_info['unread_messages'];
3120 3300
 
3121
-		if (allowedTo('moderate_forum'))
3122
-			$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3301
+		if (allowedTo('moderate_forum')) {
3302
+					$context['unapproved_members'] = (!empty($modSettings['registration_method']) && ($modSettings['registration_method'] == 2 || (!empty($modSettings['coppaType']) && $modSettings['coppaType'] == 2))) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;
3303
+		}
3123 3304
 
3124 3305
 		$context['user']['avatar'] = array();
3125 3306
 
3126 3307
 		// Check for gravatar first since we might be forcing them...
3127 3308
 		if (($modSettings['gravatarEnabled'] && substr($user_info['avatar']['url'], 0, 11) == 'gravatar://') || !empty($modSettings['gravatarOverride']))
3128 3309
 		{
3129
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11)
3130
-				$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3131
-			else
3132
-				$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3310
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($user_info['avatar']['url'], 'gravatar://') && strlen($user_info['avatar']['url']) > 11) {
3311
+							$context['user']['avatar']['href'] = get_gravatar_url($smcFunc['substr']($user_info['avatar']['url'], 11));
3312
+			} else {
3313
+							$context['user']['avatar']['href'] = get_gravatar_url($user_info['email']);
3314
+			}
3133 3315
 		}
3134 3316
 		// Uploaded?
3135
-		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach']))
3136
-			$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3317
+		elseif ($user_info['avatar']['url'] == '' && !empty($user_info['avatar']['id_attach'])) {
3318
+					$context['user']['avatar']['href'] = $user_info['avatar']['custom_dir'] ? $modSettings['custom_avatar_url'] . '/' . $user_info['avatar']['filename'] : $scripturl . '?action=dlattach;attach=' . $user_info['avatar']['id_attach'] . ';type=avatar';
3319
+		}
3137 3320
 		// Full URL?
3138
-		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0)
3139
-			$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3321
+		elseif (strpos($user_info['avatar']['url'], 'http://') === 0 || strpos($user_info['avatar']['url'], 'https://') === 0) {
3322
+					$context['user']['avatar']['href'] = $user_info['avatar']['url'];
3323
+		}
3140 3324
 		// Otherwise we assume it's server stored.
3141
-		elseif ($user_info['avatar']['url'] != '')
3142
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3325
+		elseif ($user_info['avatar']['url'] != '') {
3326
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/' . $smcFunc['htmlspecialchars']($user_info['avatar']['url']);
3327
+		}
3143 3328
 		// No avatar at all? Fine, we have a big fat default avatar ;)
3144
-		else
3145
-			$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3329
+		else {
3330
+					$context['user']['avatar']['href'] = $modSettings['avatar_url'] . '/default.png';
3331
+		}
3146 3332
 
3147
-		if (!empty($context['user']['avatar']))
3148
-			$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3333
+		if (!empty($context['user']['avatar'])) {
3334
+					$context['user']['avatar']['image'] = '<img src="' . $context['user']['avatar']['href'] . '" alt="" class="avatar">';
3335
+		}
3149 3336
 
3150 3337
 		// Figure out how long they've been logged in.
3151 3338
 		$context['user']['total_time_logged_in'] = array(
@@ -3153,8 +3340,7 @@  discard block
 block discarded – undo
3153 3340
 			'hours' => floor(($user_info['total_time_logged_in'] % 86400) / 3600),
3154 3341
 			'minutes' => floor(($user_info['total_time_logged_in'] % 3600) / 60)
3155 3342
 		);
3156
-	}
3157
-	else
3343
+	} else
3158 3344
 	{
3159 3345
 		$context['user']['messages'] = 0;
3160 3346
 		$context['user']['unread_messages'] = 0;
@@ -3162,12 +3348,14 @@  discard block
 block discarded – undo
3162 3348
 		$context['user']['total_time_logged_in'] = array('days' => 0, 'hours' => 0, 'minutes' => 0);
3163 3349
 		$context['user']['popup_messages'] = false;
3164 3350
 
3165
-		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1)
3166
-			$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3351
+		if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 1) {
3352
+					$txt['welcome_guest'] .= $txt['welcome_guest_activate'];
3353
+		}
3167 3354
 
3168 3355
 		// If we've upgraded recently, go easy on the passwords.
3169
-		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime']))
3170
-			$context['disable_login_hashing'] = true;
3356
+		if (!empty($modSettings['disableHashTime']) && ($modSettings['disableHashTime'] == 1 || time() < $modSettings['disableHashTime'])) {
3357
+					$context['disable_login_hashing'] = true;
3358
+		}
3171 3359
 	}
3172 3360
 
3173 3361
 	// Setup the main menu items.
@@ -3180,8 +3368,8 @@  discard block
 block discarded – undo
3180 3368
 	$context['show_pm_popup'] = $context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm');
3181 3369
 
3182 3370
 	// 2.1+: Add the PM popup here instead. Theme authors can still override it simply by editing/removing the 'fPmPopup' in the array.
3183
-	if ($context['show_pm_popup'])
3184
-		addInlineJavaScript('
3371
+	if ($context['show_pm_popup']) {
3372
+			addInlineJavaScript('
3185 3373
 		jQuery(document).ready(function($) {
3186 3374
 			new smc_Popup({
3187 3375
 				heading: ' . JavaScriptEscape($txt['show_personal_messages_heading']) . ',
@@ -3189,15 +3377,17 @@  discard block
 block discarded – undo
3189 3377
 				icon_class: \'generic_icons mail_new\'
3190 3378
 			});
3191 3379
 		});');
3380
+	}
3192 3381
 
3193 3382
 	// Add a generic "Are you sure?" confirmation message.
3194 3383
 	addInlineJavaScript('
3195 3384
 	var smf_you_sure =' . JavaScriptEscape($txt['quickmod_confirm']) .';');
3196 3385
 
3197 3386
 	// Now add the capping code for avatars.
3198
-	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize')
3199
-		addInlineCss('
3387
+	if (!empty($modSettings['avatar_max_width_external']) && !empty($modSettings['avatar_max_height_external']) && !empty($modSettings['avatar_action_too_large']) && $modSettings['avatar_action_too_large'] == 'option_css_resize') {
3388
+			addInlineCss('
3200 3389
 img.avatar { max-width: ' . $modSettings['avatar_max_width_external'] . 'px; max-height: ' . $modSettings['avatar_max_height_external'] . 'px; }');
3390
+	}
3201 3391
 
3202 3392
 	// This looks weird, but it's because BoardIndex.php references the variable.
3203 3393
 	$context['common_stats']['latest_member'] = array(
@@ -3214,11 +3404,13 @@  discard block
 block discarded – undo
3214 3404
 	);
3215 3405
 	$context['common_stats']['boardindex_total_posts'] = sprintf($txt['boardindex_total_posts'], $context['common_stats']['total_posts'], $context['common_stats']['total_topics'], $context['common_stats']['total_members']);
3216 3406
 
3217
-	if (empty($settings['theme_version']))
3218
-		addJavaScriptVar('smf_scripturl', $scripturl);
3407
+	if (empty($settings['theme_version'])) {
3408
+			addJavaScriptVar('smf_scripturl', $scripturl);
3409
+	}
3219 3410
 
3220
-	if (!isset($context['page_title']))
3221
-		$context['page_title'] = '';
3411
+	if (!isset($context['page_title'])) {
3412
+			$context['page_title'] = '';
3413
+	}
3222 3414
 
3223 3415
 	// Set some specific vars.
3224 3416
 	$context['page_title_html_safe'] = $smcFunc['htmlspecialchars'](un_htmlspecialchars($context['page_title'])) . (!empty($context['current_page']) ? ' - ' . $txt['page'] . ' ' . ($context['current_page'] + 1) : '');
@@ -3228,21 +3420,23 @@  discard block
 block discarded – undo
3228 3420
 	$context['meta_tags'][] = array('property' => 'og:site_name', 'content' => $context['forum_name']);
3229 3421
 	$context['meta_tags'][] = array('property' => 'og:title', 'content' => $context['page_title_html_safe']);
3230 3422
 
3231
-	if (!empty($context['meta_keywords']))
3232
-		$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3423
+	if (!empty($context['meta_keywords'])) {
3424
+			$context['meta_tags'][] = array('name' => 'keywords', 'content' => $context['meta_keywords']);
3425
+	}
3233 3426
 
3234
-	if (!empty($context['canonical_url']))
3235
-		$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3427
+	if (!empty($context['canonical_url'])) {
3428
+			$context['meta_tags'][] = array('property' => 'og:url', 'content' => $context['canonical_url']);
3429
+	}
3236 3430
 
3237
-	if (!empty($settings['og_image']))
3238
-		$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3431
+	if (!empty($settings['og_image'])) {
3432
+			$context['meta_tags'][] = array('property' => 'og:image', 'content' => $settings['og_image']);
3433
+	}
3239 3434
 
3240 3435
 	if (!empty($context['meta_description']))
3241 3436
 	{
3242 3437
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['meta_description']);
3243 3438
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['meta_description']);
3244
-	}
3245
-	else
3439
+	} else
3246 3440
 	{
3247 3441
 		$context['meta_tags'][] = array('property' => 'og:description', 'content' => $context['page_title_html_safe']);
3248 3442
 		$context['meta_tags'][] = array('name' => 'description', 'content' => $context['page_title_html_safe']);
@@ -3267,8 +3461,9 @@  discard block
 block discarded – undo
3267 3461
 	$memory_needed = memoryReturnBytes($needed);
3268 3462
 
3269 3463
 	// should we account for how much is currently being used?
3270
-	if ($in_use)
3271
-		$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3464
+	if ($in_use) {
3465
+			$memory_needed += function_exists('memory_get_usage') ? memory_get_usage() : (2 * 1048576);
3466
+	}
3272 3467
 
3273 3468
 	// if more is needed, request it
3274 3469
 	if ($memory_current < $memory_needed)
@@ -3291,8 +3486,9 @@  discard block
 block discarded – undo
3291 3486
  */
3292 3487
 function memoryReturnBytes($val)
3293 3488
 {
3294
-	if (is_integer($val))
3295
-		return $val;
3489
+	if (is_integer($val)) {
3490
+			return $val;
3491
+	}
3296 3492
 
3297 3493
 	// Separate the number from the designator
3298 3494
 	$val = trim($val);
@@ -3328,10 +3524,11 @@  discard block
 block discarded – undo
3328 3524
 		header('Last-Modified: ' . gmdate('D, d M Y H:i:s') . ' GMT');
3329 3525
 
3330 3526
 		// Are we debugging the template/html content?
3331
-		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie'))
3332
-			header('Content-Type: application/xhtml+xml');
3333
-		elseif (!isset($_REQUEST['xml']))
3334
-			header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3527
+		if (!isset($_REQUEST['xml']) && isset($_GET['debug']) && !isBrowser('ie')) {
3528
+					header('Content-Type: application/xhtml+xml');
3529
+		} elseif (!isset($_REQUEST['xml'])) {
3530
+					header('Content-Type: text/html; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3531
+		}
3335 3532
 	}
3336 3533
 
3337 3534
 	header('Content-Type: text/' . (isset($_REQUEST['xml']) ? 'xml' : 'html') . '; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
@@ -3340,8 +3537,9 @@  discard block
 block discarded – undo
3340 3537
 	if ($context['in_maintenance'] && $context['user']['is_admin'])
3341 3538
 	{
3342 3539
 		$position = array_search('body', $context['template_layers']);
3343
-		if ($position === false)
3344
-			$position = array_search('main', $context['template_layers']);
3540
+		if ($position === false) {
3541
+					$position = array_search('main', $context['template_layers']);
3542
+		}
3345 3543
 
3346 3544
 		if ($position !== false)
3347 3545
 		{
@@ -3369,23 +3567,25 @@  discard block
 block discarded – undo
3369 3567
 
3370 3568
 			foreach ($securityFiles as $i => $securityFile)
3371 3569
 			{
3372
-				if (!file_exists($boarddir . '/' . $securityFile))
3373
-					unset($securityFiles[$i]);
3570
+				if (!file_exists($boarddir . '/' . $securityFile)) {
3571
+									unset($securityFiles[$i]);
3572
+				}
3374 3573
 			}
3375 3574
 
3376 3575
 			// We are already checking so many files...just few more doesn't make any difference! :P
3377
-			if (!empty($modSettings['currentAttachmentUploadDir']))
3378
-				$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3379
-
3380
-			else
3381
-				$path = $modSettings['attachmentUploadDir'];
3576
+			if (!empty($modSettings['currentAttachmentUploadDir'])) {
3577
+							$path = $modSettings['attachmentUploadDir'][$modSettings['currentAttachmentUploadDir']];
3578
+			} else {
3579
+							$path = $modSettings['attachmentUploadDir'];
3580
+			}
3382 3581
 
3383 3582
 			secureDirectory($path, true);
3384 3583
 			secureDirectory($cachedir);
3385 3584
 
3386 3585
 			// If agreement is enabled, at least the english version shall exists
3387
-			if ($modSettings['requireAgreement'])
3388
-				$agreement = !file_exists($boarddir . '/agreement.txt');
3586
+			if ($modSettings['requireAgreement']) {
3587
+							$agreement = !file_exists($boarddir . '/agreement.txt');
3588
+			}
3389 3589
 
3390 3590
 			if (!empty($securityFiles) || (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) || !empty($agreement))
3391 3591
 			{
@@ -3400,18 +3600,21 @@  discard block
 block discarded – undo
3400 3600
 					echo '
3401 3601
 				', $txt['not_removed'], '<strong>', $securityFile, '</strong>!<br>';
3402 3602
 
3403
-					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~')
3404
-						echo '
3603
+					if ($securityFile == 'Settings.php~' || $securityFile == 'Settings_bak.php~') {
3604
+											echo '
3405 3605
 				', sprintf($txt['not_removed_extra'], $securityFile, substr($securityFile, 0, -1)), '<br>';
3606
+					}
3406 3607
 				}
3407 3608
 
3408
-				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir))
3409
-					echo '
3609
+				if (!empty($modSettings['cache_enable']) && !is_writable($cachedir)) {
3610
+									echo '
3410 3611
 				<strong>', $txt['cache_writable'], '</strong><br>';
3612
+				}
3411 3613
 
3412
-				if (!empty($agreement))
3413
-					echo '
3614
+				if (!empty($agreement)) {
3615
+									echo '
3414 3616
 				<strong>', $txt['agreement_missing'], '</strong><br>';
3617
+				}
3415 3618
 
3416 3619
 				echo '
3417 3620
 			</p>
@@ -3426,16 +3629,18 @@  discard block
 block discarded – undo
3426 3629
 				<div class="windowbg alert" style="margin: 2ex; padding: 2ex; border: 2px dashed red;">
3427 3630
 					', sprintf($txt['you_are_post_banned'], $user_info['is_guest'] ? $txt['guest_title'] : $user_info['name']);
3428 3631
 
3429
-			if (!empty($_SESSION['ban']['cannot_post']['reason']))
3430
-				echo '
3632
+			if (!empty($_SESSION['ban']['cannot_post']['reason'])) {
3633
+							echo '
3431 3634
 					<div style="padding-left: 4ex; padding-top: 1ex;">', $_SESSION['ban']['cannot_post']['reason'], '</div>';
3635
+			}
3432 3636
 
3433
-			if (!empty($_SESSION['ban']['expire_time']))
3434
-				echo '
3637
+			if (!empty($_SESSION['ban']['expire_time'])) {
3638
+							echo '
3435 3639
 					<div>', sprintf($txt['your_ban_expires'], timeformat($_SESSION['ban']['expire_time'], false)), '</div>';
3436
-			else
3437
-				echo '
3640
+			} else {
3641
+							echo '
3438 3642
 					<div>', $txt['your_ban_expires_never'], '</div>';
3643
+			}
3439 3644
 
3440 3645
 			echo '
3441 3646
 				</div>';
@@ -3451,8 +3656,9 @@  discard block
 block discarded – undo
3451 3656
 	global $forum_copyright, $software_year, $forum_version;
3452 3657
 
3453 3658
 	// Don't display copyright for things like SSI.
3454
-	if (!isset($forum_version) || !isset($software_year))
3455
-		return;
3659
+	if (!isset($forum_version) || !isset($software_year)) {
3660
+			return;
3661
+	}
3456 3662
 
3457 3663
 	// Put in the version...
3458 3664
 	printf($forum_copyright, $forum_version, $software_year);
@@ -3470,9 +3676,10 @@  discard block
 block discarded – undo
3470 3676
 	$context['load_time'] = round(microtime(true) - $time_start, 3);
3471 3677
 	$context['load_queries'] = $db_count;
3472 3678
 
3473
-	foreach (array_reverse($context['template_layers']) as $layer)
3474
-		loadSubTemplate($layer . '_below', true);
3475
-}
3679
+	foreach (array_reverse($context['template_layers']) as $layer) {
3680
+			loadSubTemplate($layer . '_below', true);
3681
+	}
3682
+	}
3476 3683
 
3477 3684
 /**
3478 3685
  * Output the Javascript files
@@ -3503,8 +3710,7 @@  discard block
 block discarded – undo
3503 3710
 			{
3504 3711
 				echo '
3505 3712
 		var ', $key, ';';
3506
-			}
3507
-			else
3713
+			} else
3508 3714
 			{
3509 3715
 				echo '
3510 3716
 		var ', $key, ' = ', $value, ';';
@@ -3519,26 +3725,27 @@  discard block
 block discarded – undo
3519 3725
 	foreach ($context['javascript_files'] as $id => $js_file)
3520 3726
 	{
3521 3727
 		// Last minute call! allow theme authors to disable single files.
3522
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3523
-			continue;
3728
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3729
+					continue;
3730
+		}
3524 3731
 
3525 3732
 		// By default all files don't get minimized unless the file explicitly says so!
3526 3733
 		if (!empty($js_file['options']['minimize']) && !empty($modSettings['minimize_files']))
3527 3734
 		{
3528
-			if ($do_deferred && !empty($js_file['options']['defer']))
3529
-				$toMinifyDefer[] = $js_file;
3530
-
3531
-			elseif (!$do_deferred && empty($js_file['options']['defer']))
3532
-				$toMinify[] = $js_file;
3735
+			if ($do_deferred && !empty($js_file['options']['defer'])) {
3736
+							$toMinifyDefer[] = $js_file;
3737
+			} elseif (!$do_deferred && empty($js_file['options']['defer'])) {
3738
+							$toMinify[] = $js_file;
3739
+			}
3533 3740
 
3534 3741
 			// Grab a random seed.
3535
-			if (!isset($minSeed))
3536
-				$minSeed = $js_file['options']['seed'];
3537
-		}
3538
-
3539
-		elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer'])))
3540
-			echo '
3742
+			if (!isset($minSeed)) {
3743
+							$minSeed = $js_file['options']['seed'];
3744
+			}
3745
+		} elseif ((!$do_deferred && empty($js_file['options']['defer'])) || ($do_deferred && !empty($js_file['options']['defer']))) {
3746
+					echo '
3541 3747
 	<script src="', $js_file['fileUrl'], '"', !empty($js_file['options']['async']) ? ' async="async"' : '', '></script>';
3748
+		}
3542 3749
 	}
3543 3750
 
3544 3751
 	if ((!$do_deferred && !empty($toMinify)) || ($do_deferred && !empty($toMinifyDefer)))
@@ -3546,14 +3753,14 @@  discard block
 block discarded – undo
3546 3753
 		$result = custMinify(($do_deferred ? $toMinifyDefer : $toMinify), 'js', $do_deferred);
3547 3754
 
3548 3755
 		// Minify process couldn't work, print each individual files.
3549
-		if (!empty($result) && is_array($result))
3550
-			foreach ($result as $minFailedFile)
3756
+		if (!empty($result) && is_array($result)) {
3757
+					foreach ($result as $minFailedFile)
3551 3758
 				echo '
3552 3759
 	<script src="', $minFailedFile['fileUrl'], '"', !empty($minFailedFile['options']['async']) ? ' async="async"' : '', '></script>';
3553
-
3554
-		else
3555
-			echo '
3760
+		} else {
3761
+					echo '
3556 3762
 	<script src="', $settings['theme_url'] ,'/scripts/minified', ($do_deferred ? '_deferred' : '') ,'.js', $minSeed ,'"></script>';
3763
+		}
3557 3764
 	}
3558 3765
 
3559 3766
 	// Inline JavaScript - Actually useful some times!
@@ -3564,8 +3771,9 @@  discard block
 block discarded – undo
3564 3771
 			echo '
3565 3772
 <script>';
3566 3773
 
3567
-			foreach ($context['javascript_inline']['defer'] as $js_code)
3568
-				echo $js_code;
3774
+			foreach ($context['javascript_inline']['defer'] as $js_code) {
3775
+							echo $js_code;
3776
+			}
3569 3777
 
3570 3778
 			echo '
3571 3779
 </script>';
@@ -3576,8 +3784,9 @@  discard block
 block discarded – undo
3576 3784
 			echo '
3577 3785
 	<script>';
3578 3786
 
3579
-			foreach ($context['javascript_inline']['standard'] as $js_code)
3580
-				echo $js_code;
3787
+			foreach ($context['javascript_inline']['standard'] as $js_code) {
3788
+							echo $js_code;
3789
+			}
3581 3790
 
3582 3791
 			echo '
3583 3792
 	</script>';
@@ -3602,8 +3811,9 @@  discard block
 block discarded – undo
3602 3811
 	foreach ($context['css_files'] as $id => $file)
3603 3812
 	{
3604 3813
 		// Last minute call! allow theme authors to disable single files.
3605
-		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files']))
3606
-			continue;
3814
+		if (!empty($settings['disable_files']) && in_array($id, $settings['disable_files'])) {
3815
+					continue;
3816
+		}
3607 3817
 
3608 3818
 		// By default all files don't get minimized unless the file explicitly says so!
3609 3819
 		if (!empty($file['options']['minimize']) && !empty($modSettings['minimize_files']))
@@ -3611,12 +3821,12 @@  discard block
 block discarded – undo
3611 3821
 			$toMinify[] = $file;
3612 3822
 
3613 3823
 			// Grab a random seed.
3614
-			if (!isset($minSeed))
3615
-				$minSeed = $file['options']['seed'];
3824
+			if (!isset($minSeed)) {
3825
+							$minSeed = $file['options']['seed'];
3826
+			}
3827
+		} else {
3828
+					$normal[] = $file['fileUrl'];
3616 3829
 		}
3617
-
3618
-		else
3619
-			$normal[] = $file['fileUrl'];
3620 3830
 	}
3621 3831
 
3622 3832
 	if (!empty($toMinify))
@@ -3624,28 +3834,30 @@  discard block
 block discarded – undo
3624 3834
 		$result = custMinify($toMinify, 'css');
3625 3835
 
3626 3836
 		// Minify process couldn't work, print each individual files.
3627
-		if (!empty($result) && is_array($result))
3628
-			foreach ($result as $minFailedFile)
3837
+		if (!empty($result) && is_array($result)) {
3838
+					foreach ($result as $minFailedFile)
3629 3839
 				echo '
3630 3840
 	<link rel="stylesheet" href="', $minFailedFile['fileUrl'], '">';
3631
-
3632
-		else
3633
-			echo '
3841
+		} else {
3842
+					echo '
3634 3843
 	<link rel="stylesheet" href="', $settings['theme_url'] ,'/css/minified.css', $minSeed ,'">';
3844
+		}
3635 3845
 	}
3636 3846
 
3637 3847
 	// Print the rest after the minified files.
3638
-	if (!empty($normal))
3639
-		foreach ($normal as $nf)
3848
+	if (!empty($normal)) {
3849
+			foreach ($normal as $nf)
3640 3850
 			echo '
3641 3851
 	<link rel="stylesheet" href="', $nf ,'">';
3852
+	}
3642 3853
 
3643 3854
 	if ($db_show_debug === true)
3644 3855
 	{
3645 3856
 		// Try to keep only what's useful.
3646 3857
 		$repl = array($boardurl . '/Themes/' => '', $boardurl . '/' => '');
3647
-		foreach ($context['css_files'] as $file)
3648
-			$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3858
+		foreach ($context['css_files'] as $file) {
3859
+					$context['debug']['sheets'][] = strtr($file['fileName'], $repl);
3860
+		}
3649 3861
 	}
3650 3862
 
3651 3863
 	if (!empty($context['css_header']))
@@ -3653,9 +3865,10 @@  discard block
 block discarded – undo
3653 3865
 		echo '
3654 3866
 	<style>';
3655 3867
 
3656
-		foreach ($context['css_header'] as $css)
3657
-			echo $css .'
3868
+		foreach ($context['css_header'] as $css) {
3869
+					echo $css .'
3658 3870
 	';
3871
+		}
3659 3872
 
3660 3873
 		echo'
3661 3874
 	</style>';
@@ -3679,15 +3892,17 @@  discard block
 block discarded – undo
3679 3892
 	$type = !empty($type) && in_array($type, $types) ? $type : false;
3680 3893
 	$data = !empty($data) ? $data : false;
3681 3894
 
3682
-	if (empty($type) || empty($data))
3683
-		return false;
3895
+	if (empty($type) || empty($data)) {
3896
+			return false;
3897
+	}
3684 3898
 
3685 3899
 	// Did we already did this?
3686 3900
 	$toCache = cache_get_data('minimized_'. $settings['theme_id'] .'_'. $type, 86400);
3687 3901
 
3688 3902
 	// Already done?
3689
-	if (!empty($toCache))
3690
-		return true;
3903
+	if (!empty($toCache)) {
3904
+			return true;
3905
+	}
3691 3906
 
3692 3907
 	// No namespaces, sorry!
3693 3908
 	$classType = 'MatthiasMullie\\Minify\\'. strtoupper($type);
@@ -3769,8 +3984,9 @@  discard block
 block discarded – undo
3769 3984
 	global $modSettings, $smcFunc;
3770 3985
 
3771 3986
 	// Just make up a nice hash...
3772
-	if ($new)
3773
-		return sha1(md5($filename . time()) . mt_rand());
3987
+	if ($new) {
3988
+			return sha1(md5($filename . time()) . mt_rand());
3989
+	}
3774 3990
 
3775 3991
 	// Just make sure that attachment id is only a int
3776 3992
 	$attachment_id = (int) $attachment_id;
@@ -3787,23 +4003,25 @@  discard block
 block discarded – undo
3787 4003
 				'id_attach' => $attachment_id,
3788 4004
 			));
3789 4005
 
3790
-		if ($smcFunc['db_num_rows']($request) === 0)
3791
-			return false;
4006
+		if ($smcFunc['db_num_rows']($request) === 0) {
4007
+					return false;
4008
+		}
3792 4009
 
3793 4010
 		list ($file_hash) = $smcFunc['db_fetch_row']($request);
3794 4011
 		$smcFunc['db_free_result']($request);
3795 4012
 	}
3796 4013
 
3797 4014
 	// Still no hash? mmm...
3798
-	if (empty($file_hash))
3799
-		$file_hash = sha1(md5($filename . time()) . mt_rand());
4015
+	if (empty($file_hash)) {
4016
+			$file_hash = sha1(md5($filename . time()) . mt_rand());
4017
+	}
3800 4018
 
3801 4019
 	// Are we using multiple directories?
3802
-	if (is_array($modSettings['attachmentUploadDir']))
3803
-		$path = $modSettings['attachmentUploadDir'][$dir];
3804
-
3805
-	else
3806
-		$path = $modSettings['attachmentUploadDir'];
4020
+	if (is_array($modSettings['attachmentUploadDir'])) {
4021
+			$path = $modSettings['attachmentUploadDir'][$dir];
4022
+	} else {
4023
+			$path = $modSettings['attachmentUploadDir'];
4024
+	}
3807 4025
 
3808 4026
 	return $path . '/' . $attachment_id . '_' . $file_hash .'.dat';
3809 4027
 }
@@ -3818,8 +4036,9 @@  discard block
 block discarded – undo
3818 4036
 function ip2range($fullip)
3819 4037
 {
3820 4038
 	// Pretend that 'unknown' is 255.255.255.255. (since that can't be an IP anyway.)
3821
-	if ($fullip == 'unknown')
3822
-		$fullip = '255.255.255.255';
4039
+	if ($fullip == 'unknown') {
4040
+			$fullip = '255.255.255.255';
4041
+	}
3823 4042
 
3824 4043
 	$ip_parts = explode('-', $fullip);
3825 4044
 	$ip_array = array();
@@ -3843,10 +4062,11 @@  discard block
 block discarded – undo
3843 4062
 		$ip_array['low'] = $ip_parts[0];
3844 4063
 		$ip_array['high'] = $ip_parts[1];
3845 4064
 		return $ip_array;
3846
-	}
3847
-	elseif (count($ip_parts) == 2) // if ip 22.22.*-22.22.*
4065
+	} elseif (count($ip_parts) == 2) {
4066
+		// if ip 22.22.*-22.22.*
3848 4067
 	{
3849 4068
 		$valid_low = isValidIP($ip_parts[0]);
4069
+	}
3850 4070
 		$valid_high = isValidIP($ip_parts[1]);
3851 4071
 		$count = 0;
3852 4072
 		$mode = (preg_match('/:/',$ip_parts[0]) > 0 ? ':' : '.');
@@ -3861,7 +4081,9 @@  discard block
 block discarded – undo
3861 4081
 				$ip_parts[0] .= $mode . $min;
3862 4082
 				$valid_low = isValidIP($ip_parts[0]);
3863 4083
 				$count++;
3864
-				if ($count > 9) break;
4084
+				if ($count > 9) {
4085
+					break;
4086
+				}
3865 4087
 			}
3866 4088
 		}
3867 4089
 
@@ -3875,7 +4097,9 @@  discard block
 block discarded – undo
3875 4097
 				$ip_parts[1] .= $mode . $max;
3876 4098
 				$valid_high = isValidIP($ip_parts[1]);
3877 4099
 				$count++;
3878
-				if ($count > 9) break;
4100
+				if ($count > 9) {
4101
+					break;
4102
+				}
3879 4103
 			}
3880 4104
 		}
3881 4105
 
@@ -3900,46 +4124,54 @@  discard block
 block discarded – undo
3900 4124
 {
3901 4125
 	global $modSettings;
3902 4126
 
3903
-	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null)
3904
-		return $host;
4127
+	if (($host = cache_get_data('hostlookup-' . $ip, 600)) !== null) {
4128
+			return $host;
4129
+	}
3905 4130
 	$t = microtime();
3906 4131
 
3907 4132
 	// Try the Linux host command, perhaps?
3908 4133
 	if (!isset($host) && (strpos(strtolower(PHP_OS), 'win') === false || strpos(strtolower(PHP_OS), 'darwin') !== false) && mt_rand(0, 1) == 1)
3909 4134
 	{
3910
-		if (!isset($modSettings['host_to_dis']))
3911
-			$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
3912
-		else
3913
-			$test = @shell_exec('host ' . @escapeshellarg($ip));
4135
+		if (!isset($modSettings['host_to_dis'])) {
4136
+					$test = @shell_exec('host -W 1 ' . @escapeshellarg($ip));
4137
+		} else {
4138
+					$test = @shell_exec('host ' . @escapeshellarg($ip));
4139
+		}
3914 4140
 
3915 4141
 		// Did host say it didn't find anything?
3916
-		if (strpos($test, 'not found') !== false)
3917
-			$host = '';
4142
+		if (strpos($test, 'not found') !== false) {
4143
+					$host = '';
4144
+		}
3918 4145
 		// Invalid server option?
3919
-		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis']))
3920
-			updateSettings(array('host_to_dis' => 1));
4146
+		elseif ((strpos($test, 'invalid option') || strpos($test, 'Invalid query name 1')) && !isset($modSettings['host_to_dis'])) {
4147
+					updateSettings(array('host_to_dis' => 1));
4148
+		}
3921 4149
 		// Maybe it found something, after all?
3922
-		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1)
3923
-			$host = $match[1];
4150
+		elseif (preg_match('~\s([^\s]+?)\.\s~', $test, $match) == 1) {
4151
+					$host = $match[1];
4152
+		}
3924 4153
 	}
3925 4154
 
3926 4155
 	// This is nslookup; usually only Windows, but possibly some Unix?
3927 4156
 	if (!isset($host) && stripos(PHP_OS, 'win') !== false && strpos(strtolower(PHP_OS), 'darwin') === false && mt_rand(0, 1) == 1)
3928 4157
 	{
3929 4158
 		$test = @shell_exec('nslookup -timeout=1 ' . @escapeshellarg($ip));
3930
-		if (strpos($test, 'Non-existent domain') !== false)
3931
-			$host = '';
3932
-		elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1)
3933
-			$host = $match[1];
4159
+		if (strpos($test, 'Non-existent domain') !== false) {
4160
+					$host = '';
4161
+		} elseif (preg_match('~Name:\s+([^\s]+)~', $test, $match) == 1) {
4162
+					$host = $match[1];
4163
+		}
3934 4164
 	}
3935 4165
 
3936 4166
 	// This is the last try :/.
3937
-	if (!isset($host) || $host === false)
3938
-		$host = @gethostbyaddr($ip);
4167
+	if (!isset($host) || $host === false) {
4168
+			$host = @gethostbyaddr($ip);
4169
+	}
3939 4170
 
3940 4171
 	// It took a long time, so let's cache it!
3941
-	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5)
3942
-		cache_put_data('hostlookup-' . $ip, $host, 600);
4172
+	if (array_sum(explode(' ', microtime())) - array_sum(explode(' ', $t)) > 0.5) {
4173
+			cache_put_data('hostlookup-' . $ip, $host, 600);
4174
+	}
3943 4175
 
3944 4176
 	return $host;
3945 4177
 }
@@ -3975,20 +4207,21 @@  discard block
 block discarded – undo
3975 4207
 			{
3976 4208
 				$encrypted = substr(crypt($word, 'uk'), 2, $max_chars);
3977 4209
 				$total = 0;
3978
-				for ($i = 0; $i < $max_chars; $i++)
3979
-					$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4210
+				for ($i = 0; $i < $max_chars; $i++) {
4211
+									$total += $possible_chars[ord($encrypted{$i})] * pow(63, $i);
4212
+				}
3980 4213
 				$returned_ints[] = $max_chars == 4 ? min($total, 16777215) : $total;
3981 4214
 			}
3982 4215
 		}
3983 4216
 		return array_unique($returned_ints);
3984
-	}
3985
-	else
4217
+	} else
3986 4218
 	{
3987 4219
 		// Trim characters before and after and add slashes for database insertion.
3988 4220
 		$returned_words = array();
3989
-		foreach ($words as $word)
3990
-			if (($word = trim($word, '-_\'')) !== '')
4221
+		foreach ($words as $word) {
4222
+					if (($word = trim($word, '-_\'')) !== '')
3991 4223
 				$returned_words[] = $max_chars === null ? $word : substr($word, 0, $max_chars);
4224
+		}
3992 4225
 
3993 4226
 		// Filter out all words that occur more than once.
3994 4227
 		return array_unique($returned_words);
@@ -4010,16 +4243,18 @@  discard block
 block discarded – undo
4010 4243
 	global $settings, $txt;
4011 4244
 
4012 4245
 	// Does the current loaded theme have this and we are not forcing the usage of this function?
4013
-	if (function_exists('template_create_button') && !$force_use)
4014
-		return template_create_button($name, $alt, $label = '', $custom = '');
4246
+	if (function_exists('template_create_button') && !$force_use) {
4247
+			return template_create_button($name, $alt, $label = '', $custom = '');
4248
+	}
4015 4249
 
4016
-	if (!$settings['use_image_buttons'])
4017
-		return $txt[$alt];
4018
-	elseif (!empty($settings['use_buttons']))
4019
-		return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4020
-	else
4021
-		return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4022
-}
4250
+	if (!$settings['use_image_buttons']) {
4251
+			return $txt[$alt];
4252
+	} elseif (!empty($settings['use_buttons'])) {
4253
+			return '<span class="generic_icons ' . $name . '" alt="' . $txt[$alt] . '"></span>' . ($label != '' ? '&nbsp;<strong>' . $txt[$label] . '</strong>' : '');
4254
+	} else {
4255
+			return '<img src="' . $settings['lang_images_url'] . '/' . $name . '" alt="' . $txt[$alt] . '" ' . $custom . '>';
4256
+	}
4257
+	}
4023 4258
 
4024 4259
 /**
4025 4260
  * Sets up all of the top menu buttons
@@ -4062,9 +4297,10 @@  discard block
 block discarded – undo
4062 4297
 	var user_menus = new smc_PopupMenu();
4063 4298
 	user_menus.add("profile", "' . $scripturl . '?action=profile;area=popup");
4064 4299
 	user_menus.add("alerts", "' . $scripturl . '?action=profile;area=alerts_popup;u='. $context['user']['id'] .'");', true);
4065
-		if ($context['allow_pm'])
4066
-			addInlineJavaScript('
4300
+		if ($context['allow_pm']) {
4301
+					addInlineJavaScript('
4067 4302
 	user_menus.add("pm", "' . $scripturl . '?action=pm;sa=popup");', true);
4303
+		}
4068 4304
 
4069 4305
 		if (!empty($modSettings['enable_ajax_alerts']))
4070 4306
 		{
@@ -4224,88 +4460,96 @@  discard block
 block discarded – undo
4224 4460
 
4225 4461
 		// Now we put the buttons in the context so the theme can use them.
4226 4462
 		$menu_buttons = array();
4227
-		foreach ($buttons as $act => $button)
4228
-			if (!empty($button['show']))
4463
+		foreach ($buttons as $act => $button) {
4464
+					if (!empty($button['show']))
4229 4465
 			{
4230 4466
 				$button['active_button'] = false;
4467
+		}
4231 4468
 
4232 4469
 				// This button needs some action.
4233
-				if (isset($button['action_hook']))
4234
-					$needs_action_hook = true;
4470
+				if (isset($button['action_hook'])) {
4471
+									$needs_action_hook = true;
4472
+				}
4235 4473
 
4236 4474
 				// Make sure the last button truly is the last button.
4237 4475
 				if (!empty($button['is_last']))
4238 4476
 				{
4239
-					if (isset($last_button))
4240
-						unset($menu_buttons[$last_button]['is_last']);
4477
+					if (isset($last_button)) {
4478
+											unset($menu_buttons[$last_button]['is_last']);
4479
+					}
4241 4480
 					$last_button = $act;
4242 4481
 				}
4243 4482
 
4244 4483
 				// Go through the sub buttons if there are any.
4245
-				if (!empty($button['sub_buttons']))
4246
-					foreach ($button['sub_buttons'] as $key => $subbutton)
4484
+				if (!empty($button['sub_buttons'])) {
4485
+									foreach ($button['sub_buttons'] as $key => $subbutton)
4247 4486
 					{
4248 4487
 						if (empty($subbutton['show']))
4249 4488
 							unset($button['sub_buttons'][$key]);
4489
+				}
4250 4490
 
4251 4491
 						// 2nd level sub buttons next...
4252 4492
 						if (!empty($subbutton['sub_buttons']))
4253 4493
 						{
4254 4494
 							foreach ($subbutton['sub_buttons'] as $key2 => $sub_button2)
4255 4495
 							{
4256
-								if (empty($sub_button2['show']))
4257
-									unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4496
+								if (empty($sub_button2['show'])) {
4497
+																	unset($button['sub_buttons'][$key]['sub_buttons'][$key2]);
4498
+								}
4258 4499
 							}
4259 4500
 						}
4260 4501
 					}
4261 4502
 
4262 4503
 				// Does this button have its own icon?
4263
-				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon']))
4264
-					$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4265
-				elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon']))
4266
-					$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4267
-				elseif (isset($button['icon']))
4268
-					$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4269
-				else
4270
-					$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4504
+				if (isset($button['icon']) && file_exists($settings['theme_dir'] . '/images/' . $button['icon'])) {
4505
+									$button['icon'] = '<img src="' . $settings['images_url'] . '/' . $button['icon'] . '" alt="">';
4506
+				} elseif (isset($button['icon']) && file_exists($settings['default_theme_dir'] . '/images/' . $button['icon'])) {
4507
+									$button['icon'] = '<img src="' . $settings['default_images_url'] . '/' . $button['icon'] . '" alt="">';
4508
+				} elseif (isset($button['icon'])) {
4509
+									$button['icon'] = '<span class="generic_icons ' . $button['icon'] . '"></span>';
4510
+				} else {
4511
+									$button['icon'] = '<span class="generic_icons ' . $act . '"></span>';
4512
+				}
4271 4513
 
4272 4514
 				$menu_buttons[$act] = $button;
4273 4515
 			}
4274 4516
 
4275
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
4276
-			cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4517
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
4518
+					cache_put_data('menu_buttons-' . implode('_', $user_info['groups']) . '-' . $user_info['language'], $menu_buttons, $cacheTime);
4519
+		}
4277 4520
 	}
4278 4521
 
4279 4522
 	$context['menu_buttons'] = $menu_buttons;
4280 4523
 
4281 4524
 	// Logging out requires the session id in the url.
4282
-	if (isset($context['menu_buttons']['logout']))
4283
-		$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4525
+	if (isset($context['menu_buttons']['logout'])) {
4526
+			$context['menu_buttons']['logout']['href'] = sprintf($context['menu_buttons']['logout']['href'], $context['session_var'], $context['session_id']);
4527
+	}
4284 4528
 
4285 4529
 	// Figure out which action we are doing so we can set the active tab.
4286 4530
 	// Default to home.
4287 4531
 	$current_action = 'home';
4288 4532
 
4289
-	if (isset($context['menu_buttons'][$context['current_action']]))
4290
-		$current_action = $context['current_action'];
4291
-	elseif ($context['current_action'] == 'search2')
4292
-		$current_action = 'search';
4293
-	elseif ($context['current_action'] == 'theme')
4294
-		$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4295
-	elseif ($context['current_action'] == 'register2')
4296
-		$current_action = 'register';
4297
-	elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder'))
4298
-		$current_action = 'login';
4299
-	elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center'])
4300
-		$current_action = 'moderate';
4533
+	if (isset($context['menu_buttons'][$context['current_action']])) {
4534
+			$current_action = $context['current_action'];
4535
+	} elseif ($context['current_action'] == 'search2') {
4536
+			$current_action = 'search';
4537
+	} elseif ($context['current_action'] == 'theme') {
4538
+			$current_action = isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? 'profile' : 'admin';
4539
+	} elseif ($context['current_action'] == 'register2') {
4540
+			$current_action = 'register';
4541
+	} elseif ($context['current_action'] == 'login2' || ($user_info['is_guest'] && $context['current_action'] == 'reminder')) {
4542
+			$current_action = 'login';
4543
+	} elseif ($context['current_action'] == 'groups' && $context['allow_moderation_center']) {
4544
+			$current_action = 'moderate';
4545
+	}
4301 4546
 
4302 4547
 	// There are certain exceptions to the above where we don't want anything on the menu highlighted.
4303 4548
 	if ($context['current_action'] == 'profile' && !empty($context['user']['is_owner']))
4304 4549
 	{
4305 4550
 		$current_action = !empty($_GET['area']) && $_GET['area'] == 'showalerts' ? 'self_alerts' : 'self_profile';
4306 4551
 		$context[$current_action] = true;
4307
-	}
4308
-	elseif ($context['current_action'] == 'pm')
4552
+	} elseif ($context['current_action'] == 'pm')
4309 4553
 	{
4310 4554
 		$current_action = 'self_pm';
4311 4555
 		$context['self_pm'] = true;
@@ -4346,12 +4590,14 @@  discard block
 block discarded – undo
4346 4590
 	}
4347 4591
 
4348 4592
 	// Not all actions are simple.
4349
-	if (!empty($needs_action_hook))
4350
-		call_integration_hook('integrate_current_action', array(&$current_action));
4593
+	if (!empty($needs_action_hook)) {
4594
+			call_integration_hook('integrate_current_action', array(&$current_action));
4595
+	}
4351 4596
 
4352
-	if (isset($context['menu_buttons'][$current_action]))
4353
-		$context['menu_buttons'][$current_action]['active_button'] = true;
4354
-}
4597
+	if (isset($context['menu_buttons'][$current_action])) {
4598
+			$context['menu_buttons'][$current_action]['active_button'] = true;
4599
+	}
4600
+	}
4355 4601
 
4356 4602
 /**
4357 4603
  * Generate a random seed and ensure it's stored in settings.
@@ -4375,30 +4621,35 @@  discard block
 block discarded – undo
4375 4621
 	global $modSettings, $settings, $boarddir, $sourcedir, $db_show_debug;
4376 4622
 	global $context, $txt;
4377 4623
 
4378
-	if ($db_show_debug === true)
4379
-		$context['debug']['hooks'][] = $hook;
4624
+	if ($db_show_debug === true) {
4625
+			$context['debug']['hooks'][] = $hook;
4626
+	}
4380 4627
 
4381 4628
 	// Need to have some control.
4382
-	if (!isset($context['instances']))
4383
-		$context['instances'] = array();
4629
+	if (!isset($context['instances'])) {
4630
+			$context['instances'] = array();
4631
+	}
4384 4632
 
4385 4633
 	$results = array();
4386
-	if (empty($modSettings[$hook]))
4387
-		return $results;
4634
+	if (empty($modSettings[$hook])) {
4635
+			return $results;
4636
+	}
4388 4637
 
4389 4638
 	$functions = explode(',', $modSettings[$hook]);
4390 4639
 	// Loop through each function.
4391 4640
 	foreach ($functions as $function)
4392 4641
 	{
4393 4642
 		// Hook has been marked as "disabled". Skip it!
4394
-		if (strpos($function, '!') !== false)
4395
-			continue;
4643
+		if (strpos($function, '!') !== false) {
4644
+					continue;
4645
+		}
4396 4646
 
4397 4647
 		$call = call_helper($function, true);
4398 4648
 
4399 4649
 		// Is it valid?
4400
-		if (!empty($call))
4401
-			$results[$function] = call_user_func_array($call, $parameters);
4650
+		if (!empty($call)) {
4651
+					$results[$function] = call_user_func_array($call, $parameters);
4652
+		}
4402 4653
 
4403 4654
 		// Whatever it was suppose to call, it failed :(
4404 4655
 		elseif (!empty($function))
@@ -4414,8 +4665,9 @@  discard block
 block discarded – undo
4414 4665
 			}
4415 4666
 
4416 4667
 			// "Assume" the file resides on $boarddir somewhere...
4417
-			else
4418
-				log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4668
+			else {
4669
+							log_error(sprintf($txt['hook_fail_call_to'], $function, $boarddir), 'general');
4670
+			}
4419 4671
 		}
4420 4672
 	}
4421 4673
 
@@ -4437,12 +4689,14 @@  discard block
 block discarded – undo
4437 4689
 	global $smcFunc, $modSettings;
4438 4690
 
4439 4691
 	// Any objects?
4440
-	if ($object)
4441
-		$function = $function . '#';
4692
+	if ($object) {
4693
+			$function = $function . '#';
4694
+	}
4442 4695
 
4443 4696
 	// Any files  to load?
4444
-	if (!empty($file) && is_string($file))
4445
-		$function = $file . (!empty($function) ? '|' . $function : '');
4697
+	if (!empty($file) && is_string($file)) {
4698
+			$function = $file . (!empty($function) ? '|' . $function : '');
4699
+	}
4446 4700
 
4447 4701
 	// Get the correct string.
4448 4702
 	$integration_call = $function;
@@ -4464,13 +4718,14 @@  discard block
 block discarded – undo
4464 4718
 		if (!empty($current_functions))
4465 4719
 		{
4466 4720
 			$current_functions = explode(',', $current_functions);
4467
-			if (in_array($integration_call, $current_functions))
4468
-				return;
4721
+			if (in_array($integration_call, $current_functions)) {
4722
+							return;
4723
+			}
4469 4724
 
4470 4725
 			$permanent_functions = array_merge($current_functions, array($integration_call));
4726
+		} else {
4727
+					$permanent_functions = array($integration_call);
4471 4728
 		}
4472
-		else
4473
-			$permanent_functions = array($integration_call);
4474 4729
 
4475 4730
 		updateSettings(array($hook => implode(',', $permanent_functions)));
4476 4731
 	}
@@ -4479,8 +4734,9 @@  discard block
 block discarded – undo
4479 4734
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4480 4735
 
4481 4736
 	// Do nothing, if it's already there.
4482
-	if (in_array($integration_call, $functions))
4483
-		return;
4737
+	if (in_array($integration_call, $functions)) {
4738
+			return;
4739
+	}
4484 4740
 
4485 4741
 	$functions[] = $integration_call;
4486 4742
 	$modSettings[$hook] = implode(',', $functions);
@@ -4503,12 +4759,14 @@  discard block
 block discarded – undo
4503 4759
 	global $smcFunc, $modSettings;
4504 4760
 
4505 4761
 	// Any objects?
4506
-	if ($object)
4507
-		$function = $function . '#';
4762
+	if ($object) {
4763
+			$function = $function . '#';
4764
+	}
4508 4765
 
4509 4766
 	// Any files  to load?
4510
-	if (!empty($file) && is_string($file))
4511
-		$function = $file . '|' . $function;
4767
+	if (!empty($file) && is_string($file)) {
4768
+			$function = $file . '|' . $function;
4769
+	}
4512 4770
 
4513 4771
 	// Get the correct string.
4514 4772
 	$integration_call = $function;
@@ -4529,16 +4787,18 @@  discard block
 block discarded – undo
4529 4787
 	{
4530 4788
 		$current_functions = explode(',', $current_functions);
4531 4789
 
4532
-		if (in_array($integration_call, $current_functions))
4533
-			updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4790
+		if (in_array($integration_call, $current_functions)) {
4791
+					updateSettings(array($hook => implode(',', array_diff($current_functions, array($integration_call)))));
4792
+		}
4534 4793
 	}
4535 4794
 
4536 4795
 	// Turn the function list into something usable.
4537 4796
 	$functions = empty($modSettings[$hook]) ? array() : explode(',', $modSettings[$hook]);
4538 4797
 
4539 4798
 	// You can only remove it if it's available.
4540
-	if (!in_array($integration_call, $functions))
4541
-		return;
4799
+	if (!in_array($integration_call, $functions)) {
4800
+			return;
4801
+	}
4542 4802
 
4543 4803
 	$functions = array_diff($functions, array($integration_call));
4544 4804
 	$modSettings[$hook] = implode(',', $functions);
@@ -4559,17 +4819,20 @@  discard block
 block discarded – undo
4559 4819
 	global $context, $smcFunc, $txt, $db_show_debug;
4560 4820
 
4561 4821
 	// Really?
4562
-	if (empty($string))
4563
-		return false;
4822
+	if (empty($string)) {
4823
+			return false;
4824
+	}
4564 4825
 
4565 4826
 	// An array? should be a "callable" array IE array(object/class, valid_callable).
4566 4827
 	// A closure? should be a callable one.
4567
-	if (is_array($string) || $string instanceof Closure)
4568
-		return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4828
+	if (is_array($string) || $string instanceof Closure) {
4829
+			return $return ? $string : (is_callable($string) ? call_user_func($string) : false);
4830
+	}
4569 4831
 
4570 4832
 	// No full objects, sorry! pass a method or a property instead!
4571
-	if (is_object($string))
4572
-		return false;
4833
+	if (is_object($string)) {
4834
+			return false;
4835
+	}
4573 4836
 
4574 4837
 	// Stay vitaminized my friends...
4575 4838
 	$string = $smcFunc['htmlspecialchars']($smcFunc['htmltrim']($string));
@@ -4578,8 +4841,9 @@  discard block
 block discarded – undo
4578 4841
 	$string = load_file($string);
4579 4842
 
4580 4843
 	// Loaded file failed
4581
-	if (empty($string))
4582
-		return false;
4844
+	if (empty($string)) {
4845
+			return false;
4846
+	}
4583 4847
 
4584 4848
 	// Found a method.
4585 4849
 	if (strpos($string, '::') !== false)
@@ -4600,8 +4864,9 @@  discard block
 block discarded – undo
4600 4864
 				// Add another one to the list.
4601 4865
 				if ($db_show_debug === true)
4602 4866
 				{
4603
-					if (!isset($context['debug']['instances']))
4604
-						$context['debug']['instances'] = array();
4867
+					if (!isset($context['debug']['instances'])) {
4868
+											$context['debug']['instances'] = array();
4869
+					}
4605 4870
 
4606 4871
 					$context['debug']['instances'][$class] = $class;
4607 4872
 				}
@@ -4611,13 +4876,15 @@  discard block
 block discarded – undo
4611 4876
 		}
4612 4877
 
4613 4878
 		// Right then. This is a call to a static method.
4614
-		else
4615
-			$func = array($class, $method);
4879
+		else {
4880
+					$func = array($class, $method);
4881
+		}
4616 4882
 	}
4617 4883
 
4618 4884
 	// Nope! just a plain regular function.
4619
-	else
4620
-		$func = $string;
4885
+	else {
4886
+			$func = $string;
4887
+	}
4621 4888
 
4622 4889
 	// Right, we got what we need, time to do some checks.
4623 4890
 	if (!is_callable($func, false, $callable_name))
@@ -4633,17 +4900,18 @@  discard block
 block discarded – undo
4633 4900
 	else
4634 4901
 	{
4635 4902
 		// What are we gonna do about it?
4636
-		if ($return)
4637
-			return $func;
4903
+		if ($return) {
4904
+					return $func;
4905
+		}
4638 4906
 
4639 4907
 		// If this is a plain function, avoid the heat of calling call_user_func().
4640 4908
 		else
4641 4909
 		{
4642
-			if (is_array($func))
4643
-				call_user_func($func);
4644
-
4645
-			else
4646
-				$func();
4910
+			if (is_array($func)) {
4911
+							call_user_func($func);
4912
+			} else {
4913
+							$func();
4914
+			}
4647 4915
 		}
4648 4916
 	}
4649 4917
 }
@@ -4660,31 +4928,34 @@  discard block
 block discarded – undo
4660 4928
 {
4661 4929
 	global $sourcedir, $txt, $boarddir, $settings;
4662 4930
 
4663
-	if (empty($string))
4664
-		return false;
4931
+	if (empty($string)) {
4932
+			return false;
4933
+	}
4665 4934
 
4666 4935
 	if (strpos($string, '|') !== false)
4667 4936
 	{
4668 4937
 		list ($file, $string) = explode('|', $string);
4669 4938
 
4670 4939
 		// Match the wildcards to their regular vars.
4671
-		if (empty($settings['theme_dir']))
4672
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4673
-
4674
-		else
4675
-			$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4940
+		if (empty($settings['theme_dir'])) {
4941
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
4942
+		} else {
4943
+					$absPath = strtr(trim($file), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
4944
+		}
4676 4945
 
4677 4946
 		// Load the file if it can be loaded.
4678
-		if (file_exists($absPath))
4679
-			require_once($absPath);
4947
+		if (file_exists($absPath)) {
4948
+					require_once($absPath);
4949
+		}
4680 4950
 
4681 4951
 		// No? try a fallback to $sourcedir
4682 4952
 		else
4683 4953
 		{
4684 4954
 			$absPath = $sourcedir .'/'. $file;
4685 4955
 
4686
-			if (file_exists($absPath))
4687
-				require_once($absPath);
4956
+			if (file_exists($absPath)) {
4957
+							require_once($absPath);
4958
+			}
4688 4959
 
4689 4960
 			// Sorry, can't do much for you at this point.
4690 4961
 			else
@@ -4711,8 +4982,9 @@  discard block
 block discarded – undo
4711 4982
 	global $user_info, $smcFunc;
4712 4983
 
4713 4984
 	// Make sure we have something to work with.
4714
-	if (empty($topic))
4715
-		return array();
4985
+	if (empty($topic)) {
4986
+			return array();
4987
+	}
4716 4988
 
4717 4989
 
4718 4990
 	// We already know the number of likes per message, we just want to know whether the current user liked it or not.
@@ -4735,8 +5007,9 @@  discard block
 block discarded – undo
4735 5007
 				'topic' => $topic,
4736 5008
 			)
4737 5009
 		);
4738
-		while ($row = $smcFunc['db_fetch_assoc']($request))
4739
-			$temp[] = (int) $row['content_id'];
5010
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
5011
+					$temp[] = (int) $row['content_id'];
5012
+		}
4740 5013
 
4741 5014
 		cache_put_data($cache_key, $temp, $ttl);
4742 5015
 	}
@@ -4757,8 +5030,9 @@  discard block
 block discarded – undo
4757 5030
 {
4758 5031
 	global $context;
4759 5032
 
4760
-	if (empty($string))
4761
-		return $string;
5033
+	if (empty($string)) {
5034
+			return $string;
5035
+	}
4762 5036
 
4763 5037
 	// UTF-8 occurences of MS special characters
4764 5038
 	$findchars_utf8 = array(
@@ -4799,10 +5073,11 @@  discard block
 block discarded – undo
4799 5073
 		'--',	// &mdash;
4800 5074
 	);
4801 5075
 
4802
-	if ($context['utf8'])
4803
-		$string = str_replace($findchars_utf8, $replacechars, $string);
4804
-	else
4805
-		$string = str_replace($findchars_iso, $replacechars, $string);
5076
+	if ($context['utf8']) {
5077
+			$string = str_replace($findchars_utf8, $replacechars, $string);
5078
+	} else {
5079
+			$string = str_replace($findchars_iso, $replacechars, $string);
5080
+	}
4806 5081
 
4807 5082
 	return $string;
4808 5083
 }
@@ -4821,49 +5096,59 @@  discard block
 block discarded – undo
4821 5096
 {
4822 5097
 	global $context;
4823 5098
 
4824
-	if (!isset($matches[2]))
4825
-		return '';
5099
+	if (!isset($matches[2])) {
5100
+			return '';
5101
+	}
4826 5102
 
4827 5103
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4828 5104
 
4829 5105
 	// remove left to right / right to left overrides
4830
-	if ($num === 0x202D || $num === 0x202E)
4831
-		return '';
5106
+	if ($num === 0x202D || $num === 0x202E) {
5107
+			return '';
5108
+	}
4832 5109
 
4833 5110
 	// Quote, Ampersand, Apostrophe, Less/Greater Than get html replaced
4834
-	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E)))
4835
-		return '&#' . $num . ';';
5111
+	if (in_array($num, array(0x22, 0x26, 0x27, 0x3C, 0x3E))) {
5112
+			return '&#' . $num . ';';
5113
+	}
4836 5114
 
4837 5115
 	if (empty($context['utf8']))
4838 5116
 	{
4839 5117
 		// no control characters
4840
-		if ($num < 0x20)
4841
-			return '';
5118
+		if ($num < 0x20) {
5119
+					return '';
5120
+		}
4842 5121
 		// text is text
4843
-		elseif ($num < 0x80)
4844
-			return chr($num);
5122
+		elseif ($num < 0x80) {
5123
+					return chr($num);
5124
+		}
4845 5125
 		// all others get html-ised
4846
-		else
4847
-			return '&#' . $matches[2] . ';';
4848
-	}
4849
-	else
5126
+		else {
5127
+					return '&#' . $matches[2] . ';';
5128
+		}
5129
+	} else
4850 5130
 	{
4851 5131
 		// <0x20 are control characters, 0x20 is a space, > 0x10FFFF is past the end of the utf8 character set
4852 5132
 		// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text)
4853
-		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF))
4854
-			return '';
5133
+		if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF)) {
5134
+					return '';
5135
+		}
4855 5136
 		// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4856
-		elseif ($num < 0x80)
4857
-			return chr($num);
5137
+		elseif ($num < 0x80) {
5138
+					return chr($num);
5139
+		}
4858 5140
 		// <0x800 (2048)
4859
-		elseif ($num < 0x800)
4860
-			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5141
+		elseif ($num < 0x800) {
5142
+					return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5143
+		}
4861 5144
 		// < 0x10000 (65536)
4862
-		elseif ($num < 0x10000)
4863
-			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5145
+		elseif ($num < 0x10000) {
5146
+					return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5147
+		}
4864 5148
 		// <= 0x10FFFF (1114111)
4865
-		else
4866
-			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5149
+		else {
5150
+					return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5151
+		}
4867 5152
 	}
4868 5153
 }
4869 5154
 
@@ -4879,28 +5164,34 @@  discard block
 block discarded – undo
4879 5164
  */
4880 5165
 function fixchar__callback($matches)
4881 5166
 {
4882
-	if (!isset($matches[1]))
4883
-		return '';
5167
+	if (!isset($matches[1])) {
5168
+			return '';
5169
+	}
4884 5170
 
4885 5171
 	$num = $matches[1][0] === 'x' ? hexdec(substr($matches[1], 1)) : (int) $matches[1];
4886 5172
 
4887 5173
 	// <0x20 are control characters, > 0x10FFFF is past the end of the utf8 character set
4888 5174
 	// 0xD800 >= $num <= 0xDFFF are surrogate markers (not valid for utf8 text), 0x202D-E are left to right overrides
4889
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E)
4890
-		return '';
5175
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num === 0x202D || $num === 0x202E) {
5176
+			return '';
5177
+	}
4891 5178
 	// <0x80 (or less than 128) are standard ascii characters a-z A-Z 0-9 and punctuation
4892
-	elseif ($num < 0x80)
4893
-		return chr($num);
5179
+	elseif ($num < 0x80) {
5180
+			return chr($num);
5181
+	}
4894 5182
 	// <0x800 (2048)
4895
-	elseif ($num < 0x800)
4896
-		return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5183
+	elseif ($num < 0x800) {
5184
+			return chr(($num >> 6) + 192) . chr(($num & 63) + 128);
5185
+	}
4897 5186
 	// < 0x10000 (65536)
4898
-	elseif ($num < 0x10000)
4899
-		return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5187
+	elseif ($num < 0x10000) {
5188
+			return chr(($num >> 12) + 224) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5189
+	}
4900 5190
 	// <= 0x10FFFF (1114111)
4901
-	else
4902
-		return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
4903
-}
5191
+	else {
5192
+			return chr(($num >> 18) + 240) . chr((($num >> 12) & 63) + 128) . chr((($num >> 6) & 63) + 128) . chr(($num & 63) + 128);
5193
+	}
5194
+	}
4904 5195
 
4905 5196
 /**
4906 5197
  * Strips out invalid html entities, replaces others with html style &#123; codes
@@ -4913,17 +5204,19 @@  discard block
 block discarded – undo
4913 5204
  */
4914 5205
 function entity_fix__callback($matches)
4915 5206
 {
4916
-	if (!isset($matches[2]))
4917
-		return '';
5207
+	if (!isset($matches[2])) {
5208
+			return '';
5209
+	}
4918 5210
 
4919 5211
 	$num = $matches[2][0] === 'x' ? hexdec(substr($matches[2], 1)) : (int) $matches[2];
4920 5212
 
4921 5213
 	// we don't allow control characters, characters out of range, byte markers, etc
4922
-	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E)
4923
-		return '';
4924
-	else
4925
-		return '&#' . $num . ';';
4926
-}
5214
+	if ($num < 0x20 || $num > 0x10FFFF || ($num >= 0xD800 && $num <= 0xDFFF) || $num == 0x202D || $num == 0x202E) {
5215
+			return '';
5216
+	} else {
5217
+			return '&#' . $num . ';';
5218
+	}
5219
+	}
4927 5220
 
4928 5221
 /**
4929 5222
  * Return a Gravatar URL based on
@@ -4947,18 +5240,23 @@  discard block
 block discarded – undo
4947 5240
 		$ratings = array('G', 'PG', 'R', 'X');
4948 5241
 		$defaults = array('mm', 'identicon', 'monsterid', 'wavatar', 'retro', 'blank');
4949 5242
 		$url_params = array();
4950
-		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings))
4951
-			$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
4952
-		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults))
4953
-			$url_params[] = 'default=' . $modSettings['gravatarDefault'];
4954
-		if (!empty($modSettings['avatar_max_width_external']))
4955
-			$size_string = (int) $modSettings['avatar_max_width_external'];
4956
-		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string))
4957
-			if ((int) $modSettings['avatar_max_height_external'] < $size_string)
5243
+		if (!empty($modSettings['gravatarMaxRating']) && in_array($modSettings['gravatarMaxRating'], $ratings)) {
5244
+					$url_params[] = 'rating=' . $modSettings['gravatarMaxRating'];
5245
+		}
5246
+		if (!empty($modSettings['gravatarDefault']) && in_array($modSettings['gravatarDefault'], $defaults)) {
5247
+					$url_params[] = 'default=' . $modSettings['gravatarDefault'];
5248
+		}
5249
+		if (!empty($modSettings['avatar_max_width_external'])) {
5250
+					$size_string = (int) $modSettings['avatar_max_width_external'];
5251
+		}
5252
+		if (!empty($modSettings['avatar_max_height_external']) && !empty($size_string)) {
5253
+					if ((int) $modSettings['avatar_max_height_external'] < $size_string)
4958 5254
 				$size_string = $modSettings['avatar_max_height_external'];
5255
+		}
4959 5256
 
4960
-		if (!empty($size_string))
4961
-			$url_params[] = 's=' . $size_string;
5257
+		if (!empty($size_string)) {
5258
+					$url_params[] = 's=' . $size_string;
5259
+		}
4962 5260
 	}
4963 5261
 	$http_method = !empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 ? 'https://secure' : 'http://www';
4964 5262
 
@@ -4977,22 +5275,26 @@  discard block
 block discarded – undo
4977 5275
 	static $timezones = null, $lastwhen = null;
4978 5276
 
4979 5277
 	// No point doing this over if we already did it once
4980
-	if (!empty($timezones) && $when == $lastwhen)
4981
-		return $timezones;
4982
-	else
4983
-		$lastwhen = $when;
5278
+	if (!empty($timezones) && $when == $lastwhen) {
5279
+			return $timezones;
5280
+	} else {
5281
+			$lastwhen = $when;
5282
+	}
4984 5283
 
4985 5284
 	// Parseable datetime string?
4986
-	if (is_int($timestamp = strtotime($when)))
4987
-		$when = $timestamp;
5285
+	if (is_int($timestamp = strtotime($when))) {
5286
+			$when = $timestamp;
5287
+	}
4988 5288
 
4989 5289
 	// A Unix timestamp?
4990
-	elseif (is_numeric($when))
4991
-		$when = intval($when);
5290
+	elseif (is_numeric($when)) {
5291
+			$when = intval($when);
5292
+	}
4992 5293
 
4993 5294
 	// Invalid value? Just get current Unix timestamp.
4994
-	else
4995
-		$when = time();
5295
+	else {
5296
+			$when = time();
5297
+	}
4996 5298
 
4997 5299
 	// We'll need these too
4998 5300
 	$date_when = date_create('@' . $when);
@@ -5056,8 +5358,9 @@  discard block
 block discarded – undo
5056 5358
 	foreach ($priority_countries as $country)
5057 5359
 	{
5058 5360
 		$country_tzids = @timezone_identifiers_list(DateTimeZone::PER_COUNTRY, strtoupper(trim($country)));
5059
-		if (!empty($country_tzids))
5060
-			$priority_tzids = array_merge($priority_tzids, $country_tzids);
5361
+		if (!empty($country_tzids)) {
5362
+					$priority_tzids = array_merge($priority_tzids, $country_tzids);
5363
+		}
5061 5364
 	}
5062 5365
 
5063 5366
 	// Process the preferred timezones first, then the rest.
@@ -5067,8 +5370,9 @@  discard block
 block discarded – undo
5067 5370
 	foreach ($tzids as $tzid)
5068 5371
 	{
5069 5372
 		// We don't want UTC right now
5070
-		if ($tzid == 'UTC')
5071
-			continue;
5373
+		if ($tzid == 'UTC') {
5374
+					continue;
5375
+		}
5072 5376
 
5073 5377
 		$tz = timezone_open($tzid);
5074 5378
 
@@ -5089,8 +5393,9 @@  discard block
 block discarded – undo
5089 5393
 		}
5090 5394
 
5091 5395
 		// A time zone from a prioritized country?
5092
-		if (in_array($tzid, $priority_tzids))
5093
-			$priority_zones[$tzkey] = true;
5396
+		if (in_array($tzid, $priority_tzids)) {
5397
+					$priority_zones[$tzkey] = true;
5398
+		}
5094 5399
 
5095 5400
 		// Keep track of the location and offset for this tzid
5096 5401
 		$tzid_parts = explode('/', $tzid);
@@ -5109,15 +5414,17 @@  discard block
 block discarded – undo
5109 5414
 	{
5110 5415
 		date_timezone_set($date_when, timezone_open($tzvalue['tzid']));
5111 5416
 
5112
-		if (!empty($timezone_descriptions[$tzvalue['tzid']]))
5113
-			$desc = $timezone_descriptions[$tzvalue['tzid']];
5114
-		else
5115
-			$desc = implode(', ', array_unique($tzvalue['locations']));
5417
+		if (!empty($timezone_descriptions[$tzvalue['tzid']])) {
5418
+					$desc = $timezone_descriptions[$tzvalue['tzid']];
5419
+		} else {
5420
+					$desc = implode(', ', array_unique($tzvalue['locations']));
5421
+		}
5116 5422
 
5117
-		if (isset($priority_zones[$tzkey]))
5118
-			$priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5119
-		else
5120
-			$timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5423
+		if (isset($priority_zones[$tzkey])) {
5424
+					$priority_timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5425
+		} else {
5426
+					$timezones[$tzvalue['tzid']] = $tzvalue['abbr'] . ' - ' . $desc . ' [UTC' . date_format($date_when, 'P') . ']';
5427
+		}
5121 5428
 	}
5122 5429
 
5123 5430
 	$timezones = array_merge(
@@ -5171,9 +5478,9 @@  discard block
 block discarded – undo
5171 5478
 			'Indian/Kerguelen' => 'TFT',
5172 5479
 		);
5173 5480
 
5174
-		if (!empty($missing_tz_abbrs[$tzid]))
5175
-			$tz_abbrev = $missing_tz_abbrs[$tzid];
5176
-		else
5481
+		if (!empty($missing_tz_abbrs[$tzid])) {
5482
+					$tz_abbrev = $missing_tz_abbrs[$tzid];
5483
+		} else
5177 5484
 		{
5178 5485
 			// Russia likes to experiment with time zones often, and names them as offsets from Moscow
5179 5486
 			$tz_location = timezone_location_get(timezone_open($tzid));
@@ -5201,8 +5508,9 @@  discard block
 block discarded – undo
5201 5508
  */
5202 5509
 function inet_ptod($ip_address)
5203 5510
 {
5204
-	if (!isValidIP($ip_address))
5205
-		return $ip_address;
5511
+	if (!isValidIP($ip_address)) {
5512
+			return $ip_address;
5513
+	}
5206 5514
 
5207 5515
 	$bin = inet_pton($ip_address);
5208 5516
 	return $bin;
@@ -5214,13 +5522,15 @@  discard block
 block discarded – undo
5214 5522
  */
5215 5523
 function inet_dtop($bin)
5216 5524
 {
5217
-	if(empty($bin))
5218
-		return '';
5525
+	if(empty($bin)) {
5526
+			return '';
5527
+	}
5219 5528
 
5220 5529
 	global $db_type;
5221 5530
 
5222
-	if ($db_type == 'postgresql')
5223
-		return $bin;
5531
+	if ($db_type == 'postgresql') {
5532
+			return $bin;
5533
+	}
5224 5534
 
5225 5535
 	$ip_address = inet_ntop($bin);
5226 5536
 
@@ -5245,26 +5555,32 @@  discard block
 block discarded – undo
5245 5555
  */
5246 5556
 function _safe_serialize($value)
5247 5557
 {
5248
-	if(is_null($value))
5249
-		return 'N;';
5558
+	if(is_null($value)) {
5559
+			return 'N;';
5560
+	}
5250 5561
 
5251
-	if(is_bool($value))
5252
-		return 'b:'. (int) $value .';';
5562
+	if(is_bool($value)) {
5563
+			return 'b:'. (int) $value .';';
5564
+	}
5253 5565
 
5254
-	if(is_int($value))
5255
-		return 'i:'. $value .';';
5566
+	if(is_int($value)) {
5567
+			return 'i:'. $value .';';
5568
+	}
5256 5569
 
5257
-	if(is_float($value))
5258
-		return 'd:'. str_replace(',', '.', $value) .';';
5570
+	if(is_float($value)) {
5571
+			return 'd:'. str_replace(',', '.', $value) .';';
5572
+	}
5259 5573
 
5260
-	if(is_string($value))
5261
-		return 's:'. strlen($value) .':"'. $value .'";';
5574
+	if(is_string($value)) {
5575
+			return 's:'. strlen($value) .':"'. $value .'";';
5576
+	}
5262 5577
 
5263 5578
 	if(is_array($value))
5264 5579
 	{
5265 5580
 		$out = '';
5266
-		foreach($value as $k => $v)
5267
-			$out .= _safe_serialize($k) . _safe_serialize($v);
5581
+		foreach($value as $k => $v) {
5582
+					$out .= _safe_serialize($k) . _safe_serialize($v);
5583
+		}
5268 5584
 
5269 5585
 		return 'a:'. count($value) .':{'. $out .'}';
5270 5586
 	}
@@ -5290,8 +5606,9 @@  discard block
 block discarded – undo
5290 5606
 
5291 5607
 	$out = _safe_serialize($value);
5292 5608
 
5293
-	if (isset($mbIntEnc))
5294
-		mb_internal_encoding($mbIntEnc);
5609
+	if (isset($mbIntEnc)) {
5610
+			mb_internal_encoding($mbIntEnc);
5611
+	}
5295 5612
 
5296 5613
 	return $out;
5297 5614
 }
@@ -5308,8 +5625,9 @@  discard block
 block discarded – undo
5308 5625
 function _safe_unserialize($str)
5309 5626
 {
5310 5627
 	// Input  is not a string.
5311
-	if(empty($str) || !is_string($str))
5312
-		return false;
5628
+	if(empty($str) || !is_string($str)) {
5629
+			return false;
5630
+	}
5313 5631
 
5314 5632
 	$stack = array();
5315 5633
 	$expected = array();
@@ -5325,43 +5643,38 @@  discard block
 block discarded – undo
5325 5643
 	while($state != 1)
5326 5644
 	{
5327 5645
 		$type = isset($str[0]) ? $str[0] : '';
5328
-		if($type == '}')
5329
-			$str = substr($str, 1);
5330
-
5331
-		else if($type == 'N' && $str[1] == ';')
5646
+		if($type == '}') {
5647
+					$str = substr($str, 1);
5648
+		} else if($type == 'N' && $str[1] == ';')
5332 5649
 		{
5333 5650
 			$value = null;
5334 5651
 			$str = substr($str, 2);
5335
-		}
5336
-		else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5652
+		} else if($type == 'b' && preg_match('/^b:([01]);/', $str, $matches))
5337 5653
 		{
5338 5654
 			$value = $matches[1] == '1' ? true : false;
5339 5655
 			$str = substr($str, 4);
5340
-		}
5341
-		else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5656
+		} else if($type == 'i' && preg_match('/^i:(-?[0-9]+);(.*)/s', $str, $matches))
5342 5657
 		{
5343 5658
 			$value = (int)$matches[1];
5344 5659
 			$str = $matches[2];
5345
-		}
5346
-		else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5660
+		} else if($type == 'd' && preg_match('/^d:(-?[0-9]+\.?[0-9]*(E[+-][0-9]+)?);(.*)/s', $str, $matches))
5347 5661
 		{
5348 5662
 			$value = (float)$matches[1];
5349 5663
 			$str = $matches[3];
5350
-		}
5351
-		else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5664
+		} else if($type == 's' && preg_match('/^s:([0-9]+):"(.*)/s', $str, $matches) && substr($matches[2], (int)$matches[1], 2) == '";')
5352 5665
 		{
5353 5666
 			$value = substr($matches[2], 0, (int)$matches[1]);
5354 5667
 			$str = substr($matches[2], (int)$matches[1] + 2);
5355
-		}
5356
-		else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5668
+		} else if($type == 'a' && preg_match('/^a:([0-9]+):{(.*)/s', $str, $matches))
5357 5669
 		{
5358 5670
 			$expectedLength = (int)$matches[1];
5359 5671
 			$str = $matches[2];
5360 5672
 		}
5361 5673
 
5362 5674
 		// Object or unknown/malformed type.
5363
-		else
5364
-			return false;
5675
+		else {
5676
+					return false;
5677
+		}
5365 5678
 
5366 5679
 		switch($state)
5367 5680
 		{
@@ -5389,8 +5702,9 @@  discard block
 block discarded – undo
5389 5702
 				if($type == '}')
5390 5703
 				{
5391 5704
 					// Array size is less than expected.
5392
-					if(count($list) < end($expected))
5393
-						return false;
5705
+					if(count($list) < end($expected)) {
5706
+											return false;
5707
+					}
5394 5708
 
5395 5709
 					unset($list);
5396 5710
 					$list = &$stack[count($stack)-1];
@@ -5399,8 +5713,9 @@  discard block
 block discarded – undo
5399 5713
 					// Go to terminal state if we're at the end of the root array.
5400 5714
 					array_pop($expected);
5401 5715
 
5402
-					if(count($expected) == 0)
5403
-						$state = 1;
5716
+					if(count($expected) == 0) {
5717
+											$state = 1;
5718
+					}
5404 5719
 
5405 5720
 					break;
5406 5721
 				}
@@ -5408,8 +5723,9 @@  discard block
 block discarded – undo
5408 5723
 				if($type == 'i' || $type == 's')
5409 5724
 				{
5410 5725
 					// Array size exceeds expected length.
5411
-					if(count($list) >= end($expected))
5412
-						return false;
5726
+					if(count($list) >= end($expected)) {
5727
+											return false;
5728
+					}
5413 5729
 
5414 5730
 					$key = $value;
5415 5731
 					$state = 3;
@@ -5443,8 +5759,9 @@  discard block
 block discarded – undo
5443 5759
 	}
5444 5760
 
5445 5761
 	// Trailing data in input.
5446
-	if(!empty($str))
5447
-		return false;
5762
+	if(!empty($str)) {
5763
+			return false;
5764
+	}
5448 5765
 
5449 5766
 	return $data;
5450 5767
 }
@@ -5467,8 +5784,9 @@  discard block
 block discarded – undo
5467 5784
 
5468 5785
 	$out = _safe_unserialize($str);
5469 5786
 
5470
-	if (isset($mbIntEnc))
5471
-		mb_internal_encoding($mbIntEnc);
5787
+	if (isset($mbIntEnc)) {
5788
+			mb_internal_encoding($mbIntEnc);
5789
+	}
5472 5790
 
5473 5791
 	return $out;
5474 5792
 }
@@ -5483,12 +5801,14 @@  discard block
 block discarded – undo
5483 5801
 function smf_chmod($file, $value = 0)
5484 5802
 {
5485 5803
 	// No file? no checks!
5486
-	if (empty($file))
5487
-		return false;
5804
+	if (empty($file)) {
5805
+			return false;
5806
+	}
5488 5807
 
5489 5808
 	// Already writable?
5490
-	if (is_writable($file))
5491
-		return true;
5809
+	if (is_writable($file)) {
5810
+			return true;
5811
+	}
5492 5812
 
5493 5813
 	// Do we have a file or a dir?
5494 5814
 	$isDir = is_dir($file);
@@ -5504,10 +5824,9 @@  discard block
 block discarded – undo
5504 5824
 		{
5505 5825
 			$isWritable = true;
5506 5826
 			break;
5827
+		} else {
5828
+					@chmod($file, $val);
5507 5829
 		}
5508
-
5509
-		else
5510
-			@chmod($file, $val);
5511 5830
 	}
5512 5831
 
5513 5832
 	return $isWritable;
@@ -5526,8 +5845,9 @@  discard block
 block discarded – undo
5526 5845
 	global $txt;
5527 5846
 
5528 5847
 	// Come on...
5529
-	if (empty($json) || !is_string($json))
5530
-		return array();
5848
+	if (empty($json) || !is_string($json)) {
5849
+			return array();
5850
+	}
5531 5851
 
5532 5852
 	$returnArray = @json_decode($json, $returnAsArray);
5533 5853
 
@@ -5565,11 +5885,11 @@  discard block
 block discarded – undo
5565 5885
 		$jsonDebug = $jsonDebug[0];
5566 5886
 		loadLanguage('Errors');
5567 5887
 
5568
-		if (!empty($jsonDebug))
5569
-			log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5570
-
5571
-		else
5572
-			log_error($txt['json_'. $jsonError], 'critical');
5888
+		if (!empty($jsonDebug)) {
5889
+					log_error($txt['json_'. $jsonError], 'critical', $jsonDebug['file'], $jsonDebug['line']);
5890
+		} else {
5891
+					log_error($txt['json_'. $jsonError], 'critical');
5892
+		}
5573 5893
 
5574 5894
 		// Everyone expects an array.
5575 5895
 		return array();
@@ -5603,8 +5923,9 @@  discard block
 block discarded – undo
5603 5923
 	global $db_show_debug, $modSettings;
5604 5924
 
5605 5925
 	// Defensive programming anyone?
5606
-	if (empty($data))
5607
-		return false;
5926
+	if (empty($data)) {
5927
+			return false;
5928
+	}
5608 5929
 
5609 5930
 	// Don't need extra stuff...
5610 5931
 	$db_show_debug = false;
@@ -5612,11 +5933,11 @@  discard block
 block discarded – undo
5612 5933
 	// Kill anything else.
5613 5934
 	ob_end_clean();
5614 5935
 
5615
-	if (!empty($modSettings['CompressedOutput']))
5616
-		@ob_start('ob_gzhandler');
5617
-
5618
-	else
5619
-		ob_start();
5936
+	if (!empty($modSettings['CompressedOutput'])) {
5937
+			@ob_start('ob_gzhandler');
5938
+	} else {
5939
+			ob_start();
5940
+	}
5620 5941
 
5621 5942
 	// Set the header.
5622 5943
 	header($type);
@@ -5648,8 +5969,9 @@  discard block
 block discarded – undo
5648 5969
 	static $done = false;
5649 5970
 
5650 5971
 	// If we don't need to do anything, don't
5651
-	if (!$update && $done)
5652
-		return;
5972
+	if (!$update && $done) {
5973
+			return;
5974
+	}
5653 5975
 
5654 5976
 	// Should we get a new copy of the official list of TLDs?
5655 5977
 	if ($update)
@@ -5658,8 +5980,9 @@  discard block
 block discarded – undo
5658 5980
 		$tlds = fetch_web_data('https://data.iana.org/TLD/tlds-alpha-by-domain.txt');
5659 5981
 
5660 5982
 		// If the Internet Assigned Numbers Authority can't be reached, the Internet is gone. We're probably running on a server hidden in a bunker deep underground to protect it from marauding bandits roaming on the surface. We don't want to waste precious electricity on pointlessly repeating background tasks, so we'll wait until the next regularly scheduled update to see if civilization has been restored.
5661
-		if ($tlds === false)
5662
-			$postapocalypticNightmare = true;
5983
+		if ($tlds === false) {
5984
+					$postapocalypticNightmare = true;
5985
+		}
5663 5986
 	}
5664 5987
 	// If we aren't updating and the regex is valid, we're done
5665 5988
 	elseif (!empty($modSettings['tld_regex']) && @preg_match('~' . $modSettings['tld_regex'] . '~', null) !== false)
@@ -5674,10 +5997,11 @@  discard block
 block discarded – undo
5674 5997
 		// Clean $tlds and convert it to an array
5675 5998
 		$tlds = array_filter(explode("\n", strtolower($tlds)), function($line) {
5676 5999
 			$line = trim($line);
5677
-			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false)
5678
-				return false;
5679
-			else
5680
-				return true;
6000
+			if (empty($line) || strpos($line, '#') !== false || strpos($line, ' ') !== false) {
6001
+							return false;
6002
+			} else {
6003
+							return true;
6004
+			}
5681 6005
 		});
5682 6006
 
5683 6007
 		// Convert Punycode to Unicode
@@ -5731,8 +6055,9 @@  discard block
 block discarded – undo
5731 6055
 						$idx += $digit * $w;
5732 6056
 						$t = ($k <= $bias) ? $tmin : (($k >= $bias + $tmax) ? $tmax : ($k - $bias));
5733 6057
 
5734
-						if ($digit < $t)
5735
-							break;
6058
+						if ($digit < $t) {
6059
+													break;
6060
+						}
5736 6061
 
5737 6062
 						$w = (int) ($w * ($base - $t));
5738 6063
 					}
@@ -5741,8 +6066,9 @@  discard block
 block discarded – undo
5741 6066
 					$delta = intval($is_first ? ($delta / $damp) : ($delta / 2));
5742 6067
 					$delta += intval($delta / ($deco_len + 1));
5743 6068
 
5744
-					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base)
5745
-						$delta = intval($delta / ($base - $tmin));
6069
+					for ($k = 0; $delta > (($base - $tmin) * $tmax) / 2; $k += $base) {
6070
+											$delta = intval($delta / ($base - $tmin));
6071
+					}
5746 6072
 
5747 6073
 					$bias = intval($k + ($base - $tmin + 1) * $delta / ($delta + $skew));
5748 6074
 					$is_first = false;
@@ -5751,8 +6077,9 @@  discard block
 block discarded – undo
5751 6077
 
5752 6078
 					if ($deco_len > 0)
5753 6079
 					{
5754
-						for ($i = $deco_len; $i > $idx; $i--)
5755
-							$decoded[$i] = $decoded[($i - 1)];
6080
+						for ($i = $deco_len; $i > $idx; $i--) {
6081
+													$decoded[$i] = $decoded[($i - 1)];
6082
+						}
5756 6083
 					}
5757 6084
 					$decoded[$idx++] = $char;
5758 6085
 				}
@@ -5760,24 +6087,29 @@  discard block
 block discarded – undo
5760 6087
 				foreach ($decoded as $k => $v)
5761 6088
 				{
5762 6089
 					// 7bit are transferred literally
5763
-					if ($v < 128)
5764
-						$output .= chr($v);
6090
+					if ($v < 128) {
6091
+											$output .= chr($v);
6092
+					}
5765 6093
 
5766 6094
 					// 2 bytes
5767
-					elseif ($v < (1 << 11))
5768
-						$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
6095
+					elseif ($v < (1 << 11)) {
6096
+											$output .= chr(192+($v >> 6)) . chr(128+($v & 63));
6097
+					}
5769 6098
 
5770 6099
 					// 3 bytes
5771
-					elseif ($v < (1 << 16))
5772
-						$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6100
+					elseif ($v < (1 << 16)) {
6101
+											$output .= chr(224+($v >> 12)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6102
+					}
5773 6103
 
5774 6104
 					// 4 bytes
5775
-					elseif ($v < (1 << 21))
5776
-						$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6105
+					elseif ($v < (1 << 21)) {
6106
+											$output .= chr(240+($v >> 18)) . chr(128+(($v >> 12) & 63)) . chr(128+(($v >> 6) & 63)) . chr(128+($v & 63));
6107
+					}
5777 6108
 
5778 6109
 					//  'Conversion from UCS-4 to UTF-8 failed: malformed input at byte '.$k
5779
-					else
5780
-						$output .= $safe_char;
6110
+					else {
6111
+											$output .= $safe_char;
6112
+					}
5781 6113
 				}
5782 6114
 
5783 6115
 				$output_parts[] = $output;
@@ -5870,8 +6202,7 @@  discard block
 block discarded – undo
5870 6202
 
5871 6203
 		$strlen = 'mb_strlen';
5872 6204
 		$substr = 'mb_substr';
5873
-	}
5874
-	else
6205
+	} else
5875 6206
 	{
5876 6207
 		$strlen = $smcFunc['strlen'];
5877 6208
 		$substr = $smcFunc['substr'];
@@ -5885,20 +6216,21 @@  discard block
 block discarded – undo
5885 6216
 
5886 6217
 		$first = $substr($string, 0, 1);
5887 6218
 
5888
-		if (empty($index[$first]))
5889
-			$index[$first] = array();
6219
+		if (empty($index[$first])) {
6220
+					$index[$first] = array();
6221
+		}
5890 6222
 
5891 6223
 		if ($strlen($string) > 1)
5892 6224
 		{
5893 6225
 			// Sanity check on recursion
5894
-			if ($depth > 99)
5895
-				$index[$first][$substr($string, 1)] = '';
5896
-
5897
-			else
5898
-				$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6226
+			if ($depth > 99) {
6227
+							$index[$first][$substr($string, 1)] = '';
6228
+			} else {
6229
+							$index[$first] = $add_string_to_index($substr($string, 1), $index[$first]);
6230
+			}
6231
+		} else {
6232
+					$index[$first][''] = '';
5899 6233
 		}
5900
-		else
5901
-			$index[$first][''] = '';
5902 6234
 
5903 6235
 		$depth--;
5904 6236
 		return $index;
@@ -5921,9 +6253,9 @@  discard block
 block discarded – undo
5921 6253
 			$key_regex = preg_quote($key, $delim);
5922 6254
 			$new_key = $key;
5923 6255
 
5924
-			if (empty($value))
5925
-				$sub_regex = '';
5926
-			else
6256
+			if (empty($value)) {
6257
+							$sub_regex = '';
6258
+			} else
5927 6259
 			{
5928 6260
 				$sub_regex = $index_to_regex($value, $delim);
5929 6261
 
@@ -5931,22 +6263,22 @@  discard block
 block discarded – undo
5931 6263
 				{
5932 6264
 					$new_key_array = explode('(?'.'>', $sub_regex);
5933 6265
 					$new_key .= $new_key_array[0];
6266
+				} else {
6267
+									$sub_regex = '(?'.'>' . $sub_regex . ')';
5934 6268
 				}
5935
-				else
5936
-					$sub_regex = '(?'.'>' . $sub_regex . ')';
5937 6269
 			}
5938 6270
 
5939
-			if ($depth > 1)
5940
-				$regex[$new_key] = $key_regex . $sub_regex;
5941
-			else
6271
+			if ($depth > 1) {
6272
+							$regex[$new_key] = $key_regex . $sub_regex;
6273
+			} else
5942 6274
 			{
5943 6275
 				if (($length += strlen($key_regex) + 1) < $max_length || empty($regex))
5944 6276
 				{
5945 6277
 					$regex[$new_key] = $key_regex . $sub_regex;
5946 6278
 					unset($index[$key]);
6279
+				} else {
6280
+									break;
5947 6281
 				}
5948
-				else
5949
-					break;
5950 6282
 			}
5951 6283
 		}
5952 6284
 
@@ -5955,10 +6287,11 @@  discard block
 block discarded – undo
5955 6287
 			$l1 = $strlen($k1);
5956 6288
 			$l2 = $strlen($k2);
5957 6289
 
5958
-			if ($l1 == $l2)
5959
-				return strcmp($k1, $k2) > 0 ? 1 : -1;
5960
-			else
5961
-				return $l1 > $l2 ? -1 : 1;
6290
+			if ($l1 == $l2) {
6291
+							return strcmp($k1, $k2) > 0 ? 1 : -1;
6292
+			} else {
6293
+							return $l1 > $l2 ? -1 : 1;
6294
+			}
5962 6295
 		});
5963 6296
 
5964 6297
 		$depth--;
@@ -5969,21 +6302,24 @@  discard block
 block discarded – undo
5969 6302
 	$index = array();
5970 6303
 	$regex = '';
5971 6304
 
5972
-	foreach ($strings as $string)
5973
-		$index = $add_string_to_index($string, $index);
6305
+	foreach ($strings as $string) {
6306
+			$index = $add_string_to_index($string, $index);
6307
+	}
5974 6308
 
5975 6309
 	if ($returnArray === true)
5976 6310
 	{
5977 6311
 		$regex = array();
5978
-		while (!empty($index))
5979
-			$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6312
+		while (!empty($index)) {
6313
+					$regex[] = '(?'.'>' . $index_to_regex($index, $delim) . ')';
6314
+		}
6315
+	} else {
6316
+			$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
5980 6317
 	}
5981
-	else
5982
-		$regex = '(?'.'>' . $index_to_regex($index, $delim) . ')';
5983 6318
 
5984 6319
 	// Restore PHP's internal character encoding to whatever it was originally
5985
-	if (!empty($current_encoding))
5986
-		mb_internal_encoding($current_encoding);
6320
+	if (!empty($current_encoding)) {
6321
+			mb_internal_encoding($current_encoding);
6322
+	}
5987 6323
 
5988 6324
 	return $regex;
5989 6325
 }
@@ -6023,13 +6359,15 @@  discard block
 block discarded – undo
6023 6359
 	// Need to add the trailing slash, or it puts it there & thinks there's a redirect when there isn't...
6024 6360
 	$url = str_ireplace('https://', 'http://', $url) . '/';
6025 6361
 	$headers = @get_headers($url);
6026
-	if ($headers === false)
6027
-		return false;
6362
+	if ($headers === false) {
6363
+			return false;
6364
+	}
6028 6365
 
6029 6366
 	// Now to see if it came back https...   
6030 6367
 	// First check for a redirect status code in first row (301, 302, 307)
6031
-	if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false)
6032
-		return false;
6368
+	if (strstr($headers[0], '301') === false && strstr($headers[0], '302') === false && strstr($headers[0], '307') === false) {
6369
+			return false;
6370
+	}
6033 6371
 	
6034 6372
 	// Search for the location entry to confirm https
6035 6373
 	$result = false;
Please login to merge, or discard this patch.
Sources/Load.php 1 patch
Braces   +793 added lines, -599 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Load the $modSettings array.
@@ -25,13 +26,14 @@  discard block
 block discarded – undo
25 26
 	global $cache_enable, $sourcedir, $context;
26 27
 
27 28
 	// Most database systems have not set UTF-8 as their default input charset.
28
-	if (!empty($db_character_set))
29
-		$smcFunc['db_query']('', '
29
+	if (!empty($db_character_set)) {
30
+			$smcFunc['db_query']('', '
30 31
 			SET NAMES {string:db_character_set}',
31 32
 			array(
32 33
 				'db_character_set' => $db_character_set,
33 34
 			)
34 35
 		);
36
+	}
35 37
 
36 38
 	// We need some caching support, maybe.
37 39
 	loadCacheAccelerator();
@@ -46,28 +48,36 @@  discard block
 block discarded – undo
46 48
 			)
47 49
 		);
48 50
 		$modSettings = array();
49
-		if (!$request)
50
-			display_db_error();
51
-		while ($row = $smcFunc['db_fetch_row']($request))
52
-			$modSettings[$row[0]] = $row[1];
51
+		if (!$request) {
52
+					display_db_error();
53
+		}
54
+		while ($row = $smcFunc['db_fetch_row']($request)) {
55
+					$modSettings[$row[0]] = $row[1];
56
+		}
53 57
 		$smcFunc['db_free_result']($request);
54 58
 
55 59
 		// Do a few things to protect against missing settings or settings with invalid values...
56
-		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999)
57
-			$modSettings['defaultMaxTopics'] = 20;
58
-		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999)
59
-			$modSettings['defaultMaxMessages'] = 15;
60
-		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999)
61
-			$modSettings['defaultMaxMembers'] = 30;
62
-		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999)
63
-			$modSettings['defaultMaxListItems'] = 15;
60
+		if (empty($modSettings['defaultMaxTopics']) || $modSettings['defaultMaxTopics'] <= 0 || $modSettings['defaultMaxTopics'] > 999) {
61
+					$modSettings['defaultMaxTopics'] = 20;
62
+		}
63
+		if (empty($modSettings['defaultMaxMessages']) || $modSettings['defaultMaxMessages'] <= 0 || $modSettings['defaultMaxMessages'] > 999) {
64
+					$modSettings['defaultMaxMessages'] = 15;
65
+		}
66
+		if (empty($modSettings['defaultMaxMembers']) || $modSettings['defaultMaxMembers'] <= 0 || $modSettings['defaultMaxMembers'] > 999) {
67
+					$modSettings['defaultMaxMembers'] = 30;
68
+		}
69
+		if (empty($modSettings['defaultMaxListItems']) || $modSettings['defaultMaxListItems'] <= 0 || $modSettings['defaultMaxListItems'] > 999) {
70
+					$modSettings['defaultMaxListItems'] = 15;
71
+		}
64 72
 
65 73
 		// We excpiclity do not use $smcFunc['json_decode'] here yet, as $smcFunc is not fully loaded.
66
-		if (!is_array($modSettings['attachmentUploadDir']))
67
-			$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
74
+		if (!is_array($modSettings['attachmentUploadDir'])) {
75
+					$modSettings['attachmentUploadDir'] = smf_json_decode($modSettings['attachmentUploadDir'], true);
76
+		}
68 77
 
69
-		if (!empty($cache_enable))
70
-			cache_put_data('modSettings', $modSettings, 90);
78
+		if (!empty($cache_enable)) {
79
+					cache_put_data('modSettings', $modSettings, 90);
80
+		}
71 81
 	}
72 82
 
73 83
 	$modSettings['cache_enable'] = $cache_enable;
@@ -87,8 +97,9 @@  discard block
 block discarded – undo
87 97
 		};
88 98
 	$fix_utf8mb4 = function($string) use ($utf8, $smcFunc)
89 99
 	{
90
-		if (!$utf8 || $smcFunc['db_mb4'])
91
-			return $string;
100
+		if (!$utf8 || $smcFunc['db_mb4']) {
101
+					return $string;
102
+		}
92 103
 
93 104
 		$i = 0;
94 105
 		$len = strlen($string);
@@ -100,18 +111,15 @@  discard block
 block discarded – undo
100 111
 			{
101 112
 				$new_string .= $string[$i];
102 113
 				$i++;
103
-			}
104
-			elseif ($ord < 224)
114
+			} elseif ($ord < 224)
105 115
 			{
106 116
 				$new_string .= $string[$i] . $string[$i + 1];
107 117
 				$i += 2;
108
-			}
109
-			elseif ($ord < 240)
118
+			} elseif ($ord < 240)
110 119
 			{
111 120
 				$new_string .= $string[$i] . $string[$i + 1] . $string[$i + 2];
112 121
 				$i += 3;
113
-			}
114
-			elseif ($ord < 248)
122
+			} elseif ($ord < 248)
115 123
 			{
116 124
 				// Magic happens.
117 125
 				$val = (ord($string[$i]) & 0x07) << 18;
@@ -155,8 +163,7 @@  discard block
 block discarded – undo
155 163
 			{
156 164
 				$result = array_search($needle, array_slice($haystack_arr, $offset));
157 165
 				return is_int($result) ? $result + $offset : false;
158
-			}
159
-			else
166
+			} else
160 167
 			{
161 168
 				$needle_arr = preg_split('~(&#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . ';|&quot;|&amp;|&lt;|&gt;|&nbsp;|.)~' . ($utf8 ? 'u' : '') . '', $ent_check($needle), -1, PREG_SPLIT_DELIM_CAPTURE | PREG_SPLIT_NO_EMPTY);
162 169
 				$needle_size = count($needle_arr);
@@ -165,8 +172,9 @@  discard block
 block discarded – undo
165 172
 				while ((int) $result === $result)
166 173
 				{
167 174
 					$offset += $result;
168
-					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr)
169
-						return $offset;
175
+					if (array_slice($haystack_arr, $offset, $needle_size) === $needle_arr) {
176
+											return $offset;
177
+					}
170 178
 					$result = array_search($needle_arr[0], array_slice($haystack_arr, ++$offset));
171 179
 				}
172 180
 				return false;
@@ -204,8 +212,9 @@  discard block
 block discarded – undo
204 212
 			$string = $ent_check($string);
205 213
 			preg_match('~^(' . $ent_list . '|.){' . $smcFunc['strlen'](substr($string, 0, $length)) . '}~' . ($utf8 ? 'u' : ''), $string, $matches);
206 214
 			$string = $matches[0];
207
-			while (strlen($string) > $length)
208
-				$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
215
+			while (strlen($string) > $length) {
216
+							$string = preg_replace('~(?:' . $ent_list . '|.)$~' . ($utf8 ? 'u' : ''), '', $string);
217
+			}
209 218
 			return $string;
210 219
 		},
211 220
 		'ucfirst' => $utf8 ? function($string) use (&$smcFunc)
@@ -215,8 +224,9 @@  discard block
 block discarded – undo
215 224
 		'ucwords' => $utf8 ? function($string) use (&$smcFunc)
216 225
 		{
217 226
 			$words = preg_split('~([\s\r\n\t]+)~', $string, -1, PREG_SPLIT_DELIM_CAPTURE);
218
-			for ($i = 0, $n = count($words); $i < $n; $i += 2)
219
-				$words[$i] = $smcFunc['ucfirst']($words[$i]);
227
+			for ($i = 0, $n = count($words); $i < $n; $i += 2) {
228
+							$words[$i] = $smcFunc['ucfirst']($words[$i]);
229
+			}
220 230
 			return implode('', $words);
221 231
 		} : 'ucwords',
222 232
 		'json_decode' => 'smf_json_decode',
@@ -224,16 +234,17 @@  discard block
 block discarded – undo
224 234
 	);
225 235
 
226 236
 	// Setting the timezone is a requirement for some functions.
227
-	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list()))
228
-		date_default_timezone_set($modSettings['default_timezone']);
229
-	else
237
+	if (isset($modSettings['default_timezone']) && in_array($modSettings['default_timezone'], timezone_identifiers_list())) {
238
+			date_default_timezone_set($modSettings['default_timezone']);
239
+	} else
230 240
 	{
231 241
 		// Get PHP's default timezone, if set
232 242
 		$ini_tz = ini_get('date.timezone');
233
-		if (!empty($ini_tz))
234
-			$modSettings['default_timezone'] = $ini_tz;
235
-		else
236
-			$modSettings['default_timezone'] = '';
243
+		if (!empty($ini_tz)) {
244
+					$modSettings['default_timezone'] = $ini_tz;
245
+		} else {
246
+					$modSettings['default_timezone'] = '';
247
+		}
237 248
 
238 249
 		// If date.timezone is unset, invalid, or just plain weird, make a best guess
239 250
 		if (!in_array($modSettings['default_timezone'], timezone_identifiers_list()))
@@ -251,22 +262,26 @@  discard block
 block discarded – undo
251 262
 		if (($modSettings['load_average'] = cache_get_data('loadavg', 90)) == null)
252 263
 		{
253 264
 			$modSettings['load_average'] = @file_get_contents('/proc/loadavg');
254
-			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0)
255
-				$modSettings['load_average'] = (float) $matches[1];
256
-			elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0)
257
-				$modSettings['load_average'] = (float) $matches[1];
258
-			else
259
-				unset($modSettings['load_average']);
265
+			if (!empty($modSettings['load_average']) && preg_match('~^([^ ]+?) ([^ ]+?) ([^ ]+)~', $modSettings['load_average'], $matches) != 0) {
266
+							$modSettings['load_average'] = (float) $matches[1];
267
+			} elseif (($modSettings['load_average'] = @`uptime`) != null && preg_match('~load average[s]?: (\d+\.\d+), (\d+\.\d+), (\d+\.\d+)~i', $modSettings['load_average'], $matches) != 0) {
268
+							$modSettings['load_average'] = (float) $matches[1];
269
+			} else {
270
+							unset($modSettings['load_average']);
271
+			}
260 272
 
261
-			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
262
-				cache_put_data('loadavg', $modSettings['load_average'], 90);
273
+			if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
274
+							cache_put_data('loadavg', $modSettings['load_average'], 90);
275
+			}
263 276
 		}
264 277
 
265
-		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)
266
-			call_integration_hook('integrate_load_average', array($modSettings['load_average']));
278
+		if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0) {
279
+					call_integration_hook('integrate_load_average', array($modSettings['load_average']));
280
+		}
267 281
 
268
-		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum'])
269
-			display_loadavg_error();
282
+		if (!empty($modSettings['loadavg_forum']) && !empty($modSettings['load_average']) && $modSettings['load_average'] >= $modSettings['loadavg_forum']) {
283
+					display_loadavg_error();
284
+		}
270 285
 	}
271 286
 
272 287
 	// Is post moderation alive and well? Everywhere else assumes this has been defined, so let's make sure it is.
@@ -287,8 +302,9 @@  discard block
 block discarded – undo
287 302
 	if (defined('SMF_INTEGRATION_SETTINGS'))
288 303
 	{
289 304
 		$integration_settings = $smcFunc['json_decode'](SMF_INTEGRATION_SETTINGS, true);
290
-		foreach ($integration_settings as $hook => $function)
291
-			add_integration_function($hook, $function, '', false);
305
+		foreach ($integration_settings as $hook => $function) {
306
+					add_integration_function($hook, $function, '', false);
307
+		}
292 308
 	}
293 309
 
294 310
 	// Any files to pre include?
@@ -298,8 +314,9 @@  discard block
 block discarded – undo
298 314
 		foreach ($pre_includes as $include)
299 315
 		{
300 316
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir));
301
-			if (file_exists($include))
302
-				require_once($include);
317
+			if (file_exists($include)) {
318
+							require_once($include);
319
+			}
303 320
 		}
304 321
 	}
305 322
 
@@ -403,27 +420,28 @@  discard block
 block discarded – undo
403 420
 				break;
404 421
 			}
405 422
 		}
423
+	} else {
424
+			$id_member = 0;
406 425
 	}
407
-	else
408
-		$id_member = 0;
409 426
 
410 427
 	if (empty($id_member) && isset($_COOKIE[$cookiename]))
411 428
 	{
412 429
 		$cookie_data = $smcFunc['json_decode']($_COOKIE[$cookiename], true, false);
413 430
 
414
-		if (empty($cookie_data))
415
-			$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
431
+		if (empty($cookie_data)) {
432
+					$cookie_data = safe_unserialize($_COOKIE[$cookiename]);
433
+		}
416 434
 
417 435
 		list ($id_member, $password) = $cookie_data;
418 436
 		$id_member = !empty($id_member) && strlen($password) > 0 ? (int) $id_member : 0;
419
-	}
420
-	elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
437
+	} elseif (empty($id_member) && isset($_SESSION['login_' . $cookiename]) && ($_SESSION['USER_AGENT'] == $_SERVER['HTTP_USER_AGENT'] || !empty($modSettings['disableCheckUA'])))
421 438
 	{
422 439
 		// @todo Perhaps we can do some more checking on this, such as on the first octet of the IP?
423 440
 		$cookie_data = $smcFunc['json_decode']($_SESSION['login_' . $cookiename]);
424 441
 
425
-		if (empty($cookie_data))
426
-			$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
442
+		if (empty($cookie_data)) {
443
+					$cookie_data = safe_unserialize($_SESSION['login_' . $cookiename]);
444
+		}
427 445
 
428 446
 		list ($id_member, $password, $login_span) = $cookie_data;
429 447
 		$id_member = !empty($id_member) && strlen($password) == 128 && $login_span > time() ? (int) $id_member : 0;
@@ -448,30 +466,34 @@  discard block
 block discarded – undo
448 466
 			$user_settings = $smcFunc['db_fetch_assoc']($request);
449 467
 			$smcFunc['db_free_result']($request);
450 468
 
451
-			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false)
452
-				$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
469
+			if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($user_settings['avatar'], 'http://') !== false) {
470
+							$user_settings['avatar'] = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($user_settings['avatar']) . '&hash=' . md5($user_settings['avatar'] . $image_proxy_secret);
471
+			}
453 472
 
454
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
455
-				cache_put_data('user_settings-' . $id_member, $user_settings, 60);
473
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
474
+							cache_put_data('user_settings-' . $id_member, $user_settings, 60);
475
+			}
456 476
 		}
457 477
 
458 478
 		// Did we find 'im?  If not, junk it.
459 479
 		if (!empty($user_settings))
460 480
 		{
461 481
 			// As much as the password should be right, we can assume the integration set things up.
462
-			if (!empty($already_verified) && $already_verified === true)
463
-				$check = true;
482
+			if (!empty($already_verified) && $already_verified === true) {
483
+							$check = true;
484
+			}
464 485
 			// SHA-512 hash should be 128 characters long.
465
-			elseif (strlen($password) == 128)
466
-				$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
467
-			else
468
-				$check = false;
486
+			elseif (strlen($password) == 128) {
487
+							$check = hash_salt($user_settings['passwd'], $user_settings['password_salt']) == $password;
488
+			} else {
489
+							$check = false;
490
+			}
469 491
 
470 492
 			// Wrong password or not activated - either way, you're going nowhere.
471 493
 			$id_member = $check && ($user_settings['is_activated'] == 1 || $user_settings['is_activated'] == 11) ? (int) $user_settings['id_member'] : 0;
494
+		} else {
495
+					$id_member = 0;
472 496
 		}
473
-		else
474
-			$id_member = 0;
475 497
 
476 498
 		// If we no longer have the member maybe they're being all hackey, stop brute force!
477 499
 		if (!$id_member)
@@ -500,8 +522,9 @@  discard block
 block discarded – undo
500 522
 
501 523
 					list ($tfamember, $tfasecret) = $tfa_data;
502 524
 
503
-					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member)
504
-						$tfasecret = null;
525
+					if (!isset($tfamember, $tfasecret) || (int) $tfamember != $id_member) {
526
+											$tfasecret = null;
527
+					}
505 528
 				}
506 529
 
507 530
 				if (empty($tfasecret) || hash_salt($user_settings['tfa_backup'], $user_settings['password_salt']) != $tfasecret)
@@ -521,10 +544,12 @@  discard block
 block discarded – undo
521 544
 		// Are we forcing 2FA? Need to check if the user groups actually require 2FA
522 545
 		elseif (!empty($modSettings['tfa_mode']) && $modSettings['tfa_mode'] >= 2 && $id_member && empty($user_settings['tfa_secret']))
523 546
 		{
524
-			if ($modSettings['tfa_mode'] == 2) //only do this if we are just forcing SOME membergroups
547
+			if ($modSettings['tfa_mode'] == 2) {
548
+				//only do this if we are just forcing SOME membergroups
525 549
 			{
526 550
 				//Build an array of ALL user membergroups.
527 551
 				$full_groups = array($user_settings['id_group']);
552
+			}
528 553
 				if (!empty($user_settings['additional_groups']))
529 554
 				{
530 555
 					$full_groups = array_merge($full_groups, explode(',', $user_settings['additional_groups']));
@@ -544,15 +569,17 @@  discard block
 block discarded – undo
544 569
 				);
545 570
 				$row = $smcFunc['db_fetch_assoc']($request);
546 571
 				$smcFunc['db_free_result']($request);
572
+			} else {
573
+							$row['total'] = 1;
547 574
 			}
548
-			else
549
-				$row['total'] = 1; //simplifies logics in the next "if"
575
+			//simplifies logics in the next "if"
550 576
 
551 577
 			$area = !empty($_REQUEST['area']) ? $_REQUEST['area'] : '';
552 578
 			$action = !empty($_REQUEST['action']) ? $_REQUEST['action'] : '';
553 579
 
554
-			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup'))
555
-				redirectexit('action=profile;area=tfasetup;forced');
580
+			if ($row['total'] > 0 && !in_array($action, array('profile', 'logout')) || ($action == 'profile' && $area != 'tfasetup')) {
581
+							redirectexit('action=profile;area=tfasetup;forced');
582
+			}
556 583
 		}
557 584
 	}
558 585
 
@@ -589,33 +616,37 @@  discard block
 block discarded – undo
589 616
 				updateMemberData($id_member, array('id_msg_last_visit' => (int) $modSettings['maxMsgID'], 'last_login' => time(), 'member_ip' => $_SERVER['REMOTE_ADDR'], 'member_ip2' => $_SERVER['BAN_CHECK_IP']));
590 617
 				$user_settings['last_login'] = time();
591 618
 
592
-				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
593
-					cache_put_data('user_settings-' . $id_member, $user_settings, 60);
619
+				if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
620
+									cache_put_data('user_settings-' . $id_member, $user_settings, 60);
621
+				}
594 622
 
595
-				if (!empty($modSettings['cache_enable']))
596
-					cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
623
+				if (!empty($modSettings['cache_enable'])) {
624
+									cache_put_data('user_last_visit-' . $id_member, $_SESSION['id_msg_last_visit'], 5 * 3600);
625
+				}
597 626
 			}
627
+		} elseif (empty($_SESSION['id_msg_last_visit'])) {
628
+					$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
598 629
 		}
599
-		elseif (empty($_SESSION['id_msg_last_visit']))
600
-			$_SESSION['id_msg_last_visit'] = $user_settings['id_msg_last_visit'];
601 630
 
602 631
 		$username = $user_settings['member_name'];
603 632
 
604
-		if (empty($user_settings['additional_groups']))
605
-			$user_info = array(
633
+		if (empty($user_settings['additional_groups'])) {
634
+					$user_info = array(
606 635
 				'groups' => array($user_settings['id_group'], $user_settings['id_post_group'])
607 636
 			);
608
-		else
609
-			$user_info = array(
637
+		} else {
638
+					$user_info = array(
610 639
 				'groups' => array_merge(
611 640
 					array($user_settings['id_group'], $user_settings['id_post_group']),
612 641
 					explode(',', $user_settings['additional_groups'])
613 642
 				)
614 643
 			);
644
+		}
615 645
 
616 646
 		// Because history has proven that it is possible for groups to go bad - clean up in case.
617
-		foreach ($user_info['groups'] as $k => $v)
618
-			$user_info['groups'][$k] = (int) $v;
647
+		foreach ($user_info['groups'] as $k => $v) {
648
+					$user_info['groups'][$k] = (int) $v;
649
+		}
619 650
 
620 651
 		// This is a logged in user, so definitely not a spider.
621 652
 		$user_info['possibly_robot'] = false;
@@ -629,8 +660,7 @@  discard block
 block discarded – undo
629 660
 			$time_system = new DateTime('now', $tz_system);
630 661
 			$time_user = new DateTime('now', $tz_user);
631 662
 			$user_info['time_offset'] = ($tz_user->getOffset($time_user) - $tz_system->getOffset($time_system)) / 3600;
632
-		}
633
-		else
663
+		} else
634 664
 		{
635 665
 			// !!! Compatibility.
636 666
 			$user_info['time_offset'] = empty($user_settings['time_offset']) ? 0 : $user_settings['time_offset'];
@@ -644,8 +674,9 @@  discard block
 block discarded – undo
644 674
 		$user_info = array('groups' => array(-1));
645 675
 		$user_settings = array();
646 676
 
647
-		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member']))
648
-			$_COOKIE[$cookiename] = '';
677
+		if (isset($_COOKIE[$cookiename]) && empty($context['tfa_member'])) {
678
+					$_COOKIE[$cookiename] = '';
679
+		}
649 680
 
650 681
 		// Expire the 2FA cookie
651 682
 		if (isset($_COOKIE[$cookiename . '_tfa']) && empty($context['tfa_member']))
@@ -662,19 +693,20 @@  discard block
 block discarded – undo
662 693
 		}
663 694
 
664 695
 		// Create a login token if it doesn't exist yet.
665
-		if (!isset($_SESSION['token']['post-login']))
666
-			createToken('login');
667
-		else
668
-			list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
696
+		if (!isset($_SESSION['token']['post-login'])) {
697
+					createToken('login');
698
+		} else {
699
+					list ($context['login_token_var'],,, $context['login_token']) = $_SESSION['token']['post-login'];
700
+		}
669 701
 
670 702
 		// Do we perhaps think this is a search robot? Check every five minutes just in case...
671 703
 		if ((!empty($modSettings['spider_mode']) || !empty($modSettings['spider_group'])) && (!isset($_SESSION['robot_check']) || $_SESSION['robot_check'] < time() - 300))
672 704
 		{
673 705
 			require_once($sourcedir . '/ManageSearchEngines.php');
674 706
 			$user_info['possibly_robot'] = SpiderCheck();
707
+		} elseif (!empty($modSettings['spider_mode'])) {
708
+					$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
675 709
 		}
676
-		elseif (!empty($modSettings['spider_mode']))
677
-			$user_info['possibly_robot'] = isset($_SESSION['id_robot']) ? $_SESSION['id_robot'] : 0;
678 710
 		// If we haven't turned on proper spider hunts then have a guess!
679 711
 		else
680 712
 		{
@@ -722,8 +754,9 @@  discard block
 block discarded – undo
722 754
 	$user_info['groups'] = array_unique($user_info['groups']);
723 755
 
724 756
 	// Make sure that the last item in the ignore boards array is valid. If the list was too long it could have an ending comma that could cause problems.
725
-	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1]))
726
-		unset($user_info['ignoreboards'][$tmp]);
757
+	if (!empty($user_info['ignoreboards']) && empty($user_info['ignoreboards'][$tmp = count($user_info['ignoreboards']) - 1])) {
758
+			unset($user_info['ignoreboards'][$tmp]);
759
+	}
727 760
 
728 761
 	// Allow the user to change their language.
729 762
 	if (!empty($modSettings['userLanguage']))
@@ -736,31 +769,36 @@  discard block
 block discarded – undo
736 769
 			$user_info['language'] = strtr($_GET['language'], './\\:', '____');
737 770
 
738 771
 			// Make it permanent for members.
739
-			if (!empty($user_info['id']))
740
-				updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
741
-			else
742
-				$_SESSION['language'] = $user_info['language'];
772
+			if (!empty($user_info['id'])) {
773
+							updateMemberData($user_info['id'], array('lngfile' => $user_info['language']));
774
+			} else {
775
+							$_SESSION['language'] = $user_info['language'];
776
+			}
777
+		} elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')])) {
778
+					$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
743 779
 		}
744
-		elseif (!empty($_SESSION['language']) && isset($languages[strtr($_SESSION['language'], './\\:', '____')]))
745
-			$user_info['language'] = strtr($_SESSION['language'], './\\:', '____');
746 780
 	}
747 781
 
748 782
 	// Just build this here, it makes it easier to change/use - administrators can see all boards.
749
-	if ($user_info['is_admin'])
750
-		$user_info['query_see_board'] = '1=1';
783
+	if ($user_info['is_admin']) {
784
+			$user_info['query_see_board'] = '1=1';
785
+	}
751 786
 	// Otherwise just the groups in $user_info['groups'].
752
-	else
753
-		$user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')';
787
+	else {
788
+			$user_info['query_see_board'] = '((FIND_IN_SET(' . implode(', b.member_groups) != 0 OR FIND_IN_SET(', $user_info['groups']) . ', b.member_groups) != 0)' . (!empty($modSettings['deny_boards_access']) ? ' AND (FIND_IN_SET(' . implode(', b.deny_member_groups) = 0 AND FIND_IN_SET(', $user_info['groups']) . ', b.deny_member_groups) = 0)' : '') . (isset($user_info['mod_cache']) ? ' OR ' . $user_info['mod_cache']['mq'] : '') . ')';
789
+	}
754 790
 
755 791
 	// Build the list of boards they WANT to see.
756 792
 	// This will take the place of query_see_boards in certain spots, so it better include the boards they can see also
757 793
 
758 794
 	// If they aren't ignoring any boards then they want to see all the boards they can see
759
-	if (empty($user_info['ignoreboards']))
760
-		$user_info['query_wanna_see_board'] = $user_info['query_see_board'];
795
+	if (empty($user_info['ignoreboards'])) {
796
+			$user_info['query_wanna_see_board'] = $user_info['query_see_board'];
797
+	}
761 798
 	// Ok I guess they don't want to see all the boards
762
-	else
763
-		$user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))';
799
+	else {
800
+			$user_info['query_wanna_see_board'] = '(' . $user_info['query_see_board'] . ' AND b.id_board NOT IN (' . implode(',', $user_info['ignoreboards']) . '))';
801
+	}
764 802
 
765 803
 	call_integration_hook('integrate_user_info');
766 804
 }
@@ -818,9 +856,9 @@  discard block
 block discarded – undo
818 856
 		}
819 857
 
820 858
 		// Remember redirection is the key to avoiding fallout from your bosses.
821
-		if (!empty($topic))
822
-			redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
823
-		else
859
+		if (!empty($topic)) {
860
+					redirectexit('topic=' . $topic . '.msg' . $_REQUEST['msg'] . '#msg' . $_REQUEST['msg']);
861
+		} else
824 862
 		{
825 863
 			loadPermissions();
826 864
 			loadTheme();
@@ -838,10 +876,11 @@  discard block
 block discarded – undo
838 876
 	if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
839 877
 	{
840 878
 		// @todo SLOW?
841
-		if (!empty($topic))
842
-			$temp = cache_get_data('topic_board-' . $topic, 120);
843
-		else
844
-			$temp = cache_get_data('board-' . $board, 120);
879
+		if (!empty($topic)) {
880
+					$temp = cache_get_data('topic_board-' . $topic, 120);
881
+		} else {
882
+					$temp = cache_get_data('board-' . $board, 120);
883
+		}
845 884
 
846 885
 		if (!empty($temp))
847 886
 		{
@@ -879,8 +918,9 @@  discard block
 block discarded – undo
879 918
 			$row = $smcFunc['db_fetch_assoc']($request);
880 919
 
881 920
 			// Set the current board.
882
-			if (!empty($row['id_board']))
883
-				$board = $row['id_board'];
921
+			if (!empty($row['id_board'])) {
922
+							$board = $row['id_board'];
923
+			}
884 924
 
885 925
 			// Basic operating information. (globals... :/)
886 926
 			$board_info = array(
@@ -916,21 +956,23 @@  discard block
 block discarded – undo
916 956
 
917 957
 			do
918 958
 			{
919
-				if (!empty($row['id_moderator']))
920
-					$board_info['moderators'][$row['id_moderator']] = array(
959
+				if (!empty($row['id_moderator'])) {
960
+									$board_info['moderators'][$row['id_moderator']] = array(
921 961
 						'id' => $row['id_moderator'],
922 962
 						'name' => $row['real_name'],
923 963
 						'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
924 964
 						'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
925 965
 					);
966
+				}
926 967
 
927
-				if (!empty($row['id_moderator_group']))
928
-					$board_info['moderator_groups'][$row['id_moderator_group']] = array(
968
+				if (!empty($row['id_moderator_group'])) {
969
+									$board_info['moderator_groups'][$row['id_moderator_group']] = array(
929 970
 						'id' => $row['id_moderator_group'],
930 971
 						'name' => $row['group_name'],
931 972
 						'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
932 973
 						'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
933 974
 					);
975
+				}
934 976
 			}
935 977
 			while ($row = $smcFunc['db_fetch_assoc']($request));
936 978
 
@@ -962,12 +1004,12 @@  discard block
 block discarded – undo
962 1004
 			if (!empty($modSettings['cache_enable']) && (empty($topic) || $modSettings['cache_enable'] >= 3))
963 1005
 			{
964 1006
 				// @todo SLOW?
965
-				if (!empty($topic))
966
-					cache_put_data('topic_board-' . $topic, $board_info, 120);
1007
+				if (!empty($topic)) {
1008
+									cache_put_data('topic_board-' . $topic, $board_info, 120);
1009
+				}
967 1010
 				cache_put_data('board-' . $board, $board_info, 120);
968 1011
 			}
969
-		}
970
-		else
1012
+		} else
971 1013
 		{
972 1014
 			// Otherwise the topic is invalid, there are no moderators, etc.
973 1015
 			$board_info = array(
@@ -981,8 +1023,9 @@  discard block
 block discarded – undo
981 1023
 		$smcFunc['db_free_result']($request);
982 1024
 	}
983 1025
 
984
-	if (!empty($topic))
985
-		$_GET['board'] = (int) $board;
1026
+	if (!empty($topic)) {
1027
+			$_GET['board'] = (int) $board;
1028
+	}
986 1029
 
987 1030
 	if (!empty($board))
988 1031
 	{
@@ -992,10 +1035,12 @@  discard block
 block discarded – undo
992 1035
 		// Now check if the user is a moderator.
993 1036
 		$user_info['is_mod'] = isset($board_info['moderators'][$user_info['id']]) || count(array_intersect($user_info['groups'], $moderator_groups)) != 0;
994 1037
 
995
-		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin'])
996
-			$board_info['error'] = 'access';
997
-		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin'])
998
-			$board_info['error'] = 'access';
1038
+		if (count(array_intersect($user_info['groups'], $board_info['groups'])) == 0 && !$user_info['is_admin']) {
1039
+					$board_info['error'] = 'access';
1040
+		}
1041
+		if (!empty($modSettings['deny_boards_access']) && count(array_intersect($user_info['groups'], $board_info['deny_groups'])) != 0 && !$user_info['is_admin']) {
1042
+					$board_info['error'] = 'access';
1043
+		}
999 1044
 
1000 1045
 		// Build up the linktree.
1001 1046
 		$context['linktree'] = array_merge(
@@ -1018,8 +1063,9 @@  discard block
 block discarded – undo
1018 1063
 	$context['current_board'] = $board;
1019 1064
 
1020 1065
 	// No posting in redirection boards!
1021
-	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect']))
1022
-		$board_info['error'] == 'post_in_redirect';
1066
+	if (!empty($_REQUEST['action']) && $_REQUEST['action'] == 'post' && !empty($board_info['redirect'])) {
1067
+			$board_info['error'] == 'post_in_redirect';
1068
+	}
1023 1069
 
1024 1070
 	// Hacker... you can't see this topic, I'll tell you that. (but moderators can!)
1025 1071
 	if (!empty($board_info['error']) && (!empty($modSettings['deny_boards_access']) || $board_info['error'] != 'access' || !$user_info['is_mod']))
@@ -1045,24 +1091,23 @@  discard block
 block discarded – undo
1045 1091
 			ob_end_clean();
1046 1092
 			header('HTTP/1.1 403 Forbidden');
1047 1093
 			die;
1048
-		}
1049
-		elseif ($board_info['error'] == 'post_in_redirect')
1094
+		} elseif ($board_info['error'] == 'post_in_redirect')
1050 1095
 		{
1051 1096
 			// Slightly different error message here...
1052 1097
 			fatal_lang_error('cannot_post_redirect', false);
1053
-		}
1054
-		elseif ($user_info['is_guest'])
1098
+		} elseif ($user_info['is_guest'])
1055 1099
 		{
1056 1100
 			loadLanguage('Errors');
1057 1101
 			is_not_guest($txt['topic_gone']);
1102
+		} else {
1103
+					fatal_lang_error('topic_gone', false);
1058 1104
 		}
1059
-		else
1060
-			fatal_lang_error('topic_gone', false);
1061 1105
 	}
1062 1106
 
1063
-	if ($user_info['is_mod'])
1064
-		$user_info['groups'][] = 3;
1065
-}
1107
+	if ($user_info['is_mod']) {
1108
+			$user_info['groups'][] = 3;
1109
+	}
1110
+	}
1066 1111
 
1067 1112
 /**
1068 1113
  * Load this user's permissions.
@@ -1083,8 +1128,9 @@  discard block
 block discarded – undo
1083 1128
 		asort($cache_groups);
1084 1129
 		$cache_groups = implode(',', $cache_groups);
1085 1130
 		// If it's a spider then cache it different.
1086
-		if ($user_info['possibly_robot'])
1087
-			$cache_groups .= '-spider';
1131
+		if ($user_info['possibly_robot']) {
1132
+					$cache_groups .= '-spider';
1133
+		}
1088 1134
 
1089 1135
 		if ($modSettings['cache_enable'] >= 2 && !empty($board) && ($temp = cache_get_data('permissions:' . $cache_groups . ':' . $board, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1090 1136
 		{
@@ -1092,9 +1138,9 @@  discard block
 block discarded – undo
1092 1138
 			banPermissions();
1093 1139
 
1094 1140
 			return;
1141
+		} elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated']) {
1142
+					list ($user_info['permissions'], $removals) = $temp;
1095 1143
 		}
1096
-		elseif (($temp = cache_get_data('permissions:' . $cache_groups, 240)) != null && time() - 240 > $modSettings['settings_updated'])
1097
-			list ($user_info['permissions'], $removals) = $temp;
1098 1144
 	}
1099 1145
 
1100 1146
 	// If it is detected as a robot, and we are restricting permissions as a special group - then implement this.
@@ -1116,23 +1162,26 @@  discard block
 block discarded – undo
1116 1162
 		$removals = array();
1117 1163
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1118 1164
 		{
1119
-			if (empty($row['add_deny']))
1120
-				$removals[] = $row['permission'];
1121
-			else
1122
-				$user_info['permissions'][] = $row['permission'];
1165
+			if (empty($row['add_deny'])) {
1166
+							$removals[] = $row['permission'];
1167
+			} else {
1168
+							$user_info['permissions'][] = $row['permission'];
1169
+			}
1123 1170
 		}
1124 1171
 		$smcFunc['db_free_result']($request);
1125 1172
 
1126
-		if (isset($cache_groups))
1127
-			cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1173
+		if (isset($cache_groups)) {
1174
+					cache_put_data('permissions:' . $cache_groups, array($user_info['permissions'], $removals), 240);
1175
+		}
1128 1176
 	}
1129 1177
 
1130 1178
 	// Get the board permissions.
1131 1179
 	if (!empty($board))
1132 1180
 	{
1133 1181
 		// Make sure the board (if any) has been loaded by loadBoard().
1134
-		if (!isset($board_info['profile']))
1135
-			fatal_lang_error('no_board');
1182
+		if (!isset($board_info['profile'])) {
1183
+					fatal_lang_error('no_board');
1184
+		}
1136 1185
 
1137 1186
 		$request = $smcFunc['db_query']('', '
1138 1187
 			SELECT permission, add_deny
@@ -1148,20 +1197,23 @@  discard block
 block discarded – undo
1148 1197
 		);
1149 1198
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1150 1199
 		{
1151
-			if (empty($row['add_deny']))
1152
-				$removals[] = $row['permission'];
1153
-			else
1154
-				$user_info['permissions'][] = $row['permission'];
1200
+			if (empty($row['add_deny'])) {
1201
+							$removals[] = $row['permission'];
1202
+			} else {
1203
+							$user_info['permissions'][] = $row['permission'];
1204
+			}
1155 1205
 		}
1156 1206
 		$smcFunc['db_free_result']($request);
1157 1207
 	}
1158 1208
 
1159 1209
 	// Remove all the permissions they shouldn't have ;).
1160
-	if (!empty($modSettings['permission_enable_deny']))
1161
-		$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1210
+	if (!empty($modSettings['permission_enable_deny'])) {
1211
+			$user_info['permissions'] = array_diff($user_info['permissions'], $removals);
1212
+	}
1162 1213
 
1163
-	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2)
1164
-		cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1214
+	if (isset($cache_groups) && !empty($board) && $modSettings['cache_enable'] >= 2) {
1215
+			cache_put_data('permissions:' . $cache_groups . ':' . $board, array($user_info['permissions'], null), 240);
1216
+	}
1165 1217
 
1166 1218
 	// Banned?  Watch, don't touch..
1167 1219
 	banPermissions();
@@ -1173,17 +1225,18 @@  discard block
 block discarded – undo
1173 1225
 		{
1174 1226
 			require_once($sourcedir . '/Subs-Auth.php');
1175 1227
 			rebuildModCache();
1228
+		} else {
1229
+					$user_info['mod_cache'] = $_SESSION['mc'];
1176 1230
 		}
1177
-		else
1178
-			$user_info['mod_cache'] = $_SESSION['mc'];
1179 1231
 
1180 1232
 		// This is a useful phantom permission added to the current user, and only the current user while they are logged in.
1181 1233
 		// For example this drastically simplifies certain changes to the profile area.
1182 1234
 		$user_info['permissions'][] = 'is_not_guest';
1183 1235
 		// And now some backwards compatibility stuff for mods and whatnot that aren't expecting the new permissions.
1184 1236
 		$user_info['permissions'][] = 'profile_view_own';
1185
-		if (in_array('profile_view', $user_info['permissions']))
1186
-			$user_info['permissions'][] = 'profile_view_any';
1237
+		if (in_array('profile_view', $user_info['permissions'])) {
1238
+					$user_info['permissions'][] = 'profile_view_any';
1239
+		}
1187 1240
 	}
1188 1241
 }
1189 1242
 
@@ -1201,8 +1254,9 @@  discard block
 block discarded – undo
1201 1254
 	global $image_proxy_enabled, $image_proxy_secret, $boardurl;
1202 1255
 
1203 1256
 	// Can't just look for no users :P.
1204
-	if (empty($users))
1205
-		return array();
1257
+	if (empty($users)) {
1258
+			return array();
1259
+	}
1206 1260
 
1207 1261
 	// Pass the set value
1208 1262
 	$context['loadMemberContext_set'] = $set;
@@ -1217,8 +1271,9 @@  discard block
 block discarded – undo
1217 1271
 		for ($i = 0, $n = count($users); $i < $n; $i++)
1218 1272
 		{
1219 1273
 			$data = cache_get_data('member_data-' . $set . '-' . $users[$i], 240);
1220
-			if ($data == null)
1221
-				continue;
1274
+			if ($data == null) {
1275
+							continue;
1276
+			}
1222 1277
 
1223 1278
 			$loaded_ids[] = $data['id_member'];
1224 1279
 			$user_profile[$data['id_member']] = $data;
@@ -1285,16 +1340,19 @@  discard block
 block discarded – undo
1285 1340
 			$row['avatar_original'] = !empty($row['avatar']) ? $row['avatar'] : '';
1286 1341
 
1287 1342
 			// Take care of proxying avatar if required, do this here for maximum reach
1288
-			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false)
1289
-				$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1343
+			if ($image_proxy_enabled && !empty($row['avatar']) && stripos($row['avatar'], 'http://') !== false) {
1344
+							$row['avatar'] = $boardurl . '/proxy.php?request=' . urlencode($row['avatar']) . '&hash=' . md5($row['avatar'] . $image_proxy_secret);
1345
+			}
1290 1346
 
1291 1347
 			// Keep track of the member's normal member group
1292 1348
 			$row['primary_group'] = $row['member_group'];
1293 1349
 
1294
-			if (isset($row['member_ip']))
1295
-				$row['member_ip'] = inet_dtop($row['member_ip']);
1296
-			if (isset($row['member_ip2']))
1297
-				$row['member_ip2'] = inet_dtop($row['member_ip2']);
1350
+			if (isset($row['member_ip'])) {
1351
+							$row['member_ip'] = inet_dtop($row['member_ip']);
1352
+			}
1353
+			if (isset($row['member_ip2'])) {
1354
+							$row['member_ip2'] = inet_dtop($row['member_ip2']);
1355
+			}
1298 1356
 			$new_loaded_ids[] = $row['id_member'];
1299 1357
 			$loaded_ids[] = $row['id_member'];
1300 1358
 			$row['options'] = array();
@@ -1313,8 +1371,9 @@  discard block
 block discarded – undo
1313 1371
 				'loaded_ids' => $new_loaded_ids,
1314 1372
 			)
1315 1373
 		);
1316
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1317
-			$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1374
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1375
+					$user_profile[$row['id_member']]['options'][$row['variable']] = $row['value'];
1376
+		}
1318 1377
 		$smcFunc['db_free_result']($request);
1319 1378
 	}
1320 1379
 
@@ -1325,10 +1384,11 @@  discard block
 block discarded – undo
1325 1384
 	{
1326 1385
 		foreach ($loaded_ids as $a_member)
1327 1386
 		{
1328
-			if (!empty($user_profile[$a_member]['additional_groups']))
1329
-				$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1330
-			else
1331
-				$groups = array($user_profile[$a_member]['id_group']);
1387
+			if (!empty($user_profile[$a_member]['additional_groups'])) {
1388
+							$groups = array_merge(array($user_profile[$a_member]['id_group']), explode(',', $user_profile[$a_member]['additional_groups']));
1389
+			} else {
1390
+							$groups = array($user_profile[$a_member]['id_group']);
1391
+			}
1332 1392
 
1333 1393
 			$temp = array_intersect($groups, array_keys($board_info['moderator_groups']));
1334 1394
 
@@ -1341,8 +1401,9 @@  discard block
 block discarded – undo
1341 1401
 
1342 1402
 	if (!empty($new_loaded_ids) && !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 3)
1343 1403
 	{
1344
-		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++)
1345
-			cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1404
+		for ($i = 0, $n = count($new_loaded_ids); $i < $n; $i++) {
1405
+					cache_put_data('member_data-' . $set . '-' . $new_loaded_ids[$i], $user_profile[$new_loaded_ids[$i]], 240);
1406
+		}
1346 1407
 	}
1347 1408
 
1348 1409
 	// Are we loading any moderators?  If so, fix their group data...
@@ -1368,14 +1429,17 @@  discard block
 block discarded – undo
1368 1429
 		foreach ($temp_mods as $id)
1369 1430
 		{
1370 1431
 			// By popular demand, don't show admins or global moderators as moderators.
1371
-			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2)
1372
-				$user_profile[$id]['member_group'] = $row['member_group'];
1432
+			if ($user_profile[$id]['id_group'] != 1 && $user_profile[$id]['id_group'] != 2) {
1433
+							$user_profile[$id]['member_group'] = $row['member_group'];
1434
+			}
1373 1435
 
1374 1436
 			// If the Moderator group has no color or icons, but their group does... don't overwrite.
1375
-			if (!empty($row['icons']))
1376
-				$user_profile[$id]['icons'] = $row['icons'];
1377
-			if (!empty($row['member_group_color']))
1378
-				$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1437
+			if (!empty($row['icons'])) {
1438
+							$user_profile[$id]['icons'] = $row['icons'];
1439
+			}
1440
+			if (!empty($row['member_group_color'])) {
1441
+							$user_profile[$id]['member_group_color'] = $row['member_group_color'];
1442
+			}
1379 1443
 		}
1380 1444
 	}
1381 1445
 
@@ -1397,12 +1461,14 @@  discard block
 block discarded – undo
1397 1461
 	static $loadedLanguages = array();
1398 1462
 
1399 1463
 	// If this person's data is already loaded, skip it.
1400
-	if (isset($dataLoaded[$user]))
1401
-		return true;
1464
+	if (isset($dataLoaded[$user])) {
1465
+			return true;
1466
+	}
1402 1467
 
1403 1468
 	// We can't load guests or members not loaded by loadMemberData()!
1404
-	if ($user == 0)
1405
-		return false;
1469
+	if ($user == 0) {
1470
+			return false;
1471
+	}
1406 1472
 	if (!isset($user_profile[$user]))
1407 1473
 	{
1408 1474
 		trigger_error('loadMemberContext(): member id ' . $user . ' not previously loaded by loadMemberData()', E_USER_WARNING);
@@ -1428,12 +1494,16 @@  discard block
 block discarded – undo
1428 1494
 	$buddy_list = !empty($profile['buddy_list']) ? explode(',', $profile['buddy_list']) : array();
1429 1495
 
1430 1496
 	//We need a little fallback for the membergroup icons. If it doesn't exist in the current theme, fallback to default theme
1431
-	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) //icon is set and exists
1497
+	if (isset($profile['icons'][1]) && file_exists($settings['actual_theme_dir'] . '/images/membericons/' . $profile['icons'][1])) {
1498
+		//icon is set and exists
1432 1499
 		$group_icon_url = $settings['images_url'] . '/membericons/' . $profile['icons'][1];
1433
-	elseif (isset($profile['icons'][1])) //icon is set and doesn't exist, fallback to default
1500
+	} elseif (isset($profile['icons'][1])) {
1501
+		//icon is set and doesn't exist, fallback to default
1434 1502
 		$group_icon_url = $settings['default_images_url'] . '/membericons/' . $profile['icons'][1];
1435
-	else //not set, bye bye
1503
+	} else {
1504
+		//not set, bye bye
1436 1505
 		$group_icon_url = '';
1506
+	}
1437 1507
 
1438 1508
 	// These minimal values are always loaded
1439 1509
 	$memberContext[$user] = array(
@@ -1452,8 +1522,9 @@  discard block
 block discarded – undo
1452 1522
 	if ($context['loadMemberContext_set'] != 'minimal')
1453 1523
 	{
1454 1524
 		// Go the extra mile and load the user's native language name.
1455
-		if (empty($loadedLanguages))
1456
-			$loadedLanguages = getLanguages();
1525
+		if (empty($loadedLanguages)) {
1526
+					$loadedLanguages = getLanguages();
1527
+		}
1457 1528
 
1458 1529
 		$memberContext[$user] += array(
1459 1530
 			'username_color' => '<span ' . (!empty($profile['member_group_color']) ? 'style="color:' . $profile['member_group_color'] . ';"' : '') . '>' . $profile['member_name'] . '</span>',
@@ -1508,31 +1579,33 @@  discard block
 block discarded – undo
1508 1579
 	{
1509 1580
 		if (!empty($modSettings['gravatarOverride']) || (!empty($modSettings['gravatarEnabled']) && stristr($profile['avatar'], 'gravatar://')))
1510 1581
 		{
1511
-			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11)
1512
-				$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1513
-			else
1514
-				$image = get_gravatar_url($profile['email_address']);
1515
-		}
1516
-		else
1582
+			if (!empty($modSettings['gravatarAllowExtraEmail']) && stristr($profile['avatar'], 'gravatar://') && strlen($profile['avatar']) > 11) {
1583
+							$image = get_gravatar_url($smcFunc['substr']($profile['avatar'], 11));
1584
+			} else {
1585
+							$image = get_gravatar_url($profile['email_address']);
1586
+			}
1587
+		} else
1517 1588
 		{
1518 1589
 			// So it's stored in the member table?
1519 1590
 			if (!empty($profile['avatar']))
1520 1591
 			{
1521 1592
 				$image = (stristr($profile['avatar'], 'http://') || stristr($profile['avatar'], 'https://')) ? $profile['avatar'] : $modSettings['avatar_url'] . '/' . $profile['avatar'];
1593
+			} elseif (!empty($profile['filename'])) {
1594
+							$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1522 1595
 			}
1523
-			elseif (!empty($profile['filename']))
1524
-				$image = $modSettings['custom_avatar_url'] . '/' . $profile['filename'];
1525 1596
 			// Right... no avatar...use the default one
1526
-			else
1527
-				$image = $modSettings['avatar_url'] . '/default.png';
1597
+			else {
1598
+							$image = $modSettings['avatar_url'] . '/default.png';
1599
+			}
1528 1600
 		}
1529
-		if (!empty($image))
1530
-			$memberContext[$user]['avatar'] = array(
1601
+		if (!empty($image)) {
1602
+					$memberContext[$user]['avatar'] = array(
1531 1603
 				'name' => $profile['avatar'],
1532 1604
 				'image' => '<img class="avatar" src="' . $image . '" alt="avatar_' . $profile['member_name'] . '">',
1533 1605
 				'href' => $image,
1534 1606
 				'url' => $image,
1535 1607
 			);
1608
+		}
1536 1609
 	}
1537 1610
 
1538 1611
 	// Are we also loading the members custom fields into context?
@@ -1540,35 +1613,41 @@  discard block
 block discarded – undo
1540 1613
 	{
1541 1614
 		$memberContext[$user]['custom_fields'] = array();
1542 1615
 
1543
-		if (!isset($context['display_fields']))
1544
-			$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1616
+		if (!isset($context['display_fields'])) {
1617
+					$context['display_fields'] = $smcFunc['json_decode']($modSettings['displayFields'], true);
1618
+		}
1545 1619
 
1546 1620
 		foreach ($context['display_fields'] as $custom)
1547 1621
 		{
1548
-			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']]))
1549
-				continue;
1622
+			if (!isset($custom['col_name']) || trim($custom['col_name']) == '' || empty($profile['options'][$custom['col_name']])) {
1623
+							continue;
1624
+			}
1550 1625
 
1551 1626
 			$value = $profile['options'][$custom['col_name']];
1552 1627
 
1553 1628
 			// Don't show the "disabled" option for the "gender" field.
1554
-			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled')
1555
-				continue;
1629
+			if ($custom['col_name'] == 'cust_gender' && $value == 'Disabled') {
1630
+							continue;
1631
+			}
1556 1632
 
1557 1633
 			// BBC?
1558
-			if ($custom['bbc'])
1559
-				$value = parse_bbc($value);
1634
+			if ($custom['bbc']) {
1635
+							$value = parse_bbc($value);
1636
+			}
1560 1637
 			// ... or checkbox?
1561
-			elseif (isset($custom['type']) && $custom['type'] == 'check')
1562
-				$value = $value ? $txt['yes'] : $txt['no'];
1638
+			elseif (isset($custom['type']) && $custom['type'] == 'check') {
1639
+							$value = $value ? $txt['yes'] : $txt['no'];
1640
+			}
1563 1641
 
1564 1642
 			// Enclosing the user input within some other text?
1565
-			if (!empty($custom['enclose']))
1566
-				$value = strtr($custom['enclose'], array(
1643
+			if (!empty($custom['enclose'])) {
1644
+							$value = strtr($custom['enclose'], array(
1567 1645
 					'{SCRIPTURL}' => $scripturl,
1568 1646
 					'{IMAGES_URL}' => $settings['images_url'],
1569 1647
 					'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1570 1648
 					'{INPUT}' => $value,
1571 1649
 				));
1650
+			}
1572 1651
 
1573 1652
 			$memberContext[$user]['custom_fields'][] = array(
1574 1653
 				'title' => !empty($custom['title']) ? $custom['title'] : $custom['col_name'],
@@ -1595,8 +1674,9 @@  discard block
 block discarded – undo
1595 1674
 	global $smcFunc, $txt, $scripturl, $settings;
1596 1675
 
1597 1676
 	// Do not waste my time...
1598
-	if (empty($users) || empty($params))
1599
-		return false;
1677
+	if (empty($users) || empty($params)) {
1678
+			return false;
1679
+	}
1600 1680
 
1601 1681
 	// Make sure it's an array.
1602 1682
 	$users = !is_array($users) ? array($users) : array_unique($users);
@@ -1620,31 +1700,36 @@  discard block
 block discarded – undo
1620 1700
 	while ($row = $smcFunc['db_fetch_assoc']($request))
1621 1701
 	{
1622 1702
 		// BBC?
1623
-		if (!empty($row['bbc']))
1624
-			$row['value'] = parse_bbc($row['value']);
1703
+		if (!empty($row['bbc'])) {
1704
+					$row['value'] = parse_bbc($row['value']);
1705
+		}
1625 1706
 
1626 1707
 		// ... or checkbox?
1627
-		elseif (isset($row['type']) && $row['type'] == 'check')
1628
-			$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1708
+		elseif (isset($row['type']) && $row['type'] == 'check') {
1709
+					$row['value'] = !empty($row['value']) ? $txt['yes'] : $txt['no'];
1710
+		}
1629 1711
 
1630 1712
 		// Enclosing the user input within some other text?
1631
-		if (!empty($row['enclose']))
1632
-			$row['value'] = strtr($row['enclose'], array(
1713
+		if (!empty($row['enclose'])) {
1714
+					$row['value'] = strtr($row['enclose'], array(
1633 1715
 				'{SCRIPTURL}' => $scripturl,
1634 1716
 				'{IMAGES_URL}' => $settings['images_url'],
1635 1717
 				'{DEFAULT_IMAGES_URL}' => $settings['default_images_url'],
1636 1718
 				'{INPUT}' => un_htmlspecialchars($row['value']),
1637 1719
 			));
1720
+		}
1638 1721
 
1639 1722
 		// Send a simple array if there is just 1 param
1640
-		if (count($params) == 1)
1641
-			$return[$row['id_member']] = $row;
1723
+		if (count($params) == 1) {
1724
+					$return[$row['id_member']] = $row;
1725
+		}
1642 1726
 
1643 1727
 		// More than 1? knock yourself out...
1644 1728
 		else
1645 1729
 		{
1646
-			if (!isset($return[$row['id_member']]))
1647
-				$return[$row['id_member']] = array();
1730
+			if (!isset($return[$row['id_member']])) {
1731
+							$return[$row['id_member']] = array();
1732
+			}
1648 1733
 
1649 1734
 			$return[$row['id_member']][$row['variable']] = $row;
1650 1735
 		}
@@ -1678,8 +1763,9 @@  discard block
 block discarded – undo
1678 1763
 	global $context;
1679 1764
 
1680 1765
 	// Don't know any browser!
1681
-	if (empty($context['browser']))
1682
-		detectBrowser();
1766
+	if (empty($context['browser'])) {
1767
+			detectBrowser();
1768
+	}
1683 1769
 
1684 1770
 	return !empty($context['browser'][$browser]) || !empty($context['browser']['is_' . $browser]) ? true : false;
1685 1771
 }
@@ -1697,8 +1783,9 @@  discard block
 block discarded – undo
1697 1783
 	global $context, $settings, $options, $sourcedir, $ssi_theme, $smcFunc, $language, $board, $image_proxy_enabled;
1698 1784
 
1699 1785
 	// The theme was specified by parameter.
1700
-	if (!empty($id_theme))
1701
-		$id_theme = (int) $id_theme;
1786
+	if (!empty($id_theme)) {
1787
+			$id_theme = (int) $id_theme;
1788
+	}
1702 1789
 	// The theme was specified by REQUEST.
1703 1790
 	elseif (!empty($_REQUEST['theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1704 1791
 	{
@@ -1706,54 +1793,61 @@  discard block
 block discarded – undo
1706 1793
 		$_SESSION['id_theme'] = $id_theme;
1707 1794
 	}
1708 1795
 	// The theme was specified by REQUEST... previously.
1709
-	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum')))
1710
-		$id_theme = (int) $_SESSION['id_theme'];
1796
+	elseif (!empty($_SESSION['id_theme']) && (!empty($modSettings['theme_allow']) || allowedTo('admin_forum'))) {
1797
+			$id_theme = (int) $_SESSION['id_theme'];
1798
+	}
1711 1799
 	// The theme is just the user's choice. (might use ?board=1;theme=0 to force board theme.)
1712
-	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme']))
1713
-		$id_theme = $user_info['theme'];
1800
+	elseif (!empty($user_info['theme']) && !isset($_REQUEST['theme'])) {
1801
+			$id_theme = $user_info['theme'];
1802
+	}
1714 1803
 	// The theme was specified by the board.
1715
-	elseif (!empty($board_info['theme']))
1716
-		$id_theme = $board_info['theme'];
1804
+	elseif (!empty($board_info['theme'])) {
1805
+			$id_theme = $board_info['theme'];
1806
+	}
1717 1807
 	// The theme is the forum's default.
1718
-	else
1719
-		$id_theme = $modSettings['theme_guests'];
1808
+	else {
1809
+			$id_theme = $modSettings['theme_guests'];
1810
+	}
1720 1811
 
1721 1812
 	// We already load the basic stuff?
1722 1813
 	if (empty($settings['theme_id']) || $settings['theme_id'] != $id_theme )
1723 1814
 	{
1724 1815
 		// Verify the id_theme... no foul play.
1725 1816
 		// Always allow the board specific theme, if they are overriding.
1726
-		if (!empty($board_info['theme']) && $board_info['override_theme'])
1727
-			$id_theme = $board_info['theme'];
1817
+		if (!empty($board_info['theme']) && $board_info['override_theme']) {
1818
+					$id_theme = $board_info['theme'];
1819
+		}
1728 1820
 		// If they have specified a particular theme to use with SSI allow it to be used.
1729
-		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme)
1730
-			$id_theme = (int) $id_theme;
1731
-		elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1821
+		elseif (!empty($ssi_theme) && $id_theme == $ssi_theme) {
1822
+					$id_theme = (int) $id_theme;
1823
+		} elseif (!empty($modSettings['enableThemes']) && !allowedTo('admin_forum'))
1732 1824
 		{
1733 1825
 			$themes = explode(',', $modSettings['enableThemes']);
1734
-			if (!in_array($id_theme, $themes))
1735
-				$id_theme = $modSettings['theme_guests'];
1736
-			else
1737
-				$id_theme = (int) $id_theme;
1826
+			if (!in_array($id_theme, $themes)) {
1827
+							$id_theme = $modSettings['theme_guests'];
1828
+			} else {
1829
+							$id_theme = (int) $id_theme;
1830
+			}
1831
+		} else {
1832
+					$id_theme = (int) $id_theme;
1738 1833
 		}
1739
-		else
1740
-			$id_theme = (int) $id_theme;
1741 1834
 
1742 1835
 		$member = empty($user_info['id']) ? -1 : $user_info['id'];
1743 1836
 
1744 1837
 		// Disable image proxy if we don't have SSL enabled
1745
-		if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2)
1746
-			$image_proxy_enabled = false;
1838
+		if (empty($modSettings['force_ssl']) || $modSettings['force_ssl'] < 2) {
1839
+					$image_proxy_enabled = false;
1840
+		}
1747 1841
 
1748 1842
 		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2 && ($temp = cache_get_data('theme_settings-' . $id_theme . ':' . $member, 60)) != null && time() - 60 > $modSettings['settings_updated'])
1749 1843
 		{
1750 1844
 			$themeData = $temp;
1751 1845
 			$flag = true;
1846
+		} elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated']) {
1847
+					$themeData = $temp + array($member => array());
1848
+		} else {
1849
+					$themeData = array(-1 => array(), 0 => array(), $member => array());
1752 1850
 		}
1753
-		elseif (($temp = cache_get_data('theme_settings-' . $id_theme, 90)) != null && time() - 60 > $modSettings['settings_updated'])
1754
-			$themeData = $temp + array($member => array());
1755
-		else
1756
-			$themeData = array(-1 => array(), 0 => array(), $member => array());
1757 1851
 
1758 1852
 		if (empty($flag))
1759 1853
 		{
@@ -1772,31 +1866,37 @@  discard block
 block discarded – undo
1772 1866
 			while ($row = $smcFunc['db_fetch_assoc']($result))
1773 1867
 			{
1774 1868
 				// There are just things we shouldn't be able to change as members.
1775
-				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url')))
1776
-					continue;
1869
+				if ($row['id_member'] != 0 && in_array($row['variable'], array('actual_theme_url', 'actual_images_url', 'base_theme_dir', 'base_theme_url', 'default_images_url', 'default_theme_dir', 'default_theme_url', 'default_template', 'images_url', 'number_recent_posts', 'smiley_sets_default', 'theme_dir', 'theme_id', 'theme_layers', 'theme_templates', 'theme_url'))) {
1870
+									continue;
1871
+				}
1777 1872
 
1778 1873
 				// If this is the theme_dir of the default theme, store it.
1779
-				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member']))
1780
-					$themeData[0]['default_' . $row['variable']] = $row['value'];
1874
+				if (in_array($row['variable'], array('theme_dir', 'theme_url', 'images_url')) && $row['id_theme'] == '1' && empty($row['id_member'])) {
1875
+									$themeData[0]['default_' . $row['variable']] = $row['value'];
1876
+				}
1781 1877
 
1782 1878
 				// If this isn't set yet, is a theme option, or is not the default theme..
1783
-				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1')
1784
-					$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1879
+				if (!isset($themeData[$row['id_member']][$row['variable']]) || $row['id_theme'] != '1') {
1880
+									$themeData[$row['id_member']][$row['variable']] = substr($row['variable'], 0, 5) == 'show_' ? $row['value'] == '1' : $row['value'];
1881
+				}
1785 1882
 			}
1786 1883
 			$smcFunc['db_free_result']($result);
1787 1884
 
1788
-			if (!empty($themeData[-1]))
1789
-				foreach ($themeData[-1] as $k => $v)
1885
+			if (!empty($themeData[-1])) {
1886
+							foreach ($themeData[-1] as $k => $v)
1790 1887
 				{
1791 1888
 					if (!isset($themeData[$member][$k]))
1792 1889
 						$themeData[$member][$k] = $v;
1890
+			}
1793 1891
 				}
1794 1892
 
1795
-			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2)
1796
-				cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1893
+			if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= 2) {
1894
+							cache_put_data('theme_settings-' . $id_theme . ':' . $member, $themeData, 60);
1895
+			}
1797 1896
 			// Only if we didn't already load that part of the cache...
1798
-			elseif (!isset($temp))
1799
-				cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1897
+			elseif (!isset($temp)) {
1898
+							cache_put_data('theme_settings-' . $id_theme, array(-1 => $themeData[-1], 0 => $themeData[0]), 90);
1899
+			}
1800 1900
 		}
1801 1901
 
1802 1902
 		$settings = $themeData[0];
@@ -1813,22 +1913,26 @@  discard block
 block discarded – undo
1813 1913
 		$settings['template_dirs'][] = $settings['theme_dir'];
1814 1914
 
1815 1915
 		// Based on theme (if there is one).
1816
-		if (!empty($settings['base_theme_dir']))
1817
-			$settings['template_dirs'][] = $settings['base_theme_dir'];
1916
+		if (!empty($settings['base_theme_dir'])) {
1917
+					$settings['template_dirs'][] = $settings['base_theme_dir'];
1918
+		}
1818 1919
 
1819 1920
 		// Lastly the default theme.
1820
-		if ($settings['theme_dir'] != $settings['default_theme_dir'])
1821
-			$settings['template_dirs'][] = $settings['default_theme_dir'];
1921
+		if ($settings['theme_dir'] != $settings['default_theme_dir']) {
1922
+					$settings['template_dirs'][] = $settings['default_theme_dir'];
1923
+		}
1822 1924
 	}
1823 1925
 	
1824 1926
 
1825
-	if (!$initialize)
1826
-		return;
1927
+	if (!$initialize) {
1928
+			return;
1929
+	}
1827 1930
 
1828 1931
 	// Check to see if we're forcing SSL
1829 1932
 	if (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] == 2 && empty($maintenance) &&
1830
-		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI')
1831
-		redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1933
+		(!isset($_SERVER['HTTPS']) || $_SERVER['HTTPS'] == 'off') && SMF != 'SSI') {
1934
+			redirectexit(strtr($_SERVER['REQUEST_URL'], array('http://' => 'https://')));
1935
+	}
1832 1936
 
1833 1937
 	// Check to see if they're accessing it from the wrong place.
1834 1938
 	if (isset($_SERVER['HTTP_HOST']) || isset($_SERVER['SERVER_NAME']))
@@ -1836,8 +1940,9 @@  discard block
 block discarded – undo
1836 1940
 		$detected_url = isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on' ? 'https://' : 'http://';
1837 1941
 		$detected_url .= empty($_SERVER['HTTP_HOST']) ? $_SERVER['SERVER_NAME'] . (empty($_SERVER['SERVER_PORT']) || $_SERVER['SERVER_PORT'] == '80' ? '' : ':' . $_SERVER['SERVER_PORT']) : $_SERVER['HTTP_HOST'];
1838 1942
 		$temp = preg_replace('~/' . basename($scripturl) . '(/.+)?$~', '', strtr(dirname($_SERVER['PHP_SELF']), '\\', '/'));
1839
-		if ($temp != '/')
1840
-			$detected_url .= $temp;
1943
+		if ($temp != '/') {
1944
+					$detected_url .= $temp;
1945
+		}
1841 1946
 	}
1842 1947
 	if (isset($detected_url) && $detected_url != $boardurl)
1843 1948
 	{
@@ -1849,8 +1954,9 @@  discard block
 block discarded – undo
1849 1954
 			foreach ($aliases as $alias)
1850 1955
 			{
1851 1956
 				// Rip off all the boring parts, spaces, etc.
1852
-				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias))
1853
-					$do_fix = true;
1957
+				if ($detected_url == trim($alias) || strtr($detected_url, array('http://' => '', 'https://' => '')) == trim($alias)) {
1958
+									$do_fix = true;
1959
+				}
1854 1960
 			}
1855 1961
 		}
1856 1962
 
@@ -1858,20 +1964,22 @@  discard block
 block discarded – undo
1858 1964
 		if (empty($do_fix) && strtr($detected_url, array('://' => '://www.')) == $boardurl && (empty($_GET) || count($_GET) == 1) && SMF != 'SSI')
1859 1965
 		{
1860 1966
 			// Okay, this seems weird, but we don't want an endless loop - this will make $_GET not empty ;).
1861
-			if (empty($_GET))
1862
-				redirectexit('wwwRedirect');
1863
-			else
1967
+			if (empty($_GET)) {
1968
+							redirectexit('wwwRedirect');
1969
+			} else
1864 1970
 			{
1865 1971
 				list ($k, $v) = each($_GET);
1866 1972
 
1867
-				if ($k != 'wwwRedirect')
1868
-					redirectexit('wwwRedirect;' . $k . '=' . $v);
1973
+				if ($k != 'wwwRedirect') {
1974
+									redirectexit('wwwRedirect;' . $k . '=' . $v);
1975
+				}
1869 1976
 			}
1870 1977
 		}
1871 1978
 
1872 1979
 		// #3 is just a check for SSL...
1873
-		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl)
1874
-			$do_fix = true;
1980
+		if (strtr($detected_url, array('https://' => 'http://')) == $boardurl) {
1981
+					$do_fix = true;
1982
+		}
1875 1983
 
1876 1984
 		// Okay, #4 - perhaps it's an IP address?  We're gonna want to use that one, then. (assuming it's the IP or something...)
1877 1985
 		if (!empty($do_fix) || preg_match('~^http[s]?://(?:[\d\.:]+|\[[\d:]+\](?::\d+)?)(?:$|/)~', $detected_url) == 1)
@@ -1905,8 +2013,9 @@  discard block
 block discarded – undo
1905 2013
 					$board_info['moderators'][$k]['link'] = strtr($dummy['link'], array('"' . $oldurl => '"' . $boardurl));
1906 2014
 				}
1907 2015
 			}
1908
-			foreach ($context['linktree'] as $k => $dummy)
1909
-				$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2016
+			foreach ($context['linktree'] as $k => $dummy) {
2017
+							$context['linktree'][$k]['url'] = strtr($dummy['url'], array($oldurl => $boardurl));
2018
+			}
1910 2019
 		}
1911 2020
 	}
1912 2021
 	// Set up the contextual user array.
@@ -1925,16 +2034,16 @@  discard block
 block discarded – undo
1925 2034
 			'email' => $user_info['email'],
1926 2035
 			'ignoreusers' => $user_info['ignoreusers'],
1927 2036
 		);
1928
-		if (!$context['user']['is_guest'])
1929
-			$context['user']['name'] = $user_info['name'];
1930
-		elseif ($context['user']['is_guest'] && !empty($txt['guest_title']))
1931
-			$context['user']['name'] = $txt['guest_title'];
2037
+		if (!$context['user']['is_guest']) {
2038
+					$context['user']['name'] = $user_info['name'];
2039
+		} elseif ($context['user']['is_guest'] && !empty($txt['guest_title'])) {
2040
+					$context['user']['name'] = $txt['guest_title'];
2041
+		}
1932 2042
 
1933 2043
 		// Determine the current smiley set.
1934 2044
 		$user_info['smiley_set'] = (!in_array($user_info['smiley_set'], explode(',', $modSettings['smiley_sets_known'])) && $user_info['smiley_set'] != 'none') || empty($modSettings['smiley_sets_enable']) ? (!empty($settings['smiley_sets_default']) ? $settings['smiley_sets_default'] : $modSettings['smiley_sets_default']) : $user_info['smiley_set'];
1935 2045
 		$context['user']['smiley_set'] = $user_info['smiley_set'];
1936
-	}
1937
-	else
2046
+	} else
1938 2047
 	{
1939 2048
 		$context['user'] = array(
1940 2049
 			'id' => -1,
@@ -1950,18 +2059,24 @@  discard block
 block discarded – undo
1950 2059
 	}
1951 2060
 
1952 2061
 	// Some basic information...
1953
-	if (!isset($context['html_headers']))
1954
-		$context['html_headers'] = '';
1955
-	if (!isset($context['javascript_files']))
1956
-		$context['javascript_files'] = array();
1957
-	if (!isset($context['css_files']))
1958
-		$context['css_files'] = array();
1959
-	if (!isset($context['css_header']))
1960
-		$context['css_header'] = array();
1961
-	if (!isset($context['javascript_inline']))
1962
-		$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
1963
-	if (!isset($context['javascript_vars']))
1964
-		$context['javascript_vars'] = array();
2062
+	if (!isset($context['html_headers'])) {
2063
+			$context['html_headers'] = '';
2064
+	}
2065
+	if (!isset($context['javascript_files'])) {
2066
+			$context['javascript_files'] = array();
2067
+	}
2068
+	if (!isset($context['css_files'])) {
2069
+			$context['css_files'] = array();
2070
+	}
2071
+	if (!isset($context['css_header'])) {
2072
+			$context['css_header'] = array();
2073
+	}
2074
+	if (!isset($context['javascript_inline'])) {
2075
+			$context['javascript_inline'] = array('standard' => array(), 'defer' => array());
2076
+	}
2077
+	if (!isset($context['javascript_vars'])) {
2078
+			$context['javascript_vars'] = array();
2079
+	}
1965 2080
 
1966 2081
 	$context['login_url'] = (!empty($modSettings['force_ssl']) && $modSettings['force_ssl'] < 2 ? strtr($scripturl, array('http://' => 'https://')) : $scripturl) . '?action=login2';
1967 2082
 	$context['menu_separator'] = !empty($settings['use_image_buttons']) ? ' ' : ' | ';
@@ -1973,8 +2088,9 @@  discard block
 block discarded – undo
1973 2088
 	$context['current_action'] = isset($_REQUEST['action']) ? $smcFunc['htmlspecialchars']($_REQUEST['action']) : null;
1974 2089
 	$context['current_subaction'] = isset($_REQUEST['sa']) ? $_REQUEST['sa'] : null;
1975 2090
 	$context['can_register'] = empty($modSettings['registration_method']) || $modSettings['registration_method'] != 3;
1976
-	if (isset($modSettings['load_average']))
1977
-		$context['load_average'] = $modSettings['load_average'];
2091
+	if (isset($modSettings['load_average'])) {
2092
+			$context['load_average'] = $modSettings['load_average'];
2093
+	}
1978 2094
 
1979 2095
 	// Detect the browser. This is separated out because it's also used in attachment downloads
1980 2096
 	detectBrowser();
@@ -1988,8 +2104,9 @@  discard block
 block discarded – undo
1988 2104
 	// This allows sticking some HTML on the page output - useful for controls.
1989 2105
 	$context['insert_after_template'] = '';
1990 2106
 
1991
-	if (!isset($txt))
1992
-		$txt = array();
2107
+	if (!isset($txt)) {
2108
+			$txt = array();
2109
+	}
1993 2110
 
1994 2111
 	$simpleActions = array(
1995 2112
 		'findmember',
@@ -2035,9 +2152,10 @@  discard block
 block discarded – undo
2035 2152
 
2036 2153
 	// See if theres any extra param to check.
2037 2154
 	$requiresXML = false;
2038
-	foreach ($extraParams as $key => $extra)
2039
-		if (isset($_REQUEST[$extra]))
2155
+	foreach ($extraParams as $key => $extra) {
2156
+			if (isset($_REQUEST[$extra]))
2040 2157
 			$requiresXML = true;
2158
+	}
2041 2159
 
2042 2160
 	// Output is fully XML, so no need for the index template.
2043 2161
 	if (isset($_REQUEST['xml']) && (in_array($context['current_action'], $xmlActions) || $requiresXML))
@@ -2052,37 +2170,39 @@  discard block
 block discarded – undo
2052 2170
 	{
2053 2171
 		loadLanguage('index+Modifications');
2054 2172
 		$context['template_layers'] = array();
2055
-	}
2056
-
2057
-	else
2173
+	} else
2058 2174
 	{
2059 2175
 		// Custom templates to load, or just default?
2060
-		if (isset($settings['theme_templates']))
2061
-			$templates = explode(',', $settings['theme_templates']);
2062
-		else
2063
-			$templates = array('index');
2176
+		if (isset($settings['theme_templates'])) {
2177
+					$templates = explode(',', $settings['theme_templates']);
2178
+		} else {
2179
+					$templates = array('index');
2180
+		}
2064 2181
 
2065 2182
 		// Load each template...
2066
-		foreach ($templates as $template)
2067
-			loadTemplate($template);
2183
+		foreach ($templates as $template) {
2184
+					loadTemplate($template);
2185
+		}
2068 2186
 
2069 2187
 		// ...and attempt to load their associated language files.
2070 2188
 		$required_files = implode('+', array_merge($templates, array('Modifications')));
2071 2189
 		loadLanguage($required_files, '', false);
2072 2190
 
2073 2191
 		// Custom template layers?
2074
-		if (isset($settings['theme_layers']))
2075
-			$context['template_layers'] = explode(',', $settings['theme_layers']);
2076
-		else
2077
-			$context['template_layers'] = array('html', 'body');
2192
+		if (isset($settings['theme_layers'])) {
2193
+					$context['template_layers'] = explode(',', $settings['theme_layers']);
2194
+		} else {
2195
+					$context['template_layers'] = array('html', 'body');
2196
+		}
2078 2197
 	}
2079 2198
 
2080 2199
 	// Initialize the theme.
2081 2200
 	loadSubTemplate('init', 'ignore');
2082 2201
 
2083 2202
 	// Allow overriding the board wide time/number formats.
2084
-	if (empty($user_settings['time_format']) && !empty($txt['time_format']))
2085
-		$user_info['time_format'] = $txt['time_format'];
2203
+	if (empty($user_settings['time_format']) && !empty($txt['time_format'])) {
2204
+			$user_info['time_format'] = $txt['time_format'];
2205
+	}
2086 2206
 
2087 2207
 	// Set the character set from the template.
2088 2208
 	$context['character_set'] = empty($modSettings['global_character_set']) ? $txt['lang_character_set'] : $modSettings['global_character_set'];
@@ -2090,12 +2210,14 @@  discard block
 block discarded – undo
2090 2210
 	$context['right_to_left'] = !empty($txt['lang_rtl']);
2091 2211
 
2092 2212
 	// Guests may still need a name.
2093
-	if ($context['user']['is_guest'] && empty($context['user']['name']))
2094
-		$context['user']['name'] = $txt['guest_title'];
2213
+	if ($context['user']['is_guest'] && empty($context['user']['name'])) {
2214
+			$context['user']['name'] = $txt['guest_title'];
2215
+	}
2095 2216
 
2096 2217
 	// Any theme-related strings that need to be loaded?
2097
-	if (!empty($settings['require_theme_strings']))
2098
-		loadLanguage('ThemeStrings', '', false);
2218
+	if (!empty($settings['require_theme_strings'])) {
2219
+			loadLanguage('ThemeStrings', '', false);
2220
+	}
2099 2221
 
2100 2222
 	// Make a special URL for the language.
2101 2223
 	$settings['lang_images_url'] = $settings['images_url'] . '/' . (!empty($txt['image_lang']) ? $txt['image_lang'] : $user_info['language']);
@@ -2106,8 +2228,9 @@  discard block
 block discarded – undo
2106 2228
 	// Here is my luvly Responsive CSS
2107 2229
 	loadCSSFile('responsive.css', array('force_current' => false, 'validate' => true, 'minimize' => true), 'smf_responsive');
2108 2230
 
2109
-	if ($context['right_to_left'])
2110
-		loadCSSFile('rtl.css', array(), 'smf_rtl');
2231
+	if ($context['right_to_left']) {
2232
+			loadCSSFile('rtl.css', array(), 'smf_rtl');
2233
+	}
2111 2234
 
2112 2235
 	// We allow theme variants, because we're cool.
2113 2236
 	$context['theme_variant'] = '';
@@ -2115,14 +2238,17 @@  discard block
 block discarded – undo
2115 2238
 	if (!empty($settings['theme_variants']))
2116 2239
 	{
2117 2240
 		// Overriding - for previews and that ilk.
2118
-		if (!empty($_REQUEST['variant']))
2119
-			$_SESSION['id_variant'] = $_REQUEST['variant'];
2241
+		if (!empty($_REQUEST['variant'])) {
2242
+					$_SESSION['id_variant'] = $_REQUEST['variant'];
2243
+		}
2120 2244
 		// User selection?
2121
-		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum'))
2122
-			$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2245
+		if (empty($settings['disable_user_variant']) || allowedTo('admin_forum')) {
2246
+					$context['theme_variant'] = !empty($_SESSION['id_variant']) ? $_SESSION['id_variant'] : (!empty($options['theme_variant']) ? $options['theme_variant'] : '');
2247
+		}
2123 2248
 		// If not a user variant, select the default.
2124
-		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants']))
2125
-			$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2249
+		if ($context['theme_variant'] == '' || !in_array($context['theme_variant'], $settings['theme_variants'])) {
2250
+					$context['theme_variant'] = !empty($settings['default_variant']) && in_array($settings['default_variant'], $settings['theme_variants']) ? $settings['default_variant'] : $settings['theme_variants'][0];
2251
+		}
2126 2252
 
2127 2253
 		// Do this to keep things easier in the templates.
2128 2254
 		$context['theme_variant'] = '_' . $context['theme_variant'];
@@ -2131,20 +2257,23 @@  discard block
 block discarded – undo
2131 2257
 		if (!empty($context['theme_variant']))
2132 2258
 		{
2133 2259
 			loadCSSFile('index' . $context['theme_variant'] . '.css', array(), 'smf_index' . $context['theme_variant']);
2134
-			if ($context['right_to_left'])
2135
-				loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2260
+			if ($context['right_to_left']) {
2261
+							loadCSSFile('rtl' . $context['theme_variant'] . '.css', array(), 'smf_rtl' . $context['theme_variant']);
2262
+			}
2136 2263
 		}
2137 2264
 	}
2138 2265
 
2139 2266
 	// Let's be compatible with old themes!
2140
-	if (!function_exists('template_html_above') && in_array('html', $context['template_layers']))
2141
-		$context['template_layers'] = array('main');
2267
+	if (!function_exists('template_html_above') && in_array('html', $context['template_layers'])) {
2268
+			$context['template_layers'] = array('main');
2269
+	}
2142 2270
 
2143 2271
 	$context['tabindex'] = 1;
2144 2272
 
2145 2273
 	// Compatibility.
2146
-	if (!isset($settings['theme_version']))
2147
-		$modSettings['memberCount'] = $modSettings['totalMembers'];
2274
+	if (!isset($settings['theme_version'])) {
2275
+			$modSettings['memberCount'] = $modSettings['totalMembers'];
2276
+	}
2148 2277
 
2149 2278
 	// Default JS variables for use in every theme
2150 2279
 	$context['javascript_vars'] = array(
@@ -2163,18 +2292,18 @@  discard block
 block discarded – undo
2163 2292
 	);
2164 2293
 
2165 2294
 	// Add the JQuery library to the list of files to load.
2166
-	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn')
2167
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2168
-
2169
-	elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local')
2170
-		loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2171
-
2172
-	elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom')
2173
-		loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2295
+	if (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'cdn') {
2296
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2297
+	} elseif (isset($modSettings['jquery_source']) && $modSettings['jquery_source'] == 'local') {
2298
+			loadJavaScriptFile('jquery-3.1.1.min.js', array('seed' => false), 'smf_jquery');
2299
+	} elseif (isset($modSettings['jquery_source'], $modSettings['jquery_custom']) && $modSettings['jquery_source'] == 'custom') {
2300
+			loadJavaScriptFile($modSettings['jquery_custom'], array('external' => true), 'smf_jquery');
2301
+	}
2174 2302
 
2175 2303
 	// Auto loading? template_javascript() will take care of the local half of this.
2176
-	else
2177
-		loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2304
+	else {
2305
+			loadJavaScriptFile('https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js', array('external' => true), 'smf_jquery');
2306
+	}
2178 2307
 
2179 2308
 	// Queue our JQuery plugins!
2180 2309
 	loadJavaScriptFile('smf_jquery_plugins.js', array('minimize' => true), 'smf_jquery_plugins');
@@ -2197,12 +2326,12 @@  discard block
 block discarded – undo
2197 2326
 			require_once($sourcedir . '/ScheduledTasks.php');
2198 2327
 
2199 2328
 			// What to do, what to do?!
2200
-			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time())
2201
-				AutoTask();
2202
-			else
2203
-				ReduceMailQueue();
2204
-		}
2205
-		else
2329
+			if (empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time()) {
2330
+							AutoTask();
2331
+			} else {
2332
+							ReduceMailQueue();
2333
+			}
2334
+		} else
2206 2335
 		{
2207 2336
 			$type = empty($modSettings['next_task_time']) || $modSettings['next_task_time'] < time() ? 'task' : 'mailq';
2208 2337
 			$ts = $type == 'mailq' ? $modSettings['mail_next_send'] : $modSettings['next_task_time'];
@@ -2253,8 +2382,9 @@  discard block
 block discarded – undo
2253 2382
 		foreach ($theme_includes as $include)
2254 2383
 		{
2255 2384
 			$include = strtr(trim($include), array('$boarddir' => $boarddir, '$sourcedir' => $sourcedir, '$themedir' => $settings['theme_dir']));
2256
-			if (file_exists($include))
2257
-				require_once($include);
2385
+			if (file_exists($include)) {
2386
+							require_once($include);
2387
+			}
2258 2388
 		}
2259 2389
 	}
2260 2390
 
@@ -2284,16 +2414,19 @@  discard block
 block discarded – undo
2284 2414
 	// Do any style sheets first, cause we're easy with those.
2285 2415
 	if (!empty($style_sheets))
2286 2416
 	{
2287
-		if (!is_array($style_sheets))
2288
-			$style_sheets = array($style_sheets);
2417
+		if (!is_array($style_sheets)) {
2418
+					$style_sheets = array($style_sheets);
2419
+		}
2289 2420
 
2290
-		foreach ($style_sheets as $sheet)
2291
-			loadCSSFile($sheet . '.css', array(), $sheet);
2421
+		foreach ($style_sheets as $sheet) {
2422
+					loadCSSFile($sheet . '.css', array(), $sheet);
2423
+		}
2292 2424
 	}
2293 2425
 
2294 2426
 	// No template to load?
2295
-	if ($template_name === false)
2296
-		return true;
2427
+	if ($template_name === false) {
2428
+			return true;
2429
+	}
2297 2430
 
2298 2431
 	$loaded = false;
2299 2432
 	foreach ($settings['template_dirs'] as $template_dir)
@@ -2308,12 +2441,14 @@  discard block
 block discarded – undo
2308 2441
 
2309 2442
 	if ($loaded)
2310 2443
 	{
2311
-		if ($db_show_debug === true)
2312
-			$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2444
+		if ($db_show_debug === true) {
2445
+					$context['debug']['templates'][] = $template_name . ' (' . basename($template_dir) . ')';
2446
+		}
2313 2447
 
2314 2448
 		// If they have specified an initialization function for this template, go ahead and call it now.
2315
-		if (function_exists('template_' . $template_name . '_init'))
2316
-			call_user_func('template_' . $template_name . '_init');
2449
+		if (function_exists('template_' . $template_name . '_init')) {
2450
+					call_user_func('template_' . $template_name . '_init');
2451
+		}
2317 2452
 	}
2318 2453
 	// Hmmm... doesn't exist?!  I don't suppose the directory is wrong, is it?
2319 2454
 	elseif (!file_exists($settings['default_theme_dir']) && file_exists($boarddir . '/Themes/default'))
@@ -2333,13 +2468,14 @@  discard block
 block discarded – undo
2333 2468
 		loadTemplate($template_name);
2334 2469
 	}
2335 2470
 	// Cause an error otherwise.
2336
-	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal)
2337
-		fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2338
-	elseif ($fatal)
2339
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2340
-	else
2341
-		return false;
2342
-}
2471
+	elseif ($template_name != 'Errors' && $template_name != 'index' && $fatal) {
2472
+			fatal_lang_error('theme_template_error', 'template', array((string) $template_name));
2473
+	} elseif ($fatal) {
2474
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load Themes/default/%s.template.php!', (string) $template_name), 'template'));
2475
+	} else {
2476
+			return false;
2477
+	}
2478
+	}
2343 2479
 
2344 2480
 /**
2345 2481
  * Load a sub-template.
@@ -2357,17 +2493,19 @@  discard block
 block discarded – undo
2357 2493
 {
2358 2494
 	global $context, $txt, $db_show_debug;
2359 2495
 
2360
-	if ($db_show_debug === true)
2361
-		$context['debug']['sub_templates'][] = $sub_template_name;
2496
+	if ($db_show_debug === true) {
2497
+			$context['debug']['sub_templates'][] = $sub_template_name;
2498
+	}
2362 2499
 
2363 2500
 	// Figure out what the template function is named.
2364 2501
 	$theme_function = 'template_' . $sub_template_name;
2365
-	if (function_exists($theme_function))
2366
-		$theme_function();
2367
-	elseif ($fatal === false)
2368
-		fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2369
-	elseif ($fatal !== 'ignore')
2370
-		die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2502
+	if (function_exists($theme_function)) {
2503
+			$theme_function();
2504
+	} elseif ($fatal === false) {
2505
+			fatal_lang_error('theme_template_error', 'template', array((string) $sub_template_name));
2506
+	} elseif ($fatal !== 'ignore') {
2507
+			die(log_error(sprintf(isset($txt['theme_template_error']) ? $txt['theme_template_error'] : 'Unable to load the %s sub template!', (string) $sub_template_name), 'template'));
2508
+	}
2371 2509
 
2372 2510
 	// Are we showing debugging for templates?  Just make sure not to do it before the doctype...
2373 2511
 	if (allowedTo('admin_forum') && isset($_REQUEST['debug']) && !in_array($sub_template_name, array('init', 'main_below')) && ob_get_length() > 0 && !isset($_REQUEST['xml']))
@@ -2404,8 +2542,9 @@  discard block
 block discarded – undo
2404 2542
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2405 2543
 
2406 2544
 	// If this is an external file, automatically set this to false.
2407
-	if (!empty($params['external']))
2408
-		$params['minimize'] = false;
2545
+	if (!empty($params['external'])) {
2546
+			$params['minimize'] = false;
2547
+	}
2409 2548
 
2410 2549
 	// Account for shorthand like admin.css?alp21 filenames
2411 2550
 	$has_seed = strpos($fileName, '.css?');
@@ -2422,13 +2561,10 @@  discard block
 block discarded – undo
2422 2561
 			{
2423 2562
 				$fileUrl = $settings['default_theme_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2424 2563
 				$filePath = $settings['default_theme_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2564
+			} else {
2565
+							$fileUrl = false;
2425 2566
 			}
2426
-
2427
-			else
2428
-				$fileUrl = false;
2429
-		}
2430
-
2431
-		else
2567
+		} else
2432 2568
 		{
2433 2569
 			$fileUrl = $settings[$themeRef . '_url'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
2434 2570
 			$filePath = $settings[$themeRef . '_dir'] . '/css/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2443,12 +2579,14 @@  discard block
 block discarded – undo
2443 2579
 	}
2444 2580
 
2445 2581
 	// Add it to the array for use in the template
2446
-	if (!empty($fileName))
2447
-		$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2582
+	if (!empty($fileName)) {
2583
+			$context['css_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2584
+	}
2448 2585
 
2449
-	if (!empty($context['right_to_left']) && !empty($params['rtl']))
2450
-		loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2451
-}
2586
+	if (!empty($context['right_to_left']) && !empty($params['rtl'])) {
2587
+			loadCSSFile($params['rtl'], array_diff_key($params, array('rtl' => 0)));
2588
+	}
2589
+	}
2452 2590
 
2453 2591
 /**
2454 2592
  * Add a block of inline css code to be executed later
@@ -2465,8 +2603,9 @@  discard block
 block discarded – undo
2465 2603
 	global $context;
2466 2604
 
2467 2605
 	// Gotta add something...
2468
-	if (empty($css))
2469
-		return false;
2606
+	if (empty($css)) {
2607
+			return false;
2608
+	}
2470 2609
 
2471 2610
 	$context['css_header'][] = $css;
2472 2611
 }
@@ -2501,8 +2640,9 @@  discard block
 block discarded – undo
2501 2640
 	$params['validate'] = isset($params['validate']) ? $params['validate'] : true;
2502 2641
 
2503 2642
 	// If this is an external file, automatically set this to false.
2504
-	if (!empty($params['external']))
2505
-		$params['minimize'] = false;
2643
+	if (!empty($params['external'])) {
2644
+			$params['minimize'] = false;
2645
+	}
2506 2646
 
2507 2647
 	// Account for shorthand like admin.js?alp21 filenames
2508 2648
 	$has_seed = strpos($fileName, '.js?');
@@ -2519,16 +2659,12 @@  discard block
 block discarded – undo
2519 2659
 			{
2520 2660
 				$fileUrl = $settings['default_theme_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2521 2661
 				$filePath = $settings['default_theme_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2522
-			}
2523
-
2524
-			else
2662
+			} else
2525 2663
 			{
2526 2664
 				$fileUrl = false;
2527 2665
 				$filePath = false;
2528 2666
 			}
2529
-		}
2530
-
2531
-		else
2667
+		} else
2532 2668
 		{
2533 2669
 			$fileUrl = $settings[$themeRef . '_url'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
2534 2670
 			$filePath = $settings[$themeRef . '_dir'] . '/scripts/' . $fileName . ($has_seed ? '' : $params['seed']);
@@ -2543,9 +2679,10 @@  discard block
 block discarded – undo
2543 2679
 	}
2544 2680
 
2545 2681
 	// Add it to the array for use in the template
2546
-	if (!empty($fileName))
2547
-		$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2548
-}
2682
+	if (!empty($fileName)) {
2683
+			$context['javascript_files'][$id] = array('fileUrl' => $fileUrl, 'filePath' => $filePath, 'fileName' => $fileName, 'options' => $params);
2684
+	}
2685
+	}
2549 2686
 
2550 2687
 /**
2551 2688
  * Add a Javascript variable for output later (for feeding text strings and similar to JS)
@@ -2559,9 +2696,10 @@  discard block
 block discarded – undo
2559 2696
 {
2560 2697
 	global $context;
2561 2698
 
2562
-	if (!empty($key) && (!empty($value) || $value === '0'))
2563
-		$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2564
-}
2699
+	if (!empty($key) && (!empty($value) || $value === '0')) {
2700
+			$context['javascript_vars'][$key] = !empty($escape) ? JavaScriptEscape($value) : $value;
2701
+	}
2702
+	}
2565 2703
 
2566 2704
 /**
2567 2705
  * Add a block of inline Javascript code to be executed later
@@ -2578,8 +2716,9 @@  discard block
 block discarded – undo
2578 2716
 {
2579 2717
 	global $context;
2580 2718
 
2581
-	if (empty($javascript))
2582
-		return false;
2719
+	if (empty($javascript)) {
2720
+			return false;
2721
+	}
2583 2722
 
2584 2723
 	$context['javascript_inline'][($defer === true ? 'defer' : 'standard')][] = $javascript;
2585 2724
 }
@@ -2600,15 +2739,18 @@  discard block
 block discarded – undo
2600 2739
 	static $already_loaded = array();
2601 2740
 
2602 2741
 	// Default to the user's language.
2603
-	if ($lang == '')
2604
-		$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2742
+	if ($lang == '') {
2743
+			$lang = isset($user_info['language']) ? $user_info['language'] : $language;
2744
+	}
2605 2745
 
2606 2746
 	// Do we want the English version of language file as fallback?
2607
-	if (empty($modSettings['disable_language_fallback']) && $lang != 'english')
2608
-		loadLanguage($template_name, 'english', false);
2747
+	if (empty($modSettings['disable_language_fallback']) && $lang != 'english') {
2748
+			loadLanguage($template_name, 'english', false);
2749
+	}
2609 2750
 
2610
-	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang)
2611
-		return $lang;
2751
+	if (!$force_reload && isset($already_loaded[$template_name]) && $already_loaded[$template_name] == $lang) {
2752
+			return $lang;
2753
+	}
2612 2754
 
2613 2755
 	// Make sure we have $settings - if not we're in trouble and need to find it!
2614 2756
 	if (empty($settings['default_theme_dir']))
@@ -2619,8 +2761,9 @@  discard block
 block discarded – undo
2619 2761
 
2620 2762
 	// What theme are we in?
2621 2763
 	$theme_name = basename($settings['theme_url']);
2622
-	if (empty($theme_name))
2623
-		$theme_name = 'unknown';
2764
+	if (empty($theme_name)) {
2765
+			$theme_name = 'unknown';
2766
+	}
2624 2767
 
2625 2768
 	// For each file open it up and write it out!
2626 2769
 	foreach (explode('+', $template_name) as $template)
@@ -2662,8 +2805,9 @@  discard block
 block discarded – undo
2662 2805
 				$found = true;
2663 2806
 
2664 2807
 				// setlocale is required for basename() & pathinfo() to work properly on the selected language
2665
-				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set']))
2666
-					setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2808
+				if (!empty($txt['lang_locale']) && !empty($modSettings['global_character_set'])) {
2809
+									setlocale(LC_CTYPE, $txt['lang_locale'] . '.' . $modSettings['global_character_set']);
2810
+				}
2667 2811
 
2668 2812
 				break;
2669 2813
 			}
@@ -2703,8 +2847,9 @@  discard block
 block discarded – undo
2703 2847
 	}
2704 2848
 
2705 2849
 	// Keep track of what we're up to soldier.
2706
-	if ($db_show_debug === true)
2707
-		$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2850
+	if ($db_show_debug === true) {
2851
+			$context['debug']['language_files'][] = $template_name . '.' . $lang . ' (' . $theme_name . ')';
2852
+	}
2708 2853
 
2709 2854
 	// Remember what we have loaded, and in which language.
2710 2855
 	$already_loaded[$template_name] = $lang;
@@ -2750,8 +2895,9 @@  discard block
 block discarded – undo
2750 2895
 				)
2751 2896
 			);
2752 2897
 			// In the EXTREMELY unlikely event this happens, give an error message.
2753
-			if ($smcFunc['db_num_rows']($result) == 0)
2754
-				fatal_lang_error('parent_not_found', 'critical');
2898
+			if ($smcFunc['db_num_rows']($result) == 0) {
2899
+							fatal_lang_error('parent_not_found', 'critical');
2900
+			}
2755 2901
 			while ($row = $smcFunc['db_fetch_assoc']($result))
2756 2902
 			{
2757 2903
 				if (!isset($boards[$row['id_board']]))
@@ -2768,8 +2914,8 @@  discard block
 block discarded – undo
2768 2914
 					);
2769 2915
 				}
2770 2916
 				// If a moderator exists for this board, add that moderator for all children too.
2771
-				if (!empty($row['id_moderator']))
2772
-					foreach ($boards as $id => $dummy)
2917
+				if (!empty($row['id_moderator'])) {
2918
+									foreach ($boards as $id => $dummy)
2773 2919
 					{
2774 2920
 						$boards[$id]['moderators'][$row['id_moderator']] = array(
2775 2921
 							'id' => $row['id_moderator'],
@@ -2777,11 +2923,12 @@  discard block
 block discarded – undo
2777 2923
 							'href' => $scripturl . '?action=profile;u=' . $row['id_moderator'],
2778 2924
 							'link' => '<a href="' . $scripturl . '?action=profile;u=' . $row['id_moderator'] . '">' . $row['real_name'] . '</a>'
2779 2925
 						);
2926
+				}
2780 2927
 					}
2781 2928
 
2782 2929
 				// If a moderator group exists for this board, add that moderator group for all children too
2783
-				if (!empty($row['id_moderator_group']))
2784
-					foreach ($boards as $id => $dummy)
2930
+				if (!empty($row['id_moderator_group'])) {
2931
+									foreach ($boards as $id => $dummy)
2785 2932
 					{
2786 2933
 						$boards[$id]['moderator_groups'][$row['id_moderator_group']] = array(
2787 2934
 							'id' => $row['id_moderator_group'],
@@ -2789,6 +2936,7 @@  discard block
 block discarded – undo
2789 2936
 							'href' => $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'],
2790 2937
 							'link' => '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $row['id_moderator_group'] . '">' . $row['group_name'] . '</a>'
2791 2938
 						);
2939
+				}
2792 2940
 					}
2793 2941
 			}
2794 2942
 			$smcFunc['db_free_result']($result);
@@ -2815,23 +2963,27 @@  discard block
 block discarded – undo
2815 2963
 	if (!$use_cache || ($context['languages'] = cache_get_data('known_languages', !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600)) == null)
2816 2964
 	{
2817 2965
 		// If we don't have our ucwords function defined yet, let's load the settings data.
2818
-		if (empty($smcFunc['ucwords']))
2819
-			reloadSettings();
2966
+		if (empty($smcFunc['ucwords'])) {
2967
+					reloadSettings();
2968
+		}
2820 2969
 
2821 2970
 		// If we don't have our theme information yet, let's get it.
2822
-		if (empty($settings['default_theme_dir']))
2823
-			loadTheme(0, false);
2971
+		if (empty($settings['default_theme_dir'])) {
2972
+					loadTheme(0, false);
2973
+		}
2824 2974
 
2825 2975
 		// Default language directories to try.
2826 2976
 		$language_directories = array(
2827 2977
 			$settings['default_theme_dir'] . '/languages',
2828 2978
 		);
2829
-		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir'])
2830
-			$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2979
+		if (!empty($settings['actual_theme_dir']) && $settings['actual_theme_dir'] != $settings['default_theme_dir']) {
2980
+					$language_directories[] = $settings['actual_theme_dir'] . '/languages';
2981
+		}
2831 2982
 
2832 2983
 		// We possibly have a base theme directory.
2833
-		if (!empty($settings['base_theme_dir']))
2834
-			$language_directories[] = $settings['base_theme_dir'] . '/languages';
2984
+		if (!empty($settings['base_theme_dir'])) {
2985
+					$language_directories[] = $settings['base_theme_dir'] . '/languages';
2986
+		}
2835 2987
 
2836 2988
 		// Remove any duplicates.
2837 2989
 		$language_directories = array_unique($language_directories);
@@ -2845,20 +2997,21 @@  discard block
 block discarded – undo
2845 2997
 		foreach ($language_directories as $language_dir)
2846 2998
 		{
2847 2999
 			// Can't look in here... doesn't exist!
2848
-			if (!file_exists($language_dir))
2849
-				continue;
3000
+			if (!file_exists($language_dir)) {
3001
+							continue;
3002
+			}
2850 3003
 
2851 3004
 			$dir = dir($language_dir);
2852 3005
 			while ($entry = $dir->read())
2853 3006
 			{
2854 3007
 				// Look for the index language file... For good measure skip any "index.language-utf8.php" files
2855
-				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches))
2856
-					continue;
2857
-
2858
-				if (!empty($langList) && !empty($langList[$matches[1]]))
2859
-					$langName = $langList[$matches[1]];
3008
+				if (!preg_match('~^index\.(.+[^-utf8])\.php$~', $entry, $matches)) {
3009
+									continue;
3010
+				}
2860 3011
 
2861
-				else
3012
+				if (!empty($langList) && !empty($langList[$matches[1]])) {
3013
+									$langName = $langList[$matches[1]];
3014
+				} else
2862 3015
 				{
2863 3016
 					$langName = $smcFunc['ucwords'](strtr($matches[1], array('_' => ' ')));
2864 3017
 
@@ -2899,12 +3052,14 @@  discard block
 block discarded – undo
2899 3052
 		}
2900 3053
 
2901 3054
 		// Do we need to store the lang list?
2902
-		if (empty($langList))
2903
-			updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3055
+		if (empty($langList)) {
3056
+					updateSettings(array('langList' => $smcFunc['json_encode']($catchLang)));
3057
+		}
2904 3058
 
2905 3059
 		// Let's cash in on this deal.
2906
-		if (!empty($modSettings['cache_enable']))
2907
-			cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3060
+		if (!empty($modSettings['cache_enable'])) {
3061
+					cache_put_data('known_languages', $context['languages'], !empty($modSettings['cache_enable']) && $modSettings['cache_enable'] < 1 ? 86400 : 3600);
3062
+		}
2908 3063
 	}
2909 3064
 
2910 3065
 	return $context['languages'];
@@ -2927,8 +3082,9 @@  discard block
 block discarded – undo
2927 3082
 	global $modSettings, $options, $txt;
2928 3083
 	static $censor_vulgar = null, $censor_proper;
2929 3084
 
2930
-	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '')
2931
-		return $text;
3085
+	if ((!empty($options['show_no_censored']) && !empty($modSettings['allow_no_censored']) && !$force) || empty($modSettings['censor_vulgar']) || trim($text) === '') {
3086
+			return $text;
3087
+	}
2932 3088
 
2933 3089
 	// If they haven't yet been loaded, load them.
2934 3090
 	if ($censor_vulgar == null)
@@ -2956,9 +3112,9 @@  discard block
 block discarded – undo
2956 3112
 	{
2957 3113
 		$func = !empty($modSettings['censorIgnoreCase']) ? 'str_ireplace' : 'str_replace';
2958 3114
 		$text = $func($censor_vulgar, $censor_proper, $text);
3115
+	} else {
3116
+			$text = preg_replace($censor_vulgar, $censor_proper, $text);
2959 3117
 	}
2960
-	else
2961
-		$text = preg_replace($censor_vulgar, $censor_proper, $text);
2962 3118
 
2963 3119
 	return $text;
2964 3120
 }
@@ -2984,38 +3140,42 @@  discard block
 block discarded – undo
2984 3140
 	@ini_set('track_errors', '1');
2985 3141
 
2986 3142
 	// Don't include the file more than once, if $once is true.
2987
-	if ($once && in_array($filename, $templates))
2988
-		return;
3143
+	if ($once && in_array($filename, $templates)) {
3144
+			return;
3145
+	}
2989 3146
 	// Add this file to the include list, whether $once is true or not.
2990
-	else
2991
-		$templates[] = $filename;
3147
+	else {
3148
+			$templates[] = $filename;
3149
+	}
2992 3150
 
2993 3151
 	// Are we going to use eval?
2994 3152
 	if (empty($modSettings['disableTemplateEval']))
2995 3153
 	{
2996 3154
 		$file_found = file_exists($filename) && eval('?' . '>' . rtrim(file_get_contents($filename))) !== false;
2997 3155
 		$settings['current_include_filename'] = $filename;
2998
-	}
2999
-	else
3156
+	} else
3000 3157
 	{
3001 3158
 		$file_found = file_exists($filename);
3002 3159
 
3003
-		if ($once && $file_found)
3004
-			require_once($filename);
3005
-		elseif ($file_found)
3006
-			require($filename);
3160
+		if ($once && $file_found) {
3161
+					require_once($filename);
3162
+		} elseif ($file_found) {
3163
+					require($filename);
3164
+		}
3007 3165
 	}
3008 3166
 
3009 3167
 	if ($file_found !== true)
3010 3168
 	{
3011 3169
 		ob_end_clean();
3012
-		if (!empty($modSettings['enableCompressedOutput']))
3013
-			@ob_start('ob_gzhandler');
3014
-		else
3015
-			ob_start();
3170
+		if (!empty($modSettings['enableCompressedOutput'])) {
3171
+					@ob_start('ob_gzhandler');
3172
+		} else {
3173
+					ob_start();
3174
+		}
3016 3175
 
3017
-		if (isset($_GET['debug']))
3018
-			header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3176
+		if (isset($_GET['debug'])) {
3177
+					header('Content-Type: application/xhtml+xml; charset=' . (empty($context['character_set']) ? 'ISO-8859-1' : $context['character_set']));
3178
+		}
3019 3179
 
3020 3180
 		// Don't cache error pages!!
3021 3181
 		header('Expires: Mon, 26 Jul 1997 05:00:00 GMT');
@@ -3034,12 +3194,13 @@  discard block
 block discarded – undo
3034 3194
 		echo '<!DOCTYPE html>
3035 3195
 <html', !empty($context['right_to_left']) ? ' dir="rtl"' : '', '>
3036 3196
 	<head>';
3037
-		if (isset($context['character_set']))
3038
-			echo '
3197
+		if (isset($context['character_set'])) {
3198
+					echo '
3039 3199
 		<meta charset="', $context['character_set'], '">';
3200
+		}
3040 3201
 
3041
-		if (!empty($maintenance) && !allowedTo('admin_forum'))
3042
-			echo '
3202
+		if (!empty($maintenance) && !allowedTo('admin_forum')) {
3203
+					echo '
3043 3204
 		<title>', $mtitle, '</title>
3044 3205
 	</head>
3045 3206
 	<body>
@@ -3047,8 +3208,8 @@  discard block
 block discarded – undo
3047 3208
 		', $mmessage, '
3048 3209
 	</body>
3049 3210
 </html>';
3050
-		elseif (!allowedTo('admin_forum'))
3051
-			echo '
3211
+		} elseif (!allowedTo('admin_forum')) {
3212
+					echo '
3052 3213
 		<title>', $txt['template_parse_error'], '</title>
3053 3214
 	</head>
3054 3215
 	<body>
@@ -3056,16 +3217,18 @@  discard block
 block discarded – undo
3056 3217
 		', $txt['template_parse_error_message'], '
3057 3218
 	</body>
3058 3219
 </html>';
3059
-		else
3220
+		} else
3060 3221
 		{
3061 3222
 			require_once($sourcedir . '/Subs-Package.php');
3062 3223
 
3063 3224
 			$error = fetch_web_data($boardurl . strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3064 3225
 			$error_array = error_get_last();
3065
-			if (empty($error) && ini_get('track_errors') && !empty($error_array))
3066
-				$error = $error_array['message'];
3067
-			if (empty($error))
3068
-				$error = $txt['template_parse_errmsg'];
3226
+			if (empty($error) && ini_get('track_errors') && !empty($error_array)) {
3227
+							$error = $error_array['message'];
3228
+			}
3229
+			if (empty($error)) {
3230
+							$error = $txt['template_parse_errmsg'];
3231
+			}
3069 3232
 
3070 3233
 			$error = strtr($error, array('<b>' => '<strong>', '</b>' => '</strong>'));
3071 3234
 
@@ -3076,11 +3239,12 @@  discard block
 block discarded – undo
3076 3239
 		<h3>', $txt['template_parse_error'], '</h3>
3077 3240
 		', sprintf($txt['template_parse_error_details'], strtr($filename, array($boarddir => '', strtr($boarddir, '\\', '/') => '')));
3078 3241
 
3079
-			if (!empty($error))
3080
-				echo '
3242
+			if (!empty($error)) {
3243
+							echo '
3081 3244
 		<hr>
3082 3245
 
3083 3246
 		<div style="margin: 0 20px;"><pre>', strtr(strtr($error, array('<strong>' . $boarddir => '<strong>...', '<strong>' . strtr($boarddir, '\\', '/') => '<strong>...')), '\\', '/'), '</pre></div>';
3247
+			}
3084 3248
 
3085 3249
 			// I know, I know... this is VERY COMPLICATED.  Still, it's good.
3086 3250
 			if (preg_match('~ <strong>(\d+)</strong><br( /)?' . '>$~i', $error, $match) != 0)
@@ -3090,10 +3254,11 @@  discard block
 block discarded – undo
3090 3254
 				$data2 = preg_split('~\<br( /)?\>~', $data2);
3091 3255
 
3092 3256
 				// Fix the PHP code stuff...
3093
-				if (!isBrowser('gecko'))
3094
-					$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3095
-				else
3096
-					$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3257
+				if (!isBrowser('gecko')) {
3258
+									$data2 = str_replace("\t", '<span style="white-space: pre;">' . "\t" . '</span>', $data2);
3259
+				} else {
3260
+									$data2 = str_replace('<pre style="display: inline;">' . "\t" . '</pre>', "\t", $data2);
3261
+				}
3097 3262
 
3098 3263
 				// Now we get to work around a bug in PHP where it doesn't escape <br>s!
3099 3264
 				$j = -1;
@@ -3101,8 +3266,9 @@  discard block
 block discarded – undo
3101 3266
 				{
3102 3267
 					$j++;
3103 3268
 
3104
-					if (substr_count($line, '<br>') == 0)
3105
-						continue;
3269
+					if (substr_count($line, '<br>') == 0) {
3270
+											continue;
3271
+					}
3106 3272
 
3107 3273
 					$n = substr_count($line, '<br>');
3108 3274
 					for ($i = 0; $i < $n; $i++)
@@ -3121,38 +3287,42 @@  discard block
 block discarded – undo
3121 3287
 				// Figure out what the color coding was before...
3122 3288
 				$line = max($match[1] - 9, 1);
3123 3289
 				$last_line = '';
3124
-				for ($line2 = $line - 1; $line2 > 1; $line2--)
3125
-					if (strpos($data2[$line2], '<') !== false)
3290
+				for ($line2 = $line - 1; $line2 > 1; $line2--) {
3291
+									if (strpos($data2[$line2], '<') !== false)
3126 3292
 					{
3127 3293
 						if (preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line2], $color_match) != 0)
3128 3294
 							$last_line = $color_match[1];
3295
+				}
3129 3296
 						break;
3130 3297
 					}
3131 3298
 
3132 3299
 				// Show the relevant lines...
3133 3300
 				for ($n = min($match[1] + 4, count($data2) + 1); $line <= $n; $line++)
3134 3301
 				{
3135
-					if ($line == $match[1])
3136
-						echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3302
+					if ($line == $match[1]) {
3303
+											echo '</pre><div style="background-color: #ffb0b5;"><pre style="margin: 0;">';
3304
+					}
3137 3305
 
3138 3306
 					echo '<span style="color: black;">', sprintf('%' . strlen($n) . 's', $line), ':</span> ';
3139
-					if (isset($data2[$line]) && $data2[$line] != '')
3140
-						echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3307
+					if (isset($data2[$line]) && $data2[$line] != '') {
3308
+											echo substr($data2[$line], 0, 2) == '</' ? preg_replace('~^</[^>]+>~', '', $data2[$line]) : $last_line . $data2[$line];
3309
+					}
3141 3310
 
3142 3311
 					if (isset($data2[$line]) && preg_match('~(<[^/>]+>)[^<]*$~', $data2[$line], $color_match) != 0)
3143 3312
 					{
3144 3313
 						$last_line = $color_match[1];
3145 3314
 						echo '</', substr($last_line, 1, 4), '>';
3315
+					} elseif ($last_line != '' && strpos($data2[$line], '<') !== false) {
3316
+											$last_line = '';
3317
+					} elseif ($last_line != '' && $data2[$line] != '') {
3318
+											echo '</', substr($last_line, 1, 4), '>';
3146 3319
 					}
3147
-					elseif ($last_line != '' && strpos($data2[$line], '<') !== false)
3148
-						$last_line = '';
3149
-					elseif ($last_line != '' && $data2[$line] != '')
3150
-						echo '</', substr($last_line, 1, 4), '>';
3151 3320
 
3152
-					if ($line == $match[1])
3153
-						echo '</pre></div><pre style="margin: 0;">';
3154
-					else
3155
-						echo "\n";
3321
+					if ($line == $match[1]) {
3322
+											echo '</pre></div><pre style="margin: 0;">';
3323
+					} else {
3324
+											echo "\n";
3325
+					}
3156 3326
 				}
3157 3327
 
3158 3328
 				echo '</pre></div>';
@@ -3176,8 +3346,9 @@  discard block
 block discarded – undo
3176 3346
 	global $db_type, $db_name, $ssi_db_user, $ssi_db_passwd, $sourcedir, $db_prefix, $db_port;
3177 3347
 
3178 3348
 	// Figure out what type of database we are using.
3179
-	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php'))
3180
-		$db_type = 'mysql';
3349
+	if (empty($db_type) || !file_exists($sourcedir . '/Subs-Db-' . $db_type . '.php')) {
3350
+			$db_type = 'mysql';
3351
+	}
3181 3352
 
3182 3353
 	// Load the file for the database.
3183 3354
 	require_once($sourcedir . '/Subs-Db-' . $db_type . '.php');
@@ -3185,8 +3356,9 @@  discard block
 block discarded – undo
3185 3356
 	$db_options = array();
3186 3357
 
3187 3358
 	// Add in the port if needed
3188
-	if (!empty($db_port))
3189
-		$db_options['port'] = $db_port;
3359
+	if (!empty($db_port)) {
3360
+			$db_options['port'] = $db_port;
3361
+	}
3190 3362
 
3191 3363
 	// If we are in SSI try them first, but don't worry if it doesn't work, we have the normal username and password we can use.
3192 3364
 	if (SMF == 'SSI' && !empty($ssi_db_user) && !empty($ssi_db_passwd))
@@ -3205,13 +3377,15 @@  discard block
 block discarded – undo
3205 3377
 	}
3206 3378
 
3207 3379
 	// Safe guard here, if there isn't a valid connection lets put a stop to it.
3208
-	if (!$db_connection)
3209
-		display_db_error();
3380
+	if (!$db_connection) {
3381
+			display_db_error();
3382
+	}
3210 3383
 
3211 3384
 	// If in SSI mode fix up the prefix.
3212
-	if (SMF == 'SSI')
3213
-		db_fix_prefix($db_prefix, $db_name);
3214
-}
3385
+	if (SMF == 'SSI') {
3386
+			db_fix_prefix($db_prefix, $db_name);
3387
+	}
3388
+	}
3215 3389
 
3216 3390
 /**
3217 3391
  * Try to load up a supported caching method. This is saved in $cacheAPI if we are not overriding it.
@@ -3225,10 +3399,11 @@  discard block
 block discarded – undo
3225 3399
 	global $sourcedir, $cacheAPI, $cache_accelerator;
3226 3400
 
3227 3401
 	// Not overriding this and we have a cacheAPI, send it back.
3228
-	if (empty($overrideCache) && is_object($cacheAPI))
3229
-		return $cacheAPI;
3230
-	elseif (is_null($cacheAPI))
3231
-		$cacheAPI = false;
3402
+	if (empty($overrideCache) && is_object($cacheAPI)) {
3403
+			return $cacheAPI;
3404
+	} elseif (is_null($cacheAPI)) {
3405
+			$cacheAPI = false;
3406
+	}
3232 3407
 
3233 3408
 	// Make sure our class is in session.
3234 3409
 	require_once($sourcedir . '/Class-CacheAPI.php');
@@ -3249,8 +3424,9 @@  discard block
 block discarded – undo
3249 3424
 		if (!$testAPI->isSupported())
3250 3425
 		{
3251 3426
 			// Can we save ourselves?
3252
-			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf')
3253
-				return loadCacheAccelerator(null, false);
3427
+			if (!empty($fallbackSMF) && is_null($overrideCache) && $tryAccelerator != 'smf') {
3428
+							return loadCacheAccelerator(null, false);
3429
+			}
3254 3430
 			return false;
3255 3431
 		}
3256 3432
 
@@ -3262,9 +3438,9 @@  discard block
 block discarded – undo
3262 3438
 		{
3263 3439
 			$cacheAPI = $testAPI;
3264 3440
 			return $cacheAPI;
3441
+		} else {
3442
+					return $testAPI;
3265 3443
 		}
3266
-		else
3267
-			return $testAPI;
3268 3444
 	}
3269 3445
 }
3270 3446
 
@@ -3284,8 +3460,9 @@  discard block
 block discarded – undo
3284 3460
 
3285 3461
 	// @todo Why are we doing this if caching is disabled?
3286 3462
 
3287
-	if (function_exists('call_integration_hook'))
3288
-		call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3463
+	if (function_exists('call_integration_hook')) {
3464
+			call_integration_hook('pre_cache_quick_get', array(&$key, &$file, &$function, &$params, &$level));
3465
+	}
3289 3466
 
3290 3467
 	/* Refresh the cache if either:
3291 3468
 		1. Caching is disabled.
@@ -3299,16 +3476,19 @@  discard block
 block discarded – undo
3299 3476
 		require_once($sourcedir . '/' . $file);
3300 3477
 		$cache_block = call_user_func_array($function, $params);
3301 3478
 
3302
-		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level)
3303
-			cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3479
+		if (!empty($modSettings['cache_enable']) && $modSettings['cache_enable'] >= $level) {
3480
+					cache_put_data($key, $cache_block, $cache_block['expires'] - time());
3481
+		}
3304 3482
 	}
3305 3483
 
3306 3484
 	// Some cached data may need a freshening up after retrieval.
3307
-	if (!empty($cache_block['post_retri_eval']))
3308
-		eval($cache_block['post_retri_eval']);
3485
+	if (!empty($cache_block['post_retri_eval'])) {
3486
+			eval($cache_block['post_retri_eval']);
3487
+	}
3309 3488
 
3310
-	if (function_exists('call_integration_hook'))
3311
-		call_integration_hook('post_cache_quick_get', array(&$cache_block));
3489
+	if (function_exists('call_integration_hook')) {
3490
+			call_integration_hook('post_cache_quick_get', array(&$cache_block));
3491
+	}
3312 3492
 
3313 3493
 	return $cache_block['data'];
3314 3494
 }
@@ -3335,8 +3515,9 @@  discard block
 block discarded – undo
3335 3515
 	global $smcFunc, $cache_enable, $cacheAPI;
3336 3516
 	global $cache_hits, $cache_count, $db_show_debug;
3337 3517
 
3338
-	if (empty($cache_enable) || empty($cacheAPI))
3339
-		return;
3518
+	if (empty($cache_enable) || empty($cacheAPI)) {
3519
+			return;
3520
+	}
3340 3521
 
3341 3522
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3342 3523
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3349,12 +3530,14 @@  discard block
 block discarded – undo
3349 3530
 	$value = $value === null ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_encode']($value) : json_encode($value));
3350 3531
 	$cacheAPI->putData($key, $value, $ttl);
3351 3532
 
3352
-	if (function_exists('call_integration_hook'))
3353
-		call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3533
+	if (function_exists('call_integration_hook')) {
3534
+			call_integration_hook('cache_put_data', array(&$key, &$value, &$ttl));
3535
+	}
3354 3536
 
3355
-	if (isset($db_show_debug) && $db_show_debug === true)
3356
-		$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3357
-}
3537
+	if (isset($db_show_debug) && $db_show_debug === true) {
3538
+			$cache_hits[$cache_count]['t'] = array_sum(explode(' ', microtime())) - array_sum(explode(' ', $st));
3539
+	}
3540
+	}
3358 3541
 
3359 3542
 /**
3360 3543
  * Gets the value from the cache specified by key, so long as it is not older than ttl seconds.
@@ -3370,8 +3553,9 @@  discard block
 block discarded – undo
3370 3553
 	global $smcFunc, $cache_enable, $cacheAPI;
3371 3554
 	global $cache_hits, $cache_count, $cache_misses, $cache_count_misses, $db_show_debug;
3372 3555
 
3373
-	if (empty($cache_enable) || empty($cacheAPI))
3374
-		return;
3556
+	if (empty($cache_enable) || empty($cacheAPI)) {
3557
+			return;
3558
+	}
3375 3559
 
3376 3560
 	$cache_count = isset($cache_count) ? $cache_count + 1 : 1;
3377 3561
 	if (isset($db_show_debug) && $db_show_debug === true)
@@ -3391,16 +3575,18 @@  discard block
 block discarded – undo
3391 3575
 
3392 3576
 		if (empty($value))
3393 3577
 		{
3394
-			if (!is_array($cache_misses))
3395
-				$cache_misses = array();
3578
+			if (!is_array($cache_misses)) {
3579
+							$cache_misses = array();
3580
+			}
3396 3581
 
3397 3582
 			$cache_count_misses = isset($cache_count_misses) ? $cache_count_misses + 1 : 1;
3398 3583
 			$cache_misses[$cache_count_misses] = array('k' => $original_key, 'd' => 'get');
3399 3584
 		}
3400 3585
 	}
3401 3586
 
3402
-	if (function_exists('call_integration_hook') && isset($value))
3403
-		call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3587
+	if (function_exists('call_integration_hook') && isset($value)) {
3588
+			call_integration_hook('cache_get_data', array(&$key, &$ttl, &$value));
3589
+	}
3404 3590
 
3405 3591
 	return empty($value) ? null : (isset($smcFunc['json_encode']) ? $smcFunc['json_decode']($value, true) : smf_json_decode($value, true));
3406 3592
 }
@@ -3422,8 +3608,9 @@  discard block
 block discarded – undo
3422 3608
 	global $cacheAPI;
3423 3609
 
3424 3610
 	// If we can't get to the API, can't do this.
3425
-	if (empty($cacheAPI))
3426
-		return;
3611
+	if (empty($cacheAPI)) {
3612
+			return;
3613
+	}
3427 3614
 
3428 3615
 	// Ask the API to do the heavy lifting. cleanCache also calls invalidateCache to be sure.
3429 3616
 	$cacheAPI->cleanCache($type);
@@ -3448,8 +3635,9 @@  discard block
 block discarded – undo
3448 3635
 	global $modSettings, $boardurl, $smcFunc, $image_proxy_enabled, $image_proxy_secret;
3449 3636
 
3450 3637
 	// Come on!
3451
-	if (empty($data))
3452
-		return array();
3638
+	if (empty($data)) {
3639
+			return array();
3640
+	}
3453 3641
 
3454 3642
 	// Set a nice default var.
3455 3643
 	$image = '';
@@ -3457,11 +3645,11 @@  discard block
 block discarded – undo
3457 3645
 	// Gravatar has been set as mandatory!
3458 3646
 	if (!empty($modSettings['gravatarOverride']))
3459 3647
 	{
3460
-		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://'))
3461
-			$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3462
-
3463
-		else if (!empty($data['email']))
3464
-			$image = get_gravatar_url($data['email']);
3648
+		if (!empty($modSettings['gravatarAllowExtraEmail']) && !empty($data['avatar']) && stristr($data['avatar'], 'gravatar://')) {
3649
+					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3650
+		} else if (!empty($data['email'])) {
3651
+					$image = get_gravatar_url($data['email']);
3652
+		}
3465 3653
 	}
3466 3654
 
3467 3655
 	// Look if the user has a gravatar field or has set an external url as avatar.
@@ -3473,54 +3661,60 @@  discard block
 block discarded – undo
3473 3661
 			// Gravatar.
3474 3662
 			if (stristr($data['avatar'], 'gravatar://'))
3475 3663
 			{
3476
-				if ($data['avatar'] == 'gravatar://')
3477
-					$image = get_gravatar_url($data['email']);
3478
-
3479
-				elseif (!empty($modSettings['gravatarAllowExtraEmail']))
3480
-					$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3664
+				if ($data['avatar'] == 'gravatar://') {
3665
+									$image = get_gravatar_url($data['email']);
3666
+				} elseif (!empty($modSettings['gravatarAllowExtraEmail'])) {
3667
+									$image = get_gravatar_url($smcFunc['substr']($data['avatar'], 11));
3668
+				}
3481 3669
 			}
3482 3670
 
3483 3671
 			// External url.
3484 3672
 			else
3485 3673
 			{
3486 3674
 				// Using ssl?
3487
-				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false)
3488
-					$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3675
+				if (!empty($modSettings['force_ssl']) && $image_proxy_enabled && stripos($data['avatar'], 'http://') !== false) {
3676
+									$image = strtr($boardurl, array('http://' => 'https://')) . '/proxy.php?request=' . urlencode($data['avatar']) . '&hash=' . md5($data['avatar'] . $image_proxy_secret);
3677
+				}
3489 3678
 
3490 3679
 				// Just a plain external url.
3491
-				else
3492
-					$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3680
+				else {
3681
+									$image = (stristr($data['avatar'], 'http://') || stristr($data['avatar'], 'https://')) ? $data['avatar'] : $modSettings['avatar_url'] . '/' . $data['avatar'];
3682
+				}
3493 3683
 			}
3494 3684
 		}
3495 3685
 
3496 3686
 		// Perhaps this user has an attachment as avatar...
3497
-		else if (!empty($data['filename']))
3498
-			$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3687
+		else if (!empty($data['filename'])) {
3688
+					$image = $modSettings['custom_avatar_url'] . '/' . $data['filename'];
3689
+		}
3499 3690
 
3500 3691
 		// Right... no avatar... use our default image.
3501
-		else
3502
-			$image = $modSettings['avatar_url'] . '/default.png';
3692
+		else {
3693
+					$image = $modSettings['avatar_url'] . '/default.png';
3694
+		}
3503 3695
 	}
3504 3696
 
3505 3697
 	call_integration_hook('integrate_set_avatar_data', array(&$image, &$data));
3506 3698
 
3507 3699
 	// At this point in time $image has to be filled unless you chose to force gravatar and the user doesn't have the needed data to retrieve it... thus a check for !empty() is still needed.
3508
-	if (!empty($image))
3509
-		return array(
3700
+	if (!empty($image)) {
3701
+			return array(
3510 3702
 			'name' => !empty($data['avatar']) ? $data['avatar'] : '',
3511 3703
 			'image' => '<img class="avatar" src="' . $image . '" />',
3512 3704
 			'href' => $image,
3513 3705
 			'url' => $image,
3514 3706
 		);
3707
+	}
3515 3708
 
3516 3709
 	// Fallback to make life easier for everyone...
3517
-	else
3518
-		return array(
3710
+	else {
3711
+			return array(
3519 3712
 			'name' => '',
3520 3713
 			'image' => '',
3521 3714
 			'href' => '',
3522 3715
 			'url' => '',
3523 3716
 		);
3524
-}
3717
+	}
3718
+	}
3525 3719
 
3526 3720
 ?>
3527 3721
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/DbExtra-postgresql.php 1 patch
Braces   +37 added lines, -27 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Add the functions implemented in this file to the $smcFunc array.
@@ -23,8 +24,8 @@  discard block
 block discarded – undo
23 24
 {
24 25
 	global $smcFunc;
25 26
 
26
-	if (!isset($smcFunc['db_backup_table']) || $smcFunc['db_backup_table'] != 'smf_db_backup_table')
27
-		$smcFunc += array(
27
+	if (!isset($smcFunc['db_backup_table']) || $smcFunc['db_backup_table'] != 'smf_db_backup_table') {
28
+			$smcFunc += array(
28 29
 			'db_backup_table' => 'smf_db_backup_table',
29 30
 			'db_optimize_table' => 'smf_db_optimize_table',
30 31
 			'db_table_sql' => 'smf_db_table_sql',
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
32 33
 			'db_get_version' => 'smf_db_get_version',
33 34
 			'db_get_engine' => 'smf_db_get_engine',
34 35
 		);
35
-}
36
+	}
37
+	}
36 38
 
37 39
 /**
38 40
  * Backup $table to $backup_table.
@@ -48,13 +50,14 @@  discard block
 block discarded – undo
48 50
 
49 51
 	// Do we need to drop it first?
50 52
 	$tables = smf_db_list_tables(false, $backup_table);
51
-	if (!empty($tables))
52
-		$smcFunc['db_query']('', '
53
+	if (!empty($tables)) {
54
+			$smcFunc['db_query']('', '
53 55
 			DROP TABLE {raw:backup_table}',
54 56
 			array(
55 57
 				'backup_table' => $backup_table,
56 58
 			)
57 59
 		);
60
+	}
58 61
 
59 62
 	/**
60 63
 	 * @todo Should we create backups of sequences as well?
@@ -117,8 +120,9 @@  discard block
 block discarded – undo
117 120
 			)
118 121
 		);
119 122
 
120
-	if (!$request)
121
-		return -1;
123
+	if (!$request) {
124
+			return -1;
125
+	}
122 126
 
123 127
 	$request = $smcFunc['db_query']('', '
124 128
 		SELECT pg_relation_size(C.oid) AS "size"
@@ -136,11 +140,12 @@  discard block
 block discarded – undo
136 140
 	$row = $smcFunc['db_fetch_assoc']($request);
137 141
 	$smcFunc['db_free_result']($request);
138 142
 
139
-	if (isset($row['size']))
140
-			return ($old_size - $row['size']) / 1024;
141
-	else
142
-		return 0;
143
-}
143
+	if (isset($row['size'])) {
144
+				return ($old_size - $row['size']) / 1024;
145
+	} else {
146
+			return 0;
147
+	}
148
+	}
144 149
 
145 150
 /**
146 151
  * This function lists all tables in the database.
@@ -167,8 +172,9 @@  discard block
 block discarded – undo
167 172
 	);
168 173
 
169 174
 	$tables = array();
170
-	while ($row = $smcFunc['db_fetch_row']($request))
171
-		$tables[] = $row[0];
175
+	while ($row = $smcFunc['db_fetch_row']($request)) {
176
+			$tables[] = $row[0];
177
+	}
172 178
 	$smcFunc['db_free_result']($request);
173 179
 
174 180
 	return $tables;
@@ -209,12 +215,14 @@  discard block
 block discarded – undo
209 215
 	);
210 216
 	while ($row = $smcFunc['db_fetch_assoc']($result))
211 217
 	{
212
-		if ($row['data_type'] == 'character varying')
213
-			$row['data_type'] = 'varchar';
214
-		elseif ($row['data_type'] == 'character')
215
-			$row['data_type'] = 'char';
216
-		if ($row['character_maximum_length'])
217
-			$row['data_type'] .= '(' . $row['character_maximum_length'] . ')';
218
+		if ($row['data_type'] == 'character varying') {
219
+					$row['data_type'] = 'varchar';
220
+		} elseif ($row['data_type'] == 'character') {
221
+					$row['data_type'] = 'char';
222
+		}
223
+		if ($row['character_maximum_length']) {
224
+					$row['data_type'] .= '(' . $row['character_maximum_length'] . ')';
225
+		}
218 226
 
219 227
 		// Make the CREATE for this column.
220 228
 		$schema_create .= ' "' . $row['column_name'] . '" ' . $row['data_type'] . ($row['is_nullable'] != 'YES' ? ' NOT NULL' : '');
@@ -265,13 +273,14 @@  discard block
 block discarded – undo
265 273
 	{
266 274
 		if ($row['is_primary'])
267 275
 		{
268
-			if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0)
269
-				continue;
276
+			if (preg_match('~\(([^\)]+?)\)~i', $row['inddef'], $matches) == 0) {
277
+							continue;
278
+			}
270 279
 
271 280
 			$index_create .= $crlf . 'ALTER TABLE ' . $tableName . ' ADD PRIMARY KEY ("' . $matches[1] . '");';
281
+		} else {
282
+					$index_create .= $crlf . $row['inddef'] . ';';
272 283
 		}
273
-		else
274
-			$index_create .= $crlf . $row['inddef'] . ';';
275 284
 	}
276 285
 	$smcFunc['db_free_result']($result);
277 286
 
@@ -290,8 +299,9 @@  discard block
 block discarded – undo
290 299
 	global $db_connection;
291 300
 	static $ver;
292 301
 
293
-	if(!empty($ver))
294
-		return $ver;
302
+	if(!empty($ver)) {
303
+			return $ver;
304
+	}
295 305
 
296 306
 	$ver = pg_version($db_connection)['server'];
297 307
 
Please login to merge, or discard this patch.
Sources/ManageMail.php 1 patch
Braces   +26 added lines, -18 removed lines patch added patch discarded remove patch
@@ -15,8 +15,9 @@  discard block
 block discarded – undo
15 15
  * @version 2.1 Beta 4
16 16
  */
17 17
 
18
-if (!defined('SMF'))
18
+if (!defined('SMF')) {
19 19
 	die('No direct access...');
20
+}
20 21
 
21 22
 /**
22 23
  * Main dispatcher. This function checks permissions and passes control through to the relevant section.
@@ -245,8 +246,9 @@  discard block
 block discarded – undo
245 246
 	while ($row = $smcFunc['db_fetch_assoc']($request))
246 247
 	{
247 248
 		// Private PM/email subjects and similar shouldn't be shown in the mailbox area.
248
-		if (!empty($row['private']))
249
-			$row['subject'] = $txt['personal_message'];
249
+		if (!empty($row['private'])) {
250
+					$row['subject'] = $txt['personal_message'];
251
+		}
250 252
 
251 253
 		$mails[] = $row;
252 254
 	}
@@ -300,8 +302,9 @@  discard block
 block discarded – undo
300 302
 		$element = substr($key, strrpos($key, '_') + 1);
301 303
 		$processedBirthdayEmails[$index][$element] = $value;
302 304
 	}
303
-	foreach ($processedBirthdayEmails as $index => $dummy)
304
-		$emails[$index] = $index;
305
+	foreach ($processedBirthdayEmails as $index => $dummy) {
306
+			$emails[$index] = $index;
307
+	}
305 308
 
306 309
 	$config_vars = array(
307 310
 			// Mail queue stuff, this rocks ;)
@@ -322,8 +325,9 @@  discard block
 block discarded – undo
322 325
 
323 326
 	call_integration_hook('integrate_modify_mail_settings', array(&$config_vars));
324 327
 
325
-	if ($return_config)
326
-		return $config_vars;
328
+	if ($return_config) {
329
+			return $config_vars;
330
+	}
327 331
 
328 332
 	// Saving?
329 333
 	if (isset($_GET['save']))
@@ -398,9 +402,9 @@  discard block
 block discarded – undo
398 402
 		);
399 403
 		list ($_GET['te']) = $smcFunc['db_fetch_row']($request);
400 404
 		$smcFunc['db_free_result']($request);
405
+	} else {
406
+			$_GET['te'] = (int) $_GET['te'];
401 407
 	}
402
-	else
403
-		$_GET['te'] = (int) $_GET['te'];
404 408
 
405 409
 	$_GET['sent'] = isset($_GET['sent']) ? (int) $_GET['sent'] : 0;
406 410
 
@@ -424,12 +428,14 @@  discard block
 block discarded – undo
424 428
 
425 429
 	// Try get more time...
426 430
 	@set_time_limit(600);
427
-	if (function_exists('apache_reset_timeout'))
428
-		@apache_reset_timeout();
431
+	if (function_exists('apache_reset_timeout')) {
432
+			@apache_reset_timeout();
433
+	}
429 434
 
430 435
 	// Have we already used our maximum time?
431
-	if ((time() - $time_start) < 5)
432
-		return;
436
+	if ((time() - $time_start) < 5) {
437
+			return;
438
+	}
433 439
 
434 440
 	$context['continue_get_data'] = '?action=admin;area=mailqueue;sa=clear;te=' . $_GET['te'] . ';sent=' . $_GET['sent'] . ';' . $context['session_var'] . '=' . $context['session_id'];
435 441
 	$context['page_title'] = $txt['not_done_title'];
@@ -459,8 +465,9 @@  discard block
 block discarded – undo
459 465
 {
460 466
 	global $txt;
461 467
 
462
-	if ($time_diff < 0)
463
-		$time_diff = 0;
468
+	if ($time_diff < 0) {
469
+			$time_diff = 0;
470
+	}
464 471
 
465 472
 	// Just do a bit of an if fest...
466 473
 	if ($time_diff > 86400)
@@ -481,8 +488,9 @@  discard block
 block discarded – undo
481 488
 		return sprintf($minutes == 1 ? $txt['mq_minute'] : $txt['mq_minutes'], $minutes);
482 489
 	}
483 490
 	// Otherwise must be second
484
-	else
485
-		return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff);
486
-}
491
+	else {
492
+			return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff);
493
+	}
494
+	}
487 495
 
488 496
 ?>
489 497
\ No newline at end of file
Please login to merge, or discard this patch.
Sources/MessageIndex.php 1 patch
Braces   +264 added lines, -197 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * Show the list of topics in this board, along with any child boards.
@@ -56,8 +57,9 @@  discard block
 block discarded – undo
56 57
 
57 58
 	$context['name'] = $board_info['name'];
58 59
 	$context['description'] = $board_info['description'];
59
-	if (!empty($board_info['description']))
60
-		$context['meta_description'] = strip_tags($board_info['description']);
60
+	if (!empty($board_info['description'])) {
61
+			$context['meta_description'] = strip_tags($board_info['description']);
62
+	}
61 63
 
62 64
 	// How many topics do we have in total?
63 65
 	$board_info['total_topics'] = allowedTo('approve_posts') ? $board_info['num_topics'] + $board_info['unapproved_topics'] : $board_info['num_topics'] + $board_info['unapproved_user_topics'];
@@ -73,12 +75,14 @@  discard block
 block discarded – undo
73 75
 		$session_name = session_name();
74 76
 		foreach ($_GET as $k => $v)
75 77
 		{
76
-			if (!in_array($k, array('board', 'start', $session_name)))
77
-				$context['robot_no_index'] = true;
78
+			if (!in_array($k, array('board', 'start', $session_name))) {
79
+							$context['robot_no_index'] = true;
80
+			}
78 81
 		}
79 82
 	}
80
-	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0))
81
-		$context['robot_no_index'] = true;
83
+	if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) {
84
+			$context['robot_no_index'] = true;
85
+	}
82 86
 
83 87
 	// If we can view unapproved messages and there are some build up a list.
84 88
 	if (allowedTo('approve_posts') && ($board_info['unapproved_topics'] || $board_info['unapproved_posts']))
@@ -89,14 +93,16 @@  discard block
 block discarded – undo
89 93
 	}
90 94
 
91 95
 	// We only know these.
92
-	if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post')))
93
-		$_REQUEST['sort'] = 'last_post';
96
+	if (isset($_REQUEST['sort']) && !in_array($_REQUEST['sort'], array('subject', 'starter', 'last_poster', 'replies', 'views', 'first_post', 'last_post'))) {
97
+			$_REQUEST['sort'] = 'last_post';
98
+	}
94 99
 
95 100
 	// Make sure the starting place makes sense and construct the page index.
96
-	if (isset($_REQUEST['sort']))
97
-		$context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true);
98
-	else
99
-		$context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true);
101
+	if (isset($_REQUEST['sort'])) {
102
+			$context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d;sort=' . $_REQUEST['sort'] . (isset($_REQUEST['desc']) ? ';desc' : ''), $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true);
103
+	} else {
104
+			$context['page_index'] = constructPageIndex($scripturl . '?board=' . $board . '.%1$d', $_REQUEST['start'], $board_info['total_topics'], $context['maxindex'], true);
105
+	}
100 106
 	$context['start'] = &$_REQUEST['start'];
101 107
 
102 108
 	// Set a canonical URL for this page.
@@ -132,14 +138,16 @@  discard block
 block discarded – undo
132 138
 	$context['link_moderators'] = array();
133 139
 	if (!empty($board_info['moderators']))
134 140
 	{
135
-		foreach ($board_info['moderators'] as $mod)
136
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
141
+		foreach ($board_info['moderators'] as $mod) {
142
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>';
143
+		}
137 144
 	}
138 145
 	if (!empty($board_info['moderator_groups']))
139 146
 	{
140 147
 		// By default just tack the moderator groups onto the end of the members
141
-		foreach ($board_info['moderator_groups'] as $mod_group)
142
-			$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
148
+		foreach ($board_info['moderator_groups'] as $mod_group) {
149
+					$context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=members;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>';
150
+		}
143 151
 	}
144 152
 
145 153
 	// Now we tack the info onto the end of the linktree
@@ -191,20 +199,24 @@  discard block
 block discarded – undo
191 199
 		);
192 200
 		while ($row = $smcFunc['db_fetch_assoc']($request))
193 201
 		{
194
-			if (empty($row['id_member']))
195
-				continue;
202
+			if (empty($row['id_member'])) {
203
+							continue;
204
+			}
196 205
 
197
-			if (!empty($row['online_color']))
198
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
199
-			else
200
-				$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
206
+			if (!empty($row['online_color'])) {
207
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>';
208
+			} else {
209
+							$link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>';
210
+			}
201 211
 
202 212
 			$is_buddy = in_array($row['id_member'], $user_info['buddies']);
203
-			if ($is_buddy)
204
-				$link = '<strong>' . $link . '</strong>';
213
+			if ($is_buddy) {
214
+							$link = '<strong>' . $link . '</strong>';
215
+			}
205 216
 
206
-			if (!empty($row['show_online']) || allowedTo('moderate_forum'))
207
-				$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
217
+			if (!empty($row['show_online']) || allowedTo('moderate_forum')) {
218
+							$context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link;
219
+			}
208 220
 			// @todo why are we filling this array of data that are just counted (twice) and discarded? ???
209 221
 			$context['view_members'][$row['log_time'] . $row['member_name']] = array(
210 222
 				'id' => $row['id_member'],
@@ -217,8 +229,9 @@  discard block
 block discarded – undo
217 229
 				'hidden' => empty($row['show_online']),
218 230
 			);
219 231
 
220
-			if (empty($row['show_online']))
221
-				$context['view_num_hidden']++;
232
+			if (empty($row['show_online'])) {
233
+							$context['view_num_hidden']++;
234
+			}
222 235
 		}
223 236
 		$context['view_num_guests'] = $smcFunc['db_num_rows']($request) - count($context['view_members']);
224 237
 		$smcFunc['db_free_result']($request);
@@ -260,8 +273,9 @@  discard block
 block discarded – undo
260 273
 	// Bring in any changes we want to make before the query.
261 274
 	call_integration_hook('integrate_pre_messageindex', array(&$sort_methods));
262 275
 
263
-	foreach ($sort_methods as $key => $val)
264
-		$context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>';
276
+	foreach ($sort_methods as $key => $val) {
277
+			$context['topics_headers'][$key] = '<a href="' . $scripturl . '?board=' . $context['current_board'] . '.' . $context['start'] . ';sort=' . $key . ($context['sort_by'] == $key && $context['sort_direction'] == 'up' ? ';desc' : '') . '">' . $txt[$key] . ($context['sort_by'] == $key ? '<span class="sort sort_' . $context['sort_direction'] . '"></span>' : '') . '</a>';
278
+	}
265 279
 
266 280
 	// Calculate the fastest way to get the topics.
267 281
 	$start = (int) $_REQUEST['start'];
@@ -271,14 +285,15 @@  discard block
 block discarded – undo
271 285
 		$fake_ascending = true;
272 286
 		$context['maxindex'] = $board_info['total_topics'] < $start + $context['maxindex'] + 1 ? $board_info['total_topics'] - $start : $context['maxindex'];
273 287
 		$start = $board_info['total_topics'] < $start + $context['maxindex'] + 1 ? 0 : $board_info['total_topics'] - $start - $context['maxindex'];
288
+	} else {
289
+			$fake_ascending = false;
274 290
 	}
275
-	else
276
-		$fake_ascending = false;
277 291
 
278 292
 	// Setup the default topic icons...
279 293
 	$context['icon_sources'] = array();
280
-	foreach ($context['stable_icons'] as $icon)
281
-		$context['icon_sources'][$icon] = 'images_url';
294
+	foreach ($context['stable_icons'] as $icon) {
295
+			$context['icon_sources'][$icon] = 'images_url';
296
+	}
282 297
 
283 298
 	$topic_ids = array();
284 299
 	$context['topics'] = array();
@@ -316,8 +331,9 @@  discard block
 block discarded – undo
316 331
 			$message_pre_index_parameters
317 332
 		);
318 333
 		$topic_ids = array();
319
-		while ($row = $smcFunc['db_fetch_assoc']($request))
320
-			$topic_ids[] = $row['id_topic'];
334
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
335
+					$topic_ids[] = $row['id_topic'];
336
+		}
321 337
 	}
322 338
 
323 339
 	// Grab the appropriate topic information...
@@ -375,11 +391,13 @@  discard block
 block discarded – undo
375 391
 		// Begin 'printing' the message index for current board.
376 392
 		while ($row = $smcFunc['db_fetch_assoc']($result))
377 393
 		{
378
-			if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0')
379
-				continue;
394
+			if ($row['id_poll'] > 0 && $modSettings['pollMode'] == '0') {
395
+							continue;
396
+			}
380 397
 
381
-			if (!$pre_query)
382
-				$topic_ids[] = $row['id_topic'];
398
+			if (!$pre_query) {
399
+							$topic_ids[] = $row['id_topic'];
400
+			}
383 401
 
384 402
 			// Reference the main color class.
385 403
 			$colorClass = 'windowbg';
@@ -389,8 +407,9 @@  discard block
 block discarded – undo
389 407
 			{
390 408
 				// Limit them to $modSettings['preview_characters'] characters
391 409
 				$row['first_body'] = strip_tags(strtr(parse_bbc($row['first_body'], $row['first_smileys'], $row['id_first_msg']), array('<br>' => '&#10;')));
392
-				if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters'])
393
-					$row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...';
410
+				if ($smcFunc['strlen']($row['first_body']) > $modSettings['preview_characters']) {
411
+									$row['first_body'] = $smcFunc['substr']($row['first_body'], 0, $modSettings['preview_characters']) . '...';
412
+				}
394 413
 
395 414
 				// Censor the subject and message preview.
396 415
 				censorText($row['first_subject']);
@@ -401,27 +420,27 @@  discard block
 block discarded – undo
401 420
 				{
402 421
 					$row['last_subject'] = $row['first_subject'];
403 422
 					$row['last_body'] = $row['first_body'];
404
-				}
405
-				else
423
+				} else
406 424
 				{
407 425
 					$row['last_body'] = strip_tags(strtr(parse_bbc($row['last_body'], $row['last_smileys'], $row['id_last_msg']), array('<br>' => '&#10;')));
408
-					if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters'])
409
-						$row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...';
426
+					if ($smcFunc['strlen']($row['last_body']) > $modSettings['preview_characters']) {
427
+											$row['last_body'] = $smcFunc['substr']($row['last_body'], 0, $modSettings['preview_characters']) . '...';
428
+					}
410 429
 
411 430
 					censorText($row['last_subject']);
412 431
 					censorText($row['last_body']);
413 432
 				}
414
-			}
415
-			else
433
+			} else
416 434
 			{
417 435
 				$row['first_body'] = '';
418 436
 				$row['last_body'] = '';
419 437
 				censorText($row['first_subject']);
420 438
 
421
-				if ($row['id_first_msg'] == $row['id_last_msg'])
422
-					$row['last_subject'] = $row['first_subject'];
423
-				else
424
-					censorText($row['last_subject']);
439
+				if ($row['id_first_msg'] == $row['id_last_msg']) {
440
+									$row['last_subject'] = $row['first_subject'];
441
+				} else {
442
+									censorText($row['last_subject']);
443
+				}
425 444
 			}
426 445
 
427 446
 			// Decide how many pages the topic should have.
@@ -432,42 +451,50 @@  discard block
 block discarded – undo
432 451
 				$pages = constructPageIndex($scripturl . '?topic=' . $row['id_topic'] . '.%1$d', $start, $row['num_replies'] + 1, $context['messages_per_page'], true, false);
433 452
 
434 453
 				// If we can use all, show all.
435
-				if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages'])
436
-					$pages .= ' &nbsp;<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>';
454
+				if (!empty($modSettings['enableAllMessages']) && $row['num_replies'] + 1 < $modSettings['enableAllMessages']) {
455
+									$pages .= ' &nbsp;<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.0;all">' . $txt['all'] . '</a>';
456
+				}
457
+			} else {
458
+							$pages = '';
437 459
 			}
438
-			else
439
-				$pages = '';
440 460
 
441 461
 			// We need to check the topic icons exist...
442 462
 			if (!empty($modSettings['messageIconChecks_enable']))
443 463
 			{
444
-				if (!isset($context['icon_sources'][$row['first_icon']]))
445
-					$context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url';
446
-				if (!isset($context['icon_sources'][$row['last_icon']]))
447
-					$context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url';
448
-			}
449
-			else
464
+				if (!isset($context['icon_sources'][$row['first_icon']])) {
465
+									$context['icon_sources'][$row['first_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['first_icon'] . '.png') ? 'images_url' : 'default_images_url';
466
+				}
467
+				if (!isset($context['icon_sources'][$row['last_icon']])) {
468
+									$context['icon_sources'][$row['last_icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $row['last_icon'] . '.png') ? 'images_url' : 'default_images_url';
469
+				}
470
+			} else
450 471
 			{
451
-				if (!isset($context['icon_sources'][$row['first_icon']]))
452
-					$context['icon_sources'][$row['first_icon']] = 'images_url';
453
-				if (!isset($context['icon_sources'][$row['last_icon']]))
454
-					$context['icon_sources'][$row['last_icon']] = 'images_url';
472
+				if (!isset($context['icon_sources'][$row['first_icon']])) {
473
+									$context['icon_sources'][$row['first_icon']] = 'images_url';
474
+				}
475
+				if (!isset($context['icon_sources'][$row['last_icon']])) {
476
+									$context['icon_sources'][$row['last_icon']] = 'images_url';
477
+				}
455 478
 			}
456 479
 
457
-			if (!empty($board_info['recycle']))
458
-				$row['first_icon'] = 'recycled';
480
+			if (!empty($board_info['recycle'])) {
481
+							$row['first_icon'] = 'recycled';
482
+			}
459 483
 
460 484
 			// Is this topic pending approval, or does it have any posts pending approval?
461
-			if ($context['can_approve_posts'] && $row['unapproved_posts'])
462
-				$colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost');
485
+			if ($context['can_approve_posts'] && $row['unapproved_posts']) {
486
+							$colorClass .= (!$row['approved'] ? ' approvetopic' : ' approvepost');
487
+			}
463 488
 
464 489
 			// Sticky topics should get a different color, too.
465
-			if ($row['is_sticky'])
466
-				$colorClass .= ' sticky';
490
+			if ($row['is_sticky']) {
491
+							$colorClass .= ' sticky';
492
+			}
467 493
 
468 494
 			// Locked topics get special treatment as well.
469
-			if ($row['locked'])
470
-				$colorClass .= ' locked';
495
+			if ($row['locked']) {
496
+							$colorClass .= ' locked';
497
+			}
471 498
 
472 499
 			// 'Print' the topic info.
473 500
 			$context['topics'][$row['id_topic']] = array_merge($row, array(
@@ -548,8 +575,9 @@  discard block
 block discarded – undo
548 575
 		$smcFunc['db_free_result']($result);
549 576
 
550 577
 		// Fix the sequence of topics if they were retrieved in the wrong order. (for speed reasons...)
551
-		if ($fake_ascending)
552
-			$context['topics'] = array_reverse($context['topics'], true);
578
+		if ($fake_ascending) {
579
+					$context['topics'] = array_reverse($context['topics'], true);
580
+		}
553 581
 
554 582
 		if (!empty($modSettings['enableParticipation']) && !$user_info['is_guest'] && !empty($topic_ids))
555 583
 		{
@@ -566,8 +594,9 @@  discard block
 block discarded – undo
566 594
 					'limit' => count($topic_ids),
567 595
 				)
568 596
 			);
569
-			while ($row = $smcFunc['db_fetch_assoc']($result))
570
-				$context['topics'][$row['id_topic']]['is_posted_in'] = true;
597
+			while ($row = $smcFunc['db_fetch_assoc']($result)) {
598
+							$context['topics'][$row['id_topic']]['is_posted_in'] = true;
599
+			}
571 600
 			$smcFunc['db_free_result']($result);
572 601
 		}
573 602
 	}
@@ -592,9 +621,9 @@  discard block
 block discarded – undo
592 621
 		// Can we restore topics?
593 622
 		$context['can_restore'] = allowedTo('move_any') && !empty($board_info['recycle']);
594 623
 
595
-		if ($user_info['is_admin'] || $modSettings['topic_move_any'])
596
-			$context['can_move_any'] = true;
597
-		else
624
+		if ($user_info['is_admin'] || $modSettings['topic_move_any']) {
625
+					$context['can_move_any'] = true;
626
+		} else
598 627
 		{
599 628
 			// We'll use this in a minute
600 629
 			$boards_allowed = boardsAllowedTo('post_new');
@@ -621,11 +650,13 @@  discard block
 block discarded – undo
621 650
 		}
622 651
 
623 652
 		// Can we use quick moderation checkboxes?
624
-		if ($options['display_quick_mod'] == 1)
625
-			$context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore'];
653
+		if ($options['display_quick_mod'] == 1) {
654
+					$context['can_quick_mod'] = $context['user']['is_logged'] || $context['can_approve'] || $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'] || $context['can_merge'] || $context['can_restore'];
655
+		}
626 656
 		// Or the icons?
627
-		else
628
-			$context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'];
657
+		else {
658
+					$context['can_quick_mod'] = $context['can_remove'] || $context['can_lock'] || $context['can_sticky'] || $context['can_move'];
659
+		}
629 660
 	}
630 661
 
631 662
 	if (!empty($context['can_quick_mod']) && $options['display_quick_mod'] == 1)
@@ -659,13 +690,15 @@  discard block
 block discarded – undo
659 690
 			);
660 691
 
661 692
 			// We've seen all these boards now!
662
-			foreach ($board_info['parent_boards'] as $k => $dummy)
663
-				if (isset($_SESSION['topicseen_cache'][$k]))
693
+			foreach ($board_info['parent_boards'] as $k => $dummy) {
694
+							if (isset($_SESSION['topicseen_cache'][$k]))
664 695
 					unset($_SESSION['topicseen_cache'][$k]);
696
+			}
665 697
 		}
666 698
 
667
-		if (isset($_SESSION['topicseen_cache'][$board]))
668
-			unset($_SESSION['topicseen_cache'][$board]);
699
+		if (isset($_SESSION['topicseen_cache'][$board])) {
700
+					unset($_SESSION['topicseen_cache'][$board]);
701
+		}
669 702
 
670 703
 		$request = $smcFunc['db_query']('', '
671 704
 			SELECT id_topic, id_board, sent
@@ -686,8 +719,9 @@  discard block
 block discarded – undo
686 719
 				$context['is_marked_notify'] = true;
687 720
 				$board_sent = $row['sent'];
688 721
 			}
689
-			if (!empty($row['id_topic']))
690
-				$context['topics'][$row['id_topic']]['is_watched'] = true;
722
+			if (!empty($row['id_topic'])) {
723
+							$context['topics'][$row['id_topic']]['is_watched'] = true;
724
+			}
691 725
 		}
692 726
 		$smcFunc['db_free_result']($request);
693 727
 
@@ -711,8 +745,7 @@  discard block
 block discarded – undo
711 745
 		$pref = !empty($pref[$user_info['id']]) ? $pref[$user_info['id']] : array();
712 746
 		$pref = isset($pref['board_notify_' . $board]) ? $pref['board_notify_' . $board] : (!empty($pref['board_notify']) ? $pref['board_notify'] : 0);
713 747
 		$context['board_notification_mode'] = !$context['is_marked_notify'] ? 1 : ($pref & 0x02 ? 3 : ($pref & 0x01 ? 2 : 1));
714
-	}
715
-	else
748
+	} else
716 749
 	{
717 750
 		$context['is_marked_notify'] = false;
718 751
 		$context['board_notification_mode'] = 1;
@@ -725,23 +758,27 @@  discard block
 block discarded – undo
725 758
 	$context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false;
726 759
 
727 760
 	// Don't want to show this forever...
728
-	if ($context['becomesUnapproved'])
729
-		unset($_SESSION['becomesUnapproved']);
761
+	if ($context['becomesUnapproved']) {
762
+			unset($_SESSION['becomesUnapproved']);
763
+	}
730 764
 
731 765
 	// Build the message index button array.
732 766
 	$context['normal_buttons'] = array();
733 767
 
734
-	if ($context['can_post_new'])
735
-		$context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true);
768
+	if ($context['can_post_new']) {
769
+			$context['normal_buttons']['new_topic'] = array('text' => 'new_topic', 'image' => 'new_topic.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0', 'active' => true);
770
+	}
736 771
 
737
-	if ($context['can_post_poll'])
738
-		$context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll');
772
+	if ($context['can_post_poll']) {
773
+			$context['normal_buttons']['post_poll'] = array('text' => 'new_poll', 'image' => 'new_poll.png', 'lang' => true, 'url' => $scripturl . '?action=post;board=' . $context['current_board'] . '.0;poll');
774
+	}
739 775
 
740
-	if (!$context['user']['is_logged'])
741
-		$context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
776
+	if (!$context['user']['is_logged']) {
777
+			$context['normal_buttons']['markread'] = array('text' => 'mark_read_short', 'image' => 'markread.png', 'lang' => true, 'custom' => 'data-confirm="' . $txt['are_sure_mark_read'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=markasread;sa=board;board=' . $context['current_board'] . '.0;' . $context['session_var'] . '=' . $context['session_id']);
778
+	}
742 779
 
743
-	if ($context['can_mark_notify'])
744
-		$context['normal_buttons']['notify'] = array(
780
+	if ($context['can_mark_notify']) {
781
+			$context['normal_buttons']['notify'] = array(
745 782
 			'lang' => true,
746 783
 			'text' => 'notify_board_' . $context['board_notification_mode'],
747 784
 			'sub_buttons' => array(
@@ -759,6 +796,7 @@  discard block
 block discarded – undo
759 796
 				),
760 797
 			),
761 798
 		);
799
+	}
762 800
 
763 801
 	// Javascript for inline editing.
764 802
 	loadJavaScriptFile('topic.js', array('defer' => false), 'smf_topic');
@@ -780,18 +818,21 @@  discard block
 block discarded – undo
780 818
 	checkSession('request');
781 819
 
782 820
 	// Lets go straight to the restore area.
783
-	if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics']))
784
-		redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']);
821
+	if (isset($_REQUEST['qaction']) && $_REQUEST['qaction'] == 'restore' && !empty($_REQUEST['topics'])) {
822
+			redirectexit('action=restoretopic;topics=' . implode(',', $_REQUEST['topics']) . ';' . $context['session_var'] . '=' . $context['session_id']);
823
+	}
785 824
 
786
-	if (isset($_SESSION['topicseen_cache']))
787
-		$_SESSION['topicseen_cache'] = array();
825
+	if (isset($_SESSION['topicseen_cache'])) {
826
+			$_SESSION['topicseen_cache'] = array();
827
+	}
788 828
 
789 829
 	// This is going to be needed to send off the notifications and for updateLastMessages().
790 830
 	require_once($sourcedir . '/Subs-Post.php');
791 831
 
792 832
 	// Remember the last board they moved things to.
793
-	if (isset($_REQUEST['move_to']))
794
-		$_SESSION['move_to_topic'] = $_REQUEST['move_to'];
833
+	if (isset($_REQUEST['move_to'])) {
834
+			$_SESSION['move_to_topic'] = $_REQUEST['move_to'];
835
+	}
795 836
 
796 837
 	// Only a few possible actions.
797 838
 	$possibleActions = array();
@@ -811,8 +852,7 @@  discard block
 block discarded – undo
811 852
 		);
812 853
 
813 854
 		$redirect_url = 'board=' . $board . '.' . $_REQUEST['start'];
814
-	}
815
-	else
855
+	} else
816 856
 	{
817 857
 		/**
818 858
 		 * @todo Ugly. There's no getting around this, is there?
@@ -830,8 +870,7 @@  discard block
 block discarded – undo
830 870
 		if (!empty($board))
831 871
 		{
832 872
 			$boards_can['post_new'] = array_diff(boardsAllowedTo('post_new'), array($board));
833
-		}
834
-		else
873
+		} else
835 874
 		{
836 875
 			$boards_can['post_new'] = boardsAllowedTo('post_new');
837 876
 		}
@@ -842,55 +881,67 @@  discard block
 block discarded – undo
842 881
 		}
843 882
 	}
844 883
 
845
-	if (!$user_info['is_guest'])
846
-		$possibleActions[] = 'markread';
847
-	if (!empty($boards_can['make_sticky']))
848
-		$possibleActions[] = 'sticky';
849
-	if (!empty($boards_can['move_any']) || !empty($boards_can['move_own']))
850
-		$possibleActions[] = 'move';
851
-	if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own']))
852
-		$possibleActions[] = 'remove';
853
-	if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own']))
854
-		$possibleActions[] = 'lock';
855
-	if (!empty($boards_can['merge_any']))
856
-		$possibleActions[] = 'merge';
857
-	if (!empty($boards_can['approve_posts']))
858
-		$possibleActions[] = 'approve';
884
+	if (!$user_info['is_guest']) {
885
+			$possibleActions[] = 'markread';
886
+	}
887
+	if (!empty($boards_can['make_sticky'])) {
888
+			$possibleActions[] = 'sticky';
889
+	}
890
+	if (!empty($boards_can['move_any']) || !empty($boards_can['move_own'])) {
891
+			$possibleActions[] = 'move';
892
+	}
893
+	if (!empty($boards_can['remove_any']) || !empty($boards_can['remove_own'])) {
894
+			$possibleActions[] = 'remove';
895
+	}
896
+	if (!empty($boards_can['lock_any']) || !empty($boards_can['lock_own'])) {
897
+			$possibleActions[] = 'lock';
898
+	}
899
+	if (!empty($boards_can['merge_any'])) {
900
+			$possibleActions[] = 'merge';
901
+	}
902
+	if (!empty($boards_can['approve_posts'])) {
903
+			$possibleActions[] = 'approve';
904
+	}
859 905
 
860 906
 	// Two methods: $_REQUEST['actions'] (id_topic => action), and $_REQUEST['topics'] and $_REQUEST['qaction'].
861 907
 	// (if action is 'move', $_REQUEST['move_to'] or $_REQUEST['move_tos'][$topic] is used.)
862 908
 	if (!empty($_REQUEST['topics']))
863 909
 	{
864 910
 		// If the action isn't valid, just quit now.
865
-		if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions))
866
-			redirectexit($redirect_url);
911
+		if (empty($_REQUEST['qaction']) || !in_array($_REQUEST['qaction'], $possibleActions)) {
912
+					redirectexit($redirect_url);
913
+		}
867 914
 
868 915
 		// Merge requires all topics as one parameter and can be done at once.
869 916
 		if ($_REQUEST['qaction'] == 'merge')
870 917
 		{
871 918
 			// Merge requires at least two topics.
872
-			if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2)
873
-				redirectexit($redirect_url);
919
+			if (empty($_REQUEST['topics']) || count($_REQUEST['topics']) < 2) {
920
+							redirectexit($redirect_url);
921
+			}
874 922
 
875 923
 			require_once($sourcedir . '/SplitTopics.php');
876 924
 			return MergeExecute($_REQUEST['topics']);
877 925
 		}
878 926
 
879 927
 		// Just convert to the other method, to make it easier.
880
-		foreach ($_REQUEST['topics'] as $topic)
881
-			$_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction'];
928
+		foreach ($_REQUEST['topics'] as $topic) {
929
+					$_REQUEST['actions'][(int) $topic] = $_REQUEST['qaction'];
930
+		}
882 931
 	}
883 932
 
884 933
 	// Weird... how'd you get here?
885
-	if (empty($_REQUEST['actions']))
886
-		redirectexit($redirect_url);
934
+	if (empty($_REQUEST['actions'])) {
935
+			redirectexit($redirect_url);
936
+	}
887 937
 
888 938
 	// Validate each action.
889 939
 	$temp = array();
890 940
 	foreach ($_REQUEST['actions'] as $topic => $action)
891 941
 	{
892
-		if (in_array($action, $possibleActions))
893
-			$temp[(int) $topic] = $action;
942
+		if (in_array($action, $possibleActions)) {
943
+					$temp[(int) $topic] = $action;
944
+		}
894 945
 	}
895 946
 	$_REQUEST['actions'] = $temp;
896 947
 
@@ -911,27 +962,31 @@  discard block
 block discarded – undo
911 962
 		{
912 963
 			if (!empty($board))
913 964
 			{
914
-				if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts')))
915
-					unset($_REQUEST['actions'][$row['id_topic']]);
916
-			}
917
-			else
965
+				if ($row['id_board'] != $board || ($modSettings['postmod_active'] && !$row['approved'] && !allowedTo('approve_posts'))) {
966
+									unset($_REQUEST['actions'][$row['id_topic']]);
967
+				}
968
+			} else
918 969
 			{
919 970
 				// Don't allow them to act on unapproved posts they can't see...
920
-				if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts']))
921
-					unset($_REQUEST['actions'][$row['id_topic']]);
971
+				if ($modSettings['postmod_active'] && !$row['approved'] && !in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])) {
972
+									unset($_REQUEST['actions'][$row['id_topic']]);
973
+				}
922 974
 				// Goodness, this is fun.  We need to validate the action.
923
-				elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky']))
924
-					unset($_REQUEST['actions'][$row['id_topic']]);
925
-				elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own']))))
926
-					unset($_REQUEST['actions'][$row['id_topic']]);
927
-				elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own']))))
928
-					unset($_REQUEST['actions'][$row['id_topic']]);
975
+				elseif ($_REQUEST['actions'][$row['id_topic']] == 'sticky' && !in_array(0, $boards_can['make_sticky']) && !in_array($row['id_board'], $boards_can['make_sticky'])) {
976
+									unset($_REQUEST['actions'][$row['id_topic']]);
977
+				} elseif ($_REQUEST['actions'][$row['id_topic']] == 'move' && !in_array(0, $boards_can['move_any']) && !in_array($row['id_board'], $boards_can['move_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['move_own']) && !in_array($row['id_board'], $boards_can['move_own'])))) {
978
+									unset($_REQUEST['actions'][$row['id_topic']]);
979
+				} elseif ($_REQUEST['actions'][$row['id_topic']] == 'remove' && !in_array(0, $boards_can['remove_any']) && !in_array($row['id_board'], $boards_can['remove_any']) && ($row['id_member_started'] != $user_info['id'] || (!in_array(0, $boards_can['remove_own']) && !in_array($row['id_board'], $boards_can['remove_own'])))) {
980
+									unset($_REQUEST['actions'][$row['id_topic']]);
981
+				}
929 982
 				// @todo $locked is not set, what are you trying to do? (taking the change it is supposed to be $row['locked'])
930
-				elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own']))))
931
-					unset($_REQUEST['actions'][$row['id_topic']]);
983
+				elseif ($_REQUEST['actions'][$row['id_topic']] == 'lock' && !in_array(0, $boards_can['lock_any']) && !in_array($row['id_board'], $boards_can['lock_any']) && ($row['id_member_started'] != $user_info['id'] || $row['locked'] == 1 || (!in_array(0, $boards_can['lock_own']) && !in_array($row['id_board'], $boards_can['lock_own'])))) {
984
+									unset($_REQUEST['actions'][$row['id_topic']]);
985
+				}
932 986
 				// If the topic is approved then you need permission to approve the posts within.
933
-				elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts']))))
934
-					unset($_REQUEST['actions'][$row['id_topic']]);
987
+				elseif ($_REQUEST['actions'][$row['id_topic']] == 'approve' && (!$row['unapproved_posts'] || (!in_array(0, $boards_can['approve_posts']) && !in_array($row['id_board'], $boards_can['approve_posts'])))) {
988
+									unset($_REQUEST['actions'][$row['id_topic']]);
989
+				}
935 990
 			}
936 991
 		}
937 992
 		$smcFunc['db_free_result']($request);
@@ -949,11 +1004,11 @@  discard block
 block discarded – undo
949 1004
 	{
950 1005
 		$topic = (int) $topic;
951 1006
 
952
-		if ($action == 'markread')
953
-			$markCache[] = $topic;
954
-		elseif ($action == 'sticky')
955
-			$stickyCache[] = $topic;
956
-		elseif ($action == 'move')
1007
+		if ($action == 'markread') {
1008
+					$markCache[] = $topic;
1009
+		} elseif ($action == 'sticky') {
1010
+					$stickyCache[] = $topic;
1011
+		} elseif ($action == 'move')
957 1012
 		{
958 1013
 			require_once($sourcedir . '/MoveTopic.php');
959 1014
 			moveTopicConcurrence();
@@ -961,23 +1016,25 @@  discard block
 block discarded – undo
961 1016
 			// $moveCache[0] is the topic, $moveCache[1] is the board to move to.
962 1017
 			$moveCache[1][$topic] = (int) (isset($_REQUEST['move_tos'][$topic]) ? $_REQUEST['move_tos'][$topic] : $_REQUEST['move_to']);
963 1018
 
964
-			if (empty($moveCache[1][$topic]))
965
-				continue;
1019
+			if (empty($moveCache[1][$topic])) {
1020
+							continue;
1021
+			}
966 1022
 
967 1023
 			$moveCache[0][] = $topic;
1024
+		} elseif ($action == 'remove') {
1025
+					$removeCache[] = $topic;
1026
+		} elseif ($action == 'lock') {
1027
+					$lockCache[] = $topic;
1028
+		} elseif ($action == 'approve') {
1029
+					$approveCache[] = $topic;
968 1030
 		}
969
-		elseif ($action == 'remove')
970
-			$removeCache[] = $topic;
971
-		elseif ($action == 'lock')
972
-			$lockCache[] = $topic;
973
-		elseif ($action == 'approve')
974
-			$approveCache[] = $topic;
975 1031
 	}
976 1032
 
977
-	if (empty($board))
978
-		$affectedBoards = array();
979
-	else
980
-		$affectedBoards = array($board => array(0, 0));
1033
+	if (empty($board)) {
1034
+			$affectedBoards = array();
1035
+	} else {
1036
+			$affectedBoards = array($board => array(0, 0));
1037
+	}
981 1038
 
982 1039
 	// Do all the stickies...
983 1040
 	if (!empty($stickyCache))
@@ -1037,14 +1094,16 @@  discard block
 block discarded – undo
1037 1094
 		{
1038 1095
 			$to = $moveCache[1][$row['id_topic']];
1039 1096
 
1040
-			if (empty($to))
1041
-				continue;
1097
+			if (empty($to)) {
1098
+							continue;
1099
+			}
1042 1100
 
1043 1101
 			// Does this topic's board count the posts or not?
1044 1102
 			$countPosts[$row['id_topic']] = empty($row['count_posts']);
1045 1103
 
1046
-			if (!isset($moveTos[$to]))
1047
-				$moveTos[$to] = array();
1104
+			if (!isset($moveTos[$to])) {
1105
+							$moveTos[$to] = array();
1106
+			}
1048 1107
 
1049 1108
 			$moveTos[$to][] = $row['id_topic'];
1050 1109
 
@@ -1058,8 +1117,9 @@  discard block
 block discarded – undo
1058 1117
 		require_once($sourcedir . '/MoveTopic.php');
1059 1118
 
1060 1119
 		// Do the actual moves...
1061
-		foreach ($moveTos as $to => $topics)
1062
-			moveTopics($topics, $to);
1120
+		foreach ($moveTos as $to => $topics) {
1121
+					moveTopics($topics, $to);
1122
+		}
1063 1123
 
1064 1124
 		// Does the post counts need to be updated?
1065 1125
 		if (!empty($moveTos))
@@ -1108,20 +1168,23 @@  discard block
 block discarded – undo
1108 1168
 
1109 1169
 				while ($row = $smcFunc['db_fetch_assoc']($request))
1110 1170
 				{
1111
-					if (!isset($members[$row['id_member']]))
1112
-						$members[$row['id_member']] = 0;
1171
+					if (!isset($members[$row['id_member']])) {
1172
+											$members[$row['id_member']] = 0;
1173
+					}
1113 1174
 
1114
-					if ($topicRecounts[$row['id_topic']] === '+')
1115
-						$members[$row['id_member']] += 1;
1116
-					else
1117
-						$members[$row['id_member']] -= 1;
1175
+					if ($topicRecounts[$row['id_topic']] === '+') {
1176
+											$members[$row['id_member']] += 1;
1177
+					} else {
1178
+											$members[$row['id_member']] -= 1;
1179
+					}
1118 1180
 				}
1119 1181
 
1120 1182
 				$smcFunc['db_free_result']($request);
1121 1183
 
1122 1184
 				// And now update them member's post counts
1123
-				foreach ($members as $id_member => $post_adj)
1124
-					updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj));
1185
+				foreach ($members as $id_member => $post_adj) {
1186
+									updateMemberData($id_member, array('posts' => 'posts + ' . $post_adj));
1187
+				}
1125 1188
 
1126 1189
 			}
1127 1190
 		}
@@ -1201,8 +1264,9 @@  discard block
 block discarded – undo
1201 1264
 			approveTopics($approveCache);
1202 1265
 
1203 1266
 			// Time for some logging!
1204
-			foreach ($approveCache as $topic)
1205
-				logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic]));
1267
+			foreach ($approveCache as $topic) {
1268
+							logAction('approve_topic', array('topic' => $topic, 'member' => $approveCacheMembers[$topic]));
1269
+			}
1206 1270
 		}
1207 1271
 	}
1208 1272
 
@@ -1237,8 +1301,7 @@  discard block
 block discarded – undo
1237 1301
 				$lockStatus[$row['id_topic']] = empty($row['locked']);
1238 1302
 			}
1239 1303
 			$smcFunc['db_free_result']($result);
1240
-		}
1241
-		else
1304
+		} else
1242 1305
 		{
1243 1306
 			$result = $smcFunc['db_query']('', '
1244 1307
 				SELECT id_topic, locked, id_board
@@ -1288,13 +1351,15 @@  discard block
 block discarded – undo
1288 1351
 			)
1289 1352
 		);
1290 1353
 		$logged_topics = array();
1291
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1292
-			$logged_topics[$row['id_topic']] = $row['unwatched'];
1354
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1355
+					$logged_topics[$row['id_topic']] = $row['unwatched'];
1356
+		}
1293 1357
 		$smcFunc['db_free_result']($request);
1294 1358
 
1295 1359
 		$markArray = array();
1296
-		foreach ($markCache as $topic)
1297
-			$markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0));
1360
+		foreach ($markCache as $topic) {
1361
+					$markArray[] = array($modSettings['maxMsgID'], $user_info['id'], $topic, (isset($logged_topics[$topic]) ? $logged_topics[$topic] : 0));
1362
+		}
1298 1363
 
1299 1364
 		$smcFunc['db_insert']('replace',
1300 1365
 			'{db_prefix}log_topics',
@@ -1307,8 +1372,9 @@  discard block
 block discarded – undo
1307 1372
 	foreach ($moveCache as $topic)
1308 1373
 	{
1309 1374
 		// Didn't actually move anything!
1310
-		if (!isset($topic[0]))
1311
-			break;
1375
+		if (!isset($topic[0])) {
1376
+					break;
1377
+		}
1312 1378
 
1313 1379
 		logAction('move', array('topic' => $topic[0], 'board_from' => $topic[1], 'board_to' => $topic[2]));
1314 1380
 		sendNotifications($topic[0], 'move');
@@ -1330,8 +1396,9 @@  discard block
 block discarded – undo
1330 1396
 		'calendar_updated' => time(),
1331 1397
 	));
1332 1398
 
1333
-	if (!empty($affectedBoards))
1334
-		updateLastMessages(array_keys($affectedBoards));
1399
+	if (!empty($affectedBoards)) {
1400
+			updateLastMessages(array_keys($affectedBoards));
1401
+	}
1335 1402
 
1336 1403
 	redirectexit($redirect_url);
1337 1404
 }
Please login to merge, or discard this patch.
Sources/RepairBoards.php 1 patch
Braces   +119 added lines, -85 removed lines patch added patch discarded remove patch
@@ -13,8 +13,9 @@  discard block
 block discarded – undo
13 13
  * @version 2.1 Beta 4
14 14
  */
15 15
 
16
-if (!defined('SMF'))
16
+if (!defined('SMF')) {
17 17
 	die('No direct access...');
18
+}
18 19
 
19 20
 /**
20 21
  * Finds or repairs errors in the database to fix possible problems.
@@ -50,8 +51,9 @@  discard block
 block discarded – undo
50 51
 	);
51 52
 
52 53
 	// Start displaying errors without fixing them.
53
-	if (isset($_GET['fixErrors']))
54
-		checkSession('get');
54
+	if (isset($_GET['fixErrors'])) {
55
+			checkSession('get');
56
+	}
55 57
 
56 58
 	// Will want this.
57 59
 	loadForumTests();
@@ -69,11 +71,11 @@  discard block
 block discarded – undo
69 71
 			$_SESSION['repairboards_to_fix'] = $context['to_fix'];
70 72
 			$_SESSION['repairboards_to_fix2'] = null;
71 73
 
72
-			if (empty($context['repair_errors']))
73
-				$context['repair_errors'][] = '???';
74
+			if (empty($context['repair_errors'])) {
75
+							$context['repair_errors'][] = '???';
76
+			}
74 77
 		}
75
-	}
76
-	else
78
+	} else
77 79
 	{
78 80
 		$context['error_search'] = false;
79 81
 		$context['to_fix'] = isset($_SESSION['repairboards_to_fix']) ? $_SESSION['repairboards_to_fix'] : array();
@@ -120,16 +122,19 @@  discard block
 block discarded – undo
120 122
 
121 123
 	// More time, I need more time!
122 124
 	@set_time_limit(600);
123
-	if (function_exists('apache_reset_timeout'))
124
-		@apache_reset_timeout();
125
+	if (function_exists('apache_reset_timeout')) {
126
+			@apache_reset_timeout();
127
+	}
125 128
 
126 129
 	// Errr, wait.  How much time has this taken already?
127
-	if (!$force && (time() - $time_start) < 3)
128
-		return;
130
+	if (!$force && (time() - $time_start) < 3) {
131
+			return;
132
+	}
129 133
 
130 134
 	// Restore the query cache if interested.
131
-	if (!empty($db_temp_cache))
132
-		$db_cache = $db_temp_cache;
135
+	if (!empty($db_temp_cache)) {
136
+			$db_cache = $db_temp_cache;
137
+	}
133 138
 
134 139
 	$context['continue_get_data'] = '?action=admin;area=repairboards' . (isset($_GET['fixErrors']) ? ';fixErrors' : '') . ';step=' . $_GET['step'] . ';substep=' . $_GET['substep'] . ';' . $context['session_var'] . '=' . $context['session_id'];
135 140
 	$context['page_title'] = $txt['not_done_title'];
@@ -138,10 +143,11 @@  discard block
 block discarded – undo
138 143
 	$context['sub_template'] = 'not_done';
139 144
 
140 145
 	// Change these two if more steps are added!
141
-	if (empty($max_substep))
142
-		$context['continue_percent'] = round(($_GET['step'] * 100) / $context['total_steps']);
143
-	else
144
-		$context['continue_percent'] = round((($_GET['step'] + ($_GET['substep'] / $max_substep)) * 100) / $context['total_steps']);
146
+	if (empty($max_substep)) {
147
+			$context['continue_percent'] = round(($_GET['step'] * 100) / $context['total_steps']);
148
+	} else {
149
+			$context['continue_percent'] = round((($_GET['step'] + ($_GET['substep'] / $max_substep)) * 100) / $context['total_steps']);
150
+	}
145 151
 
146 152
 	// Never more than 100%!
147 153
 	$context['continue_percent'] = min($context['continue_percent'], 100);
@@ -612,8 +618,9 @@  discard block
 block discarded – undo
612 618
 				$row['myid_last_msg'] = (int) $row['myid_last_msg'];
613 619
 
614 620
 				// Not really a problem?
615
-				if ($row['myid_first_msg'] == $row['myid_first_msg'] && $row['myid_first_msg'] == $row['myid_first_msg'] && $row['approved'] == $row['firstmsg_approved'])
616
-					return false;
621
+				if ($row['myid_first_msg'] == $row['myid_first_msg'] && $row['myid_first_msg'] == $row['myid_first_msg'] && $row['approved'] == $row['firstmsg_approved']) {
622
+									return false;
623
+				}
617 624
 
618 625
 				$memberStartedID = (int) getMsgMemberID($row['myid_first_msg']);
619 626
 				$memberUpdatedID = (int) getMsgMemberID($row['myid_last_msg']);
@@ -637,15 +644,19 @@  discard block
 block discarded – undo
637 644
 			'message_function' => function ($row) use ($txt, &$context)
638 645
 			{
639 646
 				// A pretend error?
640
-				if ($row['myid_first_msg'] == $row['myid_first_msg'] && $row['myid_first_msg'] == $row['myid_first_msg'] && $row['approved'] == $row['firstmsg_approved'])
641
-					return false;
647
+				if ($row['myid_first_msg'] == $row['myid_first_msg'] && $row['myid_first_msg'] == $row['myid_first_msg'] && $row['approved'] == $row['firstmsg_approved']) {
648
+									return false;
649
+				}
642 650
 
643
-				if ($row['id_first_msg'] != $row['myid_first_msg'])
644
-					$context['repair_errors'][] = sprintf($txt['repair_stats_topics_1'], $row['id_topic'], $row['id_first_msg']);
645
-				if ($row['id_last_msg'] != $row['myid_last_msg'])
646
-					$context['repair_errors'][] = sprintf($txt['repair_stats_topics_2'], $row['id_topic'], $row['id_last_msg']);
647
-				if ($row['approved'] != $row['firstmsg_approved'])
648
-					$context['repair_errors'][] = sprintf($txt['repair_stats_topics_5'], $row['id_topic']);
651
+				if ($row['id_first_msg'] != $row['myid_first_msg']) {
652
+									$context['repair_errors'][] = sprintf($txt['repair_stats_topics_1'], $row['id_topic'], $row['id_first_msg']);
653
+				}
654
+				if ($row['id_last_msg'] != $row['myid_last_msg']) {
655
+									$context['repair_errors'][] = sprintf($txt['repair_stats_topics_2'], $row['id_topic'], $row['id_last_msg']);
656
+				}
657
+				if ($row['approved'] != $row['firstmsg_approved']) {
658
+									$context['repair_errors'][] = sprintf($txt['repair_stats_topics_5'], $row['id_topic']);
659
+				}
649 660
 
650 661
 				return true;
651 662
 			},
@@ -675,8 +686,9 @@  discard block
 block discarded – undo
675 686
 				$row['my_num_replies'] = (int) $row['my_num_replies'];
676 687
 
677 688
 				// Not really a problem?
678
-				if ($row['my_num_replies'] == $row['num_replies'])
679
-					return false;
689
+				if ($row['my_num_replies'] == $row['num_replies']) {
690
+									return false;
691
+				}
680 692
 
681 693
 				$smcFunc['db_query']('', '
682 694
 					UPDATE {db_prefix}topics
@@ -695,11 +707,13 @@  discard block
 block discarded – undo
695 707
 				global $txt, $context;
696 708
 
697 709
 				// Just joking?
698
-				if ($row['my_num_replies'] == $row['num_replies'])
699
-					return false;
710
+				if ($row['my_num_replies'] == $row['num_replies']) {
711
+									return false;
712
+				}
700 713
 
701
-				if ($row['num_replies'] != $row['my_num_replies'])
702
-					$context['repair_errors'][] = sprintf($txt['repair_stats_topics_3'], $row['id_topic'], $row['num_replies']);
714
+				if ($row['num_replies'] != $row['my_num_replies']) {
715
+									$context['repair_errors'][] = sprintf($txt['repair_stats_topics_3'], $row['id_topic'], $row['num_replies']);
716
+				}
703 717
 
704 718
 				return true;
705 719
 
@@ -1290,8 +1304,9 @@  discard block
 block discarded – undo
1290 1304
 				$inserts = array();
1291 1305
 				while ($row = $smcFunc['db_fetch_assoc']($result))
1292 1306
 				{
1293
-					foreach (text2words($row['subject']) as $word)
1294
-						$inserts[] = array($word, $row['id_topic']);
1307
+					foreach (text2words($row['subject']) as $word) {
1308
+											$inserts[] = array($word, $row['id_topic']);
1309
+					}
1295 1310
 					if (count($inserts) > 500)
1296 1311
 					{
1297 1312
 						$smcFunc['db_insert']('ignore',
@@ -1305,13 +1320,14 @@  discard block
 block discarded – undo
1305 1320
 
1306 1321
 				}
1307 1322
 
1308
-				if (!empty($inserts))
1309
-					$smcFunc['db_insert']('ignore',
1323
+				if (!empty($inserts)) {
1324
+									$smcFunc['db_insert']('ignore',
1310 1325
 						'{db_prefix}log_search_subjects',
1311 1326
 						array('word' => 'string', 'id_topic' => 'int'),
1312 1327
 						$inserts,
1313 1328
 						array('word', 'id_topic')
1314 1329
 					);
1330
+				}
1315 1331
 
1316 1332
 		},
1317 1333
 			'message_function' => function ($row)
@@ -1581,8 +1597,9 @@  discard block
 block discarded – undo
1581 1597
 		$current_step++;
1582 1598
 
1583 1599
 		// Already done this?
1584
-		if ($_GET['step'] > $current_step)
1585
-			continue;
1600
+		if ($_GET['step'] > $current_step) {
1601
+					continue;
1602
+		}
1586 1603
 
1587 1604
 		// If we're fixing it but it ain't broke why try?
1588 1605
 		if ($do_fix && !in_array($error_type, $to_fix))
@@ -1611,14 +1628,16 @@  discard block
 block discarded – undo
1611 1628
 		while (!$done)
1612 1629
 		{
1613 1630
 			// Make sure there's at least one ID to test.
1614
-			if (isset($test['substeps']) && empty($step_max))
1615
-				break;
1631
+			if (isset($test['substeps']) && empty($step_max)) {
1632
+							break;
1633
+			}
1616 1634
 
1617 1635
 			// What is the testing query (Changes if we are testing or fixing)
1618
-			if (!$do_fix)
1619
-				$test_query = 'check_query';
1620
-			else
1621
-				$test_query = isset($test['fix_query']) ? 'fix_query' : 'check_query';
1636
+			if (!$do_fix) {
1637
+							$test_query = 'check_query';
1638
+			} else {
1639
+							$test_query = isset($test['fix_query']) ? 'fix_query' : 'check_query';
1640
+			}
1622 1641
 
1623 1642
 			// Do the test...
1624 1643
 			$request = $smcFunc['db_query']('',
@@ -1628,10 +1647,11 @@  discard block
 block discarded – undo
1628 1647
 			);
1629 1648
 
1630 1649
 			// Does it need a fix?
1631
-			if (!empty($test['check_type']) && $test['check_type'] == 'count')
1632
-				list ($needs_fix) = $smcFunc['db_fetch_row']($request);
1633
-			else
1634
-				$needs_fix = $smcFunc['db_num_rows']($request);
1650
+			if (!empty($test['check_type']) && $test['check_type'] == 'count') {
1651
+							list ($needs_fix) = $smcFunc['db_fetch_row']($request);
1652
+			} else {
1653
+							$needs_fix = $smcFunc['db_num_rows']($request);
1654
+			}
1635 1655
 
1636 1656
 			$total_queries++;
1637 1657
 
@@ -1643,8 +1663,9 @@  discard block
 block discarded – undo
1643 1663
 					// Assume need to fix.
1644 1664
 					$found_errors = true;
1645 1665
 
1646
-					if (isset($test['message']))
1647
-						$context['repair_errors'][] = $txt[$test['message']];
1666
+					if (isset($test['message'])) {
1667
+											$context['repair_errors'][] = $txt[$test['message']];
1668
+					}
1648 1669
 
1649 1670
 					// One per row!
1650 1671
 					elseif (isset($test['messages']))
@@ -1654,10 +1675,11 @@  discard block
 block discarded – undo
1654 1675
 							$variables = $test['messages'];
1655 1676
 							foreach ($variables as $k => $v)
1656 1677
 							{
1657
-								if ($k == 0 && isset($txt[$v]))
1658
-									$variables[$k] = $txt[$v];
1659
-								elseif ($k > 0 && isset($row[$v]))
1660
-									$variables[$k] = $row[$v];
1678
+								if ($k == 0 && isset($txt[$v])) {
1679
+																	$variables[$k] = $txt[$v];
1680
+								} elseif ($k > 0 && isset($row[$v])) {
1681
+																	$variables[$k] = $row[$v];
1682
+								}
1661 1683
 							}
1662 1684
 							$context['repair_errors'][] = call_user_func_array('sprintf', $variables);
1663 1685
 						}
@@ -1668,13 +1690,15 @@  discard block
 block discarded – undo
1668 1690
 					{
1669 1691
 						// Find out if there are actually errors.
1670 1692
 						$found_errors = false;
1671
-						while ($row = $smcFunc['db_fetch_assoc']($request))
1672
-							$found_errors |= $test['message_function']($row);
1693
+						while ($row = $smcFunc['db_fetch_assoc']($request)) {
1694
+													$found_errors |= $test['message_function']($row);
1695
+						}
1673 1696
 					}
1674 1697
 
1675 1698
 					// Actually have something to fix?
1676
-					if ($found_errors)
1677
-						$to_fix[] = $error_type;
1699
+					if ($found_errors) {
1700
+											$to_fix[] = $error_type;
1701
+					}
1678 1702
 				}
1679 1703
 
1680 1704
 				// We want to fix, we need to fix - so work out what exactly to do!
@@ -1684,8 +1708,9 @@  discard block
 block discarded – undo
1684 1708
 					if (isset($test['fix_collect']))
1685 1709
 					{
1686 1710
 						$ids = array();
1687
-						while ($row = $smcFunc['db_fetch_assoc']($request))
1688
-							$ids[] = $row[$test['fix_collect']['index']];
1711
+						while ($row = $smcFunc['db_fetch_assoc']($request)) {
1712
+													$ids[] = $row[$test['fix_collect']['index']];
1713
+						}
1689 1714
 						if (!empty($ids))
1690 1715
 						{
1691 1716
 							// Fix it!
@@ -1694,30 +1719,34 @@  discard block
 block discarded – undo
1694 1719
 					}
1695 1720
 
1696 1721
 					// Simply executing a fix it query?
1697
-					elseif (isset($test['fix_it_query']))
1698
-						$smcFunc['db_query']('',
1722
+					elseif (isset($test['fix_it_query'])) {
1723
+											$smcFunc['db_query']('',
1699 1724
 							$test['fix_it_query'],
1700 1725
 							array(
1701 1726
 							)
1702 1727
 						);
1728
+					}
1703 1729
 
1704 1730
 					// Do we have some processing to do?
1705 1731
 					elseif (isset($test['fix_processing']))
1706 1732
 					{
1707
-						while ($row = $smcFunc['db_fetch_assoc']($request))
1708
-							$test['fix_processing']($row);
1733
+						while ($row = $smcFunc['db_fetch_assoc']($request)) {
1734
+													$test['fix_processing']($row);
1735
+						}
1709 1736
 					}
1710 1737
 
1711 1738
 					// What about the full set of processing?
1712
-					elseif (isset($test['fix_full_processing']))
1713
-						$test['fix_full_processing']($request);
1739
+					elseif (isset($test['fix_full_processing'])) {
1740
+											$test['fix_full_processing']($request);
1741
+					}
1714 1742
 
1715 1743
 					// Do we have other things we need to fix as a result?
1716 1744
 					if (!empty($test['force_fix']))
1717 1745
 					{
1718
-						foreach ($test['force_fix'] as $item)
1719
-							if (!in_array($item, $to_fix))
1746
+						foreach ($test['force_fix'] as $item) {
1747
+													if (!in_array($item, $to_fix))
1720 1748
 								$to_fix[] = $item;
1749
+						}
1721 1750
 					}
1722 1751
 				}
1723 1752
 			}
@@ -1735,16 +1764,17 @@  discard block
 block discarded – undo
1735 1764
 				if ($_GET['substep'] <= $step_max)
1736 1765
 				{
1737 1766
 					pauseRepairProcess($to_fix, $error_type, $step_max);
1767
+				} else {
1768
+									$done = true;
1738 1769
 				}
1739
-				else
1740
-					$done = true;
1770
+			} else {
1771
+							$done = true;
1741 1772
 			}
1742
-			else
1743
-				$done = true;
1744 1773
 
1745 1774
 			// Don't allow more than 1000 queries at a time.
1746
-			if ($total_queries >= 1000)
1747
-				pauseRepairProcess($to_fix, $error_type, $step_max, true);
1775
+			if ($total_queries >= 1000) {
1776
+							pauseRepairProcess($to_fix, $error_type, $step_max, true);
1777
+			}
1748 1778
 		}
1749 1779
 
1750 1780
 		// Keep going.
@@ -1757,8 +1787,9 @@  discard block
 block discarded – undo
1757 1787
 		if ($do_fix)
1758 1788
 		{
1759 1789
 			$key = array_search($error_type, $to_fix);
1760
-			if ($key !== false && isset($to_fix[$key]))
1761
-				unset($to_fix[$key]);
1790
+			if ($key !== false && isset($to_fix[$key])) {
1791
+							unset($to_fix[$key]);
1792
+			}
1762 1793
 		}
1763 1794
 
1764 1795
 		// Are we done?
@@ -1781,10 +1812,11 @@  discard block
 block discarded – undo
1781 1812
 	static $createOnce = false;
1782 1813
 
1783 1814
 	// Have we already created it?
1784
-	if ($createOnce)
1785
-		return;
1786
-	else
1787
-		$createOnce = true;
1815
+	if ($createOnce) {
1816
+			return;
1817
+	} else {
1818
+			$createOnce = true;
1819
+	}
1788 1820
 
1789 1821
 	// Back to the forum's default language.
1790 1822
 	loadLanguage('Admin', $language);
@@ -1799,8 +1831,9 @@  discard block
 block discarded – undo
1799 1831
 			'cat_name' => $txt['salvaged_category_name'],
1800 1832
 		)
1801 1833
 	);
1802
-	if ($smcFunc['db_num_rows']($result) != 0)
1803
-		list ($salvageCatID) = $smcFunc['db_fetch_row']($result);
1834
+	if ($smcFunc['db_num_rows']($result) != 0) {
1835
+			list ($salvageCatID) = $smcFunc['db_fetch_row']($result);
1836
+	}
1804 1837
 	$smcFunc['db_free_result']($result);
1805 1838
 
1806 1839
 	if (empty($salvageCatID))
@@ -1832,8 +1865,9 @@  discard block
 block discarded – undo
1832 1865
 			'board_name' => $txt['salvaged_board_name'],
1833 1866
 		)
1834 1867
 	);
1835
-	if ($smcFunc['db_num_rows']($result) != 0)
1836
-		list ($salvageBoardID) = $smcFunc['db_fetch_row']($result);
1868
+	if ($smcFunc['db_num_rows']($result) != 0) {
1869
+			list ($salvageBoardID) = $smcFunc['db_fetch_row']($result);
1870
+	}
1837 1871
 	$smcFunc['db_free_result']($result);
1838 1872
 
1839 1873
 	if (empty($salvageBoardID))
Please login to merge, or discard this patch.