Completed
Push — release-2.1 ( 121660...f19596 )
by Mathias
09:09
created
Sources/tasks/MemberReport-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class MemberReport_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
22
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23 23
 	 * @return bool Always returns true.
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -46,9 +46,10 @@  discard block
 block discarded – undo
46 46
 
47 47
 		foreach ($prefs as $member => $pref_option)
48 48
 		{
49
-			foreach ($alert_bits as $type => $bitvalue)
50
-				if ($pref_option['member_report'] & $bitvalue)
49
+			foreach ($alert_bits as $type => $bitvalue) {
50
+							if ($pref_option['member_report'] & $bitvalue)
51 51
 					$notifies[$type][] = $member;
52
+			}
52 53
 		}
53 54
 
54 55
 		// Firstly, anyone who wants alerts.
@@ -109,8 +110,9 @@  discard block
 block discarded – undo
109 110
 			);
110 111
 			while ($row = $smcFunc['db_fetch_assoc']($request))
111 112
 			{
112
-				if (empty($row['lngfile']))
113
-					$row['lngfile'] = $language;
113
+				if (empty($row['lngfile'])) {
114
+									$row['lngfile'] = $language;
115
+				}
114 116
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
115 117
 			}
116 118
 			$smcFunc['db_free_result']($request);
@@ -129,8 +131,9 @@  discard block
 block discarded – undo
129 131
 				$emaildata = loadEmailTemplate('report_member_profile', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
130 132
 
131 133
 				// And do the actual sending...
132
-				foreach ($recipients as $id_member => $email_address)
133
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'ureport' . $this->_details['report_id'], $emaildata['is_html'], 2);
134
+				foreach ($recipients as $id_member => $email_address) {
135
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'ureport' . $this->_details['report_id'], $emaildata['is_html'], 2);
136
+				}
134 137
 			}
135 138
 		}
136 139
 
Please login to merge, or discard this patch.
Sources/tasks/Birthday-Notify.php 2 patches
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -51,8 +51,9 @@  discard block
 block discarded – undo
51 51
 		$birthdays = array();
52 52
 		while ($row = $smcFunc['db_fetch_assoc']($result))
53 53
 		{
54
-			if (!isset($birthdays[$row['lngfile']]))
55
-				$birthdays[$row['lngfile']] = array();
54
+			if (!isset($birthdays[$row['lngfile']])) {
55
+							$birthdays[$row['lngfile']] = array();
56
+			}
56 57
 			$birthdays[$row['lngfile']][$row['id_member']] = array(
57 58
 				'name' => $row['real_name'],
58 59
 				'email' => $row['email_address']
@@ -117,8 +118,8 @@  discard block
 block discarded – undo
117 118
 			AddMailQueue(true);
118 119
 
119 120
 			// Insert the alerts if any
120
-			if (!empty($alert_rows))
121
-				$smcFunc['db_insert']('',
121
+			if (!empty($alert_rows)) {
122
+							$smcFunc['db_insert']('',
122 123
 					'{db_prefix}user_alerts',
123 124
 					array(
124 125
 						'alert_time' => 'int', 'id_member' => 'int', 'content_type' => 'string',
@@ -127,6 +128,7 @@  discard block
 block discarded – undo
127 128
 					$alert_rows,
128 129
 					array()
129 130
 				);
131
+			}
130 132
 		}
131 133
 
132 134
 		return true;
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@
 block discarded – undo
18 18
  */
19 19
 class Birthday_Notify_Background extends SMF_BackgroundTask
20 20
 {
21
-    /**
22
-     * This executes the task. It loads up the birthdays, figures out the greeting, etc.
23
-     * @return bool Always returns true
24
-     */
21
+	/**
22
+	 * This executes the task. It loads up the birthdays, figures out the greeting, etc.
23
+	 * @return bool Always returns true
24
+	 */
25 25
 	public function execute()
26 26
  	{
27 27
 		global $txt, $smcFunc, $txtBirthdayEmails, $modSettings, $sourcedir;
Please login to merge, or discard this patch.
Sources/tasks/MsgReportReply-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 class MsgReportReply_Notify_Background extends SMF_BackgroundTask
21 21
 {
22 22
 	/**
23
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
24 24
 	 * @return bool Always returns true.
25 25
 	 */
26 26
 	public function execute()
Please login to merge, or discard this patch.
Braces   +21 added lines, -14 removed lines patch added patch discarded remove patch
@@ -40,8 +40,9 @@  discard block
 block discarded – undo
40 40
 				'last_comment' => $this->_details['comment_id'],
41 41
 			)
42 42
 		);
43
-		while ($row = $smcFunc['db_fetch_row']($request))
44
-			$possible_members[] = $row[0];
43
+		while ($row = $smcFunc['db_fetch_row']($request)) {
44
+					$possible_members[] = $row[0];
45
+		}
45 46
 		$smcFunc['db_free_result']($request);
46 47
 
47 48
 		// Presumably, there are some people?
@@ -50,8 +51,9 @@  discard block
 block discarded – undo
50 51
 			$possible_members = array_flip(array_flip($possible_members));
51 52
 			$possible_members = array_diff($possible_members, array($this->_details['sender_id']));
52 53
 		}
53
-		if (empty($possible_members))
54
-			return true;
54
+		if (empty($possible_members)) {
55
+					return true;
56
+		}
55 57
 
56 58
 		// We need to know who can moderate this board - and therefore who can see this report.
57 59
 		// First up, people who have moderate_board in the board this topic was in.
@@ -67,8 +69,9 @@  discard block
 block discarded – undo
67 69
 				'current_board' => $this->_details['board_id'],
68 70
 			)
69 71
 		);
70
-		while ($row = $smcFunc['db_fetch_assoc']($request))
71
-			$members[] = $row['id_member'];
72
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
73
+					$members[] = $row['id_member'];
74
+		}
72 75
 		$smcFunc['db_free_result']($request);
73 76
 
74 77
 		// Thirdly, anyone assigned to be a moderator of this group as a group->board moderator.
@@ -85,8 +88,9 @@  discard block
 block discarded – undo
85 88
 			)
86 89
 		);
87 90
 
88
-		while ($row = $smcFunc['db_fetch_assoc']($request))
89
-			$members[] = $row['id_member'];
91
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
92
+					$members[] = $row['id_member'];
93
+		}
90 94
 		$smcFunc['db_free_result']($request);
91 95
 
92 96
 		// So now we have two lists: the people who replied to a report in the past,
@@ -108,8 +112,9 @@  discard block
 block discarded – undo
108 112
 		{
109 113
 			foreach ($alert_bits as $type => $bitvalue)
110 114
 			{
111
-				if ($pref_option['msg_report_reply'] & $bitvalue)
112
-					$notifies[$type][] = $member;
115
+				if ($pref_option['msg_report_reply'] & $bitvalue) {
116
+									$notifies[$type][] = $member;
117
+				}
113 118
 			}
114 119
 		}
115 120
 
@@ -170,8 +175,9 @@  discard block
 block discarded – undo
170 175
 			);
171 176
 			while ($row = $smcFunc['db_fetch_assoc']($request))
172 177
 			{
173
-				if (empty($row['lngfile']))
174
-					$row['lngfile'] = $language;
178
+				if (empty($row['lngfile'])) {
179
+									$row['lngfile'] = $language;
180
+				}
175 181
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
176 182
 			}
177 183
 			$smcFunc['db_free_result']($request);
@@ -203,8 +209,9 @@  discard block
 block discarded – undo
203 209
 				$emaildata = loadEmailTemplate('reply_to_moderator', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
204 210
 
205 211
 				// And do the actual sending...
206
-				foreach ($recipients as $id_member => $email_address)
207
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'rptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3);
212
+				foreach ($recipients as $id_member => $email_address) {
213
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'rptrpy' . $this->_details['comment_id'], $emaildata['is_html'], 3);
214
+				}
208 215
 			}
209 216
 		}
210 217
 
Please login to merge, or discard this patch.
Sources/tasks/ApproveReply-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 class ApproveReply_Notify_Background extends SMF_BackgroundTask
19 19
 {
20 20
 	/**
21
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts.
21
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts.
22 22
 	 * @return bool Always returns true.
23 23
 	 */
24 24
 	public function execute()
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,14 +96,15 @@
 block discarded – undo
96 96
 		}
97 97
 
98 98
 		// Insert the alerts if any
99
-		if (!empty($alert_rows))
100
-			$smcFunc['db_insert']('',
99
+		if (!empty($alert_rows)) {
100
+					$smcFunc['db_insert']('',
101 101
 				'{db_prefix}user_alerts',
102 102
 				array('alert_time' => 'int', 'id_member' => 'int', 'id_member_started' => 'int', 'member_name' => 'string',
103 103
 					'content_type' => 'string', 'content_id' => 'int', 'content_action' => 'string', 'is_read' => 'int', 'extra' => 'string'),
104 104
 				$alert_rows,
105 105
 				array()
106 106
 			);
107
+		}
107 108
 
108 109
 		return true;
109 110
 	}
Please login to merge, or discard this patch.
Sources/tasks/MsgReport-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class MsgReport_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
22
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
23 23
 	 * @return bool Always returns true.
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Braces   +15 added lines, -10 removed lines patch added patch discarded remove patch
@@ -40,8 +40,9 @@  discard block
 block discarded – undo
40 40
 				'current_board' => $this->_details['board_id'],
41 41
 			)
42 42
 		);
43
-		while ($row = $smcFunc['db_fetch_assoc']($request))
44
-			$members[] = $row['id_member'];
43
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
44
+					$members[] = $row['id_member'];
45
+		}
45 46
 		$smcFunc['db_free_result']($request);
46 47
 
47 48
 		// Thirdly, anyone assigned to be a moderator of this group as a group->board moderator.
@@ -58,8 +59,9 @@  discard block
 block discarded – undo
58 59
 			)
59 60
 		);
60 61
 
61
-		while ($row = $smcFunc['db_fetch_assoc']($request))
62
-			$members[] = $row['id_member'];
62
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
63
+					$members[] = $row['id_member'];
64
+		}
63 65
 		$smcFunc['db_free_result']($request);
64 66
 
65 67
 		// And now weed out the duplicates.
@@ -81,9 +83,10 @@  discard block
 block discarded – undo
81 83
 
82 84
 		foreach ($prefs as $member => $pref_option)
83 85
 		{
84
-			foreach ($alert_bits as $type => $bitvalue)
85
-				if ($pref_option['msg_report'] & $bitvalue)
86
+			foreach ($alert_bits as $type => $bitvalue) {
87
+							if ($pref_option['msg_report'] & $bitvalue)
86 88
 					$notifies[$type][] = $member;
89
+			}
87 90
 		}
88 91
 
89 92
 		// Firstly, anyone who wants alerts.
@@ -143,8 +146,9 @@  discard block
 block discarded – undo
143 146
 			);
144 147
 			while ($row = $smcFunc['db_fetch_assoc']($request))
145 148
 			{
146
-				if (empty($row['lngfile']))
147
-					$row['lngfile'] = $language;
149
+				if (empty($row['lngfile'])) {
150
+									$row['lngfile'] = $language;
151
+				}
148 152
 				$emails[$row['lngfile']][$row['id_member']] = $row['email_address'];
149 153
 			}
150 154
 			$smcFunc['db_free_result']($request);
@@ -177,8 +181,9 @@  discard block
 block discarded – undo
177 181
 				$emaildata = loadEmailTemplate('report_to_moderator', $replacements, empty($modSettings['userLanguage']) ? $language : $this_lang);
178 182
 
179 183
 				// And do the actual sending...
180
-				foreach ($recipients as $id_member => $email_address)
181
-					sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'report' . $this->_details['report_id'], $emaildata['is_html'], 2);
184
+				foreach ($recipients as $id_member => $email_address) {
185
+									sendmail($email_address, $emaildata['subject'], $emaildata['body'], null, 'report' . $this->_details['report_id'], $emaildata['is_html'], 2);
186
+				}
182 187
 			}
183 188
 		}
184 189
 
Please login to merge, or discard this patch.
Sources/tasks/Buddy-Notify.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
 class Buddy_Notify_Background extends SMF_BackgroundTask
20 20
 {
21 21
 	/**
22
-     * This executes the task - loads up the info, sets the alerts and loads up the email queue.
22
+	 * This executes the task - loads up the info, sets the alerts and loads up the email queue.
23 23
 	 * @return bool Always returns true
24 24
 	 */
25 25
 	public function execute()
Please login to merge, or discard this patch.
Sources/tasks/GroupReq-Notify.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
 class GroupReq_Notify_Background extends SMF_BackgroundTask
21 21
 {
22 22
 	/**
23
-     * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed.
23
+	 * This executes the task - loads up the information, puts the email in the queue and inserts any alerts as needed.
24 24
 	 * @return bool Always returns true.
25 25
 	 */
26 26
 	public function execute()
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -37,8 +37,9 @@  discard block
 block discarded – undo
37 37
 			)
38 38
 		);
39 39
 		$moderators = array();
40
-		while ($row = $smcFunc['db_fetch_assoc']($request))
41
-			$moderators[] = $row['id_member'];
40
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
41
+					$moderators[] = $row['id_member'];
42
+		}
42 43
 		$smcFunc['db_free_result']($request);
43 44
 
44 45
 		require_once($sourcedir . '/Subs-Members.php');
@@ -59,11 +60,13 @@  discard block
 block discarded – undo
59 60
 			{
60 61
 				if (!empty($prefs[$mod]['request_group']))
61 62
 				{
62
-					if ($prefs[$mod]['request_group'] & 0x01)
63
-						$data['alert'][] = $mod;
63
+					if ($prefs[$mod]['request_group'] & 0x01) {
64
+											$data['alert'][] = $mod;
65
+					}
64 66
 
65
-					if ($prefs[$mod]['request_group'] & 0x02)
66
-						$data['email'][] = $mod;
67
+					if ($prefs[$mod]['request_group'] & 0x02) {
68
+											$data['email'][] = $mod;
69
+					}
67 70
 				}
68 71
 			}
69 72
 
Please login to merge, or discard this patch.
Sources/tasks/GroupAct-Notify.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,10 +19,10 @@
 block discarded – undo
19 19
  */
20 20
 class GroupAct_Notify_Background extends SMF_BackgroundTask
21 21
 {
22
-    /**
23
-     * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
24
-     * @return bool Always returns true
25
-     */
22
+	/**
23
+	 * This executes the task - loads up the information, puts the email in the queue and inserts alerts as needed.
24
+	 * @return bool Always returns true
25
+	 */
26 26
 	public function execute()
27 27
 	{
28 28
 		global $sourcedir, $smcFunc, $language, $modSettings;
Please login to merge, or discard this patch.
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -132,8 +132,9 @@  discard block
 block discarded – undo
132 132
 						'GROUPNAME' => $user['group_name'],
133 133
 					);
134 134
 
135
-					if (!empty($custom_reason))
136
-						$replacements['REASON'] = $custom_reason;
135
+					if (!empty($custom_reason)) {
136
+											$replacements['REASON'] = $custom_reason;
137
+					}
137 138
 
138 139
 					$emaildata = loadEmailTemplate($email_template_name, $replacements, $user['language']);
139 140
 
@@ -142,8 +143,8 @@  discard block
 block discarded – undo
142 143
 			}
143 144
 
144 145
 			// Insert the alerts if any
145
-			if (!empty($alert_rows))
146
-				$smcFunc['db_insert']('',
146
+			if (!empty($alert_rows)) {
147
+							$smcFunc['db_insert']('',
147 148
 					'{db_prefix}user_alerts',
148 149
 					array(
149 150
 						'alert_time' => 'int', 'id_member' => 'int', 'content_type' => 'string',
@@ -152,6 +153,7 @@  discard block
 block discarded – undo
152 153
 					$alert_rows,
153 154
 					array()
154 155
 				);
156
+			}
155 157
 		}
156 158
 
157 159
 		return true;
Please login to merge, or discard this patch.
Sources/ManageSettings.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1323,7 +1323,7 @@  discard block
 block discarded – undo
1323 1323
 					'class' => 'centercol',
1324 1324
 				),
1325 1325
 				'data' => array(
1326
-					'function' => function ($rowData)
1326
+					'function' => function($rowData)
1327 1327
 					{
1328 1328
 						$isChecked = $rowData['disabled'] ? '' : ' checked';
1329 1329
 						$onClickHandler = $rowData['can_show_register'] ? sprintf(' onclick="document.getElementById(\'reg_%1$s\').disabled = !this.checked;"', $rowData['id']) : '';
@@ -1339,7 +1339,7 @@  discard block
 block discarded – undo
1339 1339
 					'class' => 'centercol',
1340 1340
 				),
1341 1341
 				'data' => array(
1342
-					'function' => function ($rowData)
1342
+					'function' => function($rowData)
1343 1343
 					{
1344 1344
 						$isChecked = $rowData['on_register'] && !$rowData['disabled'] ? ' checked' : '';
1345 1345
 						$isDisabled = $rowData['can_show_register'] ? '' : ' disabled';
@@ -1386,15 +1386,15 @@  discard block
 block discarded – undo
1386 1386
 					'value' => $txt['custom_profile_fieldorder'],
1387 1387
 				),
1388 1388
 				'data' => array(
1389
-					'function' => function ($rowData) use ($context, $txt, $scripturl)
1389
+					'function' => function($rowData) use ($context, $txt, $scripturl)
1390 1390
 					{
1391
-						$return = '<p class="centertext bold_text">'. $rowData['field_order'] .'<br />';
1391
+						$return = '<p class="centertext bold_text">' . $rowData['field_order'] . '<br />';
1392 1392
 
1393 1393
 						if ($rowData['field_order'] > 1)
1394
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1394
+							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="' . $txt['custom_edit_order_move'] . ' ' . $txt['custom_edit_order_up'] . '"></span></a>';
1395 1395
 
1396 1396
 						if ($rowData['field_order'] < $context['custFieldsMaxOrder'])
1397
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1397
+							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="' . $txt['custom_edit_order_move'] . ' ' . $txt['custom_edit_order_down'] . '"></span></a>';
1398 1398
 
1399 1399
 						$return .= '</p>';
1400 1400
 
@@ -1412,7 +1412,7 @@  discard block
 block discarded – undo
1412 1412
 					'value' => $txt['custom_profile_fieldname'],
1413 1413
 				),
1414 1414
 				'data' => array(
1415
-					'function' => function ($rowData) use ($scripturl)
1415
+					'function' => function($rowData) use ($scripturl)
1416 1416
 					{
1417 1417
 						return sprintf('<a href="%1$s?action=admin;area=featuresettings;sa=profileedit;fid=%2$d">%3$s</a><div class="smalltext">%4$s</div>', $scripturl, $rowData['id_field'], $rowData['field_name'], $rowData['field_desc']);
1418 1418
 					},
@@ -1428,7 +1428,7 @@  discard block
 block discarded – undo
1428 1428
 					'value' => $txt['custom_profile_fieldtype'],
1429 1429
 				),
1430 1430
 				'data' => array(
1431
-					'function' => function ($rowData) use ($txt)
1431
+					'function' => function($rowData) use ($txt)
1432 1432
 					{
1433 1433
 						$textKey = sprintf('custom_profile_type_%1$s', $rowData['field_type']);
1434 1434
 						return isset($txt[$textKey]) ? $txt[$textKey] : $textKey;
@@ -1446,7 +1446,7 @@  discard block
 block discarded – undo
1446 1446
 					'value' => $txt['custom_profile_active'],
1447 1447
 				),
1448 1448
 				'data' => array(
1449
-					'function' => function ($rowData) use ($txt)
1449
+					'function' => function($rowData) use ($txt)
1450 1450
 					{
1451 1451
 						return $rowData['active'] ? $txt['yes'] : $txt['no'];
1452 1452
 					},
@@ -1463,7 +1463,7 @@  discard block
 block discarded – undo
1463 1463
 					'value' => $txt['custom_profile_placement'],
1464 1464
 				),
1465 1465
 				'data' => array(
1466
-					'function' => function ($rowData)
1466
+					'function' => function($rowData)
1467 1467
 					{
1468 1468
 						global $txt, $context;
1469 1469
 
@@ -1698,7 +1698,7 @@  discard block
 block discarded – undo
1698 1698
 			redirectexit('action=admin;area=featuresettings;sa=profile'); // @todo implement an error handler
1699 1699
 
1700 1700
 		// All good, proceed.
1701
-		$smcFunc['db_query']('','
1701
+		$smcFunc['db_query']('', '
1702 1702
 			UPDATE {db_prefix}custom_fields
1703 1703
 			SET field_order = {int:old_order}
1704 1704
 			WHERE field_order = {int:new_order}',
@@ -1707,7 +1707,7 @@  discard block
 block discarded – undo
1707 1707
 				'old_order' => $context['field']['order'],
1708 1708
 			)
1709 1709
 		);
1710
-		$smcFunc['db_query']('','
1710
+		$smcFunc['db_query']('', '
1711 1711
 			UPDATE {db_prefix}custom_fields
1712 1712
 			SET field_order = {int:new_order}
1713 1713
 			WHERE id_field = {int:id_field}',
@@ -1809,7 +1809,7 @@  discard block
 block discarded – undo
1809 1809
 			$smcFunc['db_free_result']($request);
1810 1810
 
1811 1811
 			$unique = false;
1812
-			for ($i = 0; !$unique && $i < 9; $i ++)
1812
+			for ($i = 0; !$unique && $i < 9; $i++)
1813 1813
 			{
1814 1814
 				if (!in_array($col_name, $current_fields))
1815 1815
 					$unique = true;
@@ -1982,7 +1982,7 @@  discard block
 block discarded – undo
1982 1982
 		);
1983 1983
 
1984 1984
 		// Re-arrange the order.
1985
-		$smcFunc['db_query']('','
1985
+		$smcFunc['db_query']('', '
1986 1986
 			UPDATE {db_prefix}custom_fields
1987 1987
 			SET field_order = field_order - 1
1988 1988
 			WHERE field_order > {int:current_order}',
@@ -2246,7 +2246,7 @@  discard block
 block discarded – undo
2246 2246
 	$context['token_check'] = 'noti-admin';
2247 2247
 
2248 2248
 	// Specify our action since we'll want to post back here instead of the profile
2249
-	$context['action'] = 'action=admin;area=featuresettings;sa=alerts;'. $context['session_var'] .'='. $context['session_id'];
2249
+	$context['action'] = 'action=admin;area=featuresettings;sa=alerts;' . $context['session_var'] . '=' . $context['session_id'];
2250 2250
 
2251 2251
 	loadTemplate('Profile');
2252 2252
 	loadLanguage('Profile');
Please login to merge, or discard this patch.
Braces   +273 added lines, -199 removed lines patch added patch discarded remove patch
@@ -14,8 +14,9 @@  discard block
 block discarded – undo
14 14
  * @version 2.1 Beta 4
15 15
  */
16 16
 
17
-if (!defined('SMF'))
17
+if (!defined('SMF')) {
18 18
 	die('No direct access...');
19
+}
19 20
 
20 21
 /**
21 22
  * This function makes sure the requested subaction does exists, if it doesn't, it sets a default action or.
@@ -206,16 +207,18 @@  discard block
 block discarded – undo
206 207
 	{
207 208
 		$all_zones = timezone_identifiers_list();
208 209
 		// Make sure we set the value to the same as the printed value.
209
-		foreach ($all_zones as $zone)
210
-			$config_vars['default_timezone'][2][$zone] = $zone;
210
+		foreach ($all_zones as $zone) {
211
+					$config_vars['default_timezone'][2][$zone] = $zone;
212
+		}
213
+	} else {
214
+			unset($config_vars['default_timezone']);
211 215
 	}
212
-	else
213
-		unset($config_vars['default_timezone']);
214 216
 
215 217
 	call_integration_hook('integrate_modify_basic_settings', array(&$config_vars));
216 218
 
217
-	if ($return_config)
218
-		return $config_vars;
219
+	if ($return_config) {
220
+			return $config_vars;
221
+	}
219 222
 
220 223
 	// Saving?
221 224
 	if (isset($_GET['save']))
@@ -223,8 +226,9 @@  discard block
 block discarded – undo
223 226
 		checkSession();
224 227
 
225 228
 		// Prevent absurd boundaries here - make it a day tops.
226
-		if (isset($_POST['lastActive']))
227
-			$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
229
+		if (isset($_POST['lastActive'])) {
230
+					$_POST['lastActive'] = min((int) $_POST['lastActive'], 1440);
231
+		}
228 232
 
229 233
 		call_integration_hook('integrate_save_basic_settings');
230 234
 
@@ -269,8 +273,9 @@  discard block
 block discarded – undo
269 273
 
270 274
 	call_integration_hook('integrate_modify_bbc_settings', array(&$config_vars));
271 275
 
272
-	if ($return_config)
273
-		return $config_vars;
276
+	if ($return_config) {
277
+			return $config_vars;
278
+	}
274 279
 
275 280
 	// Setup the template.
276 281
 	require_once($sourcedir . '/ManageServer.php');
@@ -287,13 +292,15 @@  discard block
 block discarded – undo
287 292
 
288 293
 		// Clean up the tags.
289 294
 		$bbcTags = array();
290
-		foreach (parse_bbc(false) as $tag)
291
-			$bbcTags[] = $tag['tag'];
295
+		foreach (parse_bbc(false) as $tag) {
296
+					$bbcTags[] = $tag['tag'];
297
+		}
292 298
 
293
-		if (!isset($_POST['disabledBBC_enabledTags']))
294
-			$_POST['disabledBBC_enabledTags'] = array();
295
-		elseif (!is_array($_POST['disabledBBC_enabledTags']))
296
-			$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
299
+		if (!isset($_POST['disabledBBC_enabledTags'])) {
300
+					$_POST['disabledBBC_enabledTags'] = array();
301
+		} elseif (!is_array($_POST['disabledBBC_enabledTags'])) {
302
+					$_POST['disabledBBC_enabledTags'] = array($_POST['disabledBBC_enabledTags']);
303
+		}
297 304
 		// Work out what is actually disabled!
298 305
 		$_POST['disabledBBC'] = implode(',', array_diff($bbcTags, $_POST['disabledBBC_enabledTags']));
299 306
 
@@ -337,8 +344,9 @@  discard block
 block discarded – undo
337 344
 
338 345
 	call_integration_hook('integrate_layout_settings', array(&$config_vars));
339 346
 
340
-	if ($return_config)
341
-		return $config_vars;
347
+	if ($return_config) {
348
+			return $config_vars;
349
+	}
342 350
 
343 351
 	// Saving?
344 352
 	if (isset($_GET['save']))
@@ -379,8 +387,9 @@  discard block
 block discarded – undo
379 387
 
380 388
 	call_integration_hook('integrate_likes_settings', array(&$config_vars));
381 389
 
382
-	if ($return_config)
383
-		return $config_vars;
390
+	if ($return_config) {
391
+			return $config_vars;
392
+	}
384 393
 
385 394
 	// Saving?
386 395
 	if (isset($_GET['save']))
@@ -418,8 +427,9 @@  discard block
 block discarded – undo
418 427
 
419 428
 	call_integration_hook('integrate_mentions_settings', array(&$config_vars));
420 429
 
421
-	if ($return_config)
422
-		return $config_vars;
430
+	if ($return_config) {
431
+			return $config_vars;
432
+	}
423 433
 
424 434
 	// Saving?
425 435
 	if (isset($_GET['save']))
@@ -463,8 +473,8 @@  discard block
 block discarded – undo
463 473
 			'enable' => array('check', 'warning_enable'),
464 474
 	);
465 475
 
466
-	if (!empty($modSettings['warning_settings']) && $currently_enabled)
467
-		$config_vars += array(
476
+	if (!empty($modSettings['warning_settings']) && $currently_enabled) {
477
+			$config_vars += array(
468 478
 			'',
469 479
 				array('int', 'warning_watch', 'subtext' => $txt['setting_warning_watch_note'] . ' ' . $txt['zero_to_disable']),
470 480
 				'moderate' => array('int', 'warning_moderate', 'subtext' => $txt['setting_warning_moderate_note'] . ' ' . $txt['zero_to_disable']),
@@ -473,15 +483,18 @@  discard block
 block discarded – undo
473 483
 				'rem2' => array('int', 'warning_decrement', 'subtext' => $txt['setting_warning_decrement_note'] . ' ' . $txt['zero_to_disable']),
474 484
 				array('permissions', 'view_warning'),
475 485
 		);
486
+	}
476 487
 
477 488
 	call_integration_hook('integrate_warning_settings', array(&$config_vars));
478 489
 
479
-	if ($return_config)
480
-		return $config_vars;
490
+	if ($return_config) {
491
+			return $config_vars;
492
+	}
481 493
 
482 494
 	// Cannot use moderation if post moderation is not enabled.
483
-	if (!$modSettings['postmod_active'])
484
-		unset($config_vars['moderate']);
495
+	if (!$modSettings['postmod_active']) {
496
+			unset($config_vars['moderate']);
497
+	}
485 498
 
486 499
 	// Will need the utility functions from here.
487 500
 	require_once($sourcedir . '/ManageServer.php');
@@ -506,16 +519,16 @@  discard block
 block discarded – undo
506 519
 				'warning_watch' => 10,
507 520
 				'warning_mute' => 60,
508 521
 			);
509
-			if ($modSettings['postmod_active'])
510
-				$vars['warning_moderate'] = 35;
522
+			if ($modSettings['postmod_active']) {
523
+							$vars['warning_moderate'] = 35;
524
+			}
511 525
 
512 526
 			foreach ($vars as $var => $value)
513 527
 			{
514 528
 				$config_vars[] = array('int', $var);
515 529
 				$_POST[$var] = $value;
516 530
 			}
517
-		}
518
-		else
531
+		} else
519 532
 		{
520 533
 			$_POST['warning_watch'] = min($_POST['warning_watch'], 100);
521 534
 			$_POST['warning_moderate'] = $modSettings['postmod_active'] ? min($_POST['warning_moderate'], 100) : 0;
@@ -603,8 +616,9 @@  discard block
 block discarded – undo
603 616
 
604 617
 	call_integration_hook('integrate_spam_settings', array(&$config_vars));
605 618
 
606
-	if ($return_config)
607
-		return $config_vars;
619
+	if ($return_config) {
620
+			return $config_vars;
621
+	}
608 622
 
609 623
 	// You need to be an admin to edit settings!
610 624
 	isAllowedTo('admin_forum');
@@ -638,8 +652,9 @@  discard block
 block discarded – undo
638 652
 
639 653
 	if (empty($context['qa_by_lang'][strtr($language, array('-utf8' => ''))]) && !empty($context['question_answers']))
640 654
 	{
641
-		if (empty($context['settings_insert_above']))
642
-			$context['settings_insert_above'] = '';
655
+		if (empty($context['settings_insert_above'])) {
656
+					$context['settings_insert_above'] = '';
657
+		}
643 658
 
644 659
 		$context['settings_insert_above'] .= '<div class="noticebox">' . sprintf($txt['question_not_defined'], $context['languages'][$language]['name']) . '</div>';
645 660
 	}
@@ -682,8 +697,9 @@  discard block
 block discarded – undo
682 697
 		$_POST['pm_spam_settings'] = (int) $_POST['max_pm_recipients'] . ',' . (int) $_POST['pm_posts_verification'] . ',' . (int) $_POST['pm_posts_per_hour'];
683 698
 
684 699
 		// Hack in guest requiring verification!
685
-		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha']))
686
-			$_POST['posts_require_captcha'] = -1;
700
+		if (empty($_POST['posts_require_captcha']) && !empty($_POST['guests_require_captcha'])) {
701
+					$_POST['posts_require_captcha'] = -1;
702
+		}
687 703
 
688 704
 		$save_vars = $config_vars;
689 705
 		unset($save_vars['pm1'], $save_vars['pm2'], $save_vars['pm3'], $save_vars['guest_verify']);
@@ -700,14 +716,16 @@  discard block
 block discarded – undo
700 716
 		foreach ($context['qa_languages'] as $lang_id => $dummy)
701 717
 		{
702 718
 			// If we had some questions for this language before, but don't now, delete everything from that language.
703
-			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id]))
704
-				$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
719
+			if ((!isset($_POST['question'][$lang_id]) || !is_array($_POST['question'][$lang_id])) && !empty($context['qa_by_lang'][$lang_id])) {
720
+							$changes['delete'] = array_merge($questions['delete'], $context['qa_by_lang'][$lang_id]);
721
+			}
705 722
 
706 723
 			// Now step through and see if any existing questions no longer exist.
707
-			if (!empty($context['qa_by_lang'][$lang_id]))
708
-				foreach ($context['qa_by_lang'][$lang_id] as $q_id)
724
+			if (!empty($context['qa_by_lang'][$lang_id])) {
725
+							foreach ($context['qa_by_lang'][$lang_id] as $q_id)
709 726
 					if (empty($_POST['question'][$lang_id][$q_id]))
710 727
 						$changes['delete'][] = $q_id;
728
+			}
711 729
 
712 730
 			// Now let's see if there are new questions or ones that need updating.
713 731
 			if (isset($_POST['question'][$lang_id]))
@@ -716,14 +734,16 @@  discard block
 block discarded – undo
716 734
 				{
717 735
 					// Ignore junky ids.
718 736
 					$q_id = (int) $q_id;
719
-					if ($q_id <= 0)
720
-						continue;
737
+					if ($q_id <= 0) {
738
+											continue;
739
+					}
721 740
 
722 741
 					// Check the question isn't empty (because they want to delete it?)
723 742
 					if (empty($question) || trim($question) == '')
724 743
 					{
725
-						if (isset($context['question_answers'][$q_id]))
726
-							$changes['delete'][] = $q_id;
744
+						if (isset($context['question_answers'][$q_id])) {
745
+													$changes['delete'][] = $q_id;
746
+						}
727 747
 						continue;
728 748
 					}
729 749
 					$question = $smcFunc['htmlspecialchars'](trim($question));
@@ -731,19 +751,22 @@  discard block
 block discarded – undo
731 751
 					// Get the answers. Firstly check there actually might be some.
732 752
 					if (!isset($_POST['answer'][$lang_id][$q_id]) || !is_array($_POST['answer'][$lang_id][$q_id]))
733 753
 					{
734
-						if (isset($context['question_answers'][$q_id]))
735
-							$changes['delete'][] = $q_id;
754
+						if (isset($context['question_answers'][$q_id])) {
755
+													$changes['delete'][] = $q_id;
756
+						}
736 757
 						continue;
737 758
 					}
738 759
 					// Now get them and check that they might be viable.
739 760
 					$answers = array();
740
-					foreach ($_POST['answer'][$lang_id][$q_id] as $answer)
741
-						if (!empty($answer) && trim($answer) !== '')
761
+					foreach ($_POST['answer'][$lang_id][$q_id] as $answer) {
762
+											if (!empty($answer) && trim($answer) !== '')
742 763
 							$answers[] = $smcFunc['htmlspecialchars'](trim($answer));
764
+					}
743 765
 					if (empty($answers))
744 766
 					{
745
-						if (isset($context['question_answers'][$q_id]))
746
-							$changes['delete'][] = $q_id;
767
+						if (isset($context['question_answers'][$q_id])) {
768
+													$changes['delete'][] = $q_id;
769
+						}
747 770
 						continue;
748 771
 					}
749 772
 					$answers = $smcFunc['json_encode']($answers);
@@ -753,16 +776,17 @@  discard block
 block discarded – undo
753 776
 					{
754 777
 						// New question. Now, we don't want to randomly consume ids, so we'll set those, rather than trusting the browser's supplied ids.
755 778
 						$changes['insert'][] = array($lang_id, $question, $answers);
756
-					}
757
-					else
779
+					} else
758 780
 					{
759 781
 						// It's an existing question. Let's see what's changed, if anything.
760
-						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers'])
761
-							$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
782
+						if ($lang_id != $context['question_answers'][$q_id]['lngfile'] || $question != $context['question_answers'][$q_id]['question'] || $answers != $context['question_answers'][$q_id]['answers']) {
783
+													$changes['replace'][$q_id] = array('lngfile' => $lang_id, 'question' => $question, 'answers' => $answers);
784
+						}
762 785
 					}
763 786
 
764
-					if (!isset($qs_per_lang[$lang_id]))
765
-						$qs_per_lang[$lang_id] = 0;
787
+					if (!isset($qs_per_lang[$lang_id])) {
788
+											$qs_per_lang[$lang_id] = 0;
789
+					}
766 790
 					$qs_per_lang[$lang_id]++;
767 791
 				}
768 792
 			}
@@ -812,8 +836,9 @@  discard block
 block discarded – undo
812 836
 
813 837
 		// Lastly, the count of messages needs to be no more than the lowest number of questions for any one language.
814 838
 		$count_questions = empty($qs_per_lang) ? 0 : min($qs_per_lang);
815
-		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions)
816
-			$_POST['qa_verification_number'] = $count_questions;
839
+		if (empty($count_questions) || $_POST['qa_verification_number'] > $count_questions) {
840
+					$_POST['qa_verification_number'] = $count_questions;
841
+		}
817 842
 
818 843
 		call_integration_hook('integrate_save_spam_settings', array(&$save_vars));
819 844
 
@@ -828,24 +853,27 @@  discard block
 block discarded – undo
828 853
 
829 854
 	$character_range = array_merge(range('A', 'H'), array('K', 'M', 'N', 'P', 'R'), range('T', 'Y'));
830 855
 	$_SESSION['visual_verification_code'] = '';
831
-	for ($i = 0; $i < 6; $i++)
832
-		$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
856
+	for ($i = 0; $i < 6; $i++) {
857
+			$_SESSION['visual_verification_code'] .= $character_range[array_rand($character_range)];
858
+	}
833 859
 
834 860
 	// Some javascript for CAPTCHA.
835 861
 	$context['settings_post_javascript'] = '';
836
-	if ($context['use_graphic_library'])
837
-		$context['settings_post_javascript'] .= '
862
+	if ($context['use_graphic_library']) {
863
+			$context['settings_post_javascript'] .= '
838 864
 		function refreshImages()
839 865
 		{
840 866
 			var imageType = document.getElementById(\'visual_verification_type\').value;
841 867
 			document.getElementById(\'verification_image\').src = \'' . $context['verification_image_href'] . ';type=\' + imageType;
842 868
 		}';
869
+	}
843 870
 
844 871
 	// Show the image itself, or text saying we can't.
845
-	if ($context['use_graphic_library'])
846
-		$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
847
-	else
848
-		$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
872
+	if ($context['use_graphic_library']) {
873
+			$config_vars['vv']['postinput'] = '<br><img src="' . $context['verification_image_href'] . ';type=' . (empty($modSettings['visual_verification_type']) ? 0 : $modSettings['visual_verification_type']) . '" alt="' . $txt['setting_image_verification_sample'] . '" id="verification_image"><br>';
874
+	} else {
875
+			$config_vars['vv']['postinput'] = '<br><span class="smalltext">' . $txt['setting_image_verification_nogd'] . '</span>';
876
+	}
849 877
 
850 878
 	// Hack for PM spam settings.
851 879
 	list ($modSettings['max_pm_recipients'], $modSettings['pm_posts_verification'], $modSettings['pm_posts_per_hour']) = explode(',', $modSettings['pm_spam_settings']);
@@ -855,9 +883,10 @@  discard block
 block discarded – undo
855 883
 	$modSettings['posts_require_captcha'] = !isset($modSettings['posts_require_captcha']) || $modSettings['posts_require_captcha'] == -1 ? 0 : $modSettings['posts_require_captcha'];
856 884
 
857 885
 	// Some minor javascript for the guest post setting.
858
-	if ($modSettings['posts_require_captcha'])
859
-		$context['settings_post_javascript'] .= '
886
+	if ($modSettings['posts_require_captcha']) {
887
+			$context['settings_post_javascript'] .= '
860 888
 		document.getElementById(\'guests_require_captcha\').disabled = true;';
889
+	}
861 890
 
862 891
 	// And everything else.
863 892
 	$context['post_url'] = $scripturl . '?action=admin;area=antispam;save';
@@ -904,8 +933,9 @@  discard block
 block discarded – undo
904 933
 
905 934
 	call_integration_hook('integrate_signature_settings', array(&$config_vars));
906 935
 
907
-	if ($return_config)
908
-		return $config_vars;
936
+	if ($return_config) {
937
+			return $config_vars;
938
+	}
909 939
 
910 940
 	// Setup the template.
911 941
 	$context['page_title'] = $txt['signature_settings'];
@@ -960,8 +990,9 @@  discard block
 block discarded – undo
960 990
 				$sig = strtr($row['signature'], array('<br>' => "\n"));
961 991
 
962 992
 				// Max characters...
963
-				if (!empty($sig_limits[1]))
964
-					$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
993
+				if (!empty($sig_limits[1])) {
994
+									$sig = $smcFunc['substr']($sig, 0, $sig_limits[1]);
995
+				}
965 996
 				// Max lines...
966 997
 				if (!empty($sig_limits[2]))
967 998
 				{
@@ -971,8 +1002,9 @@  discard block
 block discarded – undo
971 1002
 						if ($sig[$i] == "\n")
972 1003
 						{
973 1004
 							$count++;
974
-							if ($count >= $sig_limits[2])
975
-								$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1005
+							if ($count >= $sig_limits[2]) {
1006
+															$sig = substr($sig, 0, $i) . strtr(substr($sig, $i), array("\n" => ' '));
1007
+							}
976 1008
 						}
977 1009
 					}
978 1010
 				}
@@ -983,17 +1015,19 @@  discard block
 block discarded – undo
983 1015
 					{
984 1016
 						$limit_broke = 0;
985 1017
 						// Attempt to allow all sizes of abuse, so to speak.
986
-						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7])
987
-							$limit_broke = $sig_limits[7] . 'px';
988
-						elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75))
989
-							$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
990
-						elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16))
991
-							$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
992
-						elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18)
993
-							$limit_broke = 'large';
994
-
995
-						if ($limit_broke)
996
-							$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1018
+						if ($matches[2][$ind] == 'px' && $size > $sig_limits[7]) {
1019
+													$limit_broke = $sig_limits[7] . 'px';
1020
+						} elseif ($matches[2][$ind] == 'pt' && $size > ($sig_limits[7] * 0.75)) {
1021
+													$limit_broke = ((int) $sig_limits[7] * 0.75) . 'pt';
1022
+						} elseif ($matches[2][$ind] == 'em' && $size > ((float) $sig_limits[7] / 16)) {
1023
+													$limit_broke = ((float) $sig_limits[7] / 16) . 'em';
1024
+						} elseif ($matches[2][$ind] != 'px' && $matches[2][$ind] != 'pt' && $matches[2][$ind] != 'em' && $sig_limits[7] < 18) {
1025
+													$limit_broke = 'large';
1026
+						}
1027
+
1028
+						if ($limit_broke) {
1029
+													$sig = str_replace($matches[0][$ind], '[size=' . $sig_limits[7] . 'px', $sig);
1030
+						}
997 1031
 					}
998 1032
 				}
999 1033
 
@@ -1049,32 +1083,34 @@  discard block
 block discarded – undo
1049 1083
 											$img_offset = false;
1050 1084
 										}
1051 1085
 									}
1086
+								} else {
1087
+																	$replaces[$image] = '';
1052 1088
 								}
1053
-								else
1054
-									$replaces[$image] = '';
1055 1089
 
1056 1090
 								continue;
1057 1091
 							}
1058 1092
 
1059 1093
 							// Does it have predefined restraints? Width first.
1060
-							if ($matches[6][$key])
1061
-								$matches[2][$key] = $matches[6][$key];
1094
+							if ($matches[6][$key]) {
1095
+															$matches[2][$key] = $matches[6][$key];
1096
+							}
1062 1097
 							if ($matches[2][$key] && $sig_limits[5] && $matches[2][$key] > $sig_limits[5])
1063 1098
 							{
1064 1099
 								$width = $sig_limits[5];
1065 1100
 								$matches[4][$key] = $matches[4][$key] * ($width / $matches[2][$key]);
1101
+							} elseif ($matches[2][$key]) {
1102
+															$width = $matches[2][$key];
1066 1103
 							}
1067
-							elseif ($matches[2][$key])
1068
-								$width = $matches[2][$key];
1069 1104
 							// ... and height.
1070 1105
 							if ($matches[4][$key] && $sig_limits[6] && $matches[4][$key] > $sig_limits[6])
1071 1106
 							{
1072 1107
 								$height = $sig_limits[6];
1073
-								if ($width != -1)
1074
-									$width = $width * ($height / $matches[4][$key]);
1108
+								if ($width != -1) {
1109
+																	$width = $width * ($height / $matches[4][$key]);
1110
+								}
1111
+							} elseif ($matches[4][$key]) {
1112
+															$height = $matches[4][$key];
1075 1113
 							}
1076
-							elseif ($matches[4][$key])
1077
-								$height = $matches[4][$key];
1078 1114
 
1079 1115
 							// If the dimensions are still not fixed - we need to check the actual image.
1080 1116
 							if (($width == -1 && $sig_limits[5]) || ($height == -1 && $sig_limits[6]))
@@ -1092,12 +1128,13 @@  discard block
 block discarded – undo
1092 1128
 									if ($sizes[1] > $sig_limits[6] && $sig_limits[6])
1093 1129
 									{
1094 1130
 										$height = $sig_limits[6];
1095
-										if ($width == -1)
1096
-											$width = $sizes[0];
1131
+										if ($width == -1) {
1132
+																					$width = $sizes[0];
1133
+										}
1097 1134
 										$width = $width * ($height / $sizes[1]);
1135
+									} elseif ($width != -1) {
1136
+																			$height = $sizes[1];
1098 1137
 									}
1099
-									elseif ($width != -1)
1100
-										$height = $sizes[1];
1101 1138
 								}
1102 1139
 							}
1103 1140
 
@@ -1110,8 +1147,9 @@  discard block
 block discarded – undo
1110 1147
 							// Record that we got one.
1111 1148
 							$image_count_holder[$image] = isset($image_count_holder[$image]) ? $image_count_holder[$image] + 1 : 1;
1112 1149
 						}
1113
-						if (!empty($replaces))
1114
-							$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1150
+						if (!empty($replaces)) {
1151
+													$sig = str_replace(array_keys($replaces), array_values($replaces), $sig);
1152
+						}
1115 1153
 					}
1116 1154
 				}
1117 1155
 				// Try to fix disabled tags.
@@ -1123,18 +1161,20 @@  discard block
 block discarded – undo
1123 1161
 
1124 1162
 				$sig = strtr($sig, array("\n" => '<br>'));
1125 1163
 				call_integration_hook('integrate_apply_signature_settings', array(&$sig, $sig_limits, $disabledTags));
1126
-				if ($sig != $row['signature'])
1127
-					$changes[$row['id_member']] = $sig;
1164
+				if ($sig != $row['signature']) {
1165
+									$changes[$row['id_member']] = $sig;
1166
+				}
1167
+			}
1168
+			if ($smcFunc['db_num_rows']($request) == 0) {
1169
+							$done = true;
1128 1170
 			}
1129
-			if ($smcFunc['db_num_rows']($request) == 0)
1130
-				$done = true;
1131 1171
 			$smcFunc['db_free_result']($request);
1132 1172
 
1133 1173
 			// Do we need to delete what we have?
1134 1174
 			if (!empty($changes))
1135 1175
 			{
1136
-				foreach ($changes as $id => $sig)
1137
-					$smcFunc['db_query']('', '
1176
+				foreach ($changes as $id => $sig) {
1177
+									$smcFunc['db_query']('', '
1138 1178
 						UPDATE {db_prefix}members
1139 1179
 						SET signature = {string:signature}
1140 1180
 						WHERE id_member = {int:id_member}',
@@ -1143,11 +1183,13 @@  discard block
 block discarded – undo
1143 1183
 							'signature' => $sig,
1144 1184
 						)
1145 1185
 					);
1186
+				}
1146 1187
 			}
1147 1188
 
1148 1189
 			$_GET['step'] += 50;
1149
-			if (!$done)
1150
-				pauseSignatureApplySettings();
1190
+			if (!$done) {
1191
+							pauseSignatureApplySettings();
1192
+			}
1151 1193
 		}
1152 1194
 		$settings_applied = true;
1153 1195
 	}
@@ -1165,8 +1207,9 @@  discard block
 block discarded – undo
1165 1207
 	);
1166 1208
 
1167 1209
 	// Temporarily make each setting a modSetting!
1168
-	foreach ($context['signature_settings'] as $key => $value)
1169
-		$modSettings['signature_' . $key] = $value;
1210
+	foreach ($context['signature_settings'] as $key => $value) {
1211
+			$modSettings['signature_' . $key] = $value;
1212
+	}
1170 1213
 
1171 1214
 	// Make sure we check the right tags!
1172 1215
 	$modSettings['bbc_disabled_signature_bbc'] = $disabledTags;
@@ -1178,23 +1221,26 @@  discard block
 block discarded – undo
1178 1221
 
1179 1222
 		// Clean up the tag stuff!
1180 1223
 		$bbcTags = array();
1181
-		foreach (parse_bbc(false) as $tag)
1182
-			$bbcTags[] = $tag['tag'];
1224
+		foreach (parse_bbc(false) as $tag) {
1225
+					$bbcTags[] = $tag['tag'];
1226
+		}
1183 1227
 
1184
-		if (!isset($_POST['signature_bbc_enabledTags']))
1185
-			$_POST['signature_bbc_enabledTags'] = array();
1186
-		elseif (!is_array($_POST['signature_bbc_enabledTags']))
1187
-			$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1228
+		if (!isset($_POST['signature_bbc_enabledTags'])) {
1229
+					$_POST['signature_bbc_enabledTags'] = array();
1230
+		} elseif (!is_array($_POST['signature_bbc_enabledTags'])) {
1231
+					$_POST['signature_bbc_enabledTags'] = array($_POST['signature_bbc_enabledTags']);
1232
+		}
1188 1233
 
1189 1234
 		$sig_limits = array();
1190 1235
 		foreach ($context['signature_settings'] as $key => $value)
1191 1236
 		{
1192
-			if ($key == 'allow_smileys')
1193
-				continue;
1194
-			elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys']))
1195
-				$sig_limits[] = -1;
1196
-			else
1197
-				$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1237
+			if ($key == 'allow_smileys') {
1238
+							continue;
1239
+			} elseif ($key == 'max_smileys' && empty($_POST['signature_allow_smileys'])) {
1240
+							$sig_limits[] = -1;
1241
+			} else {
1242
+							$sig_limits[] = !empty($_POST['signature_' . $key]) ? max(1, (int) $_POST['signature_' . $key]) : 0;
1243
+			}
1198 1244
 		}
1199 1245
 
1200 1246
 		call_integration_hook('integrate_save_signature_settings', array(&$sig_limits, &$bbcTags));
@@ -1227,12 +1273,14 @@  discard block
 block discarded – undo
1227 1273
 
1228 1274
 	// Try get more time...
1229 1275
 	@set_time_limit(600);
1230
-	if (function_exists('apache_reset_timeout'))
1231
-		@apache_reset_timeout();
1276
+	if (function_exists('apache_reset_timeout')) {
1277
+			@apache_reset_timeout();
1278
+	}
1232 1279
 
1233 1280
 	// Have we exhausted all the time we allowed?
1234
-	if (time() - array_sum(explode(' ', $sig_start)) < 3)
1235
-		return;
1281
+	if (time() - array_sum(explode(' ', $sig_start)) < 3) {
1282
+			return;
1283
+	}
1236 1284
 
1237 1285
 	$context['continue_get_data'] = '?action=admin;area=featuresettings;sa=sig;apply;step=' . $_GET['step'] . ';' . $context['session_var'] . '=' . $context['session_id'];
1238 1286
 	$context['page_title'] = $txt['not_done_title'];
@@ -1278,9 +1326,10 @@  discard block
 block discarded – undo
1278 1326
 		$disable_fields = array_flip($standard_fields);
1279 1327
 		if (!empty($_POST['active']))
1280 1328
 		{
1281
-			foreach ($_POST['active'] as $value)
1282
-				if (isset($disable_fields[$value]))
1329
+			foreach ($_POST['active'] as $value) {
1330
+							if (isset($disable_fields[$value]))
1283 1331
 					unset($disable_fields[$value]);
1332
+			}
1284 1333
 		}
1285 1334
 		// What we have left!
1286 1335
 		$changes['disabled_profile_fields'] = empty($disable_fields) ? '' : implode(',', array_keys($disable_fields));
@@ -1289,16 +1338,18 @@  discard block
 block discarded – undo
1289 1338
 		$reg_fields = array();
1290 1339
 		if (!empty($_POST['reg']))
1291 1340
 		{
1292
-			foreach ($_POST['reg'] as $value)
1293
-				if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1341
+			foreach ($_POST['reg'] as $value) {
1342
+							if (in_array($value, $standard_fields) && !isset($disable_fields[$value]))
1294 1343
 					$reg_fields[] = $value;
1344
+			}
1295 1345
 		}
1296 1346
 		// What we have left!
1297 1347
 		$changes['registration_fields'] = empty($reg_fields) ? '' : implode(',', $reg_fields);
1298 1348
 
1299 1349
 		$_SESSION['adm-save'] = true;
1300
-		if (!empty($changes))
1301
-			updateSettings($changes);
1350
+		if (!empty($changes)) {
1351
+					updateSettings($changes);
1352
+		}
1302 1353
 	}
1303 1354
 
1304 1355
 	createToken('admin-scp');
@@ -1401,11 +1452,13 @@  discard block
 block discarded – undo
1401 1452
 					{
1402 1453
 						$return = '<p class="centertext bold_text">'. $rowData['field_order'] .'<br />';
1403 1454
 
1404
-						if ($rowData['field_order'] > 1)
1405
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1455
+						if ($rowData['field_order'] > 1) {
1456
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=up"><span class="toggle_up" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_up'] .'"></span></a>';
1457
+						}
1406 1458
 
1407
-						if ($rowData['field_order'] < $context['custFieldsMaxOrder'])
1408
-							$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1459
+						if ($rowData['field_order'] < $context['custFieldsMaxOrder']) {
1460
+													$return .= '<a href="' . $scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $rowData['id_field'] . ';move=down"><span class="toggle_down" title="'. $txt['custom_edit_order_move'] .' '. $txt['custom_edit_order_down'] .'"></span></a>';
1461
+						}
1409 1462
 
1410 1463
 						$return .= '</p>';
1411 1464
 
@@ -1543,16 +1596,16 @@  discard block
 block discarded – undo
1543 1596
 		$disabled_fields = isset($modSettings['disabled_profile_fields']) ? explode(',', $modSettings['disabled_profile_fields']) : array();
1544 1597
 		$registration_fields = isset($modSettings['registration_fields']) ? explode(',', $modSettings['registration_fields']) : array();
1545 1598
 
1546
-		foreach ($standard_fields as $field)
1547
-			$list[] = array(
1599
+		foreach ($standard_fields as $field) {
1600
+					$list[] = array(
1548 1601
 				'id' => $field,
1549 1602
 				'label' => isset($txt['standard_profile_field_' . $field]) ? $txt['standard_profile_field_' . $field] : (isset($txt[$field]) ? $txt[$field] : $field),
1550 1603
 				'disabled' => in_array($field, $disabled_fields),
1551 1604
 				'on_register' => in_array($field, $registration_fields) && !in_array($field, $fields_no_registration),
1552 1605
 				'can_show_register' => !in_array($field, $fields_no_registration),
1553 1606
 			);
1554
-	}
1555
-	else
1607
+		}
1608
+	} else
1556 1609
 	{
1557 1610
 		// Load all the fields.
1558 1611
 		$request = $smcFunc['db_query']('', '
@@ -1566,8 +1619,9 @@  discard block
 block discarded – undo
1566 1619
 				'items_per_page' => $items_per_page,
1567 1620
 			)
1568 1621
 		);
1569
-		while ($row = $smcFunc['db_fetch_assoc']($request))
1570
-			$list[] = $row;
1622
+		while ($row = $smcFunc['db_fetch_assoc']($request)) {
1623
+					$list[] = $row;
1624
+		}
1571 1625
 		$smcFunc['db_free_result']($request);
1572 1626
 	}
1573 1627
 
@@ -1633,9 +1687,9 @@  discard block
 block discarded – undo
1633 1687
 		$context['field'] = array();
1634 1688
 		while ($row = $smcFunc['db_fetch_assoc']($request))
1635 1689
 		{
1636
-			if ($row['field_type'] == 'textarea')
1637
-				@list ($rows, $cols) = @explode(',', $row['default_value']);
1638
-			else
1690
+			if ($row['field_type'] == 'textarea') {
1691
+							@list ($rows, $cols) = @explode(',', $row['default_value']);
1692
+			} else
1639 1693
 			{
1640 1694
 				$rows = 3;
1641 1695
 				$cols = 30;
@@ -1671,8 +1725,8 @@  discard block
 block discarded – undo
1671 1725
 	}
1672 1726
 
1673 1727
 	// Setup the default values as needed.
1674
-	if (empty($context['field']))
1675
-		$context['field'] = array(
1728
+	if (empty($context['field'])) {
1729
+			$context['field'] = array(
1676 1730
 			'name' => '',
1677 1731
 			'col_name' => '???',
1678 1732
 			'desc' => '',
@@ -1697,6 +1751,7 @@  discard block
 block discarded – undo
1697 1751
 			'enclose' => '',
1698 1752
 			'placement' => 0,
1699 1753
 		);
1754
+	}
1700 1755
 
1701 1756
 	// Are we moving it?
1702 1757
 	if (isset($_GET['move']) && in_array($smcFunc['htmlspecialchars']($_GET['move']), $move_to))
@@ -1705,8 +1760,10 @@  discard block
 block discarded – undo
1705 1760
 		$new_order = ($_GET['move'] == 'up' ? ($context['field']['order'] - 1) : ($context['field']['order'] + 1));
1706 1761
 
1707 1762
 		// Is this a valid position?
1708
-		if ($new_order <= 0 || $new_order > $order_count)
1709
-			redirectexit('action=admin;area=featuresettings;sa=profile'); // @todo implement an error handler
1763
+		if ($new_order <= 0 || $new_order > $order_count) {
1764
+					redirectexit('action=admin;area=featuresettings;sa=profile');
1765
+		}
1766
+		// @todo implement an error handler
1710 1767
 
1711 1768
 		// All good, proceed.
1712 1769
 		$smcFunc['db_query']('','
@@ -1737,12 +1794,14 @@  discard block
 block discarded – undo
1737 1794
 		validateToken('admin-ecp');
1738 1795
 
1739 1796
 		// Everyone needs a name - even the (bracket) unknown...
1740
-		if (trim($_POST['field_name']) == '')
1741
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1797
+		if (trim($_POST['field_name']) == '') {
1798
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=need_name');
1799
+		}
1742 1800
 
1743 1801
 		// Regex you say?  Do a very basic test to see if the pattern is valid
1744
-		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false)
1745
-			redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1802
+		if (!empty($_POST['regex']) && @preg_match($_POST['regex'], 'dummy') === false) {
1803
+					redirectexit($scripturl . '?action=admin;area=featuresettings;sa=profileedit;fid=' . $_GET['fid'] . ';msg=regex_error');
1804
+		}
1746 1805
 
1747 1806
 		$_POST['field_name'] = $smcFunc['htmlspecialchars']($_POST['field_name']);
1748 1807
 		$_POST['field_desc'] = $smcFunc['htmlspecialchars']($_POST['field_desc']);
@@ -1759,8 +1818,9 @@  discard block
 block discarded – undo
1759 1818
 
1760 1819
 		// Some masking stuff...
1761 1820
 		$mask = isset($_POST['mask']) ? $_POST['mask'] : '';
1762
-		if ($mask == 'regex' && isset($_POST['regex']))
1763
-			$mask .= $_POST['regex'];
1821
+		if ($mask == 'regex' && isset($_POST['regex'])) {
1822
+					$mask .= $_POST['regex'];
1823
+		}
1764 1824
 
1765 1825
 		$field_length = isset($_POST['max_length']) ? (int) $_POST['max_length'] : 255;
1766 1826
 		$enclose = isset($_POST['enclose']) ? $_POST['enclose'] : '';
@@ -1779,8 +1839,9 @@  discard block
 block discarded – undo
1779 1839
 				$v = strtr($v, array(',' => ''));
1780 1840
 
1781 1841
 				// Nada, zip, etc...
1782
-				if (trim($v) == '')
1783
-					continue;
1842
+				if (trim($v) == '') {
1843
+									continue;
1844
+				}
1784 1845
 
1785 1846
 				// Otherwise, save it boy.
1786 1847
 				$field_options .= $v . ',';
@@ -1788,15 +1849,17 @@  discard block
 block discarded – undo
1788 1849
 				$newOptions[$k] = $v;
1789 1850
 
1790 1851
 				// Is it default?
1791
-				if (isset($_POST['default_select']) && $_POST['default_select'] == $k)
1792
-					$default = $v;
1852
+				if (isset($_POST['default_select']) && $_POST['default_select'] == $k) {
1853
+									$default = $v;
1854
+				}
1793 1855
 			}
1794 1856
 			$field_options = substr($field_options, 0, -1);
1795 1857
 		}
1796 1858
 
1797 1859
 		// Text area has default has dimensions
1798
-		if ($_POST['field_type'] == 'textarea')
1799
-			$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1860
+		if ($_POST['field_type'] == 'textarea') {
1861
+					$default = (int) $_POST['rows'] . ',' . (int) $_POST['cols'];
1862
+		}
1800 1863
 
1801 1864
 		// Come up with the unique name?
1802 1865
 		if (empty($context['fid']))
@@ -1805,32 +1868,36 @@  discard block
 block discarded – undo
1805 1868
 			preg_match('~([\w\d_-]+)~', $col_name, $matches);
1806 1869
 
1807 1870
 			// If there is nothing to the name, then let's start out own - for foreign languages etc.
1808
-			if (isset($matches[1]))
1809
-				$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1810
-			else
1811
-				$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1871
+			if (isset($matches[1])) {
1872
+							$col_name = $initial_col_name = 'cust_' . strtolower($matches[1]);
1873
+			} else {
1874
+							$col_name = $initial_col_name = 'cust_' . mt_rand(1, 9999);
1875
+			}
1812 1876
 
1813 1877
 			// Make sure this is unique.
1814 1878
 			$current_fields = array();
1815 1879
 			$request = $smcFunc['db_query']('', '
1816 1880
 				SELECT id_field, col_name
1817 1881
 				FROM {db_prefix}custom_fields');
1818
-			while ($row = $smcFunc['db_fetch_assoc']($request))
1819
-				$current_fields[$row['id_field']] = $row['col_name'];
1882
+			while ($row = $smcFunc['db_fetch_assoc']($request)) {
1883
+							$current_fields[$row['id_field']] = $row['col_name'];
1884
+			}
1820 1885
 			$smcFunc['db_free_result']($request);
1821 1886
 
1822 1887
 			$unique = false;
1823 1888
 			for ($i = 0; !$unique && $i < 9; $i ++)
1824 1889
 			{
1825
-				if (!in_array($col_name, $current_fields))
1826
-					$unique = true;
1827
-				else
1828
-					$col_name = $initial_col_name . $i;
1890
+				if (!in_array($col_name, $current_fields)) {
1891
+									$unique = true;
1892
+				} else {
1893
+									$col_name = $initial_col_name . $i;
1894
+				}
1829 1895
 			}
1830 1896
 
1831 1897
 			// Still not a unique column name? Leave it up to the user, then.
1832
-			if (!$unique)
1833
-				fatal_lang_error('custom_option_not_unique');
1898
+			if (!$unique) {
1899
+							fatal_lang_error('custom_option_not_unique');
1900
+			}
1834 1901
 		}
1835 1902
 		// Work out what to do with the user data otherwise...
1836 1903
 		else
@@ -1858,8 +1925,9 @@  discard block
 block discarded – undo
1858 1925
 				// Work out what's changed!
1859 1926
 				foreach ($context['field']['options'] as $k => $option)
1860 1927
 				{
1861
-					if (trim($option) == '')
1862
-						continue;
1928
+					if (trim($option) == '') {
1929
+											continue;
1930
+					}
1863 1931
 
1864 1932
 					// Still exists?
1865 1933
 					if (in_array($option, $newOptions))
@@ -1873,8 +1941,8 @@  discard block
 block discarded – undo
1873 1941
 				foreach ($optionChanges as $k => $option)
1874 1942
 				{
1875 1943
 					// Just been renamed?
1876
-					if (!in_array($k, $takenKeys) && !empty($newOptions[$k]))
1877
-						$smcFunc['db_query']('', '
1944
+					if (!in_array($k, $takenKeys) && !empty($newOptions[$k])) {
1945
+											$smcFunc['db_query']('', '
1878 1946
 							UPDATE {db_prefix}themes
1879 1947
 							SET value = {string:new_value}
1880 1948
 							WHERE variable = {string:current_column}
@@ -1887,6 +1955,7 @@  discard block
 block discarded – undo
1887 1955
 								'old_value' => $option,
1888 1956
 							)
1889 1957
 						);
1958
+					}
1890 1959
 				}
1891 1960
 			}
1892 1961
 			// @todo Maybe we should adjust based on new text length limits?
@@ -1929,8 +1998,8 @@  discard block
 block discarded – undo
1929 1998
 			);
1930 1999
 
1931 2000
 			// Just clean up any old selects - these are a pain!
1932
-			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions))
1933
-				$smcFunc['db_query']('', '
2001
+			if (($_POST['field_type'] == 'select' || $_POST['field_type'] == 'radio') && !empty($newOptions)) {
2002
+							$smcFunc['db_query']('', '
1934 2003
 					DELETE FROM {db_prefix}themes
1935 2004
 					WHERE variable = {string:current_column}
1936 2005
 						AND value NOT IN ({array_string:new_option_values})
@@ -1941,8 +2010,8 @@  discard block
 block discarded – undo
1941 2010
 						'current_column' => $context['field']['col_name'],
1942 2011
 					)
1943 2012
 				);
1944
-		}
1945
-		else
2013
+			}
2014
+		} else
1946 2015
 		{
1947 2016
 			// Gotta figure it out the order.
1948 2017
 			$new_order = $order_count > 1 ? ($order_count + 1) : 1;
@@ -2116,11 +2185,13 @@  discard block
 block discarded – undo
2116 2185
 	call_integration_hook('integrate_prune_settings', array(&$config_vars, &$prune_toggle, false));
2117 2186
 
2118 2187
 	$prune_toggle_dt = array();
2119
-	foreach ($prune_toggle as $item)
2120
-		$prune_toggle_dt[] = 'setting_' . $item;
2188
+	foreach ($prune_toggle as $item) {
2189
+			$prune_toggle_dt[] = 'setting_' . $item;
2190
+	}
2121 2191
 
2122
-	if ($return_config)
2123
-		return $config_vars;
2192
+	if ($return_config) {
2193
+			return $config_vars;
2194
+	}
2124 2195
 
2125 2196
 	addInlineJavaScript('
2126 2197
 	function togglePruned()
@@ -2158,15 +2229,16 @@  discard block
 block discarded – undo
2158 2229
 			$vals = array();
2159 2230
 			foreach ($config_vars as $index => $dummy)
2160 2231
 			{
2161
-				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle))
2162
-					continue;
2232
+				if (!is_array($dummy) || $index == 'pruningOptions' || !in_array($dummy[1], $prune_toggle)) {
2233
+									continue;
2234
+				}
2163 2235
 
2164 2236
 				$vals[] = empty($_POST[$dummy[1]]) || $_POST[$dummy[1]] < 0 ? 0 : (int) $_POST[$dummy[1]];
2165 2237
 			}
2166 2238
 			$_POST['pruningOptions'] = implode(',', $vals);
2239
+		} else {
2240
+					$_POST['pruningOptions'] = '';
2167 2241
 		}
2168
-		else
2169
-			$_POST['pruningOptions'] = '';
2170 2242
 
2171 2243
 		saveDBSettings($savevar);
2172 2244
 		$_SESSION['adm-save'] = true;
@@ -2178,10 +2250,11 @@  discard block
 block discarded – undo
2178 2250
 	$context['sub_template'] = 'show_settings';
2179 2251
 
2180 2252
 	// Get the actual values
2181
-	if (!empty($modSettings['pruningOptions']))
2182
-		@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2183
-	else
2184
-		$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2253
+	if (!empty($modSettings['pruningOptions'])) {
2254
+			@list ($modSettings['pruneErrorLog'], $modSettings['pruneModLog'], $modSettings['pruneBanLog'], $modSettings['pruneReportLog'], $modSettings['pruneScheduledTaskLog'], $modSettings['pruneSpiderHitLog']) = explode(',', $modSettings['pruningOptions']);
2255
+	} else {
2256
+			$modSettings['pruneErrorLog'] = $modSettings['pruneModLog'] = $modSettings['pruneBanLog'] = $modSettings['pruneReportLog'] = $modSettings['pruneScheduledTaskLog'] = $modSettings['pruneSpiderHitLog'] = 0;
2257
+	}
2185 2258
 
2186 2259
 	prepareDBSettingContext($config_vars);
2187 2260
 }
@@ -2203,8 +2276,9 @@  discard block
 block discarded – undo
2203 2276
 	// Make it even easier to add new settings.
2204 2277
 	call_integration_hook('integrate_general_mod_settings', array(&$config_vars));
2205 2278
 
2206
-	if ($return_config)
2207
-		return $config_vars;
2279
+	if ($return_config) {
2280
+			return $config_vars;
2281
+	}
2208 2282
 
2209 2283
 	$context['post_url'] = $scripturl . '?action=admin;area=modsettings;save;sa=general';
2210 2284
 	$context['settings_title'] = $txt['mods_cat_modifications_misc'];
Please login to merge, or discard this patch.