Passed
Push — release-2.1 ( 0e5bfc...908430 )
by Mathias
07:53 queued 12s
created
Sources/Display.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -1535,14 +1535,14 @@  discard block
 block discarded – undo
1535 1535
 	$output['quickbuttons'] = array(
1536 1536
 		'quote' => array(
1537 1537
 			'label' => $txt['quote_action'],
1538
-			'href' => $scripturl.'?action=post;quote='.$output['id'].';topic='.$context['current_topic'], '.'.$context['start'].';last_msg='.$context['topic_last_message'],
1539
-			'javascript' => 'onclick="return oQuickReply.quote('.$output['id'].');"',
1538
+			'href' => $scripturl . '?action=post;quote=' . $output['id'] . ';topic=' . $context['current_topic'], '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'],
1539
+			'javascript' => 'onclick="return oQuickReply.quote(' . $output['id'] . ');"',
1540 1540
 			'icon' => 'quote',
1541 1541
 			'show' => $context['can_quote']
1542 1542
 		),
1543 1543
 		'quote_selected' => array(
1544 1544
 			'label' => $txt['quote_selected_action'],
1545
-			'id' => 'quoteSelected_'. $output['id'],
1545
+			'id' => 'quoteSelected_' . $output['id'],
1546 1546
 			'href' => 'javascript:void(0)',
1547 1547
 			'custom' => 'style="display:none"',
1548 1548
 			'icon' => 'quote_selected',
@@ -1551,74 +1551,74 @@  discard block
 block discarded – undo
1551 1551
 		'quick_edit' => array(
1552 1552
 			'label' => $txt['quick_edit'],
1553 1553
 			'class' => 'quick_edit',
1554
-			'id' => 'modify_button_'. $output['id'],
1555
-			'custom' => 'onclick="oQuickModify.modifyMsg(\''.$output['id'].'\', \''.!empty($modSettings['toggle_subject']).'\')"',
1554
+			'id' => 'modify_button_' . $output['id'],
1555
+			'custom' => 'onclick="oQuickModify.modifyMsg(\'' . $output['id'] . '\', \'' . !empty($modSettings['toggle_subject']) . '\')"',
1556 1556
 			'icon' => 'quick_edit_button',
1557 1557
 			'show' => $output['can_modify']
1558 1558
 		),
1559 1559
 		'more' => array(
1560 1560
 			'modify' => array(
1561 1561
 				'label' => $txt['modify'],
1562
-				'href' => $scripturl.'?action=post;msg='.$output['id'].';topic='.$context['current_topic'].'.'.$context['start'],
1562
+				'href' => $scripturl . '?action=post;msg=' . $output['id'] . ';topic=' . $context['current_topic'] . '.' . $context['start'],
1563 1563
 				'icon' => 'modify_button',
1564 1564
 				'show' => $output['can_modify']
1565 1565
 			),
1566 1566
 			'remove_topic' => array(
1567 1567
 				'label' => $txt['remove_topic'],
1568
-				'href' => $scripturl.'?action=removetopic2;topic='.$context['current_topic'].'.'.$context['start'].';'.$context['session_var'].'='.$context['session_id'],
1569
-				'javascript' => 'data-confirm="'.$txt['are_sure_remove_topic'].'"',
1568
+				'href' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1569
+				'javascript' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"',
1570 1570
 				'class' => 'you_sure',
1571 1571
 				'icon' => 'remove_button',
1572 1572
 				'show' => $context['can_delete'] && ($context['topic_first_message'] == $output['id'])
1573 1573
 			),
1574 1574
 			'remove' => array(
1575 1575
 				'label' => $txt['remove'],
1576
-				'href' => $scripturl.'?action=deletemsg;topic='.$context['current_topic'].'.'.$context['start'].';msg='.$output['id'].';'.$context['session_var'].'='.$context['session_id'],
1577
-				'javascript' => 'data-confirm="'.$txt['remove_message_question'].'"',
1576
+				'href' => $scripturl . '?action=deletemsg;topic=' . $context['current_topic'] . '.' . $context['start'] . ';msg=' . $output['id'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1577
+				'javascript' => 'data-confirm="' . $txt['remove_message_question'] . '"',
1578 1578
 				'class' => 'you_sure',
1579 1579
 				'icon' => 'remove_button',
1580 1580
 				'show' => $output['can_remove'] && ($context['topic_first_message'] != $output['id'])
1581 1581
 			),
1582 1582
 			'split' => array(
1583 1583
 				'label' => $txt['split'],
1584
-				'href' => $scripturl.'?action=splittopics;topic='.$context['current_topic'].'.0;at='.$output['id'],
1584
+				'href' => $scripturl . '?action=splittopics;topic=' . $context['current_topic'] . '.0;at=' . $output['id'],
1585 1585
 				'icon' => 'split_button',
1586 1586
 				'show' => $context['can_split'] && !empty($context['real_num_replies'])
1587 1587
 			),
1588 1588
 			'report' => array(
1589 1589
 				'label' => $txt['report_to_mod'],
1590
-				'href' => $scripturl.'?action=reporttm;topic='.$context['current_topic'].'.'.$output['counter'].';msg='.$output['id'],
1590
+				'href' => $scripturl . '?action=reporttm;topic=' . $context['current_topic'] . '.' . $output['counter'] . ';msg=' . $output['id'],
1591 1591
 				'icon' => 'error',
1592 1592
 				'show' => $context['can_report_moderator']
1593 1593
 			),
1594 1594
 			'warn' => array(
1595 1595
 				'label' => $txt['issue_warning'],
1596
-				'href' => $scripturl.'?action=profile;area=issuewarning;u='.$output['member']['id'].';msg='.$output['id'],
1596
+				'href' => $scripturl . '?action=profile;area=issuewarning;u=' . $output['member']['id'] . ';msg=' . $output['id'],
1597 1597
 				'icon' => 'warn_button',
1598 1598
 				'show' => $context['can_issue_warning'] && !$output['is_message_author'] && !$output['member']['is_guest']
1599 1599
 			),
1600 1600
 			'restore' => array(
1601 1601
 				'label' => $txt['restore_message'],
1602
-				'href' => $scripturl.'?action=restoretopic;msgs='.$output['id'].';'.$context['session_var'].'='.$context['session_id'],
1602
+				'href' => $scripturl . '?action=restoretopic;msgs=' . $output['id'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1603 1603
 				'icon' => 'restore_button',
1604 1604
 				'show' => $context['can_restore_msg']
1605 1605
 			),
1606 1606
 			'approve' => array(
1607 1607
 				'label' => $txt['approve'],
1608
-				'href' => $scripturl.'?action=moderate;area=postmod;sa=approve;topic='.$context['current_topic'].'.'.$context['start'].';msg='.$output['id'].';'.$context['session_var'].'='.$context['session_id'],
1608
+				'href' => $scripturl . '?action=moderate;area=postmod;sa=approve;topic=' . $context['current_topic'] . '.' . $context['start'] . ';msg=' . $output['id'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1609 1609
 				'icon' => 'approve_button',
1610 1610
 				'show' => $output['can_approve']
1611 1611
 			),
1612 1612
 			'unapprove' => array(
1613 1613
 				'label' => $txt['unapprove'],
1614
-				'href' => $scripturl.'?action=moderate;area=postmod;sa=approve;topic='.$context['current_topic'].'.'.$context['start'].';msg='.$output['id'].';'.$context['session_var'].'='.$context['session_id'],
1614
+				'href' => $scripturl . '?action=moderate;area=postmod;sa=approve;topic=' . $context['current_topic'] . '.' . $context['start'] . ';msg=' . $output['id'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1615 1615
 				'icon' => 'unapprove_button',
1616 1616
 				'show' => $output['can_unapprove']
1617 1617
 			),
1618 1618
 		),
1619 1619
 		'quickmod' => array(
1620 1620
 			'class' => 'inline_mod_check',
1621
-			'id' => 'in_topic_mod_check_'. $output['id'],
1621
+			'id' => 'in_topic_mod_check_' . $output['id'],
1622 1622
 			'custom' => 'style="display: none;"',
1623 1623
 			'content' => '',
1624 1624
 			'show' => !empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && $output['can_remove']
Please login to merge, or discard this patch.
Sources/Cache/APIs/MemcacheImplementation.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -169,16 +169,16 @@  discard block
 block discarded – undo
169 169
 	{
170 170
 		global $context, $txt;
171 171
 
172
-		if (!in_array($txt[self::CLASS_KEY .'_settings'], $config_vars))
172
+		if (!in_array($txt[self::CLASS_KEY . '_settings'], $config_vars))
173 173
 		{
174
-			$config_vars[] = $txt[self::CLASS_KEY .'_settings'];
174
+			$config_vars[] = $txt[self::CLASS_KEY . '_settings'];
175 175
 			$config_vars[] = array(
176 176
 				self::CLASS_KEY,
177
-				$txt[self::CLASS_KEY .'_servers'],
177
+				$txt[self::CLASS_KEY . '_servers'],
178 178
 				'file',
179 179
 				'text',
180 180
 				0,
181
-				'subtext' => $txt[self::CLASS_KEY .'_servers_subtext']);
181
+				'subtext' => $txt[self::CLASS_KEY . '_servers_subtext']);
182 182
 		}
183 183
 
184 184
 		if (!isset($context['settings_post_javascript']))
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
 		$context['settings_post_javascript'] .= '
188 188
 			$("#cache_accelerator").change(function (e) {
189 189
 				var cache_type = e.currentTarget.value;
190
-				$("#'. self::CLASS_KEY .'").prop("disabled", cache_type != "MemcacheImplementation" && cache_type != "MemcachedImplementation");
190
+				$("#'. self::CLASS_KEY . '").prop("disabled", cache_type != "MemcacheImplementation" && cache_type != "MemcachedImplementation");
191 191
 			});';
192 192
 	}
193 193
 
Please login to merge, or discard this patch.
Themes/default/Profile.template.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1721,7 +1721,7 @@  discard block
 block discarded – undo
1721 1721
 		{
1722 1722
 			// Avoid double separators and empty titled sections
1723 1723
 			$empty_section = true;
1724
-			for ($j=$i+1; $j < count($context['theme_options']); $j++)
1724
+			for ($j = $i + 1; $j < count($context['theme_options']); $j++)
1725 1725
 			{
1726 1726
 				// Found another separator, so we're done
1727 1727
 				if (!is_array($context['theme_options'][$j]))
@@ -2700,8 +2700,7 @@  discard block
 block discarded – undo
2700 2700
 		foreach ($context['post_errors'] as $error)
2701 2701
 		{
2702 2702
 			$text_key_error = $error == 'password_short' ?
2703
-				sprintf($txt['profile_error_' . $error], (empty($modSettings['password_strength']) ? 4 : 8)) :
2704
-				(isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : '');
2703
+				sprintf($txt['profile_error_' . $error], (empty($modSettings['password_strength']) ? 4 : 8)) : (isset($txt['profile_error_' . $error]) ? $txt['profile_error_' . $error] : '');
2705 2704
 
2706 2705
 			echo '
2707 2706
 				<li>', isset($txt['profile_error_' . $error]) ? $text_key_error : $error, '</li>';
Please login to merge, or discard this patch.
index.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 require_once($sourcedir . '/Security.php');
79 79
 
80 80
 // If $maintenance is set specifically to 2, then we're upgrading or something.
81
-if (!empty($maintenance) &&  2 === $maintenance)
81
+if (!empty($maintenance) && 2 === $maintenance)
82 82
 {
83 83
 	display_maintenance_message();
84 84
 }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
  *
95 95
  * @param string $class The fully-qualified class name.
96 96
  */
97
-spl_autoload_register(function ($class) use ($sourcedir)
97
+spl_autoload_register(function($class) use ($sourcedir)
98 98
 {
99 99
 	$classMap = array(
100 100
 		'ReCaptcha\\' => 'ReCaptcha/',
Please login to merge, or discard this patch.
Sources/MessageIndex.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -340,7 +340,7 @@
 block discarded – undo
340 340
 		WHERE t.id_board = {int:current_board} '
341 341
 			. (!$modSettings['postmod_active'] || $context['can_approve_posts'] ? '' : '
342 342
 			AND (t.approved = {int:is_approved}' . ($user_info['is_guest'] ? '' : ' OR t.id_member_started = {int:current_member}') . ')') . (!empty($message_index_topic_wheres) ? '
343
-			AND ' . implode("\n\t\t\t\tAND ", $message_index_topic_wheres) : ''). '
343
+			AND ' . implode("\n\t\t\t\tAND ", $message_index_topic_wheres) : '') . '
344 344
 		ORDER BY is_sticky' . ($fake_ascending ? '' : ' DESC') . ', ' . $_REQUEST['sort'] . ($ascending ? '' : ' DESC') . '
345 345
 		LIMIT {int:maxindex}
346 346
 			OFFSET {int:start} ';
Please login to merge, or discard this patch.
Sources/Post.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1283,7 +1283,7 @@
 block discarded – undo
1283 1283
 	if ($context['can_post_attachment'])
1284 1284
 	{
1285 1285
 		$acceptedFiles = empty($context['allowed_extensions']) ? '' : implode(',', array_map(
1286
-			function ($val) use ($smcFunc)
1286
+			function($val) use ($smcFunc)
1287 1287
 			{
1288 1288
 				return !empty($val) ? ('.' . $smcFunc['htmltrim']($val)) : '';
1289 1289
 			},
Please login to merge, or discard this patch.
Sources/News.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	);
92 92
 	foreach (array('action', 'sa', 'type', 'board', 'boards', 'c', 'u', 'limit', 'offset') as $var)
93 93
 		if (isset($_GET[$var]))
94
-			$feed_meta['self'] .= ($feed_meta['self'] === $scripturl ? '?' : ';' ) . $var . '=' . $_GET[$var];
94
+			$feed_meta['self'] .= ($feed_meta['self'] === $scripturl ? '?' : ';') . $var . '=' . $_GET[$var];
95 95
 
96 96
 	// Handle the cases where a board, boards, or category is asked for.
97 97
 	$query_this_board = 1;
@@ -303,17 +303,17 @@  discard block
 block discarded – undo
303 303
 	 * namespaces, which could cause it to mangle the XML horrifically
304 304
 	 * during processing.
305 305
 	 */
306
-	$smf_ns = 'htt'.'p:/'.'/ww'.'w.simple'.'machines.o'.'rg/xml/' . $subaction;
306
+	$smf_ns = 'htt' . 'p:/' . '/ww' . 'w.simple' . 'machines.o' . 'rg/xml/' . $subaction;
307 307
 
308 308
 	// Allow mods to add extra namespaces and tags to the feed/channel
309 309
 	$namespaces = array(
310 310
 		'rss' => array(),
311
-		'rss2' => array('atom' => 'htt'.'p:/'.'/ww'.'w.w3.o'.'rg/2005/Atom'),
312
-		'atom' => array('' => 'htt'.'p:/'.'/ww'.'w.w3.o'.'rg/2005/Atom'),
311
+		'rss2' => array('atom' => 'htt' . 'p:/' . '/ww' . 'w.w3.o' . 'rg/2005/Atom'),
312
+		'atom' => array('' => 'htt' . 'p:/' . '/ww' . 'w.w3.o' . 'rg/2005/Atom'),
313 313
 		'rdf' => array(
314
-			'' => 'htt'.'p:/'.'/purl.o'.'rg/rss/1.0/',
315
-			'rdf' => 'htt'.'p:/'.'/ww'.'w.w3.o'.'rg/1999/02/22-rdf-syntax-ns#',
316
-			'dc' => 'htt'.'p:/'.'/purl.o'.'rg/dc/elements/1.1/',
314
+			'' => 'htt' . 'p:/' . '/purl.o' . 'rg/rss/1.0/',
315
+			'rdf' => 'htt' . 'p:/' . '/ww' . 'w.w3.o' . 'rg/1999/02/22-rdf-syntax-ns#',
316
+			'dc' => 'htt' . 'p:/' . '/purl.o' . 'rg/dc/elements/1.1/',
317 317
 		),
318 318
 		'smf' => array(
319 319
 			'smf' => $smf_ns,
@@ -2141,7 +2141,7 @@  discard block
 block discarded – undo
2141 2141
 			m.id_msg, m.id_topic, m.id_board, m.id_member, m.poster_email, m.poster_ip,
2142 2142
 			m.poster_time, m.subject, m.modified_time, m.modified_name, m.modified_reason, m.body,
2143 2143
 			m.likes, m.approved, m.smileys_enabled
2144
-		FROM {db_prefix}messages AS m' . ($modSettings['postmod_active'] && !$show_all ?'
2144
+		FROM {db_prefix}messages AS m' . ($modSettings['postmod_active'] && !$show_all ? '
2145 2145
 			INNER JOIN {db_prefix}topics AS t ON (t.id_topic = m.id_topic)' : '') . '
2146 2146
 		WHERE m.id_member = {int:uid}
2147 2147
 			AND m.id_msg > {int:start_after}
Please login to merge, or discard this patch.
Sources/ManagePermissions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1840,7 +1840,7 @@
 block discarded – undo
1840 1840
 		// Make sure this is an array of integers
1841 1841
 		$excluded_groups = array_filter(
1842 1842
 			(array) $excluded_groups,
1843
-			function ($v)
1843
+			function($v)
1844 1844
 			{
1845 1845
 				return is_int($v) || is_string($v) && (string) intval($v) === $v;
1846 1846
 			}
Please login to merge, or discard this patch.
Sources/Profile-View.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
 			AND a.is_read = 0' : '') . (!empty($alertIDs) ? '
263 263
 			AND a.id_alert IN ({array_int:alertIDs})' : '') . '
264 264
 		ORDER BY id_alert DESC' . (!empty($limit) ? '
265
-		LIMIT {int:limit}' : '') . (!empty($offset) ?'
265
+		LIMIT {int:limit}' : '') . (!empty($offset) ? '
266 266
 		OFFSET {int:offset}' : ''),
267 267
 		array(
268 268
 			'id_member' => $memID,
@@ -361,7 +361,7 @@  discard block
 block discarded – undo
361 361
 
362 362
 	// Substitute $scripturl into the link formats. (Done here to make life easier for hooked mods.)
363 363
 	$formats = array_map(
364
-		function ($format) use ($scripturl)
364
+		function($format) use ($scripturl)
365 365
 		{
366 366
 			$format['link'] = str_replace('{scripturl}', $scripturl, $format['link']);
367 367
 			$format['text'] = str_replace('{scripturl}', $scripturl, $format['text']);
@@ -1176,20 +1176,20 @@  discard block
 block discarded – undo
1176 1176
 		$context['posts'][$key]['quickbuttons'] = array(
1177 1177
 			'reply' => array(
1178 1178
 				'label' => $txt['reply'],
1179
-				'href' => $scripturl.'?action=post;topic='.$post['topic'].'.'.$post['start'],
1179
+				'href' => $scripturl . '?action=post;topic=' . $post['topic'] . '.' . $post['start'],
1180 1180
 				'icon' => 'reply_button',
1181 1181
 				'show' => $post['can_reply']
1182 1182
 			),
1183 1183
 			'quote' => array(
1184 1184
 				'label' => $txt['quote_action'],
1185
-				'href' => $scripturl.'?action=post;topic='.$post['topic'].'.'.$post['start'].';quote='.$post['id'],
1185
+				'href' => $scripturl . '?action=post;topic=' . $post['topic'] . '.' . $post['start'] . ';quote=' . $post['id'],
1186 1186
 				'icon' => 'quote',
1187 1187
 				'show' => $post['can_quote']
1188 1188
 			),
1189 1189
 			'remove' => array(
1190 1190
 				'label' => $txt['remove'],
1191
-				'href' => $scripturl.'?action=deletemsg;msg='.$post['id'].';topic='.$post['topic'].';profile;u='.$context['member']['id'].';start='.$context['start'].';'.$context['session_var'].'='.$context['session_id'],
1192
-				'javascript' => 'data-confirm="'.$txt['remove_message'].'"',
1191
+				'href' => $scripturl . '?action=deletemsg;msg=' . $post['id'] . ';topic=' . $post['topic'] . ';profile;u=' . $context['member']['id'] . ';start=' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id'],
1192
+				'javascript' => 'data-confirm="' . $txt['remove_message'] . '"',
1193 1193
 				'class' => 'you_sure',
1194 1194
 				'icon' => 'remove_button',
1195 1195
 				'show' => $post['can_delete']
Please login to merge, or discard this patch.