@@ -899,13 +899,13 @@ |
||
899 | 899 | if ($start_char === 'C') |
900 | 900 | $limit_seek = $limit; |
901 | 901 | else |
902 | - $limit_seek = $limit + 1; |
|
902 | + $limit_seek = $limit + 1; |
|
903 | 903 | |
904 | 904 | $request = $smcFunc['db_query']('', ' |
905 | 905 | SELECT id_msg, id_member, approved |
906 | 906 | FROM {db_prefix}messages |
907 | 907 | WHERE id_topic = {int:current_topic} |
908 | - AND id_msg '. $page_operator . ' {int:page_id}'. (!$modSettings['postmod_active'] || $approve_posts ? '' : ' |
|
908 | + AND id_msg '. $page_operator . ' {int:page_id}' . (!$modSettings['postmod_active'] || $approve_posts ? '' : ' |
|
909 | 909 | AND (approved = {int:is_approved}' . ($user_info['is_guest'] ? '' : ' OR id_member = {int:current_member}') . ')') . ' |
910 | 910 | ORDER BY id_msg ' . ($ascending_seek ? '' : 'DESC') . ($context['messages_per_page'] == -1 ? '' : ' |
911 | 911 | LIMIT {int:limit}'), |
@@ -14,8 +14,9 @@ discard block |
||
14 | 14 | * @version 2.1 Beta 4 |
15 | 15 | */ |
16 | 16 | |
17 | -if (!defined('SMF')) |
|
17 | +if (!defined('SMF')) { |
|
18 | 18 | die('No direct access...'); |
19 | +} |
|
19 | 20 | |
20 | 21 | /** |
21 | 22 | * The central part of the board - topic display. |
@@ -34,8 +35,9 @@ discard block |
||
34 | 35 | global $messages_request, $language, $smcFunc; |
35 | 36 | |
36 | 37 | // What are you gonna display if these are empty?! |
37 | - if (empty($topic)) |
|
38 | - fatal_lang_error('no_board', false); |
|
38 | + if (empty($topic)) { |
|
39 | + fatal_lang_error('no_board', false); |
|
40 | + } |
|
39 | 41 | |
40 | 42 | // Load the proper template. |
41 | 43 | loadTemplate('Display'); |
@@ -52,15 +54,17 @@ discard block |
||
52 | 54 | $context['messages_per_page'] = empty($modSettings['disableCustomPerPage']) && !empty($options['messages_per_page']) ? $options['messages_per_page'] : $modSettings['defaultMaxMessages']; |
53 | 55 | |
54 | 56 | // Let's do some work on what to search index. |
55 | - if (count($_GET) > 2) |
|
56 | - foreach ($_GET as $k => $v) |
|
57 | + if (count($_GET) > 2) { |
|
58 | + foreach ($_GET as $k => $v) |
|
57 | 59 | { |
58 | 60 | if (!in_array($k, array('topic', 'board', 'start', session_name()))) |
59 | 61 | $context['robot_no_index'] = true; |
62 | + } |
|
60 | 63 | } |
61 | 64 | |
62 | - if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) |
|
63 | - $context['robot_no_index'] = true; |
|
65 | + if (!empty($_REQUEST['start']) && (!is_numeric($_REQUEST['start']) || $_REQUEST['start'] % $context['messages_per_page'] != 0)) { |
|
66 | + $context['robot_no_index'] = true; |
|
67 | + } |
|
64 | 68 | |
65 | 69 | // Find the previous or next topic. Make a fuss if there are no more. |
66 | 70 | if (isset($_REQUEST['prev_next']) && ($_REQUEST['prev_next'] == 'prev' || $_REQUEST['prev_next'] == 'next')) |
@@ -172,8 +176,9 @@ discard block |
||
172 | 176 | $topic_parameters |
173 | 177 | ); |
174 | 178 | |
175 | - if ($smcFunc['db_num_rows']($request) == 0) |
|
176 | - fatal_lang_error('not_a_topic', false, 404); |
|
179 | + if ($smcFunc['db_num_rows']($request) == 0) { |
|
180 | + fatal_lang_error('not_a_topic', false, 404); |
|
181 | + } |
|
177 | 182 | $context['topicinfo'] = $smcFunc['db_fetch_assoc']($request); |
178 | 183 | $smcFunc['db_free_result']($request); |
179 | 184 | |
@@ -210,8 +215,9 @@ discard block |
||
210 | 215 | $context['topic_unwatched'] = isset($context['topicinfo']['unwatched']) ? $context['topicinfo']['unwatched'] : 0; |
211 | 216 | |
212 | 217 | // Add up unapproved replies to get real number of replies... |
213 | - if ($modSettings['postmod_active'] && $approve_posts) |
|
214 | - $context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1); |
|
218 | + if ($modSettings['postmod_active'] && $approve_posts) { |
|
219 | + $context['real_num_replies'] += $context['topicinfo']['unapproved_posts'] - ($context['topicinfo']['approved'] ? 0 : 1); |
|
220 | + } |
|
215 | 221 | |
216 | 222 | // If this topic has unapproved posts, we need to work out how many posts the user can see, for page indexing. |
217 | 223 | if ($modSettings['postmod_active'] && $context['topicinfo']['unapproved_posts'] && !$user_info['is_guest'] && !$approve_posts) |
@@ -231,11 +237,11 @@ discard block |
||
231 | 237 | $smcFunc['db_free_result']($request); |
232 | 238 | |
233 | 239 | $context['total_visible_posts'] = $context['num_replies'] + $myUnapprovedPosts + ($context['topicinfo']['approved'] ? 1 : 0); |
240 | + } elseif ($user_info['is_guest']) { |
|
241 | + $context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
242 | + } else { |
|
243 | + $context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
234 | 244 | } |
235 | - elseif ($user_info['is_guest']) |
|
236 | - $context['total_visible_posts'] = $context['num_replies'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
237 | - else |
|
238 | - $context['total_visible_posts'] = $context['num_replies'] + $context['topicinfo']['unapproved_posts'] + ($context['topicinfo']['approved'] ? 1 : 0); |
|
239 | 245 | |
240 | 246 | // The start isn't a number; it's information about what to do, where to go. |
241 | 247 | if (!is_numeric($_REQUEST['start'])) |
@@ -248,8 +254,7 @@ discard block |
||
248 | 254 | { |
249 | 255 | $context['start_from'] = $context['total_visible_posts'] - 1; |
250 | 256 | $_REQUEST['start'] = empty($options['view_newest_first']) ? $context['start_from'] : 0; |
251 | - } |
|
252 | - else |
|
257 | + } else |
|
253 | 258 | { |
254 | 259 | // Find the earliest unread message in the topic. (the use of topics here is just for both tables.) |
255 | 260 | $request = $smcFunc['db_query']('', ' |
@@ -277,9 +282,9 @@ discard block |
||
277 | 282 | if (substr($_REQUEST['start'], 0, 4) == 'from') |
278 | 283 | { |
279 | 284 | $timestamp = (int) substr($_REQUEST['start'], 4); |
280 | - if ($timestamp === 0) |
|
281 | - $_REQUEST['start'] = 0; |
|
282 | - else |
|
285 | + if ($timestamp === 0) { |
|
286 | + $_REQUEST['start'] = 0; |
|
287 | + } else |
|
283 | 288 | { |
284 | 289 | // Find the number of messages posted before said time... |
285 | 290 | $request = $smcFunc['db_query']('', ' |
@@ -307,11 +312,11 @@ discard block |
||
307 | 312 | elseif (substr($_REQUEST['start'], 0, 3) == 'msg') |
308 | 313 | { |
309 | 314 | $virtual_msg = (int) substr($_REQUEST['start'], 3); |
310 | - if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) |
|
311 | - $context['start_from'] = $context['total_visible_posts'] - 1; |
|
312 | - elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) |
|
313 | - $context['start_from'] = 0; |
|
314 | - else |
|
315 | + if (!$context['topicinfo']['unapproved_posts'] && $virtual_msg >= $context['topicinfo']['id_last_msg']) { |
|
316 | + $context['start_from'] = $context['total_visible_posts'] - 1; |
|
317 | + } elseif (!$context['topicinfo']['unapproved_posts'] && $virtual_msg <= $context['topicinfo']['id_first_msg']) { |
|
318 | + $context['start_from'] = 0; |
|
319 | + } else |
|
315 | 320 | { |
316 | 321 | // Find the start value for that message...... |
317 | 322 | $request = $smcFunc['db_query']('', ' |
@@ -394,21 +399,25 @@ discard block |
||
394 | 399 | ); |
395 | 400 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
396 | 401 | { |
397 | - if (empty($row['id_member'])) |
|
398 | - continue; |
|
402 | + if (empty($row['id_member'])) { |
|
403 | + continue; |
|
404 | + } |
|
399 | 405 | |
400 | - if (!empty($row['online_color'])) |
|
401 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
402 | - else |
|
403 | - $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
406 | + if (!empty($row['online_color'])) { |
|
407 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '" style="color: ' . $row['online_color'] . ';">' . $row['real_name'] . '</a>'; |
|
408 | + } else { |
|
409 | + $link = '<a href="' . $scripturl . '?action=profile;u=' . $row['id_member'] . '">' . $row['real_name'] . '</a>'; |
|
410 | + } |
|
404 | 411 | |
405 | 412 | $is_buddy = in_array($row['id_member'], $user_info['buddies']); |
406 | - if ($is_buddy) |
|
407 | - $link = '<strong>' . $link . '</strong>'; |
|
413 | + if ($is_buddy) { |
|
414 | + $link = '<strong>' . $link . '</strong>'; |
|
415 | + } |
|
408 | 416 | |
409 | 417 | // Add them both to the list and to the more detailed list. |
410 | - if (!empty($row['show_online']) || allowedTo('moderate_forum')) |
|
411 | - $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
418 | + if (!empty($row['show_online']) || allowedTo('moderate_forum')) { |
|
419 | + $context['view_members_list'][$row['log_time'] . $row['member_name']] = empty($row['show_online']) ? '<em>' . $link . '</em>' : $link; |
|
420 | + } |
|
412 | 421 | $context['view_members'][$row['log_time'] . $row['member_name']] = array( |
413 | 422 | 'id' => $row['id_member'], |
414 | 423 | 'username' => $row['member_name'], |
@@ -420,8 +429,9 @@ discard block |
||
420 | 429 | 'hidden' => empty($row['show_online']), |
421 | 430 | ); |
422 | 431 | |
423 | - if (empty($row['show_online'])) |
|
424 | - $context['view_num_hidden']++; |
|
432 | + if (empty($row['show_online'])) { |
|
433 | + $context['view_num_hidden']++; |
|
434 | + } |
|
425 | 435 | } |
426 | 436 | |
427 | 437 | // The number of guests is equal to the rows minus the ones we actually used ;). |
@@ -435,11 +445,13 @@ discard block |
||
435 | 445 | |
436 | 446 | // If all is set, but not allowed... just unset it. |
437 | 447 | $can_show_all = !empty($modSettings['enableAllMessages']) && $context['total_visible_posts'] > $context['messages_per_page'] && $context['total_visible_posts'] < $modSettings['enableAllMessages']; |
438 | - if (isset($_REQUEST['all']) && !$can_show_all) |
|
439 | - unset($_REQUEST['all']); |
|
448 | + if (isset($_REQUEST['all']) && !$can_show_all) { |
|
449 | + unset($_REQUEST['all']); |
|
450 | + } |
|
440 | 451 | // Otherwise, it must be allowed... so pretend start was -1. |
441 | - elseif (isset($_REQUEST['all'])) |
|
442 | - $_REQUEST['start'] = -1; |
|
452 | + elseif (isset($_REQUEST['all'])) { |
|
453 | + $_REQUEST['start'] = -1; |
|
454 | + } |
|
443 | 455 | |
444 | 456 | // Construct the page index, allowing for the .START method... |
445 | 457 | $context['page_index'] = constructPageIndex($scripturl . '?topic=' . $topic . '.%1$d', $_REQUEST['start'], $context['total_visible_posts'], $context['messages_per_page'], true); |
@@ -476,8 +488,9 @@ discard block |
||
476 | 488 | $_REQUEST['start'] = 0; |
477 | 489 | } |
478 | 490 | // They aren't using it, but the *option* is there, at least. |
479 | - else |
|
480 | - $context['page_index'] .= ' <a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> '; |
|
491 | + else { |
|
492 | + $context['page_index'] .= ' <a href="' . $scripturl . '?topic=' . $topic . '.0;all">' . $txt['all'] . '</a> '; |
|
493 | + } |
|
481 | 494 | } |
482 | 495 | |
483 | 496 | // Build the link tree. |
@@ -493,14 +506,16 @@ discard block |
||
493 | 506 | if (!empty($board_info['moderators'])) |
494 | 507 | { |
495 | 508 | // Add a link for each moderator... |
496 | - foreach ($board_info['moderators'] as $mod) |
|
497 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
509 | + foreach ($board_info['moderators'] as $mod) { |
|
510 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=profile;u=' . $mod['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod['name'] . '</a>'; |
|
511 | + } |
|
498 | 512 | } |
499 | 513 | if (!empty($board_info['moderator_groups'])) |
500 | 514 | { |
501 | 515 | // Add a link for each moderator group as well... |
502 | - foreach ($board_info['moderator_groups'] as $mod_group) |
|
503 | - $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
516 | + foreach ($board_info['moderator_groups'] as $mod_group) { |
|
517 | + $context['link_moderators'][] = '<a href="' . $scripturl . '?action=groups;sa=viewmemberes;group=' . $mod_group['id'] . '" title="' . $txt['board_moderator'] . '">' . $mod_group['name'] . '</a>'; |
|
518 | + } |
|
504 | 519 | } |
505 | 520 | |
506 | 521 | if (!empty($context['link_moderators'])) |
@@ -531,9 +546,9 @@ discard block |
||
531 | 546 | // For quick reply we need a response prefix in the default forum language. |
532 | 547 | if (!isset($context['response_prefix']) && !($context['response_prefix'] = cache_get_data('response_prefix', 600))) |
533 | 548 | { |
534 | - if ($language === $user_info['language']) |
|
535 | - $context['response_prefix'] = $txt['response_prefix']; |
|
536 | - else |
|
549 | + if ($language === $user_info['language']) { |
|
550 | + $context['response_prefix'] = $txt['response_prefix']; |
|
551 | + } else |
|
537 | 552 | { |
538 | 553 | loadLanguage('index', $language, false); |
539 | 554 | $context['response_prefix'] = $txt['response_prefix']; |
@@ -565,8 +580,9 @@ discard block |
||
565 | 580 | list($start, $end, $allday, $span, $tz, $tz_abbrev) = buildEventDatetimes($row); |
566 | 581 | |
567 | 582 | // Sanity check |
568 | - if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) |
|
569 | - continue; |
|
583 | + if (!empty($start['error_count']) || !empty($start['warning_count']) || !empty($end['error_count']) || !empty($end['warning_count'])) { |
|
584 | + continue; |
|
585 | + } |
|
570 | 586 | |
571 | 587 | $linked_calendar_event = array( |
572 | 588 | 'id' => $row['id_event'], |
@@ -615,8 +631,9 @@ discard block |
||
615 | 631 | } |
616 | 632 | $smcFunc['db_free_result']($request); |
617 | 633 | |
618 | - if (!empty($context['linked_calendar_events'])) |
|
619 | - $context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true; |
|
634 | + if (!empty($context['linked_calendar_events'])) { |
|
635 | + $context['linked_calendar_events'][count($context['linked_calendar_events']) - 1]['is_last'] = true; |
|
636 | + } |
|
620 | 637 | } |
621 | 638 | |
622 | 639 | // Create the poll info if it exists. |
@@ -679,8 +696,9 @@ discard block |
||
679 | 696 | $smcFunc['db_free_result']($request); |
680 | 697 | |
681 | 698 | // Got we multi choice? |
682 | - if ($pollinfo['max_votes'] > 1) |
|
683 | - $realtotal = $pollinfo['total']; |
|
699 | + if ($pollinfo['max_votes'] > 1) { |
|
700 | + $realtotal = $pollinfo['total']; |
|
701 | + } |
|
684 | 702 | |
685 | 703 | // If this is a guest we need to do our best to work out if they have voted, and what they voted for. |
686 | 704 | if ($user_info['is_guest'] && $pollinfo['guest_vote'] && allowedTo('poll_vote')) |
@@ -693,20 +711,21 @@ discard block |
||
693 | 711 | foreach ($guestinfo as $i => $guestvoted) |
694 | 712 | { |
695 | 713 | $guestvoted = explode(',', $guestvoted); |
696 | - if ($guestvoted[0] == $context['topicinfo']['id_poll']) |
|
697 | - break; |
|
714 | + if ($guestvoted[0] == $context['topicinfo']['id_poll']) { |
|
715 | + break; |
|
716 | + } |
|
698 | 717 | } |
699 | 718 | // Has the poll been reset since guest voted? |
700 | 719 | if ($pollinfo['reset_poll'] > $guestvoted[1]) |
701 | 720 | { |
702 | 721 | // Remove the poll info from the cookie to allow guest to vote again |
703 | 722 | unset($guestinfo[$i]); |
704 | - if (!empty($guestinfo)) |
|
705 | - $_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo); |
|
706 | - else |
|
707 | - unset($_COOKIE['guest_poll_vote']); |
|
708 | - } |
|
709 | - else |
|
723 | + if (!empty($guestinfo)) { |
|
724 | + $_COOKIE['guest_poll_vote'] = ';' . implode(';', $guestinfo); |
|
725 | + } else { |
|
726 | + unset($_COOKIE['guest_poll_vote']); |
|
727 | + } |
|
728 | + } else |
|
710 | 729 | { |
711 | 730 | // What did they vote for? |
712 | 731 | unset($guestvoted[0], $guestvoted[1]); |
@@ -820,23 +839,29 @@ discard block |
||
820 | 839 | // Build the poll moderation button array. |
821 | 840 | $context['poll_buttons'] = array(); |
822 | 841 | |
823 | - if ($context['allow_return_vote']) |
|
824 | - $context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']); |
|
842 | + if ($context['allow_return_vote']) { |
|
843 | + $context['poll_buttons']['vote'] = array('text' => 'poll_return_vote', 'image' => 'poll_options.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start']); |
|
844 | + } |
|
825 | 845 | |
826 | - if ($context['show_view_results_button']) |
|
827 | - $context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults'); |
|
846 | + if ($context['show_view_results_button']) { |
|
847 | + $context['poll_buttons']['results'] = array('text' => 'poll_results', 'image' => 'poll_results.png', 'url' => $scripturl . '?topic=' . $context['current_topic'] . '.' . $context['start'] . ';viewresults'); |
|
848 | + } |
|
828 | 849 | |
829 | - if ($context['allow_change_vote']) |
|
830 | - $context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
850 | + if ($context['allow_change_vote']) { |
|
851 | + $context['poll_buttons']['change_vote'] = array('text' => 'poll_change_vote', 'image' => 'poll_change_vote.png', 'url' => $scripturl . '?action=vote;topic=' . $context['current_topic'] . '.' . $context['start'] . ';poll=' . $context['poll']['id'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
852 | + } |
|
831 | 853 | |
832 | - if ($context['allow_lock_poll']) |
|
833 | - $context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
854 | + if ($context['allow_lock_poll']) { |
|
855 | + $context['poll_buttons']['lock'] = array('text' => (!$context['poll']['is_locked'] ? 'poll_lock' : 'poll_unlock'), 'image' => 'poll_lock.png', 'url' => $scripturl . '?action=lockvoting;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
856 | + } |
|
834 | 857 | |
835 | - if ($context['allow_edit_poll']) |
|
836 | - $context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
858 | + if ($context['allow_edit_poll']) { |
|
859 | + $context['poll_buttons']['edit'] = array('text' => 'poll_edit', 'image' => 'poll_edit.png', 'url' => $scripturl . '?action=editpoll;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
860 | + } |
|
837 | 861 | |
838 | - if ($context['can_remove_poll']) |
|
839 | - $context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
862 | + if ($context['can_remove_poll']) { |
|
863 | + $context['poll_buttons']['remove_poll'] = array('text' => 'poll_remove', 'image' => 'admin_remove_poll.png', 'custom' => 'data-confirm="' . $txt['poll_remove_warn'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removepoll;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
864 | + } |
|
840 | 865 | |
841 | 866 | // Allow mods to add additional buttons here |
842 | 867 | call_integration_hook('integrate_poll_buttons'); |
@@ -872,9 +897,9 @@ discard block |
||
872 | 897 | { |
873 | 898 | $start_char = 'C'; |
874 | 899 | $page_id = $ascending ? $context['topicinfo']['id_first_msg'] : $context['topicinfo']['id_last_msg']; |
900 | + } else { |
|
901 | + $start_char = null; |
|
875 | 902 | } |
876 | - else |
|
877 | - $start_char = null; |
|
878 | 903 | |
879 | 904 | $limit = $context['messages_per_page']; |
880 | 905 | |
@@ -889,17 +914,17 @@ discard block |
||
889 | 914 | { |
890 | 915 | $ascending_seek = true; |
891 | 916 | $page_operator = $ascending ? '>=' : '<='; |
892 | - } |
|
893 | - else |
|
917 | + } else |
|
894 | 918 | { |
895 | 919 | $ascending_seek = false; |
896 | 920 | $page_operator = $ascending ? '<=' : '>='; |
897 | 921 | } |
898 | 922 | |
899 | - if ($start_char === 'C') |
|
900 | - $limit_seek = $limit; |
|
901 | - else |
|
902 | - $limit_seek = $limit + 1; |
|
923 | + if ($start_char === 'C') { |
|
924 | + $limit_seek = $limit; |
|
925 | + } else { |
|
926 | + $limit_seek = $limit + 1; |
|
927 | + } |
|
903 | 928 | |
904 | 929 | $request = $smcFunc['db_query']('', ' |
905 | 930 | SELECT id_msg, id_member, approved |
@@ -922,21 +947,23 @@ discard block |
||
922 | 947 | $found_msg = false; |
923 | 948 | |
924 | 949 | // Fallback |
925 | - if ($smcFunc['db_num_rows']($request) < 1) |
|
926 | - unset($start_char); |
|
927 | - else |
|
950 | + if ($smcFunc['db_num_rows']($request) < 1) { |
|
951 | + unset($start_char); |
|
952 | + } else |
|
928 | 953 | { |
929 | 954 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
930 | 955 | { |
931 | 956 | // Check if the start msg is in our result |
932 | - if ($row['id_msg'] == $page_id) |
|
933 | - $found_msg = true; |
|
957 | + if ($row['id_msg'] == $page_id) { |
|
958 | + $found_msg = true; |
|
959 | + } |
|
934 | 960 | |
935 | 961 | // Skip the the start msg if we not in mode C |
936 | 962 | if ($start_char === 'C' || $row['id_msg'] != $page_id) |
937 | 963 | { |
938 | - if (!empty($row['id_member'])) |
|
939 | - $all_posters[$row['id_msg']] = $row['id_member']; |
|
964 | + if (!empty($row['id_member'])) { |
|
965 | + $all_posters[$row['id_msg']] = $row['id_member']; |
|
966 | + } |
|
940 | 967 | |
941 | 968 | $messages[] = $row['id_msg']; |
942 | 969 | } |
@@ -952,8 +979,9 @@ discard block |
||
952 | 979 | } |
953 | 980 | |
954 | 981 | // Before Page bring in the right order |
955 | - if (!empty($start_char) && $start_char === 'L') |
|
956 | - krsort($messages); |
|
982 | + if (!empty($start_char) && $start_char === 'L') { |
|
983 | + krsort($messages); |
|
984 | + } |
|
957 | 985 | } |
958 | 986 | |
959 | 987 | // Jump to page |
@@ -989,14 +1017,16 @@ discard block |
||
989 | 1017 | |
990 | 1018 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
991 | 1019 | { |
992 | - if (!empty($row['id_member'])) |
|
993 | - $all_posters[$row['id_msg']] = $row['id_member']; |
|
1020 | + if (!empty($row['id_member'])) { |
|
1021 | + $all_posters[$row['id_msg']] = $row['id_member']; |
|
1022 | + } |
|
994 | 1023 | $messages[] = $row['id_msg']; |
995 | 1024 | } |
996 | 1025 | |
997 | 1026 | // Sort the messages into the correct display order |
998 | - if (!$ascending) |
|
999 | - sort($messages); |
|
1027 | + if (!$ascending) { |
|
1028 | + sort($messages); |
|
1029 | + } |
|
1000 | 1030 | } |
1001 | 1031 | |
1002 | 1032 | // Remember the paging data for next time |
@@ -1016,8 +1046,9 @@ discard block |
||
1016 | 1046 | if (!$user_info['is_guest'] && !empty($messages)) |
1017 | 1047 | { |
1018 | 1048 | $mark_at_msg = max($messages); |
1019 | - if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) |
|
1020 | - $mark_at_msg = $modSettings['maxMsgID']; |
|
1049 | + if ($mark_at_msg >= $context['topicinfo']['id_last_msg']) { |
|
1050 | + $mark_at_msg = $modSettings['maxMsgID']; |
|
1051 | + } |
|
1021 | 1052 | if ($mark_at_msg >= $context['topicinfo']['new_from']) |
1022 | 1053 | { |
1023 | 1054 | $smcFunc['db_insert']($context['topicinfo']['new_from'] == 0 ? 'ignore' : 'replace', |
@@ -1049,8 +1080,9 @@ discard block |
||
1049 | 1080 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1050 | 1081 | { |
1051 | 1082 | // Find if this topic is marked for notification... |
1052 | - if (!empty($row['id_topic'])) |
|
1053 | - $context['is_marked_notify'] = true; |
|
1083 | + if (!empty($row['id_topic'])) { |
|
1084 | + $context['is_marked_notify'] = true; |
|
1085 | + } |
|
1054 | 1086 | |
1055 | 1087 | // Only do this once, but mark the notifications as "not sent yet" for next time. |
1056 | 1088 | if (!empty($row['sent']) && $do_once) |
@@ -1072,8 +1104,9 @@ discard block |
||
1072 | 1104 | } |
1073 | 1105 | |
1074 | 1106 | // Have we recently cached the number of new topics in this board, and it's still a lot? |
1075 | - if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) |
|
1076 | - $_SESSION['topicseen_cache'][$board]--; |
|
1107 | + if (isset($_REQUEST['topicseen']) && isset($_SESSION['topicseen_cache'][$board]) && $_SESSION['topicseen_cache'][$board] > 5) { |
|
1108 | + $_SESSION['topicseen_cache'][$board]--; |
|
1109 | + } |
|
1077 | 1110 | // Mark board as seen if this is the only new topic. |
1078 | 1111 | elseif (isset($_REQUEST['topicseen'])) |
1079 | 1112 | { |
@@ -1097,14 +1130,16 @@ discard block |
||
1097 | 1130 | $smcFunc['db_free_result']($request); |
1098 | 1131 | |
1099 | 1132 | // If there're no real new topics in this board, mark the board as seen. |
1100 | - if (empty($numNewTopics)) |
|
1101 | - $_REQUEST['boardseen'] = true; |
|
1102 | - else |
|
1103 | - $_SESSION['topicseen_cache'][$board] = $numNewTopics; |
|
1133 | + if (empty($numNewTopics)) { |
|
1134 | + $_REQUEST['boardseen'] = true; |
|
1135 | + } else { |
|
1136 | + $_SESSION['topicseen_cache'][$board] = $numNewTopics; |
|
1137 | + } |
|
1104 | 1138 | } |
1105 | 1139 | // Probably one less topic - maybe not, but even if we decrease this too fast it will only make us look more often. |
1106 | - elseif (isset($_SESSION['topicseen_cache'][$board])) |
|
1107 | - $_SESSION['topicseen_cache'][$board]--; |
|
1140 | + elseif (isset($_SESSION['topicseen_cache'][$board])) { |
|
1141 | + $_SESSION['topicseen_cache'][$board]--; |
|
1142 | + } |
|
1108 | 1143 | |
1109 | 1144 | // Mark board as seen if we came using last post link from BoardIndex. (or other places...) |
1110 | 1145 | if (isset($_REQUEST['boardseen'])) |
@@ -1161,23 +1196,26 @@ discard block |
||
1161 | 1196 | $temp = array(); |
1162 | 1197 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1163 | 1198 | { |
1164 | - if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) |
|
1165 | - continue; |
|
1199 | + if (!$row['approved'] && $modSettings['postmod_active'] && !allowedTo('approve_posts') && (!isset($all_posters[$row['id_msg']]) || $all_posters[$row['id_msg']] != $user_info['id'])) { |
|
1200 | + continue; |
|
1201 | + } |
|
1166 | 1202 | |
1167 | 1203 | $temp[$row['id_attach']] = $row; |
1168 | 1204 | $temp[$row['id_attach']]['topic'] = $topic; |
1169 | 1205 | $temp[$row['id_attach']]['board'] = $board; |
1170 | 1206 | |
1171 | - if (!isset($context['loaded_attachments'][$row['id_msg']])) |
|
1172 | - $context['loaded_attachments'][$row['id_msg']] = array(); |
|
1207 | + if (!isset($context['loaded_attachments'][$row['id_msg']])) { |
|
1208 | + $context['loaded_attachments'][$row['id_msg']] = array(); |
|
1209 | + } |
|
1173 | 1210 | } |
1174 | 1211 | $smcFunc['db_free_result']($request); |
1175 | 1212 | |
1176 | 1213 | // This is better than sorting it with the query... |
1177 | 1214 | ksort($temp); |
1178 | 1215 | |
1179 | - foreach ($temp as $row) |
|
1180 | - $context['loaded_attachments'][$row['id_msg']][] = $row; |
|
1216 | + foreach ($temp as $row) { |
|
1217 | + $context['loaded_attachments'][$row['id_msg']][] = $row; |
|
1218 | + } |
|
1181 | 1219 | } |
1182 | 1220 | |
1183 | 1221 | $msg_parameters = array( |
@@ -1204,21 +1242,23 @@ discard block |
||
1204 | 1242 | ); |
1205 | 1243 | |
1206 | 1244 | // And the likes |
1207 | - if (!empty($modSettings['enable_likes'])) |
|
1208 | - $context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic); |
|
1245 | + if (!empty($modSettings['enable_likes'])) { |
|
1246 | + $context['my_likes'] = $context['user']['is_guest'] ? array() : prepareLikesContext($topic); |
|
1247 | + } |
|
1209 | 1248 | |
1210 | 1249 | // Go to the last message if the given time is beyond the time of the last message. |
1211 | - if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) |
|
1212 | - $context['start_from'] = $context['topicinfo']['num_replies']; |
|
1250 | + if (isset($context['start_from']) && $context['start_from'] >= $context['topicinfo']['num_replies']) { |
|
1251 | + $context['start_from'] = $context['topicinfo']['num_replies']; |
|
1252 | + } |
|
1213 | 1253 | |
1214 | 1254 | // Since the anchor information is needed on the top of the page we load these variables beforehand. |
1215 | 1255 | $context['first_message'] = isset($messages[$firstIndex]) ? $messages[$firstIndex] : $messages[0]; |
1216 | - if (empty($options['view_newest_first'])) |
|
1217 | - $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from']; |
|
1218 | - else |
|
1219 | - $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from']; |
|
1220 | - } |
|
1221 | - else |
|
1256 | + if (empty($options['view_newest_first'])) { |
|
1257 | + $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['start_from']; |
|
1258 | + } else { |
|
1259 | + $context['first_new_message'] = isset($context['start_from']) && $_REQUEST['start'] == $context['topicinfo']['num_replies'] - $context['start_from']; |
|
1260 | + } |
|
1261 | + } else |
|
1222 | 1262 | { |
1223 | 1263 | $messages_request = false; |
1224 | 1264 | $context['first_message'] = 0; |
@@ -1253,8 +1293,9 @@ discard block |
||
1253 | 1293 | 'can_restore_msg' => 'move_any', |
1254 | 1294 | 'can_like' => 'likes_like', |
1255 | 1295 | ); |
1256 | - foreach ($common_permissions as $contextual => $perm) |
|
1257 | - $context[$contextual] = allowedTo($perm); |
|
1296 | + foreach ($common_permissions as $contextual => $perm) { |
|
1297 | + $context[$contextual] = allowedTo($perm); |
|
1298 | + } |
|
1258 | 1299 | |
1259 | 1300 | // Permissions with _any/_own versions. $context[YYY] => ZZZ_any/_own. |
1260 | 1301 | $anyown_permissions = array( |
@@ -1267,8 +1308,9 @@ discard block |
||
1267 | 1308 | 'can_reply_unapproved' => 'post_unapproved_replies', |
1268 | 1309 | 'can_view_warning' => 'profile_warning', |
1269 | 1310 | ); |
1270 | - foreach ($anyown_permissions as $contextual => $perm) |
|
1271 | - $context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own')); |
|
1311 | + foreach ($anyown_permissions as $contextual => $perm) { |
|
1312 | + $context[$contextual] = allowedTo($perm . '_any') || ($context['user']['started'] && allowedTo($perm . '_own')); |
|
1313 | + } |
|
1272 | 1314 | |
1273 | 1315 | if (!$user_info['is_admin'] && $context['can_move'] && !$modSettings['topic_move_any']) |
1274 | 1316 | { |
@@ -1314,8 +1356,9 @@ discard block |
||
1314 | 1356 | // Check if the draft functions are enabled and that they have permission to use them (for quick reply.) |
1315 | 1357 | $context['drafts_save'] = !empty($modSettings['drafts_post_enabled']) && allowedTo('post_draft') && $context['can_reply']; |
1316 | 1358 | $context['drafts_autosave'] = !empty($context['drafts_save']) && !empty($modSettings['drafts_autosave_enabled']); |
1317 | - if (!empty($context['drafts_save'])) |
|
1318 | - loadLanguage('Drafts'); |
|
1359 | + if (!empty($context['drafts_save'])) { |
|
1360 | + loadLanguage('Drafts'); |
|
1361 | + } |
|
1319 | 1362 | |
1320 | 1363 | // When was the last time this topic was replied to? Should we warn them about it? |
1321 | 1364 | if (!empty($modSettings['oldTopicDays']) && ($context['can_reply'] || $context['can_reply_unapproved']) && empty($context['topicinfo']['is_sticky'])) |
@@ -1376,26 +1419,31 @@ discard block |
||
1376 | 1419 | // Message icons - customized icons are off? |
1377 | 1420 | $context['icons'] = getMessageIcons($board); |
1378 | 1421 | |
1379 | - if (!empty($context['icons'])) |
|
1380 | - $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1422 | + if (!empty($context['icons'])) { |
|
1423 | + $context['icons'][count($context['icons']) - 1]['is_last'] = true; |
|
1424 | + } |
|
1381 | 1425 | |
1382 | 1426 | // Build the normal button array. |
1383 | 1427 | $context['normal_buttons'] = array(); |
1384 | 1428 | |
1385 | - if ($context['can_reply']) |
|
1386 | - $context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true); |
|
1429 | + if ($context['can_reply']) { |
|
1430 | + $context['normal_buttons']['reply'] = array('text' => 'reply', 'image' => 'reply.png', 'url' => $scripturl . '?action=post;topic=' . $context['current_topic'] . '.' . $context['start'] . ';last_msg=' . $context['topic_last_message'], 'active' => true); |
|
1431 | + } |
|
1387 | 1432 | |
1388 | - if ($context['can_add_poll']) |
|
1389 | - $context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
1433 | + if ($context['can_add_poll']) { |
|
1434 | + $context['normal_buttons']['add_poll'] = array('text' => 'add_poll', 'image' => 'add_poll.png', 'url' => $scripturl . '?action=editpoll;add;topic=' . $context['current_topic'] . '.' . $context['start']); |
|
1435 | + } |
|
1390 | 1436 | |
1391 | - if ($context['can_mark_unread']) |
|
1392 | - $context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1437 | + if ($context['can_mark_unread']) { |
|
1438 | + $context['normal_buttons']['mark_unread'] = array('text' => 'mark_unread', 'image' => 'markunread.png', 'url' => $scripturl . '?action=markasread;sa=topic;t=' . $context['mark_unread_time'] . ';topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1439 | + } |
|
1393 | 1440 | |
1394 | - if ($context['can_print']) |
|
1395 | - $context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'); |
|
1441 | + if ($context['can_print']) { |
|
1442 | + $context['normal_buttons']['print'] = array('text' => 'print', 'image' => 'print.png', 'custom' => 'rel="nofollow"', 'url' => $scripturl . '?action=printpage;topic=' . $context['current_topic'] . '.0'); |
|
1443 | + } |
|
1396 | 1444 | |
1397 | - if ($context['can_set_notify']) |
|
1398 | - $context['normal_buttons']['notify'] = array( |
|
1445 | + if ($context['can_set_notify']) { |
|
1446 | + $context['normal_buttons']['notify'] = array( |
|
1399 | 1447 | 'text' => 'notify_topic_' . $context['topic_notification_mode'], |
1400 | 1448 | 'sub_buttons' => array( |
1401 | 1449 | array( |
@@ -1417,38 +1465,47 @@ discard block |
||
1417 | 1465 | ), |
1418 | 1466 | ), |
1419 | 1467 | ); |
1468 | + } |
|
1420 | 1469 | |
1421 | 1470 | // Build the mod button array |
1422 | 1471 | $context['mod_buttons'] = array(); |
1423 | 1472 | |
1424 | - if ($context['can_move']) |
|
1425 | - $context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1473 | + if ($context['can_move']) { |
|
1474 | + $context['mod_buttons']['move'] = array('text' => 'move_topic', 'image' => 'admin_move.png', 'url' => $scripturl . '?action=movetopic;current_board=' . $context['current_board'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1475 | + } |
|
1426 | 1476 | |
1427 | - if ($context['can_delete']) |
|
1428 | - $context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
1477 | + if ($context['can_delete']) { |
|
1478 | + $context['mod_buttons']['delete'] = array('text' => 'remove_topic', 'image' => 'admin_rem.png', 'custom' => 'data-confirm="' . $txt['are_sure_remove_topic'] . '"', 'class' => 'you_sure', 'url' => $scripturl . '?action=removetopic2;topic=' . $context['current_topic'] . '.0;' . $context['session_var'] . '=' . $context['session_id']); |
|
1479 | + } |
|
1429 | 1480 | |
1430 | - if ($context['can_lock']) |
|
1431 | - $context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1481 | + if ($context['can_lock']) { |
|
1482 | + $context['mod_buttons']['lock'] = array('text' => empty($context['is_locked']) ? 'set_lock' : 'set_unlock', 'image' => 'admin_lock.png', 'url' => $scripturl . '?action=lock;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1483 | + } |
|
1432 | 1484 | |
1433 | - if ($context['can_sticky']) |
|
1434 | - $context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1485 | + if ($context['can_sticky']) { |
|
1486 | + $context['mod_buttons']['sticky'] = array('text' => empty($context['is_sticky']) ? 'set_sticky' : 'set_nonsticky', 'image' => 'admin_sticky.png', 'url' => $scripturl . '?action=sticky;topic=' . $context['current_topic'] . '.' . $context['start'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1487 | + } |
|
1435 | 1488 | |
1436 | - if ($context['can_merge']) |
|
1437 | - $context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']); |
|
1489 | + if ($context['can_merge']) { |
|
1490 | + $context['mod_buttons']['merge'] = array('text' => 'merge', 'image' => 'merge.png', 'url' => $scripturl . '?action=mergetopics;board=' . $context['current_board'] . '.0;from=' . $context['current_topic']); |
|
1491 | + } |
|
1438 | 1492 | |
1439 | - if ($context['calendar_post']) |
|
1440 | - $context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1493 | + if ($context['calendar_post']) { |
|
1494 | + $context['mod_buttons']['calendar'] = array('text' => 'calendar_link', 'image' => 'linktocal.png', 'url' => $scripturl . '?action=post;calendar;msg=' . $context['topic_first_message'] . ';topic=' . $context['current_topic'] . '.0'); |
|
1495 | + } |
|
1441 | 1496 | |
1442 | 1497 | // Restore topic. eh? No monkey business. |
1443 | - if ($context['can_restore_topic']) |
|
1444 | - $context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1498 | + if ($context['can_restore_topic']) { |
|
1499 | + $context['mod_buttons']['restore_topic'] = array('text' => 'restore_topic', 'image' => '', 'url' => $scripturl . '?action=restoretopic;topics=' . $context['current_topic'] . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1500 | + } |
|
1445 | 1501 | |
1446 | 1502 | // Show a message in case a recently posted message became unapproved. |
1447 | 1503 | $context['becomesUnapproved'] = !empty($_SESSION['becomesUnapproved']) ? true : false; |
1448 | 1504 | |
1449 | 1505 | // Don't want to show this forever... |
1450 | - if ($context['becomesUnapproved']) |
|
1451 | - unset($_SESSION['becomesUnapproved']); |
|
1506 | + if ($context['becomesUnapproved']) { |
|
1507 | + unset($_SESSION['becomesUnapproved']); |
|
1508 | + } |
|
1452 | 1509 | |
1453 | 1510 | // Allow adding new mod buttons easily. |
1454 | 1511 | // Note: $context['normal_buttons'] and $context['mod_buttons'] are added for backward compatibility with 2.0, but are deprecated and should not be used |
@@ -1457,12 +1514,14 @@ discard block |
||
1457 | 1514 | call_integration_hook('integrate_mod_buttons', array(&$context['mod_buttons'])); |
1458 | 1515 | |
1459 | 1516 | // Load the drafts js file |
1460 | - if ($context['drafts_autosave']) |
|
1461 | - loadJavaScriptFile('drafts.js', array('defer' => false), 'smf_drafts'); |
|
1517 | + if ($context['drafts_autosave']) { |
|
1518 | + loadJavaScriptFile('drafts.js', array('defer' => false), 'smf_drafts'); |
|
1519 | + } |
|
1462 | 1520 | |
1463 | 1521 | // Spellcheck |
1464 | - if ($context['show_spellchecking']) |
|
1465 | - loadJavaScriptFile('spellcheck.js', array('defer' => false), 'smf_spellcheck'); |
|
1522 | + if ($context['show_spellchecking']) { |
|
1523 | + loadJavaScriptFile('spellcheck.js', array('defer' => false), 'smf_spellcheck'); |
|
1524 | + } |
|
1466 | 1525 | |
1467 | 1526 | // topic.js |
1468 | 1527 | loadJavaScriptFile('topic.js', array('defer' => false), 'smf_topic'); |
@@ -1496,16 +1555,19 @@ discard block |
||
1496 | 1555 | static $counter = null; |
1497 | 1556 | |
1498 | 1557 | // If the query returned false, bail. |
1499 | - if ($messages_request == false) |
|
1500 | - return false; |
|
1558 | + if ($messages_request == false) { |
|
1559 | + return false; |
|
1560 | + } |
|
1501 | 1561 | |
1502 | 1562 | // Remember which message this is. (ie. reply #83) |
1503 | - if ($counter === null || $reset) |
|
1504 | - $counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start']; |
|
1563 | + if ($counter === null || $reset) { |
|
1564 | + $counter = empty($options['view_newest_first']) ? $context['start'] : $context['total_visible_posts'] - $context['start']; |
|
1565 | + } |
|
1505 | 1566 | |
1506 | 1567 | // Start from the beginning... |
1507 | - if ($reset) |
|
1508 | - return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1568 | + if ($reset) { |
|
1569 | + return @$smcFunc['db_data_seek']($messages_request, 0); |
|
1570 | + } |
|
1509 | 1571 | |
1510 | 1572 | // Attempt to get the next message. |
1511 | 1573 | $message = $smcFunc['db_fetch_assoc']($messages_request); |
@@ -1519,19 +1581,21 @@ discard block |
||
1519 | 1581 | if (empty($context['icon_sources'])) |
1520 | 1582 | { |
1521 | 1583 | $context['icon_sources'] = array(); |
1522 | - foreach ($context['stable_icons'] as $icon) |
|
1523 | - $context['icon_sources'][$icon] = 'images_url'; |
|
1584 | + foreach ($context['stable_icons'] as $icon) { |
|
1585 | + $context['icon_sources'][$icon] = 'images_url'; |
|
1586 | + } |
|
1524 | 1587 | } |
1525 | 1588 | |
1526 | 1589 | // Message Icon Management... check the images exist. |
1527 | 1590 | if (empty($modSettings['messageIconChecks_disable'])) |
1528 | 1591 | { |
1529 | 1592 | // If the current icon isn't known, then we need to do something... |
1530 | - if (!isset($context['icon_sources'][$message['icon']])) |
|
1531 | - $context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
1593 | + if (!isset($context['icon_sources'][$message['icon']])) { |
|
1594 | + $context['icon_sources'][$message['icon']] = file_exists($settings['theme_dir'] . '/images/post/' . $message['icon'] . '.png') ? 'images_url' : 'default_images_url'; |
|
1595 | + } |
|
1596 | + } elseif (!isset($context['icon_sources'][$message['icon']])) { |
|
1597 | + $context['icon_sources'][$message['icon']] = 'images_url'; |
|
1532 | 1598 | } |
1533 | - elseif (!isset($context['icon_sources'][$message['icon']])) |
|
1534 | - $context['icon_sources'][$message['icon']] = 'images_url'; |
|
1535 | 1599 | |
1536 | 1600 | // If you're a lazy bum, you probably didn't give a subject... |
1537 | 1601 | $message['subject'] = $message['subject'] != '' ? $message['subject'] : $txt['no_subject']; |
@@ -1556,8 +1620,7 @@ discard block |
||
1556 | 1620 | $memberContext[$message['id_member']]['email'] = $message['poster_email']; |
1557 | 1621 | $memberContext[$message['id_member']]['show_email'] = allowedTo('moderate_forum'); |
1558 | 1622 | $memberContext[$message['id_member']]['is_guest'] = true; |
1559 | - } |
|
1560 | - else |
|
1623 | + } else |
|
1561 | 1624 | { |
1562 | 1625 | // Define this here to make things a bit more readable |
1563 | 1626 | $can_view_warning = $context['user']['can_mod'] || allowedTo('view_warning_any') || ($message['id_member'] == $user_info['id'] && allowedTo('view_warning_own')); |
@@ -1580,8 +1643,9 @@ discard block |
||
1580 | 1643 | $message['body'] = parse_bbc($message['body'], $message['smileys_enabled'], $message['id_msg']); |
1581 | 1644 | |
1582 | 1645 | // If it's in the recycle bin we need to override whatever icon we did have. |
1583 | - if (!empty($board_info['recycle'])) |
|
1584 | - $message['icon'] = 'recycled'; |
|
1646 | + if (!empty($board_info['recycle'])) { |
|
1647 | + $message['icon'] = 'recycled'; |
|
1648 | + } |
|
1585 | 1649 | |
1586 | 1650 | require_once($sourcedir . '/Subs-Attachments.php'); |
1587 | 1651 | |
@@ -1625,32 +1689,36 @@ discard block |
||
1625 | 1689 | } |
1626 | 1690 | |
1627 | 1691 | // Are likes enable? |
1628 | - if (!empty($modSettings['enable_likes'])) |
|
1629 | - $output['likes'] = array( |
|
1692 | + if (!empty($modSettings['enable_likes'])) { |
|
1693 | + $output['likes'] = array( |
|
1630 | 1694 | 'count' => $message['likes'], |
1631 | 1695 | 'you' => in_array($message['id_msg'], $context['my_likes']), |
1632 | 1696 | 'can_like' => !$context['user']['is_guest'] && $message['id_member'] != $context['user']['id'] && !empty($context['can_like']), |
1633 | 1697 | ); |
1698 | + } |
|
1634 | 1699 | |
1635 | 1700 | // Is this user the message author? |
1636 | 1701 | $output['is_message_author'] = $message['id_member'] == $user_info['id']; |
1637 | - if (!empty($output['modified']['name'])) |
|
1638 | - $output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']); |
|
1702 | + if (!empty($output['modified']['name'])) { |
|
1703 | + $output['modified']['last_edit_text'] = sprintf($txt['last_edit_by'], $output['modified']['time'], $output['modified']['name']); |
|
1704 | + } |
|
1639 | 1705 | |
1640 | 1706 | // Did they give a reason for editing? |
1641 | - if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) |
|
1642 | - $output['modified']['last_edit_text'] .= ' ' . sprintf($txt['last_edit_reason'], $output['modified']['reason']); |
|
1707 | + if (!empty($output['modified']['name']) && !empty($output['modified']['reason'])) { |
|
1708 | + $output['modified']['last_edit_text'] .= ' ' . sprintf($txt['last_edit_reason'], $output['modified']['reason']); |
|
1709 | + } |
|
1643 | 1710 | |
1644 | 1711 | // Any custom profile fields? |
1645 | - if (!empty($memberContext[$message['id_member']]['custom_fields'])) |
|
1646 | - foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom) |
|
1712 | + if (!empty($memberContext[$message['id_member']]['custom_fields'])) { |
|
1713 | + foreach ($memberContext[$message['id_member']]['custom_fields'] as $custom) |
|
1647 | 1714 | $output['custom_fields'][$context['cust_profile_fields_placement'][$custom['placement']]][] = $custom; |
1715 | + } |
|
1648 | 1716 | |
1649 | - if (empty($options['view_newest_first'])) |
|
1650 | - $counter++; |
|
1651 | - |
|
1652 | - else |
|
1653 | - $counter--; |
|
1717 | + if (empty($options['view_newest_first'])) { |
|
1718 | + $counter++; |
|
1719 | + } else { |
|
1720 | + $counter--; |
|
1721 | + } |
|
1654 | 1722 | |
1655 | 1723 | call_integration_hook('integrate_prepare_display_context', array(&$output, &$message, $counter)); |
1656 | 1724 | |
@@ -1676,8 +1744,9 @@ discard block |
||
1676 | 1744 | */ |
1677 | 1745 | function approved_attach_sort($a, $b) |
1678 | 1746 | { |
1679 | - if ($a['is_approved'] == $b['is_approved']) |
|
1680 | - return 0; |
|
1747 | + if ($a['is_approved'] == $b['is_approved']) { |
|
1748 | + return 0; |
|
1749 | + } |
|
1681 | 1750 | |
1682 | 1751 | return $a['is_approved'] > $b['is_approved'] ? -1 : 1; |
1683 | 1752 | } |
@@ -1694,16 +1763,19 @@ discard block |
||
1694 | 1763 | |
1695 | 1764 | require_once($sourcedir . '/RemoveTopic.php'); |
1696 | 1765 | |
1697 | - if (empty($_REQUEST['msgs'])) |
|
1698 | - redirectexit('topic=' . $topic . '.' . $_REQUEST['start']); |
|
1766 | + if (empty($_REQUEST['msgs'])) { |
|
1767 | + redirectexit('topic=' . $topic . '.' . $_REQUEST['start']); |
|
1768 | + } |
|
1699 | 1769 | |
1700 | 1770 | $messages = array(); |
1701 | - foreach ($_REQUEST['msgs'] as $dummy) |
|
1702 | - $messages[] = (int) $dummy; |
|
1771 | + foreach ($_REQUEST['msgs'] as $dummy) { |
|
1772 | + $messages[] = (int) $dummy; |
|
1773 | + } |
|
1703 | 1774 | |
1704 | 1775 | // We are restoring messages. We handle this in another place. |
1705 | - if (isset($_REQUEST['restore_selected'])) |
|
1706 | - redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1776 | + if (isset($_REQUEST['restore_selected'])) { |
|
1777 | + redirectexit('action=restoretopic;msgs=' . implode(',', $messages) . ';' . $context['session_var'] . '=' . $context['session_id']); |
|
1778 | + } |
|
1707 | 1779 | if (isset($_REQUEST['split_selection'])) |
1708 | 1780 | { |
1709 | 1781 | $request = $smcFunc['db_query']('', ' |
@@ -1722,8 +1794,9 @@ discard block |
||
1722 | 1794 | } |
1723 | 1795 | |
1724 | 1796 | // Allowed to delete any message? |
1725 | - if (allowedTo('delete_any')) |
|
1726 | - $allowed_all = true; |
|
1797 | + if (allowedTo('delete_any')) { |
|
1798 | + $allowed_all = true; |
|
1799 | + } |
|
1727 | 1800 | // Allowed to delete replies to their messages? |
1728 | 1801 | elseif (allowedTo('delete_replies')) |
1729 | 1802 | { |
@@ -1740,13 +1813,14 @@ discard block |
||
1740 | 1813 | $smcFunc['db_free_result']($request); |
1741 | 1814 | |
1742 | 1815 | $allowed_all = $starter == $user_info['id']; |
1816 | + } else { |
|
1817 | + $allowed_all = false; |
|
1743 | 1818 | } |
1744 | - else |
|
1745 | - $allowed_all = false; |
|
1746 | 1819 | |
1747 | 1820 | // Make sure they're allowed to delete their own messages, if not any. |
1748 | - if (!$allowed_all) |
|
1749 | - isAllowedTo('delete_own'); |
|
1821 | + if (!$allowed_all) { |
|
1822 | + isAllowedTo('delete_own'); |
|
1823 | + } |
|
1750 | 1824 | |
1751 | 1825 | // Allowed to remove which messages? |
1752 | 1826 | $request = $smcFunc['db_query']('', ' |
@@ -1766,8 +1840,9 @@ discard block |
||
1766 | 1840 | $messages = array(); |
1767 | 1841 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1768 | 1842 | { |
1769 | - if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) |
|
1770 | - continue; |
|
1843 | + if (!$allowed_all && !empty($modSettings['edit_disable_time']) && $row['poster_time'] + $modSettings['edit_disable_time'] * 60 < time()) { |
|
1844 | + continue; |
|
1845 | + } |
|
1771 | 1846 | |
1772 | 1847 | $messages[$row['id_msg']] = array($row['subject'], $row['id_member']); |
1773 | 1848 | } |
@@ -1790,17 +1865,20 @@ discard block |
||
1790 | 1865 | foreach ($messages as $message => $info) |
1791 | 1866 | { |
1792 | 1867 | // Just skip the first message - if it's not the last. |
1793 | - if ($message == $first_message && $message != $last_message) |
|
1794 | - continue; |
|
1868 | + if ($message == $first_message && $message != $last_message) { |
|
1869 | + continue; |
|
1870 | + } |
|
1795 | 1871 | // If the first message is going then don't bother going back to the topic as we're effectively deleting it. |
1796 | - elseif ($message == $first_message) |
|
1797 | - $topicGone = true; |
|
1872 | + elseif ($message == $first_message) { |
|
1873 | + $topicGone = true; |
|
1874 | + } |
|
1798 | 1875 | |
1799 | 1876 | removeMessage($message); |
1800 | 1877 | |
1801 | 1878 | // Log this moderation action ;). |
1802 | - if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) |
|
1803 | - logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board)); |
|
1879 | + if (allowedTo('delete_any') && (!allowedTo('delete_own') || $info[1] != $user_info['id'])) { |
|
1880 | + logAction('delete', array('topic' => $topic, 'subject' => $info[0], 'member' => $info[1], 'board' => $board)); |
|
1881 | + } |
|
1804 | 1882 | } |
1805 | 1883 | |
1806 | 1884 | redirectexit(!empty($topicGone) ? 'board=' . $board : 'topic=' . $topic . '.' . $_REQUEST['start']); |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -23,15 +23,15 @@ discard block |
||
23 | 23 | { |
24 | 24 | global $context, $txt; |
25 | 25 | |
26 | - if (!empty($context['simple_action'])) |
|
27 | - echo ' |
|
26 | + if (!empty($context['simple_action'])) { |
|
27 | + echo ' |
|
28 | 28 | <strong> |
29 | 29 | ', $context['error_title'], ' |
30 | 30 | </strong><br> |
31 | 31 | <div ', $context['error_code'], 'class="padding"> |
32 | 32 | ', $context['error_message'], ' |
33 | 33 | </div>'; |
34 | - else |
|
34 | + } else |
|
35 | 35 | { |
36 | 36 | echo ' |
37 | 37 | <div id="fatal_error"> |
@@ -85,21 +85,23 @@ discard block |
||
85 | 85 | |
86 | 86 | $error_types = array(); |
87 | 87 | |
88 | - foreach ($context['error_types'] as $type => $details) |
|
89 | - $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
88 | + foreach ($context['error_types'] as $type => $details) { |
|
89 | + $error_types[] = ($details['is_selected'] ? '<img src="' . $settings['images_url'] . '/selected.png" alt=""> ' : '') . '<a href="' . $details['url'] . '" ' . ($details['is_selected'] ? 'style="font-weight: bold;"' : '') . ' title="' . $details['description'] . '">' . $details['label'] . '</a>'; |
|
90 | + } |
|
90 | 91 | |
91 | 92 | echo ' |
92 | 93 | ', implode(' | ', $error_types), ' |
93 | 94 | </td> |
94 | 95 | </tr>'; |
95 | 96 | |
96 | - if ($context['has_filter']) |
|
97 | - echo ' |
|
97 | + if ($context['has_filter']) { |
|
98 | + echo ' |
|
98 | 99 | <tr> |
99 | 100 | <td colspan="3" class="windowbg"> |
100 | 101 | <strong>', $txt['applying_filter'], ':</strong> ', $context['filter']['entity'], ' ', $context['filter']['value']['html'], ' [<a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', '">', $txt['clear_filter'], '</a>] |
101 | 102 | </td> |
102 | 103 | </tr>'; |
104 | + } |
|
103 | 105 | |
104 | 106 | echo ' |
105 | 107 | <tr> |
@@ -110,11 +112,12 @@ discard block |
||
110 | 112 | </tr>'; |
111 | 113 | |
112 | 114 | // No errors, then show a message |
113 | - if (count($context['errors']) == 0) |
|
114 | - echo ' |
|
115 | + if (count($context['errors']) == 0) { |
|
116 | + echo ' |
|
115 | 117 | <tr class="windowbg"> |
116 | 118 | <td class="centertext" colspan="2">', $txt['errlog_no_entries'], '</td> |
117 | 119 | </tr>'; |
120 | + } |
|
118 | 121 | |
119 | 122 | // We have some errors, must be some mods installed :P |
120 | 123 | foreach ($context['errors'] as $error) |
@@ -128,16 +131,18 @@ discard block |
||
128 | 131 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? '' : ';desc', $context['has_filter'] ? $context['filter']['href'] : '', '" title="', $txt['reverse_direction'], '"><span class="generic_icons sort_' . $context['sort_direction'] . '"></span></a> |
129 | 132 | ', $error['time'], '<br>'; |
130 | 133 | |
131 | - if (!empty($error['member']['ip'])) |
|
132 | - echo ' |
|
134 | + if (!empty($error['member']['ip'])) { |
|
135 | + echo ' |
|
133 | 136 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=ip;value=', $error['member']['ip'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_ip'], '"><span class="generic_icons filter centericon"></span></a> |
134 | 137 | <strong><a href="', $scripturl, '?action=trackip;searchip=', $error['member']['ip'], '">', $error['member']['ip'], '</a></strong>'; |
138 | + } |
|
135 | 139 | |
136 | - if ($error['member']['session'] != '') |
|
137 | - echo ' |
|
140 | + if ($error['member']['session'] != '') { |
|
141 | + echo ' |
|
138 | 142 | <br> |
139 | 143 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=session;value=', $error['member']['session'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_session'], '"><span class="generic_icons filter centericon"></span></a> |
140 | 144 | ', $error['member']['session'], '<br>'; |
145 | + } |
|
141 | 146 | |
142 | 147 | echo ' |
143 | 148 | </div> |
@@ -152,12 +157,13 @@ discard block |
||
152 | 157 | <a href="', $error['url']['html'], '">', $error['url']['html'], '</a> |
153 | 158 | '; |
154 | 159 | |
155 | - if (!empty($error['file'])) |
|
156 | - echo ' |
|
160 | + if (!empty($error['file'])) { |
|
161 | + echo ' |
|
157 | 162 | <div> |
158 | 163 | <a href="', $scripturl, '?action=admin;area=logs;sa=errorlog', $context['sort_direction'] == 'down' ? ';desc' : '', ';filter=file;value=', $error['file']['search'], '" title="', $txt['apply_filter'], ': ', $txt['filter_only_file'], '">' |
159 | 164 | . ' <span class="generic_icons filter"></span></a> ', $error['file']['link'], ' (', $txt['line'], ' ', $error['file']['line'], ') |
160 | 165 | </div>'; |
166 | + } |
|
161 | 167 | |
162 | 168 | echo ' |
163 | 169 | </div> |
@@ -186,9 +192,10 @@ discard block |
||
186 | 192 | </div> |
187 | 193 | </div>'; |
188 | 194 | |
189 | - if ($context['sort_direction'] == 'down') |
|
190 | - echo ' |
|
195 | + if ($context['sort_direction'] == 'down') { |
|
196 | + echo ' |
|
191 | 197 | <input type="hidden" name="desc" value="1">'; |
198 | + } |
|
192 | 199 | |
193 | 200 | echo ' |
194 | 201 | <input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '"> |
@@ -30,8 +30,9 @@ discard block |
||
30 | 30 | * @version 2.1 Beta 4 |
31 | 31 | */ |
32 | 32 | |
33 | -if (!defined('SMF')) |
|
33 | +if (!defined('SMF')) { |
|
34 | 34 | die('No direct access...'); |
35 | +} |
|
35 | 36 | |
36 | 37 | /** |
37 | 38 | * Subaction handler - manages the action and delegates control to the proper |
@@ -103,12 +104,12 @@ discard block |
||
103 | 104 | cache_put_data('minimized_css', null); |
104 | 105 | |
105 | 106 | // Follow the sa or just go to administration. |
106 | - if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) |
|
107 | - call_helper($subActions[$_GET['sa']]); |
|
108 | - |
|
109 | - else |
|
110 | - call_helper($subActions['admin']); |
|
111 | -} |
|
107 | + if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) { |
|
108 | + call_helper($subActions[$_GET['sa']]); |
|
109 | + } else { |
|
110 | + call_helper($subActions['admin']); |
|
111 | + } |
|
112 | + } |
|
112 | 113 | |
113 | 114 | /** |
114 | 115 | * This function allows administration of themes and their settings, |
@@ -130,15 +131,16 @@ discard block |
||
130 | 131 | checkSession(); |
131 | 132 | validateToken('admin-tm'); |
132 | 133 | |
133 | - if (isset($_POST['options']['known_themes'])) |
|
134 | - foreach ($_POST['options']['known_themes'] as $key => $id) |
|
134 | + if (isset($_POST['options']['known_themes'])) { |
|
135 | + foreach ($_POST['options']['known_themes'] as $key => $id) |
|
135 | 136 | $_POST['options']['known_themes'][$key] = (int) $id; |
137 | + } else { |
|
138 | + fatal_lang_error('themes_none_selectable', false); |
|
139 | + } |
|
136 | 140 | |
137 | - else |
|
138 | - fatal_lang_error('themes_none_selectable', false); |
|
139 | - |
|
140 | - if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) |
|
141 | - fatal_lang_error('themes_default_selectable', false); |
|
141 | + if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) { |
|
142 | + fatal_lang_error('themes_default_selectable', false); |
|
143 | + } |
|
142 | 144 | |
143 | 145 | // Commit the new settings. |
144 | 146 | updateSettings(array( |
@@ -146,8 +148,9 @@ discard block |
||
146 | 148 | 'theme_guests' => $_POST['options']['theme_guests'], |
147 | 149 | 'knownThemes' => implode(',', $_POST['options']['known_themes']), |
148 | 150 | )); |
149 | - if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) |
|
150 | - updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
151 | + if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) { |
|
152 | + updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
153 | + } |
|
151 | 154 | |
152 | 155 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=admin'); |
153 | 156 | } |
@@ -166,8 +169,9 @@ discard block |
||
166 | 169 | // Look for a non existent theme directory. (ie theme87.) |
167 | 170 | $theme_dir = $boarddir . '/Themes/theme'; |
168 | 171 | $i = 1; |
169 | - while (file_exists($theme_dir . $i)) |
|
170 | - $i++; |
|
172 | + while (file_exists($theme_dir . $i)) { |
|
173 | + $i++; |
|
174 | + } |
|
171 | 175 | |
172 | 176 | $context['new_theme_name'] = 'theme' . $i; |
173 | 177 | |
@@ -189,8 +193,9 @@ discard block |
||
189 | 193 | loadLanguage('Admin'); |
190 | 194 | isAllowedTo('admin_forum'); |
191 | 195 | |
192 | - if (isset($_REQUEST['th'])) |
|
193 | - return SetThemeSettings(); |
|
196 | + if (isset($_REQUEST['th'])) { |
|
197 | + return SetThemeSettings(); |
|
198 | + } |
|
194 | 199 | |
195 | 200 | if (isset($_POST['save'])) |
196 | 201 | { |
@@ -274,12 +279,13 @@ discard block |
||
274 | 279 | $context['themes'] = array(); |
275 | 280 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
276 | 281 | { |
277 | - if (!isset($context['themes'][$row['id_theme']])) |
|
278 | - $context['themes'][$row['id_theme']] = array( |
|
282 | + if (!isset($context['themes'][$row['id_theme']])) { |
|
283 | + $context['themes'][$row['id_theme']] = array( |
|
279 | 284 | 'id' => $row['id_theme'], |
280 | 285 | 'num_default_options' => 0, |
281 | 286 | 'num_members' => 0, |
282 | 287 | ); |
288 | + } |
|
283 | 289 | $context['themes'][$row['id_theme']][$row['variable']] = $row['value']; |
284 | 290 | } |
285 | 291 | $smcFunc['db_free_result']($request); |
@@ -293,8 +299,9 @@ discard block |
||
293 | 299 | 'guest_member' => -1, |
294 | 300 | ) |
295 | 301 | ); |
296 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
297 | - $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
302 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
303 | + $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
304 | + } |
|
298 | 305 | $smcFunc['db_free_result']($request); |
299 | 306 | |
300 | 307 | // Need to make sure we don't do custom fields. |
@@ -305,8 +312,9 @@ discard block |
||
305 | 312 | ) |
306 | 313 | ); |
307 | 314 | $customFields = array(); |
308 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
309 | - $customFields[] = $row['col_name']; |
|
315 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
316 | + $customFields[] = $row['col_name']; |
|
317 | + } |
|
310 | 318 | $smcFunc['db_free_result']($request); |
311 | 319 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
312 | 320 | |
@@ -321,14 +329,16 @@ discard block |
||
321 | 329 | 'custom_fields' => empty($customFields) ? array() : $customFields, |
322 | 330 | ) |
323 | 331 | ); |
324 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
325 | - $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
332 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
333 | + $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
334 | + } |
|
326 | 335 | $smcFunc['db_free_result']($request); |
327 | 336 | |
328 | 337 | // There has to be a Settings template! |
329 | - foreach ($context['themes'] as $k => $v) |
|
330 | - if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
338 | + foreach ($context['themes'] as $k => $v) { |
|
339 | + if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
331 | 340 | unset($context['themes'][$k]); |
341 | + } |
|
332 | 342 | |
333 | 343 | loadTemplate('Themes'); |
334 | 344 | $context['sub_template'] = 'reset_list'; |
@@ -343,16 +353,19 @@ discard block |
||
343 | 353 | checkSession(); |
344 | 354 | validateToken('admin-sto'); |
345 | 355 | |
346 | - if (empty($_POST['options'])) |
|
347 | - $_POST['options'] = array(); |
|
348 | - if (empty($_POST['default_options'])) |
|
349 | - $_POST['default_options'] = array(); |
|
356 | + if (empty($_POST['options'])) { |
|
357 | + $_POST['options'] = array(); |
|
358 | + } |
|
359 | + if (empty($_POST['default_options'])) { |
|
360 | + $_POST['default_options'] = array(); |
|
361 | + } |
|
350 | 362 | |
351 | 363 | // Set up the sql query. |
352 | 364 | $setValues = array(); |
353 | 365 | |
354 | - foreach ($_POST['options'] as $opt => $val) |
|
355 | - $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
366 | + foreach ($_POST['options'] as $opt => $val) { |
|
367 | + $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
368 | + } |
|
356 | 369 | |
357 | 370 | $old_settings = array(); |
358 | 371 | foreach ($_POST['default_options'] as $opt => $val) |
@@ -366,8 +379,8 @@ discard block |
||
366 | 379 | if (!empty($setValues)) |
367 | 380 | { |
368 | 381 | // Are there options in non-default themes set that should be cleared? |
369 | - if (!empty($old_settings)) |
|
370 | - $smcFunc['db_query']('', ' |
|
382 | + if (!empty($old_settings)) { |
|
383 | + $smcFunc['db_query']('', ' |
|
371 | 384 | DELETE FROM {db_prefix}themes |
372 | 385 | WHERE id_theme != {int:default_theme} |
373 | 386 | AND id_member = {int:guest_member} |
@@ -378,6 +391,7 @@ discard block |
||
378 | 391 | 'old_settings' => $old_settings, |
379 | 392 | ) |
380 | 393 | ); |
394 | + } |
|
381 | 395 | |
382 | 396 | $smcFunc['db_insert']('replace', |
383 | 397 | '{db_prefix}themes', |
@@ -391,8 +405,7 @@ discard block |
||
391 | 405 | cache_put_data('theme_settings-1', null, 90); |
392 | 406 | |
393 | 407 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
394 | - } |
|
395 | - elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
408 | + } elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
396 | 409 | { |
397 | 410 | checkSession(); |
398 | 411 | validateToken('admin-sto'); |
@@ -405,9 +418,9 @@ discard block |
||
405 | 418 | $old_settings = array(); |
406 | 419 | foreach ($_POST['default_options'] as $opt => $val) |
407 | 420 | { |
408 | - if ($_POST['default_options_master'][$opt] == 0) |
|
409 | - continue; |
|
410 | - elseif ($_POST['default_options_master'][$opt] == 1) |
|
421 | + if ($_POST['default_options_master'][$opt] == 0) { |
|
422 | + continue; |
|
423 | + } elseif ($_POST['default_options_master'][$opt] == 1) |
|
411 | 424 | { |
412 | 425 | // Delete then insert for ease of database compatibility! |
413 | 426 | $smcFunc['db_query']('substring', ' |
@@ -433,8 +446,7 @@ discard block |
||
433 | 446 | ); |
434 | 447 | |
435 | 448 | $old_settings[] = $opt; |
436 | - } |
|
437 | - elseif ($_POST['default_options_master'][$opt] == 2) |
|
449 | + } elseif ($_POST['default_options_master'][$opt] == 2) |
|
438 | 450 | { |
439 | 451 | $smcFunc['db_query']('', ' |
440 | 452 | DELETE FROM {db_prefix}themes |
@@ -449,8 +461,8 @@ discard block |
||
449 | 461 | } |
450 | 462 | |
451 | 463 | // Delete options from other themes. |
452 | - if (!empty($old_settings)) |
|
453 | - $smcFunc['db_query']('', ' |
|
464 | + if (!empty($old_settings)) { |
|
465 | + $smcFunc['db_query']('', ' |
|
454 | 466 | DELETE FROM {db_prefix}themes |
455 | 467 | WHERE id_theme != {int:default_theme} |
456 | 468 | AND id_member > {int:no_member} |
@@ -461,12 +473,13 @@ discard block |
||
461 | 473 | 'old_settings' => $old_settings, |
462 | 474 | ) |
463 | 475 | ); |
476 | + } |
|
464 | 477 | |
465 | 478 | foreach ($_POST['options'] as $opt => $val) |
466 | 479 | { |
467 | - if ($_POST['options_master'][$opt] == 0) |
|
468 | - continue; |
|
469 | - elseif ($_POST['options_master'][$opt] == 1) |
|
480 | + if ($_POST['options_master'][$opt] == 0) { |
|
481 | + continue; |
|
482 | + } elseif ($_POST['options_master'][$opt] == 1) |
|
470 | 483 | { |
471 | 484 | // Delete then insert for ease of database compatibility - again! |
472 | 485 | $smcFunc['db_query']('substring', ' |
@@ -491,8 +504,7 @@ discard block |
||
491 | 504 | 'value' => (is_array($val) ? implode(',', $val) : $val), |
492 | 505 | ) |
493 | 506 | ); |
494 | - } |
|
495 | - elseif ($_POST['options_master'][$opt] == 2) |
|
507 | + } elseif ($_POST['options_master'][$opt] == 2) |
|
496 | 508 | { |
497 | 509 | $smcFunc['db_query']('', ' |
498 | 510 | DELETE FROM {db_prefix}themes |
@@ -509,8 +521,7 @@ discard block |
||
509 | 521 | } |
510 | 522 | |
511 | 523 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
512 | - } |
|
513 | - elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
524 | + } elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
514 | 525 | { |
515 | 526 | checkSession('get'); |
516 | 527 | validateToken('admin-stor', 'request'); |
@@ -525,8 +536,9 @@ discard block |
||
525 | 536 | ) |
526 | 537 | ); |
527 | 538 | $customFields = array(); |
528 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
529 | - $customFields[] = $row['col_name']; |
|
539 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
540 | + $customFields[] = $row['col_name']; |
|
541 | + } |
|
530 | 542 | $smcFunc['db_free_result']($request); |
531 | 543 | } |
532 | 544 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
@@ -581,13 +593,13 @@ discard block |
||
581 | 593 | ) |
582 | 594 | ); |
583 | 595 | $context['theme_options'] = array(); |
584 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
585 | - $context['theme_options'][$row['variable']] = $row['value']; |
|
596 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
597 | + $context['theme_options'][$row['variable']] = $row['value']; |
|
598 | + } |
|
586 | 599 | $smcFunc['db_free_result']($request); |
587 | 600 | |
588 | 601 | $context['theme_options_reset'] = false; |
589 | - } |
|
590 | - else |
|
602 | + } else |
|
591 | 603 | { |
592 | 604 | $context['theme_options'] = array(); |
593 | 605 | $context['theme_options_reset'] = true; |
@@ -596,30 +608,32 @@ discard block |
||
596 | 608 | foreach ($context['options'] as $i => $setting) |
597 | 609 | { |
598 | 610 | // Just skip separators |
599 | - if (!is_array($setting)) |
|
600 | - continue; |
|
611 | + if (!is_array($setting)) { |
|
612 | + continue; |
|
613 | + } |
|
601 | 614 | |
602 | 615 | // Is this disabled? |
603 | 616 | if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
604 | 617 | { |
605 | 618 | unset($context['options'][$i]); |
606 | 619 | continue; |
607 | - } |
|
608 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
620 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
609 | 621 | { |
610 | 622 | unset($context['options'][$i]); |
611 | 623 | continue; |
612 | 624 | } |
613 | 625 | |
614 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
615 | - $context['options'][$i]['type'] = 'checkbox'; |
|
616 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
617 | - $context['options'][$i]['type'] = 'number'; |
|
618 | - elseif ($setting['type'] == 'string') |
|
619 | - $context['options'][$i]['type'] = 'text'; |
|
626 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
627 | + $context['options'][$i]['type'] = 'checkbox'; |
|
628 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
629 | + $context['options'][$i]['type'] = 'number'; |
|
630 | + } elseif ($setting['type'] == 'string') { |
|
631 | + $context['options'][$i]['type'] = 'text'; |
|
632 | + } |
|
620 | 633 | |
621 | - if (isset($setting['options'])) |
|
622 | - $context['options'][$i]['type'] = 'list'; |
|
634 | + if (isset($setting['options'])) { |
|
635 | + $context['options'][$i]['type'] = 'list'; |
|
636 | + } |
|
623 | 637 | |
624 | 638 | $context['options'][$i]['value'] = !isset($context['theme_options'][$setting['id']]) ? '' : $context['theme_options'][$setting['id']]; |
625 | 639 | } |
@@ -644,8 +658,9 @@ discard block |
||
644 | 658 | { |
645 | 659 | global $txt, $context, $settings, $modSettings, $smcFunc; |
646 | 660 | |
647 | - if (empty($_GET['th']) && empty($_GET['id'])) |
|
648 | - return ThemeAdmin(); |
|
661 | + if (empty($_GET['th']) && empty($_GET['id'])) { |
|
662 | + return ThemeAdmin(); |
|
663 | + } |
|
649 | 664 | |
650 | 665 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
651 | 666 | |
@@ -656,8 +671,9 @@ discard block |
||
656 | 671 | isAllowedTo('admin_forum'); |
657 | 672 | |
658 | 673 | // Validate inputs/user. |
659 | - if (empty($_GET['th'])) |
|
660 | - fatal_lang_error('no_theme', false); |
|
674 | + if (empty($_GET['th'])) { |
|
675 | + fatal_lang_error('no_theme', false); |
|
676 | + } |
|
661 | 677 | |
662 | 678 | // Fetch the smiley sets... |
663 | 679 | $sets = explode(',', 'none,' . $modSettings['smiley_sets_known']); |
@@ -665,8 +681,9 @@ discard block |
||
665 | 681 | $context['smiley_sets'] = array( |
666 | 682 | '' => $txt['smileys_no_default'] |
667 | 683 | ); |
668 | - foreach ($sets as $i => $set) |
|
669 | - $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
684 | + foreach ($sets as $i => $set) { |
|
685 | + $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
686 | + } |
|
670 | 687 | |
671 | 688 | $old_id = $settings['theme_id']; |
672 | 689 | $old_settings = $settings; |
@@ -691,8 +708,9 @@ discard block |
||
691 | 708 | if (file_exists($settings['theme_dir'] . '/index.template.php')) |
692 | 709 | { |
693 | 710 | $file_contents = implode('', file($settings['theme_dir'] . '/index.template.php')); |
694 | - if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) |
|
695 | - eval('global $settings;' . $matches[0]); |
|
711 | + if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) { |
|
712 | + eval('global $settings;' . $matches[0]); |
|
713 | + } |
|
696 | 714 | } |
697 | 715 | |
698 | 716 | // Let mods hook into the theme settings. |
@@ -704,37 +722,45 @@ discard block |
||
704 | 722 | checkSession(); |
705 | 723 | validateToken('admin-sts'); |
706 | 724 | |
707 | - if (empty($_POST['options'])) |
|
708 | - $_POST['options'] = array(); |
|
709 | - if (empty($_POST['default_options'])) |
|
710 | - $_POST['default_options'] = array(); |
|
725 | + if (empty($_POST['options'])) { |
|
726 | + $_POST['options'] = array(); |
|
727 | + } |
|
728 | + if (empty($_POST['default_options'])) { |
|
729 | + $_POST['default_options'] = array(); |
|
730 | + } |
|
711 | 731 | |
712 | 732 | // Make sure items are cast correctly. |
713 | 733 | foreach ($context['theme_settings'] as $item) |
714 | 734 | { |
715 | 735 | // Disregard this item if this is just a separator. |
716 | - if (!is_array($item)) |
|
717 | - continue; |
|
736 | + if (!is_array($item)) { |
|
737 | + continue; |
|
738 | + } |
|
718 | 739 | |
719 | 740 | foreach (array('options', 'default_options') as $option) |
720 | 741 | { |
721 | - if (!isset($_POST[$option][$item['id']])) |
|
722 | - continue; |
|
742 | + if (!isset($_POST[$option][$item['id']])) { |
|
743 | + continue; |
|
744 | + } |
|
723 | 745 | // Checkbox. |
724 | - elseif (empty($item['type'])) |
|
725 | - $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
746 | + elseif (empty($item['type'])) { |
|
747 | + $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
748 | + } |
|
726 | 749 | // Number |
727 | - elseif ($item['type'] == 'number') |
|
728 | - $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
750 | + elseif ($item['type'] == 'number') { |
|
751 | + $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
752 | + } |
|
729 | 753 | } |
730 | 754 | } |
731 | 755 | |
732 | 756 | // Set up the sql query. |
733 | 757 | $inserts = array(); |
734 | - foreach ($_POST['options'] as $opt => $val) |
|
735 | - $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
736 | - foreach ($_POST['default_options'] as $opt => $val) |
|
737 | - $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
758 | + foreach ($_POST['options'] as $opt => $val) { |
|
759 | + $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
760 | + } |
|
761 | + foreach ($_POST['default_options'] as $opt => $val) { |
|
762 | + $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
763 | + } |
|
738 | 764 | // If we're actually inserting something.. |
739 | 765 | if (!empty($inserts)) |
740 | 766 | { |
@@ -760,8 +786,9 @@ discard block |
||
760 | 786 | |
761 | 787 | foreach ($settings as $setting => $dummy) |
762 | 788 | { |
763 | - if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) |
|
764 | - $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
789 | + if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) { |
|
790 | + $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
791 | + } |
|
765 | 792 | } |
766 | 793 | |
767 | 794 | $context['settings'] = $context['theme_settings']; |
@@ -770,18 +797,21 @@ discard block |
||
770 | 797 | foreach ($context['settings'] as $i => $setting) |
771 | 798 | { |
772 | 799 | // Separators are dummies, so leave them alone. |
773 | - if (!is_array($setting)) |
|
774 | - continue; |
|
800 | + if (!is_array($setting)) { |
|
801 | + continue; |
|
802 | + } |
|
775 | 803 | |
776 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
777 | - $context['settings'][$i]['type'] = 'checkbox'; |
|
778 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
779 | - $context['settings'][$i]['type'] = 'number'; |
|
780 | - elseif ($setting['type'] == 'string') |
|
781 | - $context['settings'][$i]['type'] = 'text'; |
|
804 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
805 | + $context['settings'][$i]['type'] = 'checkbox'; |
|
806 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
807 | + $context['settings'][$i]['type'] = 'number'; |
|
808 | + } elseif ($setting['type'] == 'string') { |
|
809 | + $context['settings'][$i]['type'] = 'text'; |
|
810 | + } |
|
782 | 811 | |
783 | - if (isset($setting['options'])) |
|
784 | - $context['settings'][$i]['type'] = 'list'; |
|
812 | + if (isset($setting['options'])) { |
|
813 | + $context['settings'][$i]['type'] = 'list'; |
|
814 | + } |
|
785 | 815 | |
786 | 816 | $context['settings'][$i]['value'] = !isset($settings[$setting['id']]) ? '' : $settings[$setting['id']]; |
787 | 817 | } |
@@ -834,8 +864,9 @@ discard block |
||
834 | 864 | $themeID = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
835 | 865 | |
836 | 866 | // You can't delete the default theme! |
837 | - if ($themeID == 1) |
|
838 | - fatal_lang_error('no_access', false); |
|
867 | + if ($themeID == 1) { |
|
868 | + fatal_lang_error('no_access', false); |
|
869 | + } |
|
839 | 870 | |
840 | 871 | $theme_info = get_single_theme($themeID); |
841 | 872 | |
@@ -843,8 +874,9 @@ discard block |
||
843 | 874 | remove_theme($themeID); |
844 | 875 | |
845 | 876 | // And remove all its files and folders too. |
846 | - if (!empty($theme_info) && !empty($theme_info['theme_dir'])) |
|
847 | - remove_dir($theme_info['theme_dir']); |
|
877 | + if (!empty($theme_info) && !empty($theme_info['theme_dir'])) { |
|
878 | + remove_dir($theme_info['theme_dir']); |
|
879 | + } |
|
848 | 880 | |
849 | 881 | // Go back to the list page. |
850 | 882 | redirectexit('action=admin;area=theme;sa=list;' . $context['session_var'] . '=' . $context['session_id'] . ';done=removing'); |
@@ -869,12 +901,14 @@ discard block |
||
869 | 901 | $enableThemes = explode(',', $modSettings['enableThemes']); |
870 | 902 | |
871 | 903 | // Are we disabling it? |
872 | - if (isset($_GET['disabled'])) |
|
873 | - $enableThemes = array_diff($enableThemes, array($themeID)); |
|
904 | + if (isset($_GET['disabled'])) { |
|
905 | + $enableThemes = array_diff($enableThemes, array($themeID)); |
|
906 | + } |
|
874 | 907 | |
875 | 908 | // Nope? then enable it! |
876 | - else |
|
877 | - $enableThemes[] = (string) $themeID; |
|
909 | + else { |
|
910 | + $enableThemes[] = (string) $themeID; |
|
911 | + } |
|
878 | 912 | |
879 | 913 | // Update the setting. |
880 | 914 | $enableThemes = strtr(implode(',', $enableThemes), array(',,' => ',')); |
@@ -909,18 +943,21 @@ discard block |
||
909 | 943 | |
910 | 944 | $_SESSION['id_theme'] = 0; |
911 | 945 | |
912 | - if (isset($_GET['id'])) |
|
913 | - $_GET['th'] = $_GET['id']; |
|
946 | + if (isset($_GET['id'])) { |
|
947 | + $_GET['th'] = $_GET['id']; |
|
948 | + } |
|
914 | 949 | |
915 | 950 | // Saving a variant cause JS doesn't work - pretend it did ;) |
916 | 951 | if (isset($_POST['save'])) |
917 | 952 | { |
918 | 953 | // Which theme? |
919 | - foreach ($_POST['save'] as $k => $v) |
|
920 | - $_GET['th'] = (int) $k; |
|
954 | + foreach ($_POST['save'] as $k => $v) { |
|
955 | + $_GET['th'] = (int) $k; |
|
956 | + } |
|
921 | 957 | |
922 | - if (isset($_POST['vrt'][$k])) |
|
923 | - $_GET['vrt'] = $_POST['vrt'][$k]; |
|
958 | + if (isset($_POST['vrt'][$k])) { |
|
959 | + $_GET['vrt'] = $_POST['vrt'][$k]; |
|
960 | + } |
|
924 | 961 | } |
925 | 962 | |
926 | 963 | // Have we made a decision, or are we just browsing? |
@@ -998,8 +1035,9 @@ discard block |
||
998 | 1035 | else |
999 | 1036 | { |
1000 | 1037 | // The forum's default theme is always 0 and we |
1001 | - if (isset($_GET['th']) && $_GET['th'] == 0) |
|
1002 | - $_GET['th'] = $modSettings['theme_guests']; |
|
1038 | + if (isset($_GET['th']) && $_GET['th'] == 0) { |
|
1039 | + $_GET['th'] = $modSettings['theme_guests']; |
|
1040 | + } |
|
1003 | 1041 | |
1004 | 1042 | updateMemberData((int) $_REQUEST['u'], array('id_theme' => (int) $_GET['th'])); |
1005 | 1043 | |
@@ -1013,8 +1051,9 @@ discard block |
||
1013 | 1051 | ); |
1014 | 1052 | cache_put_data('theme_settings-' . $_GET['th'] . ':' . (int) $_REQUEST['u'], null, 90); |
1015 | 1053 | |
1016 | - if ($user_info['id'] == $_REQUEST['u']) |
|
1017 | - $_SESSION['id_variant'] = 0; |
|
1054 | + if ($user_info['id'] == $_REQUEST['u']) { |
|
1055 | + $_SESSION['id_variant'] = 0; |
|
1056 | + } |
|
1018 | 1057 | } |
1019 | 1058 | |
1020 | 1059 | redirectexit('action=profile;u=' . (int) $_REQUEST['u'] . ';area=theme'); |
@@ -1083,12 +1122,13 @@ discard block |
||
1083 | 1122 | ); |
1084 | 1123 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1085 | 1124 | { |
1086 | - if (!isset($context['available_themes'][$row['id_theme']])) |
|
1087 | - $context['available_themes'][$row['id_theme']] = array( |
|
1125 | + if (!isset($context['available_themes'][$row['id_theme']])) { |
|
1126 | + $context['available_themes'][$row['id_theme']] = array( |
|
1088 | 1127 | 'id' => $row['id_theme'], |
1089 | 1128 | 'selected' => $context['current_theme'] == $row['id_theme'], |
1090 | 1129 | 'num_users' => 0 |
1091 | 1130 | ); |
1131 | + } |
|
1092 | 1132 | $context['available_themes'][$row['id_theme']][$row['variable']] = $row['value']; |
1093 | 1133 | } |
1094 | 1134 | $smcFunc['db_free_result']($request); |
@@ -1101,9 +1141,9 @@ discard block |
||
1101 | 1141 | 'num_users' => 0 |
1102 | 1142 | ); |
1103 | 1143 | $guest_theme = 0; |
1144 | + } else { |
|
1145 | + $guest_theme = $modSettings['theme_guests']; |
|
1104 | 1146 | } |
1105 | - else |
|
1106 | - $guest_theme = $modSettings['theme_guests']; |
|
1107 | 1147 | |
1108 | 1148 | $request = $smcFunc['db_query']('', ' |
1109 | 1149 | SELECT id_theme, COUNT(*) AS the_count |
@@ -1116,15 +1156,17 @@ discard block |
||
1116 | 1156 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1117 | 1157 | { |
1118 | 1158 | // Figure out which theme it is they are REALLY using. |
1119 | - if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) |
|
1120 | - $row['id_theme'] = $guest_theme; |
|
1121 | - elseif (empty($modSettings['theme_allow'])) |
|
1122 | - $row['id_theme'] = $guest_theme; |
|
1159 | + if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) { |
|
1160 | + $row['id_theme'] = $guest_theme; |
|
1161 | + } elseif (empty($modSettings['theme_allow'])) { |
|
1162 | + $row['id_theme'] = $guest_theme; |
|
1163 | + } |
|
1123 | 1164 | |
1124 | - if (isset($context['available_themes'][$row['id_theme']])) |
|
1125 | - $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1126 | - else |
|
1127 | - $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1165 | + if (isset($context['available_themes'][$row['id_theme']])) { |
|
1166 | + $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1167 | + } else { |
|
1168 | + $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1169 | + } |
|
1128 | 1170 | } |
1129 | 1171 | $smcFunc['db_free_result']($request); |
1130 | 1172 | |
@@ -1143,8 +1185,9 @@ discard block |
||
1143 | 1185 | 'id_member' => isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? array(-1, $context['current_member']) : array(-1), |
1144 | 1186 | ) |
1145 | 1187 | ); |
1146 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1147 | - $variant_preferences[$row['id_theme']] = $row['value']; |
|
1188 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1189 | + $variant_preferences[$row['id_theme']] = $row['value']; |
|
1190 | + } |
|
1148 | 1191 | $smcFunc['db_free_result']($request); |
1149 | 1192 | } |
1150 | 1193 | |
@@ -1155,17 +1198,18 @@ discard block |
||
1155 | 1198 | foreach ($context['available_themes'] as $id_theme => $theme_data) |
1156 | 1199 | { |
1157 | 1200 | // Don't try to load the forum or board default theme's data... it doesn't have any! |
1158 | - if ($id_theme == 0) |
|
1159 | - continue; |
|
1201 | + if ($id_theme == 0) { |
|
1202 | + continue; |
|
1203 | + } |
|
1160 | 1204 | |
1161 | 1205 | // The thumbnail needs the correct path. |
1162 | 1206 | $settings['images_url'] = &$theme_data['images_url']; |
1163 | 1207 | |
1164 | - if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) |
|
1165 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1166 | - elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) |
|
1167 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1168 | - else |
|
1208 | + if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) { |
|
1209 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1210 | + } elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) { |
|
1211 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1212 | + } else |
|
1169 | 1213 | { |
1170 | 1214 | $txt['theme_thumbnail_href'] = $theme_data['images_url'] . '/thumbnail.png'; |
1171 | 1215 | $txt['theme_description'] = ''; |
@@ -1190,15 +1234,17 @@ discard block |
||
1190 | 1234 | loadLanguage('Settings'); |
1191 | 1235 | |
1192 | 1236 | $context['available_themes'][$id_theme]['variants'] = array(); |
1193 | - foreach ($settings['theme_variants'] as $variant) |
|
1194 | - $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1237 | + foreach ($settings['theme_variants'] as $variant) { |
|
1238 | + $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1195 | 1239 | 'label' => isset($txt['variant_' . $variant]) ? $txt['variant_' . $variant] : $variant, |
1196 | 1240 | 'thumbnail' => !file_exists($theme_data['theme_dir'] . '/images/thumbnail.png') || file_exists($theme_data['theme_dir'] . '/images/thumbnail_' . $variant . '.png') ? $theme_data['images_url'] . '/thumbnail_' . $variant . '.png' : ($theme_data['images_url'] . '/thumbnail.png'), |
1197 | 1241 | ); |
1242 | + } |
|
1198 | 1243 | |
1199 | 1244 | $context['available_themes'][$id_theme]['selected_variant'] = isset($_GET['vrt']) ? $_GET['vrt'] : (!empty($variant_preferences[$id_theme]) ? $variant_preferences[$id_theme] : (!empty($settings['default_variant']) ? $settings['default_variant'] : $settings['theme_variants'][0])); |
1200 | - if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) |
|
1201 | - $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1245 | + if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) { |
|
1246 | + $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1247 | + } |
|
1202 | 1248 | |
1203 | 1249 | $context['available_themes'][$id_theme]['thumbnail_href'] = $context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail']; |
1204 | 1250 | // Allow themes to override the text. |
@@ -1214,8 +1260,9 @@ discard block |
||
1214 | 1260 | // As long as we're not doing the default theme... |
1215 | 1261 | if (!isset($_REQUEST['u']) || $_REQUEST['u'] >= 0) |
1216 | 1262 | { |
1217 | - if ($guest_theme != 0) |
|
1218 | - $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1263 | + if ($guest_theme != 0) { |
|
1264 | + $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1265 | + } |
|
1219 | 1266 | |
1220 | 1267 | $context['available_themes'][0]['id'] = 0; |
1221 | 1268 | $context['available_themes'][0]['name'] = $txt['theme_forum_default']; |
@@ -1264,14 +1311,16 @@ discard block |
||
1264 | 1311 | $action = $smcFunc['htmlspecialchars'](trim($_GET['do'])); |
1265 | 1312 | |
1266 | 1313 | // Got any info from the specific form? |
1267 | - if (!isset($_POST['save_' . $action])) |
|
1268 | - fatal_lang_error('theme_install_no_action', false); |
|
1314 | + if (!isset($_POST['save_' . $action])) { |
|
1315 | + fatal_lang_error('theme_install_no_action', false); |
|
1316 | + } |
|
1269 | 1317 | |
1270 | 1318 | validateToken('admin-t-' . $action); |
1271 | 1319 | |
1272 | 1320 | // Hopefully the themes directory is writable, or we might have a problem. |
1273 | - if (!is_writable($themedir)) |
|
1274 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1321 | + if (!is_writable($themedir)) { |
|
1322 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1323 | + } |
|
1275 | 1324 | |
1276 | 1325 | // Call the function and handle the result. |
1277 | 1326 | $result = $subActions[$action](); |
@@ -1286,9 +1335,10 @@ discard block |
||
1286 | 1335 | } |
1287 | 1336 | |
1288 | 1337 | // Nope, show a nice error. |
1289 | - else |
|
1290 | - fatal_lang_error('theme_install_no_action', false); |
|
1291 | -} |
|
1338 | + else { |
|
1339 | + fatal_lang_error('theme_install_no_action', false); |
|
1340 | + } |
|
1341 | + } |
|
1292 | 1342 | |
1293 | 1343 | /** |
1294 | 1344 | * Installs a theme from a theme package. |
@@ -1304,8 +1354,9 @@ discard block |
||
1304 | 1354 | $dirtemp = $themedir . '/temp'; |
1305 | 1355 | |
1306 | 1356 | // Make sure the temp dir doesn't already exist |
1307 | - if (file_exists($dirtemp)) |
|
1308 | - remove_dir($dirtemp); |
|
1357 | + if (file_exists($dirtemp)) { |
|
1358 | + remove_dir($dirtemp); |
|
1359 | + } |
|
1309 | 1360 | |
1310 | 1361 | // Create the temp dir. |
1311 | 1362 | mkdir($dirtemp, 0777); |
@@ -1317,17 +1368,20 @@ discard block |
||
1317 | 1368 | smf_chmod($dirtemp, '0755'); |
1318 | 1369 | |
1319 | 1370 | // How about now? |
1320 | - if (!is_writable($dirtemp)) |
|
1321 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1371 | + if (!is_writable($dirtemp)) { |
|
1372 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1373 | + } |
|
1322 | 1374 | } |
1323 | 1375 | |
1324 | 1376 | // This happens when the admin session is gone and the user has to login again. |
1325 | - if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) |
|
1326 | - redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1377 | + if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) { |
|
1378 | + redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1379 | + } |
|
1327 | 1380 | |
1328 | 1381 | // Another error check layer, something went wrong with the upload. |
1329 | - if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) |
|
1330 | - fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1382 | + if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) { |
|
1383 | + fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1384 | + } |
|
1331 | 1385 | |
1332 | 1386 | // Get the theme's name. |
1333 | 1387 | $name = pathinfo($_FILES['theme_gz']['name'], PATHINFO_FILENAME); |
@@ -1358,11 +1412,10 @@ discard block |
||
1358 | 1412 | |
1359 | 1413 | // return all the info. |
1360 | 1414 | return $context['to_install']; |
1415 | + } else { |
|
1416 | + fatal_lang_error('theme_install_error_title', false); |
|
1417 | + } |
|
1361 | 1418 | } |
1362 | - |
|
1363 | - else |
|
1364 | - fatal_lang_error('theme_install_error_title', false); |
|
1365 | -} |
|
1366 | 1419 | |
1367 | 1420 | /** |
1368 | 1421 | * Makes a copy from the default theme, assigns a name for it and installs it. |
@@ -1376,15 +1429,17 @@ discard block |
||
1376 | 1429 | global $forum_version; |
1377 | 1430 | |
1378 | 1431 | // There's gotta be something to work with. |
1379 | - if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) |
|
1380 | - fatal_lang_error('theme_install_error_title', false); |
|
1432 | + if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) { |
|
1433 | + fatal_lang_error('theme_install_error_title', false); |
|
1434 | + } |
|
1381 | 1435 | |
1382 | 1436 | // Get a cleaner version. |
1383 | 1437 | $name = preg_replace('~[^A-Za-z0-9_\- ]~', '', $_REQUEST['copy']); |
1384 | 1438 | |
1385 | 1439 | // Is there a theme already named like this? |
1386 | - if (file_exists($themedir . '/' . $name)) |
|
1387 | - fatal_lang_error('theme_install_already_dir', false); |
|
1440 | + if (file_exists($themedir . '/' . $name)) { |
|
1441 | + fatal_lang_error('theme_install_already_dir', false); |
|
1442 | + } |
|
1388 | 1443 | |
1389 | 1444 | // This is a brand new theme so set all possible values. |
1390 | 1445 | $context['to_install'] = array( |
@@ -1404,8 +1459,9 @@ discard block |
||
1404 | 1459 | |
1405 | 1460 | // Buy some time. |
1406 | 1461 | @set_time_limit(600); |
1407 | - if (function_exists('apache_reset_timeout')) |
|
1408 | - @apache_reset_timeout(); |
|
1462 | + if (function_exists('apache_reset_timeout')) { |
|
1463 | + @apache_reset_timeout(); |
|
1464 | + } |
|
1409 | 1465 | |
1410 | 1466 | // Create subdirectories for css and javascript files. |
1411 | 1467 | mkdir($context['to_install']['theme_dir'] . '/css', 0777); |
@@ -1441,12 +1497,13 @@ discard block |
||
1441 | 1497 | |
1442 | 1498 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1443 | 1499 | { |
1444 | - if ($row['variable'] == 'theme_templates') |
|
1445 | - $theme_templates = $row['value']; |
|
1446 | - elseif ($row['variable'] == 'theme_layers') |
|
1447 | - $theme_layers = $row['value']; |
|
1448 | - else |
|
1449 | - continue; |
|
1500 | + if ($row['variable'] == 'theme_templates') { |
|
1501 | + $theme_templates = $row['value']; |
|
1502 | + } elseif ($row['variable'] == 'theme_layers') { |
|
1503 | + $theme_layers = $row['value']; |
|
1504 | + } else { |
|
1505 | + continue; |
|
1506 | + } |
|
1450 | 1507 | } |
1451 | 1508 | |
1452 | 1509 | $smcFunc['db_free_result']($request); |
@@ -1505,12 +1562,14 @@ discard block |
||
1505 | 1562 | global $themedir, $themeurl, $context; |
1506 | 1563 | |
1507 | 1564 | // Cannot use the theme dir as a theme dir. |
1508 | - if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) |
|
1509 | - fatal_lang_error('theme_install_invalid_dir', false); |
|
1565 | + if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) { |
|
1566 | + fatal_lang_error('theme_install_invalid_dir', false); |
|
1567 | + } |
|
1510 | 1568 | |
1511 | 1569 | // Check is there is "something" on the dir. |
1512 | - elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) |
|
1513 | - fatal_lang_error('theme_install_error', false); |
|
1570 | + elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) { |
|
1571 | + fatal_lang_error('theme_install_error', false); |
|
1572 | + } |
|
1514 | 1573 | |
1515 | 1574 | $name = basename($_REQUEST['theme_dir']); |
1516 | 1575 | $name = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $name); |
@@ -1554,24 +1613,27 @@ discard block |
||
1554 | 1613 | } |
1555 | 1614 | |
1556 | 1615 | // Any special layers? |
1557 | - if (isset($settings['catch_action']['layers'])) |
|
1558 | - $context['template_layers'] = $settings['catch_action']['layers']; |
|
1616 | + if (isset($settings['catch_action']['layers'])) { |
|
1617 | + $context['template_layers'] = $settings['catch_action']['layers']; |
|
1618 | + } |
|
1559 | 1619 | |
1560 | 1620 | // Any function to call? |
1561 | 1621 | if (isset($settings['catch_action']['function'])) |
1562 | 1622 | { |
1563 | 1623 | $hook = $settings['catch_action']['function']; |
1564 | 1624 | |
1565 | - if (!isset($settings['catch_action']['filename'])) |
|
1566 | - $settings['catch_action']['filename'] = ''; |
|
1625 | + if (!isset($settings['catch_action']['filename'])) { |
|
1626 | + $settings['catch_action']['filename'] = ''; |
|
1627 | + } |
|
1567 | 1628 | |
1568 | 1629 | add_integration_function('integrate_wrap_action', $hook, false, $settings['catch_action']['filename'], false); |
1569 | 1630 | call_integration_hook('integrate_wrap_action'); |
1570 | 1631 | } |
1571 | 1632 | // And finally, the main sub template ;). |
1572 | - if (isset($settings['catch_action']['sub_template'])) |
|
1573 | - $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1574 | -} |
|
1633 | + if (isset($settings['catch_action']['sub_template'])) { |
|
1634 | + $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1635 | + } |
|
1636 | + } |
|
1575 | 1637 | |
1576 | 1638 | /** |
1577 | 1639 | * Set an option via javascript. |
@@ -1590,12 +1652,14 @@ discard block |
||
1590 | 1652 | checkSession('get'); |
1591 | 1653 | |
1592 | 1654 | // This good-for-nothing pixel is being used to keep the session alive. |
1593 | - if (empty($_GET['var']) || !isset($_GET['val'])) |
|
1594 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1655 | + if (empty($_GET['var']) || !isset($_GET['val'])) { |
|
1656 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1657 | + } |
|
1595 | 1658 | |
1596 | 1659 | // Sorry, guests can't go any further than this. |
1597 | - if ($user_info['is_guest'] || $user_info['id'] == 0) |
|
1598 | - obExit(false); |
|
1660 | + if ($user_info['is_guest'] || $user_info['id'] == 0) { |
|
1661 | + obExit(false); |
|
1662 | + } |
|
1599 | 1663 | |
1600 | 1664 | $reservedVars = array( |
1601 | 1665 | 'actual_theme_url', |
@@ -1618,8 +1682,9 @@ discard block |
||
1618 | 1682 | ); |
1619 | 1683 | |
1620 | 1684 | // Can't change reserved vars. |
1621 | - if (in_array(strtolower($_GET['var']), $reservedVars)) |
|
1622 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1685 | + if (in_array(strtolower($_GET['var']), $reservedVars)) { |
|
1686 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1687 | + } |
|
1623 | 1688 | |
1624 | 1689 | // Use a specific theme? |
1625 | 1690 | if (isset($_GET['th']) || isset($_GET['id'])) |
@@ -1635,8 +1700,9 @@ discard block |
||
1635 | 1700 | { |
1636 | 1701 | $options['admin_preferences'] = !empty($options['admin_preferences']) ? $smcFunc['json_decode']($options['admin_preferences'], true) : array(); |
1637 | 1702 | // New thingy... |
1638 | - if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) |
|
1639 | - $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1703 | + if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) { |
|
1704 | + $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1705 | + } |
|
1640 | 1706 | |
1641 | 1707 | // Change the value to be something nice, |
1642 | 1708 | $_GET['val'] = $smcFunc['json_encode']($options['admin_preferences']); |
@@ -1666,8 +1732,9 @@ discard block |
||
1666 | 1732 | global $context, $scripturl, $boarddir, $smcFunc, $txt; |
1667 | 1733 | |
1668 | 1734 | // @todo Should this be removed? |
1669 | - if (isset($_REQUEST['preview'])) |
|
1670 | - die('die() with fire'); |
|
1735 | + if (isset($_REQUEST['preview'])) { |
|
1736 | + die('die() with fire'); |
|
1737 | + } |
|
1671 | 1738 | |
1672 | 1739 | isAllowedTo('admin_forum'); |
1673 | 1740 | loadTemplate('Themes'); |
@@ -1681,11 +1748,11 @@ discard block |
||
1681 | 1748 | foreach ($context['themes'] as $key => $theme) |
1682 | 1749 | { |
1683 | 1750 | // There has to be a Settings template! |
1684 | - if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) |
|
1685 | - unset($context['themes'][$key]); |
|
1686 | - |
|
1687 | - else |
|
1688 | - $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1751 | + if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) { |
|
1752 | + unset($context['themes'][$key]); |
|
1753 | + } else { |
|
1754 | + $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1755 | + } |
|
1689 | 1756 | } |
1690 | 1757 | |
1691 | 1758 | $context['sub_template'] = 'edit_list'; |
@@ -1700,22 +1767,24 @@ discard block |
||
1700 | 1767 | $context['theme_id'] = $currentTheme['id']; |
1701 | 1768 | $context['browse_title'] = sprintf($txt['themeadmin_browsing_theme'], $currentTheme['name']); |
1702 | 1769 | |
1703 | - if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) |
|
1704 | - fatal_lang_error('theme_edit_missing', false); |
|
1770 | + if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) { |
|
1771 | + fatal_lang_error('theme_edit_missing', false); |
|
1772 | + } |
|
1705 | 1773 | |
1706 | 1774 | if (!isset($_REQUEST['filename'])) |
1707 | 1775 | { |
1708 | 1776 | if (isset($_GET['directory'])) |
1709 | 1777 | { |
1710 | - if (substr($_GET['directory'], 0, 1) == '.') |
|
1711 | - $_GET['directory'] = ''; |
|
1712 | - else |
|
1778 | + if (substr($_GET['directory'], 0, 1) == '.') { |
|
1779 | + $_GET['directory'] = ''; |
|
1780 | + } else |
|
1713 | 1781 | { |
1714 | 1782 | $_GET['directory'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_GET['directory']); |
1715 | 1783 | |
1716 | 1784 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_GET['directory']); |
1717 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1718 | - $_GET['directory'] = ''; |
|
1785 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1786 | + $_GET['directory'] = ''; |
|
1787 | + } |
|
1719 | 1788 | } |
1720 | 1789 | } |
1721 | 1790 | |
@@ -1734,37 +1803,39 @@ discard block |
||
1734 | 1803 | 'href' => $scripturl . '?action=admin;area=theme;th=' . $_GET['th'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=edit;directory=' . $temp, |
1735 | 1804 | 'size' => '', |
1736 | 1805 | )); |
1806 | + } else { |
|
1807 | + $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1737 | 1808 | } |
1738 | - else |
|
1739 | - $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1740 | 1809 | |
1741 | 1810 | $context['sub_template'] = 'edit_browse'; |
1742 | 1811 | |
1743 | 1812 | return; |
1744 | - } |
|
1745 | - else |
|
1813 | + } else |
|
1746 | 1814 | { |
1747 | - if (substr($_REQUEST['filename'], 0, 1) == '.') |
|
1748 | - $_REQUEST['filename'] = ''; |
|
1749 | - else |
|
1815 | + if (substr($_REQUEST['filename'], 0, 1) == '.') { |
|
1816 | + $_REQUEST['filename'] = ''; |
|
1817 | + } else |
|
1750 | 1818 | { |
1751 | 1819 | $_REQUEST['filename'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_REQUEST['filename']); |
1752 | 1820 | |
1753 | 1821 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
1754 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1755 | - $_REQUEST['filename'] = ''; |
|
1822 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1823 | + $_REQUEST['filename'] = ''; |
|
1824 | + } |
|
1756 | 1825 | } |
1757 | 1826 | |
1758 | - if (empty($_REQUEST['filename'])) |
|
1759 | - fatal_lang_error('theme_edit_missing', false); |
|
1827 | + if (empty($_REQUEST['filename'])) { |
|
1828 | + fatal_lang_error('theme_edit_missing', false); |
|
1829 | + } |
|
1760 | 1830 | } |
1761 | 1831 | |
1762 | 1832 | if (isset($_POST['save'])) |
1763 | 1833 | { |
1764 | 1834 | if (checkSession('post', '', false) == '' && validateToken('admin-te-' . md5($_GET['th'] . '-' . $_REQUEST['filename']), 'post', false) == true) |
1765 | 1835 | { |
1766 | - if (is_array($_POST['entire_file'])) |
|
1767 | - $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1836 | + if (is_array($_POST['entire_file'])) { |
|
1837 | + $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1838 | + } |
|
1768 | 1839 | |
1769 | 1840 | $_POST['entire_file'] = rtrim(strtr($_POST['entire_file'], array("\r" => '', ' ' => "\t"))); |
1770 | 1841 | |
@@ -1776,10 +1847,11 @@ discard block |
||
1776 | 1847 | fclose($fp); |
1777 | 1848 | |
1778 | 1849 | $error = @file_get_contents($currentTheme['theme_url'] . '/tmp_' . session_id() . '.php'); |
1779 | - if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) |
|
1780 | - $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1781 | - else |
|
1782 | - unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1850 | + if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) { |
|
1851 | + $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1852 | + } else { |
|
1853 | + unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1854 | + } |
|
1783 | 1855 | } |
1784 | 1856 | |
1785 | 1857 | if (!isset($error_file)) |
@@ -1800,10 +1872,11 @@ discard block |
||
1800 | 1872 | $context['sub_template'] = 'edit_file'; |
1801 | 1873 | |
1802 | 1874 | // Recycle the submitted data. |
1803 | - if (is_array($_POST['entire_file'])) |
|
1804 | - $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1805 | - else |
|
1806 | - $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1875 | + if (is_array($_POST['entire_file'])) { |
|
1876 | + $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1877 | + } else { |
|
1878 | + $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1879 | + } |
|
1807 | 1880 | |
1808 | 1881 | $context['edit_filename'] = $smcFunc['htmlspecialchars']($_POST['filename']); |
1809 | 1882 | |
@@ -1826,17 +1899,17 @@ discard block |
||
1826 | 1899 | $context['sub_template'] = 'edit_style'; |
1827 | 1900 | |
1828 | 1901 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(file_get_contents($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']), array("\t" => ' '))); |
1829 | - } |
|
1830 | - elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1902 | + } elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1831 | 1903 | { |
1832 | 1904 | $context['sub_template'] = 'edit_template'; |
1833 | 1905 | |
1834 | - if (!isset($error_file)) |
|
1835 | - $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1836 | - else |
|
1906 | + if (!isset($error_file)) { |
|
1907 | + $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1908 | + } else |
|
1837 | 1909 | { |
1838 | - if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) |
|
1839 | - $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1910 | + if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) { |
|
1911 | + $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1912 | + } |
|
1840 | 1913 | $file_data = file($error_file); |
1841 | 1914 | unlink($error_file); |
1842 | 1915 | } |
@@ -1850,8 +1923,9 @@ discard block |
||
1850 | 1923 | // Try to format the functions a little nicer... |
1851 | 1924 | $context['file_parts'][$j]['data'] = trim($context['file_parts'][$j]['data']) . "\n"; |
1852 | 1925 | |
1853 | - if (empty($context['file_parts'][$j]['lines'])) |
|
1854 | - unset($context['file_parts'][$j]); |
|
1926 | + if (empty($context['file_parts'][$j]['lines'])) { |
|
1927 | + unset($context['file_parts'][$j]); |
|
1928 | + } |
|
1855 | 1929 | $context['file_parts'][++$j] = array('lines' => 0, 'line' => $i + 1, 'data' => ''); |
1856 | 1930 | } |
1857 | 1931 | |
@@ -1860,8 +1934,7 @@ discard block |
||
1860 | 1934 | } |
1861 | 1935 | |
1862 | 1936 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(implode('', $file_data), array("\t" => ' '))); |
1863 | - } |
|
1864 | - else |
|
1937 | + } else |
|
1865 | 1938 | { |
1866 | 1939 | $context['sub_template'] = 'edit_file'; |
1867 | 1940 | |
@@ -1887,8 +1960,9 @@ discard block |
||
1887 | 1960 | |
1888 | 1961 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
1889 | 1962 | |
1890 | - if (empty($_GET['th'])) |
|
1891 | - fatal_lang_error('theme_install_invalid_id'); |
|
1963 | + if (empty($_GET['th'])) { |
|
1964 | + fatal_lang_error('theme_install_invalid_id'); |
|
1965 | + } |
|
1892 | 1966 | |
1893 | 1967 | // Get the theme info. |
1894 | 1968 | $theme = get_single_theme($_GET['th']); |
@@ -1896,25 +1970,24 @@ discard block |
||
1896 | 1970 | |
1897 | 1971 | if (isset($_REQUEST['template']) && preg_match('~[\./\\\\:\0]~', $_REQUEST['template']) == 0) |
1898 | 1972 | { |
1899 | - if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) |
|
1900 | - $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1901 | - |
|
1902 | - else |
|
1903 | - fatal_lang_error('no_access', false); |
|
1973 | + if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) { |
|
1974 | + $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1975 | + } else { |
|
1976 | + fatal_lang_error('no_access', false); |
|
1977 | + } |
|
1904 | 1978 | |
1905 | 1979 | $fp = fopen($theme['theme_dir'] . '/' . $_REQUEST['template'] . '.template.php', 'w'); |
1906 | 1980 | fwrite($fp, file_get_contents($filename)); |
1907 | 1981 | fclose($fp); |
1908 | 1982 | |
1909 | 1983 | redirectexit('action=admin;area=theme;th=' . $context['theme_id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=copy'); |
1910 | - } |
|
1911 | - elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1984 | + } elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1912 | 1985 | { |
1913 | - if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) |
|
1914 | - $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1915 | - |
|
1916 | - else |
|
1917 | - fatal_lang_error('no_access', false); |
|
1986 | + if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) { |
|
1987 | + $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1988 | + } else { |
|
1989 | + fatal_lang_error('no_access', false); |
|
1990 | + } |
|
1918 | 1991 | |
1919 | 1992 | $fp = fopen($theme['theme_dir'] . '/languages/' . $_REQUEST['lang_file'] . '.php', 'w'); |
1920 | 1993 | fwrite($fp, file_get_contents($filename)); |
@@ -1929,16 +2002,18 @@ discard block |
||
1929 | 2002 | $dir = dir($settings['default_theme_dir']); |
1930 | 2003 | while ($entry = $dir->read()) |
1931 | 2004 | { |
1932 | - if (substr($entry, -13) == '.template.php') |
|
1933 | - $templates[] = substr($entry, 0, -13); |
|
2005 | + if (substr($entry, -13) == '.template.php') { |
|
2006 | + $templates[] = substr($entry, 0, -13); |
|
2007 | + } |
|
1934 | 2008 | } |
1935 | 2009 | $dir->close(); |
1936 | 2010 | |
1937 | 2011 | $dir = dir($settings['default_theme_dir'] . '/languages'); |
1938 | 2012 | while ($entry = $dir->read()) |
1939 | 2013 | { |
1940 | - if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) |
|
1941 | - $lang_files[] = $matches[1]; |
|
2014 | + if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) { |
|
2015 | + $lang_files[] = $matches[1]; |
|
2016 | + } |
|
1942 | 2017 | } |
1943 | 2018 | $dir->close(); |
1944 | 2019 | |
@@ -1946,21 +2021,23 @@ discard block |
||
1946 | 2021 | natcasesort($lang_files); |
1947 | 2022 | |
1948 | 2023 | $context['available_templates'] = array(); |
1949 | - foreach ($templates as $template) |
|
1950 | - $context['available_templates'][$template] = array( |
|
2024 | + foreach ($templates as $template) { |
|
2025 | + $context['available_templates'][$template] = array( |
|
1951 | 2026 | 'filename' => $template . '.template.php', |
1952 | 2027 | 'value' => $template, |
1953 | 2028 | 'already_exists' => false, |
1954 | 2029 | 'can_copy' => is_writable($theme['theme_dir']), |
1955 | 2030 | ); |
2031 | + } |
|
1956 | 2032 | $context['available_language_files'] = array(); |
1957 | - foreach ($lang_files as $file) |
|
1958 | - $context['available_language_files'][$file] = array( |
|
2033 | + foreach ($lang_files as $file) { |
|
2034 | + $context['available_language_files'][$file] = array( |
|
1959 | 2035 | 'filename' => $file . '.php', |
1960 | 2036 | 'value' => $file, |
1961 | 2037 | 'already_exists' => false, |
1962 | 2038 | 'can_copy' => file_exists($theme['theme_dir'] . '/languages') ? is_writable($theme['theme_dir'] . '/languages') : is_writable($theme['theme_dir']), |
1963 | 2039 | ); |
2040 | + } |
|
1964 | 2041 | |
1965 | 2042 | $dir = dir($theme['theme_dir']); |
1966 | 2043 | while ($entry = $dir->read()) |