Completed
Push — release-2.1 ( c3ff7f...f1e1b9 )
by Mathias
11s
created
Themes/default/Poll.template.php 1 patch
Braces   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
 				<h3 class="catbg">', $context['page_title'], '</h3>
47 47
 			</div>';
48 48
 
49
-	if (!empty($context['poll_error']['messages']))
50
-		echo '
49
+	if (!empty($context['poll_error']['messages'])) {
50
+			echo '
51 51
 			<div class="errorbox">
52 52
 				<dl class="poll_error">
53 53
 					<dt>
@@ -58,6 +58,7 @@  discard block
 block discarded – undo
58 58
 					</dt>
59 59
 				</dl>
60 60
 			</div>';
61
+	}
61 62
 
62 63
 	echo '
63 64
 			<div>
@@ -79,8 +80,9 @@  discard block
 block discarded – undo
79 80
 								<input type="text" name="options[', $choice['id'], ']" id="options-', $choice['id'], '" value="', $choice['label'], '" size="80" maxlength="255">';
80 81
 
81 82
 		// Does this option have a vote count yet, or is it new?
82
-		if ($choice['votes'] != -1)
83
-			echo ' (', $choice['votes'], ' ', $txt['votes'], ')';
83
+		if ($choice['votes'] != -1) {
84
+					echo ' (', $choice['votes'], ' ', $txt['votes'], ')';
85
+		}
84 86
 
85 87
 		echo '
86 88
 							</dd>';
@@ -118,14 +120,15 @@  discard block
 block discarded – undo
118 120
 								<input type="checkbox" id="poll_change_vote" name="poll_change_vote"', !empty($context['poll']['change_vote']) ? ' checked' : '', '>
119 121
 							</dd>';
120 122
 
121
-		if ($context['poll']['guest_vote_allowed'])
122
-			echo '
123
+		if ($context['poll']['guest_vote_allowed']) {
124
+					echo '
123 125
 							<dt>
124 126
 								<label for="poll_guest_vote">', $txt['poll_guest_vote'], ':</label>
125 127
 							</dt>
126 128
 							<dd>
127 129
 								<input type="checkbox" id="poll_guest_vote" name="poll_guest_vote"', !empty($context['poll']['guest_vote']) ? ' checked' : '', '>
128 130
 							</dd>';
131
+		}
129 132
 	}
130 133
 
131 134
 	echo '
@@ -141,12 +144,13 @@  discard block
 block discarded – undo
141 144
 					</fieldset>';
142 145
 
143 146
 	// If this is an edit, we can allow them to reset the vote counts.
144
-	if ($context['is_edit'])
145
-		echo '
147
+	if ($context['is_edit']) {
148
+			echo '
146 149
 					<fieldset id="poll_reset">
147 150
 						<legend>', $txt['reset_votes'], '</legend>
148 151
 						<input type="checkbox" name="resetVoteCount" value="on"> ' . $txt['reset_votes_check'] . '
149 152
 					</fieldset>';
153
+	}
150 154
 	echo '
151 155
 					<input type="submit" name="post" value="', $txt['save'], '" onclick="return submitThisOnce(this);" accesskey="s" class="button">
152 156
 				</div><!-- .roundframe -->
Please login to merge, or discard this patch.
Themes/default/ManageMembers.template.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
 				</thead>
149 149
 				<tbody>';
150 150
 
151
-	foreach ($context['membergroups'] as $membergroup)
152
-		echo '
151
+	foreach ($context['membergroups'] as $membergroup) {
152
+			echo '
153 153
 					<tr class="windowbg">
154 154
 						<td>', $membergroup['name'], '</td>
155 155
 						<td class="centercol">
@@ -159,6 +159,7 @@  discard block
 block discarded – undo
159 159
 							', $membergroup['can_be_additional'] ? '<input type="checkbox" name="membergroups[2][]" value="' . $membergroup['id'] . '" checked>' : '', '
160 160
 						</td>
161 161
 					</tr>';
162
+	}
162 163
 
163 164
 	echo '
164 165
 					<tr class="windowbg">
@@ -185,8 +186,8 @@  discard block
 block discarded – undo
185 186
 				</thead>
186 187
 				<tbody>';
187 188
 
188
-	foreach ($context['postgroups'] as $postgroup)
189
-		echo '
189
+	foreach ($context['postgroups'] as $postgroup) {
190
+			echo '
190 191
 					<tr class="windowbg">
191 192
 						<td>
192 193
 							', $postgroup['name'], '
@@ -195,6 +196,7 @@  discard block
 block discarded – undo
195 196
 							<input type="checkbox" name="postgroups[]" value="', $postgroup['id'], '" checked>
196 197
 						</td>
197 198
 					</tr>';
199
+	}
198 200
 
199 201
 	echo '
200 202
 					<tr class="windowbg">
Please login to merge, or discard this patch.
Themes/default/index.template.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -232,7 +232,7 @@
 block discarded – undo
232 232
 			// In maintenance mode, only login is allowed and don't show OverlayDiv
233 233
 			echo '
234 234
 			<ul class="floatleft welcome">
235
-				<li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li>
235
+				<li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl . '?action=login', 'return true;'), '</li>
236 236
 			</ul>';
237 237
 
238 238
 	if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1)
Please login to merge, or discard this patch.
Braces   +98 added lines, -67 removed lines patch added patch discarded remove patch
@@ -72,9 +72,10 @@  discard block
 block discarded – undo
72 72
 
73 73
 	// Allow css/js files to be disabled for this specific theme.
74 74
 	// Add the identifier as an array key. IE array('smf_script'); Some external files might not add identifiers, on those cases SMF uses its filename as reference.
75
-	if (!isset($settings['disable_files']))
76
-		$settings['disable_files'] = array();
77
-}
75
+	if (!isset($settings['disable_files'])) {
76
+			$settings['disable_files'] = array();
77
+	}
78
+	}
78 79
 
79 80
 /**
80 81
  * The main sub template above the content.
@@ -112,8 +113,9 @@  discard block
 block discarded – undo
112 113
 		echo '
113 114
 	<meta';
114 115
 
115
-		foreach ($meta_tag as $meta_key => $meta_value)
116
-			echo ' ', $meta_key, '="', $meta_value, '"';
116
+		foreach ($meta_tag as $meta_key => $meta_value) {
117
+					echo ' ', $meta_key, '="', $meta_value, '"';
118
+		}
117 119
 
118 120
 		echo '>';
119 121
 	}
@@ -124,14 +126,16 @@  discard block
 block discarded – undo
124 126
 	<meta name="theme-color" content="#557EA0">';
125 127
 
126 128
 	// Please don't index these Mr Robot.
127
-	if (!empty($context['robot_no_index']))
128
-		echo '
129
+	if (!empty($context['robot_no_index'])) {
130
+			echo '
129 131
 	<meta name="robots" content="noindex">';
132
+	}
130 133
 
131 134
 	// Present a canonical url for search engines to prevent duplicate content in their indices.
132
-	if (!empty($context['canonical_url']))
133
-		echo '
135
+	if (!empty($context['canonical_url'])) {
136
+			echo '
134 137
 	<link rel="canonical" href="', $context['canonical_url'], '">';
138
+	}
135 139
 
136 140
 	// Show all the relative links, such as help, search, contents, and the like.
137 141
 	echo '
@@ -140,24 +144,28 @@  discard block
 block discarded – undo
140 144
 	<link rel="search" href="' . $scripturl . '?action=search">' : '');
141 145
 
142 146
 	// If RSS feeds are enabled, advertise the presence of one.
143
-	if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged']))
144
-		echo '
147
+	if (!empty($modSettings['xmlnews_enable']) && (!empty($modSettings['allow_guestAccess']) || $context['user']['is_logged'])) {
148
+			echo '
145 149
 	<link rel="alternate" type="application/rss+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['rss'], '" href="', $scripturl, '?action=.xml;type=rss2', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">
146 150
 	<link rel="alternate" type="application/atom+xml" title="', $context['forum_name_html_safe'], ' - ', $txt['atom'], '" href="', $scripturl, '?action=.xml;type=atom', !empty($context['current_board']) ? ';board=' . $context['current_board'] : '', '">';
151
+	}
147 152
 
148 153
 	// If we're viewing a topic, these should be the previous and next topics, respectively.
149
-	if (!empty($context['links']['next']))
150
-		echo '
154
+	if (!empty($context['links']['next'])) {
155
+			echo '
151 156
 	<link rel="next" href="', $context['links']['next'], '">';
157
+	}
152 158
 
153
-	if (!empty($context['links']['prev']))
154
-		echo '
159
+	if (!empty($context['links']['prev'])) {
160
+			echo '
155 161
 	<link rel="prev" href="', $context['links']['prev'], '">';
162
+	}
156 163
 
157 164
 	// If we're in a board, or a topic for that matter, the index will be the board's index.
158
-	if (!empty($context['current_board']))
159
-		echo '
165
+	if (!empty($context['current_board'])) {
166
+			echo '
160 167
 	<link rel="index" href="', $scripturl, '?board=', $context['current_board'], '.0">';
168
+	}
161 169
 
162 170
 	// Output any remaining HTML headers. (from mods, maybe?)
163 171
 	echo $context['html_headers'];
@@ -190,20 +198,22 @@  discard block
 block discarded – undo
190 198
 				<li>
191 199
 					<a href="', $scripturl, '?action=profile"', !empty($context['self_profile']) ? ' class="active"' : '', ' id="profile_menu_top" onclick="return false;">';
192 200
 
193
-		if (!empty($context['user']['avatar']))
194
-			echo $context['user']['avatar']['image'];
201
+		if (!empty($context['user']['avatar'])) {
202
+					echo $context['user']['avatar']['image'];
203
+		}
195 204
 
196 205
 		echo $context['user']['name'], '</a>
197 206
 					<div id="profile_menu" class="top_menu"></div>
198 207
 				</li>';
199 208
 
200 209
 		// Secondly, PMs if we're doing them
201
-		if ($context['allow_pm'])
202
-			echo '
210
+		if ($context['allow_pm']) {
211
+					echo '
203 212
 				<li>
204 213
 					<a href="', $scripturl, '?action=pm"', !empty($context['self_pm']) ? ' class="active"' : '', ' id="pm_menu_top">', $txt['pm_short'], !empty($context['user']['unread_messages']) ? ' <span class="amt">' . $context['user']['unread_messages'] . '</span>' : '', '</a>
205 214
 					<div id="pm_menu" class="top_menu scrollable"></div>
206 215
 				</li>';
216
+		}
207 217
 
208 218
 		// Thirdly, alerts
209 219
 		echo '
@@ -218,17 +228,18 @@  discard block
 block discarded – undo
218 228
 	}
219 229
 	// Otherwise they're a guest. Ask them to either register or login.
220 230
 	else
221
-		if (empty($maintenance))
222
-			echo '
231
+		if (empty($maintenance)) {
232
+					echo '
223 233
 			<ul class="floatleft welcome">
224 234
 				<li>', sprintf($txt[$context['can_register'] ? 'welcome_guest_register' : 'welcome_guest'], $txt['guest_title'], $context['forum_name_html_safe'], $scripturl . '?action=login', 'return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ');', $scripturl . '?action=signup'), '</li>
225 235
 			</ul>';
226
-		else
227
-			// In maintenance mode, only login is allowed and don't show OverlayDiv
236
+		} else {
237
+					// In maintenance mode, only login is allowed and don't show OverlayDiv
228 238
 			echo '
229 239
 			<ul class="floatleft welcome">
230 240
 				<li>', sprintf($txt['welcome_guest'], $txt['guest_title'], '', $scripturl. '?action=login', 'return true;'), '</li>
231 241
 			</ul>';
242
+		}
232 243
 
233 244
 	if (!empty($modSettings['userLanguage']) && !empty($context['languages']) && count($context['languages']) > 1)
234 245
 	{
@@ -236,9 +247,10 @@  discard block
 block discarded – undo
236 247
 			<form id="languages_form" method="get" class="floatright">
237 248
 				<select id="language_select" name="language" onchange="this.form.submit()">';
238 249
 
239
-		foreach ($context['languages'] as $language)
240
-			echo '
250
+		foreach ($context['languages'] as $language) {
251
+					echo '
241 252
 					<option value="', $language['filename'], '"', isset($context['user']['language']) && $context['user']['language'] == $language['filename'] ? ' selected="selected"' : '', '>', str_replace('-utf8', '', $language['name']), '</option>';
253
+		}
242 254
 
243 255
 		echo '
244 256
 				</select>
@@ -262,32 +274,37 @@  discard block
 block discarded – undo
262 274
 					<option value="all"', ($selected == 'all' ? ' selected' : ''), '>', $txt['search_entireforum'], ' </option>';
263 275
 
264 276
 		// Can't limit it to a specific topic if we are not in one
265
-		if (!empty($context['current_topic']))
266
-			echo '
277
+		if (!empty($context['current_topic'])) {
278
+					echo '
267 279
 					<option value="topic"', ($selected == 'current_topic' ? ' selected' : ''), '>', $txt['search_thistopic'], '</option>';
280
+		}
268 281
 
269 282
 		// Can't limit it to a specific board if we are not in one
270
-		if (!empty($context['current_board']))
271
-			echo '
283
+		if (!empty($context['current_board'])) {
284
+					echo '
272 285
 					<option value="board"', ($selected == 'current_board' ? ' selected' : ''), '>', $txt['search_thisbrd'], '</option>';
286
+		}
273 287
 
274 288
 		// Can't search for members if we can't see the memberlist
275
-		if (!empty($context['allow_memberlist']))
276
-			echo '
289
+		if (!empty($context['allow_memberlist'])) {
290
+					echo '
277 291
 					<option value="members"', ($selected == 'members' ? ' selected' : ''), '>', $txt['search_members'], ' </option>';
292
+		}
278 293
 
279 294
 		echo '
280 295
 				</select>';
281 296
 
282 297
 		// Search within current topic?
283
-		if (!empty($context['current_topic']))
284
-			echo '
298
+		if (!empty($context['current_topic'])) {
299
+					echo '
285 300
 				<input type="hidden" name="sd_topic" value="', $context['current_topic'], '">';
301
+		}
286 302
 
287 303
 		// If we're on a certain board, limit it to this board ;).
288
-		elseif (!empty($context['current_board']))
289
-			echo '
304
+		elseif (!empty($context['current_board'])) {
305
+					echo '
290 306
 				<input type="hidden" name="sd_brd" value="', $context['current_board'], '">';
307
+		}
291 308
 
292 309
 		echo '
293 310
 				<input type="submit" name="search2" value="', $txt['search'], '" class="button">
@@ -319,12 +336,13 @@  discard block
 block discarded – undo
319 336
 					</div>';
320 337
 
321 338
 	// Show a random news item? (or you could pick one from news_lines...)
322
-	if (!empty($settings['enable_news']) && !empty($context['random_news_line']))
323
-		echo '
339
+	if (!empty($settings['enable_news']) && !empty($context['random_news_line'])) {
340
+			echo '
324 341
 					<div class="news">
325 342
 						<h2>', $txt['news'], ': </h2>
326 343
 						<p>', $context['random_news_line'], '</p>
327 344
 					</div>';
345
+	}
328 346
 
329 347
 	echo '
330 348
 					<hr class="clear">
@@ -385,9 +403,10 @@  discard block
 block discarded – undo
385 403
 		</ul>';
386 404
 
387 405
 	// Show the load time?
388
-	if ($context['show_load_time'])
389
-		echo '
406
+	if ($context['show_load_time']) {
407
+			echo '
390 408
 		<p>', sprintf($txt['page_created_full'], $context['load_time'], $context['load_queries']), '</p>';
409
+	}
391 410
 
392 411
 	echo '
393 412
 		</div>
@@ -418,18 +437,20 @@  discard block
 block discarded – undo
418 437
 	global $context, $shown_linktree, $scripturl, $txt;
419 438
 
420 439
 	// If linktree is empty, just return - also allow an override.
421
-	if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show))
422
-		return;
440
+	if (empty($context['linktree']) || (!empty($context['dont_default_linktree']) && !$force_show)) {
441
+			return;
442
+	}
423 443
 		echo '
424 444
 				<div class="navigate_section">
425 445
 					<ul>';
426 446
 
427
-	if ($context['user']['is_logged'])
428
-		echo '
447
+	if ($context['user']['is_logged']) {
448
+			echo '
429 449
 						<li class="unread_links">
430 450
 							<a href="', $scripturl, '?action=unread" title="', $txt['unread_since_visit'], '">', $txt['view_unread_category'], '</a>
431 451
 							<a href="', $scripturl, '?action=unreadreplies" title="', $txt['show_unread_replies'], '">', $txt['unread_replies'], '</a>
432 452
 						</li>';
453
+	}
433 454
 
434 455
 	// Each tree item has a URL and name. Some may have extra_before and extra_after.
435 456
 	foreach ($context['linktree'] as $link_num => $tree)
@@ -440,25 +461,29 @@  discard block
 block discarded – undo
440 461
 		// Don't show a separator for the first one.
441 462
 		// Better here. Always points to the next level when the linktree breaks to a second line.
442 463
 		// Picked a better looking HTML entity, and added support for RTL plus a span for styling.
443
-		if ($link_num != 0)
444
-			echo '
464
+		if ($link_num != 0) {
465
+					echo '
445 466
 							<span class="dividers">', $context['right_to_left'] ? ' &#9668; ' : ' &#9658; ', '</span>';
467
+		}
446 468
 
447 469
 		// Show something before the link?
448
-		if (isset($tree['extra_before']))
449
-			echo $tree['extra_before'], ' ';
470
+		if (isset($tree['extra_before'])) {
471
+					echo $tree['extra_before'], ' ';
472
+		}
450 473
 
451 474
 		// Show the link, including a URL if it should have one.
452
-		if (isset($tree['url']))
453
-			echo '
475
+		if (isset($tree['url'])) {
476
+					echo '
454 477
 							<a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>';
455
-		else
456
-			echo '
478
+		} else {
479
+					echo '
457 480
 							<span>' . $tree['name'] . '</span>';
481
+		}
458 482
 
459 483
 		// Show something after the link...?
460
-		if (isset($tree['extra_after']))
461
-			echo ' ', $tree['extra_after'];
484
+		if (isset($tree['extra_after'])) {
485
+					echo ' ', $tree['extra_after'];
486
+		}
462 487
 
463 488
 		echo '
464 489
 						</li>';
@@ -509,13 +534,14 @@  discard block
 block discarded – undo
509 534
 					echo '
510 535
 									<ul>';
511 536
 
512
-					foreach ($childbutton['sub_buttons'] as $grandchildbutton)
513
-						echo '
537
+					foreach ($childbutton['sub_buttons'] as $grandchildbutton) {
538
+											echo '
514 539
 										<li>
515 540
 											<a href="', $grandchildbutton['href'], '"', isset($grandchildbutton['target']) ? ' target="' . $grandchildbutton['target'] . '"' : '', '>
516 541
 												', $grandchildbutton['title'], '
517 542
 											</a>
518 543
 										</li>';
544
+					}
519 545
 
520 546
 					echo '
521 547
 									</ul>';
@@ -546,8 +572,9 @@  discard block
 block discarded – undo
546 572
 {
547 573
 	global $context, $txt;
548 574
 
549
-	if (!is_array($strip_options))
550
-		$strip_options = array();
575
+	if (!is_array($strip_options)) {
576
+			$strip_options = array();
577
+	}
551 578
 
552 579
 	// Create the buttons...
553 580
 	$buttons = array();
@@ -556,8 +583,9 @@  discard block
 block discarded – undo
556 583
 		// As of 2.1, the 'test' for each button happens while the array is being generated. The extra 'test' check here is deprecated but kept for backward compatibility (update your mods, folks!)
557 584
 		if (!isset($value['test']) || !empty($context[$value['test']]))
558 585
 		{
559
-			if (!isset($value['id']))
560
-				$value['id'] = $key;
586
+			if (!isset($value['id'])) {
587
+							$value['id'] = $key;
588
+			}
561 589
 
562 590
 			$button = '
563 591
 				<a class="button button_strip_' . $key . (!empty($value['active']) ? ' active' : '') . (isset($value['class']) ? ' ' . $value['class'] : '') . '" ' . (!empty($value['url']) ? 'href="' . $value['url'] . '"' : '') . ' ' . (isset($value['custom']) ? ' ' . $value['custom'] : '') . '>' . $txt[$value['text']] . '</a>';
@@ -570,13 +598,15 @@  discard block
 block discarded – undo
570 598
 							<div class="overview">';
571 599
 				foreach ($value['sub_buttons'] as $element)
572 600
 				{
573
-					if (isset($element['test']) && empty($context[$element['test']]))
574
-						continue;
601
+					if (isset($element['test']) && empty($context[$element['test']])) {
602
+											continue;
603
+					}
575 604
 
576 605
 					$button .= '
577 606
 								<a href="' . $element['url'] . '"><strong>' . $txt[$element['text']] . '</strong>';
578
-					if (isset($txt[$element['text'] . '_desc']))
579
-						$button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>';
607
+					if (isset($txt[$element['text'] . '_desc'])) {
608
+											$button .= '<br><span>' . $txt[$element['text'] . '_desc'] . '</span>';
609
+					}
580 610
 					$button .= '</a>';
581 611
 				}
582 612
 				$button .= '
@@ -590,8 +620,9 @@  discard block
 block discarded – undo
590 620
 	}
591 621
 
592 622
 	// No buttons? No button strip either.
593
-	if (empty($buttons))
594
-		return;
623
+	if (empty($buttons)) {
624
+			return;
625
+	}
595 626
 
596 627
 	echo '
597 628
 		<div class="buttonlist', !empty($direction) ? ' float' . $direction : '', '"', (empty($buttons) ? ' style="display: none;"' : ''), (!empty($strip_options['id']) ? ' id="' . $strip_options['id'] . '"' : ''), '>
Please login to merge, or discard this patch.
Themes/default/Admin.template.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -945,7 +945,7 @@
 block discarded – undo
945 945
 				}
946 946
 
947 947
 				echo isset($config_var['postinput']) ? '
948
-											' . $config_var['postinput'] : '','
948
+											' . $config_var['postinput'] : '', '
949 949
 									</dd>';
950 950
 			}
951 951
 		}
Please login to merge, or discard this patch.
Braces   +179 added lines, -128 removed lines patch added patch discarded remove patch
@@ -65,9 +65,10 @@  discard block
 block discarded – undo
65 65
 										', implode(', ', $context['administrators']);
66 66
 
67 67
 	// If we have lots of admins... don't show them all.
68
-	if (!empty($context['more_admins_link']))
69
-		echo '
68
+	if (!empty($context['more_admins_link'])) {
69
+			echo '
70 70
 										(', $context['more_admins_link'], ')';
71
+	}
71 72
 
72 73
 	echo '
73 74
 									</div><!-- #version_details -->
@@ -84,17 +85,19 @@  discard block
 block discarded – undo
84 85
 		foreach ($area['areas'] as $item_id => $item)
85 86
 		{
86 87
 			// No point showing the 'home' page here, we're already on it!
87
-			if ($area_id == 'forum' && $item_id == 'index')
88
-				continue;
88
+			if ($area_id == 'forum' && $item_id == 'index') {
89
+							continue;
90
+			}
89 91
 
90 92
 			$url = isset($item['url']) ? $item['url'] : $scripturl . '?action=admin;area=' . $item_id . (!empty($context[$context['admin_menu_name']]['extra_parameters']) ? $context[$context['admin_menu_name']]['extra_parameters'] : '');
91 93
 
92
-			if (!empty($item['icon_file']))
93
-				echo '
94
+			if (!empty($item['icon_file'])) {
95
+							echo '
94 96
 							<a href="', $url, '" class="admin_group', !empty($item['inactive']) ? ' inactive' : '', '"><img class="large_admin_menu_icon_file" src="', $item['icon_file'], '" alt="">', $item['label'], '</a>';
95
-			else
96
-				echo '
97
+			} else {
98
+							echo '
97 99
 							<a href="', $url, '"><span class="large_', $item['icon_class'], !empty($item['inactive']) ? ' inactive' : '', '"></span>', $item['label'], '</a>';
100
+			}
98 101
 		}
99 102
 
100 103
 		echo '
@@ -105,10 +108,11 @@  discard block
 block discarded – undo
105 108
 					</div><!-- #admincenter -->';
106 109
 
107 110
 	// The below functions include all the scripts needed from the simplemachines.org site. The language and format are passed for internationalization.
108
-	if (empty($modSettings['disable_smf_js']))
109
-		echo '
111
+	if (empty($modSettings['disable_smf_js'])) {
112
+			echo '
110 113
 					<script src="', $scripturl, '?action=viewsmfile;filename=current-version.js"></script>
111 114
 					<script src="', $scripturl, '?action=viewsmfile;filename=latest-news.js"></script>';
115
+	}
112 116
 
113 117
 	// This sets the announcements and current versions themselves ;).
114 118
 	echo '
@@ -187,9 +191,10 @@  discard block
 block discarded – undo
187 191
 								<em>', $version['version'], '</em>';
188 192
 
189 193
 		// more details for this item, show them a link
190
-		if ($context['can_admin'] && isset($version['more']))
191
-			echo
194
+		if ($context['can_admin'] && isset($version['more'])) {
195
+					echo
192 196
 								' <a href="', $scripturl, $version['more'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['version_check_more'], '</a>';
197
+		}
193 198
 		echo '
194 199
 								<br>';
195 200
 	}
@@ -220,21 +225,23 @@  discard block
 block discarded – undo
220 225
 
221 226
 	foreach ($context['credits'] as $section)
222 227
 	{
223
-		if (isset($section['pretext']))
224
-			echo '
228
+		if (isset($section['pretext'])) {
229
+					echo '
225 230
 								<p>', $section['pretext'], '</p>
226 231
 								<hr>';
232
+		}
227 233
 
228 234
 		echo '
229 235
 								<dl>';
230 236
 
231 237
 		foreach ($section['groups'] as $group)
232 238
 		{
233
-			if (isset($group['title']))
234
-				echo '
239
+			if (isset($group['title'])) {
240
+							echo '
235 241
 									<dt>
236 242
 										<strong>', $group['title'], ':</strong>
237 243
 									</dt>';
244
+			}
238 245
 
239 246
 			echo '
240 247
 									<dd>', implode(', ', $group['members']), '</dd>';
@@ -243,10 +250,11 @@  discard block
 block discarded – undo
243 250
 		echo '
244 251
 								</dl>';
245 252
 
246
-		if (isset($section['posttext']))
247
-			echo '
253
+		if (isset($section['posttext'])) {
254
+					echo '
248 255
 								<hr>
249 256
 								<p>', $section['posttext'], '</p>';
257
+		}
250 258
 	}
251 259
 
252 260
 	echo '
@@ -262,9 +270,10 @@  discard block
 block discarded – undo
262 270
 						smfSupportVersions.forum = "', $context['forum_version'], '";';
263 271
 
264 272
 	// Don't worry, none of this is logged, it's just used to give information that might be of use.
265
-	foreach ($context['current_versions'] as $variable => $version)
266
-		echo '
273
+	foreach ($context['current_versions'] as $variable => $version) {
274
+			echo '
267 275
 						smfSupportVersions.', $variable, ' = "', $version['version'], '";';
276
+	}
268 277
 
269 278
 	// Now we just have to include the script and wait ;).
270 279
 	echo '
@@ -361,8 +370,8 @@  discard block
 block discarded – undo
361 370
 								<tbody>';
362 371
 
363 372
 	// Loop through every source file displaying its version - using javascript.
364
-	foreach ($context['file_versions'] as $filename => $version)
365
-		echo '
373
+	foreach ($context['file_versions'] as $filename => $version) {
374
+			echo '
366 375
 									<tr class="windowbg">
367 376
 										<td class="half_table">
368 377
 											', $filename, '
@@ -374,6 +383,7 @@  discard block
 block discarded – undo
374 383
 											<em id="currentSources', $filename, '">??</em>
375 384
 										</td>
376 385
 									</tr>';
386
+	}
377 387
 
378 388
 	// Default template files.
379 389
 	echo '
@@ -399,8 +409,8 @@  discard block
 block discarded – undo
399 409
 							<table id="Default" class="table_grid">
400 410
 								<tbody>';
401 411
 
402
-	foreach ($context['default_template_versions'] as $filename => $version)
403
-		echo '
412
+	foreach ($context['default_template_versions'] as $filename => $version) {
413
+			echo '
404 414
 									<tr class="windowbg">
405 415
 										<td class="half_table">
406 416
 											', $filename, '
@@ -412,6 +422,7 @@  discard block
 block discarded – undo
412 422
 											<em id="currentDefault', $filename, '">??</em>
413 423
 										</td>
414 424
 									</tr>';
425
+	}
415 426
 
416 427
 	// Now the language files...
417 428
 	echo '
@@ -439,8 +450,8 @@  discard block
 block discarded – undo
439 450
 
440 451
 	foreach ($context['default_language_versions'] as $language => $files)
441 452
 	{
442
-		foreach ($files as $filename => $version)
443
-			echo '
453
+		foreach ($files as $filename => $version) {
454
+					echo '
444 455
 									<tr class="windowbg">
445 456
 										<td class="half_table">
446 457
 											', $filename, '.<em>', $language, '</em>.php
@@ -452,6 +463,7 @@  discard block
 block discarded – undo
452 463
 											<em id="current', $filename, '.', $language, '">??</em>
453 464
 										</td>
454 465
 									</tr>';
466
+		}
455 467
 	}
456 468
 
457 469
 	echo '
@@ -481,8 +493,8 @@  discard block
 block discarded – undo
481 493
 							<table id="Templates" class="table_grid">
482 494
 								<tbody>';
483 495
 
484
-		foreach ($context['template_versions'] as $filename => $version)
485
-			echo '
496
+		foreach ($context['template_versions'] as $filename => $version) {
497
+					echo '
486 498
 									<tr class="windowbg">
487 499
 										<td class="half_table">
488 500
 											', $filename, '
@@ -494,6 +506,7 @@  discard block
 block discarded – undo
494 506
 											<em id="currentTemplates', $filename, '">??</em>
495 507
 										</td>
496 508
 									</tr>';
509
+		}
497 510
 
498 511
 		echo '
499 512
 								</tbody>
@@ -523,8 +536,8 @@  discard block
 block discarded – undo
523 536
 							<table id="Tasks" class="table_grid">
524 537
 								<tbody>';
525 538
 
526
-		foreach ($context['tasks_versions'] as $filename => $version)
527
-			echo '
539
+		foreach ($context['tasks_versions'] as $filename => $version) {
540
+					echo '
528 541
 									<tr class="windowbg">
529 542
 										<td class="half_table">
530 543
 											', $filename, '
@@ -536,6 +549,7 @@  discard block
 block discarded – undo
536 549
 											<em id="currentTasks', $filename, '">??</em>
537 550
 										</td>
538 551
 									</tr>';
552
+		}
539 553
 
540 554
 		echo '
541 555
 								</tbody>
@@ -577,9 +591,10 @@  discard block
 block discarded – undo
577 591
 {
578 592
 	global $context, $scripturl, $txt, $modSettings;
579 593
 
580
-	if (!empty($context['saved_successful']))
581
-		echo '
594
+	if (!empty($context['saved_successful'])) {
595
+			echo '
582 596
 					<div class="infobox">', $txt['settings_saved'], '</div>';
597
+	}
583 598
 
584 599
 	// First section is for adding/removing words from the censored list.
585 600
 	echo '
@@ -594,11 +609,12 @@  discard block
 block discarded – undo
594 609
 								<p>', $txt['admin_censored_where'], '</p>';
595 610
 
596 611
 	// Show text boxes for censoring [bad   ] => [good  ].
597
-	foreach ($context['censored_words'] as $vulgar => $proper)
598
-		echo '
612
+	foreach ($context['censored_words'] as $vulgar => $proper) {
613
+			echo '
599 614
 								<div class="block">
600 615
 									<input type="text" name="censor_vulgar[]" value="', $vulgar, '" size="30"> =&gt; <input type="text" name="censor_proper[]" value="', $proper, '" size="30">
601 616
 								</div>';
617
+	}
602 618
 
603 619
 	// Now provide a way to censor more words.
604 620
 	echo '
@@ -673,19 +689,21 @@  discard block
 block discarded – undo
673 689
 						<div class="windowbg2 noup">
674 690
 							', $txt['not_done_reason'];
675 691
 
676
-	if (!empty($context['continue_percent']))
677
-		echo '
692
+	if (!empty($context['continue_percent'])) {
693
+			echo '
678 694
 							<div class="progress_bar">
679 695
 								<div class="full_bar">', $context['continue_percent'], '%</div>
680 696
 								<div class="green_percent" style="width: ', $context['continue_percent'], '%;"></div>
681 697
 							</div>';
698
+	}
682 699
 
683
-	if (!empty($context['substep_enabled']))
684
-		echo '
700
+	if (!empty($context['substep_enabled'])) {
701
+			echo '
685 702
 							<div class="progress_bar">
686 703
 								<div class="full_bar">', $context['substep_title'], ' (', $context['substep_continue_percent'], '%)</div>
687 704
 								<div class="blue_percent" style="width: ', $context['substep_continue_percent'], '%;"></div>
688 705
 							</div>';
706
+	}
689 707
 
690 708
 	echo '
691 709
 							<form action="', $scripturl, $context['continue_get_data'], '" method="post" accept-charset="', $context['character_set'], '" name="autoSubmit" id="autoSubmit">
@@ -720,35 +738,40 @@  discard block
 block discarded – undo
720 738
 {
721 739
 	global $context, $txt, $scripturl;
722 740
 
723
-	if (!empty($context['saved_successful']))
724
-		echo '
741
+	if (!empty($context['saved_successful'])) {
742
+			echo '
725 743
 					<div class="infobox">', $txt['settings_saved'], '</div>';
726
-	elseif (!empty($context['saved_failed']))
727
-		echo '
744
+	} elseif (!empty($context['saved_failed'])) {
745
+			echo '
728 746
 					<div class="errorbox">', sprintf($txt['settings_not_saved'], $context['saved_failed']), '</div>';
747
+	}
729 748
 
730
-	if (!empty($context['settings_pre_javascript']))
731
-		echo '
749
+	if (!empty($context['settings_pre_javascript'])) {
750
+			echo '
732 751
 					<script>', $context['settings_pre_javascript'], '</script>';
752
+	}
733 753
 
734
-	if (!empty($context['settings_insert_above']))
735
-		echo $context['settings_insert_above'];
754
+	if (!empty($context['settings_insert_above'])) {
755
+			echo $context['settings_insert_above'];
756
+	}
736 757
 
737 758
 	echo '
738 759
 					<div id="admincenter">
739 760
 						<form id="admin_form_wrapper" action="', $context['post_url'], '" method="post" accept-charset="', $context['character_set'], '"', !empty($context['force_form_onsubmit']) ? ' onsubmit="' . $context['force_form_onsubmit'] . '"' : '', '>';
740 761
 
741 762
 	// Is there a custom title?
742
-	if (isset($context['settings_title']))
743
-		echo '
763
+	if (isset($context['settings_title'])) {
764
+			echo '
744 765
 							<div class="cat_bar">
745 766
 								<h3 class="catbg">', $context['settings_title'], '</h3>
746 767
 							</div>';
768
+	}
747 769
 
748 770
 	// Have we got a message to display?
749
-	if (!empty($context['settings_message']))
750
-		echo '
771
+	if (!empty($context['settings_message'])) {
772
+			echo '
751 773
 							<div class="information">', $context['settings_message'], '</div>';
774
+	}
752 775
 
753 776
 	// Now actually loop through all the variables.
754 777
 	$is_open = false;
@@ -801,8 +824,9 @@  discard block
 block discarded – undo
801 824
 		// Hang about? Are you pulling my leg - a callback?!
802 825
 		if (is_array($config_var) && $config_var['type'] == 'callback')
803 826
 		{
804
-			if (function_exists('template_callback_' . $config_var['name']))
805
-				call_user_func('template_callback_' . $config_var['name']);
827
+			if (function_exists('template_callback_' . $config_var['name'])) {
828
+							call_user_func('template_callback_' . $config_var['name']);
829
+			}
806 830
 
807 831
 			continue;
808 832
 		}
@@ -832,9 +856,10 @@  discard block
 block discarded – undo
832 856
 				$text_types = array('color', 'date', 'datetime', 'datetime-local', 'email', 'month', 'time');
833 857
 
834 858
 				// Show the [?] button.
835
-				if ($config_var['help'])
836
-					echo '
859
+				if ($config_var['help']) {
860
+									echo '
837 861
 										<a id="setting_', $config_var['name'], '_help" href="', $scripturl, '?action=helpadmin;help=', $config_var['help'], '" onclick="return reqOverlayDiv(this.href);"><span class="generic_icons help" title="', $txt['help'], '"></span></a> ';
862
+				}
838 863
 
839 864
 				echo '
840 865
 										<a id="setting_', $config_var['name'], '"></a> <span', ($config_var['disabled'] ? ' style="color: #777777;"' : ($config_var['invalid'] ? ' class="error"' : '')), '><label for="', $config_var['name'], '">', $config_var['label'], '</label>', $subtext, ($config_var['type'] == 'password' ? '<br><em>' . $txt['admin_confirm_password'] . '</em>' : ''), '</span>
@@ -843,23 +868,26 @@  discard block
 block discarded – undo
843 868
 										$config_var['preinput'];
844 869
 
845 870
 				// Show a check box.
846
-				if ($config_var['type'] == 'check')
847
-					echo '
871
+				if ($config_var['type'] == 'check') {
872
+									echo '
848 873
 										<input type="checkbox"', $javascript, $disabled, ' name="', $config_var['name'], '" id="', $config_var['name'], '"', ($config_var['value'] ? ' checked' : ''), ' value="1">';
874
+				}
849 875
 				// Escape (via htmlspecialchars.) the text box.
850
-				elseif ($config_var['type'] == 'password')
851
-					echo '
876
+				elseif ($config_var['type'] == 'password') {
877
+									echo '
852 878
 										<input type="password"', $disabled, $javascript, ' name="', $config_var['name'], '[0]"', ($config_var['size'] ? ' size="' . $config_var['size'] . '"' : ''), ' value="*#fakepass#*" onfocus="this.value = \'\'; this.form.', $config_var['name'], '.disabled = false;"><br>
853 879
 										<input type="password" disabled id="', $config_var['name'], '" name="', $config_var['name'], '[1]"', ($config_var['size'] ? ' size="' . $config_var['size'] . '"' : ''), '>';
880
+				}
854 881
 				// Show a selection box.
855 882
 				elseif ($config_var['type'] == 'select')
856 883
 				{
857 884
 					echo '
858 885
 										<select name="', $config_var['name'], '" id="', $config_var['name'], '" ', $javascript, $disabled, (!empty($config_var['multiple']) ? ' multiple="multiple"' : ''), (!empty($config_var['multiple']) && !empty($config_var['size']) ? ' size="' . $config_var['size'] . '"' : ''), '>';
859 886
 
860
-					foreach ($config_var['data'] as $option)
861
-						echo '
887
+					foreach ($config_var['data'] as $option) {
888
+											echo '
862 889
 											<option value="', $option[0], '"', (!empty($config_var['value']) && ($option[0] == $config_var['value'] || (!empty($config_var['multiple']) && in_array($option[0], $config_var['value']))) ? ' selected' : ''), '>', $option[1], '</option>';
890
+					}
863 891
 					echo '
864 892
 										</select>';
865 893
 				}
@@ -876,16 +904,18 @@  discard block
 block discarded – undo
876 904
 
877 905
 					foreach ($context['board_list'] as $id_cat => $cat)
878 906
 					{
879
-						if (!$first)
880
-							echo '
907
+						if (!$first) {
908
+													echo '
881 909
 											<hr>';
910
+						}
882 911
 						echo '
883 912
 											<strong>', $cat['name'], '</strong>
884 913
 											<ul>';
885 914
 
886
-						foreach ($cat['boards'] as $id_board => $brd)
887
-							echo '
915
+						foreach ($cat['boards'] as $id_board => $brd) {
916
+													echo '
888 917
 												<li><label><input type="checkbox" name="', $config_var['name'], '[', $brd['id'], ']" value="1"', in_array($brd['id'], $config_var['value']) ? ' checked' : '', '> ', $brd['child_level'] > 0 ? str_repeat('&nbsp; &nbsp;', $brd['child_level']) : '', $brd['name'], '</label></li>';
918
+						}
889 919
 
890 920
 						echo '
891 921
 											</ul>';
@@ -895,12 +925,14 @@  discard block
 block discarded – undo
895 925
 										</fieldset>';
896 926
 				}
897 927
 				// Text area?
898
-				elseif ($config_var['type'] == 'large_text')
899
-					echo '
928
+				elseif ($config_var['type'] == 'large_text') {
929
+									echo '
900 930
 										<textarea rows="', (!empty($config_var['size']) ? $config_var['size'] : (!empty($config_var['rows']) ? $config_var['rows'] : 4)), '" cols="', (!empty($config_var['cols']) ? $config_var['cols'] : 30), '" ', $javascript, $disabled, ' name="', $config_var['name'], '" id="', $config_var['name'], '">', $config_var['value'], '</textarea>';
931
+				}
901 932
 				// Permission group?
902
-				elseif ($config_var['type'] == 'permissions')
903
-					theme_inline_permissions($config_var['name']);
933
+				elseif ($config_var['type'] == 'permissions') {
934
+									theme_inline_permissions($config_var['name']);
935
+				}
904 936
 
905 937
 				// BBC selection?
906 938
 				elseif ($config_var['type'] == 'bbc')
@@ -912,22 +944,24 @@  discard block
 block discarded – undo
912 944
 
913 945
 					foreach ($context['bbc_columns'] as $bbcColumn)
914 946
 					{
915
-						foreach ($bbcColumn as $bbcTag)
916
-							echo '
947
+						foreach ($bbcColumn as $bbcTag) {
948
+													echo '
917 949
 												<li class="list_bbc floatleft">
918 950
 													<input type="checkbox" name="', $config_var['name'], '_enabledTags[]" id="tag_', $config_var['name'], '_', $bbcTag['tag'], '" value="', $bbcTag['tag'], '"', !in_array($bbcTag['tag'], $context['bbc_sections'][$config_var['name']]['disabled']) ? ' checked' : '', '> <label for="tag_', $config_var['name'], '_', $bbcTag['tag'], '">', $bbcTag['tag'], '</label>', $bbcTag['show_help'] ? ' (<a href="' . $scripturl . '?action=helpadmin;help=tag_' . $bbcTag['tag'] . '" onclick="return reqOverlayDiv(this.href);">?</a>)' : '', '
919 951
 												</li>';
952
+						}
920 953
 					}
921 954
 					echo '					</ul>
922 955
 											<input type="checkbox" id="bbc_', $config_var['name'], '_select_all" onclick="invertAll(this, this.form, \'', $config_var['name'], '_enabledTags\');"', $context['bbc_sections'][$config_var['name']]['all_selected'] ? ' checked' : '', '> <label for="bbc_', $config_var['name'], '_select_all"><em>', $txt['bbcTagsToUse_select_all'], '</em></label>
923 956
 										</fieldset>';
924 957
 				}
925 958
 				// A simple message?
926
-				elseif ($config_var['type'] == 'var_message')
927
-					echo '
959
+				elseif ($config_var['type'] == 'var_message') {
960
+									echo '
928 961
 										<div', !empty($config_var['name']) ? ' id="' . $config_var['name'] . '"' : '', '>
929 962
 											', $config_var['var_message'], '
930 963
 										</div>';
964
+				}
931 965
 				// Assume it must be a text box
932 966
 				else
933 967
 				{
@@ -952,62 +986,70 @@  discard block
 block discarded – undo
952 986
 											' . $config_var['postinput'] : '','
953 987
 									</dd>';
954 988
 			}
955
-		}
956
-		else
989
+		} else
957 990
 		{
958 991
 			// Just show a separator.
959
-			if ($config_var == '')
960
-				echo '
992
+			if ($config_var == '') {
993
+							echo '
961 994
 								</dl>
962 995
 								<hr>
963 996
 								<dl class="settings">';
964
-			else
965
-				echo '
997
+			} else {
998
+							echo '
966 999
 									<dd>
967 1000
 										<strong>' . $config_var . '</strong>
968 1001
 									</dd>';
1002
+			}
969 1003
 		}
970 1004
 	}
971 1005
 
972
-	if ($is_open)
973
-		echo '
1006
+	if ($is_open) {
1007
+			echo '
974 1008
 								</dl>';
1009
+	}
975 1010
 
976
-	if (empty($context['settings_save_dont_show']))
977
-		echo '
1011
+	if (empty($context['settings_save_dont_show'])) {
1012
+			echo '
978 1013
 								<input type="submit" value="', $txt['save'], '"', (!empty($context['save_disabled']) ? ' disabled' : ''), (!empty($context['settings_save_onclick']) ? ' onclick="' . $context['settings_save_onclick'] . '"' : ''), ' class="button">';
1014
+	}
979 1015
 
980
-	if ($is_open)
981
-		echo '
1016
+	if ($is_open) {
1017
+			echo '
982 1018
 							</div><!-- .windowbg2 -->';
1019
+	}
983 1020
 
984 1021
 
985 1022
 	// At least one token has to be used!
986
-	if (isset($context['admin-ssc_token']))
987
-		echo '
1023
+	if (isset($context['admin-ssc_token'])) {
1024
+			echo '
988 1025
 							<input type="hidden" name="', $context['admin-ssc_token_var'], '" value="', $context['admin-ssc_token'], '">';
1026
+	}
989 1027
 
990
-	if (isset($context['admin-dbsc_token']))
991
-		echo '
1028
+	if (isset($context['admin-dbsc_token'])) {
1029
+			echo '
992 1030
 							<input type="hidden" name="', $context['admin-dbsc_token_var'], '" value="', $context['admin-dbsc_token'], '">';
1031
+	}
993 1032
 
994
-	if (isset($context['admin-mp_token']))
995
-		echo '
1033
+	if (isset($context['admin-mp_token'])) {
1034
+			echo '
996 1035
 							<input type="hidden" name="', $context['admin-mp_token_var'], '" value="', $context['admin-mp_token'], '">';
1036
+	}
997 1037
 
998 1038
 	echo '
999 1039
 							<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1000 1040
 						</form>
1001 1041
 					</div><!-- #admincenter -->';
1002 1042
 
1003
-	if (!empty($context['settings_post_javascript']))
1004
-		echo '
1043
+	if (!empty($context['settings_post_javascript'])) {
1044
+			echo '
1005 1045
 					<script>
1006 1046
 						', $context['settings_post_javascript'], '
1007 1047
 					</script>';
1048
+	}
1008 1049
 
1009
-	if (!empty($context['settings_insert_below']))
1010
-		echo $context['settings_insert_below'];
1050
+	if (!empty($context['settings_insert_below'])) {
1051
+			echo $context['settings_insert_below'];
1052
+	}
1011 1053
 
1012 1054
 	// We may have added a board listing. If we did, we need to make it work.
1013 1055
 	addInlineJavascript('
@@ -1030,9 +1072,10 @@  discard block
 block discarded – undo
1030 1072
 {
1031 1073
 	global $context, $txt;
1032 1074
 
1033
-	if (!empty($context['saved_successful']))
1034
-		echo '
1075
+	if (!empty($context['saved_successful'])) {
1076
+			echo '
1035 1077
 					<div class="infobox">', $txt['settings_saved'], '</div>';
1078
+	}
1036 1079
 
1037 1080
 	// Standard fields.
1038 1081
 	template_show_list('standard_profile_fields');
@@ -1066,11 +1109,12 @@  discard block
 block discarded – undo
1066 1109
 	{
1067 1110
 		loadLanguage('Errors');
1068 1111
 
1069
-		if (isset($txt['custom_option_' . $_GET['msg']]))
1070
-			echo '
1112
+		if (isset($txt['custom_option_' . $_GET['msg']])) {
1113
+					echo '
1071 1114
 					<div class="errorbox">',
1072 1115
 						$txt['custom_option_' . $_GET['msg']], '
1073 1116
 					</div>';
1117
+		}
1074 1118
 	}
1075 1119
 
1076 1120
 	echo '
@@ -1137,9 +1181,10 @@  discard block
 block discarded – undo
1137 1181
 										<dd>
1138 1182
 											<select name="placement" id="placement">';
1139 1183
 
1140
-	foreach ($context['cust_profile_fields_placement'] as $order => $name)
1141
-		echo '
1184
+	foreach ($context['cust_profile_fields_placement'] as $order => $name) {
1185
+			echo '
1142 1186
 												<option value="', $order, '"', $context['field']['placement'] == $order ? ' selected' : '', '>', $txt['custom_profile_placement_' . $name], '</option>';
1187
+	}
1143 1188
 
1144 1189
 	echo '
1145 1190
 											</select>
@@ -1163,9 +1208,10 @@  discard block
 block discarded – undo
1163 1208
 										<dd>
1164 1209
 											<select name="field_type" id="field_type" onchange="updateInputBoxes();">';
1165 1210
 
1166
-	foreach (array('text', 'textarea', 'select', 'radio', 'check') as $field_type)
1167
-		echo '
1211
+	foreach (array('text', 'textarea', 'select', 'radio', 'check') as $field_type) {
1212
+			echo '
1168 1213
 												<option value="', $field_type, '"', $context['field']['type'] == $field_type ? ' selected' : '', '>', $txt['custom_profile_type_' . $field_type], '</option>';
1214
+	}
1169 1215
 
1170 1216
 	echo '
1171 1217
 											</select>
@@ -1197,9 +1243,10 @@  discard block
 block discarded – undo
1197 1243
 										</dt>
1198 1244
 										<dd id="options_dd">';
1199 1245
 
1200
-	foreach ($context['field']['options'] as $k => $option)
1201
-		echo '
1246
+	foreach ($context['field']['options'] as $k => $option) {
1247
+			echo '
1202 1248
 											', $k == 0 ? '' : '<br>', '<input type="radio" name="default_select" value="', $k, '"', $context['field']['default_select'] == $option ? ' checked' : '', '><input type="text" name="select_option[', $k, ']" value="', $option, '">';
1249
+	}
1203 1250
 
1204 1251
 	echo '
1205 1252
 											<span id="addopt"></span>
@@ -1263,9 +1310,10 @@  discard block
 block discarded – undo
1263 1310
 								</fieldset>
1264 1311
 								<input type="submit" name="save" value="', $txt['save'], '" class="button">';
1265 1312
 
1266
-	if ($context['fid'])
1267
-		echo '
1313
+	if ($context['fid']) {
1314
+			echo '
1268 1315
 								<input type="submit" name="delete" value="', $txt['delete'], '" data-confirm="', $txt['custom_edit_delete_sure'], '" class="button you_sure">';
1316
+	}
1269 1317
 
1270 1318
 	echo '
1271 1319
 							</div><!-- .windowbg2 -->
@@ -1312,8 +1360,7 @@  discard block
 block discarded – undo
1312 1360
 							<p class="centertext">
1313 1361
 								<strong>', $txt['admin_search_results_none'], '</strong>
1314 1362
 							</p>';
1315
-	}
1316
-	else
1363
+	} else
1317 1364
 	{
1318 1365
 		echo '
1319 1366
 							<ol class="search_results">';
@@ -1340,9 +1387,10 @@  discard block
 block discarded – undo
1340 1387
 								<li>
1341 1388
 									<a href="', $result['url'], '"><strong>', $result['name'], '</strong></a> [', isset($txt['admin_search_section_' . $result['type']]) ? $txt['admin_search_section_' . $result['type']] : $result['type'], ']';
1342 1389
 
1343
-				if ($result['help'])
1344
-					echo '
1390
+				if ($result['help']) {
1391
+									echo '
1345 1392
 									<p class="double_height">', $result['help'], '</p>';
1393
+				}
1346 1394
 
1347 1395
 				echo '
1348 1396
 								</li>';
@@ -1382,10 +1430,11 @@  discard block
 block discarded – undo
1382 1430
 									<strong>', $txt['setup_verification_answer'], '</strong>
1383 1431
 								</dd>';
1384 1432
 
1385
-		if (!empty($context['qa_by_lang'][$lang_id]))
1386
-			foreach ($context['qa_by_lang'][$lang_id] as $q_id)
1433
+		if (!empty($context['qa_by_lang'][$lang_id])) {
1434
+					foreach ($context['qa_by_lang'][$lang_id] as $q_id)
1387 1435
 			{
1388 1436
 				$question = $context['question_answers'][$q_id];
1437
+		}
1389 1438
 
1390 1439
 				echo '
1391 1440
 								<dt>
@@ -1393,9 +1442,10 @@  discard block
 block discarded – undo
1393 1442
 								</dt>
1394 1443
 								<dd>';
1395 1444
 
1396
-				foreach ($question['answers'] as $answer)
1397
-					echo '
1445
+				foreach ($question['answers'] as $answer) {
1446
+									echo '
1398 1447
 									<input type="text" name="answer[', $lang_id, '][', $q_id, '][]" value="', $answer, '" size="50" class="verification_answer">';
1448
+				}
1399 1449
 
1400 1450
 				echo '
1401 1451
 									<div class="qa_add_answer"><a href="javascript:void(0);" onclick="return addAnswer(this);">[ ', $txt['setup_verification_add_answer'], ' ]</a></div>
@@ -1434,11 +1484,12 @@  discard block
 block discarded – undo
1434 1484
 							', $txt['errors_found'], ':
1435 1485
 							<ul>';
1436 1486
 
1437
-			foreach ($context['repair_errors'] as $error)
1438
-				echo '
1487
+			foreach ($context['repair_errors'] as $error) {
1488
+							echo '
1439 1489
 								<li>
1440 1490
 									', $error, '
1441 1491
 								</li>';
1492
+			}
1442 1493
 
1443 1494
 			echo '
1444 1495
 							</ul>
@@ -1448,16 +1499,15 @@  discard block
 block discarded – undo
1448 1499
 							<p class="padding">
1449 1500
 								<strong><a href="', $scripturl, '?action=admin;area=repairboards;fixErrors;', $context['session_var'], '=', $context['session_id'], '">', $txt['yes'], '</a> - <a href="', $scripturl, '?action=admin;area=maintain">', $txt['no'], '</a></strong>
1450 1501
 							</p>';
1451
-		}
1452
-		else
1453
-			echo '
1502
+		} else {
1503
+					echo '
1454 1504
 							<p>', $txt['maintain_no_errors'], '</p>
1455 1505
 							<p class="padding">
1456 1506
 								<a href="', $scripturl, '?action=admin;area=maintain;sa=routine">', $txt['maintain_return'], '</a>
1457 1507
 							</p>';
1508
+		}
1458 1509
 
1459
-	}
1460
-	else
1510
+	} else
1461 1511
 	{
1462 1512
 		if (!empty($context['redirect_to_recount']))
1463 1513
 		{
@@ -1469,8 +1519,7 @@  discard block
 block discarded – undo
1469 1519
 								<input type="hidden" name="', $context['session_var'], '" value="', $context['session_id'], '">
1470 1520
 								<input type="submit" name="recount" id="recount_now" value="', $txt['errors_recount_now'], '">
1471 1521
 							</form>';
1472
-		}
1473
-		else
1522
+		} else
1474 1523
 		{
1475 1524
 			echo '
1476 1525
 							<p>', $txt['errors_fixed'], '</p>
@@ -1561,9 +1610,10 @@  discard block
 block discarded – undo
1561 1610
 								<tr class="windowbg">
1562 1611
 									<td class="equal_table">', $key, '</td>';
1563 1612
 
1564
-				foreach ($setting as $key_lm => $value)
1565
-					echo '
1613
+				foreach ($setting as $key_lm => $value) {
1614
+									echo '
1566 1615
 									<td class="equal_table">', $value, '</td>';
1616
+				}
1567 1617
 
1568 1618
 				echo '
1569 1619
 								</tr>';
@@ -1623,8 +1673,8 @@  discard block
 block discarded – undo
1623 1673
 {
1624 1674
 	global $context, $txt;
1625 1675
 
1626
-	if ($context['user']['is_admin'])
1627
-		echo '
1676
+	if ($context['user']['is_admin']) {
1677
+			echo '
1628 1678
 								<span class="floatright admin_search">
1629 1679
 									<span class="generic_icons filter centericon"></span>
1630 1680
 									<input type="search" name="search_term" value="', $txt['admin_search'], '" onclick="if (this.value == \'', $txt['admin_search'], '\') this.value = \'\';">
@@ -1635,6 +1685,7 @@  discard block
 block discarded – undo
1635 1685
 									</select>
1636 1686
 									<input type="submit" name="search_go" id="search_go" value="', $txt['admin_search_go'], '" class="button">
1637 1687
 								</span>';
1638
-}
1688
+	}
1689
+	}
1639 1690
 
1640 1691
 ?>
1641 1692
\ No newline at end of file
Please login to merge, or discard this patch.
Themes/default/Printpage.template.php 1 patch
Braces   +11 added lines, -8 removed lines patch added patch discarded remove patch
@@ -144,11 +144,12 @@  discard block
 block discarded – undo
144 144
 				<div class="question">', $txt['poll_question'], ': <strong>', $context['poll']['question'], '</strong>';
145 145
 
146 146
 		$options = 1;
147
-		foreach ($context['poll']['options'] as $option)
148
-			echo '
147
+		foreach ($context['poll']['options'] as $option) {
148
+					echo '
149 149
 					<div class="', $option['voted_this'] ? 'voted' : '', '">', $txt['option'], ' ', $options++, ': <strong>', $option['option'], '</strong>
150 150
 						', $context['allow_poll_view'] ? $txt['votes'] . ': ' . $option['votes'] . '' : '', '
151 151
 					</div>';
152
+		}
152 153
 
153 154
 		echo '
154 155
 			</div>';
@@ -170,9 +171,10 @@  discard block
 block discarded – undo
170 171
 			echo '
171 172
 				<hr>';
172 173
 
173
-			foreach ($context['printattach'][$post['id_msg']] as $attach)
174
-				echo '
174
+			foreach ($context['printattach'][$post['id_msg']] as $attach) {
175
+							echo '
175 176
 					<img width="' . $attach['width'] . '" height="' . $attach['height'] . '" src="', $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attach['id_attach'] . '" alt="">';
177
+			}
176 178
 		}
177 179
 
178 180
 		echo '
@@ -207,12 +209,13 @@  discard block
 block discarded – undo
207 209
 		<div class="print_options">';
208 210
 
209 211
 	// Which option is set, text or text&images
210
-	if (isset($_REQUEST['images']))
211
-		echo '
212
+	if (isset($_REQUEST['images'])) {
213
+			echo '
212 214
 			<a href="', $url_text, '">', $txt['print_page_text'], '</a> | <strong><a href="', $url_images, '">', $txt['print_page_images'], '</a></strong>';
213
-	else
214
-		echo '
215
+	} else {
216
+			echo '
215 217
 			<strong><a href="', $url_text, '">', $txt['print_page_text'], '</a></strong> | <a href="', $url_images, '">', $txt['print_page_images'], '</a>';
218
+	}
216 219
 
217 220
 	echo '
218 221
 		</div><!-- .print_options -->';
Please login to merge, or discard this patch.
Themes/default/Xml.template.php 1 patch
Braces   +50 added lines, -37 removed lines patch added patch discarded remove patch
@@ -73,10 +73,10 @@  discard block
 block discarded – undo
73 73
 		<subject is_first="', $context['message']['first_in_topic'] ? '1' : '0', '"><![CDATA[', cleanXml($context['message']['subject']), ']]></subject>
74 74
 		<body><![CDATA[', $context['message']['body'], ']]></body>
75 75
 		<success><![CDATA[', $txt['quick_modify_message'], ']]></success>';
76
-	}
77
-	else
78
-		echo '
76
+	} else {
77
+			echo '
79 78
 		<error in_subject="', $context['message']['error_in_subject'] ? '1' : '0', '" in_body="', cleanXml($context['message']['error_in_body']) ? '1' : '0', '"><![CDATA[', implode('<br />', $context['message']['errors']), ']]></error>';
79
+	}
80 80
 	echo '
81 81
 	</message>
82 82
 </smf>';
@@ -101,13 +101,14 @@  discard block
 block discarded – undo
101 101
 		echo '
102 102
 		<modified><![CDATA[', empty($modified) ? '' : cleanXml('&#171; <em>' . $modified . '</em>&#187;'), ']]></modified>';
103 103
 
104
-		if (!empty($context['message']['subject']))
105
-			echo '
104
+		if (!empty($context['message']['subject'])) {
105
+					echo '
106 106
 		<subject><![CDATA[', cleanXml($context['message']['subject']), ']]></subject>';
107
-	}
108
-	else
109
-		echo '
107
+		}
108
+	} else {
109
+			echo '
110 110
 		<error in_subject="', $context['message']['error_in_subject'] ? '1' : '0', '"><![CDATA[', cleanXml(implode('<br />', $context['message']['errors'])), ']]></error>';
111
+	}
111 112
 	echo '
112 113
 	</message>
113 114
 </smf>';
@@ -128,10 +129,11 @@  discard block
 block discarded – undo
128 129
 	</preview>
129 130
 	<errors serious="', empty($context['error_type']) || $context['error_type'] != 'serious' ? '0' : '1', '" topic_locked="', $context['locked'] ? '1' : '0', '">';
130 131
 
131
-	if (!empty($context['post_error']))
132
-		foreach ($context['post_error'] as $message)
132
+	if (!empty($context['post_error'])) {
133
+			foreach ($context['post_error'] as $message)
133 134
 			echo '
134 135
 		<error><![CDATA[', cleanXml($message), ']]></error>';
136
+	}
135 137
 
136 138
 	echo '
137 139
 		<caption name="guestname" class="', isset($context['post_error']['long_name']) || isset($context['post_error']['no_name']) || isset($context['post_error']['bad_name']) ? 'error' : '', '" />
@@ -148,14 +150,15 @@  discard block
 block discarded – undo
148 150
 		echo '
149 151
 	<new_posts>';
150 152
 
151
-		foreach ($context['previous_posts'] as $post)
152
-			echo '
153
+		foreach ($context['previous_posts'] as $post) {
154
+					echo '
153 155
 		<post id="', $post['id'], '">
154 156
 			<time><![CDATA[', $post['time'], ']]></time>
155 157
 			<poster><![CDATA[', cleanXml($post['poster']), ']]></poster>
156 158
 			<message><![CDATA[', cleanXml($post['message']), ']]></message>
157 159
 			<is_ignored>', $post['is_ignored'] ? '1' : '0', '</is_ignored>
158 160
 		</post>';
161
+		}
159 162
 
160 163
 		echo '
161 164
 	</new_posts>';
@@ -181,10 +184,11 @@  discard block
 block discarded – undo
181 184
 	</preview>
182 185
 	<errors serious="', empty($context['error_type']) || $context['error_type'] != 'serious' ? '0' : '1', '">';
183 186
 
184
-	if (!empty($context['post_error']['messages']))
185
-		foreach ($context['post_error']['messages'] as $message)
187
+	if (!empty($context['post_error']['messages'])) {
188
+			foreach ($context['post_error']['messages'] as $message)
186 189
 			echo '
187 190
 		<error><![CDATA[', cleanXml($message), ']]></error>';
191
+	}
188 192
 
189 193
 	echo '
190 194
 		<caption name="to" class="', isset($context['post_error']['no_to']) ? 'error' : '', '" />
@@ -214,10 +218,11 @@  discard block
 block discarded – undo
214 218
 	</preview>
215 219
 	<errors serious="', empty($context['error_type']) || $context['error_type'] != 'serious' ? '0' : '1', '">';
216 220
 
217
-	if (!empty($context['post_error']['messages']))
218
-		foreach ($context['post_error']['messages'] as $message)
221
+	if (!empty($context['post_error']['messages'])) {
222
+			foreach ($context['post_error']['messages'] as $message)
219 223
 			echo '
220 224
 		<error><![CDATA[', cleanXml($message), ']]></error>';
225
+	}
221 226
 
222 227
 	echo '
223 228
 	</errors>';
@@ -233,20 +238,23 @@  discard block
 block discarded – undo
233 238
 {
234 239
 	global $context, $modSettings;
235 240
 
236
-	if (empty($context['yearly']))
237
-		return;
241
+	if (empty($context['yearly'])) {
242
+			return;
243
+	}
238 244
 
239 245
 	echo '<', '?xml version="1.0" encoding="', $context['character_set'], '"?', '>
240 246
 <smf>';
241
-	foreach ($context['yearly'] as $year)
242
-		foreach ($year['months'] as $month)
247
+	foreach ($context['yearly'] as $year) {
248
+			foreach ($year['months'] as $month)
243 249
 		{
244 250
 			echo '
245 251
 	<month id="', $month['date']['year'], $month['date']['month'], '">';
252
+	}
246 253
 
247
-			foreach ($month['days'] as $day)
248
-				echo '
254
+			foreach ($month['days'] as $day) {
255
+							echo '
249 256
 		<day date="', $day['year'], '-', $day['month'], '-', $day['day'], '" new_topics="', $day['new_topics'], '" new_posts="', $day['new_posts'], '" new_members="', $day['new_members'], '" most_members_online="', $day['most_members_online'], '"', empty($modSettings['hitStats']) ? '' : ' hits="' . $day['hits'] . '"', ' />';
257
+			}
250 258
 
251 259
 			echo '
252 260
 	</month>';
@@ -269,17 +277,18 @@  discard block
 block discarded – undo
269 277
 	<pageIndex section="selected" startFrom="', $context['selected']['start'], '"><![CDATA[', $context['selected']['page_index'], ']]></pageIndex>';
270 278
 	foreach ($context['changes'] as $change)
271 279
 	{
272
-		if ($change['type'] == 'remove')
273
-			echo '
280
+		if ($change['type'] == 'remove') {
281
+					echo '
274 282
 	<change id="', $change['id'], '" curAction="remove" section="', $change['section'], '" />';
275
-		else
276
-			echo '
283
+		} else {
284
+					echo '
277 285
 	<change id="', $change['id'], '" curAction="insert" section="', $change['section'], '">
278 286
 		<subject><![CDATA[', cleanXml($change['insert_value']['subject']), ']]></subject>
279 287
 		<time><![CDATA[', cleanXml($change['insert_value']['time']), ']]></time>
280 288
 		<body><![CDATA[', cleanXml($change['insert_value']['body']), ']]></body>
281 289
 		<poster><![CDATA[', cleanXml($change['insert_value']['poster']), ']]></poster>
282 290
 	</change>';
291
+		}
283 292
 	}
284 293
 	echo '
285 294
 </smf>';
@@ -310,10 +319,10 @@  discard block
 block discarded – undo
310 319
 	echo '<', '?xml version="1.0" encoding="', $context['character_set'], '"?', '>
311 320
 <smf>';
312 321
 
313
-	if (empty($context['topics']))
314
-		echo '
322
+	if (empty($context['topics'])) {
323
+			echo '
315 324
 		<noresults>', $txt['search_no_results'], '</noresults>';
316
-	else
325
+	} else
317 326
 	{
318 327
 		echo '
319 328
 		<results>';
@@ -382,9 +391,10 @@  discard block
 block discarded – undo
382 391
 		echo '
383 392
 	<item type="category" id="', $category['id'], '"><![CDATA[', cleanXml($category['name']), ']]></item>';
384 393
 
385
-		foreach ($category['boards'] as $board)
386
-			echo '
394
+		foreach ($category['boards'] as $board) {
395
+					echo '
387 396
 	<item type="board" id="', $board['id'], '" childlevel="', $board['child_level'], '"><![CDATA[', cleanXml($board['name']), ']]></item>';
397
+		}
388 398
 	}
389 399
 	echo '
390 400
 </smf>';
@@ -400,9 +410,10 @@  discard block
 block discarded – undo
400 410
 	echo '<', '?xml version="1.0" encoding="', $context['character_set'], '"?', '>
401 411
 <smf>';
402 412
 
403
-	foreach ($context['icons'] as $icon)
404
-		echo '
413
+	foreach ($context['icons'] as $icon) {
414
+			echo '
405 415
 	<icon value="', $icon['value'], '" url="', $icon['url'], '"><![CDATA[', cleanXml($icon['name']), ']]></icon>';
416
+	}
406 417
 
407 418
 	echo '
408 419
 </smf>';
@@ -452,16 +463,18 @@  discard block
 block discarded – undo
452 463
 	foreach ($xml_data as $key => $data)
453 464
 	{
454 465
 		// A group?
455
-		if (is_array($data) && isset($data['identifier']))
456
-			template_generic_xml_recursive($data['children'], $key, $data['identifier'], $level);
466
+		if (is_array($data) && isset($data['identifier'])) {
467
+					template_generic_xml_recursive($data['children'], $key, $data['identifier'], $level);
468
+		}
457 469
 		// An item...
458 470
 		elseif (is_array($data) && isset($data['value']))
459 471
 		{
460 472
 			echo "\n", str_repeat("\t", $level), '<', $child_ident;
461 473
 
462
-			if (!empty($data['attributes']))
463
-				foreach ($data['attributes'] as $k => $v)
474
+			if (!empty($data['attributes'])) {
475
+							foreach ($data['attributes'] as $k => $v)
464 476
 					echo ' ' . $k . '="' . $v . '"';
477
+			}
465 478
 			echo '><![CDATA[', cleanXml($data['value']), ']]></', $child_ident, '>';
466 479
 		}
467 480
 
Please login to merge, or discard this patch.
Themes/default/Likes.template.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 		<div class="windowbg">
32 32
 			<ul id="likes">';
33 33
 
34
-	foreach ($context['likers'] as $liker => $like_details)
35
-		echo '
34
+	foreach ($context['likers'] as $liker => $like_details) {
35
+			echo '
36 36
 				<li>
37 37
 					', $like_details['profile']['avatar']['image'], '
38 38
 					<span>
@@ -41,6 +41,7 @@  discard block
 block discarded – undo
41 41
 					</span>
42 42
 					<span class="floatright">', $like_details['time'], '</span>
43 43
 				</li>';
44
+	}
44 45
 
45 46
 	echo '
46 47
 			</ul>
@@ -61,11 +62,12 @@  discard block
 block discarded – undo
61 62
 	echo '
62 63
 	<ul class="floatleft">';
63 64
 
64
-	if (!empty($context['data']['can_like']))
65
-		echo '
65
+	if (!empty($context['data']['can_like'])) {
66
+			echo '
66 67
 		<li class="like_button" id="', $context['data']['type'], '_', $context['data']['id_content'], '_likes"', '>
67 68
 			<a href="', $scripturl, '?action=likes;ltype=', $context['data']['type'], ';sa=like;like=', $context['data']['id_content'], ';', $context['session_var'], '=', $context['session_id'], '" class="', $context['data']['type'], '_like"><span class="generic_icons ', $context['data']['already_liked'] ? 'unlike' : 'like', '"></span> ', $context['data']['already_liked'] ? $txt['unlike'] : $txt['like'], '</a>
68 69
 		</li>';
70
+	}
69 71
 
70 72
 	if (!empty($context['data']['count']))
71 73
 	{
Please login to merge, or discard this patch.
Themes/default/ManageBans.template.php 1 patch
Braces   +24 added lines, -16 removed lines patch added patch discarded remove patch
@@ -26,9 +26,10 @@  discard block
 block discarded – undo
26 26
 				</h3>
27 27
 			</div>';
28 28
 
29
-	if ($context['ban']['is_new'])
30
-		echo '
29
+	if ($context['ban']['is_new']) {
30
+			echo '
31 31
 			<div class="information noup">', $txt['ban_add_notes'], '</div>';
32
+	}
32 33
 
33 34
 	// If there were errors creating the ban, show them.
34 35
 	if (!empty($context['error_messages']))
@@ -38,9 +39,10 @@  discard block
 block discarded – undo
38 39
 				<strong>', $txt['ban_errors_detected'], '</strong>
39 40
 				<ul>';
40 41
 
41
-		foreach ($context['error_messages'] as $error)
42
-			echo '
42
+		foreach ($context['error_messages'] as $error) {
43
+					echo '
43 44
 					<li class="error">', $error, '</li>';
45
+		}
44 46
 
45 47
 		echo '
46 48
 				</ul>
@@ -57,8 +59,8 @@  discard block
 block discarded – undo
57 59
 						<input type="text" id="ban_name" name="ban_name" value="', $context['ban']['name'], '" size="45" maxlength="60">
58 60
 					</dd>';
59 61
 
60
-	if (isset($context['ban']['reason']))
61
-		echo '
62
+	if (isset($context['ban']['reason'])) {
63
+			echo '
62 64
 					<dt>
63 65
 						<strong><label for="reason">', $txt['ban_reason'], ':</label></strong><br>
64 66
 						<span class="smalltext">', $txt['ban_reason_desc'], '</span>
@@ -66,9 +68,10 @@  discard block
 block discarded – undo
66 68
 					<dd>
67 69
 						<textarea name="reason" id="reason" cols="40" rows="3">', $context['ban']['reason'], '</textarea>
68 70
 					</dd>';
71
+	}
69 72
 
70
-	if (isset($context['ban']['notes']))
71
-		echo '
73
+	if (isset($context['ban']['notes'])) {
74
+			echo '
72 75
 					<dt>
73 76
 						<strong><label for="ban_notes">', $txt['ban_notes'], ':</label></strong><br>
74 77
 						<span class="smalltext">', $txt['ban_notes_desc'], '</span>
@@ -76,6 +79,7 @@  discard block
 block discarded – undo
76 79
 					<dd>
77 80
 						<textarea name="notes" id="ban_notes" cols="40" rows="3">', $context['ban']['notes'], '</textarea>
78 81
 					</dd>';
82
+	}
79 83
 
80 84
 	echo '
81 85
 				</dl>
@@ -115,8 +119,8 @@  discard block
 block discarded – undo
115 119
 							<input type="text" name="main_ip" value="', $context['ban_suggestions']['main_ip'], '" size="44" onfocus="document.getElementById(\'main_ip_check\').checked = true;">
116 120
 						</dd>';
117 121
 
118
-		if (empty($modSettings['disableHostnameLookup']))
119
-			echo '
122
+		if (empty($modSettings['disableHostnameLookup'])) {
123
+					echo '
120 124
 						<dt>
121 125
 							<input type="checkbox" name="ban_suggestions[]" id="hostname_check" value="hostname"', !empty($context['ban_suggestions']['hostname']) ? ' checked' : '', '>
122 126
 							<label for="hostname_check">', $txt['ban_on_hostname'], '</label>
@@ -124,6 +128,7 @@  discard block
 block discarded – undo
124 128
 						<dd>
125 129
 							<input type="text" name="hostname" value="', $context['ban_suggestions']['hostname'], '" size="44" onfocus="document.getElementById(\'hostname_check\').checked = true;">
126 130
 						</dd>';
131
+		}
127 132
 
128 133
 		echo '
129 134
 						<dt>
@@ -153,14 +158,15 @@  discard block
 block discarded – undo
153 158
 					<dl class="settings">';
154 159
 
155 160
 					$count = 0;
156
-					foreach ($ban_ips as $ip)
157
-						echo '
161
+					foreach ($ban_ips as $ip) {
162
+											echo '
158 163
 						<dt>
159 164
 							<input type="checkbox" id="suggestions_', $key, '_', $count, '" name="ban_suggestions[', $key, '][]"', !empty($context['ban_suggestions']['saved_triggers'][$key]) && in_array($ip, $context['ban_suggestions']['saved_triggers'][$key]) ? ' checked' : '', ' value="', $ip, '">
160 165
 						</dt>
161 166
 						<dd>
162 167
 							<label for="suggestions_', $key, '_', $count++, '">', $ip, '</label>
163 168
 						</dd>';
169
+					}
164 170
 
165 171
 					echo '
166 172
 					</dl>';
@@ -202,8 +208,8 @@  discard block
 block discarded – undo
202 208
 		addLoadEvent(fUpdateStatus);';
203 209
 
204 210
 	// Auto suggest only needed for adding new bans, not editing
205
-	if ($context['ban']['is_new'] && empty($_REQUEST['u']))
206
-		echo '
211
+	if ($context['ban']['is_new'] && empty($_REQUEST['u'])) {
212
+			echo '
207 213
 		var oAddMemberSuggest = new smc_AutoSuggest({
208 214
 			sSelf: \'oAddMemberSuggest\',
209 215
 			sSessionId: smf_session_id,
@@ -221,6 +227,7 @@  discard block
 block discarded – undo
221 227
 			return true;
222 228
 		}
223 229
 		oAddMemberSuggest.registerCallback(\'onBeforeUpdate\', \'onUpdateName\');';
230
+	}
224 231
 
225 232
 	echo '
226 233
 		function confirmBan(aForm)
@@ -269,8 +276,8 @@  discard block
 block discarded – undo
269 276
 							<input type="text" name="main_ip" value="', $context['ban_trigger']['ip']['value'], '" size="44" onfocus="document.getElementById(\'main_ip_check\').checked = true;">
270 277
 						</dd>';
271 278
 
272
-	if (empty($modSettings['disableHostnameLookup']))
273
-		echo '
279
+	if (empty($modSettings['disableHostnameLookup'])) {
280
+			echo '
274 281
 						<dt>
275 282
 							<input type="checkbox" name="ban_suggestions[]" id="hostname_check" value="hostname"', $context['ban_trigger']['hostname']['selected'] ? ' checked' : '', '>
276 283
 							<label for="hostname_check">', $txt['ban_on_hostname'], '</label>
@@ -278,6 +285,7 @@  discard block
 block discarded – undo
278 285
 						<dd>
279 286
 							<input type="text" name="hostname" value="', $context['ban_trigger']['hostname']['value'], '" size="44" onfocus="document.getElementById(\'hostname_check\').checked = true;">
280 287
 						</dd>';
288
+	}
281 289
 
282 290
 	echo '
283 291
 						<dt>
Please login to merge, or discard this patch.
Themes/default/ManageScheduledTasks.template.php 1 patch
Braces   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -20,13 +20,12 @@  discard block
 block discarded – undo
20 20
 	// We completed some tasks?
21 21
 	if (!empty($context['tasks_were_run']))
22 22
 	{
23
-		if (empty($context['scheduled_errors']))
24
-			echo '
23
+		if (empty($context['scheduled_errors'])) {
24
+					echo '
25 25
 	<div class="infobox">
26 26
 		', $txt['scheduled_tasks_were_run'], '
27 27
 	</div>';
28
-
29
-		else
28
+		} else
30 29
 		{
31 30
 			echo '
32 31
 	<div class="errorbox" id="errors">
@@ -35,14 +34,15 @@  discard block
 block discarded – undo
35 34
 				<strong id="error_serious">', $txt['scheduled_tasks_were_run_errors'], '</strong>
36 35
 			</dt>';
37 36
 
38
-			foreach ($context['scheduled_errors'] as $task => $errors)
39
-				echo '
37
+			foreach ($context['scheduled_errors'] as $task => $errors) {
38
+							echo '
40 39
 			<dd class="error">
41 40
 				<strong>', isset($txt['scheduled_task_' . $task]) ? $txt['scheduled_task_' . $task] : $task, '</strong>
42 41
 				<ul>
43 42
 					<li>', implode('</li><li>', $errors), '</li>
44 43
 				</ul>
45 44
 			</dd>';
45
+			}
46 46
 
47 47
 			echo '
48 48
 		</dl>
Please login to merge, or discard this patch.