Passed
Push — release-2.1 ( 7401ba...5d05c6 )
by Mathias
08:16 queued 14s
created
Sources/Subs-Compat.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@
 block discarded – undo
222 222
 			if (!function_exists('mb_encode_numericentity'))
223 223
 				return false;
224 224
 
225
-			$entity = mb_encode_numericentity($string, array(0x0,0x10FFFF,0x0,0xFFFFFF), $encoding);
225
+			$entity = mb_encode_numericentity($string, array(0x0, 0x10FFFF, 0x0, 0xFFFFFF), $encoding);
226 226
 
227 227
 			if (strpos($entity, '&#') !== 0)
228 228
 				return false;
Please login to merge, or discard this patch.
Sources/ManageMaintenance.php 2 patches
Braces   -1 removed lines patch added patch discarded remove patch
@@ -2214,7 +2214,6 @@
 block discarded – undo
2214 2214
 		$hookData['pureFunc'] = $hookData['method'];
2215 2215
 		$hookData['call'] = $modFunc;
2216 2216
 	}
2217
-
2218 2217
 	else
2219 2218
 		$hookData['call'] = $hookData['pureFunc'] = $modFunc;
2220 2219
 
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2065,7 +2065,7 @@  discard block
 block discarded – undo
2065 2065
 		new RecursiveIteratorIterator(
2066 2066
 			new RecursiveCallbackFilterIterator(
2067 2067
 				new RecursiveDirectoryIterator($dirname, FilesystemIterator::UNIX_PATHS),
2068
-				function ($fileInfo, $currentFile, $iterator)
2068
+				function($fileInfo, $currentFile, $iterator)
2069 2069
 				{
2070 2070
 					// Allow recursion
2071 2071
 					if ($iterator->hasChildren())
@@ -2112,7 +2112,7 @@  discard block
 block discarded – undo
2112 2112
 			$hookParsedData = parse_integration_hook($hook, $rawFunc);
2113 2113
 
2114 2114
 			// Handle hooks pointing outside the sources directory.
2115
-			$absPath_clean =  rtrim($hookParsedData['absPath'], '!');
2115
+			$absPath_clean = rtrim($hookParsedData['absPath'], '!');
2116 2116
 			if ($absPath_clean != '' && !isset($files[$absPath_clean]) && file_exists($absPath_clean))
2117 2117
 				$function_list += get_defined_functions_in_file($absPath_clean);
2118 2118
 
Please login to merge, or discard this patch.
Sources/Mentions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -256,7 +256,7 @@
 block discarded – undo
256 256
 			return array();
257 257
 
258 258
 		// preparse code does a few things which might mess with our parsing
259
-		$body = htmlspecialchars_decode(preg_replace('~<br\s*/?'.'>~', "\n", str_replace('&nbsp;', ' ', $body)), ENT_QUOTES);
259
+		$body = htmlspecialchars_decode(preg_replace('~<br\s*/?' . '>~', "\n", str_replace('&nbsp;', ' ', $body)), ENT_QUOTES);
260 260
 
261 261
 		if (empty(self::$excluded_bbc_regex))
262 262
 			self::setExcludedBbcRegex();
Please login to merge, or discard this patch.
Sources/Subs.php 2 patches
Braces   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -280,7 +280,6 @@  discard block
 block discarded – undo
280 280
 		$condition = 'id_member IN ({array_int:members})';
281 281
 		$parameters['members'] = $members;
282 282
 	}
283
-
284 283
 	elseif ($members === null)
285 284
 		$condition = '1=1';
286 285
 
@@ -383,11 +382,9 @@  discard block
 block discarded – undo
383 382
 				$val = $val . ' END';
384 383
 				$type = 'raw';
385 384
 			}
386
-
387 385
 			else
388 386
 				$val = alert_count($members, true);
389 387
 		}
390
-
391 388
 		elseif ($type == 'int' && ($val === '+' || $val === '-'))
392 389
 		{
393 390
 			$val = $var . ' ' . $val . ' 1';
@@ -2344,12 +2341,12 @@  discard block
 block discarded – undo
2344 2341
 			'tag' => 'cowsay',
2345 2342
 			'parameters' => array(
2346 2343
 				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
2347
-					{
2344
+				{
2348 2345
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
2349 2346
 					},
2350 2347
 				),
2351 2348
 				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
2352
-					{
2349
+				{
2353 2350
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
2354 2351
 					},
2355 2352
 				),
@@ -2711,7 +2708,8 @@  discard block
 block discarded – undo
2711 2708
 
2712 2709
 							foreach (array('path', 'query', 'fragment') as $part)
2713 2710
 							{
2714
-								switch ($part) {
2711
+								switch ($part)
2712
+								{
2715 2713
 									case 'path':
2716 2714
 										$part_disallowed_chars = '\h\v<>' . $bracket_quote_chars . $excluded_trailing_chars . '/#&';
2717 2715
 										$part_excluded_trailing_chars = str_replace('?', '', $excluded_trailing_chars);
@@ -3048,7 +3046,9 @@  discard block
 block discarded – undo
3048 3046
 			$look_for = strtolower(substr($message, $pos + 2, $pos2 - $pos - 2));
3049 3047
 
3050 3048
 			// A closing tag that doesn't match any open tags? Skip it.
3051
-			if (!in_array($look_for, array_map(function($code) { return $code['tag']; }, $open_tags)))
3049
+			if (!in_array($look_for, array_map(function($code)
3050
+			{
3051
+return $code['tag']; }, $open_tags)))
3052 3052
 				continue;
3053 3053
 
3054 3054
 			$to_close = array();
@@ -4588,7 +4588,6 @@  discard block
 block discarded – undo
4588 4588
 				if (!isset($minSeed) && isset($js_file['options']['seed']))
4589 4589
 					$minSeed = $js_file['options']['seed'];
4590 4590
 			}
4591
-
4592 4591
 			else
4593 4592
 			{
4594 4593
 				echo '
@@ -6513,7 +6512,8 @@  discard block
 block discarded – undo
6513 6512
 			$zones[$tzkey]['tzid'] = $tzid;
6514 6513
 			$zones[$tzkey]['dst_type'] = count($tzinfo) > 1 ? 1 : ($tzinfo[0]['isdst'] ? 2 : 0);
6515 6514
 
6516
-			foreach ($tzinfo as $transition) {
6515
+			foreach ($tzinfo as $transition)
6516
+			{
6517 6517
 				$zones[$tzkey]['abbrs'][] = $transition['abbr'];
6518 6518
 			}
6519 6519
 
@@ -7035,7 +7035,6 @@  discard block
 block discarded – undo
7035 7035
 			$isWritable = true;
7036 7036
 			break;
7037 7037
 		}
7038
-
7039 7038
 		else
7040 7039
 			@chmod($file, $val);
7041 7040
 	}
@@ -8125,7 +8124,8 @@  discard block
 block discarded – undo
8125 8124
 	$replaceWith = array();
8126 8125
 
8127 8126
 	if (!empty($matches[1]))
8128
-		foreach ($matches[1] as $token) {
8127
+		foreach ($matches[1] as $token)
8128
+		{
8129 8129
 			$toFind[] = '{' . $token . '}';
8130 8130
 			$replaceWith[] = isset($txt[$token]) ? $txt[$token] : $token;
8131 8131
 		}
Please login to merge, or discard this patch.
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 			{
380 380
 				$val = 'CASE ';
381 381
 				foreach ($members as $k => $v)
382
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. alert_count($v, true) . ' ';
382
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . alert_count($v, true) . ' ';
383 383
 
384 384
 				$val = $val . ' END';
385 385
 				$type = 'raw';
@@ -851,12 +851,12 @@  discard block
 block discarded – undo
851 851
 			// Anything that isn't a specification, punctuation mark, or whitespace.
852 852
 			'~(?<!%)\p{L}|[^\p{L}\p{P}\s]~u',
853 853
 			// Repeated punctuation marks (except %), possibly separated by whitespace.
854
-			'~(?'.'>([^%\P{P}])\s*(?=\1))*~u',
855
-			'~([^%\P{P}])(?'.'>\1(?!$))*~u',
854
+			'~(?' . '>([^%\P{P}])\s*(?=\1))*~u',
855
+			'~([^%\P{P}])(?' . '>\1(?!$))*~u',
856 856
 			// Unwanted trailing punctuation and whitespace.
857
-			'~(?'.'>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
857
+			'~(?' . '>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
858 858
 			// Unwanted opening punctuation and whitespace.
859
-			'~^\s*(?'.'>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
859
+			'~^\s*(?' . '>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
860 860
 			// Runs of horizontal whitespace.
861 861
 			'~\s+~',
862 862
 		),
@@ -1163,7 +1163,7 @@  discard block
 block discarded – undo
1163 1163
 	{
1164 1164
 		$dates[$tzid . '_' . $timestamp]['results'][$format] = preg_replace_callback(
1165 1165
 			'/\xEE\x84\xA0([\d_]+)(\xEE\x84(?:[\xA1-\xAF]))/',
1166
-			function ($matches)
1166
+			function($matches)
1167 1167
 			{
1168 1168
 				switch ($matches[2])
1169 1169
 				{
@@ -1297,7 +1297,7 @@  discard block
 block discarded – undo
1297 1297
 	elseif (!empty($context['character_set']) && is_callable('mb_decode_numericentity'))
1298 1298
 	{
1299 1299
 		// Get whatever the default replacement character is for this encoding.
1300
-		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD,0xFFFD,0,0xFFFF), $context['character_set']);
1300
+		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD, 0xFFFD, 0, 0xFFFF), $context['character_set']);
1301 1301
 	}
1302 1302
 	else
1303 1303
 		$substitute = '?';
@@ -1747,7 +1747,7 @@  discard block
 block discarded – undo
1747 1747
 
1748 1748
 					// parseAttachBBC will return a string ($txt key) rather than dying with a fatal_error. Up to you to decide what to do.
1749 1749
 					if (is_string($currentAttachment))
1750
-						return $data = '<span style="display:inline-block" class="errorbox">' . (!empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment)  . '</span>';
1750
+						return $data = '<span style="display:inline-block" class="errorbox">' . (!empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment) . '</span>';
1751 1751
 
1752 1752
 					// We need a display mode.
1753 1753
 					if (empty($params['{display}']))
@@ -1773,7 +1773,7 @@  discard block
 block discarded – undo
1773 1773
 								$returnContext .= '<img src="' . $currentAttachment['href'] . '"' . $alt . $title . ' class="bbc_img">';
1774 1774
 							else
1775 1775
 							{
1776
-								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"': '';
1776
+								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1777 1777
 								$height = !empty($params['{height}']) ? 'height="' . $params['{height}'] . '"' : '';
1778 1778
 								$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img resized"/>';
1779 1779
 							}
@@ -1784,7 +1784,7 @@  discard block
 block discarded – undo
1784 1784
 							$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
1785 1785
 							$height = !empty($params['{height}']) ? ' height="' . $params['{height}'] . '"' : '';
1786 1786
 
1787
-							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="'. $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1787
+							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="' . $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
1788 1788
 						}
1789 1789
 						// Audio.
1790 1790
 						elseif (strpos($currentAttachment['mime_type'], 'audio/') === 0)
@@ -1792,7 +1792,7 @@  discard block
 block discarded – undo
1792 1792
 							$width = 'max-width:100%; width: ' . (!empty($params['{width}']) ? $params['{width}'] : '400') . 'px;';
1793 1793
 							$height = !empty($params['{height}']) ? 'height: ' . $params['{height}'] . 'px;' : '';
1794 1794
 
1795
-							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="'. $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1795
+							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="' . $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
1796 1796
 						}
1797 1797
 						// Anything else.
1798 1798
 						else
@@ -1961,7 +1961,7 @@  discard block
 block discarded – undo
1961 1961
 				'type' => 'unparsed_commas_content',
1962 1962
 				'test' => '\d+,\d+\]',
1963 1963
 				'content' => '<a href="$1" target="_blank" rel="noopener">$1</a>',
1964
-				'validate' => function (&$tag, &$data, $disabled)
1964
+				'validate' => function(&$tag, &$data, $disabled)
1965 1965
 				{
1966 1966
 					$data[0] = normalize_iri(strtr(trim($data[0]), array('<br>' => '', ' ' => '%20')));
1967 1967
 
@@ -2087,8 +2087,8 @@  discard block
 block discarded – undo
2087 2087
 					else
2088 2088
 						$url = get_proxied_url($url);
2089 2089
 
2090
-					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}']. '"' : ' alt=""';
2091
-					$title = !empty($params['{title}']) ? ' title="' . $params['{title}']. '"' : '';
2090
+					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}'] . '"' : ' alt=""';
2091
+					$title = !empty($params['{title}']) ? ' title="' . $params['{title}'] . '"' : '';
2092 2092
 
2093 2093
 					$data = isset($disabled[$tag['tag']]) ? $url : '<img src="' . $url . '"' . $alt . $title . $params['{width}'] . $params['{height}'] . ' class="bbc_img' . (!empty($params['{width}']) || !empty($params['{height}']) ? ' resized' : '') . '" loading="lazy">';
2094 2094
 				},
@@ -2526,12 +2526,12 @@  discard block
 block discarded – undo
2526 2526
 		$codes[] = array(
2527 2527
 			'tag' => 'cowsay',
2528 2528
 			'parameters' => array(
2529
-				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
2529
+				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function($eyes) use ($smcFunc)
2530 2530
 					{
2531 2531
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
2532 2532
 					},
2533 2533
 				),
2534
-				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
2534
+				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function($tongue) use ($smcFunc)
2535 2535
 					{
2536 2536
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
2537 2537
 					},
@@ -4236,7 +4236,7 @@  discard block
 block discarded – undo
4236 4236
 		if ($fp != false)
4237 4237
 		{
4238 4238
 			// Send the HEAD request (since we don't have to worry about chunked, HTTP/1.1 is fine here.)
4239
-			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: '. SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4239
+			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: ' . SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
4240 4240
 
4241 4241
 			// Read in the HTTP/1.1 or whatever.
4242 4242
 			$test = substr(fgets($fp, 11), -1);
@@ -4832,7 +4832,7 @@  discard block
 block discarded – undo
4832 4832
 
4833 4833
 	uasort(
4834 4834
 		$context['css_files'],
4835
-		function ($a, $b)
4835
+		function($a, $b)
4836 4836
 		{
4837 4837
 			return $a['options']['order_pos'] < $b['options']['order_pos'] ? -1 : ($a['options']['order_pos'] > $b['options']['order_pos'] ? 1 : 0);
4838 4838
 		}
@@ -6166,7 +6166,7 @@  discard block
 block discarded – undo
6166 6166
 			{
6167 6167
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
6168 6168
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6169
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6169
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6170 6170
 				if ($keep_alive)
6171 6171
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
6172 6172
 				else
@@ -6176,7 +6176,7 @@  discard block
 block discarded – undo
6176 6176
 			{
6177 6177
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
6178 6178
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
6179
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
6179
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
6180 6180
 				if ($keep_alive)
6181 6181
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
6182 6182
 				else
@@ -6425,13 +6425,13 @@  discard block
 block discarded – undo
6425 6425
 
6426 6426
 	// UTF-8 occurrences of MS special characters
6427 6427
 	$findchars_utf8 = array(
6428
-		"\xe2\x80\x9a",	// single low-9 quotation mark
6429
-		"\xe2\x80\x9e",	// double low-9 quotation mark
6430
-		"\xe2\x80\xa6",	// horizontal ellipsis
6431
-		"\xe2\x80\x98",	// left single curly quote
6432
-		"\xe2\x80\x99",	// right single curly quote
6433
-		"\xe2\x80\x9c",	// left double curly quote
6434
-		"\xe2\x80\x9d",	// right double curly quote
6428
+		"\xe2\x80\x9a", // single low-9 quotation mark
6429
+		"\xe2\x80\x9e", // double low-9 quotation mark
6430
+		"\xe2\x80\xa6", // horizontal ellipsis
6431
+		"\xe2\x80\x98", // left single curly quote
6432
+		"\xe2\x80\x99", // right single curly quote
6433
+		"\xe2\x80\x9c", // left double curly quote
6434
+		"\xe2\x80\x9d", // right double curly quote
6435 6435
 	);
6436 6436
 
6437 6437
 	// windows 1252 / iso equivalents
@@ -6447,13 +6447,13 @@  discard block
 block discarded – undo
6447 6447
 
6448 6448
 	// safe replacements
6449 6449
 	$replacechars = array(
6450
-		',',	// &sbquo;
6451
-		',,',	// &bdquo;
6452
-		'...',	// &hellip;
6453
-		"'",	// &lsquo;
6454
-		"'",	// &rsquo;
6455
-		'"',	// &ldquo;
6456
-		'"',	// &rdquo;
6450
+		',', // &sbquo;
6451
+		',,', // &bdquo;
6452
+		'...', // &hellip;
6453
+		"'", // &lsquo;
6454
+		"'", // &rsquo;
6455
+		'"', // &ldquo;
6456
+		'"', // &rdquo;
6457 6457
 	);
6458 6458
 
6459 6459
 	if ($context['utf8'])
@@ -6816,7 +6816,7 @@  discard block
 block discarded – undo
6816 6816
 		// We don't want abbreviations like '+03' or '-11'.
6817 6817
 		$abbrs = array_filter(
6818 6818
 			$tzvalue['abbrs'],
6819
-			function ($abbr)
6819
+			function($abbr)
6820 6820
 			{
6821 6821
 				return !strspn($abbr, '+-');
6822 6822
 			}
@@ -7805,7 +7805,7 @@  discard block
 block discarded – undo
7805 7805
 			EXISTS (
7806 7806
 				SELECT bpv.id_board
7807 7807
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7808
-				WHERE bpv.id_group IN ('. implode(',', $groups) .')
7808
+				WHERE bpv.id_group IN ('. implode(',', $groups) . ')
7809 7809
 					AND bpv.deny = 0
7810 7810
 					AND bpv.id_board = b.id_board
7811 7811
 			)';
@@ -7815,7 +7815,7 @@  discard block
 block discarded – undo
7815 7815
 			AND NOT EXISTS (
7816 7816
 				SELECT bpv.id_board
7817 7817
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
7818
-				WHERE bpv.id_group IN ( '. implode(',', $groups) .')
7818
+				WHERE bpv.id_group IN ( '. implode(',', $groups) . ')
7819 7819
 					AND bpv.deny = 1
7820 7820
 					AND bpv.id_board = b.id_board
7821 7821
 			)';
@@ -8228,8 +8228,8 @@  discard block
 block discarded – undo
8228 8228
 	$i = 0;
8229 8229
 	while (empty($done))
8230 8230
 	{
8231
-		if (strpos($format, '{'. --$i . '}') !== false)
8232
-			$replacements['{'. $i . '}'] = array_pop($list);
8231
+		if (strpos($format, '{' . --$i . '}') !== false)
8232
+			$replacements['{' . $i . '}'] = array_pop($list);
8233 8233
 		else
8234 8234
 			$done = true;
8235 8235
 	}
@@ -8239,8 +8239,8 @@  discard block
 block discarded – undo
8239 8239
 	$i = 0;
8240 8240
 	while (empty($done))
8241 8241
 	{
8242
-		if (strpos($format, '{'. ++$i . '}') !== false)
8243
-			$replacements['{'. $i . '}'] = array_shift($list);
8242
+		if (strpos($format, '{' . ++$i . '}') !== false)
8243
+			$replacements['{' . $i . '}'] = array_shift($list);
8244 8244
 		else
8245 8245
 			$done = true;
8246 8246
 	}
@@ -8421,7 +8421,7 @@  discard block
 block discarded – undo
8421 8421
 	if (empty($stringSubject))
8422 8422
 		return '';
8423 8423
 
8424
-	$translatable_tokens = preg_match_all('/{(.*?)}/' , $stringSubject, $matches);
8424
+	$translatable_tokens = preg_match_all('/{(.*?)}/', $stringSubject, $matches);
8425 8425
 	$toFind = array();
8426 8426
 	$replaceWith = array();
8427 8427
 
Please login to merge, or discard this patch.
Sources/Search.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1107,7 +1107,7 @@
 block discarded – undo
1107 1107
 						'left_join' => array(),
1108 1108
 						'where' => array(
1109 1109
 							't.id_redirect_topic = {int:not_redirected}',
1110
-						    't.redirect_expires = {int:never_expires}',
1110
+							't.redirect_expires = {int:never_expires}',
1111 1111
 						),
1112 1112
 					);
1113 1113
 
Please login to merge, or discard this patch.
Sources/Profile-Modify.php 1 patch
Braces   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -156,7 +156,6 @@  discard block
 block discarded – undo
156 156
 					$diff = $cur_profile['date_registered'] - strtotime(smf_strftime('%Y-%m-%d', $cur_profile['date_registered']));
157 157
 					$value = $value + $diff;
158 158
 				}
159
-
160 159
 				else
161 160
 					$value = $cur_profile['date_registered'];
162 161
 
@@ -507,7 +506,7 @@  discard block
 block discarded – undo
507 506
 						log_error(sprintf($txt['smiley_set_dir_not_found'], $set_names[array_search($set, $context['smiley_sets'])]));
508 507
 
509 508
 						$context['smiley_sets'] = array_filter($context['smiley_sets'], function($v) use ($set)
510
-							{
509
+						{
511 510
 								return $v != $set;
512 511
 							});
513 512
 					}
@@ -3518,7 +3517,6 @@  discard block
 block discarded – undo
3518 3517
 			}
3519 3518
 		}
3520 3519
 	}
3521
-
3522 3520
 	elseif (($value == 'upload' && allowedTo('profile_upload_avatar')) || $downloadedExternalAvatar)
3523 3521
 	{
3524 3522
 		if ((isset($_FILES['attachment']['name']) && $_FILES['attachment']['name'] != '') || $downloadedExternalAvatar)
Please login to merge, or discard this patch.
other/install.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
 				return false;
93 93
 		},
94 94
 		'utf8_version' => '8.0',
95
-		'utf8_version_check' => function (){
95
+		'utf8_version_check' => function() {
96 96
 			global $db_connection;
97 97
 			$request = pg_query($db_connection, 'SELECT version()');
98 98
 			list ($version) = pg_fetch_row($request);
@@ -987,7 +987,7 @@  discard block
 block discarded – undo
987 987
 	$incontext['continue'] = 1;
988 988
 
989 989
 	// Check Postgres setting
990
-	if ( $db_type === 'postgresql')
990
+	if ($db_type === 'postgresql')
991 991
 	{
992 992
 		load_database();
993 993
 		$result = $smcFunc['db_query']('', '
Please login to merge, or discard this patch.
Braces   +9 added lines, -5 removed lines patch added patch discarded remove patch
@@ -40,7 +40,8 @@  discard block
 block discarded – undo
40 40
 	'mysql' => array(
41 41
 		'name' => 'MySQL',
42 42
 		'version' => '5.6.0',
43
-		'version_check' => function() {
43
+		'version_check' => function()
44
+		{
44 45
 			global $db_connection;
45 46
 			if (!function_exists('mysqli_fetch_row'))
46 47
 				return false;
@@ -56,7 +57,8 @@  discard block
 block discarded – undo
56 57
 			return true;
57 58
 		},
58 59
 		'utf8_version' => '5.0.22',
59
-		'utf8_version_check' => function() {
60
+		'utf8_version_check' => function()
61
+		{
60 62
 			global $db_connection;
61 63
 			return mysqli_get_server_info($db_connection);
62 64
 		},
@@ -70,7 +72,8 @@  discard block
 block discarded – undo
70 72
 	'postgresql' => array(
71 73
 		'name' => 'PostgreSQL',
72 74
 		'version' => '9.6',
73
-		'version_check' => function() {
75
+		'version_check' => function()
76
+		{
74 77
 			global $db_connection;
75 78
 			$request = pg_query($db_connection, 'SELECT version()');
76 79
 			list ($version) = pg_fetch_row($request);
@@ -92,7 +95,8 @@  discard block
 block discarded – undo
92 95
 				return false;
93 96
 		},
94 97
 		'utf8_version' => '8.0',
95
-		'utf8_version_check' => function (){
98
+		'utf8_version_check' => function ()
99
+		{
96 100
 			global $db_connection;
97 101
 			$request = pg_query($db_connection, 'SELECT version()');
98 102
 			list ($version) = pg_fetch_row($request);
@@ -1001,7 +1005,7 @@  discard block
 block discarded – undo
1001 1005
 		{
1002 1006
 			$row = $smcFunc['db_fetch_assoc']($result);
1003 1007
 			if ($row['standard_conforming_strings'] !== 'on')
1004
-				{
1008
+			{
1005 1009
 					$incontext['continue'] = 0;
1006 1010
 					$incontext['error'] = $txt['error_pg_scs'];
1007 1011
 				}
Please login to merge, or discard this patch.
Sources/Load.php 2 patches
Spacing   +6 added lines, -9 removed lines patch added patch discarded remove patch
@@ -853,7 +853,7 @@  discard block
 block discarded – undo
853 853
 			'filename' => empty($user_settings['filename']) ? '' : $user_settings['filename'],
854 854
 			'custom_dir' => !empty($user_settings['attachment_type']) && $user_settings['attachment_type'] == 1,
855 855
 			'id_attach' => isset($user_settings['id_attach']) ? $user_settings['id_attach'] : 0,
856
-			'width' => isset($user_settings['attachment_width']) > 0 ? $user_settings['attachment_width']: 0,
856
+			'width' => isset($user_settings['attachment_width']) > 0 ? $user_settings['attachment_width'] : 0,
857 857
 			'height' => isset($user_settings['attachment_height']) > 0 ? $user_settings['attachment_height'] : 0,
858 858
 		),
859 859
 		'smiley_set' => isset($user_settings['smiley_set']) ? $user_settings['smiley_set'] : '',
@@ -2539,7 +2539,7 @@  discard block
 block discarded – undo
2539 2539
 	);
2540 2540
 
2541 2541
 	// Add the JQuery library to the list of files to load.
2542
-	$jQueryUrls = array ('cdn' => 'https://ajax.googleapis.com/ajax/libs/jquery/'. JQUERY_VERSION . '/jquery.min.js', 'jquery_cdn' => 'https://code.jquery.com/jquery-'. JQUERY_VERSION . '.min.js', 'microsoft_cdn' => 'https://ajax.aspnetcdn.com/ajax/jQuery/jquery-'. JQUERY_VERSION . '.min.js');
2542
+	$jQueryUrls = array('cdn' => 'https://ajax.googleapis.com/ajax/libs/jquery/' . JQUERY_VERSION . '/jquery.min.js', 'jquery_cdn' => 'https://code.jquery.com/jquery-' . JQUERY_VERSION . '.min.js', 'microsoft_cdn' => 'https://ajax.aspnetcdn.com/ajax/jQuery/jquery-' . JQUERY_VERSION . '.min.js');
2543 2543
 
2544 2544
 	if (isset($modSettings['jquery_source']) && array_key_exists($modSettings['jquery_source'], $jQueryUrls))
2545 2545
 		loadJavaScriptFile($jQueryUrls[$modSettings['jquery_source']], array('external' => true, 'seed' => false), 'smf_jquery');
@@ -2780,8 +2780,7 @@  discard block
 block discarded – undo
2780 2780
 		$context['css_files_order'] = array();
2781 2781
 
2782 2782
 	$params['seed'] = (!array_key_exists('seed', $params) || (array_key_exists('seed', $params) && $params['seed'] === true)) ?
2783
-		(array_key_exists('browser_cache', $context) ? $context['browser_cache'] : '') :
2784
-		(is_string($params['seed']) ? '?' . ltrim($params['seed'], '?') : '');
2783
+		(array_key_exists('browser_cache', $context) ? $context['browser_cache'] : '') : (is_string($params['seed']) ? '?' . ltrim($params['seed'], '?') : '');
2785 2784
 	$params['force_current'] = isset($params['force_current']) ? $params['force_current'] : false;
2786 2785
 	$themeRef = !empty($params['default_theme']) ? 'default_theme' : 'theme';
2787 2786
 	$params['minimize'] = isset($params['minimize']) ? $params['minimize'] : true;
@@ -2896,8 +2895,7 @@  discard block
 block discarded – undo
2896 2895
 	global $settings, $context, $modSettings;
2897 2896
 
2898 2897
 	$params['seed'] = (!array_key_exists('seed', $params) || (array_key_exists('seed', $params) && $params['seed'] === true)) ?
2899
-		(array_key_exists('browser_cache', $context) ? $context['browser_cache'] : '') :
2900
-		(is_string($params['seed']) ? '?' . ltrim($params['seed'], '?') : '');
2898
+		(array_key_exists('browser_cache', $context) ? $context['browser_cache'] : '') : (is_string($params['seed']) ? '?' . ltrim($params['seed'], '?') : '');
2901 2899
 	$params['force_current'] = isset($params['force_current']) ? $params['force_current'] : false;
2902 2900
 	$themeRef = !empty($params['default_theme']) ? 'default_theme' : 'theme';
2903 2901
 	$params['async'] = isset($params['async']) ? $params['async'] : false;
@@ -3687,8 +3685,7 @@  discard block
 block discarded – undo
3687 3685
 
3688 3686
 	// What accelerator we are going to try.
3689 3687
 	$cache_class_name = !empty($cache_accelerator) ? $cache_accelerator : CacheApi::APIS_DEFAULT;
3690
-	$fully_qualified_class_name = !empty($overrideCache) ? $overrideCache :
3691
-		CacheApi::APIS_NAMESPACE . $cache_class_name;
3688
+	$fully_qualified_class_name = !empty($overrideCache) ? $overrideCache : CacheApi::APIS_NAMESPACE . $cache_class_name;
3692 3689
 
3693 3690
 	// Do some basic tests.
3694 3691
 	if (class_exists($fully_qualified_class_name))
@@ -3992,7 +3989,7 @@  discard block
 block discarded – undo
3992 3989
 			$auth_secret = hash_file('sha256', $boarddir . '/Settings.php');
3993 3990
 
3994 3991
 			// Set the last error to now, but only every 15 minutes.  Don't need to flood the logs.
3995
-			if (empty($db_last_error) || ($db_last_error + 60*15) <= time())
3992
+			if (empty($db_last_error) || ($db_last_error + 60 * 15) <= time())
3996 3993
 			{
3997 3994
 				updateDbLastError(time());
3998 3995
 				loadLanguage('Errors');
Please login to merge, or discard this patch.
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 	// Set a list of common functions.
108 108
 	$ent_list = '&(?:#' . (empty($modSettings['disableEntityCheck']) ? '\d{1,7}' : '021') . '|quot|amp|lt|gt|nbsp);';
109 109
 	$ent_check = empty($modSettings['disableEntityCheck']) ? function($string)
110
-		{
110
+	{
111 111
 			$string = preg_replace_callback('~(&#(\d{1,7}|x[0-9a-fA-F]{1,6});)~', 'entity_fix__callback', (string) $string);
112 112
 			return $string;
113 113
 		} : function($string)
@@ -2422,7 +2422,6 @@  discard block
 block discarded – undo
2422 2422
 		loadLanguage('index+Modifications');
2423 2423
 		$context['template_layers'] = array();
2424 2424
 	}
2425
-
2426 2425
 	else
2427 2426
 	{
2428 2427
 		// Custom templates to load, or just default?
@@ -2976,7 +2975,8 @@  discard block
 block discarded – undo
2976 2975
 	// Take care of escaping the value for JavaScript?
2977 2976
 	if (!empty($escape))
2978 2977
 	{
2979
-		switch (gettype($value)) {
2978
+		switch (gettype($value))
2979
+		{
2980 2980
 			// Illegal.
2981 2981
 			case 'resource':
2982 2982
 				break;
Please login to merge, or discard this patch.
Sources/Subs-Auth.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -871,7 +871,7 @@
 block discarded – undo
871 871
 	// Intercept cookie?
872 872
 	call_integration_hook('integrate_cookie', array($name, $value, $expire, $path, $domain, $secure, $httponly, $samesite));
873 873
 
874
-	if(PHP_VERSION_ID < 70300)
874
+	if (PHP_VERSION_ID < 70300)
875 875
 		return setcookie($name, $value, $expire, $path . ';samesite=' . $samesite, $domain, $secure, $httponly);
876 876
 	else
877 877
 		return setcookie($name, $value, array(
Please login to merge, or discard this patch.