albertlast / SMF2.1

Sources/Subs-Boards.php

Spacing +6 added lines, -6 removed lines

@@ -660,7 +660,7 @@ 
 	if (!empty($boardUpdateParameters['deny_groups']))
 	{
 		$insert = array();
-		foreach($boardOptions['deny_groups'] as $value)
+		foreach ($boardOptions['deny_groups'] as $value)
 			$insert[] = array($value, $board_id, 1);
 
 		$smcFunc['db_query']('', '
@@ -674,14 +674,14 @@ 
 				'{db_prefix}board_permissions_view',
 				array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'),
 				$insert,
-				array('id_group','id_board','deny')
+				array('id_group', 'id_board', 'deny')
 				);
 	}
 
 	if (!empty($boardUpdateParameters['member_groups']))
 	{
 		$insert = array();
-		foreach($boardOptions['access_groups'] as $value)
+		foreach ($boardOptions['access_groups'] as $value)
 			$insert[] = array($value, $board_id, 0);
 		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}board_permissions_view
@@ -694,7 +694,7 @@ 
 				'{db_prefix}board_permissions_view',
 				array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'),
 				$insert,
-				array('id_group','id_board','deny')
+				array('id_group', 'id_board', 'deny')
 				);
 	}
 
@@ -901,14 +901,14 @@ 
 
 	$insert = array();
 
-	foreach(explode(',', $default_memgrps) as $value)
+	foreach (explode(',', $default_memgrps) as $value)
 			$insert[] = array($value, $board_id, 0);
 
 	$smcFunc['db_insert']('',
 		'{db_prefix}board_permissions_view',
 		array('id_group' => 'int', 'id_board' => 'int', 'deny' => 'int'),
 		$insert,
-		array('id_group','id_board','deny'),
+		array('id_group', 'id_board', 'deny'),
 		1
 	);
 

Sources/ManagePaid.php

Spacing +1 added lines, -1 removed lines

@@ -1129,7 +1129,7 @@
 					'{db_prefix}log_subscribed',
 					array(
 						'id_subscribe' => 'int', 'id_member' => 'int', 'old_id_group' => 'int', 'start_time' => 'int',
-						'end_time' => 'int', 'status' => 'int','pending_details' => 'string-65534'
+						'end_time' => 'int', 'status' => 'int', 'pending_details' => 'string-65534'
 					),
 					array(
 						$context['sub_id'], $id_member, $id_group, $starttime,

Sources/Subs-Membergroups.php

Braces -1 removed lines

@@ -756,7 +756,6 @@
 				$groups[$row['id_group']]['num_members'] += $row['num_members'];
 			$smcFunc['db_free_result']($query);
 		}
-
 		else
 		{
 			$query = $smcFunc['db_query']('', '

Sources/Class-SearchAPI.php

Spacing +4 added lines, -4 removed lines

@@ -223,7 +223,7 @@ 
 
 		global $smcFunc;
 
-		$result = $smcFunc['db_query']('','
+		$result = $smcFunc['db_query']('', '
 			SELECT DISTINCT id_search
 			FROM {db_prefix}log_search_results
 			WHERE id_msg = {int:id_msg}',
@@ -239,7 +239,7 @@ 
 		if (count($id_searchs) < 1)
 			return;
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_results
 			WHERE id_search in ({array_int:id_searchs})',
 			array(
@@ -247,7 +247,7 @@ 
 			)
 		);
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_topics
 			WHERE id_search in ({array_int:id_searchs})',
 			array(
@@ -255,7 +255,7 @@ 
 			)
 		);
 
-		$smcFunc['db_query']('','
+		$smcFunc['db_query']('', '
 			DELETE FROM {db_prefix}log_search_messages
 			WHERE id_search in ({array_int:id_searchs})',
 			array(

Sources/Errors.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 		$backtrace = debug_backtrace();
 
 	// are we in a loop?
-	if($error_call > 2)
+	if ($error_call > 2)
 	{
 		var_dump($backtrace);
 		die('Error loop.');
@@ -549,7 +549,7 @@ 
 		$url['error'] = $error;
 		// Url field got a max length of 1024 in db
 		if (strlen($url['error']) > 500)
-			$url['error'] = substr($url['error'],0,500);
+			$url['error'] = substr($url['error'], 0, 500);
 
 		if (!empty($sprintf))
 			$url['error_params'] = $sprintf;

Sources/SearchAPI-Fulltext.php

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
 	/**
 	 * @var array Which databases support this method?
 	 */
-	protected $supported_databases = array('mysql','postgresql');
+	protected $supported_databases = array('mysql', 'postgresql');
 
 	/**
 	 * The constructor function
@@ -176,7 +176,7 @@ 
 		$query_where = array();
 		$query_params = $search_data['params'];
 
-		if( $smcFunc['db_title'] == "PostgreSQL")
+		if ($smcFunc['db_title'] == "PostgreSQL")
 			$modSettings['search_simple_fulltext'] = true;
 
 		if ($query_params['id_search'])
@@ -256,7 +256,7 @@ 
 			// if we have bool terms to search, add them in
 			if ($query_params['boolean_match'])
 			{
-				if($smcFunc['db_title'] == "PostgreSQL")
+				if ($smcFunc['db_title'] == "PostgreSQL")
 				{
 					$language_ftx = $smcFunc['db_search_language']();
 
@@ -268,7 +268,7 @@ 
 			}
 		}
 
-		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ( '
+		$ignoreRequest = $smcFunc['db_search_query']('insert_into_log_messages_fulltext', ($smcFunc['db_support_ignore'] ? ('
 			INSERT IGNORE INTO {db_prefix}' . $search_data['insert_into'] . '
 				(' . implode(', ', array_keys($query_select)) . ')') : '') . '
 			SELECT ' . implode(', ', $query_select) . '

Sources/tasks/CreatePost-Notify.php

Indentation +4 added lines, -4 removed lines

@@ -19,13 +19,13 @@ 
 {
 	/**
 	 * Constants for receiving email notfications.
-	*/
+	 */
 	const RECEIVE_NOTIFY_EMAIL = 0x02;
 	const RECEIVE_NOTIFY_ALERT = 0x01;
 
 	/**
 	 * Constants for reply types.
-	*/
+	 */
 	const NOTIFY_TYPE_REPLY_AND_MODIFY = 1;
 	const NOTIFY_TYPE_REPLY_AND_TOPIC_START_FOLLOWING = 2;
 	const NOTIFY_TYPE_ONLY_REPLIES = 3;
@@ -33,7 +33,7 @@ 
 
 	/**
 	 * Constants for frequencies.
-	*/
+	 */
 	const FREQUENCY_NOTHING = 0;
 	const FREQUENCY_EVERYTHING = 1;
 	const FREQUENCY_FIRST_UNREAD_MSG = 2;
@@ -41,7 +41,7 @@ 
 	const FREQUENCY_WEEKLY_DIGEST = 4;
 
 	/**
-     * This handles notifications when a new post is created - new topic, reply, quotes and mentions.
+	 * This handles notifications when a new post is created - new topic, reply, quotes and mentions.
 	 * @return bool Always returns true
 	 */
 	public function execute()

Sources/Class-TOTP.php

Braces +24 added lines, -12 removed lines

@@ -64,7 +64,8 @@ 
 	{
 		$this->buildLookup();
 
-		if ($initKey !== null) {
+		if ($initKey !== null)
+		{
 			$this->setInitKey($initKey);
 		}
 	}
@@ -98,7 +99,8 @@ 
 	 */
 	public function setRange($range)
 	{
-		if (!is_numeric($range)) {
+		if (!is_numeric($range))
+		{
 			throw new \InvalidArgumentException('Invalid window range');
 		}
 		$this->range = $range;
@@ -114,7 +116,8 @@ 
 	 */
 	public function setInitKey($key)
 	{
-		if (preg_match('/^[' . implode('', array_keys($this->getLookup())) . ']+$/', $key) == false) {
+		if (preg_match('/^[' . implode('', array_keys($this->getLookup())) . ']+$/', $key) == false)
+		{
 			throw new \InvalidArgumentException('Invalid base32 hash!');
 		}
 		$this->initKey = $key;
@@ -140,7 +143,8 @@ 
 	 */
 	public function setLookup($lookup)
 	{
-		if (!is_array($lookup)) {
+		if (!is_array($lookup))
+		{
 			throw new \InvalidArgumentException('Lookup value must be an array');
 		}
 		$this->lookup = $lookup;
@@ -176,7 +180,8 @@ 
 	 */
 	public function setRefresh($seconds)
 	{
-		if (!is_numeric($seconds)) {
+		if (!is_numeric($seconds))
+		{
 			throw new \InvalidArgumentException('Seconds must be numeric');
 		}
 		$this->refreshSeconds = $seconds;
@@ -217,7 +222,8 @@ 
 	 */
 	public function validateCode($code, $initKey = null, $timestamp = null, $range = null)
 	{
-		if (strlen($code) !== $this->getCodeLength()) {
+		if (strlen($code) !== $this->getCodeLength())
+		{
 			throw new \InvalidArgumentException('Incorrect code length');
 		}
 
@@ -227,8 +233,10 @@ 
 
 		$binary = $this->base32_decode($initKey);
 
-		for ($time = ($timestamp - $range); $time <= ($timestamp + $range); $time++) {
-			if ($this->generateOneTime($binary, $time) == $code) {
+		for ($time = ($timestamp - $range); $time <= ($timestamp + $range); $time++)
+		{
+			if ($this->generateOneTime($binary, $time) == $code)
+			{
 				return true;
 			}
 		}
@@ -271,7 +279,8 @@ 
 		$lookup = implode('', array_keys($this->getLookup()));
 		$code = '';
 
-		for ($i = 0; $i < $length; $i++) {
+		for ($i = 0; $i < $length; $i++)
+		{
 			$code .= $lookup[$smcFunc['random_int'](0, strlen($lookup) - 1)];
 		}
 
@@ -317,7 +326,8 @@ 
 	{
 		$lookup = $this->getLookup();
 
-		if (preg_match('/^[' . implode('', array_keys($lookup)) . ']+$/', $hash) == false) {
+		if (preg_match('/^[' . implode('', array_keys($lookup)) . ']+$/', $hash) == false)
+		{
 			throw new \InvalidArgumentException('Invalid base32 hash!');
 		}
 
@@ -326,12 +336,14 @@ 
 		$length = 0;
 		$binary = '';
 
-		for ($i = 0; $i < strlen($hash); $i++) {
+		for ($i = 0; $i < strlen($hash); $i++)
+		{
 			$buffer = $buffer << 5;
 			$buffer += $lookup[$hash[$i]];
 			$length += 5;
 
-			if ($length >= 8) {
+			if ($length >= 8)
+			{
 				$length -= 8;
 				$binary .= chr(($buffer & (0xFF << $length)) >> $length);
 			}

Sources/SplitTopics.php

Braces +2 added lines, -1 removed lines

@@ -1076,7 +1076,8 @@
 		{
 			unset($topics[$row['id_topic']]); // If we can't see it, we should not merge it and not adjust counts! Instead skip it.
 			continue;
-		}elseif (!$row['approved'])
+		}
+		elseif (!$row['approved'])
 			$boardTotals[$row['id_board']]['unapproved_topics']++;
 		else
 			$boardTotals[$row['id_board']]['topics']++;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1339,7 +1339,7 @@
 	list ($member_started) = $smcFunc['db_fetch_row']($request);
 	list ($member_updated) = $smcFunc['db_fetch_row']($request);
 	// First and last message are the same, so only row was returned.
-	if ($member_updated === NULL)
+	if ($member_updated === null)
 		$member_updated = $member_started;
 
 	$smcFunc['db_free_result']($request);