@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -12,7 +12,8 @@ |
||
12 | 12 | header('Location: ' . $boardurl); |
13 | 13 | } |
14 | 14 | // Can't find it... just forget it. |
15 | -else |
|
15 | +else { |
|
16 | 16 | exit; |
17 | +} |
|
17 | 18 | |
18 | 19 | ?> |
19 | 20 | \ No newline at end of file |
@@ -1,9 +1,10 @@ |
||
1 | 1 | <?php |
2 | 2 | |
3 | 3 | // Try to handle it with the upper level index.php. (it should know what to do.) |
4 | -if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) |
|
4 | +if (file_exists(dirname(dirname(__FILE__)) . '/index.php')) { |
|
5 | 5 | include (dirname(dirname(__FILE__)) . '/index.php'); |
6 | -else |
|
6 | +} else { |
|
7 | 7 | exit; |
8 | +} |
|
8 | 9 | |
9 | 10 | ?> |
10 | 11 | \ No newline at end of file |
@@ -15,8 +15,9 @@ discard block |
||
15 | 15 | * @version 2.1 Beta 3 |
16 | 16 | */ |
17 | 17 | |
18 | -if (!defined('SMF')) |
|
18 | +if (!defined('SMF')) { |
|
19 | 19 | die('No direct access...'); |
20 | +} |
|
20 | 21 | |
21 | 22 | /** |
22 | 23 | * Main dispatcher. This function checks permissions and passes control through to the relevant section. |
@@ -245,8 +246,9 @@ discard block |
||
245 | 246 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
246 | 247 | { |
247 | 248 | // Private PM/email subjects and similar shouldn't be shown in the mailbox area. |
248 | - if (!empty($row['private'])) |
|
249 | - $row['subject'] = $txt['personal_message']; |
|
249 | + if (!empty($row['private'])) { |
|
250 | + $row['subject'] = $txt['personal_message']; |
|
251 | + } |
|
250 | 252 | |
251 | 253 | $mails[] = $row; |
252 | 254 | } |
@@ -300,8 +302,9 @@ discard block |
||
300 | 302 | $element = substr($key, strrpos($key, '_') + 1); |
301 | 303 | $processedBirthdayEmails[$index][$element] = $value; |
302 | 304 | } |
303 | - foreach ($processedBirthdayEmails as $index => $dummy) |
|
304 | - $emails[$index] = $index; |
|
305 | + foreach ($processedBirthdayEmails as $index => $dummy) { |
|
306 | + $emails[$index] = $index; |
|
307 | + } |
|
305 | 308 | |
306 | 309 | $config_vars = array( |
307 | 310 | // Mail queue stuff, this rocks ;) |
@@ -322,8 +325,9 @@ discard block |
||
322 | 325 | |
323 | 326 | call_integration_hook('integrate_modify_mail_settings', array(&$config_vars)); |
324 | 327 | |
325 | - if ($return_config) |
|
326 | - return $config_vars; |
|
328 | + if ($return_config) { |
|
329 | + return $config_vars; |
|
330 | + } |
|
327 | 331 | |
328 | 332 | // Saving? |
329 | 333 | if (isset($_GET['save'])) |
@@ -398,9 +402,9 @@ discard block |
||
398 | 402 | ); |
399 | 403 | list ($_GET['te']) = $smcFunc['db_fetch_row']($request); |
400 | 404 | $smcFunc['db_free_result']($request); |
405 | + } else { |
|
406 | + $_GET['te'] = (int) $_GET['te']; |
|
401 | 407 | } |
402 | - else |
|
403 | - $_GET['te'] = (int) $_GET['te']; |
|
404 | 408 | |
405 | 409 | $_GET['sent'] = isset($_GET['sent']) ? (int) $_GET['sent'] : 0; |
406 | 410 | |
@@ -424,12 +428,14 @@ discard block |
||
424 | 428 | |
425 | 429 | // Try get more time... |
426 | 430 | @set_time_limit(600); |
427 | - if (function_exists('apache_reset_timeout')) |
|
428 | - @apache_reset_timeout(); |
|
431 | + if (function_exists('apache_reset_timeout')) { |
|
432 | + @apache_reset_timeout(); |
|
433 | + } |
|
429 | 434 | |
430 | 435 | // Have we already used our maximum time? |
431 | - if (time() - array_sum(explode(' ', $time_start)) < 5) |
|
432 | - return; |
|
436 | + if (time() - array_sum(explode(' ', $time_start)) < 5) { |
|
437 | + return; |
|
438 | + } |
|
433 | 439 | |
434 | 440 | $context['continue_get_data'] = '?action=admin;area=mailqueue;sa=clear;te=' . $_GET['te'] . ';sent=' . $_GET['sent'] . ';' . $context['session_var'] . '=' . $context['session_id']; |
435 | 441 | $context['page_title'] = $txt['not_done_title']; |
@@ -459,8 +465,9 @@ discard block |
||
459 | 465 | { |
460 | 466 | global $txt; |
461 | 467 | |
462 | - if ($time_diff < 0) |
|
463 | - $time_diff = 0; |
|
468 | + if ($time_diff < 0) { |
|
469 | + $time_diff = 0; |
|
470 | + } |
|
464 | 471 | |
465 | 472 | // Just do a bit of an if fest... |
466 | 473 | if ($time_diff > 86400) |
@@ -481,8 +488,9 @@ discard block |
||
481 | 488 | return sprintf($minutes == 1 ? $txt['mq_minute'] : $txt['mq_minutes'], $minutes); |
482 | 489 | } |
483 | 490 | // Otherwise must be second |
484 | - else |
|
485 | - return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
486 | -} |
|
491 | + else { |
|
492 | + return sprintf($time_diff == 1 ? $txt['mq_second'] : $txt['mq_seconds'], $time_diff); |
|
493 | + } |
|
494 | + } |
|
487 | 495 | |
488 | 496 | ?> |
489 | 497 | \ No newline at end of file |
@@ -30,8 +30,9 @@ discard block |
||
30 | 30 | * @version 2.1 Beta 3 |
31 | 31 | */ |
32 | 32 | |
33 | -if (!defined('SMF')) |
|
33 | +if (!defined('SMF')) { |
|
34 | 34 | die('No direct access...'); |
35 | +} |
|
35 | 36 | |
36 | 37 | /** |
37 | 38 | * Subaction handler - manages the action and delegates control to the proper |
@@ -103,12 +104,12 @@ discard block |
||
103 | 104 | cache_put_data('minimized_css', null); |
104 | 105 | |
105 | 106 | // Follow the sa or just go to administration. |
106 | - if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) |
|
107 | - call_helper($subActions[$_GET['sa']]); |
|
108 | - |
|
109 | - else |
|
110 | - call_helper($subActions['admin']); |
|
111 | -} |
|
107 | + if (isset($_GET['sa']) && !empty($subActions[$_GET['sa']])) { |
|
108 | + call_helper($subActions[$_GET['sa']]); |
|
109 | + } else { |
|
110 | + call_helper($subActions['admin']); |
|
111 | + } |
|
112 | + } |
|
112 | 113 | |
113 | 114 | /** |
114 | 115 | * This function allows administration of themes and their settings, |
@@ -130,15 +131,16 @@ discard block |
||
130 | 131 | checkSession(); |
131 | 132 | validateToken('admin-tm'); |
132 | 133 | |
133 | - if (isset($_POST['options']['known_themes'])) |
|
134 | - foreach ($_POST['options']['known_themes'] as $key => $id) |
|
134 | + if (isset($_POST['options']['known_themes'])) { |
|
135 | + foreach ($_POST['options']['known_themes'] as $key => $id) |
|
135 | 136 | $_POST['options']['known_themes'][$key] = (int) $id; |
137 | + } else { |
|
138 | + fatal_lang_error('themes_none_selectable', false); |
|
139 | + } |
|
136 | 140 | |
137 | - else |
|
138 | - fatal_lang_error('themes_none_selectable', false); |
|
139 | - |
|
140 | - if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) |
|
141 | - fatal_lang_error('themes_default_selectable', false); |
|
141 | + if (!in_array($_POST['options']['theme_guests'], $_POST['options']['known_themes'])) { |
|
142 | + fatal_lang_error('themes_default_selectable', false); |
|
143 | + } |
|
142 | 144 | |
143 | 145 | // Commit the new settings. |
144 | 146 | updateSettings(array( |
@@ -146,8 +148,9 @@ discard block |
||
146 | 148 | 'theme_guests' => $_POST['options']['theme_guests'], |
147 | 149 | 'knownThemes' => implode(',', $_POST['options']['known_themes']), |
148 | 150 | )); |
149 | - if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) |
|
150 | - updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
151 | + if ((int) $_POST['theme_reset'] == 0 || in_array($_POST['theme_reset'], $_POST['options']['known_themes'])) { |
|
152 | + updateMemberData(null, array('id_theme' => (int) $_POST['theme_reset'])); |
|
153 | + } |
|
151 | 154 | |
152 | 155 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=admin'); |
153 | 156 | } |
@@ -166,8 +169,9 @@ discard block |
||
166 | 169 | // Look for a non existent theme directory. (ie theme87.) |
167 | 170 | $theme_dir = $boarddir . '/Themes/theme'; |
168 | 171 | $i = 1; |
169 | - while (file_exists($theme_dir . $i)) |
|
170 | - $i++; |
|
172 | + while (file_exists($theme_dir . $i)) { |
|
173 | + $i++; |
|
174 | + } |
|
171 | 175 | |
172 | 176 | $context['new_theme_name'] = 'theme' . $i; |
173 | 177 | |
@@ -189,8 +193,9 @@ discard block |
||
189 | 193 | loadLanguage('Admin'); |
190 | 194 | isAllowedTo('admin_forum'); |
191 | 195 | |
192 | - if (isset($_REQUEST['th'])) |
|
193 | - return SetThemeSettings(); |
|
196 | + if (isset($_REQUEST['th'])) { |
|
197 | + return SetThemeSettings(); |
|
198 | + } |
|
194 | 199 | |
195 | 200 | if (isset($_POST['save'])) |
196 | 201 | { |
@@ -274,12 +279,13 @@ discard block |
||
274 | 279 | $context['themes'] = array(); |
275 | 280 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
276 | 281 | { |
277 | - if (!isset($context['themes'][$row['id_theme']])) |
|
278 | - $context['themes'][$row['id_theme']] = array( |
|
282 | + if (!isset($context['themes'][$row['id_theme']])) { |
|
283 | + $context['themes'][$row['id_theme']] = array( |
|
279 | 284 | 'id' => $row['id_theme'], |
280 | 285 | 'num_default_options' => 0, |
281 | 286 | 'num_members' => 0, |
282 | 287 | ); |
288 | + } |
|
283 | 289 | $context['themes'][$row['id_theme']][$row['variable']] = $row['value']; |
284 | 290 | } |
285 | 291 | $smcFunc['db_free_result']($request); |
@@ -293,8 +299,9 @@ discard block |
||
293 | 299 | 'guest_member' => -1, |
294 | 300 | ) |
295 | 301 | ); |
296 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
297 | - $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
302 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
303 | + $context['themes'][$row['id_theme']]['num_default_options'] = $row['value']; |
|
304 | + } |
|
298 | 305 | $smcFunc['db_free_result']($request); |
299 | 306 | |
300 | 307 | // Need to make sure we don't do custom fields. |
@@ -305,8 +312,9 @@ discard block |
||
305 | 312 | ) |
306 | 313 | ); |
307 | 314 | $customFields = array(); |
308 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
309 | - $customFields[] = $row['col_name']; |
|
315 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
316 | + $customFields[] = $row['col_name']; |
|
317 | + } |
|
310 | 318 | $smcFunc['db_free_result']($request); |
311 | 319 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
312 | 320 | |
@@ -321,14 +329,16 @@ discard block |
||
321 | 329 | 'custom_fields' => empty($customFields) ? array() : $customFields, |
322 | 330 | ) |
323 | 331 | ); |
324 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
325 | - $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
332 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
333 | + $context['themes'][$row['id_theme']]['num_members'] = $row['value']; |
|
334 | + } |
|
326 | 335 | $smcFunc['db_free_result']($request); |
327 | 336 | |
328 | 337 | // There has to be a Settings template! |
329 | - foreach ($context['themes'] as $k => $v) |
|
330 | - if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
338 | + foreach ($context['themes'] as $k => $v) { |
|
339 | + if (empty($v['theme_dir']) || (!file_exists($v['theme_dir'] . '/Settings.template.php') && empty($v['num_members']))) |
|
331 | 340 | unset($context['themes'][$k]); |
341 | + } |
|
332 | 342 | |
333 | 343 | loadTemplate('Themes'); |
334 | 344 | $context['sub_template'] = 'reset_list'; |
@@ -343,16 +353,19 @@ discard block |
||
343 | 353 | checkSession(); |
344 | 354 | validateToken('admin-sto'); |
345 | 355 | |
346 | - if (empty($_POST['options'])) |
|
347 | - $_POST['options'] = array(); |
|
348 | - if (empty($_POST['default_options'])) |
|
349 | - $_POST['default_options'] = array(); |
|
356 | + if (empty($_POST['options'])) { |
|
357 | + $_POST['options'] = array(); |
|
358 | + } |
|
359 | + if (empty($_POST['default_options'])) { |
|
360 | + $_POST['default_options'] = array(); |
|
361 | + } |
|
350 | 362 | |
351 | 363 | // Set up the sql query. |
352 | 364 | $setValues = array(); |
353 | 365 | |
354 | - foreach ($_POST['options'] as $opt => $val) |
|
355 | - $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
366 | + foreach ($_POST['options'] as $opt => $val) { |
|
367 | + $setValues[] = array(-1, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
368 | + } |
|
356 | 369 | |
357 | 370 | $old_settings = array(); |
358 | 371 | foreach ($_POST['default_options'] as $opt => $val) |
@@ -366,8 +379,8 @@ discard block |
||
366 | 379 | if (!empty($setValues)) |
367 | 380 | { |
368 | 381 | // Are there options in non-default themes set that should be cleared? |
369 | - if (!empty($old_settings)) |
|
370 | - $smcFunc['db_query']('', ' |
|
382 | + if (!empty($old_settings)) { |
|
383 | + $smcFunc['db_query']('', ' |
|
371 | 384 | DELETE FROM {db_prefix}themes |
372 | 385 | WHERE id_theme != {int:default_theme} |
373 | 386 | AND id_member = {int:guest_member} |
@@ -378,6 +391,7 @@ discard block |
||
378 | 391 | 'old_settings' => $old_settings, |
379 | 392 | ) |
380 | 393 | ); |
394 | + } |
|
381 | 395 | |
382 | 396 | $smcFunc['db_insert']('replace', |
383 | 397 | '{db_prefix}themes', |
@@ -391,8 +405,7 @@ discard block |
||
391 | 405 | cache_put_data('theme_settings-1', null, 90); |
392 | 406 | |
393 | 407 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
394 | - } |
|
395 | - elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
408 | + } elseif (isset($_POST['submit']) && $_POST['who'] == 1) |
|
396 | 409 | { |
397 | 410 | checkSession(); |
398 | 411 | validateToken('admin-sto'); |
@@ -405,9 +418,9 @@ discard block |
||
405 | 418 | $old_settings = array(); |
406 | 419 | foreach ($_POST['default_options'] as $opt => $val) |
407 | 420 | { |
408 | - if ($_POST['default_options_master'][$opt] == 0) |
|
409 | - continue; |
|
410 | - elseif ($_POST['default_options_master'][$opt] == 1) |
|
421 | + if ($_POST['default_options_master'][$opt] == 0) { |
|
422 | + continue; |
|
423 | + } elseif ($_POST['default_options_master'][$opt] == 1) |
|
411 | 424 | { |
412 | 425 | // Delete then insert for ease of database compatibility! |
413 | 426 | $smcFunc['db_query']('substring', ' |
@@ -433,8 +446,7 @@ discard block |
||
433 | 446 | ); |
434 | 447 | |
435 | 448 | $old_settings[] = $opt; |
436 | - } |
|
437 | - elseif ($_POST['default_options_master'][$opt] == 2) |
|
449 | + } elseif ($_POST['default_options_master'][$opt] == 2) |
|
438 | 450 | { |
439 | 451 | $smcFunc['db_query']('', ' |
440 | 452 | DELETE FROM {db_prefix}themes |
@@ -449,8 +461,8 @@ discard block |
||
449 | 461 | } |
450 | 462 | |
451 | 463 | // Delete options from other themes. |
452 | - if (!empty($old_settings)) |
|
453 | - $smcFunc['db_query']('', ' |
|
464 | + if (!empty($old_settings)) { |
|
465 | + $smcFunc['db_query']('', ' |
|
454 | 466 | DELETE FROM {db_prefix}themes |
455 | 467 | WHERE id_theme != {int:default_theme} |
456 | 468 | AND id_member > {int:no_member} |
@@ -461,12 +473,13 @@ discard block |
||
461 | 473 | 'old_settings' => $old_settings, |
462 | 474 | ) |
463 | 475 | ); |
476 | + } |
|
464 | 477 | |
465 | 478 | foreach ($_POST['options'] as $opt => $val) |
466 | 479 | { |
467 | - if ($_POST['options_master'][$opt] == 0) |
|
468 | - continue; |
|
469 | - elseif ($_POST['options_master'][$opt] == 1) |
|
480 | + if ($_POST['options_master'][$opt] == 0) { |
|
481 | + continue; |
|
482 | + } elseif ($_POST['options_master'][$opt] == 1) |
|
470 | 483 | { |
471 | 484 | // Delete then insert for ease of database compatibility - again! |
472 | 485 | $smcFunc['db_query']('substring', ' |
@@ -491,8 +504,7 @@ discard block |
||
491 | 504 | 'value' => (is_array($val) ? implode(',', $val) : $val), |
492 | 505 | ) |
493 | 506 | ); |
494 | - } |
|
495 | - elseif ($_POST['options_master'][$opt] == 2) |
|
507 | + } elseif ($_POST['options_master'][$opt] == 2) |
|
496 | 508 | { |
497 | 509 | $smcFunc['db_query']('', ' |
498 | 510 | DELETE FROM {db_prefix}themes |
@@ -509,8 +521,7 @@ discard block |
||
509 | 521 | } |
510 | 522 | |
511 | 523 | redirectexit('action=admin;area=theme;' . $context['session_var'] . '=' . $context['session_id'] . ';sa=reset'); |
512 | - } |
|
513 | - elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
524 | + } elseif (!empty($_GET['who']) && $_GET['who'] == 2) |
|
514 | 525 | { |
515 | 526 | checkSession('get'); |
516 | 527 | validateToken('admin-stor', 'request'); |
@@ -525,8 +536,9 @@ discard block |
||
525 | 536 | ) |
526 | 537 | ); |
527 | 538 | $customFields = array(); |
528 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
529 | - $customFields[] = $row['col_name']; |
|
539 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
540 | + $customFields[] = $row['col_name']; |
|
541 | + } |
|
530 | 542 | $smcFunc['db_free_result']($request); |
531 | 543 | } |
532 | 544 | $customFieldsQuery = empty($customFields) ? '' : ('AND variable NOT IN ({array_string:custom_fields})'); |
@@ -578,13 +590,13 @@ discard block |
||
578 | 590 | ) |
579 | 591 | ); |
580 | 592 | $context['theme_options'] = array(); |
581 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
582 | - $context['theme_options'][$row['variable']] = $row['value']; |
|
593 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
594 | + $context['theme_options'][$row['variable']] = $row['value']; |
|
595 | + } |
|
583 | 596 | $smcFunc['db_free_result']($request); |
584 | 597 | |
585 | 598 | $context['theme_options_reset'] = false; |
586 | - } |
|
587 | - else |
|
599 | + } else |
|
588 | 600 | { |
589 | 601 | $context['theme_options'] = array(); |
590 | 602 | $context['theme_options_reset'] = true; |
@@ -593,30 +605,32 @@ discard block |
||
593 | 605 | foreach ($context['options'] as $i => $setting) |
594 | 606 | { |
595 | 607 | // Just skip separators |
596 | - if (!is_array($setting)) |
|
597 | - continue; |
|
608 | + if (!is_array($setting)) { |
|
609 | + continue; |
|
610 | + } |
|
598 | 611 | |
599 | 612 | // Is this disabled? |
600 | 613 | if ($setting['id'] == 'calendar_start_day' && empty($modSettings['cal_enabled'])) |
601 | 614 | { |
602 | 615 | unset($context['options'][$i]); |
603 | 616 | continue; |
604 | - } |
|
605 | - elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
617 | + } elseif (($setting['id'] == 'topics_per_page' || $setting['id'] == 'messages_per_page') && !empty($modSettings['disableCustomPerPage'])) |
|
606 | 618 | { |
607 | 619 | unset($context['options'][$i]); |
608 | 620 | continue; |
609 | 621 | } |
610 | 622 | |
611 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
612 | - $context['options'][$i]['type'] = 'checkbox'; |
|
613 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
614 | - $context['options'][$i]['type'] = 'number'; |
|
615 | - elseif ($setting['type'] == 'string') |
|
616 | - $context['options'][$i]['type'] = 'text'; |
|
623 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
624 | + $context['options'][$i]['type'] = 'checkbox'; |
|
625 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
626 | + $context['options'][$i]['type'] = 'number'; |
|
627 | + } elseif ($setting['type'] == 'string') { |
|
628 | + $context['options'][$i]['type'] = 'text'; |
|
629 | + } |
|
617 | 630 | |
618 | - if (isset($setting['options'])) |
|
619 | - $context['options'][$i]['type'] = 'list'; |
|
631 | + if (isset($setting['options'])) { |
|
632 | + $context['options'][$i]['type'] = 'list'; |
|
633 | + } |
|
620 | 634 | |
621 | 635 | $context['options'][$i]['value'] = !isset($context['theme_options'][$setting['id']]) ? '' : $context['theme_options'][$setting['id']]; |
622 | 636 | } |
@@ -641,8 +655,9 @@ discard block |
||
641 | 655 | { |
642 | 656 | global $txt, $context, $settings, $modSettings, $smcFunc; |
643 | 657 | |
644 | - if (empty($_GET['th']) && empty($_GET['id'])) |
|
645 | - return ThemeAdmin(); |
|
658 | + if (empty($_GET['th']) && empty($_GET['id'])) { |
|
659 | + return ThemeAdmin(); |
|
660 | + } |
|
646 | 661 | |
647 | 662 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
648 | 663 | |
@@ -653,8 +668,9 @@ discard block |
||
653 | 668 | isAllowedTo('admin_forum'); |
654 | 669 | |
655 | 670 | // Validate inputs/user. |
656 | - if (empty($_GET['th'])) |
|
657 | - fatal_lang_error('no_theme', false); |
|
671 | + if (empty($_GET['th'])) { |
|
672 | + fatal_lang_error('no_theme', false); |
|
673 | + } |
|
658 | 674 | |
659 | 675 | // Fetch the smiley sets... |
660 | 676 | $sets = explode(',', 'none,' . $modSettings['smiley_sets_known']); |
@@ -662,8 +678,9 @@ discard block |
||
662 | 678 | $context['smiley_sets'] = array( |
663 | 679 | '' => $txt['smileys_no_default'] |
664 | 680 | ); |
665 | - foreach ($sets as $i => $set) |
|
666 | - $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
681 | + foreach ($sets as $i => $set) { |
|
682 | + $context['smiley_sets'][$set] = $smcFunc['htmlspecialchars']($set_names[$i]); |
|
683 | + } |
|
667 | 684 | |
668 | 685 | $old_id = $settings['theme_id']; |
669 | 686 | $old_settings = $settings; |
@@ -688,8 +705,9 @@ discard block |
||
688 | 705 | if (file_exists($settings['theme_dir'] . '/index.template.php')) |
689 | 706 | { |
690 | 707 | $file_contents = implode('', file($settings['theme_dir'] . '/index.template.php')); |
691 | - if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) |
|
692 | - eval('global $settings;' . $matches[0]); |
|
708 | + if (preg_match('~\$settings\[\'theme_variants\'\]\s*=(.+?);~', $file_contents, $matches)) { |
|
709 | + eval('global $settings;' . $matches[0]); |
|
710 | + } |
|
693 | 711 | } |
694 | 712 | |
695 | 713 | // Submitting! |
@@ -698,37 +716,45 @@ discard block |
||
698 | 716 | checkSession(); |
699 | 717 | validateToken('admin-sts'); |
700 | 718 | |
701 | - if (empty($_POST['options'])) |
|
702 | - $_POST['options'] = array(); |
|
703 | - if (empty($_POST['default_options'])) |
|
704 | - $_POST['default_options'] = array(); |
|
719 | + if (empty($_POST['options'])) { |
|
720 | + $_POST['options'] = array(); |
|
721 | + } |
|
722 | + if (empty($_POST['default_options'])) { |
|
723 | + $_POST['default_options'] = array(); |
|
724 | + } |
|
705 | 725 | |
706 | 726 | // Make sure items are cast correctly. |
707 | 727 | foreach ($context['theme_settings'] as $item) |
708 | 728 | { |
709 | 729 | // Disregard this item if this is just a separator. |
710 | - if (!is_array($item)) |
|
711 | - continue; |
|
730 | + if (!is_array($item)) { |
|
731 | + continue; |
|
732 | + } |
|
712 | 733 | |
713 | 734 | foreach (array('options', 'default_options') as $option) |
714 | 735 | { |
715 | - if (!isset($_POST[$option][$item['id']])) |
|
716 | - continue; |
|
736 | + if (!isset($_POST[$option][$item['id']])) { |
|
737 | + continue; |
|
738 | + } |
|
717 | 739 | // Checkbox. |
718 | - elseif (empty($item['type'])) |
|
719 | - $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
740 | + elseif (empty($item['type'])) { |
|
741 | + $_POST[$option][$item['id']] = $_POST[$option][$item['id']] ? 1 : 0; |
|
742 | + } |
|
720 | 743 | // Number |
721 | - elseif ($item['type'] == 'number') |
|
722 | - $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
744 | + elseif ($item['type'] == 'number') { |
|
745 | + $_POST[$option][$item['id']] = (int) $_POST[$option][$item['id']]; |
|
746 | + } |
|
723 | 747 | } |
724 | 748 | } |
725 | 749 | |
726 | 750 | // Set up the sql query. |
727 | 751 | $inserts = array(); |
728 | - foreach ($_POST['options'] as $opt => $val) |
|
729 | - $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
730 | - foreach ($_POST['default_options'] as $opt => $val) |
|
731 | - $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
752 | + foreach ($_POST['options'] as $opt => $val) { |
|
753 | + $inserts[] = array(0, $_GET['th'], $opt, is_array($val) ? implode(',', $val) : $val); |
|
754 | + } |
|
755 | + foreach ($_POST['default_options'] as $opt => $val) { |
|
756 | + $inserts[] = array(0, 1, $opt, is_array($val) ? implode(',', $val) : $val); |
|
757 | + } |
|
732 | 758 | // If we're actually inserting something.. |
733 | 759 | if (!empty($inserts)) |
734 | 760 | { |
@@ -754,8 +780,9 @@ discard block |
||
754 | 780 | |
755 | 781 | foreach ($settings as $setting => $dummy) |
756 | 782 | { |
757 | - if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) |
|
758 | - $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
783 | + if (!in_array($setting, array('theme_url', 'theme_dir', 'images_url', 'template_dirs'))) { |
|
784 | + $settings[$setting] = htmlspecialchars__recursive($settings[$setting]); |
|
785 | + } |
|
759 | 786 | } |
760 | 787 | |
761 | 788 | $context['settings'] = $context['theme_settings']; |
@@ -764,18 +791,21 @@ discard block |
||
764 | 791 | foreach ($context['settings'] as $i => $setting) |
765 | 792 | { |
766 | 793 | // Separators are dummies, so leave them alone. |
767 | - if (!is_array($setting)) |
|
768 | - continue; |
|
794 | + if (!is_array($setting)) { |
|
795 | + continue; |
|
796 | + } |
|
769 | 797 | |
770 | - if (!isset($setting['type']) || $setting['type'] == 'bool') |
|
771 | - $context['settings'][$i]['type'] = 'checkbox'; |
|
772 | - elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') |
|
773 | - $context['settings'][$i]['type'] = 'number'; |
|
774 | - elseif ($setting['type'] == 'string') |
|
775 | - $context['settings'][$i]['type'] = 'text'; |
|
798 | + if (!isset($setting['type']) || $setting['type'] == 'bool') { |
|
799 | + $context['settings'][$i]['type'] = 'checkbox'; |
|
800 | + } elseif ($setting['type'] == 'int' || $setting['type'] == 'integer') { |
|
801 | + $context['settings'][$i]['type'] = 'number'; |
|
802 | + } elseif ($setting['type'] == 'string') { |
|
803 | + $context['settings'][$i]['type'] = 'text'; |
|
804 | + } |
|
776 | 805 | |
777 | - if (isset($setting['options'])) |
|
778 | - $context['settings'][$i]['type'] = 'list'; |
|
806 | + if (isset($setting['options'])) { |
|
807 | + $context['settings'][$i]['type'] = 'list'; |
|
808 | + } |
|
779 | 809 | |
780 | 810 | $context['settings'][$i]['value'] = !isset($settings[$setting['id']]) ? '' : $settings[$setting['id']]; |
781 | 811 | } |
@@ -828,8 +858,9 @@ discard block |
||
828 | 858 | $themeID = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
829 | 859 | |
830 | 860 | // You can't delete the default theme! |
831 | - if ($themeID == 1) |
|
832 | - fatal_lang_error('no_access', false); |
|
861 | + if ($themeID == 1) { |
|
862 | + fatal_lang_error('no_access', false); |
|
863 | + } |
|
833 | 864 | |
834 | 865 | $theme_info = get_single_theme($themeID); |
835 | 866 | |
@@ -837,8 +868,9 @@ discard block |
||
837 | 868 | remove_theme($themeID); |
838 | 869 | |
839 | 870 | // And remove all its files and folders too. |
840 | - if (!empty($theme_info) && !empty($theme_info['theme_dir'])) |
|
841 | - remove_dir($theme_info['theme_dir']); |
|
871 | + if (!empty($theme_info) && !empty($theme_info['theme_dir'])) { |
|
872 | + remove_dir($theme_info['theme_dir']); |
|
873 | + } |
|
842 | 874 | |
843 | 875 | // Go back to the list page. |
844 | 876 | redirectexit('action=admin;area=theme;sa=list;' . $context['session_var'] . '=' . $context['session_id'] . ';done=removing'); |
@@ -863,12 +895,14 @@ discard block |
||
863 | 895 | $enableThemes = explode(',', $modSettings['enableThemes']); |
864 | 896 | |
865 | 897 | // Are we disabling it? |
866 | - if (isset($_GET['disabled'])) |
|
867 | - $enableThemes = array_diff($enableThemes, array($themeID)); |
|
898 | + if (isset($_GET['disabled'])) { |
|
899 | + $enableThemes = array_diff($enableThemes, array($themeID)); |
|
900 | + } |
|
868 | 901 | |
869 | 902 | // Nope? then enable it! |
870 | - else |
|
871 | - $enableThemes[] = (string) $themeID; |
|
903 | + else { |
|
904 | + $enableThemes[] = (string) $themeID; |
|
905 | + } |
|
872 | 906 | |
873 | 907 | // Update the setting. |
874 | 908 | $enableThemes = strtr(implode(',', $enableThemes), array(',,' => ',')); |
@@ -903,18 +937,21 @@ discard block |
||
903 | 937 | |
904 | 938 | $_SESSION['id_theme'] = 0; |
905 | 939 | |
906 | - if (isset($_GET['id'])) |
|
907 | - $_GET['th'] = $_GET['id']; |
|
940 | + if (isset($_GET['id'])) { |
|
941 | + $_GET['th'] = $_GET['id']; |
|
942 | + } |
|
908 | 943 | |
909 | 944 | // Saving a variant cause JS doesn't work - pretend it did ;) |
910 | 945 | if (isset($_POST['save'])) |
911 | 946 | { |
912 | 947 | // Which theme? |
913 | - foreach ($_POST['save'] as $k => $v) |
|
914 | - $_GET['th'] = (int) $k; |
|
948 | + foreach ($_POST['save'] as $k => $v) { |
|
949 | + $_GET['th'] = (int) $k; |
|
950 | + } |
|
915 | 951 | |
916 | - if (isset($_POST['vrt'][$k])) |
|
917 | - $_GET['vrt'] = $_POST['vrt'][$k]; |
|
952 | + if (isset($_POST['vrt'][$k])) { |
|
953 | + $_GET['vrt'] = $_POST['vrt'][$k]; |
|
954 | + } |
|
918 | 955 | } |
919 | 956 | |
920 | 957 | // Have we made a decision, or are we just browsing? |
@@ -992,8 +1029,9 @@ discard block |
||
992 | 1029 | else |
993 | 1030 | { |
994 | 1031 | // The forum's default theme is always 0 and we |
995 | - if (isset($_GET['th']) && $_GET['th'] == 0) |
|
996 | - $_GET['th'] = $modSettings['theme_guests']; |
|
1032 | + if (isset($_GET['th']) && $_GET['th'] == 0) { |
|
1033 | + $_GET['th'] = $modSettings['theme_guests']; |
|
1034 | + } |
|
997 | 1035 | |
998 | 1036 | updateMemberData((int) $_REQUEST['u'], array('id_theme' => (int) $_GET['th'])); |
999 | 1037 | |
@@ -1007,8 +1045,9 @@ discard block |
||
1007 | 1045 | ); |
1008 | 1046 | cache_put_data('theme_settings-' . $_GET['th'] . ':' . (int) $_REQUEST['u'], null, 90); |
1009 | 1047 | |
1010 | - if ($user_info['id'] == $_REQUEST['u']) |
|
1011 | - $_SESSION['id_variant'] = 0; |
|
1048 | + if ($user_info['id'] == $_REQUEST['u']) { |
|
1049 | + $_SESSION['id_variant'] = 0; |
|
1050 | + } |
|
1012 | 1051 | } |
1013 | 1052 | |
1014 | 1053 | redirectexit('action=profile;u=' . (int) $_REQUEST['u'] . ';area=theme'); |
@@ -1077,12 +1116,13 @@ discard block |
||
1077 | 1116 | ); |
1078 | 1117 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1079 | 1118 | { |
1080 | - if (!isset($context['available_themes'][$row['id_theme']])) |
|
1081 | - $context['available_themes'][$row['id_theme']] = array( |
|
1119 | + if (!isset($context['available_themes'][$row['id_theme']])) { |
|
1120 | + $context['available_themes'][$row['id_theme']] = array( |
|
1082 | 1121 | 'id' => $row['id_theme'], |
1083 | 1122 | 'selected' => $context['current_theme'] == $row['id_theme'], |
1084 | 1123 | 'num_users' => 0 |
1085 | 1124 | ); |
1125 | + } |
|
1086 | 1126 | $context['available_themes'][$row['id_theme']][$row['variable']] = $row['value']; |
1087 | 1127 | } |
1088 | 1128 | $smcFunc['db_free_result']($request); |
@@ -1095,9 +1135,9 @@ discard block |
||
1095 | 1135 | 'num_users' => 0 |
1096 | 1136 | ); |
1097 | 1137 | $guest_theme = 0; |
1138 | + } else { |
|
1139 | + $guest_theme = $modSettings['theme_guests']; |
|
1098 | 1140 | } |
1099 | - else |
|
1100 | - $guest_theme = $modSettings['theme_guests']; |
|
1101 | 1141 | |
1102 | 1142 | $request = $smcFunc['db_query']('', ' |
1103 | 1143 | SELECT id_theme, COUNT(*) AS the_count |
@@ -1110,15 +1150,17 @@ discard block |
||
1110 | 1150 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1111 | 1151 | { |
1112 | 1152 | // Figure out which theme it is they are REALLY using. |
1113 | - if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) |
|
1114 | - $row['id_theme'] = $guest_theme; |
|
1115 | - elseif (empty($modSettings['theme_allow'])) |
|
1116 | - $row['id_theme'] = $guest_theme; |
|
1153 | + if (!empty($modSettings['knownThemes']) && !in_array($row['id_theme'], explode(',', $modSettings['knownThemes']))) { |
|
1154 | + $row['id_theme'] = $guest_theme; |
|
1155 | + } elseif (empty($modSettings['theme_allow'])) { |
|
1156 | + $row['id_theme'] = $guest_theme; |
|
1157 | + } |
|
1117 | 1158 | |
1118 | - if (isset($context['available_themes'][$row['id_theme']])) |
|
1119 | - $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1120 | - else |
|
1121 | - $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1159 | + if (isset($context['available_themes'][$row['id_theme']])) { |
|
1160 | + $context['available_themes'][$row['id_theme']]['num_users'] += $row['the_count']; |
|
1161 | + } else { |
|
1162 | + $context['available_themes'][$guest_theme]['num_users'] += $row['the_count']; |
|
1163 | + } |
|
1122 | 1164 | } |
1123 | 1165 | $smcFunc['db_free_result']($request); |
1124 | 1166 | |
@@ -1137,8 +1179,9 @@ discard block |
||
1137 | 1179 | 'id_member' => isset($_REQUEST['sa']) && $_REQUEST['sa'] == 'pick' ? array(-1, $context['current_member']) : array(-1), |
1138 | 1180 | ) |
1139 | 1181 | ); |
1140 | - while ($row = $smcFunc['db_fetch_assoc']($request)) |
|
1141 | - $variant_preferences[$row['id_theme']] = $row['value']; |
|
1182 | + while ($row = $smcFunc['db_fetch_assoc']($request)) { |
|
1183 | + $variant_preferences[$row['id_theme']] = $row['value']; |
|
1184 | + } |
|
1142 | 1185 | $smcFunc['db_free_result']($request); |
1143 | 1186 | } |
1144 | 1187 | |
@@ -1149,17 +1192,18 @@ discard block |
||
1149 | 1192 | foreach ($context['available_themes'] as $id_theme => $theme_data) |
1150 | 1193 | { |
1151 | 1194 | // Don't try to load the forum or board default theme's data... it doesn't have any! |
1152 | - if ($id_theme == 0) |
|
1153 | - continue; |
|
1195 | + if ($id_theme == 0) { |
|
1196 | + continue; |
|
1197 | + } |
|
1154 | 1198 | |
1155 | 1199 | // The thumbnail needs the correct path. |
1156 | 1200 | $settings['images_url'] = &$theme_data['images_url']; |
1157 | 1201 | |
1158 | - if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) |
|
1159 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1160 | - elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) |
|
1161 | - include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1162 | - else |
|
1202 | + if (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php')) { |
|
1203 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $user_info['language'] . '.php'); |
|
1204 | + } elseif (file_exists($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php')) { |
|
1205 | + include($theme_data['theme_dir'] . '/languages/Settings.' . $language . '.php'); |
|
1206 | + } else |
|
1163 | 1207 | { |
1164 | 1208 | $txt['theme_thumbnail_href'] = $theme_data['images_url'] . '/thumbnail.png'; |
1165 | 1209 | $txt['theme_description'] = ''; |
@@ -1184,15 +1228,17 @@ discard block |
||
1184 | 1228 | loadLanguage('Settings'); |
1185 | 1229 | |
1186 | 1230 | $context['available_themes'][$id_theme]['variants'] = array(); |
1187 | - foreach ($settings['theme_variants'] as $variant) |
|
1188 | - $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1231 | + foreach ($settings['theme_variants'] as $variant) { |
|
1232 | + $context['available_themes'][$id_theme]['variants'][$variant] = array( |
|
1189 | 1233 | 'label' => isset($txt['variant_' . $variant]) ? $txt['variant_' . $variant] : $variant, |
1190 | 1234 | 'thumbnail' => !file_exists($theme_data['theme_dir'] . '/images/thumbnail.png') || file_exists($theme_data['theme_dir'] . '/images/thumbnail_' . $variant . '.png') ? $theme_data['images_url'] . '/thumbnail_' . $variant . '.png' : ($theme_data['images_url'] . '/thumbnail.png'), |
1191 | 1235 | ); |
1236 | + } |
|
1192 | 1237 | |
1193 | 1238 | $context['available_themes'][$id_theme]['selected_variant'] = isset($_GET['vrt']) ? $_GET['vrt'] : (!empty($variant_preferences[$id_theme]) ? $variant_preferences[$id_theme] : (!empty($settings['default_variant']) ? $settings['default_variant'] : $settings['theme_variants'][0])); |
1194 | - if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) |
|
1195 | - $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1239 | + if (!isset($context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail'])) { |
|
1240 | + $context['available_themes'][$id_theme]['selected_variant'] = $settings['theme_variants'][0]; |
|
1241 | + } |
|
1196 | 1242 | |
1197 | 1243 | $context['available_themes'][$id_theme]['thumbnail_href'] = $context['available_themes'][$id_theme]['variants'][$context['available_themes'][$id_theme]['selected_variant']]['thumbnail']; |
1198 | 1244 | // Allow themes to override the text. |
@@ -1208,8 +1254,9 @@ discard block |
||
1208 | 1254 | // As long as we're not doing the default theme... |
1209 | 1255 | if (!isset($_REQUEST['u']) || $_REQUEST['u'] >= 0) |
1210 | 1256 | { |
1211 | - if ($guest_theme != 0) |
|
1212 | - $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1257 | + if ($guest_theme != 0) { |
|
1258 | + $context['available_themes'][0] = $context['available_themes'][$guest_theme]; |
|
1259 | + } |
|
1213 | 1260 | |
1214 | 1261 | $context['available_themes'][0]['id'] = 0; |
1215 | 1262 | $context['available_themes'][0]['name'] = $txt['theme_forum_default']; |
@@ -1258,14 +1305,16 @@ discard block |
||
1258 | 1305 | $action = $smcFunc['htmlspecialchars'](trim($_GET['do'])); |
1259 | 1306 | |
1260 | 1307 | // Got any info from the specific form? |
1261 | - if (!isset($_POST['save_' . $action])) |
|
1262 | - fatal_lang_error('theme_install_no_action', false); |
|
1308 | + if (!isset($_POST['save_' . $action])) { |
|
1309 | + fatal_lang_error('theme_install_no_action', false); |
|
1310 | + } |
|
1263 | 1311 | |
1264 | 1312 | validateToken('admin-t-' . $action); |
1265 | 1313 | |
1266 | 1314 | // Hopefully the themes directory is writable, or we might have a problem. |
1267 | - if (!is_writable($themedir)) |
|
1268 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1315 | + if (!is_writable($themedir)) { |
|
1316 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1317 | + } |
|
1269 | 1318 | |
1270 | 1319 | // Call the function and handle the result. |
1271 | 1320 | $result = $subActions[$action](); |
@@ -1280,9 +1329,10 @@ discard block |
||
1280 | 1329 | } |
1281 | 1330 | |
1282 | 1331 | // Nope, show a nice error. |
1283 | - else |
|
1284 | - fatal_lang_error('theme_install_no_action', false); |
|
1285 | -} |
|
1332 | + else { |
|
1333 | + fatal_lang_error('theme_install_no_action', false); |
|
1334 | + } |
|
1335 | + } |
|
1286 | 1336 | |
1287 | 1337 | /** |
1288 | 1338 | * Installs a theme from a theme package. |
@@ -1298,8 +1348,9 @@ discard block |
||
1298 | 1348 | $dirtemp = $themedir . '/temp'; |
1299 | 1349 | |
1300 | 1350 | // Make sure the temp dir doesn't already exist |
1301 | - if (file_exists($dirtemp)) |
|
1302 | - remove_dir($dirtemp); |
|
1351 | + if (file_exists($dirtemp)) { |
|
1352 | + remove_dir($dirtemp); |
|
1353 | + } |
|
1303 | 1354 | |
1304 | 1355 | // Create the temp dir. |
1305 | 1356 | mkdir($dirtemp, 0777); |
@@ -1311,17 +1362,20 @@ discard block |
||
1311 | 1362 | smf_chmod($dirtemp, '0755'); |
1312 | 1363 | |
1313 | 1364 | // How about now? |
1314 | - if (!is_writable($dirtemp)) |
|
1315 | - fatal_lang_error('theme_install_write_error', 'critical'); |
|
1365 | + if (!is_writable($dirtemp)) { |
|
1366 | + fatal_lang_error('theme_install_write_error', 'critical'); |
|
1367 | + } |
|
1316 | 1368 | } |
1317 | 1369 | |
1318 | 1370 | // This happens when the admin session is gone and the user has to login again. |
1319 | - if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) |
|
1320 | - redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1371 | + if (!isset($_FILES) || !isset($_FILES['theme_gz']) || empty($_FILES['theme_gz'])) { |
|
1372 | + redirectexit('action=admin;area=theme;sa=admin;' . $context['session_var'] . '=' . $context['session_id']); |
|
1373 | + } |
|
1321 | 1374 | |
1322 | 1375 | // Another error check layer, something went wrong with the upload. |
1323 | - if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) |
|
1324 | - fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1376 | + if (isset($_FILES['theme_gz']['error']) && $_FILES['theme_gz']['error'] != 0) { |
|
1377 | + fatal_lang_error('theme_install_error_file_' . $_FILES['theme_gz']['error'], false); |
|
1378 | + } |
|
1325 | 1379 | |
1326 | 1380 | // Get the theme's name. |
1327 | 1381 | $name = pathinfo($_FILES['theme_gz']['name'], PATHINFO_FILENAME); |
@@ -1352,11 +1406,10 @@ discard block |
||
1352 | 1406 | |
1353 | 1407 | // return all the info. |
1354 | 1408 | return $context['to_install']; |
1409 | + } else { |
|
1410 | + fatal_lang_error('theme_install_error_title', false); |
|
1411 | + } |
|
1355 | 1412 | } |
1356 | - |
|
1357 | - else |
|
1358 | - fatal_lang_error('theme_install_error_title', false); |
|
1359 | -} |
|
1360 | 1413 | |
1361 | 1414 | /** |
1362 | 1415 | * Makes a copy from the default theme, assigns a name for it and installs it. |
@@ -1370,15 +1423,17 @@ discard block |
||
1370 | 1423 | global $forum_version; |
1371 | 1424 | |
1372 | 1425 | // There's gotta be something to work with. |
1373 | - if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) |
|
1374 | - fatal_lang_error('theme_install_error_title', false); |
|
1426 | + if (!isset($_REQUEST['copy']) || empty($_REQUEST['copy'])) { |
|
1427 | + fatal_lang_error('theme_install_error_title', false); |
|
1428 | + } |
|
1375 | 1429 | |
1376 | 1430 | // Get a cleaner version. |
1377 | 1431 | $name = preg_replace('~[^A-Za-z0-9_\- ]~', '', $_REQUEST['copy']); |
1378 | 1432 | |
1379 | 1433 | // Is there a theme already named like this? |
1380 | - if (file_exists($themedir . '/' . $name)) |
|
1381 | - fatal_lang_error('theme_install_already_dir', false); |
|
1434 | + if (file_exists($themedir . '/' . $name)) { |
|
1435 | + fatal_lang_error('theme_install_already_dir', false); |
|
1436 | + } |
|
1382 | 1437 | |
1383 | 1438 | // This is a brand new theme so set all possible values. |
1384 | 1439 | $context['to_install'] = array( |
@@ -1398,8 +1453,9 @@ discard block |
||
1398 | 1453 | |
1399 | 1454 | // Buy some time. |
1400 | 1455 | @set_time_limit(600); |
1401 | - if (function_exists('apache_reset_timeout')) |
|
1402 | - @apache_reset_timeout(); |
|
1456 | + if (function_exists('apache_reset_timeout')) { |
|
1457 | + @apache_reset_timeout(); |
|
1458 | + } |
|
1403 | 1459 | |
1404 | 1460 | // Create subdirectories for css and javascript files. |
1405 | 1461 | mkdir($context['to_install']['theme_dir'] . '/css', 0777); |
@@ -1435,12 +1491,13 @@ discard block |
||
1435 | 1491 | |
1436 | 1492 | while ($row = $smcFunc['db_fetch_assoc']($request)) |
1437 | 1493 | { |
1438 | - if ($row['variable'] == 'theme_templates') |
|
1439 | - $theme_templates = $row['value']; |
|
1440 | - elseif ($row['variable'] == 'theme_layers') |
|
1441 | - $theme_layers = $row['value']; |
|
1442 | - else |
|
1443 | - continue; |
|
1494 | + if ($row['variable'] == 'theme_templates') { |
|
1495 | + $theme_templates = $row['value']; |
|
1496 | + } elseif ($row['variable'] == 'theme_layers') { |
|
1497 | + $theme_layers = $row['value']; |
|
1498 | + } else { |
|
1499 | + continue; |
|
1500 | + } |
|
1444 | 1501 | } |
1445 | 1502 | |
1446 | 1503 | $smcFunc['db_free_result']($request); |
@@ -1499,12 +1556,14 @@ discard block |
||
1499 | 1556 | global $themedir, $themeurl, $context; |
1500 | 1557 | |
1501 | 1558 | // Cannot use the theme dir as a theme dir. |
1502 | - if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) |
|
1503 | - fatal_lang_error('theme_install_invalid_dir', false); |
|
1559 | + if (!isset($_REQUEST['theme_dir']) || empty($_REQUEST['theme_dir']) || rtrim(realpath($_REQUEST['theme_dir']), '/\\') == realpath($themedir)) { |
|
1560 | + fatal_lang_error('theme_install_invalid_dir', false); |
|
1561 | + } |
|
1504 | 1562 | |
1505 | 1563 | // Check is there is "something" on the dir. |
1506 | - elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) |
|
1507 | - fatal_lang_error('theme_install_error', false); |
|
1564 | + elseif (!is_dir($_REQUEST['theme_dir']) || !file_exists($_REQUEST['theme_dir'] . '/theme_info.xml')) { |
|
1565 | + fatal_lang_error('theme_install_error', false); |
|
1566 | + } |
|
1508 | 1567 | |
1509 | 1568 | $name = basename($_REQUEST['theme_dir']); |
1510 | 1569 | $name = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $name); |
@@ -1548,24 +1607,27 @@ discard block |
||
1548 | 1607 | } |
1549 | 1608 | |
1550 | 1609 | // Any special layers? |
1551 | - if (isset($settings['catch_action']['layers'])) |
|
1552 | - $context['template_layers'] = $settings['catch_action']['layers']; |
|
1610 | + if (isset($settings['catch_action']['layers'])) { |
|
1611 | + $context['template_layers'] = $settings['catch_action']['layers']; |
|
1612 | + } |
|
1553 | 1613 | |
1554 | 1614 | // Any function to call? |
1555 | 1615 | if (isset($settings['catch_action']['function'])) |
1556 | 1616 | { |
1557 | 1617 | $hook = $settings['catch_action']['function']; |
1558 | 1618 | |
1559 | - if (!isset($settings['catch_action']['filename'])) |
|
1560 | - $settings['catch_action']['filename'] = ''; |
|
1619 | + if (!isset($settings['catch_action']['filename'])) { |
|
1620 | + $settings['catch_action']['filename'] = ''; |
|
1621 | + } |
|
1561 | 1622 | |
1562 | 1623 | add_integration_function('integrate_wrap_action', $hook, false, $settings['catch_action']['filename'], false); |
1563 | 1624 | call_integration_hook('integrate_wrap_action'); |
1564 | 1625 | } |
1565 | 1626 | // And finally, the main sub template ;). |
1566 | - if (isset($settings['catch_action']['sub_template'])) |
|
1567 | - $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1568 | -} |
|
1627 | + if (isset($settings['catch_action']['sub_template'])) { |
|
1628 | + $context['sub_template'] = $settings['catch_action']['sub_template']; |
|
1629 | + } |
|
1630 | + } |
|
1569 | 1631 | |
1570 | 1632 | /** |
1571 | 1633 | * Set an option via javascript. |
@@ -1584,12 +1646,14 @@ discard block |
||
1584 | 1646 | checkSession('get'); |
1585 | 1647 | |
1586 | 1648 | // This good-for-nothing pixel is being used to keep the session alive. |
1587 | - if (empty($_GET['var']) || !isset($_GET['val'])) |
|
1588 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1649 | + if (empty($_GET['var']) || !isset($_GET['val'])) { |
|
1650 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1651 | + } |
|
1589 | 1652 | |
1590 | 1653 | // Sorry, guests can't go any further than this. |
1591 | - if ($user_info['is_guest'] || $user_info['id'] == 0) |
|
1592 | - obExit(false); |
|
1654 | + if ($user_info['is_guest'] || $user_info['id'] == 0) { |
|
1655 | + obExit(false); |
|
1656 | + } |
|
1593 | 1657 | |
1594 | 1658 | $reservedVars = array( |
1595 | 1659 | 'actual_theme_url', |
@@ -1612,8 +1676,9 @@ discard block |
||
1612 | 1676 | ); |
1613 | 1677 | |
1614 | 1678 | // Can't change reserved vars. |
1615 | - if (in_array(strtolower($_GET['var']), $reservedVars)) |
|
1616 | - redirectexit($settings['images_url'] . '/blank.png'); |
|
1679 | + if (in_array(strtolower($_GET['var']), $reservedVars)) { |
|
1680 | + redirectexit($settings['images_url'] . '/blank.png'); |
|
1681 | + } |
|
1617 | 1682 | |
1618 | 1683 | // Use a specific theme? |
1619 | 1684 | if (isset($_GET['th']) || isset($_GET['id'])) |
@@ -1629,8 +1694,9 @@ discard block |
||
1629 | 1694 | { |
1630 | 1695 | $options['admin_preferences'] = !empty($options['admin_preferences']) ? smf_json_decode($options['admin_preferences'], true) : array(); |
1631 | 1696 | // New thingy... |
1632 | - if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) |
|
1633 | - $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1697 | + if (isset($_GET['admin_key']) && strlen($_GET['admin_key']) < 5) { |
|
1698 | + $options['admin_preferences'][$_GET['admin_key']] = $_GET['val']; |
|
1699 | + } |
|
1634 | 1700 | |
1635 | 1701 | // Change the value to be something nice, |
1636 | 1702 | $_GET['val'] = json_encode($options['admin_preferences']); |
@@ -1660,8 +1726,9 @@ discard block |
||
1660 | 1726 | global $context, $scripturl, $boarddir, $smcFunc, $txt; |
1661 | 1727 | |
1662 | 1728 | // @todo Should this be removed? |
1663 | - if (isset($_REQUEST['preview'])) |
|
1664 | - die('die() with fire'); |
|
1729 | + if (isset($_REQUEST['preview'])) { |
|
1730 | + die('die() with fire'); |
|
1731 | + } |
|
1665 | 1732 | |
1666 | 1733 | isAllowedTo('admin_forum'); |
1667 | 1734 | loadTemplate('Themes'); |
@@ -1675,11 +1742,11 @@ discard block |
||
1675 | 1742 | foreach ($context['themes'] as $key => $theme) |
1676 | 1743 | { |
1677 | 1744 | // There has to be a Settings template! |
1678 | - if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) |
|
1679 | - unset($context['themes'][$key]); |
|
1680 | - |
|
1681 | - else |
|
1682 | - $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1745 | + if (!file_exists($theme['theme_dir'] . '/index.template.php') && !file_exists($theme['theme_dir'] . '/css/index.css')) { |
|
1746 | + unset($context['themes'][$key]); |
|
1747 | + } else { |
|
1748 | + $context['themes'][$key]['can_edit_style'] = file_exists($theme['theme_dir'] . '/css/index.css'); |
|
1749 | + } |
|
1683 | 1750 | } |
1684 | 1751 | |
1685 | 1752 | $context['sub_template'] = 'edit_list'; |
@@ -1694,22 +1761,24 @@ discard block |
||
1694 | 1761 | $context['theme_id'] = $currentTheme['id']; |
1695 | 1762 | $context['browse_title'] = sprintf($txt['themeadmin_browsing_theme'], $currentTheme['name']); |
1696 | 1763 | |
1697 | - if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) |
|
1698 | - fatal_lang_error('theme_edit_missing', false); |
|
1764 | + if (!file_exists($currentTheme['theme_dir'] . '/index.template.php') && !file_exists($currentTheme['theme_dir'] . '/css/index.css')) { |
|
1765 | + fatal_lang_error('theme_edit_missing', false); |
|
1766 | + } |
|
1699 | 1767 | |
1700 | 1768 | if (!isset($_REQUEST['filename'])) |
1701 | 1769 | { |
1702 | 1770 | if (isset($_GET['directory'])) |
1703 | 1771 | { |
1704 | - if (substr($_GET['directory'], 0, 1) == '.') |
|
1705 | - $_GET['directory'] = ''; |
|
1706 | - else |
|
1772 | + if (substr($_GET['directory'], 0, 1) == '.') { |
|
1773 | + $_GET['directory'] = ''; |
|
1774 | + } else |
|
1707 | 1775 | { |
1708 | 1776 | $_GET['directory'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_GET['directory']); |
1709 | 1777 | |
1710 | 1778 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_GET['directory']); |
1711 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1712 | - $_GET['directory'] = ''; |
|
1779 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1780 | + $_GET['directory'] = ''; |
|
1781 | + } |
|
1713 | 1782 | } |
1714 | 1783 | } |
1715 | 1784 | |
@@ -1728,37 +1797,39 @@ discard block |
||
1728 | 1797 | 'href' => $scripturl . '?action=admin;area=theme;th=' . $_GET['th'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=edit;directory=' . $temp, |
1729 | 1798 | 'size' => '', |
1730 | 1799 | )); |
1800 | + } else { |
|
1801 | + $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1731 | 1802 | } |
1732 | - else |
|
1733 | - $context['theme_files'] = get_file_listing($currentTheme['theme_dir'], ''); |
|
1734 | 1803 | |
1735 | 1804 | $context['sub_template'] = 'edit_browse'; |
1736 | 1805 | |
1737 | 1806 | return; |
1738 | - } |
|
1739 | - else |
|
1807 | + } else |
|
1740 | 1808 | { |
1741 | - if (substr($_REQUEST['filename'], 0, 1) == '.') |
|
1742 | - $_REQUEST['filename'] = ''; |
|
1743 | - else |
|
1809 | + if (substr($_REQUEST['filename'], 0, 1) == '.') { |
|
1810 | + $_REQUEST['filename'] = ''; |
|
1811 | + } else |
|
1744 | 1812 | { |
1745 | 1813 | $_REQUEST['filename'] = preg_replace(array('~^[\./\\:\0\n\r]+~', '~[\\\\]~', '~/[\./]+~'), array('', '/', '/'), $_REQUEST['filename']); |
1746 | 1814 | |
1747 | 1815 | $temp = realpath($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
1748 | - if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) |
|
1749 | - $_REQUEST['filename'] = ''; |
|
1816 | + if (empty($temp) || substr($temp, 0, strlen(realpath($currentTheme['theme_dir']))) != realpath($currentTheme['theme_dir'])) { |
|
1817 | + $_REQUEST['filename'] = ''; |
|
1818 | + } |
|
1750 | 1819 | } |
1751 | 1820 | |
1752 | - if (empty($_REQUEST['filename'])) |
|
1753 | - fatal_lang_error('theme_edit_missing', false); |
|
1821 | + if (empty($_REQUEST['filename'])) { |
|
1822 | + fatal_lang_error('theme_edit_missing', false); |
|
1823 | + } |
|
1754 | 1824 | } |
1755 | 1825 | |
1756 | 1826 | if (isset($_POST['save'])) |
1757 | 1827 | { |
1758 | 1828 | if (checkSession('post', '', false) == '' && validateToken('admin-te-' . md5($_GET['th'] . '-' . $_REQUEST['filename']), 'post', false) == true) |
1759 | 1829 | { |
1760 | - if (is_array($_POST['entire_file'])) |
|
1761 | - $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1830 | + if (is_array($_POST['entire_file'])) { |
|
1831 | + $_POST['entire_file'] = implode("\n", $_POST['entire_file']); |
|
1832 | + } |
|
1762 | 1833 | |
1763 | 1834 | $_POST['entire_file'] = rtrim(strtr($_POST['entire_file'], array("\r" => '', ' ' => "\t"))); |
1764 | 1835 | |
@@ -1770,10 +1841,11 @@ discard block |
||
1770 | 1841 | fclose($fp); |
1771 | 1842 | |
1772 | 1843 | $error = @file_get_contents($currentTheme['theme_url'] . '/tmp_' . session_id() . '.php'); |
1773 | - if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) |
|
1774 | - $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1775 | - else |
|
1776 | - unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1844 | + if (preg_match('~ <b>(\d+)</b><br( /)?' . '>$~i', $error) != 0) { |
|
1845 | + $error_file = $currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'; |
|
1846 | + } else { |
|
1847 | + unlink($currentTheme['theme_dir'] . '/tmp_' . session_id() . '.php'); |
|
1848 | + } |
|
1777 | 1849 | } |
1778 | 1850 | |
1779 | 1851 | if (!isset($error_file)) |
@@ -1794,10 +1866,11 @@ discard block |
||
1794 | 1866 | $context['sub_template'] = 'edit_file'; |
1795 | 1867 | |
1796 | 1868 | // Recycle the submitted data. |
1797 | - if (is_array($_POST['entire_file'])) |
|
1798 | - $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1799 | - else |
|
1800 | - $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1869 | + if (is_array($_POST['entire_file'])) { |
|
1870 | + $context['entire_file'] = $smcFunc['htmlspecialchars'](implode("\n", $_POST['entire_file'])); |
|
1871 | + } else { |
|
1872 | + $context['entire_file'] = $smcFunc['htmlspecialchars']($_POST['entire_file']); |
|
1873 | + } |
|
1801 | 1874 | |
1802 | 1875 | $context['edit_filename'] = $smcFunc['htmlspecialchars']($_POST['filename']); |
1803 | 1876 | |
@@ -1820,17 +1893,17 @@ discard block |
||
1820 | 1893 | $context['sub_template'] = 'edit_style'; |
1821 | 1894 | |
1822 | 1895 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(file_get_contents($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']), array("\t" => ' '))); |
1823 | - } |
|
1824 | - elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1896 | + } elseif (substr($_REQUEST['filename'], -13) == '.template.php') |
|
1825 | 1897 | { |
1826 | 1898 | $context['sub_template'] = 'edit_template'; |
1827 | 1899 | |
1828 | - if (!isset($error_file)) |
|
1829 | - $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1830 | - else |
|
1900 | + if (!isset($error_file)) { |
|
1901 | + $file_data = file($currentTheme['theme_dir'] . '/' . $_REQUEST['filename']); |
|
1902 | + } else |
|
1831 | 1903 | { |
1832 | - if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) |
|
1833 | - $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1904 | + if (preg_match('~(<b>.+?</b>:.+?<b>).+?(</b>.+?<b>\d+</b>)<br( /)?' . '>$~i', $error, $match) != 0) { |
|
1905 | + $context['parse_error'] = $match[1] . $_REQUEST['filename'] . $match[2]; |
|
1906 | + } |
|
1834 | 1907 | $file_data = file($error_file); |
1835 | 1908 | unlink($error_file); |
1836 | 1909 | } |
@@ -1844,8 +1917,9 @@ discard block |
||
1844 | 1917 | // Try to format the functions a little nicer... |
1845 | 1918 | $context['file_parts'][$j]['data'] = trim($context['file_parts'][$j]['data']) . "\n"; |
1846 | 1919 | |
1847 | - if (empty($context['file_parts'][$j]['lines'])) |
|
1848 | - unset($context['file_parts'][$j]); |
|
1920 | + if (empty($context['file_parts'][$j]['lines'])) { |
|
1921 | + unset($context['file_parts'][$j]); |
|
1922 | + } |
|
1849 | 1923 | $context['file_parts'][++$j] = array('lines' => 0, 'line' => $i + 1, 'data' => ''); |
1850 | 1924 | } |
1851 | 1925 | |
@@ -1854,8 +1928,7 @@ discard block |
||
1854 | 1928 | } |
1855 | 1929 | |
1856 | 1930 | $context['entire_file'] = $smcFunc['htmlspecialchars'](strtr(implode('', $file_data), array("\t" => ' '))); |
1857 | - } |
|
1858 | - else |
|
1931 | + } else |
|
1859 | 1932 | { |
1860 | 1933 | $context['sub_template'] = 'edit_file'; |
1861 | 1934 | |
@@ -1881,8 +1954,9 @@ discard block |
||
1881 | 1954 | |
1882 | 1955 | $_GET['th'] = isset($_GET['th']) ? (int) $_GET['th'] : (int) $_GET['id']; |
1883 | 1956 | |
1884 | - if (empty($_GET['th'])) |
|
1885 | - fatal_lang_error('theme_install_invalid_id'); |
|
1957 | + if (empty($_GET['th'])) { |
|
1958 | + fatal_lang_error('theme_install_invalid_id'); |
|
1959 | + } |
|
1886 | 1960 | |
1887 | 1961 | // Get the theme info. |
1888 | 1962 | $theme = get_single_theme($_GET['th']); |
@@ -1890,25 +1964,24 @@ discard block |
||
1890 | 1964 | |
1891 | 1965 | if (isset($_REQUEST['template']) && preg_match('~[\./\\\\:\0]~', $_REQUEST['template']) == 0) |
1892 | 1966 | { |
1893 | - if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) |
|
1894 | - $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1895 | - |
|
1896 | - else |
|
1897 | - fatal_lang_error('no_access', false); |
|
1967 | + if (file_exists($settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php')) { |
|
1968 | + $filename = $settings['default_theme_dir'] . '/' . $_REQUEST['template'] . '.template.php'; |
|
1969 | + } else { |
|
1970 | + fatal_lang_error('no_access', false); |
|
1971 | + } |
|
1898 | 1972 | |
1899 | 1973 | $fp = fopen($theme['theme_dir'] . '/' . $_REQUEST['template'] . '.template.php', 'w'); |
1900 | 1974 | fwrite($fp, file_get_contents($filename)); |
1901 | 1975 | fclose($fp); |
1902 | 1976 | |
1903 | 1977 | redirectexit('action=admin;area=theme;th=' . $context['theme_id'] . ';' . $context['session_var'] . '=' . $context['session_id'] . ';sa=copy'); |
1904 | - } |
|
1905 | - elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1978 | + } elseif (isset($_REQUEST['lang_file']) && preg_match('~^[^\./\\\\:\0]\.[^\./\\\\:\0]$~', $_REQUEST['lang_file']) != 0) |
|
1906 | 1979 | { |
1907 | - if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) |
|
1908 | - $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1909 | - |
|
1910 | - else |
|
1911 | - fatal_lang_error('no_access', false); |
|
1980 | + if (file_exists($settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php')) { |
|
1981 | + $filename = $settings['default_theme_dir'] . '/languages/' . $_REQUEST['template'] . '.php'; |
|
1982 | + } else { |
|
1983 | + fatal_lang_error('no_access', false); |
|
1984 | + } |
|
1912 | 1985 | |
1913 | 1986 | $fp = fopen($theme['theme_dir'] . '/languages/' . $_REQUEST['lang_file'] . '.php', 'w'); |
1914 | 1987 | fwrite($fp, file_get_contents($filename)); |
@@ -1923,16 +1996,18 @@ discard block |
||
1923 | 1996 | $dir = dir($settings['default_theme_dir']); |
1924 | 1997 | while ($entry = $dir->read()) |
1925 | 1998 | { |
1926 | - if (substr($entry, -13) == '.template.php') |
|
1927 | - $templates[] = substr($entry, 0, -13); |
|
1999 | + if (substr($entry, -13) == '.template.php') { |
|
2000 | + $templates[] = substr($entry, 0, -13); |
|
2001 | + } |
|
1928 | 2002 | } |
1929 | 2003 | $dir->close(); |
1930 | 2004 | |
1931 | 2005 | $dir = dir($settings['default_theme_dir'] . '/languages'); |
1932 | 2006 | while ($entry = $dir->read()) |
1933 | 2007 | { |
1934 | - if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) |
|
1935 | - $lang_files[] = $matches[1]; |
|
2008 | + if (preg_match('~^([^\.]+\.[^\.]+)\.php$~', $entry, $matches)) { |
|
2009 | + $lang_files[] = $matches[1]; |
|
2010 | + } |
|
1936 | 2011 | } |
1937 | 2012 | $dir->close(); |
1938 | 2013 | |
@@ -1940,21 +2015,23 @@ discard block |
||
1940 | 2015 | natcasesort($lang_files); |
1941 | 2016 | |
1942 | 2017 | $context['available_templates'] = array(); |
1943 | - foreach ($templates as $template) |
|
1944 | - $context['available_templates'][$template] = array( |
|
2018 | + foreach ($templates as $template) { |
|
2019 | + $context['available_templates'][$template] = array( |
|
1945 | 2020 | 'filename' => $template . '.template.php', |
1946 | 2021 | 'value' => $template, |
1947 | 2022 | 'already_exists' => false, |
1948 | 2023 | 'can_copy' => is_writable($theme['theme_dir']), |
1949 | 2024 | ); |
2025 | + } |
|
1950 | 2026 | $context['available_language_files'] = array(); |
1951 | - foreach ($lang_files as $file) |
|
1952 | - $context['available_language_files'][$file] = array( |
|
2027 | + foreach ($lang_files as $file) { |
|
2028 | + $context['available_language_files'][$file] = array( |
|
1953 | 2029 | 'filename' => $file . '.php', |
1954 | 2030 | 'value' => $file, |
1955 | 2031 | 'already_exists' => false, |
1956 | 2032 | 'can_copy' => file_exists($theme['theme_dir'] . '/languages') ? is_writable($theme['theme_dir'] . '/languages') : is_writable($theme['theme_dir']), |
1957 | 2033 | ); |
2034 | + } |
|
1958 | 2035 | |
1959 | 2036 | $dir = dir($theme['theme_dir']); |
1960 | 2037 | while ($entry = $dir->read()) |