albertlast / SMF2.1

Sources/Subs.php

Spacing +42 added lines, -42 removed lines

@@ -379,7 +379,7 @@ 
 			{
 				$val = 'CASE ';
 				foreach ($members as $k => $v)
-					$val .= 'WHEN id_member = ' . $v . ' THEN '. alert_count($v, true) . ' ';
+					$val .= 'WHEN id_member = ' . $v . ' THEN ' . alert_count($v, true) . ' ';
 
 				$val = $val . ' END';
 				$type = 'raw';
@@ -851,12 +851,12 @@ 
 			// Anything that isn't a specification, punctuation mark, or whitespace.
 			'~(?<!%)\p{L}|[^\p{L}\p{P}\s]~u',
 			// Repeated punctuation marks (except %), possibly separated by whitespace.
-			'~(?'.'>([^%\P{P}])\s*(?=\1))*~u',
-			'~([^%\P{P}])(?'.'>\1(?!$))*~u',
+			'~(?' . '>([^%\P{P}])\s*(?=\1))*~u',
+			'~([^%\P{P}])(?' . '>\1(?!$))*~u',
 			// Unwanted trailing punctuation and whitespace.
-			'~(?'.'>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
+			'~(?' . '>([\p{Pd}\p{Ps}\p{Pi}\p{Pc}]|[^%\P{Po}])\s*)*$~u',
 			// Unwanted opening punctuation and whitespace.
-			'~^\s*(?'.'>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
+			'~^\s*(?' . '>([\p{Pd}\p{Pe}\p{Pf}\p{Pc}]|[^%\P{Po}])\s*)*~u',
 			// Runs of horizontal whitespace.
 			'~\s+~',
 		),
@@ -1163,7 +1163,7 @@ 
 	{
 		$dates[$tzid . '_' . $timestamp]['results'][$format] = preg_replace_callback(
 			'/\xEE\x84\xA0([\d_]+)(\xEE\x84(?:[\xA1-\xAF]))/',
-			function ($matches)
+			function($matches)
 			{
 				switch ($matches[2])
 				{
@@ -1297,7 +1297,7 @@ 
 	elseif (!empty($context['character_set']) && is_callable('mb_decode_numericentity'))
 	{
 		// Get whatever the default replacement character is for this encoding.
-		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD,0xFFFD,0,0xFFFF), $context['character_set']);
+		$substitute = mb_decode_numericentity('&#xFFFD;', array(0xFFFD, 0xFFFD, 0, 0xFFFF), $context['character_set']);
 	}
 	else
 		$substitute = '?';
@@ -1747,7 +1747,7 @@ 
 
 					// parseAttachBBC will return a string ($txt key) rather than dying with a fatal_error. Up to you to decide what to do.
 					if (is_string($currentAttachment))
-						return $data = '<span style="display:inline-block" class="errorbox">' . (!empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment)  . '</span>';
+						return $data = '<span style="display:inline-block" class="errorbox">' . (!empty($txt[$currentAttachment]) ? $txt[$currentAttachment] : $currentAttachment) . '</span>';
 
 					// We need a display mode.
 					if (empty($params['{display}']))
@@ -1773,7 +1773,7 @@ 
 								$returnContext .= '<img src="' . $currentAttachment['href'] . '"' . $alt . $title . ' class="bbc_img">';
 							else
 							{
-								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"': '';
+								$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
 								$height = !empty($params['{height}']) ? 'height="' . $params['{height}'] . '"' : '';
 								$returnContext .= '<img src="' . $currentAttachment['href'] . ';image"' . $alt . $title . $width . $height . ' class="bbc_img resized"/>';
 							}
@@ -1784,7 +1784,7 @@ 
 							$width = !empty($params['{width}']) ? ' width="' . $params['{width}'] . '"' : '';
 							$height = !empty($params['{height}']) ? ' height="' . $params['{height}'] . '"' : '';
 
-							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="'. $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
+							$returnContext .= '<div class="videocontainer"><video controls preload="metadata" src="' . $currentAttachment['href'] . '" playsinline' . $width . $height . '><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></video></div>' . (!empty($data) && $data != $currentAttachment['name'] ? '<div class="smalltext">' . $data . '</div>' : '');
 						}
 						// Audio.
 						elseif (strpos($currentAttachment['mime_type'], 'audio/') === 0)
@@ -1792,7 +1792,7 @@ 
 							$width = 'max-width:100%; width: ' . (!empty($params['{width}']) ? $params['{width}'] : '400') . 'px;';
 							$height = !empty($params['{height}']) ? 'height: ' . $params['{height}'] . 'px;' : '';
 
-							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="'. $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
+							$returnContext .= (!empty($data) && $data != $currentAttachment['name'] ? $data . ' ' : '') . '<audio controls preload="none" src="' . $currentAttachment['href'] . '" class="bbc_audio" style="vertical-align:middle;' . $width . $height . '"><a href="' . $currentAttachment['href'] . '" class="bbc_link">' . $smcFunc['htmlspecialchars'](!empty($data) ? $data : $currentAttachment['name']) . '</a></audio>';
 						}
 						// Anything else.
 						else
@@ -1961,7 +1961,7 @@ 
 				'type' => 'unparsed_commas_content',
 				'test' => '\d+,\d+\]',
 				'content' => '<a href="$1" target="_blank" rel="noopener">$1</a>',
-				'validate' => function (&$tag, &$data, $disabled)
+				'validate' => function(&$tag, &$data, $disabled)
 				{
 					$data[0] = normalize_iri(strtr(trim($data[0]), array('<br>' => '', ' ' => '%20')));
 
@@ -2087,8 +2087,8 @@ 
 					else
 						$url = get_proxied_url($url);
 
-					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}']. '"' : ' alt=""';
-					$title = !empty($params['{title}']) ? ' title="' . $params['{title}']. '"' : '';
+					$alt = !empty($params['{alt}']) ? ' alt="' . $params['{alt}'] . '"' : ' alt=""';
+					$title = !empty($params['{title}']) ? ' title="' . $params['{title}'] . '"' : '';
 
 					$data = isset($disabled[$tag['tag']]) ? $url : '<img src="' . $url . '"' . $alt . $title . $params['{width}'] . $params['{height}'] . ' class="bbc_img' . (!empty($params['{width}']) || !empty($params['{height}']) ? ' resized' : '') . '" loading="lazy">';
 				},
@@ -2526,12 +2526,12 @@ 
 		$codes[] = array(
 			'tag' => 'cowsay',
 			'parameters' => array(
-				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function ($eyes) use ($smcFunc)
+				'e' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => 'oo', 'validate' => function($eyes) use ($smcFunc)
 					{
 						return $smcFunc['substr']($eyes . 'oo', 0, 2);
 					},
 				),
-				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function ($tongue) use ($smcFunc)
+				't' => array('optional' => true, 'quoted' => true, 'match' => '(.*?)', 'default' => '  ', 'validate' => function($tongue) use ($smcFunc)
 					{
 						return $smcFunc['substr']($tongue . '  ', 0, 2);
 					},
@@ -4236,7 +4236,7 @@ 
 		if ($fp != false)
 		{
 			// Send the HEAD request (since we don't have to worry about chunked, HTTP/1.1 is fine here.)
-			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: '. SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
+			fwrite($fp, 'HEAD /' . $match[2] . ' HTTP/1.1' . "\r\n" . 'Host: ' . $match[1] . "\r\n" . 'user-agent: ' . SMF_USER_AGENT . "\r\n" . 'Connection: close' . "\r\n\r\n");
 
 			// Read in the HTTP/1.1 or whatever.
 			$test = substr(fgets($fp, 11), -1);
@@ -4832,7 +4832,7 @@ 
 
 	uasort(
 		$context['css_files'],
-		function ($a, $b)
+		function($a, $b)
 		{
 			return $a['options']['order_pos'] < $b['options']['order_pos'] ? -1 : ($a['options']['order_pos'] > $b['options']['order_pos'] ? 1 : 0);
 		}
@@ -6152,7 +6152,7 @@ 
 			{
 				fwrite($fp, 'GET ' . ($match[6] !== '/' ? str_replace(' ', '%20', $match[6]) : '') . ' HTTP/1.0' . "\r\n");
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
 				if ($keep_alive)
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n\r\n");
 				else
@@ -6162,7 +6162,7 @@ 
 			{
 				fwrite($fp, 'POST ' . ($match[6] !== '/' ? $match[6] : '') . ' HTTP/1.0' . "\r\n");
 				fwrite($fp, 'Host: ' . $match[3] . (empty($match[5]) ? ($match[2] ? ':443' : '') : ':' . $match[5]) . "\r\n");
-				fwrite($fp, 'user-agent: '. SMF_USER_AGENT . "\r\n");
+				fwrite($fp, 'user-agent: ' . SMF_USER_AGENT . "\r\n");
 				if ($keep_alive)
 					fwrite($fp, 'connection: Keep-Alive' . "\r\n");
 				else
@@ -6411,13 +6411,13 @@ 
 
 	// UTF-8 occurences of MS special characters
 	$findchars_utf8 = array(
-		"\xe2\x80\x9a",	// single low-9 quotation mark
-		"\xe2\x80\x9e",	// double low-9 quotation mark
-		"\xe2\x80\xa6",	// horizontal ellipsis
-		"\xe2\x80\x98",	// left single curly quote
-		"\xe2\x80\x99",	// right single curly quote
-		"\xe2\x80\x9c",	// left double curly quote
-		"\xe2\x80\x9d",	// right double curly quote
+		"\xe2\x80\x9a", // single low-9 quotation mark
+		"\xe2\x80\x9e", // double low-9 quotation mark
+		"\xe2\x80\xa6", // horizontal ellipsis
+		"\xe2\x80\x98", // left single curly quote
+		"\xe2\x80\x99", // right single curly quote
+		"\xe2\x80\x9c", // left double curly quote
+		"\xe2\x80\x9d", // right double curly quote
 	);
 
 	// windows 1252 / iso equivalents
@@ -6433,13 +6433,13 @@ 
 
 	// safe replacements
 	$replacechars = array(
-		',',	// &sbquo;
-		',,',	// &bdquo;
-		'...',	// &hellip;
-		"'",	// &lsquo;
-		"'",	// &rsquo;
-		'"',	// &ldquo;
-		'"',	// &rdquo;
+		',', // &sbquo;
+		',,', // &bdquo;
+		'...', // &hellip;
+		"'", // &lsquo;
+		"'", // &rsquo;
+		'"', // &ldquo;
+		'"', // &rdquo;
 	);
 
 	if ($context['utf8'])
@@ -6802,7 +6802,7 @@ 
 		// We don't want abbreviations like '+03' or '-11'.
 		$abbrs = array_filter(
 			$tzvalue['abbrs'],
-			function ($abbr)
+			function($abbr)
 			{
 				return !strspn($abbr, '+-');
 			}
@@ -7791,7 +7791,7 @@ 
 			EXISTS (
 				SELECT bpv.id_board
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
-				WHERE bpv.id_group IN ('. implode(',', $groups) .')
+				WHERE bpv.id_group IN ('. implode(',', $groups) . ')
 					AND bpv.deny = 0
 					AND bpv.id_board = b.id_board
 			)';
@@ -7801,7 +7801,7 @@ 
 			AND NOT EXISTS (
 				SELECT bpv.id_board
 				FROM ' . $db_prefix . 'board_permissions_view AS bpv
-				WHERE bpv.id_group IN ( '. implode(',', $groups) .')
+				WHERE bpv.id_group IN ( '. implode(',', $groups) . ')
 					AND bpv.deny = 1
 					AND bpv.id_board = b.id_board
 			)';
@@ -8214,8 +8214,8 @@ 
 	$i = 0;
 	while (empty($done))
 	{
-		if (strpos($format, '{'. --$i . '}') !== false)
-			$replacements['{'. $i . '}'] = array_pop($list);
+		if (strpos($format, '{' . --$i . '}') !== false)
+			$replacements['{' . $i . '}'] = array_pop($list);
 		else
 			$done = true;
 	}
@@ -8225,8 +8225,8 @@ 
 	$i = 0;
 	while (empty($done))
 	{
-		if (strpos($format, '{'. ++$i . '}') !== false)
-			$replacements['{'. $i . '}'] = array_shift($list);
+		if (strpos($format, '{' . ++$i . '}') !== false)
+			$replacements['{' . $i . '}'] = array_shift($list);
 		else
 			$done = true;
 	}
@@ -8407,7 +8407,7 @@ 
 	if (empty($stringSubject))
 		return '';
 
-	$translatable_tokens = preg_match_all('/{(.*?)}/' , $stringSubject, $matches);
+	$translatable_tokens = preg_match_all('/{(.*?)}/', $stringSubject, $matches);
 	$toFind = array();
 	$replaceWith = array();
 

Sources/Subs-Db-postgresql.php

Spacing +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
 		display_db_error();
 
 	// We need to escape ' and \
-	$db_passwd = str_replace(array('\\','\''), array('\\\\','\\\''), $db_passwd);
+	$db_passwd = str_replace(array('\\', '\''), array('\\\\', '\\\''), $db_passwd);
 
 	// Since pg_connect doesn't feed error info to pg_last_error, we have to catch issues with a try/catch.
 	set_error_handler(
@@ -926,7 +926,7 @@ 
 	if (!empty($inTransaction))
 		smf_db_transaction('rollback');
 
-	if(empty($db_persist))
+	if (empty($db_persist))
 	{ // without pooling
 		if (empty($pg_error_data_prep))
 			$pg_error_data_prep = pg_prepare($db_connection, 'smf_log_errors',

Sources/Class-Punycode.php

Spacing +2 added lines, -2 removed lines

@@ -241,7 +241,7 @@ 
 				}
 				if ($c === $n) {
 					$q = $delta;
-					for ($k = static::BASE;; $k += static::BASE) {
+					for ($k = static::BASE; ; $k += static::BASE) {
 						$t = $this->calculateThreshold($k, $bias);
 						if ($q < $t) {
 							break;
@@ -344,7 +344,7 @@ 
 			$oldi = $i;
 			$w = 1;
 
-			for ($k = static::BASE;; $k += static::BASE)
+			for ($k = static::BASE; ; $k += static::BASE)
 			{
 				if (!isset($input[$pos]) || !isset(static::$decodeTable[$input[$pos]]))
 					return false;

Sources/Errors.php

Spacing +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
 
 	// Send a custom header if we have a custom message.
 	if (isset($_REQUEST['js']) || isset($_REQUEST['xml']) || isset($_RQEUEST['ajax']))
-		header('X-SMF-errormsg: ' .  $error_message);
+		header('X-SMF-errormsg: ' . $error_message);
 
 	// If we have no theme stuff we can't have the language file...
 	if (empty($context['theme_loaded']))

Sources/ManageMaintenance.php

Spacing +2 added lines, -2 removed lines

@@ -2065,7 +2065,7 @@ 
 		new RecursiveIteratorIterator(
 			new RecursiveCallbackFilterIterator(
 				new RecursiveDirectoryIterator($dirname, FilesystemIterator::UNIX_PATHS),
-				function ($fileInfo, $currentFile, $iterator)
+				function($fileInfo, $currentFile, $iterator)
 				{
 					// Allow recursion
 					if ($iterator->hasChildren())
@@ -2112,7 +2112,7 @@ 
 			$hookParsedData = parse_integration_hook($hook, $rawFunc);
 
 			// Handle hooks pointing outside the sources directory.
-			$absPath_clean =  rtrim($hookParsedData['absPath'], '!');
+			$absPath_clean = rtrim($hookParsedData['absPath'], '!');
 			if ($absPath_clean != '' && !isset($files[$absPath_clean]) && file_exists($absPath_clean))
 				$function_list += get_defined_functions_in_file($absPath_clean);
 

Sources/Subs-Charset.php

Spacing +6 added lines, -6 removed lines

@@ -549,7 +549,7 @@ 
 	$combining_classes = utf8_combining_classes();
 
 	// Replace characters with decomposed forms.
-	for ($i=0; $i < count($chars); $i++)
+	for ($i = 0; $i < count($chars); $i++)
 	{
 		// Hangul characters.
 		// See "Hangul Syllable Decomposition" in the Unicode standard, ch. 3.12.
@@ -584,7 +584,7 @@ 
 		{
 			$temp = $chars[$i];
 			$chars[$i] = $chars[$i - 1];
-			$chars[$i -1] = $temp;
+			$chars[$i - 1] = $temp;
 
 			// Backtrack and check again.
 			if ($i > 1)
@@ -824,7 +824,7 @@ 
 
 	// Use placeholders to preserve known emoji from further processing.
 	// Regex source is https://unicode.org/reports/tr51/#EBNF_and_Regex
-	$string  = preg_replace_callback(
+	$string = preg_replace_callback(
 		'/' .
 		// Flag emojis
 		'[' . $prop_classes['Regional_Indicator'] . ']{2}' .
@@ -853,7 +853,7 @@ 
 			')?' .
 		')*' .
 		'/u',
-		function ($matches) use (&$placeholders)
+		function($matches) use (&$placeholders)
 		{
 			// Skip lone ASCII characters that are not actully part of an emoji sequence.
 			// This can happen because the digits 0-9 and the '*' and '#' characters are
@@ -884,7 +884,7 @@ 
 		// Use placeholders for sanctioned variation selectors.
 		$string = preg_replace_callback(
 			$patterns,
-			function ($matches) use (&$placeholders)
+			function($matches) use (&$placeholders)
 			{
 				$placeholders[$matches[0]] = "\xEE\xB3\x9B" . md5($matches[0]) . "\xEE\xB3\x9C";
 				return $placeholders[$matches[0]];
@@ -964,7 +964,7 @@ 
 			// Do the thing.
 			$string = preg_replace_callback(
 				'/' . $pattern . '/u',
-				function ($matches) use ($placeholders)
+				function($matches) use ($placeholders)
 				{
 					return strtr($matches[0], $placeholders);
 				},

Sources/tasks/UpdateUnicode.php

Spacing +4 added lines, -4 removed lines

@@ -416,7 +416,7 @@ 
 		if (!@touch($this->temp_dir . DIRECTORY_SEPARATOR . 'lock'))
 			return true;
 
-		register_shutdown_function(function () {
+		register_shutdown_function(function() {
 			if (file_exists($this->temp_dir . DIRECTORY_SEPARATOR . 'lock'))
 				unlink($this->temp_dir . DIRECTORY_SEPARATOR . 'lock');
 		});
@@ -902,7 +902,7 @@ 
 					$func_code = rtrim($func_code);
 
 					$func_code .= $nextline . implode(' .' . $nextline, array_map(
-						function ($v)
+						function($v)
 						{
 							return var_export($v, true);
 						},
@@ -1833,7 +1833,7 @@ 
 			}
 		}
 		// This sort works decently well to ensure widely used scripts are ranked before rare scripts.
-		uasort($this->funcs['utf8_regex_joining_type']['data'], function ($a, $b)
+		uasort($this->funcs['utf8_regex_joining_type']['data'], function($a, $b)
 		{
 			if ($a['stats']['age'] == $b['stats']['age'])
 			{
@@ -1921,7 +1921,7 @@ 
 			}
 		}
 		// Again, sort commonly used scripts before rare scripts.
-		uasort($this->funcs['utf8_regex_indic']['data'], function ($a, $b)
+		uasort($this->funcs['utf8_regex_indic']['data'], function($a, $b)
 		{
 			if ($a['stats']['age'] == $b['stats']['age'])
 			{

Sources/Reports.php

Spacing +1 added lines, -1 removed lines

@@ -419,7 +419,7 @@
 
 	$board_names = array_reduce(
 		$boards,
-		function (array $accumulator, array $board)
+		function(array $accumulator, array $board)
 		{
 			$accumulator[$board['profile']][] = $board['name'];
 

Sources/Session.php

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
 	 * @return boolean Whether the info was successfully written
 	 */
 	#[\ReturnTypeWillChange]
-	public function write(/*PHP 8.0 string*/$id,/*PHP 8.0 string */ $data): bool
+	public function write(/*PHP 8.0 string*/$id, /*PHP 8.0 string */ $data): bool
 	{
 		global $smcFunc;