View GitHub Repository SMF2.1

Schedule Inspection
Subscribe

Code Duplication    Length = 2-2 lines in 2 locations

Sources/ManageSmileys.php 2 locations

@@ 618-619 (lines=2) @@
615 
			$_FILES['uploadSmiley']['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['uploadSmiley']['name']);
616 

                                

                                                            

                                    617
                                    
                                    
			// We only allow image files - it's THAT simple - no messing around here...

                                

                                                            

                                    618
                                    
                                    
			if (!in_array(strtolower(substr(strrchr($_FILES['uploadSmiley']['name'], '.'), 1)), $allowedTypes))

                                

                                                            

                                    619
                                    
                                    
				fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes)));

                                

                                                            

                                    620
                                    
                                    

                                

                                                            

                                    621
                                    
                                    
			// We only need the filename...

                                

                                                            

                                    622
                                    
                                    
			$destName = basename($_FILES['uploadSmiley']['name']);

                                

                                                                                

                                
                                
                                    @@ 690-691 (lines=2) @@
                                
                            


                                                            

                                    687
                                    
                                    
				$_FILES['individual_' . $set['name']]['name'] = preg_replace(array('/\s/', '/\.[\.]+/', '/[^\w_\.\-]/'), array('_', '.', ''), $_FILES['individual_' . $set['name']]['name']);

                                

                                                            

                                    688
                                    
                                    

                                

                                                            

                                    689
                                    
                                    
				// We only allow image files - it's THAT simple - no messing around here...

                                

                                                            

                                    690
                                    
                                    
				if (!in_array(strtolower(substr(strrchr($_FILES['individual_' . $set['name']]['name'], '.'), 1)), $allowedTypes))

                                

                                                            

                                    691
                                    
                                    
					fatal_lang_error('smileys_upload_error_types', false, array(implode(', ', $allowedTypes)));

                                

                                                            

                                    692
                                    
                                    

                                

                                                            

                                    693
                                    
                                    
				// We only need the filename...

                                

                                                            

                                    694
                                    
                                    
				$destName = basename($_FILES['individual_' . $set['name']]['name']);