SMSMessenger::sendMessage() - Code Metrics - Inspection of "ATS-263" - alaninchika/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1)

by Alan

created 2018-11-07 11:50 UTC

SMSMessenger::sendMessage() A

↳ Parent: SMSMessenger

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	12
nc	3
nop	2
dl	0
loc	22
rs	9.8666
c	0
b	0
f	0

<?php

namespace Messenger;

use Messenger\SMSProviders\SMSProvider;

class SMSMessenger extends Messenger
{
    /**
     * Sends an sms message with a given provider if they have been registered.
     *
     * @param string $providerName
     * @param string $to
     * @param string $message
     * @return array
     */
    public function sendMessageWith(string $providerName, string $to, string $message)
    {
        $result = array(
            'provider' => $providerName,
            'result' => [
                'sent' => false
            ]
        );

        if (isset($this->smsProviders[$providerName])) {
            $provider = $this->smsProviders[$providerName];

            if (!$provider->isValid()) {
                $result['result']['error'] = 'Invalid credentials';
                return $result;
            }

            $result['result'] = $provider->send($to, $message);
        }

        return $result;
    }

    /**
     * Sends an sms message.
     *
     * @param string $to
     * @param string $message
     * @return array
     */
    public function sendMessage(string $to, string $message)
    {
        $result = array(
            'provider' => 'Empty providers',
            'result' => [
                'sent' => false
            ]
        );

        foreach ($this->smsProviders() as $name => $provider) {
            $result['provider'] = $name;

            if (!$provider->isValid()) {
                $result['result']['error'] = 'Invalid credentials';
            } else {
                $result['result'] = $provider->send($to, $message);
            }

            return $result;
        }

        return $result;
    }

    /**
     * Returns all sms providers.
     *
     * @return SMSProvider[]
     */
    public function smsProviders()
    {
        return $this->smsProviders;
    }
}

1			<?php
2
3			namespace Messenger;
4
5			use Messenger\SMSProviders\SMSProvider;
6
7			class SMSMessenger extends Messenger
8			{
9			/**
10			* Sends an sms message with a given provider if they have been registered.
11			*
12			* @param string $providerName
13			* @param string $to
14			* @param string $message
15			* @return array
16			*/
17			public function sendMessageWith(string $providerName, string $to, string $message)
18			{
19			$result = array(
20			'provider' => $providerName,
21			'result' => [
22			'sent' => false
23			]
24			);
25
26			if (isset($this->smsProviders[$providerName])) {
27			$provider = $this->smsProviders[$providerName];
28
29			if (!$provider->isValid()) {
30			$result['result']['error'] = 'Invalid credentials';
31			return $result;
32			}
33
34			$result['result'] = $provider->send($to, $message);
35			}
36
37			return $result;
38			}
39
40			/**
41			* Sends an sms message.
42			*
43			* @param string $to
44			* @param string $message
45			* @return array
46			*/
47			public function sendMessage(string $to, string $message)
48			{
49			$result = array(
50			'provider' => 'Empty providers',
51			'result' => [
52			'sent' => false
53			]
54			);
55
56			foreach ($this->smsProviders() as $name => $provider) {
57			$result['provider'] = $name;
58
59			if (!$provider->isValid()) {
60			$result['result']['error'] = 'Invalid credentials';
61			} else {
62			$result['result'] = $provider->send($to, $message);
63			}
64
65			return $result;
66			}
67
68			return $result;
69			}
70
71			/**
72			* Returns all sms providers.
73			*
74			* @return SMSProvider[]
75			*/
76			public function smsProviders()
77			{
78			return $this->smsProviders;
79			}
80			}

alaninchika / messenger

Pull Request — master (#1)

SMSMessenger::sendMessage() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like