akubiczek / applicake-backend

app/Utils/SourceCreator.php

<?php

namespace App\Utils;

use App\Models\Source;
use Illuminate\Support\Str;

class SourceCreator
{
    const SOURCE_KEY_MAXLENGTH = 6;

    public static function create(array $data): Source
    {
        $source = new Source();
        $source->name = $data['name'];
        $source->recruitment_id = $data['recruitment_id'];

The property recruitment_id does not exist on App\Models\Source. Did you mean recruitment?

        $source->key = self::generateKey();
        $source->save();

        return Source::find($source->id);

The expression return App\Models\Source::find($source->id) could return the type null which is incompatible with the type-hinted return App\Models\Source. Consider adding an additional type-check to rule them out.

    }

    private static function generateKey()
    {
        do {
            $key = strtoupper(Str::random(self::SOURCE_KEY_MAXLENGTH));

The method random() does not exist on Illuminate\Support\Str.

            $sources = Source::where('key', $key)->count();
        } while ($sources > 0);

        return $key;
    }
}