HttpClient::setClient() - Code Metrics - Inspection of "Refactor code and add Unit Tests for \Rundeck\Reso..." - akramfares/rundeck-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc864c...f8b489 )

by Akram

created 2017-05-06 13:26 UTC

HttpClient::setClient() A

↳ Parent: HttpClient

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Rundeck;

class HttpClient
{

    private $client;
    private $endpoint;
    private $authToken;
    private $version;

    public function setAuth($endpoint, $authToken, $version)
    {
        $this->endpoint = trim($endpoint, "/");
        $this->authToken = $authToken;
        $this->version = $version;
    }

    public function getClient()
    {
        if (isset($this->client)) {
            return $this->client;
        } else {
            $this->client = new \GuzzleHttp\Client();
            return $this->client;
        }
    }

    /**
     * @param mixed $client
     */
    public function setClient($client)
    {
        $this->client = $client;
    }

    public function get($uri, $alt)
    {
        $options = ['headers'=> ['Accept' => 'application/xml']];

        if ($alt == "json") {
            $options = ['headers'=> ['Accept' => 'application/json']];
        }
        $uri = $this->endpoint. "/api/". $this->version .$uri."?authtoken=".$this->authToken;

        $response = $this->getClient()->request('GET', $uri, $options);
        $xml = simplexml_load_string($response->getBody());
        $json = json_encode($xml);
        $data = json_decode($json, true);

        //echo $response->getBody(); die();

        return $data;
    }
}


1		<?php
2
3		namespace Rundeck;
4
5		class HttpClient
6		{
7
8		private $client;
9		private $endpoint;
10		private $authToken;
11		private $version;
12
13		public function setAuth($endpoint, $authToken, $version)
14		{
15		$this->endpoint = trim($endpoint, "/");
16		$this->authToken = $authToken;
17		$this->version = $version;
18		}
19
20	15	public function getClient()
21		{
22	15	if (isset($this->client)) {
23	15	return $this->client;
24		} else {
25		$this->client = new \GuzzleHttp\Client();
26		return $this->client;
27		}
28		}
29
30		/**
31		* @param mixed $client
32		*/
33	15	public function setClient($client)
34		{
35	15	$this->client = $client;
36	15	}
37
38	15	public function get($uri, $alt)
39		{
40	15	$options = ['headers'=> ['Accept' => 'application/xml']];
41
42	15	if ($alt == "json") {
43		$options = ['headers'=> ['Accept' => 'application/json']];
44		}
45	15	$uri = $this->endpoint. "/api/". $this->version .$uri."?authtoken=".$this->authToken;
46
47	15	$response = $this->getClient()->request('GET', $uri, $options);
48	15	$xml = simplexml_load_string($response->getBody());
49	15	$json = json_encode($xml);
50	15	$data = json_decode($json, true);
51
52		//echo $response->getBody(); die();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-06 13:29 UTC by Report Bug Copy Issue Report `77%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53	15	return $data;
54		}
55		}
56

akramfares / rundeck-sdk-php

Push — master ( cc864c...f8b489 )

HttpClient::setClient() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like