Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class DownloadSpec extends ObjectBehavior |
||
13 | { |
||
14 | public function let(Client $client, HttpClient $http) |
||
21 | |||
22 | public function it_should_be_an_api() |
||
26 | |||
27 | public function it_has_a_package_with_all_languages() |
||
32 | |||
33 | public function it_has_a_package_with_one_language() |
||
38 | |||
39 | public function it_has_a_copy_destination() |
||
44 | |||
45 | View Code Duplication | public function it_downloads_all_translations(HttpClient $http, Request $request, Response $response) |
|
53 | |||
54 | View Code Duplication | public function it_downloads_french_translations(HttpClient $http, Request $request, Response $response) |
|
62 | } |
||
63 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.