| Conditions | 24 |
| Paths | 24 |
| Total Lines | 76 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 132 | protected function getErrorMessage($errorCode) |
||
| 133 | { |
||
| 134 | switch ($errorCode) { |
||
| 135 | case \ZipArchive::ER_MULTIDISK: |
||
| 136 | return 'Multi-disk zip archives not supported'; |
||
| 137 | |||
| 138 | case \ZipArchive::ER_RENAME: |
||
| 139 | return 'Renaming temporary file failed'; |
||
| 140 | |||
| 141 | case \ZipArchive::ER_CLOSE: |
||
| 142 | return 'Closing zip archive failed'; |
||
| 143 | |||
| 144 | case \ZipArchive::ER_SEEK: |
||
| 145 | return 'Seek error'; |
||
| 146 | |||
| 147 | case \ZipArchive::ER_READ: |
||
| 148 | return 'Read error'; |
||
| 149 | |||
| 150 | case \ZipArchive::ER_WRITE: |
||
| 151 | return 'Write error'; |
||
| 152 | |||
| 153 | case \ZipArchive::ER_CRC: |
||
| 154 | return 'CRC error'; |
||
| 155 | |||
| 156 | case \ZipArchive::ER_ZIPCLOSED: |
||
| 157 | return 'Containing zip archive was closed'; |
||
| 158 | |||
| 159 | case \ZipArchive::ER_NOENT: |
||
| 160 | return 'No such file'; |
||
| 161 | |||
| 162 | case \ZipArchive::ER_EXISTS: |
||
| 163 | return 'File already exists'; |
||
| 164 | |||
| 165 | case \ZipArchive::ER_OPEN: |
||
| 166 | return 'Can\'t open file'; |
||
| 167 | |||
| 168 | case \ZipArchive::ER_TMPOPEN: |
||
| 169 | return 'Failure to create temporary file'; |
||
| 170 | |||
| 171 | case \ZipArchive::ER_ZLIB: |
||
| 172 | return 'Zlib error'; |
||
| 173 | |||
| 174 | case \ZipArchive::ER_MEMORY: |
||
| 175 | return 'Malloc failure'; |
||
| 176 | |||
| 177 | case \ZipArchive::ER_CHANGED: |
||
| 178 | return 'Entry has been changed'; |
||
| 179 | |||
| 180 | case \ZipArchive::ER_COMPNOTSUPP: |
||
| 181 | return 'Compression method not supported'; |
||
| 182 | |||
| 183 | case \ZipArchive::ER_EOF: |
||
| 184 | return 'Premature EOF'; |
||
| 185 | |||
| 186 | case \ZipArchive::ER_INVAL: |
||
| 187 | return 'Invalid argument'; |
||
| 188 | |||
| 189 | case \ZipArchive::ER_NOZIP: |
||
| 190 | return 'Not a zip archive'; |
||
| 191 | |||
| 192 | case \ZipArchive::ER_INTERNAL: |
||
| 193 | return 'Internal error'; |
||
| 194 | |||
| 195 | case \ZipArchive::ER_INCONS: |
||
| 196 | return 'Zip archive inconsistent'; |
||
| 197 | |||
| 198 | case \ZipArchive::ER_REMOVE: |
||
| 199 | return 'Can\'t remove file'; |
||
| 200 | |||
| 201 | case \ZipArchive::ER_DELETED: |
||
| 202 | return 'Entry has been deleted'; |
||
| 203 | |||
| 204 | default: |
||
| 205 | return 'An unknown error has occurred('.intval($errorCode).')'; |
||
| 206 | } |
||
| 207 | } |
||
| 208 | } |
||
| 209 |