Controller::__construct() - Code Metrics - akeneo-labs/CustomEntityBundle - Measure and Improve Code Quality continuously with Scrutinizer

Controller::__construct() A
last analyzed 2016-03-17 09:30 UTC

↳ Parent: Controller

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	5
rs	9.4285
cc	1
eloc	3
nc	1
nop	2

<?php

namespace Pim\Bundle\CustomEntityBundle\Controller;

use Pim\Bundle\CustomEntityBundle\Action\ActionFactory;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

/**
 * Controller for custom entities
 *
 * @author    Antoine Guigan <[email protected]>
 * @copyright 2013 Akeneo SAS (http://www.akeneo.com)
 * @license   http://opensource.org/licenses/osl-3.0.php  Open Software License (OSL 3.0)
 */
class Controller
{
    /**
     * @var ActionFactory
     */
    protected $actionFactory;

    /**
     * @var Request
     */
    protected $request;

    /**
     * @param ActionFactory $actionFactory
     * @param Request       $request
     */
    public function __construct(ActionFactory $actionFactory, Request $request)

    {
        $this->actionFactory = $actionFactory;
        $this->request = $request;
    }

    /**
     * Default action
     *
     * @param string $customEntityName
     * @param string $actionType
     *
     * @return Response
     * @throws NotFoundHttpException
     */
    public function executeAction($customEntityName, $actionType)
    {
        $action = $this->actionFactory->getAction($customEntityName, $actionType);
        if (!$action) {
            throw new NotFoundHttpException(
                sprintf('No action found for type "%s"', $actionType)
            );
        }

        return $action->execute($this->request);
    }
}


1			<?php
2
3			namespace Pim\Bundle\CustomEntityBundle\Controller;
4
5			use Pim\Bundle\CustomEntityBundle\Action\ActionFactory;
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\HttpFoundation\Response;
8			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
9
10			/**
11			* Controller for custom entities
12			*
13			* @author Antoine Guigan <[email protected]>
14			* @copyright 2013 Akeneo SAS (http://www.akeneo.com)
15			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
16			*/
17			class Controller
18			{
19			/**
20			* @var ActionFactory
21			*/
22			protected $actionFactory;
23
24			/**
25			* @var Request
26			*/
27			protected $request;
28
29			/**
30			* @param ActionFactory $actionFactory
31			* @param Request $request
32			*/
33			public function __construct(ActionFactory $actionFactory, Request $request)
			0 ignored issues – show Bug introduced 2016-02-29 17:40 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
34			{
35			$this->actionFactory = $actionFactory;
36			$this->request = $request;
37			}
38
39			/**
40			* Default action
41			*
42			* @param string $customEntityName
43			* @param string $actionType
44			*
45			* @return Response
46			* @throws NotFoundHttpException
47			*/
48			public function executeAction($customEntityName, $actionType)
49			{
50			$action = $this->actionFactory->getAction($customEntityName, $actionType);
51			if (!$action) {
52			throw new NotFoundHttpException(
53			sprintf('No action found for type "%s"', $actionType)
54			);
55			}
56
57			return $action->execute($this->request);
58			}
59			}
60

akeneo-labs / CustomEntityBundle

Controller::__construct() A last analyzed 2016-03-17 09:30 UTC

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like

Controller::__construct() A
last analyzed 2016-03-17 09:30 UTC