ReplyKeyboardEntry::addRow() - Code Metrics - akeinhell/telegram-bot - Measure and Improve Code Quality continuously with Scrutinizer

ReplyKeyboardEntry::addRow() A
last analyzed 2017-04-08 14:28 UTC

↳ Parent: ReplyKeyboardEntry

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php
/**
 * Created by PhpStorm.
 * User: akeinhell
 * Date: 20.11.16
 * Time: 20:02
 */

namespace Telegram\Entry;


use Illuminate\Support\Collection;
use Telegram\Base\BaseEntry;

class ReplyKeyboardEntry extends BaseEntry
{
    private $rows;

    const KEYBOARD_KEY = 'keyboard';

    public function __construct()
    {
        parent::__construct();
        $this->set(self::KEYBOARD_KEY, collect());
    }

    /**
     * @param KeyboardButton[] $row
     * @return $this
     */
    public function addRow(array $row)
    {
        $rows = $this->get(self::KEYBOARD_KEY, collect())->push($row);

        return $this->set(self::KEYBOARD_KEY, $rows);
    }

    /**
     * @return mixed
     */
    public function getKeyboard()
    {
        return $this->rows;
    }

    /**
     * @param bool $resize
     * @return $this
     */
    public function setResizeKeyboard($resize)
    {
        return $this->set('resize_keyboard', $resize);
    }

    /**
     * @param bool $oneTime
     * @return $this
     */
    public function setOneTimeKeyboard($oneTime)
    {
        return $this->set('one_time_keyboard', $oneTime);
    }

    /**
     * @param bool $selective
     * @return $this
     */
    public function setSelective($selective)
    {
        return $this->set('selective', $selective);
    }

    public function toArray()
    {
        $rows = $this->get(self::KEYBOARD_KEY, collect());
        if (!is_array($rows) && get_class($rows) == Collection::class) {
            $clone = clone $this;
            $rows  = $clone
                ->get(self::KEYBOARD_KEY, collect())
                ->mapWithKeys(function ($item, $key) {
                    return [
                        $key => collect($item)
                            ->mapWithKeys(function ($item, $key) {
                                /** @var $item Collection */
                                return [$key => $item->toArray()];
                            }),
                    ];

                })
                ->toArray();

            $clone->set(self::KEYBOARD_KEY, $rows);

            return $clone::toArray();
        }

        return json_encode(parent::toArray());
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }


}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: akeinhell
5		* Date: 20.11.16
6		* Time: 20:02
7		*/
8
9		namespace Telegram\Entry;
10
11
12		use Illuminate\Support\Collection;
13		use Telegram\Base\BaseEntry;
14
15		class ReplyKeyboardEntry extends BaseEntry
16		{
17		private $rows;
18
19		const KEYBOARD_KEY = 'keyboard';
20
21	1	public function __construct()
22		{
23	1	parent::__construct();
24	1	$this->set(self::KEYBOARD_KEY, collect());
25	1	}
26
27		/**
28		* @param KeyboardButton[] $row
29		* @return $this
30		*/
31	1	public function addRow(array $row)
32		{
33	1	$rows = $this->get(self::KEYBOARD_KEY, collect())->push($row);
34
35	1	return $this->set(self::KEYBOARD_KEY, $rows);
36		}
37
38		/**
39		* @return mixed
40		*/
41		public function getKeyboard()
42		{
43		return $this->rows;
44		}
45
46		/**
47		* @param bool $resize
48		* @return $this
49		*/
50	1	public function setResizeKeyboard($resize)
51		{
52	1	return $this->set('resize_keyboard', $resize);
53		}
54
55		/**
56		* @param bool $oneTime
57		* @return $this
58		*/
59	1	public function setOneTimeKeyboard($oneTime)
60		{
61	1	return $this->set('one_time_keyboard', $oneTime);
62		}
63
64		/**
65		* @param bool $selective
66		* @return $this
67		*/
68	1	public function setSelective($selective)
69		{
70	1	return $this->set('selective', $selective);
71		}
72
73	1	public function toArray()
74		{
75	1	$rows = $this->get(self::KEYBOARD_KEY, collect());
76	1	if (!is_array($rows) && get_class($rows) == Collection::class) {
77	1	$clone = clone $this;
78		$rows = $clone
79	1	->get(self::KEYBOARD_KEY, collect())
80		->mapWithKeys(function ($item, $key) {
81		return [
82	1	$key => collect($item)
83	1	->mapWithKeys(function ($item, $key) {
84		/** @var $item Collection */
85	1	return [$key => $item->toArray()];
86	1	}),
87	1	];
88
89	1	})
90	1	->toArray();
91
92	1	$clone->set(self::KEYBOARD_KEY, $rows);
93
94	1	return $clone::toArray();
95		}
96
97	1	return json_encode(parent::toArray());
		0 ignored issues – show Bug Best Practice introduced 2016-11-20 16:11 UTC by Report Bug Copy Issue Report The return type of `return json_encode(parent::toArray());` (`string`) is incompatible with the return type of the parent method `Telegram\Base\BaseEntry::toArray` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
98		}
99
100
101		}

akeinhell / telegram-bot

ReplyKeyboardEntry::addRow() A last analyzed 2017-04-08 14:28 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ReplyKeyboardEntry::addRow() A
last analyzed 2017-04-08 14:28 UTC