KeyboardCommand::execute() - Code Metrics - Inspection of "Scrutinizer fixes" - akalongman/php-telegram-bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#288)

by Armando

created 2016-09-02 16:08 UTC

KeyboardCommand::execute() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	73
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	73
rs	9.0675
cc	1
eloc	43
nc	1
nop	0

How to fix Long Method

<?php
/**
 * This file is part of the TelegramBot package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\TelegramBot\Commands\UserCommands;

use Longman\TelegramBot\Commands\UserCommand;
use Longman\TelegramBot\Request;
use Longman\TelegramBot\Entities\ReplyKeyboardMarkup;

/**
 * User "/keyboard" command
 */
class KeyboardCommand extends UserCommand
{
    /**#@+
     * {@inheritdoc}
     */
    protected $name = 'keyboard';
    protected $description = 'Show a custom keyboard with reply markup';
    protected $usage = '/keyboard';
    protected $version = '0.1.0';
    /**#@-*/

    /**
     * {@inheritdoc}
     */
    public function execute()
    {
        $message = $this->getMessage();
        $chat_id = $message->getChat()->getId();

        $data = [
            'chat_id' => $chat_id,
            'text'    => 'Press a Button:',
        ];

        //Keyboard examples
        $keyboards = [];

        //Example 0
        $keyboard    = [];
        $keyboard[]  = ['7', '8', '9'];
        $keyboard[]  = ['4', '5', '6'];
        $keyboard[]  = ['1', '2', '3'];
        $keyboard[]  = [' ', '0', ' '];
        $keyboards[] = $keyboard;

        //Example 1
        $keyboard    = [];
        $keyboard[]  = ['7', '8', '9', '+'];
        $keyboard[]  = ['4', '5', '6', '-'];
        $keyboard[]  = ['1', '2', '3', '*'];
        $keyboard[]  = [' ', '0', ' ', '/'];
        $keyboards[] = $keyboard;

        //Example 2
        $keyboard    = [];
        $keyboard[]  = ['A'];
        $keyboard[]  = ['B'];
        $keyboard[]  = ['C'];
        $keyboards[] = $keyboard;

        //Example 3
        $keyboard    = [];
        $keyboard[]  = ['A'];
        $keyboard[]  = ['B'];
        $keyboard[]  = ['C', 'D'];
        $keyboards[] = $keyboard;

        //Example 4 (bots version 2.0)
        $keyboard    = [];
        $keyboard[]  = [
            [
                'text'            => 'Send my contact',
                'request_contact' => true,
            ],
            [
                'text'             => 'Send my location',
                'request_location' => true,
            ],
        ];
        $keyboards[] = $keyboard;

        //Return a random keyboard.
        $keyboard             = $keyboards[mt_rand(0, count($keyboards) - 1)];
        $data['reply_markup'] = new ReplyKeyboardMarkup(
            [
                'keyboard'          => $keyboard,
                'resize_keyboard'   => true,
                'one_time_keyboard' => false,
                'selective'         => false,
            ]
        );

        return Request::sendMessage($data);
    }
}


1			<?php
2			/**
3			* This file is part of the TelegramBot package.
4			*
5			* (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Longman\TelegramBot\Commands\UserCommands;
12
13			use Longman\TelegramBot\Commands\UserCommand;
14			use Longman\TelegramBot\Request;
15			use Longman\TelegramBot\Entities\ReplyKeyboardMarkup;
16
17			/**
18			* User "/keyboard" command
19			*/
20			class KeyboardCommand extends UserCommand
21			{
22			/**#@+
23			* {@inheritdoc}
24			*/
25			protected $name = 'keyboard';
26			protected $description = 'Show a custom keyboard with reply markup';
27			protected $usage = '/keyboard';
28			protected $version = '0.1.0';
29			/*#@-/
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function execute()
35			{
36			$message = $this->getMessage();
37			$chat_id = $message->getChat()->getId();
38
39			$data = [
40			'chat_id' => $chat_id,
41			'text' => 'Press a Button:',
42			];
43
44			//Keyboard examples
45			$keyboards = [];
46
47			//Example 0
48			$keyboard = [];
49			$keyboard[] = ['7', '8', '9'];
50			$keyboard[] = ['4', '5', '6'];
51			$keyboard[] = ['1', '2', '3'];
52			$keyboard[] = [' ', '0', ' '];
53			$keyboards[] = $keyboard;
54
55			//Example 1
56			$keyboard = [];
57			$keyboard[] = ['7', '8', '9', '+'];
58			$keyboard[] = ['4', '5', '6', '-'];
59			$keyboard[] = ['1', '2', '3', '*'];
60			$keyboard[] = [' ', '0', ' ', '/'];
61			$keyboards[] = $keyboard;
62
63			//Example 2
64			$keyboard = [];
65			$keyboard[] = ['A'];
66			$keyboard[] = ['B'];
67			$keyboard[] = ['C'];
68			$keyboards[] = $keyboard;
69
70			//Example 3
71			$keyboard = [];
72			$keyboard[] = ['A'];
73			$keyboard[] = ['B'];
74			$keyboard[] = ['C', 'D'];
75			$keyboards[] = $keyboard;
76
77			//Example 4 (bots version 2.0)
78			$keyboard = [];
79			$keyboard[] = [
80			[
81			'text' => 'Send my contact',
82			'request_contact' => true,
83			],
84			[
85			'text' => 'Send my location',
86			'request_location' => true,
87			],
88			];
89			$keyboards[] = $keyboard;
90
91			//Return a random keyboard.
92			$keyboard = $keyboards[mt_rand(0, count($keyboards) - 1)];
93			$data['reply_markup'] = new ReplyKeyboardMarkup(
94			[
95			'keyboard' => $keyboard,
96			'resize_keyboard' => true,
97			'one_time_keyboard' => false,
98			'selective' => false,
99			]
100			);
101
102			return Request::sendMessage($data);
103			}
104			}
105

akalongman / php-telegram-bot

Pull Request — develop (#288)

KeyboardCommand::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like