ConversationDB::updateConversation() - Code Metrics - Inspection of "Give notes more space in the database." - akalongman/php-telegram-bot - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4b2edc...52afdb )

by Armando

created 2016-12-25 03:56 UTC

ConversationDB::updateConversation() A

↳ Parent: ConversationDB

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2
crap	2

<?php
/**
 * This file is part of the TelegramBot package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\TelegramBot;

use Exception;
use Longman\TelegramBot\Exception\TelegramException;
use PDO;

class ConversationDB extends DB
{
    /**
     * Initilize conversation table
     */
    public static function initializeConversation()
    {
        if (!defined('TB_CONVERSATION')) {
            define('TB_CONVERSATION', self::$table_prefix . 'conversation');
        }
    }

    /**
     * Select a conversation from the DB
     *
     * @param int  $user_id
     * @param int  $chat_id
     * @param bool $limit
     *
     * @return array|bool
     * @throws \Longman\TelegramBot\Exception\TelegramException
     */
    public static function selectConversation($user_id, $chat_id, $limit = null)
    {
        if (!self::isDbConnected()) {
            return false;
        }

        try {
            $query = 'SELECT * FROM `' . TB_CONVERSATION . '` ';
            $query .= 'WHERE `status` = :status ';
            $query .= 'AND `chat_id` = :chat_id ';
            $query .= 'AND `user_id` = :user_id ';

            if (!is_null($limit)) {
                $query .= ' LIMIT :limit';
            }
            $sth = self::$pdo->prepare($query);

            $active = 'active';
            $sth->bindParam(':status', $active, PDO::PARAM_STR);
            $sth->bindParam(':user_id', $user_id, PDO::PARAM_INT);
            $sth->bindParam(':chat_id', $chat_id, PDO::PARAM_INT);
            $sth->bindParam(':limit', $limit, PDO::PARAM_INT);
            $sth->execute();

            $results = $sth->fetchAll(PDO::FETCH_ASSOC);
        } catch (Exception $e) {
            throw new TelegramException($e->getMessage());
        }
        return $results;
    }

    /**
     * Insert the conversation in the database
     *
     * @param int    $user_id
     * @param int    $chat_id
     * @param string $command
     *
     * @return bool
     * @throws \Longman\TelegramBot\Exception\TelegramException
     */
    public static function insertConversation($user_id, $chat_id, $command)
    {
        if (!self::isDbConnected()) {
            return false;
        }

        try {
            $sth    = self::$pdo->prepare('INSERT INTO `' . TB_CONVERSATION . '`
                (
                `status`, `user_id`, `chat_id`, `command`, `notes`, `created_at`, `updated_at`
                )
                VALUES (
                :status, :user_id, :chat_id, :command, :notes, :date, :date
                )
               ');
            $active = 'active';
            //$notes = json_encode('');

            $notes      = '""';
            $created_at = self::getTimestamp();

            $sth->bindParam(':status', $active);
            $sth->bindParam(':command', $command);
            $sth->bindParam(':user_id', $user_id);
            $sth->bindParam(':chat_id', $chat_id);
            $sth->bindParam(':notes', $notes);
            $sth->bindParam(':date', $created_at);

            $status = $sth->execute();
        } catch (Exception $e) {
            throw new TelegramException($e->getMessage());
        }
        return $status;
    }

    /**
     * Update a specific conversation
     *
     * @param array $fields_values
     * @param array $where_fields_values
     *
     * @return bool
     */
    public static function updateConversation(array $fields_values, array $where_fields_values)
    {
        return self::update(TB_CONVERSATION, $fields_values, $where_fields_values);
    }

    /**
     * Update the conversation in the database
     *
     * @param string $table
     * @param array  $fields_values
     * @param array  $where_fields_values
     *
     * @todo This function is generic should be moved in DB.php
     *
     * @return bool
     * @throws \Longman\TelegramBot\Exception\TelegramException
     */
    public static function update($table, array $fields_values, array $where_fields_values)
    {
        if (!self::isDbConnected()) {
            return false;
        }
        //Auto update the field update_at
        $fields_values['updated_at'] = self::getTimestamp();

        //Values
        $update         = '';
        $tokens         = [];
        $tokens_counter = 0;
        $a              = 0;
        foreach ($fields_values as $field => $value) {

            if ($a) {
                $update .= ', ';
            }
            ++$a;
            ++$tokens_counter;
            $update .= '`' . $field . '` = :' . $tokens_counter;
            $tokens[':' . $tokens_counter] = $value;
        }

        //Where
        $a     = 0;
        $where = '';
        foreach ($where_fields_values as $field => $value) {

            if ($a) {
                $where .= ' AND ';
            } else {
                ++$a;
                $where .= 'WHERE ';
            }
            ++$tokens_counter;
            $where .= '`' . $field . '`= :' . $tokens_counter;
            $tokens[':' . $tokens_counter] = $value;
        }

        $query = 'UPDATE `' . $table . '` SET ' . $update . ' ' . $where;
        try {
            $sth    = self::$pdo->prepare($query);
            $status = $sth->execute($tokens);
        } catch (Exception $e) {
            throw new TelegramException($e->getMessage());
        }
        return $status;
    }
}


1			<?php
2			/**
3			* This file is part of the TelegramBot package.
4			*
5			* (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Longman\TelegramBot;
12
13			use Exception;
14			use Longman\TelegramBot\Exception\TelegramException;
15			use PDO;
16
17			class ConversationDB extends DB
18			{
19			/**
20			* Initilize conversation table
21			*/
22	9		public static function initializeConversation()
23			{
24	9		if (!defined('TB_CONVERSATION')) {
25	1		define('TB_CONVERSATION', self::$table_prefix . 'conversation');
26			}
27	9		}
28
29			/**
30			* Select a conversation from the DB
31			*
32			* @param int $user_id
33			* @param int $chat_id
34			* @param bool $limit
35			*
36			* @return array\|bool
37			* @throws \Longman\TelegramBot\Exception\TelegramException
38			*/
39	9		public static function selectConversation($user_id, $chat_id, $limit = null)
40			{
41	9		if (!self::isDbConnected()) {
42			return false;
43			}
44
45			try {
46	9		$query = 'SELECT * FROM `' . TB_CONVERSATION . '` ';
47	9		$query .= 'WHERE `status` = :status ';
48	9		$query .= 'AND `chat_id` = :chat_id ';
49	9		$query .= 'AND `user_id` = :user_id ';
50
51	9		if (!is_null($limit)) {
52	9		$query .= ' LIMIT :limit';
53			}
54	9		$sth = self::$pdo->prepare($query);
55
56	9		$active = 'active';
57	9		$sth->bindParam(':status', $active, PDO::PARAM_STR);
58	9		$sth->bindParam(':user_id', $user_id, PDO::PARAM_INT);
59	9		$sth->bindParam(':chat_id', $chat_id, PDO::PARAM_INT);
60	9		$sth->bindParam(':limit', $limit, PDO::PARAM_INT);
61	9		$sth->execute();
62
63			$results = $sth->fetchAll(PDO::FETCH_ASSOC);
64	9		} catch (Exception $e) {
65	9		throw new TelegramException($e->getMessage());
66			}
67			return $results;
68			}
69
70			/**
71			* Insert the conversation in the database
72			*
73			* @param int $user_id
74			* @param int $chat_id
75			* @param string $command
76			*
77			* @return bool
78			* @throws \Longman\TelegramBot\Exception\TelegramException
79			*/
80			public static function insertConversation($user_id, $chat_id, $command)
81			{
82			if (!self::isDbConnected()) {
83			return false;
84			}
85
86			try {
87			$sth = self::$pdo->prepare('INSERT INTO `' . TB_CONVERSATION . '`
88			(
89			`status`, `user_id`, `chat_id`, `command`, `notes`, `created_at`, `updated_at`
90			)
91			VALUES (
92			:status, :user_id, :chat_id, :command, :notes, :date, :date
93			)
94			');
95			$active = 'active';
96			//$notes = json_encode('');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-08-23 14:21 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97			$notes = '""';
98			$created_at = self::getTimestamp();
99
100			$sth->bindParam(':status', $active);
101			$sth->bindParam(':command', $command);
102			$sth->bindParam(':user_id', $user_id);
103			$sth->bindParam(':chat_id', $chat_id);
104			$sth->bindParam(':notes', $notes);
105			$sth->bindParam(':date', $created_at);
106
107			$status = $sth->execute();
108			} catch (Exception $e) {
109			throw new TelegramException($e->getMessage());
110			}
111			return $status;
112			}
113
114			/**
115			* Update a specific conversation
116			*
117			* @param array $fields_values
118			* @param array $where_fields_values
119			*
120			* @return bool
121			*/
122			public static function updateConversation(array $fields_values, array $where_fields_values)
123			{
124			return self::update(TB_CONVERSATION, $fields_values, $where_fields_values);
125			}
126
127			/**
128			* Update the conversation in the database
129			*
130			* @param string $table
131			* @param array $fields_values
132			* @param array $where_fields_values
133			*
134			* @todo This function is generic should be moved in DB.php
135			*
136			* @return bool
137			* @throws \Longman\TelegramBot\Exception\TelegramException
138			*/
139			public static function update($table, array $fields_values, array $where_fields_values)
140			{
141			if (!self::isDbConnected()) {
142			return false;
143			}
144			//Auto update the field update_at
145			$fields_values['updated_at'] = self::getTimestamp();
146
147			//Values
148			$update = '';
149			$tokens = [];
150			$tokens_counter = 0;
151			$a = 0;
152		View Code Duplication	foreach ($fields_values as $field => $value) {
			0 ignored issues – show Duplication introduced 2016-08-23 14:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153			if ($a) {
154			$update .= ', ';
155			}
156			++$a;
157			++$tokens_counter;
158			$update .= '`' . $field . '` = :' . $tokens_counter;
159			$tokens[':' . $tokens_counter] = $value;
160			}
161
162			//Where
163			$a = 0;
164			$where = '';
165		View Code Duplication	foreach ($where_fields_values as $field => $value) {
			0 ignored issues – show Duplication introduced 2016-08-23 14:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
166			if ($a) {
167			$where .= ' AND ';
168			} else {
169			++$a;
170			$where .= 'WHERE ';
171			}
172			++$tokens_counter;
173			$where .= '`' . $field . '`= :' . $tokens_counter;
174			$tokens[':' . $tokens_counter] = $value;
175			}
176
177			$query = 'UPDATE `' . $table . '` SET ' . $update . ' ' . $where;
178			try {
179			$sth = self::$pdo->prepare($query);
180			$status = $sth->execute($tokens);
181			} catch (Exception $e) {
182			throw new TelegramException($e->getMessage());
183			}
184			return $status;
185			}
186			}
187

akalongman / php-telegram-bot

Push — master ( 4b2edc...52afdb )

ConversationDB::updateConversation() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like