PermissionTrait - Code Metrics - akalongman/laravel-platfourm - Measure and Improve Code Quality continuously with Scrutinizer

PermissionTrait A
last analyzed 2017-04-08 21:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	13
cp	0
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	roles()	0	4	1
A	bootEntrustPermissionTrait()	0	10	2

<?php
/*
 * This file is part of the Laravel Platfourm package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\Platfourm\User\Models\Eloquent\Traits;

use Config;

trait PermissionTrait
{
    /**
     * Many-to-Many relations with role model.
     *
     * @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
     */
    public function roles()
    {
        return $this->belongsToMany(Config::get('entrust.role'), Config::get('entrust.permission_role_table'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    //change function boot to
    public static function bootEntrustPermissionTrait()
    {
        static::deleting(function ($permission) {
            if (!method_exists(static::class, 'bootSoftDeletes')) {
                $permission->roles()->sync([]);
            }

            return true;
        });
    }
}


1			<?php
2			/*
3			* This file is part of the Laravel Platfourm package.
4			*
5			* (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace Longman\Platfourm\User\Models\Eloquent\Traits;
12
13			use Config;
14
15			trait PermissionTrait
16			{
17			/**
18			* Many-to-Many relations with role model.
19			*
20			* @return \Illuminate\Database\Eloquent\Relations\BelongsToMany
21			*/
22			public function roles()
23			{
24			return $this->belongsToMany(Config::get('entrust.role'), Config::get('entrust.permission_role_table'));
			0 ignored issues – show Bug introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report It seems like `belongsToMany()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
25			}
26
27			//change function boot to
28			public static function bootEntrustPermissionTrait()
29			{
30			static::deleting(function ($permission) {
31			if (!method_exists(static::class, 'bootSoftDeletes')) {
32			$permission->roles()->sync([]);
33			}
34
35			return true;
36			});
37			}
38			}
39

akalongman / laravel-platfourm

PermissionTrait A last analyzed 2017-04-08 21:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

PermissionTrait A
last analyzed 2017-04-08 21:25 UTC