FindEntities - Code Metrics - akalongman/laravel-platfourm - Measure and Improve Code Quality continuously with Scrutinizer

FindEntities A
last analyzed 2017-04-08 21:25 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	29
loc	29
ccs	0
cts	15
cp	0
rs	10
c	0
b	0
f	0
wmc	4
lcom	1
cbo	1

1 Method

Rating	Name	Duplication	Size	Complexity
B	run()	24	24	4

How to fix Duplicated Code

<?php
/*
 * This file is part of the Laravel Platfourm package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\Platfourm\Service\Traits;

use Longman\Platfourm\Repository\Criteria\SearchCriteria;

trait FindEntities

{

    public function run($columns = '*', array $options = null, $sortBy = null)
    {
        $this->checkRepository();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if (!empty($options['search'])) {
            $searchFields   = !empty($options['searchFields']) ? $options['searchFields'] : null;
            $searchCriteria = new SearchCriteria($options['search'], $searchFields);
            $this->repository->pushCriteria($searchCriteria);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        if (!empty($options['trashed'])) {
            $this->repository = $this->repository->withTrashed();
        }

        unset($options['search'], $options['searchFields'], $options['trashed']);

        $entityCollection = $this->repository->findBy($columns, $options, null, null, $sortBy);

        /*if (empty($entityCollection)) {

            throw new EntitiesNotFoundException;
        }*/

        return $this->parseResult($entityCollection);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

}


1		<?php
2		/*
3		* This file is part of the Laravel Platfourm package.
4		*
5		* (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Longman\Platfourm\Service\Traits;
12
13		use Longman\Platfourm\Repository\Criteria\SearchCriteria;
14
15	View Code Duplication	trait FindEntities
		0 ignored issues – show Duplication introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17
18		public function run($columns = '*', array $options = null, $sortBy = null)
19		{
20		$this->checkRepository();
		0 ignored issues – show Bug introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report It seems like `checkRepository()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21
22		if (!empty($options['search'])) {
23		$searchFields = !empty($options['searchFields']) ? $options['searchFields'] : null;
24		$searchCriteria = new SearchCriteria($options['search'], $searchFields);
25		$this->repository->pushCriteria($searchCriteria);
		0 ignored issues – show Bug introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report The property `repository` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26		}
27
28		if (!empty($options['trashed'])) {
29		$this->repository = $this->repository->withTrashed();
30		}
31
32		unset($options['search'], $options['searchFields'], $options['trashed']);
33
34		$entityCollection = $this->repository->findBy($columns, $options, null, null, $sortBy);
35
36		/*if (empty($entityCollection)) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report `64%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
37		throw new EntitiesNotFoundException;
38		}*/
39
40		return $this->parseResult($entityCollection);
		0 ignored issues – show Bug introduced 2016-09-01 13:10 UTC by Report Bug Copy Issue Report It seems like `parseResult()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41		}
42
43		}
44

akalongman / laravel-platfourm

FindEntities A last analyzed 2017-04-08 21:25 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

FindEntities A
last analyzed 2017-04-08 21:25 UTC