Longman\Platfourm\Auth\Middleware\ResponseGuestIfAuthenticated

Complexity

Total Complexity

6

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	13	3
A	redirect()	0	5	2

<?php
/*
 * This file is part of the Laravel Platfourm package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <akalongman@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\Platfourm\Auth\Middleware;

use Closure;
use Longman\Platfourm\Contracts\Auth\AuthUserService as AuthUserServiceContract;

class ResponseGuestIfAuthenticated
{
    /**
     * The Guard implementation.
     *
     * @var Guard
     */
    protected $authService;

    /**
     * Create a new filter instance.
     *
     * @param  Guard $auth

There is no parameter named $auth. Was it maybe removed?

     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct(AuthUserServiceContract $authService)
    {
        $this->authService = $authService;

It seems like $authService of type object<Longman\Platfourm\Contracts\Auth\AuthUserService> is incompatible with the declared type object<Longman\Platfourm\Auth\Middleware\Guard> of property $authService.

    }

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure                 $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {

        if ($this->authService->check()) {
            if ($request->wantsJson()) {
                return response('Unauthorized.', 401);
            } else {
                return $this->redirect();
            }
        }

        return $next($request);
    }

    protected function redirect()
    {
        $url = app()->isAdmin() ? admin_url('login') : site_url('login');
        return redirect()->guest($url)->with(['error' => 'You must log in first']);

It seems like $url defined by app()->isAdmin() ? admin_url('login') : site_url('login') on line 59 can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Illuminate\Routing\Redirector::guest() does only seem to accept string, maybe add an additional type check?

    }

}