Longman\LaravelMultiLang\TextsTrait

Complexity

Total Complexity

11

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
C	index()	0	39	7
A	save()	0	20	4

<?php

namespace Longman\LaravelMultiLang;

use Illuminate\Http\Request;
use Longman\LaravelMultiLang\Models\Text;

trait TextsTrait
{

    public function index(Request $request)
    {
        $options['lang'] = config('multilang.default_locale');

$options was never initialized. Although not strictly required by PHP, it is generally a good practice to add $options = array(); before regardless.

        if ($request->lang) {
            $options['lang'] = $request->lang;

The property lang does not seem to exist in Illuminate\Http\Request.

        }

        if ($request->keyword) {
            $options['keyword'] = $request->keyword;

The property keyword does not seem to exist in Illuminate\Http\Request.

        }

        if ($request->scope) {
            $options['scope'] = $request->scope;

The property scope does not seem to exist in Illuminate\Http\Request.

        }

        $texts = Text::where(function ($q) use ($options) {
            foreach ($options as $k => $v) {
                if ($k == 'keyword') {
                    $q->where(function ($query) use ($v) {
                        $query->where('key', 'LIKE', '%' . $v . '%')->orWhere('value', 'LIKE', '%' . $v . '%');
                    });
                } else {
                    $q->where($k, $v);
                }
            }
        })->orderBy('value', 'asc')->get();

        if (isset($request->search)) {
            $options['search'] = true;
        }

        $options['keyword'] = $request->keyword;

        $data['texts'] = $texts;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

        $data['options'] = $options;

        return view($this->view, $data);

The property view does not exist. Did you maybe forget to declare it?

    }

    public function save(Request $request)
    {
        $this->validate($request, [

It seems like validate() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'texts' => 'required|array',
        ]);

        $locales = array_keys(config('multilang.locales'));
        foreach ($request->texts as $lang => $items) {
            if (!in_array($lang, $locales)) {
                //to do must set errors
                continue;
            }
            foreach ($items as $key => $value) {
                Text::where('lang', $lang)
                    ->where('key', $key)
                    ->update(['value' => $value]);
            }
        }
        return redirect()->back();
    }
}