Localizable::getLocalizableColumn() - Code Metrics - Inspection of "Merge branch 'dev'" - akalongman/laravel-multilang - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — master ( 5d4742...dadafa )

by Avtandil

created 2019-12-17 11:55 UTC

Localizable::getLocalizableColumn() A

↳ Parent: Localizable

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	6
ccs	0
cts	1
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Longman\LaravelMultiLang\Models;

trait Localizable
{
    /**
     * Boot trait
     */
    public static function bootLocalizable()
    {
        static::addGlobalScope(new LocalizableScope());
    }

    /**
     * Get column name
     *
     * @return string
     */
    public function getLocalizableColumn()
    {
        $localizableColumn = static::$localizableColumn ?? 'lang';

        return $localizableColumn;
    }

    /**
     * Get column name with table name
     *
     * @return string
     */
    public function getQualifiedLocalizableColumn()
    {
        return $this->getTable() . '.' . $this->getLocalizableColumn();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Longman\LaravelMultiLang\Models;
6
7			trait Localizable
8			{
9			/**
10			* Boot trait
11			*/
12			public static function bootLocalizable()
13			{
14			static::addGlobalScope(new LocalizableScope());
15			}
16
17			/**
18			* Get column name
19			*
20			* @return string
21			*/
22			public function getLocalizableColumn()
23			{
24			$localizableColumn = static::$localizableColumn ?? 'lang';
25
26			return $localizableColumn;
27			}
28
29			/**
30			* Get column name with table name
31			*
32			* @return string
33			*/
34			public function getQualifiedLocalizableColumn()
35			{
36			return $this->getTable() . '.' . $this->getLocalizableColumn();
			0 ignored issues – show Bug introduced 2016-05-19 12:15 UTC by Report Bug Copy Issue Report It seems like `getTable()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			}
38			}
39

akalongman / laravel-multilang

Push — master ( 5d4742...dadafa )

Localizable::getLocalizableColumn() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like