MultiLang - Code Metrics - Inspection of "Added clover" - akalongman/laravel-multilang - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a92b73...59f0bc )

by Avtandil

created 2016-04-19 11:03 UTC

MultiLang B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	338
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

56.64%

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
wmc	42
c	4
b	1
f	1
lcom	1
cbo	2
dl	0
loc	338
ccs	64
cts	113
cp	0.5664
rs	8.295

19 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	getConfig()	8	3
A	get()	20	4
A	getTexts()	5	1
A	queueToSave()	4	1
A	mustLoadFromCache()	4	1
A	storeTextsInCache()	6	1
A	loadTextsFromCache()	5	1
A	setCacheName()	4	1
A	autoSaveIsAllowed()	7	4
A	getLocale()	4	1
A	setConfig()	21	2
A	setLocale()	15	4
B	loadTexts()	20	5
A	setTexts()	11	2
A	loadTextsFromDatabase()	12	3
A	getUrl()	8	2
B	saveTexts()	31	3
A	getTableName()	9	2

How to fix Complexity

<?php
/*
 * This file is part of the Laravel MultiLang package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Longman\LaravelMultiLang;

use Illuminate\Contracts\Cache\Factory as CacheContract;
use Illuminate\Database\DatabaseManager as DatabaseContract;
use Illuminate\Support\Collection;
use InvalidArgumentException;

class MultiLang
{
    /**
     * Language/Locale.
     *
     * @var string
     */
    protected $lang;

    /**
     * System environment
     *
     * @var string
     */
    protected $environment;

    /**
     * The instance of the laravel app.
     *
     * @var \Illuminate\Foundation\Application
     */
    protected $app;

    /**
     * The instance of the cache.
     *
     * @var \Illuminate\Cache\CacheManager
     */
    protected $cache;

    /**
     * Config.
     *
     * @var array
     */
    protected $config;

    /**
     * The instance of the database.
     *
     * @var \Illuminate\Database\DatabaseManager
     */
    protected $db;

    /**
     * Name of the cache.
     *
     * @var string
     */
    protected $cache_name;

    /**
     * Texts collection.
     *
     * @var \Illuminate\Support\Collection
     */
    protected $texts;

    /**
     * Missing texts.
     *
     * @var array
     */
    protected $new_texts;

    /**
     * Create a new MultiLang instance.
     *
     * @param  string                               $environment
     * @param  array                                $config
     * @param  \Illuminate\Cache\CacheManager       $cache
     * @param  \Illuminate\Database\DatabaseManager $db
     * @return void

     */
    public function __construct($environment, array $config, CacheContract $cache, DatabaseContract $db)
    {
        $this->environment = $environment;
        $this->cache       = $cache;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
        $this->db          = $db;

        $this->setConfig($config);
    }

    public function setConfig(array $config)
    {
        $this->config = [
            'enabled'        => true,
            'locales'        => [
                'en' => [
                    'name'        => 'English',
                    'native_name' => 'English',
                    'default'     => true,
                ],
            ],
            'autosave'       => true,
            'cache'          => true,
            'cache_lifetime' => 1440,
            'texts_table'    => 'texts',
        ];

        foreach ($config as $k => $v) {
            $this->config[$k] = $v;
        }
    }

    public function getConfig($key = null)
    {
        if ($key === null) {
            return $this->config;
        }

        return isset($this->config[$key]) ? $this->config[$key] : null;
    }

    /**
     * Set locale and load texts
     *
     * @param  string                               $lang
     * @param  \Illuminate\Support\Collection|array $text
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return void
     */
    public function setLocale($lang, $texts = null)
    {
        if (!$lang) {
            throw new InvalidArgumentException('Locale is empty!');
        }
        $this->lang = $lang;

        $this->setCacheName();

        if (is_array($texts)) {
            $texts = new Collection($texts);
        }

        $this->texts = $texts ? $texts : $this->loadTexts($this->getLocale());
    }

    /**
     * Load texts
     *
     * @param  string                           $lang
     * @return \Illuminate\Support\Collection
     */
    public function loadTexts($lang = null)
    {
        $cache = $this->getConfig('cache');

        if (!$cache || $this->cache === null || $this->environment != 'production') {
            $texts = $this->loadTextsFromDatabase($lang);
            return $texts;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        if ($this->mustLoadFromCache()) {
            $texts = $this->loadTextsFromCache();
        } else {
            $texts = $this->loadTextsFromDatabase($lang);
            $this->storeTextsInCache($texts);
        }

        $texts = new Collection($texts);

        return $texts;
    }

    /**
     * Get translated text
     *
     * @param  string   $key
     * @param  string   $default
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return string
     */
    public function get($key)
    {

        if (empty($key)) {
            return null;
        }

        if (!$this->lang) {
            return $key;
        }

        if (!$this->texts->has($key)) {
            $this->queueToSave($key);
            return $key;
        }

        $text = $this->texts->get($key);

        return $text;
    }

    /**
     * Get texts
     *
     * @param  string   $lang
     * @return string
     */
    public function getTexts($lang = null)
    {

        return $this->loadTexts($lang);
    }

    /**
     * Set texts manually
     *
     * @param  array                                 $texts_array
     * @return \Longman\LaravelMultiLang\MultiLang
     */
    public function setTexts(array $texts_array)
    {
        $texts = [];
        foreach ($texts_array as $key => $value) {
            $texts[$key] = $value;
        }

        $this->texts = new Collection($texts);

        return $this;
    }

    /**
     * Queue missing texts
     *
     * @param  string $key
     * @return void
     */
    protected function queueToSave($key)
    {
        $this->new_texts[$key] = $key;
    }

    /**
     * Check if we must load texts from cache
     *
     * @return bool
     */
    protected function mustLoadFromCache()
    {
        return $this->cache->has($this->cache_name);
    }

    protected function storeTextsInCache(array $texts)
    {
        $cache_lifetime = $this->getConfig('cache_lifetime', 1440);

        $status         = $this->cache->put($this->cache_name, $texts, $cache_lifetime);
        return $status;
    }

    protected function loadTextsFromDatabase($lang)
    {
        $texts = $lang ? $this->db->table($this->getTableName())
            ->where('lang', $lang)
            ->get(['key', 'value', 'lang', 'scope']) : $this->db->table($this->getTableName())->get(['key', 'value', 'lang', 'scope']);

        $array = [];
        foreach ($texts as $row) {
            $array[$row->key] = $row->value;
        }
        return $array;
    }

    protected function loadTextsFromCache()
    {
        $texts = $this->cache->get($this->cache_name);

        return $texts;
    }

    protected function setCacheName()
    {
        $this->cache_name = 'texts.' . $this->lang;
    }

    public function getUrl($path)
    {
        $locale = $this->getLocale();
        if ($locale) {
            $path = $locale . '/' . $path;
        }
        return $path;
    }

    public function autoSaveIsAllowed()
    {
        if ($this->environment == 'local' && $this->getConfig('autosave') && $this->db !== null) {
            return true;
        }
        return false;
    }

    public function getLocale()
    {
        return $this->lang;
    }

    public function saveTexts()
    {
        if (empty($this->new_texts)) {
            return null;
        }

        $ins          = [];
        $placeholders = [];
        $lang         = $this->lang;
        $i            = 1;
        foreach ($this->new_texts as $k => $v) {
            $ins['key' . $i]   = $k;
            $ins['lang' . $i]  = $lang;
            $ins['value' . $i] = $v;

            $placeholders[] = '(:key' . $i . ', :lang' . $i . ', :value' . $i . ')';
            $i++;
        }

        $fields = ['key', 'lang', 'value'];

        $placeholders = implode(', ', $placeholders);

        $table = $this->getTableName(true);

        $query = 'INSERT IGNORE
            INTO `' . $table . '` (`' . implode('`, `', $fields) . '`)
            VALUES ' . $placeholders;

        $this->db->insert($query, $ins);
    }

    protected function getTableName($with_prefix = false)
    {
        $table = $this->getConfig('texts_table');
        if ($with_prefix) {
            $prefix = $this->db->getTablePrefix();
            $table  = $prefix . $table;
        }
        return $table;
    }
}


1		<?php
2		/*
3		* This file is part of the Laravel MultiLang package.
4		*
5		* (c) Avtandil Kikabidze aka LONGMAN <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Longman\LaravelMultiLang;
12
13		use Illuminate\Contracts\Cache\Factory as CacheContract;
14		use Illuminate\Database\DatabaseManager as DatabaseContract;
15		use Illuminate\Support\Collection;
16		use InvalidArgumentException;
17
18		class MultiLang
19		{
20		/**
21		* Language/Locale.
22		*
23		* @var string
24		*/
25		protected $lang;
26
27		/**
28		* System environment
29		*
30		* @var string
31		*/
32		protected $environment;
33
34		/**
35		* The instance of the laravel app.
36		*
37		* @var \Illuminate\Foundation\Application
38		*/
39		protected $app;
40
41		/**
42		* The instance of the cache.
43		*
44		* @var \Illuminate\Cache\CacheManager
45		*/
46		protected $cache;
47
48		/**
49		* Config.
50		*
51		* @var array
52		*/
53		protected $config;
54
55		/**
56		* The instance of the database.
57		*
58		* @var \Illuminate\Database\DatabaseManager
59		*/
60		protected $db;
61
62		/**
63		* Name of the cache.
64		*
65		* @var string
66		*/
67		protected $cache_name;
68
69		/**
70		* Texts collection.
71		*
72		* @var \Illuminate\Support\Collection
73		*/
74		protected $texts;
75
76		/**
77		* Missing texts.
78		*
79		* @var array
80		*/
81		protected $new_texts;
82
83		/**
84		* Create a new MultiLang instance.
85		*
86		* @param string $environment
87		* @param array $config
88		* @param \Illuminate\Cache\CacheManager $cache
89		* @param \Illuminate\Database\DatabaseManager $db
90		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-04-19 09:42 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
91		*/
92	5	public function __construct($environment, array $config, CacheContract $cache, DatabaseContract $db)
93		{
94	5	$this->environment = $environment;
95	5	$this->cache = $cache;
		0 ignored issues – show Documentation Bug introduced 2016-04-19 09:42 UTC by Report Bug Copy Issue Report `$cache` is of type `object<Illuminate\Contracts\Cache\Factory>`, but the property `$cache` was declared to be of type `object<Illuminate\Cache\CacheManager>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
96	5	$this->db = $db;
97
98	5	$this->setConfig($config);
99	5	}
100
101	5	public function setConfig(array $config)
102		{
103	5	$this->config = [
104		'enabled' => true,
105		'locales' => [
106		'en' => [
107		'name' => 'English',
108		'native_name' => 'English',
109		'default' => true,
110		],
111		],
112		'autosave' => true,
113		'cache' => true,
114		'cache_lifetime' => 1440,
115		'texts_table' => 'texts',
116		];
117
118	5	foreach ($config as $k => $v) {
119	1	$this->config[$k] = $v;
120		}
121	5	}
122
123	5	public function getConfig($key = null)
124		{
125	5	if ($key === null) {
126		return $this->config;
127		}
128
129	5	return isset($this->config[$key]) ? $this->config[$key] : null;
130		}
131
132		/**
133		* Set locale and load texts
134		*
135		* @param string $lang
136		* @param \Illuminate\Support\Collection\|array $text
		0 ignored issues – show Bug introduced 2016-04-19 10:03 UTC by Report Bug Copy Issue Report There is no parameter named `$text`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
137		* @return void
138		*/
139	5	public function setLocale($lang, $texts = null)
140		{
141	5	if (!$lang) {
142		throw new InvalidArgumentException('Locale is empty!');
143		}
144	5	$this->lang = $lang;
145
146	5	$this->setCacheName();
147
148	5	if (is_array($texts)) {
149		$texts = new Collection($texts);
150		}
151
152	5	$this->texts = $texts ? $texts : $this->loadTexts($this->getLocale());
153	5	}
154
155		/**
156		* Load texts
157		*
158		* @param string $lang
159		* @return \Illuminate\Support\Collection
160		*/
161	5	public function loadTexts($lang = null)
162		{
163	5	$cache = $this->getConfig('cache');
164
165	5	if (!$cache \|\| $this->cache === null \|\| $this->environment != 'production') {
166	5	$texts = $this->loadTextsFromDatabase($lang);
167	5	return $texts;
		0 ignored issues – show Bug Best Practice introduced 2016-04-19 09:42 UTC by Report Bug Copy Issue Report The return type of `return $texts;` (`array`) is incompatible with the return type documented by `Longman\LaravelMultiLang\MultiLang::loadTexts` of type `Illuminate\Support\Collection`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
168		}
169
170		if ($this->mustLoadFromCache()) {
171		$texts = $this->loadTextsFromCache();
172		} else {
173		$texts = $this->loadTextsFromDatabase($lang);
174		$this->storeTextsInCache($texts);
175		}
176
177		$texts = new Collection($texts);
178
179		return $texts;
180		}
181
182		/**
183		* Get translated text
184		*
185		* @param string $key
186		* @param string $default
		0 ignored issues – show Bug introduced 2016-04-19 10:03 UTC by Report Bug Copy Issue Report There is no parameter named `$default`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
187		* @return string
188		*/
189	2	public function get($key)
190		{
191
192	2	if (empty($key)) {
193		return null;
194		}
195
196	2	if (!$this->lang) {
197		return $key;
198		}
199
200	2	if (!$this->texts->has($key)) {
201	1	$this->queueToSave($key);
202	1	return $key;
203		}
204
205	1	$text = $this->texts->get($key);
206
207	1	return $text;
208		}
209
210		/**
211		* Get texts
212		*
213		* @param string $lang
214		* @return string
215		*/
216		public function getTexts($lang = null)
217		{
218
219		return $this->loadTexts($lang);
220		}
221
222		/**
223		* Set texts manually
224		*
225		* @param array $texts_array
226		* @return \Longman\LaravelMultiLang\MultiLang
227		*/
228	2	public function setTexts(array $texts_array)
229		{
230	2	$texts = [];
231	2	foreach ($texts_array as $key => $value) {
232	2	$texts[$key] = $value;
233		}
234
235	2	$this->texts = new Collection($texts);
236
237	2	return $this;
238		}
239
240		/**
241		* Queue missing texts
242		*
243		* @param string $key
244		* @return void
245		*/
246	1	protected function queueToSave($key)
247		{
248	1	$this->new_texts[$key] = $key;
249	1	}
250
251		/**
252		* Check if we must load texts from cache
253		*
254		* @return bool
255		*/
256		protected function mustLoadFromCache()
257		{
258		return $this->cache->has($this->cache_name);
259		}
260
261		protected function storeTextsInCache(array $texts)
262		{
263		$cache_lifetime = $this->getConfig('cache_lifetime', 1440);
		0 ignored issues – show Unused Code introduced 2016-04-19 10:03 UTC by Report Bug Copy Issue Report The call to `MultiLang::getConfig()` has too many arguments starting with `1440`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
264		$status = $this->cache->put($this->cache_name, $texts, $cache_lifetime);
265		return $status;
266		}
267
268	5	protected function loadTextsFromDatabase($lang)
269		{
270	5	$texts = $lang ? $this->db->table($this->getTableName())
271	5	->where('lang', $lang)
272	5	->get(['key', 'value', 'lang', 'scope']) : $this->db->table($this->getTableName())->get(['key', 'value', 'lang', 'scope']);
273
274	5	$array = [];
275	5	foreach ($texts as $row) {
276		$array[$row->key] = $row->value;
277		}
278	5	return $array;
279		}
280
281		protected function loadTextsFromCache()
282		{
283		$texts = $this->cache->get($this->cache_name);
		0 ignored issues – show Bug introduced 2016-04-19 09:42 UTC by Report Bug Copy Issue Report The method `get()` cannot be called from this context as it is declared protected in class `Illuminate\Cache\CacheManager`. This check looks for access to methods that are not accessible from the current context. If you need to make a method accessible to another context you can raise its visibility level in the defining class. Loading history...
284		return $texts;
285		}
286
287	5	protected function setCacheName()
288		{
289	5	$this->cache_name = 'texts.' . $this->lang;
290	5	}
291
292	1	public function getUrl($path)
293		{
294	1	$locale = $this->getLocale();
295	1	if ($locale) {
296	1	$path = $locale . '/' . $path;
297		}
298	1	return $path;
299		}
300
301		public function autoSaveIsAllowed()
302		{
303		if ($this->environment == 'local' && $this->getConfig('autosave') && $this->db !== null) {
304		return true;
305		}
306		return false;
307		}
308
309	5	public function getLocale()
310		{
311	5	return $this->lang;
312		}
313
314		public function saveTexts()
315		{
316		if (empty($this->new_texts)) {
317		return null;
318		}
319
320		$ins = [];
321		$placeholders = [];
322		$lang = $this->lang;
323		$i = 1;
324		foreach ($this->new_texts as $k => $v) {
325		$ins['key' . $i] = $k;
326		$ins['lang' . $i] = $lang;
327		$ins['value' . $i] = $v;
328
329		$placeholders[] = '(:key' . $i . ', :lang' . $i . ', :value' . $i . ')';
330		$i++;
331		}
332
333		$fields = ['key', 'lang', 'value'];
334
335		$placeholders = implode(', ', $placeholders);
336
337		$table = $this->getTableName(true);
338
339		$query = 'INSERT IGNORE
340		INTO `' . $table . '` (`' . implode('`, `', $fields) . '`)
341		VALUES ' . $placeholders;
342
343		$this->db->insert($query, $ins);
344		}
345
346	5	protected function getTableName($with_prefix = false)
347		{
348	5	$table = $this->getConfig('texts_table');
349	5	if ($with_prefix) {
350		$prefix = $this->db->getTablePrefix();
351		$table = $prefix . $table;
352		}
353	5	return $table;
354		}
355		}
356

akalongman / laravel-multilang

Push — master ( a92b73...59f0bc )

MultiLang B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

19 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like