UsesUuidAsPrimary::bootUsesUuidAsPrimary() - Code Metrics - Inspection of "Fix code style issues" - akalongman/laravel-lodash - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( efafaa...1ce8a3 )

by Avtandil

created 2020-11-29 01:34 UTC

UsesUuidAsPrimary::bootUsesUuidAsPrimary() A

↳ Parent: UsesUuidAsPrimary

Complexity

Conditions	5
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
cc	5
nc	1
nop	0
dl	0
loc	20
ccs	0
cts	14
cp	0
crap	30
rs	9.2888
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Longman\LaravelLodash\Eloquent;

use Ramsey\Uuid\Uuid;

use function preg_match;

/**
 * @mixin \Illuminate\Database\Eloquent\Model
 */
trait UsesUuidAsPrimary
{
    public function isUuidBinary(string $value): bool
    {
        return isset($value[0]) && ! preg_match('//u', $value);
    }

    public function getIncrementing(): bool
    {
        return false;
    }

    public function getKeyType(): string
    {
        return 'string';
    }

    protected static function bootUsesUuidAsPrimary(): void
    {
        static::creating(static function (UuidAsPrimaryContract $model): void {
            $keyName = $model->getKeyName();

            if (! empty($model->{$keyName})) {
                // Do some validation
                $model->isUuidBinary($model->{$keyName})
                    ? Uuid::fromBytes($model->{$keyName})
                    : Uuid::fromString($model->{$keyName});
            } elseif (! empty($model->attributes[$keyName])) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                // Do some validation
                $model->isUuidBinary($model->attributes[$keyName])
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    ? Uuid::fromBytes($model->attributes[$keyName])
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    : Uuid::fromString($model->attributes[$keyName]);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            } else {
                $model->{$keyName} = Uuid::uuid1()->getBytes();
            }
        });
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Longman\LaravelLodash\Eloquent;
6
7			use Ramsey\Uuid\Uuid;
8
9			use function preg_match;
10
11			/**
12			* @mixin \Illuminate\Database\Eloquent\Model
13			*/
14			trait UsesUuidAsPrimary
15			{
16			public function isUuidBinary(string $value): bool
17			{
18			return isset($value[0]) && ! preg_match('//u', $value);
19			}
20
21			public function getIncrementing(): bool
22			{
23			return false;
24			}
25
26			public function getKeyType(): string
27			{
28			return 'string';
29			}
30
31			protected static function bootUsesUuidAsPrimary(): void
32			{
33			static::creating(static function (UuidAsPrimaryContract $model): void {
34			$keyName = $model->getKeyName();
35
36			if (! empty($model->{$keyName})) {
37			// Do some validation
38			$model->isUuidBinary($model->{$keyName})
39			? Uuid::fromBytes($model->{$keyName})
40			: Uuid::fromString($model->{$keyName});
41			} elseif (! empty($model->attributes[$keyName])) {
			0 ignored issues – show Bug introduced 2020-11-29 01:39 UTC by Report Bug Copy Issue Report Accessing `attributes` on the interface `Longman\LaravelLodash\El...t\UuidAsPrimaryContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
42			// Do some validation
43			$model->isUuidBinary($model->attributes[$keyName])
			0 ignored issues – show Bug introduced 2020-11-29 01:39 UTC by Report Bug Copy Issue Report Accessing `attributes` on the interface `Longman\LaravelLodash\El...t\UuidAsPrimaryContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
44			? Uuid::fromBytes($model->attributes[$keyName])
			0 ignored issues – show Bug introduced 2020-11-29 01:39 UTC by Report Bug Copy Issue Report Accessing `attributes` on the interface `Longman\LaravelLodash\El...t\UuidAsPrimaryContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			: Uuid::fromString($model->attributes[$keyName]);
			0 ignored issues – show Bug introduced 2020-11-29 01:39 UTC by Report Bug Copy Issue Report Accessing `attributes` on the interface `Longman\LaravelLodash\El...t\UuidAsPrimaryContract` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
46			} else {
47			$model->{$keyName} = Uuid::uuid1()->getBytes();
48			}
49			});
50			}
51			}
52

akalongman / laravel-lodash

Push — master ( efafaa...1ce8a3 )

UsesUuidAsPrimary::bootUsesUuidAsPrimary() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like