Longman\LaravelLodash\Redis\Connectors\PhpRedisConnector

Complexity

Total Complexity

19

Size/Duplication

Total Lines	149
Duplicated Lines	5.37 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

78.43%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getSerializerFromConfig()	0	19	4
A	connectToCluster()	0	18	2
A	buildRedisArrayConnectionString()	0	4	1
B	createClient()	4	31	7
A	createRedisArrayInstance()	4	36	5

<?php
/*
 * This file is part of the Laravel Lodash package.
 *
 * (c) Avtandil Kikabidze aka LONGMAN <akalongman@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Longman\LaravelLodash\Redis\Connectors;

use Illuminate\Redis\Connections\PhpRedisClusterConnection;
use Illuminate\Redis\Connectors\PhpRedisConnector as BasePhpRedisConnector;
use Illuminate\Support\Arr;
use InvalidArgumentException;
use Redis;
use RedisArray;

class PhpRedisConnector extends BasePhpRedisConnector
{
    /**
     * Create the Redis client instance.
     *
     * @param  array $config
     * @return \Redis
     */
    protected function createClient(array $config)
    {
        return tap(new Redis(), function (Redis $client) use ($config) {
            $this->establishConnection($client, $config);

            if (! empty($config['password'])) {
                $client->auth((string) $config['password']);
            }

            if (! empty($config['database'])) {
                $client->select((int) $config['database']);
            }

            if (! empty($config['prefix'])) {
                $client->setOption(Redis::OPT_PREFIX, (string) $config['prefix']);
            }

            if (! empty($config['read_timeout'])) {
                $client->setOption(Redis::OPT_READ_TIMEOUT, (string) $config['read_timeout']);
            }

            if (! empty($config['serializer'])) {

This code seems to be duplicated across your project.

                $serializer = $this->getSerializerFromConfig($config['serializer']);
                $client->setOption(Redis::OPT_SERIALIZER, (string) $serializer);
            }

            if (! empty($config['scan'])) {
                $client->setOption(Redis::OPT_SCAN, Redis::SCAN_RETRY);
            }
        });
    }

    /**
     * Create a new clustered PhpRedis connection.
     *
     * @param  array $config
     * @param  array $clusterOptions
     * @param  array $options
     * @return \Illuminate\Redis\Connections\PhpRedisClusterConnection
     */
    public function connectToCluster(array $config, array $clusterOptions, array $options)
    {
        $options = array_merge($options, $clusterOptions, Arr::pull($config, 'options', []));

        // Use native Redis clustering
        if (Arr::get($options, 'cluster') === 'redis') {
            return new PhpRedisClusterConnection($this->createRedisClusterInstance(
                array_map([$this, 'buildClusterConnectionString'], $config),
                $options
            ));
        }

        // Use client-side sharding
        return new PhpRedisClusterConnection($this->createRedisArrayInstance(

$this->createRedisArrayInstance(array_map(array($this, 'buildRedisArrayConnectionString'), $config), $options) is of type object<RedisArray>, but the function expects a object<Redis>.

            array_map([$this, 'buildRedisArrayConnectionString'], $config),
            $options
        ));
    }

    /**
     * Build a PhpRedis hosts array.
     *
     * @param  array $server
     * @return string
     */
    protected function buildRedisArrayConnectionString(array $server)
    {
        return $server['host'] . ':' . $server['port'];
    }

    /**
     * Create a new redis array instance.
     *
     * @param  array $servers
     * @param  array $options
     * @return \RedisArray
     */
    protected function createRedisArrayInstance(array $servers, array $options)
    {
        $client = new RedisArray($servers, Arr::only($options, [
            'function',
            'previous',
            'retry_interval',
            'lazy_connect',
            'connect_timeout',
            'read_timeout',
            'algorithm',
            'consistent',
            'distributor',
        ]));

        if (! empty($options['password'])) {
            // @TODO: Remove after this will be implemented
            // https://github.com/phpredis/phpredis/issues/1508
            throw new InvalidArgumentException('RedisArray does not support authorization');
            //$client->auth((string) $options['password']);
        }

        if (! empty($options['database'])) {
            $client->select((int) $options['database']);
        }

        if (! empty($options['prefix'])) {
            $client->setOption(Redis::OPT_PREFIX, (string) $options['prefix']);
        }

        if (! empty($options['serializer'])) {

This code seems to be duplicated across your project.

            $serializer = $this->getSerializerFromConfig($options['serializer']);
            $client->setOption(Redis::OPT_SERIALIZER, (string) $serializer);
        }

        return $client;
    }

    /**
     * Resolve serializer
     *
     * @param  string $serializer
     * @return int
     * @throws \InvalidArgumentException
     */
    protected function getSerializerFromConfig(string $serializer): int
    {
        switch ($serializer) {
            default:
                $flag = Redis::SERIALIZER_NONE;
                break;
            case 'igbinary':
                if (! defined('Redis::SERIALIZER_IGBINARY')) {
                    throw new InvalidArgumentException('Error: phpredis was not compiled with igbinary support!');
                }
                $flag = Redis::SERIALIZER_IGBINARY;
                break;
            case 'php':
                $flag = Redis::SERIALIZER_PHP;
                break;
        }

        return $flag;
    }
}