SimpleBasicAuthTest::getEnvironmentSetUp() - Code Metrics - Inspection of "Add tests for new auth middleware" - akalongman/laravel-lodash - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36d657...227603 )

by Avtandil

created 2019-05-23 10:09 UTC

SimpleBasicAuthTest::getEnvironmentSetUp() A

↳ Parent: SimpleBasicAuthTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0

<?php
declare(strict_types=1);

namespace Tests\Unit\Middleware;

use Longman\LaravelLodash\Middlewares\SimpleBasicAuth;
use Tests\Unit\TestCase;

use function config;

class SimpleBasicAuthTest extends TestCase

{
    protected function getEnvironmentSetUp($app)
    {
        /** @var \Illuminate\Routing\Router $router */
        $router = $app['router'];

        $router->get('url1', static function () {
            return 'ok';
        })->middleware(SimpleBasicAuth::class);
    }

    /** @test */
    public function it_should_return_access_denied_on_empty_credentials()

    {
        config()->set('auth.simple', [
            'enabled'  => true,
            'user'     => 'testuser',
            'password' => 'testpass',
        ]);

        $response = $this->call('GET', 'url1', [], [], [], []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response->assertStatus(401);

    }

    /** @test */
    public function it_should_return_access_denied_on_wrong_credentials()

    {
        config()->set('auth.simple', [
            'enabled'  => true,
            'user'     => 'testuser',
            'password' => 'testpass',
        ]);

        $response = $this->call('GET', 'url1', [], [], [], ['PHP_AUTH_USER' => 'testuser', 'PHP_AUTH_PW' => 'wrongpass']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response->assertStatus(401);

    }

    /** @test */
    public function it_should_return_ok_on_disabled_auth()

    {
        config()->set('auth.simple', [
            'enabled'  => false,
            'user'     => 'testuser',
            'password' => 'testpass',
        ]);

        $response = $this->call('GET', 'url1', [], [], [], []);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response->assertStatus(200);

        $response->assertSeeText('ok');
    }

    /** @test */
    public function it_should_return_ok_with_credentials()

    {
        config()->set('auth.simple', [
            'enabled'  => true,
            'user'     => 'testuser',
            'password' => 'testpass',
        ]);
        $response = $this->call('GET', 'url1', [], [], [], ['PHP_AUTH_USER' => 'testuser', 'PHP_AUTH_PW' => 'testpass']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $response->assertStatus(200);

        $response->assertSeeText('ok');
    }

}


1		<?php
2		declare(strict_types=1);
3
4		namespace Tests\Unit\Middleware;
5
6		use Longman\LaravelLodash\Middlewares\SimpleBasicAuth;
7		use Tests\Unit\TestCase;
8
9		use function config;
10
11		class SimpleBasicAuthTest extends TestCase
		0 ignored issues – show Bug introduced 2019-05-22 15:49 UTC by Report Bug Copy Issue Report There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: artisan, be, call, seed Loading history...
12		{
13		protected function getEnvironmentSetUp($app)
14		{
15		/** @var \Illuminate\Routing\Router $router */
16		$router = $app['router'];
17
18		$router->get('url1', static function () {
19		return 'ok';
20		})->middleware(SimpleBasicAuth::class);
21		}
22
23		/** @test */
24	View Code Duplication	public function it_should_return_access_denied_on_empty_credentials()
		0 ignored issues – show Duplication introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		config()->set('auth.simple', [
27		'enabled' => true,
28		'user' => 'testuser',
29		'password' => 'testpass',
30		]);
31
32		$response = $this->call('GET', 'url1', [], [], [], []);
		0 ignored issues – show Documentation introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33		$response->assertStatus(401);
		0 ignored issues – show Bug introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report The method `assertStatus()` does not exist on `Illuminate\Http\Response`. Did you maybe mean `status()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
34		}
35
36		/** @test */
37	View Code Duplication	public function it_should_return_access_denied_on_wrong_credentials()
		0 ignored issues – show Duplication introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		config()->set('auth.simple', [
40		'enabled' => true,
41		'user' => 'testuser',
42		'password' => 'testpass',
43		]);
44
45		$response = $this->call('GET', 'url1', [], [], [], ['PHP_AUTH_USER' => 'testuser', 'PHP_AUTH_PW' => 'wrongpass']);
		0 ignored issues – show Documentation introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report `array('PHP_AUTH_USER' =>...UTH_PW' => 'wrongpass')` is of type `array<string,string,{"PH...PHP_AUTH_PW":"string"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
46		$response->assertStatus(401);
		0 ignored issues – show Bug introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report The method `assertStatus()` does not exist on `Illuminate\Http\Response`. Did you maybe mean `status()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
47		}
48
49		/** @test */
50	View Code Duplication	public function it_should_return_ok_on_disabled_auth()
		0 ignored issues – show Duplication introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		{
52		config()->set('auth.simple', [
53		'enabled' => false,
54		'user' => 'testuser',
55		'password' => 'testpass',
56		]);
57
58		$response = $this->call('GET', 'url1', [], [], [], []);
		0 ignored issues – show Documentation introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
59		$response->assertStatus(200);
		0 ignored issues – show Bug introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report The method `assertStatus()` does not exist on `Illuminate\Http\Response`. Did you maybe mean `status()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
60		$response->assertSeeText('ok');
61		}
62
63		/** @test */
64	View Code Duplication	public function it_should_return_ok_with_credentials()
		0 ignored issues – show Duplication introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		config()->set('auth.simple', [
67		'enabled' => true,
68		'user' => 'testuser',
69		'password' => 'testpass',
70		]);
71		$response = $this->call('GET', 'url1', [], [], [], ['PHP_AUTH_USER' => 'testuser', 'PHP_AUTH_PW' => 'testpass']);
		0 ignored issues – show Documentation introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report `array('PHP_AUTH_USER' =>...AUTH_PW' => 'testpass')` is of type `array<string,string,{"PH...PHP_AUTH_PW":"string"}>`, but the function expects a `string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72		$response->assertStatus(200);
		0 ignored issues – show Bug introduced 2019-05-23 10:19 UTC by Report Bug Copy Issue Report The method `assertStatus()` does not exist on `Illuminate\Http\Response`. Did you maybe mean `status()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
73		$response->assertSeeText('ok');
74		}
75
76		}
77

akalongman / laravel-lodash

Push — master ( 36d657...227603 )

SimpleBasicAuthTest::getEnvironmentSetUp() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like