Conditions | 1 |
Paths | 1 |
Total Lines | 95 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
52 | public function provideData(): array |
||
53 | { |
||
54 | return [ |
||
55 | [ |
||
56 | [ |
||
57 | 'field1' => 'required', |
||
58 | 'field2' => 'required', |
||
59 | ], |
||
60 | [ |
||
61 | 'field1' => 'Some Data 1', |
||
62 | 'field2' => 'Some Data 2', |
||
63 | 'field3' => 'Some Data 3', |
||
64 | ], |
||
65 | [ |
||
66 | 'field3', |
||
67 | ], |
||
68 | ], |
||
69 | [ |
||
70 | [ |
||
71 | 'field1' => 'required', |
||
72 | 'field2.subfield1' => 'required', |
||
73 | 'field2.subfield2' => 'required', |
||
74 | 'field2.subfield3' => 'required', |
||
75 | ], |
||
76 | [ |
||
77 | 'field1' => 'Some Data 1', |
||
78 | 'field2' => [ |
||
79 | 'subfield1' => 'Some Data 2-1', |
||
80 | 'subfield2' => 'Some Data 2-2', |
||
81 | 'subfield3' => 'Some Data 2-3', |
||
82 | 'subfield4' => 'Some Data 2-3', |
||
83 | ], |
||
84 | 'field3' => 'Some Data 3', |
||
85 | ], |
||
86 | [ |
||
87 | 'field2.subfield4', |
||
88 | 'field3', |
||
89 | ], |
||
90 | ], |
||
91 | [ |
||
92 | [ |
||
93 | 'field1' => 'required', |
||
94 | 'field2.*.subfield1' => 'required', |
||
95 | 'field2.*.subfield2' => 'required', |
||
96 | 'field2.*.subfield3' => 'required', |
||
97 | 'field3' => 'required', |
||
98 | 'field4' => 'required', |
||
99 | ], |
||
100 | [ |
||
101 | 'field1' => 'Some Data 1', |
||
102 | 'field2' => [ |
||
103 | [ |
||
104 | 'subfield1' => 'Some Data 2-1', |
||
105 | 'subfield2' => 'Some Data 2-2', |
||
106 | ], |
||
107 | [ |
||
108 | 'subfield3' => 'Some Data 2-3', |
||
109 | 'subfield4' => 'Some Data 2-3', |
||
110 | ], |
||
111 | ], |
||
112 | 'field3' => 'Some Data 3', |
||
113 | 'field4' => 'Some Data 4', |
||
114 | 'field5' => 'Some Data 3', |
||
115 | ], |
||
116 | [ |
||
117 | 'field2.*.subfield4', |
||
118 | 'field5', |
||
119 | ], |
||
120 | ], |
||
121 | [ |
||
122 | [ |
||
123 | 'field1' => 'required', |
||
124 | 'field2' => 'required', |
||
125 | 'field2.*' => 'required', |
||
126 | ], |
||
127 | [ |
||
128 | 'field1' => 'Some Data 1', |
||
129 | 'field2' => [ |
||
130 | [ |
||
131 | 'subfield1' => 'Some Data 2-1', |
||
132 | 'subfield2' => 'Some Data 2-2', |
||
133 | ], |
||
134 | [ |
||
135 | 'subfield3' => 'Some Data 2-3', |
||
136 | 'subfield4' => 'Some Data 2-3', |
||
137 | ], |
||
138 | ], |
||
139 | 'field3' => 'Some Data 3', |
||
140 | ], |
||
141 | [ |
||
142 | 'field3', |
||
143 | ], |
||
144 | ], |
||
145 | ]; |
||
146 | } |
||
147 | |||
164 |