RedisTest::createConnection() - Code Metrics - akalongman/laravel-lodash - Measure and Improve Code Quality continuously with Scrutinizer

RedisTest::createConnection() A
last analyzed 2021-03-16 10:54 UTC

↳ Parent: RedisTest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Tests\Unit;

use Longman\LaravelLodash\Redis\RedisManager;
use Redis;
use RedisArray;

use function getenv;
use function version_compare;

class RedisTest extends TestCase

{
    /** @test */
    public function it_should_set_custom_serializer()
    {
        $redis = $this->createConnection('phpredis', [
            'cluster' => false,
            'default' => [
                'host'         => getenv('REDIS_HOST') ?: '127.0.0.1',
                'port'         => getenv('REDIS_PORT') ?: 6379,
                'database'     => 5,
                'options'      => ['prefix' => 'lodash:'],
                'timeout'      => 0.5,
                'read_timeout' => 1.5,
                'serializer'   => 'igbinary',
            ],
        ]);
        /** @var \Redis $client */
        $client = $redis->connection()->client();

        $data = ['name' => 'Georgia'];
        $redis->set('country', $data, null, 60);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->assertInstanceOf(Redis::class, $client);
        $this->assertEquals($client->getOption(Redis::OPT_SERIALIZER), Redis::SERIALIZER_IGBINARY);
        $this->assertEquals($redis->get('country'), $data);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /** @test */
    public function it_should_set_custom_serializer_for_cluster()
    {
        $redis = $this->createConnection('phpredis', [
            'clusters' => [
                'options' => [
                    'lazy_connect'    => true,
                    'connect_timeout' => 1,
                    'read_timeout'    => 3,
                    'password'        => getenv('REDIS_PASSWORD') ?: null,
                    'database'        => 5,
                    'prefix'          => 'lodash:',
                    'serializer'      => 'igbinary',
                ],

                'default' => [
                    [
                        'host' => getenv('REDIS_HOST') ?: '127.0.0.1',
                        'port' => getenv('REDIS_PORT') ?: 6379,
                    ],
                ],
            ],
        ]);
        /** @var \RedisArray $client */
        $client = $redis->connection()->client();

        $data = ['name' => 'Georgia'];
        $redis->set('country2', $data, null, 60);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        $this->assertInstanceOf(RedisArray::class, $client);
        $this->assertEquals($redis->get('country2'), $data);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        foreach ($client->getOption(Redis::OPT_SERIALIZER) as $serializer) {
            $this->assertEquals($serializer, Redis::SERIALIZER_IGBINARY);
        }
    }

    private function createConnection(string $driver, array $config = []): RedisManager
    {
        if (version_compare($this->app->version(), '5.7', '<')) {
            $redis = new RedisManager($driver, $config);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $redis = new RedisManager($this->app, $driver, $config);
        }

        return $redis;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Tests\Unit;
6
7			use Longman\LaravelLodash\Redis\RedisManager;
8			use Redis;
9			use RedisArray;
10
11			use function getenv;
12			use function version_compare;
13
14			class RedisTest extends TestCase
			0 ignored issues – show Bug introduced 2020-03-18 14:06 UTC by Report Bug Copy Issue Report There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: artisan, be, call, seed Loading history...
15			{
16			/** @test */
17			public function it_should_set_custom_serializer()
18			{
19			$redis = $this->createConnection('phpredis', [
20			'cluster' => false,
21			'default' => [
22			'host' => getenv('REDIS_HOST') ?: '127.0.0.1',
23			'port' => getenv('REDIS_PORT') ?: 6379,
24			'database' => 5,
25			'options' => ['prefix' => 'lodash:'],
26			'timeout' => 0.5,
27			'read_timeout' => 1.5,
28			'serializer' => 'igbinary',
29			],
30			]);
31			/** @var \Redis $client */
32			$client = $redis->connection()->client();
33
34			$data = ['name' => 'Georgia'];
35			$redis->set('country', $data, null, 60);
			0 ignored issues – show Documentation Bug introduced 2019-02-15 12:54 UTC by Report Bug Copy Issue Report The method `set` does not exist on `object<Longman\LaravelLodash\Redis\RedisManager>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
36
37			$this->assertInstanceOf(Redis::class, $client);
38			$this->assertEquals($client->getOption(Redis::OPT_SERIALIZER), Redis::SERIALIZER_IGBINARY);
39			$this->assertEquals($redis->get('country'), $data);
			0 ignored issues – show Documentation Bug introduced 2019-02-15 12:54 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<Longman\LaravelLodash\Redis\RedisManager>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
40			}
41
42			/** @test */
43			public function it_should_set_custom_serializer_for_cluster()
44			{
45			$redis = $this->createConnection('phpredis', [
46			'clusters' => [
47			'options' => [
48			'lazy_connect' => true,
49			'connect_timeout' => 1,
50			'read_timeout' => 3,
51			'password' => getenv('REDIS_PASSWORD') ?: null,
52			'database' => 5,
53			'prefix' => 'lodash:',
54			'serializer' => 'igbinary',
55			],
56
57			'default' => [
58			[
59			'host' => getenv('REDIS_HOST') ?: '127.0.0.1',
60			'port' => getenv('REDIS_PORT') ?: 6379,
61			],
62			],
63			],
64			]);
65			/** @var \RedisArray $client */
66			$client = $redis->connection()->client();
67
68			$data = ['name' => 'Georgia'];
69			$redis->set('country2', $data, null, 60);
			0 ignored issues – show Documentation Bug introduced 2019-02-15 17:53 UTC by Report Bug Copy Issue Report The method `set` does not exist on `object<Longman\LaravelLodash\Redis\RedisManager>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
70
71			$this->assertInstanceOf(RedisArray::class, $client);
72			$this->assertEquals($redis->get('country2'), $data);
			0 ignored issues – show Documentation Bug introduced 2019-02-15 17:53 UTC by Report Bug Copy Issue Report The method `get` does not exist on `object<Longman\LaravelLodash\Redis\RedisManager>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
73			foreach ($client->getOption(Redis::OPT_SERIALIZER) as $serializer) {
74			$this->assertEquals($serializer, Redis::SERIALIZER_IGBINARY);
75			}
76			}
77
78			private function createConnection(string $driver, array $config = []): RedisManager
79			{
80			if (version_compare($this->app->version(), '5.7', '<')) {
81			$redis = new RedisManager($driver, $config);
			0 ignored issues – show Bug introduced 2019-02-15 16:25 UTC by Report Bug Copy Issue Report The call to `RedisManager::__construct()` misses a required argument `$config`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2019-03-22 12:08 UTC by Report Bug Copy Issue Report `$driver` is of type `string`, but the function expects a `object<Illuminate\Contra...Foundation\Application>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-02-15 17:53 UTC by Report Bug Copy Issue Report `$config` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
82			} else {
83			$redis = new RedisManager($this->app, $driver, $config);
84			}
85
86			return $redis;
87			}
88			}
89

akalongman / laravel-lodash

RedisTest::createConnection() A last analyzed 2021-03-16 10:54 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RedisTest::createConnection() A
last analyzed 2021-03-16 10:54 UTC