Longman\LaravelDummyUser\DummyUserServiceProvider

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	59.46 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	boot()	22	33	5

<?php

namespace Longman\LaravelDummyUser;

use Illuminate\Auth\AuthManager;
use Illuminate\Auth\Events\Login;
use Illuminate\Auth\Events\Logout;
use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Contracts\Cache\Repository as CacheContract;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Support\ServiceProvider;

class DummyUserServiceProvider extends ServiceProvider
{
    public function boot(AuthManager $auth)
    {
        $auth->provider('dummy', function (Application $app, array $config) {
            /** @var \Illuminate\Contracts\Cache\Repository $cache */
            $cache = $app->make(CacheContract::class);

            $this->app['events']->listen(Login::class, function ($event) use ($config, $cache) {

This code seems to be duplicated across your project.

                if (! $event->user instanceof Authenticatable) {
                    return false;
                }

                $id = $event->user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if (! $id) {
                    return false;
                }
                $cache->put('users.' . $id, $event->user, $config['lifetime']);
            });

            $this->app['events']->listen(Logout::class, function ($event) use ($config, $cache) {

This code seems to be duplicated across your project.

                if (! $event->user instanceof Authenticatable) {
                    return false;
                }

                $id = $event->user->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                if (! $id) {
                    return false;
                }
                $cache->forget('users.' . $id);
            });

            return new DummyUserProvider($cache, $config);
        });
    }

}