akDeveloper / patterns-eaa-in-php

src/WebPresentation/FrontController/FrontCommand.php

<?php

declare(strict_types = 1);

namespace WebPresentation\FrontController;

use WebPresentation\Forward;
use Psr\Http\Message\ResponseInterface as Response;
use Psr\Http\Message\ServerRequestInterface as ServerRequest;

abstract class FrontCommand
{
    protected ?ServerRequest $request = null;

    protected ?Response $response = null;

    abstract public function process(): void;

    public function init(ServerRequest $request, Response $response)
    {
        $this->request = $request;
        $this->response = $response;
    }

    public function getResponse(): Response
    {
        return $this->response;

The expression return $this->response could return the type null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }

    protected function forward(string $target): void
    {
        $f = new Forward($this->request, $this->response);

It seems like $this->response can also be of type null; however, parameter $response of WebPresentation\Forward::__construct() does only seem to accept Psr\Http\Message\ResponseInterface, maybe add an additional type check?

It seems like $this->request can also be of type null; however, parameter $request of WebPresentation\Forward::__construct() does only seem to accept Psr\Http\Message\ServerRequestInterface, maybe add an additional type check?

        $this->response = $f->sendResponse($target);
    }
}