akDeveloper / patterns-eaa-in-php

src/WebPresentation/ApplicationController/FrontServlet.php

<?php

declare(strict_types = 1);

namespace WebPresentation\ApplicationController;

use WebPresentation\Forward;
use Psr\Http\Message\ResponseInterface as ServerResponse;
use Psr\Http\Message\ServerRequestInterface as ServerRequest;

class FrontServlet
{
    private ?ServerResponse $response = null;

    public function service(ServerRequest $request, ServerResponse $response): void
    {
        $params = $this->getParameterMap($request);
        $appController = $this->getApplicationController($request);
        $commandString = $params["command"] ?? '';
        $domainCommand = $appController->getDomainCommand($commandString, $params);
        $domainCommand->run($params);

        $viewPage = sprintf(
            "/%s.php",
            $appController->getView($commandString, $params)
        );

        $this->response = $this->forward($viewPage, $request, $response);
    }

    public function getResponse(): ServerResponse
    {
        return $this->response;

The expression return $this->response could return the type null which is incompatible with the type-hinted return Psr\Http\Message\ResponseInterface. Consider adding an additional type-check to rule them out.

    }

    protected function getParameterMap(ServerRequest $request): array
    {
        return array_merge(
            $request->getQueryParams() ?? [],
            $request->getParsedBody() ?? []

It seems like $request->getParsedBody() ?? array() can also be of type object; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

        );
    }

    protected function forward(
        string $viewPage,
        ServerRequest $request,
        ServerResponse $response
    ): ServerResponse {
        $f = new Forward($request, $response);

        return $f->sendResponse($viewPage);
    }

    private function getApplicationController(ServerRequest $request): ApplicationController
    {
        $target = trim($request->getUri()->getPath(), "/");

        $class = sprintf("%s\%sApplicationController", __NAMESPACE__, $target);

        return new $class();
    }
}